Re: Review Request: Improve lyrics applet

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100013/#review319 --- I'm able to resolve the text colour problem. For the labels that

Re: Review Request: Up/down key track selection while using progressive search widget

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100124/ --- (Updated 2010-11-06 22:23:18.455509) Review request for Amarok. Changes

Re: Review Request: Album Artist for QueryMaker

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100135/ --- (Updated 2010-11-06 22:10:42.870991) Review request for Amarok. Changes

Re: Review Request: Album Artist for QueryMaker

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100135/ --- (Updated 2010-11-06 19:58:32.908609) Review request for Amarok. Summary

Fwd: about collection scanner

As per request, I'm forwarding this to the list. Thanks Messaggio originale Oggetto:about collection scanner Data: Sat, 06 Nov 2010 12:45:32 +0100 Mittente: Mikko C. A: Ralf Engels Hi, I have a problem. I have amarok updated from git master. I added 3

Re: Review Request: Improve lyrics applet

> On 2010-11-05 21:50:28, Leo Franchi wrote: > > src/context/Applet.cpp, line 417 > > > > > > You can use Plasma::MessageButtons instead of QFlags<> here for > > readability :) Good point - done :) > On 2010-11-05

Re: Review Request: Improve lyrics applet

> On 2010-11-05 07:41:17, Rick W. Chen wrote: > > ChangeLog, lines 8-9 > > > > > > Please don't put changelog diffs in the review request. the patch will > > almost certainly fail to apply if ChangeLog has been changed

Re: Review Request: Improve lyrics applet

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100013/ --- (Updated 2010-11-06 17:18:27.760440) Review request for Amarok. Changes

Re: Review Request: Match space-separated search terms individually

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100128/#review314 --- Ship it! I think he meant const ref, so const QString&. But I'll

Re: Review Request: Coverbling applet (playground) build fix

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100133/#review313 --- Ship it! Looks good to me too, after the minor whitespace fix!

Re: New collection scanner

Hi Ralf, An update. After your various fixes, scanning is much faster now (yay QSharedMemory!) Now it gets stuck at 24%, here is the debug output: http://pastebin.com/HPadHHtf leo On Wednesday, November 03, 2010 06:09:35 PM Ralf Engels wrote: > Hi all, > since this morning (very early) the ne

Re: cmake check for mysql

On 11/05/2010 10:11 AM, Edward Hades wrote: > Can you please show the cmake output (when it succeedes without having > mysql)? Also, please check if you have the mysql_config binary. > I have the mysql_config binary. And now I have installed all necessary devel pkgs. I would need to uninstall th

Re: Review Request: Album Artist for QueryMaker

> On 2010-11-06 14:28:07, Stefan Derkits wrote: > > src/browsers/CollectionTreeItemModelBase.cpp, line 402 > > > > > > The plural of index is either indices or indexes ... but not indixes :) > > Sergey Ivanov wrote:

Re: Review Request: Album Artist for QueryMaker

> On 2010-11-06 14:28:07, Stefan Derkits wrote: > > src/browsers/CollectionTreeItemModelBase.cpp, line 402 > > > > > > The plural of index is either indices or indexes ... but not indixes :) Ah, my English terrible,

Re: Review Request: Album Artist for QueryMaker

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100135/ --- (Updated 2010-11-06 14:41:00.191557) Review request for Amarok. Changes

Re: Review Request: Album Artist for QueryMaker

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100135/#review310 --- src/browsers/CollectionTreeItemModelBase.cpp

Review Request: Album Artist for QueryMaker

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100135/ --- Review request for Amarok. Summary --- Add new QueryType - AlbumArtis

Re: [Amarok] b18a028: Use shared memory for collection scanner to rememb

On 11/06/2010 05:38 AM, Maximilian Kossick wrote: > One of the reasons for collection scanner as a separate executable was > to prevent a crash in collectionscanner from bringing down Amarok as > well. As both processes only communicated with each other via files or > stdout/stdin, this was relativ

Re: [Amarok] b18a028: Use shared memory for collection scanner to rememb

One of the reasons for collection scanner as a separate executable was to prevent a crash in collectionscanner from bringing down Amarok as well. As both processes only communicated with each other via files or stdout/stdin, this was relatively safe. Is it ensured that a corrpution of the shared me