----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100124/ -----------------------------------------------------------
(Updated 2010-11-06 22:23:18.455509) Review request for Amarok. Changes ------- Moved common code from upOneTrack() and downOneTrack() to a private slot moveTrackSelection(offset) as per Kevin's suggestion. Summary ------- This lets the user use up/down keys while keeping focus in the progressive search widget. The use case for this is particularly when "Show only matches" is checked: type in the first few letters of the track you're interested in, use arrow keys to select from a much smaller list, then press enter to play it and go back to a full playlist. Previously, pressing down would give focus to the playlist which meant that pressing enter on a track would not clear the search box and the refined playlist would remain. IMHO it would be better to make this "temporary search-based playlist" behaviour explicit either by clicking focus to the playlist or by pressing TAB (this last part is something else I would like to add). Overall I think this is a smoother and more consistent workflow for people like me who don't like to take their hands off the keyboard. Also, my Qt experience is almost nil so any comments or suggestions regarding code style and approach would be much appreciated. Cheers! Diffs (updated) ----- src/playlist/PlaylistDock.cpp b0b725a src/playlist/ProgressiveSearchWidget.h 310b37b src/playlist/ProgressiveSearchWidget.cpp 4e7bc84 src/playlist/view/listview/PrettyListView.h ffbd723 src/playlist/view/listview/PrettyListView.cpp 527dc84 src/widgets/LineEdit.h dde6d5d src/widgets/LineEdit.cpp a76deaf Diff: http://git.reviewboard.kde.org/r/100124/diff Testing ------- The use of up & down has been tested to make sure that selection stays within bounds. A good test of the index-setting which brought out some odd behaviour early on: - Turn on "Show only matches" - Use search and start a song playing by using up/down and enter - Search again and type in a string which doesn't match the song playing - Backspace it and type in a search which includes the current playing song plus others above it - Make sure the top song is selected by default and pressing enter plays that one, not the already playing track - Make sure that pressing down/up starts with the selection moving from the top, not the already playing track And the same again, except don't ever let the currently playing song be filtered out. Thanks, Thomas
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
