----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100135/#review310 -----------------------------------------------------------
src/browsers/CollectionTreeItemModelBase.cpp <http://git.reviewboard.kde.org/r/100135/#comment262> The plural of index is either indices or indexes ... but not indixes :) - Stefan On 2010-11-06 14:09:57, Sergey Ivanov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100135/ > ----------------------------------------------------------- > > (Updated 2010-11-06 14:09:57) > > > Review request for Amarok. > > > Summary > ------- > > Add new QueryType - AlbumArtist. Add new "level" to collection browser. > It works well with SqlCollection, still need to make It work for all services > which support such queries. > > > Diffs > ----- > > src/amarokurls/NavigationUrlGenerator.cpp 5c48e73 > src/amarokurls/NavigationUrlRunner.cpp 2d6384b > src/browsers/CollectionTreeItemModelBase.h 23a189f > src/browsers/CollectionTreeItemModelBase.cpp 280245a > src/browsers/collectionbrowser/CollectionWidget.cpp f493a5e > src/core-impl/collections/db/sql/SqlQueryMaker.cpp ca105e8 > src/core-impl/collections/db/sql/SqlQueryMakerInternal.cpp 9002acf > src/core-impl/collections/proxycollection/ProxyCollectionQueryMaker.cpp > c17c3fd > src/core-impl/collections/support/MemoryQueryMaker.cpp 81bf9b6 > src/core-impl/collections/support/MemoryQueryMakerInternal.cpp eeffd77 > src/core-impl/collections/support/XmlQueryWriter.cpp 3c9cf41 > src/core/collections/QueryMaker.h 9c15659 > src/services/ServiceSqlQueryMaker.cpp 197f2cf > src/services/ampache/AmpacheServiceQueryMaker.cpp 7dee8c8 > src/services/scriptable/ScriptableServiceQueryMaker.cpp 76faca2 > > Diff: http://git.reviewboard.kde.org/r/100135/diff > > > Testing > ------- > > Tested with SqlCollection. Seems works for me. > > > Thanks, > > Sergey > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
