Re: cmake check for mysql

The missing packages where mysql(-devel) and mysql-embedded(-devel). I use Fedora 14 (since a few hours). -panzi On 11/05/2010 01:11 AM, James Duncan wrote: > Such a check does exist. However, you may be missing libwrap (called > libwrap0-dev in the Ubuntu > repositories, and tcpd-dev

Re: cmake check for mysql

Such a check does exist. However, you may be missing libwrap (called libwrap0-dev in the Ubuntu repositories, and tcpd-devel in OpenSuSE). It is a dependency of MySQL, but isn't marked as such in the repositories, and so is often left out. James On Thu, Nov 4, 2010 at 5:02 PM, Mathias Panzenböc

Re: Review Request: Use MetaQueryWidget in the advanced playlist generator.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100070/#review294 --- I can't get the patch to apply cleanly. What revision is this ag

cmake check for mysql

Apparently there is no cmake check for mysql(-devel) in the amarok build system, because for me cmake finished ok but then there was a compile error on a missing mysql.h. -panzi ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kd

Re: Review Request: Helper Methods for FileType Enum in new Class FileTypeSupport, get Type in TagDialog from Database instead of Extension, some Code Changes as Example of the Advantage of the Helpe

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100088/ --- (Updated 2010-11-04 21:24:56.775220) Review request for Amarok. Changes

Review Request: Fix crash in Albums context applet

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100134/ --- Review request for Amarok. Summary --- This patch fixes a crash in th

Re: Review Request: Up/down key track selection while using progressive search widget

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100124/#review293 --- Ship it! Rest looks fine. I'd say ship it! src/playlist/view/l

Re: Review Request: Coverbling applet (playground) build fix

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100133/#review292 --- playground/src/context/applets/coverbling/CoverBlingApplet.cpp <

Review Request: Coverbling applet (playground) build fix

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100133/ --- Review request for Amarok. Summary --- This fixes CoverBling applet b

Re: Review Request: Improve lyrics applet

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100013/ --- (Updated 2010-11-04 18:37:00.435783) Review request for Amarok. Changes

Review Request: Improve lyrics applet

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100013/ --- Review request for Amarok. Summary --- This fixes multiple issues wit

Re: Review Request: Permit the use of iPod touch 3G (and upper?) with Amarok

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100132/ --- (Updated 2010-11-04 17:50:10.208143) Review request for Amarok. Summary

Re: Review Request: Permit the use of iPod touch 3G (and upper?) with Amarok

> On 2010-11-04 16:18:16, Ian Monroe wrote: > > src/MediaDeviceCache.cpp, line 218 > > > > > > Maybe a comment here explaining why iPods shouldn't use the following > > codepath. > > Ian Monroe wrote: > Oh and i

Re: Review Request: Permit the use of iPod touch 3G (and upper?) with Amarok

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100132/#review291 --- src/MediaDeviceCache.cpp

Re: Review Request: Permit the use of iPod touch 3G (and upper?) with Amarok

> On 2010-11-04 16:18:16, Ian Monroe wrote: > > src/MediaDeviceCache.cpp, line 218 > > > > > > Maybe a comment here explaining why iPods shouldn't use the following > > codepath. Oh and it should be QLatin1Literal("

Re: Review Request: Permit the use of iPod touch 3G (and upper?) with Amarok

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100132/#review287 --- src/MediaDeviceCache.cpp

Re: Review Request: Permit the use of iPod touch 3G (and upper?) with Amarok

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100132/#review286 --- Ship it! This patch looks OK but I have no way to test. The med

Review Request: Permit the use of iPod touch 3G (and upper?) with Amarok

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100132/ --- Review request for Amarok. Summary --- Permit the use of ipod touch 3

Re: Review Request: MusicBrainz Tagger "restyling"

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100127/ --- (Updated 2010-11-04 14:43:40.070248) Review request for Amarok. Changes

Re: Review Request: Use MetaQueryWidget in the advanced playlist generator.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100070/#review285 --- With visual inspection, r3 looks fine. I will try to get around

Re: Review Request: MusicBrainz Tagger "restyling"

> On 2010-11-04 11:28:25, Mark Kretschmann wrote: > > Looks great now. Many thanks for the improvements! > > > > I think after the many fixes you made, this could go into Mainline. Best > > way to get more eyeballs on it. It still has one bug, It crash amarok some times (rarely, but happens).

Re: Review Request: MusicBrainz Tagger "restyling"

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100127/#review283 --- Ship it! Looks great now. Many thanks for the improvements! I t

Re: Review Request: MusicBrainz Tagger "restyling"

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100127/ --- (Updated 2010-11-04 11:20:27.683987) Review request for Amarok. Changes