----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100134/ -----------------------------------------------------------
Review request for Amarok. Summary ------- This patch fixes a crash in the Albums context applet. If a recently added album (one currently displayed in the Albums applet) is removed from the collection, AlbumProxyModel::lessThan will crash asking for the last element of an empty QVector. In addition, the patch improves the efficiency of the comparator. Diffs ----- src/context/applets/albums/AlbumsModel.cpp 577499b src/context/applets/albums/AlbumsModel.h b899ddb Diff: http://git.reviewboard.kde.org/r/100134/diff Testing ------- Tested adding new albums and removing currently existing albums (both those that were currently shown in the applet and ones not shown). No crashes yet, and ordering has not been affected. Thanks, James
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
