Re: [PATCH bpf-next 1/2] trace: bpf: Allow bpf to attach to bare tracepoints
Hi Qais, Thank you for the patch! Yet something to improve: [auto build test ERROR on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Qais-Yousef/Allow-attaching-to-bare-tracepoints/20210112-022350 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master config: x86_64-rhel-7.6-kselftests (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/8f02e2ee2ac949ce6b4fd3cfd323f2e513a2cac6 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Qais-Yousef/Allow-attaching-to-bare-tracepoints/20210112-022350 git checkout 8f02e2ee2ac949ce6b4fd3cfd323f2e513a2cac6 # save the attached .config to linux build tree make W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): In file included from include/trace/define_trace.h:104, from include/trace/events/sched.h:740, from kernel/sched/core.c:10: >> include/trace/bpf_probe.h:59:1: error: expected identifier or '(' before >> 'static' 59 | static notrace void \ | ^~ include/trace/bpf_probe.h:119:3: note: in expansion of macro '__BPF_DECLARE_TRACE' 119 | (__BPF_DECLARE_TRACE(call, PARAMS(proto), PARAMS(args)) \ | ^~~ include/trace/events/sched.h:693:1: note: in expansion of macro 'DECLARE_TRACE' 693 | DECLARE_TRACE(pelt_cfs_tp, | ^ >> include/trace/bpf_probe.h:59:1: error: expected identifier or '(' before >> 'static' 59 | static notrace void \ | ^~ include/trace/bpf_probe.h:119:3: note: in expansion of macro '__BPF_DECLARE_TRACE' 119 | (__BPF_DECLARE_TRACE(call, PARAMS(proto), PARAMS(args)) \ | ^~~ include/trace/events/sched.h:697:1: note: in expansion of macro 'DECLARE_TRACE' 697 | DECLARE_TRACE(pelt_rt_tp, | ^ >> include/trace/bpf_probe.h:59:1: error: expected identifier or '(' before >> 'static' 59 | static notrace void \ | ^~ include/trace/bpf_probe.h:119:3: note: in expansion of macro '__BPF_DECLARE_TRACE' 119 | (__BPF_DECLARE_TRACE(call, PARAMS(proto), PARAMS(args)) \ | ^~~ include/trace/events/sched.h:701:1: note: in expansion of macro 'DECLARE_TRACE' 701 | DECLARE_TRACE(pelt_dl_tp, | ^ >> include/trace/bpf_probe.h:59:1: error: expected identifier or '(' before >> 'static' 59 | static notrace void \ | ^~ include/trace/bpf_probe.h:119:3: note: in expansion of macro '__BPF_DECLARE_TRACE' 119 | (__BPF_DECLARE_TRACE(call, PARAMS(proto), PARAMS(args)) \ | ^~~ include/trace/events/sched.h:705:1: note: in expansion of macro 'DECLARE_TRACE' 705 | DECLARE_TRACE(pelt_thermal_tp, | ^ >> include/trace/bpf_probe.h:59:1: error: expected identifier or '(' before >> 'static' 59 | static notrace void \ | ^~ include/trace/bpf_probe.h:119:3: note: in expansion of macro '__BPF_DECLARE_TRACE' 119 | (__BPF_DECLARE_TRACE(call, PARAMS(proto), PARAMS(args)) \ | ^~~ include/trace/events/sched.h:709:1: note: in expansion of macro 'DECLARE_TRACE' 709 | DECLARE_TRACE(pelt_irq_tp, | ^ >> include/trace/bpf_probe.h:59:1: error: expected identifier or '(' before >> 'static' 59 | static notrace void \ | ^~ include/trace/bpf_probe.h:119:3: note: in expansion of macro '__BPF_DECLARE_TRACE' 119 | (__BPF_DECLARE_TRACE(call, PARAMS(proto), PARAMS(args)) \ | ^~~ include/trace/events/sched.h:713:1: note: in expansion of macro 'DECLARE_TRACE' 713 | DECLARE_TRACE(pelt_se_tp, | ^ >> include/trace/bpf_probe.h:59:1: error: expected identifier or '(' before >> 'static' 59 | static notrace void \ | ^~ include/trace/bpf_probe.h:119:3: note: in expansion of macro '__BPF_DECLARE_TRACE' 119 | (__BPF_DECLARE_TRACE(call, PARAMS(proto), PARAMS(args)) \ | ^~~ include/trace/events/sched.h:717:1: note: in expansion of macro 'DECLARE_TRACE' 717 | DECLARE_TRACE(sched_cpu_capacity_tp, | ^ >> include/trace/bpf_probe.h:59:1: error: expected identifier or
Re: [PATCH bpf-next 1/2] trace: bpf: Allow bpf to attach to bare tracepoints
Hi Qais, Thank you for the patch! Yet something to improve: [auto build test ERROR on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Qais-Yousef/Allow-attaching-to-bare-tracepoints/20210112-022350 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master config: x86_64-rhel-8.3 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/8f02e2ee2ac949ce6b4fd3cfd323f2e513a2cac6 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Qais-Yousef/Allow-attaching-to-bare-tracepoints/20210112-022350 git checkout 8f02e2ee2ac949ce6b4fd3cfd323f2e513a2cac6 # save the attached .config to linux build tree make W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): In file included from include/trace/define_trace.h:104, from include/trace/events/sched.h:740, from kernel/sched/core.c:10: >> include/trace/bpf_probe.h:59:1: error: expected identifier or '(' before >> 'static' 59 | static notrace void \ | ^~ include/trace/bpf_probe.h:119:3: note: in expansion of macro '__BPF_DECLARE_TRACE' 119 | (__BPF_DECLARE_TRACE(call, PARAMS(proto), PARAMS(args)) \ | ^~~ include/trace/events/sched.h:693:1: note: in expansion of macro 'DECLARE_TRACE' 693 | DECLARE_TRACE(pelt_cfs_tp, | ^ >> include/trace/bpf_probe.h:59:1: error: expected identifier or '(' before >> 'static' 59 | static notrace void \ | ^~ include/trace/bpf_probe.h:119:3: note: in expansion of macro '__BPF_DECLARE_TRACE' 119 | (__BPF_DECLARE_TRACE(call, PARAMS(proto), PARAMS(args)) \ | ^~~ include/trace/events/sched.h:697:1: note: in expansion of macro 'DECLARE_TRACE' 697 | DECLARE_TRACE(pelt_rt_tp, | ^ >> include/trace/bpf_probe.h:59:1: error: expected identifier or '(' before >> 'static' 59 | static notrace void \ | ^~ include/trace/bpf_probe.h:119:3: note: in expansion of macro '__BPF_DECLARE_TRACE' 119 | (__BPF_DECLARE_TRACE(call, PARAMS(proto), PARAMS(args)) \ | ^~~ include/trace/events/sched.h:701:1: note: in expansion of macro 'DECLARE_TRACE' 701 | DECLARE_TRACE(pelt_dl_tp, | ^ >> include/trace/bpf_probe.h:59:1: error: expected identifier or '(' before >> 'static' 59 | static notrace void \ | ^~ include/trace/bpf_probe.h:119:3: note: in expansion of macro '__BPF_DECLARE_TRACE' 119 | (__BPF_DECLARE_TRACE(call, PARAMS(proto), PARAMS(args)) \ | ^~~ include/trace/events/sched.h:705:1: note: in expansion of macro 'DECLARE_TRACE' 705 | DECLARE_TRACE(pelt_thermal_tp, | ^ >> include/trace/bpf_probe.h:59:1: error: expected identifier or '(' before >> 'static' 59 | static notrace void \ | ^~ include/trace/bpf_probe.h:119:3: note: in expansion of macro '__BPF_DECLARE_TRACE' 119 | (__BPF_DECLARE_TRACE(call, PARAMS(proto), PARAMS(args)) \ | ^~~ include/trace/events/sched.h:709:1: note: in expansion of macro 'DECLARE_TRACE' 709 | DECLARE_TRACE(pelt_irq_tp, | ^ >> include/trace/bpf_probe.h:59:1: error: expected identifier or '(' before >> 'static' 59 | static notrace void \ | ^~ include/trace/bpf_probe.h:119:3: note: in expansion of macro '__BPF_DECLARE_TRACE' 119 | (__BPF_DECLARE_TRACE(call, PARAMS(proto), PARAMS(args)) \ | ^~~ include/trace/events/sched.h:713:1: note: in expansion of macro 'DECLARE_TRACE' 713 | DECLARE_TRACE(pelt_se_tp, | ^ >> include/trace/bpf_probe.h:59:1: error: expected identifier or '(' before >> 'static' 59 | static notrace void \ | ^~ include/trace/bpf_probe.h:119:3: note: in expansion of macro '__BPF_DECLARE_TRACE' 119 | (__BPF_DECLARE_TRACE(call, PARAMS(proto), PARAMS(args)) \ | ^~~ include/trace/events/sched.h:717:1: note: in expansion of macro 'DECLARE_TRACE' 717 | DECLARE_TRACE(sched_cpu_capacity_tp, | ^ >> include/trace/bpf_probe.h:59:1: error: expected identifier or
Re: [PATCH net v3] net: macb: Add default usrio config to default gem config
Hi Atish, Thank you for the patch! Yet something to improve: [auto build test ERROR on net/master] url: https://github.com/0day-ci/linux/commits/Atish-Patra/net-macb-Add-default-usrio-config-to-default-gem-config/20210114-034147 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git c8a8ead01736419a14c3106e1f26a79d74fc84c7 config: x86_64-rhel-7.6-kselftests (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/a870ba09ad366b8a2aa9cde42e3b0404a333ce03 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Atish-Patra/net-macb-Add-default-usrio-config-to-default-gem-config/20210114-034147 git checkout a870ba09ad366b8a2aa9cde42e3b0404a333ce03 # save the attached .config to linux build tree make W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): >> drivers/net/ethernet/cadence/macb_main.c:4593:12: error: >> 'macb_default_usrio' undeclared here (not in a function) 4593 | .usrio = &macb_default_usrio, |^~ vim +/macb_default_usrio +4593 drivers/net/ethernet/cadence/macb_main.c 4585 4586 static const struct macb_config default_gem_config = { 4587 .caps = MACB_CAPS_GIGABIT_MODE_AVAILABLE | 4588 MACB_CAPS_JUMBO | 4589 MACB_CAPS_GEM_HAS_PTP, 4590 .dma_burst_length = 16, 4591 .clk_init = macb_clk_init, 4592 .init = macb_init, > 4593 .usrio = &macb_default_usrio, 4594 .jumbo_max_len = 10240, 4595 }; 4596 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [RPC PATCH bpf-next] bpf: implement new BPF_CGROUP_INET_SOCK_POST_CONNECT
Hi Stanislav, Thank you for the patch! Yet something to improve: [auto build test ERROR on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Stanislav-Fomichev/bpf-implement-new-BPF_CGROUP_INET_SOCK_POST_CONNECT/20210115-112524 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master config: arm-randconfig-r014-20210115 (attached as .config) compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/342141c74fe4ece77f9d9753918a77e66d9d3316 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Stanislav-Fomichev/bpf-implement-new-BPF_CGROUP_INET_SOCK_POST_CONNECT/20210115-112524 git checkout 342141c74fe4ece77f9d9753918a77e66d9d3316 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): net/ipv4/af_inet.c: In function 'inet_dgram_connect': >> net/ipv4/af_inet.c:579:9: error: implicit declaration of function >> 'BPF_CGROUP_RUN_PROG_INET_SOCK_POST_CONNECT_LOCKED'; did you mean >> 'BPF_CGROUP_RUN_PROG_INET6_CONNECT_LOCK'? >> [-Werror=implicit-function-declaration] 579 | err = BPF_CGROUP_RUN_PROG_INET_SOCK_POST_CONNECT_LOCKED(sk); | ^ | BPF_CGROUP_RUN_PROG_INET6_CONNECT_LOCK net/ipv4/af_inet.c: In function 'inet_stream_connect': >> net/ipv4/af_inet.c:730:9: error: implicit declaration of function >> 'BPF_CGROUP_RUN_PROG_INET_SOCK_POST_CONNECT'; did you mean >> 'BPF_CGROUP_RUN_PROG_INET6_CONNECT'? [-Werror=implicit-function-declaration] 730 | err = BPF_CGROUP_RUN_PROG_INET_SOCK_POST_CONNECT(sock->sk); | ^~ | BPF_CGROUP_RUN_PROG_INET6_CONNECT cc1: some warnings being treated as errors vim +579 net/ipv4/af_inet.c 557 558 int inet_dgram_connect(struct socket *sock, struct sockaddr *uaddr, 559 int addr_len, int flags) 560 { 561 struct sock *sk = sock->sk; 562 int err; 563 564 if (addr_len < sizeof(uaddr->sa_family)) 565 return -EINVAL; 566 if (uaddr->sa_family == AF_UNSPEC) 567 return sk->sk_prot->disconnect(sk, flags); 568 569 if (BPF_CGROUP_PRE_CONNECT_ENABLED(sk)) { 570 err = sk->sk_prot->pre_connect(sk, uaddr, addr_len); 571 if (err) 572 return err; 573 } 574 575 if (!inet_sk(sk)->inet_num && inet_autobind(sk)) 576 return -EAGAIN; 577 err = sk->sk_prot->connect(sk, uaddr, addr_len); 578 if (!err) > 579 err = > BPF_CGROUP_RUN_PROG_INET_SOCK_POST_CONNECT_LOCKED(sk); 580 return err; 581 } 582 EXPORT_SYMBOL(inet_dgram_connect); 583 584 static long inet_wait_for_connect(struct sock *sk, long timeo, int writebias) 585 { 586 DEFINE_WAIT_FUNC(wait, woken_wake_function); 587 588 add_wait_queue(sk_sleep(sk), &wait); 589 sk->sk_write_pending += writebias; 590 591 /* Basic assumption: if someone sets sk->sk_err, he _must_ 592 * change state of the socket from TCP_SYN_*. 593 * Connect() does not allow to get error notifications 594 * without closing the socket. 595 */ 596 while ((1 << sk->sk_state) & (TCPF_SYN_SENT | TCPF_SYN_RECV)) { 597 release_sock(sk); 598 timeo = wait_woken(&wait, TASK_INTERRUPTIBLE, timeo); 599 lock_sock(sk); 600 if (signal_pending(current) || !timeo) 601 break; 602 } 603 remove_wait_queue(sk_sleep(sk), &wait); 604 sk->sk_write_pending -= writebias; 605 return timeo; 606 } 607 608 /* 609 * Connect to a remote host. There is regrettably still a little 610 * TCP 'magic' in here. 611 */ 612 int __inet_stream_connect(struct socket *sock, struct sockaddr *uaddr, 613int addr_len, int flags, int is_sendmsg) 614 { 615 struct sock *sk = sock->sk; 616 int err; 617 long timeo;
Re: [RPC PATCH bpf-next] bpf: implement new BPF_CGROUP_INET_SOCK_POST_CONNECT
Hi Stanislav, Thank you for the patch! Yet something to improve: [auto build test ERROR on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Stanislav-Fomichev/bpf-implement-new-BPF_CGROUP_INET_SOCK_POST_CONNECT/20210115-112524 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master config: powerpc64-randconfig-r021-20210115 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 5b42fd8dd4e7e29125a09a41a33af7c9cb57d144) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install powerpc64 cross compiling tool for clang build # apt-get install binutils-powerpc64-linux-gnu # https://github.com/0day-ci/linux/commit/342141c74fe4ece77f9d9753918a77e66d9d3316 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Stanislav-Fomichev/bpf-implement-new-BPF_CGROUP_INET_SOCK_POST_CONNECT/20210115-112524 git checkout 342141c74fe4ece77f9d9753918a77e66d9d3316 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): __do_insb ^ arch/powerpc/include/asm/io.h:556:56: note: expanded from macro '__do_insb' #define __do_insb(p, b, n) readsb((PCI_IO_ADDR)_IO_BASE+(p), (b), (n)) ~^ In file included from net/ipv4/af_inet.c:81: In file included from include/linux/interrupt.h:11: In file included from include/linux/hardirq.h:10: In file included from arch/powerpc/include/asm/hardirq.h:6: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:13: In file included from arch/powerpc/include/asm/io.h:619: arch/powerpc/include/asm/io-defs.h:45:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] DEF_PCI_AC_NORET(insw, (unsigned long p, void *b, unsigned long c), ^~~ arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET' __do_##name al; \ ^~ :100:1: note: expanded from here __do_insw ^ arch/powerpc/include/asm/io.h:557:56: note: expanded from macro '__do_insw' #define __do_insw(p, b, n) readsw((PCI_IO_ADDR)_IO_BASE+(p), (b), (n)) ~^ In file included from net/ipv4/af_inet.c:81: In file included from include/linux/interrupt.h:11: In file included from include/linux/hardirq.h:10: In file included from arch/powerpc/include/asm/hardirq.h:6: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:13: In file included from arch/powerpc/include/asm/io.h:619: arch/powerpc/include/asm/io-defs.h:47:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] DEF_PCI_AC_NORET(insl, (unsigned long p, void *b, unsigned long c), ^~~ arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET' __do_##name al; \ ^~ :102:1: note: expanded from here __do_insl ^ arch/powerpc/include/asm/io.h:558:56: note: expanded from macro '__do_insl' #define __do_insl(p, b, n) readsl((PCI_IO_ADDR)_IO_BASE+(p), (b), (n)) ~^ In file included from net/ipv4/af_inet.c:81: In file included from include/linux/interrupt.h:11: In file included from include/linux/hardirq.h:10: In file included from arch/powerpc/include/asm/hardirq.h:6: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:13: In file included from arch/powerpc/include/asm/io.h:619: arch/powerpc/include/asm/io-defs.h:49:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] DEF_PCI_AC_NORET(outsb, (unsigned long p, const void *b, unsigned long c), ^~ arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET' __do_##name al; \ ^~ :104:1: note: expanded from here __do_outsb ^ arch/powerpc/include/asm/io.h:559:58: note: expanded
Re: [PATCH v2 net-next 1/1] Allow user to set metric on default route learned via Router Advertisement.
Hi Praveen, Thank you for the patch! Yet something to improve: [auto build test ERROR on 139711f033f636cc78b6aaf7363252241b9698ef] url: https://github.com/0day-ci/linux/commits/Praveen-Chaudhary/Allow-user-to-set-metric-on-default-route-learned-via-Router-Advertisement/20210115-160758 base:139711f033f636cc78b6aaf7363252241b9698ef config: nds32-randconfig-r015-20210115 (attached as .config) compiler: nds32le-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/35f232fe80f8b50430aee1c6e534cba119c88de8 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Praveen-Chaudhary/Allow-user-to-set-metric-on-default-route-learned-via-Router-Advertisement/20210115-160758 git checkout 35f232fe80f8b50430aee1c6e534cba119c88de8 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nds32 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): net/ipv6/ndisc.c: In function 'ndisc_router_discovery': >> net/ipv6/ndisc.c:1308:35: error: 'struct ipv6_devconf' has no member named >> 'accept_ra_defrtr_metric'; did you mean 'accept_ra_defrtr'? 1308 | defrtr_usr_metric = in6_dev->cnf.accept_ra_defrtr_metric; | ^~~ | accept_ra_defrtr Kconfig warnings: (for reference only) WARNING: unmet direct dependencies detected for FRAME_POINTER Depends on DEBUG_KERNEL && (M68K || UML || SUPERH) || ARCH_WANT_FRAME_POINTERS Selected by - LATENCYTOP && DEBUG_KERNEL && STACKTRACE_SUPPORT && PROC_FS && !MIPS && !PPC && !S390 && !MICROBLAZE && !ARM && !ARC && !X86 vim +1308 net/ipv6/ndisc.c 1241 1242 if (in6_dev->if_flags & IF_RS_SENT) { 1243 /* 1244 * flag that an RA was received after an RS was sent 1245 * out on this interface. 1246 */ 1247 in6_dev->if_flags |= IF_RA_RCVD; 1248 } 1249 1250 /* 1251 * Remember the managed/otherconf flags from most recently 1252 * received RA message (RFC 2462) -- yoshfuji 1253 */ 1254 old_if_flags = in6_dev->if_flags; 1255 in6_dev->if_flags = (in6_dev->if_flags & ~(IF_RA_MANAGED | 1256 IF_RA_OTHERCONF)) | 1257 (ra_msg->icmph.icmp6_addrconf_managed ? 1258 IF_RA_MANAGED : 0) | 1259 (ra_msg->icmph.icmp6_addrconf_other ? 1260 IF_RA_OTHERCONF : 0); 1261 1262 if (old_if_flags != in6_dev->if_flags) 1263 send_ifinfo_notify = true; 1264 1265 if (!in6_dev->cnf.accept_ra_defrtr) { 1266 ND_PRINTK(2, info, 1267"RA: %s, defrtr is false for dev: %s\n", 1268__func__, skb->dev->name); 1269 goto skip_defrtr; 1270 } 1271 1272 /* Do not accept RA with source-addr found on local machine unless 1273 * accept_ra_from_local is set to true. 1274 */ 1275 net = dev_net(in6_dev->dev); 1276 if (!in6_dev->cnf.accept_ra_from_local && 1277 ipv6_chk_addr(net, &ipv6_hdr(skb)->saddr, in6_dev->dev, 0)) { 1278 ND_PRINTK(2, info, 1279"RA from local address detected on dev: %s: default router ignored\n", 1280skb->dev->name); 1281 goto skip_defrtr; 1282 } 1283 1284 lifetime = ntohs(ra_msg->icmph.icmp6_rt_lifetime); 1285 1286 #ifdef CONFIG_IPV6_ROUTER_PREF 1287 pref = ra_msg->icmph.icmp6_router_pref; 1288 /* 10b is handled as if it were 00b (medium) */ 1289 if (pref == ICMPV6_ROUTER_PREF_INVALID || 1290 !in6_dev->cnf.accept_ra_rtr_pref) 1291 pref = ICMPV6_ROUTER_PREF_MEDIUM; 1292 #endif 1293 /* routes added from RAs do not use nexthop objects */ 1294 rt = rt6_get_dflt_router(net, &ipv6_hdr(skb)->saddr, skb->dev); 1295 if (rt) { 1296 neigh = ip6_neigh_lookup(&rt->fib
Re: [PATCH net-next] net: ks8851: Fix mixed module/builtin build
Hi Marek, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Marek-Vasut/net-ks8851-Fix-mixed-module-builtin-build/20210115-215024 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 1d9f03c0a15fa01aa14fb295cbc1236403fceb0b config: riscv-allyesconfig (attached as .config) compiler: riscv64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/e11965ba009b3247ecbbb87730c724405eae8753 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Marek-Vasut/net-ks8851-Fix-mixed-module-builtin-build/20210115-215024 git checkout e11965ba009b3247ecbbb87730c724405eae8753 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=riscv If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): riscv64-linux-ld: drivers/net/ethernet/micrel/ks8851_par.o: in function `ks8851_remove_common': >> (.text+0x469a): multiple definition of `ks8851_remove_common'; >> drivers/net/ethernet/micrel/ks8851_spi.o:(.text+0x47a4): first defined here riscv64-linux-ld: drivers/net/ethernet/micrel/ks8851_par.o: in function `ks8851_probe_common': >> (.text+0x360c): multiple definition of `ks8851_probe_common'; >> drivers/net/ethernet/micrel/ks8851_spi.o:(.text+0x3570): first defined here --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [PATCH net-next] net: ks8851: Fix mixed module/builtin build
Hi Marek, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Marek-Vasut/net-ks8851-Fix-mixed-module-builtin-build/20210115-215024 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 1d9f03c0a15fa01aa14fb295cbc1236403fceb0b config: mips-allyesconfig (attached as .config) compiler: mips-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/e11965ba009b3247ecbbb87730c724405eae8753 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Marek-Vasut/net-ks8851-Fix-mixed-module-builtin-build/20210115-215024 git checkout e11965ba009b3247ecbbb87730c724405eae8753 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): mips-linux-ld: drivers/net/ethernet/micrel/ks8851_par.o: in function `ks8851_resume': >> ks8851_par.c:(.text.ks8851_resume+0x0): multiple definition of >> `ks8851_resume'; >> drivers/net/ethernet/micrel/ks8851_spi.o:ks8851_spi.c:(.text.ks8851_resume+0x0): >> first defined here mips-linux-ld: drivers/net/ethernet/micrel/ks8851_par.o: in function `ks8851_suspend': >> ks8851_par.c:(.text.ks8851_suspend+0x0): multiple definition of >> `ks8851_suspend'; >> drivers/net/ethernet/micrel/ks8851_spi.o:ks8851_spi.c:(.text.ks8851_suspend+0x0): >> first defined here mips-linux-ld: drivers/net/ethernet/micrel/ks8851_par.o: in function `ks8851_probe_common': >> ks8851_par.c:(.text.ks8851_probe_common+0x0): multiple definition of >> `ks8851_probe_common'; >> drivers/net/ethernet/micrel/ks8851_spi.o:ks8851_spi.c:(.text.ks8851_probe_common+0x0): >> first defined here mips-linux-ld: drivers/net/ethernet/micrel/ks8851_par.o: in function `ks8851_remove_common': >> ks8851_par.c:(.text.ks8851_remove_common+0x0): multiple definition of >> `ks8851_remove_common'; >> drivers/net/ethernet/micrel/ks8851_spi.o:ks8851_spi.c:(.text.ks8851_remove_common+0x0): >> first defined here --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [PATCH bpf-next] xsk: build skb by page
Hi Xuan, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Xuan-Zhuo/xsk-build-skb-by-page/20210116-105116 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master config: sh-allmodconfig (attached as .config) compiler: sh4-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/ee139d2988e5c5945108889a7c95c751910c1877 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Xuan-Zhuo/xsk-build-skb-by-page/20210116-105116 git checkout ee139d2988e5c5945108889a7c95c751910c1877 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): net/xdp/xsk.c: In function 'xsk_build_skb': net/xdp/xsk.c:497:4: error: invalid type argument of unary '*' (have 'int') 497 |*err = -ENOMEM; |^~~~ net/xdp/xsk.c:508:4: error: invalid type argument of unary '*' (have 'int') 508 |*err = -EINVAL; |^~~~ >> net/xdp/xsk.c:490:7: warning: variable 'addr' set but not used >> [-Wunused-but-set-variable] 490 | u64 addr; | ^~~~ Kconfig warnings: (for reference only) WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_PDC Depends on SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && HAS_DMA Selected by - SND_ATMEL_SOC_SSC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC - SND_ATMEL_SOC_SSC_PDC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && ATMEL_SSC vim +/addr +490 net/xdp/xsk.c 476 477 static struct sk_buff *xsk_build_skb(struct xdp_sock *xs, 478 struct xdp_desc *desc, int *err) 479 { 480 struct sk_buff *skb; 481 482 if (xs->dev->features & NETIF_F_SKB_NO_LINEAR) { 483 skb = xsk_build_skb_zerocopy(xs, desc); 484 if (unlikely(!skb)) { 485 *err = -ENOMEM; 486 return NULL; 487 } 488 } else { 489 char *buffer; > 490 u64 addr; 491 u32 len; 492 int err; 493 494 len = desc->len; 495 skb = sock_alloc_send_skb(&xs->sk, len, 1, &err); 496 if (unlikely(!skb)) { > 497 *err = -ENOMEM; 498 return NULL; 499 } 500 501 skb_put(skb, len); 502 addr = desc->addr; 503 buffer = xsk_buff_raw_get_data(xs->pool, desc->addr); 504 err = skb_store_bits(skb, 0, buffer, len); 505 506 if (unlikely(err)) { 507 kfree_skb(skb); 508 *err = -EINVAL; 509 return NULL; 510 } 511 } 512 513 skb->dev = xs->dev; 514 skb->priority = xs->sk.sk_priority; 515 skb->mark = xs->sk.sk_mark; 516 skb_shinfo(skb)->destructor_arg = (void *)(long)desc->addr; 517 skb->destructor = xsk_destruct_skb; 518 519 return skb; 520 } 521 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [PATCH bpf-next] xsk: build skb by page
Hi Xuan, Thank you for the patch! Yet something to improve: [auto build test ERROR on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Xuan-Zhuo/xsk-build-skb-by-page/20210116-105116 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master config: sh-allmodconfig (attached as .config) compiler: sh4-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/ee139d2988e5c5945108889a7c95c751910c1877 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Xuan-Zhuo/xsk-build-skb-by-page/20210116-105116 git checkout ee139d2988e5c5945108889a7c95c751910c1877 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): net/xdp/xsk.c: In function 'xsk_build_skb': >> net/xdp/xsk.c:497:4: error: invalid type argument of unary '*' (have 'int') 497 |*err = -ENOMEM; |^~~~ net/xdp/xsk.c:508:4: error: invalid type argument of unary '*' (have 'int') 508 |*err = -EINVAL; |^~~~ net/xdp/xsk.c:490:7: warning: variable 'addr' set but not used [-Wunused-but-set-variable] 490 | u64 addr; | ^~~~ Kconfig warnings: (for reference only) WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_PDC Depends on SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && HAS_DMA Selected by - SND_ATMEL_SOC_SSC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC - SND_ATMEL_SOC_SSC_PDC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && ATMEL_SSC vim +497 net/xdp/xsk.c 476 477 static struct sk_buff *xsk_build_skb(struct xdp_sock *xs, 478 struct xdp_desc *desc, int *err) 479 { 480 struct sk_buff *skb; 481 482 if (xs->dev->features & NETIF_F_SKB_NO_LINEAR) { 483 skb = xsk_build_skb_zerocopy(xs, desc); 484 if (unlikely(!skb)) { 485 *err = -ENOMEM; 486 return NULL; 487 } 488 } else { 489 char *buffer; 490 u64 addr; 491 u32 len; 492 int err; 493 494 len = desc->len; 495 skb = sock_alloc_send_skb(&xs->sk, len, 1, &err); 496 if (unlikely(!skb)) { > 497 *err = -ENOMEM; 498 return NULL; 499 } 500 501 skb_put(skb, len); 502 addr = desc->addr; 503 buffer = xsk_buff_raw_get_data(xs->pool, desc->addr); 504 err = skb_store_bits(skb, 0, buffer, len); 505 506 if (unlikely(err)) { 507 kfree_skb(skb); 508 *err = -EINVAL; 509 return NULL; 510 } 511 } 512 513 skb->dev = xs->dev; 514 skb->priority = xs->sk.sk_priority; 515 skb->mark = xs->sk.sk_mark; 516 skb_shinfo(skb)->destructor_arg = (void *)(long)desc->addr; 517 skb->destructor = xsk_destruct_skb; 518 519 return skb; 520 } 521 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [PATCH net-next] net: mdio: access c22 registers via debugfs
Hi "Pavel, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Pavel-imerda/net-mdio-access-c22-registers-via-debugfs/20210117-053409 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 9ab7e76aefc97a9aa664accb59d6e8dc5e52514a config: powerpc-adder875_defconfig (attached as .config) compiler: powerpc-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/22d74f4896850840331d36d6867f7bc5ce728bbd git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Pavel-imerda/net-mdio-access-c22-registers-via-debugfs/20210117-053409 git checkout 22d74f4896850840331d36d6867f7bc5ce728bbd # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/net/phy/mdio-debugfs.c:170:6: warning: no previous prototype for >> 'mdio_debugfs_add' [-Wmissing-prototypes] 170 | void mdio_debugfs_add(struct mii_bus *bus) | ^~~~ >> drivers/net/phy/mdio-debugfs.c:177:6: warning: no previous prototype for >> 'mdio_debugfs_remove' [-Wmissing-prototypes] 177 | void mdio_debugfs_remove(struct mii_bus *bus) | ^~~ >> drivers/net/phy/mdio-debugfs.c:184:12: warning: no previous prototype for >> 'mdio_debugfs_init' [-Wmissing-prototypes] 184 | int __init mdio_debugfs_init(void) |^ >> drivers/net/phy/mdio-debugfs.c:192:13: warning: no previous prototype for >> 'mdio_debugfs_exit' [-Wmissing-prototypes] 192 | void __exit mdio_debugfs_exit(void) | ^ vim +/mdio_debugfs_add +170 drivers/net/phy/mdio-debugfs.c 169 > 170 void mdio_debugfs_add(struct mii_bus *bus) 171 { 172 bus->debugfs_dentry = debugfs_create_dir(dev_name(&bus->dev), mdio_debugfs_dentry); 173 debugfs_create_file("control", 0600, bus->debugfs_dentry, bus, &mdio_debug_fops); 174 } 175 EXPORT_SYMBOL_GPL(mdio_debugfs_add); 176 > 177 void mdio_debugfs_remove(struct mii_bus *bus) 178 { 179 debugfs_remove(bus->debugfs_dentry); 180 bus->debugfs_dentry = NULL; 181 } 182 EXPORT_SYMBOL_GPL(mdio_debugfs_remove); 183 > 184 int __init mdio_debugfs_init(void) 185 { 186 mdio_debugfs_dentry = debugfs_create_dir("mdio", NULL); 187 188 return PTR_ERR_OR_ZERO(mdio_debugfs_dentry); 189 } 190 module_init(mdio_debugfs_init); 191 > 192 void __exit mdio_debugfs_exit(void) --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [PATCH net-next] net: mdio: access c22 registers via debugfs
Hi "Pavel, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Pavel-imerda/net-mdio-access-c22-registers-via-debugfs/20210117-053409 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 9ab7e76aefc97a9aa664accb59d6e8dc5e52514a config: i386-randconfig-s002-20210117 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.3-208-g46a52ca4-dirty # https://github.com/0day-ci/linux/commit/22d74f4896850840331d36d6867f7bc5ce728bbd git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Pavel-imerda/net-mdio-access-c22-registers-via-debugfs/20210117-053409 git checkout 22d74f4896850840331d36d6867f7bc5ce728bbd # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot "sparse warnings: (new ones prefixed by >>)" >> drivers/net/phy/mdio-debugfs.c:160:17: sparse: sparse: incorrect type in >> initializer (different base types) @@ expected restricted __poll_t ( >> *poll )( ... ) @@ got unsigned int ( * )( ... ) @@ drivers/net/phy/mdio-debugfs.c:160:17: sparse: expected restricted __poll_t ( *poll )( ... ) drivers/net/phy/mdio-debugfs.c:160:17: sparse: got unsigned int ( * )( ... ) >> drivers/net/phy/mdio-debugfs.c:154:24: sparse: sparse: symbol >> 'mdio_debug_fops' was not declared. Should it be static? >> drivers/net/phy/mdio-debugfs.c:184:12: sparse: sparse: symbol >> 'mdio_debugfs_init' was not declared. Should it be static? >> drivers/net/phy/mdio-debugfs.c:192:13: sparse: sparse: symbol >> 'mdio_debugfs_exit' was not declared. Should it be static? Please review and possibly fold the followup patch. vim +160 drivers/net/phy/mdio-debugfs.c 153 > 154 struct file_operations mdio_debug_fops = { 155 .owner = THIS_MODULE, 156 .open = mdio_debug_open, 157 .release = mdio_debug_release, 158 .write = mdio_debug_write, 159 .read = mdio_debug_read, > 160 .poll = mdio_debug_poll, 161 }; 162 163 /* 164 * TODO: This implementation doesn't support module load/unload and has no 165 * error checking. 166 */ 167 168 static struct dentry *mdio_debugfs_dentry; 169 170 void mdio_debugfs_add(struct mii_bus *bus) 171 { 172 bus->debugfs_dentry = debugfs_create_dir(dev_name(&bus->dev), mdio_debugfs_dentry); 173 debugfs_create_file("control", 0600, bus->debugfs_dentry, bus, &mdio_debug_fops); 174 } 175 EXPORT_SYMBOL_GPL(mdio_debugfs_add); 176 177 void mdio_debugfs_remove(struct mii_bus *bus) 178 { 179 debugfs_remove(bus->debugfs_dentry); 180 bus->debugfs_dentry = NULL; 181 } 182 EXPORT_SYMBOL_GPL(mdio_debugfs_remove); 183 > 184 int __init mdio_debugfs_init(void) 185 { 186 mdio_debugfs_dentry = debugfs_create_dir("mdio", NULL); 187 188 return PTR_ERR_OR_ZERO(mdio_debugfs_dentry); 189 } 190 module_init(mdio_debugfs_init); 191 > 192 void __exit mdio_debugfs_exit(void) --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
[RFC PATCH] net: mdio: mdio_debug_fops can be static
Reported-by: kernel test robot Signed-off-by: kernel test robot --- mdio-debugfs.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/phy/mdio-debugfs.c b/drivers/net/phy/mdio-debugfs.c index abed40052c20a1d..f1c9a3c604714c2 100644 --- a/drivers/net/phy/mdio-debugfs.c +++ b/drivers/net/phy/mdio-debugfs.c @@ -151,7 +151,7 @@ static unsigned int mdio_debug_poll(struct file *file, poll_table *wait) return data->value == -1 ? POLLOUT : POLLIN; } -struct file_operations mdio_debug_fops = { +static struct file_operations mdio_debug_fops = { .owner = THIS_MODULE, .open = mdio_debug_open, .release = mdio_debug_release, @@ -181,7 +181,7 @@ void mdio_debugfs_remove(struct mii_bus *bus) } EXPORT_SYMBOL_GPL(mdio_debugfs_remove); -int __init mdio_debugfs_init(void) +static int __init mdio_debugfs_init(void) { mdio_debugfs_dentry = debugfs_create_dir("mdio", NULL); @@ -189,7 +189,7 @@ int __init mdio_debugfs_init(void) } module_init(mdio_debugfs_init); -void __exit mdio_debugfs_exit(void) +static void __exit mdio_debugfs_exit(void) { debugfs_remove(mdio_debugfs_dentry); }
Re: [PATCH net-next] net: mdio: access c22 registers via debugfs
Hi "Pavel, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Pavel-imerda/net-mdio-access-c22-registers-via-debugfs/20210117-053409 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 9ab7e76aefc97a9aa664accb59d6e8dc5e52514a config: s390-randconfig-r015-20210117 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 2082b10d100e8dbaffc2ba8f497db5d2ab61beb2) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install s390 cross compiling tool for clang build # apt-get install binutils-s390x-linux-gnu # https://github.com/0day-ci/linux/commit/22d74f4896850840331d36d6867f7bc5ce728bbd git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Pavel-imerda/net-mdio-access-c22-registers-via-debugfs/20210117-053409 git checkout 22d74f4896850840331d36d6867f7bc5ce728bbd # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=s390 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): ^ include/uapi/linux/swab.h:20:12: note: expanded from macro '___constant_swab32' (((__u32)(x) & (__u32)0xff00UL) << 8) |\ ^ In file included from drivers/net/phy/mdio-debugfs.c:3: In file included from include/linux/phy.h:16: In file included from include/linux/ethtool.h:18: In file included from include/uapi/linux/ethtool.h:19: In file included from include/linux/if_ether.h:19: In file included from include/linux/skbuff.h:31: In file included from include/linux/dma-mapping.h:10: In file included from include/linux/scatterlist.h:9: In file included from arch/s390/include/asm/io.h:80: include/asm-generic/io.h:490:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr)); ~~ ^ include/uapi/linux/byteorder/big_endian.h:34:59: note: expanded from macro '__le32_to_cpu' #define __le32_to_cpu(x) __swab32((__force __u32)(__le32)(x)) ^ include/uapi/linux/swab.h:119:21: note: expanded from macro '__swab32' ___constant_swab32(x) : \ ^ include/uapi/linux/swab.h:21:12: note: expanded from macro '___constant_swab32' (((__u32)(x) & (__u32)0x00ffUL) >> 8) |\ ^ In file included from drivers/net/phy/mdio-debugfs.c:3: In file included from include/linux/phy.h:16: In file included from include/linux/ethtool.h:18: In file included from include/uapi/linux/ethtool.h:19: In file included from include/linux/if_ether.h:19: In file included from include/linux/skbuff.h:31: In file included from include/linux/dma-mapping.h:10: In file included from include/linux/scatterlist.h:9: In file included from arch/s390/include/asm/io.h:80: include/asm-generic/io.h:490:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr)); ~~ ^ include/uapi/linux/byteorder/big_endian.h:34:59: note: expanded from macro '__le32_to_cpu' #define __le32_to_cpu(x) __swab32((__force __u32)(__le32)(x)) ^ include/uapi/linux/swab.h:119:21: note: expanded from macro '__swab32' ___constant_swab32(x) : \ ^ include/uapi/linux/swab.h:22:12: note: expanded from macro '___constant_swab32' (((__u32)(x) & (__u32)0xff00UL) >> 24))) ^ In file included from drivers/net/phy/mdio-debugfs.c:3: In file included from include/linux/phy.h:16: In file included from include/linux/ethtool.h:18: In file included from include/uapi/linux/ethtool.h:19: In file included from include/linux/if_ether.h:19: In file included from include/linux/skbuff.h:31: In file included from include/linux/dma-mapping.h:10: In file included from include/linux/scatterlist.h:9: In file included from arch/s390/include/asm/io.h:80: include/asm-generic/io.h:490:61: warning: performing pointer arithmetic on a
Re: [PATCH v3 net-next 10/15] net: mscc: ocelot: refactor ocelot_port_inject_frame out of ocelot_port_xmit
Hi Vladimir, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Vladimir-Oltean/tag_8021q-for-Ocelot-switches/20210119-004520 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 213b97b125808aa220ba460a7af09d8f3772f669 config: sh-allmodconfig (attached as .config) compiler: sh4-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/b0c94dae99772294285cc3219500b73026853e83 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Vladimir-Oltean/tag_8021q-for-Ocelot-switches/20210119-004520 git checkout b0c94dae99772294285cc3219500b73026853e83 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>, old ones prefixed by <<): >> ERROR: modpost: "ocelot_can_inject" >> [drivers/net/ethernet/mscc/mscc_ocelot.ko] undefined! ERROR: modpost: "ocelot_port_inject_frame" [drivers/net/ethernet/mscc/mscc_ocelot.ko] undefined! ERROR: modpost: "__delay" [drivers/net/mdio/mdio-cavium.ko] undefined! ERROR: modpost: "__udivdi3" [fs/btrfs/btrfs.ko] undefined! ERROR: modpost: "__umoddi3" [fs/btrfs/btrfs.ko] undefined! Kconfig warnings: (for reference only) WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_PDC Depends on SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && HAS_DMA Selected by - SND_ATMEL_SOC_SSC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC - SND_ATMEL_SOC_SSC_PDC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && ATMEL_SSC --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [PATCH bpf-next v2 4/8] xsk: register XDP sockets at bind(), and add new AF_XDP BPF helper
Hi "Björn, I love your patch! Yet something to improve: [auto build test ERROR on 95204c9bfa48d2f4d3bab7df55c1cc823957ff81] url: https://github.com/0day-ci/linux/commits/Bj-rn-T-pel/Introduce-bpf_redirect_xsk-helper/20210120-150357 base:95204c9bfa48d2f4d3bab7df55c1cc823957ff81 config: x86_64-randconfig-m031-20210120 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/419b1341d7980ee57fb10f4306719eef3c1a15f8 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Bj-rn-T-pel/Introduce-bpf_redirect_xsk-helper/20210120-150357 git checkout 419b1341d7980ee57fb10f4306719eef3c1a15f8 # save the attached .config to linux build tree make W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): In file included from : net/core/filter.c: In function 'bpf_xdp_redirect_xsk': >> net/core/filter.c:4165:35: error: 'struct netdev_rx_queue' has no member >> named 'xsk' 4165 | xs = READ_ONCE(dev->_rx[queue_id].xsk); | ^ include/linux/compiler_types.h:300:9: note: in definition of macro '__compiletime_assert' 300 | if (!(condition)) \ | ^ include/linux/compiler_types.h:320:2: note: in expansion of macro '_compiletime_assert' 320 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^~~ include/asm-generic/rwonce.h:36:2: note: in expansion of macro 'compiletime_assert' 36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \ | ^~ include/asm-generic/rwonce.h:36:21: note: in expansion of macro '__native_word' 36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \ | ^ include/asm-generic/rwonce.h:49:2: note: in expansion of macro 'compiletime_assert_rwonce_type' 49 | compiletime_assert_rwonce_type(x);\ | ^~ net/core/filter.c:4165:7: note: in expansion of macro 'READ_ONCE' 4165 | xs = READ_ONCE(dev->_rx[queue_id].xsk); | ^ >> net/core/filter.c:4165:35: error: 'struct netdev_rx_queue' has no member >> named 'xsk' 4165 | xs = READ_ONCE(dev->_rx[queue_id].xsk); | ^ include/linux/compiler_types.h:300:9: note: in definition of macro '__compiletime_assert' 300 | if (!(condition)) \ | ^ include/linux/compiler_types.h:320:2: note: in expansion of macro '_compiletime_assert' 320 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^~~ include/asm-generic/rwonce.h:36:2: note: in expansion of macro 'compiletime_assert' 36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \ | ^~ include/asm-generic/rwonce.h:36:21: note: in expansion of macro '__native_word' 36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \ | ^ include/asm-generic/rwonce.h:49:2: note: in expansion of macro 'compiletime_assert_rwonce_type' 49 | compiletime_assert_rwonce_type(x);\ | ^~ net/core/filter.c:4165:7: note: in expansion of macro 'READ_ONCE' 4165 | xs = READ_ONCE(dev->_rx[queue_id].xsk); | ^ >> net/core/filter.c:4165:35: error: 'struct netdev_rx_queue' has no member >> named 'xsk' 4165 | xs = READ_ONCE(dev->_rx[queue_id].xsk); | ^ include/linux/compiler_types.h:300:9: note: in definition of macro '__compiletime_assert' 300 | if (!(condition)) \ | ^ include/linux/compiler_types.h:320:2: note: in expansion of macro '_compiletime_assert' 320 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^~~ include/asm-generic/rwonce.h:36:2: note: in expansion of macro 'compiletime_assert' 36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \ | ^~ include/asm-generic/rwonce.h:36:21: note: in expansion of macro '__native_word' 36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \ | ^ include/asm-g
Re: [PATCH bpf-next v2 4/8] xsk: register XDP sockets at bind(), and add new AF_XDP BPF helper
Hi "Björn, I love your patch! Yet something to improve: [auto build test ERROR on 95204c9bfa48d2f4d3bab7df55c1cc823957ff81] url: https://github.com/0day-ci/linux/commits/Bj-rn-T-pel/Introduce-bpf_redirect_xsk-helper/20210120-150357 base:95204c9bfa48d2f4d3bab7df55c1cc823957ff81 config: arm-randconfig-r013-20210120 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 22b68440e1647e16b5ee24b924986207173c02d1) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm cross compiling tool for clang build # apt-get install binutils-arm-linux-gnueabi # https://github.com/0day-ci/linux/commit/419b1341d7980ee57fb10f4306719eef3c1a15f8 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Bj-rn-T-pel/Introduce-bpf_redirect_xsk-helper/20210120-150357 git checkout 419b1341d7980ee57fb10f4306719eef3c1a15f8 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): >> net/core/filter.c:4165:36: error: no member named 'xsk' in 'struct >> netdev_rx_queue' xs = READ_ONCE(dev->_rx[queue_id].xsk); ~~ ^ include/asm-generic/rwonce.h:49:33: note: expanded from macro 'READ_ONCE' compiletime_assert_rwonce_type(x); \ ^ include/asm-generic/rwonce.h:36:35: note: expanded from macro 'compiletime_assert_rwonce_type' compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \ ^ include/linux/compiler_types.h:282:10: note: expanded from macro '__native_word' (sizeof(t) == sizeof(char) || sizeof(t) == sizeof(short) || \ ^ include/linux/compiler_types.h:320:22: note: expanded from macro 'compiletime_assert' _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) ^ include/linux/compiler_types.h:308:23: note: expanded from macro '_compiletime_assert' __compiletime_assert(condition, msg, prefix, suffix) ^ include/linux/compiler_types.h:300:9: note: expanded from macro '__compiletime_assert' if (!(condition)) \ ^ >> net/core/filter.c:4165:36: error: no member named 'xsk' in 'struct >> netdev_rx_queue' xs = READ_ONCE(dev->_rx[queue_id].xsk); ~~ ^ include/asm-generic/rwonce.h:49:33: note: expanded from macro 'READ_ONCE' compiletime_assert_rwonce_type(x); \ ^ include/asm-generic/rwonce.h:36:35: note: expanded from macro 'compiletime_assert_rwonce_type' compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \ ^ include/linux/compiler_types.h:282:39: note: expanded from macro '__native_word' (sizeof(t) == sizeof(char) || sizeof(t) == sizeof(short) || \ ^ include/linux/compiler_types.h:320:22: note: expanded from macro 'compiletime_assert' _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) ^ include/linux/compiler_types.h:308:23: note: expanded from macro '_compiletime_assert' __compiletime_assert(condition, msg, prefix, suffix) ^ include/linux/compiler_types.h:300:9: note: expanded from macro '__compiletime_assert' if (!(condition)) \ ^ >> net/core/filter.c:4165:36: error: no member named 'xsk' in 'struct >> netdev_rx_queue' xs = READ_ONCE(dev->_rx[queue_id].xsk); ~~ ^ include/asm-generic/rwonce.h:49:33: note: expanded from macro 'READ_ONCE' compiletime_assert_rwonce_type(x); \ ^ include/asm-generic/rwonce.h:36:35: note: expanded from macro 'compiletime_assert_rwonce_type' compiletime_assert(__native_word(t) || sizeof(t)
Re: [PATCH v4 net-next 15/16] net: dsa: felix: setup MMIO filtering rules for PTP when using tag_8021q
Hi Vladimir, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Vladimir-Oltean/tag_8021q-for-Ocelot-switches/20210120-145800 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 7b8fc0103bb51d1d3e1fb5fd67958612e709f883 config: nds32-allyesconfig (attached as .config) compiler: nds32le-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/c1cb52858ce53bff4293bc96d800bbb0bd22fc74 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Vladimir-Oltean/tag_8021q-for-Ocelot-switches/20210120-145800 git checkout c1cb52858ce53bff4293bc96d800bbb0bd22fc74 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nds32 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): drivers/net/dsa/ocelot/felix.c: In function 'felix_setup_tag_8021q': >> drivers/net/dsa/ocelot/felix.c:464:12: warning: variable 'err' set but not >> used [-Wunused-but-set-variable] 464 | int port, err; |^~~ vim +/err +464 drivers/net/dsa/ocelot/felix.c 7bc3a3dc54b2bb6 Vladimir Oltean 2021-01-20 458 7bc3a3dc54b2bb6 Vladimir Oltean 2021-01-20 459 static int felix_setup_tag_8021q(struct dsa_switch *ds, int cpu) 7bc3a3dc54b2bb6 Vladimir Oltean 2021-01-20 460 { 7bc3a3dc54b2bb6 Vladimir Oltean 2021-01-20 461 struct ocelot *ocelot = ds->priv; 7bc3a3dc54b2bb6 Vladimir Oltean 2021-01-20 462 struct felix *felix = ocelot_to_felix(ocelot); 7bc3a3dc54b2bb6 Vladimir Oltean 2021-01-20 463 unsigned long cpu_flood; 7bc3a3dc54b2bb6 Vladimir Oltean 2021-01-20 @464 int port, err; 7bc3a3dc54b2bb6 Vladimir Oltean 2021-01-20 465 7bc3a3dc54b2bb6 Vladimir Oltean 2021-01-20 466 felix_8021q_cpu_port_init(ocelot, cpu); 7bc3a3dc54b2bb6 Vladimir Oltean 2021-01-20 467 7bc3a3dc54b2bb6 Vladimir Oltean 2021-01-20 468 for (port = 0; port < ds->num_ports; port++) { 7bc3a3dc54b2bb6 Vladimir Oltean 2021-01-20 469 if (dsa_is_unused_port(ds, port)) 7bc3a3dc54b2bb6 Vladimir Oltean 2021-01-20 470 continue; 7bc3a3dc54b2bb6 Vladimir Oltean 2021-01-20 471 7bc3a3dc54b2bb6 Vladimir Oltean 2021-01-20 472 /* This overwrites ocelot_init(): 7bc3a3dc54b2bb6 Vladimir Oltean 2021-01-20 473 * Do not forward BPDU frames to the CPU port module, 7bc3a3dc54b2bb6 Vladimir Oltean 2021-01-20 474 * for 2 reasons: 7bc3a3dc54b2bb6 Vladimir Oltean 2021-01-20 475 * - When these packets are injected from the tag_8021q 7bc3a3dc54b2bb6 Vladimir Oltean 2021-01-20 476 * CPU port, we want them to go out, not loop back 7bc3a3dc54b2bb6 Vladimir Oltean 2021-01-20 477 * into the system. 7bc3a3dc54b2bb6 Vladimir Oltean 2021-01-20 478 * - STP traffic ingressing on a user port should go to 7bc3a3dc54b2bb6 Vladimir Oltean 2021-01-20 479 * the tag_8021q CPU port, not to the hardware CPU 7bc3a3dc54b2bb6 Vladimir Oltean 2021-01-20 480 * port module. 7bc3a3dc54b2bb6 Vladimir Oltean 2021-01-20 481 */ 7bc3a3dc54b2bb6 Vladimir Oltean 2021-01-20 482 ocelot_write_gix(ocelot, 7bc3a3dc54b2bb6 Vladimir Oltean 2021-01-20 483 ANA_PORT_CPU_FWD_BPDU_CFG_BPDU_REDIR_ENA(0), 7bc3a3dc54b2bb6 Vladimir Oltean 2021-01-20 484 ANA_PORT_CPU_FWD_BPDU_CFG, port); 7bc3a3dc54b2bb6 Vladimir Oltean 2021-01-20 485 } 7bc3a3dc54b2bb6 Vladimir Oltean 2021-01-20 486 c1cb52858ce53bf Vladimir Oltean 2021-01-20 487 /* In tag_8021q mode, the CPU port module is unused, except for PTP c1cb52858ce53bf Vladimir Oltean 2021-01-20 488 * frames. So we want to disable flooding of any kind to the CPU port c1cb52858ce53bf Vladimir Oltean 2021-01-20 489 * module, since packets going there will end in a black hole. 7bc3a3dc54b2bb6 Vladimir Oltean 2021-01-20 490 */ 7bc3a3dc54b2bb6 Vladimir Oltean 2021-01-20 491 cpu_flood = ANA_PGID_PGID_PGID(BIT(ocelot->num_phys_ports)); 7bc3a3dc54b2bb6 Vladimir Oltean 2021-01-20 492 ocelot_rmw_rix(ocelot, 0, cpu_flood, ANA_PGID_PGID, PGID_UC); 7bc3a3dc54b2bb6 Vladimir Oltean 2021-01-20 493 ocelot_rmw_rix(ocelot, 0, cpu_flood, ANA_PGID_PGID, PGID_MC); 7bc3a3dc54b2bb6 Vladimir Oltean 2021-01-20 494 7bc3a3dc54b2bb6 Vladimir Oltean 2021-01-20 495 oce
Re: [PATCH bpf-next 4/8] xsk: register XDP sockets at bind(), and add new AF_XDP BPF helper
Hi "Björn, I love your patch! Yet something to improve: [auto build test ERROR on 95204c9bfa48d2f4d3bab7df55c1cc823957ff81] url: https://github.com/0day-ci/linux/commits/Bj-rn-T-pel/Introduce-bpf_redirect_xsk-helper/20210120-165233 base:95204c9bfa48d2f4d3bab7df55c1cc823957ff81 config: nios2-randconfig-r034-20210120 (attached as .config) compiler: nios2-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/e90e83e99e93790a73ecb4071ffd4366c75f12c0 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Bj-rn-T-pel/Introduce-bpf_redirect_xsk-helper/20210120-165233 git checkout e90e83e99e93790a73ecb4071ffd4366c75f12c0 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nios2 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): In file included from : net/core/filter.c: In function 'bpf_xdp_redirect_xsk': >> net/core/filter.c:4165:35: error: 'struct netdev_rx_queue' has no member >> named 'xsk' 4165 | xs = READ_ONCE(dev->_rx[queue_id].xsk); | ^ include/linux/compiler_types.h:300:9: note: in definition of macro '__compiletime_assert' 300 | if (!(condition)) \ | ^ include/linux/compiler_types.h:320:2: note: in expansion of macro '_compiletime_assert' 320 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^~~ include/asm-generic/rwonce.h:36:2: note: in expansion of macro 'compiletime_assert' 36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \ | ^~ include/asm-generic/rwonce.h:36:21: note: in expansion of macro '__native_word' 36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \ | ^ include/asm-generic/rwonce.h:49:2: note: in expansion of macro 'compiletime_assert_rwonce_type' 49 | compiletime_assert_rwonce_type(x);\ | ^~ net/core/filter.c:4165:7: note: in expansion of macro 'READ_ONCE' 4165 | xs = READ_ONCE(dev->_rx[queue_id].xsk); | ^ >> net/core/filter.c:4165:35: error: 'struct netdev_rx_queue' has no member >> named 'xsk' 4165 | xs = READ_ONCE(dev->_rx[queue_id].xsk); | ^ include/linux/compiler_types.h:300:9: note: in definition of macro '__compiletime_assert' 300 | if (!(condition)) \ | ^ include/linux/compiler_types.h:320:2: note: in expansion of macro '_compiletime_assert' 320 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^~~ include/asm-generic/rwonce.h:36:2: note: in expansion of macro 'compiletime_assert' 36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \ | ^~ include/asm-generic/rwonce.h:36:21: note: in expansion of macro '__native_word' 36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \ | ^ include/asm-generic/rwonce.h:49:2: note: in expansion of macro 'compiletime_assert_rwonce_type' 49 | compiletime_assert_rwonce_type(x);\ | ^~ net/core/filter.c:4165:7: note: in expansion of macro 'READ_ONCE' 4165 | xs = READ_ONCE(dev->_rx[queue_id].xsk); | ^ >> net/core/filter.c:4165:35: error: 'struct netdev_rx_queue' has no member >> named 'xsk' 4165 | xs = READ_ONCE(dev->_rx[queue_id].xsk); | ^ include/linux/compiler_types.h:300:9: note: in definition of macro '__compiletime_assert' 300 | if (!(condition)) \ | ^ include/linux/compiler_types.h:320:2: note: in expansion of macro '_compiletime_assert' 320 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^~~ include/asm-generic/rwonce.h:36:2: note: in expansion of macro 'compiletime_assert' 36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \ | ^~ include/asm-generic/rwonce.h:36:21: no
Re: [PATCH] dsa: vsc73xx: add support for vlan filtering
Hi Pawel, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net/master] [also build test WARNING on net-next/master ipvs/master linus/master v5.11-rc4 next-20210120] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Pawel-Dembicki/dsa-vsc73xx-add-support-for-vlan-filtering/20210120-161228 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git 8e4052c32d6b4b39c1e13c652c7e33748d447409 config: powerpc-allyesconfig (attached as .config) compiler: powerpc64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/1b3778a3f0b1d668f4fa289c82997ebbd2145178 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Pawel-Dembicki/dsa-vsc73xx-add-support-for-vlan-filtering/20210120-161228 git checkout 1b3778a3f0b1d668f4fa289c82997ebbd2145178 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): drivers/net/dsa/vitesse-vsc73xx-core.c: In function 'vsc73xx_port_set_vlan_unaware': >> drivers/net/dsa/vitesse-vsc73xx-core.c:686:8: warning: conversion from 'long >> unsigned int' to 'u32' {aka 'unsigned int'} changes value from >> '18446744073709535231' to '4294950911' [-Woverflow] 686 |~VSC73XX_MAC_CFG_VLAN_AWR); drivers/net/dsa/vitesse-vsc73xx-core.c:689:8: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709518847' to '4294934527' [-Woverflow] 689 |~VSC73XX_MAC_CFG_VLAN_DBLAWR); drivers/net/dsa/vitesse-vsc73xx-core.c:698:8: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709551613' to '4294967293' [-Woverflow] 698 |~VSC73XX_CAT_DROP_TAGGED_ENA); drivers/net/dsa/vitesse-vsc73xx-core.c:701:8: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709551611' to '4294967291' [-Woverflow] 701 |~VSC73XX_CAT_DROP_UNTAGGED_ENA); drivers/net/dsa/vitesse-vsc73xx-core.c: In function 'vsc73xx_port_set_vlan_aware': drivers/net/dsa/vitesse-vsc73xx-core.c:716:8: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709518847' to '4294934527' [-Woverflow] 716 |~VSC73XX_MAC_CFG_VLAN_DBLAWR); drivers/net/dsa/vitesse-vsc73xx-core.c:719:8: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709551359' to '4294967039' [-Woverflow] 719 |~VSC73XX_CAT_VLAN_MISC_VLAN_TCI_IGNORE_ENA); drivers/net/dsa/vitesse-vsc73xx-core.c:722:8: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709551487' to '4294967167' [-Woverflow] 722 |~VSC73XX_CAT_VLAN_MISC_VLAN_KEEP_TAG_ENA); drivers/net/dsa/vitesse-vsc73xx-core.c:725:8: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709551613' to '4294967293' [-Woverflow] 725 |~VSC73XX_CAT_DROP_TAGGED_ENA); drivers/net/dsa/vitesse-vsc73xx-core.c:734:8: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709551607' to '4294967287' [-Woverflow] 734 |~VSC73XX_TXUPDCFG_TX_UNTAGGED_VID_ENA); drivers/net/dsa/vitesse-vsc73xx-core.c: In function 'vsc73xx_port_vlan_add': drivers/net/dsa/vitesse-vsc73xx-core.c:811:9: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709551611' to '4294967291' [-Woverflow] 811 | ~VSC73XX_CAT_DROP_UNTAGGED_ENA); drivers/net/dsa/vitesse-vsc73xx-core.c: In function 'vsc73xx_port_vlan_del': drivers/net/dsa/vitesse-vsc73xx-core.c:848:9: warning: conversion
Re: [PATCH 1/3] Add TX sending hardware timestamp.
Hi Erez, Thank you for the patch! Yet something to improve: [auto build test ERROR on b65054597872ce3aefbc6a666385eabdf9e288da] url: https://github.com/0day-ci/linux/commits/Erez-Geva/Add-sending-TX-hardware-timestamp-for-TC-ETF-Qdisc/20201210-000521 base:b65054597872ce3aefbc6a666385eabdf9e288da config: mips-randconfig-r026-20201209 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 1968804ac726e7674d5de22bc2204b45857da344) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install mips cross compiling tool for clang build # apt-get install binutils-mips-linux-gnu # https://github.com/0day-ci/linux/commit/8a8f634bc74db16dc551cfcf3b63c1183f98eaac git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Erez-Geva/Add-sending-TX-hardware-timestamp-for-TC-ETF-Qdisc/20201210-000521 git checkout 8a8f634bc74db16dc551cfcf3b63c1183f98eaac # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=mips If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): >> net/core/sock.c:2383:7: error: use of undeclared identifier 'SCM_HW_TXTIME'; >> did you mean 'SOCK_HW_TXTIME'? case SCM_HW_TXTIME: ^ SOCK_HW_TXTIME include/net/sock.h:862:2: note: 'SOCK_HW_TXTIME' declared here SOCK_HW_TXTIME, ^ 1 error generated. vim +2383 net/core/sock.c 2351 2352 int __sock_cmsg_send(struct sock *sk, struct msghdr *msg, struct cmsghdr *cmsg, 2353 struct sockcm_cookie *sockc) 2354 { 2355 u32 tsflags; 2356 2357 switch (cmsg->cmsg_type) { 2358 case SO_MARK: 2359 if (!ns_capable(sock_net(sk)->user_ns, CAP_NET_ADMIN)) 2360 return -EPERM; 2361 if (cmsg->cmsg_len != CMSG_LEN(sizeof(u32))) 2362 return -EINVAL; 2363 sockc->mark = *(u32 *)CMSG_DATA(cmsg); 2364 break; 2365 case SO_TIMESTAMPING_OLD: 2366 if (cmsg->cmsg_len != CMSG_LEN(sizeof(u32))) 2367 return -EINVAL; 2368 2369 tsflags = *(u32 *)CMSG_DATA(cmsg); 2370 if (tsflags & ~SOF_TIMESTAMPING_TX_RECORD_MASK) 2371 return -EINVAL; 2372 2373 sockc->tsflags &= ~SOF_TIMESTAMPING_TX_RECORD_MASK; 2374 sockc->tsflags |= tsflags; 2375 break; 2376 case SCM_TXTIME: 2377 if (!sock_flag(sk, SOCK_TXTIME)) 2378 return -EINVAL; 2379 if (cmsg->cmsg_len != CMSG_LEN(sizeof(u64))) 2380 return -EINVAL; 2381 sockc->transmit_time = get_unaligned((u64 *)CMSG_DATA(cmsg)); 2382 break; > 2383 case SCM_HW_TXTIME: 2384 if (!sock_flag(sk, SOCK_HW_TXTIME)) 2385 return -EINVAL; 2386 if (cmsg->cmsg_len != CMSG_LEN(sizeof(u64))) 2387 return -EINVAL; 2388 sockc->transmit_hw_time = get_unaligned((u64 *)CMSG_DATA(cmsg)); 2389 break; 2390 /* SCM_RIGHTS and SCM_CREDENTIALS are semantically in SOL_UNIX. */ 2391 case SCM_RIGHTS: 2392 case SCM_CREDENTIALS: 2393 break; 2394 default: 2395 return -EINVAL; 2396 } 2397 return 0; 2398 } 2399 EXPORT_SYMBOL(__sock_cmsg_send); 2400 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [PATCH] net: bonding: retrieve device statistics under RTNL, not RCU
Hi Vladimir, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.10-rc7 next-20201209] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Vladimir-Oltean/net-bonding-retrieve-device-statistics-under-RTNL-not-RCU/20201201-025343 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git b65054597872ce3aefbc6a666385eabdf9e288da config: mips-randconfig-r026-20201209 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 1968804ac726e7674d5de22bc2204b45857da344) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install mips cross compiling tool for clang build # apt-get install binutils-mips-linux-gnu # https://github.com/0day-ci/linux/commit/ae1fadfd6122065f2a211de176290d184fda525a git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Vladimir-Oltean/net-bonding-retrieve-device-statistics-under-RTNL-not-RCU/20201201-025343 git checkout ae1fadfd6122065f2a211de176290d184fda525a # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=mips If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/net/bonding/bond_main.c:3698:12: warning: unused function >> 'bond_get_lowest_level_rcu' static int bond_get_lowest_level_rcu(struct net_device ^ fatal error: error in backend: Nested variants found in inline asm string: ' .set push .set mips64r2 .if ( 0x00 ) != -1)) 0x00 ) != -1)) : ($( static struct ftrace_branch_data __attribute__((__aligned__(4))) __attribute__((__section__("_ftrace_branch"))) __if_trace = $( .func = __func__, .file = "arch/mips/include/asm/atomic.h", .line = 153, $); 0x00 ) != -1)) : $))) ) && ( 0 ); .set push; .set mips64r2; .rept 1; sync 0x00; .endr; .set pop; .else; ; .endif 1: ll $0, $1 # atomic_add addu $0, $2 sc $0, $1 beqz $0, 1b .set pop ' clang-12: error: clang frontend command failed with exit code 70 (use -v to see invocation) clang version 12.0.0 (git://gitmirror/llvm_project 1968804ac726e7674d5de22bc2204b45857da344) Target: mipsel-unknown-linux-gnu Thread model: posix InstalledDir: /opt/cross/clang-1968804ac7/bin clang-12: note: diagnostic msg: Makefile arch drivers include kernel scripts source usr vim +/bond_get_lowest_level_rcu +3698 drivers/net/bonding/bond_main.c fe30937b65354c Eric Dumazet 2016-03-17 3696 b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3697 #ifdef CONFIG_LOCKDEP b3e80d44f5b1b4 Taehee Yoo 2020-02-15 @3698 static int bond_get_lowest_level_rcu(struct net_device *dev) b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3699 { b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3700struct net_device *ldev, *next, *now, *dev_stack[MAX_NEST_DEV + 1]; b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3701struct list_head *niter, *iter, *iter_stack[MAX_NEST_DEV + 1]; b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3702int cur = 0, max = 0; b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3703 b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3704now = dev; b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3705iter = &dev->adj_list.lower; b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3706 b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3707while (1) { b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3708next = NULL; b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3709while (1) { b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3710ldev = netdev_next_lower_dev_rcu(now, &iter); b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3711if (!ldev) b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3712break; b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3713 b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3714next = ldev; b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3715niter = &ldev->adj_list.lower; b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3716dev_stack[cur] = now; b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3717 iter_stack[cur++] = iter; b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3718if (max <= cur) b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3719max = cur; b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3720break; b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3721} b3e80d44f5b1b4 Taehee Yoo 2020-02-15 3722 b3e80d44f5b1b4 T
Re: [PATCH v2 1/2] net: dsa: lantiq: allow to use all GPHYs on xRX300 and xRX330
Hi Aleksander, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on robh/for-next] [also build test WARNING on net-next/master net/master linus/master sparc-next/master v5.10-rc7 next-20201209] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Aleksander-Jan-Bajkowski/net-dsa-lantiq-add-support-for-xRX300-and-xRX330/20201206-213318 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next config: parisc-randconfig-r033-20201209 (attached as .config) compiler: hppa-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/3a3400f9d3cd41f2b72cd741f208a70fca7fe93f git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Aleksander-Jan-Bajkowski/net-dsa-lantiq-add-support-for-xRX300-and-xRX330/20201206-213318 git checkout 3a3400f9d3cd41f2b72cd741f208a70fca7fe93f # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=parisc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): In file included from include/linux/kasan-checks.h:5, from include/asm-generic/rwonce.h:26, from ./arch/parisc/include/generated/asm/rwonce.h:1, from include/linux/compiler.h:232, from include/linux/err.h:5, from include/linux/clk.h:12, from drivers/net/dsa/lantiq_gswip.c:28: drivers/net/dsa/lantiq_gswip.c: In function 'gswip_xrx300_phylink_validate': drivers/net/dsa/lantiq_gswip.c:1495:35: warning: unused variable 'mask' [-Wunused-variable] 1495 | __ETHTOOL_DECLARE_LINK_MODE_MASK(mask) = { 0, }; | ^~~~ include/linux/types.h:11:16: note: in definition of macro 'DECLARE_BITMAP' 11 | unsigned long name[BITS_TO_LONGS(bits)] |^~~~ drivers/net/dsa/lantiq_gswip.c:1495:2: note: in expansion of macro '__ETHTOOL_DECLARE_LINK_MODE_MASK' 1495 | __ETHTOOL_DECLARE_LINK_MODE_MASK(mask) = { 0, }; | ^~~~ drivers/net/dsa/lantiq_gswip.c: At top level: >> drivers/net/dsa/lantiq_gswip.c:2068:9: warning: initialization discards >> 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 2068 | .ops = &gswip_xrx200_switch_ops, | ^ drivers/net/dsa/lantiq_gswip.c:2074:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 2074 | .ops = &gswip_xrx300_switch_ops, | ^ drivers/net/dsa/lantiq_gswip.c:1741:34: warning: 'xway_gphy_match' defined but not used [-Wunused-const-variable=] 1741 | static const struct of_device_id xway_gphy_match[] = { | ^~~ vim +/const +2068 drivers/net/dsa/lantiq_gswip.c 2064 2065 static const struct gswip_hw_info gswip_xrx200 = { 2066 .max_ports = 7, 2067 .cpu_port = 6, > 2068 .ops = &gswip_xrx200_switch_ops, 2069 }; 2070 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [PATCH net-next] inet_ecn: Use csum16_add() helper for IP_ECN_set_* helpers
Hi "Toke, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Toke-H-iland-J-rgensen/inet_ecn-Use-csum16_add-helper-for-IP_ECN_set_-helpers/20201210-190846 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git a7105e3472bf6bb3099d1293ea7d70e7783aa582 config: i386-randconfig-s001-20201209 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.3-179-ga00755aa-dirty # https://github.com/0day-ci/linux/commit/fbed6705f871b8eb4e522c874927ac8e57c8889b git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Toke-H-iland-J-rgensen/inet_ecn-Use-csum16_add-helper-for-IP_ECN_set_-helpers/20201210-190846 git checkout fbed6705f871b8eb4e522c874927ac8e57c8889b # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot "sparse warnings: (new ones prefixed by >>)" net/sched/sch_choke.c: note: in included file: >> include/net/inet_ecn.h:97:21: sparse: sparse: restricted __be16 degrades to >> integer include/net/inet_ecn.h:97:37: sparse: sparse: restricted __be16 degrades to integer >> include/net/inet_ecn.h:99:45: sparse: sparse: incorrect type in argument 2 >> (different base types) @@ expected restricted __be16 [usertype] addend >> @@ got unsigned short [assigned] [usertype] check_add @@ include/net/inet_ecn.h:99:45: sparse: expected restricted __be16 [usertype] addend include/net/inet_ecn.h:99:45: sparse: got unsigned short [assigned] [usertype] check_add >> include/net/inet_ecn.h:97:21: sparse: sparse: restricted __be16 degrades to >> integer include/net/inet_ecn.h:97:37: sparse: sparse: restricted __be16 degrades to integer >> include/net/inet_ecn.h:99:45: sparse: sparse: incorrect type in argument 2 >> (different base types) @@ expected restricted __be16 [usertype] addend >> @@ got unsigned short [assigned] [usertype] check_add @@ include/net/inet_ecn.h:99:45: sparse: expected restricted __be16 [usertype] addend include/net/inet_ecn.h:99:45: sparse: got unsigned short [assigned] [usertype] check_add -- net/sched/sch_sfb.c: note: in included file: >> include/net/inet_ecn.h:97:21: sparse: sparse: restricted __be16 degrades to >> integer include/net/inet_ecn.h:97:37: sparse: sparse: restricted __be16 degrades to integer >> include/net/inet_ecn.h:99:45: sparse: sparse: incorrect type in argument 2 >> (different base types) @@ expected restricted __be16 [usertype] addend >> @@ got unsigned short [assigned] [usertype] check_add @@ include/net/inet_ecn.h:99:45: sparse: expected restricted __be16 [usertype] addend include/net/inet_ecn.h:99:45: sparse: got unsigned short [assigned] [usertype] check_add -- net/sched/sch_codel.c: note: in included file (through include/net/codel.h): >> include/net/inet_ecn.h:97:21: sparse: sparse: restricted __be16 degrades to >> integer include/net/inet_ecn.h:97:37: sparse: sparse: restricted __be16 degrades to integer >> include/net/inet_ecn.h:99:45: sparse: sparse: incorrect type in argument 2 >> (different base types) @@ expected restricted __be16 [usertype] addend >> @@ got unsigned short [assigned] [usertype] check_add @@ include/net/inet_ecn.h:99:45: sparse: expected restricted __be16 [usertype] addend include/net/inet_ecn.h:99:45: sparse: got unsigned short [assigned] [usertype] check_add >> include/net/inet_ecn.h:97:21: sparse: sparse: restricted __be16 degrades to >> integer include/net/inet_ecn.h:97:37: sparse: sparse: restricted __be16 degrades to integer >> include/net/inet_ecn.h:99:45: sparse: sparse: incorrect type in argument 2 >> (different base types) @@ expected restricted __be16 [usertype] addend >> @@ got unsigned short [assigned] [usertype] check_add @@ include/net/inet_ecn.h:99:45: sparse: expected restricted __be16 [usertype] addend include/net/inet_ecn.h:99:45: sparse: got unsigned short [assigned] [usertype] check_add >> include/net/inet_ecn.h:97:21: sparse: sparse: restricted __be16 degrades to >> integer include/net/inet_ecn.h:97:37: sparse: sparse: restricted __be16 degrades to integer >> include/net/inet_ecn.h:99:45: sparse: sparse: incorrect type in argument 2 >> (different base types) @@ expected restricted __be16 [usertype] addend >> @@ got unsigned short [assigned] [usertype] check_add @@ include/net/inet_ecn.h:99:45: sparse: expected restr
Re: [PATCH net-next v2] inet_ecn: Use csum16_add() helper for IP_ECN_set_* helpers
Hi "Toke, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Toke-H-iland-J-rgensen/inet_ecn-Use-csum16_add-helper-for-IP_ECN_set_-helpers/20201211-071305 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 51e13685bd93654e0e9b2559c8e103d6545ddf95 config: i386-randconfig-s001-20201209 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.3-179-ga00755aa-dirty # https://github.com/0day-ci/linux/commit/30ca3d0f48b3d72f9ca0a3509eb63956484d02ad git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Toke-H-iland-J-rgensen/inet_ecn-Use-csum16_add-helper-for-IP_ECN_set_-helpers/20201211-071305 git checkout 30ca3d0f48b3d72f9ca0a3509eb63956484d02ad # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot "sparse warnings: (new ones prefixed by >>)" net/sched/sch_fq.c: note: in included file (through include/net/tcp.h): include/net/inet_ecn.h:97:21: sparse: sparse: restricted __be16 degrades to integer include/net/inet_ecn.h:97:37: sparse: sparse: restricted __be16 degrades to integer >> include/net/inet_ecn.h:97:19: sparse: sparse: incorrect type in assignment >> (different base types) @@ expected restricted __be16 [usertype] >> check_add @@ got int @@ include/net/inet_ecn.h:97:19: sparse: expected restricted __be16 [usertype] check_add include/net/inet_ecn.h:97:19: sparse: got int -- net/sched/sch_sfq.c: note: in included file (through include/net/red.h): include/net/inet_ecn.h:97:21: sparse: sparse: restricted __be16 degrades to integer include/net/inet_ecn.h:97:37: sparse: sparse: restricted __be16 degrades to integer >> include/net/inet_ecn.h:97:19: sparse: sparse: incorrect type in assignment >> (different base types) @@ expected restricted __be16 [usertype] >> check_add @@ got int @@ include/net/inet_ecn.h:97:19: sparse: expected restricted __be16 [usertype] check_add include/net/inet_ecn.h:97:19: sparse: got int include/net/inet_ecn.h:97:21: sparse: sparse: restricted __be16 degrades to integer include/net/inet_ecn.h:97:37: sparse: sparse: restricted __be16 degrades to integer >> include/net/inet_ecn.h:97:19: sparse: sparse: incorrect type in assignment >> (different base types) @@ expected restricted __be16 [usertype] >> check_add @@ got int @@ include/net/inet_ecn.h:97:19: sparse: expected restricted __be16 [usertype] check_add include/net/inet_ecn.h:97:19: sparse: got int include/net/inet_ecn.h:97:21: sparse: sparse: restricted __be16 degrades to integer include/net/inet_ecn.h:97:37: sparse: sparse: restricted __be16 degrades to integer >> include/net/inet_ecn.h:97:19: sparse: sparse: incorrect type in assignment >> (different base types) @@ expected restricted __be16 [usertype] >> check_add @@ got int @@ include/net/inet_ecn.h:97:19: sparse: expected restricted __be16 [usertype] check_add include/net/inet_ecn.h:97:19: sparse: got int include/net/inet_ecn.h:97:21: sparse: sparse: restricted __be16 degrades to integer include/net/inet_ecn.h:97:37: sparse: sparse: restricted __be16 degrades to integer >> include/net/inet_ecn.h:97:19: sparse: sparse: incorrect type in assignment >> (different base types) @@ expected restricted __be16 [usertype] >> check_add @@ got int @@ include/net/inet_ecn.h:97:19: sparse: expected restricted __be16 [usertype] check_add include/net/inet_ecn.h:97:19: sparse: got int -- net/sched/sch_sfb.c: note: in included file: include/net/inet_ecn.h:97:21: sparse: sparse: restricted __be16 degrades to integer include/net/inet_ecn.h:97:37: sparse: sparse: restricted __be16 degrades to integer >> include/net/inet_ecn.h:97:19: sparse: sparse: incorrect type in assignment >> (different base types) @@ expected restricted __be16 [usertype] >> check_add @@ got int @@ include/net/inet_ecn.h:97:19: sparse: expected restricted __be16 [usertype] check_add include/net/inet_ecn.h:97:19: sparse: got int -- net/sched/sch_fq_codel.c: note: in included file (through include/net/codel.h): include/net/inet_ecn.h:97:21: sparse: sparse: restricted __be16 degrades to integer include/net/inet_ecn.h:97:37: sparse: sparse: restricted __be16 degrades to integer >> include/net/inet_ecn.h:97:19: sparse: sparse: incorrect type in assignment >> (different base types) @@ expected restricted __be16 [usertype]
Re: [PATCH v5 3/6] net: dsa: microchip: ksz8795: move register offsets and shifts to separate struct
Hi Michael, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] [also build test WARNING on next-20201210] [cannot apply to net/master ipvs/master linus/master v5.10-rc7] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Michael-Grzeschik/microchip-add-support-for-ksz88x3-driver-family/20201207-205945 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git af3f4a85d90218bb59315d591bd2bffa5e646466 config: riscv-randconfig-r003-20201210 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 1968804ac726e7674d5de22bc2204b45857da344) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install riscv cross compiling tool for clang build # apt-get install binutils-riscv64-linux-gnu # https://github.com/0day-ci/linux/commit/db1f7322c8fa2c28587f13ab3eebbb6ee02874b1 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Michael-Grzeschik/microchip-add-support-for-ksz88x3-driver-family/20201207-205945 git checkout db1f7322c8fa2c28587f13ab3eebbb6ee02874b1 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=riscv If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): ~~ ^ arch/riscv/include/asm/mmio.h:87:48: note: expanded from macro 'readb_cpu' #define readb_cpu(c)({ u8 __r = __raw_readb(c); __r; }) ^ In file included from drivers/net/dsa/microchip/ksz8795.c:11: In file included from include/linux/gpio.h:62: In file included from include/asm-generic/gpio.h:11: In file included from include/linux/gpio/driver.h:7: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:13: In file included from arch/riscv/include/asm/io.h:149: include/asm-generic/io.h:564:9: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] return inw(addr); ^ arch/riscv/include/asm/io.h:56:76: note: expanded from macro 'inw' #define inw(c) ({ u16 __v; __io_pbr(); __v = readw_cpu((void*)(PCI_IOBASE + (c))); __io_par(__v); __v; }) ~~ ^ arch/riscv/include/asm/mmio.h:88:76: note: expanded from macro 'readw_cpu' #define readw_cpu(c)({ u16 __r = le16_to_cpu((__force __le16)__raw_readw(c)); __r; }) ^ include/uapi/linux/byteorder/little_endian.h:36:51: note: expanded from macro '__le16_to_cpu' #define __le16_to_cpu(x) ((__force __u16)(__le16)(x)) ^ In file included from drivers/net/dsa/microchip/ksz8795.c:11: In file included from include/linux/gpio.h:62: In file included from include/asm-generic/gpio.h:11: In file included from include/linux/gpio/driver.h:7: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:13: In file included from arch/riscv/include/asm/io.h:149: include/asm-generic/io.h:572:9: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] return inl(addr); ^ arch/riscv/include/asm/io.h:57:76: note: expanded from macro 'inl' #define inl(c) ({ u32 __v; __io_pbr(); __v = readl_cpu((void*)(PCI_IOBASE + (c))); __io_par(__v); __v; }) ~~ ^ arch/riscv/include/asm/mmio.h:89:76: note: expanded from macro 'readl_cpu' #define readl_cpu(c)({ u32 __r = le32_to_cpu((__force __le32)__raw_readl(c)); __r; }) ^ include/uapi/linux/byteorder/little_endian.h:34:51: note: expanded from macro '__le32_to_cpu' #define __le32_to_cpu(x) ((__force __u32)(__le32)(x)) ^ In file included from drivers/net/dsa/microchip/ksz8795.c:11: In file included from include/linux/gpio.h:62: In file included from include/asm-generic/gpio.h:11: In file included from
Re: [PATCH net-next 1/4] net: use indirect call helpers for dst_input
Hi Brian, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Brian-Vazquez/net-avoid-indirect-calls-in-dst-functions/20201211-100941 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 51e13685bd93654e0e9b2559c8e103d6545ddf95 config: x86_64-randconfig-a011-20201209 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/f63e8ffacedd4f9e322d6deaf20adacf4c9e3c87 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Brian-Vazquez/net-avoid-indirect-calls-in-dst-functions/20201211-100941 git checkout f63e8ffacedd4f9e322d6deaf20adacf4c9e3c87 # save the attached .config to linux build tree make W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>, old ones prefixed by <<): >> ERROR: modpost: "ip_local_deliver" [net/decnet/decnet.ko] undefined! --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [PATCH net-next 2/4] net: use indirect call helpers for dst_output
Hi Brian, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Brian-Vazquez/net-avoid-indirect-calls-in-dst-functions/20201211-100941 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 51e13685bd93654e0e9b2559c8e103d6545ddf95 config: x86_64-randconfig-a011-20201209 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/fdc06a361d26c1fda6387e9ce0ac220cbcc1b32a git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Brian-Vazquez/net-avoid-indirect-calls-in-dst-functions/20201211-100941 git checkout fdc06a361d26c1fda6387e9ce0ac220cbcc1b32a # save the attached .config to linux build tree make W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>, old ones prefixed by <<): >> ERROR: modpost: "ip6_output" [net/decnet/decnet.ko] undefined! ERROR: modpost: "ip_local_deliver" [net/decnet/decnet.ko] undefined! >> ERROR: modpost: "ip_output" [net/decnet/decnet.ko] undefined! --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [PATCH net-next] GTP: add support for flow based tunneling API
Hi Pravin, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Pravin-B-Shelar/GTP-add-support-for-flow-based-tunneling-API/20201211-150317 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 91163f82143630a9629a8bf0227d49173697c69c config: x86_64-randconfig-a006-20201209 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 5ff35356f1af2bb92785b38c657463924d9ec386) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # https://github.com/0day-ci/linux/commit/aaf7f4d49a6f3be16634aae4d0a84ed96f50e70c git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Pravin-B-Shelar/GTP-add-support-for-flow-based-tunneling-API/20201211-150317 git checkout aaf7f4d49a6f3be16634aae4d0a84ed96f50e70c # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): In file included from :1: >> ./usr/include/linux/gtp.h:42:2: error: unknown type name '__u8' __u8ver; ^ ./usr/include/linux/gtp.h:43:2: error: unknown type name '__u8' __u8flags; ^ ./usr/include/linux/gtp.h:44:2: error: unknown type name '__u8' __u8type; ^ 3 errors generated. --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [net PATCH] tcp: Mark fastopen SYN packet as lost when receiving ICMP_TOOBIG/ICMP_FRAG_NEEDED
Hi Alexander, Thank you for the patch! Yet something to improve: [auto build test ERROR on net/master] url: https://github.com/0day-ci/linux/commits/Alexander-Duyck/tcp-Mark-fastopen-SYN-packet-as-lost-when-receiving-ICMP_TOOBIG-ICMP_FRAG_NEEDED/20201211-100032 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git d9838b1d39283c1200c13f9076474c7624b8ec34 config: sh-allmodconfig (attached as .config) compiler: sh4-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/01abda6be2a196620ae2057c3e654edc82beb144 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Alexander-Duyck/tcp-Mark-fastopen-SYN-packet-as-lost-when-receiving-ICMP_TOOBIG-ICMP_FRAG_NEEDED/20201211-100032 git checkout 01abda6be2a196620ae2057c3e654edc82beb144 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>, old ones prefixed by <<): >> ERROR: modpost: "tcp_mark_syn_lost" [net/ipv6/ipv6.ko] undefined! ERROR: modpost: "clk_set_min_rate" [sound/soc/atmel/snd-soc-mchp-spdifrx.ko] undefined! ERROR: modpost: "__delay" [drivers/net/mdio/mdio-cavium.ko] undefined! --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [PATCH net-next] GTP: add support for flow based tunneling API
Hi Pravin, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Pravin-B-Shelar/GTP-add-support-for-flow-based-tunneling-API/20201211-150317 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 91163f82143630a9629a8bf0227d49173697c69c config: x86_64-randconfig-r023-20201209 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/aaf7f4d49a6f3be16634aae4d0a84ed96f50e70c git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Pravin-B-Shelar/GTP-add-support-for-flow-based-tunneling-API/20201211-150317 git checkout aaf7f4d49a6f3be16634aae4d0a84ed96f50e70c # save the attached .config to linux build tree make W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): In file included from :32: >> ./usr/include/linux/gtp.h:42:2: error: unknown type name '__u8' 42 | __u8ver; | ^~~~ ./usr/include/linux/gtp.h:43:2: error: unknown type name '__u8' 43 | __u8flags; | ^~~~ ./usr/include/linux/gtp.h:44:2: error: unknown type name '__u8' 44 | __u8type; | ^~~~ --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [PATCH net-next v2 09/12] gtp: support GRO
Hi Jonas, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Jonas-Bonn/gtp-IPv6-support/20201211-203639 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 91163f82143630a9629a8bf0227d49173697c69c config: mips-randconfig-r026-20201209 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 5ff35356f1af2bb92785b38c657463924d9ec386) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install mips cross compiling tool for clang build # apt-get install binutils-mips-linux-gnu # https://github.com/0day-ci/linux/commit/de5669628a8f684dd7ed378aaf2a997221d243fa git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Jonas-Bonn/gtp-IPv6-support/20201211-203639 git checkout de5669628a8f684dd7ed378aaf2a997221d243fa # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=mips If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/net/gtp.c:402:2: warning: variable 'err' is used uninitialized >> whenever 'if' condition is true if (!ptype) ^~~ include/linux/compiler.h:56:28: note: expanded from macro 'if' #define if(cond, ...) if ( __trace_if_var( , ## __VA_ARGS__) ) ) ^~~ include/linux/compiler.h:58:30: note: expanded from macro '__trace_if_var' #define __trace_if_var(cond) (__builtin_constant_p(cond) (cond) : __trace_if_value(cond)) ^~ drivers/net/gtp.c:413:9: note: uninitialized use occurs here return err; ^~~ drivers/net/gtp.c:402:2: note: remove the 'if' if its condition is always false if (!ptype) ^~~ include/linux/compiler.h:56:23: note: expanded from macro 'if' #define if(cond, ...) if ( __trace_if_var( , ## __VA_ARGS__) ) ) ^ >> drivers/net/gtp.c:396:2: warning: variable 'err' is used uninitialized >> whenever switch default is taken default: ^~~ drivers/net/gtp.c:413:9: note: uninitialized use occurs here return err; ^~~ drivers/net/gtp.c:372:9: note: initialize the variable 'err' to silence this warning int err; ^ = 0 fatal error: error in backend: Nested variants found in inline asm string: ' .set push .set mips64r2 .if ( 0x00 ) != -1)) 0x00 ) != -1)) : ($( static struct ftrace_branch_data __attribute__((__aligned__(4))) __attribute__((__section__("_ftrace_branch"))) __if_trace = $( .func = __func__, .file = "arch/mips/include/asm/atomic.h", .line = 153, $); 0x00 ) != -1)) : $))) ) && ( 0 ); .set push; .set mips64r2; .rept 1; sync 0x00; .endr; .set pop; .else; ; .endif 1: ll $1, $2 # atomic_fetch_add addu $0, $1, $3 sc $0, $2 beqz $0, 1b .set pop move $0, $1 ' clang-12: error: clang frontend command failed with exit code 70 (use -v to see invocation) clang version 12.0.0 (git://gitmirror/llvm_project 5ff35356f1af2bb92785b38c657463924d9ec386) Target: mipsel-unknown-linux-gnu Thread model: posix InstalledDir: /opt/cross/clang-5ff35356f1/bin clang-12: note: diagnostic msg: Makefile arch drivers include kernel scripts source usr vim +402 drivers/net/gtp.c 363 364 static int gtp_gro_complete(struct sock *sk, struct sk_buff * skb, int nhoff) 365 { 366 size_t hdrlen; 367 char* gtphdr = skb->data + nhoff; 368 u8 version; 369 __be16 type; 370 struct packet_offload *ptype; 371 uint8_t ipver; 372 int err; 373 374 version = *gtphdr >> 5; 375 switch (version) { 376 case GTP_V0: 377 hdrlen = sizeof(struct gtp0_header); 378 break; 379 case GTP_V1: 380 hdrlen = sizeof(struct gtp1_header); 381 if (*gtphdr & GTP1_F_MASK) 382 hdrlen += 4; 383 break; 384 } 385 386 skb_set_inner_network_header(skb, nhoff + hdrlen); 387 388 ipver = inner_ip_hdr(skb)->version; 389 switch (ipver) { 390 case 4: 391 type = cpu_to_be16(ETH_P_IP); 392 break; 393 case 6: 394 type = cpu_to_be16(ETH_P_IPV6); 395 break; > 396 default: 397
Re: [PATCH net-next v2 12/12] gtp: add dst_cache to tunnels
Hi Jonas, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Jonas-Bonn/gtp-IPv6-support/20201211-203639 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 91163f82143630a9629a8bf0227d49173697c69c config: mips-randconfig-r026-20201209 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 5ff35356f1af2bb92785b38c657463924d9ec386) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install mips cross compiling tool for clang build # apt-get install binutils-mips-linux-gnu # https://github.com/0day-ci/linux/commit/a8ea47bc0c1903be018f4d566bb96146c156ddce git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Jonas-Bonn/gtp-IPv6-support/20201211-203639 git checkout a8ea47bc0c1903be018f4d566bb96146c156ddce # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=mips If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All error/warnings (new ones prefixed by >>): drivers/net/gtp.c:471:2: warning: variable 'err' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] if (!ptype) ^~~ include/linux/compiler.h:56:28: note: expanded from macro 'if' #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) ^~~ include/linux/compiler.h:58:30: note: expanded from macro '__trace_if_var' #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) ^~ drivers/net/gtp.c:482:9: note: uninitialized use occurs here return err; ^~~ drivers/net/gtp.c:471:2: note: remove the 'if' if its condition is always false if (!ptype) ^~~ include/linux/compiler.h:56:23: note: expanded from macro 'if' #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) ^ drivers/net/gtp.c:465:2: warning: variable 'err' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized] default: ^~~ drivers/net/gtp.c:482:9: note: uninitialized use occurs here return err; ^~~ drivers/net/gtp.c:441:9: note: initialize the variable 'err' to silence this warning int err; ^ = 0 >> drivers/net/gtp.c:627:8: error: implicit declaration of function >> 'dst_cache_get_ip6' [-Werror,-Wimplicit-function-declaration] dst = dst_cache_get_ip6(dst_cache, saddr); ^ drivers/net/gtp.c:627:8: note: did you mean 'dst_cache_get_ip4'? include/net/dst_cache.h:33:16: note: 'dst_cache_get_ip4' declared here struct rtable *dst_cache_get_ip4(struct dst_cache *dst_cache, __be32 *saddr); ^ >> drivers/net/gtp.c:627:6: warning: incompatible integer to pointer conversion >> assigning to 'struct dst_entry *' from 'int' [-Wint-conversion] dst = dst_cache_get_ip6(dst_cache, saddr); ^ ~~~ >> drivers/net/gtp.c:649:2: error: implicit declaration of function >> 'dst_cache_set_ip6' [-Werror,-Wimplicit-function-declaration] dst_cache_set_ip6(dst_cache, dst, saddr); ^ 3 warnings and 2 errors generated. vim +/dst_cache_get_ip6 +627 drivers/net/gtp.c 615 616 static struct dst_entry *gtp_get_v6_dst(struct sk_buff *skb, 617 struct net_device *dev, 618 struct pdp_ctx *pctx, 619 struct in6_addr *saddr) 620 { 621 const struct sock *sk = pctx->sk; 622 struct dst_entry *dst = NULL; 623 struct dst_cache *dst_cache; 624 struct flowi6 fl6; 625 626 dst_cache = (struct dst_cache *)&pctx->dst_cache; > 627 dst = dst_cache_get_ip6(dst_cache, saddr); 628 if (dst) 629 return dst; 630 631 memset(&fl6, 0, sizeof(fl6)); 632 fl6.flowi6_mark = skb->mark; 633 fl6.flowi6_proto = IPPROTO_UDP; 634 fl6.daddr = pctx->peer_addr; 635 636 dst = ipv6_stub->ipv6_dst_lookup_flow(
Re: [PATCH net-next v2 4/4] net/mlx5e: Support HTB offload
Hi Maxim, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Maxim-Mikityanskiy/HTB-offload/20201211-233216 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 91163f82143630a9629a8bf0227d49173697c69c config: parisc-allyesconfig (attached as .config) compiler: hppa-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/71646f8ea82de5f48f4ea47869dc9de06bdef3bf git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Maxim-Mikityanskiy/HTB-offload/20201211-233216 git checkout 71646f8ea82de5f48f4ea47869dc9de06bdef3bf # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=parisc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): hppa-linux-ld: drivers/net/ethernet/mellanox/mlx5/core/en/qos.o: in function `mlx5e_htb_leaf_to_inner': >> (.text+0x2794): undefined reference to `__xchg_called_with_bad_pointer' hppa-linux-ld: drivers/net/ethernet/mellanox/mlx5/core/en/qos.o: in function `mlx5e_htb_leaf_del_last': (.text+0x2f8c): undefined reference to `__xchg_called_with_bad_pointer' --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [PATCH v1 net-next] net: phy: mchp: Add 1588 support for LAN8814 Quad PHY
Hi Divya, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Divya-Koppera/net-phy-mchp-Add-1588-support-for-LAN8814-Quad-PHY/20201214-205209 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 13458ffe0a953e17587f172a8e5059c243e6850a config: microblaze-randconfig-r006-20201214 (attached as .config) compiler: microblaze-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/d3b83e2903ca90bd2652d828d0e33f0d5559757a git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Divya-Koppera/net-phy-mchp-Add-1588-support-for-LAN8814-Quad-PHY/20201214-205209 git checkout d3b83e2903ca90bd2652d828d0e33f0d5559757a # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=microblaze If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): drivers/net/phy/micrel.c: In function 'lan8814_dequeue_skb': >> drivers/net/phy/micrel.c:429:11: warning: variable 'rc' set but not used >> [-Wunused-but-set-variable] 429 | int len, rc; | ^~ drivers/net/phy/micrel.c: At top level: >> drivers/net/phy/micrel.c:492:13: warning: no previous prototype for >> 'lan8814_handle_ptp_interrupt' [-Wmissing-prototypes] 492 | irqreturn_t lan8814_handle_ptp_interrupt(struct phy_device *phydev) | ^~~~ >> drivers/net/phy/micrel.c:507:13: warning: no previous prototype for >> 'lan8814_handle_interrupt' [-Wmissing-prototypes] 507 | irqreturn_t lan8814_handle_interrupt(struct phy_device *phydev) | ^~~~ drivers/net/phy/micrel.c: In function 'lan8814_ptp_clock_step': >> drivers/net/phy/micrel.c:1911:8: warning: variable 'adjustment_value_lo' set >> but not used [-Wunused-but-set-variable] 1911 |u16 adjustment_value_lo, adjustment_value_hi; |^~~ drivers/net/phy/micrel.c:1926:8: warning: variable 'adjustment_value_lo' set but not used [-Wunused-but-set-variable] 1926 |u16 adjustment_value_lo, adjustment_value_hi; |^~~ drivers/net/phy/micrel.c: In function 'lan8814_txtstamp': >> drivers/net/phy/micrel.c:1750:6: warning: this statement may fall through >> [-Wimplicit-fallthrough=] 1750 | if (is_sync(skb, type)) { | ^ drivers/net/phy/micrel.c:1754:2: note: here 1754 | case HWTSTAMP_TX_ON: | ^~~~ vim +/rc +429 drivers/net/phy/micrel.c 421 422 static void lan8814_dequeue_skb(struct lan8814_ptp *ptp) 423 { 424 struct lan8814_priv *priv = container_of(ptp, struct lan8814_priv, ptp); 425 struct phy_device *phydev = priv->phydev; 426 struct skb_shared_hwtstamps shhwtstamps; 427 struct sk_buff *skb; 428 u8 skb_sig[16]; > 429 int len, rc; 430 u32 reg, cnt; 431 u32 seconds, nsec, seq_id; 432 433 reg = lan8814_read_page_reg(phydev, 5, PTP_CAP_INFO); 434 cnt = PTP_CAP_INFO_TX_TS_CNT_GET_(reg); 435 436 /* FIFO is Empty*/ 437 if (cnt == 0) 438 return; 439 440 len = skb_queue_len(&ptp->tx_queue); 441 if (len < 1) 442 return; 443 444 while (len--) { 445 skb = __skb_dequeue(&ptp->tx_queue); 446 if (!skb) 447 return; 448 449 /* Can't get the signature of the packet, won't ever 450 * be able to have one so let's dequeue the packet. 451 */ 452 if (get_sig(skb, skb_sig) < 0) { 453 kfree_skb(skb); 454 continue; 455 } 456 457 lan8814_ptp_tx_ts_get(phydev, &seconds, &nsec, &seq_id); 458 459 rc = memcmp(skb_sig, &seq_id, sizeof(skb_sig)); 460 461 /* Check if we found the signature we were looking for. */ 462 if (memcmp(skb_sig, &seq_id, sizeof(skb_sig))) { 463 memset(&shhwtstamps, 0, sizeof(shhwtstamps)); 464 shhwtstamps.hwtstamp = ktime_set(seconds, nsec); 465
Re: [PATCH v1 net-next] net: phy: mchp: Add 1588 support for LAN8814 Quad PHY
Hi Divya, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Divya-Koppera/net-phy-mchp-Add-1588-support-for-LAN8814-Quad-PHY/20201214-205209 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 13458ffe0a953e17587f172a8e5059c243e6850a config: s390-allyesconfig (attached as .config) compiler: s390-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/d3b83e2903ca90bd2652d828d0e33f0d5559757a git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Divya-Koppera/net-phy-mchp-Add-1588-support-for-LAN8814-Quad-PHY/20201214-205209 git checkout d3b83e2903ca90bd2652d828d0e33f0d5559757a # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=s390 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): drivers/net/phy/micrel.c: In function 'lan8814_dequeue_skb': >> drivers/net/phy/micrel.c:429:11: warning: variable 'rc' set but not used >> [-Wunused-but-set-variable] 429 | int len, rc; | ^~ drivers/net/phy/micrel.c: At top level: >> drivers/net/phy/micrel.c:492:13: warning: no previous prototype for >> 'lan8814_handle_ptp_interrupt' [-Wmissing-prototypes] 492 | irqreturn_t lan8814_handle_ptp_interrupt(struct phy_device *phydev) | ^~~~ >> drivers/net/phy/micrel.c:507:13: warning: no previous prototype for >> 'lan8814_handle_interrupt' [-Wmissing-prototypes] 507 | irqreturn_t lan8814_handle_interrupt(struct phy_device *phydev) | ^~~~ drivers/net/phy/micrel.c: In function 'lan8814_ptp_clock_step': >> drivers/net/phy/micrel.c:1911:8: warning: variable 'adjustment_value_lo' set >> but not used [-Wunused-but-set-variable] 1911 |u16 adjustment_value_lo, adjustment_value_hi; |^~~ drivers/net/phy/micrel.c:1926:8: warning: variable 'adjustment_value_lo' set but not used [-Wunused-but-set-variable] 1926 |u16 adjustment_value_lo, adjustment_value_hi; |^~~ drivers/net/phy/micrel.c: In function 'lan8814_txtstamp': >> drivers/net/phy/micrel.c:1750:6: warning: this statement may fall through >> [-Wimplicit-fallthrough=] 1750 | if (is_sync(skb, type)) { | ^ drivers/net/phy/micrel.c:1754:2: note: here 1754 | case HWTSTAMP_TX_ON: | ^~~~ In file included from include/linux/bitmap.h:9, from include/linux/cpumask.h:12, from include/linux/smp.h:13, from include/linux/lockdep.h:14, from include/linux/spinlock.h:59, from include/linux/mmzone.h:8, from include/linux/gfp.h:6, from include/linux/umh.h:4, from include/linux/kmod.h:9, from include/linux/module.h:16, from drivers/net/phy/micrel.c:24: In function 'memcmp', inlined from 'lan8814_dequeue_skb' at drivers/net/phy/micrel.c:459:8, inlined from 'lan8814_get_tx_ts' at drivers/net/phy/micrel.c:485:3, inlined from 'lan8814_handle_ptp_interrupt' at drivers/net/phy/micrel.c:502:2: include/linux/string.h:436:4: error: call to '__read_overflow2' declared with attribute error: detected read beyond size of object passed as 2nd parameter 436 |__read_overflow2(); |^~ vim +/rc +429 drivers/net/phy/micrel.c 421 422 static void lan8814_dequeue_skb(struct lan8814_ptp *ptp) 423 { 424 struct lan8814_priv *priv = container_of(ptp, struct lan8814_priv, ptp); 425 struct phy_device *phydev = priv->phydev; 426 struct skb_shared_hwtstamps shhwtstamps; 427 struct sk_buff *skb; 428 u8 skb_sig[16]; > 429 int len, rc; 430 u32 reg, cnt; 431 u32 seconds, nsec, seq_id; 432 433 reg = lan8814_read_page_reg(phydev, 5, PTP_CAP_INFO); 434 cnt = PTP_CAP_INFO_TX_TS_CNT_GET_(reg); 435 436 /* FIFO is Empty*/ 437 if (cnt == 0) 438 return; 439 440 len = skb_queue_len(&ptp->tx_queue); 441 if (len < 1) 442 return; 443 4
Re: [PATCH net-next v4] udp:allow UDP cmsghdrs through io_uring
Hi Victor, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Victor-Stewart/udp-allow-UDP-cmsghdrs-through-io_uring/20201217-020451 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 3db1a3fa98808aa90f95ec3e0fa2fc7abf28f5c9 config: riscv-randconfig-r031-20201216 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 71601d2ac9954cb59c443cb3ae442cb106df35d4) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install riscv cross compiling tool for clang build # apt-get install binutils-riscv64-linux-gnu # https://github.com/0day-ci/linux/commit/6cce2a0155c3ee2a1550cb3d5e434cc85f055a60 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Victor-Stewart/udp-allow-UDP-cmsghdrs-through-io_uring/20201217-020451 git checkout 6cce2a0155c3ee2a1550cb3d5e434cc85f055a60 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=riscv If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): /tmp/leds-blinkm-655475.s: Assembler messages: >> /tmp/leds-blinkm-655475.s:590: Error: unrecognized opcode `zext.b s7,a0' >> /tmp/leds-blinkm-655475.s:614: Error: unrecognized opcode `zext.b a0,a0' >> /tmp/leds-blinkm-655475.s:667: Error: unrecognized opcode `zext.b a2,s2' /tmp/leds-blinkm-655475.s:750: Error: unrecognized opcode `zext.b a2,s2' /tmp/leds-blinkm-655475.s:833: Error: unrecognized opcode `zext.b a2,s2' clang-12: error: assembler command failed with exit code 1 (use -v to see invocation) --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [PATCH 21/21] vdpasim: control virtqueue support
Hi Jason, I love your patch! Perhaps something to improve: [auto build test WARNING on vhost/linux-next] [also build test WARNING on linus/master v5.10] [cannot apply to next-20201217] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Jason-Wang/Control-VQ-support-in-vDPA/20201216-150025 base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next config: x86_64-randconfig-a014-20201217 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project cee1e7d14f4628d6174b33640d502bff3b54ae45) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # https://github.com/0day-ci/linux/commit/157796e1c075942914d2096899f4a9b7cf824373 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Jason-Wang/Control-VQ-support-in-vDPA/20201216-150025 git checkout 157796e1c075942914d2096899f4a9b7cf824373 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/vdpa/vdpa_sim/vdpa_sim.c:204:21: warning: no previous prototype for >> function 'vdpasim_handle_ctrl_mac' [-Wmissing-prototypes] virtio_net_ctrl_ack vdpasim_handle_ctrl_mac(struct vdpasim *vdpasim, ^ drivers/vdpa/vdpa_sim/vdpa_sim.c:204:1: note: declare 'static' if the function is not intended to be used outside of this translation unit virtio_net_ctrl_ack vdpasim_handle_ctrl_mac(struct vdpasim *vdpasim, ^ static >> drivers/vdpa/vdpa_sim/vdpa_sim.c:731:5: warning: no previous prototype for >> function 'vdpasim_set_group_asid' [-Wmissing-prototypes] int vdpasim_set_group_asid(struct vdpa_device *vdpa, unsigned int group, ^ drivers/vdpa/vdpa_sim/vdpa_sim.c:731:1: note: declare 'static' if the function is not intended to be used outside of this translation unit int vdpasim_set_group_asid(struct vdpa_device *vdpa, unsigned int group, ^ static drivers/vdpa/vdpa_sim/vdpa_sim.c:101:19: warning: unused function 'vdpasim16_to_cpu' [-Wunused-function] static inline u16 vdpasim16_to_cpu(struct vdpasim *vdpasim, __virtio16 val) ^ 3 warnings generated. vim +/vdpasim_handle_ctrl_mac +204 drivers/vdpa/vdpa_sim/vdpa_sim.c 203 > 204 virtio_net_ctrl_ack vdpasim_handle_ctrl_mac(struct vdpasim *vdpasim, 205 u8 cmd) 206 { 207 struct vdpasim_virtqueue *cvq = &vdpasim->vqs[2]; 208 virtio_net_ctrl_ack status = VIRTIO_NET_ERR; 209 size_t read; 210 211 switch (cmd) { 212 case VIRTIO_NET_CTRL_MAC_ADDR_SET: 213 read = vringh_iov_pull_iotlb(&cvq->vring, &cvq->in_iov, 214 (void *)vdpasim->config.mac, 215 ETH_ALEN); 216 if (read == ETH_ALEN) 217 status = VIRTIO_NET_OK; 218 break; 219 default: 220 break; 221 } 222 223 return status; 224 } 225 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [PATCH v2 net-next] net: phy: mchp: Add 1588 support for LAN8814 Quad PHY
Hi Divya, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Divya-Koppera/net-phy-mchp-Add-1588-support-for-LAN8814-Quad-PHY/20201215-020140 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 13458ffe0a953e17587f172a8e5059c243e6850a config: powerpc-randconfig-r025-20201217 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project cee1e7d14f4628d6174b33640d502bff3b54ae45) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install powerpc cross compiling tool for clang build # apt-get install binutils-powerpc-linux-gnu # https://github.com/0day-ci/linux/commit/d92cad561db30d2e4d3e70352b2f715b5c775fe8 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Divya-Koppera/net-phy-mchp-Add-1588-support-for-LAN8814-Quad-PHY/20201215-020140 git checkout d92cad561db30d2e4d3e70352b2f715b5c775fe8 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/net/phy/micrel.c:1641:6: warning: variable 'rxcfg' is used >> uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] if (lan8814->hwts_rx_en && (lan8814->layer & PTP_CLASS_L2)) ^~ drivers/net/phy/micrel.c:1657:66: note: uninitialized use occurs here lan8814_write_page_reg(lan8814->phydev, 5, PTP_RX_PARSE_CONFIG, rxcfg); ^ drivers/net/phy/micrel.c:1641:2: note: remove the 'if' if its condition is always true if (lan8814->hwts_rx_en && (lan8814->layer & PTP_CLASS_L2)) ^~~ >> drivers/net/phy/micrel.c:1641:6: warning: variable 'rxcfg' is used >> uninitialized whenever '&&' condition is false [-Wsometimes-uninitialized] if (lan8814->hwts_rx_en && (lan8814->layer & PTP_CLASS_L2)) ^~~ drivers/net/phy/micrel.c:1657:66: note: uninitialized use occurs here lan8814_write_page_reg(lan8814->phydev, 5, PTP_RX_PARSE_CONFIG, rxcfg); ^ drivers/net/phy/micrel.c:1641:6: note: remove the '&&' if its condition is always true if (lan8814->hwts_rx_en && (lan8814->layer & PTP_CLASS_L2)) ^~ drivers/net/phy/micrel.c:1597:18: note: initialize the variable 'rxcfg' to silence this warning int txcfg, rxcfg; ^ = 0 >> drivers/net/phy/micrel.c:1644:6: warning: variable 'txcfg' is used >> uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] if (lan8814->hwts_tx_en && (lan8814->layer & PTP_CLASS_L2)) ^~ drivers/net/phy/micrel.c:1658:66: note: uninitialized use occurs here lan8814_write_page_reg(lan8814->phydev, 5, PTP_TX_PARSE_CONFIG, txcfg); ^ drivers/net/phy/micrel.c:1644:2: note: remove the 'if' if its condition is always true if (lan8814->hwts_tx_en && (lan8814->layer & PTP_CLASS_L2)) ^~~ >> drivers/net/phy/micrel.c:1644:6: warning: variable 'txcfg' is used >> uninitialized whenever '&&' condition is false [-Wsometimes-uninitialized] if (lan8814->hwts_tx_en && (lan8814->layer & PTP_CLASS_L2)) ^~~ drivers/net/phy/micrel.c:1658:66: note: uninitialized use occurs here lan8814_write_page_reg(lan8814->phydev, 5, PTP_TX_PARSE_CONFIG, txcfg); ^ drivers/net/phy/micrel.c:1644:6: note: remove the '&&' if its condition is always true if (lan8814->hwts_tx_en && (lan8814->layer & PTP_CLASS_L2)) ^~ drivers/net/phy/micrel.c:1597:11: note: initialize the variable 'txcfg&
Re: [PATCH net 1/4] net-sysfs: take the rtnl lock when storing xps_cpus
Hi Antoine, I love your patch! Yet something to improve: [auto build test ERROR on net/master] url: https://github.com/0day-ci/linux/commits/Antoine-Tenart/net-sysfs-fix-race-conditions-in-the-xps-code/20201218-002852 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git 3ae32c07815a24ae12de2e7838d9d429ba31e5e0 config: riscv-randconfig-r014-20201217 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project cee1e7d14f4628d6174b33640d502bff3b54ae45) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install riscv cross compiling tool for clang build # apt-get install binutils-riscv64-linux-gnu # https://github.com/0day-ci/linux/commit/f989c3dcbe4d9abd1c6c48b34f08c6c0cd9d44b3 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Antoine-Tenart/net-sysfs-fix-race-conditions-in-the-xps-code/20201218-002852 git checkout f989c3dcbe4d9abd1c6c48b34f08c6c0cd9d44b3 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=riscv If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot Note: the linux-review/Antoine-Tenart/net-sysfs-fix-race-conditions-in-the-xps-code/20201218-002852 HEAD 563d144b47845dea594b409ecf22914b9797cd1e builds fine. It only hurts bisectibility. All errors (new ones prefixed by >>): /tmp/ics932s401-422897.s: Assembler messages: >> /tmp/ics932s401-422897.s:260: Error: unrecognized opcode `zext.b a1,s11' /tmp/ics932s401-422897.s:362: Error: unrecognized opcode `zext.b a1,s11' /tmp/ics932s401-422897.s:518: Error: unrecognized opcode `zext.b a1,s11' /tmp/ics932s401-422897.s:637: Error: unrecognized opcode `zext.b a1,s11' /tmp/ics932s401-422897.s:774: Error: unrecognized opcode `zext.b a1,s11' /tmp/ics932s401-422897.s:893: Error: unrecognized opcode `zext.b a1,s11' /tmp/ics932s401-422897.s:1021: Error: unrecognized opcode `zext.b a1,s11' >> /tmp/ics932s401-422897.s:1180: Error: unrecognized opcode `zext.b a1,s2' clang-12: error: assembler command failed with exit code 1 (use -v to see invocation) --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [PATCH] ptp: Add clock driver for the OpenCompute TimeCard.
Hi Jonathan, I love your patch! Yet something to improve: [auto build test ERROR on net/master] [also build test ERROR on ipvs/master net-next/master linus/master v5.10-rc6 next-20201201] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Jonathan-Lemon/ptp-Add-clock-driver-for-the-OpenCompute-TimeCard/20201202-045520 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git 14483cbf040fcb38113497161088a1ce8ce5d713 config: sh-allmodconfig (attached as .config) compiler: sh4-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/212c31abce553dfb3146a24086b8a50046097f0d git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Jonathan-Lemon/ptp-Add-clock-driver-for-the-OpenCompute-TimeCard/20201202-045520 git checkout 212c31abce553dfb3146a24086b8a50046097f0d # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): drivers/ptp/ptp_ocp.c: In function 'ptp_ocp_remove': >> drivers/ptp/ptp_ocp.c:374:2: error: implicit declaration of function >> 'pci_iounmap'; did you mean 'pcim_iounmap'? >> [-Werror=implicit-function-declaration] 374 | pci_iounmap(pdev, bp->base); | ^~~ | pcim_iounmap cc1: some warnings being treated as errors vim +374 drivers/ptp/ptp_ocp.c 367 368 static void 369 ptp_ocp_remove(struct pci_dev *pdev) 370 { 371 struct ptp_ocp *bp = pci_get_drvdata(pdev); 372 373 ptp_clock_unregister(bp->ptp); > 374 pci_iounmap(pdev, bp->base); 375 pci_release_regions(pdev); 376 pci_disable_device(pdev); 377 pci_set_drvdata(pdev, NULL); 378 kfree(bp); 379 } 380 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
[net:master 1/3] ERROR: modpost: "__uio_register_device" undefined!
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git master head: 2867e1eac61016f59b3d730e3f7aa488e186e917 commit: 14483cbf040fcb38113497161088a1ce8ce5d713 [1/3] net: broadcom CNIC: requires MMU config: microblaze-randconfig-r011-20201201 (attached as .config) compiler: microblaze-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git/commit/?id=14483cbf040fcb38113497161088a1ce8ce5d713 git remote add net https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git git fetch --no-tags net master git checkout 14483cbf040fcb38113497161088a1ce8ce5d713 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=microblaze If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>, old ones prefixed by <<): >> ERROR: modpost: "__uio_register_device" >> [drivers/net/ethernet/broadcom/cnic.ko] undefined! >> ERROR: modpost: "uio_unregister_device" >> [drivers/net/ethernet/broadcom/cnic.ko] undefined! >> ERROR: modpost: "uio_event_notify" [drivers/net/ethernet/broadcom/cnic.ko] >> undefined! --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [PATCH v5 bpf-next 09/14] bpf: remove hard-coded btf_vmlinux assumption from BPF verifier
Hi Andrii, I love your patch! Yet something to improve: [auto build test ERROR on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Andrii-Nakryiko/Support-BTF-powered-BPF-tracing-programs-for-kernel-modules/20201203-115515 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master config: ia64-defconfig (attached as .config) compiler: ia64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/c0eabf99f8312c12d4c210628360d28bbf915a91 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Andrii-Nakryiko/Support-BTF-powered-BPF-tracing-programs-for-kernel-modules/20201203-115515 git checkout c0eabf99f8312c12d4c210628360d28bbf915a91 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): ia64-linux-ld: kernel/bpf/core.o: in function `bpf_prog_free': >> (.text+0x3d2): undefined reference to `btf_put' --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [PATCH v5 bpf-next 09/14] bpf: remove hard-coded btf_vmlinux assumption from BPF verifier
Hi Andrii, I love your patch! Yet something to improve: [auto build test ERROR on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Andrii-Nakryiko/Support-BTF-powered-BPF-tracing-programs-for-kernel-modules/20201203-115515 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master config: i386-randconfig-s002-20201203 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.3-179-ga00755aa-dirty # https://github.com/0day-ci/linux/commit/c0eabf99f8312c12d4c210628360d28bbf915a91 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Andrii-Nakryiko/Support-BTF-powered-BPF-tracing-programs-for-kernel-modules/20201203-115515 git checkout c0eabf99f8312c12d4c210628360d28bbf915a91 # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): ld: kernel/bpf/core.o: in function `bpf_prog_free': >> kernel/bpf/core.c:2155: undefined reference to `btf_put' vim +2155 kernel/bpf/core.c 2146 2147 /* Free internal BPF program */ 2148 void bpf_prog_free(struct bpf_prog *fp) 2149 { 2150 struct bpf_prog_aux *aux = fp->aux; 2151 2152 if (aux->dst_prog) 2153 bpf_prog_put(aux->dst_prog); 2154 if (aux->attach_btf) > 2155 btf_put(aux->attach_btf); 2156 INIT_WORK(&aux->work, bpf_prog_free_deferred); 2157 schedule_work(&aux->work); 2158 } 2159 EXPORT_SYMBOL_GPL(bpf_prog_free); 2160 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [PATCH net] net/tls: Fix kernel panic when socket is in tls toe mode
Hi Vinay, I love your patch! Perhaps something to improve: [auto build test WARNING on net/master] url: https://github.com/0day-ci/linux/commits/Vinay-Kumar-Yadav/net-tls-Fix-kernel-panic-when-socket-is-in-tls-toe-mode/20201205-051743 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git bbe2ba04c5a92a49db8a42c850a5a2f6481e47eb config: x86_64-randconfig-a014-20201204 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project fc7818f5d6906555cebad2c2e7c313a383b9cb82) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # https://github.com/0day-ci/linux/commit/293ac488f7830f7f2a6d8baa08d4c9240e8cbe38 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Vinay-Kumar-Yadav/net-tls-Fix-kernel-panic-when-socket-is-in-tls-toe-mode/20201205-051743 git checkout 293ac488f7830f7f2a6d8baa08d4c9240e8cbe38 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> net/tls/tls_toe.c:109:4: warning: variable 'err' is uninitialized when used >> here [-Wuninitialized] err |= dev->hash(dev, sk); ^~~ net/tls/tls_toe.c:102:9: note: initialize the variable 'err' to silence this warning int err; ^ = 0 1 warning generated. vim +/err +109 net/tls/tls_toe.c 08700dab816847 Jakub Kicinski 2019-10-03 98 0eb8745e03c9ed Jakub Kicinski 2019-10-03 99 int tls_toe_hash(struct sock *sk) 08700dab816847 Jakub Kicinski 2019-10-03 100 { 08700dab816847 Jakub Kicinski 2019-10-03 101 struct tls_toe_device *dev; 08700dab816847 Jakub Kicinski 2019-10-03 102 int err; 08700dab816847 Jakub Kicinski 2019-10-03 103 08700dab816847 Jakub Kicinski 2019-10-03 104 spin_lock_bh(&device_spinlock); 08700dab816847 Jakub Kicinski 2019-10-03 105 list_for_each_entry(dev, &device_list, dev_list) { 08700dab816847 Jakub Kicinski 2019-10-03 106 if (dev->hash) { 08700dab816847 Jakub Kicinski 2019-10-03 107 kref_get(&dev->kref); 08700dab816847 Jakub Kicinski 2019-10-03 108 spin_unlock_bh(&device_spinlock); 08700dab816847 Jakub Kicinski 2019-10-03 @109 err |= dev->hash(dev, sk); 08700dab816847 Jakub Kicinski 2019-10-03 110 kref_put(&dev->kref, dev->release); 08700dab816847 Jakub Kicinski 2019-10-03 111 spin_lock_bh(&device_spinlock); 08700dab816847 Jakub Kicinski 2019-10-03 112 } 08700dab816847 Jakub Kicinski 2019-10-03 113 } 08700dab816847 Jakub Kicinski 2019-10-03 114 spin_unlock_bh(&device_spinlock); 08700dab816847 Jakub Kicinski 2019-10-03 115 08700dab816847 Jakub Kicinski 2019-10-03 116 if (err) 0eb8745e03c9ed Jakub Kicinski 2019-10-03 117 tls_toe_unhash(sk); 08700dab816847 Jakub Kicinski 2019-10-03 118 return err; 08700dab816847 Jakub Kicinski 2019-10-03 119 } 08700dab816847 Jakub Kicinski 2019-10-03 120 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [PATCH 1/1] ice: fix array overflow on receiving too many fragments for a packet
Hi Xiaohui, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on tnguy-next-queue/dev-queue] [also build test WARNING on v5.10-rc7 next-20201204] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Xiaohui-Zhang/ice-fix-array-overflow-on-receiving-too-many-fragments-for-a-packet/20201207-141033 base: https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue.git dev-queue config: riscv-allyesconfig (attached as .config) compiler: riscv64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/b3906f69dcad641195cbf1ce9af3e9105a6f72e1 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Xiaohui-Zhang/ice-fix-array-overflow-on-receiving-too-many-fragments-for-a-packet/20201207-141033 git checkout b3906f69dcad641195cbf1ce9af3e9105a6f72e1 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=riscv If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): In file included from include/vdso/processor.h:10, from arch/riscv/include/asm/processor.h:11, from include/linux/prefetch.h:15, from drivers/net/ethernet/intel/ice/ice_txrx.c:6: arch/riscv/include/asm/vdso/processor.h: In function 'cpu_relax': arch/riscv/include/asm/vdso/processor.h:14:2: error: implicit declaration of function 'barrier' [-Werror=implicit-function-declaration] 14 | barrier(); | ^~~ drivers/net/ethernet/intel/ice/ice_txrx.c: In function 'ice_add_rx_frag': >> drivers/net/ethernet/intel/ice/ice_txrx.c:828:2: warning: ISO C90 forbids >> mixed declarations and code [-Wdeclaration-after-statement] 828 | struct skb_shared_info *shinfo = skb_shinfo(skb); | ^~ >> drivers/net/ethernet/intel/ice/ice_txrx.c:831:24: warning: passing argument >> 2 of 'skb_add_rx_frag' makes integer from pointer without a cast >> [-Wint-conversion] 831 | skb_add_rx_frag(skb, shinfo, rx_buf->page, |^~ || |struct skb_shared_info * In file included from include/net/net_namespace.h:39, from include/linux/netdevice.h:37, from include/trace/events/xdp.h:8, from include/linux/bpf_trace.h:5, from drivers/net/ethernet/intel/ice/ice_txrx.c:8: include/linux/skbuff.h:2187:47: note: expected 'int' but argument is of type 'struct skb_shared_info *' 2187 | void skb_add_rx_frag(struct sk_buff *skb, int i, struct page *page, int off, | ^ cc1: some warnings being treated as errors vim +828 drivers/net/ethernet/intel/ice/ice_txrx.c 825 826 if (!size) 827 return; > 828 struct skb_shared_info *shinfo = skb_shinfo(skb); 829 830 if (shinfo->nr_frags < ARRAY_SIZE(shinfo->frags)) { > 831 skb_add_rx_frag(skb, shinfo, rx_buf->page, 832 rx_buf->page_offset, size, truesize); 833 } 834 835 /* page is being used so we must update the page offset */ 836 ice_rx_buf_adjust_pg_offset(rx_buf, truesize); 837 } 838 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [PATCH v5 3/6] net: dsa: microchip: ksz8795: move register offsets and shifts to separate struct
Hi Michael, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] [also build test WARNING on next-20201207] [cannot apply to net/master ipvs/master linus/master v5.10-rc7] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Michael-Grzeschik/microchip-add-support-for-ksz88x3-driver-family/20201207-205945 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git af3f4a85d90218bb59315d591bd2bffa5e646466 config: arc-allyesconfig (attached as .config) compiler: arceb-elf-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/db1f7322c8fa2c28587f13ab3eebbb6ee02874b1 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Michael-Grzeschik/microchip-add-support-for-ksz88x3-driver-family/20201207-205945 git checkout db1f7322c8fa2c28587f13ab3eebbb6ee02874b1 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/net/dsa/microchip/ksz8795.c:69:27: warning: initialized field >> overwritten [-Woverride-init] 69 | [DYNAMIC_MAC_ENTRIES] = 29, | ^~ drivers/net/dsa/microchip/ksz8795.c:69:27: note: (near initialization for 'ksz8795_shifts[5]') vim +69 drivers/net/dsa/microchip/ksz8795.c 62 63 static const u8 ksz8795_shifts[] = { 64 [VLAN_TABLE_MEMBERSHIP] = 7, 65 [VLAN_TABLE]= 16, 66 [STATIC_MAC_FWD_PORTS] = 16, 67 [STATIC_MAC_FID]= 24, 68 [DYNAMIC_MAC_ENTRIES_H] = 3, > 69 [DYNAMIC_MAC_ENTRIES] = 29, 70 [DYNAMIC_MAC_FID] = 16, 71 [DYNAMIC_MAC_TIMESTAMP] = 27, 72 [DYNAMIC_MAC_SRC_PORT] = 24, 73 }; 74 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [PATCH] Bluetooth: smp: Fix biased random passkey generation
Hi Mincheol, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on bluetooth-next/master] [also build test WARNING on net-next/master net/master bluetooth/master sparc-next/master v5.10-rc7 next-20201207] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Mincheol-Son/Bluetooth-smp-Fix-biased-random-passkey-generation/20201208-015207 base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master config: parisc-randconfig-r035-20201207 (attached as .config) compiler: hppa-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/80c9c180f997bc9d9e1df4426fc7957839caee56 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Mincheol-Son/Bluetooth-smp-Fix-biased-random-passkey-generation/20201208-015207 git checkout 80c9c180f997bc9d9e1df4426fc7957839caee56 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=parisc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): net/bluetooth/smp.c: In function 'tk_request': >> net/bluetooth/smp.c:927:3: warning: this decimal constant is unsigned only >> in ISO C90 927 | } while (passkey >= (u32)42); | ^ vim +927 net/bluetooth/smp.c 849 850 static int tk_request(struct l2cap_conn *conn, u8 remote_oob, u8 auth, 851 u8 local_io, u8 remote_io) 852 { 853 struct hci_conn *hcon = conn->hcon; 854 struct l2cap_chan *chan = conn->smp; 855 struct smp_chan *smp = chan->data; 856 u32 passkey = 0; 857 int ret; 858 859 /* Initialize key for JUST WORKS */ 860 memset(smp->tk, 0, sizeof(smp->tk)); 861 clear_bit(SMP_FLAG_TK_VALID, &smp->flags); 862 863 BT_DBG("tk_request: auth:%d lcl:%d rem:%d", auth, local_io, remote_io); 864 865 /* If neither side wants MITM, either "just" confirm an incoming 866 * request or use just-works for outgoing ones. The JUST_CFM 867 * will be converted to JUST_WORKS if necessary later in this 868 * function. If either side has MITM look up the method from the 869 * table. 870 */ 871 if (!(auth & SMP_AUTH_MITM)) 872 smp->method = JUST_CFM; 873 else 874 smp->method = get_auth_method(smp, local_io, remote_io); 875 876 /* Don't confirm locally initiated pairing attempts */ 877 if (smp->method == JUST_CFM && test_bit(SMP_FLAG_INITIATOR, 878 &smp->flags)) 879 smp->method = JUST_WORKS; 880 881 /* Don't bother user space with no IO capabilities */ 882 if (smp->method == JUST_CFM && 883 hcon->io_capability == HCI_IO_NO_INPUT_OUTPUT) 884 smp->method = JUST_WORKS; 885 886 /* If Just Works, Continue with Zero TK and ask user-space for 887 * confirmation */ 888 if (smp->method == JUST_WORKS) { 889 ret = mgmt_user_confirm_request(hcon->hdev, &hcon->dst, 890 hcon->type, 891 hcon->dst_type, 892 passkey, 1); 893 if (ret) 894 return ret; 895 set_bit(SMP_FLAG_WAIT_USER, &smp->flags); 896 return 0; 897 } 898 899 /* If this function is used for SC -> legacy fallback we 900 * can only recover the just-works case. 901 */ 902 if (test_bit(SMP_FLAG_SC, &smp->flags)) 903 return -EINVAL; 904 905 /* Not Just Works/Confirm results in MITM Authentication */ 906 if (smp->method != JUST_CFM) { 907 set_bit(SMP_FLAG_MITM_AUTH, &smp->flags); 908 if (hcon->pending_sec_level < BT_SECURITY_HIGH) 909 hcon->pending_sec_level = BT_SECURITY_HIGH;
Re: [PATCH net-next v3 2/3] net: dsa: add Arrow SpeedChips XRS700x driver
Hi George, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/George-McCollister/Arrow-SpeedChips-XRS700x-DSA-Driver/20201208-060957 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git b1f7b0983601af4054876bca42e3094bf6b034c0 config: arc-allyesconfig (attached as .config) compiler: arceb-elf-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/17e19d3e01ec0a36ca45992b96580d271e9f6f75 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review George-McCollister/Arrow-SpeedChips-XRS700x-DSA-Driver/20201208-060957 git checkout 17e19d3e01ec0a36ca45992b96580d271e9f6f75 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): drivers/net/dsa/xrs700x/xrs700x.c:511:3: error: 'const struct dsa_switch_ops' has no member named 'get_stats64' 511 | .get_stats64 = xrs700x_getstats64, | ^~~ drivers/net/dsa/xrs700x/xrs700x.c:511:18: error: initialization of 'int (*)(struct dsa_switch *, int, int)' from incompatible pointer type 'void (*)(struct dsa_switch *, int, struct rtnl_link_stats64 *)' [-Werror=incompatible-pointer-types] 511 | .get_stats64 = xrs700x_getstats64, | ^~ drivers/net/dsa/xrs700x/xrs700x.c:511:18: note: (near initialization for 'xrs700x_ops.get_sset_count') >> drivers/net/dsa/xrs700x/xrs700x.c:511:18: warning: initialized field >> overwritten [-Woverride-init] drivers/net/dsa/xrs700x/xrs700x.c:511:18: note: (near initialization for 'xrs700x_ops.get_sset_count') cc1: some warnings being treated as errors vim +511 drivers/net/dsa/xrs700x/xrs700x.c 500 501 static const struct dsa_switch_ops xrs700x_ops = { 502 .get_tag_protocol = xrs700x_get_tag_protocol, 503 .setup = xrs700x_setup, 504 .teardown = xrs700x_teardown, 505 .port_stp_state_set = xrs700x_port_stp_state_set, 506 .phylink_validate = xrs700x_phylink_validate, 507 .phylink_mac_link_up= xrs700x_mac_link_up, 508 .get_strings= xrs700x_get_strings, 509 .get_sset_count = xrs700x_get_sset_count, 510 .get_ethtool_stats = xrs700x_get_ethtool_stats, > 511 .get_stats64= xrs700x_getstats64, 512 .port_bridge_join = xrs700x_bridge_join, 513 .port_bridge_leave = xrs700x_bridge_leave, 514 }; 515 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [PATCH] net: 8021q: vlan: reduce noise in driver initialization
Hi "Enrico, I love your patch! Yet something to improve: [auto build test ERROR on linux/master] [also build test ERROR on net-next/master net/master linus/master v5.10-rc7 next-20201207] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Enrico-Weigelt-metux-IT-consult/net-8021q-vlan-reduce-noise-in-driver-initialization/20201208-165821 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 09162bc32c880a791c6c0668ce0745cf7958f576 config: i386-randconfig-s001-20201208 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.3-179-ga00755aa-dirty # https://github.com/0day-ci/linux/commit/7c73ca17c3872132d7bd1b9407a26dd5ed916e2c git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Enrico-Weigelt-metux-IT-consult/net-8021q-vlan-reduce-noise-in-driver-initialization/20201208-165821 git checkout 7c73ca17c3872132d7bd1b9407a26dd5ed916e2c # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): ld: net/8021q/vlan_dev.o: in function `strlcpy': >> include/linux/string.h:346: undefined reference to `vlan_fullname' >> ld: include/linux/string.h:346: undefined reference to `vlan_version' vim +346 include/linux/string.h 6974f0c4555e28 Daniel Micay 2017-07-12 337 6974f0c4555e28 Daniel Micay 2017-07-12 338 /* defined after fortified strlen to reuse it */ 6974f0c4555e28 Daniel Micay 2017-07-12 339 extern size_t __real_strlcpy(char *, const char *, size_t) __RENAME(strlcpy); 6974f0c4555e28 Daniel Micay 2017-07-12 340 __FORTIFY_INLINE size_t strlcpy(char *p, const char *q, size_t size) 6974f0c4555e28 Daniel Micay 2017-07-12 341 { 6974f0c4555e28 Daniel Micay 2017-07-12 342size_t ret; 6974f0c4555e28 Daniel Micay 2017-07-12 343size_t p_size = __builtin_object_size(p, 0); 6974f0c4555e28 Daniel Micay 2017-07-12 344size_t q_size = __builtin_object_size(q, 0); 6974f0c4555e28 Daniel Micay 2017-07-12 345if (p_size == (size_t)-1 && q_size == (size_t)-1) 6974f0c4555e28 Daniel Micay 2017-07-12 @346return __real_strlcpy(p, q, size); 6974f0c4555e28 Daniel Micay 2017-07-12 347ret = strlen(q); 6974f0c4555e28 Daniel Micay 2017-07-12 348if (size) { 6974f0c4555e28 Daniel Micay 2017-07-12 349size_t len = (ret >= size) ? size - 1 : ret; 6974f0c4555e28 Daniel Micay 2017-07-12 350if (__builtin_constant_p(len) && len >= p_size) 6974f0c4555e28 Daniel Micay 2017-07-12 351 __write_overflow(); 6974f0c4555e28 Daniel Micay 2017-07-12 352if (len >= p_size) 6974f0c4555e28 Daniel Micay 2017-07-12 353 fortify_panic(__func__); 47227d27e2fcb0 Daniel Axtens 2020-06-03 354__underlying_memcpy(p, q, len); 6974f0c4555e28 Daniel Micay 2017-07-12 355p[len] = '\0'; 6974f0c4555e28 Daniel Micay 2017-07-12 356} 6974f0c4555e28 Daniel Micay 2017-07-12 357return ret; 6974f0c4555e28 Daniel Micay 2017-07-12 358 } 6974f0c4555e28 Daniel Micay 2017-07-12 359 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [PATCH] net: 8021q: vlan: reduce noise in driver initialization
Hi "Enrico, I love your patch! Yet something to improve: [auto build test ERROR on linux/master] [also build test ERROR on net-next/master net/master linus/master v5.10-rc7 next-20201208] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Enrico-Weigelt-metux-IT-consult/net-8021q-vlan-reduce-noise-in-driver-initialization/20201208-165821 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 09162bc32c880a791c6c0668ce0745cf7958f576 config: nds32-randconfig-r014-20201208 (attached as .config) compiler: nds32le-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/7c73ca17c3872132d7bd1b9407a26dd5ed916e2c git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Enrico-Weigelt-metux-IT-consult/net-8021q-vlan-reduce-noise-in-driver-initialization/20201208-165821 git checkout 7c73ca17c3872132d7bd1b9407a26dd5ed916e2c # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nds32 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): nds32le-linux-ld: net/8021q/vlan_dev.o: in function `vlan_ethtool_get_drvinfo': >> vlan_dev.c:(.text+0x2e8): undefined reference to `vlan_fullname' >> nds32le-linux-ld: vlan_dev.c:(.text+0x2ec): undefined reference to >> `vlan_fullname' >> nds32le-linux-ld: vlan_dev.c:(.text+0x300): undefined reference to >> `vlan_version' nds32le-linux-ld: vlan_dev.c:(.text+0x304): undefined reference to `vlan_version' --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [PATCH v2 3/8] net: macb: add function to disable all macb clocks
Hi Claudiu, I love your patch! Perhaps something to improve: [auto build test WARNING on robh/for-next] [also build test WARNING on net-next/master net/master linus/master v5.10-rc7 next-20201208] [cannot apply to sparc-next/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Claudiu-Beznea/net-macb-add-support-for-sama7g5/20201207-201959 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next config: arm64-randconfig-r021-20201208 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 1968804ac726e7674d5de22bc2204b45857da344) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm64 cross compiling tool for clang build # apt-get install binutils-aarch64-linux-gnu # https://github.com/0day-ci/linux/commit/7a9fff9938fe9b459aa67f4afb0e817313d3d54a git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Claudiu-Beznea/net-macb-add-support-for-sama7g5/20201207-201959 git checkout 7a9fff9938fe9b459aa67f4afb0e817313d3d54a # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/net/ethernet/cadence/macb_main.c:4506:6: warning: variable 'bp' is >> used uninitialized whenever 'if' condition is true >> [-Wsometimes-uninitialized] if (!dev) { ^~~~ drivers/net/ethernet/cadence/macb_main.c:4641:20: note: uninitialized use occurs here macb_clks_disable(bp->pclk, bp->hclk, bp->tx_clk, bp->rx_clk, bp->tsu_clk); ^~ drivers/net/ethernet/cadence/macb_main.c:4506:2: note: remove the 'if' if its condition is always false if (!dev) { ^~~ drivers/net/ethernet/cadence/macb_main.c:4474:17: note: initialize the variable 'bp' to silence this warning struct macb *bp; ^ = NULL 1 warning generated. vim +4506 drivers/net/ethernet/cadence/macb_main.c 83a77e9ec4150e drivers/net/ethernet/cadence/macb.c Bartosz Folta 2016-12-14 4456 421d9df0628be1 drivers/net/ethernet/cadence/macb.c Cyrille Pitchen 2015-03-07 4457 static int macb_probe(struct platform_device *pdev) 421d9df0628be1 drivers/net/ethernet/cadence/macb.c Cyrille Pitchen 2015-03-07 4458 { 83a77e9ec4150e drivers/net/ethernet/cadence/macb.c Bartosz Folta 2016-12-14 4459 const struct macb_config *macb_config = &default_gem_config; c69618b3e4f220 drivers/net/ethernet/cadence/macb.c Nicolas Ferre 2015-03-31 4460 int (*clk_init)(struct platform_device *, struct clk **, f5473d1d44e4b4 drivers/net/ethernet/cadence/macb_main.c Harini Katakam 2019-03-01 4461 struct clk **, struct clk **, struct clk **, f5473d1d44e4b4 drivers/net/ethernet/cadence/macb_main.c Harini Katakam 2019-03-01 4462 struct clk **) = macb_config->clk_init; 83a77e9ec4150e drivers/net/ethernet/cadence/macb.c Bartosz Folta 2016-12-14 4463 int (*init)(struct platform_device *) = macb_config->init; 421d9df0628be1 drivers/net/ethernet/cadence/macb.c Cyrille Pitchen 2015-03-07 4464 struct device_node *np = pdev->dev.of_node; aead88bd0e9905 drivers/net/ethernet/cadence/macb.c shubhrajyoti.da...@xilinx.com 2016-08-16 4465 struct clk *pclk, *hclk = NULL, *tx_clk = NULL, *rx_clk = NULL; f5473d1d44e4b4 drivers/net/ethernet/cadence/macb_main.c Harini Katakam 2019-03-01 4466 struct clk *tsu_clk = NULL; 421d9df0628be1 drivers/net/ethernet/cadence/macb.c Cyrille Pitchen 2015-03-07 4467 unsigned int queue_mask, num_queues; f2ce8a9e48385f drivers/net/ethernet/cadence/macb.c Andy Shevchenko 2015-07-24 4468 bool native_io; 0c65b2b90d13c1 drivers/net/ethernet/cadence/macb_main.c Andrew Lunn 2019-11-04 4469 phy_interface_t interface; 421d9df0628be1 drivers/net/ethernet/cadence/macb.c Cyrille Pitchen 2015-03-07 4470 struct net_device *dev; 421d9df0628be1 drivers/net/ethernet/cadence/macb.c Cyrille Pitchen 2015-03-07
Re: [Intel-wired-lan] [PATCH 1/1] fix possible array overflow on receiving too many fragments for a packet
Hi Xiaohui, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on tnguy-next-queue/dev-queue] [also build test WARNING on linus/master sparc-next/master v5.10-rc7 next-20201208] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Xiaohui-Zhang/fix-possible-array-overflow-on-receiving-too-many-fragments-for-a-packet/20201209-010457 base: https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue.git dev-queue config: riscv-allyesconfig (attached as .config) compiler: riscv64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/4bc4508ab14b72993c4e9a927f8e82a1dfdcf39c git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Xiaohui-Zhang/fix-possible-array-overflow-on-receiving-too-many-fragments-for-a-packet/20201209-010457 git checkout 4bc4508ab14b72993c4e9a927f8e82a1dfdcf39c # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=riscv If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): In file included from include/linux/ip.h:16, from drivers/net/ethernet/pensando/ionic/ionic_txrx.c:4: drivers/net/ethernet/pensando/ionic/ionic_txrx.c: In function 'ionic_rx_frags': >> include/linux/skbuff.h:1431:53: warning: 'skb' is used uninitialized in this >> function [-Wuninitialized] 1431 | #define skb_shinfo(SKB) ((struct skb_shared_info *)(skb_end_pointer(SKB))) | ^~~ drivers/net/ethernet/pensando/ionic/ionic_txrx.c:76:18: note: 'skb' was declared here 76 | struct sk_buff *skb; | ^~~ vim +/skb +1431 include/linux/skbuff.h 4305b541357ddbd Arnaldo Carvalho de Melo 2007-04-19 1429 ^1da177e4c3f415 Linus Torvalds 2005-04-16 1430 /* Internal */ 4305b541357ddbd Arnaldo Carvalho de Melo 2007-04-19 @1431 #define skb_shinfo(SKB) ((struct skb_shared_info *)(skb_end_pointer(SKB))) ^1da177e4c3f415 Linus Torvalds 2005-04-16 1432 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
[RFC PATCH] ptp: clock_pair_gpa can be static
Reported-by: kernel test robot Signed-off-by: kernel test robot --- ptp_kvm_x86.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ptp/ptp_kvm_x86.c b/drivers/ptp/ptp_kvm_x86.c index e011d691e549a7..19cad4c0297265 100644 --- a/drivers/ptp/ptp_kvm_x86.c +++ b/drivers/ptp/ptp_kvm_x86.c @@ -15,8 +15,8 @@ #include #include -phys_addr_t clock_pair_gpa; -struct kvm_clock_pairing clock_pair; +static phys_addr_t clock_pair_gpa; +static struct kvm_clock_pairing clock_pair; struct pvclock_vsyscall_time_info *hv_clock; int kvm_arch_ptp_init(void)
Re: [PATCH v16 3/9] ptp: Reorganize ptp_kvm module to make it arch-independent.
Hi Jianyong, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on kvmarm/next] [also build test WARNING on linus/master v5.10-rc7 next-20201208] [cannot apply to tip/timers/core kvm/linux-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Jianyong-Wu/Enable-ptp_kvm-for-arm-arm64/20201209-141506 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvmarm/kvmarm.git next config: i386-randconfig-s001-20201209 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.3-179-ga00755aa-dirty # https://github.com/0day-ci/linux/commit/35c13e9c526d0900f8d80f4b3f6a34234d29a911 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Jianyong-Wu/Enable-ptp_kvm-for-arm-arm64/20201209-141506 git checkout 35c13e9c526d0900f8d80f4b3f6a34234d29a911 # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot "sparse warnings: (new ones prefixed by >>)" >> drivers/ptp/ptp_kvm_x86.c:18:13: sparse: sparse: symbol 'clock_pair_gpa' was >> not declared. Should it be static? >> drivers/ptp/ptp_kvm_x86.c:19:26: sparse: sparse: symbol 'clock_pair' was not >> declared. Should it be static? Please review and possibly fold the followup patch. --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [PATCH v2 1/2] net: dsa: lantiq: allow to use all GPHYs on xRX300 and xRX330
Hi Aleksander, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on robh/for-next] [also build test WARNING on net-next/master net/master linus/master sparc-next/master v5.10-rc7 next-20201208] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Aleksander-Jan-Bajkowski/net-dsa-lantiq-add-support-for-xRX300-and-xRX330/20201206-213318 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next config: x86_64-randconfig-s022-20201209 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.3-179-ga00755aa-dirty # https://github.com/0day-ci/linux/commit/3a3400f9d3cd41f2b72cd741f208a70fca7fe93f git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Aleksander-Jan-Bajkowski/net-dsa-lantiq-add-support-for-xRX300-and-xRX330/20201206-213318 git checkout 3a3400f9d3cd41f2b72cd741f208a70fca7fe93f # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot "sparse warnings: (new ones prefixed by >>)" >> drivers/net/dsa/lantiq_gswip.c:2068:17: sparse: sparse: incorrect type in >> initializer (different modifiers) @@ expected struct dsa_switch_ops *ops >> @@ got struct dsa_switch_ops const * @@ drivers/net/dsa/lantiq_gswip.c:2068:17: sparse: expected struct dsa_switch_ops *ops drivers/net/dsa/lantiq_gswip.c:2068:17: sparse: got struct dsa_switch_ops const * drivers/net/dsa/lantiq_gswip.c:2074:17: sparse: sparse: incorrect type in initializer (different modifiers) @@ expected struct dsa_switch_ops *ops @@ got struct dsa_switch_ops const * @@ drivers/net/dsa/lantiq_gswip.c:2074:17: sparse: expected struct dsa_switch_ops *ops drivers/net/dsa/lantiq_gswip.c:2074:17: sparse: got struct dsa_switch_ops const * vim +2068 drivers/net/dsa/lantiq_gswip.c 2064 2065 static const struct gswip_hw_info gswip_xrx200 = { 2066 .max_ports = 7, 2067 .cpu_port = 6, > 2068 .ops = &gswip_xrx200_switch_ops, 2069 }; 2070 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [Intel-wired-lan] [PATCH v2 bpf 2/5] drivers/net: turn XDP properties on
Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on eceae70bdeaeb6b8ceb662983cf663ff352fbc96] url: https://github.com/0day-ci/linux/commits/alardam-gmail-com/New-netdev-feature-flags-for-XDP/20201204-183428 base:eceae70bdeaeb6b8ceb662983cf663ff352fbc96 config: x86_64-randconfig-a003-20201209 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 1968804ac726e7674d5de22bc2204b45857da344) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # https://github.com/0day-ci/linux/commit/34e23fdbb761e9296101b14dc8c523d574ce6f74 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review alardam-gmail-com/New-netdev-feature-flags-for-XDP/20201204-183428 git checkout 34e23fdbb761e9296101b14dc8c523d574ce6f74 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): >> drivers/net/ethernet/intel/ice/ice_main.c:2984:2: error: implicit >> declaration of function 'xsk_set_zc_properties' >> [-Werror,-Wimplicit-function-declaration] xsk_set_zc_properties(&netdev->xdp_properties); ^ drivers/net/ethernet/intel/ice/ice_main.c:2984:2: note: did you mean 'xsk_set_zc_property'? include/net/xdp_sock_drv.h:251:20: note: 'xsk_set_zc_property' declared here static inline void xsk_set_zc_property(xdp_properties_t *properties) ^ 1 error generated. vim +/xsk_set_zc_properties +2984 drivers/net/ethernet/intel/ice/ice_main.c 2951 2952 /** 2953 * ice_cfg_netdev - Allocate, configure and register a netdev 2954 * @vsi: the VSI associated with the new netdev 2955 * 2956 * Returns 0 on success, negative value on failure 2957 */ 2958 static int ice_cfg_netdev(struct ice_vsi *vsi) 2959 { 2960 struct ice_pf *pf = vsi->back; 2961 struct ice_netdev_priv *np; 2962 struct net_device *netdev; 2963 u8 mac_addr[ETH_ALEN]; 2964 int err; 2965 2966 err = ice_devlink_create_port(vsi); 2967 if (err) 2968 return err; 2969 2970 netdev = alloc_etherdev_mqs(sizeof(*np), vsi->alloc_txq, 2971 vsi->alloc_rxq); 2972 if (!netdev) { 2973 err = -ENOMEM; 2974 goto err_destroy_devlink_port; 2975 } 2976 2977 vsi->netdev = netdev; 2978 np = netdev_priv(netdev); 2979 np->vsi = vsi; 2980 2981 ice_set_netdev_features(netdev); 2982 2983 xdp_set_full_properties(&netdev->xdp_properties); > 2984 xsk_set_zc_properties(&netdev->xdp_properties); 2985 2986 ice_set_ops(netdev); 2987 2988 if (vsi->type == ICE_VSI_PF) { 2989 SET_NETDEV_DEV(netdev, ice_pf_to_dev(pf)); 2990 ether_addr_copy(mac_addr, vsi->port_info->mac.perm_addr); 2991 ether_addr_copy(netdev->dev_addr, mac_addr); 2992 ether_addr_copy(netdev->perm_addr, mac_addr); 2993 } 2994 2995 netdev->priv_flags |= IFF_UNICAST_FLT; 2996 2997 /* Setup netdev TC information */ 2998 ice_vsi_cfg_netdev_tc(vsi, vsi->tc_cfg.ena_tc); 2999 3000 /* setup watchdog timeout value to be 5 second */ 3001 netdev->watchdog_timeo = 5 * HZ; 3002 3003 netdev->min_mtu = ETH_MIN_MTU; 3004 netdev->max_mtu = ICE_MAX_MTU; 3005 3006 err = register_netdev(vsi->netdev); 3007 if (err) 3008 goto err_free_netdev; 3009 3010 devlink_port_type_eth_set(&vsi->devlink_port, vsi->netdev); 3011 3012 netif_carrier_off(vsi->netdev); 3013 3014 /* make sure transmit queues start off as stopped */ 3015 netif_tx_stop_all_queues(vsi->netdev); 3016 3017 return 0; 3018 3019 err_free_netdev: 3020 free_netdev(vsi->netdev); 3021 vsi->netdev = NULL; 3022 err_destroy_devlink_port: 3023 ice_devlink_destroy_port(vsi); 3024 return err; 3025 } 3026 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [PATCH net-next 4/4] net/mlx5e: Support HTB offload
Hi Maxim, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Maxim-Mikityanskiy/HTB-offload/20201210-000703 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git afae3cc2da100ead3cd6ef4bb1fb8bc9d4b817c5 config: x86_64-randconfig-s021-20201210 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.3-179-ga00755aa-dirty # https://github.com/0day-ci/linux/commit/2b06403da63c880ec87d0bcee80b8936116935c6 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Maxim-Mikityanskiy/HTB-offload/20201210-000703 git checkout 2b06403da63c880ec87d0bcee80b8936116935c6 # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot "sparse warnings: (new ones prefixed by >>)" >> drivers/net/ethernet/mellanox/mlx5/core/en_txrx.c:135:17: sparse: sparse: >> incorrect type in assignment (different address spaces) @@ expected >> struct mlx5e_txqsq **qos_sqs @@ got struct mlx5e_txqsq [noderef] __rcu >> ** @@ drivers/net/ethernet/mellanox/mlx5/core/en_txrx.c:135:17: sparse: expected struct mlx5e_txqsq **qos_sqs drivers/net/ethernet/mellanox/mlx5/core/en_txrx.c:135:17: sparse: got struct mlx5e_txqsq [noderef] __rcu ** >> drivers/net/ethernet/mellanox/mlx5/core/en_txrx.c:149:50: sparse: sparse: >> incompatible types in comparison expression (different address spaces): >> drivers/net/ethernet/mellanox/mlx5/core/en_txrx.c:149:50: sparse:struct >> mlx5e_txqsq [noderef] __rcu * >> drivers/net/ethernet/mellanox/mlx5/core/en_txrx.c:149:50: sparse:struct >> mlx5e_txqsq * drivers/net/ethernet/mellanox/mlx5/core/en_txrx.c:211:50: sparse: sparse: incompatible types in comparison expression (different address spaces): drivers/net/ethernet/mellanox/mlx5/core/en_txrx.c:211:50: sparse:struct mlx5e_txqsq [noderef] __rcu * drivers/net/ethernet/mellanox/mlx5/core/en_txrx.c:211:50: sparse:struct mlx5e_txqsq * -- >> drivers/net/ethernet/mellanox/mlx5/core/en/qos.c:174:17: sparse: sparse: >> incorrect type in assignment (different address spaces) @@ expected >> struct mlx5e_txqsq **qos_sqs @@ got struct mlx5e_txqsq [noderef] __rcu >> ** @@ drivers/net/ethernet/mellanox/mlx5/core/en/qos.c:174:17: sparse: expected struct mlx5e_txqsq **qos_sqs drivers/net/ethernet/mellanox/mlx5/core/en/qos.c:174:17: sparse: got struct mlx5e_txqsq [noderef] __rcu ** >> drivers/net/ethernet/mellanox/mlx5/core/en/qos.c:175:16: sparse: sparse: >> incompatible types in comparison expression (different address spaces): >> drivers/net/ethernet/mellanox/mlx5/core/en/qos.c:175:16: sparse:struct >> mlx5e_txqsq [noderef] __rcu * >> drivers/net/ethernet/mellanox/mlx5/core/en/qos.c:175:16: sparse:struct >> mlx5e_txqsq * drivers/net/ethernet/mellanox/mlx5/core/en/qos.c:225:17: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct mlx5e_txqsq **qos_sqs @@ got struct mlx5e_txqsq [noderef] __rcu ** @@ drivers/net/ethernet/mellanox/mlx5/core/en/qos.c:225:17: sparse: expected struct mlx5e_txqsq **qos_sqs drivers/net/ethernet/mellanox/mlx5/core/en/qos.c:225:17: sparse: got struct mlx5e_txqsq [noderef] __rcu ** drivers/net/ethernet/mellanox/mlx5/core/en/qos.c:245:9: sparse: sparse: incompatible types in comparison expression (different address spaces): drivers/net/ethernet/mellanox/mlx5/core/en/qos.c:245:9: sparse:struct mlx5e_txqsq [noderef] __rcu * drivers/net/ethernet/mellanox/mlx5/core/en/qos.c:245:9: sparse:struct mlx5e_txqsq * drivers/net/ethernet/mellanox/mlx5/core/en/qos.c:301:17: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct mlx5e_txqsq **qos_sqs @@ got struct mlx5e_txqsq [noderef] __rcu ** @@ drivers/net/ethernet/mellanox/mlx5/core/en/qos.c:302:14: sparse: sparse: incompatible types in comparison expression (different address spaces): drivers/net/ethernet/mellanox/mlx5/core/en/qos.c:302:14: sparse:struct mlx5e_txqsq [noderef] __rcu * drivers/net/ethernet/mellanox/mlx5/core/en/qos.c:302:14: sparse:struct mlx5e_txqsq * drivers/net/ethernet/mellanox/mlx5/core/en/qos.c:302:14: sparse: sparse: incompatible types in comparison expression (different address spaces): drivers/net/ethernet/mellanox/mlx5/core/en/qos.c:302:14: sparse:struct mlx5e_txqsq [noderef] __rcu * drivers/net/ethernet/mellanox/mlx5/core/en/qos.c:302:14: sparse:
Re: [PATCH 05/11] net: dsa: microchip: ksz8795: use mib_cnt where possible
Hi Michael, I love your patch! Yet something to improve: [auto build test ERROR on net/master] [also build test ERROR on net-next/master ipvs/master linus/master v5.10-rc4 next-20201118] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Michael-Grzeschik/net-dsa-microchip-make-ksz8795-driver-more-dynamic/20201119-060705 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git a3dcb3e7e70c72a68a79b30fc3a3adad5612731c config: h8300-randconfig-r031-20201119 (attached as .config) compiler: h8300-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/9debc1a2179402cc4391e253c57fafa0ef357e05 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Michael-Grzeschik/net-dsa-microchip-make-ksz8795-driver-more-dynamic/20201119-060705 git checkout 9debc1a2179402cc4391e253c57fafa0ef357e05 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=h8300 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): drivers/net/dsa/microchip/ksz8795.c: In function 'ksz8795_get_strings': >> drivers/net/dsa/microchip/ksz8795.c:659:18: error: 'dev' undeclared (first >> use in this function); did you mean 'cdev'? 659 | for (i = 0; i < dev->mib_cnt; i++) { | ^~~ | cdev drivers/net/dsa/microchip/ksz8795.c:659:18: note: each undeclared identifier is reported only once for each function it appears in vim +659 drivers/net/dsa/microchip/ksz8795.c 653 654 static void ksz8795_get_strings(struct dsa_switch *ds, int port, 655 u32 stringset, uint8_t *buf) 656 { 657 int i; 658 > 659 for (i = 0; i < dev->mib_cnt; i++) { 660 memcpy(buf + i * ETH_GSTRING_LEN, mib_names[i].string, 661 ETH_GSTRING_LEN); 662 } 663 } 664 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [PATCH v9 4/4] net: dsa: mv88e6xxx: Add support for mv88e6393x family of Marvell
Hi Pavana, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on robh/for-next] [also build test WARNING on net-next/master net/master linus/master v5.10-rc4 next-20201119] [cannot apply to sparc-next/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Pavana-Sharma/Add-support-for-mv88e6393x-family-of-Marvell/20201119-160915 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next config: sh-allmodconfig (attached as .config) compiler: sh4-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/2b347d8ede029475baf73ac8e08ea38dad2526e4 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Pavana-Sharma/Add-support-for-mv88e6393x-family-of-Marvell/20201119-160915 git checkout 2b347d8ede029475baf73ac8e08ea38dad2526e4 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): drivers/net/dsa/mv88e6xxx/serdes.c: In function 'mv88e6393x_serdes_power': >> drivers/net/dsa/mv88e6xxx/serdes.c:1212:2: warning: ISO C90 forbids mixed >> declarations and code [-Wdeclaration-after-statement] 1212 | u8 cmode = chip->ports[port].cmode; | ^~ vim +1212 drivers/net/dsa/mv88e6xxx/serdes.c 1205 1206 int mv88e6393x_serdes_power(struct mv88e6xxx_chip *chip, int port, int lane, 1207 bool on) 1208 { 1209 if (port != 0 && port != 9 && port != 10) 1210 return -EOPNOTSUPP; 1211 > 1212 u8 cmode = chip->ports[port].cmode; --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [PATCH v9 4/4] net: dsa: mv88e6xxx: Add support for mv88e6393x family of Marvell
Hi Pavana, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on robh/for-next] [also build test WARNING on net-next/master net/master linus/master v5.10-rc4 next-20201119] [cannot apply to sparc-next/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Pavana-Sharma/Add-support-for-mv88e6393x-family-of-Marvell/20201119-160915 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next config: x86_64-randconfig-a004-20201119 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project b2613fb2f0f53691dd0211895afbb9413457fca7) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # https://github.com/0day-ci/linux/commit/2b347d8ede029475baf73ac8e08ea38dad2526e4 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Pavana-Sharma/Add-support-for-mv88e6393x-family-of-Marvell/20201119-160915 git checkout 2b347d8ede029475baf73ac8e08ea38dad2526e4 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/net/dsa/mv88e6xxx/serdes.c:1212:5: warning: ISO C90 forbids mixing >> declarations and code [-Wdeclaration-after-statement] u8 cmode = chip->ports[port].cmode; ^ 1 warning generated. vim +1212 drivers/net/dsa/mv88e6xxx/serdes.c 1205 1206 int mv88e6393x_serdes_power(struct mv88e6xxx_chip *chip, int port, int lane, 1207 bool on) 1208 { 1209 if (port != 0 && port != 9 && port != 10) 1210 return -EOPNOTSUPP; 1211 > 1212 u8 cmode = chip->ports[port].cmode; --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [PATCH net-next 3/3] net: phy: mscc: use new PTP_MSGTYPE_* defines
Hi Christian, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Christian-Eggers/net-ptp-use-common-defines-for-PTP-message-types-in-further-drivers/20201122-163319 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git f9e425e99b0756c1479042afe761073779df2a30 config: sparc-randconfig-r012-20201122 (attached as .config) compiler: sparc64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/78cc4b0e1739511ed9712c9466a48ddc6885d153 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Christian-Eggers/net-ptp-use-common-defines-for-PTP-message-types-in-further-drivers/20201122-163319 git checkout 78cc4b0e1739511ed9712c9466a48ddc6885d153 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sparc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): drivers/net/phy/mscc/mscc_ptp.c: In function 'vsc85xx_ptp_cmp_init': drivers/net/phy/mscc/mscc_ptp.c:510:3: error: 'PTP_MSGTYPE_SYNC' undeclared (first use in this function); did you mean 'CSD_TYPE_SYNC'? 510 | PTP_MSGTYPE_SYNC, | ^~~~ | CSD_TYPE_SYNC drivers/net/phy/mscc/mscc_ptp.c:510:3: note: each undeclared identifier is reported only once for each function it appears in drivers/net/phy/mscc/mscc_ptp.c:511:3: error: 'PTP_MSGTYPE_DELAY_REQ' undeclared (first use in this function) 511 | PTP_MSGTYPE_DELAY_REQ | ^ drivers/net/phy/mscc/mscc_ptp.c: In function 'vsc85xx_ptp_conf': drivers/net/phy/mscc/mscc_ptp.c:851:3: error: 'PTP_MSGTYPE_SYNC' undeclared (first use in this function); did you mean 'CSD_TYPE_SYNC'? 851 | PTP_MSGTYPE_SYNC, | ^~~~ | CSD_TYPE_SYNC >> drivers/net/phy/mscc/mscc_ptp.c:851:3: warning: initialization of 'unsigned >> char' from 'u8 *' {aka 'unsigned char *'} makes integer from pointer without >> a cast [-Wint-conversion] drivers/net/phy/mscc/mscc_ptp.c:851:3: note: (near initialization for 'msgs[0]') drivers/net/phy/mscc/mscc_ptp.c:852:3: error: 'PTP_MSGTYPE_DELAY_REQ' undeclared (first use in this function) 852 | PTP_MSGTYPE_DELAY_REQ | ^ drivers/net/phy/mscc/mscc_ptp.c:852:3: warning: initialization of 'unsigned char' from 'u8 *' {aka 'unsigned char *'} makes integer from pointer without a cast [-Wint-conversion] drivers/net/phy/mscc/mscc_ptp.c:852:3: note: (near initialization for 'msgs[1]') >> drivers/net/phy/mscc/mscc_ptp.c:861:20: warning: comparison between pointer >> and integer 861 | else if (msgs[i] == PTP_MSGTYPE_SYNC && one_step) |^~ vim +851 drivers/net/phy/mscc/mscc_ptp.c 846 847 static int vsc85xx_ptp_conf(struct phy_device *phydev, enum ts_blk blk, 848 bool one_step, bool enable) 849 { 850 u8 msgs[] = { > 851 PTP_MSGTYPE_SYNC, 852 PTP_MSGTYPE_DELAY_REQ 853 }; 854 u32 val; 855 u8 i; 856 857 for (i = 0; i < ARRAY_SIZE(msgs); i++) { 858 if (blk == INGRESS) 859 vsc85xx_ts_ptp_action_flow(phydev, blk, msgs[i], 860 PTP_WRITE_NS); > 861 else if (msgs[i] == PTP_MSGTYPE_SYNC && one_step) 862 /* no need to know Sync t when sending in one_step */ 863 vsc85xx_ts_ptp_action_flow(phydev, blk, msgs[i], 864 PTP_WRITE_1588); 865 else 866 vsc85xx_ts_ptp_action_flow(phydev, blk, msgs[i], 867 PTP_SAVE_IN_TS_FIFO); 868 869 val = vsc85xx_ts_read_csr(phydev, blk, 870MSCC_ANA_PTP_FLOW_ENA(i)); 871 val &= ~PTP_FLOW_ENA; 872 if (enable) 873 val |= PTP_FLOW_ENA; 874 vsc85xx_ts_write_csr(phydev, blk, MSCC_ANA_PTP_FLOW_ENA(i), 875 val); 876 } 877 878 return 0; 879 } 880 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [PATCH] libbpf: add support for canceling cached_cons advance
Hi Li, Thank you for the patch! Yet something to improve: [auto build test ERROR on bpf-next/master] [also build test ERROR on bpf/master ipvs/master v5.10-rc4 next-20201120] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Li-RongQing/libbpf-add-support-for-canceling-cached_cons-advance/20201122-212415 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master config: x86_64-randconfig-a006-20201122 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/394b6e92389887aaf0ef8a2a70ef295b045c748b git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Li-RongQing/libbpf-add-support-for-canceling-cached_cons-advance/20201122-212415 git checkout 394b6e92389887aaf0ef8a2a70ef295b045c748b # save the attached .config to linux build tree make W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): In file included from xsk.c:35: xsk.h: In function 'xsk_ring_cons__cancel': >> xsk.h:159:2: error: 'rx' undeclared (first use in this function) 159 | rx->cached_cons -= nb; | ^~ xsk.h:159:2: note: each undeclared identifier is reported only once for each function it appears in make[6]: *** [tools/build/Makefile.build:97: kernel/bpf/preload/staticobjs/xsk.o] Error 1 make[6]: Target '__build' not remade because of errors. --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [PATCH net] bonding: fix feature flag setting at init time
Hi Jarod, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] [also build test ERROR on next-20201123] [cannot apply to net/master linux/master linus/master sparc-next/master v5.10-rc5] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Jarod-Wilson/bonding-fix-feature-flag-setting-at-init-time/20201123-111956 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git f9e425e99b0756c1479042afe761073779df2a30 config: x86_64-rhel (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/6d883c4c2b01573ba9dddcb9fe109f961a8b7f10 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Jarod-Wilson/bonding-fix-feature-flag-setting-at-init-time/20201123-111956 git checkout 6d883c4c2b01573ba9dddcb9fe109f961a8b7f10 # save the attached .config to linux build tree make W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): drivers/net/bonding/bond_options.c: In function 'bond_option_mode_set': >> drivers/net/bonding/bond_options.c:752:38: error: 'BOND_XFRM_FEATURES' >> undeclared (first use in this function) 752 | netdev_features_t mask = features & BOND_XFRM_FEATURES; | ^~ drivers/net/bonding/bond_options.c:752:38: note: each undeclared identifier is reported only once for each function it appears in drivers/net/bonding/bond_options.c:752:20: warning: unused variable 'mask' [-Wunused-variable] 752 | netdev_features_t mask = features & BOND_XFRM_FEATURES; |^~~~ vim +/BOND_XFRM_FEATURES +752 drivers/net/bonding/bond_options.c 747 748 static int bond_option_mode_set(struct bonding *bond, 749 const struct bond_opt_value *newval) 750 { 751 netdev_features_t features = bond->dev->features; > 752 netdev_features_t mask = features & BOND_XFRM_FEATURES; 753 754 if (!bond_mode_uses_arp(newval->value)) { 755 if (bond->params.arp_interval) { 756 netdev_dbg(bond->dev, "%s mode is incompatible with arp monitoring, start mii monitoring\n", 757 newval->string); 758 /* disable arp monitoring */ 759 bond->params.arp_interval = 0; 760 } 761 762 if (!bond->params.miimon) { 763 /* set miimon to default value */ 764 bond->params.miimon = BOND_DEFAULT_MIIMON; 765 netdev_dbg(bond->dev, "Setting MII monitoring interval to %d\n", 766 bond->params.miimon); 767 } 768 } 769 770 if (newval->value == BOND_MODE_ALB) 771 bond->params.tlb_dynamic_lb = 1; 772 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [PATCH net-next] net: sfp: VSOL V2801F / CarlitoxxPro CPGOS03-0490 v2.0 workaround
Hi Russell, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Russell-King/net-sfp-VSOL-V2801F-CarlitoxxPro-CPGOS03-0490-v2-0-workaround/20201124-055921 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 8e1e33ffa696b2d779dd5cd422a80960b88e508c config: arc-randconfig-r016-20201123 (attached as .config) compiler: arc-elf-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/90849b26224de3b2e508f1c3fa31665f4fd72d0a git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Russell-King/net-sfp-VSOL-V2801F-CarlitoxxPro-CPGOS03-0490-v2-0-workaround/20201124-055921 git checkout 90849b26224de3b2e508f1c3fa31665f4fd72d0a # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): drivers/net/phy/sfp.c: In function 'sfp_i2c_read': >> drivers/net/phy/sfp.c:339:9: warning: variable 'block_size' set but not used >> [-Wunused-but-set-variable] 339 | size_t block_size; | ^~ vim +/block_size +339 drivers/net/phy/sfp.c 334 335 static int sfp_i2c_read(struct sfp *sfp, bool a2, u8 dev_addr, void *buf, 336 size_t len) 337 { 338 struct i2c_msg msgs[2]; > 339 size_t block_size; 340 size_t this_len; 341 u8 bus_addr; 342 int ret; 343 344 if (a2) { 345 block_size = 16; 346 bus_addr = 0x51; 347 } else { 348 block_size = sfp->i2c_block_size; 349 bus_addr = 0x50; 350 } 351 352 msgs[0].addr = bus_addr; 353 msgs[0].flags = 0; 354 msgs[0].len = 1; 355 msgs[0].buf = &dev_addr; 356 msgs[1].addr = bus_addr; 357 msgs[1].flags = I2C_M_RD; 358 msgs[1].len = len; 359 msgs[1].buf = buf; 360 361 while (len) { 362 this_len = len; 363 if (this_len > sfp->i2c_block_size) 364 this_len = sfp->i2c_block_size; 365 366 msgs[1].len = this_len; 367 368 ret = i2c_transfer(sfp->i2c, msgs, ARRAY_SIZE(msgs)); 369 if (ret < 0) 370 return ret; 371 372 if (ret != ARRAY_SIZE(msgs)) 373 break; 374 375 msgs[1].buf += this_len; 376 dev_addr += this_len; 377 len -= this_len; 378 } 379 380 return msgs[1].buf - (u8 *)buf; 381 } 382 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [net-next 2/3] tipc: make node number calculation reproducible
Hi, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/jmaloy-redhat-com/tipc-some-minor-improvements/20201125-013225 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git d5a05e69ac6e4c431c380ced2b534c91f7bc3280 config: i386-randconfig-s002-20201125 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.3-151-g540c2c4b-dirty # https://github.com/0day-ci/linux/commit/417ce7b0ea8ed268ee0302eb02ee6eaa55f22f9b git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review jmaloy-redhat-com/tipc-some-minor-improvements/20201125-013225 git checkout 417ce7b0ea8ed268ee0302eb02ee6eaa55f22f9b # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot "sparse warnings: (new ones prefixed by >>)" net/tipc/addr.c: note: in included file (through net/tipc/addr.h): >> net/tipc/core.h:218:15: sparse: sparse: cast to restricted __be32 >> net/tipc/core.h:218:15: sparse: sparse: cast to restricted __be32 >> net/tipc/core.h:218:15: sparse: sparse: cast to restricted __be32 >> net/tipc/core.h:218:15: sparse: sparse: cast to restricted __be32 >> net/tipc/core.h:218:15: sparse: sparse: cast to restricted __be32 >> net/tipc/core.h:218:15: sparse: sparse: cast to restricted __be32 net/tipc/core.h:222:27: sparse: sparse: cast to restricted __be32 net/tipc/core.h:222:27: sparse: sparse: cast to restricted __be32 net/tipc/core.h:222:27: sparse: sparse: cast to restricted __be32 net/tipc/core.h:222:27: sparse: sparse: cast to restricted __be32 net/tipc/core.h:222:27: sparse: sparse: cast to restricted __be32 net/tipc/core.h:222:27: sparse: sparse: cast to restricted __be32 vim +218 net/tipc/core.h 213 214 static inline u32 hash128to32(char *bytes) 215 { 216 u32 res, *tmp = (u32 *)bytes; 217 > 218 res = ntohl(tmp[0] ^ tmp[1] ^ tmp[2] ^ tmp[3]); 219 if (likely(res)) 220 return res; 221 res = tmp[0] | tmp[1] | tmp[2] | tmp[3]; 222 return !res ? 0 : ntohl(18140715); 223 } 224 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [PATCH net-next 1/2] ppp: add PPPIOCBRIDGECHAN and PPPIOCUNBRIDGECHAN ioctls
Hi Tom, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Tom-Parkin/add-ppp_generic-ioctl-s-to-bridge-channels/20201126-202933 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 594e31bcebd6b8127ab8bcf37068ecef6c996459 config: alpha-randconfig-s032-20201126 (attached as .config) compiler: alpha-linux-gcc (GCC) 9.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # apt-get install sparse # sparse version: v0.6.3-151-g540c2c4b-dirty # https://github.com/0day-ci/linux/commit/d956f9918541d0b973ce241bd26020c3d08878db git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Tom-Parkin/add-ppp_generic-ioctl-s-to-bridge-channels/20201126-202933 git checkout d956f9918541d0b973ce241bd26020c3d08878db # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=alpha If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot "sparse warnings: (new ones prefixed by >>)" >> drivers/net/ppp/ppp_generic.c:641:9: sparse: sparse: incompatible types in >> comparison expression (different address spaces): >> drivers/net/ppp/ppp_generic.c:641:9: sparse:struct channel [noderef] >> __rcu * >> drivers/net/ppp/ppp_generic.c:641:9: sparse:struct channel * drivers/net/ppp/ppp_generic.c:644:9: sparse: sparse: incompatible types in comparison expression (different address spaces): drivers/net/ppp/ppp_generic.c:644:9: sparse:struct channel [noderef] __rcu * drivers/net/ppp/ppp_generic.c:644:9: sparse:struct channel * drivers/net/ppp/ppp_generic.c:666:16: sparse: sparse: incompatible types in comparison expression (different address spaces): drivers/net/ppp/ppp_generic.c:666:16: sparse:struct channel [noderef] __rcu * drivers/net/ppp/ppp_generic.c:666:16: sparse:struct channel * drivers/net/ppp/ppp_generic.c:672:20: sparse: sparse: incompatible types in comparison expression (different address spaces): drivers/net/ppp/ppp_generic.c:672:20: sparse:struct channel [noderef] __rcu * drivers/net/ppp/ppp_generic.c:672:20: sparse:struct channel * drivers/net/ppp/ppp_generic.c:680:9: sparse: sparse: incompatible types in comparison expression (different address spaces): drivers/net/ppp/ppp_generic.c:680:9: sparse:struct channel [noderef] __rcu * drivers/net/ppp/ppp_generic.c:680:9: sparse:struct channel * drivers/net/ppp/ppp_generic.c:681:9: sparse: sparse: incompatible types in comparison expression (different address spaces): drivers/net/ppp/ppp_generic.c:681:9: sparse:struct channel [noderef] __rcu * drivers/net/ppp/ppp_generic.c:681:9: sparse:struct channel * drivers/net/ppp/ppp_generic.c:2209:16: sparse: sparse: incompatible types in comparison expression (different address spaces): drivers/net/ppp/ppp_generic.c:2209:16: sparse:struct channel [noderef] __rcu * drivers/net/ppp/ppp_generic.c:2209:16: sparse:struct channel * vim +641 drivers/net/ppp/ppp_generic.c 609 610 /* Bridge one PPP channel to another. 611 * When two channels are bridged, ppp_input on one channel is redirected to 612 * the other's ops->start_xmit handler. 613 * In order to safely bridge channels we must reject channels which are already 614 * part of a bridge instance, or which form part of an existing unit. 615 * Once successfully bridged, each channel holds a reference on the other 616 * to prevent it being freed while the bridge is extant. 617 */ 618 static int ppp_bridge_channels(struct channel *pch, struct channel *pchb) 619 { 620 int ret = -EALREADY; 621 622 /* We need to take each channel upl for access to the 'ppp' field, 623 * and each channel downl for write access to the 'bridge' field. 624 */ 625 626 read_lock_bh(&pch->upl); 627 if (pch->ppp) 628 goto out0; 629 630 spin_lock(&pch->downl); 631 632 read_lock_bh(&pchb->upl); 633 if (pchb->ppp) 634 goto out1; 635 636 spin_lock(&pchb->downl); 637 638 if (pch->bridge || pchb->bridge) 639 goto out2; 640 > 641 rcu_assign_pointer(pch->bridge, pchb); 642 refcount_inc(&pchb->file.refcnt); 643 644 rcu_assign_pointer(pchb->bridge, pch); 645 refcount_inc(
[RFC PATCH] net: dsa: ksz8795: ksz8795_adjust_link() can be static
Reported-by: kernel test robot Signed-off-by: kernel test robot --- ksz8795.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/microchip/ksz8795.c b/drivers/net/dsa/microchip/ksz8795.c index 09c1173cc6073c..834a8dc251adba 100644 --- a/drivers/net/dsa/microchip/ksz8795.c +++ b/drivers/net/dsa/microchip/ksz8795.c @@ -,7 +,7 @@ static int ksz8795_setup(struct dsa_switch *ds) return 0; } -void ksz8795_adjust_link(struct dsa_switch *ds, int port, +static void ksz8795_adjust_link(struct dsa_switch *ds, int port, struct phy_device *phydev) { struct ksz_device *dev = ds->priv;
Re: [PATCH 2/2] net: dsa: ksz8795: adjust CPU link to host interface
Hi Jean, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net/master] [also build test WARNING on ipvs/master linus/master v5.10-rc5] [cannot apply to net-next/master next-20201127] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Jean-Pihet/net-dsa-ksz-pad-frame-to-64-bytes-for-transmission/20201129-182750 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git 4d521943f76bd0d1e68ea5e02df7aadd30b2838a config: i386-randconfig-s031-20201129 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.3-170-g3bc348f6-dirty # https://github.com/0day-ci/linux/commit/5a255bc7fbe20060c6f86dfaa0bbe9fbcd024128 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Jean-Pihet/net-dsa-ksz-pad-frame-to-64-bytes-for-transmission/20201129-182750 git checkout 5a255bc7fbe20060c6f86dfaa0bbe9fbcd024128 # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot "sparse warnings: (new ones prefixed by >>)" >> drivers/net/dsa/microchip/ksz8795.c:1114:6: sparse: sparse: symbol >> 'ksz8795_adjust_link' was not declared. Should it be static? Please review and possibly fold the followup patch. --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [PATCH 2/2] net: dsa: ksz8795: adjust CPU link to host interface
Hi Jean, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net/master] [also build test WARNING on ipvs/master linus/master v5.10-rc5] [cannot apply to net-next/master next-20201127] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Jean-Pihet/net-dsa-ksz-pad-frame-to-64-bytes-for-transmission/20201129-182750 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git 4d521943f76bd0d1e68ea5e02df7aadd30b2838a config: x86_64-allyesconfig (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/5a255bc7fbe20060c6f86dfaa0bbe9fbcd024128 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Jean-Pihet/net-dsa-ksz-pad-frame-to-64-bytes-for-transmission/20201129-182750 git checkout 5a255bc7fbe20060c6f86dfaa0bbe9fbcd024128 # save the attached .config to linux build tree make W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/net/dsa/microchip/ksz8795.c:1114:6: warning: no previous prototype >> for 'ksz8795_adjust_link' [-Wmissing-prototypes] 1114 | void ksz8795_adjust_link(struct dsa_switch *ds, int port, | ^~~ vim +/ksz8795_adjust_link +1114 drivers/net/dsa/microchip/ksz8795.c 1113 > 1114 void ksz8795_adjust_link(struct dsa_switch *ds, int port, 1115 struct phy_device *phydev) 1116 { 1117 struct ksz_device *dev = ds->priv; 1118 struct ksz_port *p = &dev->ports[port]; 1119 1120 /* Adjust the link interface mode and speed for the CPU port */ 1121 if (port == dev->cpu_port) 1122 ksz8795_mii_config(dev, p); 1123 } 1124 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [PATCH] netfilter: conntrack: fix -Wformat
Hi Nick, I love your patch! Perhaps something to improve: [auto build test WARNING on nf-next/master] [also build test WARNING on nf/master ipvs/master v5.10-rc3 next-20201109] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Nick-Desaulniers/netfilter-conntrack-fix-Wformat/20201109-085104 base: https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git master config: riscv-randconfig-s031-20201109 (attached as .config) compiler: riscv32-linux-gcc (GCC) 9.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # apt-get install sparse # sparse version: v0.6.3-76-gf680124b-dirty # https://github.com/0day-ci/linux/commit/407a53117fa32f8f17a73a51bced0e85f168acb4 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Nick-Desaulniers/netfilter-conntrack-fix-Wformat/20201109-085104 git checkout 407a53117fa32f8f17a73a51bced0e85f168acb4 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=riscv If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot "sparse warnings: (new ones prefixed by >>)" >> net/netfilter/nf_conntrack_standalone.c:56:29: sparse: sparse: cast to >> restricted __be16 net/netfilter/nf_conntrack_standalone.c:60:29: sparse: sparse: cast to restricted __be16 net/netfilter/nf_conntrack_standalone.c:61:29: sparse: sparse: cast to restricted __be16 net/netfilter/nf_conntrack_standalone.c:66:29: sparse: sparse: cast to restricted __be16 net/netfilter/nf_conntrack_standalone.c:67:29: sparse: sparse: cast to restricted __be16 net/netfilter/nf_conntrack_standalone.c:72:29: sparse: sparse: cast to restricted __be16 net/netfilter/nf_conntrack_standalone.c:73:29: sparse: sparse: cast to restricted __be16 net/netfilter/nf_conntrack_standalone.c:77:29: sparse: sparse: cast to restricted __be16 net/netfilter/nf_conntrack_standalone.c:78:29: sparse: sparse: cast to restricted __be16 net/netfilter/nf_conntrack_standalone.c:84:29: sparse: sparse: cast to restricted __be16 vim +56 net/netfilter/nf_conntrack_standalone.c 32 33 #ifdef CONFIG_NF_CONNTRACK_PROCFS 34 void 35 print_tuple(struct seq_file *s, const struct nf_conntrack_tuple *tuple, 36 const struct nf_conntrack_l4proto *l4proto) 37 { 38 switch (tuple->src.l3num) { 39 case NFPROTO_IPV4: 40 seq_printf(s, "src=%pI4 dst=%pI4 ", 41 &tuple->src.u3.ip, &tuple->dst.u3.ip); 42 break; 43 case NFPROTO_IPV6: 44 seq_printf(s, "src=%pI6 dst=%pI6 ", 45 tuple->src.u3.ip6, tuple->dst.u3.ip6); 46 break; 47 default: 48 break; 49 } 50 51 switch (l4proto->l4proto) { 52 case IPPROTO_ICMP: 53 seq_printf(s, "type=%u code=%u id=%hu ", 54 tuple->dst.u.icmp.type, 55 tuple->dst.u.icmp.code, > 56 (__be16)ntohs(tuple->src.u.icmp.id)); 57 break; 58 case IPPROTO_TCP: 59 seq_printf(s, "sport=%hu dport=%hu ", 60 (__be16)ntohs(tuple->src.u.tcp.port), 61 (__be16)ntohs(tuple->dst.u.tcp.port)); 62 break; 63 case IPPROTO_UDPLITE: 64 case IPPROTO_UDP: 65 seq_printf(s, "sport=%hu dport=%hu ", 66 (__be16)ntohs(tuple->src.u.udp.port), 67 (__be16)ntohs(tuple->dst.u.udp.port)); 68 69 break; 70 case IPPROTO_DCCP: 71 seq_printf(s, "sport=%hu dport=%hu ", 72 (__be16)ntohs(tuple->src.u.dccp.port), 73 (__be16)ntohs(tuple->dst.u.dccp.port)); 74 break; 75 case IPPROTO_SCTP: 76 seq_printf(s, "sport=%hu dport=%hu ", 77 (__be16)ntohs(tuple->src.u.sctp.port), 78 (__be16)ntohs(tuple->dst.u.sctp.port)); 79
Re: Re: [PATCH net-next] net: Variable SLAAC: SLAAC with prefixes of arbitrary length in PIO
Hi Dmytro, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Dmytro-Shytyi/Re-PATCH-net-next-net-Variable-SLAAC-SLAAC-with-prefixes-of-arbitrary-length-in-PIO/2020-014800 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 8be33ecfc1ffd2da20cc29e957e4cb6eb99310cb config: sh-allmodconfig (attached as .config) compiler: sh4-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/0d851d20831574b490bbb131cb68f722dc2419ca git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Dmytro-Shytyi/Re-PATCH-net-next-net-Variable-SLAAC-SLAAC-with-prefixes-of-arbitrary-length-in-PIO/2020-014800 git checkout 0d851d20831574b490bbb131cb68f722dc2419ca # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All error/warnings (new ones prefixed by >>): net/ipv6/addrconf.c: In function 'ipv6_create_tempaddr': >> net/ipv6/addrconf.c:1329:2: error: expected expression before '__int128' 1329 | __int128 host_id; | ^~~~ net/ipv6/addrconf.c:1330:2: error: expected expression before '__int128' 1330 | __int128 net_prfx; | ^~~~ net/ipv6/addrconf.c:1331:2: error: expected expression before '__int128' 1331 | __int128 ipv6addr; | ^~~~ net/ipv6/addrconf.c:1332:2: error: expected expression before '__int128' 1332 | __int128 mask_128; | ^~~~ net/ipv6/addrconf.c:1333:2: error: expected expression before '__int128' 1333 | __int128 mask_host_id; | ^~~~ net/ipv6/addrconf.c:1334:2: error: expected expression before '__int128' 1334 | __int128 mask_net_prfx; | ^~~~ >> net/ipv6/addrconf.c:1335:2: warning: ISO C90 forbids mixed declarations and >> code [-Wdeclaration-after-statement] 1335 | int i; | ^~~ >> net/ipv6/addrconf.c:1338:10: error: 'mask_128' undeclared (first use in this >> function) 1338 | memset(&mask_128, 0xFF, 16); | ^~~~ net/ipv6/addrconf.c:1338:10: note: each undeclared identifier is reported only once for each function it appears in >> net/ipv6/addrconf.c:1370:11: error: 'host_id' undeclared (first use in this >> function) 1370 | memcpy(&host_id, temp.s6_addr32, sizeof(host_id)); | ^~~ >> net/ipv6/addrconf.c:1371:11: error: 'net_prfx' undeclared (first use in this >> function) 1371 | memcpy(&net_prfx, addr.s6_addr, sizeof(net_prfx)); | ^~~~ >> net/ipv6/addrconf.c:1373:3: error: 'mask_host_id' undeclared (first use in >> this function); did you mean 'mask_host_id_arr'? 1373 | mask_host_id = ifp->prefix_len != 128 ? (mask_128 << ifp->prefix_len) : 0x0; | ^~~~ | mask_host_id_arr >> net/ipv6/addrconf.c:1380:3: error: 'mask_net_prfx' undeclared (first use in >> this function) 1380 | mask_net_prfx = mask_128 ^ mask_host_id; | ^ >> net/ipv6/addrconf.c:1383:3: error: 'ipv6addr' undeclared (first use in this >> function); did you mean 'ipv6_hdr'? 1383 | ipv6addr = net_prfx | host_id; | ^~~~ | ipv6_hdr net/ipv6/addrconf.c: In function 'addrconf_prefix_rcv_add_addr': net/ipv6/addrconf.c:2626:3: error: expected expression before '__int128' 2626 | __int128 mask_128; | ^~~~ net/ipv6/addrconf.c:2627:3: error: expected expression before '__int128' 2627 | __int128 mask_net_prfx; | ^~~~ net/ipv6/addrconf.c:2628:3: error: expected expression before '__int128' 2628 | __int128 net_prfx; | ^~~~ net/ipv6/addrconf.c:2629:3: error: expected expression before '__int128' 2629 | __int128 curr_net_prfx; | ^~~~ net/ipv6/addrconf.c:2630:3: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] 2630 | int hostid_len; | ^~~ net/ipv6/addrconf.c:2634:11: error: 'mask_128' undeclared (first use in this function) 2634 | memset(&mask_128, 0xFF, 16); | ^~~~ net/ipv6/addrconf.c:2642:4: error: 'mask_net_prfx' undeclared (first use in this function) 2642 |mask
Re: [PATCH bpf-next v2 5/5] i40e: use batched xsk Tx interfaces to increase performance
Hi Magnus, I love your patch! Perhaps something to improve: [auto build test WARNING on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Magnus-Karlsson/xsk-i40e-Tx-performance-improvements/20201110-190310 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master config: powerpc64-randconfig-r025-20201110 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 4d81c8adb6ed9840257f6cb6b93f60856d422a15) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install powerpc64 cross compiling tool for clang build # apt-get install binutils-powerpc64-linux-gnu # https://github.com/0day-ci/linux/commit/b016bbeac6692a93e61b28efa430d64645032b5e git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Magnus-Karlsson/xsk-i40e-Tx-performance-improvements/20201110-190310 git checkout b016bbeac6692a93e61b28efa430d64645032b5e # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/net/ethernet/intel/i40e/i40e_xsk.c:417:13: warning: unknown pragma >> ignored [-Wunknown-pragmas] #pragma GCC unroll 4 ^ 1 warning generated. vim +417 drivers/net/ethernet/intel/i40e/i40e_xsk.c 408 409 static void i40e_xmit_pkt_batch(struct i40e_ring *xdp_ring, struct xdp_desc *desc, 410 unsigned int *total_bytes) 411 { 412 u16 ntu = xdp_ring->next_to_use; 413 struct i40e_tx_desc *tx_desc; 414 dma_addr_t dma; 415 u32 i; 416 > 417 #pragma GCC unroll 4 418 for (i = 0; i < PKTS_PER_BATCH; i++) { 419 dma = xsk_buff_raw_get_dma(xdp_ring->xsk_pool, desc[i].addr); 420 xsk_buff_raw_dma_sync_for_device(xdp_ring->xsk_pool, dma, desc[i].len); 421 422 tx_desc = I40E_TX_DESC(xdp_ring, ntu++); 423 tx_desc->buffer_addr = cpu_to_le64(dma); 424 tx_desc->cmd_type_offset_bsz = build_ctob(I40E_TX_DESC_CMD_ICRC | 425 I40E_TX_DESC_CMD_EOP, 4260, desc[i].len, 0); 427 428 *total_bytes += desc[i].len; 429 } 430 431 xdp_ring->next_to_use = ntu; 432 } 433 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [PATCH v5] can: usb: etas_es58X: add support for ETAS ES58X CAN USB interfaces
Hi Vincent, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.10-rc3 next-20201110] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Vincent-Mailhol/can-usb-etas_es58X-add-support-for-ETAS-ES58X-CAN-USB-interfaces/20201109-094004 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 521b619acdc8f1f5acdac15b84f81fd9515b2aff config: i386-randconfig-a012-20201110 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/879dffec30f6576b5fdea872e5d3c71965f902ca git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Vincent-Mailhol/can-usb-etas_es58X-add-support-for-ETAS-ES58X-CAN-USB-interfaces/20201109-094004 git checkout 879dffec30f6576b5fdea872e5d3c71965f902ca # save the attached .config to linux build tree make W=1 ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): drivers/net/can/usb/etas_es58x/es58x_core.c: In function 'es58x_rx_can_msg': drivers/net/can/usb/etas_es58x/es58x_core.c:745:12: error: 'CAN_MAX_RAW_DLC' undeclared (first use in this function); did you mean 'CAN_MAX_DLC'? 745 | if (dlc > CAN_MAX_RAW_DLC) { |^~~ |CAN_MAX_DLC drivers/net/can/usb/etas_es58x/es58x_core.c:745:12: note: each undeclared identifier is reported only once for each function it appears in drivers/net/can/usb/etas_es58x/es58x_core.c:756:9: error: implicit declaration of function 'can_get_cc_len'; did you mean 'can_get_echo_skb'? [-Werror=implicit-function-declaration] 756 | len = can_get_cc_len(dlc); | ^~ | can_get_echo_skb drivers/net/can/usb/etas_es58x/es58x_core.c:775:6: error: 'struct can_frame' has no member named 'len8_dlc' 775 | ccf->len8_dlc = can_get_len8_dlc(es58x_priv(netdev)->can.ctrlmode, | ^~ >> drivers/net/can/usb/etas_es58x/es58x_core.c:775:19: error: implicit >> declaration of function 'can_get_len8_dlc'; did you mean 'can_len2dlc'? >> [-Werror=implicit-function-declaration] 775 | ccf->len8_dlc = can_get_len8_dlc(es58x_priv(netdev)->can.ctrlmode, | ^~~~ | can_len2dlc cc1: some warnings being treated as errors -- drivers/net/can/usb/etas_es58x/es581_4.c: In function 'es581_4_tx_can_msg': drivers/net/can/usb/etas_es58x/es581_4.c:385:20: error: implicit declaration of function 'can_get_cc_dlc'; did you mean 'can_get_echo_skb'? [-Werror=implicit-function-declaration] 385 | tx_can_msg->dlc = can_get_cc_dlc(priv->can.ctrlmode, |^~ |can_get_echo_skb >> drivers/net/can/usb/etas_es58x/es581_4.c:386:9: error: 'struct can_frame' >> has no member named 'len' 386 | cf->len, cf->len8_dlc); | ^~ drivers/net/can/usb/etas_es58x/es581_4.c:386:18: error: 'struct can_frame' has no member named 'len8_dlc' 386 | cf->len, cf->len8_dlc); | ^~ In file included from arch/x86/include/asm/string.h:3, from include/linux/string.h:20, from include/linux/uuid.h:12, from include/linux/mod_devicetable.h:13, from include/linux/usb.h:5, from drivers/net/can/usb/etas_es58x/es58x_core.h:16, from drivers/net/can/usb/etas_es58x/es581_4.c:15: drivers/net/can/usb/etas_es58x/es581_4.c:388:39: error: 'struct can_frame' has no member named 'len' 388 | memcpy(tx_can_msg->data, cf->data, cf->len); | ^~ arch/x86/include/asm/string_32.h:182:48: note: in definition of macro 'memcpy' 182 | #define memcpy(t, f, n) __builtin_memcpy(t, f, n) |^ In file included from : drivers/net/can/usb/etas_es58x/es581_4.c:30:29: error: implicit declaration of function 'can_get_cc_len'; did you mean 'can_get_echo_skb'? [-Werror=implicit-function-declaration] 30 | offsetof(typeof(msg), data[can_get_cc_len((msg).dlc)]) | ^~ include/linux/compiler_types.h
Re: [PATCH v4 bpf-next 4/5] bpf: load and verify kernel module BTFs
Hi Andrii, I love your patch! Perhaps something to improve: [auto build test WARNING on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Andrii-Nakryiko/Integrate-kernel-module-BTF-support/20201110-095309 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master config: mips-randconfig-r002-20201110 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 4d81c8adb6ed9840257f6cb6b93f60856d422a15) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install mips cross compiling tool for clang build # apt-get install binutils-mips-linux-gnu # https://github.com/0day-ci/linux/commit/dcd763b7808fdc01ebf70bbe07ba92388df4d20d git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Andrii-Nakryiko/Integrate-kernel-module-BTF-support/20201110-095309 git checkout dcd763b7808fdc01ebf70bbe07ba92388df4d20d # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=mips If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> kernel/bpf/btf.c:4481:20: warning: unused function 'btf_parse_module' static struct btf char const void unsigned int data_size) ^ fatal error: error in backend: Nested variants found in inline asm string: ' .set push .set mips64r2 .if ( 0x00 ) != -1)) 0x00 ) != -1)) : ($( static struct ftrace_branch_data __attribute__((__aligned__(4))) __attribute__((__section__("_ftrace_branch"))) __if_trace = $( .func = __func__, .file = "arch/mips/include/asm/atomic.h", .line = 154, $); 0x00 ) != -1)) : $))) ) && ( 0 ); .set push; .set mips64r2; .rept 1; sync 0x00; .endr; .set pop; .else; ; .endif 1: ll $1, $2 # atomic_fetch_sub subu $0, $1, $3 sc $0, $2 beqz $0, 1b .set pop move $0, $1 ' clang-12: error: clang frontend command failed with exit code 70 (use -v to see invocation) clang version 12.0.0 (git://gitmirror/llvm_project 874b0a0b9db93f5d3350ffe6b5efda2d908415d0) Target: mipsel-unknown-linux-gnu Thread model: posix InstalledDir: /opt/cross/clang-874b0a0b9d/bin clang-12: note: diagnostic msg: Makefile arch drivers include kernel mm scripts source usr vim +/btf_parse_module +4481 kernel/bpf/btf.c 4480 > 4481 static struct btf *btf_parse_module(const char *module_name, const void > *data, unsigned int data_size) 4482 { 4483 struct btf_verifier_env *env = NULL; 4484 struct bpf_verifier_log *log; 4485 struct btf *btf = NULL, *base_btf; 4486 int err; 4487 4488 base_btf = bpf_get_btf_vmlinux(); 4489 if (IS_ERR(base_btf)) 4490 return base_btf; 4491 if (!base_btf) 4492 return ERR_PTR(-EINVAL); 4493 4494 env = kzalloc(sizeof(*env), GFP_KERNEL | __GFP_NOWARN); 4495 if (!env) 4496 return ERR_PTR(-ENOMEM); 4497 4498 log = &env->log; 4499 log->level = BPF_LOG_KERNEL; 4500 4501 btf = kzalloc(sizeof(*btf), GFP_KERNEL | __GFP_NOWARN); 4502 if (!btf) { 4503 err = -ENOMEM; 4504 goto errout; 4505 } 4506 env->btf = btf; 4507 4508 btf->base_btf = base_btf; 4509 btf->start_id = base_btf->nr_types; 4510 btf->start_str_off = base_btf->hdr.str_len; 4511 btf->kernel_btf = true; 4512 snprintf(btf->name, sizeof(btf->name), "%s", module_name); 4513 4514 btf->data = kvmalloc(data_size, GFP_KERNEL | __GFP_NOWARN); 4515 if (!btf->data) { 4516 err = -ENOMEM; 4517 goto errout; 4518 } 4519 memcpy(btf->data, data, data_size); 4520 btf->data_size = data_size; 4521 4522 err = btf_parse_hdr(env); 4523 if (err) 4524 goto errout; 4525 4526 btf->nohdr_data = btf->data + btf->hdr.hdr_len; 4527 4528 err = btf_parse_str_sec(env); 4529 if (err) 4530 goto errout; 4531 4532 err = btf_check_all_metas(env); 4533 if (err) 4534 goto errout; 4535 4536 btf_verifier_env_free(env); 4537 refcount_set(&btf->refcnt, 1); 4538 return btf; 4539 4540 errout: 4541 btf_verifier_env_free(env); 4542 if (btf) { 4543 kvfree(btf->data); 4544 kvfree
Re: [PATCH v15 7/9] ptp: arm/arm64: Enable ptp_kvm for arm/arm64
Hi Jianyong, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.10-rc3 next-20201110] [cannot apply to tip/timers/core kvmarm/next kvm/linux-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Jianyong-Wu/Enable-ptp_kvm-for-arm-arm64/2020-142600 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git eccc876724927ff3b9ff91f36f7b6b159e948f0c config: arm64-randconfig-r016-2020 (attached as .config) compiler: aarch64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/94d44d1bc7bec0d91d4c4851dd935a752bffe07d git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Jianyong-Wu/Enable-ptp_kvm-for-arm-arm64/2020-142600 git checkout 94d44d1bc7bec0d91d4c4851dd935a752bffe07d # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/clocksource/arm_arch_timer.c:1655:5: warning: no previous prototype >> for 'kvm_arch_ptp_get_crosststamp' [-Wmissing-prototypes] 1655 | int kvm_arch_ptp_get_crosststamp(u64 *cycle, struct timespec64 *ts, | ^~~~ -- >> drivers/ptp/ptp_kvm_arm.c:19:5: warning: no previous prototype for >> 'kvm_arch_ptp_init' [-Wmissing-prototypes] 19 | int kvm_arch_ptp_init(void) | ^ >> drivers/ptp/ptp_kvm_arm.c:30:5: warning: no previous prototype for >> 'kvm_arch_ptp_get_clock' [-Wmissing-prototypes] 30 | int kvm_arch_ptp_get_clock(struct timespec64 *ts) | ^~ vim +/kvm_arch_ptp_get_crosststamp +1655 drivers/clocksource/arm_arch_timer.c 1654 > 1655 int kvm_arch_ptp_get_crosststamp(u64 *cycle, struct timespec64 *ts, --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [PATCH v15 3/9] ptp: Reorganize ptp_kvm module to make it arch-independent.
Hi Jianyong, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.10-rc3 next-2020] [cannot apply to tip/timers/core kvmarm/next kvm/linux-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Jianyong-Wu/Enable-ptp_kvm-for-arm-arm64/2020-142600 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git eccc876724927ff3b9ff91f36f7b6b159e948f0c config: i386-randconfig-p002-2020 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/8cc52e023b81a9f561cc2094ecdd7266f5e29230 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Jianyong-Wu/Enable-ptp_kvm-for-arm-arm64/2020-142600 git checkout 8cc52e023b81a9f561cc2094ecdd7266f5e29230 # save the attached .config to linux build tree make W=1 ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/ptp/ptp_kvm_x86.c:21:5: warning: no previous prototype for >> 'kvm_arch_ptp_init' [-Wmissing-prototypes] 21 | int kvm_arch_ptp_init(void) | ^ >> drivers/ptp/ptp_kvm_x86.c:41:5: warning: no previous prototype for >> 'kvm_arch_ptp_get_clock' [-Wmissing-prototypes] 41 | int kvm_arch_ptp_get_clock(struct timespec64 *ts) | ^~ >> drivers/ptp/ptp_kvm_x86.c:59:5: warning: no previous prototype for >> 'kvm_arch_ptp_get_crosststamp' [-Wmissing-prototypes] 59 | int kvm_arch_ptp_get_crosststamp(u64 *cycle, struct timespec64 *tspec, | ^~~~ vim +/kvm_arch_ptp_init +21 drivers/ptp/ptp_kvm_x86.c 20 > 21 int kvm_arch_ptp_init(void) 22 { 23 long ret; 24 25 if (!kvm_para_available()) 26 return -ENODEV; 27 28 clock_pair_gpa = slow_virt_to_phys(&clock_pair); 29 hv_clock = pvclock_get_pvti_cpu0_va(); 30 if (!hv_clock) 31 return -ENODEV; 32 33 ret = kvm_hypercall2(KVM_HC_CLOCK_PAIRING, clock_pair_gpa, 34 KVM_CLOCK_PAIRING_WALLCLOCK); 35 if (ret == -KVM_ENOSYS || ret == -KVM_EOPNOTSUPP) 36 return -ENODEV; 37 38 return 0; 39 } 40 > 41 int kvm_arch_ptp_get_clock(struct timespec64 *ts) 42 { 43 unsigned long ret; 44 45 ret = kvm_hypercall2(KVM_HC_CLOCK_PAIRING, 46 clock_pair_gpa, 47 KVM_CLOCK_PAIRING_WALLCLOCK); 48 if (ret != 0) { 49 pr_err_ratelimited("clock offset hypercall ret %lu\n", ret); 50 return -EOPNOTSUPP; 51 } 52 53 ts->tv_sec = clock_pair.sec; 54 ts->tv_nsec = clock_pair.nsec; 55 56 return 0; 57 } 58 > 59 int kvm_arch_ptp_get_crosststamp(u64 *cycle, struct timespec64 *tspec, --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [PATCH v15 7/9] ptp: arm/arm64: Enable ptp_kvm for arm/arm64
Hi Jianyong, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.10-rc3 next-2020] [cannot apply to tip/timers/core kvmarm/next kvm/linux-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Jianyong-Wu/Enable-ptp_kvm-for-arm-arm64/2020-142600 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git eccc876724927ff3b9ff91f36f7b6b159e948f0c config: arm-milbeaut_m10v_defconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/94d44d1bc7bec0d91d4c4851dd935a752bffe07d git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Jianyong-Wu/Enable-ptp_kvm-for-arm-arm64/2020-142600 git checkout 94d44d1bc7bec0d91d4c4851dd935a752bffe07d # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): arch/arm/vfp/vfphw.o: in function `vfp_support_entry': (.text+0xa): relocation truncated to fit: R_ARM_THM_JUMP19 against symbol `vfp_kmode_exception' defined in .text.unlikely section in arch/arm/vfp/vfpmodule.o arm-linux-gnueabi-ld: arch/arm/kernel/setup.o: in function `setup_arch': setup.c:(.init.text+0xaa2): undefined reference to `kvm_init_hyp_services' arm-linux-gnueabi-ld: drivers/clocksource/arm_arch_timer.o: in function `kvm_arch_ptp_get_crosststamp': >> arm_arch_timer.c:(.text+0x202): undefined reference to >> `arm_smccc_1_1_get_conduit' --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [PATCH v15 3/9] ptp: Reorganize ptp_kvm module to make it arch-independent.
Hi Jianyong, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.10-rc3 next-2020] [cannot apply to tip/timers/core kvmarm/next kvm/linux-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Jianyong-Wu/Enable-ptp_kvm-for-arm-arm64/2020-142600 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git eccc876724927ff3b9ff91f36f7b6b159e948f0c config: x86_64-randconfig-a005-2020 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 874b0a0b9db93f5d3350ffe6b5efda2d908415d0) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # https://github.com/0day-ci/linux/commit/8cc52e023b81a9f561cc2094ecdd7266f5e29230 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Jianyong-Wu/Enable-ptp_kvm-for-arm-arm64/2020-142600 git checkout 8cc52e023b81a9f561cc2094ecdd7266f5e29230 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/ptp/ptp_kvm_x86.c:21:5: warning: no previous prototype for function >> 'kvm_arch_ptp_init' [-Wmissing-prototypes] int kvm_arch_ptp_init(void) ^ drivers/ptp/ptp_kvm_x86.c:21:1: note: declare 'static' if the function is not intended to be used outside of this translation unit int kvm_arch_ptp_init(void) ^ static >> drivers/ptp/ptp_kvm_x86.c:41:5: warning: no previous prototype for function >> 'kvm_arch_ptp_get_clock' [-Wmissing-prototypes] int kvm_arch_ptp_get_clock(struct timespec64 *ts) ^ drivers/ptp/ptp_kvm_x86.c:41:1: note: declare 'static' if the function is not intended to be used outside of this translation unit int kvm_arch_ptp_get_clock(struct timespec64 *ts) ^ static >> drivers/ptp/ptp_kvm_x86.c:59:5: warning: no previous prototype for function >> 'kvm_arch_ptp_get_crosststamp' [-Wmissing-prototypes] int kvm_arch_ptp_get_crosststamp(u64 *cycle, struct timespec64 *tspec, ^ drivers/ptp/ptp_kvm_x86.c:59:1: note: declare 'static' if the function is not intended to be used outside of this translation unit int kvm_arch_ptp_get_crosststamp(u64 *cycle, struct timespec64 *tspec, ^ static 3 warnings generated. vim +/kvm_arch_ptp_init +21 drivers/ptp/ptp_kvm_x86.c 20 > 21 int kvm_arch_ptp_init(void) 22 { 23 long ret; 24 25 if (!kvm_para_available()) 26 return -ENODEV; 27 28 clock_pair_gpa = slow_virt_to_phys(&clock_pair); 29 hv_clock = pvclock_get_pvti_cpu0_va(); 30 if (!hv_clock) 31 return -ENODEV; 32 33 ret = kvm_hypercall2(KVM_HC_CLOCK_PAIRING, clock_pair_gpa, 34 KVM_CLOCK_PAIRING_WALLCLOCK); 35 if (ret == -KVM_ENOSYS || ret == -KVM_EOPNOTSUPP) 36 return -ENODEV; 37 38 return 0; 39 } 40 > 41 int kvm_arch_ptp_get_clock(struct timespec64 *ts) 42 { 43 unsigned long ret; 44 45 ret = kvm_hypercall2(KVM_HC_CLOCK_PAIRING, 46 clock_pair_gpa, 47 KVM_CLOCK_PAIRING_WALLCLOCK); 48 if (ret != 0) { 49 pr_err_ratelimited("clock offset hypercall ret %lu\n", ret); 50 return -EOPNOTSUPP; 51 } 52 53 ts->tv_sec = clock_pair.sec; 54 ts->tv_nsec = clock_pair.nsec; 55 56 return 0; 57 } 58 > 59 int kvm_arch_ptp_get_crosststamp(u64 *cycle, struct timespec64 *tspec, --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [PATCH v8 net-next 3/3] net/sched: act_frag: add implict packet fragment support.
Hi, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/wenxu-ucloud-cn/net-sched-fix-over-mtu-packet-of-defrag-in/2020-143001 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 70408949a35f1a31c327c69b6a187635cb0305fa :: branch date: 3 hours ago :: commit date: 3 hours ago config: x86_64-randconfig-s021-2020 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.3-106-gd020cf33-dirty # https://github.com/0day-ci/linux/commit/a551316818f8b3f9164d7a734538decca3762fda git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review wenxu-ucloud-cn/net-sched-fix-over-mtu-packet-of-defrag-in/2020-143001 git checkout a551316818f8b3f9164d7a734538decca3762fda # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot "sparse warnings: (new ones prefixed by >>)" net/sched/act_api.c:30:5: sparse: sparse: symbol 'tcf_set_xmit_hook' redeclared with different type (incompatible argument 1 (different address spaces)): >> net/sched/act_api.c:30:5: sparse:int extern [addressable] [signed] >> [toplevel] tcf_set_xmit_hook( ... ) net/sched/act_api.c: note: in included file (through include/net/pkt_cls.h): include/net/act_api.h:244:5: sparse: note: previously declared as: >> include/net/act_api.h:244:5: sparse:int extern [addressable] [signed] >> [toplevel] tcf_set_xmit_hook( ... ) >> net/sched/act_api.c:64:19: sparse: sparse: incorrect type in assignment >> (different address spaces) @@ expected int ( [noderef] __rcu *xmit_hook >> )( ... ) @@ got int ( [noderef] * )( ... ) @@ >> net/sched/act_api.c:64:19: sparse: expected int ( [noderef] __rcu >> *xmit_hook )( ... ) net/sched/act_api.c:64:19: sparse: got int ( [noderef] * )( ... ) vim +30 net/sched/act_api.c a551316818f8b3f wenxu 2020-11-11 29 a551316818f8b3f wenxu 2020-11-11 @30 int tcf_set_xmit_hook(int (__rcu *xmit_hook)(struct sk_buff *skb, a551316818f8b3f wenxu 2020-11-11 31 int (*xmit)(struct sk_buff *skb))) a551316818f8b3f wenxu 2020-11-11 32 { a551316818f8b3f wenxu 2020-11-11 33spin_lock(&tcf_xmit_hook_lock); a551316818f8b3f wenxu 2020-11-11 34if (!tcf_xmit_hook_count) { a551316818f8b3f wenxu 2020-11-11 35 rcu_assign_pointer(tcf_xmit_hook, xmit_hook); a551316818f8b3f wenxu 2020-11-11 36} else if (xmit_hook != tcf_xmit_hook) { a551316818f8b3f wenxu 2020-11-11 37 spin_unlock(&tcf_xmit_hook_lock); a551316818f8b3f wenxu 2020-11-11 38return -EBUSY; a551316818f8b3f wenxu 2020-11-11 39} a551316818f8b3f wenxu 2020-11-11 40 a551316818f8b3f wenxu 2020-11-11 41tcf_xmit_hook_count++; a551316818f8b3f wenxu 2020-11-11 42spin_unlock(&tcf_xmit_hook_lock); a551316818f8b3f wenxu 2020-11-11 43 a551316818f8b3f wenxu 2020-11-11 44return 0; a551316818f8b3f wenxu 2020-11-11 45 } a551316818f8b3f wenxu 2020-11-11 46 EXPORT_SYMBOL_GPL(tcf_set_xmit_hook); a551316818f8b3f wenxu 2020-11-11 47 a551316818f8b3f wenxu 2020-11-11 48 void tcf_clear_xmit_hook(void) a551316818f8b3f wenxu 2020-11-11 49 { a551316818f8b3f wenxu 2020-11-11 50spin_lock(&tcf_xmit_hook_lock); a551316818f8b3f wenxu 2020-11-11 51if (--tcf_xmit_hook_count == 0) a551316818f8b3f wenxu 2020-11-11 52 rcu_assign_pointer(tcf_xmit_hook, NULL); a551316818f8b3f wenxu 2020-11-11 53spin_unlock(&tcf_xmit_hook_lock); a551316818f8b3f wenxu 2020-11-11 54 a551316818f8b3f wenxu 2020-11-11 55synchronize_rcu(); a551316818f8b3f wenxu 2020-11-11 56 } a551316818f8b3f wenxu 2020-11-11 57 EXPORT_SYMBOL_GPL(tcf_clear_xmit_hook); a551316818f8b3f wenxu 2020-11-11 58 a551316818f8b3f wenxu 2020-11-11 59 int tcf_dev_queue_xmit(struct sk_buff *skb, int (*xmit)(struct sk_buff *skb)) a551316818f8b3f wenxu 2020-11-11 60 { a551316818f8b3f wenxu 2020-11-11 61int (__rcu *xmit_hook)(struct sk_buff *skb, a551316818f8b3f wenxu 2020-11-11 62 int (*xmit)(struct sk_buff *skb)); a551316818f8b3f wenxu 2020-11-11 63 a551316818f8b3f wenxu 2020-11-11 @64xmit_hook = rcu_dereference(tcf_xmit_hook); a551316818f8b3f wenxu 2020-11-11 65if (xmit_hook) a551316818f8b3f wenxu 2020-11-11 66return xmit_hook(skb, xmit); a551316818f8b3f wenxu 2020-11-11 67else a551316818f8b3f wenxu 2020-11-11 68return xmit(skb); a551316818f8b3f wenxu 2020-11-11 69 } a551316818f8b3f wenxu 2020-11-11 70 EXPORT_SYMBOL_GPL(tcf_dev_
Re: [net-next 1/8] tcp: Copy straggler unaligned data for TCP Rx. zerocopy.
Hi Arjun, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Arjun-Roy/Perf-optimizations-for-TCP-Recv-Zerocopy/20201113-030506 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git e545f86573937142b8a90bd65d476b9f001088cf config: nds32-defconfig (attached as .config) compiler: nds32le-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/5c20c7c34817692f87427a655374172fd8ed git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Arjun-Roy/Perf-optimizations-for-TCP-Recv-Zerocopy/20201113-030506 git checkout 5c20c7c34817692f87427a655374172fd8ed # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nds32 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): net/ipv4/tcp.c: In function 'tcp_copy_straggler_data': >> net/ipv4/tcp.c:1754:34: warning: cast to pointer from integer of different >> size [-Wint-to-pointer-cast] 1754 | err = import_single_range(READ, (void __user *)zc->copybuf_address, | ^ vim +1754 net/ipv4/tcp.c 1745 1746 static int tcp_copy_straggler_data(struct tcp_zerocopy_receive *zc, 1747 struct sk_buff *skb, u32 copylen, 1748 u32 *offset, u32 *seq) 1749 { 1750 struct msghdr msg = {}; 1751 struct iovec iov; 1752 int err; 1753 > 1754 err = import_single_range(READ, (void __user > *)zc->copybuf_address, 1755copylen, &iov, &msg.msg_iter); 1756 if (err) 1757 return err; 1758 err = skb_copy_datagram_msg(skb, *offset, &msg, copylen); 1759 if (err) 1760 return err; 1761 zc->recv_skip_hint -= copylen; 1762 *offset += copylen; 1763 *seq += copylen; 1764 return (__s32)copylen; 1765 } 1766 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [net-next,v2,4/5] seg6: add support for the SRv6 End.DT4 behavior
Hi Andrea, Thank you for the patch! Yet something to improve: [auto build test ERROR on ipvs/master] [also build test ERROR on linus/master sparc-next/master v5.10-rc3 next-20201112] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Andrea-Mayer/seg6-add-support-for-the-SRv6-End-DT4-behavior/20201109-093019 base: https://git.kernel.org/pub/scm/linux/kernel/git/horms/ipvs.git master config: x86_64-randconfig-a005-2020 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 874b0a0b9db93f5d3350ffe6b5efda2d908415d0) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # https://github.com/0day-ci/linux/commit/761138e2f757ac64efe97b03311c976db242dc92 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Andrea-Mayer/seg6-add-support-for-the-SRv6-End-DT4-behavior/20201109-093019 git checkout 761138e2f757ac64efe97b03311c976db242dc92 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): >> net/ipv6/seg6_local.c:793:4: error: field designator 'slwt_ops' does not >> refer to any field in type 'struct seg6_action_desc' .slwt_ops = { ^ >> net/ipv6/seg6_local.c:826:10: error: invalid application of 'sizeof' to an >> incomplete type 'struct seg6_action_desc []' count = ARRAY_SIZE(seg6_action_table); ^ include/linux/kernel.h:48:32: note: expanded from macro 'ARRAY_SIZE' #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr)) ^ 2 errors generated. vim +793 net/ipv6/seg6_local.c 757 758 static struct seg6_action_desc seg6_action_table[] = { 759 { 760 .action = SEG6_LOCAL_ACTION_END, 761 .attrs = 0, 762 .input = input_action_end, 763 }, 764 { 765 .action = SEG6_LOCAL_ACTION_END_X, 766 .attrs = (1 << SEG6_LOCAL_NH6), 767 .input = input_action_end_x, 768 }, 769 { 770 .action = SEG6_LOCAL_ACTION_END_T, 771 .attrs = (1 << SEG6_LOCAL_TABLE), 772 .input = input_action_end_t, 773 }, 774 { 775 .action = SEG6_LOCAL_ACTION_END_DX2, 776 .attrs = (1 << SEG6_LOCAL_OIF), 777 .input = input_action_end_dx2, 778 }, 779 { 780 .action = SEG6_LOCAL_ACTION_END_DX6, 781 .attrs = (1 << SEG6_LOCAL_NH6), 782 .input = input_action_end_dx6, 783 }, 784 { 785 .action = SEG6_LOCAL_ACTION_END_DX4, 786 .attrs = (1 << SEG6_LOCAL_NH4), 787 .input = input_action_end_dx4, 788 }, 789 { 790 .action = SEG6_LOCAL_ACTION_END_DT4, 791 .attrs = (1 << SEG6_LOCAL_TABLE), 792 .input = input_action_end_dt4, > 793 .slwt_ops = { 794 .build_state = seg6_end_dt4_build, 795}, 796 }, 797 { 798 .action = SEG6_LOCAL_ACTION_END_DT6, 799 .attrs = (1 << SEG6_LOCAL_TABLE), 800 .input = input_action_end_dt6, 801 }, 802 { 803 .action = SEG6_LOCAL_ACTION_END_B6, 804 .attrs = (1 << SEG6_LOCAL_SRH), 805 .input = input_action_end_b6, 806 }, 807 { 808 .action = SEG6_LOCAL_ACTION_END_B6_ENCAP, 809 .attrs = (1 << SEG6_LOCAL_SRH), 810 .input
Re: [PATCH v6] can: usb: etas_es58X: add support for ETAS ES58X CAN USB interfaces
Hi Vincent, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on bff6f1db91e330d7fba56f815cdbc412c75fe163 v5.10-rc3 next-20201113] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Vincent-Mailhol/can-usb-etas_es58X-add-support-for-ETAS-ES58X-CAN-USB-interfaces/20201114-232854 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git f01c30de86f1047e9bae1b1b1417b0ce8dcd15b1 config: x86_64-randconfig-a005-20201115 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 9a85643cd357e412cff69067bb5c4840e228c2ab) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # https://github.com/0day-ci/linux/commit/80a9b72580bad04e879752fa5c54d278b486e2bb git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Vincent-Mailhol/can-usb-etas_es58X-add-support-for-ETAS-ES58X-CAN-USB-interfaces/20201114-232854 git checkout 80a9b72580bad04e879752fa5c54d278b486e2bb # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): >> drivers/net/can/usb/etas_es58x/es58x_core.c:745:12: error: use of undeclared >> identifier 'CAN_MAX_RAW_DLC' if (dlc > CAN_MAX_RAW_DLC) { ^ drivers/net/can/usb/etas_es58x/es58x_core.c:748:22: error: use of undeclared identifier 'CAN_MAX_RAW_DLC' __func__, dlc, CAN_MAX_RAW_DLC); ^ >> drivers/net/can/usb/etas_es58x/es58x_core.c:753:9: error: implicit >> declaration of function 'can_fd_dlc2len' >> [-Werror,-Wimplicit-function-declaration] len = can_fd_dlc2len(dlc); ^ drivers/net/can/usb/etas_es58x/es58x_core.c:753:9: note: did you mean 'can_dlc2len'? include/linux/can/dev.h:190:4: note: 'can_dlc2len' declared here u8 can_dlc2len(u8 can_dlc); ^ >> drivers/net/can/usb/etas_es58x/es58x_core.c:756:9: error: implicit >> declaration of function 'can_cc_dlc2len' >> [-Werror,-Wimplicit-function-declaration] len = can_cc_dlc2len(dlc); ^ drivers/net/can/usb/etas_es58x/es58x_core.c:756:9: note: did you mean 'can_dlc2len'? include/linux/can/dev.h:190:4: note: 'can_dlc2len' declared here u8 can_dlc2len(u8 can_dlc); ^ >> drivers/net/can/usb/etas_es58x/es58x_core.c:775:3: error: implicit >> declaration of function 'can_frame_set_cc_len' >> [-Werror,-Wimplicit-function-declaration] can_frame_set_cc_len(ccf, dlc, es58x_priv(netdev)->can.ctrlmode); ^ 5 errors generated. -- >> drivers/net/can/usb/etas_es58x/es581_4.c:385:20: error: implicit declaration >> of function 'can_get_cc_dlc' [-Werror,-Wimplicit-function-declaration] tx_can_msg->dlc = can_get_cc_dlc(cf, priv->can.ctrlmode); ^ >> drivers/net/can/usb/etas_es58x/es581_4.c:387:41: error: no member named >> 'len' in 'struct can_frame' memcpy(tx_can_msg->data, cf->data, cf->len); ~~ ^ >> drivers/net/can/usb/etas_es58x/es581_4.c:391:13: error: implicit declaration >> of function 'can_cc_dlc2len' [-Werror,-Wimplicit-function-declaration] msg_len += es581_4_sizeof_rx_tx_msg(*tx_can_msg); ^ drivers/net/can/usb/etas_es58x/es581_4.c:30:29: note: expanded from macro 'es581_4_sizeof_rx_tx_msg' offsetof(typeof(msg), data[can_cc_dlc2len((msg).dlc)]) ^ drivers/net/can/usb/etas_es58x/es581_4.c:391:13: note: did you mean 'can_dlc2len'? drivers/net/can/usb/etas_es58x/es581_4.c:30:29: note: expanded from macro 'es581_4_sizeof_rx_tx_msg' offsetof(typeof(msg), data[can_cc_dlc2len((msg).dlc)]) ^ include/linux/can/dev.h:190:4: note: 'can_dlc2len' declared here u8 can_dlc2len(u8 can_dlc); ^ >> drivers/net/can/usb/etas_es58x/es581_4
Re: [PATCH 2/6] net/x25: make neighbour params configurable
Hi Martin, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] [also build test ERROR on net/master linus/master sparc-next/master v5.10-rc4 next-20201116] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Martin-Schiller/net-x25-add-remove-x25_link_device-by-NETDEV_REGISTER-UNREGISTER/20201116-153459 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 0064c5c1b3bf2a695c772c90e8dea38426a870ff config: x86_64-randconfig-a011-20201116 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project c044709b8fbea2a9a375e4173a6bd735f6866c0c) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # https://github.com/0day-ci/linux/commit/2d44533245f7e8388db93c53c26703ac52650e57 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Martin-Schiller/net-x25-add-remove-x25_link_device-by-NETDEV_REGISTER-UNREGISTER/20201116-153459 git checkout 2d44533245f7e8388db93c53c26703ac52650e57 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): >> net/x25/af_x25.c:1709:30: error: assigning to 'struct compat_x25_facilities' >> from incompatible type 'struct x25_facilities' x25_subscr.facilities= nb->facilities; ^ ~~ >> net/x25/af_x25.c:1761:24: error: assigning to 'struct x25_facilities' from >> incompatible type 'struct compat_x25_facilities' nb->facilities= x25_subscr.facilities; ^ ~ 2 errors generated. vim +1709 net/x25/af_x25.c 1678 1679 #ifdef CONFIG_COMPAT 1680 static int compat_x25_subscr_ioctl(unsigned int cmd, 1681 struct compat_x25_subscrip_struct __user *x25_subscr32) 1682 { 1683 struct compat_x25_subscrip_struct x25_subscr; 1684 struct x25_neigh *nb; 1685 struct net_device *dev; 1686 int rc = -EINVAL; 1687 1688 if (cmd != SIOCX25GSUBSCRIP && cmd != SIOCX25SSUBSCRIP) 1689 goto out; 1690 1691 rc = -EFAULT; 1692 if (copy_from_user(&x25_subscr, x25_subscr32, sizeof(*x25_subscr32))) 1693 goto out; 1694 1695 rc = -EINVAL; 1696 dev = x25_dev_get(x25_subscr.device); 1697 if (dev == NULL) 1698 goto out; 1699 1700 nb = x25_get_neigh(dev); 1701 if (nb == NULL) 1702 goto out_dev_put; 1703 1704 if (cmd == SIOCX25GSUBSCRIP) { 1705 read_lock_bh(&x25_neigh_list_lock); 1706 x25_subscr.extended = nb->extended; 1707 x25_subscr.dce = nb->dce; 1708 x25_subscr.lc= nb->lc; > 1709 x25_subscr.facilities= nb->facilities; 1710 x25_subscr.t20 = nb->t20; 1711 x25_subscr.global_facil_mask = nb->global_facil_mask; 1712 read_unlock_bh(&x25_neigh_list_lock); 1713 rc = copy_to_user(x25_subscr32, &x25_subscr, 1714 sizeof(*x25_subscr32)) ? -EFAULT : 0; 1715 } else { 1716 rc = -EINVAL; 1717 1718 if (dev->flags & IFF_UP) 1719 return -EBUSY; 1720 1721 if (x25_subscr.extended != 0 && x25_subscr.extended != 1) 1722 goto out_dev_and_neigh_put; 1723 if (x25_subscr.dce != 0 && x25_subscr.dce != 1) 1724 goto out_dev_and_neigh_put; 1725 if (x25_subscr.lc < 1 || x25_subscr.lc > 4095) 1726 goto out_dev_and_neigh_put; 1727 if (x25_subscr.facilities.pacsize_in < X25_PS16 || 1728 x25_subscr.facilities.pacsize_in > X25_PS4096) 1729 goto out_dev_and_neigh_put; 1730 if (x25_subscr.facilities.pa
Re: Re: [PATCH net-next] net: DSCP in IPv4 routing
Hi Russell, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Russell-Strong/Re-PATCH-net-next-net-DSCP-in-IPv4-routing/20201115-071518 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 9e6cad531c9de1ba39334fca535af0da5fdf8770 config: x86_64-randconfig-r014-20201116 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project c044709b8fbea2a9a375e4173a6bd735f6866c0c) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # https://github.com/0day-ci/linux/commit/f5e2676aa421caddeef6d412be65f35d9e4d3b85 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Russell-Strong/Re-PATCH-net-next-net-DSCP-in-IPv4-routing/20201115-071518 git checkout f5e2676aa421caddeef6d412be65f35d9e4d3b85 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): In file included from net/core/filter.c:33: In file included from include/net/ip.h:29: include/net/route.h:337:10: error: implicit declaration of function 'rt_tos' [-Werror,-Wimplicit-function-declaration] RT_CONN_FLAGS(sk), fl4->daddr, ^ include/net/route.h:43:30: note: expanded from macro 'RT_CONN_FLAGS' #define RT_CONN_FLAGS(sk) (rt_tos(sock_net(sk), inet_sk(sk)->tos) | sock_flag(sk, SOCK_LOCALROUTE)) ^ include/net/route.h:337:10: note: did you mean 'rt_task'? include/net/route.h:43:30: note: expanded from macro 'RT_CONN_FLAGS' #define RT_CONN_FLAGS(sk) (rt_tos(sock_net(sk), inet_sk(sk)->tos) | sock_flag(sk, SOCK_LOCALROUTE)) ^ include/linux/sched/rt.h:16:19: note: 'rt_task' declared here static inline int rt_task(struct task_struct *p) ^ In file included from net/core/filter.c:33: include/net/ip.h:245:28: error: implicit declaration of function 'rt_tos' [-Werror,-Wimplicit-function-declaration] return (ipc->tos != -1) ? rt_tos(net, ipc->tos) : rt_tos(net, inet->tos); ^ include/net/ip.h:250:28: error: implicit declaration of function 'rt_tos' [-Werror,-Wimplicit-function-declaration] return (ipc->tos != -1) ? RT_CONN_FLAGS_TOS(sk, ipc->tos) : RT_CONN_FLAGS(sk); ^ include/net/route.h:44:38: note: expanded from macro 'RT_CONN_FLAGS_TOS' #define RT_CONN_FLAGS_TOS(sk,tos) (rt_tos(sock_net(sk), tos) | sock_flag(sk, SOCK_LOCALROUTE)) ^ >> net/core/filter.c:2348:20: error: implicit declaration of function 'rt_tos' >> [-Werror,-Wimplicit-function-declaration] .flowi4_tos = rt_tos(net, ip4h->tos), ^ >> net/core/filter.c:5312:33: error: implicit declaration of function >> 'iptos_rt_mask' [-Werror,-Wimplicit-function-declaration] fl4.flowi4_tos = params->tos & iptos_rt_mask(net); ^ 5 errors generated. -- In file included from net/ipv4/route.c:90: In file included from include/net/dst_metadata.h:6: In file included from include/net/ip_tunnels.h:18: In file included from include/net/lwtunnel.h:9: include/net/route.h:337:10: error: implicit declaration of function 'rt_tos' [-Werror,-Wimplicit-function-declaration] RT_CONN_FLAGS(sk), fl4->daddr, ^ include/net/route.h:43:30: note: expanded from macro 'RT_CONN_FLAGS' #define RT_CONN_FLAGS(sk) (rt_tos(sock_net(sk), inet_sk(sk)->tos) | sock_flag(sk, SOCK_LOCALROUTE)) ^ include/net/route.h:337:10: note: did you mean 'rt_task'? include/net/route.h:43:30: note: expanded from macro 'RT_CONN_FLAGS' #define RT_CONN_FLAGS(sk) (rt_tos(sock_net(sk), inet_sk(sk)->tos) | sock_flag(sk, SOCK_LOCALROUTE)) ^ include/linux/sched/rt.h:16:19: note: 'rt_task' declared here static inline int rt_task(struct task_struct *p) ^ In file included from n
Re: [PATCH net-next] net-loopback: allow lo dev initial state to be controlled
Hi Jian, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Jian-Yang/net-loopback-allow-lo-dev-initial-state-to-be-controlled/20201112-044539 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 70408949a35f1a31c327c69b6a187635cb0305fa config: powerpc64-randconfig-r006-20201116 (attached as .config) compiler: powerpc-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/f1167177eeca028a046726f582c332d4c638a0c8 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Jian-Yang/net-loopback-allow-lo-dev-initial-state-to-be-controlled/20201112-044539 git checkout f1167177eeca028a046726f582c332d4c638a0c8 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): powerpc-linux-ld: drivers/net/loopback.o: in function `loopback_net_init': >> loopback.c:(.init.text+0x7a): undefined reference to >> `sysctl_netdev_loopback_state' >> powerpc-linux-ld: loopback.c:(.init.text+0x7e): undefined reference to >> `sysctl_netdev_loopback_state' --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [PATCH 6/8] libbpf: add functions to get XSK modes
Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on bpf-next/master] [also build test ERROR on bpf/master jkirsher-next-queue/dev-queue linus/master v5.10-rc4 next-20201116] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/alardam-gmail-com/New-netdev-feature-flags-for-XDP/20201116-173655 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master config: x86_64-randconfig-a015-20201116 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project ace9653c11c6308401dcda2e8b26bf97e6e66e30) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # https://github.com/0day-ci/linux/commit/fd9c1373aeb0b1aad73c9660e2d8457d3cfed55f git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review alardam-gmail-com/New-netdev-feature-flags-for-XDP/20201116-173655 git checkout fd9c1373aeb0b1aad73c9660e2d8457d3cfed55f # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): In file included from netlink.c:19: >> ./ethtool.h:12:10: fatal error: 'linux/ethtool_netlink.h' file not found #include ^ 1 error generated. make[6]: *** [tools/build/Makefile.build:97: kernel/bpf/preload/staticobjs/netlink.o] Error 1 make[6]: Target '__build' not remade because of errors. --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [PATCH v2 net-next 5/5] ptp: clockmatrix: deprecate firmware older than 4.8.7
Hi, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/min-li-xe-renesas-com/ptp_clockmatrix-bug-fix-and-improvement/20201118-004135 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 72308ecbf33b145641aba61071be31a85ebfd92c config: sparc-allyesconfig (attached as .config) compiler: sparc64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/2b6e446631ab9940f935bc0299d01cb323e35389 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review min-li-xe-renesas-com/ptp_clockmatrix-bug-fix-and-improvement/20201118-004135 git checkout 2b6e446631ab9940f935bc0299d01cb323e35389 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sparc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): In function 'idtcm_strverscmp', inlined from 'idtcm_set_version_info' at drivers/ptp/ptp_clockmatrix.c:2113:6, inlined from 'idtcm_probe' at drivers/ptp/ptp_clockmatrix.c:2372:2: >> drivers/ptp/ptp_clockmatrix.c:147:2: warning: 'strncpy' output may be >> truncated copying 15 bytes from a string of length 15 [-Wstringop-truncation] 147 | strncpy(ver1, version1, 15); | ^~~ vim +/strncpy +147 drivers/ptp/ptp_clockmatrix.c 3a6ba7dc7799355 Vincent Cheng 2019-10-31 134 bdb09b91d9a2f66 Min Li2020-11-17 135 static int idtcm_strverscmp(const char *version1, const char *version2) 7ea5fda2b1325e1 Min Li2020-07-28 136 { 7ea5fda2b1325e1 Min Li2020-07-28 137 u8 num1; 7ea5fda2b1325e1 Min Li2020-07-28 138 u8 num2; 7ea5fda2b1325e1 Min Li2020-07-28 139 int result = 0; bdb09b91d9a2f66 Min Li2020-11-17 140 char ver1[16]; bdb09b91d9a2f66 Min Li2020-11-17 141 char ver2[16]; bdb09b91d9a2f66 Min Li2020-11-17 142 char *cur1; bdb09b91d9a2f66 Min Li2020-11-17 143 char *cur2; bdb09b91d9a2f66 Min Li2020-11-17 144 char *next1; bdb09b91d9a2f66 Min Li2020-11-17 145 char *next2; bdb09b91d9a2f66 Min Li2020-11-17 146 bdb09b91d9a2f66 Min Li2020-11-17 @147 strncpy(ver1, version1, 15); bdb09b91d9a2f66 Min Li2020-11-17 148 strncpy(ver2, version2, 15); bdb09b91d9a2f66 Min Li2020-11-17 149 cur1 = ver1; bdb09b91d9a2f66 Min Li2020-11-17 150 cur2 = ver2; 7ea5fda2b1325e1 Min Li2020-07-28 151 7ea5fda2b1325e1 Min Li2020-07-28 152 /* loop through each level of the version string */ 7ea5fda2b1325e1 Min Li2020-07-28 153 while (result == 0) { bdb09b91d9a2f66 Min Li2020-11-17 154 next1 = strchr(cur1, '.'); bdb09b91d9a2f66 Min Li2020-11-17 155 next2 = strchr(cur2, '.'); bdb09b91d9a2f66 Min Li2020-11-17 156 bdb09b91d9a2f66 Min Li2020-11-17 157 /* kstrtou8 could fail for dot */ bdb09b91d9a2f66 Min Li2020-11-17 158 if (next1) { bdb09b91d9a2f66 Min Li2020-11-17 159 *next1 = '\0'; bdb09b91d9a2f66 Min Li2020-11-17 160 next1++; bdb09b91d9a2f66 Min Li2020-11-17 161 } bdb09b91d9a2f66 Min Li2020-11-17 162 bdb09b91d9a2f66 Min Li2020-11-17 163 if (next2) { bdb09b91d9a2f66 Min Li2020-11-17 164 *next2 = '\0'; bdb09b91d9a2f66 Min Li2020-11-17 165 next2++; bdb09b91d9a2f66 Min Li2020-11-17 166 } bdb09b91d9a2f66 Min Li2020-11-17 167 7ea5fda2b1325e1 Min Li2020-07-28 168 /* extract leading version numbers */ bdb09b91d9a2f66 Min Li2020-11-17 169 if (kstrtou8(cur1, 10, &num1) < 0) 7ea5fda2b1325e1 Min Li2020-07-28 170 return -1; 7ea5fda2b1325e1 Min Li2020-07-28 171 bdb09b91d9a2f66 Min Li2020-11-17 172 if (kstrtou8(cur2, 10, &num2) < 0) 7ea5fda2b1325e1 Min Li2020-07-28 173 return -1; 7ea5fda2b1325e1 Min Li2020-07-28 174 7ea5fda2b1325e1 Min Li2020-07-28 175 /* if numbers differ, then set the result */ bdb09b91d9a2f66 Min Li2020-11-17 176 if (num1 < num2) { 7ea5fda2b1325e1 Min Li2020-07-28 177 result = -1; bdb09b91d9a2f66 Min Li2020-11-17 178 } else if (num1 > num2) { 7ea5fda2b1325e1 Min
Re: [PATCH net-next 4/4] ptp: ptp_ines: use enum ptp_msg_type
Hi Christian, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Christian-Eggers/net-ptp-introduce-enum-ptp_msg_type/20201118-033828 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 72308ecbf33b145641aba61071be31a85ebfd92c config: sh-allmodconfig (attached as .config) compiler: sh4-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/c4e4cfcabe3201e2ece90cc9025894e4ed08f069 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Christian-Eggers/net-ptp-introduce-enum-ptp_msg_type/20201118-033828 git checkout c4e4cfcabe3201e2ece90cc9025894e4ed08f069 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All error/warnings (new ones prefixed by >>): >> drivers/ptp/ptp_ines.c:690:26: error: conflicting types for 'tag_to_msgtype' 690 | static enum ptp_msg_type tag_to_msgtype(u8 tag) | ^~ drivers/ptp/ptp_ines.c:178:11: note: previous declaration of 'tag_to_msgtype' was here 178 | static u8 tag_to_msgtype(u8 tag); | ^~ >> drivers/ptp/ptp_ines.c:178:11: warning: 'tag_to_msgtype' used but never >> defined drivers/ptp/ptp_ines.c:690:26: warning: 'tag_to_msgtype' defined but not used [-Wunused-function] 690 | static enum ptp_msg_type tag_to_msgtype(u8 tag) | ^~ vim +/tag_to_msgtype +690 drivers/ptp/ptp_ines.c 689 > 690 static enum ptp_msg_type tag_to_msgtype(u8 tag) 691 { 692 switch (tag) { 693 case MESSAGE_TYPE_SYNC: 694 return PTP_MSGTYPE_SYNC; 695 case MESSAGE_TYPE_P_DELAY_REQ: 696 return PTP_MSGTYPE_PDELAY_REQ; 697 case MESSAGE_TYPE_P_DELAY_RESP: 698 return PTP_MSGTYPE_PDELAY_RESP; 699 case MESSAGE_TYPE_DELAY_REQ: 700 return PTP_MSGTYPE_DELAY_REQ; 701 } 702 return 0xf; 703 } 704 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [PATCH net-next v4 4/4] net: phy: dp83td510: Add support for the DP83TD510 Ethernet PHY
Hi Dan, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Dan-Murphy/DP83TD510-Single-Pair-10Mbps-Ethernet-PHY/20201118-041918 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 72308ecbf33b145641aba61071be31a85ebfd92c config: arm-randconfig-m031-20201118 (attached as .config) compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/ec556cedbd640ecfa25713eadf48e5b7ee74fda3 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Dan-Murphy/DP83TD510-Single-Pair-10Mbps-Ethernet-PHY/20201118-041918 git checkout ec556cedbd640ecfa25713eadf48e5b7ee74fda3 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): drivers/net/phy/dp83td510.c: In function 'dp83869_of_init': >> drivers/net/phy/dp83td510.c:450:2: error: 'dp83td510' undeclared (first use >> in this function) 450 | dp83td510->hi_diff_output = DP83TD510_2_4V_P2P | ^ drivers/net/phy/dp83td510.c:450:2: note: each undeclared identifier is reported only once for each function it appears in >> drivers/net/phy/dp83td510.c:451:2: error: expected ';' before 'dp83td510' 451 | dp83td510->tx_fifo_depth = DP83TD510_FIFO_DEPTH_5_B_NIB | ^ drivers/net/phy/dp83td510.c:453:1: error: no return statement in function returning non-void [-Werror=return-type] 453 | } | ^ drivers/net/phy/dp83td510.c: In function 'dp83td510_probe': >> drivers/net/phy/dp83td510.c:468:8: error: implicit declaration of function >> 'dp83td510_of_init'; did you mean 'dp83td510_config_init'? >> [-Werror=implicit-function-declaration] 468 | ret = dp83td510_of_init(phydev); |^ |dp83td510_config_init At top level: drivers/net/phy/dp83td510.c:448:12: warning: 'dp83869_of_init' defined but not used [-Wunused-function] 448 | static int dp83869_of_init(struct phy_device *phydev) |^~~ cc1: some warnings being treated as errors vim +/dp83td510 +450 drivers/net/phy/dp83td510.c 390 391 #if IS_ENABLED(CONFIG_OF_MDIO) 392 static int dp83td510_of_init(struct phy_device *phydev) 393 { 394 struct dp83td510_private *dp83td510 = phydev->priv; 395 struct device *dev = &phydev->mdio.dev; 396 struct device_node *of_node = dev->of_node; 397 s32 rx_int_delay; 398 s32 tx_int_delay; 399 int ret; 400 401 if (!of_node) 402 return -ENODEV; 403 404 ret = of_property_read_u32(phydev->mdio.dev.of_node, 405 "max-tx-rx-p2p-microvolt", 406 &dp83td510->hi_diff_output); 407 if (ret) 408 dp83td510->hi_diff_output = DP83TD510_2_4V_P2P; 409 410 if (dp83td510->hi_diff_output != DP83TD510_2_4V_P2P && 411 dp83td510->hi_diff_output != DP83TD510_1_1V_P2P) 412 return -EINVAL; 413 414 if (of_property_read_u32(phydev->mdio.dev.of_node, "tx-fifo-depth", 415 &dp83td510->tx_fifo_depth)) 416 dp83td510->tx_fifo_depth = DP83TD510_FIFO_DEPTH_5_B_NIB; 417 418 switch (dp83td510->tx_fifo_depth) { 419 case 4: 420 dp83td510->tx_fifo_depth = DP83TD510_FIFO_DEPTH_4_B_NIB; 421 break; 422 case 6: 423 dp83td510->tx_fifo_depth = DP83TD510_FIFO_DEPTH_6_B_NIB; 424 break; 425 case 8: 426 dp83td510->tx_fifo_depth = DP83TD510_FIFO_DEPTH_8_B_NIB; 427 break; 428 case 5: 429 default: 430 dp83td510->tx_fifo_depth = DP83TD510_FIFO_DEPTH_5_B_NIB; 431 } 432 433 rx_int_delay = phy_get_internal_delay(phydev, dev, NULL, 0, true); 434 if (rx_int_delay <= 0) 435 dp83td510->rgmii_delay = DP83TD510_RX_CLK_SHIFT; 436 else 437 dp83td510->rgmii_delay = 0; 438 439 tx_int_delay = phy_get_i
Re: [PATCH net 2/3] net: ipa: use state to determine channel command success
Hi Alex, I love your patch! Perhaps something to improve: [auto build test WARNING on net/master] url: https://github.com/0day-ci/linux/commits/Alex-Elder/net-ipa-GSI-interrupt-handling-fixes/20201223-020409 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git 2575bc1aa9d52a62342b57a0b7d0a12146cf6aed config: arm64-allyesconfig (attached as .config) compiler: aarch64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/4073b68cee8a9d0dbb83080db22255fc9b9d7fd5 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Alex-Elder/net-ipa-GSI-interrupt-handling-fixes/20201223-020409 git checkout 4073b68cee8a9d0dbb83080db22255fc9b9d7fd5 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): drivers/net/ipa/gsi.c: In function 'gsi_channel_alloc_command': >> drivers/net/ipa/gsi.c:496:6: warning: variable 'ret' set but not used >> [-Wunused-but-set-variable] 496 | int ret; | ^~~ drivers/net/ipa/gsi.c: In function 'gsi_channel_start_command': drivers/net/ipa/gsi.c:524:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable] 524 | int ret; | ^~~ drivers/net/ipa/gsi.c: In function 'gsi_channel_stop_command': drivers/net/ipa/gsi.c:552:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable] 552 | int ret; | ^~~ drivers/net/ipa/gsi.c: In function 'gsi_channel_reset_command': drivers/net/ipa/gsi.c:591:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable] 591 | int ret; | ^~~ drivers/net/ipa/gsi.c: In function 'gsi_channel_de_alloc_command': drivers/net/ipa/gsi.c:620:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable] 620 | int ret; | ^~~ vim +/ret +496 drivers/net/ipa/gsi.c 650d1603825d8ba Alex Elder 2020-03-05 489 650d1603825d8ba Alex Elder 2020-03-05 490 /* Allocate GSI channel in NOT_ALLOCATED state */ 650d1603825d8ba Alex Elder 2020-03-05 491 static int gsi_channel_alloc_command(struct gsi *gsi, u32 channel_id) 650d1603825d8ba Alex Elder 2020-03-05 492 { 650d1603825d8ba Alex Elder 2020-03-05 493 struct gsi_channel *channel = &gsi->channel[channel_id]; a442b3c7554898f Alex Elder 2020-06-30 494 struct device *dev = gsi->dev; a2003b303875b41 Alex Elder 2020-04-30 495 enum gsi_channel_state state; 650d1603825d8ba Alex Elder 2020-03-05 @496 int ret; 650d1603825d8ba Alex Elder 2020-03-05 497 650d1603825d8ba Alex Elder 2020-03-05 498 /* Get initial channel state */ a2003b303875b41 Alex Elder 2020-04-30 499 state = gsi_channel_state(channel); a442b3c7554898f Alex Elder 2020-06-30 500 if (state != GSI_CHANNEL_STATE_NOT_ALLOCATED) { f8d3bdd561a7c95 Alex Elder 2020-11-19 501 dev_err(dev, "channel %u bad state %u before alloc\n", f8d3bdd561a7c95 Alex Elder 2020-11-19 502 channel_id, state); 650d1603825d8ba Alex Elder 2020-03-05 503 return -EINVAL; a442b3c7554898f Alex Elder 2020-06-30 504 } 650d1603825d8ba Alex Elder 2020-03-05 505 650d1603825d8ba Alex Elder 2020-03-05 506 ret = gsi_channel_command(channel, GSI_CH_ALLOCATE); a2003b303875b41 Alex Elder 2020-04-30 507 4073b68cee8a9d0 Alex Elder 2020-12-22 508 /* If successful the channel state will have changed */ a2003b303875b41 Alex Elder 2020-04-30 509 state = gsi_channel_state(channel); 4073b68cee8a9d0 Alex Elder 2020-12-22 510 if (state == GSI_CHANNEL_STATE_ALLOCATED) 4073b68cee8a9d0 Alex Elder 2020-12-22 511 return 0; 4073b68cee8a9d0 Alex Elder 2020-12-22 512 f8d3bdd561a7c95 Alex Elder 2020-11-19 513 dev_err(dev, "channel %u bad state %u after alloc\n", f8d3bdd561a7c95 Alex Elder 2020-11-19 514 channel_id, state); 650d1603825d8ba Alex Elder 2020-03-05 515 4073b68cee8a9d0 Alex Elder 2020-12-22 516 return -EIO; 650d1603825d8ba Alex Elder 2020-03-05 517 } 650d1603825d8ba Alex Elder 2020-03-05 518 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [PATCH 1/2] net: stmmac: retain PTP-clock at hwtstamp_set
Hi Holger, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on 3db1a3fa98808aa90f95ec3e0fa2fc7abf28f5c9] url: https://github.com/0day-ci/linux/commits/Holger-Assmann/net-stmmac-retain-PTP-clock-at-hwtstamp_set/20201216-194127 base:3db1a3fa98808aa90f95ec3e0fa2fc7abf28f5c9 config: arm-randconfig-r021-20201221 (attached as .config) compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/303da978c0e8ad80e7577245b7c399f601a29b7a git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Holger-Assmann/net-stmmac-retain-PTP-clock-at-hwtstamp_set/20201216-194127 git checkout 303da978c0e8ad80e7577245b7c399f601a29b7a # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): drivers/net/ethernet/stmicro/stmmac/stmmac_main.c: In function 'stmmac_hwtstamp_set': >> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:528:7: warning: variable >> 'xmac' set but not used [-Wunused-but-set-variable] 528 | bool xmac; | ^~~~ vim +/xmac +528 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c 891434b18ec0a21 Rayagond Kokatanur 2013-03-26 503 891434b18ec0a21 Rayagond Kokatanur 2013-03-26 504 /** d6228b7cdd6e790 Artem Panfilov 2019-01-20 505 * stmmac_hwtstamp_set - control hardware timestamping. 891434b18ec0a21 Rayagond Kokatanur 2013-03-26 506 * @dev: device pointer. 8d45e42babb1c7b LABBE Corentin 2017-02-08 507 * @ifr: An IOCTL specific structure, that can contain a pointer to 891434b18ec0a21 Rayagond Kokatanur 2013-03-26 508 * a proprietary structure used to pass information to the driver. 891434b18ec0a21 Rayagond Kokatanur 2013-03-26 509 * Description: 891434b18ec0a21 Rayagond Kokatanur 2013-03-26 510 * This function configures the MAC to enable/disable both outgoing(TX) 891434b18ec0a21 Rayagond Kokatanur 2013-03-26 511 * and incoming(RX) packets time stamping based on user input. 891434b18ec0a21 Rayagond Kokatanur 2013-03-26 512 * Return Value: 891434b18ec0a21 Rayagond Kokatanur 2013-03-26 513 * 0 on success and an appropriate -ve integer on failure. 891434b18ec0a21 Rayagond Kokatanur 2013-03-26 514 */ d6228b7cdd6e790 Artem Panfilov 2019-01-20 515 static int stmmac_hwtstamp_set(struct net_device *dev, struct ifreq *ifr) 891434b18ec0a21 Rayagond Kokatanur 2013-03-26 516 { 891434b18ec0a21 Rayagond Kokatanur 2013-03-26 517 struct stmmac_priv *priv = netdev_priv(dev); 891434b18ec0a21 Rayagond Kokatanur 2013-03-26 518 struct hwtstamp_config config; 891434b18ec0a21 Rayagond Kokatanur 2013-03-26 519 u32 ptp_v2 = 0; 891434b18ec0a21 Rayagond Kokatanur 2013-03-26 520 u32 tstamp_all = 0; 891434b18ec0a21 Rayagond Kokatanur 2013-03-26 521 u32 ptp_over_ipv4_udp = 0; 891434b18ec0a21 Rayagond Kokatanur 2013-03-26 522 u32 ptp_over_ipv6_udp = 0; 891434b18ec0a21 Rayagond Kokatanur 2013-03-26 523 u32 ptp_over_ethernet = 0; 891434b18ec0a21 Rayagond Kokatanur 2013-03-26 524 u32 snap_type_sel = 0; 891434b18ec0a21 Rayagond Kokatanur 2013-03-26 525 u32 ts_master_en = 0; 891434b18ec0a21 Rayagond Kokatanur 2013-03-26 526 u32 ts_event_en = 0; 891434b18ec0a21 Rayagond Kokatanur 2013-03-26 527 u32 value = 0; 7d9e6c5afab6bfb Jose Abreu 2018-08-08 @528 bool xmac; 7d9e6c5afab6bfb Jose Abreu 2018-08-08 529 7d9e6c5afab6bfb Jose Abreu 2018-08-08 530 xmac = priv->plat->has_gmac4 || priv->plat->has_xgmac; 891434b18ec0a21 Rayagond Kokatanur 2013-03-26 531 891434b18ec0a21 Rayagond Kokatanur 2013-03-26 532 if (!(priv->dma_cap.time_stamp || priv->adv_ts)) { 891434b18ec0a21 Rayagond Kokatanur 2013-03-26 533 netdev_alert(priv->dev, "No support for HW time stamping\n"); 891434b18ec0a21 Rayagond Kokatanur 2013-03-26 534 priv->hwts_tx_en = 0; 891434b18ec0a21 Rayagond Kokatanur 2013-03-26 535 priv->hwts_rx_en = 0; 891434b18ec0a21 Rayagond Kokatanur 2013-03-26 536 891434b18ec0a21 Rayagond Kokatanur 2013-03-26 537 return -EOPNOTSUPP; 891434b18ec0a21 Rayagond Kokatanur 2013-03-26 538 } 891434b18ec0a21 Rayagond Kokatanur 2013-03-26 539 891434b18ec0a21 Rayagond Kokatanur 2013-03-26 540 if (copy_from_user(&config, ifr->ifr_data, d6228b7cdd6e790 Artem Panfilov 2019-01-20 541 sizeof(config))) 891434b18ec0a21 Rayagond Kokatanur 2013-03-26 542 re
Re: [PATCH 2/2] net: ks8851: Register MDIO bus and the internal PHY
Hi Marek, I love your patch! Perhaps something to improve: [auto build test WARNING on net/master] [also build test WARNING on net-next/master ipvs/master linus/master v5.11-rc1 next-20201223] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Marek-Vasut/net-phy-micrel-Add-KS8851-PHY-support/20201230-210003 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git 4bfc4714849d005e6835bcffa3c29ebd6e5ee35d config: alpha-allmodconfig (attached as .config) compiler: alpha-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/799aae00b2ec29ee4a86a2d8b8a8b0c1b816cb84 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Marek-Vasut/net-phy-micrel-Add-KS8851-PHY-support/20201230-210003 git checkout 799aae00b2ec29ee4a86a2d8b8a8b0c1b816cb84 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=alpha If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): drivers/net/ethernet/micrel/ks8851_common.c: In function 'ks8851_register_mdiobus': >> drivers/net/ethernet/micrel/ks8851_common.c:1082:22: warning: conversion >> from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from >> '18446744073709551614' to '4294967294' [-Woverflow] 1082 | mii_bus->phy_mask = ~BIT(0); | ^ vim +1082 drivers/net/ethernet/micrel/ks8851_common.c 1067 1068 static int ks8851_register_mdiobus(struct ks8851_net *ks, struct device *dev) 1069 { 1070 struct mii_bus *mii_bus; 1071 int ret; 1072 1073 mii_bus = mdiobus_alloc(); 1074 if (!mii_bus) 1075 return -ENOMEM; 1076 1077 mii_bus->name = "ks8851_eth_mii"; 1078 mii_bus->read = ks8851_mdio_read; 1079 mii_bus->write = ks8851_mdio_write; 1080 mii_bus->priv = ks; 1081 mii_bus->parent = dev; > 1082 mii_bus->phy_mask = ~BIT(0); 1083 snprintf(mii_bus->id, MII_BUS_ID_SIZE, "%s", dev_name(dev)); 1084 1085 ret = mdiobus_register(mii_bus); 1086 if (ret) 1087 goto err_mdiobus_register; 1088 1089 ks->mii_bus = mii_bus; 1090 1091 return 0; 1092 1093 err_mdiobus_register: 1094 mdiobus_free(mii_bus); 1095 return ret; 1096 } 1097 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [PATCH net,stable] net: cdc_ncm: correct overhead in delayed_ndp_size
Hi "Jouni, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.11-rc1 next-20201223] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Jouni-Sepp-nen/net-cdc_ncm-correct-overhead-in-delayed_ndp_size/20210103-224538 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 3516bd729358a2a9b090c1905bd2a3fa926e24c6 config: x86_64-randconfig-a003-20210103 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 7af6a134508cd1c7f75c6e3441ce436f220f30a4) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # https://github.com/0day-ci/linux/commit/3d8cc665ef1cf4705135a5a96893a6fdc6dcd398 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Jouni-Sepp-nen/net-cdc_ncm-correct-overhead-in-delayed_ndp_size/20210103-224538 git checkout 3d8cc665ef1cf4705135a5a96893a6fdc6dcd398 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/net/usb/cdc_ncm.c:1203:4: warning: comparison of distinct pointer >> types ('typeof (ctx->tx_ndp_modulus) *' (aka 'unsigned short *') and 'typeof >> (ctx->tx_modulus + ctx->tx_remainder) *' (aka 'int *')) >> [-Wcompare-distinct-pointer-types] max(ctx->tx_ndp_modulus, ^~~~ include/linux/minmax.h:58:19: note: expanded from macro 'max' #define max(x, y) __careful_cmp(x, y, >) ^~ include/linux/minmax.h:42:24: note: expanded from macro '__careful_cmp' __builtin_choose_expr(__safe_cmp(x, y), \ ^~~~ include/linux/minmax.h:32:4: note: expanded from macro '__safe_cmp' (__typecheck(x, y) && __no_side_effects(x, y)) ^ include/linux/minmax.h:18:28: note: expanded from macro '__typecheck' (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1))) ~~ ^ ~~ 1 warning generated. vim +1203 drivers/net/usb/cdc_ncm.c 1179 1180 struct sk_buff * 1181 cdc_ncm_fill_tx_frame(struct usbnet *dev, struct sk_buff *skb, __le32 sign) 1182 { 1183 struct cdc_ncm_ctx *ctx = (struct cdc_ncm_ctx *)dev->data[0]; 1184 union { 1185 struct usb_cdc_ncm_nth16 *nth16; 1186 struct usb_cdc_ncm_nth32 *nth32; 1187 } nth; 1188 union { 1189 struct usb_cdc_ncm_ndp16 *ndp16; 1190 struct usb_cdc_ncm_ndp32 *ndp32; 1191 } ndp; 1192 struct sk_buff *skb_out; 1193 u16 n = 0, index, ndplen; 1194 u8 ready2send = 0; 1195 u32 delayed_ndp_size; 1196 size_t padding_count; 1197 1198 /* When our NDP gets written in cdc_ncm_ndp(), then skb_out->len gets updated 1199 * accordingly. Otherwise, we should check here. 1200 */ 1201 if (ctx->drvflags & CDC_NCM_FLAG_NDP_TO_END) 1202 delayed_ndp_size = ctx->max_ndp_size + > 1203 max(ctx->tx_ndp_modulus, 1204 ctx->tx_modulus + ctx->tx_remainder) - 1; 1205 else 1206 delayed_ndp_size = 0; 1207 1208 /* if there is a remaining skb, it gets priority */ 1209 if (skb != NULL) { 1210 swap(skb, ctx->tx_rem_skb); 1211 swap(sign, ctx->tx_rem_sign); 1212 } else { 1213 ready2send = 1; 1214 } 1215 1216 /* check if we are resuming an OUT skb */ 1217 skb_out = ctx->tx_curr_skb; 1218 1219 /* allocate a new OUT skb */ 1220 if (!skb_out) { 1221 if (ctx->tx_low_mem_val == 0) { 1222 ctx->tx_curr_size = ctx->tx_max; 1223 skb_out = alloc_skb(ctx->tx_curr_size, GFP_ATOMIC); 1224 /* If the memory
Re: [PATCH 1/5] vsock/virtio: support for SOCK_SEQPACKET socket.
Hi Arseny, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.11-rc1 next-20201223] [cannot apply to vhost/linux-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Arseny-Krasnov/virtio-vsock-introduce-SOCK_SEQPACKET-support/20210104-041042 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 3516bd729358a2a9b090c1905bd2a3fa926e24c6 config: ia64-randconfig-s031-20210104 (attached as .config) compiler: ia64-linux-gcc (GCC) 9.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # apt-get install sparse # sparse version: v0.6.3-184-g1b896707-dirty # https://github.com/0day-ci/linux/commit/0fa3b3d10df0564a37d3ddf00d954a2bfaec8718 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Arseny-Krasnov/virtio-vsock-introduce-SOCK_SEQPACKET-support/20210104-041042 git checkout 0fa3b3d10df0564a37d3ddf00d954a2bfaec8718 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=ia64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot "sparse warnings: (new ones prefixed by >>)" net/vmw_vsock/virtio_transport_common.c:162:13: sparse: sparse: cast to restricted __le32 >> net/vmw_vsock/virtio_transport_common.c:162:13: sparse: sparse: cast from >> restricted __le16 >> net/vmw_vsock/virtio_transport_common.c:560:29: sparse: sparse: cast to >> restricted __le16 >> net/vmw_vsock/virtio_transport_common.c:560:29: sparse: sparse: cast from >> restricted __le32 net/vmw_vsock/virtio_transport_common.c:1106:17: sparse: sparse: cast to restricted __le32 net/vmw_vsock/virtio_transport_common.c:1106:17: sparse: sparse: cast from restricted __le16 vim +162 net/vmw_vsock/virtio_transport_common.c 158 159 void virtio_transport_deliver_tap_pkt(struct virtio_vsock_pkt *pkt) 160 { 161 /* TODO: implement tap support for SOCK_SEQPACKET. */ > 162 if (le32_to_cpu(pkt->hdr.type) == VIRTIO_VSOCK_TYPE_SEQPACKET) 163 return; 164 165 if (pkt->tap_delivered) 166 return; 167 168 vsock_deliver_tap(virtio_transport_build_skb, pkt); 169 pkt->tap_delivered = true; 170 } 171 EXPORT_SYMBOL_GPL(virtio_transport_deliver_tap_pkt); 172 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [PATCH V2 2/2] net: ks8851: Register MDIO bus and the internal PHY
Hi Marek, I love your patch! Yet something to improve: [auto build test ERROR on net/master] [also build test ERROR on ipvs/master net-next/master linus/master v5.11-rc2 next-20210104] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Marek-Vasut/net-phy-micrel-Add-KS8851-PHY-support/20210104-203217 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git 4bfc4714849d005e6835bcffa3c29ebd6e5ee35d config: i386-randconfig-a013-20210105 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/ab74850be61e7510a3304091c458b8aedfd51388 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Marek-Vasut/net-phy-micrel-Add-KS8851-PHY-support/20210104-203217 git checkout ab74850be61e7510a3304091c458b8aedfd51388 # save the attached .config to linux build tree make W=1 ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): ld: drivers/net/ethernet/micrel/ks8851_common.o: in function `ks8851_register_mdiobus': >> drivers/net/ethernet/micrel/ks8851_common.c:1103: undefined reference to >> `__this_module' vim +1103 drivers/net/ethernet/micrel/ks8851_common.c 1085 1086 static int ks8851_register_mdiobus(struct ks8851_net *ks, struct device *dev) 1087 { 1088 struct mii_bus *mii_bus; 1089 int ret; 1090 1091 mii_bus = mdiobus_alloc(); 1092 if (!mii_bus) 1093 return -ENOMEM; 1094 1095 mii_bus->name = "ks8851_eth_mii"; 1096 mii_bus->read = ks8851_mdio_read; 1097 mii_bus->write = ks8851_mdio_write; 1098 mii_bus->priv = ks; 1099 mii_bus->parent = dev; 1100 mii_bus->phy_mask = ~((u32)BIT(0)); 1101 snprintf(mii_bus->id, MII_BUS_ID_SIZE, "%s", dev_name(dev)); 1102 > 1103 ret = mdiobus_register(mii_bus); 1104 if (ret) 1105 goto err_mdiobus_register; 1106 1107 ks->mii_bus = mii_bus; 1108 1109 return 0; 1110 err_mdiobus_register: 1112 mdiobus_free(mii_bus); 1113 return ret; 1114 } 1115 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [PATCH netdev 5/5] virtio-net, xsk: virtio-net support xsk zero copy tx
Hi Xuan, Thank you for the patch! Yet something to improve: [auto build test ERROR on ipvs/master] [also build test ERROR on linus/master v5.11-rc2 next-20210104] [cannot apply to sparc-next/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Xuan-Zhuo/virtio-net-support-xdp-socket-zero-copy-xmit/20210105-171505 base: https://git.kernel.org/pub/scm/linux/kernel/git/horms/ipvs.git master config: i386-randconfig-r036-20210105 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/265d3cdead3bd609bec53e66dfb7c5bf7339f73f git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Xuan-Zhuo/virtio-net-support-xdp-socket-zero-copy-xmit/20210105-171505 git checkout 265d3cdead3bd609bec53e66dfb7c5bf7339f73f # save the attached .config to linux build tree make W=1 ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>, old ones prefixed by <<): >> ERROR: modpost: "__umoddi3" [drivers/net/virtio_net.ko] undefined! --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [PATCH netdev 5/5] virtio-net, xsk: virtio-net support xsk zero copy tx
Hi Xuan, Thank you for the patch! Yet something to improve: [auto build test ERROR on ipvs/master] [also build test ERROR on linus/master v5.11-rc2 next-20210104] [cannot apply to sparc-next/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Xuan-Zhuo/virtio-net-support-xdp-socket-zero-copy-xmit/20210105-171505 base: https://git.kernel.org/pub/scm/linux/kernel/git/horms/ipvs.git master config: riscv-rv32_defconfig (attached as .config) compiler: riscv32-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/265d3cdead3bd609bec53e66dfb7c5bf7339f73f git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Xuan-Zhuo/virtio-net-support-xdp-socket-zero-copy-xmit/20210105-171505 git checkout 265d3cdead3bd609bec53e66dfb7c5bf7339f73f # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=riscv If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): riscv32-linux-ld: drivers/net/virtio_net.o: in function `.L936': >> virtio_net.c:(.text+0x3068): undefined reference to `__umoddi3' --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [PATCH netdev 5/5] virtio-net, xsk: virtio-net support xsk zero copy tx
Hi Xuan, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on ipvs/master] [also build test WARNING on linus/master v5.11-rc2 next-20210104] [cannot apply to sparc-next/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Xuan-Zhuo/virtio-net-support-xdp-socket-zero-copy-xmit/20210105-171505 base: https://git.kernel.org/pub/scm/linux/kernel/git/horms/ipvs.git master config: x86_64-randconfig-s032-20210105 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.3-208-g46a52ca4-dirty # https://github.com/0day-ci/linux/commit/265d3cdead3bd609bec53e66dfb7c5bf7339f73f git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Xuan-Zhuo/virtio-net-support-xdp-socket-zero-copy-xmit/20210105-171505 git checkout 265d3cdead3bd609bec53e66dfb7c5bf7339f73f # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot "sparse warnings: (new ones prefixed by >>)" >> drivers/net/virtio_net.c:1502:38: sparse: sparse: incorrect type in argument >> 1 (different address spaces) @@ expected void const * @@ got struct >> virtnet_xsk_hdr [noderef] __rcu *hdr @@ drivers/net/virtio_net.c:1502:38: sparse: expected void const * drivers/net/virtio_net.c:1502:38: sparse: got struct virtnet_xsk_hdr [noderef] __rcu *hdr drivers/net/virtio_net.c:2745:30: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const * @@ got struct virtnet_xsk_hdr [noderef] __rcu *hdr @@ drivers/net/virtio_net.c:2745:30: sparse: expected void const * drivers/net/virtio_net.c:2745:30: sparse: got struct virtnet_xsk_hdr [noderef] __rcu *hdr >> drivers/net/virtio_net.c:2798:16: sparse: sparse: incorrect type in >> assignment (different address spaces) @@ expected struct virtnet_xsk_hdr >> *xskhdr @@ got struct virtnet_xsk_hdr [noderef] __rcu * @@ drivers/net/virtio_net.c:2798:16: sparse: expected struct virtnet_xsk_hdr *xskhdr drivers/net/virtio_net.c:2798:16: sparse: got struct virtnet_xsk_hdr [noderef] __rcu * drivers/net/virtio_net.c:602:9: sparse: sparse: context imbalance in 'virtnet_get_xdp_sq' - different lock contexts for basic block drivers/net/virtio_net.c:611:22: sparse: sparse: context imbalance in 'virtnet_put_xdp_sq' - unexpected unlock vim +1502 drivers/net/virtio_net.c 1489 1490 static void virt_xsk_complete(struct send_queue *sq, u32 num, bool xsk_wakeup) 1491 { 1492 struct xsk_buff_pool *pool; 1493 int n; 1494 1495 rcu_read_lock(); 1496 1497 WRITE_ONCE(sq->xsk.hdr_pro, sq->xsk.hdr_pro + num); 1498 1499 pool = rcu_dereference(sq->xsk.pool); 1500 if (!pool) { 1501 if (sq->xsk.hdr_pro - sq->xsk.hdr_con == sq->xsk.hdr_n) { > 1502 kfree(sq->xsk.hdr); 1503 rcu_assign_pointer(sq->xsk.hdr, NULL); 1504 } 1505 rcu_read_unlock(); 1506 return; 1507 } 1508 1509 xsk_tx_completed(pool, num); 1510 1511 rcu_read_unlock(); 1512 1513 if (!xsk_wakeup || !sq->xsk.wait_slot) 1514 return; 1515 1516 n = sq->xsk.hdr_pro - sq->xsk.hdr_con; 1517 1518 if (n > sq->xsk.hdr_n / 2) { 1519 sq->xsk.wait_slot = false; 1520 virtqueue_napi_schedule(&sq->napi, sq->vq); 1521 } 1522 } 1523 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [PATCH 2/3] hv_netvsc: Wait for completion on request NVSP_MSG4_TYPE_SWITCH_DATA_PATH
Hi Long, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.11-rc2 next-20210104] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Long-Li/hv_netvsc-Check-VF-datapath-when-sending-traffic-to-VF/20210106-092237 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git e71ba9452f0b5b2e8dc8aa5445198cd9214a6a62 config: i386-allyesconfig (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/8c92b5574da1b0c2aee3eab7da2c4dad8d92572c git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Long-Li/hv_netvsc-Check-VF-datapath-when-sending-traffic-to-VF/20210106-092237 git checkout 8c92b5574da1b0c2aee3eab7da2c4dad8d92572c # save the attached .config to linux build tree make W=1 ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): drivers/net/hyperv/netvsc.c: In function 'netvsc_send_completion': >> drivers/net/hyperv/netvsc.c:778:14: warning: cast to pointer from integer of >> different size [-Wint-to-pointer-cast] 778 | pkt_rqst = (struct nvsp_message *)cmd_rqst; | ^ vim +778 drivers/net/hyperv/netvsc.c 757 758 static void netvsc_send_completion(struct net_device *ndev, 759 struct netvsc_device *net_device, 760 struct vmbus_channel *incoming_channel, 761 const struct vmpacket_descriptor *desc, 762 int budget) 763 { 764 const struct nvsp_message *nvsp_packet = hv_pkt_data(desc); 765 u32 msglen = hv_pkt_datalen(desc); 766 struct nvsp_message *pkt_rqst; 767 u64 cmd_rqst; 768 769 /* First check if this is a VMBUS completion without data payload */ 770 if (!msglen) { 771 cmd_rqst = vmbus_request_addr(&incoming_channel->requestor, 772(u64)desc->trans_id); 773 if (cmd_rqst == VMBUS_RQST_ERROR) { 774 netdev_err(ndev, "Invalid transaction id\n"); 775 return; 776 } 777 > 778 pkt_rqst = (struct nvsp_message *)cmd_rqst; 779 switch (pkt_rqst->hdr.msg_type) { 780 case NVSP_MSG4_TYPE_SWITCH_DATA_PATH: 781 complete(&net_device->channel_init_wait); 782 break; 783 784 default: 785 netdev_err(ndev, "Unexpected VMBUS completion!!\n"); 786 } 787 return; 788 } 789 790 /* Ensure packet is big enough to read header fields */ 791 if (msglen < sizeof(struct nvsp_message_header)) { 792 netdev_err(ndev, "nvsp_message length too small: %u\n", msglen); 793 return; 794 } 795 796 switch (nvsp_packet->hdr.msg_type) { 797 case NVSP_MSG_TYPE_INIT_COMPLETE: 798 if (msglen < sizeof(struct nvsp_message_header) + 799 sizeof(struct nvsp_message_init_complete)) { 800 netdev_err(ndev, "nvsp_msg length too small: %u\n", 801 msglen); 802 return; 803 } 804 fallthrough; 805 806 case NVSP_MSG1_TYPE_SEND_RECV_BUF_COMPLETE: 807 if (msglen < sizeof(struct nvsp_message_header) + 808 sizeof(struct nvsp_1_message_send_receive_buffer_complete)) { 809 netdev_err(ndev, "nvsp_msg1 length too small: %u\n", 810 msglen); 811 return; 812 } 813 fallthrough; 814 815 case NVSP_MSG1_TYPE_SEND_SEND_BUF_COMPLETE: 816 if (msglen < sizeof(struct nvsp_message_header) + 817 sizeof(struct nvsp_1_message_send_send_buffer_complete)) { 818 netdev_err(ndev, "nvsp_msg1 length too small: %u\n", 819 msgle