Hi, Thank you for the patch! Yet something to improve:
[auto build test ERROR on eceae70bdeaeb6b8ceb662983cf663ff352fbc96] url: https://github.com/0day-ci/linux/commits/alardam-gmail-com/New-netdev-feature-flags-for-XDP/20201204-183428 base: eceae70bdeaeb6b8ceb662983cf663ff352fbc96 config: x86_64-randconfig-a003-20201209 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 1968804ac726e7674d5de22bc2204b45857da344) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # https://github.com/0day-ci/linux/commit/34e23fdbb761e9296101b14dc8c523d574ce6f74 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review alardam-gmail-com/New-netdev-feature-flags-for-XDP/20201204-183428 git checkout 34e23fdbb761e9296101b14dc8c523d574ce6f74 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> All errors (new ones prefixed by >>): >> drivers/net/ethernet/intel/ice/ice_main.c:2984:2: error: implicit >> declaration of function 'xsk_set_zc_properties' >> [-Werror,-Wimplicit-function-declaration] xsk_set_zc_properties(&netdev->xdp_properties); ^ drivers/net/ethernet/intel/ice/ice_main.c:2984:2: note: did you mean 'xsk_set_zc_property'? include/net/xdp_sock_drv.h:251:20: note: 'xsk_set_zc_property' declared here static inline void xsk_set_zc_property(xdp_properties_t *properties) ^ 1 error generated. vim +/xsk_set_zc_properties +2984 drivers/net/ethernet/intel/ice/ice_main.c 2951 2952 /** 2953 * ice_cfg_netdev - Allocate, configure and register a netdev 2954 * @vsi: the VSI associated with the new netdev 2955 * 2956 * Returns 0 on success, negative value on failure 2957 */ 2958 static int ice_cfg_netdev(struct ice_vsi *vsi) 2959 { 2960 struct ice_pf *pf = vsi->back; 2961 struct ice_netdev_priv *np; 2962 struct net_device *netdev; 2963 u8 mac_addr[ETH_ALEN]; 2964 int err; 2965 2966 err = ice_devlink_create_port(vsi); 2967 if (err) 2968 return err; 2969 2970 netdev = alloc_etherdev_mqs(sizeof(*np), vsi->alloc_txq, 2971 vsi->alloc_rxq); 2972 if (!netdev) { 2973 err = -ENOMEM; 2974 goto err_destroy_devlink_port; 2975 } 2976 2977 vsi->netdev = netdev; 2978 np = netdev_priv(netdev); 2979 np->vsi = vsi; 2980 2981 ice_set_netdev_features(netdev); 2982 2983 xdp_set_full_properties(&netdev->xdp_properties); > 2984 xsk_set_zc_properties(&netdev->xdp_properties); 2985 2986 ice_set_ops(netdev); 2987 2988 if (vsi->type == ICE_VSI_PF) { 2989 SET_NETDEV_DEV(netdev, ice_pf_to_dev(pf)); 2990 ether_addr_copy(mac_addr, vsi->port_info->mac.perm_addr); 2991 ether_addr_copy(netdev->dev_addr, mac_addr); 2992 ether_addr_copy(netdev->perm_addr, mac_addr); 2993 } 2994 2995 netdev->priv_flags |= IFF_UNICAST_FLT; 2996 2997 /* Setup netdev TC information */ 2998 ice_vsi_cfg_netdev_tc(vsi, vsi->tc_cfg.ena_tc); 2999 3000 /* setup watchdog timeout value to be 5 second */ 3001 netdev->watchdog_timeo = 5 * HZ; 3002 3003 netdev->min_mtu = ETH_MIN_MTU; 3004 netdev->max_mtu = ICE_MAX_MTU; 3005 3006 err = register_netdev(vsi->netdev); 3007 if (err) 3008 goto err_free_netdev; 3009 3010 devlink_port_type_eth_set(&vsi->devlink_port, vsi->netdev); 3011 3012 netif_carrier_off(vsi->netdev); 3013 3014 /* make sure transmit queues start off as stopped */ 3015 netif_tx_stop_all_queues(vsi->netdev); 3016 3017 return 0; 3018 3019 err_free_netdev: 3020 free_netdev(vsi->netdev); 3021 vsi->netdev = NULL; 3022 err_destroy_devlink_port: 3023 ice_devlink_destroy_port(vsi); 3024 return err; 3025 } 3026 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
