Hi Marek,

I love your patch! Perhaps something to improve:

[auto build test WARNING on net/master]
[also build test WARNING on net-next/master ipvs/master linus/master v5.11-rc1 
next-20201223]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    
https://github.com/0day-ci/linux/commits/Marek-Vasut/net-phy-micrel-Add-KS8851-PHY-support/20201230-210003
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git 
4bfc4714849d005e6835bcffa3c29ebd6e5ee35d
config: alpha-allmodconfig (attached as .config)
compiler: alpha-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
        chmod +x ~/bin/make.cross
        # 
https://github.com/0day-ci/linux/commit/799aae00b2ec29ee4a86a2d8b8a8b0c1b816cb84
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review 
Marek-Vasut/net-phy-micrel-Add-KS8851-PHY-support/20201230-210003
        git checkout 799aae00b2ec29ee4a86a2d8b8a8b0c1b816cb84
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross 
ARCH=alpha 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <l...@intel.com>

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/micrel/ks8851_common.c: In function 
'ks8851_register_mdiobus':
>> drivers/net/ethernet/micrel/ks8851_common.c:1082:22: warning: conversion 
>> from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from 
>> '18446744073709551614' to '4294967294' [-Woverflow]
    1082 |  mii_bus->phy_mask = ~BIT(0);
         |                      ^


vim +1082 drivers/net/ethernet/micrel/ks8851_common.c

  1067  
  1068  static int ks8851_register_mdiobus(struct ks8851_net *ks, struct device 
*dev)
  1069  {
  1070          struct mii_bus *mii_bus;
  1071          int ret;
  1072  
  1073          mii_bus = mdiobus_alloc();
  1074          if (!mii_bus)
  1075                  return -ENOMEM;
  1076  
  1077          mii_bus->name = "ks8851_eth_mii";
  1078          mii_bus->read = ks8851_mdio_read;
  1079          mii_bus->write = ks8851_mdio_write;
  1080          mii_bus->priv = ks;
  1081          mii_bus->parent = dev;
> 1082          mii_bus->phy_mask = ~BIT(0);
  1083          snprintf(mii_bus->id, MII_BUS_ID_SIZE, "%s", dev_name(dev));
  1084  
  1085          ret = mdiobus_register(mii_bus);
  1086          if (ret)
  1087                  goto err_mdiobus_register;
  1088  
  1089          ks->mii_bus = mii_bus;
  1090  
  1091          return 0;
  1092  
  1093  err_mdiobus_register:
  1094          mdiobus_free(mii_bus);
  1095          return ret;
  1096  }
  1097  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org

Attachment: .config.gz
Description: application/gzip

Reply via email to