[Kmymoney-devel] [Bug 311347] New: Kmymoney crash

2012-12-08 Thread Tim 
https://bugs.kde.org/show_bug.cgi?id=311347

Bug ID: 311347
  Severity: crash
   Version: 4.6.1
  Priority: NOR
  Assignee: kmymoney-devel@kde.org
   Summary: Kmymoney crash
Classification: Unclassified
OS: Linux
  Reporter: tmic...@cox.net
  Hardware: Ubuntu Packages
Status: UNCONFIRMED
 Component: general
   Product: kmymoney4

Application: kmymoney (4.6.1)
KDE Platform Version: 4.8.5 (4.8.5)
Qt Version: 4.8.1
Operating System: Linux 3.2.0-34-generic-pae i686
Distribution: Ubuntu 12.04.1 LTS

-- Information about the crash:
- What I was doing when the application crashed:

entering a transaction into register, used either enter keys instead of
clicking "enter" tab on transaction form.

The crash can be reproduced every time.

-- Backtrace:
Application: KMyMoney (kmymoney), signal: Segmentation fault
Using host libthread_db library "/lib/i386-linux-gnu/libthread_db.so.1".
[Current thread is 1 (Thread 0xb3c4f740 (LWP 6204))]

Thread 3 (Thread 0xb16d5b40 (LWP 6205)):
#0  0xb76e7424 in __kernel_vsyscall ()
#1  0xb518f5f0 in poll () from /lib/i386-linux-gnu/libc.so.6
#2  0xb4618a7b in g_poll () from /lib/i386-linux-gnu/libglib-2.0.so.0
#3  0xb460b0ae in ?? () from /lib/i386-linux-gnu/libglib-2.0.so.0
#4  0xb460b56b in g_main_loop_run () from /lib/i386-linux-gnu/libglib-2.0.so.0
#5  0xb16da134 in ?? () from
/usr/lib/i386-linux-gnu/gio/modules/libdconfsettings.so
#6  0xb462e6b3 in ?? () from /lib/i386-linux-gnu/libglib-2.0.so.0
#7  0xb67bbd4c in start_thread () from /lib/i386-linux-gnu/libpthread.so.0
#8  0xb519dd3e in clone () from /lib/i386-linux-gnu/libc.so.6

Thread 2 (Thread 0xb0cffb40 (LWP 6206)):
#0  0xb76e7424 in __kernel_vsyscall ()
#1  0xb518f5f0 in poll () from /lib/i386-linux-gnu/libc.so.6
#2  0xb4618a7b in g_poll () from /lib/i386-linux-gnu/libglib-2.0.so.0
#3  0xb460b0ae in ?? () from /lib/i386-linux-gnu/libglib-2.0.so.0
#4  0xb460b56b in g_main_loop_run () from /lib/i386-linux-gnu/libglib-2.0.so.0
#5  0xb241b1ba in ?? () from /usr/lib/i386-linux-gnu/libgio-2.0.so.0
#6  0xb462e6b3 in ?? () from /lib/i386-linux-gnu/libglib-2.0.so.0
#7  0xb67bbd4c in start_thread () from /lib/i386-linux-gnu/libpthread.so.0
#8  0xb519dd3e in clone () from /lib/i386-linux-gnu/libc.so.6

Thread 1 (Thread 0xb3c4f740 (LWP 6204)):
[KCrash Handler]
#7  QWidget::nativeParentWidget (this=0xb685768) at kernel/qwidget.cpp:4353
#8  0xb550e33c in QWidget::effectiveWinId (this=0xb685768) at
kernel/qwidget.cpp:2612
#9  0xb5b30616 in QXIMInputContext::reset (this=0xb090250) at
inputmethod/qximinputcontext_x11.cpp:579
#10 0xb5b32a0d in QXIMInputContext::setFocusWidget (this=0xb090250, w=0x0) at
inputmethod/qximinputcontext_x11.cpp:649
#11 0xb5b31fe4 in QXIMInputContext::close_xim (this=0xb090250) at
inputmethod/qximinputcontext_x11.cpp:533
#12 0xb5b32104 in QXIMInputContext::~QXIMInputContext (this=0xb090250,
__in_chrg=) at inputmethod/qximinputcontext_x11.cpp:542
#13 0xb5b321c2 in QXIMInputContext::~QXIMInputContext (this=0xb090250,
__in_chrg=) at inputmethod/qximinputcontext_x11.cpp:545
#14 0xb606ed11 in QObjectPrivate::deleteChildren (this=0xa1f4ef0) at
kernel/qobject.cpp:1908
#15 0xb551817c in QWidget::~QWidget (this=0xb61d938, __in_chrg=)
at kernel/qwidget.cpp:1676
#16 0xb59078fe in QComboBox::~QComboBox (this=0xb61d938, __in_chrg=) at widgets/qcombobox.cpp:1298
#17 0xb6c3cc28 in KComboBox::~KComboBox() () from /usr/lib/libkdeui.so.5
#18 0x08368350 in ~KMyMoneyCombo (this=0xb61d938, __in_chrg=) at
/build/buildd/kmymoney-4.6.1/kmymoney/widgets/kmymoneycombo.h:48
#19 KMyMoneyCategory::~KMyMoneyCategory (this=0xb61d938, __in_chrg=) at /build/buildd/kmymoney-4.6.1/kmymoney/widgets/kmymoneycategory.cpp:99
#20 0x083684e2 in KMyMoneyCategory::~KMyMoneyCategory (this=0xb61d938,
__in_chrg=) at
/build/buildd/kmymoney-4.6.1/kmymoney/widgets/kmymoneycategory.cpp:106
#21 0x0820daaf in KMyMoneyTransactionForm::TransactionForm::removeEditWidgets
(this=0xa717510, editWidgets=...) at
/build/buildd/kmymoney-4.6.1/kmymoney/widgets/transactionform.cpp:447
#22 0x08334c47 in TransactionEditor::~TransactionEditor (this=0xb398990,
__in_chrg=) at
/build/buildd/kmymoney-4.6.1/kmymoney/dialogs/transactioneditor.cpp:89
#23 0x08334e12 in StdTransactionEditor::~StdTransactionEditor (this=0xb398990,
__in_chrg=) at
/build/buildd/kmymoney-4.6.1/kmymoney/dialogs/transactioneditor.cpp:726
#24 0x080b8007 in deleteTransactionEditor (this=0xa114ec0) at
/build/buildd/kmymoney-4.6.1/kmymoney/kmymoney.cpp:5169
#25 KMyMoneyApp::slotTransactionsEnter (this=0xa114ec0) at
/build/buildd/kmymoney-4.6.1/kmymoney/kmymoney.cpp:5233
#26 0x080d296d in KMyMoneyApp::qt_static_metacall (_o=0xa114ec0,
_c=QMetaObject::InvokeMetaMethod, _id=78, _a=0xbf9d3e78) at
/build/buildd/kmymoney-4.6.1/obj-i686-linux-gnu/kmymoney/kmymoney.moc:456
#27 0xb60706b1 in QMetaObject::activate (sender=0xa2c89a8, m=0xb5e3b3f8,
local_signal_index=1, argv=0xbf9d3e78) at kernel/qobject.cpp:3547

Re: [Kmymoney-devel] Review Request: Refactoring of matching a transaction-under-import

2012-12-08 Thread Łukasz Maszczyński 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107137/
---

(Updated Dec. 8, 2012, 4:45 p.m.)


Review request for KMymoney.


Changes
---

1. const correctness
2. BOOST_FOREACH loops replaced with Qt's foreach


Description
---

1. please note that dependency on Boost is no longer optional (see changes in 
CMakeLists.txt)

2. Architectural changes
   Until now, the method MyMoneyStatementReader::processTransactionEntry() 
handled the whole process of importing a transaction - that is: handling the 
securities, matching and creating payees, and - at the very end of the method - 
adding the transaction to the ledger.
   The last step (adding transaction to ledger) is the main target of this 
refactoring. Its algorithm was as follows:
   1. find a matching transaction (either existing or scheduled) - using 
TransactionMatcher::findMatch()
   2. If an "existing transaction match" is found - handle it (in the old code 
it's the block starting with a comment "// it matched a simple transaction. 
that's the easy case")
   3. Else if a "scheduled transaction match" is found - handle it ("// a match 
has been found in a pending schedule"...)

   Code "mapping" is as follows:
   - step 2 (above) is extracted to handleMatchingOfExistingTransaction()
   - step 3 (above) is extracted to handleMatchingOfScheduledTransaction()
   - TransactionMatcher::findMatch() is extracted to 
TransactionMatchFinder::findMatch() (note: there are two pure-virtual functions 
that are implemented in ExistingTransactionMatchFinder, 
ScheduledTransactionMatchFinder classes)
   - TransactionMatcher::checkTransaction() is extracted to 
TransactionMatchFinder::findMatchingSplit()

3. Memory management changes
   Raw pointers are no longer used, as these are typically error-prone. 
Pointers were replaced either with object instances, or boost::optional is used 
if applicable (e.g. see members of TransactionMatchFinder class).

4. dynamic_casts removed (were used on pointers returned by 
TransactionMatcher::findMatch(), no longer needed - see 
TransactionMatchFinder::getMatchedTransaction() and getMatchedSchedule() )

5. variable/method names - I did my best to keep those meaningful: e.g. 
"importedTransaction" instead of "t")


Diffs (updated)
-

  CMakeLists.txt 93af070 
  kmymoney/converter/mymoneystatementreader.h 758ff00 
  kmymoney/converter/mymoneystatementreader.cpp 42c4841 
  kmymoney/dialogs/CMakeLists.txt 9a8d782 
  kmymoney/dialogs/existingtransactionmatchfinder.h PRE-CREATION 
  kmymoney/dialogs/existingtransactionmatchfinder.cpp PRE-CREATION 
  kmymoney/dialogs/scheduledtransactionmatchfinder.h PRE-CREATION 
  kmymoney/dialogs/scheduledtransactionmatchfinder.cpp PRE-CREATION 
  kmymoney/dialogs/transactionmatcher.h d09a4cd 
  kmymoney/dialogs/transactionmatcher.cpp c380877 
  kmymoney/dialogs/transactionmatchfinder.h PRE-CREATION 
  kmymoney/dialogs/transactionmatchfinder.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/107137/diff/


Testing
---

make test


Thanks,

Łukasz Maszczyński

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request: Refactoring of matching a transaction-under-import

2012-12-08 Thread Łukasz Maszczyński 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107137/
---

(Updated Dec. 8, 2012, 4:49 p.m.)


Review request for KMymoney.


Changes
---

One more BOOST_FOREACH loop replaced with Qt's foreach


Description
---

1. please note that dependency on Boost is no longer optional (see changes in 
CMakeLists.txt)

2. Architectural changes
   Until now, the method MyMoneyStatementReader::processTransactionEntry() 
handled the whole process of importing a transaction - that is: handling the 
securities, matching and creating payees, and - at the very end of the method - 
adding the transaction to the ledger.
   The last step (adding transaction to ledger) is the main target of this 
refactoring. Its algorithm was as follows:
   1. find a matching transaction (either existing or scheduled) - using 
TransactionMatcher::findMatch()
   2. If an "existing transaction match" is found - handle it (in the old code 
it's the block starting with a comment "// it matched a simple transaction. 
that's the easy case")
   3. Else if a "scheduled transaction match" is found - handle it ("// a match 
has been found in a pending schedule"...)

   Code "mapping" is as follows:
   - step 2 (above) is extracted to handleMatchingOfExistingTransaction()
   - step 3 (above) is extracted to handleMatchingOfScheduledTransaction()
   - TransactionMatcher::findMatch() is extracted to 
TransactionMatchFinder::findMatch() (note: there are two pure-virtual functions 
that are implemented in ExistingTransactionMatchFinder, 
ScheduledTransactionMatchFinder classes)
   - TransactionMatcher::checkTransaction() is extracted to 
TransactionMatchFinder::findMatchingSplit()

3. Memory management changes
   Raw pointers are no longer used, as these are typically error-prone. 
Pointers were replaced either with object instances, or boost::optional is used 
if applicable (e.g. see members of TransactionMatchFinder class).

4. dynamic_casts removed (were used on pointers returned by 
TransactionMatcher::findMatch(), no longer needed - see 
TransactionMatchFinder::getMatchedTransaction() and getMatchedSchedule() )

5. variable/method names - I did my best to keep those meaningful: e.g. 
"importedTransaction" instead of "t")


Diffs (updated)
-

  CMakeLists.txt 93af070 
  kmymoney/converter/mymoneystatementreader.h 758ff00 
  kmymoney/converter/mymoneystatementreader.cpp 42c4841 
  kmymoney/dialogs/CMakeLists.txt 9a8d782 
  kmymoney/dialogs/existingtransactionmatchfinder.h PRE-CREATION 
  kmymoney/dialogs/existingtransactionmatchfinder.cpp PRE-CREATION 
  kmymoney/dialogs/scheduledtransactionmatchfinder.h PRE-CREATION 
  kmymoney/dialogs/scheduledtransactionmatchfinder.cpp PRE-CREATION 
  kmymoney/dialogs/transactionmatcher.h d09a4cd 
  kmymoney/dialogs/transactionmatcher.cpp c380877 
  kmymoney/dialogs/transactionmatchfinder.h PRE-CREATION 
  kmymoney/dialogs/transactionmatchfinder.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/107137/diff/


Testing
---

make test


Thanks,

Łukasz Maszczyński

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request: Refactoring of matching a transaction-under-import

2012-12-08 Thread Łukasz Maszczyński 


> On Dec. 7, 2012, 6:35 p.m., Cristian Oneț wrote:
> >
> 
> Cristian Oneț wrote:
> I don't have anything else to add other than these two issues and the 
> boost hard dependency. If the dependency get's the OK from the others and 
> these small issues are fixed then this review is OK to be shipped since it 
> seems to work as the old code but it is a lot more readable.

Issues fixed in rev.7. I also replaced BOOST_FOREACH with Qt's foreach loop, as 
Thomas originally suggested. 

Boost is still needed for boost::optional though, and in my opinion we 
shouldn't get rid of boost just because it's not Qt ;)


- Łukasz


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107137/#review23132
---


On Dec. 8, 2012, 4:49 p.m., Łukasz Maszczyński wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107137/
> ---
> 
> (Updated Dec. 8, 2012, 4:49 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Description
> ---
> 
> 1. please note that dependency on Boost is no longer optional (see changes in 
> CMakeLists.txt)
> 
> 2. Architectural changes
>Until now, the method MyMoneyStatementReader::processTransactionEntry() 
> handled the whole process of importing a transaction - that is: handling the 
> securities, matching and creating payees, and - at the very end of the method 
> - adding the transaction to the ledger.
>The last step (adding transaction to ledger) is the main target of this 
> refactoring. Its algorithm was as follows:
>1. find a matching transaction (either existing or scheduled) - using 
> TransactionMatcher::findMatch()
>2. If an "existing transaction match" is found - handle it (in the old 
> code it's the block starting with a comment "// it matched a simple 
> transaction. that's the easy case")
>3. Else if a "scheduled transaction match" is found - handle it ("// a 
> match has been found in a pending schedule"...)
> 
>Code "mapping" is as follows:
>- step 2 (above) is extracted to handleMatchingOfExistingTransaction()
>- step 3 (above) is extracted to handleMatchingOfScheduledTransaction()
>- TransactionMatcher::findMatch() is extracted to 
> TransactionMatchFinder::findMatch() (note: there are two pure-virtual 
> functions that are implemented in ExistingTransactionMatchFinder, 
> ScheduledTransactionMatchFinder classes)
>- TransactionMatcher::checkTransaction() is extracted to 
> TransactionMatchFinder::findMatchingSplit()
> 
> 3. Memory management changes
>Raw pointers are no longer used, as these are typically error-prone. 
> Pointers were replaced either with object instances, or boost::optional is 
> used if applicable (e.g. see members of TransactionMatchFinder class).
> 
> 4. dynamic_casts removed (were used on pointers returned by 
> TransactionMatcher::findMatch(), no longer needed - see 
> TransactionMatchFinder::getMatchedTransaction() and getMatchedSchedule() )
> 
> 5. variable/method names - I did my best to keep those meaningful: e.g. 
> "importedTransaction" instead of "t")
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 93af070 
>   kmymoney/converter/mymoneystatementreader.h 758ff00 
>   kmymoney/converter/mymoneystatementreader.cpp 42c4841 
>   kmymoney/dialogs/CMakeLists.txt 9a8d782 
>   kmymoney/dialogs/existingtransactionmatchfinder.h PRE-CREATION 
>   kmymoney/dialogs/existingtransactionmatchfinder.cpp PRE-CREATION 
>   kmymoney/dialogs/scheduledtransactionmatchfinder.h PRE-CREATION 
>   kmymoney/dialogs/scheduledtransactionmatchfinder.cpp PRE-CREATION 
>   kmymoney/dialogs/transactionmatcher.h d09a4cd 
>   kmymoney/dialogs/transactionmatcher.cpp c380877 
>   kmymoney/dialogs/transactionmatchfinder.h PRE-CREATION 
>   kmymoney/dialogs/transactionmatchfinder.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/107137/diff/
> 
> 
> Testing
> ---
> 
> make test
> 
> 
> Thanks,
> 
> Łukasz Maszczyński
> 
>

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[Kmymoney-devel] [Bug 311357] New: kmm crashes when filtering categories

2012-12-08 Thread 20120808_bugs.kde.org 
https://bugs.kde.org/show_bug.cgi?id=311357

Bug ID: 311357
  Severity: crash
   Version: 4.6.1
  Priority: NOR
  Assignee: kmymoney-devel@kde.org
   Summary: kmm crashes when filtering categories
Classification: Unclassified
OS: Linux
  Reporter: 20120808_bugs.kde@waltzingalong.org
  Hardware: Ubuntu Packages
Status: UNCONFIRMED
 Component: general
   Product: kmymoney4

Application: kmymoney (4.6.1)
KDE Platform Version: 4.9.4
Qt Version: 4.8.2
Operating System: Linux 3.7.0-030700rc8-generic x86_64
Distribution: Ubuntu 12.04.1 LTS

-- Information about the crash:
had finished entering some transactions in a ledger; saved; switched to
categories to modify one of the categories; used the filter (entered a few
characters), at which point kmymoney crashed

The crash can be reproduced some of the time.

-- Backtrace:
Application: KMyMoney (kmymoney), signal: Segmentation fault
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
[Current thread is 1 (Thread 0x7f313d2aa780 (LWP 4762))]

Thread 2 (Thread 0x7f3124c19700 (LWP 4763)):
#0  timerSourcePrepareHelper (src=, timeout=0x7f3124c18c6c) at
kernel/qeventdispatcher_glib.cpp:139
#1  0x7f3139555f05 in timerSourcePrepare (source=,
timeout=) at kernel/qeventdispatcher_glib.cpp:169
#2  0x7f3132fd9846 in g_main_context_prepare () from
/lib/x86_64-linux-gnu/libglib-2.0.so.0
#3  0x7f3132fd9f5b in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#4  0x7f3132fda164 in g_main_context_iteration () from
/lib/x86_64-linux-gnu/libglib-2.0.so.0
#5  0x7f3139556906 in QEventDispatcherGlib::processEvents
(this=0x7f3128c0, flags=...) at kernel/qeventdispatcher_glib.cpp:426
#6  0x7f3139525e42 in QEventLoop::processEvents (this=,
flags=...) at kernel/qeventloop.cpp:149
#7  0x7f3139526097 in QEventLoop::exec (this=0x7f3124c18dd0, flags=...) at
kernel/qeventloop.cpp:204
#8  0x7f3139425057 in QThread::exec (this=) at
thread/qthread.cpp:501
#9  0x7f3139505b4f in QInotifyFileSystemWatcherEngine::run (this=0x1869aa0)
at io/qfilesystemwatcher_inotify.cpp:248
#10 0x7f313942807b in QThreadPrivate::start (arg=0x1869aa0) at
thread/qthread_unix.cpp:307
#11 0x7f313a698e9a in start_thread (arg=0x7f3124c19700) at
pthread_create.c:308
#12 0x7f3137981cbd in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:112
#13 0x in ?? ()

Thread 1 (Thread 0x7f313d2aa780 (LWP 4762)):
[KCrash Handler]
#6  qCopy (dest=, end=0xd7717a8,
begin=0x80de75df8) at
../../include/QtCore/../../src/corelib/tools/qalgorithms.h:82
#7  QVector::erase (this=0x7d26e40, abegin=,
aend=) at
../../include/QtCore/../../src/corelib/tools/qvector.h:634
#8  0x7f3138bdfffe in erase (pos=0xde75de0, this=0x7d26e40) at
../../include/QtCore/../../src/corelib/tools/qvector.h:256
#9  QSortFilterProxyModelPrivate::filter_changed (this=0x1a08210,
source_parent=...) at itemviews/qsortfilterproxymodel.cpp:1044
#10 0x7f3138be00aa in QSortFilterProxyModelPrivate::filter_changed
(this=0x1a08210, source_parent=...) at itemviews/qsortfilterproxymodel.cpp:1047
#11 0x7f3138be0285 in QSortFilterProxyModel::setFilterFixedString
(this=, pattern=...) at itemviews/qsortfilterproxymodel.cpp:2227
#12 0x7f313953b761 in QMetaObject::activate (sender=0x1a01560, m=, local_signal_index=, argv=0x7fff87957920) at
kernel/qobject.cpp:3547
#13 0x7f3138a4c142 in QLineEdit::textChanged (this=,
_t1=...) at .moc/release-shared/moc_qlineedit.cpp:264
#14 0x7f3138a4c3e9 in QLineEdit::qt_static_metacall (_o=,
_c=, _id=, _a=) at
.moc/release-shared/moc_qlineedit.cpp:140
#15 0x7f313953b761 in QMetaObject::activate (sender=0x1a018e0, m=, local_signal_index=, argv=0x7fff87957a90) at
kernel/qobject.cpp:3547
#16 0x7f3138cbf2f5 in QLineControl::textChanged (this=,
_t1=...) at .moc/release-shared/moc_qlinecontrol_p.cpp:148
#17 0x7f3138a5100b in QLineControl::finishChange (this=0x1a018e0,
validateFromState=13, update=, edited=true) at
widgets/qlinecontrol.cpp:660
#18 0x7f3138a533dd in QLineControl::processKeyEvent (this=0x1a018e0,
event=0x7fff87958850) at widgets/qlinecontrol.cpp:1879
#19 0x7f3138a481d9 in QLineEdit::keyPressEvent (this=0x1a01560,
event=0x7fff87958850) at widgets/qlineedit.cpp:1707
#20 0x7f313b97c488 in KLineEdit::keyPressEvent(QKeyEvent*) () from
/usr/lib/libkdeui.so.5
#21 0x7f313867c038 in QWidget::event (this=0x1a01560, event=0x7fff87958850)
at kernel/qwidget.cpp:8406
#22 0x7f3138a4a777 in QLineEdit::event (this=0x1a01560, e=0x7fff87958850)
at widgets/qlineedit.cpp:1524
#23 0x7f313b97ab7b in KLineEdit::event(QEvent*) () from
/usr/lib/libkdeui.so.5
#24 0x7f313862b7b4 in notify_helper (e=0x7fff87958850, receiver=0x1a01560,
this=0x11a8e30) at kernel/qapplication.cpp:4556
#25 QApplicationPrivate::notify_helper (this=0x11a8e30, receiver=0x1a01560,
e=0x7fff87958850) at kernel/qapplication.cpp:4528
#2

Re: [Kmymoney-devel] Review Request: Refactoring of matching a transaction-under-import

2012-12-08 Thread Alvaro Soliverez 
I disagree. It's not about adding a non-Qt dependency, which KMyMoney
already has a few. It's about adding a new dependency without a sound
rationale, just for a convenience class that one or another developer has
grown used to.

I still don't see boost bringing in enough of an improvement to add a new
dependency here.

Besides this, my experience with boost has been horrible in the past.
Removing or adding features for minor versions, API changing, no ABI
compatibility and other stuff. It's not the kind of dependency I'd like to
maintain.

Regards,
Alvaro

On Sat, Dec 8, 2012 at 1:58 PM, Łukasz Maszczyński
wrote:

> needed for boost::optional though, and in my opinion we shouldn't get rid
> of boost just because it's n
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request: Refactoring of matching a transaction-under-import

2012-12-08 Thread Alvaro Soliverez 
BTW, when the Transaction objects are created, they are initialized, so I
really don't see why boost::optional should be used here.


On Sat, Dec 8, 2012 at 2:08 PM, Alvaro Soliverez  wrote:

> I disagree. It's not about adding a non-Qt dependency, which KMyMoney
> already has a few. It's about adding a new dependency without a sound
> rationale, just for a convenience class that one or another developer has
> grown used to.
>
> I still don't see boost bringing in enough of an improvement to add a new
> dependency here.
>
> Besides this, my experience with boost has been horrible in the past.
> Removing or adding features for minor versions, API changing, no ABI
> compatibility and other stuff. It's not the kind of dependency I'd like to
> maintain.
>
> Regards,
> Alvaro
>
>
> On Sat, Dec 8, 2012 at 1:58 PM, Łukasz Maszczyński  > wrote:
>
>> needed for boost::optional though, and in my opinion we shouldn't get rid
>> of boost just because it's n
>
>
>
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request: show another icon on homepage accounts tables if there are transactions after the last online transaction (not yet functioning as expected)

2012-12-08 Thread Marko Käning 


> On Dec. 7, 2012, 6:50 p.m., Cristian Oneț wrote:
> > kmymoney/views/khomeview.cpp, line 865
> > 
> >
> > You are comparing the last reconciliation date with the last imported 
> > transaction date, it that what you really want?

I thought that "lastStatementDate" is the last transaction in the ledger. Now 
you tell me that it is the last reconciled one... OK, that explains it.

How do I find the date of the last transaction in the ledger?


- Marko


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107619/#review23134
---


On Dec. 6, 2012, 9:41 p.m., Marko Käning wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107619/
> ---
> 
> (Updated Dec. 6, 2012, 9:41 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Description
> ---
> 
> The goal is to show another icon in homepage accounts tables if there are 
> transactions for an account after the last online transaction.
> 
> Unfortunately this is not yet functioning as expected! :-(
> 
> Obviously my date comparison in line 865 doesn't work the way I thought it 
> would do. 
> What am I doing wrong here?
> 
> 
> Diffs
> -
> 
>   kmymoney/views/khomeview.cpp c79337176b7265cabe15cad4972bc719e797af7c 
> 
> Diff: http://git.reviewboard.kde.org/r/107619/diff/
> 
> 
> Testing
> ---
> 
> Does not yet show the desired icon. :-(
> 
> 
> Thanks,
> 
> Marko Käning
> 
>

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request: Some i18n improvements

2012-12-08 Thread Rolf Eike Beer 


> On April 28, 2012, 6:52 a.m., Marko Käning wrote:
> > This looks all sensible to me.
> > 
> > 
> > And yes, why wouldn't one want to use this approach:
> > 
> > > -why are the month names as translatable strings in there, isn't it 
> > > enough to call QDate::longMonthName()?
> > 
> > 

Ping?


- Rolf Eike


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103622/#review13013
---


On Jan. 3, 2012, 8:25 p.m., Rolf Eike Beer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103622/
> ---
> 
> (Updated Jan. 3, 2012, 8:25 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Description
> ---
> 
> This is the beginning of some work needed to ease translators work. I was 
> looking into the kmymoney.po file today and found a bunch of issues which I 
> reported to the IRC channel and now copy in here:
> 
> -then there is a pushbutton labeled "Del", while usually "Delete" is used. 
> Using the short form there will not give any benefits, as most translations 
> will be longer anyway. Near that "Del" thing are some other very short texts, 
> like "Upd", "Res", "Ren", and so on. As long as you don't put in a context 
> that says the translation must not be longer than 3 characters this effort on 
> short names is void
> -then 'Duplicate' has contexts 'Duplicate transaction' and 'To duplicate a 
> split'. I would say the first context will fit the second place, too
> -there are 3 occurences of "From" without context, and one with context 
> ">From (Date)". would be nice if the other 3 could be annotated, too. For 
> stable branch (if applicable): only annotate those that would get "From 
> (Date)", this will not break string freeze
> -then there is the tooltip "Select column containing amount field", once with 
> and once without following dot. one has a context that is the text itself, 
> the other has none. I suggest using the one with dot and without context
> -then there is the text "Select column containing date field", also with and 
> without dot
> -the context is "verb, Select column containing number field." which doesn't 
> look useful to me
> -there are some more tooltips with the context being "verb, "
> -there are a lot of "Total" with context "Total balance" (which is enough 
> IMHO). Then there are 2 with "Total balance for ..." which can be merged in 
> the above IMHO
> -why are the month names as translatable strings in there, isn't it enough to 
> call QDate::longMonthName()?
> -kmymoney/plugins/csvimport/lines-datewizardpage.ui:241, 246, 251 have 
> strings like "y m d". The translation fuzzy cache shows that such a string 
> previously existed with the context "abbreviation of 'year', 'month', 'day'". 
> I would like to see that context returning.
> -there are strings that start or end in whitespace, I'm not sure if that 
> makes sense at all
> 
> I left out some parts of the chat that are already fixed by the attached 
> patch. Some other lines are rearranged to make reading smoother as related 
> lines are together. Please note that I'll not go to fix up the rest as there 
> is additional knowledge needed about the program that I don't have and I 
> don't really have time to go over the whole codebase. I hope this is still 
> valueable for you as it may give you an idea of what needs to be touched.
> 
> 
> Diffs
> -
> 
>   kmymoney/dialogs/settings/ksettingsregisterdecl.ui 8d99e48 
>   kmymoney/kmymoneyutils.cpp 0d524e2 
>   kmymoney/plugins/csvimport/separatorwizardpage.ui f9d07d3 
>   kmymoney/views/kmymoneyview.cpp 8369f66 
>   kmymoney/widgets/transaction.cpp bfaafbf 
>   kmymoney/wizards/newaccountwizard/kloanpaymentpagedecl.ui 6b7bf1e 
>   kmymoney/wizards/newaccountwizard/knewaccountwizard.cpp a35cb16 
>   kmymoney/wizards/newloanwizard/summaryeditwizardpagedecl.ui 1c7de3e 
> 
> Diff: http://git.reviewboard.kde.org/r/103622/diff/
> 
> 
> Testing
> ---
> 
> None (not even compile tested)
> 
> 
> Thanks,
> 
> Rolf Eike Beer
> 
>

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Re: [Kmymoney-devel] Review Request: Some i18n improvements

2012-12-08 Thread Allan Anderson 


> On April 28, 2012, 6:52 a.m., Marko Käning wrote:
> > This looks all sensible to me.
> > 
> > 
> > And yes, why wouldn't one want to use this approach:
> > 
> > > -why are the month names as translatable strings in there, isn't it 
> > > enough to call QDate::longMonthName()?
> > 
> > 
> 
> Rolf Eike Beer wrote:
> Ping?

Just to confirm that the csv plugin issues were attended to last March.
At least, the ones I know to be mine.


- Allan


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103622/#review13013
---


On Jan. 3, 2012, 8:25 p.m., Rolf Eike Beer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103622/
> ---
> 
> (Updated Jan. 3, 2012, 8:25 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Description
> ---
> 
> This is the beginning of some work needed to ease translators work. I was 
> looking into the kmymoney.po file today and found a bunch of issues which I 
> reported to the IRC channel and now copy in here:
> 
> -then there is a pushbutton labeled "Del", while usually "Delete" is used. 
> Using the short form there will not give any benefits, as most translations 
> will be longer anyway. Near that "Del" thing are some other very short texts, 
> like "Upd", "Res", "Ren", and so on. As long as you don't put in a context 
> that says the translation must not be longer than 3 characters this effort on 
> short names is void
> -then 'Duplicate' has contexts 'Duplicate transaction' and 'To duplicate a 
> split'. I would say the first context will fit the second place, too
> -there are 3 occurences of "From" without context, and one with context 
> ">From (Date)". would be nice if the other 3 could be annotated, too. For 
> stable branch (if applicable): only annotate those that would get "From 
> (Date)", this will not break string freeze
> -then there is the tooltip "Select column containing amount field", once with 
> and once without following dot. one has a context that is the text itself, 
> the other has none. I suggest using the one with dot and without context
> -then there is the text "Select column containing date field", also with and 
> without dot
> -the context is "verb, Select column containing number field." which doesn't 
> look useful to me
> -there are some more tooltips with the context being "verb, "
> -there are a lot of "Total" with context "Total balance" (which is enough 
> IMHO). Then there are 2 with "Total balance for ..." which can be merged in 
> the above IMHO
> -why are the month names as translatable strings in there, isn't it enough to 
> call QDate::longMonthName()?
> -kmymoney/plugins/csvimport/lines-datewizardpage.ui:241, 246, 251 have 
> strings like "y m d". The translation fuzzy cache shows that such a string 
> previously existed with the context "abbreviation of 'year', 'month', 'day'". 
> I would like to see that context returning.
> -there are strings that start or end in whitespace, I'm not sure if that 
> makes sense at all
> 
> I left out some parts of the chat that are already fixed by the attached 
> patch. Some other lines are rearranged to make reading smoother as related 
> lines are together. Please note that I'll not go to fix up the rest as there 
> is additional knowledge needed about the program that I don't have and I 
> don't really have time to go over the whole codebase. I hope this is still 
> valueable for you as it may give you an idea of what needs to be touched.
> 
> 
> Diffs
> -
> 
>   kmymoney/dialogs/settings/ksettingsregisterdecl.ui 8d99e48 
>   kmymoney/kmymoneyutils.cpp 0d524e2 
>   kmymoney/plugins/csvimport/separatorwizardpage.ui f9d07d3 
>   kmymoney/views/kmymoneyview.cpp 8369f66 
>   kmymoney/widgets/transaction.cpp bfaafbf 
>   kmymoney/wizards/newaccountwizard/kloanpaymentpagedecl.ui 6b7bf1e 
>   kmymoney/wizards/newaccountwizard/knewaccountwizard.cpp a35cb16 
>   kmymoney/wizards/newloanwizard/summaryeditwizardpagedecl.ui 1c7de3e 
> 
> Diff: http://git.reviewboard.kde.org/r/103622/diff/
> 
> 
> Testing
> ---
> 
> None (not even compile tested)
> 
> 
> Thanks,
> 
> Rolf Eike Beer
> 
>

___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel