[PR] More cleanup [maven-mvnd]
cstamas opened a new pull request, #967: URL: https://github.com/apache/maven-mvnd/pull/967 Changes: * update maven-wrapper to 3.3.0 * do not override parent versions * use properties where appropriate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Make our lives simpler: mvnd is Java17 [maven-mvnd]
cstamas closed pull request #956: Make our lives simpler: mvnd is Java17 URL: https://github.com/apache/maven-mvnd/pull/956 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Make mvnd Java17 [maven-mvnd]
cstamas closed issue #954: Make mvnd Java17 URL: https://github.com/apache/maven-mvnd/issues/954 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Make our lives simpler: mvnd is Java17 [maven-mvnd]
cstamas commented on PR #956: URL: https://github.com/apache/maven-mvnd/pull/956#issuecomment-2071611702 Agreed, closing this one out -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] More cleanup [maven-mvnd]
cstamas merged PR #967: URL: https://github.com/apache/maven-mvnd/pull/967 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.junit.jupiter:junit-jupiter from 5.7.0 to 5.10.2 [maven-mvnd]
dependabot[bot] commented on PR #961: URL: https://github.com/apache/maven-mvnd/pull/961#issuecomment-2071620657 Looks like org.junit.jupiter:junit-jupiter is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.junit.jupiter:junit-jupiter from 5.7.0 to 5.10.2 [maven-mvnd]
dependabot[bot] closed pull request #961: Bump org.junit.jupiter:junit-jupiter from 5.7.0 to 5.10.2 URL: https://github.com/apache/maven-mvnd/pull/961 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.junit.jupiter:junit-jupiter-params from 5.7.0 to 5.10.2 [maven-mvnd]
dependabot[bot] commented on PR #964: URL: https://github.com/apache/maven-mvnd/pull/964#issuecomment-2071620745 Looks like org.junit.jupiter:junit-jupiter-params is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] More cleanup [maven-mvnd]
cstamas commented on code in PR #967: URL: https://github.com/apache/maven-mvnd/pull/967#discussion_r1575779152 ## .mvn/wrapper/maven-wrapper.properties: ## @@ -6,13 +6,12 @@ # "License"); you may not use this file except in compliance # with the License. You may obtain a copy of the License at # -# https://www.apache.org/licenses/LICENSE-2.0 +# http://www.apache.org/licenses/LICENSE-2.0 Review Comment: yes, but this is licence, "verbatim copied": https://www.apache.org/licenses/LICENSE-2.0 In license it does have HTTP and not HTTPS -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] More cleanup [maven-mvnd]
gnodet commented on code in PR #967: URL: https://github.com/apache/maven-mvnd/pull/967#discussion_r1575778108 ## .mvn/wrapper/maven-wrapper.properties: ## @@ -6,13 +6,12 @@ # "License"); you may not use this file except in compliance # with the License. You may obtain a copy of the License at # -# https://www.apache.org/licenses/LICENSE-2.0 +# http://www.apache.org/licenses/LICENSE-2.0 Review Comment: Fwiw, the http link redirects to https... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Default value must be manually handled [maven-mvnd]
gnodet commented on code in PR #953:
URL: https://github.com/apache/maven-mvnd/pull/953#discussion_r1575782068
##
client/src/main/java/org/mvndaemon/mvnd/client/DaemonParameters.java:
##
@@ -491,16 +491,22 @@ private static List
readCoreExtensionsDescriptor(Path multiModule
private static List
filterCoreExtensions(List coreExtensions) {
Set exclusions = new HashSet<>();
-String exclusionsString =
-
systemProperty(Environment.MVND_CORE_EXTENSIONS_EXCLUDE).asString();
+String exclusionsString =
systemProperty(Environment.MVND_CORE_EXTENSIONS_EXCLUDE)
+.asOptional()
Review Comment:
I think this should be:
```
String exclusionsString =
systemProperty(Environment.MVND_CORE_EXTENSIONS_EXCLUDE).orDefault().asString();
```
##
client/src/main/java/org/mvndaemon/mvnd/client/DaemonParameters.java:
##
@@ -491,16 +491,22 @@ private static List
readCoreExtensionsDescriptor(Path multiModule
private static List
filterCoreExtensions(List coreExtensions) {
Set exclusions = new HashSet<>();
-String exclusionsString =
-
systemProperty(Environment.MVND_CORE_EXTENSIONS_EXCLUDE).asString();
+String exclusionsString =
systemProperty(Environment.MVND_CORE_EXTENSIONS_EXCLUDE)
+.asOptional()
+.orElse(Environment.MVND_CORE_EXTENSIONS_EXCLUDE.getDefault());
if (exclusionsString != null) {
exclusions.addAll(Arrays.stream(exclusionsString.split(","))
.filter(e -> e != null && !e.trim().isEmpty())
.collect(Collectors.toList()));
}
-return coreExtensions.stream()
-.filter(e -> !exclusions.contains(e.getGroupId() + ":" +
e.getArtifactId()))
-.collect(Collectors.toList());
+if (!exclusions.isEmpty()) {
+LOG.info("Excluded extensions (GA): {}", exclusions);
Review Comment:
This should definitely not be part of the output, and not 4 times.
I'll revert this chunk, or log to debug at most.
##
integration-tests/src/test/projects/maven-conf-ignore-ext/pom.xml:
##
@@ -0,0 +1,27 @@
+
Re: [PR] Bump org.junit.jupiter:junit-jupiter-params from 5.7.0 to 5.10.2 [maven-mvnd]
dependabot[bot] closed pull request #964: Bump org.junit.jupiter:junit-jupiter-params from 5.7.0 to 5.10.2 URL: https://github.com/apache/maven-mvnd/pull/964 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] maven-git-versioning-extension extension is not supported [maven-mvnd]
gzvincen opened a new issue, #968: URL: https://github.com/apache/maven-mvnd/issues/968 maven-git-versioning-extension ```xml me.qoomon maven-git-versioning-extension 9.7.0 ``` I want to disable maven-git-version-extension with the `-Dversion.disable=true` configuration, but when using mvnd, the `-Dversion.disable=true` configuration does not work. But with the mvn command, this configuration works. Does mvnd not yet support Maven-git-version-extension??? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Daemons should not swallow any exception [maven-mvnd]
cstamas opened a new pull request, #969: URL: https://github.com/apache/maven-mvnd/pull/969 The "happy path" should happen without anything thrown, unsure why here runtime ex is rethrown, others swallowed. Fixes #957 Fixes #968 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Daemons should not swallow any exception [maven-mvnd]
cstamas merged PR #969: URL: https://github.com/apache/maven-mvnd/pull/969 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Mvnd should fail is extension cannot be loaded [maven-mvnd]
cstamas closed issue #966: Mvnd should fail is extension cannot be loaded URL: https://github.com/apache/maven-mvnd/issues/966 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Mvnd should fail is extension cannot be loaded [maven-mvnd]
cstamas closed issue #966: Mvnd should fail is extension cannot be loaded URL: https://github.com/apache/maven-mvnd/issues/966 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] mvnd happily fails to load extension and continues on [maven-mvnd]
cstamas closed issue #957: mvnd happily fails to load extension and continues on URL: https://github.com/apache/maven-mvnd/issues/957 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Default value must be manually handled [maven-mvnd]
cstamas commented on code in PR #953: URL: https://github.com/apache/maven-mvnd/pull/953#discussion_r1575828803 ## integration-tests/src/test/projects/maven-conf-ignore-ext-def/pom.xml: ## @@ -0,0 +1,27 @@ +
[jira] [Commented] (MCOMPILER-515) Plugin is NOT incremental, so let it go
[ https://issues.apache.org/jira/browse/MCOMPILER-515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839995#comment-17839995 ] ASF GitHub Bot commented on MCOMPILER-515: -- desruisseaux commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-2071683447 > remove plexus-compiler layer but what about other compilers? `javax.tools.JavaCompiler` is an interface. From a quick search on internet, I think (but did not verified closely) that the Eclipse compiler implements this interface. If there is still a need for the Plexus compiler, we can write a wrapper. The `javax.tools` API is preferred to the Plexus API because it has some JPMS specific methods that I didn't saw in Plexus API. It also has a method telling us whether an option is valid, and a caching mechanism. For languages other than Java, we would need a separated plugin. With JPMS support, multi-releases support, incremental build (even incomplete), etc., this plugin is very Java-specific. > Plugin is NOT incremental, so let it go > --- > > Key: MCOMPILER-515 > URL: https://issues.apache.org/jira/browse/MCOMPILER-515 > Project: Maven Compiler Plugin > Issue Type: Bug >Reporter: Tamas Cservenak >Priority: Major > > The maven-compiler-plugin is NOT incremental, so we should just let it go. > The shared incremental stuff is broken since it's last factual code change > (2012!). > Moreover, the broken incremental stuff just makes us look bad, see the "mvn > clean install" vs "mvn verify" issue: > [https://www.youtube.com/watch?v=XeQj-IbSxJI] > Accept it, that this plugins is not incremental, so it should not make users > believe it is. Moreover, the bugs in this feature exist for too long, that > just cause harm to users and to project as whole. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MCOMPILER-515] This plugin is not "incremental" [maven-compiler-plugin]
desruisseaux commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-2071683447 > remove plexus-compiler layer but what about other compilers? `javax.tools.JavaCompiler` is an interface. From a quick search on internet, I think (but did not verified closely) that the Eclipse compiler implements this interface. If there is still a need for the Plexus compiler, we can write a wrapper. The `javax.tools` API is preferred to the Plexus API because it has some JPMS specific methods that I didn't saw in Plexus API. It also has a method telling us whether an option is valid, and a caching mechanism. For languages other than Java, we would need a separated plugin. With JPMS support, multi-releases support, incremental build (even incomplete), etc., this plugin is very Java-specific. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MCOMPILER-515] This plugin is not "incremental" [maven-compiler-plugin]
rmannibucau commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-2071704037 @desruisseaux +1 to drop plexus but also +1 to keep the current incremental feature support by default - whatever name is given if incremental is not considered accurate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MCOMPILER-515) Plugin is NOT incremental, so let it go
[ https://issues.apache.org/jira/browse/MCOMPILER-515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1783#comment-1783 ] ASF GitHub Bot commented on MCOMPILER-515: -- rmannibucau commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-2071704037 @desruisseaux +1 to drop plexus but also +1 to keep the current incremental feature support by default - whatever name is given if incremental is not considered accurate. > Plugin is NOT incremental, so let it go > --- > > Key: MCOMPILER-515 > URL: https://issues.apache.org/jira/browse/MCOMPILER-515 > Project: Maven Compiler Plugin > Issue Type: Bug >Reporter: Tamas Cservenak >Priority: Major > > The maven-compiler-plugin is NOT incremental, so we should just let it go. > The shared incremental stuff is broken since it's last factual code change > (2012!). > Moreover, the broken incremental stuff just makes us look bad, see the "mvn > clean install" vs "mvn verify" issue: > [https://www.youtube.com/watch?v=XeQj-IbSxJI] > Accept it, that this plugins is not incremental, so it should not make users > believe it is. Moreover, the bugs in this feature exist for too long, that > just cause harm to users and to project as whole. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MNG-8104) proxy settings ignored for dependencies
Patrick Mackinlay created MNG-8104: -- Summary: proxy settings ignored for dependencies Key: MNG-8104 URL: https://issues.apache.org/jira/browse/MNG-8104 Project: Maven Issue Type: Bug Components: Core Affects Versions: 3.9.6 Reporter: Patrick Mackinlay The proxy settings are ignored for dependencies in maven 3.9.6 (working in 3.9.2). On a machine with no direct internet access, if you clear your local repository with a command like: rm -rf ~/.m2/repository/org/apache/maven/maven-core/2.2.1 and then try and download the dependency: mvn dependency:get -DgroupId=org.apache.maven -DartifactId=maven-core -Dversion=2.2.1 It will fail. The proxy settings are ignored. However, it should be noted that for plugins they are used, its only for dependencies that they are ignored. maven version 3.9.2 works, so looks like this was introduced in 3.9.3 probably when the dependency plugin version was upgraded. I used a minimal settings.xml with just one proxy entry. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-8104) proxy settings ignored for dependencies
[ https://issues.apache.org/jira/browse/MNG-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840021#comment-17840021 ] Tamas Cservenak commented on MNG-8104: -- Is this issue about m-dependency-p plugin or Maven core? Like you cannot build as Maven fails to get dependencies when proxy used? > proxy settings ignored for dependencies > --- > > Key: MNG-8104 > URL: https://issues.apache.org/jira/browse/MNG-8104 > Project: Maven > Issue Type: Bug > Components: Core >Affects Versions: 3.9.6 >Reporter: Patrick Mackinlay >Priority: Major > > The proxy settings are ignored for dependencies in maven 3.9.6 (working in > 3.9.2). > On a machine with no direct internet access, if you clear your local > repository with a command like: > rm -rf ~/.m2/repository/org/apache/maven/maven-core/2.2.1 > and then try and download the dependency: > mvn dependency:get -DgroupId=org.apache.maven -DartifactId=maven-core > -Dversion=2.2.1 > > It will fail. The proxy settings are ignored. However, it should be noted > that for plugins they are used, its only for dependencies that they are > ignored. > maven version 3.9.2 works, so looks like this was introduced in 3.9.3 > probably when the dependency plugin version was upgraded. > > I used a minimal settings.xml with just one proxy entry. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-8104) proxy settings ignored for dependencies
[ https://issues.apache.org/jira/browse/MNG-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840025#comment-17840025 ] Patrick Mackinlay commented on MNG-8104: Its about the full maven 3.9.6 release, in a corporate environment (no direct internet) nothing can be built with a fresh local repository. A build will result in all the plugins downloading, but then it fails on the first remote dependency. I dont know what component is actually broken... > proxy settings ignored for dependencies > --- > > Key: MNG-8104 > URL: https://issues.apache.org/jira/browse/MNG-8104 > Project: Maven > Issue Type: Bug > Components: Core >Affects Versions: 3.9.6 >Reporter: Patrick Mackinlay >Priority: Major > > The proxy settings are ignored for dependencies in maven 3.9.6 (working in > 3.9.2). > On a machine with no direct internet access, if you clear your local > repository with a command like: > rm -rf ~/.m2/repository/org/apache/maven/maven-core/2.2.1 > and then try and download the dependency: > mvn dependency:get -DgroupId=org.apache.maven -DartifactId=maven-core > -Dversion=2.2.1 > > It will fail. The proxy settings are ignored. However, it should be noted > that for plugins they are used, its only for dependencies that they are > ignored. > maven version 3.9.2 works, so looks like this was introduced in 3.9.3 > probably when the dependency plugin version was upgraded. > > I used a minimal settings.xml with just one proxy entry. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Default value must be manually handled [maven-mvnd]
cstamas commented on PR #953: URL: https://github.com/apache/maven-mvnd/pull/953#issuecomment-2071802629 Unsure why ubuntu failed, win passed locally also passed w/ same CLI params as CI invoked :thinking: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-8104) proxy settings ignored for dependencies
[ https://issues.apache.org/jira/browse/MNG-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840029#comment-17840029 ] Tamas Cservenak commented on MNG-8104: -- Can you tell us a bit more info? We talk about Maven 3.9.6, but what transport do you use? What kind of proxy you use? Any extension or alike? > proxy settings ignored for dependencies > --- > > Key: MNG-8104 > URL: https://issues.apache.org/jira/browse/MNG-8104 > Project: Maven > Issue Type: Bug > Components: Core >Affects Versions: 3.9.6 >Reporter: Patrick Mackinlay >Priority: Major > > The proxy settings are ignored for dependencies in maven 3.9.6 (working in > 3.9.2). > On a machine with no direct internet access, if you clear your local > repository with a command like: > rm -rf ~/.m2/repository/org/apache/maven/maven-core/2.2.1 > and then try and download the dependency: > mvn dependency:get -DgroupId=org.apache.maven -DartifactId=maven-core > -Dversion=2.2.1 > > It will fail. The proxy settings are ignored. However, it should be noted > that for plugins they are used, its only for dependencies that they are > ignored. > maven version 3.9.2 works, so looks like this was introduced in 3.9.3 > probably when the dependency plugin version was upgraded. > > I used a minimal settings.xml with just one proxy entry. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-8104) proxy settings ignored for dependencies
[ https://issues.apache.org/jira/browse/MNG-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840033#comment-17840033 ] Patrick Mackinlay commented on MNG-8104: Its a vanilla install of maven 3.9.6, with the ~/.m2 directory completely cleared and the settings containing just one http proxy (can't show the details of the corp network, but its just a regular http proxy). Nothing else, no extensions, no other plugins. Note that the mvn dependency:get command is run from an empty directory, so no pom is read (hence no plugins/extension ..). The problem is as simple as the proxy settings are completely ignored for dependencies. > proxy settings ignored for dependencies > --- > > Key: MNG-8104 > URL: https://issues.apache.org/jira/browse/MNG-8104 > Project: Maven > Issue Type: Bug > Components: Core >Affects Versions: 3.9.6 >Reporter: Patrick Mackinlay >Priority: Major > > The proxy settings are ignored for dependencies in maven 3.9.6 (working in > 3.9.2). > On a machine with no direct internet access, if you clear your local > repository with a command like: > rm -rf ~/.m2/repository/org/apache/maven/maven-core/2.2.1 > and then try and download the dependency: > mvn dependency:get -DgroupId=org.apache.maven -DartifactId=maven-core > -Dversion=2.2.1 > > It will fail. The proxy settings are ignored. However, it should be noted > that for plugins they are used, its only for dependencies that they are > ignored. > maven version 3.9.2 works, so looks like this was introduced in 3.9.3 > probably when the dependency plugin version was upgraded. > > I used a minimal settings.xml with just one proxy entry. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-8104) proxy settings ignored for dependencies
[ https://issues.apache.org/jira/browse/MNG-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840046#comment-17840046 ] Tamas Cservenak commented on MNG-8104: -- And what kind of error you have? > proxy settings ignored for dependencies > --- > > Key: MNG-8104 > URL: https://issues.apache.org/jira/browse/MNG-8104 > Project: Maven > Issue Type: Bug > Components: Core >Affects Versions: 3.9.6 >Reporter: Patrick Mackinlay >Priority: Major > > The proxy settings are ignored for dependencies in maven 3.9.6 (working in > 3.9.2). > On a machine with no direct internet access, if you clear your local > repository with a command like: > rm -rf ~/.m2/repository/org/apache/maven/maven-core/2.2.1 > and then try and download the dependency: > mvn dependency:get -DgroupId=org.apache.maven -DartifactId=maven-core > -Dversion=2.2.1 > > It will fail. The proxy settings are ignored. However, it should be noted > that for plugins they are used, its only for dependencies that they are > ignored. > maven version 3.9.2 works, so looks like this was introduced in 3.9.3 > probably when the dependency plugin version was upgraded. > > I used a minimal settings.xml with just one proxy entry. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-8104) proxy settings ignored for dependencies
[ https://issues.apache.org/jira/browse/MNG-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840048#comment-17840048 ] Tamas Cservenak commented on MNG-8104: -- Created a reproducer [https://github.com/cstamas/MNG-8104] It works well locally: all went thru mitmproxy !image-2024-04-23-12-02-38-218.png! > proxy settings ignored for dependencies > --- > > Key: MNG-8104 > URL: https://issues.apache.org/jira/browse/MNG-8104 > Project: Maven > Issue Type: Bug > Components: Core >Affects Versions: 3.9.6 >Reporter: Patrick Mackinlay >Priority: Major > Attachments: image-2024-04-23-12-02-38-218.png > > > The proxy settings are ignored for dependencies in maven 3.9.6 (working in > 3.9.2). > On a machine with no direct internet access, if you clear your local > repository with a command like: > rm -rf ~/.m2/repository/org/apache/maven/maven-core/2.2.1 > and then try and download the dependency: > mvn dependency:get -DgroupId=org.apache.maven -DartifactId=maven-core > -Dversion=2.2.1 > > It will fail. The proxy settings are ignored. However, it should be noted > that for plugins they are used, its only for dependencies that they are > ignored. > maven version 3.9.2 works, so looks like this was introduced in 3.9.3 > probably when the dependency plugin version was upgraded. > > I used a minimal settings.xml with just one proxy entry. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MNG-8104) proxy settings ignored for dependencies
[ https://issues.apache.org/jira/browse/MNG-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-8104: - Attachment: image-2024-04-23-12-02-38-218.png > proxy settings ignored for dependencies > --- > > Key: MNG-8104 > URL: https://issues.apache.org/jira/browse/MNG-8104 > Project: Maven > Issue Type: Bug > Components: Core >Affects Versions: 3.9.6 >Reporter: Patrick Mackinlay >Priority: Major > Attachments: image-2024-04-23-12-02-38-218.png > > > The proxy settings are ignored for dependencies in maven 3.9.6 (working in > 3.9.2). > On a machine with no direct internet access, if you clear your local > repository with a command like: > rm -rf ~/.m2/repository/org/apache/maven/maven-core/2.2.1 > and then try and download the dependency: > mvn dependency:get -DgroupId=org.apache.maven -DartifactId=maven-core > -Dversion=2.2.1 > > It will fail. The proxy settings are ignored. However, it should be noted > that for plugins they are used, its only for dependencies that they are > ignored. > maven version 3.9.2 works, so looks like this was introduced in 3.9.3 > probably when the dependency plugin version was upgraded. > > I used a minimal settings.xml with just one proxy entry. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MNG-8104) proxy settings ignored for dependencies
[ https://issues.apache.org/jira/browse/MNG-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Mackinlay updated MNG-8104: --- Attachment: settings.xml > proxy settings ignored for dependencies > --- > > Key: MNG-8104 > URL: https://issues.apache.org/jira/browse/MNG-8104 > Project: Maven > Issue Type: Bug > Components: Core >Affects Versions: 3.9.6 >Reporter: Patrick Mackinlay >Priority: Major > Attachments: image-2024-04-23-12-02-38-218.png, settings.xml > > > The proxy settings are ignored for dependencies in maven 3.9.6 (working in > 3.9.2). > On a machine with no direct internet access, if you clear your local > repository with a command like: > rm -rf ~/.m2/repository/org/apache/maven/maven-core/2.2.1 > and then try and download the dependency: > mvn dependency:get -DgroupId=org.apache.maven -DartifactId=maven-core > -Dversion=2.2.1 > > It will fail. The proxy settings are ignored. However, it should be noted > that for plugins they are used, its only for dependencies that they are > ignored. > maven version 3.9.2 works, so looks like this was introduced in 3.9.3 > probably when the dependency plugin version was upgraded. > > I used a minimal settings.xml with just one proxy entry. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-8104) proxy settings ignored for dependencies
[
https://issues.apache.org/jira/browse/MNG-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840053#comment-17840053
]
Tamas Cservenak commented on MNG-8104:
--
Ok I think I got it. This issue is not about Maven 3.9.6, is fine.
This issue is about dependency:get that it does not honors proxy. On my
reproducer I did this:
{noformat}
$ mvn -Dmaven.repo.local=local -s settings.xml dependency:get
-DgroupId=org.apache.maven -DartifactId=maven-core -Dversion=2.2.1
-Daether.connector.https.securityMode=insecure {noformat}
and plugin was dowloaded thru proxy, but the maven-core:2.2.1 (and transitive
hull) {*}was not{*}.
> proxy settings ignored for dependencies
> ---
>
> Key: MNG-8104
> URL: https://issues.apache.org/jira/browse/MNG-8104
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 3.9.6
>Reporter: Patrick Mackinlay
>Priority: Major
> Attachments: image-2024-04-23-12-02-38-218.png, settings.xml
>
>
> The proxy settings are ignored for dependencies in maven 3.9.6 (working in
> 3.9.2).
> On a machine with no direct internet access, if you clear your local
> repository with a command like:
> rm -rf ~/.m2/repository/org/apache/maven/maven-core/2.2.1
> and then try and download the dependency:
> mvn dependency:get -DgroupId=org.apache.maven -DartifactId=maven-core
> -Dversion=2.2.1
>
> It will fail. The proxy settings are ignored. However, it should be noted
> that for plugins they are used, its only for dependencies that they are
> ignored.
> maven version 3.9.2 works, so looks like this was introduced in 3.9.3
> probably when the dependency plugin version was upgraded.
>
> I used a minimal settings.xml with just one proxy entry.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MNG-8104) proxy settings ignored for dependencies
[
https://issues.apache.org/jira/browse/MNG-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840056#comment-17840056
]
Tamas Cservenak edited comment on MNG-8104 at 4/23/24 10:35 AM:
As a workaround, you can try
{noformat}
mvn eu.maveniverse.maven.plugins:toolbox:gav-resolve-transitive
-Dgav=org.apache.maven:maven-core:2.2.1 {noformat}
Tested it, and this one obeys HTTP proxy.
was (Author: cstamas):
As a workaround, you can try
{noformat}
eu.maveniverse.maven.plugins:toolbox:gav-resolve-transitive
-Dgav=org.apache.maven:maven-core:2.2.1 {noformat}
Tested it, and this one obeys HTTP proxy.
> proxy settings ignored for dependencies
> ---
>
> Key: MNG-8104
> URL: https://issues.apache.org/jira/browse/MNG-8104
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 3.9.6
>Reporter: Patrick Mackinlay
>Priority: Major
> Attachments: image-2024-04-23-12-02-38-218.png, settings.xml
>
>
> The proxy settings are ignored for dependencies in maven 3.9.6 (working in
> 3.9.2).
> On a machine with no direct internet access, if you clear your local
> repository with a command like:
> rm -rf ~/.m2/repository/org/apache/maven/maven-core/2.2.1
> and then try and download the dependency:
> mvn dependency:get -DgroupId=org.apache.maven -DartifactId=maven-core
> -Dversion=2.2.1
>
> It will fail. The proxy settings are ignored. However, it should be noted
> that for plugins they are used, its only for dependencies that they are
> ignored.
> maven version 3.9.2 works, so looks like this was introduced in 3.9.3
> probably when the dependency plugin version was upgraded.
>
> I used a minimal settings.xml with just one proxy entry.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8104) proxy settings ignored for dependencies
[
https://issues.apache.org/jira/browse/MNG-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840056#comment-17840056
]
Tamas Cservenak commented on MNG-8104:
--
As a workaround, you can try
{noformat}
eu.maveniverse.maven.plugins:toolbox:gav-resolve-transitive
-Dgav=org.apache.maven:maven-core:2.2.1 {noformat}
Tested it, and this one obeys HTTP proxy.
> proxy settings ignored for dependencies
> ---
>
> Key: MNG-8104
> URL: https://issues.apache.org/jira/browse/MNG-8104
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 3.9.6
>Reporter: Patrick Mackinlay
>Priority: Major
> Attachments: image-2024-04-23-12-02-38-218.png, settings.xml
>
>
> The proxy settings are ignored for dependencies in maven 3.9.6 (working in
> 3.9.2).
> On a machine with no direct internet access, if you clear your local
> repository with a command like:
> rm -rf ~/.m2/repository/org/apache/maven/maven-core/2.2.1
> and then try and download the dependency:
> mvn dependency:get -DgroupId=org.apache.maven -DartifactId=maven-core
> -Dversion=2.2.1
>
> It will fail. The proxy settings are ignored. However, it should be noted
> that for plugins they are used, its only for dependencies that they are
> ignored.
> maven version 3.9.2 works, so looks like this was introduced in 3.9.3
> probably when the dependency plugin version was upgraded.
>
> I used a minimal settings.xml with just one proxy entry.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MCOMPILER-515] This plugin is not "incremental" [maven-compiler-plugin]
gnodet commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-2071969652 > > remove plexus-compiler layer but what about other compilers? > > `javax.tools.JavaCompiler` is an interface. From a quick search on internet, I think (but did not verified closely) that the Eclipse compiler implements this interface. If there is still a need for the Plexus compiler, we can write a wrapper. The `javax.tools` API is preferred to the Plexus API because it has some JPMS specific methods that I didn't saw in Plexus API. It also has a method telling us whether an option is valid, and a caching mechanism. > > For languages other than Java, we would need a separated plugin. With JPMS support, multi-releases support, incremental build (even incomplete), etc., this plugin is very Java-specific. The point is that this interface may not be sufficient. Ideally, we'd have a list of output files, that would help with the heuristic. I'm not sure the eclipse compiler is required for full incremental build, I think the requirement for the eclipse compiler is when only exposing direct dependencies for compiled classes (i.e. hide transitive dependencies so that the user is forced to declare those when the code is actually using them) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MCOMPILER-515) Plugin is NOT incremental, so let it go
[ https://issues.apache.org/jira/browse/MCOMPILER-515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840059#comment-17840059 ] ASF GitHub Bot commented on MCOMPILER-515: -- gnodet commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-2071969652 > > remove plexus-compiler layer but what about other compilers? > > `javax.tools.JavaCompiler` is an interface. From a quick search on internet, I think (but did not verified closely) that the Eclipse compiler implements this interface. If there is still a need for the Plexus compiler, we can write a wrapper. The `javax.tools` API is preferred to the Plexus API because it has some JPMS specific methods that I didn't saw in Plexus API. It also has a method telling us whether an option is valid, and a caching mechanism. > > For languages other than Java, we would need a separated plugin. With JPMS support, multi-releases support, incremental build (even incomplete), etc., this plugin is very Java-specific. The point is that this interface may not be sufficient. Ideally, we'd have a list of output files, that would help with the heuristic. I'm not sure the eclipse compiler is required for full incremental build, I think the requirement for the eclipse compiler is when only exposing direct dependencies for compiled classes (i.e. hide transitive dependencies so that the user is forced to declare those when the code is actually using them) > Plugin is NOT incremental, so let it go > --- > > Key: MCOMPILER-515 > URL: https://issues.apache.org/jira/browse/MCOMPILER-515 > Project: Maven Compiler Plugin > Issue Type: Bug >Reporter: Tamas Cservenak >Priority: Major > > The maven-compiler-plugin is NOT incremental, so we should just let it go. > The shared incremental stuff is broken since it's last factual code change > (2012!). > Moreover, the broken incremental stuff just makes us look bad, see the "mvn > clean install" vs "mvn verify" issue: > [https://www.youtube.com/watch?v=XeQj-IbSxJI] > Accept it, that this plugins is not incremental, so it should not make users > believe it is. Moreover, the bugs in this feature exist for too long, that > just cause harm to users and to project as whole. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-8104) proxy settings ignored for dependencies
[ https://issues.apache.org/jira/browse/MNG-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840064#comment-17840064 ] Patrick Mackinlay commented on MNG-8104: Its not just "dependency:get". I used dependency get as an example and to resproduce the problem. All our builds fail with maven 3.9.6 and a cleared repository. > proxy settings ignored for dependencies > --- > > Key: MNG-8104 > URL: https://issues.apache.org/jira/browse/MNG-8104 > Project: Maven > Issue Type: Bug > Components: Core >Affects Versions: 3.9.6 >Reporter: Patrick Mackinlay >Priority: Major > Attachments: image-2024-04-23-12-02-38-218.png, settings.xml > > > The proxy settings are ignored for dependencies in maven 3.9.6 (working in > 3.9.2). > On a machine with no direct internet access, if you clear your local > repository with a command like: > rm -rf ~/.m2/repository/org/apache/maven/maven-core/2.2.1 > and then try and download the dependency: > mvn dependency:get -DgroupId=org.apache.maven -DartifactId=maven-core > -Dversion=2.2.1 > > It will fail. The proxy settings are ignored. However, it should be noted > that for plugins they are used, its only for dependencies that they are > ignored. > maven version 3.9.2 works, so looks like this was introduced in 3.9.3 > probably when the dependency plugin version was upgraded. > > I used a minimal settings.xml with just one proxy entry. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (MNG-8104) proxy settings ignored for dependencies
[ https://issues.apache.org/jira/browse/MNG-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840064#comment-17840064 ] Patrick Mackinlay edited comment on MNG-8104 at 4/23/24 11:04 AM: -- Its not just "dependency:get". I used dependency get as an example and to resproduce the problem. All our builds fail with maven 3.9.6 and a cleared repository. Note that /app/apache-maven-3.9.6/bin/mvn eu.maveniverse.maven.plugins:toolbox:gav-resolve-transitive -Dgav=org.apache.maven:maven-core:2.2.1 works for me. So that must not use the same code path as dependency resolution. The proxy is used in some cases (such as plugin resolution), just not dependency resolution was (Author: JIRAUSER304196): Its not just "dependency:get". I used dependency get as an example and to resproduce the problem. All our builds fail with maven 3.9.6 and a cleared repository. > proxy settings ignored for dependencies > --- > > Key: MNG-8104 > URL: https://issues.apache.org/jira/browse/MNG-8104 > Project: Maven > Issue Type: Bug > Components: Core >Affects Versions: 3.9.6 >Reporter: Patrick Mackinlay >Priority: Major > Attachments: image-2024-04-23-12-02-38-218.png, settings.xml > > > The proxy settings are ignored for dependencies in maven 3.9.6 (working in > 3.9.2). > On a machine with no direct internet access, if you clear your local > repository with a command like: > rm -rf ~/.m2/repository/org/apache/maven/maven-core/2.2.1 > and then try and download the dependency: > mvn dependency:get -DgroupId=org.apache.maven -DartifactId=maven-core > -Dversion=2.2.1 > > It will fail. The proxy settings are ignored. However, it should be noted > that for plugins they are used, its only for dependencies that they are > ignored. > maven version 3.9.2 works, so looks like this was introduced in 3.9.3 > probably when the dependency plugin version was upgraded. > > I used a minimal settings.xml with just one proxy entry. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MCOMPILER-515] This plugin is not "incremental" [maven-compiler-plugin]
desruisseaux commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-2072026430 The use of Eclipse compiler would not be mandated. If no tool chain or `compilerId` parameter is specified, the plugin uses whatever compiler is returned by `ToolProvider.getSystemJavaCompiler()`. The Eclipse compiler was mentioned only for saying that its use should still be possible. The `JavaCompiler` API seems to have some support for giving the output files with `JavaFileManager.getJavaFileForOutput(StandardLocation.CLASS_OUTPUT, , JavaFileObject.Kind.CLASS, )` (I just tested it). However, it does not return the `*.class` files for inner (nested) classes, so some heuristic would still be needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MCOMPILER-515) Plugin is NOT incremental, so let it go
[ https://issues.apache.org/jira/browse/MCOMPILER-515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840067#comment-17840067 ] ASF GitHub Bot commented on MCOMPILER-515: -- desruisseaux commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-2072026430 The use of Eclipse compiler would not be mandated. If no tool chain or `compilerId` parameter is specified, the plugin uses whatever compiler is returned by `ToolProvider.getSystemJavaCompiler()`. The Eclipse compiler was mentioned only for saying that its use should still be possible. The `JavaCompiler` API seems to have some support for giving the output files with `JavaFileManager.getJavaFileForOutput(StandardLocation.CLASS_OUTPUT, , JavaFileObject.Kind.CLASS, )` (I just tested it). However, it does not return the `*.class` files for inner (nested) classes, so some heuristic would still be needed. > Plugin is NOT incremental, so let it go > --- > > Key: MCOMPILER-515 > URL: https://issues.apache.org/jira/browse/MCOMPILER-515 > Project: Maven Compiler Plugin > Issue Type: Bug >Reporter: Tamas Cservenak >Priority: Major > > The maven-compiler-plugin is NOT incremental, so we should just let it go. > The shared incremental stuff is broken since it's last factual code change > (2012!). > Moreover, the broken incremental stuff just makes us look bad, see the "mvn > clean install" vs "mvn verify" issue: > [https://www.youtube.com/watch?v=XeQj-IbSxJI] > Accept it, that this plugins is not incremental, so it should not make users > believe it is. Moreover, the bugs in this feature exist for too long, that > just cause harm to users and to project as whole. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-8104) proxy settings ignored for dependencies
[ https://issues.apache.org/jira/browse/MNG-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840070#comment-17840070 ] Tamas Cservenak commented on MNG-8104: -- When you say "build fails", what error you get? > proxy settings ignored for dependencies > --- > > Key: MNG-8104 > URL: https://issues.apache.org/jira/browse/MNG-8104 > Project: Maven > Issue Type: Bug > Components: Core >Affects Versions: 3.9.6 >Reporter: Patrick Mackinlay >Priority: Major > Attachments: image-2024-04-23-12-02-38-218.png, settings.xml > > > The proxy settings are ignored for dependencies in maven 3.9.6 (working in > 3.9.2). > On a machine with no direct internet access, if you clear your local > repository with a command like: > rm -rf ~/.m2/repository/org/apache/maven/maven-core/2.2.1 > and then try and download the dependency: > mvn dependency:get -DgroupId=org.apache.maven -DartifactId=maven-core > -Dversion=2.2.1 > > It will fail. The proxy settings are ignored. However, it should be noted > that for plugins they are used, its only for dependencies that they are > ignored. > maven version 3.9.2 works, so looks like this was introduced in 3.9.3 > probably when the dependency plugin version was upgraded. > > I used a minimal settings.xml with just one proxy entry. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-8104) proxy settings ignored for dependencies
[ https://issues.apache.org/jira/browse/MNG-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840074#comment-17840074 ] Patrick Mackinlay commented on MNG-8104: an error like [ERROR] Failed to execute goal org.apache.maven.plugins:maven-dependency-plugin:3.6.1:get (default-cli) on project standalone-pom: Couldn't download artifact: org.eclipse.aether.resolution.DependencyResolutionException: Failed to read artifact descriptor for org.apache.maven:maven-core:jar:2.2.1: The following artifacts could not be resolved: org.apache.maven:maven-core:pom:2.2.1 (absent): Could not transfer artifact org.apache.maven:maven-core:pom:2.2.1 from/to central (https://repo.maven.apache.org/maven2): Connect to repo.maven.apache.org:443 [repo.maven.apache.org/146.75.72.215] failed: connect timed out -> [Help 1] [ERROR] > proxy settings ignored for dependencies > --- > > Key: MNG-8104 > URL: https://issues.apache.org/jira/browse/MNG-8104 > Project: Maven > Issue Type: Bug > Components: Core >Affects Versions: 3.9.6 >Reporter: Patrick Mackinlay >Priority: Major > Attachments: image-2024-04-23-12-02-38-218.png, settings.xml > > > The proxy settings are ignored for dependencies in maven 3.9.6 (working in > 3.9.2). > On a machine with no direct internet access, if you clear your local > repository with a command like: > rm -rf ~/.m2/repository/org/apache/maven/maven-core/2.2.1 > and then try and download the dependency: > mvn dependency:get -DgroupId=org.apache.maven -DartifactId=maven-core > -Dversion=2.2.1 > > It will fail. The proxy settings are ignored. However, it should be noted > that for plugins they are used, its only for dependencies that they are > ignored. > maven version 3.9.2 works, so looks like this was introduced in 3.9.3 > probably when the dependency plugin version was upgraded. > > I used a minimal settings.xml with just one proxy entry. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-8104) proxy settings ignored for dependencies
[ https://issues.apache.org/jira/browse/MNG-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840089#comment-17840089 ] Tamas Cservenak commented on MNG-8104: -- Yes, but this is clearly m-dependency-p issue, as the plugin itself was downloaded (via proxy) as it runs... So, this issue is related to m-dependency-p and not Maven. Maven is fine. > proxy settings ignored for dependencies > --- > > Key: MNG-8104 > URL: https://issues.apache.org/jira/browse/MNG-8104 > Project: Maven > Issue Type: Bug > Components: Core >Affects Versions: 3.9.6 >Reporter: Patrick Mackinlay >Priority: Major > Attachments: image-2024-04-23-12-02-38-218.png, settings.xml > > > The proxy settings are ignored for dependencies in maven 3.9.6 (working in > 3.9.2). > On a machine with no direct internet access, if you clear your local > repository with a command like: > rm -rf ~/.m2/repository/org/apache/maven/maven-core/2.2.1 > and then try and download the dependency: > mvn dependency:get -DgroupId=org.apache.maven -DartifactId=maven-core > -Dversion=2.2.1 > > It will fail. The proxy settings are ignored. However, it should be noted > that for plugins they are used, its only for dependencies that they are > ignored. > maven version 3.9.2 works, so looks like this was introduced in 3.9.3 > probably when the dependency plugin version was upgraded. > > I used a minimal settings.xml with just one proxy entry. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-8104) proxy settings ignored for dependencies
[ https://issues.apache.org/jira/browse/MNG-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840090#comment-17840090 ] Tamas Cservenak commented on MNG-8104: -- One more question: you say 3.9.2 "works" and 3.9.6 "does not work". Any info about used m-dependency-p version maybe? So m-dependency-p 3.6.1 works in Maven 3.9.2 but does not work in Maven 3.9.6? > proxy settings ignored for dependencies > --- > > Key: MNG-8104 > URL: https://issues.apache.org/jira/browse/MNG-8104 > Project: Maven > Issue Type: Bug > Components: Core >Affects Versions: 3.9.6 >Reporter: Patrick Mackinlay >Priority: Major > Attachments: image-2024-04-23-12-02-38-218.png, settings.xml > > > The proxy settings are ignored for dependencies in maven 3.9.6 (working in > 3.9.2). > On a machine with no direct internet access, if you clear your local > repository with a command like: > rm -rf ~/.m2/repository/org/apache/maven/maven-core/2.2.1 > and then try and download the dependency: > mvn dependency:get -DgroupId=org.apache.maven -DartifactId=maven-core > -Dversion=2.2.1 > > It will fail. The proxy settings are ignored. However, it should be noted > that for plugins they are used, its only for dependencies that they are > ignored. > maven version 3.9.2 works, so looks like this was introduced in 3.9.3 > probably when the dependency plugin version was upgraded. > > I used a minimal settings.xml with just one proxy entry. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-8082] - Exceptions of proxied SessionScoped components are not working correctly [maven]
gnodet merged PR #1449: URL: https://github.com/apache/maven/pull/1449 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MNG-8082) Exceptions of proxied SessionScoped components are not working correctly
[
https://issues.apache.org/jira/browse/MNG-8082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet reassigned MNG-8082:
Assignee: Guillaume Nodet
> Exceptions of proxied SessionScoped components are not working correctly
>
>
> Key: MNG-8082
> URL: https://issues.apache.org/jira/browse/MNG-8082
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 4.0.0-alpha-13
>Reporter: Jonas Rutishauser
>Assignee: Guillaume Nodet
>Priority: Major
>
> As the {{InvocationTargetException}} is not handled in the proxy a runtime
> exception will be wrapped by an {{InvocationTargetException}} and an
> application exception is additional wrapped by an
> {{UndeclaredThrowableException}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (MNG-8038) Model builder API
[
https://issues.apache.org/jira/browse/MNG-8038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet reassigned MNG-8038:
Assignee: Guillaume Nodet
> Model builder API
> -
>
> Key: MNG-8038
> URL: https://issues.apache.org/jira/browse/MNG-8038
> Project: Maven
> Issue Type: Improvement
> Components: API
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0, 4.0.0-beta-1
>
>
> In some cases, it may be needed to access the _raw_ or the _effective_ model
> of artifacts downloaded from repositories (usually dependencies of the
> current project). The file model can already be read using the
> {{ModelXmlFactory}} but that's quite limited in scope.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8082) Exceptions of proxied SessionScoped components are not working correctly
[
https://issues.apache.org/jira/browse/MNG-8082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840092#comment-17840092
]
ASF GitHub Bot commented on MNG-8082:
-
gnodet merged PR #1449:
URL: https://github.com/apache/maven/pull/1449
> Exceptions of proxied SessionScoped components are not working correctly
>
>
> Key: MNG-8082
> URL: https://issues.apache.org/jira/browse/MNG-8082
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 4.0.0-alpha-13
>Reporter: Jonas Rutishauser
>Priority: Major
>
> As the {{InvocationTargetException}} is not handled in the proxy a runtime
> exception will be wrapped by an {{InvocationTargetException}} and an
> application exception is additional wrapped by an
> {{UndeclaredThrowableException}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MNG-8082) Exceptions of proxied SessionScoped components are not working correctly
[
https://issues.apache.org/jira/browse/MNG-8082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet closed MNG-8082.
Fix Version/s: 4.0.0-alpha-14
Resolution: Fixed
> Exceptions of proxied SessionScoped components are not working correctly
>
>
> Key: MNG-8082
> URL: https://issues.apache.org/jira/browse/MNG-8082
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 4.0.0-alpha-13
>Reporter: Jonas Rutishauser
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-alpha-14
>
>
> As the {{InvocationTargetException}} is not handled in the proxy a runtime
> exception will be wrapped by an {{InvocationTargetException}} and an
> application exception is additional wrapped by an
> {{UndeclaredThrowableException}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MNG-8038) Model builder API
[
https://issues.apache.org/jira/browse/MNG-8038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet closed MNG-8038.
Fix Version/s: (was: 4.0.0)
Resolution: Fixed
> Model builder API
> -
>
> Key: MNG-8038
> URL: https://issues.apache.org/jira/browse/MNG-8038
> Project: Maven
> Issue Type: Improvement
> Components: API
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-beta-1
>
>
> In some cases, it may be needed to access the _raw_ or the _effective_ model
> of artifacts downloaded from repositories (usually dependencies of the
> current project). The file model can already be read using the
> {{ModelXmlFactory}} but that's quite limited in scope.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Fix nasty concurrency issue in AbstractSession [maven]
gnodet merged PR #1479: URL: https://github.com/apache/maven/pull/1479 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Default value must be manually handled [maven-mvnd]
gnodet commented on code in PR #953:
URL: https://github.com/apache/maven-mvnd/pull/953#discussion_r1576253478
##
common/src/main/java/org/mvndaemon/mvnd/common/Environment.java:
##
@@ -224,7 +224,7 @@ public enum Environment {
null,
"io.takari.maven:takari-smart-builder",
OptionType.STRING,
-Flags.OPTIONAL),
+Flags.DISCRIMINATING | Flags.OPTIONAL),
Review Comment:
I don't think this one is discriminating. What is discriminating is the
list of extensions to load which may actually be affected by this property, but
not necessarily. If you add an exclusion which is not supposed to be loaded,
this won't affect the result. In addition, that property is not really
interesting on the daemon side, as the extensions list is loaded by the
client...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (MNG-8105) Upgrade to JLine 3.26.0
Guillaume Nodet created MNG-8105: Summary: Upgrade to JLine 3.26.0 Key: MNG-8105 URL: https://issues.apache.org/jira/browse/MNG-8105 Project: Maven Issue Type: Dependency upgrade Reporter: Guillaume Nodet Assignee: Guillaume Nodet Fix For: 4.0.0-beta-1 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MNG-8025) API incompatibility with m-remote-resources-p
[
https://issues.apache.org/jira/browse/MNG-8025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet updated MNG-8025:
-
Fix Version/s: 4.0.0
> API incompatibility with m-remote-resources-p
> -
>
> Key: MNG-8025
> URL: https://issues.apache.org/jira/browse/MNG-8025
> Project: Maven
> Issue Type: Bug
>Affects Versions: 4.0.0-alpha-12
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0, 4.0.0-beta-1
>
>
> {code:java}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-remote-resources-plugin:3.1.0:process
> (default) on project sshd: Execution default of goal
> org.apache.maven.plugins:maven-remote-resources-plugin:3.1.0:process failed:
> An API incompatibility was encountered while executing
> org.apache.maven.plugins:maven-remote-resources-plugin:3.1.0:process:
> java.lang.NoSuchMethodError: 'void
> org.apache.maven.model.Plugin.unsetInheritanceApplied()'
> [ERROR] -
> [ERROR] realm =
> plugin>org.apache.maven.plugins:maven-remote-resources-plugin:3.1.0
> [ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-8105] Upgrade JLine to 3.26.0 [maven]
gnodet merged PR #1478: URL: https://github.com/apache/maven/pull/1478 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MNG-8105) Upgrade to JLine 3.26.0
[ https://issues.apache.org/jira/browse/MNG-8105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet closed MNG-8105. Fix Version/s: 4.0.0 Resolution: Fixed > Upgrade to JLine 3.26.0 > --- > > Key: MNG-8105 > URL: https://issues.apache.org/jira/browse/MNG-8105 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0, 4.0.0-beta-1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-8105) Upgrade to JLine 3.26.0
[ https://issues.apache.org/jira/browse/MNG-8105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840104#comment-17840104 ] ASF GitHub Bot commented on MNG-8105: - gnodet merged PR #1478: URL: https://github.com/apache/maven/pull/1478 > Upgrade to JLine 3.26.0 > --- > > Key: MNG-8105 > URL: https://issues.apache.org/jira/browse/MNG-8105 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-beta-1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MNG-8025) API incompatibility with m-remote-resources-p
[
https://issues.apache.org/jira/browse/MNG-8025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet closed MNG-8025.
Resolution: Fixed
> API incompatibility with m-remote-resources-p
> -
>
> Key: MNG-8025
> URL: https://issues.apache.org/jira/browse/MNG-8025
> Project: Maven
> Issue Type: Bug
>Affects Versions: 4.0.0-alpha-12
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-beta-1
>
>
> {code:java}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-remote-resources-plugin:3.1.0:process
> (default) on project sshd: Execution default of goal
> org.apache.maven.plugins:maven-remote-resources-plugin:3.1.0:process failed:
> An API incompatibility was encountered while executing
> org.apache.maven.plugins:maven-remote-resources-plugin:3.1.0:process:
> java.lang.NoSuchMethodError: 'void
> org.apache.maven.model.Plugin.unsetInheritanceApplied()'
> [ERROR] -
> [ERROR] realm =
> plugin>org.apache.maven.plugins:maven-remote-resources-plugin:3.1.0
> [ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-8025] Restore compatibility [maven]
gnodet merged PR #1467: URL: https://github.com/apache/maven/pull/1467 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-8025) API incompatibility with m-remote-resources-p
[
https://issues.apache.org/jira/browse/MNG-8025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840103#comment-17840103
]
ASF GitHub Bot commented on MNG-8025:
-
gnodet merged PR #1467:
URL: https://github.com/apache/maven/pull/1467
> API incompatibility with m-remote-resources-p
> -
>
> Key: MNG-8025
> URL: https://issues.apache.org/jira/browse/MNG-8025
> Project: Maven
> Issue Type: Bug
>Affects Versions: 4.0.0-alpha-12
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-beta-1
>
>
> {code:java}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-remote-resources-plugin:3.1.0:process
> (default) on project sshd: Execution default of goal
> org.apache.maven.plugins:maven-remote-resources-plugin:3.1.0:process failed:
> An API incompatibility was encountered while executing
> org.apache.maven.plugins:maven-remote-resources-plugin:3.1.0:process:
> java.lang.NoSuchMethodError: 'void
> org.apache.maven.model.Plugin.unsetInheritanceApplied()'
> [ERROR] -
> [ERROR] realm =
> plugin>org.apache.maven.plugins:maven-remote-resources-plugin:3.1.0
> [ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-8102] Upgrade Parent to 42 [maven]
gnodet merged PR #1476: URL: https://github.com/apache/maven/pull/1476 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-8102) Upgrade Parent to 42
[ https://issues.apache.org/jira/browse/MNG-8102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840105#comment-17840105 ] ASF GitHub Bot commented on MNG-8102: - gnodet merged PR #1476: URL: https://github.com/apache/maven/pull/1476 > Upgrade Parent to 42 > > > Key: MNG-8102 > URL: https://issues.apache.org/jira/browse/MNG-8102 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 4.0.0-beta-1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MNG-8102) Upgrade Parent to 42
[ https://issues.apache.org/jira/browse/MNG-8102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet closed MNG-8102. Fix Version/s: 4.0.0 Resolution: Fixed > Upgrade Parent to 42 > > > Key: MNG-8102 > URL: https://issues.apache.org/jira/browse/MNG-8102 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 4.0.0, 4.0.0-beta-1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [DOXIASITETOOLS-336] Make SiteRenderingContext#siteDirectories editab… [maven-doxia-sitetools]
michael-o commented on PR #150: URL: https://github.com/apache/maven-doxia-sitetools/pull/150#issuecomment-2072373572 I will run our plugins and see how it goes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DOXIASITETOOLS-336) Make SiteRenderingContext#siteDirectories editable aware
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840110#comment-17840110
]
ASF GitHub Bot commented on DOXIASITETOOLS-336:
---
michael-o commented on PR #150:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/150#issuecomment-2072373572
I will run our plugins and see how it goes.
> Make SiteRenderingContext#siteDirectories editable aware
>
>
> Key: DOXIASITETOOLS-336
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-336
> Project: Maven Doxia Sitetools
> Issue Type: Improvement
> Components: Site renderer
>Affects Versions: 2.0.0-M16
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0, 2.0.0-M18
>
>
> Right now you cannot qualify a {{siteDirectory}} whether the content is
> editable or generated. You need to perform multiple calls with distinct
> {{SiteRenderingContexts}}. This causes computational overhead is hacks like
> MSITE-723.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-8103] Upgrade default plugin bindings - fix ITs [maven-integration-testing]
slawekjaranowski merged PR #334: URL: https://github.com/apache/maven-integration-testing/pull/334 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [DOXIASITETOOLS-336] Make SiteRenderingContext#siteDirectories editab… [maven-doxia-sitetools]
michael-o commented on PR #150: URL: https://github.com/apache/maven-doxia-sitetools/pull/150#issuecomment-2072684521 @kwin Just ran: ``` osipovmi@deblndw011x:~/var/Projekte/maven-project-info-reports-plugin (doxia-2.0.0 *=) $ git diff -U0 diff --git a/pom.xml b/pom.xml index 9395b30..69c5416 100644 --- a/pom.xml +++ b/pom.xml @@ -117,2 +117,2 @@ under the License. -2.0.0-M8 -2.0.0-M16 +2.0.0-M10 +2.0.0-M18-SNAPSHOT @@ -122 +122 @@ under the License. -4.0.0-M13 +4.0.0-M14-SNAPSHOT @@ -132 +132 @@ under the License. - 4.0.0-M9 + 4.0.0-M11 @@ -137 +137 @@ under the License. - 4.0.0-M13 + 4.0.0-M14-SNAPSHOT ``` Result: ``` [INFO] --- maven-invoker-plugin:3.6.0:verify (integration-test) @ maven-project-info-reports-plugin --- [INFO] - [INFO] Build Summary: [INFO] Passed: 17, Failed: 0, Errors: 0, Skipped: 0 [INFO] - [INFO] [INFO] --- maven-install-plugin:3.1.1:install (default-install) @ maven-project-info-reports-plugin --- [INFO] Installing /var/osipovmi/Projekte/maven-project-info-reports-plugin/pom.xml to /net/home/osipovmi/.m2/repository/org/apache/maven/plugins/maven-project-info-reports-plugin/4.0.0-M1-SNAPSHOT/maven-project-info-reports-plugin-4.0.0-M1-SNAPSHOT.pom [INFO] Installing /var/osipovmi/Projekte/maven-project-info-reports-plugin/target/maven-project-info-reports-plugin-4.0.0-M1-SNAPSHOT.jar to /net/home/osipovmi/.m2/repository/org/apache/maven/plugins/maven-project-info-reports-plugin/4.0.0-M1-SNAPSHOT/maven-project-info-reports-plugin-4.0.0-M1-SNAPSHOT.jar [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 02:45 min [INFO] Finished at: 2024-04-23T17:21:48+02:00 [INFO] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DOXIASITETOOLS-336) Make SiteRenderingContext#siteDirectories editable aware
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840135#comment-17840135
]
ASF GitHub Bot commented on DOXIASITETOOLS-336:
---
michael-o commented on PR #150:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/150#issuecomment-2072684521
@kwin Just ran:
```
osipovmi@deblndw011x:~/var/Projekte/maven-project-info-reports-plugin
(doxia-2.0.0 *=)
$ git diff -U0
diff --git a/pom.xml b/pom.xml
index 9395b30..69c5416 100644
-
> Make SiteRenderingContext#siteDirectories editable aware
>
>
> Key: DOXIASITETOOLS-336
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-336
> Project: Maven Doxia Sitetools
> Issue Type: Improvement
> Components: Site renderer
>Affects Versions: 2.0.0-M16
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0, 2.0.0-M18
>
>
> Right now you cannot qualify a {{siteDirectory}} whether the content is
> editable or generated. You need to perform multiple calls with distinct
> {{SiteRenderingContexts}}. This causes computational overhead is hacks like
> MSITE-723.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8103) Upgrade default plugin bindings
[
https://issues.apache.org/jira/browse/MNG-8103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840141#comment-17840141
]
ASF GitHub Bot commented on MNG-8103:
-
slawekjaranowski merged PR #1475:
URL: https://github.com/apache/maven/pull/1475
> Upgrade default plugin bindings
> ---
>
> Key: MNG-8103
> URL: https://issues.apache.org/jira/browse/MNG-8103
> Project: Maven
> Issue Type: Dependency upgrade
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 4.0.0-beta-1
>
>
> {noformat}
> 3.9.x
> compiler3.11.0 -> 3.13.0
> surefire3.2.2 -> 3.2.5
> jar 3.3.0 -> 3.4.1
> plugin 3.9.0 -> 3.12.0
> 4.x
> compiler3.11.0 -> 3.13.0
> surefire3.1.2 -> 3.2.5
> jar 3.3.0 -> 3.4.1
> plugin 3.9.0 -> 3.12.0
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-8103] Upgrade default plugin bindings [maven]
slawekjaranowski merged PR #1475: URL: https://github.com/apache/maven/pull/1475 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MNG-8103) Upgrade default plugin bindings
[
https://issues.apache.org/jira/browse/MNG-8103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski closed MNG-8103.
Fix Version/s: 4.0.0
Resolution: Fixed
> Upgrade default plugin bindings
> ---
>
> Key: MNG-8103
> URL: https://issues.apache.org/jira/browse/MNG-8103
> Project: Maven
> Issue Type: Dependency upgrade
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 4.0.0, 4.0.0-beta-1
>
>
> {noformat}
> 3.9.x
> compiler3.11.0 -> 3.13.0
> surefire3.2.2 -> 3.2.5
> jar 3.3.0 -> 3.4.1
> plugin 3.9.0 -> 3.12.0
> 4.x
> compiler3.11.0 -> 3.13.0
> surefire3.1.2 -> 3.2.5
> jar 3.3.0 -> 3.4.1
> plugin 3.9.0 -> 3.12.0
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MCOMPILER-588) JUnit4 test framework to JUnit5 migration
[ https://issues.apache.org/jira/browse/MCOMPILER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840161#comment-17840161 ] Mikhail Deviatov commented on MCOMPILER-588: [~sjaranowski] hi! Could you please provide a feedback? :) > JUnit4 test framework to JUnit5 migration > - > > Key: MCOMPILER-588 > URL: https://issues.apache.org/jira/browse/MCOMPILER-588 > Project: Maven Compiler Plugin > Issue Type: Improvement >Reporter: Mikhail Deviatov >Priority: Major > > We have JUnit5 test framework for a long time. > It have modular architecture, good support in IDE and quite fast. It would be > good to add support JUnit5 to the project. > The problem is that there are 2 library used for testing in project > *maven-plugin-testing-harness* and *org.eclipse.sisu.plexus* and they both > don't have JUnit5 support. > I created a solution that overrides parts of code used derived and my own > implementation. > Please take a look at it > https://github.com/apache/maven-compiler-plugin/pull/233 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [DOXIASITETOOLS-336] Make SiteRenderingContext#siteDirectories editab… [maven-doxia-sitetools]
asfgit closed pull request #150: [DOXIASITETOOLS-336] Make SiteRenderingContext#siteDirectories editab… URL: https://github.com/apache/maven-doxia-sitetools/pull/150 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [DOXIASITETOOLS-336] Make SiteRenderingContext#siteDirectories editab… [maven-doxia-sitetools]
asfgit merged PR #150: URL: https://github.com/apache/maven-doxia-sitetools/pull/150 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DOXIASITETOOLS-336) Make SiteRenderingContext#siteDirectories editable aware
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840194#comment-17840194
]
ASF GitHub Bot commented on DOXIASITETOOLS-336:
---
asfgit merged PR #150:
URL: https://github.com/apache/maven-doxia-sitetools/pull/150
> Make SiteRenderingContext#siteDirectories editable aware
>
>
> Key: DOXIASITETOOLS-336
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-336
> Project: Maven Doxia Sitetools
> Issue Type: Improvement
> Components: Site renderer
>Affects Versions: 2.0.0-M16
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0, 2.0.0-M18
>
>
> Right now you cannot qualify a {{siteDirectory}} whether the content is
> editable or generated. You need to perform multiple calls with distinct
> {{SiteRenderingContexts}}. This causes computational overhead is hacks like
> MSITE-723.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (DOXIASITETOOLS-336) Make SiteRenderingContext#siteDirectories editable aware
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840193#comment-17840193
]
ASF GitHub Bot commented on DOXIASITETOOLS-336:
---
asfgit closed pull request #150: [DOXIASITETOOLS-336] Make
SiteRenderingContext#siteDirectories editab…
URL: https://github.com/apache/maven-doxia-sitetools/pull/150
> Make SiteRenderingContext#siteDirectories editable aware
>
>
> Key: DOXIASITETOOLS-336
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-336
> Project: Maven Doxia Sitetools
> Issue Type: Improvement
> Components: Site renderer
>Affects Versions: 2.0.0-M16
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0, 2.0.0-M18
>
>
> Right now you cannot qualify a {{siteDirectory}} whether the content is
> editable or generated. You need to perform multiple calls with distinct
> {{SiteRenderingContexts}}. This causes computational overhead is hacks like
> MSITE-723.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (DOXIASITETOOLS-336) Make SiteRenderingContext#siteDirectories editable aware
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed DOXIASITETOOLS-336.
-
Resolution: Fixed
Fixed with
[f76b6608ef1084cb125a8ab5e351af8f7022c92a|https://gitbox.apache.org/repos/asf?p=maven-doxia-sitetools.git;a=commit;h=f76b6608ef1084cb125a8ab5e351af8f7022c92a].
> Make SiteRenderingContext#siteDirectories editable aware
>
>
> Key: DOXIASITETOOLS-336
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-336
> Project: Maven Doxia Sitetools
> Issue Type: Improvement
> Components: Site renderer
>Affects Versions: 2.0.0-M16
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0, 2.0.0-M18
>
>
> Right now you cannot qualify a {{siteDirectory}} whether the content is
> editable or generated. You need to perform multiple calls with distinct
> {{SiteRenderingContexts}}. This causes computational overhead is hacks like
> MSITE-723.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (DOXIA-730) Update Asciidoctor Doxia Modules in doxia-site
[ https://issues.apache.org/jira/browse/DOXIA-730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated DOXIA-730: - Fix Version/s: (was: 2.0.0) (was: 2.0.0-M10) > Update Asciidoctor Doxia Modules in doxia-site > -- > > Key: DOXIA-730 > URL: https://issues.apache.org/jira/browse/DOXIA-730 > Project: Maven Doxia > Issue Type: Improvement >Reporter: Abel Salgado Romero >Assignee: Sylwester Lachiewicz >Priority: Major > > In v3.0.0, we renamed the current module and created a new one. > I am working on a PR to update the page > https://maven.apache.org/doxia/references/index.html -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (DOXIA-730) Update Asciidoctor Doxia Modules in doxia-site
[ https://issues.apache.org/jira/browse/DOXIA-730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated DOXIA-730: - Component/s: Documentation > Update Asciidoctor Doxia Modules in doxia-site > -- > > Key: DOXIA-730 > URL: https://issues.apache.org/jira/browse/DOXIA-730 > Project: Maven Doxia > Issue Type: Improvement > Components: Documentation >Reporter: Abel Salgado Romero >Assignee: Sylwester Lachiewicz >Priority: Major > > In v3.0.0, we renamed the current module and created a new one. > I am working on a PR to update the page > https://maven.apache.org/doxia/references/index.html -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MSHARED-1361) Upgrade plugins and components (in ITs) (2)
[ https://issues.apache.org/jira/browse/MSHARED-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MSHARED-1361: Description: * Upgrade to Doxia 2.0.0-M10 * Upgrade to Doxia Sitetools 2.0.0-M18 * Upgrade to Maven Reporting API 4.0.0-M11 * Upgrade to Maven Plugin Tools 3.12.0 was: * Upgrade to Doxia 2.0.0-M11 * Upgrade to Doxia Sitetools 2.0.0-M18 * Upgrade to Maven Reporting API 4.0.0-M11 * Upgrade to Maven Plugin Tools 3.12.0 > Upgrade plugins and components (in ITs) (2) > --- > > Key: MSHARED-1361 > URL: https://issues.apache.org/jira/browse/MSHARED-1361 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-reporting-impl >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: maven-reporting-impl-4.0.0, > maven-reporting-impl-4.0.0-M14 > > > * Upgrade to Doxia 2.0.0-M10 > * Upgrade to Doxia Sitetools 2.0.0-M18 > * Upgrade to Maven Reporting API 4.0.0-M11 > * Upgrade to Maven Plugin Tools 3.12.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MSHARED-1361) Upgrade plugins and components (in ITs) (2)
[ https://issues.apache.org/jira/browse/MSHARED-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MSHARED-1361: Description: * Upgrade to Doxia 2.0.0-M11 * Upgrade to Doxia Sitetools 2.0.0-M18 * Upgrade to Maven Reporting API 4.0.0-M11 * Upgrade to Maven Plugin Tools 3.12.0 was: * Upgrade to Doxia 2.0.0-M10 * Upgrade to Doxia Sitetools 2.0.0-M19 * Upgrade to Maven Reporting API 4.0.0-M11 * Upgrade to Maven Plugin Tools 3.12.0 > Upgrade plugins and components (in ITs) (2) > --- > > Key: MSHARED-1361 > URL: https://issues.apache.org/jira/browse/MSHARED-1361 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-reporting-impl >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: maven-reporting-impl-4.0.0, > maven-reporting-impl-4.0.0-M14 > > > * Upgrade to Doxia 2.0.0-M11 > * Upgrade to Doxia Sitetools 2.0.0-M18 > * Upgrade to Maven Reporting API 4.0.0-M11 > * Upgrade to Maven Plugin Tools 3.12.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MSHADE-471) still timestamp issues with timezones (DST)
[
https://issues.apache.org/jira/browse/MSHADE-471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Herve Boutemy updated MSHADE-471:
-
Summary: still timestamp issues with timezones (DST) (was: still timestamp
issues with timezones (DST?))
> still timestamp issues with timezones (DST)
> ---
>
> Key: MSHADE-471
> URL: https://issues.apache.org/jira/browse/MSHADE-471
> Project: Maven Shade Plugin
> Issue Type: Bug
>Affects Versions: 3.5.2
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 3.5.3
>
>
> MSHADE-420 is incomplete, problems still appear like
> {noformat}1 / 1
> target/reference/eu.maveniverse.maven.plugins/toolbox-0.1.5-cli.jar
> toolbox/target/toolbox-0.1.5-cli.jar
> --- target/reference/eu.maveniverse.maven.plugins/toolbox-0.1.5-cli.jar
> +++ toolbox/target/toolbox-0.1.5-cli.jar
> ├── zipinfo {}
> │ @@ -735,96 +735,96 @@
> │ -rw 2.0 fat 50 bl defN 24-Jan-23 12:20
> META-INF/maven/org.jline/jline/pom.properties
> │ --rw 2.0 fat0 bl defN 23-Oct-12 07:38
> META-INF/native-image/jansi/
> │ --rw 2.0 fat12491 bl defN 23-Oct-12 07:38
> META-INF/native-image/jansi/jni-config.json
> ...
> │ --rw 2.0 fat17329 bl defN 23-Oct-12 07:38
> META-INF/maven/org.fusesource.jansi/jansi/pom.xml
> │ --rw 2.0 fat 60 bl defN 23-Oct-12 07:38
> META-INF/maven/org.fusesource.jansi/jansi/pom.properties
> │ +-rw 2.0 fat0 bl defN 23-Oct-12 06:38
> META-INF/native-image/jansi/
> │ +-rw 2.0 fat12491 bl defN 23-Oct-12 06:38
> META-INF/native-image/jansi/jni-config.json
> ...
> │ +-rw 2.0 fat17329 bl defN 23-Oct-12 06:38
> META-INF/maven/org.fusesource.jansi/jansi/pom.xml
> │ +-rw 2.0 fat 60 bl defN 23-Oct-12 06:38
> META-INF/maven/org.fusesource.jansi/jansi/pom.properties
> │ -rw 2.0 fat0 bl defN 24-Apr-11 20:18
> eu/maveniverse/maven/toolbox/shared/
> {noformat}
> https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/eu/maveniverse/maven/toolbox/README.md
> (fixed since then by using a TZ, but initial UTC shows the issue)
> looks related to DST: probably need to apply what has been done in
> plexus-archiver
> https://github.com/codehaus-plexus/plexus-archiver/commit/b9ea3bf0e4c25c0a5cf1bcbc76e691067003dc36
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MDEP-925] Require Maven 3.6.3 [maven-dependency-plugin]
slawekjaranowski merged PR #381: URL: https://github.com/apache/maven-dependency-plugin/pull/381 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MDEP-925) Require Maven 3.6.3
[ https://issues.apache.org/jira/browse/MDEP-925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MDEP-925. Resolution: Fixed > Require Maven 3.6.3 > --- > > Key: MDEP-925 > URL: https://issues.apache.org/jira/browse/MDEP-925 > Project: Maven Dependency Plugin > Issue Type: Improvement >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.7.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MDEP-925) Require Maven 3.6.3
[ https://issues.apache.org/jira/browse/MDEP-925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840207#comment-17840207 ] ASF GitHub Bot commented on MDEP-925: - slawekjaranowski merged PR #381: URL: https://github.com/apache/maven-dependency-plugin/pull/381 > Require Maven 3.6.3 > --- > > Key: MDEP-925 > URL: https://issues.apache.org/jira/browse/MDEP-925 > Project: Maven Dependency Plugin > Issue Type: Improvement >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.7.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MSHARED-1362) Upgrade plugins and components (in ITs)
[ https://issues.apache.org/jira/browse/MSHARED-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MSHARED-1362: Description: * Upgrade to Maven Site Plugin 4.0.0-M13 * Upgrade to Doxia 2.0.0-M10 * Upgrade to Doxia Sitetools 2.0.0-M18 * Upgrade to Maven Reporting API 4.0.0-M11 * Upgrade to Maven Reporting Impl 4.0.0-M14 * Upgrade to Maven Plugin Tools 3.12.0 was: * Upgrade to Maven Site Plugin 4.0.0-M13 * Upgrade to Doxia 2.0.0-M10 * Upgrade to Doxia Sitetools 2.0.0-M19 * Upgrade to Maven Reporting API 4.0.0-M11 * Upgrade to Maven Reporting Impl 4.0.0-M15 * Upgrade to Maven Plugin Tools 3.12.0 > Upgrade plugins and components (in ITs) > --- > > Key: MSHARED-1362 > URL: https://issues.apache.org/jira/browse/MSHARED-1362 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-reporting-exec >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: maven-reporting-exec-2.0.0, > maven-reporting-exec-2.0.0-M13 > > > * Upgrade to Maven Site Plugin 4.0.0-M13 > * Upgrade to Doxia 2.0.0-M10 > * Upgrade to Doxia Sitetools 2.0.0-M18 > * Upgrade to Maven Reporting API 4.0.0-M11 > * Upgrade to Maven Reporting Impl 4.0.0-M14 > * Upgrade to Maven Plugin Tools 3.12.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MSITE-1003) Upgrade plugins and components (in ITs)
[ https://issues.apache.org/jira/browse/MSITE-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MSITE-1003: -- Description: * Upgrade to Doxia 2.0.0-M10 * Upgrade to Doxia Sitetools 2.0.0-M18 * Upgrade to Maven Reporting API 4.0.0-M11 * Upgrade to Maven Reporting Impl 4.0.0-M14 * Upgrade to Maven Reporting Exec 4.0.0-M13 * Upgrade to Maven Plugin Tools 3.12.0 * Upgrade to Maven JXR Plugin 3.3.2 was: * Upgrade to Doxia 2.0.0-M9 * Upgrade to Doxia Sitetools 2.0.0-M17 * Upgrade to Maven Reporting API 4.0.0-M10 * Upgrade to Maven Reporting Impl 4.0.0-M14 * Upgrade to Maven Reporting Exec 4.0.0-M13 * Upgrade to Maven Plugin Tools 3.11.0 * Upgrade to Maven JXR Plugin 3.3.2 > Upgrade plugins and components (in ITs) > --- > > Key: MSITE-1003 > URL: https://issues.apache.org/jira/browse/MSITE-1003 > Project: Maven Site Plugin > Issue Type: Dependency upgrade >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 4.0.0, 4.0.0-M14 > > > * Upgrade to Doxia 2.0.0-M10 > * Upgrade to Doxia Sitetools 2.0.0-M18 > * Upgrade to Maven Reporting API 4.0.0-M11 > * Upgrade to Maven Reporting Impl 4.0.0-M14 > * Upgrade to Maven Reporting Exec 4.0.0-M13 > * Upgrade to Maven Plugin Tools 3.12.0 > * Upgrade to Maven JXR Plugin 3.3.2 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (DOXIASITETOOLS-321) Upgrade htmlunit 2.x to 3.x
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated DOXIASITETOOLS-321: Summary: Upgrade htmlunit 2.x to 3.x (was: Upgrade htmlunit 2.x to 4.0.0) > Upgrade htmlunit 2.x to 3.x > --- > > Key: DOXIASITETOOLS-321 > URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-321 > Project: Maven Doxia Sitetools > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: 2.0.0, 2.0.0-M17, 2.0.0-M18 > > > https://github.com/advisories/GHSA-3xrr-7m6p-p7xh -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-8081] interpolate available properties during default profile selection (Maven 4.x) [maven]
gnodet commented on PR #1446: URL: https://github.com/apache/maven/pull/1446#issuecomment-2073420753 @mbenson I've rebased the PR and ported it to the new v4 model builder, please have a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MDEP-924) Get rid of maven-artifact-transfer from list-classes goal
[ https://issues.apache.org/jira/browse/MDEP-924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MDEP-924: - Component/s: list-classes > Get rid of maven-artifact-transfer from list-classes goal > - > > Key: MDEP-924 > URL: https://issues.apache.org/jira/browse/MDEP-924 > Project: Maven Dependency Plugin > Issue Type: Improvement > Components: list-classes >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.7.0 > > > We can use Resolver API > Done in simple Mojo as preparing for other. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-8081) default profile activation should consider available system and user properties
[
https://issues.apache.org/jira/browse/MNG-8081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840226#comment-17840226
]
ASF GitHub Bot commented on MNG-8081:
-
gnodet commented on PR #1446:
URL: https://github.com/apache/maven/pull/1446#issuecomment-2073420753
@mbenson I've rebased the PR and ported it to the new v4 model builder,
please have a look
> default profile activation should consider available system and user
> properties
> ---
>
> Key: MNG-8081
> URL: https://issues.apache.org/jira/browse/MNG-8081
> Project: Maven
> Issue Type: Improvement
> Components: Profiles
>Affects Versions: 3.9.6, 4.0.0
>Reporter: Matthew Jason Benson
>Priority: Minor
> Fix For: 3.9.7, 4.0.0, 4.0.0-beta-1
>
>
> As discussed in my open PR, my use case is to compare between environment
> variables e.g.:
> {code:java}
>
>
> env.FOO
> ${env.BAR}
>
> {code}
> Limiting the interpolation to user/system properties means that there is no
> mindf*ck resulting from profile activation order, etc., and keeps this
> request nonthreatening.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MDEP-924) Get rid of maven-artifact-transfer from list-classes goal
[ https://issues.apache.org/jira/browse/MDEP-924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840227#comment-17840227 ] ASF GitHub Bot commented on MDEP-924: - slawekjaranowski opened a new pull request, #382: URL: https://github.com/apache/maven-dependency-plugin/pull/382 https://issues.apache.org/jira/browse/MDEP-924 > Get rid of maven-artifact-transfer from list-classes goal > - > > Key: MDEP-924 > URL: https://issues.apache.org/jira/browse/MDEP-924 > Project: Maven Dependency Plugin > Issue Type: Improvement > Components: list-classes >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.7.0 > > > We can use Resolver API > Done in simple Mojo as preparing for other. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] [MDEP-924] Get rid of maven-artifact-transfer from list-classes goal [maven-dependency-plugin]
slawekjaranowski opened a new pull request, #382: URL: https://github.com/apache/maven-dependency-plugin/pull/382 https://issues.apache.org/jira/browse/MDEP-924 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MBUILDCACHE-88) Tests in failure when ran on jdk21
[
https://issues.apache.org/jira/browse/MBUILDCACHE-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840231#comment-17840231
]
ASF GitHub Bot commented on MBUILDCACHE-88:
---
olamy commented on PR #147:
URL:
https://github.com/apache/maven-build-cache-extension/pull/147#issuecomment-2073450704
Thanks for this.
To be sure this is tested maybe you could add build on jdk21 for both GHA
and Jenkins.
Thanks
> Tests in failure when ran on jdk21
> --
>
> Key: MBUILDCACHE-88
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-88
> Project: Maven Build Cache Extension
> Issue Type: Bug
>Affects Versions: 1.1.0
>Reporter: Kevin Buntrock
>Priority: Minor
> Labels: pull-request-available
>
> The project tests cannot be run on jdk21. Result is :
> {code:java}
> [INFO]
> [INFO] Results:
> [INFO]
> [ERROR] Failures:
> [ERROR] CacheConfigImplTest.testInitializationDisabledInXML:234 expected:
> but was:
> [ERROR]
> CacheConfigImplTest.testRemoteDisableByUserPropertyOverride:330->assertDefaults:137->assertDefaults:201->lambda$testRemoteDisableByUserPropertyOverride$39:330
> expected: but was:
> [ERROR]
> CacheConfigImplTest.testRemoteEnableByUserPropertyOverrideWithURL:313->assertDefaults:137->assertDefaults:201->lambda$testRemoteEnableByUserPropertyOverrideWithURL$38:315
> expected: but was:
> [ERROR]
> CacheConfigImplTest.testRemoteEnableInXMLWithURL:288->assertDefaults:137->assertDefaults:201->lambda$testRemoteEnableInXMLWithURL$36:290
> expected: but was:
> [ERROR]
> CacheConfigImplTest.testRemoteSaveIgnoredWhenRemoteDisabledByUserPropertyOverride:420->assertDefaults:137->assertDefaults:201->lambda$testRemoteSaveIgnoredWhenRemoteDisabledByUserPropertyOverride$48:420
> expected: but was:
> [ERROR]
> CacheConfigImplTest.testRemoveSaveDisabledByUserProperty:381->assertDefaults:137->assertDefaults:201->lambda$testRemoveSaveDisabledByUserProperty$47:383
> expected: but was:
> [ERROR]
> CacheConfigImplTest.testRemoveSaveEnabledByUserProperty:362->assertDefaults:137->assertDefaults:201->lambda$testRemoveSaveEnabledByUserProperty$45:365
> expected: but was:
> [ERROR]
> CacheConfigImplTest.testRemoveSaveEnabledInXML:344->assertDefaults:137->assertDefaults:201->lambda$testRemoveSaveEnabledInXML$42:347
> expected: but was:
> [ERROR]
> CacheConfigImplTest.testRemoveSaveFinalEnabledByUserProperty:436->assertDefaults:137->assertDefaults:201->lambda$testRemoveSaveFinalEnabledByUserProperty$51:439
> expected: but was:
> [ERROR]
> CacheConfigImplTest.testRemoveSaveFinalIgnoredWhenRemoteSaveDisabled:455->assertDefaults:137->assertDefaults:201->lambda$testRemoveSaveFinalIgnoredWhenRemoteSaveDisabled$54:457
> expected: but was:
> [INFO]
> [ERROR] Tests run: 71, Failures: 10, Errors: 0, Skipped: 4
> [INFO]
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
> {code}
> In class "CacheConfigImplTest", a method "deepMockConfigFile" mocks the
> result of the call to java.nio.file.Files.exists (via
> "FileSystemProvider.checkAccess").
> In jdk21 version, "Files.exists" does not rely on the same underlying
> "FileSystemProvider" method, therefore breaking the mocking purpose.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MBUILDCACHE-88] Fix tests execution on jdk > 20 [maven-build-cache-extension]
olamy commented on PR #147: URL: https://github.com/apache/maven-build-cache-extension/pull/147#issuecomment-2073450704 Thanks for this. To be sure this is tested maybe you could add build on jdk21 for both GHA and Jenkins. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MDEP-923) Code cleanups
[
https://issues.apache.org/jira/browse/MDEP-923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840236#comment-17840236
]
ASF GitHub Bot commented on MDEP-923:
-
slawekjaranowski opened a new pull request, #383:
URL: https://github.com/apache/maven-dependency-plugin/pull/383
(no comment)
> Code cleanups
> -
>
> Key: MDEP-923
> URL: https://issues.apache.org/jira/browse/MDEP-923
> Project: Maven Dependency Plugin
> Issue Type: Task
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
>
> * remove usage of deprecated API where possible
> * cleanup pom after update to 42
> * exclude transitive dependencies on org.apache.maven
> * add {{@project.version@}} in ITs
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] Bump mavenVersion from 3.6.3 to 3.9.6 [maven-dependency-plugin]
dependabot[bot] opened a new pull request, #385:
URL: https://github.com/apache/maven-dependency-plugin/pull/385
Bumps `mavenVersion` from 3.6.3 to 3.9.6.
Updates `org.apache.maven:maven-artifact` from 3.6.3 to 3.9.6
Release notes
Sourced from https://github.com/apache/maven/releases";>org.apache.maven:maven-artifact's
releases.
3.9.6
https://maven.apache.org/docs/3.9.6/release-notes.html";>Release
Notes - Maven - Version 3.9.6
Improvement
[https://issues.apache.org/jira/browse/MNG-7939";>MNG-7939]
- Allow to exclude plugins from validation
Dependency upgrade
[https://issues.apache.org/jira/browse/MNG-7913";>MNG-7913]
- Upgrade Sisu version to 0.9.0.M2
[https://issues.apache.org/jira/browse/MNG-7934";>MNG-7934]
- Upgrade Resolver version to 1.9.18
[https://issues.apache.org/jira/browse/MNG-7942";>MNG-7942]
- Upgrade to parent POM 41
[https://issues.apache.org/jira/browse/MNG-7943";>MNG-7943]
- Upgrade default plugin bindings
3.9.5
https://maven.apache.org/docs/3.9.5/release-notes.html";>Release
Notes - Maven - Version 3.9.5
Bug
[https://issues.apache.org/jira/browse/MNG-7851";>MNG-7851]
- Error message when modelVersion is 4.0 is confusing
Improvement
[https://issues.apache.org/jira/browse/MNG-7875";>MNG-7875]
- colorize transfer messages
[https://issues.apache.org/jira/browse/MNG-7895";>MNG-7895]
- Support ${project.basedir} in file profile activation
Task
[https://issues.apache.org/jira/browse/MNG-7856";>MNG-7856]
- Maven Resolver Provider classes ctor change
[https://issues.apache.org/jira/browse/MNG-7870";>MNG-7870]
- Undeprecate wrongly deprecated repository metadata
[https://issues.apache.org/jira/browse/MNG-7872";>MNG-7872]
- Deprecate org.apache.maven.repository.internal.MavenResolverModule
[https://issues.apache.org/jira/browse/MNG-7874";>MNG-7874]
- maven-resolver-provider: introduce NAME constants.
Dependency upgrade
[https://issues.apache.org/jira/browse/MNG-7859";>MNG-7859]
- Update to Resolver 1.9.16
3.9.4
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922&version=12353369";>Release
Notes - Maven - Version 3.9.4
... (truncated)
Commits
https://github.com/apache/maven/commit/bc0240f3c744dd6b6ec2920b3cd08dcc295161ae";>bc0240f
[maven-release-plugin] prepare release maven-3.9.6
https://github.com/apache/maven/commit/e6cc6c53cb979f46e7cf97fc9bab686343500a94";>e6cc6c5
[MNG-7943] Upgrade default plugin bindings
https://github.com/apache/maven/commit/48adee3711705c65918b2c736e88093a052f30f8";>48adee3
[MNG-7934] Update to Resolver 1.9.18 (https://redirect.github.com/apache/maven/issues/1326";>#1326)
https://github.com/apache/maven/commit/da6c7e4bcac34677ad9e7d93f345d9c896866e1b";>da6c7e4
[MNG-7942] Upgrade maven-parent to 41
https://github.com/apache/maven/commit/95fa548e1db672ac7b102ff27585c82ed5ae9ed2";>95fa548
[MNG-7934] Update to Resolver 1.9.17 (https://redirect.github.com/apache/maven/issues/1321";>#1321)
https://github.com/apache/maven/commit/c54baa64b38c09c440a11285d560e47d894b2414";>c54baa6
[MNG-7939] Allow to exclude plugins from validation
https://github.com/apache/maven/commit/ecd59b7158e048a6298b8b52d44fccaba26065ad";>ecd59b7
[MNG-7913] Upgrade Sisu version (https://redirect.github.com/apache/maven/issues/1286";>#1286)
https://github.com/apache/maven/commit/53edd71c989d8f2f2b92ee0b281976772c78b927";>53edd71
Use the same branch name for ITs on Jenkins (https://redirect.github.com/apache/maven/issues/1263";>#1263)
https://github.com/apache/maven/commit/2bc44491af62fef51e17d6ad0172baff82c8d022";>2bc4449
The maven-3.9.x branch should fallback to maven-3.9.x branch of ITs
https://github.com/apache/maven/commit/6e532cd249c0413fb6885ca6dfcc67dce25f703d";>6e532cd
[maven-release-plugin] prepare for next development iteration
Additional commits viewable in https://github.com/apache/maven/compare/maven-3.6.3...maven-3.9.6";>compare
view
Updates `org.apache.maven:maven-plugin-api` from 3.6.3 to 3.9.6
Release notes
Sourced from https://github.com/apache/maven/releases";>org.apache.maven:maven-plugin-api's
releases.
3.9.6
https://maven.apache.org/docs/3.9.6/release-notes.html";>Release
Notes - Maven - Version 3.9.6
Improvement
[https://issues.apache.org/jira/browse/MNG-7939";>MNG-7939]
- Allow to exclude plugins from validation
Dependency upgrade
[https://issues.apache.org/jira/browse/MNG-7913";>MNG-7913]
- Upgrade Sisu version to 0.9.0.M2
[https://issues.apache.org/jira/browse/MNG-7934";>MNG-7934]
- Upgrade Resolver version to 1.9.18
[https://issues.apache.org/jira/browse/MNG-7942";>MNG-7942]
- Upgrade to parent POM 41
[https://issues.apache.org/jira/browse/MNG-7943";>MNG-7943]
- Upgrade default plugin bindings
3.9.5
https://maven.apache.org/docs/3.9.5/release-no
[PR] Bump resolverVersion from 1.4.1 to 1.9.19 [maven-dependency-plugin]
dependabot[bot] opened a new pull request, #384: URL: https://github.com/apache/maven-dependency-plugin/pull/384 Bumps `resolverVersion` from 1.4.1 to 1.9.19. Updates `org.apache.maven.resolver:maven-resolver-api` from 1.4.1 to 1.9.19 Release notes Sourced from https://github.com/apache/maven-resolver/releases";>org.apache.maven.resolver:maven-resolver-api's releases. 1.9.19 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628&version=12353946";>Release Notes - Maven Resolver - Version 1.9.19 What's Changed [1.9.x][MRESOLVER-483] Fix path concatenation logic by https://github.com/cstamas";>@cstamas in https://redirect.github.com/apache/maven-resolver/pull/420";>apache/maven-resolver#420 [1.9.x] [MRESOLVER-522] Improve congested file locks behaviour (https://redirect.github.com/apache/maven-resolver/issues/455";>#455) by https://github.com/cstamas";>@cstamas in https://redirect.github.com/apache/maven-resolver/pull/461";>apache/maven-resolver#461 [1.9.x] Update dependencies by https://github.com/cstamas";>@cstamas in https://redirect.github.com/apache/maven-resolver/pull/462";>apache/maven-resolver#462 [1.9.x] [MRESOLVER-536] Do not belly up if FS does not support setting mtime by https://github.com/cstamas";>@cstamas in https://redirect.github.com/apache/maven-resolver/pull/469";>apache/maven-resolver#469 Full Changelog: https://github.com/apache/maven-resolver/compare/maven-resolver-1.9.18...maven-resolver-1.9.19";>https://github.com/apache/maven-resolver/compare/maven-resolver-1.9.18...maven-resolver-1.9.19 Maven Resolver 1.9.18 ... (truncated) Commits https://github.com/apache/maven-resolver/commit/c1b03574961fd2daa7a678bb3fbf9f0779afee56";>c1b0357 [maven-release-plugin] prepare release maven-resolver-1.9.19 https://github.com/apache/maven-resolver/commit/adadd42d1642f39bafedb2ddd619b044fecb12b0";>adadd42 [MRESOLVER-536] Do not belly up if FS does not support setting mtime (https://redirect.github.com/apache/maven-resolver/issues/469";>#469) https://github.com/apache/maven-resolver/commit/31df8a3dc503895172d277de56b1c4a53da0a27c";>31df8a3 [1.9.x] Update dependencies (https://redirect.github.com/apache/maven-resolver/issues/462";>#462) https://github.com/apache/maven-resolver/commit/b225076e5d5b2fe3f166a4018802ac94b7cc94f7";>b225076 [MRESOLVER-522] Improve congested file locks behaviour (https://redirect.github.com/apache/maven-resolver/issues/455";>#455) (https://redirect.github.com/apache/maven-resolver/issues/461";>#461) https://github.com/apache/maven-resolver/commit/fc969c2570041bb72c3f0141ff4957e8754f365c";>fc969c2 [1.9.x][MRESOLVER-483] Fix path concatenation logic (https://redirect.github.com/apache/maven-resolver/issues/420";>#420) https://github.com/apache/maven-resolver/commit/a3e620d6d2ab6ca58d42d264347341b31da00dde";>a3e620d Use one Maven in CI https://github.com/apache/maven-resolver/commit/fff4bdf92fe10937975623db27a69ced5d1efcd1";>fff4bdf [maven-release-plugin] prepare for next development iteration https://github.com/apache/maven-resolver/commit/dc0cd87c529f7175a09877482dcf009870407136";>dc0cd87 [maven-release-plugin] prepare release maven-resolver-1.9.18 https://github.com/apache/maven-resolver/commit/83a061c0939208c73665842942cbb532cd35ea92";>83a061c [MRESOLVER-437] Resolver should not override given HTTP transport default use... https://github.com/apache/maven-resolver/commit/b60921f30ab76040cd8c9621e1691e25ef419690";>b60921f [MRESOLVER-441] Undo FileUtils changes for non-Windows (https://redirect.github.com/apache/maven-resolver/issues/376";>#376) Additional commits viewable in https://github.com/apache/maven-resolver/compare/maven-resolver-1.4.1...maven-resolver-1.9.19";>compare view Updates `org.apache.maven.resolver:maven-resolver-util` from 1.4.1 to 1.9.19 Release notes Sourced from https://github.com/apache/maven-resolver/releases";>org.apache.maven.resolver:maven-resolver-util's releases. 1.9.19 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628&version=12353946";>Release Notes - Maven Resolver - Version 1.9.19 What's Changed [1.9.x][MRESOLVER-483] Fix path concatenation logic by https://github.com/cstamas";>@cstamas in https://redirect.github.com/apache/maven-resolver/pull/420";>apache/maven-resolver#420 [1.9.x] [MRESOLVER-522] Improve congested file locks behaviour (https://redirect.github.com/apache/maven-resolver/issues/455";>#455) by https://github.com/cstamas";>@cstamas in https://redirect.github.com/apache/maven-resolver/pull/461";>apache/maven-resolver#461 [1.9.x] Update dependencies by https://github.com/cstamas";>@cstamas in https://redirect.github.com/apache/maven-resolver/pull/462";>apache/maven-resolver#462 [1.9.x] [MRESOLVER-536] Do not belly up if FS does not support setting mtime by https
