gnodet commented on code in PR #953:
URL: https://github.com/apache/maven-mvnd/pull/953#discussion_r1576253478
##########
common/src/main/java/org/mvndaemon/mvnd/common/Environment.java:
##########
@@ -224,7 +224,7 @@ public enum Environment {
null,
"io.takari.maven:takari-smart-builder",
OptionType.STRING,
- Flags.OPTIONAL),
+ Flags.DISCRIMINATING | Flags.OPTIONAL),
Review Comment:
I don't think this one is discriminating. What is discriminating is the
list of extensions to load which may actually be affected by this property, but
not necessarily. If you add an exclusion which is not supposed to be loaded,
this won't affect the result. In addition, that property is not really
interesting on the daemon side, as the extensions list is loaded by the
client...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
