[
https://issues.apache.org/jira/browse/MCOMPILER-515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840067#comment-17840067
]
ASF GitHub Bot commented on MCOMPILER-515:
------------------------------------------
desruisseaux commented on PR #160:
URL:
https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-2072026430
The use of Eclipse compiler would not be mandated. If no tool chain or
`compilerId` parameter is specified, the plugin uses whatever compiler is
returned by `ToolProvider.getSystemJavaCompiler()`. The Eclipse compiler was
mentioned only for saying that its use should still be possible.
The `JavaCompiler` API seems to have some support for giving the output
files with `JavaFileManager.getJavaFileForOutput(StandardLocation.CLASS_OUTPUT,
<class name>, JavaFileObject.Kind.CLASS, <source file>)` (I just tested it).
However, it does not return the `*.class` files for inner (nested) classes, so
some heuristic would still be needed.
> Plugin is NOT incremental, so let it go
> ---------------------------------------
>
> Key: MCOMPILER-515
> URL: https://issues.apache.org/jira/browse/MCOMPILER-515
> Project: Maven Compiler Plugin
> Issue Type: Bug
> Reporter: Tamas Cservenak
> Priority: Major
>
> The maven-compiler-plugin is NOT incremental, so we should just let it go.
> The shared incremental stuff is broken since it's last factual code change
> (2012!).
> Moreover, the broken incremental stuff just makes us look bad, see the "mvn
> clean install" vs "mvn verify" issue:
> [https://www.youtube.com/watch?v=XeQj-IbSxJI]
> Accept it, that this plugins is not incremental, so it should not make users
> believe it is. Moreover, the bugs in this feature exist for too long, that
> just cause harm to users and to project as whole.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
