Re: [PR] Fix `addStylesheets` Javadoc [maven-javadoc-plugin]
slawekjaranowski merged PR #261: URL: https://github.com/apache/maven-javadoc-plugin/pull/261 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Maven 3.6.3 as minimum requirements for plugins [maven-site]
slawekjaranowski merged PR #484: URL: https://github.com/apache/maven-site/pull/484 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MPOM-456) Bump surefire/failsafe from 3.2.2 to 3.2.5
Slawomir Jaranowski created MPOM-456: Summary: Bump surefire/failsafe from 3.2.2 to 3.2.5 Key: MPOM-456 URL: https://issues.apache.org/jira/browse/MPOM-456 Project: Maven POMs Issue Type: Dependency upgrade Components: asf Reporter: Slawomir Jaranowski Assignee: Slawomir Jaranowski Fix For: ASF-32 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Bump version.maven-surefire from 3.2.2 to 3.2.5 [maven-apache-parent]
dependabot[bot] commented on PR #186: URL: https://github.com/apache/maven-apache-parent/pull/186#issuecomment-1890391347 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump version.maven-surefire from 3.2.2 to 3.2.5 [maven-apache-parent]
slawekjaranowski closed pull request #186: Bump version.maven-surefire from 3.2.2 to 3.2.5 URL: https://github.com/apache/maven-apache-parent/pull/186 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MPOM-457) Bump org.apache.maven.plugins:maven-compiler-plugin from 3.11.0 to 3.12.1
Slawomir Jaranowski created MPOM-457: Summary: Bump org.apache.maven.plugins:maven-compiler-plugin from 3.11.0 to 3.12.1 Key: MPOM-457 URL: https://issues.apache.org/jira/browse/MPOM-457 Project: Maven POMs Issue Type: Dependency upgrade Components: asf Reporter: Slawomir Jaranowski Assignee: Slawomir Jaranowski Fix For: ASF-32 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MPOM-458) Bump org.apache.maven.plugins:maven-javadoc-plugin from 3.6.2 to 3.6.3
Slawomir Jaranowski created MPOM-458: Summary: Bump org.apache.maven.plugins:maven-javadoc-plugin from 3.6.2 to 3.6.3 Key: MPOM-458 URL: https://issues.apache.org/jira/browse/MPOM-458 Project: Maven POMs Issue Type: Dependency upgrade Components: asf Reporter: Slawomir Jaranowski Assignee: Slawomir Jaranowski Fix For: ASF-32 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPOM-303) Rename property maven.plugin.tools.version to mavenPluginToolsVersion
[
https://issues.apache.org/jira/browse/MPOM-303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806263#comment-17806263
]
Slawomir Jaranowski commented on MPOM-303:
--
We have a new one properties, old is used in a few places
https://github.com/search?q=org%3Aapache%20maven.plugin.tools.version&type=code
> Rename property maven.plugin.tools.version to mavenPluginToolsVersion
> -
>
> Key: MPOM-303
> URL: https://issues.apache.org/jira/browse/MPOM-303
> Project: Maven POMs
> Issue Type: Task
> Components: asf
>Affects Versions: ASF-25
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
>
> {{maven.plugin.tools.version}} was introduced in ASF parent 25 on 2022-02-20
> (one week ago)
> https://github.com/apache/maven-apache-parent/commit/5a878dcdc00439cf03d383096c62e9003b503bfe
> having a property starting with {{maven.}} is not a good practice, because
> this prefix is used by Maven itself:
> https://maven.apache.org/ref/3.8.5/maven-model-builder/#model-interpolation
> and {{plugin.tools}} should be more {{plugin-tools}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MSITE-1000] Introduce parser configuration parameter [maven-site-plugin]
michael-o commented on PR #171: URL: https://github.com/apache/maven-site-plugin/pull/171#issuecomment-1890398224 @kwin Can you adapt to recent changes to the sitetools PR? I'd like to review this today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSITE-1000) Allow parametrisation of Doxia parser per file
[
https://issues.apache.org/jira/browse/MSITE-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806266#comment-17806266
]
ASF GitHub Bot commented on MSITE-1000:
---
michael-o commented on PR #171:
URL:
https://github.com/apache/maven-site-plugin/pull/171#issuecomment-1890398224
@kwin Can you adapt to recent changes to the sitetools PR? I'd like to
review this today.
> Allow parametrisation of Doxia parser per file
> --
>
> Key: MSITE-1000
> URL: https://issues.apache.org/jira/browse/MSITE-1000
> Project: Maven Site Plugin
> Issue Type: New Feature
> Components: doxia integration
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Currently only the attributes used for rendering the site can be
> parameterized in
> https://maven.apache.org/plugins/maven-site-plugin/site-mojo.html#attributes.
> There is no possibility to configure the parser in
> https://github.com/apache/maven-doxia-sitetools/blob/dacaa552c1b8e89eed84db0f43b6b0a72be91d0c/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java#L322
> per document.
> This would be nice in the context of
> https://issues.apache.org/jira/browse/DOXIA-722 where generation of anchors
> should be switched on/off for certain documents. Also generation of comments
> may be desirable for certain documents.
> I propose the following additional plugin goal parameter:
> {code}
>
>
>
> **/apt/**
>
> false
> true
>
>
> {code}
> where {{parserConfigurations}} is an array of a complex type with (include)
> patterns on the source path (String array) and boolean methods for features.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (DOXIA-724) SinkWrappers have wrong order AbstractParser.getWrappedSink(...)
Konrad Windszus created DOXIA-724:
-
Summary: SinkWrappers have wrong order
AbstractParser.getWrappedSink(...)
Key: DOXIA-724
URL: https://issues.apache.org/jira/browse/DOXIA-724
Project: Maven Doxia
Issue Type: Bug
Reporter: Konrad Windszus
Assignee: Konrad Windszus
According to the javadoc the SinkWrapperFactory should be ordered according to
their priority from highest to lowest. However in
{{AbstractParser.getWrappedSink()}} a pipeline is returned which is ordered the
other way around (i.e. lowest priority first).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (DOXIA-724) SinkWrappers have wrong order AbstractParser.getWrappedSink(...)
[
https://issues.apache.org/jira/browse/DOXIA-724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated DOXIA-724:
--
Affects Version/s: 2.0.0-M9
> SinkWrappers have wrong order AbstractParser.getWrappedSink(...)
>
>
> Key: DOXIA-724
> URL: https://issues.apache.org/jira/browse/DOXIA-724
> Project: Maven Doxia
> Issue Type: Bug
>Affects Versions: 2.0.0-M9
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> According to the javadoc the SinkWrapperFactory should be ordered according
> to their priority from highest to lowest. However in
> {{AbstractParser.getWrappedSink()}} a pipeline is returned which is ordered
> the other way around (i.e. lowest priority first).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (DOXIA-724) Sink pipeline returned by AbstractParser.getWrappedSink(...) has wrong order
[
https://issues.apache.org/jira/browse/DOXIA-724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated DOXIA-724:
--
Summary: Sink pipeline returned by AbstractParser.getWrappedSink(...) has
wrong order (was: SinkWrappers have wrong order
AbstractParser.getWrappedSink(...))
> Sink pipeline returned by AbstractParser.getWrappedSink(...) has wrong order
>
>
> Key: DOXIA-724
> URL: https://issues.apache.org/jira/browse/DOXIA-724
> Project: Maven Doxia
> Issue Type: Bug
>Affects Versions: 2.0.0-M9
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> According to the javadoc the SinkWrapperFactory should be ordered according
> to their priority from highest to lowest. However in
> {{AbstractParser.getWrappedSink()}} a pipeline is returned which is ordered
> the other way around (i.e. lowest priority first).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (DOXIA-724) Sink pipeline returned by AbstractParser.getWrappedSink(...) has wrong order
[
https://issues.apache.org/jira/browse/DOXIA-724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806269#comment-17806269
]
Konrad Windszus commented on DOXIA-724:
---
There are multiple bugs in the implementation:
# The order of the {{PriorityQueue.iterator()}} being used in the for each loop
does not guarantee any order
(https://docs.oracle.com/javase/8/docs/api/java/util/PriorityQueue.html#iterator--)
# The method getWrappedSink() orders the pipeline in the reverse order being
returned by 1.
> Sink pipeline returned by AbstractParser.getWrappedSink(...) has wrong order
>
>
> Key: DOXIA-724
> URL: https://issues.apache.org/jira/browse/DOXIA-724
> Project: Maven Doxia
> Issue Type: Bug
>Affects Versions: 2.0.0-M9
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> According to the javadoc the SinkWrapperFactory should be ordered according
> to their priority from highest to lowest. However in
> {{AbstractParser.getWrappedSink()}} a pipeline is returned which is ordered
> the other way around (i.e. lowest priority first).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MNG-8015) Control the type of path where each dependency can be placed
Martin Desruisseaux created MNG-8015:
Summary: Control the type of path where each dependency can be
placed
Key: MNG-8015
URL: https://issues.apache.org/jira/browse/MNG-8015
Project: Maven
Issue Type: Improvement
Components: Core
Affects Versions: 4.0.0-alpha-12
Reporter: Martin Desruisseaux
Make possible to declare where each dependency can be placed: on the
module-path, class-path, agent path, doclet path, taglet path, annotation
processing path, _etc._ The proposed improvement consists in adding a new
{{PATH_TYPES}} property that can be associated to dependencies. The property
value is an array of {{PathType}}, a new enumeration-like class with values
such as {{CLASSES}}, {{MODULES}}, {{DOCLET}}, _etc._ Contrarily to real Java
enumerations, this enumeration-like class is extensible: plugins can add their
own enumeration values. This is required at least for the {{--patch-module}}
option, where a new {{PathType}} enumeration value need to be created for each
module to patch.
Users can control indirectly the {{PathType}} of a dependency by specifying the
dependency type. Note that there is no direct mapping between the dependency
type and where the dependency will be placed, but only an indirect mapping
caused by the fact that using a dependency type implies implicit values of some
properties such as classifier, and (with this proposal) path types:
* {{jar}} implies {{PathType.CLASSES}} and {{PathType.MODULES}}.
* {{modular-jar}} implies {{PathType.MODULES}} only.
* {{classpath-jar}} implies {{PathType.CLASSES}} only.
* _etc._
When a plugin requests the paths of dependencies, the plugin specifies the
types of path it is interested in. For example, a Java compiler plugin can
specify that it is interested in {{PathType.CLASSES}} and {{PathType.MODULES}},
but not {{PathType.DOCLET}}. If a dependency declared that it can be placed on
the class-path or the doclet-path, only the class-path is left after
intersection with plugin's request. This is important for the next step.
If, after all filtering such as above paragraph are applied, a dependency has
only one {{PathType}} left, then there is no ambiguity and we are done.
Combined with above-cited dependency types like {{modular-jar}} or
{{classpath-jar}}, this rule allows users to control where the dependency will
be placed. But if there are two or more {{PathType}} left after filtering, then
a choice needs to be done. For example if there are both {{PathType.CLASSES}}
and {{PathType.MODULES}} (which may happen when {{jar}} is used),
then an heuristic rule similar to Maven 3 can be applied: check if a
{{module-info.class}} file or an {{Automatic-Name}} manifest attribute is
present, and base the decision on that.
This proposal aims to fix MNG-7855.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MNG-8016) Simplify ModelCache
Tamas Cservenak created MNG-8016: Summary: Simplify ModelCache Key: MNG-8016 URL: https://issues.apache.org/jira/browse/MNG-8016 Project: Maven Issue Type: Task Components: Core Reporter: Tamas Cservenak Fix For: 4.0.0, 4.0.0-alpha-13 The ModelCache became very bloated (and classes around like ModelCacheTag etc). The cache should be simplified a LOT. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MNG-8016) Simplify ModelCache
[ https://issues.apache.org/jira/browse/MNG-8016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MNG-8016: Assignee: Guillaume Nodet (was: Tamas Cservenak) > Simplify ModelCache > --- > > Key: MNG-8016 > URL: https://issues.apache.org/jira/browse/MNG-8016 > Project: Maven > Issue Type: Task > Components: Core >Reporter: Tamas Cservenak >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-13 > > > The ModelCache became very bloated (and classes around like ModelCacheTag > etc). The cache should be simplified a LOT. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MNG-8016) Simplify ModelCache
[ https://issues.apache.org/jira/browse/MNG-8016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MNG-8016: Assignee: Tamas Cservenak > Simplify ModelCache > --- > > Key: MNG-8016 > URL: https://issues.apache.org/jira/browse/MNG-8016 > Project: Maven > Issue Type: Task > Components: Core >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-13 > > > The ModelCache became very bloated (and classes around like ModelCacheTag > etc). The cache should be simplified a LOT. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] [MSHARED-1351] Fix console message when origin is baseDir [maven-filtering]
abelsromero opened a new pull request, #93:
URL: https://github.com/apache/maven-filtering/pull/93
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MSHARED) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
:point_right:
https://issues.apache.org/jira/browse/MSHARED-1351?jql=component%20%3D%20maven-filtering%20
- [x] Each commit in the pull request should have a meaningful subject line
and body.
:crossed_fingers:
- [x] Format the pull request title like `[MSHARED-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MSHARED-XXX` with the appropriate JIRA issue. Best
practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
:point_right: `[MSHARED-1351] - Fix console message when origin is baseDir`
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
Checks when the path for the message is empty, then replaces that empty with
"base dir" to avoid an invalid message.
I considered directly comparing paths
```java
String origin;
if (basedir.equals(resourceDirectory)) {
origin = "base directory";
} else {
origin = basedir.relativize(
resourceDirectory.getAbsoluteFile().toPath()) .toString();
}
```
It's more expressive, but that adds extra path processing that are not
necessary if we simply check the relativized result.
PS: run
- [x] Run `mvn clean verify -Prun-its` to make sure basic checks pass. A
more thorough check will
be performed on your pull request automatically.
:ok: The profile does not exist btw, simply run `mvn clean verify` and `mvn
spotless:apply` to fix formatting.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licensed under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MSHARED-1351) Confusing message when copying resources from project's baseDir
[
https://issues.apache.org/jira/browse/MSHARED-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806285#comment-17806285
]
ASF GitHub Bot commented on MSHARED-1351:
-
abelsromero opened a new pull request, #93:
URL: https://github.com/apache/maven-filtering/pull/93
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MSHARED) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
:point_right:
https://issues.apache.org/jira/browse/MSHARED-1351?jql=component%20%3D%20maven-filtering%20
- [x] Each commit in the pull request should have a meaningful subject line
and body.
:crossed_fingers:
- [x] Format the pull request title like `[MSHARED-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MSHARED-XXX` with the appropriate JIRA issue. Best
practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
:point_right: `[MSHARED-1351] - Fix console message when origin is baseDir`
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
Checks when the path for the message is empty, then replaces that empty with
"base dir" to avoid an invalid message.
I considered directly comparing paths
```java
String origin;
if (basedir.equals(resourceDirectory)) {
origin = "base directory";
} else {
origin = basedir.relativize(
resourceDirectory.getAbsoluteFile().toPath()) .toString();
}
```
It's more expressive, but that adds extra path processing that are not
necessary if we simply check the relativized result.
PS: run
- [x] Run `mvn clean verify -Prun-its` to make sure basic checks pass. A
more thorough check will
be performed on your pull request automatically.
:ok: The profile does not exist btw, simply run `mvn clean verify` and `mvn
spotless:apply` to fix formatting.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licensed under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> Confusing message when copying resources from project's baseDir
> ---
>
> Key: MSHARED-1351
> URL: https://issues.apache.org/jira/browse/MSHARED-1351
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-filtering
>Affects Versions: maven-filtering-3.3.1
>Reporter: Abel Salgado Romero
>Priority: Minor
>
> When the project base dir is used as the origin path, the relativize in
> https://github.com/apache/maven-filtering/blob/dce786df4301dab6d51d1eab6bbb79e510327086/src/main/java/org/apache/maven/shared/filtering/DefaultMavenResourcesFiltering.java#L259
> resolves to empty string, resulting in nothing being displayed path after
> "from" in the console:
> ```
> Copying 118 resources from to target/generated-docs
> ```
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-8016] Simplify ModelCache [maven]
cstamas merged PR #1377: URL: https://github.com/apache/maven/pull/1377 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MNG-8016) Simplify ModelCache
[ https://issues.apache.org/jira/browse/MNG-8016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MNG-8016. Resolution: Fixed > Simplify ModelCache > --- > > Key: MNG-8016 > URL: https://issues.apache.org/jira/browse/MNG-8016 > Project: Maven > Issue Type: Task > Components: Core >Reporter: Tamas Cservenak >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-13 > > > The ModelCache became very bloated (and classes around like ModelCacheTag > etc). The cache should be simplified a LOT. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-8016) Simplify ModelCache
[ https://issues.apache.org/jira/browse/MNG-8016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806286#comment-17806286 ] ASF GitHub Bot commented on MNG-8016: - cstamas merged PR #1377: URL: https://github.com/apache/maven/pull/1377 > Simplify ModelCache > --- > > Key: MNG-8016 > URL: https://issues.apache.org/jira/browse/MNG-8016 > Project: Maven > Issue Type: Task > Components: Core >Reporter: Tamas Cservenak >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-13 > > > The ModelCache became very bloated (and classes around like ModelCacheTag > etc). The cache should be simplified a LOT. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Bump org.codehaus.plexus:plexus-archiver from 4.2.5 to 4.8.0 [maven-rar-plugin]
asfgit closed pull request #4: Bump org.codehaus.plexus:plexus-archiver from 4.2.5 to 4.8.0 URL: https://github.com/apache/maven-rar-plugin/pull/4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-archiver from 4.2.5 to 4.8.0 [maven-rar-plugin]
dependabot[bot] commented on PR #4: URL: https://github.com/apache/maven-rar-plugin/pull/4#issuecomment-1890455146 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MSHARED-1351] Fix console message when origin is baseDir [maven-filtering]
abelsromero commented on PR #93: URL: https://github.com/apache/maven-filtering/pull/93#issuecomment-1890456578 Sent signed the CLA to the required address. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSHARED-1351) Confusing message when copying resources from project's baseDir
[ https://issues.apache.org/jira/browse/MSHARED-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806290#comment-17806290 ] ASF GitHub Bot commented on MSHARED-1351: - abelsromero commented on PR #93: URL: https://github.com/apache/maven-filtering/pull/93#issuecomment-1890456578 Sent signed the CLA to the required address. > Confusing message when copying resources from project's baseDir > --- > > Key: MSHARED-1351 > URL: https://issues.apache.org/jira/browse/MSHARED-1351 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-filtering >Affects Versions: maven-filtering-3.3.1 >Reporter: Abel Salgado Romero >Priority: Minor > > When the project base dir is used as the origin path, the relativize in > https://github.com/apache/maven-filtering/blob/dce786df4301dab6d51d1eab6bbb79e510327086/src/main/java/org/apache/maven/shared/filtering/DefaultMavenResourcesFiltering.java#L259 > resolves to empty string, resulting in nothing being displayed path after > "from" in the console: > ``` > Copying 118 resources from to target/generated-docs > ``` -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-8015) Control the type of path where each dependency can be placed
[
https://issues.apache.org/jira/browse/MNG-8015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806292#comment-17806292
]
ASF GitHub Bot commented on MNG-8015:
-
desruisseaux opened a new pull request, #1378:
URL: https://github.com/apache/maven/pull/1378
Introduces new API described in JIRA issue
[MNG-8015](https://issues.apache.org/jira/browse/MNG-8015):
* `PathType` enumeration-like class.
* `JavaPathType` subtype with values such as `MODULES`, `CLASSES`, `DOCLET`,
`TAGLETS`, _etc._
* `PATH_TYPES` dependency property key (as a side-effect, the
`DependencyProperties` API is modified for making it type-safe).
* `DependencyResolverRequest` API for allowing plugins to specify the
`PathType` that the plugin wants.
* `DependencyResolverResult.getDispatchedPath()` method for getting the
result: the paths to dependencies for each path type.
# Open issues
Commit 9c5e9ff412718e4ad29299ea79ba0d158c27d43d (which add implementation)
introduces a dependency to Java 9 or later (the `ModuleDescriptor` class). If
Maven 4 decides to stay executable on Java 8, this part will need to be
refactored in a multi-version JAR file. If Maven 4 decides to require Java 9 or
later, the `source` and `target` options in the `pom.xml` file should be
replaced by a `release` option.
The implementation has no JUnit tests yet, so it may contain bug. We may
want to write JUnit tests before to integrate this pull request. Waiting to see
if a discussion causes a modification of this proposal before to write tests.
> Control the type of path where each dependency can be placed
>
>
> Key: MNG-8015
> URL: https://issues.apache.org/jira/browse/MNG-8015
> Project: Maven
> Issue Type: Improvement
> Components: Core
>Affects Versions: 4.0.0-alpha-12
>Reporter: Martin Desruisseaux
>Priority: Major
>
> Make possible to declare where each dependency can be placed: on the
> module-path, class-path, agent path, doclet path, taglet path, annotation
> processing path, _etc._ The proposed improvement consists in adding a new
> {{PATH_TYPES}} property that can be associated to dependencies. The property
> value is an array of {{PathType}}, a new enumeration-like class with values
> such as {{CLASSES}}, {{MODULES}}, {{DOCLET}}, _etc._ Contrarily to real Java
> enumerations, this enumeration-like class is extensible: plugins can add
> their own enumeration values. This is required at least for the
> {{--patch-module}} option, where a new {{PathType}} enumeration value need to
> be created for each module to patch.
> Users can control indirectly the {{PathType}} of a dependency by specifying
> the dependency type. Note that there is no direct mapping between the
> dependency type and where the dependency will be placed, but only an indirect
> mapping caused by the fact that using a dependency type implies implicit
> values of some properties such as classifier, and (with this proposal) path
> types:
> * {{jar}} implies {{PathType.CLASSES}} and {{PathType.MODULES}}.
> * {{modular-jar}} implies {{PathType.MODULES}} only.
> * {{classpath-jar}} implies {{PathType.CLASSES}} only.
> * _etc._
> When a plugin requests the paths of dependencies, the plugin specifies the
> types of path it is interested in. For example, a Java compiler plugin can
> specify that it is interested in {{PathType.CLASSES}} and
> {{PathType.MODULES}}, but not {{PathType.DOCLET}}. If a dependency declared
> that it can be placed on the class-path or the doclet-path, only the
> class-path is left after intersection with plugin's request. This is
> important for the next step.
> If, after all filtering such as above paragraph are applied, a dependency has
> only one {{PathType}} left, then there is no ambiguity and we are done.
> Combined with above-cited dependency types like {{modular-jar}} or
> {{classpath-jar}}, this rule allows users to control where the dependency
> will be placed. But if there are two or more {{PathType}} left after
> filtering, then a choice needs to be done. For example if there are both
> {{PathType.CLASSES}} and {{PathType.MODULES}} (which may happen when
> {{jar}} is used), then an heuristic rule similar to Maven 3 can
> be applied: check if a {{module-info.class}} file or an {{Automatic-Name}}
> manifest attribute is present, and base the decision on that.
> This proposal aims to fix MNG-7855.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8015) Control the type of path where each dependency can be placed
[
https://issues.apache.org/jira/browse/MNG-8015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806293#comment-17806293
]
Martin Desruisseaux commented on MNG-8015:
--
Pull request: https://github.com/apache/maven/pull/1378
> Control the type of path where each dependency can be placed
>
>
> Key: MNG-8015
> URL: https://issues.apache.org/jira/browse/MNG-8015
> Project: Maven
> Issue Type: Improvement
> Components: Core
>Affects Versions: 4.0.0-alpha-12
>Reporter: Martin Desruisseaux
>Priority: Major
>
> Make possible to declare where each dependency can be placed: on the
> module-path, class-path, agent path, doclet path, taglet path, annotation
> processing path, _etc._ The proposed improvement consists in adding a new
> {{PATH_TYPES}} property that can be associated to dependencies. The property
> value is an array of {{PathType}}, a new enumeration-like class with values
> such as {{CLASSES}}, {{MODULES}}, {{DOCLET}}, _etc._ Contrarily to real Java
> enumerations, this enumeration-like class is extensible: plugins can add
> their own enumeration values. This is required at least for the
> {{--patch-module}} option, where a new {{PathType}} enumeration value need to
> be created for each module to patch.
> Users can control indirectly the {{PathType}} of a dependency by specifying
> the dependency type. Note that there is no direct mapping between the
> dependency type and where the dependency will be placed, but only an indirect
> mapping caused by the fact that using a dependency type implies implicit
> values of some properties such as classifier, and (with this proposal) path
> types:
> * {{jar}} implies {{PathType.CLASSES}} and {{PathType.MODULES}}.
> * {{modular-jar}} implies {{PathType.MODULES}} only.
> * {{classpath-jar}} implies {{PathType.CLASSES}} only.
> * _etc._
> When a plugin requests the paths of dependencies, the plugin specifies the
> types of path it is interested in. For example, a Java compiler plugin can
> specify that it is interested in {{PathType.CLASSES}} and
> {{PathType.MODULES}}, but not {{PathType.DOCLET}}. If a dependency declared
> that it can be placed on the class-path or the doclet-path, only the
> class-path is left after intersection with plugin's request. This is
> important for the next step.
> If, after all filtering such as above paragraph are applied, a dependency has
> only one {{PathType}} left, then there is no ambiguity and we are done.
> Combined with above-cited dependency types like {{modular-jar}} or
> {{classpath-jar}}, this rule allows users to control where the dependency
> will be placed. But if there are two or more {{PathType}} left after
> filtering, then a choice needs to be done. For example if there are both
> {{PathType.CLASSES}} and {{PathType.MODULES}} (which may happen when
> {{jar}} is used), then an heuristic rule similar to Maven 3 can
> be applied: check if a {{module-info.class}} file or an {{Automatic-Name}}
> manifest attribute is present, and base the decision on that.
> This proposal aims to fix MNG-7855.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Bump org.codehaus.plexus:plexus-io from 3.4.1 to 3.4.2 [maven-ear-plugin]
elharo merged PR #105: URL: https://github.com/apache/maven-ear-plugin/pull/105 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven:maven-archiver from 3.6.0 to 3.6.1 [maven-ear-plugin]
elharo merged PR #103: URL: https://github.com/apache/maven-ear-plugin/pull/103 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-interpolation from 1.26 to 1.27 [maven-ear-plugin]
elharo merged PR #104: URL: https://github.com/apache/maven-ear-plugin/pull/104 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven.plugins:maven-plugins from 37 to 41 [maven-ear-plugin]
elharo closed pull request #100: Bump org.apache.maven.plugins:maven-plugins from 37 to 41 URL: https://github.com/apache/maven-ear-plugin/pull/100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven.plugins:maven-plugins from 37 to 41 [maven-ear-plugin]
elharo commented on PR #100: URL: https://github.com/apache/maven-ear-plugin/pull/100#issuecomment-1890461096 This one has to be done manually. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven.plugins:maven-plugins from 37 to 41 [maven-ear-plugin]
dependabot[bot] commented on PR #100: URL: https://github.com/apache/maven-ear-plugin/pull/100#issuecomment-1890461099 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-8015) Control the type of path where each dependency can be placed
[
https://issues.apache.org/jira/browse/MNG-8015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806294#comment-17806294
]
ASF GitHub Bot commented on MNG-8015:
-
desruisseaux commented on PR #1378:
URL: https://github.com/apache/maven/pull/1378#issuecomment-1890462538
CI build has been successful on Java 17 and 21, but failed on Java 11
because of the use of the `{@return ...}` javadoc tag. This is a Javadoc issue
only. Resolution depends on Maven PMC decision about which Java version to
require.
> Control the type of path where each dependency can be placed
>
>
> Key: MNG-8015
> URL: https://issues.apache.org/jira/browse/MNG-8015
> Project: Maven
> Issue Type: Improvement
> Components: Core
>Affects Versions: 4.0.0-alpha-12
>Reporter: Martin Desruisseaux
>Priority: Major
>
> Make possible to declare where each dependency can be placed: on the
> module-path, class-path, agent path, doclet path, taglet path, annotation
> processing path, _etc._ The proposed improvement consists in adding a new
> {{PATH_TYPES}} property that can be associated to dependencies. The property
> value is an array of {{PathType}}, a new enumeration-like class with values
> such as {{CLASSES}}, {{MODULES}}, {{DOCLET}}, _etc._ Contrarily to real Java
> enumerations, this enumeration-like class is extensible: plugins can add
> their own enumeration values. This is required at least for the
> {{--patch-module}} option, where a new {{PathType}} enumeration value need to
> be created for each module to patch.
> Users can control indirectly the {{PathType}} of a dependency by specifying
> the dependency type. Note that there is no direct mapping between the
> dependency type and where the dependency will be placed, but only an indirect
> mapping caused by the fact that using a dependency type implies implicit
> values of some properties such as classifier, and (with this proposal) path
> types:
> * {{jar}} implies {{PathType.CLASSES}} and {{PathType.MODULES}}.
> * {{modular-jar}} implies {{PathType.MODULES}} only.
> * {{classpath-jar}} implies {{PathType.CLASSES}} only.
> * _etc._
> When a plugin requests the paths of dependencies, the plugin specifies the
> types of path it is interested in. For example, a Java compiler plugin can
> specify that it is interested in {{PathType.CLASSES}} and
> {{PathType.MODULES}}, but not {{PathType.DOCLET}}. If a dependency declared
> that it can be placed on the class-path or the doclet-path, only the
> class-path is left after intersection with plugin's request. This is
> important for the next step.
> If, after all filtering such as above paragraph are applied, a dependency has
> only one {{PathType}} left, then there is no ambiguity and we are done.
> Combined with above-cited dependency types like {{modular-jar}} or
> {{classpath-jar}}, this rule allows users to control where the dependency
> will be placed. But if there are two or more {{PathType}} left after
> filtering, then a choice needs to be done. For example if there are both
> {{PathType.CLASSES}} and {{PathType.MODULES}} (which may happen when
> {{jar}} is used), then an heuristic rule similar to Maven 3 can
> be applied: check if a {{module-info.class}} file or an {{Automatic-Name}}
> manifest attribute is present, and base the decision on that.
> This proposal aims to fix MNG-7855.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-8015] Control the type of path where each dependency can be placed [maven]
desruisseaux commented on PR #1378:
URL: https://github.com/apache/maven/pull/1378#issuecomment-1890462538
CI build has been successful on Java 17 and 21, but failed on Java 11
because of the use of the `{@return ...}` javadoc tag. This is a Javadoc issue
only. Resolution depends on Maven PMC decision about which Java version to
require.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (MSHARED-1050) ConcurrentModificationException for maven-filtering
[
https://issues.apache.org/jira/browse/MSHARED-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sylwester Lachiewicz updated MSHARED-1050:
--
Labels: close-pending (was: )
> ConcurrentModificationException for maven-filtering
>
>
> Key: MSHARED-1050
> URL: https://issues.apache.org/jira/browse/MSHARED-1050
> Project: Maven Shared Components
> Issue Type: Bug
> Components: maven-filtering
>Reporter: Ladislav Lencucha
>Priority: Major
> Labels: close-pending
>
> Maven filtering is not thread safe. Adding all properties from request maven
> session results in ConcurrentModificationException.
> Problem is line 117 (and possibly also 118):
> [https://github.com/apache/maven-filtering/blob/maven-filtering-3.1.1/src/main/java/org/apache/maven/shared/filtering/BaseFilter.java]
> *How to simulate:*
> # use maven-resources-plugin which relies on maven-filtering
> ## maven-resources-plugin version 3.1.0
> ## maven-filtering version 3.1.1
> # have multithreaded build (e.g. mvn package -T 48)
> # problem does not happen all the time, but more threads improve the chances
> *JDK*
> Oracle JDK 1.8
> *Possible cause:*
> I have no clue, everything seems to be synchronized. Maybe the collection is
> being added to itself and that is why synchronized set wrapper did not work?
> *Sample stacktrace of failed build:*
> {code:java}
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.maven.plugins:maven-resources-plugin:3.1.0:resources
> (default-resources) on project sample-projct: Execution default-resources of
> goal org.apache.maven.plugins:maven-resources-plugin:3.1.0:resources failed.
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:215)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:156)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:148)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:117)
> at
> org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call
> (MultiThreadedBuilder.java:196)
> at
> org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call
> (MultiThreadedBuilder.java:186)
> at java.util.concurrent.FutureTask.run (FutureTask.java:266)
> at java.util.concurrent.Executors$RunnableAdapter.call
> (Executors.java:511)
> at java.util.concurrent.FutureTask.run (FutureTask.java:266)
> at java.util.concurrent.ThreadPoolExecutor.runWorker
> (ThreadPoolExecutor.java:1149)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run
> (ThreadPoolExecutor.java:624)
> at java.lang.Thread.run (Thread.java:748)
> Caused by: org.apache.maven.plugin.PluginExecutionException: Execution
> default-resources of goal
> org.apache.maven.plugins:maven-resources-plugin:3.1.0:resources failed.
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> (DefaultBuildPluginManager.java:148)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:210)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:156)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:148)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:117)
> at
> org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call
> (MultiThreadedBuilder.java:196)
> at
> org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call
> (MultiThreadedBuilder.java:186)
> at java.util.concurrent.FutureTask.run (FutureTask.java:266)
> at java.util.concurrent.Executors$RunnableAdapter.call
> (Executors.java:511)
> at java.util.concurrent.FutureTask.run (FutureTask.java:266)
> at java.util.concurrent.ThreadPoolExecutor.runWorker
> (ThreadPoolExecutor.java:1149)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run
> (ThreadPoolExecutor.java:624)
> at java.lang.Thread.run (Thread.java:748)
> Caused by: java.util.ConcurrentModificationException
> at java.util.Hashtable$Enumerator.next (Hashtable.java:1387)
> at java.util.Hashtable.putAll (Hashtable.java:523)
> at org.apache.maven.shared.filtering.BaseFilter.getDefaultFilterWrappers
> (BaseFilter.java:117)
> at
> org.apache.maven.shared.filtering.DefaultMavenFileFilter.getDefaultFilterWrappers
> (DefaultMavenFileFilter.java:53)
> at
> org.apache.maven.shared.filtering.DefaultMavenResourcesFiltering.handleDefaultFilterWrappers
> (DefaultMavenResourcesFiltering.java:269)
> at
> org.apache.maven.sh
[PR] [EXPERIMENT] MT model builder [maven]
cstamas opened a new pull request, #1379: URL: https://github.com/apache/maven/pull/1379 Changes: * share "full reactor loaded" per build session, not per recursive call * make possible to disable model cache (mostly for debugging purposes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MSITE-1001) Write article about custom packaging
Matthias Bünger created MSITE-1001:
--
Summary: Write article about custom packaging
Key: MSITE-1001
URL: https://issues.apache.org/jira/browse/MSITE-1001
Project: Maven Site Plugin
Issue Type: Task
Reporter: Matthias Bünger
The [Plugin Developers
Centers|https://maven.apache.org/plugin-developers/index.html] site has an open
TODO
{quote}
TODO: creating and using custom packaging (like maven-archetype packaging)
{quote}
Creating this issue to have the task in the issue tracker
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] Simplify graph [maven]
gnodet opened a new pull request, #1380: URL: https://github.com/apache/maven/pull/1380 Simplify graph. First step before making it concurrent if possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-8015] Control the type of path where each dependency can be placed [maven]
cstamas commented on PR #1378: URL: https://github.com/apache/maven/pull/1378#issuecomment-1890583473 If am not mistaken, [this feature](https://bugs.openjdk.org/browse/JDK-8075778) is available since Java 16? Given master is still Java 8 (build time requirement is same I think)... I'd stick with it. So please use Java 8 conformant javadoc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-8015) Control the type of path where each dependency can be placed
[
https://issues.apache.org/jira/browse/MNG-8015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806311#comment-17806311
]
ASF GitHub Bot commented on MNG-8015:
-
cstamas commented on PR #1378:
URL: https://github.com/apache/maven/pull/1378#issuecomment-1890583473
If am not mistaken, [this
feature](https://bugs.openjdk.org/browse/JDK-8075778) is available since Java
16? Given master is still Java 8 (build time requirement is same I think)...
I'd stick with it.
So please use Java 8 conformant javadoc...
> Control the type of path where each dependency can be placed
>
>
> Key: MNG-8015
> URL: https://issues.apache.org/jira/browse/MNG-8015
> Project: Maven
> Issue Type: Improvement
> Components: Core
>Affects Versions: 4.0.0-alpha-12
>Reporter: Martin Desruisseaux
>Priority: Major
>
> Make possible to declare where each dependency can be placed: on the
> module-path, class-path, agent path, doclet path, taglet path, annotation
> processing path, _etc._ The proposed improvement consists in adding a new
> {{PATH_TYPES}} property that can be associated to dependencies. The property
> value is an array of {{PathType}}, a new enumeration-like class with values
> such as {{CLASSES}}, {{MODULES}}, {{DOCLET}}, _etc._ Contrarily to real Java
> enumerations, this enumeration-like class is extensible: plugins can add
> their own enumeration values. This is required at least for the
> {{--patch-module}} option, where a new {{PathType}} enumeration value need to
> be created for each module to patch.
> Users can control indirectly the {{PathType}} of a dependency by specifying
> the dependency type. Note that there is no direct mapping between the
> dependency type and where the dependency will be placed, but only an indirect
> mapping caused by the fact that using a dependency type implies implicit
> values of some properties such as classifier, and (with this proposal) path
> types:
> * {{jar}} implies {{PathType.CLASSES}} and {{PathType.MODULES}}.
> * {{modular-jar}} implies {{PathType.MODULES}} only.
> * {{classpath-jar}} implies {{PathType.CLASSES}} only.
> * _etc._
> When a plugin requests the paths of dependencies, the plugin specifies the
> types of path it is interested in. For example, a Java compiler plugin can
> specify that it is interested in {{PathType.CLASSES}} and
> {{PathType.MODULES}}, but not {{PathType.DOCLET}}. If a dependency declared
> that it can be placed on the class-path or the doclet-path, only the
> class-path is left after intersection with plugin's request. This is
> important for the next step.
> If, after all filtering such as above paragraph are applied, a dependency has
> only one {{PathType}} left, then there is no ambiguity and we are done.
> Combined with above-cited dependency types like {{modular-jar}} or
> {{classpath-jar}}, this rule allows users to control where the dependency
> will be placed. But if there are two or more {{PathType}} left after
> filtering, then a choice needs to be done. For example if there are both
> {{PathType.CLASSES}} and {{PathType.MODULES}} (which may happen when
> {{jar}} is used), then an heuristic rule similar to Maven 3 can
> be applied: check if a {{module-info.class}} file or an {{Automatic-Name}}
> manifest attribute is present, and base the decision on that.
> This proposal aims to fix MNG-7855.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-8015] Control the type of path where each dependency can be placed [maven]
cstamas commented on code in PR #1378:
URL: https://github.com/apache/maven/pull/1378#discussion_r145152
##
maven-artifact/src/main/java/org/apache/maven/artifact/handler/ArtifactHandler.java:
##
@@ -53,5 +53,16 @@ public interface ArtifactHandler {
String getLanguage();
+/**
+ * Specifies if the artifact contains java classes and can be added to the
classpath.
+ * Whether the artifact should be added to the classpath depends
on other
+ * dependency properties.
+ *
+ * @return if the artifact can be added to the class path
+ *
+ * @deprecated A value of {@code true} does not mean that the dependency
should
+ * be placed on the classpath. See {@code JavaPathType} instead for better
analysis.
+ */
+@Deprecated
Review Comment:
IMHO whole artifactHandler/ArtifactHandlerManager should be deprecated, is
there ONLY to support Maven3 plugins in Maven4, while since
eee037e6763445e7901b84fce4e992ddec17df0d they are really just adapting maven4
stuff.
##
maven-artifact/src/main/java/org/apache/maven/artifact/handler/ArtifactHandler.java:
##
@@ -53,5 +53,16 @@ public interface ArtifactHandler {
String getLanguage();
+/**
+ * Specifies if the artifact contains java classes and can be added to the
classpath.
+ * Whether the artifact should be added to the classpath depends
on other
+ * dependency properties.
+ *
+ * @return if the artifact can be added to the class path
+ *
+ * @deprecated A value of {@code true} does not mean that the dependency
should
+ * be placed on the classpath. See {@code JavaPathType} instead for better
analysis.
+ */
+@Deprecated
Review Comment:
IMHO whole artifactHandler/ArtifactHandlerManager should be deprecated, is
there ONLY to support Maven3 plugins in Maven4, while since
eee037e6763445e7901b84fce4e992ddec17df0d they are really just adapting maven4
stuff. This is of course unrelated to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-8015) Control the type of path where each dependency can be placed
[
https://issues.apache.org/jira/browse/MNG-8015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806312#comment-17806312
]
ASF GitHub Bot commented on MNG-8015:
-
cstamas commented on code in PR #1378:
URL: https://github.com/apache/maven/pull/1378#discussion_r145152
##
maven-artifact/src/main/java/org/apache/maven/artifact/handler/ArtifactHandler.java:
##
@@ -53,5 +53,16 @@ public interface ArtifactHandler {
String getLanguage();
+/**
+ * Specifies if the artifact contains java classes and can be added to the
classpath.
+ * Whether the artifact should be added to the classpath depends
on other
+ * dependency properties.
+ *
+ * @return if the artifact can be added to the class path
+ *
+ * @deprecated A value of {@code true} does not mean that the dependency
should
+ * be placed on the classpath. See {@code JavaPathType} instead for better
analysis.
+ */
+@Deprecated
Review Comment:
IMHO whole artifactHandler/ArtifactHandlerManager should be deprecated, is
there ONLY to support Maven3 plugins in Maven4, while since
eee037e6763445e7901b84fce4e992ddec17df0d they are really just adapting maven4
stuff.
##
maven-artifact/src/main/java/org/apache/maven/artifact/handler/ArtifactHandler.java:
##
@@ -53,5 +53,16 @@ public interface ArtifactHandler {
String getLanguage();
+/**
+ * Specifies if the artifact contains java classes and can be added to the
classpath.
+ * Whether the artifact should be added to the classpath depends
on other
+ * dependency properties.
+ *
+ * @return if the artifact can be added to the class path
+ *
+ * @deprecated A value of {@code true} does not mean that the dependency
should
+ * be placed on the classpath. See {@code JavaPathType} instead for better
analysis.
+ */
+@Deprecated
Review Comment:
IMHO whole artifactHandler/ArtifactHandlerManager should be deprecated, is
there ONLY to support Maven3 plugins in Maven4, while since
eee037e6763445e7901b84fce4e992ddec17df0d they are really just adapting maven4
stuff. This is of course unrelated to this PR.
> Control the type of path where each dependency can be placed
>
>
> Key: MNG-8015
> URL: https://issues.apache.org/jira/browse/MNG-8015
> Project: Maven
> Issue Type: Improvement
> Components: Core
>Affects Versions: 4.0.0-alpha-12
>Reporter: Martin Desruisseaux
>Priority: Major
>
> Make possible to declare where each dependency can be placed: on the
> module-path, class-path, agent path, doclet path, taglet path, annotation
> processing path, _etc._ The proposed improvement consists in adding a new
> {{PATH_TYPES}} property that can be associated to dependencies. The property
> value is an array of {{PathType}}, a new enumeration-like class with values
> such as {{CLASSES}}, {{MODULES}}, {{DOCLET}}, _etc._ Contrarily to real Java
> enumerations, this enumeration-like class is extensible: plugins can add
> their own enumeration values. This is required at least for the
> {{--patch-module}} option, where a new {{PathType}} enumeration value need to
> be created for each module to patch.
> Users can control indirectly the {{PathType}} of a dependency by specifying
> the dependency type. Note that there is no direct mapping between the
> dependency type and where the dependency will be placed, but only an indirect
> mapping caused by the fact that using a dependency type implies implicit
> values of some properties such as classifier, and (with this proposal) path
> types:
> * {{jar}} implies {{PathType.CLASSES}} and {{PathType.MODULES}}.
> * {{modular-jar}} implies {{PathType.MODULES}} only.
> * {{classpath-jar}} implies {{PathType.CLASSES}} only.
> * _etc._
> When a plugin requests the paths of dependencies, the plugin specifies the
> types of path it is interested in. For example, a Java compiler plugin can
> specify that it is interested in {{PathType.CLASSES}} and
> {{PathType.MODULES}}, but not {{PathType.DOCLET}}. If a dependency declared
> that it can be placed on the class-path or the doclet-path, only the
> class-path is left after intersection with plugin's request. This is
> important for the next step.
> If, after all filtering such as above paragraph are applied, a dependency has
> only one {{PathType}} left, then there is no ambiguity and we are done.
> Combined with above-cited dependency types like {{modular-jar}} or
> {{classpath-jar}}, this rule allows users to control where the dependency
> will be placed. But if there are two or more {{PathType}} left after
> filtering, then a choice needs to be done. For example if there are both
> {{PathType.CLASSES}} and {{PathType.MODULES}} (which m
Re: [PR] [MNG-8015] Control the type of path where each dependency can be placed [maven]
cstamas commented on code in PR #1378:
URL: https://github.com/apache/maven/pull/1378#discussion_r1451569428
##
api/maven-api-core/src/main/java/org/apache/maven/api/DependencyProperties.java:
##
@@ -33,27 +36,226 @@
@Immutable
public interface DependencyProperties {
/**
- * Boolean flag telling that dependency contains all of its dependencies.
Value of this key should be parsed with
- * {@link Boolean#parseBoolean(String)} to obtain value.
+ * Keys in the dependency properties map.
+ * Each key can be associated to values of a specific class.
+ *
+ * @paramtype of value associated to the key
+ */
+class Key {
+/**
+ * The keys that are defined in this {@code DependencyProperties} map.
+ * Accesses to this map shall be synchronized on the map.
+ *
+ * @see #intern()
+ */
+private static final Map> INTERNS = new HashMap<>();
+
+/**
+ * Value returned by {@link #name()}.
+ */
+@Nonnull
+private final String name;
+
+/**
+ * Value returned by {@link #valueType()}.
+ */
+@Nonnull
+private final Class valueType;
+
+/**
+ * Creates a new key.
+ *
+ * @param name name of the key
+ * @param valueType type of value associated to the key
+ */
+public Key(@Nonnull final String name, @Nonnull final Class
valueType) {
+this.name = Objects.requireNonNull(name);
+this.valueType = Objects.requireNonNull(valueType);
+}
+
+/**
+ * If a key exists in the {@linkplain #intern() intern pool} for the
given name, returns that key.
+ * Otherwise, if the {@code defaultType} is non-null, creates a key
for values of the specified type.
+ * Otherwise, returns {@code null}.
+ *
+ * @param name name of the key to search or create
+ * @param defaultType value type of the key to create if none exist
for the given name, or {@code null}
+ * @return key found or created, or {@code null} if no key was found
and {@code defaultType} is null
+ *
+ * @see #intern()
+ */
+public static Key forName(String name, Class defaultType) {
+Key key;
+synchronized (INTERNS) {
+key = INTERNS.get(name);
+}
+if (key == null && defaultType != null) {
+key = new Key<>(name, defaultType);
+}
+return key;
+}
+
+/**
+ * {@return the name of the key}.
+ */
+@Nonnull
+public String name() {
+return name;
+}
+
+/**
+ * {@return the type of value associated to the key}.
+ */
+@Nonnull
+public Class valueType() {
+return valueType;
+}
+
+/**
+ * {@return a canonical representation of this key}. A pool of keys,
initially empty, is maintained privately.
+ * When the {@code intern()} method is invoked, if the pool already
contains a key equal to this {@code Key}
+ * as determined by the {@link #equals(Object)} method, then the key
from the pool is returned. Otherwise,
+ * if no key exist in the pool for this key {@linkplain #name() name},
then this {@code Key} object is added
+ * to the pool and {@code this} is returned. Otherwise an {@link
IllegalStateException} is thrown.
+ *
+ * @throws IllegalStateException if a key exists in the pool for the
same name but a different class of values.
+ *
+ * @see String#intern()
+ */
+@SuppressWarnings("unchecked")
+public Key intern() {
+Key previous;
+synchronized (INTERNS) {
+previous = INTERNS.putIfAbsent(name, this);
+}
+if (previous == null) {
+return this;
+}
+if (equals(previous)) {
+return (Key) previous;
+}
+throw new IllegalStateException("Key " + name + " already exists
for a different class of values.");
+}
+
+/**
+ * {@return a string representation of this key}.
+ * By default, this is the name of this key.
+ */
+@Override
+public String toString() {
+return name;
+}
+
+/**
+ * {@return an hash code value for this key}.
+ */
+@Override
+public int hashCode() {
+return 7 + name.hashCode() + 31 * valueType.hashCode();
+}
+
+/**
+ * Compares this key with the given object for equality.
+ * Two keys are considered equal if they have the same name
+ * and are associated to values of the same class.
+ *
+ * @param obj the object to compare with this key
+ * @return whether the g
[jira] [Commented] (MNG-8015) Control the type of path where each dependency can be placed
[
https://issues.apache.org/jira/browse/MNG-8015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806313#comment-17806313
]
ASF GitHub Bot commented on MNG-8015:
-
cstamas commented on code in PR #1378:
URL: https://github.com/apache/maven/pull/1378#discussion_r1451569428
##
api/maven-api-core/src/main/java/org/apache/maven/api/DependencyProperties.java:
##
@@ -33,27 +36,226 @@
@Immutable
public interface DependencyProperties {
/**
- * Boolean flag telling that dependency contains all of its dependencies.
Value of this key should be parsed with
- * {@link Boolean#parseBoolean(String)} to obtain value.
+ * Keys in the dependency properties map.
+ * Each key can be associated to values of a specific class.
+ *
+ * @paramtype of value associated to the key
+ */
+class Key {
+/**
+ * The keys that are defined in this {@code DependencyProperties} map.
+ * Accesses to this map shall be synchronized on the map.
+ *
+ * @see #intern()
+ */
+private static final Map> INTERNS = new HashMap<>();
+
+/**
+ * Value returned by {@link #name()}.
+ */
+@Nonnull
+private final String name;
+
+/**
+ * Value returned by {@link #valueType()}.
+ */
+@Nonnull
+private final Class valueType;
+
+/**
+ * Creates a new key.
+ *
+ * @param name name of the key
+ * @param valueType type of value associated to the key
+ */
+public Key(@Nonnull final String name, @Nonnull final Class
valueType) {
+this.name = Objects.requireNonNull(name);
+this.valueType = Objects.requireNonNull(valueType);
+}
+
+/**
+ * If a key exists in the {@linkplain #intern() intern pool} for the
given name, returns that key.
+ * Otherwise, if the {@code defaultType} is non-null, creates a key
for values of the specified type.
+ * Otherwise, returns {@code null}.
+ *
+ * @param name name of the key to search or create
+ * @param defaultType value type of the key to create if none exist
for the given name, or {@code null}
+ * @return key found or created, or {@code null} if no key was found
and {@code defaultType} is null
+ *
+ * @see #intern()
+ */
+public static Key forName(String name, Class defaultType) {
+Key key;
+synchronized (INTERNS) {
+key = INTERNS.get(name);
+}
+if (key == null && defaultType != null) {
+key = new Key<>(name, defaultType);
+}
+return key;
+}
+
+/**
+ * {@return the name of the key}.
+ */
+@Nonnull
+public String name() {
+return name;
+}
+
+/**
+ * {@return the type of value associated to the key}.
+ */
+@Nonnull
+public Class valueType() {
+return valueType;
+}
+
+/**
+ * {@return a canonical representation of this key}. A pool of keys,
initially empty, is maintained privately.
+ * When the {@code intern()} method is invoked, if the pool already
contains a key equal to this {@code Key}
+ * as determined by the {@link #equals(Object)} method, then the key
from the pool is returned. Otherwise,
+ * if no key exist in the pool for this key {@linkplain #name() name},
then this {@code Key} object is added
+ * to the pool and {@code this} is returned. Otherwise an {@link
IllegalStateException} is thrown.
+ *
+ * @throws IllegalStateException if a key exists in the pool for the
same name but a different class of values.
+ *
+ * @see String#intern()
+ */
+@SuppressWarnings("unchecked")
+public Key intern() {
+Key previous;
+synchronized (INTERNS) {
+previous = INTERNS.putIfAbsent(name, this);
+}
+if (previous == null) {
+return this;
+}
+if (equals(previous)) {
+return (Key) previous;
+}
+throw new IllegalStateException("Key " + name + " already exists
for a different class of values.");
+}
+
+/**
+ * {@return a string representation of this key}.
+ * By default, this is the name of this key.
+ */
+@Override
+public String toString() {
+return name;
+}
+
+/**
+ * {@return an hash code value for this key}.
+ */
+@Override
+public int hashCode() {
+return 7 + name.hashCode() + 31 * valueType.hashCode();
+}
+
+/**
+ * Compares this key with the given objec
Re: [PR] [MNG-8015] Control the type of path where each dependency can be placed [maven]
cstamas commented on code in PR #1378:
URL: https://github.com/apache/maven/pull/1378#discussion_r1451569685
##
api/maven-api-core/src/main/java/org/apache/maven/api/DependencyProperties.java:
##
@@ -33,27 +36,226 @@
@Immutable
public interface DependencyProperties {
/**
- * Boolean flag telling that dependency contains all of its dependencies.
Value of this key should be parsed with
- * {@link Boolean#parseBoolean(String)} to obtain value.
+ * Keys in the dependency properties map.
+ * Each key can be associated to values of a specific class.
+ *
+ * @paramtype of value associated to the key
+ */
+class Key {
+/**
+ * The keys that are defined in this {@code DependencyProperties} map.
+ * Accesses to this map shall be synchronized on the map.
+ *
+ * @see #intern()
+ */
+private static final Map> INTERNS = new HashMap<>();
+
+/**
+ * Value returned by {@link #name()}.
+ */
+@Nonnull
+private final String name;
+
+/**
+ * Value returned by {@link #valueType()}.
+ */
+@Nonnull
+private final Class valueType;
+
+/**
+ * Creates a new key.
+ *
+ * @param name name of the key
+ * @param valueType type of value associated to the key
+ */
+public Key(@Nonnull final String name, @Nonnull final Class
valueType) {
+this.name = Objects.requireNonNull(name);
+this.valueType = Objects.requireNonNull(valueType);
+}
+
+/**
+ * If a key exists in the {@linkplain #intern() intern pool} for the
given name, returns that key.
+ * Otherwise, if the {@code defaultType} is non-null, creates a key
for values of the specified type.
+ * Otherwise, returns {@code null}.
+ *
+ * @param name name of the key to search or create
+ * @param defaultType value type of the key to create if none exist
for the given name, or {@code null}
+ * @return key found or created, or {@code null} if no key was found
and {@code defaultType} is null
+ *
+ * @see #intern()
+ */
+public static Key forName(String name, Class defaultType) {
+Key key;
+synchronized (INTERNS) {
+key = INTERNS.get(name);
+}
+if (key == null && defaultType != null) {
+key = new Key<>(name, defaultType);
+}
+return key;
+}
+
+/**
+ * {@return the name of the key}.
+ */
+@Nonnull
+public String name() {
+return name;
+}
+
+/**
+ * {@return the type of value associated to the key}.
+ */
+@Nonnull
+public Class valueType() {
+return valueType;
+}
+
+/**
+ * {@return a canonical representation of this key}. A pool of keys,
initially empty, is maintained privately.
+ * When the {@code intern()} method is invoked, if the pool already
contains a key equal to this {@code Key}
+ * as determined by the {@link #equals(Object)} method, then the key
from the pool is returned. Otherwise,
+ * if no key exist in the pool for this key {@linkplain #name() name},
then this {@code Key} object is added
+ * to the pool and {@code this} is returned. Otherwise an {@link
IllegalStateException} is thrown.
+ *
+ * @throws IllegalStateException if a key exists in the pool for the
same name but a different class of values.
+ *
+ * @see String#intern()
+ */
+@SuppressWarnings("unchecked")
+public Key intern() {
+Key previous;
+synchronized (INTERNS) {
+previous = INTERNS.putIfAbsent(name, this);
+}
+if (previous == null) {
+return this;
+}
+if (equals(previous)) {
+return (Key) previous;
+}
+throw new IllegalStateException("Key " + name + " already exists
for a different class of values.");
+}
+
+/**
+ * {@return a string representation of this key}.
+ * By default, this is the name of this key.
+ */
+@Override
+public String toString() {
+return name;
+}
+
+/**
+ * {@return an hash code value for this key}.
+ */
+@Override
+public int hashCode() {
+return 7 + name.hashCode() + 31 * valueType.hashCode();
+}
+
+/**
+ * Compares this key with the given object for equality.
+ * Two keys are considered equal if they have the same name
+ * and are associated to values of the same class.
+ *
+ * @param obj the object to compare with this key
+ * @return whether the g
Re: [PR] [MNG-8015] Control the type of path where each dependency can be placed [maven]
cstamas commented on code in PR #1378:
URL: https://github.com/apache/maven/pull/1378#discussion_r1451569685
##
api/maven-api-core/src/main/java/org/apache/maven/api/DependencyProperties.java:
##
@@ -33,27 +36,226 @@
@Immutable
public interface DependencyProperties {
/**
- * Boolean flag telling that dependency contains all of its dependencies.
Value of this key should be parsed with
- * {@link Boolean#parseBoolean(String)} to obtain value.
+ * Keys in the dependency properties map.
+ * Each key can be associated to values of a specific class.
+ *
+ * @paramtype of value associated to the key
+ */
+class Key {
+/**
+ * The keys that are defined in this {@code DependencyProperties} map.
+ * Accesses to this map shall be synchronized on the map.
+ *
+ * @see #intern()
+ */
+private static final Map> INTERNS = new HashMap<>();
+
+/**
+ * Value returned by {@link #name()}.
+ */
+@Nonnull
+private final String name;
+
+/**
+ * Value returned by {@link #valueType()}.
+ */
+@Nonnull
+private final Class valueType;
+
+/**
+ * Creates a new key.
+ *
+ * @param name name of the key
+ * @param valueType type of value associated to the key
+ */
+public Key(@Nonnull final String name, @Nonnull final Class
valueType) {
+this.name = Objects.requireNonNull(name);
+this.valueType = Objects.requireNonNull(valueType);
+}
+
+/**
+ * If a key exists in the {@linkplain #intern() intern pool} for the
given name, returns that key.
+ * Otherwise, if the {@code defaultType} is non-null, creates a key
for values of the specified type.
+ * Otherwise, returns {@code null}.
+ *
+ * @param name name of the key to search or create
+ * @param defaultType value type of the key to create if none exist
for the given name, or {@code null}
+ * @return key found or created, or {@code null} if no key was found
and {@code defaultType} is null
+ *
+ * @see #intern()
+ */
+public static Key forName(String name, Class defaultType) {
+Key key;
+synchronized (INTERNS) {
+key = INTERNS.get(name);
+}
+if (key == null && defaultType != null) {
+key = new Key<>(name, defaultType);
+}
+return key;
+}
+
+/**
+ * {@return the name of the key}.
+ */
+@Nonnull
+public String name() {
+return name;
+}
+
+/**
+ * {@return the type of value associated to the key}.
+ */
+@Nonnull
+public Class valueType() {
+return valueType;
+}
+
+/**
+ * {@return a canonical representation of this key}. A pool of keys,
initially empty, is maintained privately.
+ * When the {@code intern()} method is invoked, if the pool already
contains a key equal to this {@code Key}
+ * as determined by the {@link #equals(Object)} method, then the key
from the pool is returned. Otherwise,
+ * if no key exist in the pool for this key {@linkplain #name() name},
then this {@code Key} object is added
+ * to the pool and {@code this} is returned. Otherwise an {@link
IllegalStateException} is thrown.
+ *
+ * @throws IllegalStateException if a key exists in the pool for the
same name but a different class of values.
+ *
+ * @see String#intern()
+ */
+@SuppressWarnings("unchecked")
+public Key intern() {
+Key previous;
+synchronized (INTERNS) {
+previous = INTERNS.putIfAbsent(name, this);
+}
+if (previous == null) {
+return this;
+}
+if (equals(previous)) {
+return (Key) previous;
+}
+throw new IllegalStateException("Key " + name + " already exists
for a different class of values.");
+}
+
+/**
+ * {@return a string representation of this key}.
+ * By default, this is the name of this key.
+ */
+@Override
+public String toString() {
+return name;
+}
+
+/**
+ * {@return an hash code value for this key}.
+ */
+@Override
+public int hashCode() {
+return 7 + name.hashCode() + 31 * valueType.hashCode();
+}
+
+/**
+ * Compares this key with the given object for equality.
+ * Two keys are considered equal if they have the same name
+ * and are associated to values of the same class.
+ *
+ * @param obj the object to compare with this key
+ * @return whether the g
[jira] [Commented] (MNG-8015) Control the type of path where each dependency can be placed
[
https://issues.apache.org/jira/browse/MNG-8015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806315#comment-17806315
]
ASF GitHub Bot commented on MNG-8015:
-
cstamas commented on code in PR #1378:
URL: https://github.com/apache/maven/pull/1378#discussion_r1451569685
##
api/maven-api-core/src/main/java/org/apache/maven/api/DependencyProperties.java:
##
@@ -33,27 +36,226 @@
@Immutable
public interface DependencyProperties {
/**
- * Boolean flag telling that dependency contains all of its dependencies.
Value of this key should be parsed with
- * {@link Boolean#parseBoolean(String)} to obtain value.
+ * Keys in the dependency properties map.
+ * Each key can be associated to values of a specific class.
+ *
+ * @paramtype of value associated to the key
+ */
+class Key {
+/**
+ * The keys that are defined in this {@code DependencyProperties} map.
+ * Accesses to this map shall be synchronized on the map.
+ *
+ * @see #intern()
+ */
+private static final Map> INTERNS = new HashMap<>();
+
+/**
+ * Value returned by {@link #name()}.
+ */
+@Nonnull
+private final String name;
+
+/**
+ * Value returned by {@link #valueType()}.
+ */
+@Nonnull
+private final Class valueType;
+
+/**
+ * Creates a new key.
+ *
+ * @param name name of the key
+ * @param valueType type of value associated to the key
+ */
+public Key(@Nonnull final String name, @Nonnull final Class
valueType) {
+this.name = Objects.requireNonNull(name);
+this.valueType = Objects.requireNonNull(valueType);
+}
+
+/**
+ * If a key exists in the {@linkplain #intern() intern pool} for the
given name, returns that key.
+ * Otherwise, if the {@code defaultType} is non-null, creates a key
for values of the specified type.
+ * Otherwise, returns {@code null}.
+ *
+ * @param name name of the key to search or create
+ * @param defaultType value type of the key to create if none exist
for the given name, or {@code null}
+ * @return key found or created, or {@code null} if no key was found
and {@code defaultType} is null
+ *
+ * @see #intern()
+ */
+public static Key forName(String name, Class defaultType) {
+Key key;
+synchronized (INTERNS) {
+key = INTERNS.get(name);
+}
+if (key == null && defaultType != null) {
+key = new Key<>(name, defaultType);
+}
+return key;
+}
+
+/**
+ * {@return the name of the key}.
+ */
+@Nonnull
+public String name() {
+return name;
+}
+
+/**
+ * {@return the type of value associated to the key}.
+ */
+@Nonnull
+public Class valueType() {
+return valueType;
+}
+
+/**
+ * {@return a canonical representation of this key}. A pool of keys,
initially empty, is maintained privately.
+ * When the {@code intern()} method is invoked, if the pool already
contains a key equal to this {@code Key}
+ * as determined by the {@link #equals(Object)} method, then the key
from the pool is returned. Otherwise,
+ * if no key exist in the pool for this key {@linkplain #name() name},
then this {@code Key} object is added
+ * to the pool and {@code this} is returned. Otherwise an {@link
IllegalStateException} is thrown.
+ *
+ * @throws IllegalStateException if a key exists in the pool for the
same name but a different class of values.
+ *
+ * @see String#intern()
+ */
+@SuppressWarnings("unchecked")
+public Key intern() {
+Key previous;
+synchronized (INTERNS) {
+previous = INTERNS.putIfAbsent(name, this);
+}
+if (previous == null) {
+return this;
+}
+if (equals(previous)) {
+return (Key) previous;
+}
+throw new IllegalStateException("Key " + name + " already exists
for a different class of values.");
+}
+
+/**
+ * {@return a string representation of this key}.
+ * By default, this is the name of this key.
+ */
+@Override
+public String toString() {
+return name;
+}
+
+/**
+ * {@return an hash code value for this key}.
+ */
+@Override
+public int hashCode() {
+return 7 + name.hashCode() + 31 * valueType.hashCode();
+}
+
+/**
+ * Compares this key with the given objec
[jira] [Commented] (MNG-8015) Control the type of path where each dependency can be placed
[
https://issues.apache.org/jira/browse/MNG-8015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806314#comment-17806314
]
ASF GitHub Bot commented on MNG-8015:
-
cstamas commented on code in PR #1378:
URL: https://github.com/apache/maven/pull/1378#discussion_r1451569685
##
api/maven-api-core/src/main/java/org/apache/maven/api/DependencyProperties.java:
##
@@ -33,27 +36,226 @@
@Immutable
public interface DependencyProperties {
/**
- * Boolean flag telling that dependency contains all of its dependencies.
Value of this key should be parsed with
- * {@link Boolean#parseBoolean(String)} to obtain value.
+ * Keys in the dependency properties map.
+ * Each key can be associated to values of a specific class.
+ *
+ * @paramtype of value associated to the key
+ */
+class Key {
+/**
+ * The keys that are defined in this {@code DependencyProperties} map.
+ * Accesses to this map shall be synchronized on the map.
+ *
+ * @see #intern()
+ */
+private static final Map> INTERNS = new HashMap<>();
+
+/**
+ * Value returned by {@link #name()}.
+ */
+@Nonnull
+private final String name;
+
+/**
+ * Value returned by {@link #valueType()}.
+ */
+@Nonnull
+private final Class valueType;
+
+/**
+ * Creates a new key.
+ *
+ * @param name name of the key
+ * @param valueType type of value associated to the key
+ */
+public Key(@Nonnull final String name, @Nonnull final Class
valueType) {
+this.name = Objects.requireNonNull(name);
+this.valueType = Objects.requireNonNull(valueType);
+}
+
+/**
+ * If a key exists in the {@linkplain #intern() intern pool} for the
given name, returns that key.
+ * Otherwise, if the {@code defaultType} is non-null, creates a key
for values of the specified type.
+ * Otherwise, returns {@code null}.
+ *
+ * @param name name of the key to search or create
+ * @param defaultType value type of the key to create if none exist
for the given name, or {@code null}
+ * @return key found or created, or {@code null} if no key was found
and {@code defaultType} is null
+ *
+ * @see #intern()
+ */
+public static Key forName(String name, Class defaultType) {
+Key key;
+synchronized (INTERNS) {
+key = INTERNS.get(name);
+}
+if (key == null && defaultType != null) {
+key = new Key<>(name, defaultType);
+}
+return key;
+}
+
+/**
+ * {@return the name of the key}.
+ */
+@Nonnull
+public String name() {
+return name;
+}
+
+/**
+ * {@return the type of value associated to the key}.
+ */
+@Nonnull
+public Class valueType() {
+return valueType;
+}
+
+/**
+ * {@return a canonical representation of this key}. A pool of keys,
initially empty, is maintained privately.
+ * When the {@code intern()} method is invoked, if the pool already
contains a key equal to this {@code Key}
+ * as determined by the {@link #equals(Object)} method, then the key
from the pool is returned. Otherwise,
+ * if no key exist in the pool for this key {@linkplain #name() name},
then this {@code Key} object is added
+ * to the pool and {@code this} is returned. Otherwise an {@link
IllegalStateException} is thrown.
+ *
+ * @throws IllegalStateException if a key exists in the pool for the
same name but a different class of values.
+ *
+ * @see String#intern()
+ */
+@SuppressWarnings("unchecked")
+public Key intern() {
+Key previous;
+synchronized (INTERNS) {
+previous = INTERNS.putIfAbsent(name, this);
+}
+if (previous == null) {
+return this;
+}
+if (equals(previous)) {
+return (Key) previous;
+}
+throw new IllegalStateException("Key " + name + " already exists
for a different class of values.");
+}
+
+/**
+ * {@return a string representation of this key}.
+ * By default, this is the name of this key.
+ */
+@Override
+public String toString() {
+return name;
+}
+
+/**
+ * {@return an hash code value for this key}.
+ */
+@Override
+public int hashCode() {
+return 7 + name.hashCode() + 31 * valueType.hashCode();
+}
+
+/**
+ * Compares this key with the given objec
[jira] [Updated] (DOXIA-724) Sink pipeline returned by AbstractParser.getWrappedSink(...) has wrong order
[
https://issues.apache.org/jira/browse/DOXIA-724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated DOXIA-724:
--
Description: According to the javadoc the SinkWrapperFactory should be
ordered according to their priority from highest to lowest. However in
{{AbstractParser.getWrappedSink()}} a pipeline is returned which has no
predictable order. (was: According to the javadoc the SinkWrapperFactory
should be ordered according to their priority from highest to lowest. However
in {{AbstractParser.getWrappedSink()}} a pipeline is returned which is ordered
the other way around (i.e. lowest priority first).)
> Sink pipeline returned by AbstractParser.getWrappedSink(...) has wrong order
>
>
> Key: DOXIA-724
> URL: https://issues.apache.org/jira/browse/DOXIA-724
> Project: Maven Doxia
> Issue Type: Bug
>Affects Versions: 2.0.0-M9
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> According to the javadoc the SinkWrapperFactory should be ordered according
> to their priority from highest to lowest. However in
> {{AbstractParser.getWrappedSink()}} a pipeline is returned which has no
> predictable order.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (DOXIA-724) Sink pipeline returned by AbstractParser.getWrappedSink(...) has wrong order
[
https://issues.apache.org/jira/browse/DOXIA-724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806316#comment-17806316
]
ASF GitHub Bot commented on DOXIA-724:
--
kwin opened a new pull request, #195:
URL: https://github.com/apache/maven-doxia/pull/195
(no comment)
> Sink pipeline returned by AbstractParser.getWrappedSink(...) has wrong order
>
>
> Key: DOXIA-724
> URL: https://issues.apache.org/jira/browse/DOXIA-724
> Project: Maven Doxia
> Issue Type: Bug
>Affects Versions: 2.0.0-M9
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> According to the javadoc the SinkWrapperFactory should be ordered according
> to their priority from highest to lowest. However in
> {{AbstractParser.getWrappedSink()}} a pipeline is returned which has no
> predictable order.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (DOXIA-725) Latest doxia-coreM9 is not compatible with doxia-sitetools
Abel Salgado Romero created DOXIA-725: - Summary: Latest doxia-coreM9 is not compatible with doxia-sitetools Key: DOXIA-725 URL: https://issues.apache.org/jira/browse/DOXIA-725 Project: Maven Doxia Issue Type: Improvement Reporter: Abel Salgado Romero Testing Milestones I found `doxia-core`M9 is not compatible with `doxia-sitetools`. This commit https://github.com/apache/maven-doxia/commit/0dfe227b6603151b8b460d2b7cacc8953a512f4f final methods where added to `AbstractSink` class, those are still present in sub-classes like `SiteRendererSink` which now fail instantiation with: ``` java.lang.IncompatibleClassChangeError: class org.apache.maven.doxia.siterenderer.sink.SiteRendererSink overrides final method org.apache.maven.doxia.sink.impl.AbstractSink.head( ``` -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (DOXIA-725) Latest doxia-coreM9 is not compatible with doxia-sitetools
[ https://issues.apache.org/jira/browse/DOXIA-725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abel Salgado Romero updated DOXIA-725: -- Description: Testing Milestones I found `doxia-core` 4.0.0-M9 is not compatible with `doxia-sitetools`. This commit [https://github.com/apache/maven-doxia/commit/0dfe227b6603151b8b460d2b7cacc8953a512f4f] final methods where added to `AbstractSink` class, those are still present in sub-classes like `SiteRendererSink` which now fail instantiation with: ``` java.lang.IncompatibleClassChangeError: class org.apache.maven.doxia.siterenderer.sink.SiteRendererSink overrides final method org.apache.maven.doxia.sink.impl.AbstractSink.head( ``` was: Testing Milestones I found `doxia-core`M9 is not compatible with `doxia-sitetools`. This commit https://github.com/apache/maven-doxia/commit/0dfe227b6603151b8b460d2b7cacc8953a512f4f final methods where added to `AbstractSink` class, those are still present in sub-classes like `SiteRendererSink` which now fail instantiation with: ``` java.lang.IncompatibleClassChangeError: class org.apache.maven.doxia.siterenderer.sink.SiteRendererSink overrides final method org.apache.maven.doxia.sink.impl.AbstractSink.head( ``` > Latest doxia-coreM9 is not compatible with doxia-sitetools > -- > > Key: DOXIA-725 > URL: https://issues.apache.org/jira/browse/DOXIA-725 > Project: Maven Doxia > Issue Type: Improvement >Reporter: Abel Salgado Romero >Priority: Major > > Testing Milestones I found `doxia-core` 4.0.0-M9 is not compatible with > `doxia-sitetools`. > This commit > [https://github.com/apache/maven-doxia/commit/0dfe227b6603151b8b460d2b7cacc8953a512f4f] > final methods where added to `AbstractSink` class, those are still present > in sub-classes like `SiteRendererSink` which now fail instantiation with: > ``` > java.lang.IncompatibleClassChangeError: class > org.apache.maven.doxia.siterenderer.sink.SiteRendererSink overrides final > method org.apache.maven.doxia.sink.impl.AbstractSink.head( > ``` -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DOXIA-725) Latest doxia-coreM9 is not compatible with doxia-sitetools
[ https://issues.apache.org/jira/browse/DOXIA-725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806321#comment-17806321 ] Abel Salgado Romero commented on DOXIA-725: --- I just noted that since asciidoctor-maven-site 4.0.0-M4 the modules are not even detected. I assume there are some internal big changes. I found this [https://cwiki.apache.org/confluence/display/MAVEN/Towards+Doxia+2.0.0+Stack#TowardsDoxia2.0.0Stack-ReportingPluginMaintainers,] but there's no migration guide or detail on what do to. > Latest doxia-coreM9 is not compatible with doxia-sitetools > -- > > Key: DOXIA-725 > URL: https://issues.apache.org/jira/browse/DOXIA-725 > Project: Maven Doxia > Issue Type: Improvement >Reporter: Abel Salgado Romero >Priority: Major > > Testing Milestones I found `doxia-core` 4.0.0-M9 is not compatible with > `doxia-sitetools`. > This commit > [https://github.com/apache/maven-doxia/commit/0dfe227b6603151b8b460d2b7cacc8953a512f4f] > final methods where added to `AbstractSink` class, those are still present > in sub-classes like `SiteRendererSink` which now fail instantiation with: > ``` > java.lang.IncompatibleClassChangeError: class > org.apache.maven.doxia.siterenderer.sink.SiteRendererSink overrides final > method org.apache.maven.doxia.sink.impl.AbstractSink.head( > ``` -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-8015] Control the type of path where each dependency can be placed [maven]
cstamas commented on code in PR #1378:
URL: https://github.com/apache/maven/pull/1378#discussion_r1451569685
##
api/maven-api-core/src/main/java/org/apache/maven/api/DependencyProperties.java:
##
@@ -33,27 +36,226 @@
@Immutable
public interface DependencyProperties {
/**
- * Boolean flag telling that dependency contains all of its dependencies.
Value of this key should be parsed with
- * {@link Boolean#parseBoolean(String)} to obtain value.
+ * Keys in the dependency properties map.
+ * Each key can be associated to values of a specific class.
+ *
+ * @paramtype of value associated to the key
+ */
+class Key {
+/**
+ * The keys that are defined in this {@code DependencyProperties} map.
+ * Accesses to this map shall be synchronized on the map.
+ *
+ * @see #intern()
+ */
+private static final Map> INTERNS = new HashMap<>();
+
+/**
+ * Value returned by {@link #name()}.
+ */
+@Nonnull
+private final String name;
+
+/**
+ * Value returned by {@link #valueType()}.
+ */
+@Nonnull
+private final Class valueType;
+
+/**
+ * Creates a new key.
+ *
+ * @param name name of the key
+ * @param valueType type of value associated to the key
+ */
+public Key(@Nonnull final String name, @Nonnull final Class
valueType) {
+this.name = Objects.requireNonNull(name);
+this.valueType = Objects.requireNonNull(valueType);
+}
+
+/**
+ * If a key exists in the {@linkplain #intern() intern pool} for the
given name, returns that key.
+ * Otherwise, if the {@code defaultType} is non-null, creates a key
for values of the specified type.
+ * Otherwise, returns {@code null}.
+ *
+ * @param name name of the key to search or create
+ * @param defaultType value type of the key to create if none exist
for the given name, or {@code null}
+ * @return key found or created, or {@code null} if no key was found
and {@code defaultType} is null
+ *
+ * @see #intern()
+ */
+public static Key forName(String name, Class defaultType) {
+Key key;
+synchronized (INTERNS) {
+key = INTERNS.get(name);
+}
+if (key == null && defaultType != null) {
+key = new Key<>(name, defaultType);
+}
+return key;
+}
+
+/**
+ * {@return the name of the key}.
+ */
+@Nonnull
+public String name() {
+return name;
+}
+
+/**
+ * {@return the type of value associated to the key}.
+ */
+@Nonnull
+public Class valueType() {
+return valueType;
+}
+
+/**
+ * {@return a canonical representation of this key}. A pool of keys,
initially empty, is maintained privately.
+ * When the {@code intern()} method is invoked, if the pool already
contains a key equal to this {@code Key}
+ * as determined by the {@link #equals(Object)} method, then the key
from the pool is returned. Otherwise,
+ * if no key exist in the pool for this key {@linkplain #name() name},
then this {@code Key} object is added
+ * to the pool and {@code this} is returned. Otherwise an {@link
IllegalStateException} is thrown.
+ *
+ * @throws IllegalStateException if a key exists in the pool for the
same name but a different class of values.
+ *
+ * @see String#intern()
+ */
+@SuppressWarnings("unchecked")
+public Key intern() {
+Key previous;
+synchronized (INTERNS) {
+previous = INTERNS.putIfAbsent(name, this);
+}
+if (previous == null) {
+return this;
+}
+if (equals(previous)) {
+return (Key) previous;
+}
+throw new IllegalStateException("Key " + name + " already exists
for a different class of values.");
+}
+
+/**
+ * {@return a string representation of this key}.
+ * By default, this is the name of this key.
+ */
+@Override
+public String toString() {
+return name;
+}
+
+/**
+ * {@return an hash code value for this key}.
+ */
+@Override
+public int hashCode() {
+return 7 + name.hashCode() + 31 * valueType.hashCode();
+}
+
+/**
+ * Compares this key with the given object for equality.
+ * Two keys are considered equal if they have the same name
+ * and are associated to values of the same class.
+ *
+ * @param obj the object to compare with this key
+ * @return whether the g
[jira] [Commented] (MNG-8015) Control the type of path where each dependency can be placed
[
https://issues.apache.org/jira/browse/MNG-8015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806323#comment-17806323
]
ASF GitHub Bot commented on MNG-8015:
-
cstamas commented on code in PR #1378:
URL: https://github.com/apache/maven/pull/1378#discussion_r1451569685
##
api/maven-api-core/src/main/java/org/apache/maven/api/DependencyProperties.java:
##
@@ -33,27 +36,226 @@
@Immutable
public interface DependencyProperties {
/**
- * Boolean flag telling that dependency contains all of its dependencies.
Value of this key should be parsed with
- * {@link Boolean#parseBoolean(String)} to obtain value.
+ * Keys in the dependency properties map.
+ * Each key can be associated to values of a specific class.
+ *
+ * @paramtype of value associated to the key
+ */
+class Key {
+/**
+ * The keys that are defined in this {@code DependencyProperties} map.
+ * Accesses to this map shall be synchronized on the map.
+ *
+ * @see #intern()
+ */
+private static final Map> INTERNS = new HashMap<>();
+
+/**
+ * Value returned by {@link #name()}.
+ */
+@Nonnull
+private final String name;
+
+/**
+ * Value returned by {@link #valueType()}.
+ */
+@Nonnull
+private final Class valueType;
+
+/**
+ * Creates a new key.
+ *
+ * @param name name of the key
+ * @param valueType type of value associated to the key
+ */
+public Key(@Nonnull final String name, @Nonnull final Class
valueType) {
+this.name = Objects.requireNonNull(name);
+this.valueType = Objects.requireNonNull(valueType);
+}
+
+/**
+ * If a key exists in the {@linkplain #intern() intern pool} for the
given name, returns that key.
+ * Otherwise, if the {@code defaultType} is non-null, creates a key
for values of the specified type.
+ * Otherwise, returns {@code null}.
+ *
+ * @param name name of the key to search or create
+ * @param defaultType value type of the key to create if none exist
for the given name, or {@code null}
+ * @return key found or created, or {@code null} if no key was found
and {@code defaultType} is null
+ *
+ * @see #intern()
+ */
+public static Key forName(String name, Class defaultType) {
+Key key;
+synchronized (INTERNS) {
+key = INTERNS.get(name);
+}
+if (key == null && defaultType != null) {
+key = new Key<>(name, defaultType);
+}
+return key;
+}
+
+/**
+ * {@return the name of the key}.
+ */
+@Nonnull
+public String name() {
+return name;
+}
+
+/**
+ * {@return the type of value associated to the key}.
+ */
+@Nonnull
+public Class valueType() {
+return valueType;
+}
+
+/**
+ * {@return a canonical representation of this key}. A pool of keys,
initially empty, is maintained privately.
+ * When the {@code intern()} method is invoked, if the pool already
contains a key equal to this {@code Key}
+ * as determined by the {@link #equals(Object)} method, then the key
from the pool is returned. Otherwise,
+ * if no key exist in the pool for this key {@linkplain #name() name},
then this {@code Key} object is added
+ * to the pool and {@code this} is returned. Otherwise an {@link
IllegalStateException} is thrown.
+ *
+ * @throws IllegalStateException if a key exists in the pool for the
same name but a different class of values.
+ *
+ * @see String#intern()
+ */
+@SuppressWarnings("unchecked")
+public Key intern() {
+Key previous;
+synchronized (INTERNS) {
+previous = INTERNS.putIfAbsent(name, this);
+}
+if (previous == null) {
+return this;
+}
+if (equals(previous)) {
+return (Key) previous;
+}
+throw new IllegalStateException("Key " + name + " already exists
for a different class of values.");
+}
+
+/**
+ * {@return a string representation of this key}.
+ * By default, this is the name of this key.
+ */
+@Override
+public String toString() {
+return name;
+}
+
+/**
+ * {@return an hash code value for this key}.
+ */
+@Override
+public int hashCode() {
+return 7 + name.hashCode() + 31 * valueType.hashCode();
+}
+
+/**
+ * Compares this key with the given objec
[jira] [Updated] (DOXIA-725) Latest doxia-coreM9 is not compatible with doxia-sitetools
[ https://issues.apache.org/jira/browse/DOXIA-725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated DOXIA-725: - Fix Version/s: waiting-for-feedback > Latest doxia-coreM9 is not compatible with doxia-sitetools > -- > > Key: DOXIA-725 > URL: https://issues.apache.org/jira/browse/DOXIA-725 > Project: Maven Doxia > Issue Type: Improvement >Reporter: Abel Salgado Romero >Priority: Major > Fix For: waiting-for-feedback > > > Testing Milestones I found `doxia-core` 4.0.0-M9 is not compatible with > `doxia-sitetools`. > This commit > [https://github.com/apache/maven-doxia/commit/0dfe227b6603151b8b460d2b7cacc8953a512f4f] > final methods where added to `AbstractSink` class, those are still present > in sub-classes like `SiteRendererSink` which now fail instantiation with: > ``` > java.lang.IncompatibleClassChangeError: class > org.apache.maven.doxia.siterenderer.sink.SiteRendererSink overrides final > method org.apache.maven.doxia.sink.impl.AbstractSink.head( > ``` -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (DOXIA-725) Latest Doxia Core is not compatible with doxia-sitetools
[ https://issues.apache.org/jira/browse/DOXIA-725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated DOXIA-725: - Summary: Latest Doxia Core is not compatible with doxia-sitetools (was: Latest doxia-coreM9 is not compatible with doxia-sitetools) > Latest Doxia Core is not compatible with doxia-sitetools > > > Key: DOXIA-725 > URL: https://issues.apache.org/jira/browse/DOXIA-725 > Project: Maven Doxia > Issue Type: Improvement >Affects Versions: 2.0.0-M9 >Reporter: Abel Salgado Romero >Priority: Major > Fix For: waiting-for-feedback > > > Testing Milestones I found `doxia-core` 4.0.0-M9 is not compatible with > `doxia-sitetools`. > This commit > [https://github.com/apache/maven-doxia/commit/0dfe227b6603151b8b460d2b7cacc8953a512f4f] > final methods where added to `AbstractSink` class, those are still present > in sub-classes like `SiteRendererSink` which now fail instantiation with: > ``` > java.lang.IncompatibleClassChangeError: class > org.apache.maven.doxia.siterenderer.sink.SiteRendererSink overrides final > method org.apache.maven.doxia.sink.impl.AbstractSink.head( > ``` -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DOXIA-725) Latest doxia-coreM9 is not compatible with doxia-sitetools
[ https://issues.apache.org/jira/browse/DOXIA-725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806325#comment-17806325 ] Michael Osipov commented on DOXIA-725: -- I consider this as invalid because you cannot update a single component, you need to update all in one go. Next Sitetools milestone is in preparation > Latest doxia-coreM9 is not compatible with doxia-sitetools > -- > > Key: DOXIA-725 > URL: https://issues.apache.org/jira/browse/DOXIA-725 > Project: Maven Doxia > Issue Type: Improvement >Reporter: Abel Salgado Romero >Priority: Major > > Testing Milestones I found `doxia-core` 4.0.0-M9 is not compatible with > `doxia-sitetools`. > This commit > [https://github.com/apache/maven-doxia/commit/0dfe227b6603151b8b460d2b7cacc8953a512f4f] > final methods where added to `AbstractSink` class, those are still present > in sub-classes like `SiteRendererSink` which now fail instantiation with: > ``` > java.lang.IncompatibleClassChangeError: class > org.apache.maven.doxia.siterenderer.sink.SiteRendererSink overrides final > method org.apache.maven.doxia.sink.impl.AbstractSink.head( > ``` -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (DOXIA-725) Latest doxia-coreM9 is not compatible with doxia-sitetools
[ https://issues.apache.org/jira/browse/DOXIA-725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated DOXIA-725: - Affects Version/s: 2.0.0-M9 > Latest doxia-coreM9 is not compatible with doxia-sitetools > -- > > Key: DOXIA-725 > URL: https://issues.apache.org/jira/browse/DOXIA-725 > Project: Maven Doxia > Issue Type: Improvement >Affects Versions: 2.0.0-M9 >Reporter: Abel Salgado Romero >Priority: Major > Fix For: waiting-for-feedback > > > Testing Milestones I found `doxia-core` 4.0.0-M9 is not compatible with > `doxia-sitetools`. > This commit > [https://github.com/apache/maven-doxia/commit/0dfe227b6603151b8b460d2b7cacc8953a512f4f] > final methods where added to `AbstractSink` class, those are still present > in sub-classes like `SiteRendererSink` which now fail instantiation with: > ``` > java.lang.IncompatibleClassChangeError: class > org.apache.maven.doxia.siterenderer.sink.SiteRendererSink overrides final > method org.apache.maven.doxia.sink.impl.AbstractSink.head( > ``` -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DOXIA-725) Latest Doxia Core is not compatible with doxia-sitetools
[ https://issues.apache.org/jira/browse/DOXIA-725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806326#comment-17806326 ] Michael Osipov commented on DOXIA-725: -- [~kwin], you need to also maintain these sections if you change something relevant: https://cwiki.apache.org/confluence/display/MAVEN/Towards+Doxia+2.0.0+Stack#TowardsDoxia2.0.0Stack-MigrationNotes > Latest Doxia Core is not compatible with doxia-sitetools > > > Key: DOXIA-725 > URL: https://issues.apache.org/jira/browse/DOXIA-725 > Project: Maven Doxia > Issue Type: Improvement >Affects Versions: 2.0.0-M9 >Reporter: Abel Salgado Romero >Priority: Major > Fix For: waiting-for-feedback > > > Testing Milestones I found `doxia-core` 4.0.0-M9 is not compatible with > `doxia-sitetools`. > This commit > [https://github.com/apache/maven-doxia/commit/0dfe227b6603151b8b460d2b7cacc8953a512f4f] > final methods where added to `AbstractSink` class, those are still present > in sub-classes like `SiteRendererSink` which now fail instantiation with: > ``` > java.lang.IncompatibleClassChangeError: class > org.apache.maven.doxia.siterenderer.sink.SiteRendererSink overrides final > method org.apache.maven.doxia.sink.impl.AbstractSink.head( > ``` -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DOXIA-724) Sink pipeline returned by AbstractParser.getWrappedSink(...) has wrong order
[
https://issues.apache.org/jira/browse/DOXIA-724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806327#comment-17806327
]
Michael Osipov commented on DOXIA-724:
--
This means that M9 is void?
> Sink pipeline returned by AbstractParser.getWrappedSink(...) has wrong order
>
>
> Key: DOXIA-724
> URL: https://issues.apache.org/jira/browse/DOXIA-724
> Project: Maven Doxia
> Issue Type: Bug
>Affects Versions: 2.0.0-M9
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> According to the javadoc the SinkWrapperFactory should be ordered according
> to their priority from highest to lowest. However in
> {{AbstractParser.getWrappedSink()}} a pipeline is returned which has no
> predictable order.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MCLEAN-116) Create interface method to catch exceptions
Matthias Bünger created MCLEAN-116:
--
Summary: Create interface method to catch exceptions
Key: MCLEAN-116
URL: https://issues.apache.org/jira/browse/MCLEAN-116
Project: Maven Clean Plugin
Issue Type: Improvement
Affects Versions: 3.3.2
Reporter: Matthias Bünger
As stated multiple times in the {{Cleaner}} class, the {{Logger}} interface of
this class does not provide a method to log exceptions and needs a refactoring
{code:java}
// ...
if (logDebug != null) {
// TODO: this Logger interface cannot log exceptions and needs
refactoring
logDebug.log("Unable to fast delete directory: " + e);
}
// ...
private interface Logger {
void log(CharSequence message);
}
{code}
_This ticket was created to have this task in the issue tracker_
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MCLEAN-116) Create interface method to catch exceptions
[
https://issues.apache.org/jira/browse/MCLEAN-116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias Bünger updated MCLEAN-116:
---
Description:
As stated multiple times in the {{Cleaner}} class, the {{Logger}} interface of
this class does not provide a method to log exceptions and needs a refactoring
{code:java}
// ...
if (logDebug != null) {
// TODO: this Logger interface cannot log exceptions and needs
refactoring
logDebug.log("Unable to fast delete directory: " + e);
}
// ...
private interface Logger {
void log(CharSequence message);
}
{code}
However: Many plugins, e.g. the javadoc-plugin or the pmg-plugin use the
{{org.apache.maven.plugin.logging.Log}} interface. Therefor using this
interface instead an own could be a better solution than adding a new method to
the interface in the {{Cleaner}} class.
_This ticket was created to have this task in the issue tracker_
was:
As stated multiple times in the {{Cleaner}} class, the {{Logger}} interface of
this class does not provide a method to log exceptions and needs a refactoring
{code:java}
// ...
if (logDebug != null) {
// TODO: this Logger interface cannot log exceptions and needs
refactoring
logDebug.log("Unable to fast delete directory: " + e);
}
// ...
private interface Logger {
void log(CharSequence message);
}
{code}
_This ticket was created to have this task in the issue tracker_
> Create interface method to catch exceptions
> ---
>
> Key: MCLEAN-116
> URL: https://issues.apache.org/jira/browse/MCLEAN-116
> Project: Maven Clean Plugin
> Issue Type: Improvement
>Affects Versions: 3.3.2
>Reporter: Matthias Bünger
>Priority: Minor
>
> As stated multiple times in the {{Cleaner}} class, the {{Logger}} interface
> of this class does not provide a method to log exceptions and needs a
> refactoring
> {code:java}
> // ...
> if (logDebug != null) {
> // TODO: this Logger interface cannot log exceptions and
> needs refactoring
> logDebug.log("Unable to fast delete directory: " + e);
> }
> // ...
> private interface Logger {
> void log(CharSequence message);
> }
> {code}
> However: Many plugins, e.g. the javadoc-plugin or the pmg-plugin use the
> {{org.apache.maven.plugin.logging.Log}} interface. Therefor using this
> interface instead an own could be a better solution than adding a new method
> to the interface in the {{Cleaner}} class.
> _This ticket was created to have this task in the issue tracker_
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MCHANGES-421) Typo in changes.xsd
[ https://issues.apache.org/jira/browse/MCHANGES-421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806329#comment-17806329 ] Michael Osipov commented on MCHANGES-421: - I dare to say that this plugin is orphaned now for years, unfortunately...see also my email to dev@ last year about its state...I provided a way forward, a painful way. > Typo in changes.xsd > --- > > Key: MCHANGES-421 > URL: https://issues.apache.org/jira/browse/MCHANGES-421 > Project: Maven Changes Plugin > Issue Type: Bug >Affects Versions: 2.12.1 >Reporter: Philipp Ottlinger >Priority: Major > > While wondering which types to fill in as action type I stumbled upon > https://maven.apache.org/plugins/maven-changes-plugin/xsd/changes-1.0.0.xsd > and realized that there are typos: > It should be "functionality" instead of "functionnality" > As I was unable to spot the file in the repo of maven-changes-plugin I > thought creating a bugticket might be an easier way to get those trivial > fixes into the XSD. > Thanks -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MCHANGES-421) Typo in changes.xsd
[ https://issues.apache.org/jira/browse/MCHANGES-421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MCHANGES-421: --- Assignee: Michael Osipov > Typo in changes.xsd > --- > > Key: MCHANGES-421 > URL: https://issues.apache.org/jira/browse/MCHANGES-421 > Project: Maven Changes Plugin > Issue Type: Bug >Affects Versions: 2.12.1 >Reporter: Philipp Ottlinger >Assignee: Michael Osipov >Priority: Major > > While wondering which types to fill in as action type I stumbled upon > https://maven.apache.org/plugins/maven-changes-plugin/xsd/changes-1.0.0.xsd > and realized that there are typos: > It should be "functionality" instead of "functionnality" > As I was unable to spot the file in the repo of maven-changes-plugin I > thought creating a bugticket might be an easier way to get those trivial > fixes into the XSD. > Thanks -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] MCHANGES-421: Fix typos in changes.mdo [maven-changes-plugin]
michael-o commented on PR #30: URL: https://github.com/apache/maven-changes-plugin/pull/30#issuecomment-1890740736 I will happily merge this out of courtesy for a fellow committer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MCHANGES-421) Typo in changes.xsd
[ https://issues.apache.org/jira/browse/MCHANGES-421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806330#comment-17806330 ] ASF GitHub Bot commented on MCHANGES-421: - michael-o commented on PR #30: URL: https://github.com/apache/maven-changes-plugin/pull/30#issuecomment-1890740736 I will happily merge this out of courtesy for a fellow committer. > Typo in changes.xsd > --- > > Key: MCHANGES-421 > URL: https://issues.apache.org/jira/browse/MCHANGES-421 > Project: Maven Changes Plugin > Issue Type: Bug >Affects Versions: 2.12.1 >Reporter: Philipp Ottlinger >Priority: Major > > While wondering which types to fill in as action type I stumbled upon > https://maven.apache.org/plugins/maven-changes-plugin/xsd/changes-1.0.0.xsd > and realized that there are typos: > It should be "functionality" instead of "functionnality" > As I was unable to spot the file in the repo of maven-changes-plugin I > thought creating a bugticket might be an easier way to get those trivial > fixes into the XSD. > Thanks -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MCHANGES-421) Typo in changes.xsd
[ https://issues.apache.org/jira/browse/MCHANGES-421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MCHANGES-421: Fix Version/s: backlog > Typo in changes.xsd > --- > > Key: MCHANGES-421 > URL: https://issues.apache.org/jira/browse/MCHANGES-421 > Project: Maven Changes Plugin > Issue Type: Bug >Affects Versions: 2.12.1 >Reporter: Philipp Ottlinger >Assignee: Michael Osipov >Priority: Major > Fix For: backlog > > > While wondering which types to fill in as action type I stumbled upon > https://maven.apache.org/plugins/maven-changes-plugin/xsd/changes-1.0.0.xsd > and realized that there are typos: > It should be "functionality" instead of "functionnality" > As I was unable to spot the file in the repo of maven-changes-plugin I > thought creating a bugticket might be an easier way to get those trivial > fixes into the XSD. > Thanks -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [DOXIA-724] Fix order of sink wrappers in pipeline [maven-doxia]
michael-o commented on code in PR #195:
URL: https://github.com/apache/maven-doxia/pull/195#discussion_r1451591751
##
doxia-core/src/main/java/org/apache/maven/doxia/parser/Parser.java:
##
@@ -95,11 +95,12 @@ public interface Parser {
void addSinkWrapperFactory(SinkWrapperFactory factory);
/**
- *
- * @return all sink wrapper factories in the correct order (both
registered automatically and manually)
+ * Returns all sink wrapper factories (both registered automatically and
manually). The collection is ordered in a way that
+ * the factories having the lowest priority come first (i.e. in reverse
order).
+ * @return all sink wrapper factories in the reverse order
* @since 2.0.0
*/
-Collection getSinkWrapperFactories();
+List getSinkWrapperFactories();
Review Comment:
Is is necessary to change the signature here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (DOXIA-724) Sink pipeline returned by AbstractParser.getWrappedSink(...) has wrong order
[
https://issues.apache.org/jira/browse/DOXIA-724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806333#comment-17806333
]
ASF GitHub Bot commented on DOXIA-724:
--
michael-o commented on code in PR #195:
URL: https://github.com/apache/maven-doxia/pull/195#discussion_r1451591751
##
doxia-core/src/main/java/org/apache/maven/doxia/parser/Parser.java:
##
@@ -95,11 +95,12 @@ public interface Parser {
void addSinkWrapperFactory(SinkWrapperFactory factory);
/**
- *
- * @return all sink wrapper factories in the correct order (both
registered automatically and manually)
+ * Returns all sink wrapper factories (both registered automatically and
manually). The collection is ordered in a way that
+ * the factories having the lowest priority come first (i.e. in reverse
order).
+ * @return all sink wrapper factories in the reverse order
* @since 2.0.0
*/
-Collection getSinkWrapperFactories();
+List getSinkWrapperFactories();
Review Comment:
Is is necessary to change the signature here?
> Sink pipeline returned by AbstractParser.getWrappedSink(...) has wrong order
>
>
> Key: DOXIA-724
> URL: https://issues.apache.org/jira/browse/DOXIA-724
> Project: Maven Doxia
> Issue Type: Bug
>Affects Versions: 2.0.0-M9
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> According to the javadoc the SinkWrapperFactory should be ordered according
> to their priority from highest to lowest. However in
> {{AbstractParser.getWrappedSink()}} a pipeline is returned which has no
> predictable order.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] MCHANGES-421: Fix typos in changes.mdo [maven-changes-plugin]
asfgit closed pull request #30: MCHANGES-421: Fix typos in changes.mdo URL: https://github.com/apache/maven-changes-plugin/pull/30 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MCHANGES-421) Typo in changes.xsd
[ https://issues.apache.org/jira/browse/MCHANGES-421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806336#comment-17806336 ] ASF GitHub Bot commented on MCHANGES-421: - asfgit closed pull request #30: MCHANGES-421: Fix typos in changes.mdo URL: https://github.com/apache/maven-changes-plugin/pull/30 > Typo in changes.xsd > --- > > Key: MCHANGES-421 > URL: https://issues.apache.org/jira/browse/MCHANGES-421 > Project: Maven Changes Plugin > Issue Type: Bug >Affects Versions: 2.12.1 >Reporter: Philipp Ottlinger >Assignee: Michael Osipov >Priority: Major > Fix For: backlog > > > While wondering which types to fill in as action type I stumbled upon > https://maven.apache.org/plugins/maven-changes-plugin/xsd/changes-1.0.0.xsd > and realized that there are typos: > It should be "functionality" instead of "functionnality" > As I was unable to spot the file in the repo of maven-changes-plugin I > thought creating a bugticket might be an easier way to get those trivial > fixes into the XSD. > Thanks -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MCHANGES-421) Typo in changes.xsd
[ https://issues.apache.org/jira/browse/MCHANGES-421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MCHANGES-421. --- Resolution: Fixed Fixed with [8f1a462e0414fbd410897dd2f5fffe9ccdf71fe3|https://gitbox.apache.org/repos/asf?p=maven-changes-plugin.git;a=commit;h=8f1a462e0414fbd410897dd2f5fffe9ccdf71fe3]. > Typo in changes.xsd > --- > > Key: MCHANGES-421 > URL: https://issues.apache.org/jira/browse/MCHANGES-421 > Project: Maven Changes Plugin > Issue Type: Bug >Affects Versions: 2.12.1 >Reporter: Philipp Ottlinger >Assignee: Michael Osipov >Priority: Major > Fix For: backlog > > > While wondering which types to fill in as action type I stumbled upon > https://maven.apache.org/plugins/maven-changes-plugin/xsd/changes-1.0.0.xsd > and realized that there are typos: > It should be "functionality" instead of "functionnality" > As I was unable to spot the file in the repo of maven-changes-plugin I > thought creating a bugticket might be an easier way to get those trivial > fixes into the XSD. > Thanks -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] Bump commons-io:commons-io from 2.6 to 2.7 [maven-changes-plugin]
dependabot[bot] opened a new pull request, #32: URL: https://github.com/apache/maven-changes-plugin/pull/32 Bumps commons-io:commons-io from 2.6 to 2.7. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/maven-changes-plugin/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.apache.httpcomponents:httpclient from 4.2.3 to 4.5.13 [maven-changes-plugin]
dependabot[bot] opened a new pull request, #31: URL: https://github.com/apache/maven-changes-plugin/pull/31 Bumps org.apache.httpcomponents:httpclient from 4.2.3 to 4.5.13. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/maven-changes-plugin/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.apache.maven:maven-compat from 3.0.5 to 3.8.1 [maven-changes-plugin]
dependabot[bot] opened a new pull request, #34: URL: https://github.com/apache/maven-changes-plugin/pull/34 Bumps [org.apache.maven:maven-compat](https://github.com/apache/maven) from 3.0.5 to 3.8.1. Commits https://github.com/apache/maven/commit/05c21c65bdfed0f71a2f2ada8b84da59348c4c5d";>05c21c6 [maven-release-plugin] prepare release maven-3.8.1 https://github.com/apache/maven/commit/d295dc362fe7d7b189b4976a5742a17362eb51a1";>d295dc3 [MNG-7128] keep blocked attribute from mirrors in artifact repositories https://github.com/apache/maven/commit/a46906806a31edb462b935e380a657b6efde6231";>a469068 next version in branch 3.8.x is 3.8.1-SNAPSHOT https://github.com/apache/maven/commit/dad8a3e1c55f34b7949945bc622f26447ddbf4f9";>dad8a3e [maven-release-plugin] prepare for next development iteration https://github.com/apache/maven/commit/6aa1f4acf5d6323e9aa08b763cb9933dc96749b9";>6aa1f4a [maven-release-plugin] prepare release maven-3.8.0 https://github.com/apache/maven/commit/907d53ad3264718f66ff15e1363d76b07dd0c05f";>907d53a [MNG-7118] block HTTP repositories by default https://github.com/apache/maven/commit/899465aeec03753ea91e15a79579eab76369c016";>899465a [MNG-7117] add support for blocked mirror https://github.com/apache/maven/commit/fa79cb22e456cc65522b5bab8c4240fe08c5775f";>fa79cb2 [MNG-7116] add support for mirrorOf external:http:* https://github.com/apache/maven/commit/e5f6634e17362387282b3867c9b23d4b54fea871";>e5f6634 use Maven Resolver 1.6.2 https://github.com/apache/maven/commit/09f77da9b0c39848fe763bdd4a392151eec0d8c3";>09f77da [MNG-7119] Upgrade Maven Wagon to 3.4.3 Additional commits viewable in https://github.com/apache/maven/compare/maven-3.0.5...maven-3.8.1";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/maven-changes-plugin/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.apache.maven:maven-core from 3.0.5 to 3.8.1 [maven-changes-plugin]
dependabot[bot] opened a new pull request, #33: URL: https://github.com/apache/maven-changes-plugin/pull/33 Bumps [org.apache.maven:maven-core](https://github.com/apache/maven) from 3.0.5 to 3.8.1. Commits https://github.com/apache/maven/commit/05c21c65bdfed0f71a2f2ada8b84da59348c4c5d";>05c21c6 [maven-release-plugin] prepare release maven-3.8.1 https://github.com/apache/maven/commit/d295dc362fe7d7b189b4976a5742a17362eb51a1";>d295dc3 [MNG-7128] keep blocked attribute from mirrors in artifact repositories https://github.com/apache/maven/commit/a46906806a31edb462b935e380a657b6efde6231";>a469068 next version in branch 3.8.x is 3.8.1-SNAPSHOT https://github.com/apache/maven/commit/dad8a3e1c55f34b7949945bc622f26447ddbf4f9";>dad8a3e [maven-release-plugin] prepare for next development iteration https://github.com/apache/maven/commit/6aa1f4acf5d6323e9aa08b763cb9933dc96749b9";>6aa1f4a [maven-release-plugin] prepare release maven-3.8.0 https://github.com/apache/maven/commit/907d53ad3264718f66ff15e1363d76b07dd0c05f";>907d53a [MNG-7118] block HTTP repositories by default https://github.com/apache/maven/commit/899465aeec03753ea91e15a79579eab76369c016";>899465a [MNG-7117] add support for blocked mirror https://github.com/apache/maven/commit/fa79cb22e456cc65522b5bab8c4240fe08c5775f";>fa79cb2 [MNG-7116] add support for mirrorOf external:http:* https://github.com/apache/maven/commit/e5f6634e17362387282b3867c9b23d4b54fea871";>e5f6634 use Maven Resolver 1.6.2 https://github.com/apache/maven/commit/09f77da9b0c39848fe763bdd4a392151eec0d8c3";>09f77da [MNG-7119] Upgrade Maven Wagon to 3.4.3 Additional commits viewable in https://github.com/apache/maven/compare/maven-3.0.5...maven-3.8.1";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/maven-changes-plugin/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (DOXIASITETOOLS-321) Upgrade htmlunit 2.x to 3.9
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated DOXIASITETOOLS-321: -- Fix Version/s: 2.0.0 2.0.0-M17 (was: version-next) > Upgrade htmlunit 2.x to 3.9 > --- > > Key: DOXIASITETOOLS-321 > URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-321 > Project: Maven Doxia Sitetools > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: 2.0.0, 2.0.0-M17 > > > https://github.com/advisories/GHSA-3xrr-7m6p-p7xh -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [DOXIASITETOOLS-324] Allow configuration of Doxia parser [maven-doxia-sitetools]
michael-o commented on PR #126: URL: https://github.com/apache/maven-doxia-sitetools/pull/126#issuecomment-1890752975 @kwin Can you please double-check tests, they fail for me: ``` [INFO] Running org.apache.maven.doxia.siterenderer.DefaultSiteRendererTest [main] WARN org.apache.maven.doxia.module.xdoc.XdocParser - Unrecognized xdoc tag at [32:45] [ERROR] Tests run: 7, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 4.820 s <<< FAILURE! -- in org.apache.maven.doxia.siterenderer.DefaultSiteRendererTest [ERROR] org.apache.maven.doxia.siterenderer.DefaultSiteRendererTest.testRender -- Time elapsed: 2.650 s <<< ERROR! java.lang.ClassCastException: org.htmlunit.html.HtmlAnchor cannot be cast to org.htmlunit.html.HtmlHeading1 at org.apache.maven.doxia.siterenderer.NestedItemsVerifier.verify(NestedItemsVerifier.java:65) at org.apache.maven.doxia.siterenderer.DefaultSiteRendererTest.verifyNestedItemsPage(DefaultSiteRendererTest.java:353) at org.apache.maven.doxia.siterenderer.DefaultSiteRendererTest.testRender(DefaultSiteRendererTest.java:224) at java.lang.reflect.Method.invoke(Method.java:498) at java.util.ArrayList.forEach(ArrayList.java:1259) at java.util.ArrayList.forEach(ArrayList.java:1259) [INFO] Running org.apache.maven.doxia.siterenderer.RenderingContextTest [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.085 s -- in org.apache.maven.doxia.siterenderer.RenderingContextTest [INFO] [INFO] Results: [INFO] [ERROR] Errors: [ERROR] DefaultSiteRendererTest.testRender:224->verifyNestedItemsPage:353 � ClassCast org.htmlunit.html.HtmlAnchor cannot be cast to org.htmlunit.html.HtmlHeading1 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DOXIASITETOOLS-324) Allow configuration of parser (per markup source path pattern)
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806365#comment-17806365 ] ASF GitHub Bot commented on DOXIASITETOOLS-324: --- michael-o commented on PR #126: URL: https://github.com/apache/maven-doxia-sitetools/pull/126#issuecomment-1890752975 @kwin Can you please double-check tests, they fail for me: ``` [INFO] Running org.apache.maven.doxia.siterenderer.DefaultSiteRendererTest [main] WARN org.apache.maven.doxia.module.xdoc.XdocParser - Unrecognized xdoc tag at [32:45] [ERROR] Tests run: 7, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 4.820 s <<< FAILURE! > Allow configuration of parser (per markup source path pattern) > -- > > Key: DOXIASITETOOLS-324 > URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-324 > Project: Maven Doxia Sitetools > Issue Type: New Feature > Components: Site renderer >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 2.0.0-M17 > > > Currently the Doxia parsers being used for the Doxia markup sources have a > fix configuration > (https://github.com/apache/maven-doxia-sitetools/blob/dacaa552c1b8e89eed84db0f43b6b0a72be91d0c/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java#L324). > It would be beneficial to allow to dynamically configure the parsers (based > on a matching markup source path pattern) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MCHANGES-422) Require Java 8
Sylwester Lachiewicz created MCHANGES-422: - Summary: Require Java 8 Key: MCHANGES-422 URL: https://issues.apache.org/jira/browse/MCHANGES-422 Project: Maven Changes Plugin Issue Type: Dependency upgrade Reporter: Sylwester Lachiewicz -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MCHANGES-422) Require Java 8
[ https://issues.apache.org/jira/browse/MCHANGES-422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MCHANGES-422: -- Fix Version/s: 3.0.0 > Require Java 8 > -- > > Key: MCHANGES-422 > URL: https://issues.apache.org/jira/browse/MCHANGES-422 > Project: Maven Changes Plugin > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] [MCHANGES-422] Require Java 8 [maven-changes-plugin]
slachiewicz opened a new pull request, #35: URL: https://github.com/apache/maven-changes-plugin/pull/35 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MCHANGES-422] Require Java 8 [maven-changes-plugin]
slachiewicz merged PR #35: URL: https://github.com/apache/maven-changes-plugin/pull/35 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MCHANGES-422) Require Java 8
[ https://issues.apache.org/jira/browse/MCHANGES-422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806370#comment-17806370 ] ASF GitHub Bot commented on MCHANGES-422: - slachiewicz merged PR #35: URL: https://github.com/apache/maven-changes-plugin/pull/35 > Require Java 8 > -- > > Key: MCHANGES-422 > URL: https://issues.apache.org/jira/browse/MCHANGES-422 > Project: Maven Changes Plugin > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MCHANGES-422) Require Java 8
[ https://issues.apache.org/jira/browse/MCHANGES-422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806369#comment-17806369 ] ASF GitHub Bot commented on MCHANGES-422: - slachiewicz opened a new pull request, #35: URL: https://github.com/apache/maven-changes-plugin/pull/35 (no comment) > Require Java 8 > -- > > Key: MCHANGES-422 > URL: https://issues.apache.org/jira/browse/MCHANGES-422 > Project: Maven Changes Plugin > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MCHANGES-422) Require Java 8
[ https://issues.apache.org/jira/browse/MCHANGES-422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz reassigned MCHANGES-422: - Assignee: Sylwester Lachiewicz > Require Java 8 > -- > > Key: MCHANGES-422 > URL: https://issues.apache.org/jira/browse/MCHANGES-422 > Project: Maven Changes Plugin > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MCHANGES-422) Require Java 8
[ https://issues.apache.org/jira/browse/MCHANGES-422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MCHANGES-422. - Resolution: Fixed > Require Java 8 > -- > > Key: MCHANGES-422 > URL: https://issues.apache.org/jira/browse/MCHANGES-422 > Project: Maven Changes Plugin > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] [MCHANGES-415] Update parent pom to 41 [maven-changes-plugin]
slachiewicz opened a new pull request, #36: URL: https://github.com/apache/maven-changes-plugin/pull/36 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MCHANGES-415) Update parent pom to 39
[ https://issues.apache.org/jira/browse/MCHANGES-415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806372#comment-17806372 ] ASF GitHub Bot commented on MCHANGES-415: - slachiewicz opened a new pull request, #36: URL: https://github.com/apache/maven-changes-plugin/pull/36 (no comment) > Update parent pom to 39 > --- > > Key: MCHANGES-415 > URL: https://issues.apache.org/jira/browse/MCHANGES-415 > Project: Maven Changes Plugin > Issue Type: Dependency upgrade >Reporter: Elliotte Rusty Harold >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MCHANGES-415] Update parent pom to 41 [maven-changes-plugin]
slachiewicz merged PR #36: URL: https://github.com/apache/maven-changes-plugin/pull/36 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MCHANGES-415) Update parent pom to 39
[ https://issues.apache.org/jira/browse/MCHANGES-415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806373#comment-17806373 ] ASF GitHub Bot commented on MCHANGES-415: - slachiewicz merged PR #36: URL: https://github.com/apache/maven-changes-plugin/pull/36 > Update parent pom to 39 > --- > > Key: MCHANGES-415 > URL: https://issues.apache.org/jira/browse/MCHANGES-415 > Project: Maven Changes Plugin > Issue Type: Dependency upgrade >Reporter: Elliotte Rusty Harold >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [DOXIASITETOOLS-324] Allow configuration of Doxia parser [maven-doxia-sitetools]
kwin commented on PR #126: URL: https://github.com/apache/maven-doxia-sitetools/pull/126#issuecomment-1890767593 I know about the failing tests: https://github.com/apache/maven-doxia-sitetools/pull/126#issuecomment-1884787622 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DOXIASITETOOLS-324) Allow configuration of parser (per markup source path pattern)
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806379#comment-17806379 ] ASF GitHub Bot commented on DOXIASITETOOLS-324: --- kwin commented on PR #126: URL: https://github.com/apache/maven-doxia-sitetools/pull/126#issuecomment-1890767593 I know about the failing tests: https://github.com/apache/maven-doxia-sitetools/pull/126#issuecomment-1884787622 > Allow configuration of parser (per markup source path pattern) > -- > > Key: DOXIASITETOOLS-324 > URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-324 > Project: Maven Doxia Sitetools > Issue Type: New Feature > Components: Site renderer >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 2.0.0-M17 > > > Currently the Doxia parsers being used for the Doxia markup sources have a > fix configuration > (https://github.com/apache/maven-doxia-sitetools/blob/dacaa552c1b8e89eed84db0f43b6b0a72be91d0c/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java#L324). > It would be beneficial to allow to dynamically configure the parsers (based > on a matching markup source path pattern) -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [DOXIASITETOOLS-324] Allow configuration of Doxia parser [maven-doxia-sitetools]
michael-o commented on PR #126: URL: https://github.com/apache/maven-doxia-sitetools/pull/126#issuecomment-1890769500 > I know about the failing tests: [#126 (comment)](https://github.com/apache/maven-doxia-sitetools/pull/126#issuecomment-1884787622) Though, #124 has been merged. Should I ignore this for now or do you want to address it first? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DOXIASITETOOLS-324) Allow configuration of parser (per markup source path pattern)
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806381#comment-17806381 ] ASF GitHub Bot commented on DOXIASITETOOLS-324: --- michael-o commented on PR #126: URL: https://github.com/apache/maven-doxia-sitetools/pull/126#issuecomment-1890769500 > I know about the failing tests: [#126 (comment)](https://github.com/apache/maven-doxia-sitetools/pull/126#issuecomment-1884787622) Though, #124 has been merged. Should I ignore this for now or do you want to address it first? > Allow configuration of parser (per markup source path pattern) > -- > > Key: DOXIASITETOOLS-324 > URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-324 > Project: Maven Doxia Sitetools > Issue Type: New Feature > Components: Site renderer >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 2.0.0-M17 > > > Currently the Doxia parsers being used for the Doxia markup sources have a > fix configuration > (https://github.com/apache/maven-doxia-sitetools/blob/dacaa552c1b8e89eed84db0f43b6b0a72be91d0c/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java#L324). > It would be beneficial to allow to dynamically configure the parsers (based > on a matching markup source path pattern) -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MCHANGES-415] Cleanup after pom upgrade [maven-changes-plugin]
slachiewicz merged PR #37: URL: https://github.com/apache/maven-changes-plugin/pull/37 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
