[
https://issues.apache.org/jira/browse/MSHARED-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806285#comment-17806285
]
ASF GitHub Bot commented on MSHARED-1351:
-----------------------------------------
abelsromero opened a new pull request, #93:
URL: https://github.com/apache/maven-filtering/pull/93
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MSHARED) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
:point_right:
https://issues.apache.org/jira/browse/MSHARED-1351?jql=component%20%3D%20maven-filtering%20
- [x] Each commit in the pull request should have a meaningful subject line
and body.
:crossed_fingers:
- [x] Format the pull request title like `[MSHARED-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MSHARED-XXX` with the appropriate JIRA issue. Best
practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
:point_right: `[MSHARED-1351] - Fix console message when origin is baseDir`
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
Checks when the path for the message is empty, then replaces that empty with
"base dir" to avoid an invalid message.
I considered directly comparing paths
```java
String origin;
if (basedir.equals(resourceDirectory)) {
origin = "base directory";
} else {
origin = basedir.relativize(
resourceDirectory.getAbsoluteFile().toPath()) .toString();
}
```
It's more expressive, but that adds extra path processing that are not
necessary if we simply check the relativized result.
PS: run
- [x] Run `mvn clean verify -Prun-its` to make sure basic checks pass. A
more thorough check will
be performed on your pull request automatically.
:ok: The profile does not exist btw, simply run `mvn clean verify` and `mvn
spotless:apply` to fix formatting.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licensed under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> Confusing message when copying resources from project's baseDir
> ---------------------------------------------------------------
>
> Key: MSHARED-1351
> URL: https://issues.apache.org/jira/browse/MSHARED-1351
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-filtering
> Affects Versions: maven-filtering-3.3.1
> Reporter: Abel Salgado Romero
> Priority: Minor
>
> When the project base dir is used as the origin path, the relativize in
> https://github.com/apache/maven-filtering/blob/dce786df4301dab6d51d1eab6bbb79e510327086/src/main/java/org/apache/maven/shared/filtering/DefaultMavenResourcesFiltering.java#L259
> resolves to empty string, resulting in nothing being displayed path after
> "from" in the console:
> ```
> Copying 118 resources from to target/generated-docs
> ```
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
