cstamas commented on code in PR #1378:
URL: https://github.com/apache/maven/pull/1378#discussion_r1451566662
##########
maven-artifact/src/main/java/org/apache/maven/artifact/handler/ArtifactHandler.java:
##########
@@ -53,5 +53,16 @@ public interface ArtifactHandler {
String getLanguage();
+ /**
+ * Specifies if the artifact contains java classes and can be added to the
classpath.
+ * Whether the artifact <em>should</em> be added to the classpath depends
on other
+ * dependency properties.
+ *
+ * @return if the artifact <em>can</em> be added to the class path
+ *
+ * @deprecated A value of {@code true} does not mean that the dependency
<em>should</em>
+ * be placed on the classpath. See {@code JavaPathType} instead for better
analysis.
+ */
+ @Deprecated
Review Comment:
IMHO whole artifactHandler/ArtifactHandlerManager should be deprecated, is
there ONLY to support Maven3 plugins in Maven4, while since
eee037e6763445e7901b84fce4e992ddec17df0d they are really just adapting maven4
stuff.
##########
maven-artifact/src/main/java/org/apache/maven/artifact/handler/ArtifactHandler.java:
##########
@@ -53,5 +53,16 @@ public interface ArtifactHandler {
String getLanguage();
+ /**
+ * Specifies if the artifact contains java classes and can be added to the
classpath.
+ * Whether the artifact <em>should</em> be added to the classpath depends
on other
+ * dependency properties.
+ *
+ * @return if the artifact <em>can</em> be added to the class path
+ *
+ * @deprecated A value of {@code true} does not mean that the dependency
<em>should</em>
+ * be placed on the classpath. See {@code JavaPathType} instead for better
analysis.
+ */
+ @Deprecated
Review Comment:
IMHO whole artifactHandler/ArtifactHandlerManager should be deprecated, is
there ONLY to support Maven3 plugins in Maven4, while since
eee037e6763445e7901b84fce4e992ddec17df0d they are really just adapting maven4
stuff. This is of course unrelated to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
