[GitHub] [maven-enforcer] slawekjaranowski commented on pull request #183: [MENFORCER-430] Allow one of many files in RequireFiles rules to pass
slawekjaranowski commented on PR #183: URL: https://github.com/apache/maven-enforcer/pull/183#issuecomment-1237740485 @raupachz thanks for PR - looks ok. Please add corresponding documentation in this PR - we will have complete change. Files to edit are in https://github.com/apache/maven-enforcer/tree/master/enforcer-rules/src/site/apt -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-enforcer] slawekjaranowski commented on a diff in pull request #183: [MENFORCER-430] Allow one of many files in RequireFiles rules to pass
slawekjaranowski commented on code in PR #183:
URL: https://github.com/apache/maven-enforcer/pull/183#discussion_r963331915
##
enforcer-rules/src/test/java/org/apache/maven/plugins/enforcer/TestRequireFilesDontExist.java:
##
@@ -136,6 +136,34 @@ public void testFileDoesNotExist()
rule.execute( EnforcerTestUtils.getHelper() );
}
+@Test
+public void testFileDoesNotExistSatisfyAny()
+throws IOException
+{
+File f = File.createTempFile( "junit", null, temporaryFolder );
+f.delete();
Review Comment:
Instead of creating and deleting file we can simply create File object with
a wrong path
##
enforcer-rules/src/test/java/org/apache/maven/plugins/enforcer/TestRequireFilesDontExist.java:
##
@@ -136,6 +136,34 @@ public void testFileDoesNotExist()
rule.execute( EnforcerTestUtils.getHelper() );
}
+@Test
+public void testFileDoesNotExistSatisfyAny()
+throws IOException
+{
+File f = File.createTempFile( "junit", null, temporaryFolder );
+f.delete();
+
+assertFalse( f.exists() );
+
+File g = File.createTempFile( "junit", null, temporaryFolder );
+
+assertTrue( g.exists() );
+
+rule.setFiles( new File[] { f, g.getCanonicalFile() } );
+rule.setSatisfyAny(true);
+
+try
+{
+rule.execute( EnforcerTestUtils.getHelper() );
+}
+catch ( EnforcerRuleException e )
+{
+fail( "Unexpected Exception:" + e.getLocalizedMessage() );
+}
Review Comment:
We can simply add this exception to test method signature
##
enforcer-rules/src/test/java/org/apache/maven/plugins/enforcer/TestRequireFilesDontExist.java:
##
@@ -136,6 +136,34 @@ public void testFileDoesNotExist()
rule.execute( EnforcerTestUtils.getHelper() );
}
+@Test
+public void testFileDoesNotExistSatisfyAny()
+throws IOException
+{
+File f = File.createTempFile( "junit", null, temporaryFolder );
+f.delete();
+
+assertFalse( f.exists() );
+
+File g = File.createTempFile( "junit", null, temporaryFolder );
+
+assertTrue( g.exists() );
+
+rule.setFiles( new File[] { f, g.getCanonicalFile() } );
+rule.setSatisfyAny(true);
+
+try
+{
+rule.execute( EnforcerTestUtils.getHelper() );
+}
+catch ( EnforcerRuleException e )
+{
+fail( "Unexpected Exception:" + e.getLocalizedMessage() );
+}
+
+g.delete();
Review Comment:
File was created in `@TempDir` so I hope that `junit` will remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-verifier] slawekjaranowski commented on pull request #41: [MSHARED-1125] Require Maven args to be provided one by one
slawekjaranowski commented on PR #41: URL: https://github.com/apache/maven-verifier/pull/41#issuecomment-1237753963 I will look at integration tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MSHARED-1125) Require Maven args to be provided one by one
[ https://issues.apache.org/jira/browse/MSHARED-1125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski reassigned MSHARED-1125: Assignee: Slawomir Jaranowski > Require Maven args to be provided one by one > > > Key: MSHARED-1125 > URL: https://issues.apache.org/jira/browse/MSHARED-1125 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-verifier >Reporter: Michael Osipov >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: maven-verifier-2.0.0 > > > For the next major we shall require user configuration to provide each > argument passed to Maven to be separate. This will avoid edge cases and > remove the requirement to pipe this through faulty/incomplete CLI parse > Maven/Plexus Shared Utils. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SUREFIRE-2115) Unable to execute specific inner class test in Surefire
Baubak Gandomi created SUREFIRE-2115:
Summary: Unable to execute specific inner class test in Surefire
Key: SUREFIRE-2115
URL: https://issues.apache.org/jira/browse/SUREFIRE-2115
Project: Maven Surefire
Issue Type: Bug
Components: Maven Surefire Plugin, TestNG support
Reporter: Baubak Gandomi
Hi I have a nested class hierarchy which is as follows:
{code:java}
public class NestClassContainer {
@Test
public static class TestClass1 {
public void testC1_m1() {
System.out.println("Should not execute");
}
}
@Test
public static class TestClass2 {
public void testC2_m1() {
System.out.println("Should execute");
}
}
}{code}
I want to use Surefire to only execute NestClassContainer$TestClass2, This
works just fine in TestNG exeution, but I cannot get it to work in Surefire.
When I try to execute one of the nested classes TestClass2 , it executes all
the tests in the top class. (Tested versions 2.22.1 & 3.0.0-M7)
Here is my commandline:
{code:java}
mvn clean test -Dtest=NestClassContainer$TestClass2 {code}
Expected outcome:
We execute only testC2_m1
Actual outcome:
Both testC1_m1 & testC2_m1 are executed.
I have even tries setting the annotations on the test methods instead, but the
result is the same.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-verifier] michael-o commented on a diff in pull request #41: [MSHARED-1125] Require Maven args to be provided one by one
michael-o commented on code in PR #41:
URL: https://github.com/apache/maven-verifier/pull/41#discussion_r963353890
##
src/test/java/org/apache/maven/shared/verifier/VerifierTest.java:
##
@@ -130,4 +139,74 @@ void testDefaultFilterMap() throws VerificationException
assertTrue( filterMap.containsKey( "@basedir@" ) );
assertTrue( filterMap.containsKey( "@baseurl@" ) );
}
+
+@Test
+void testDefaultMavenArgument() throws VerificationException
+{
+TestVerifier verifier = new TestVerifier( "src/test/resources" );
+
+verifier.executeGoal( "test" );
Review Comment:
Unrelated: We see now that the `executeGoal()` name is misleading because
`test` isn't a goal, it is a phase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-verifier] michael-o commented on a diff in pull request #41: [MSHARED-1125] Require Maven args to be provided one by one
michael-o commented on code in PR #41:
URL: https://github.com/apache/maven-verifier/pull/41#discussion_r963360482
##
src/main/java/org/apache/maven/shared/verifier/Verifier.java:
##
@@ -1237,20 +1237,9 @@ public void executeGoals( List goals,
Map envVars )
File logFile = new File( getBasedir(), getLogFileName() );
-for ( Object cliOption : cliOptions )
+for ( String cliOption : cliOptions )
{
-String key = String.valueOf( cliOption );
-
-String resolvedArg = resolveCommandLineArg( key );
-
-try
-{
-args.addAll( Arrays.asList(
CommandLineUtils.translateCommandline( resolvedArg ) ) );
-}
-catch ( Exception e )
-{
-e.printStackTrace();
-}
+args.add( resolveCommandLineArg( cliOption ) );
Review Comment:
I believe that most quoting here is not necessary anymore:
`resolveCommandLineArg()`
##
src/test/java/org/apache/maven/shared/verifier/VerifierTest.java:
##
@@ -130,4 +139,74 @@ void testDefaultFilterMap() throws VerificationException
assertTrue( filterMap.containsKey( "@basedir@" ) );
assertTrue( filterMap.containsKey( "@baseurl@" ) );
}
+
+@Test
+void testDefaultMavenArgument() throws VerificationException
+{
+TestVerifier verifier = new TestVerifier( "src/test/resources" );
+
+verifier.executeGoal( "test" );
+
+assertThat( verifier.launcher.cliArgs, arrayContaining(
+"-e", "--batch-mode", "-Dmaven.repo.local=test-local-repo",
+"org.apache.maven.plugins:maven-clean-plugin:clean", "test" ) );
+}
+
+public static Stream argumentsForTest()
+{
+return Stream.of(
+arguments( "test-argument", "test-argument" ),
+arguments( "test/${basedir}/test", "test/src/test/resources/test"
),
+arguments( "argument with space", "argument with space" )
+);
+}
+
+@ParameterizedTest
+@MethodSource( "argumentsForTest" )
+void argumentShouldBePassAsIs(String inputArgument, String
expectedArgument) throws VerificationException
Review Comment:
`...Passed`
##
src/test/java/org/apache/maven/shared/verifier/VerifierTest.java:
##
@@ -130,4 +139,74 @@ void testDefaultFilterMap() throws VerificationException
assertTrue( filterMap.containsKey( "@basedir@" ) );
assertTrue( filterMap.containsKey( "@baseurl@" ) );
}
+
+@Test
+void testDefaultMavenArgument() throws VerificationException
+{
+TestVerifier verifier = new TestVerifier( "src/test/resources" );
+
+verifier.executeGoal( "test" );
+
+assertThat( verifier.launcher.cliArgs, arrayContaining(
+"-e", "--batch-mode", "-Dmaven.repo.local=test-local-repo",
+"org.apache.maven.plugins:maven-clean-plugin:clean", "test" ) );
+}
+
+public static Stream argumentsForTest()
+{
+return Stream.of(
+arguments( "test-argument", "test-argument" ),
+arguments( "test/${basedir}/test", "test/src/test/resources/test"
),
+arguments( "argument with space", "argument with space" )
+);
+}
+
+@ParameterizedTest
+@MethodSource( "argumentsForTest" )
+void argumentShouldBePassAsIs(String inputArgument, String
expectedArgument) throws VerificationException
Review Comment:
line formatting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-verifier] michael-o commented on pull request #41: [MSHARED-1125] Require Maven args to be provided one by one
michael-o commented on PR #41: URL: https://github.com/apache/maven-verifier/pull/41#issuecomment-1237775446 What about `invoker.properties`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-verifier] slawekjaranowski commented on a diff in pull request #41: [MSHARED-1125] Require Maven args to be provided one by one
slawekjaranowski commented on code in PR #41:
URL: https://github.com/apache/maven-verifier/pull/41#discussion_r963363365
##
src/test/java/org/apache/maven/shared/verifier/VerifierTest.java:
##
@@ -130,4 +139,74 @@ void testDefaultFilterMap() throws VerificationException
assertTrue( filterMap.containsKey( "@basedir@" ) );
assertTrue( filterMap.containsKey( "@baseurl@" ) );
}
+
+@Test
+void testDefaultMavenArgument() throws VerificationException
+{
+TestVerifier verifier = new TestVerifier( "src/test/resources" );
+
+verifier.executeGoal( "test" );
Review Comment:
I saw it ... I thinking to deprecate all `executeGoal` methods and replace
it by one `execute()` without arguments, in fact it is next command line
argument ... but in next change if we wish
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-verifier] michael-o commented on a diff in pull request #41: [MSHARED-1125] Require Maven args to be provided one by one
michael-o commented on code in PR #41:
URL: https://github.com/apache/maven-verifier/pull/41#discussion_r963364441
##
src/test/java/org/apache/maven/shared/verifier/VerifierTest.java:
##
@@ -130,4 +139,74 @@ void testDefaultFilterMap() throws VerificationException
assertTrue( filterMap.containsKey( "@basedir@" ) );
assertTrue( filterMap.containsKey( "@baseurl@" ) );
}
+
+@Test
+void testDefaultMavenArgument() throws VerificationException
+{
+TestVerifier verifier = new TestVerifier( "src/test/resources" );
+
+verifier.executeGoal( "test" );
Review Comment:
> I saw it ... I thinking to deprecate all `executeGoal` methods and replace
it by one `execute()` without arguments, in fact it is next command line
argument ... but in next change if we wish
I absolutely support this position!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-verifier] michael-o commented on pull request #41: [MSHARED-1125] Require Maven args to be provided one by one
michael-o commented on PR #41:
URL: https://github.com/apache/maven-verifier/pull/41#issuecomment-123803
> Looks good to me. Fwiw, I have found 32 references to such pattern in
`maven-integration-testing` by looking for `\.addCliOption\( "[\S]+ .*"`. A PR
should be raised asap to align those, even before the switch to verifier 2.0.
Maybe we could add a helper method to add several arguments:
>
> ```
> public void addCliOptions( String... options )
> {
> ...
> }
> ```
This is a good idea with varargs...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-verifier] slawekjaranowski commented on a diff in pull request #41: [MSHARED-1125] Require Maven args to be provided one by one
slawekjaranowski commented on code in PR #41:
URL: https://github.com/apache/maven-verifier/pull/41#discussion_r963366392
##
src/main/java/org/apache/maven/shared/verifier/Verifier.java:
##
@@ -1237,20 +1237,9 @@ public void executeGoals( List goals,
Map envVars )
File logFile = new File( getBasedir(), getLogFileName() );
-for ( Object cliOption : cliOptions )
+for ( String cliOption : cliOptions )
{
-String key = String.valueOf( cliOption );
-
-String resolvedArg = resolveCommandLineArg( key );
-
-try
-{
-args.addAll( Arrays.asList(
CommandLineUtils.translateCommandline( resolvedArg ) ) );
-}
-catch ( Exception e )
-{
-e.printStackTrace();
-}
+args.add( resolveCommandLineArg( cliOption ) );
Review Comment:
`resolveCommandLineArg()` is responsible for replace `${basedir}`
placeholder in arguments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-verifier] michael-o commented on a diff in pull request #41: [MSHARED-1125] Require Maven args to be provided one by one
michael-o commented on code in PR #41:
URL: https://github.com/apache/maven-verifier/pull/41#discussion_r963367622
##
src/main/java/org/apache/maven/shared/verifier/Verifier.java:
##
@@ -1237,20 +1237,9 @@ public void executeGoals( List goals,
Map envVars )
File logFile = new File( getBasedir(), getLogFileName() );
-for ( Object cliOption : cliOptions )
+for ( String cliOption : cliOptions )
{
-String key = String.valueOf( cliOption );
-
-String resolvedArg = resolveCommandLineArg( key );
-
-try
-{
-args.addAll( Arrays.asList(
CommandLineUtils.translateCommandline( resolvedArg ) ) );
-}
-catch ( Exception e )
-{
-e.printStackTrace();
-}
+args.add( resolveCommandLineArg( cliOption ) );
Review Comment:
I know, but why is there so much fiddling afterwards. I if this truy for
basedir, then the method needs to be renamed and handle basedir only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-verifier] michael-o commented on a diff in pull request #41: [MSHARED-1125] Require Maven args to be provided one by one
michael-o commented on code in PR #41:
URL: https://github.com/apache/maven-verifier/pull/41#discussion_r963367622
##
src/main/java/org/apache/maven/shared/verifier/Verifier.java:
##
@@ -1237,20 +1237,9 @@ public void executeGoals( List goals,
Map envVars )
File logFile = new File( getBasedir(), getLogFileName() );
-for ( Object cliOption : cliOptions )
+for ( String cliOption : cliOptions )
{
-String key = String.valueOf( cliOption );
-
-String resolvedArg = resolveCommandLineArg( key );
-
-try
-{
-args.addAll( Arrays.asList(
CommandLineUtils.translateCommandline( resolvedArg ) ) );
-}
-catch ( Exception e )
-{
-e.printStackTrace();
-}
+args.add( resolveCommandLineArg( cliOption ) );
Review Comment:
I know, but why is there so much fiddling afterwards. I if this truly for
basedir, then the method needs to be renamed and handle basedir only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-verifier] slawekjaranowski commented on pull request #41: [MSHARED-1125] Require Maven args to be provided one by one
slawekjaranowski commented on PR #41: URL: https://github.com/apache/maven-verifier/pull/41#issuecomment-1237793320 > What about `invoker.properties`? it is not used here ... it is for `maven-invoker-plugin` - I think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-build-cache-extension] eltsovalex commented on a diff in pull request #24: [MBUILDCACHE-22] added possibility to skip cache lookup per project or globally
eltsovalex commented on code in PR #24: URL: https://github.com/apache/maven-build-cache-extension/pull/24#discussion_r963450942 ## src/main/java/org/apache/maven/buildcache/xml/CacheConfigImpl.java: ## @@ -87,6 +87,16 @@ public class CacheConfigImpl implements org.apache.maven.buildcache.xml.CacheCon public static final String RESTORE_GENERATED_SOURCES_PROPERTY_NAME = "maven.build.cache.restoreGeneratedSources"; public static final String ALWAYS_RUN_PLUGINS = "maven.build.cache.alwaysRunPlugins"; +/** + * Flag to control if we should skip lookup for cached artifacts globally r for a particular project even if Review Comment: fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MBUILDCACHE-22) Add possibility to skip cache lookup
[ https://issues.apache.org/jira/browse/MBUILDCACHE-22?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17600681#comment-17600681 ] ASF GitHub Bot commented on MBUILDCACHE-22: --- eltsovalex commented on code in PR #24: URL: https://github.com/apache/maven-build-cache-extension/pull/24#discussion_r963450942 ## src/main/java/org/apache/maven/buildcache/xml/CacheConfigImpl.java: ## @@ -87,6 +87,16 @@ public class CacheConfigImpl implements org.apache.maven.buildcache.xml.CacheCon public static final String RESTORE_GENERATED_SOURCES_PROPERTY_NAME = "maven.build.cache.restoreGeneratedSources"; public static final String ALWAYS_RUN_PLUGINS = "maven.build.cache.alwaysRunPlugins"; +/** + * Flag to control if we should skip lookup for cached artifacts globally r for a particular project even if Review Comment: fixed > Add possibility to skip cache lookup > > > Key: MBUILDCACHE-22 > URL: https://issues.apache.org/jira/browse/MBUILDCACHE-22 > Project: Maven Build Cache Extension > Issue Type: New Feature > Components: remote build cache >Affects Versions: 1.0.0-alpha >Reporter: Alexander Eltsov >Priority: Major > Labels: pull-request-available > > Add ability to skip cache lookup for a particular module or whole project > (required to get some modules always built e.g. via a profile - e.g. I have > some additional artifacts published by CI). > Alternatively it allows an easy "force" rebuild of a whole project > The difference with not using cache is that results are put into cache, just > current matching versions are not taken from caches -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-build-cache-extension] eltsovalex commented on pull request #24: [MBUILDCACHE-22] added possibility to skip cache lookup per project or globally
eltsovalex commented on PR #24: URL: https://github.com/apache/maven-build-cache-extension/pull/24#issuecomment-1237868527 Typos fixed in javadoc + new parameters described in documentation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MBUILDCACHE-22) Add possibility to skip cache lookup
[ https://issues.apache.org/jira/browse/MBUILDCACHE-22?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17600683#comment-17600683 ] ASF GitHub Bot commented on MBUILDCACHE-22: --- eltsovalex commented on PR #24: URL: https://github.com/apache/maven-build-cache-extension/pull/24#issuecomment-1237868527 Typos fixed in javadoc + new parameters described in documentation > Add possibility to skip cache lookup > > > Key: MBUILDCACHE-22 > URL: https://issues.apache.org/jira/browse/MBUILDCACHE-22 > Project: Maven Build Cache Extension > Issue Type: New Feature > Components: remote build cache >Affects Versions: 1.0.0-alpha >Reporter: Alexander Eltsov >Priority: Major > Labels: pull-request-available > > Add ability to skip cache lookup for a particular module or whole project > (required to get some modules always built e.g. via a profile - e.g. I have > some additional artifacts published by CI). > Alternatively it allows an easy "force" rebuild of a whole project > The difference with not using cache is that results are put into cache, just > current matching versions are not taken from caches -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-verifier] michael-o commented on a diff in pull request #41: [MSHARED-1125] Require Maven args to be provided one by one
michael-o commented on code in PR #41:
URL: https://github.com/apache/maven-verifier/pull/41#discussion_r963626152
##
src/test/java/org/apache/maven/shared/verifier/VerifierTest.java:
##
@@ -130,4 +139,74 @@ void testDefaultFilterMap() throws VerificationException
assertTrue( filterMap.containsKey( "@basedir@" ) );
assertTrue( filterMap.containsKey( "@baseurl@" ) );
}
+
+@Test
+void testDefaultMavenArgument() throws VerificationException
+{
+TestVerifier verifier = new TestVerifier( "src/test/resources" );
+
+verifier.executeGoal( "test" );
Review Comment:
Can you file an issue about that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-verifier] michael-o commented on pull request #41: [MSHARED-1125] Require Maven args to be provided one by one
michael-o commented on PR #41: URL: https://github.com/apache/maven-verifier/pull/41#issuecomment-1238064353 > > What about `invoker.properties`? > > it is not used here ... it is for `maven-invoker-plugin` - I think. Right, this is used by Invoker. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MENFORCER-431) Skip specific rules
Delany created MENFORCER-431:
Summary: Skip specific rules
Key: MENFORCER-431
URL: https://issues.apache.org/jira/browse/MENFORCER-431
Project: Maven Enforcer Plugin
Issue Type: New Feature
Components: Plugin
Affects Versions: 3.1.0
Reporter: Delany
I can select rules like
{code:java}
mvn verify -Drules=alwaysPass,alwaysFail {code}
or skip all rules with
{code:java}
mvn verify -Denforcer.skip
{code}
But what if I want to skip a single rule?
{code:java}
mvn verify -DrulesSkip=BanVulnerableDependencies{code}
Vulnerabilities could be discovered and published at any time. This would be a
useful to quickly allow my builds to continue, since I can't always upgrade
dependencies as they appear.
I don't want to turn off ALL my enforcer checks and I also dont want to list
all the checks in the build command.
Skipping a rule is an exceptional circumstance so I don't want to commit it to
the pom.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MENFORCER-431) Skip specific rules
[
https://issues.apache.org/jira/browse/MENFORCER-431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Delany updated MENFORCER-431:
-
Description:
I can select rules like
{code:java}
mvn verify -Drules=alwaysPass,alwaysFail {code}
or skip all rules with
{code:java}
mvn verify -Denforcer.skip
{code}
But what if I want to skip a single rule?
{code:java}
mvn verify -DrulesSkip=BanVulnerableDependencies{code}
Or multiple
{code:java}
mvn verify -DrulesSkip=BanVulnerableDependencies,NoPackageCyclesRule{code}
Vulnerabilities could be discovered and published at any time. This would be a
useful to quickly allow my builds to continue, since I can't always upgrade
dependencies as they appear.
I don't want to turn off ALL my enforcer checks and I also dont want to list
all the checks in the build command.
Skipping a rule is an exceptional circumstance so I don't want to commit it to
the pom.
was:
I can select rules like
{code:java}
mvn verify -Drules=alwaysPass,alwaysFail {code}
or skip all rules with
{code:java}
mvn verify -Denforcer.skip
{code}
But what if I want to skip a single rule?
{code:java}
mvn verify -DrulesSkip=BanVulnerableDependencies{code}
Vulnerabilities could be discovered and published at any time. This would be a
useful to quickly allow my builds to continue, since I can't always upgrade
dependencies as they appear.
I don't want to turn off ALL my enforcer checks and I also dont want to list
all the checks in the build command.
Skipping a rule is an exceptional circumstance so I don't want to commit it to
the pom.
> Skip specific rules
> ---
>
> Key: MENFORCER-431
> URL: https://issues.apache.org/jira/browse/MENFORCER-431
> Project: Maven Enforcer Plugin
> Issue Type: New Feature
> Components: Plugin
>Affects Versions: 3.1.0
>Reporter: Delany
>Priority: Minor
>
> I can select rules like
> {code:java}
> mvn verify -Drules=alwaysPass,alwaysFail {code}
> or skip all rules with
> {code:java}
> mvn verify -Denforcer.skip
> {code}
> But what if I want to skip a single rule?
> {code:java}
> mvn verify -DrulesSkip=BanVulnerableDependencies{code}
> Or multiple
> {code:java}
> mvn verify -DrulesSkip=BanVulnerableDependencies,NoPackageCyclesRule{code}
> Vulnerabilities could be discovered and published at any time. This would be
> a useful to quickly allow my builds to continue, since I can't always upgrade
> dependencies as they appear.
> I don't want to turn off ALL my enforcer checks and I also dont want to list
> all the checks in the build command.
> Skipping a rule is an exceptional circumstance so I don't want to commit it
> to the pom.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-verifier] slawekjaranowski commented on a diff in pull request #41: [MSHARED-1125] Require Maven args to be provided one by one
slawekjaranowski commented on code in PR #41:
URL: https://github.com/apache/maven-verifier/pull/41#discussion_r963652162
##
src/test/java/org/apache/maven/shared/verifier/VerifierTest.java:
##
@@ -130,4 +139,74 @@ void testDefaultFilterMap() throws VerificationException
assertTrue( filterMap.containsKey( "@basedir@" ) );
assertTrue( filterMap.containsKey( "@baseurl@" ) );
}
+
+@Test
+void testDefaultMavenArgument() throws VerificationException
+{
+TestVerifier verifier = new TestVerifier( "src/test/resources" );
+
+verifier.executeGoal( "test" );
Review Comment:
> Can you file an issue about that?
Not yet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MSHARED-966) Resources are not copied to ${project.build.outputDirectory}
[
https://issues.apache.org/jira/browse/MSHARED-966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17600782#comment-17600782
]
Antoine Tran commented on MSHARED-966:
--
Hi,
We have a very weird similar issue upgrading from 3.1.0 to 3.2.0. We have a
simple copy directive:
{code:java}
maven-resources-plugin
3.1.0
copy-resources-docker-dir
generate-resources
copy-resources
${project.build.directory}/${dockername}
src/main/docker
{code}
And the expected result is:
{code:java}
[jenkins@cmt-configurationmanagementtool-jenkins-b67b8f-5t6b8 fci]$ ll
/var/lib/jenkins/jobs/l2pf_swci_pi_support-services-sdt/workspace/SIM-SimulatorTool/docker/sim-simulatortool/target/sim-simulatortool/container/sdt/rpm/src/tds-generators-tools/tds-generator/src/tds_app/fci
total 16905
drwxr-xr-x 3 jenkins pigroup 1045470 Sep 6 13:58 amv
drwxr-xr-x 3 jenkins pigroup 1006514 Sep 6 13:58 asr
drwxr-xr-x 3 jenkins pigroup 1073370 Sep 6 13:58 clm
drwxr-xr-x 3 jenkins pigroup 1017545 Sep 6 13:58 crm
drwxr-xr-x 3 jenkins pigroup 1003715 Sep 6 13:58 ct
drwxr-xr-x 3 jenkins pigroup 1018461 Sep 6 13:58 ctth
drwxr-xr-x 2 jenkins pigroup 1000417 Sep 6 13:58 ecmwf
drwxr-xr-x 2 jenkins pigroup 1007825 Sep 6 13:58 fdac
drwxr-xr-x 2 jenkins pigroup 1000168 Sep 6 13:58 fir
drwxr-xr-x 3 jenkins pigroup 1014870 Sep 6 13:58 giitoz
drwxr-xr-x 2 jenkins pigroup 1027650 Sep 6 13:58 idac
drwxr-xr-x 2 jenkins pigroup 1008923 Sep 6 13:58 l1c
drwxr-xr-x 3 jenkins pigroup 1021113 Sep 6 13:58 oca
drwxr-xr-x 3 jenkins pigroup 1002942 Sep 6 13:58 olr
drwxr-xr-x 3 jenkins pigroup 1018429 Sep 6 13:58 rtm
drwxr-xr-x 2 jenkins pigroup 1024893 Sep 6 13:58 sad
drwxr-xr-x 3 jenkins pigroup 1013582 Sep 6 13:58 tsit{code}
The current result with 3.2.0:
{code:java}
[jenkins@cmt-configurationmanagementtool-jenkins-b67b8f-5t6b8 fci]$ ll
/var/lib/jenkins/jobs/l2pf_swci_pi_support-services-sdt/workspace/SIM-SimulatorTool/docker/sim-simulatortool/target/sim-simulatortool/container/sdt/rpm/src/tds-generators-tools/tds-generator/src/tds_app/fci
total 4967
drwxr-xr-x 2 jenkins pigroup 3400 Sep 6 13:57 l1c
drwxr-xr-x 3 jenkins pigroup 1021113 Sep 6 13:57 oca
drwxr-xr-x 3 jenkins pigroup 1002942 Sep 6 13:57 olr
drwxr-xr-x 3 jenkins pigroup 1018429 Sep 6 13:57 rtm
drwxr-xr-x 2 jenkins pigroup 1024893 Sep 6 13:57 sad
drwxr-xr-x 3 jenkins pigroup 1013582 Sep 6 13:57 tsit {code}
I do not understand why some directories disappear. The log, with debug, is
like the directories disappeared. It is difficult to make a simple reproducible
case. Somehow this is related to a symlink, that if I remove, will make
directories reappear again:
{code:java}
[jenkins@cmt-configurationmanagementtool-jenkins-b67b8f-5t6b8 fci]$ mv
l1c/idac_deg1_preprocessing.py /tmp/
[jenkins@cmt-configurationmanagementtool-jenkins-b67b8f-5t6b8 fci]$ ll
/tmp/idac_deg1_preprocessing.py
lrwxrwxrwx 1 jenkins pigroup 34 Sep 6 12:23 /tmp/idac_deg1_preprocessing.py ->
../idac/idac_deg1_preprocessing.py {code}
I lost some hair with that issue, I am reverting back to 3.1.0.
> Resources are not copied to ${project.build.outputDirectory}
>
>
> Key: MSHARED-966
> URL: https://issues.apache.org/jira/browse/MSHARED-966
> Project: Maven Shared Components
> Issue Type: Bug
> Components: maven-filtering
>Affects Versions: maven-filtering-3.2.0, maven-filtering-3.3.0
> Environment: Maven 3.6.3, Java 11, macOS
>Reporter: Ralf Taugerbeck
>Priority: Major
> Attachments: maven-example.tgz, maven.log
>
>
> Hi,
> after upgrading from 3.1.0 to 3.2.0 I get this weird issue. My build fails
> with a java.nio.file.NoSuchFileException for a file, that actually exists in
> the resources directory.
> What's special about the file is that it was extracted from a dependency
> artifact. I
[GitHub] [maven-enforcer] raupachz commented on a diff in pull request #183: [MENFORCER-430] Allow one of many files in RequireFiles rules to pass
raupachz commented on code in PR #183:
URL: https://github.com/apache/maven-enforcer/pull/183#discussion_r963770596
##
enforcer-rules/src/test/java/org/apache/maven/plugins/enforcer/TestRequireFilesDontExist.java:
##
@@ -136,6 +136,34 @@ public void testFileDoesNotExist()
rule.execute( EnforcerTestUtils.getHelper() );
}
+@Test
+public void testFileDoesNotExistSatisfyAny()
+throws IOException
+{
+File f = File.createTempFile( "junit", null, temporaryFolder );
+f.delete();
Review Comment:
True. I just went with the observed pattern in the test case. To be honest I
find this approach quite elegant. This way I really I really know the file does
not exist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-enforcer] raupachz commented on a diff in pull request #183: [MENFORCER-430] Allow one of many files in RequireFiles rules to pass
raupachz commented on code in PR #183:
URL: https://github.com/apache/maven-enforcer/pull/183#discussion_r963771388
##
enforcer-rules/src/test/java/org/apache/maven/plugins/enforcer/TestRequireFilesDontExist.java:
##
@@ -136,6 +136,34 @@ public void testFileDoesNotExist()
rule.execute( EnforcerTestUtils.getHelper() );
}
+@Test
+public void testFileDoesNotExistSatisfyAny()
+throws IOException
+{
+File f = File.createTempFile( "junit", null, temporaryFolder );
+f.delete();
+
+assertFalse( f.exists() );
+
+File g = File.createTempFile( "junit", null, temporaryFolder );
+
+assertTrue( g.exists() );
+
+rule.setFiles( new File[] { f, g.getCanonicalFile() } );
+rule.setSatisfyAny(true);
+
+try
+{
+rule.execute( EnforcerTestUtils.getHelper() );
+}
+catch ( EnforcerRuleException e )
+{
+fail( "Unexpected Exception:" + e.getLocalizedMessage() );
+}
+
+g.delete();
Review Comment:
Just went with flow. Alright. Will remove the `g.delete()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-verifier] slawekjaranowski commented on a diff in pull request #41: [MSHARED-1125] Require Maven args to be provided one by one
slawekjaranowski commented on code in PR #41:
URL: https://github.com/apache/maven-verifier/pull/41#discussion_r964066549
##
src/test/java/org/apache/maven/shared/verifier/VerifierTest.java:
##
@@ -130,4 +139,74 @@ void testDefaultFilterMap() throws VerificationException
assertTrue( filterMap.containsKey( "@basedir@" ) );
assertTrue( filterMap.containsKey( "@baseurl@" ) );
}
+
+@Test
+void testDefaultMavenArgument() throws VerificationException
+{
+TestVerifier verifier = new TestVerifier( "src/test/resources" );
+
+verifier.executeGoal( "test" );
+
+assertThat( verifier.launcher.cliArgs, arrayContaining(
+"-e", "--batch-mode", "-Dmaven.repo.local=test-local-repo",
+"org.apache.maven.plugins:maven-clean-plugin:clean", "test" ) );
+}
+
+public static Stream argumentsForTest()
+{
+return Stream.of(
+arguments( "test-argument", "test-argument" ),
+arguments( "test/${basedir}/test", "test/src/test/resources/test"
),
+arguments( "argument with space", "argument with space" )
+);
+}
+
+@ParameterizedTest
+@MethodSource( "argumentsForTest" )
+void argumentShouldBePassAsIs(String inputArgument, String
expectedArgument) throws VerificationException
Review Comment:
By the way I'm for checkstyle also for test code ... if someone ask me 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-verifier] slawekjaranowski commented on a diff in pull request #41: [MSHARED-1125] Require Maven args to be provided one by one
slawekjaranowski commented on code in PR #41:
URL: https://github.com/apache/maven-verifier/pull/41#discussion_r964087646
##
src/main/java/org/apache/maven/shared/verifier/Verifier.java:
##
@@ -1237,20 +1237,9 @@ public void executeGoals( List goals,
Map envVars )
File logFile = new File( getBasedir(), getLogFileName() );
-for ( Object cliOption : cliOptions )
+for ( String cliOption : cliOptions )
{
-String key = String.valueOf( cliOption );
-
-String resolvedArg = resolveCommandLineArg( key );
-
-try
-{
-args.addAll( Arrays.asList(
CommandLineUtils.translateCommandline( resolvedArg ) ) );
-}
-catch ( Exception e )
-{
-e.printStackTrace();
-}
+args.add( resolveCommandLineArg( cliOption ) );
Review Comment:
greate - it never worked ... line:
```
result = result.replaceAll( "", "\\" );
```
generate exception:
```
java.lang.IllegalArgumentException: character to be escaped is missing
```
to remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-sources] Jesuis33 opened a new pull request, #3: Info
Jesuis33 opened a new pull request, #3: URL: https://github.com/apache/maven-sources/pull/3 C:\ProgramData\Microsoft\Diagnosis\FeedbackArchive -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-sources] michael-o commented on pull request #3: Info
michael-o commented on PR #3: URL: https://github.com/apache/maven-sources/pull/3#issuecomment-1238569044 What is the purpose of this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-sources] Jesuis33 commented on pull request #3: Info
Jesuis33 commented on PR #3: URL: https://github.com/apache/maven-sources/pull/3#issuecomment-1238569365 gh repo clone apache/maven-clean-plugin -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-verifier] michael-o commented on a diff in pull request #41: [MSHARED-1125] Require Maven args to be provided one by one
michael-o commented on code in PR #41:
URL: https://github.com/apache/maven-verifier/pull/41#discussion_r964096799
##
src/test/java/org/apache/maven/shared/verifier/VerifierTest.java:
##
@@ -130,4 +139,74 @@ void testDefaultFilterMap() throws VerificationException
assertTrue( filterMap.containsKey( "@basedir@" ) );
assertTrue( filterMap.containsKey( "@baseurl@" ) );
}
+
+@Test
+void testDefaultMavenArgument() throws VerificationException
+{
+TestVerifier verifier = new TestVerifier( "src/test/resources" );
+
+verifier.executeGoal( "test" );
+
+assertThat( verifier.launcher.cliArgs, arrayContaining(
+"-e", "--batch-mode", "-Dmaven.repo.local=test-local-repo",
+"org.apache.maven.plugins:maven-clean-plugin:clean", "test" ) );
+}
+
+public static Stream argumentsForTest()
+{
+return Stream.of(
+arguments( "test-argument", "test-argument" ),
+arguments( "test/${basedir}/test", "test/src/test/resources/test"
),
+arguments( "argument with space", "argument with space" )
+);
+}
+
+@ParameterizedTest
+@MethodSource( "argumentsForTest" )
+void argumentShouldBePassAsIs(String inputArgument, String
expectedArgument) throws VerificationException
Review Comment:
> By the way I'm for checkstyle also for test code ... if someone ask me 😄
me too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-verifier] michael-o commented on a diff in pull request #41: [MSHARED-1125] Require Maven args to be provided one by one
michael-o commented on code in PR #41:
URL: https://github.com/apache/maven-verifier/pull/41#discussion_r964098369
##
src/main/java/org/apache/maven/shared/verifier/Verifier.java:
##
@@ -1237,20 +1237,9 @@ public void executeGoals( List goals,
Map envVars )
File logFile = new File( getBasedir(), getLogFileName() );
-for ( Object cliOption : cliOptions )
+for ( String cliOption : cliOptions )
{
-String key = String.valueOf( cliOption );
-
-String resolvedArg = resolveCommandLineArg( key );
-
-try
-{
-args.addAll( Arrays.asList(
CommandLineUtils.translateCommandline( resolvedArg ) ) );
-}
-catch ( Exception e )
-{
-e.printStackTrace();
-}
+args.add( resolveCommandLineArg( cliOption ) );
Review Comment:
Honestly, I don't understand the purpose of this at all:
https://github.com/apache/maven-verifier/blob/96c30e3cea783fcbb06963f98754a32148957f1b/src/main/java/org/apache/maven/shared/verifier/Verifier.java#L1418-L1422
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Assigned] (MNG-7046) Revert MNG-5639 and make repo config static only (no ${param} interpolation)
[
https://issues.apache.org/jira/browse/MNG-7046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov reassigned MNG-7046:
---
Assignee: (was: Michael Osipov)
> Revert MNG-5639 and make repo config static only (no ${param} interpolation)
>
>
> Key: MNG-7046
> URL: https://issues.apache.org/jira/browse/MNG-7046
> Project: Maven
> Issue Type: Task
> Components: Artifacts and Repositories, Dependencies
>Affects Versions: 3.6.3
>Reporter: Michael Osipov
>Priority: Major
> Labels: must-be-in-4.0.0-alpha-2
> Fix For: 4.0.0-alpha-2, 4.0.0
>
>
> As discussed in MNG-5639 repositories should always be known upfront, they
> have to be static to avoid chicken and egg situations, a project should not
> influence settings. It should be the way around.
> In subsequent ticket it will be verified that repo configuration does not
> contain any expression:
> https://github.com/apache/maven/commit/d411c3fa98832e7d86d901fe86ff63ba907cf868#commitcomment-44782281.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (MDEPLOY-282) Revert MDEPLOY-231
[ https://issues.apache.org/jira/browse/MDEPLOY-282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MDEPLOY-282: -- Assignee: (was: Michael Osipov) > Revert MDEPLOY-231 > -- > > Key: MDEPLOY-282 > URL: https://issues.apache.org/jira/browse/MDEPLOY-282 > Project: Maven Deploy Plugin > Issue Type: Task >Affects Versions: 3.0.0-M1 >Reporter: Michael Osipov >Priority: Major > > It does not logically make sense to have an IT which verifies the presence of > checksums because MDEPLOY does not generate them. MRESOLVER does that. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-verifier] michael-o commented on a diff in pull request #41: [MSHARED-1125] Require Maven args to be provided one by one
michael-o commented on code in PR #41:
URL: https://github.com/apache/maven-verifier/pull/41#discussion_r964119844
##
src/main/java/org/apache/maven/shared/verifier/Verifier.java:
##
@@ -1237,20 +1237,9 @@ public void executeGoals( List goals,
Map envVars )
File logFile = new File( getBasedir(), getLogFileName() );
-for ( Object cliOption : cliOptions )
+for ( String cliOption : cliOptions )
{
-String key = String.valueOf( cliOption );
-
-String resolvedArg = resolveCommandLineArg( key );
-
-try
-{
-args.addAll( Arrays.asList(
CommandLineUtils.translateCommandline( resolvedArg ) ) );
-}
-catch ( Exception e )
-{
-e.printStackTrace();
-}
+args.add( cliOption.replace( "${basedir}", basedir ) );
Review Comment:
Nice...why not `getBasedir()` like the rest does?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-verifier] michael-o commented on a diff in pull request #41: [MSHARED-1125] Require Maven args to be provided one by one
michael-o commented on code in PR #41:
URL: https://github.com/apache/maven-verifier/pull/41#discussion_r964121264
##
src/main/java/org/apache/maven/shared/verifier/Verifier.java:
##
@@ -1599,11 +1576,28 @@ public void setCliOptions( List cliOptions )
this.cliOptions = cliOptions;
}
+/**
+ * Add a command line argument, each argument must be set separately one
by one.
+ *
+ * ${basedir} in argument will be replaced by value of {@link
#getBasedir()}
Review Comment:
Note that this comment is actually wrong because the value isn't replaced
here, but only at execute.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-verifier] michael-o commented on a diff in pull request #41: [MSHARED-1125] Require Maven args to be provided one by one
michael-o commented on code in PR #41:
URL: https://github.com/apache/maven-verifier/pull/41#discussion_r964121301
##
src/main/java/org/apache/maven/shared/verifier/Verifier.java:
##
@@ -1599,11 +1576,28 @@ public void setCliOptions( List cliOptions )
this.cliOptions = cliOptions;
}
+/**
+ * Add a command line argument, each argument must be set separately one
by one.
+ *
+ * ${basedir} in argument will be replaced by value of {@link
#getBasedir()}
+ * @param option an argument to add
+ */
public void addCliOption( String option )
{
cliOptions.add( option );
}
+/**
+ * Add a command line arguments, each argument must be set separately one
by one.
+ *
+ * ${basedir} in argument will be replaced by value of {@link
#getBasedir()}
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (MSHARED-1128) Deprecate all executeGoal(s) methods
Slawomir Jaranowski created MSHARED-1128:
Summary: Deprecate all executeGoal(s) methods
Key: MSHARED-1128
URL: https://issues.apache.org/jira/browse/MSHARED-1128
Project: Maven Shared Components
Issue Type: Improvement
Components: maven-verifier
Reporter: Slawomir Jaranowski
Methods {{executeGoal(s)}} take as argument Maven goal for executing test.
>From command line executing perspective all of goals are next cli arguments.
So instead of:
{code}
verifier.executeGoal( "package" );
{code}
we can use:
{code}
verifier.addCliOption( "package" );
verifier.execute();
{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MSHARED-1128) Deprecate all executeGoal(s) methods
[
https://issues.apache.org/jira/browse/MSHARED-1128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski updated MSHARED-1128:
-
Fix Version/s: maven-verifier-2.0.0
> Deprecate all executeGoal(s) methods
>
>
> Key: MSHARED-1128
> URL: https://issues.apache.org/jira/browse/MSHARED-1128
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-verifier
>Reporter: Slawomir Jaranowski
>Priority: Major
> Fix For: maven-verifier-2.0.0
>
>
> Methods {{executeGoal(s)}} take as argument Maven goal for executing test.
> From command line executing perspective all of goals are next cli arguments.
> So instead of:
> {code}
> verifier.executeGoal( "package" );
> {code}
> we can use:
> {code}
> verifier.addCliOption( "package" );
> verifier.execute();
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-verifier] slawekjaranowski commented on a diff in pull request #41: [MSHARED-1125] Require Maven args to be provided one by one
slawekjaranowski commented on code in PR #41:
URL: https://github.com/apache/maven-verifier/pull/41#discussion_r964138332
##
src/test/java/org/apache/maven/shared/verifier/VerifierTest.java:
##
@@ -130,4 +139,74 @@ void testDefaultFilterMap() throws VerificationException
assertTrue( filterMap.containsKey( "@basedir@" ) );
assertTrue( filterMap.containsKey( "@baseurl@" ) );
}
+
+@Test
+void testDefaultMavenArgument() throws VerificationException
+{
+TestVerifier verifier = new TestVerifier( "src/test/resources" );
+
+verifier.executeGoal( "test" );
Review Comment:
[MSHARED-1128](https://issues.apache.org/jira/browse/MSHARED-1128)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-javadoc-plugin] michael-o commented on a diff in pull request #159: [MJAVADOC-722] Log javadoc warnings and errors to file
michael-o commented on code in PR #159:
URL:
https://github.com/apache/maven-javadoc-plugin/pull/159#discussion_r964140570
##
src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java:
##
@@ -6879,6 +6892,33 @@ private void writeDebugJavadocScript( String cmdLine,
File javadocOutputDirector
}
}
+/**
+ * Write a files containing the javadoc errors and warnings.
+ *
+ * @param errorsAndWarnings the javadoc errors and warnings as
string, not null.
+ * @param javadocOutputDirectory the output dir, not null.
+ * @since 3.4.2-SNAPSHOT
+ */
+private void writeErrorFile( String errorsAndWarnings, File
javadocOutputDirectory )
+{
+File commandLineFile = new File( javadocOutputDirectory,
ERRORS_FILE_NAME );
+commandLineFile.getParentFile().mkdirs();
+
+try
+{
+FileUtils.fileWrite( commandLineFile.getAbsolutePath(), null /*
platform encoding */, errorsAndWarnings );
+
+if ( !SystemUtils.IS_OS_WINDOWS )
+{
+Runtime.getRuntime().exec( new String[]{ "chmod", "a+x",
commandLineFile.getAbsolutePath() } );
Review Comment:
Why is this necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Comment Edited] (MSHARED-1128) Deprecate all executeGoal(s) methods
[
https://issues.apache.org/jira/browse/MSHARED-1128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17600971#comment-17600971
]
Michael Osipov edited comment on MSHARED-1128 at 9/6/22 8:33 PM:
-
Fantastic, but has one issue. The name {{#addCliOption()}} is now wrong since
everything can be provided. Basically this needs to be {{#addCliArg()}} and
{{{}#addCliArgs(){}}}.
was (Author: michael-o):
Fantastic, but has one issue. The name {{#addCliOption()}} is now wrong since
everything can be provided. Basically this needs to be {{#addCliArg()}} and
{{{}#AddCliArgs(){}}}.
> Deprecate all executeGoal(s) methods
>
>
> Key: MSHARED-1128
> URL: https://issues.apache.org/jira/browse/MSHARED-1128
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-verifier
>Reporter: Slawomir Jaranowski
>Priority: Major
> Fix For: maven-verifier-2.0.0
>
>
> Methods {{executeGoal(s)}} take as argument Maven goal for executing test.
> From command line executing perspective all of goals are next cli arguments.
> So instead of:
> {code}
> verifier.executeGoal( "package" );
> {code}
> we can use:
> {code}
> verifier.addCliOption( "package" );
> verifier.execute();
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSHARED-1128) Deprecate all executeGoal(s) methods
[
https://issues.apache.org/jira/browse/MSHARED-1128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17600971#comment-17600971
]
Michael Osipov commented on MSHARED-1128:
-
Fantastic, but has one issue. The name {{#addCliOption()}} is now wrong since
everything can be provided. Basically this needs to be {{#addCliArg()}} and
{{{}#AddCliArgs(){}}}.
> Deprecate all executeGoal(s) methods
>
>
> Key: MSHARED-1128
> URL: https://issues.apache.org/jira/browse/MSHARED-1128
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-verifier
>Reporter: Slawomir Jaranowski
>Priority: Major
> Fix For: maven-verifier-2.0.0
>
>
> Methods {{executeGoal(s)}} take as argument Maven goal for executing test.
> From command line executing perspective all of goals are next cli arguments.
> So instead of:
> {code}
> verifier.executeGoal( "package" );
> {code}
> we can use:
> {code}
> verifier.addCliOption( "package" );
> verifier.execute();
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-javadoc-plugin] alzimmermsft commented on a diff in pull request #159: [MJAVADOC-722] Log javadoc warnings and errors to file
alzimmermsft commented on code in PR #159:
URL:
https://github.com/apache/maven-javadoc-plugin/pull/159#discussion_r964153349
##
src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java:
##
@@ -6879,6 +6892,33 @@ private void writeDebugJavadocScript( String cmdLine,
File javadocOutputDirector
}
}
+/**
+ * Write a files containing the javadoc errors and warnings.
+ *
+ * @param errorsAndWarnings the javadoc errors and warnings as
string, not null.
+ * @param javadocOutputDirectory the output dir, not null.
+ * @since 3.4.2-SNAPSHOT
+ */
+private void writeErrorFile( String errorsAndWarnings, File
javadocOutputDirectory )
+{
+File commandLineFile = new File( javadocOutputDirectory,
ERRORS_FILE_NAME );
+commandLineFile.getParentFile().mkdirs();
+
+try
+{
+FileUtils.fileWrite( commandLineFile.getAbsolutePath(), null /*
platform encoding */, errorsAndWarnings );
+
+if ( !SystemUtils.IS_OS_WINDOWS )
+{
+Runtime.getRuntime().exec( new String[]{ "chmod", "a+x",
commandLineFile.getAbsolutePath() } );
Review Comment:
Good point, I was following this pattern found elsewhere in the file:
https://github.com/apache/maven-javadoc-plugin/blob/master/src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java#L6925
But after taking a second look at it it's meant to be an executable file.
I'll remove this entire if block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-javadoc-plugin] michael-o commented on a diff in pull request #159: [MJAVADOC-722] Log javadoc warnings and errors to file
michael-o commented on code in PR #159:
URL:
https://github.com/apache/maven-javadoc-plugin/pull/159#discussion_r964160516
##
src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java:
##
@@ -6879,6 +6892,33 @@ private void writeDebugJavadocScript( String cmdLine,
File javadocOutputDirector
}
}
+/**
+ * Write a files containing the javadoc errors and warnings.
+ *
+ * @param errorsAndWarnings the javadoc errors and warnings as
string, not null.
+ * @param javadocOutputDirectory the output dir, not null.
+ * @since 3.4.2-SNAPSHOT
+ */
+private void writeErrorFile( String errorsAndWarnings, File
javadocOutputDirectory )
+{
+File commandLineFile = new File( javadocOutputDirectory,
ERRORS_FILE_NAME );
+commandLineFile.getParentFile().mkdirs();
+
+try
+{
+FileUtils.fileWrite( commandLineFile.getAbsolutePath(), null /*
platform encoding */, errorsAndWarnings );
+
+if ( !SystemUtils.IS_OS_WINDOWS )
+{
+Runtime.getRuntime().exec( new String[]{ "chmod", "a+x",
commandLineFile.getAbsolutePath() } );
Review Comment:
The file referenced is a script, totally unrelated to this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #790: [MNG-7502] Upgrade to Guice 5.1.0
michael-o commented on PR #790: URL: https://github.com/apache/maven/pull/790#issuecomment-1238646659 Why to 3.9.x first? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7502) Upgrade Guice to 5.1.0
[
https://issues.apache.org/jira/browse/MNG-7502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17600988#comment-17600988
]
ASF GitHub Bot commented on MNG-7502:
-
michael-o commented on PR #790:
URL: https://github.com/apache/maven/pull/790#issuecomment-1238646659
Why to 3.9.x first?
> Upgrade Guice to 5.1.0
> --
>
> Key: MNG-7502
> URL: https://issues.apache.org/jira/browse/MNG-7502
> Project: Maven
> Issue Type: Dependency upgrade
>Reporter: Sylwester Lachiewicz
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Fix For: 3.9.0-candidate, 4.0.x-candidate
>
>
> h3. Release notes:
> https://github.com/google/guice/wiki/Guice510
> https://github.com/google/guice/wiki/Guice501
>
> * Java 17 support: updated asm version and fixed unsafe class defining to
> work with Java 17.
> * Removed cglib as a core dependency. Guice now uses ASM directly to
> generate bytecode at runtime for invoking user code and supporting method
> interception
> * Improved error messages
> ** package names in error messages are compressed to make it easier to read
> ** errors with the same cause are grouped and reported together
> ** common error now links to a wiki page on how to debug and fix the error
> ** additional information like parameter names are included when code are
> compiled with javac {{-parameters}} flag
> ** rich formatting like bold, color are used when errors are displayed in a
> supported console (can be disabled with
> {{-Dguice_colorize_error_messages=DISABLED}} flag)
> * Removed no-aop build variant.
> * Updated the Guava and ASM versions
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] slachiewicz commented on pull request #790: [MNG-7502] Upgrade to Guice 5.1.0
slachiewicz commented on PR #790: URL: https://github.com/apache/maven/pull/790#issuecomment-1238648290 what else do you suggest? 3.8? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7502) Upgrade Guice to 5.1.0
[
https://issues.apache.org/jira/browse/MNG-7502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17600990#comment-17600990
]
ASF GitHub Bot commented on MNG-7502:
-
slachiewicz commented on PR #790:
URL: https://github.com/apache/maven/pull/790#issuecomment-1238648290
what else do you suggest? 3.8?
> Upgrade Guice to 5.1.0
> --
>
> Key: MNG-7502
> URL: https://issues.apache.org/jira/browse/MNG-7502
> Project: Maven
> Issue Type: Dependency upgrade
>Reporter: Sylwester Lachiewicz
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Fix For: 3.9.0-candidate, 4.0.x-candidate
>
>
> h3. Release notes:
> https://github.com/google/guice/wiki/Guice510
> https://github.com/google/guice/wiki/Guice501
>
> * Java 17 support: updated asm version and fixed unsafe class defining to
> work with Java 17.
> * Removed cglib as a core dependency. Guice now uses ASM directly to
> generate bytecode at runtime for invoking user code and supporting method
> interception
> * Improved error messages
> ** package names in error messages are compressed to make it easier to read
> ** errors with the same cause are grouped and reported together
> ** common error now links to a wiki page on how to debug and fix the error
> ** additional information like parameter names are included when code are
> compiled with javac {{-parameters}} flag
> ** rich formatting like bold, color are used when errors are displayed in a
> supported console (can be disabled with
> {{-Dguice_colorize_error_messages=DISABLED}} flag)
> * Removed no-aop build variant.
> * Updated the Guava and ASM versions
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] michael-o commented on pull request #790: [MNG-7502] Upgrade to Guice 5.1.0
michael-o commented on PR #790: URL: https://github.com/apache/maven/pull/790#issuecomment-1238654609 I would expect master first and then go over to 3.9.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7502) Upgrade Guice to 5.1.0
[
https://issues.apache.org/jira/browse/MNG-7502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17600999#comment-17600999
]
ASF GitHub Bot commented on MNG-7502:
-
michael-o commented on PR #790:
URL: https://github.com/apache/maven/pull/790#issuecomment-1238654609
I would expect master first and then go over to 3.9.0.
> Upgrade Guice to 5.1.0
> --
>
> Key: MNG-7502
> URL: https://issues.apache.org/jira/browse/MNG-7502
> Project: Maven
> Issue Type: Dependency upgrade
>Reporter: Sylwester Lachiewicz
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Fix For: 3.9.0-candidate, 4.0.x-candidate
>
>
> h3. Release notes:
> https://github.com/google/guice/wiki/Guice510
> https://github.com/google/guice/wiki/Guice501
>
> * Java 17 support: updated asm version and fixed unsafe class defining to
> work with Java 17.
> * Removed cglib as a core dependency. Guice now uses ASM directly to
> generate bytecode at runtime for invoking user code and supporting method
> interception
> * Improved error messages
> ** package names in error messages are compressed to make it easier to read
> ** errors with the same cause are grouped and reported together
> ** common error now links to a wiki page on how to debug and fix the error
> ** additional information like parameter names are included when code are
> compiled with javac {{-parameters}} flag
> ** rich formatting like bold, color are used when errors are displayed in a
> supported console (can be disabled with
> {{-Dguice_colorize_error_messages=DISABLED}} flag)
> * Removed no-aop build variant.
> * Updated the Guava and ASM versions
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-javadoc-plugin] alzimmermsft commented on a diff in pull request #159: [MJAVADOC-722] Log javadoc warnings and errors to file
alzimmermsft commented on code in PR #159:
URL:
https://github.com/apache/maven-javadoc-plugin/pull/159#discussion_r964177173
##
src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java:
##
@@ -6879,6 +6892,33 @@ private void writeDebugJavadocScript( String cmdLine,
File javadocOutputDirector
}
}
+/**
+ * Write a files containing the javadoc errors and warnings.
+ *
+ * @param errorsAndWarnings the javadoc errors and warnings as
string, not null.
+ * @param javadocOutputDirectory the output dir, not null.
+ * @since 3.4.2-SNAPSHOT
+ */
+private void writeErrorFile( String errorsAndWarnings, File
javadocOutputDirectory )
+{
+File commandLineFile = new File( javadocOutputDirectory,
ERRORS_FILE_NAME );
+commandLineFile.getParentFile().mkdirs();
+
+try
+{
+FileUtils.fileWrite( commandLineFile.getAbsolutePath(), null /*
platform encoding */, errorsAndWarnings );
+
+if ( !SystemUtils.IS_OS_WINDOWS )
+{
+Runtime.getRuntime().exec( new String[]{ "chmod", "a+x",
commandLineFile.getAbsolutePath() } );
Review Comment:
Yeah, now this simply just does file writing with no modifications to the
permissions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (MSHARED-1129) Replace CLI options with CLI args
Michael Osipov created MSHARED-1129:
---
Summary: Replace CLI options with CLI args
Key: MSHARED-1129
URL: https://issues.apache.org/jira/browse/MSHARED-1129
Project: Maven Shared Components
Issue Type: Improvement
Components: maven-verifier
Reporter: Michael Osipov
Fix For: maven-verifier-2.0.0
As it turns out now, any type of arguments are passed, not just options or
goals. Therefore, everything which is {{cliOptions}} needs to be renamed to
{{cliArgs}} otherwise the naming is misleading.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-verifier] michael-o commented on pull request #41: [MSHARED-1125] Require Maven args to be provided one by one
michael-o commented on PR #41: URL: https://github.com/apache/maven-verifier/pull/41#issuecomment-1238926625 @slawekjaranowski FYI: https://issues.apache.org/jira/browse/MSHARED-1129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MSHARED-1129) Replace CLI options with CLI args
[
https://issues.apache.org/jira/browse/MSHARED-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MSHARED-1129:
Description: As it turns out now, any type of arguments are passed, not
just options or goals. Therefore, everything which is {{cliOptions}} needs to
be renamed to {{cliArgs}} otherwise the naming is misleading. There is not
logical change, just renaming. (was: As it turns out now, any type of
arguments are passed, not just options or goals. Therefore, everything which is
{{cliOptions}} needs to be renamed to {{cliArgs}} otherwise the naming is
misleading.)
> Replace CLI options with CLI args
> -
>
> Key: MSHARED-1129
> URL: https://issues.apache.org/jira/browse/MSHARED-1129
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-verifier
>Reporter: Michael Osipov
>Priority: Major
> Fix For: maven-verifier-2.0.0
>
>
> As it turns out now, any type of arguments are passed, not just options or
> goals. Therefore, everything which is {{cliOptions}} needs to be renamed to
> {{cliArgs}} otherwise the naming is misleading. There is not logical change,
> just renaming.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-verifier] slawekjaranowski merged pull request #41: [MSHARED-1125] Require Maven args to be provided one by one
slawekjaranowski merged PR #41: URL: https://github.com/apache/maven-verifier/pull/41 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSHARED-1125) Require Maven args to be provided one by one
[ https://issues.apache.org/jira/browse/MSHARED-1125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601143#comment-17601143 ] Hudson commented on MSHARED-1125: - Build succeeded in Jenkins: Maven » Maven TLP » maven-verifier » master #35 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-verifier/job/master/35/ > Require Maven args to be provided one by one > > > Key: MSHARED-1125 > URL: https://issues.apache.org/jira/browse/MSHARED-1125 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-verifier >Reporter: Michael Osipov >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: maven-verifier-2.0.0 > > > For the next major we shall require user configuration to provide each > argument passed to Maven to be separate. This will avoid edge cases and > remove the requirement to pipe this through faulty/incomplete CLI parse > Maven/Plexus Shared Utils. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MSHARED-1125) Require Maven args to be provided one by one
[ https://issues.apache.org/jira/browse/MSHARED-1125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MSHARED-1125. Resolution: Fixed > Require Maven args to be provided one by one > > > Key: MSHARED-1125 > URL: https://issues.apache.org/jira/browse/MSHARED-1125 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-verifier >Reporter: Michael Osipov >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: maven-verifier-2.0.0 > > > For the next major we shall require user configuration to provide each > argument passed to Maven to be separate. This will avoid edge cases and > remove the requirement to pipe this through faulty/incomplete CLI parse > Maven/Plexus Shared Utils. -- This message was sent by Atlassian Jira (v8.20.10#820010)
