Re: [PR] Merge PostingsEnum and ImpactsEnum. [lucene]
github-actions[bot] commented on PR #14716: URL: https://github.com/apache/lucene/pull/14716#issuecomment-2929379478 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog-check label to it and you will stop receiving this reminder on future updates to the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Merge PostingsEnum and ImpactsEnum. [lucene]
jpountz commented on code in PR #14716:
URL: https://github.com/apache/lucene/pull/14716#discussion_r2120387948
##
lucene/core/src/java/org/apache/lucene/index/PostingsEnum.java:
##
@@ -63,6 +87,12 @@ public abstract class PostingsEnum extends DocIdSetIterator {
*/
public static final short ALL = OFFSETS | PAYLOADS;
+ /**
+ * Flag to pass to {@link TermsEnum#postings(PostingsEnum, int)} to get
impacts in the returned
+ * enum.
+ */
+ public static final short IMPACTS = FREQS | 1 << 7;
Review Comment:
After a few iterations on wikibigall, it seems to work fine with the current
codec. However it looks challenging to apply correctly to old codecs, which use
a different PostingsEnum impl when impacts are requested, and that I'd like to
avoid touching too much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Merge PostingsEnum and ImpactsEnum. [lucene]
jpountz commented on code in PR #14716:
URL: https://github.com/apache/lucene/pull/14716#discussion_r2120389716
##
lucene/core/src/java/org/apache/lucene/index/PostingsEnum.java:
##
@@ -63,6 +87,12 @@ public abstract class PostingsEnum extends DocIdSetIterator {
*/
public static final short ALL = OFFSETS | PAYLOADS;
+ /**
+ * Flag to pass to {@link TermsEnum#postings(PostingsEnum, int)} to get
impacts in the returned
+ * enum.
+ */
+ public static final short IMPACTS = FREQS | 1 << 7;
Review Comment:
I imagine that having a flag also has some benefits, e.g. some impls could
decide to store impacts in a separate file in the future and only open this
file if impacts are requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [I] Does LRUQueryCache#uniqueQueries really needs wrapped by Collections.synchronizedMap? [lucene]
benwtrent commented on issue #14677: URL: https://github.com/apache/lucene/issues/14677#issuecomment-2930565960 @vsop-479 @jpountz maybe my understanding of how LinkedHashMaps work is wrong. But: https://github.com/apache/lucene/pull/13306#discussion_r1578328936 It seems to me that if multiple readers call `get` on `LinkedHashMap` the order will get messed up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Dynamic pruning with DocValueSkipper [lucene]
martijnvg commented on code in PR #14672:
URL: https://github.com/apache/lucene/pull/14672#discussion_r2121019535
##
lucene/core/src/java/org/apache/lucene/search/comparators/NumericComparator.java:
##
@@ -328,120 +507,47 @@ private void updateSkipInterval(boolean success) {
}
}
}
+ }
-/**
- * If {@link NumericComparator#pruning} equals {@link
Pruning#GREATER_THAN_OR_EQUAL_TO}, we
- * could better tune the {@link
NumericLeafComparator#maxValueAsLong}/{@link
- * NumericLeafComparator#minValueAsLong}. For instance, if the sort is
ascending and bottom
- * value is 5, we will use a range on [MIN_VALUE, 4].
- */
-private void encodeBottom() {
- if (reverse == false) {
-maxValueAsLong = bottomAsComparableLong();
-if (pruning == Pruning.GREATER_THAN_OR_EQUAL_TO && maxValueAsLong !=
Long.MIN_VALUE) {
- maxValueAsLong--;
-}
- } else {
-minValueAsLong = bottomAsComparableLong();
-if (pruning == Pruning.GREATER_THAN_OR_EQUAL_TO && minValueAsLong !=
Long.MAX_VALUE) {
- minValueAsLong++;
-}
- }
-}
-
-/**
- * If {@link NumericComparator#pruning} equals {@link
Pruning#GREATER_THAN_OR_EQUAL_TO}, we
- * could better tune the {@link
NumericLeafComparator#minValueAsLong}/{@link
- * NumericLeafComparator#minValueAsLong}. For instance, if the sort is
ascending and top value
- * is 3, we will use a range on [4, MAX_VALUE].
- */
-private void encodeTop() {
- if (reverse == false) {
-minValueAsLong = topAsComparableLong();
-if (singleSort
-&& pruning == Pruning.GREATER_THAN_OR_EQUAL_TO
-&& queueFull
-&& minValueAsLong != Long.MAX_VALUE) {
- minValueAsLong++;
-}
- } else {
-maxValueAsLong = topAsComparableLong();
-if (singleSort
-&& pruning == Pruning.GREATER_THAN_OR_EQUAL_TO
-&& queueFull
-&& maxValueAsLong != Long.MIN_VALUE) {
- maxValueAsLong--;
-}
- }
-}
+ private class DVSkipperCompetitiveDISIBuilder extends CompetitiveDISIBuilder
{
-private boolean isMissingValueCompetitive() {
- // if queue is full, compare with bottom first,
- // if competitive, then check if we can compare with topValue
- if (queueFull) {
-int result = Long.compare(missingValueAsLong,
bottomAsComparableLong());
-// in reverse (desc) sort missingValue is competitive when it's
greater or equal to bottom,
-// in asc sort missingValue is competitive when it's smaller or equal
to bottom
-final boolean competitive =
-reverse
-? (pruning == Pruning.GREATER_THAN_OR_EQUAL_TO ? result > 0 :
result >= 0)
-: (pruning == Pruning.GREATER_THAN_OR_EQUAL_TO ? result < 0 :
result <= 0);
-if (competitive == false) {
- return false;
-}
- }
+private final DocValuesSkipper skipper;
+private final TwoPhaseIterator innerTwoPhase;
- if (leafTopSet) {
-int result = Long.compare(missingValueAsLong, topAsComparableLong());
-// in reverse (desc) sort missingValue is competitive when it's
smaller or equal to
-// topValue,
-// in asc sort missingValue is competitive when it's greater or equal
to topValue
-return reverse ? (result <= 0) : (result >= 0);
- }
+public DVSkipperCompetitiveDISIBuilder(
+DocValuesSkipper skipper, NumericLeafComparator leafComparator) throws
IOException {
+ super(leafComparator);
+ this.skipper = skipper;
+ NumericDocValues docValues =
+ leafComparator.getNumericDocValues(leafComparator.context, field);
+ innerTwoPhase =
+ new TwoPhaseIterator(docValues) {
+@Override
+public boolean matches() throws IOException {
+ final long value = docValues.longValue();
+ return value >= minValueAsLong && value <= maxValueAsLong;
+}
- // by default competitive
- return true;
+@Override
+public float matchCost() {
+ return 2; // 2 comparisons
+}
+ };
}
@Override
-public DocIdSetIterator competitiveIterator() {
- if (enableSkipping == false) return null;
- return new AbstractDocIdSetIterator() {
-
-{
- doc = competitiveIterator.docID();
-}
-
-@Override
-public int nextDoc() throws IOException {
- return advance(doc + 1);
-}
-
-@Override
-public long cost() {
- return competitiveIterator.cost();
-}
-
-@Override
-public int advance(int target) throws IOException {
- return doc = competitiveIterator.advance(target);
-}
-
-@Override
-public void intoBitSet(int upTo, FixedBitSet bitSet, int offset)
thr
Re: [I] Can we support vectors to be loaded with direct I/O for full precision re-ranking? [lucene]
jpountz commented on issue #14746: URL: https://github.com/apache/lucene/issues/14746#issuecomment-2930378258 This was the reasoning behind the introduction of `ReadAdvice.RANDOM`. By telling the operating system that the file has a random access pattern, it should be able to optimize for this access pattern, e.g. skipping the page cache if it doesn't seem to help. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [I] Does LRUQueryCache#uniqueQueries really needs wrapped by Collections.synchronizedMap? [lucene]
jpountz commented on issue #14677: URL: https://github.com/apache/lucene/issues/14677#issuecomment-2930396347 It looks like you are right, we could remove the wrapper. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Merge PostingsEnum and ImpactsEnum. [lucene]
gf2121 commented on code in PR #14716:
URL: https://github.com/apache/lucene/pull/14716#discussion_r2121634772
##
lucene/core/src/java/org/apache/lucene/index/PostingsEnum.java:
##
@@ -63,6 +87,12 @@ public abstract class PostingsEnum extends DocIdSetIterator {
*/
public static final short ALL = OFFSETS | PAYLOADS;
+ /**
+ * Flag to pass to {@link TermsEnum#postings(PostingsEnum, int)} to get
impacts in the returned
+ * enum.
+ */
+ public static final short IMPACTS = FREQS | 1 << 7;
Review Comment:
Thanks for trying!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Merge DocAndFreqBuffer and DocAndScoreBuffer. [lucene]
romseygeek commented on code in PR #14748:
URL: https://github.com/apache/lucene/pull/14748#discussion_r2121218882
##
lucene/core/src/java/org/apache/lucene/search/DocAndFloatFeatureBuffer.java:
##
@@ -21,29 +21,32 @@
import org.apache.lucene.util.IntsRef;
/**
- * Wrapper around parallel arrays storing doc IDs and their corresponding
frequencies.
+ * Wrapper around parallel arrays storing doc IDs and their corresponding
features, stored as Java
+ * floats. These features may be anything, but are typically a term frequency
or a score.
*
* @lucene.internal
*/
-public final class DocAndFreqBuffer {
+public final class DocAndFloatFeatureBuffer {
+
+ private static final float[] EMPTY_FLOATS = new float[0];
/** Doc IDs */
public int[] docs = IntsRef.EMPTY_INTS;
- /** Frequencies */
- public int[] freqs = IntsRef.EMPTY_INTS;
+ /** Scores */
Review Comment:
```suggestion
/** Float-valued features */
```
##
lucene/core/src/java/org/apache/lucene/search/DocAndFloatFeatureBuffer.java:
##
@@ -21,29 +21,32 @@
import org.apache.lucene.util.IntsRef;
/**
- * Wrapper around parallel arrays storing doc IDs and their corresponding
frequencies.
+ * Wrapper around parallel arrays storing doc IDs and their corresponding
features, stored as Java
+ * floats. These features may be anything, but are typically a term frequency
or a score.
*
* @lucene.internal
*/
-public final class DocAndFreqBuffer {
+public final class DocAndFloatFeatureBuffer {
+
+ private static final float[] EMPTY_FLOATS = new float[0];
/** Doc IDs */
public int[] docs = IntsRef.EMPTY_INTS;
- /** Frequencies */
- public int[] freqs = IntsRef.EMPTY_INTS;
+ /** Scores */
+ public float[] features = EMPTY_FLOATS;
- /** Number of valid entries in the doc ID and frequency arrays. */
+ /** Number of valid entries in the doc ID and score arrays. */
Review Comment:
```suggestion
/** Number of valid entries in the doc ID and float-valued feature arrays.
*/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Merge PostingsEnum and ImpactsEnum. [lucene]
jpountz commented on code in PR #14716:
URL: https://github.com/apache/lucene/pull/14716#discussion_r2120355953
##
lucene/core/src/java/org/apache/lucene/index/TermsEnum.java:
##
@@ -170,11 +170,15 @@ public final PostingsEnum postings(PostingsEnum reuse)
throws IOException {
public abstract PostingsEnum postings(PostingsEnum reuse, int flags) throws
IOException;
/**
- * Return a {@link ImpactsEnum}.
+ * Return a {@link PostingsEnum} that exposes impacts.
*
* @see #postings(PostingsEnum, int)
+ * @deprecated Use {@link #postings(PostingsEnum)} with {@link
PostingsEnum#IMPACTS}
*/
- public abstract ImpactsEnum impacts(int flags) throws IOException;
+ @Deprecated
Review Comment:
Yes! I was hoping to remove in a subsequent PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Merge PostingsEnum and ImpactsEnum. [lucene]
jpountz commented on code in PR #14716:
URL: https://github.com/apache/lucene/pull/14716#discussion_r2120356527
##
lucene/core/src/java/org/apache/lucene/index/PostingsEnum.java:
##
@@ -63,6 +87,12 @@ public abstract class PostingsEnum extends DocIdSetIterator {
*/
public static final short ALL = OFFSETS | PAYLOADS;
+ /**
+ * Flag to pass to {@link TermsEnum#postings(PostingsEnum, int)} to get
impacts in the returned
+ * enum.
+ */
+ public static final short IMPACTS = FREQS | 1 << 7;
Review Comment:
Interesting idea. Let me check the performance impact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Merge CombinedFieldQuery's WeightedDisiWrapper into DisiWrapper. [lucene]
github-actions[bot] commented on PR #14747: URL: https://github.com/apache/lucene/pull/14747#issuecomment-2929530021 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog-check label to it and you will stop receiving this reminder on future updates to the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[PR] Merge DocAndFreqBuffer and DocAndScoreBuffer. [lucene]
jpountz opened a new pull request, #14748: URL: https://github.com/apache/lucene/pull/14748 I initially kept those separated but I'm now coming to the conclusion that they should be merged: - While frequencies are ints today, some queries produce float frequencies (`SloppyPhraseQuery`, `CombinedFieldQuery`). - `TermScorer` no longer needs to keep track of a separate buffer for frequencies. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [I] Potential resource leakage in WordDictionary#loadMainDataFromFile [lucene]
jpountz closed issue #14719: Potential resource leakage in WordDictionary#loadMainDataFromFile URL: https://github.com/apache/lucene/issues/14719 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [I] Potential resource leakage in WordDictionary#loadMainDataFromFile [lucene]
jpountz commented on issue #14719: URL: https://github.com/apache/lucene/issues/14719#issuecomment-2930382910 Fixed via #14727 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[PR] Merge CombinedFieldQuery's WeightedDisiWrapper into DisiWrapper. [lucene]
jpountz opened a new pull request, #14747: URL: https://github.com/apache/lucene/pull/14747 This aims at simplifying things a bit to make it easier to implement `CombinedFieldScorer#nextDocsAndScores` later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [I] Does LRUQueryCache#uniqueQueries really needs wrapped by Collections.synchronizedMap? [lucene]
jpountz commented on issue #14677: URL: https://github.com/apache/lucene/issues/14677#issuecomment-2931141062 Argh, of-couse, thank you @benwtrent! I opened a PR so that it's more obvious to readers of this code in the future: #14749. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[PR] Add code comment about use of Collections#synchronizedMap in LRUQueryCache. [lucene]
jpountz opened a new pull request, #14749: URL: https://github.com/apache/lucene/pull/14749 It may not be totally obvious why this map needs to be synchronized since reads and writes are performed under a read-write lock. Except that unlike most other collections, reads are not thread-safe on a `LinkedHashMap`. Closes #14677 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[PR] Add MathUtil#unsignedMin to simplify dividing the doc ID space into windows. [lucene]
jpountz opened a new pull request, #14750: URL: https://github.com/apache/lucene/pull/14750 We often need to divide the doc ID space into sub windows, but this is prone to integer overflows if the size of the window is greater than `Integer.MAX_VALUE - windowStart`. This adds `MathUtil#unsignedMin` to make these overflows a bit easier to manage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Keep evaluating conjunction one doc-at-a-time until dynamic pruning kicks in. [lucene]
jpountz merged PR #14739: URL: https://github.com/apache/lucene/pull/14739 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [I] Does LRUQueryCache#uniqueQueries really needs wrapped by Collections.synchronizedMap? [lucene]
vsop-479 closed issue #14677: Does LRUQueryCache#uniqueQueries really needs wrapped by Collections.synchronizedMap? URL: https://github.com/apache/lucene/issues/14677 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [I] Does LRUQueryCache#uniqueQueries really needs wrapped by Collections.synchronizedMap? [lucene]
vsop-479 commented on issue #14677: URL: https://github.com/apache/lucene/issues/14677#issuecomment-2933056790 Oh, You are right @benwtrent ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Add code comment about use of Collections#synchronizedMap in LRUQueryCache. [lucene]
vsop-479 commented on PR #14749: URL: https://github.com/apache/lucene/pull/14749#issuecomment-2933058801 Thanks @jpountz ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Merge CombinedFieldQuery's WeightedDisiWrapper into DisiWrapper. [lucene]
jpountz merged PR #14747: URL: https://github.com/apache/lucene/pull/14747 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Add code comment about use of Collections#synchronizedMap in LRUQueryCache. [lucene]
jpountz merged PR #14749: URL: https://github.com/apache/lucene/pull/14749 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Merge DocAndFreqBuffer and DocAndScoreBuffer. [lucene]
jpountz merged PR #14748: URL: https://github.com/apache/lucene/pull/14748 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
