Re: [PR] deps(java): bump com.google.errorprone:error_prone_core from 2.36.0 to 2.38.0 [lucene]
rmuir merged PR #14589: URL: https://github.com/apache/lucene/pull/14589 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Overwrite gradlew scripts with up-to-date ones and apply Lucene customizations [lucene]
dweiss merged PR #14592: URL: https://github.com/apache/lucene/pull/14592 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Upgrade to gradle 8.14 on branch_10x (backport). [lucene]
dweiss merged PR #14591: URL: https://github.com/apache/lucene/pull/14591 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Remove RANDOM_PRELOAD read advice, which is not actually used [lucene]
thecoop commented on code in PR #14593:
URL: https://github.com/apache/lucene/pull/14593#discussion_r2068324330
##
lucene/core/src/java/org/apache/lucene/store/PosixNativeAccess.java:
##
@@ -157,7 +157,6 @@ private int mapReadAdvice(ReadAdvice readAdvice) {
case NORMAL -> POSIX_MADV_NORMAL;
case RANDOM -> POSIX_MADV_RANDOM;
case SEQUENTIAL -> POSIX_MADV_SEQUENTIAL;
- case RANDOM_PRELOAD -> POSIX_MADV_NORMAL;
Review Comment:
It just results in the same madvice as NORMAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Remove abstractions of MMapDirectory and its "fake" MR-JAR support and move it to main sourceSet (vectors untouched) [lucene]
uschindler merged PR #14564: URL: https://github.com/apache/lucene/pull/14564 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Remove abstractions of MMapDirectory and its "fake" MR-JAR support and move it to main sourceSet (vectors untouched) [lucene]
uschindler commented on PR #14564: URL: https://github.com/apache/lucene/pull/14564#issuecomment-2841210449 @thecoop, I renamed the `readAdvice` field in this branch in `MMapDirectory` to `readAdviceOverride` because the old name is confusing when reading the code. It may be adviseable to backport this name change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Remove abstractions of MMapDirectory and its "fake" MR-JAR support and move it to main sourceSet (vectors untouched) [lucene]
thecoop commented on PR #14564: URL: https://github.com/apache/lucene/pull/14564#issuecomment-2841174064 The changes around `ReadAdvice` look ok to me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[PR] add comments around how dependencies are used [lucene]
rmuir opened a new pull request, #14594: URL: https://github.com/apache/lucene/pull/14594 Add one-liner above comments giving a hint how the dependency is used. This can help make the dependencies easier to maintain: it points you in the right direction and will be shown in dependabot diffs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] add comments around how dependencies are used [lucene]
rmuir merged PR #14594: URL: https://github.com/apache/lucene/pull/14594 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Change uses of withReadAdvice to use hints instead [lucene]
thecoop commented on code in PR #14510:
URL: https://github.com/apache/lucene/pull/14510#discussion_r2068657900
##
lucene/core/src/java/org/apache/lucene/store/MemorySegmentIndexInput.java:
##
@@ -70,14 +72,15 @@ public static MemorySegmentIndexInput newInstance(
MemorySegment[] segments,
long length,
int chunkSizePower,
- boolean confined) {
+ boolean confined,
+ Function toReadAdvice) {
Review Comment:
A `Function` representing the mapping keeps the IOContext -> ReadAdvice
entirely within `MMapDirectory`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Change uses of withReadAdvice to use hints instead [lucene]
thecoop commented on code in PR #14510:
URL: https://github.com/apache/lucene/pull/14510#discussion_r2068656440
##
lucene/test-framework/src/java/org/apache/lucene/tests/store/SerialIOCountingDirectory.java:
##
@@ -72,7 +72,7 @@ public ChecksumIndexInput openChecksumInput(String name)
throws IOException {
@Override
public IndexInput openInput(String name, IOContext context) throws
IOException {
-ReadAdvice readAdvice =
context.readAdvice().orElse(Constants.DEFAULT_READADVICE);
+ReadAdvice readAdvice = MMapDirectory.toReadAdvice(context);
Review Comment:
This is not great - SerialIOCountingDirectory needs to know about the
specific ReadAdvice to record the reads the OS *should* make with that
ReadAdvice. But,
https://github.com/apache/lucene/pull/14593#issuecomment-2841419541, do we
actually need these tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Change uses of withReadAdvice to use hints instead [lucene]
thecoop commented on code in PR #14510:
URL: https://github.com/apache/lucene/pull/14510#discussion_r2068657900
##
lucene/core/src/java/org/apache/lucene/store/MemorySegmentIndexInput.java:
##
@@ -70,14 +72,15 @@ public static MemorySegmentIndexInput newInstance(
MemorySegment[] segments,
long length,
int chunkSizePower,
- boolean confined) {
+ boolean confined,
+ Function toReadAdvice) {
Review Comment:
A `Function` representing the mapping keeps the IOContext -> ReadAdvice
mapping entirely within `MMapDirectory`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] deps(java): bump org.apache.rat:apache-rat from 0.14 to 0.16.1 [lucene]
dweiss commented on PR #14582: URL: https://github.com/apache/lucene/pull/14582#issuecomment-2841156503 Seems like tons of api changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] deps(java): bump org.gradle.toolchains.foojay-resolver-convention from 0.8.0 to 0.10.0 [lucene]
dweiss merged PR #14573: URL: https://github.com/apache/lucene/pull/14573 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Remove abstractions of MMapDirectory and its "fake" MR-JAR support and move it to main sourceSet (vectors untouched) [lucene]
uschindler commented on PR #14564: URL: https://github.com/apache/lucene/pull/14564#issuecomment-2841192482 Thanks @thecoop. About the other PR: It was only for main branch, right? So it won't be backported, so all changes to readAdvice will be a feature for Lucene 11. To me those changes look to invasive for a minor release. I am just asking this because due to the changes here merging of MemorySegmentIndexInput and Native access code will be more complicated du to the new location of files and removed abstractions. If the code is only developed for main branch it's not a problem. I would hope that Directory and MMapDirectoy are in "feature freeze" for 10.x. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[PR] Upgrade to gradle 8.14 on branch_10x (backport). [lucene]
dweiss opened a new pull request, #14591: URL: https://github.com/apache/lucene/pull/14591 This is a limited backport of #14533 bumping gradle to v8.14. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Upgrade to Gradle 8.14 and Java 24 minimum [lucene]
dweiss commented on PR #14533: URL: https://github.com/apache/lucene/pull/14533#issuecomment-2841274438 > I think we need to change the gradlew / gradlew.cmd files to pass the additional command line option `--enable-native-access=ALL-UNNAMED` gradle is now launched with --jar and contains a manifest entry for this (no need to tweak the scripts). Should be fine with #14592 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Remove abstractions of MMapDirectory and its "fake" MR-JAR support and move it to main sourceSet (vectors untouched) [lucene]
uschindler commented on PR #14564: URL: https://github.com/apache/lucene/pull/14564#issuecomment-2841091940 Damn: "Create file open hints on IOContext to replace ReadAdvice (https://github.com/apache/lucene/pull/14482)" was merged yesterday. Trying to figure out what's going on. @thecoop -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] deps(java): bump io.sgr:s2-geometry-library-java from 1.0.0 to 1.0.1 [lucene]
dweiss commented on PR #14575: URL: https://github.com/apache/lucene/pull/14575#issuecomment-2841138221 I think this dependency should be replaced with google's official release - https://github.com/google/s2-geometry-library-java -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] deps(java): bump com.gradle.develocity from 3.18.2 to 4.0.1 [lucene]
dweiss merged PR #14585: URL: https://github.com/apache/lucene/pull/14585 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [I] TestForTooMuchCloning: too many calls to IndexInput.clone during TermRangeQuery: 7 [lucene]
dweiss commented on issue #14546: URL: https://github.com/apache/lucene/issues/14546#issuecomment-2841306914 The number of clones here seems... ahem, high. ``` 2> Apr 30, 2025 11:04:20 AM org.apache.lucene.internal.vectorization.VectorizationProvider lookup 2> WARNING: Vector bitsize and/or integer vectors enforcement; using default vectorization provider outside of testMode > java.lang.AssertionError: too many calls to IndexInput.clone during merging: 612 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Upgrade to gradle 8.14 on branch_10x (backport). [lucene]
dweiss commented on code in PR #14591:
URL: https://github.com/apache/lucene/pull/14591#discussion_r2068225660
##
lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java:
##
@@ -379,7 +379,9 @@ private static MMapIndexInputProvider
lookupProvider() {
// access through the lookup:
final var constr = lookup.findConstructor(cls,
MethodType.methodType(void.class, int.class));
try {
-return (MMapIndexInputProvider) constr.invoke(maxPermits);
+@SuppressWarnings("unchecked")
Review Comment:
I assumed that it'd still fail with javac 24 if you're running with that.
But apparently it works so it (javac) must be --target (or --source, or
--release) sensitive somehow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Upgrade to gradle 8.14 on branch_10x (backport). [lucene]
uschindler commented on PR #14591: URL: https://github.com/apache/lucene/pull/14591#issuecomment-2841573256 I got a strange error: * What went wrong: Execution failed for task ':downloadEcjDrop'. > A failure occurred while executing de.undercouch.gradle.tasks.download.internal.DefaultWorkerExecutorHelper$DefaultWorkAction > javax.net.ssl.SSLHandshakeException: (certificate_unknown) PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target But on second try it worked. Another problem is that the ECJ compiler config is not using 24 but still 23 in this PR. I will fix this in a commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Upgrade to gradle 8.14 on branch_10x (backport). [lucene]
uschindler commented on PR #14591: URL: https://github.com/apache/lucene/pull/14591#issuecomment-2841576505 Fixed: 0550cc6d2d0294641679131b597d591896211fce -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Upgrade to gradle 8.14 on branch_10x (backport). [lucene]
uschindler commented on PR #14591: URL: https://github.com/apache/lucene/pull/14591#issuecomment-2841591612 One information about Exclipse: With the recent commit all works fine. It just sometimes fails with a compilation error (but that's not new) regarding: "Permitted type LeafReaderContext does not declare org.apache.lucene.index.IndexReaderContext as a direct supertype" This error is bullshit but something seems to confuse the compile inside the Eclipse IDE. Anyways: If you want to use exclipse, you need to install the Milestone 1 of 2025-06 release, otherwise it won't work (same reason like discussed above). Luckily on starting Eclipse it asks you if you want to try the milestone release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Upgrade to gradle 8.14 on branch_10x (backport). [lucene]
uschindler commented on PR #14591: URL: https://github.com/apache/lucene/pull/14591#issuecomment-2841593957 sorry the messages above are in wrong PR. deleting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Upgrade to Gradle 8.14 and Java 24 minimum [lucene]
uschindler commented on PR #14533: URL: https://github.com/apache/lucene/pull/14533#issuecomment-2841595622 I got a strange error: * What went wrong: Execution failed for task ':downloadEcjDrop'. > A failure occurred while executing de.undercouch.gradle.tasks.download.internal.DefaultWorkerExecutorHelper$DefaultWorkAction > javax.net.ssl.SSLHandshakeException: (certificate_unknown) PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target But on second try it worked. Another problem is that the ECJ compiler config is not using 24 but still 23 in this PR. I will fix this in a commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Upgrade to Gradle 8.14 and Java 24 minimum [lucene]
uschindler commented on PR #14533: URL: https://github.com/apache/lucene/pull/14533#issuecomment-2841596170 Fixed: 0550cc6d2d0294641679131b597d591896211fce -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Upgrade to Gradle 8.14 and Java 24 minimum [lucene]
uschindler commented on PR #14533: URL: https://github.com/apache/lucene/pull/14533#issuecomment-2841596506 One information about Exclipse: With the recent commit all works fine. It just sometimes fails with a compilation error (but that's not new) regarding: "Permitted type LeafReaderContext does not declare org.apache.lucene.index.IndexReaderContext as a direct supertype" This error is bullshit but something seems to confuse the compile inside the Eclipse IDE. Anyways: If you want to use exclipse, you need to install the Milestone 1 of 2025-06 release, otherwise it won't work (same reason like discussed above). Luckily on starting Eclipse it asks you if you want to try the milestone release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] deps(java): bump de.jflex:jflex from 1.8.2 to 1.9.1 [lucene]
rmuir commented on PR #14583: URL: https://github.com/apache/lucene/pull/14583#issuecomment-2842062463 i'm gonna circle back to this one, just need a better plan than iterating with `./gradlew regenerate --rerun-all-tasks` :) Can probably just try to iterate with StandardTokenizer: the 12GB DFA makes the process painful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [I] TestForTooMuchCloning: too many calls to IndexInput.clone during TermRangeQuery: 7 [lucene]
gf2121 commented on issue #14546: URL: https://github.com/apache/lucene/issues/14546#issuecomment-2842434087 I raised: * https://github.com/apache/lucene/pull/14595 binding limitation to the number of segments get merged. * https://github.com/apache/lucene/pull/14596 a tiny simplification found when tracing clone stacks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[PR] Simplify rootBlockFP [lucene]
gf2121 opened a new pull request, #14596: URL: https://github.com/apache/lucene/pull/14596 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [I] gradle-wrapper.jar will not be updated when its sha/version changes [lucene]
rmuir commented on issue #14598: URL: https://github.com/apache/lucene/issues/14598#issuecomment-2843104515 I looked into this, there's a `gradle/wrapper/gradle-wrapper.jar.sha256` but it is not in the standard format. How is this currently being generated/used? I would propose: Generation: ```console $ sha256sum gradle-wrapper.jar > gradle-wrapper.jar.256 ``` Validation: ```console $ sha256sum -c gradle-wrapper.jar.sha256 ``` This will work with both GNU coreutils `sha256sum` and the BSD `sha256sum` present on the macs. command works exactly the same as it is "basic" and required for many purposes. ```console $ sha256sum -c gradle-wrapper.jar.sha256 gradle-wrapper.jar: OK $ gsha256sum -c gradle-wrapper.jar.sha256 gradle-wrapper.jar: OK ``` I would happy to help make the changes to the `./gradlew`. It would prevent issues on both linux and macos operating systems. The `./gradlew.bat` might need a different solution, but it is its own file. Just would like to understand where this existing .sha256 file is coming from so that we can fix the output to be 'standard'. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] deps(java): bump org.apache.commons:commons-compress from 1.19 to 1.27.1 [lucene]
rmuir merged PR #14540: URL: https://github.com/apache/lucene/pull/14540 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[PR] Rewrite expressions module with Java 24 classfile API [lucene]
uschindler opened a new pull request, #14597: URL: https://github.com/apache/lucene/pull/14597 First step in getting rid of ASM dependency: Java 24 added the classfile API (https://openjdk.org/jeps/484) in non-preview mode. This allows to generate class files with a builder-based API (unfurtunately its is not the usual ASM visitor desaster, it is more a lambda-inside-lambda desaster). This code removes the license files and all ASM dependencies from runtime code (and module descriptors). The code was rewritten. The rewrite may not yet be the most elegant lambda-way to make it, but the PR is easier to review with not so many changes and reshuffled code. We still have ASM core as a dependncy for Gradle's APIJAR generator, but this one can also be removed soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Upgrade to Gradle 8.14 and Java 24 minimum [lucene]
dweiss commented on PR #14533: URL: https://github.com/apache/lucene/pull/14533#issuecomment-2842796053 Thank you, Uwe. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[I] gradle-wrapper.jar will not be updated when its sha/version changes [lucene]
dweiss opened a new issue, #14598: URL: https://github.com/apache/lucene/issues/14598 ### Description Uwe noticed this. After the update to gradle 8.14, I've updated the gradle-wrapper script's version and SHA. The new scripts launch it using -jar (previously it was launched using an explicit main method). This uncovered a potential problem that hasn't manifested itself so far - we only check if gradle-wrapper.jar exists; if it doesn't exist, we invoke WrapperDownloader but if gradle-wrapper.jar already exists, we take no action and use this file (which may be older/different). We could check the sha of the wrapper script on each invocation but this seems like an overkill. I don't have a fix for this one. I think we're just going to live with this oddity, hoping that it doesn't cause side effects often (what Uwe experienced). ### Version and environment details _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [I] gradle-wrapper.jar will not be updated when its sha/version changes [lucene]
rmuir commented on issue #14598: URL: https://github.com/apache/lucene/issues/14598#issuecomment-2843055994 I had to remove a wrapper manually this morning (maybe it was 0 bytes or corrupt or outdated) and force it to be re-downloaded myself. I didn't raise any issue as you know, i do hacky stuff so it might have been my fault, but just as a data point. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Rewrite expressions module with Java 24 classfile API [lucene]
uschindler commented on PR #14597: URL: https://github.com/apache/lucene/pull/14597#issuecomment-2843218827 I did some final cleanup and added changes entry. Will merge soon. Thanks for the reviews by @rjernst and @jdconrad, very appreciated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Remove abstractions of MMapDirectory and its "fake" MR-JAR support and move it to main sourceSet (vectors untouched) [lucene]
uschindler commented on PR #14564: URL: https://github.com/apache/lucene/pull/14564#issuecomment-2841163008 I am still verifyying that the conflicting changes due to readAdvice are merged in here in a correct way. I will merge this very soon tro avoid conflicts like this. My head is burning -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Remove abstractions of MMapDirectory and its "fake" MR-JAR support and move it to main sourceSet (vectors untouched) [lucene]
uschindler commented on PR #14564: URL: https://github.com/apache/lucene/pull/14564#issuecomment-2841215864 @thecoop is it correct that the `openInput()` code calls a deprecated method `IOContext#readAdvice()`? Will this be fixed in a later PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Upgrade to gradle 8.14 on branch_10x (backport). [lucene]
uschindler commented on code in PR #14591:
URL: https://github.com/apache/lucene/pull/14591#discussion_r2068218261
##
lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java:
##
@@ -379,7 +379,9 @@ private static MMapIndexInputProvider
lookupProvider() {
// access through the lookup:
final var constr = lookup.findConstructor(cls,
MethodType.methodType(void.class, int.class));
try {
-return (MMapIndexInputProvider) constr.invoke(maxPermits);
+@SuppressWarnings("unchecked")
Review Comment:
Is this needed here? This was only to workaround a java 24 bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [I] TestForTooMuchCloning: too many calls to IndexInput.clone during TermRangeQuery: 7 [lucene]
dweiss commented on issue #14546: URL: https://github.com/apache/lucene/issues/14546#issuecomment-2841305012 I hit a failure on this again, after the patch: ``` ./gradlew test -Ptests.seed=49BA5A550192C95E --tests TestForTooMuchCloning ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Reduce NeighborArray heap memory [lucene]
weizijun commented on PR #14527: URL: https://github.com/apache/lucene/pull/14527#issuecomment-2841464168 I added the change log and changed the initial size of the list to maxSize/8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Reduce NeighborArray heap memory [lucene]
weizijun commented on PR #14527: URL: https://github.com/apache/lucene/pull/14527#issuecomment-2841473318 The failed TestHnswFloatVectorGraph.testRamUsageEstimate detail: The seed is `-Dtests.seed=FEF2FF50C6824DEF` ``` Expected :1723096.0 Actual :3785393.0 java.lang.AssertionError: expected:<1723096.0> but was:<3785393.0> at __randomizedtesting.SeedInfo.seed([FEF2FF50C6824DEF:3BB69B10FD099A58]:0) at org.junit.Assert.fail(Assert.java:89) at org.junit.Assert.failNotEquals(Assert.java:835) at org.junit.Assert.assertEquals(Assert.java:555) at org.junit.Assert.assertEquals(Assert.java:685) at org.apache.lucene.util.hnsw.HnswGraphTestCase.testRamUsageEstimate(HnswGraphTestCase.java:804) at org.apache.lucene.util.hnsw.TestHnswFloatVectorGraph.testRamUsageEstimate(TestHnswFloatVectorGraph.java:39) at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103) at java.base/java.lang.reflect.Method.invoke(Method.java:580) at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1763) ``` If I change the ramBytesUsed of OnHeapHnswGraph to use the real memory of each NeighborArray, the performance will drop a lot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]
ChrisHegarty merged PR #14482: URL: https://github.com/apache/lucene/pull/14482 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] deps(java): bump nl.littlerobots.version-catalog-update from 0.8.4 to 1.0.0 [lucene]
dweiss merged PR #14568: URL: https://github.com/apache/lucene/pull/14568 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Upgrade to gradle 8.14 on branch_10x (backport). [lucene]
uschindler commented on code in PR #14591:
URL: https://github.com/apache/lucene/pull/14591#discussion_r2068232988
##
lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java:
##
@@ -379,7 +379,9 @@ private static MMapIndexInputProvider
lookupProvider() {
// access through the lookup:
final var constr = lookup.findConstructor(cls,
MethodType.methodType(void.class, int.class));
try {
-return (MMapIndexInputProvider) constr.invoke(maxPermits);
+@SuppressWarnings("unchecked")
Review Comment:
That's why I asked. The compilation with java 24 on Jenkins worked all the
time.
It is only an issue if release is targeting 24. They had some language
updates. But we should open a bug report about this.
I will make a reproducer and open issue for 24.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [I] TestForTooMuchCloning: too many calls to IndexInput.clone during TermRangeQuery: 7 [lucene]
gf2121 commented on issue #14546: URL: https://github.com/apache/lucene/issues/14546#issuecomment-2841363044 Thanks for reporting @dweiss , i'll reopen. Error assert: https://github.com/apache/lucene/blob/2a5597e83b976cb11997285811d00565ff828ffc/lucene/core/src/test/org/apache/lucene/index/TestForTooMuchCloning.java#L65-L67 This seems like an assert for the count of `IndexInput.clone` during merge, instead of query. I find the limitation 600 comes from https://github.com/apache/lucene/pull/14232, which looks like a "test passed after multiple reruns" magic number. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Add a Faiss codec for KNN searches [lucene]
mikemccand commented on PR #14178: URL: https://github.com/apache/lucene/pull/14178#issuecomment-2841908460 > > but how do I know whichever I pick is optimized properly for my particular env? > > These artifacts are created by the scripts in [this folder](https://github.com/facebookresearch/faiss/tree/main/conda/faiss) which are separate based on CPU architecture (like OSX, Windows, Arm, Intel, etc. -- see [these files](https://anaconda.org/pytorch/faiss-cpu/files) for different artifacts in Conda) Aha! Thanks for that pointer. I poked around a bit, and found [the last commit](https://github.com/conda-forge/faiss-split-feedstock/commit/838ca80809445aae4ac2f5b0d976f76b25368060) that changed those patches, which then pointed to this [still-open issue showing how difficult all of these levels of SIMD CPU instructions are for building native code like Faiss](https://github.com/conda-forge/faiss-split-feedstock/issues/23)... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Remove RANDOM_PRELOAD read advice, which is not actually used [lucene]
thecoop commented on PR #14593: URL: https://github.com/apache/lucene/pull/14593#issuecomment-2841419541 Is it actually worth keeping `SerialIOCountingDirectory` and `TestDefaultCodecParallizesIO`? Those are _assuming_ specific loading behaviour from the OS. Essentially, they're testing that specific ReadAdvice are passed to a Directory, not that the pages are actually loaded as expected from disk. Especially since ReadAdvice is moving into being a MMapDirectory-specific thing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Overwrite gradlew scripts with up-to-date ones and apply Lucene customizations [lucene]
uschindler commented on PR #14592: URL: https://github.com/apache/lucene/pull/14592#issuecomment-2841495185 Hi, I had a strange error when executing gradlew.bat the first time (sorry for German message): ``` C:\Users\Uwe Schindler\Projects\lucene\lucene>gradlew clean kein Hauptmanifestattribut, in C:\Users\Uwe Schindler\Projects\lucene\lucene\gradle\wrapper\gradle-wrapper.jar ``` After that I deleted the wrapper JAR file and after it redownloaded it, all was working fine. How can that be? There is a checksum for the wrapper file which should have changed! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Overwrite gradlew scripts with up-to-date ones and apply Lucene customizations [lucene]
uschindler commented on code in PR #14592: URL: https://github.com/apache/lucene/pull/14592#discussion_r2068371257 ## gradlew: ## @@ -239,19 +200,59 @@ if "$cygwin" || "$msys" ; then done fi +# START OF LUCENE CUSTOMIZATION + +# Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script. +DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"' + # Prevent jgit from forking/searching git.exe export GIT_CONFIG_NOSYSTEM=1 +# LUCENE-9471: workaround for gradle leaving junk temp. files behind. +GRADLE_TEMPDIR="$APP_HOME/.gradle/tmp" +mkdir -p "$GRADLE_TEMPDIR" +if [ "$cygwin" = "true" -o "$msys" = "true" ] ; then +GRADLE_TEMPDIR=`cygpath --path --mixed "$GRADLE_TEMPDIR"` +fi +DEFAULT_JVM_OPTS="$DEFAULT_JVM_OPTS \"-Djava.io.tmpdir=$GRADLE_TEMPDIR\"" + +# LUCENE-9266: verify and download the gradle wrapper jar if we don't have one. +if [ "$cygwin" = "true" -o "$msys" = "true" ] ; then +APP_HOME=`cygpath --path --mixed "$APP_HOME"` +fi + +GRADLE_WRAPPER_JAR="$APP_HOME/gradle/wrapper/gradle-wrapper.jar" +if [ ! -e "$GRADLE_WRAPPER_JAR" ]; then +"$JAVACMD" $JAVA_OPTS "$APP_HOME/build-tools/build-infra/src/main/java/org/apache/lucene/gradle/WrapperDownloader.java" "$GRADLE_WRAPPER_JAR" +WRAPPER_STATUS=$? +if [ "$WRAPPER_STATUS" -eq 1 ]; then +echo "ERROR: Something went wrong. Make sure you're using Java version of exactly 23." Review Comment: looks like a typo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Overwrite gradlew scripts with up-to-date ones and apply Lucene customizations [lucene]
uschindler commented on PR #14592: URL: https://github.com/apache/lucene/pull/14592#issuecomment-2841524735 The error message means that it did not find a "main class" (German "Hauptklasse" in the manifest attributes. This is really confusing to me. Maybe I had an older wrapper JAR in my checkout? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Add Query for reranking KnnFloatVectorQuery with full-precision vectors [lucene]
mikemccand commented on PR #14009: URL: https://github.com/apache/lucene/pull/14009#issuecomment-2841808722 I think this is a nice overall approach, adding a new `RerankKnnFloatVectorQuery` that wraps a KNN query that used quantization to get the initial results. It's reminiscent of Lucene's existing `QueryRescorer`, to implement multi-phased ranking, except that class doesn't wrap another `Query`... maybe it should (separately)! I'm curious about [your results here](https://github.com/apache/lucene/pull/14009#issuecomment-2502665806) -- why is recall better for 1bit and 4bit than 7bit, when reranking? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [I] gradle-wrapper.jar will not be updated when its sha/version changes [lucene]
dweiss commented on issue #14598: URL: https://github.com/apache/lucene/issues/14598#issuecomment-2844174816 You're right - I'm paranoid. I no longer use Windows on a regular basis but I can check on a vm later today. Like I said - if nothing else works, we can still just make WrapperDownloader do the job. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Rewrite expressions module with Java 24 classfile API [lucene]
dweiss commented on PR #14597: URL: https://github.com/apache/lucene/pull/14597#issuecomment-2844181355 Uncanny resemblance! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[PR] Switch s2-geometry to google's 'official' version [lucene]
dweiss opened a new pull request, #14599: URL: https://github.com/apache/lucene/pull/14599 This isn't complete. There are some extra dependencies I'm not sure are needed. But overall, the transition seems to be simple. Not that the "new" library from Google is that well maintained (there is only one version published). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] deps(java): bump io.sgr:s2-geometry-library-java from 1.0.0 to 1.0.1 [lucene]
dweiss closed pull request #14575: deps(java): bump io.sgr:s2-geometry-library-java from 1.0.0 to 1.0.1 URL: https://github.com/apache/lucene/pull/14575 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Switch s2-geometry to google's 'official' version [lucene]
dweiss commented on code in PR #14599:
URL: https://github.com/apache/lucene/pull/14599#discussion_r2069539389
##
gradle/validation/dependencies.gradle:
##
@@ -28,7 +28,6 @@ allprojects {
def testConfigurations = project.configurations.matching {
it.name in [
- "annotationProcessor",
Review Comment:
I've removed annotation processor configuration from version lock
computation. I don't think it's relevant to us what's used in annotation
processors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] deps(java): bump io.sgr:s2-geometry-library-java from 1.0.0 to 1.0.1 [lucene]
dweiss commented on PR #14575: URL: https://github.com/apache/lucene/pull/14575#issuecomment-2843461896 I'll try to switch, the initial draft is here: #14599 . There are some extra deps I need to work on. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] deps(java): bump io.sgr:s2-geometry-library-java from 1.0.0 to 1.0.1 [lucene]
dependabot[bot] commented on PR #14575: URL: https://github.com/apache/lucene/pull/14575#issuecomment-2843462176 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [I] gradle-wrapper.jar will not be updated when its sha/version changes [lucene]
rmuir commented on issue #14598: URL: https://github.com/apache/lucene/issues/14598#issuecomment-2843482547 > I also thought about sha256sum check in gradlew - this spawns a process but doesn't seem to be too bad... Well i mean this is what shell scripts do. The current `gradlew` spawns plenty of processes and even spawns them in loops (e.g. runs `ls` in a loop). Doesn't look like anyone is trying too hard to restrict themselves to just shell builtins. so I don't know why running `sha256sum` would be an issue. @dweiss can `certutil` work in the windows case? Sorry, my windows knowledge is limited, but if this tool could do the job it'd be perfect. https://techdocs.akamai.com/download-ctr/docs/verify-checksum -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [I] update PRs for java dependencies [lucene]
rmuir closed issue #14490: update PRs for java dependencies URL: https://github.com/apache/lucene/issues/14490 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [I] update PRs for java dependencies [lucene]
rmuir commented on issue #14490: URL: https://github.com/apache/lucene/issues/14490#issuecomment-2843493667 Thank you for solving this one @dweiss. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Rewrite expressions module with Java 24 classfile API [lucene]
dweiss commented on PR #14597: URL: https://github.com/apache/lucene/pull/14597#issuecomment-2843319741 > The hard part was more to understand and figure out how it works. For the fun of it, I asked chatgpt to do it. Uwe - you're still much, much better. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [I] gradle-wrapper.jar will not be updated when its sha/version changes [lucene]
dweiss commented on issue #14598: URL: https://github.com/apache/lucene/issues/14598#issuecomment-2843324990 I computed the current sha256 using command-line tools byte copy-pasted it directly into Lucene sources. No magic. I also thought about sha256sum check in gradlew - this spawns a process but doesn't seem to be too bad... but then we'd have an inconsistency with Windows (for which I see no solution). An alternative is to do this check in Java (WrapperDownloader) but this is a much more heavyweight process... Could be an alternative for Windows though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [I] update PRs for java dependencies [lucene]
dweiss commented on issue #14490: URL: https://github.com/apache/lucene/issues/14490#issuecomment-2843328050 Should we close this, @rmuir ? Seems to be working. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Rewrite expressions module with Java 24 classfile API [lucene]
rmuir commented on PR #14597: URL: https://github.com/apache/lucene/pull/14597#issuecomment-2843582527 lol the day we have an army of Uwe AIs, I feel like I've already seen this [movie](https://www.youtube.com/watch?v=wN6F1l4cJ1Y) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Rewrite expressions module with Java 24 classfile API [lucene]
uschindler merged PR #14597: URL: https://github.com/apache/lucene/pull/14597 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Rewrite expressions module with Java 24 classfile API [lucene]
uschindler commented on PR #14597: URL: https://github.com/apache/lucene/pull/14597#issuecomment-2843271854 > Looks great! It seems like ASM translated relatively well (in this case) to the ClassFile API (much of it was just changing imports/methods to call but looks very similar). The hard part was more to understand and figure out how it works. After that transforming the Antlr visitor to Classfile API was trivial. Very hard was that I was unable to figure out how to get a `ConstantDesc` which is needed for the bootstrapper from a `String` or `Integer`. I had to figure out first that all those classes implement `ConstantDesc` so you can just pass the `String` instance as parameter where type `ConstantDesc` is expected: https://github.com/apache/lucene/blob/938be2a1c313787bb31c6a5b9fde61b1e0025161/lucene/expressions/src/java/org/apache/lucene/expressions/js/JavascriptCompiler.java#L436  There are still some nice goodies missing in Classfile API: - No replacement for `GeneratorAdaptor#loadArgs` and a better named function like `GeneratorAdaptor#loadThis` (as synonmy for `aload(0)`). This would make the typical pass all parameters automatically to the invoke super call in ctors or overridden methods. - More methods with `TypeKind` to also generate compare code without knowing the exact tyes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [I] Add `SkipIndex` in SortedNumericDocValuesSetQuery [lucene]
kkewwei commented on issue #14551: URL: https://github.com/apache/lucene/issues/14551#issuecomment-2843657889 > Yeah -- that should be doable. > > My intuition is that we would need to keep the min/max values from the `SortedNumericDocValuesSetQuery`, then apply skipping logic similar to `SortedNumericDocValuesRangeQuery`. Is that what you had in mind [@kkewwei](https://github.com/kkewwei) ? Yes, There seems no better way to use it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [I] Apache jenkins nodes use java 24-ea [lucene]
dweiss commented on issue #14600: URL: https://github.com/apache/lucene/issues/14600#issuecomment-2844219216 Depends on #14590. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
