[GitHub] [lucene] dweiss commented on issue #11771: KeywordRepeatFilter + OpenNLPLemmatizer Early Exit
dweiss commented on issue #11771: URL: https://github.com/apache/lucene/issues/11771#issuecomment-1256892005 If this code went in the main branch then it's also a bug there. Comparing strings by reference is a no-no - I should have caught it earlier. I'll do the update on both branches later today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] romseygeek commented on pull request #11807: No need to rewrite queries in unified highlighter
romseygeek commented on PR #11807: URL: https://github.com/apache/lucene/pull/11807#issuecomment-1256931459 I thought the changes you made for unrecognized queries fixed the issues with the surround query parser? If not it would be good to implement query visitors for the queries that it produces, or at the very least have a test in the highlighting module for them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] romseygeek merged pull request #11808: Don't try to highlight very long terms
romseygeek merged PR #11808: URL: https://github.com/apache/lucene/pull/11808 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] dweiss commented on pull request #11810: fix equality check bug in test
dweiss commented on PR #11810: URL: https://github.com/apache/lucene/pull/11810#issuecomment-1256938048 This stream is not required at all: you just split on any consecutive sequence of white spaces, including newlines, and it'll be fine. I'll commit this separately and backport. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] dweiss closed pull request #11810: fix equality check bug in test
dweiss closed pull request #11810: fix equality check bug in test URL: https://github.com/apache/lucene/pull/11810 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] dweiss closed issue #11771: KeywordRepeatFilter + OpenNLPLemmatizer Early Exit
dweiss closed issue #11771: KeywordRepeatFilter + OpenNLPLemmatizer Early Exit URL: https://github.com/apache/lucene/issues/11771 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] dweiss commented on pull request #11812: Upgrade several build dependencies.
dweiss commented on PR #11812: URL: https://github.com/apache/lucene/pull/11812#issuecomment-1256959688 Not sure what's failing here, will take a look later. I suspect errorprone. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] rmuir opened a new pull request, #11813: Remove Operations.isFinite
rmuir opened a new pull request, #11813: URL: https://github.com/apache/lucene/pull/11813 This method is recursive: to avoid eating too much stack we apply a small limit. This means it can't really be used on any largish automata without hitting exception. But the benefit of knowing finite vs infinite in AutomatonTermsEnum is minor: let's not auto-compute this. FuzzyQuery still gets the finite optimization because its finite by definition. PrefixQuery is always infinite. Wildcard/Regex just assume infinite which is safe to do. Remove the auto-computation and the "trillean" Boolean parameter. If you dont know that your automaton is finite, pass false to CompiledAutomaton, it is safe. Move this method to AutomatonTestUtil so we can still use it in test asserts. Closes #11809 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] dweiss merged pull request #11811: Upgrade google java format and apply tidy
dweiss merged PR #11811: URL: https://github.com/apache/lucene/pull/11811 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] rmuir commented on pull request #11812: Upgrade several build dependencies.
rmuir commented on PR #11812: URL: https://github.com/apache/lucene/pull/11812#issuecomment-1256971988 Looks like error-prone fails saying that `PublicConstructorForAbstractClass` is not a valid checker name. We explicitly disable it currently: ``` gradle/validation/error-prone.gradle: '-Xep:PublicConstructorForAbstractClass:OFF' ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] dweiss commented on pull request #11812: Upgrade several build dependencies.
dweiss commented on PR #11812: URL: https://github.com/apache/lucene/pull/11812#issuecomment-1256973107 Yeah, thanks, Robert. I'll be looking into this - have an hour to spare at the airport anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] stefanvodita opened a new issue, #11814: Support deletes in IndexRearranger
stefanvodita opened a new issue, #11814: URL: https://github.com/apache/lucene/issues/11814 ### Description `IndexRearranger` applies deletes found in the original index, so the rearranged index will not contain any deleted docs. While deleted docs don't show up in search results, they still impact search performance. If we want the rearranged index to be as similar as possible to the original index, we should also include the docs marked for deletion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] dweiss commented on pull request #11812: Upgrade several build dependencies.
dweiss commented on PR #11812: URL: https://github.com/apache/lucene/pull/11812#issuecomment-1256975233 Right - this check was removed here: https://github.com/google/error-prone/commit/b4c6a03168102026bb6540627b21b356804250e4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] mikemccand commented on a diff in pull request #11813: Remove Operations.isFinite
mikemccand commented on code in PR #11813:
URL: https://github.com/apache/lucene/pull/11813#discussion_r979249444
##
lucene/core/src/java/org/apache/lucene/util/automaton/CompiledAutomaton.java:
##
@@ -139,21 +136,21 @@ private static int findSinkState(Automaton automaton) {
}
/**
- * Create this. If finite is null, we use {@link Operations#isFinite} to
determine whether it is
- * finite. If simplify is true, we run possibly expensive operations to
determine if the automaton
- * is one the cases in {@link CompiledAutomaton.AUTOMATON_TYPE}.
+ * Create this. If simplify is true, we run possibly expensive operations to
determine if the
+ * automaton is one the cases in {@link CompiledAutomaton.AUTOMATON_TYPE}.
Set finite to true if
+ * the automaton is finite, otherwise set to false if infinite or you don't
know.
Review Comment:
If a user accidentally claims the automaton was finite but it is not, what
happens?
##
lucene/core/src/java/org/apache/lucene/analysis/AutomatonToTokenStream.java:
##
@@ -46,10 +45,6 @@ private AutomatonToTokenStream() {}
* @return TokenStream representation of automaton.
*/
public static TokenStream toTokenStream(Automaton automaton) {
-if (Operations.isFinite(automaton) == false) {
Review Comment:
Maybe we should add a warning that this may run forever on an infinite
automaton?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] dweiss commented on pull request #11812: Upgrade several build dependencies.
dweiss commented on PR #11812: URL: https://github.com/apache/lucene/pull/11812#issuecomment-1256976327 Another check was removed here: https://github.com/google/error-prone/pull/2809 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] stefanvodita opened a new pull request, #11815: Support deletions in rearrange (#11814)
stefanvodita opened a new pull request, #11815: URL: https://github.com/apache/lucene/pull/11815 ### Description Changes made to support deletes in `IndexRearranger`: 1. Add `isDeleted(LeafReader reader, int idx)` in document selectors, which returns true if the document found at index `idx` in the leaf reader was marked for deletion in the original index. 2. Record all docs in the `DocumentSelector` (not just live ones). 3. When rearranging, in `addOneSegment`, add all docs that belong in the segment and then delete the ones that were originally marked for deletion. ### Testing The new test class is copied from `TestIndexRearranger` with modifications for deleting documents in the original index and testing that they are still present and deleted in the rearranged index. In a subsequent revision, this file would be merged into `TestIndexRearranger`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] rmuir commented on a diff in pull request #11813: Remove Operations.isFinite
rmuir commented on code in PR #11813:
URL: https://github.com/apache/lucene/pull/11813#discussion_r979251049
##
lucene/core/src/java/org/apache/lucene/analysis/AutomatonToTokenStream.java:
##
@@ -46,10 +45,6 @@ private AutomatonToTokenStream() {}
* @return TokenStream representation of automaton.
*/
public static TokenStream toTokenStream(Automaton automaton) {
-if (Operations.isFinite(automaton) == false) {
Review Comment:
ok, ill fix this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] rmuir commented on a diff in pull request #11813: Remove Operations.isFinite
rmuir commented on code in PR #11813:
URL: https://github.com/apache/lucene/pull/11813#discussion_r979251445
##
lucene/core/src/java/org/apache/lucene/util/automaton/CompiledAutomaton.java:
##
@@ -139,21 +136,21 @@ private static int findSinkState(Automaton automaton) {
}
/**
- * Create this. If finite is null, we use {@link Operations#isFinite} to
determine whether it is
- * finite. If simplify is true, we run possibly expensive operations to
determine if the automaton
- * is one the cases in {@link CompiledAutomaton.AUTOMATON_TYPE}.
+ * Create this. If simplify is true, we run possibly expensive operations to
determine if the
+ * automaton is one the cases in {@link CompiledAutomaton.AUTOMATON_TYPE}.
Set finite to true if
+ * the automaton is finite, otherwise set to false if infinite or you don't
know.
Review Comment:
I assume wrong answers or assertions :) Only FuzzyTermsEnum uses this
optimization to avoid a little CPU/upkeeping for the fuzzy case, its really an
opto for that. BlockTree intersection doesn't even look at it, i think.
We could probably tone down some of these CompiledAutomaton ctors to expose
it less in the future. We just need a single expert ctor for Fuzzy? I was
trying to minimize the scope of API changes here but can do more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] mikemccand commented on a diff in pull request #11813: Remove Operations.isFinite
mikemccand commented on code in PR #11813:
URL: https://github.com/apache/lucene/pull/11813#discussion_r979251604
##
lucene/core/src/java/org/apache/lucene/util/automaton/CompiledAutomaton.java:
##
@@ -139,21 +136,21 @@ private static int findSinkState(Automaton automaton) {
}
/**
- * Create this. If finite is null, we use {@link Operations#isFinite} to
determine whether it is
- * finite. If simplify is true, we run possibly expensive operations to
determine if the automaton
- * is one the cases in {@link CompiledAutomaton.AUTOMATON_TYPE}.
+ * Create this. If simplify is true, we run possibly expensive operations to
determine if the
+ * automaton is one the cases in {@link CompiledAutomaton.AUTOMATON_TYPE}.
Set finite to true if
+ * the automaton is finite, otherwise set to false if infinite or you don't
know.
Review Comment:
OK no worries -- no need to do more here! This change is already
self-contained and a great progress!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] rmuir commented on a diff in pull request #11813: Remove Operations.isFinite
rmuir commented on code in PR #11813:
URL: https://github.com/apache/lucene/pull/11813#discussion_r979252083
##
lucene/core/src/java/org/apache/lucene/util/automaton/CompiledAutomaton.java:
##
@@ -139,21 +136,21 @@ private static int findSinkState(Automaton automaton) {
}
/**
- * Create this. If finite is null, we use {@link Operations#isFinite} to
determine whether it is
- * finite. If simplify is true, we run possibly expensive operations to
determine if the automaton
- * is one the cases in {@link CompiledAutomaton.AUTOMATON_TYPE}.
+ * Create this. If simplify is true, we run possibly expensive operations to
determine if the
+ * automaton is one the cases in {@link CompiledAutomaton.AUTOMATON_TYPE}.
Set finite to true if
+ * the automaton is finite, otherwise set to false if infinite or you don't
know.
Review Comment:
yeah, this recursive method is "in the query path", the only remaining
recursive method is sortTopoStates, which is less exposed (i think suggesters
only).
ultimately it would be great to remove more of these "automatic" (sometimes
costly) optimizations, maybe even remove CompiledAutomaton. we've been making
progress.
but this Operations.isFinite is definitely the biggest problem and easiest
win right now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] rmuir commented on a diff in pull request #11813: Remove Operations.isFinite
rmuir commented on code in PR #11813:
URL: https://github.com/apache/lucene/pull/11813#discussion_r979254120
##
lucene/core/src/java/org/apache/lucene/analysis/AutomatonToTokenStream.java:
##
@@ -46,10 +45,6 @@ private AutomatonToTokenStream() {}
* @return TokenStream representation of automaton.
*/
public static TokenStream toTokenStream(Automaton automaton) {
-if (Operations.isFinite(automaton) == false) {
Review Comment:
I looked at the javadocs (scroll up just a bit more), it looks good?
```java
/**
* converts an automaton into a TokenStream. This is done by first Topo
sorting the nodes in the
* Automaton. Nodes that have the same distance from the start are grouped
together to form the
* position nodes for the TokenStream. The resulting TokenStream releases
edges from the automaton
* as tokens in order from the position nodes. This requires the automaton
be a finite DAG.
*
* @param automaton automaton to convert. Must be a finite DAG.
* @return TokenStream representation of automaton.
*/
public static TokenStream toTokenStream(Automaton automaton) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] mikemccand commented on a diff in pull request #11813: Remove Operations.isFinite
mikemccand commented on code in PR #11813:
URL: https://github.com/apache/lucene/pull/11813#discussion_r979254281
##
lucene/core/src/java/org/apache/lucene/analysis/AutomatonToTokenStream.java:
##
@@ -46,10 +45,6 @@ private AutomatonToTokenStream() {}
* @return TokenStream representation of automaton.
*/
public static TokenStream toTokenStream(Automaton automaton) {
-if (Operations.isFinite(automaton) == false) {
Review Comment:
Ahh super yes I agree!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] rmuir commented on a diff in pull request #11813: Remove Operations.isFinite
rmuir commented on code in PR #11813:
URL: https://github.com/apache/lucene/pull/11813#discussion_r979255164
##
lucene/core/src/java/org/apache/lucene/analysis/AutomatonToTokenStream.java:
##
@@ -46,10 +45,6 @@ private AutomatonToTokenStream() {}
* @return TokenStream representation of automaton.
*/
public static TokenStream toTokenStream(Automaton automaton) {
-if (Operations.isFinite(automaton) == false) {
Review Comment:
I boosted it a little bit with an explanation mark and the words "infinite
loop"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] rmuir commented on pull request #11813: Remove Operations.isFinite
rmuir commented on PR #11813: URL: https://github.com/apache/lucene/pull/11813#issuecomment-1256986744 I'm planning on doing this 10.x-only, not out of laziness, but because there are already several related 10.x changes around this stuff: removal of det in #11049, removal of minimize in #11332, etc. Not opposed to backporting this stuff to 9.x but we'd need to be careful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] rmuir merged pull request #11813: Remove Operations.isFinite
rmuir merged PR #11813: URL: https://github.com/apache/lucene/pull/11813 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] rmuir closed issue #11809: input automaton is too large for lengthy wildcard query
rmuir closed issue #11809: input automaton is too large for lengthy wildcard query URL: https://github.com/apache/lucene/issues/11809 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] rmuir commented on pull request #11812: Upgrade several build dependencies.
rmuir commented on PR #11812: URL: https://github.com/apache/lucene/pull/11812#issuecomment-1256988534 oh, one question @dweiss, since `javacc` is upgraded, should we force a `gradlew regenerate`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] rmuir commented on issue #11809: input automaton is too large for lengthy wildcard query
rmuir commented on issue #11809: URL: https://github.com/apache/lucene/issues/11809#issuecomment-125699 Thanks for reporting this with easy-to-reproduce testcase @taroplus -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] magibney commented on pull request #11813: Remove Operations.isFinite
magibney commented on PR #11813: URL: https://github.com/apache/lucene/pull/11813#issuecomment-1257009186 fwiw I have a local branch (very recent) that changed the implementation of `Operations.isFinite()` (and `Operations.topoSortStates()`) to be non-recursive, afaict without sacrificing performance on common use cases. Hoping to push a PR soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] shaie commented on a diff in pull request #11768: Fix tie-break bug in various Facets implementations
shaie commented on code in PR #11768:
URL: https://github.com/apache/lucene/pull/11768#discussion_r979357774
##
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/FloatTaxonomyFacets.java:
##
@@ -189,10 +190,11 @@ private TopChildrenForPath
getTopChildrenForPath(DimConfig dimConfig, int pathOr
TopOrdAndFloatQueue.OrdAndValue reuse = null;
while (ord != TaxonomyReader.INVALID_ORDINAL) {
- if (values[ord] > 0) {
+ float value = values[ord];
+ if (value > 0) {
aggregatedValue = aggregationFunction.aggregate(aggregatedValue,
values[ord]);
Review Comment:
nit: might as well use `value` here too (and check if we you can replace
`values[ord]` with `value` elsewhere
##
lucene/facet/src/test/org/apache/lucene/facet/TestDrillSideways.java:
##
@@ -626,7 +626,7 @@ public void testBasicWithCollectorManager() throws
Exception {
List topNDimsResult = r.facets.getTopDims(1, 2);
assertEquals(1, topNDimsResult.size());
assertEquals(
-"dim=Author path=[] value=5 childCount=4\n Lisa (2)\n Susan (1)\n",
Review Comment:
It's disturbing that these tests were "wrong" and we just let them be like
that. I'm glad that you fixed them, but makes me wonder if it was possible to
catch this bug earlier by scrutinizing these tests better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
