[jira] [Commented] (LUCENE-10307) Add sanity checks for the distribution
[ https://issues.apache.org/jira/browse/LUCENE-10307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17457567#comment-17457567 ] Dawid Weiss commented on LUCENE-10307: -- That's fine - provided the test is working. :) > Add sanity checks for the distribution > -- > > Key: LUCENE-10307 > URL: https://issues.apache.org/jira/browse/LUCENE-10307 > Project: Lucene - Core > Issue Type: Sub-task >Reporter: Dawid Weiss >Priority: Major > > Re-add the tests from the jms branch validating that module names are > constant, all modules are named, that service layer is consistent, etc. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Comment Edited] (LUCENE-10307) Add sanity checks for the distribution
[ https://issues.apache.org/jira/browse/LUCENE-10307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17457567#comment-17457567 ] Dawid Weiss edited comment on LUCENE-10307 at 12/11/21, 2:07 PM: - That's fine - proved the test is working. :) was (Author: dweiss): That's fine - provided the test is working. :) > Add sanity checks for the distribution > -- > > Key: LUCENE-10307 > URL: https://issues.apache.org/jira/browse/LUCENE-10307 > Project: Lucene - Core > Issue Type: Sub-task >Reporter: Dawid Weiss >Priority: Major > > Re-add the tests from the jms branch validating that module names are > constant, all modules are named, that service layer is consistent, etc. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Comment Edited] (LUCENE-10297) Speed up medium cardinality fields with readLongs and SIMD
[
https://issues.apache.org/jira/browse/LUCENE-10297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456577#comment-17456577
]
Feng Guo edited comment on LUCENE-10297 at 12/11/21, 6:38 PM:
--
Hi [~jpountz], [~ivera] ! Could you help take a look at this issue when you
have free time? Thanks!
was (Author: gf2121):
Hi [~jpountz], [~ivera] ! Would you please help take a look at this issue when
you have free time? Thanks!
> Speed up medium cardinality fields with readLongs and SIMD
> --
>
> Key: LUCENE-10297
> URL: https://issues.apache.org/jira/browse/LUCENE-10297
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/codecs
>Reporter: Feng Guo
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We introduced a bitset optimization for extremly low cardinality fields in
> [LUCENE-10233|https://issues.apache.org/jira/browse/LUCENE-10233], but medium
> cardinality fields (like 32/128) can rarely trigger this optimization, I'm
> trying to find out a way to speed up them.
> In [https://github.com/apache/lucene-solr/pull/1538], we made some effort to
> use readLELongs to speed up BKD id blocks, but did not get a obvious gain on
> this approach. I think the reason could probably be that we were trying to
> optimize the unsorted situation (typically happens for high cardinality
> fields) and the bottleneck of queries on high cardinality fields is
> {{visitDocValues}} but not {{{}readDocIds{}}}. _(Not sure, i'm doing some
> more benchmark on this)_
> However, medium cardinality fields may be tempted for this optimization
> because they need to read lots of ids for each term. The basic idea is that
> we can compute the delta of the sorted ids and encode/decode them like what
> we do in {{{}StoredFieldsInts{}}}. I benchmarked the optimization by mocking
> some random longPoint and querying them with {{{}PointInSetQuery{}}}. As
> expected, the medium cardinality fields got spped up and high cardinality
> fields get even results.
> *Benchmark Result*
> |doc count|field cardinality|query point|baseline(ms)|candidate(ms)|diff
> percentage|baseline(QPS)|candidate(QPS)|diff percentage|
> |1|32|1|19|16|-15.79%|52.63|62.50|18.75%|
> |1|32|2|34|14|-58.82%|29.41|71.43|142.86%|
> |1|32|4|76|22|-71.05%|13.16|45.45|245.45%|
> |1|32|8|139|42|-69.78%|7.19|23.81|230.95%|
> |1|32|16|279|82|-70.61%|3.58|12.20|240.24%|
> |1|128|1|17|11|-35.29%|58.82|90.91|54.55%|
> |1|128|8|75|23|-69.33%|13.33|43.48|226.09%|
> |1|128|16|126|25|-80.16%|7.94|40.00|404.00%|
> |1|128|32|245|50|-79.59%|4.08|20.00|390.00%|
> |1|128|64|528|97|-81.63%|1.89|10.31|444.33%|
> |1|1024|1|3|2|-33.33%|333.33|500.00|50.00%|
> |1|1024|8|13|8|-38.46%|76.92|125.00|62.50%|
> |1|1024|32|31|19|-38.71%|32.26|52.63|63.16%|
> |1|1024|128|120|67|-44.17%|8.33|14.93|79.10%|
> |1|1024|512|480|133|-72.29%|2.08|7.52|260.90%|
> |1|8192|1|3|3|0.00%|333.33|333.33|0.00%|
> |1|8192|16|18|15|-16.67%|55.56|66.67|20.00%|
> |1|8192|64|19|14|-26.32%|52.63|71.43|35.71%|
> |1|8192|512|69|43|-37.68%|14.49|23.26|60.47%|
> |1|8192|2048|236|134|-43.22%|4.24|7.46|76.12%|
> |1|1048576|1|3|2|-33.33%|333.33|500.00|50.00%|
> |1|1048576|16|18|19|5.56%|55.56|52.63|-5.26%|
> |1|1048576|64|17|17|0.00%|58.82|58.82|0.00%|
> |1|1048576|512|34|32|-5.88%|29.41|31.25|6.25%|
> |1|1048576|2048|89|93|4.49%|11.24|10.75|-4.30%|
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Created] (LUCENE-10308) Make ecj and javadoc run with modular paths
Dawid Weiss created LUCENE-10308: Summary: Make ecj and javadoc run with modular paths Key: LUCENE-10308 URL: https://issues.apache.org/jira/browse/LUCENE-10308 Project: Lucene - Core Issue Type: Sub-task Reporter: Dawid Weiss -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10308) Make ecj and javadoc run with modular paths
[ https://issues.apache.org/jira/browse/LUCENE-10308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17457723#comment-17457723 ] Dawid Weiss commented on LUCENE-10308: -- I made the gradle code patches but ecj is really rough to work with. Passing directories as sources confuses the compiler (the module-info has to reside in the same directory as the rest of the code). I also had to turn off API leaks warning similar to javac linter. The code is at: https://github.com/dweiss/lucene/tree/LUCENE-10308 It's not ready yet. It'd have to be combined with javadoc compiling in full modular mode or omitting module-info.java somehow in a different way. > Make ecj and javadoc run with modular paths > --- > > Key: LUCENE-10308 > URL: https://issues.apache.org/jira/browse/LUCENE-10308 > Project: Lucene - Core > Issue Type: Sub-task >Reporter: Dawid Weiss >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Created] (LUCENE-10309) Minimum KnnVector codec support in Luke
Tomoko Uchida created LUCENE-10309: -- Summary: Minimum KnnVector codec support in Luke Key: LUCENE-10309 URL: https://issues.apache.org/jira/browse/LUCENE-10309 Project: Lucene - Core Issue Type: Improvement Components: luke Affects Versions: 9.1, 10.0 (main) Reporter: Tomoko Uchida Assignee: Tomoko Uchida Attachments: Screenshot from 2021-12-12 14-40-41.png (For completeness,) Luke should show KnnVector format information in the index browsing tab. If the type of a field is KnnVector, * Show flag "K" * Show its dimension * Show its similarity function -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Updated] (LUCENE-10309) Minimum KnnVector codec support in Luke
[ https://issues.apache.org/jira/browse/LUCENE-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida updated LUCENE-10309: --- Attachment: Screenshot from 2021-12-12 14-40-41.png > Minimum KnnVector codec support in Luke > --- > > Key: LUCENE-10309 > URL: https://issues.apache.org/jira/browse/LUCENE-10309 > Project: Lucene - Core > Issue Type: Improvement > Components: luke >Affects Versions: 9.1, 10.0 (main) >Reporter: Tomoko Uchida >Assignee: Tomoko Uchida >Priority: Minor > Attachments: Screenshot from 2021-12-12 14-40-41.png > > > (For completeness,) Luke should show KnnVector format information in the > index browsing tab. > If the type of a field is KnnVector, > * Show flag "K" > * Show its dimension > * Show its similarity function -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] mikemccand commented on pull request #456: LUCENE-10236: Add change entry
mikemccand commented on pull request #456: URL: https://github.com/apache/lucene/pull/456#issuecomment-991348342 Hmm actually this issue was fixed in 9.0.0, I think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10309) Minimum KnnVector codec support in Luke
[ https://issues.apache.org/jira/browse/LUCENE-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17457822#comment-17457822 ] Tomoko Uchida commented on LUCENE-10309: Snapshot (an example index created by "demo") !Screenshot from 2021-12-12 14-40-41.png! Description of the flags. !Screenshot from 2021-12-12 14-54-47.png! > Minimum KnnVector codec support in Luke > --- > > Key: LUCENE-10309 > URL: https://issues.apache.org/jira/browse/LUCENE-10309 > Project: Lucene - Core > Issue Type: Improvement > Components: luke >Affects Versions: 9.1, 10.0 (main) >Reporter: Tomoko Uchida >Assignee: Tomoko Uchida >Priority: Minor > Attachments: Screenshot from 2021-12-12 14-40-41.png, Screenshot from > 2021-12-12 14-54-47.png > > > (For completeness,) Luke should show KnnVector format information in the > index browsing tab. > If the type of a field is KnnVector, > * Show flag "K" > * Show its dimension > * Show its similarity function -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Updated] (LUCENE-10309) Minimum KnnVector codec support in Luke
[ https://issues.apache.org/jira/browse/LUCENE-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida updated LUCENE-10309: --- Attachment: Screenshot from 2021-12-12 14-54-47.png > Minimum KnnVector codec support in Luke > --- > > Key: LUCENE-10309 > URL: https://issues.apache.org/jira/browse/LUCENE-10309 > Project: Lucene - Core > Issue Type: Improvement > Components: luke >Affects Versions: 9.1, 10.0 (main) >Reporter: Tomoko Uchida >Assignee: Tomoko Uchida >Priority: Minor > Attachments: Screenshot from 2021-12-12 14-40-41.png, Screenshot from > 2021-12-12 14-54-47.png > > > (For completeness,) Luke should show KnnVector format information in the > index browsing tab. > If the type of a field is KnnVector, > * Show flag "K" > * Show its dimension > * Show its similarity function -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] msfroh edited a comment on pull request #446: LUCENE-10237 : Add MergeOnCommitTieredMergePolicy to sandbox
msfroh edited a comment on pull request #446: URL: https://github.com/apache/lucene/pull/446#issuecomment-991340704 > As I look at this, it is kind of strange that we call setMaxMergedSegmentMB in findMerges because if a user set that explicitly, we would then override it based on the max size as percentage of index, which could be surprising. I think this max size as proportion of index is a nice feature, but I'm not sure it really has anything to do with finding small segments to merge on refresh? So +1 to dropping that feature. Maybe @msfroh will remember why it's in here -- is it just for convenience That's correct. Our Amazon product search merge policy is solving two different problems -- finding small segments that could cheaply be merged on commit (raising the floor of committed segment sizes), and setting the max segment size as a proportion of overall index size (lowering the ceiling). The variable max segment size was motivated by cases where we would have (say) a 5.5GB shard, with a 5GB max segment size. If a merge kicks in and produces a 5GB segment, then the search is basically single-threaded, which would lead to a large (and sudden) jump in latency. If the goal of this change is to just provide a reference merge policy for merge on commit/refresh, then the variable max segment size should be left out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] zacharymorn commented on a change in pull request #534: LUCENE-10183: KnnVectorsWriter#writeField to take KnnVectorsReader instead of VectorValues
zacharymorn commented on a change in pull request #534:
URL: https://github.com/apache/lucene/pull/534#discussion_r767087199
##
File path:
lucene/core/src/java/org/apache/lucene/index/EmptyKnnVectorsReader.java
##
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.lucene.index;
+
+import java.io.IOException;
+import org.apache.lucene.codecs.KnnVectorsReader;
+import org.apache.lucene.search.TopDocs;
+import org.apache.lucene.util.Bits;
+
+/** Abstract base class implementing a {@link KnnVectorsReader} that has no
vector values. */
+public abstract class EmptyKnnVectorsReader extends KnnVectorsReader {
Review comment:
This class mirrors
https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/index/EmptyDocValuesProducer.java
for doc values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Updated] (LUCENE-10309) Minimum KnnVector codec support in Luke
[ https://issues.apache.org/jira/browse/LUCENE-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida updated LUCENE-10309: --- Description: (For completeness,) Luke should show KnnVector format information in the index browsing tab. If the type of a field is KnnVector, * Show flag "K" * Show its dimension * Show its similarity function More rich support for the codec - decoding or searching - can come later. ? was: (For completeness,) Luke should show KnnVector format information in the index browsing tab. If the type of a field is KnnVector, * Show flag "K" * Show its dimension * Show its similarity function > Minimum KnnVector codec support in Luke > --- > > Key: LUCENE-10309 > URL: https://issues.apache.org/jira/browse/LUCENE-10309 > Project: Lucene - Core > Issue Type: Improvement > Components: luke >Affects Versions: 9.1, 10.0 (main) >Reporter: Tomoko Uchida >Assignee: Tomoko Uchida >Priority: Minor > Attachments: Screenshot from 2021-12-12 14-40-41.png, Screenshot from > 2021-12-12 14-54-47.png > > > (For completeness,) Luke should show KnnVector format information in the > index browsing tab. > If the type of a field is KnnVector, > * Show flag "K" > * Show its dimension > * Show its similarity function > More rich support for the codec - decoding or searching - can come later. ? -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] msfroh commented on pull request #446: LUCENE-10237 : Add MergeOnCommitTieredMergePolicy to sandbox
msfroh commented on pull request #446: URL: https://github.com/apache/lucene/pull/446#issuecomment-991340704 > As I look at this, it is kind of strange that we call setMaxMergedSegmentMB in findMerges because if a user set that explicitly, we would then override it based on the max size as percentage of index, which could be surprising. I think this max size as proportion of index is a nice feature, but I'm not sure it really has anything to do with finding small segments to merge on refresh? So +1 to dropping that feature. Maybe @msfroh will remember why it's in here -- is it just for convenience That's correct. Our Amazon product search merge policy is solving two different problems -- finding small segments that could cheaply be merged on commit (raising the floor of committed segment sizes), and setting the max segment size as a proportion of overall segment size (lowering the ceiling). The variable max segment size was motivated by cases where we would have (say) a 5.5GB shard, with a 5GB max segment size. If a merge kicks in and produces a 5GB segment, then the search is basically single-threaded, which would lead to a large (and sudden) jump in latency. If the goal of this change is to just provide a reference merge policy for merge on commit/refresh, then the variable max segment size should be left out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] zacharymorn commented on pull request #456: LUCENE-10236: Add change entry
zacharymorn commented on pull request #456: URL: https://github.com/apache/lucene/pull/456#issuecomment-991446756 > Hmm actually this issue was fixed in 9.0.0, I think? This change entry is for https://github.com/apache/lucene/commit/07ee3ba83a4c9f3abc24bf9d3fbb3c3102c4a102#diff-27a1984493254d0af3e9c50caee47443abbbdc79a87b4c348300bcb317a0a5b2, as I forgot to add it in that merge. I checked the commit immediately after mine https://github.com/apache/lucene/commit/ad911df2605591a63ca58d237182f84aa8384325# on `main` and saw the change entry used `9.1.0`, so I assumed I should use that as well? On the other hand, [`branch_9_0`](https://github.com/apache/lucene/commits/branch_9_0) doesn't contain my fix commit as I haven't back-ported it yet. Not sure if I may miss something? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] zacharymorn commented on a change in pull request #456: LUCENE-10236: Add change entry
zacharymorn commented on a change in pull request #456: URL: https://github.com/apache/lucene/pull/456#discussion_r767084987 ## File path: lucene/CHANGES.txt ## @@ -57,7 +57,9 @@ Optimizations Bug Fixes - -(No changes) + +* LUCENE-10236: Update field-weight used in CombinedFieldQuery scoring calculation. Review comment: No problem, thanks @mikemccand for the review and approval! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] msokolov commented on pull request #446: LUCENE-10237 : Add MergeOnCommitTieredMergePolicy to sandbox
msokolov commented on pull request #446: URL: https://github.com/apache/lucene/pull/446#issuecomment-991310522 > So I am thinking of revising this PR with only change 1(easy to configure merge-on-commit merges ) and make it generic to work with all merge polcies. What do you think Mike ? As I look at this, it is kind of strange that we call `setMaxMergedSegmentMB` in `findMerges` because if a user set that explicitly, we would then override it based on the max size as percentage of index, which could be surprising. I think this max size as proportion of index is a nice feature, but I'm not sure it really has anything to do with finding small segments to merge on refresh? So +1 to dropping that feature. Maybe @msfroh will remember why it's in here -- is it just for convenience? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] mdmarshmallow commented on a change in pull request #509: LUCENE-10250: Add support for arbitrary length hierarchical SSDV facets
mdmarshmallow commented on a change in pull request #509:
URL: https://github.com/apache/lucene/pull/509#discussion_r766907398
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/sortedset/SortedSetDocValuesReaderState.java
##
@@ -37,19 +38,102 @@
public abstract class SortedSetDocValuesReaderState implements Accountable {
/**
- * Holds start/end range of ords, which maps to one dimension (someday we
may generalize it to map
- * to hierarchies within one dimension).
+ * Class to store ranges of facet label as well as references to children of
that label, key'd by
+ * label string
*/
- public static final class OrdRange {
+ public static final class HierarchicalOrdRange {
/** Start of range, inclusive: */
-public final int start;
-/** End of range, inclusive: */
-public final int end;
-
-/** Start and end are inclusive. */
-public OrdRange(int start, int end) {
- this.start = start;
- this.end = end;
+private int start = -1;
+/** End of range, exclusive: */
Review comment:
This should say inclusive
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] madrob merged pull request #2627: SOLR-15843
madrob merged pull request #2627: URL: https://github.com/apache/lucene-solr/pull/2627 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] mikemccand commented on a change in pull request #456: LUCENE-10236: Add change entry
mikemccand commented on a change in pull request #456: URL: https://github.com/apache/lucene/pull/456#discussion_r767022313 ## File path: lucene/CHANGES.txt ## @@ -57,7 +57,9 @@ Optimizations Bug Fixes - -(No changes) + +* LUCENE-10236: Update field-weight used in CombinedFieldQuery scoring calculation. Review comment: Oh yes looks great sorry for the slow response! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Updated] (LUCENE-10309) Minimum KnnVector codec support in Luke
[ https://issues.apache.org/jira/browse/LUCENE-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida updated LUCENE-10309: --- Description: (For completeness,) Luke should show KnnVector format information in the index browsing tab. If the type of a field is a KnnVector, * Show flag "K" * Show its dimension * Show its similarity function More rich support for the codec - decoding or searching - could come later; I don't know if there are such use-cases. was: (For completeness,) Luke should show KnnVector format information in the index browsing tab. If the type of a field is KnnVector, * Show flag "K" * Show its dimension * Show its similarity function More rich support for the codec - decoding or searching - can come later. ? > Minimum KnnVector codec support in Luke > --- > > Key: LUCENE-10309 > URL: https://issues.apache.org/jira/browse/LUCENE-10309 > Project: Lucene - Core > Issue Type: Improvement > Components: luke >Affects Versions: 9.1, 10.0 (main) >Reporter: Tomoko Uchida >Assignee: Tomoko Uchida >Priority: Minor > Attachments: Screenshot from 2021-12-12 14-40-41.png, Screenshot from > 2021-12-12 14-54-47.png > > > (For completeness,) Luke should show KnnVector format information in the > index browsing tab. > If the type of a field is a KnnVector, > * Show flag "K" > * Show its dimension > * Show its similarity function > More rich support for the codec - decoding or searching - could come later; I > don't know if there are such use-cases. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Updated] (LUCENE-10309) Minimum KnnVector codec support in Luke
[ https://issues.apache.org/jira/browse/LUCENE-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida updated LUCENE-10309: --- Affects Version/s: (was: 9.1) (was: 10.0 (main)) > Minimum KnnVector codec support in Luke > --- > > Key: LUCENE-10309 > URL: https://issues.apache.org/jira/browse/LUCENE-10309 > Project: Lucene - Core > Issue Type: Improvement > Components: luke >Reporter: Tomoko Uchida >Assignee: Tomoko Uchida >Priority: Minor > Attachments: Screenshot from 2021-12-12 14-40-41.png, Screenshot from > 2021-12-12 14-54-47.png > > > (For completeness,) Luke should show KnnVector format information in the > index browsing tab. > If the type of a field is a KnnVector, > * Show flag "K" > * Show its dimension > * Show its similarity function > More rich support for the codec - decoding or searching - could come later; I > don't know if there are such use-cases. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] mocobeta merged pull request #535: LUCENE-10309: Minimum KnnVector codec support in Luke
mocobeta merged pull request #535: URL: https://github.com/apache/lucene/pull/535 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10309) Minimum KnnVector codec support in Luke
[ https://issues.apache.org/jira/browse/LUCENE-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17457852#comment-17457852 ] ASF subversion and git services commented on LUCENE-10309: -- Commit 2f634b0d95ec24283999c61ec700d9e96a854633 in lucene's branch refs/heads/main from Tomoko Uchida [ https://gitbox.apache.org/repos/asf?p=lucene.git;h=2f634b0 ] LUCENE-10309: Minimum KnnVector codec support in Luke (#535) > Minimum KnnVector codec support in Luke > --- > > Key: LUCENE-10309 > URL: https://issues.apache.org/jira/browse/LUCENE-10309 > Project: Lucene - Core > Issue Type: Improvement > Components: luke >Reporter: Tomoko Uchida >Assignee: Tomoko Uchida >Priority: Minor > Attachments: Screenshot from 2021-12-12 14-40-41.png, Screenshot from > 2021-12-12 14-54-47.png > > Time Spent: 10m > Remaining Estimate: 0h > > (For completeness,) Luke should show KnnVector format information in the > index browsing tab. > If the type of a field is a KnnVector, > * Show flag "K" > * Show its dimension > * Show its similarity function > More rich support for the codec - decoding or searching - could come later; I > don't know if there are such use-cases. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10309) Minimum KnnVector codec support in Luke
[ https://issues.apache.org/jira/browse/LUCENE-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17457853#comment-17457853 ] ASF subversion and git services commented on LUCENE-10309: -- Commit e0a6e1c662e4e15937693c90b0dd5a277ca355ba in lucene's branch refs/heads/branch_9x from Tomoko Uchida [ https://gitbox.apache.org/repos/asf?p=lucene.git;h=e0a6e1c ] LUCENE-10309: Minimum KnnVector codec support in Luke (#535) > Minimum KnnVector codec support in Luke > --- > > Key: LUCENE-10309 > URL: https://issues.apache.org/jira/browse/LUCENE-10309 > Project: Lucene - Core > Issue Type: Improvement > Components: luke >Reporter: Tomoko Uchida >Assignee: Tomoko Uchida >Priority: Minor > Attachments: Screenshot from 2021-12-12 14-40-41.png, Screenshot from > 2021-12-12 14-54-47.png > > Time Spent: 10m > Remaining Estimate: 0h > > (For completeness,) Luke should show KnnVector format information in the > index browsing tab. > If the type of a field is a KnnVector, > * Show flag "K" > * Show its dimension > * Show its similarity function > More rich support for the codec - decoding or searching - could come later; I > don't know if there are such use-cases. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Resolved] (LUCENE-10309) Minimum KnnVector codec support in Luke
[ https://issues.apache.org/jira/browse/LUCENE-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida resolved LUCENE-10309. Fix Version/s: 9.1 10.0 (main) Resolution: Fixed > Minimum KnnVector codec support in Luke > --- > > Key: LUCENE-10309 > URL: https://issues.apache.org/jira/browse/LUCENE-10309 > Project: Lucene - Core > Issue Type: Improvement > Components: luke >Reporter: Tomoko Uchida >Assignee: Tomoko Uchida >Priority: Minor > Fix For: 9.1, 10.0 (main) > > Attachments: Screenshot from 2021-12-12 14-40-41.png, Screenshot from > 2021-12-12 14-54-47.png > > Time Spent: 10m > Remaining Estimate: 0h > > (For completeness,) Luke should show KnnVector format information in the > index browsing tab. > If the type of a field is a KnnVector, > * Show flag "K" > * Show its dimension > * Show its similarity function > More rich support for the codec - decoding or searching - could come later; I > don't know if there are such use-cases. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
