[jira] [Commented] (GEODE-8442) Exception in server not identified correctly in client
[
https://issues.apache.org/jira/browse/GEODE-8442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17252687#comment-17252687
]
ASF GitHub Bot commented on GEODE-8442:
---
mkevo commented on a change in pull request #713:
URL: https://github.com/apache/geode-native/pull/713#discussion_r546570527
##
File path: cppcache/integration/test/ContainsKeyOnServerExceptionTest.cpp
##
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#include
+#include
+
+#include
+#include
+#include
+#include
+#include
+#include
+
+namespace {
+using apache::geode::client::Cache;
+using apache::geode::client::CacheableKey;
+using apache::geode::client::CacheableString;
+using apache::geode::client::CacheFactory;
+using apache::geode::client::CacheTransactionManager;
+using apache::geode::client::Pool;
+using apache::geode::client::Region;
+using apache::geode::client::RegionShortcut;
+
+std::string disconnectingStr("Disconnecting from the endpoint");
+
+std::string getClientLogName() {
+ std::string testSuiteName(::testing::UnitTest::GetInstance()
+->current_test_info()
+->test_case_name());
+ std::string testCaseName(
+ ::testing::UnitTest::GetInstance()->current_test_info()->name());
+ std::string logFileName(testSuiteName + "/" + testCaseName + "/client.log");
+ return logFileName;
+}
+
+std::shared_ptr createCache() {
+ auto cache = CacheFactory()
+ .set("log-level", "none")
+ .set("log-file", getClientLogName())
+ .create();
+ return std::make_shared(std::move(cache));
+}
+
+void executeTestCaseHandleException() {
+ Cluster cluster{
+ LocatorCount{1}, ServerCount{3},
+ CacheXMLFiles({
+ std::string(getFrameworkString(FrameworkVariable::TestCacheXmlDir)) +
+ "/cacheserver1_fpr_transaction.xml",
+ std::string(getFrameworkString(FrameworkVariable::TestCacheXmlDir)) +
+ "/cacheserver2_fpr_transaction.xml",
+ std::string(getFrameworkString(FrameworkVariable::TestCacheXmlDir)) +
+ "/cacheserver3_fpr_transaction.xml",
+ })};
+ cluster.start([&]() {
+cluster.getGfsh()
+.deploy()
+.jar(getFrameworkString(FrameworkVariable::JavaObjectJarPath))
+.execute();
+ });
+
+ auto cache = createCache();
+ auto poolFactory = cache->getPoolManager().createFactory();
+ ServerAddress serverAddress = cluster.getServers()[0].getAddress();
+ serverAddress.port = 40401;
+ cluster.applyServer(poolFactory, serverAddress);
+ auto pool = poolFactory.create("default");
+ auto region = cache->createRegionFactory(RegionShortcut::PROXY)
+.setPoolName("default")
+.create("region");
+
+ auto transactionManager = cache->getCacheTransactionManager();
+
+ // this key will be always routed towards server[1]
+ int theKey = 7;
+ std::string theValue = "theValue";
+ try {
Review comment:
I run it with your changes and it passed with the fix, and without the
fix it failed. So the test is ok and it works.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Exception in server not identified correctly in client
> --
>
> Key: GEODE-8442
> URL: https://issues.apache.org/jira/browse/GEODE-8442
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Alberto Bustamante Reyes
>Assignee: Mario Kevo
>Priority: Major
> Labels: needs-review, pull-request-available
>
> Native client is not identifying correctly an exception returned by the
> server.
> This is a log from an exception properly identified (I have introduced ""
> where I think I have to hide s
[jira] [Commented] (GEODE-7802) User Guide - add disclaimer that OQL queries are not pre-validated for nonexistent attributes
[ https://issues.apache.org/jira/browse/GEODE-7802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17252833#comment-17252833 ] ASF GitHub Bot commented on GEODE-7802: --- jvarenina commented on a change in pull request #5844: URL: https://github.com/apache/geode/pull/5844#discussion_r546686059 ## File path: geode-docs/developing/querying_basics/restrictions_and_unsupported_features.html.md.erb ## @@ -30,6 +30,6 @@ At a high level, <%=vars.product_name%> does not support the following querying - You cannot create an index on fields using Set/List types (Collection types) that are not comparable. The OQL index implementation expects fields to be Comparable. To workaround this, you can create a custom Collection type that implements Comparable. - ORDER BY is only supported with DISTINCT queries. - +- OQL queries aren't pre-validated for references to nonexistent methods and attributes. Review comment: Thank you both for comments and proposals. I have updated PR based on the @davebarnes97 proposal. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > User Guide - add disclaimer that OQL queries are not pre-validated for > nonexistent attributes > - > > Key: GEODE-7802 > URL: https://issues.apache.org/jira/browse/GEODE-7802 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Dave Barnes >Priority: Minor > Labels: pull-request-available > > Community member @deepak khopade requests that we add a disclaimer to the > user guide stating that OQL queries are not pre-screened for references to > nonexistent attributes. The assertion is that users who have experience with > other query models may expect Geode to apply such validation. In the Geode > model, attributes and methods are resolved at runtime during query execution > - the server does not know what's actually stored in a region until the query > is executed. > The disclaimer could be added in one of two places: > Query Language Restrictions and Unsupported Features > ([https://geode.apache.org/docs/guide/111/developing/querying_basics/restrictions_and_unsupported_features.html]) > or > Querying FAQ and Examples > ([https://geode.apache.org/docs/guide/111/getting_started/querying_quick_reference.html]) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8562) Add a new serialization test and example that uses a class for the key
[
https://issues.apache.org/jira/browse/GEODE-8562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17252935#comment-17252935
]
ASF GitHub Bot commented on GEODE-8562:
---
pivotal-jbarrett commented on a change in pull request #714:
URL: https://github.com/apache/geode-native/pull/714#discussion_r546789006
##
File path: cppcache/integration/test/Position.cpp
##
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#include "Position.hpp"
+
+#include
Review comment:
Still need these wide char includes?
##
File path: cppcache/integration/test/Position.cpp
##
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#include "Position.hpp"
+
+#include
+
+#include
+
+#include
+#include
+
+namespace DataSerializableTest {
+
+int32_t Position::cnt = 0;
+
+Position::Position()
+: avg20DaysVol(0),
+ convRatio(0.0),
+ valueGain(0.0),
+ industry(0),
+ issuer(0),
+ mktValue(0.0),
Review comment:
I would still like to see more readable variable names. The compiler
doesn't care how long the names are? ;) Also we should be following the naming
convention adopted by this project for new files.
```C++
...
marketValue_(0.0)
...
```
##
File path: cppcache/integration/test/PositionKey.hpp
##
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#pragma once
+
+#ifndef POSITIONKEY_H_
+#define POSITIONKEY_H_
+
+#include
+
+#include
+#include
+
+namespace DataSerializableTest {
+
+using apache::geode::client::CacheableKey;
+using apache::geode::client::DataInput;
+using apache::geode::client::DataOutput;
+using apache::geode::client::DataSerializable;
+
+class PositionKey : public DataSerializable, public CacheableKey {
+ private:
+ int64_t m_positionId;
Review comment:
Since this is a new class, even if it is copied from some older sources,
it should conform to our naming conventions.
```C++
int64_t positionId_;
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add a new serialization test and example that uses a class for the key
> --
>
> Key: GEODE-8562
> URL: https://issues.apache.org/jira/browse/GEODE-8562
> Pro
[jira] [Commented] (GEODE-7861) Improve error reporting when a member is unable to contact a locator
[
https://issues.apache.org/jira/browse/GEODE-7861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17252945#comment-17252945
]
ASF GitHub Bot commented on GEODE-7861:
---
bschuchardt commented on a change in pull request #5839:
URL: https://github.com/apache/geode/pull/5839#discussion_r546773728
##
File path:
geode-membership/src/integrationTest/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java
##
@@ -1441,24 +1435,74 @@ public void testCoordinatorFindRequestSuccess() throws
Exception {
public void testCoordinatorFindRequestFailure() throws Exception {
try {
initMocks(false);
- HashSet registrants = new HashSet<>();
- registrants.add(mockMembers[0]);
- FindCoordinatorResponse fcr = new
FindCoordinatorResponse(mockMembers[0], mockMembers[0],
- false, null, registrants, false, true, null);
+ mockRequestToServer(eq(new HostAndPort("localhost", 12346)));
GMSMembershipView view = createView();
JoinResponseMessage jrm = new JoinResponseMessage(mockMembers[0], view,
0);
gmsJoinLeave.setJoinResponseMessage(jrm);
- when(locatorClient.requestToServer(eq(new HostAndPort("localhost",
12346)),
- isA(FindCoordinatorRequest.class), anyInt(), anyBoolean()))
- .thenReturn(fcr);
-
- assertFalse("Should not be able to join ", gmsJoinLeave.join());
+ assertThatThrownBy(() -> gmsJoinLeave.join())
+ .isInstanceOf(MembershipConfigurationException.class);
} finally {
-
}
}
+ @Test
+ public void testJoinFailureWhenSleepInterrupted() throws Exception {
+initMocks(false);
+mockRequestToServer(isA(HostAndPort.class));
+
+when(mockConfig.getMemberTimeout()).thenReturn(100L);
+when(mockConfig.getJoinTimeout()).thenReturn(1000L);
+
+GMSJoinLeave spyGmsJoinLeave = spy(gmsJoinLeave);
+when(spyGmsJoinLeave.hasCoordinatorJoinedCluster(-1,
GMSJoinLeave.JOIN_RETRY_SLEEP))
+.thenThrow(new InterruptedException());
Review comment:
I like it - using a "when" to throw an InterruptedException
##
File path:
geode-membership/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSMembership.java
##
@@ -565,12 +565,7 @@ private void join() throws MemberStartupException {
this.isJoining = true; // added for bug #44373
// connect
-boolean ok = services.getJoinLeave().join();
-
-if (!ok) {
- throw new MembershipConfigurationException("Unable to join the
distributed system. "
- + "Operation either timed out, was stopped or Locator does not
exist.");
-}
+services.getJoinLeave().join();
Review comment:
nice change to make this a "void" method that throws an exception if it
doesn't succeed in joining the cluster
##
File path:
geode-membership/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java
##
@@ -428,6 +432,24 @@ public boolean join() throws MemberStartupException {
}
}
+ boolean hasCoordinatorJoinedCluster(int viewId, long retrySleep)
Review comment:
How about naming this something indicating that a sleep is going to be
performed, like "pauseIfThereIsNoCoordinator"?
##
File path:
geode-membership/src/main/java/org/apache/geode/distributed/internal/membership/gms/interfaces/JoinLeave.java
##
@@ -29,7 +29,7 @@
* joins the distributed system and returns true if successful, false if
not. Throws
Review comment:
This comment needs to be changed to reflect that the method now throws
an exception if it's unable to join the cluster. The comment should say which
exception is thrown. Should the exception be changed to be a checked exception
instead of a runtime exception?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Improve error reporting when a member is unable to contact a locator
>
>
> Key: GEODE-7861
> URL: https://issues.apache.org/jira/browse/GEODE-7861
> Project: Geode
> Issue Type: Improvement
> Components: membership
>Reporter: Dan Smith
>Assignee: Kamilla Aslami
>Priority: Major
> Labels: pull-request-available
>
> When a member is unable to contact a join the system due to a failure to
> contact a locator, we could be a lot more specific, which would help users
> debug issues in their environment. We currently print out
> {noformat}
> Unable to j
[jira] [Commented] (GEODE-8496) bump dependencies for 1.14
[ https://issues.apache.org/jira/browse/GEODE-8496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17252993#comment-17252993 ] Geode Integration commented on GEODE-8496: -- Seen in [WindowsCoreIntegrationTestOpenJDK8 #638|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/WindowsCoreIntegrationTestOpenJDK8/builds/638] ... see [test results|http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0571/test-results/integrationTest/1608363428/] or download [artifacts|http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0571/test-artifacts/1608363428/windows-coreintegrationtestfiles-OpenJDK8-1.14.0-build.0571.tgz]. > bump dependencies for 1.14 > -- > > Key: GEODE-8496 > URL: https://issues.apache.org/jira/browse/GEODE-8496 > Project: Geode > Issue Type: Improvement > Components: build >Reporter: Owen Nichols >Priority: Major > Labels: pull-request-available > Fix For: 1.14.0 > > > now is a good time in the lull between 1.13 and 1.14 to roll 3rd party > libraries to latest versions wherever possible. Doing this proactively helps > us stay ahead of CVEs and keep up with bugfixes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8496) bump dependencies for 1.14
[ https://issues.apache.org/jira/browse/GEODE-8496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17252997#comment-17252997 ] Geode Integration commented on GEODE-8496: -- Seen in [IntegrationTestOpenJDK8 #641|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/IntegrationTestOpenJDK8/builds/641] ... see [test results|http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0571/test-results/integrationTest/1608354206/] or download [artifacts|http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0571/test-artifacts/1608354206/integrationtestfiles-OpenJDK8-1.14.0-build.0571.tgz]. > bump dependencies for 1.14 > -- > > Key: GEODE-8496 > URL: https://issues.apache.org/jira/browse/GEODE-8496 > Project: Geode > Issue Type: Improvement > Components: build >Reporter: Owen Nichols >Priority: Major > Labels: pull-request-available > Fix For: 1.14.0 > > > now is a good time in the lull between 1.13 and 1.14 to roll 3rd party > libraries to latest versions wherever possible. Doing this proactively helps > us stay ahead of CVEs and keep up with bugfixes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8496) bump dependencies for 1.14
[ https://issues.apache.org/jira/browse/GEODE-8496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17252995#comment-17252995 ] Geode Integration commented on GEODE-8496: -- Seen in [WindowsCoreIntegrationTestOpenJDK8 #637|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/WindowsCoreIntegrationTestOpenJDK8/builds/637] ... see [test results|http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0570/test-results/integrationTest/1608363254/] or download [artifacts|http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0570/test-artifacts/1608363254/windows-coreintegrationtestfiles-OpenJDK8-1.14.0-build.0570.tgz]. > bump dependencies for 1.14 > -- > > Key: GEODE-8496 > URL: https://issues.apache.org/jira/browse/GEODE-8496 > Project: Geode > Issue Type: Improvement > Components: build >Reporter: Owen Nichols >Priority: Major > Labels: pull-request-available > Fix For: 1.14.0 > > > now is a good time in the lull between 1.13 and 1.14 to roll 3rd party > libraries to latest versions wherever possible. Doing this proactively helps > us stay ahead of CVEs and keep up with bugfixes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8496) bump dependencies for 1.14
[ https://issues.apache.org/jira/browse/GEODE-8496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17252996#comment-17252996 ] Geode Integration commented on GEODE-8496: -- Seen in [DistributedTestOpenJDK11 #677|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK11/builds/677] ... see [test results|http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0570/test-results/distributedTest/1608361552/] or download [artifacts|http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0570/test-artifacts/1608361552/distributedtestfiles-OpenJDK11-1.14.0-build.0570.tgz]. > bump dependencies for 1.14 > -- > > Key: GEODE-8496 > URL: https://issues.apache.org/jira/browse/GEODE-8496 > Project: Geode > Issue Type: Improvement > Components: build >Reporter: Owen Nichols >Priority: Major > Labels: pull-request-available > Fix For: 1.14.0 > > > now is a good time in the lull between 1.13 and 1.14 to roll 3rd party > libraries to latest versions wherever possible. Doing this proactively helps > us stay ahead of CVEs and keep up with bugfixes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8496) bump dependencies for 1.14
[ https://issues.apache.org/jira/browse/GEODE-8496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17252994#comment-17252994 ] Geode Integration commented on GEODE-8496: -- Seen in [IntegrationTestOpenJDK8 #640|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/IntegrationTestOpenJDK8/builds/640] ... see [test results|http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0570/test-results/integrationTest/1608353111/] or download [artifacts|http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0570/test-artifacts/1608353111/integrationtestfiles-OpenJDK8-1.14.0-build.0570.tgz]. > bump dependencies for 1.14 > -- > > Key: GEODE-8496 > URL: https://issues.apache.org/jira/browse/GEODE-8496 > Project: Geode > Issue Type: Improvement > Components: build >Reporter: Owen Nichols >Priority: Major > Labels: pull-request-available > Fix For: 1.14.0 > > > now is a good time in the lull between 1.13 and 1.14 to roll 3rd party > libraries to latest versions wherever possible. Doing this proactively helps > us stay ahead of CVEs and keep up with bugfixes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8737) Create new geode example about rest api
[ https://issues.apache.org/jira/browse/GEODE-8737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253050#comment-17253050 ] ASF GitHub Bot commented on GEODE-8737: --- upthewaterspout commented on pull request #104: URL: https://github.com/apache/geode-examples/pull/104#issuecomment-749143980 I think it's ok for the example if it leaves the key in place. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Create new geode example about rest api > --- > > Key: GEODE-8737 > URL: https://issues.apache.org/jira/browse/GEODE-8737 > Project: Geode > Issue Type: New Feature > Components: examples >Reporter: Ashish Choudhary >Assignee: Ashish Choudhary >Priority: Major > Labels: pull-request-available > > Create new example that demonstrate use of geode rest api. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8792) Support Universal builds on macOS
[ https://issues.apache.org/jira/browse/GEODE-8792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253088#comment-17253088 ] ASF GitHub Bot commented on GEODE-8792: --- pivotal-jbarrett commented on a change in pull request #701: URL: https://github.com/apache/geode-native/pull/701#discussion_r546172349 ## File path: dependencies/ACE/CMakeLists.txt ## @@ -13,9 +13,9 @@ # See the License for the specific language governing permissions and # limitations under the License. -project( ACE VERSION 6.5.9 LANGUAGES NONE ) +project( ACE VERSION 6.5.12 LANGUAGES NONE ) Review comment: It still compiles form arm just fine but doesn't detect macOS 11 on configure. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support Universal builds on macOS > - > > Key: GEODE-8792 > URL: https://issues.apache.org/jira/browse/GEODE-8792 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Jacob Barrett >Priority: Major > Labels: pull-request-available > > Support Universal builds (x86_64 and arm64) on recent macOS. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8792) Support Universal builds on macOS
[ https://issues.apache.org/jira/browse/GEODE-8792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253096#comment-17253096 ] ASF GitHub Bot commented on GEODE-8792: --- pivotal-jbarrett merged pull request #701: URL: https://github.com/apache/geode-native/pull/701 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support Universal builds on macOS > - > > Key: GEODE-8792 > URL: https://issues.apache.org/jira/browse/GEODE-8792 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Jacob Barrett >Priority: Major > Labels: pull-request-available > > Support Universal builds (x86_64 and arm64) on recent macOS. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8792) Support Universal builds on macOS
[ https://issues.apache.org/jira/browse/GEODE-8792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253098#comment-17253098 ] ASF subversion and git services commented on GEODE-8792: Commit 59cd01dfa87dcb8b2fe451472f75911ca93741b3 in geode-native's branch refs/heads/develop from Jacob Barrett [ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=59cd01d ] GEODE-8792: Adds support for MacOS Universal binaries. (#701) Specify CMAKE_OSX_ARCHITECTURES with multiple target architectures. * Updates ACE to 6.5.12 * Updates Boost to 1.75.0 * Updates Benchmark to 1.5.2 * Fix for statx in Travis CI for Docker > Support Universal builds on macOS > - > > Key: GEODE-8792 > URL: https://issues.apache.org/jira/browse/GEODE-8792 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Jacob Barrett >Priority: Major > Labels: pull-request-available > > Support Universal builds (x86_64 and arm64) on recent macOS. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-5922) SerialGatewaySenderQueue concurrency is poorly implemented
[ https://issues.apache.org/jira/browse/GEODE-5922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253135#comment-17253135 ] ASF GitHub Bot commented on GEODE-5922: --- bschuchardt opened a new pull request #5870: URL: https://github.com/apache/geode/pull/5870 reverting 3ed37a754d789bb52cf190db23088e819955fd58 for performance testing Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, check Concourse for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > SerialGatewaySenderQueue concurrency is poorly implemented > -- > > Key: GEODE-5922 > URL: https://issues.apache.org/jira/browse/GEODE-5922 > Project: Geode > Issue Type: Improvement > Components: wan >Reporter: Bruce J Schuchardt >Assignee: Bruce J Schuchardt >Priority: Major > Labels: pull-request-available > Fix For: 1.8.0 > > Time Spent: 20m > Remaining Estimate: 0h > > This class uses synchronization on the queue to limit access to one put at a > time. Synchronization isn't a fair locking mechanism so threads can be > blocked trying to add events to the queue while other more recent events get > the lock and insert their events. This causes inconsistent latency which > I've observed being as long as 30 seconds, causing client connections to be > shut down by the ClientHealthMonitor. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8496) bump dependencies for 1.14
[ https://issues.apache.org/jira/browse/GEODE-8496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253168#comment-17253168 ] ASF GitHub Bot commented on GEODE-8496: --- rhoughton-pivot opened a new pull request #5871: URL: https://github.com/apache/geode/pull/5871 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, check Concourse for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > bump dependencies for 1.14 > -- > > Key: GEODE-8496 > URL: https://issues.apache.org/jira/browse/GEODE-8496 > Project: Geode > Issue Type: Improvement > Components: build >Reporter: Owen Nichols >Priority: Major > Labels: pull-request-available > Fix For: 1.14.0 > > > now is a good time in the lull between 1.13 and 1.14 to roll 3rd party > libraries to latest versions wherever possible. Doing this proactively helps > us stay ahead of CVEs and keep up with bugfixes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8496) bump dependencies for 1.14
[ https://issues.apache.org/jira/browse/GEODE-8496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253182#comment-17253182 ] ASF GitHub Bot commented on GEODE-8496: --- onichols-pivotal merged pull request #5871: URL: https://github.com/apache/geode/pull/5871 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > bump dependencies for 1.14 > -- > > Key: GEODE-8496 > URL: https://issues.apache.org/jira/browse/GEODE-8496 > Project: Geode > Issue Type: Improvement > Components: build >Reporter: Owen Nichols >Priority: Major > Labels: pull-request-available > Fix For: 1.14.0 > > > now is a good time in the lull between 1.13 and 1.14 to roll 3rd party > libraries to latest versions wherever possible. Doing this proactively helps > us stay ahead of CVEs and keep up with bugfixes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8496) bump dependencies for 1.14
[ https://issues.apache.org/jira/browse/GEODE-8496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253183#comment-17253183 ] ASF GitHub Bot commented on GEODE-8496: --- onichols-pivotal merged pull request #5869: URL: https://github.com/apache/geode/pull/5869 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > bump dependencies for 1.14 > -- > > Key: GEODE-8496 > URL: https://issues.apache.org/jira/browse/GEODE-8496 > Project: Geode > Issue Type: Improvement > Components: build >Reporter: Owen Nichols >Priority: Major > Labels: pull-request-available > Fix For: 1.14.0 > > > now is a good time in the lull between 1.13 and 1.14 to roll 3rd party > libraries to latest versions wherever possible. Doing this proactively helps > us stay ahead of CVEs and keep up with bugfixes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8496) bump dependencies for 1.14
[ https://issues.apache.org/jira/browse/GEODE-8496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253187#comment-17253187 ] ASF subversion and git services commented on GEODE-8496: Commit 5fc2a0c305bde6f0423a54c52314397a75de2eaa in geode's branch refs/heads/develop from Owen Nichols [ https://gitbox.apache.org/repos/asf?p=geode.git;h=5fc2a0c ] GEODE-8496: more dependency bumps (#5869) * Bump guava from 30.0-jre to 30.1-jre * Bump micrometer-core from 1.6.1 to 1.6.2 * Bump netty-all from 4.1.54.Final to 4.1.56.Final * Bump json-path from 2.4.0 to 2.5.0 * Bump pmd from 6.29.0 to 6.30.0 * Bump compiler from 2.4.0 to 2.4.1 * Bump archunit from 0.14.1 to 0.15.0 * Bump tomcat from 8.5.60 to 8.5.61 * Bump tomcat from 9.0.40 to 9.0.41 * Bump cargo from 1.8.2 to 1.8.3 * Bump spring-boot-starter from 2.4.0 to 2.4.1 * Bump spring-hateoas from 1.2.1 to 1.2.2 * Bump jedis from 3.3.0 to 3.4.0 > bump dependencies for 1.14 > -- > > Key: GEODE-8496 > URL: https://issues.apache.org/jira/browse/GEODE-8496 > Project: Geode > Issue Type: Improvement > Components: build >Reporter: Owen Nichols >Priority: Major > Labels: pull-request-available > Fix For: 1.14.0 > > > now is a good time in the lull between 1.13 and 1.14 to roll 3rd party > libraries to latest versions wherever possible. Doing this proactively helps > us stay ahead of CVEs and keep up with bugfixes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8562) Add a new serialization test and example that uses a class for the key
[
https://issues.apache.org/jira/browse/GEODE-8562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253260#comment-17253260
]
ASF GitHub Bot commented on GEODE-8562:
---
mmartell commented on a change in pull request #714:
URL: https://github.com/apache/geode-native/pull/714#discussion_r547049677
##
File path: cppcache/integration/test/Position.cpp
##
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#include "Position.hpp"
+
+#include
+
+#include
+
+#include
+#include
+
+namespace DataSerializableTest {
+
+int32_t Position::cnt = 0;
+
+Position::Position()
+: avg20DaysVol(0),
+ convRatio(0.0),
+ valueGain(0.0),
+ industry(0),
+ issuer(0),
+ mktValue(0.0),
Review comment:
Good catch.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add a new serialization test and example that uses a class for the key
> --
>
> Key: GEODE-8562
> URL: https://issues.apache.org/jira/browse/GEODE-8562
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Michael Martell
>Priority: Major
> Labels: pull-request-available
>
> There appears to be no native client tests that use a class for the key.
> A new DataSerializable test should be added (new framework of course) that
> uses a class that implements DataSerializable for both the key and the value.
> Also, the test should be added for both C++ and .NET.
> Also update the existing put/get examples to include using a class as the
> key. Note, this will require Java code that instantiates the key class.
> Notes:
> *
> Using a class as a key requires the equivalent Java class to be deployed, as
> well as an Instantiator for that class to be executed by the server on
> startup. An example of this is the
> QueryTest::DataSerializableQueryHaveCorrectValues which uses Position.cs and
> Position.java.
> * In this existing test, Position.java needs to be deployed and instantiated
> because the test executes queries. In this new test, we need to deploy and
> instantiate the java code for the key class because it's a key not a value.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8562) Add a new serialization test and example that uses a class for the key
[
https://issues.apache.org/jira/browse/GEODE-8562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253261#comment-17253261
]
ASF GitHub Bot commented on GEODE-8562:
---
mmartell commented on a change in pull request #714:
URL: https://github.com/apache/geode-native/pull/714#discussion_r547049750
##
File path: cppcache/integration/test/PositionKey.hpp
##
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#pragma once
+
+#ifndef POSITIONKEY_H_
+#define POSITIONKEY_H_
+
+#include
+
+#include
+#include
+
+namespace DataSerializableTest {
+
+using apache::geode::client::CacheableKey;
+using apache::geode::client::DataInput;
+using apache::geode::client::DataOutput;
+using apache::geode::client::DataSerializable;
+
+class PositionKey : public DataSerializable, public CacheableKey {
+ private:
+ int64_t m_positionId;
Review comment:
Missed that.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add a new serialization test and example that uses a class for the key
> --
>
> Key: GEODE-8562
> URL: https://issues.apache.org/jira/browse/GEODE-8562
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Michael Martell
>Priority: Major
> Labels: pull-request-available
>
> There appears to be no native client tests that use a class for the key.
> A new DataSerializable test should be added (new framework of course) that
> uses a class that implements DataSerializable for both the key and the value.
> Also, the test should be added for both C++ and .NET.
> Also update the existing put/get examples to include using a class as the
> key. Note, this will require Java code that instantiates the key class.
> Notes:
> *
> Using a class as a key requires the equivalent Java class to be deployed, as
> well as an Instantiator for that class to be executed by the server on
> startup. An example of this is the
> QueryTest::DataSerializableQueryHaveCorrectValues which uses Position.cs and
> Position.java.
> * In this existing test, Position.java needs to be deployed and instantiated
> because the test executes queries. In this new test, we need to deploy and
> instantiate the java code for the key class because it's a key not a value.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8562) Add a new serialization test and example that uses a class for the key
[ https://issues.apache.org/jira/browse/GEODE-8562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253262#comment-17253262 ] ASF GitHub Bot commented on GEODE-8562: --- mmartell commented on a change in pull request #714: URL: https://github.com/apache/geode-native/pull/714#discussion_r547049836 ## File path: cppcache/integration/test/Position.cpp ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +#include "Position.hpp" + +#include Review comment: Dang. Thought I removed those already. Good catch. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add a new serialization test and example that uses a class for the key > -- > > Key: GEODE-8562 > URL: https://issues.apache.org/jira/browse/GEODE-8562 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Michael Martell >Priority: Major > Labels: pull-request-available > > There appears to be no native client tests that use a class for the key. > A new DataSerializable test should be added (new framework of course) that > uses a class that implements DataSerializable for both the key and the value. > Also, the test should be added for both C++ and .NET. > Also update the existing put/get examples to include using a class as the > key. Note, this will require Java code that instantiates the key class. > Notes: > * > Using a class as a key requires the equivalent Java class to be deployed, as > well as an Instantiator for that class to be executed by the server on > startup. An example of this is the > QueryTest::DataSerializableQueryHaveCorrectValues which uses Position.cs and > Position.java. > * In this existing test, Position.java needs to be deployed and instantiated > because the test executes queries. In this new test, we need to deploy and > instantiate the java code for the key class because it's a key not a value. -- This message was sent by Atlassian Jira (v8.3.4#803005)
