[
https://issues.apache.org/jira/browse/GEODE-8562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253262#comment-17253262
]
ASF GitHub Bot commented on GEODE-8562:
---------------------------------------
mmartell commented on a change in pull request #714:
URL: https://github.com/apache/geode-native/pull/714#discussion_r547049836
##########
File path: cppcache/integration/test/Position.cpp
##########
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#include "Position.hpp"
+
+#include <wchar.h>
Review comment:
Dang. Thought I removed those already. Good catch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add a new serialization test and example that uses a class for the key
> ----------------------------------------------------------------------
>
> Key: GEODE-8562
> URL: https://issues.apache.org/jira/browse/GEODE-8562
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Michael Martell
> Priority: Major
> Labels: pull-request-available
>
> There appears to be no native client tests that use a class for the key.
> A new DataSerializable test should be added (new framework of course) that
> uses a class that implements DataSerializable for both the key and the value.
> Also, the test should be added for both C++ and .NET.
> Also update the existing put/get examples to include using a class as the
> key. Note, this will require Java code that instantiates the key class.
> Notes:
> *
> Using a class as a key requires the equivalent Java class to be deployed, as
> well as an Instantiator for that class to be executed by the server on
> startup. An example of this is the
> QueryTest::DataSerializableQueryHaveCorrectValues which uses Position.cs and
> Position.java.
> * In this existing test, Position.java needs to be deployed and instantiated
> because the test executes queries. In this new test, we need to deploy and
> instantiate the java code for the key class because it's a key not a value.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
