[
https://issues.apache.org/jira/browse/GEODE-5922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253135#comment-17253135
]
ASF GitHub Bot commented on GEODE-5922:
---------------------------------------
bschuchardt opened a new pull request #5870:
URL: https://github.com/apache/geode/pull/5870
reverting 3ed37a754d789bb52cf190db23088e819955fd58 for performance testing
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to d...@geode.apache.org.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> SerialGatewaySenderQueue concurrency is poorly implemented
> ----------------------------------------------------------
>
> Key: GEODE-5922
> URL: https://issues.apache.org/jira/browse/GEODE-5922
> Project: Geode
> Issue Type: Improvement
> Components: wan
> Reporter: Bruce J Schuchardt
> Assignee: Bruce J Schuchardt
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.8.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> This class uses synchronization on the queue to limit access to one put at a
> time. Synchronization isn't a fair locking mechanism so threads can be
> blocked trying to add events to the queue while other more recent events get
> the lock and insert their events. This causes inconsistent latency which
> I've observed being as long as 30 seconds, causing client connections to be
> shut down by the ClientHealthMonitor.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
