[jira] [Updated] (GEODE-8157) Write "drop proxy test" for C# (clicache)
[ https://issues.apache.org/jira/browse/GEODE-8157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-8157: -- Labels: pull-request-available (was: ) > Write "drop proxy test" for C# (clicache) > - > > Key: GEODE-8157 > URL: https://issues.apache.org/jira/browse/GEODE-8157 > Project: Geode > Issue Type: New Feature > Components: native client >Reporter: Blake Bender >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8157) Write "drop proxy test" for C# (clicache)
[ https://issues.apache.org/jira/browse/GEODE-8157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17213931#comment-17213931 ] ASF GitHub Bot commented on GEODE-8157: --- mmartell opened a new pull request #674: URL: https://github.com/apache/geode-native/pull/674 This adds a new DropProxy test to the docker based acceptance tests for .NET. Note: This test will only run on Windows platforms that have docker and docker-compose installed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Write "drop proxy test" for C# (clicache) > - > > Key: GEODE-8157 > URL: https://issues.apache.org/jira/browse/GEODE-8157 > Project: Geode > Issue Type: New Feature > Components: native client >Reporter: Blake Bender >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8607) Add new API for getting oldest tombstone age.
[ https://issues.apache.org/jira/browse/GEODE-8607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214054#comment-17214054 ] ASF GitHub Bot commented on GEODE-8607: --- mhansonp opened a new pull request #5623: URL: https://github.com/apache/geode/pull/5623 - Need an API to tell how many how long until the oldest tombstone expires. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add new API for getting oldest tombstone age. > - > > Key: GEODE-8607 > URL: https://issues.apache.org/jira/browse/GEODE-8607 > Project: Geode > Issue Type: Bug > Components: core >Reporter: Mark Hanson >Priority: Major > > It would be handy in diagnosing certain issues. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8607) Add new API for getting oldest tombstone age.
[ https://issues.apache.org/jira/browse/GEODE-8607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-8607: -- Labels: pull-request-available (was: ) > Add new API for getting oldest tombstone age. > - > > Key: GEODE-8607 > URL: https://issues.apache.org/jira/browse/GEODE-8607 > Project: Geode > Issue Type: Bug > Components: core >Reporter: Mark Hanson >Priority: Major > Labels: pull-request-available > > It would be handy in diagnosing certain issues. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7864) Code improvement refactoring
[
https://issues.apache.org/jira/browse/GEODE-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214058#comment-17214058
]
ASF GitHub Bot commented on GEODE-7864:
---
DonalEvans commented on a change in pull request #5582:
URL: https://github.com/apache/geode/pull/5582#discussion_r504835943
##
File path:
geode-tcp-server/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpClient.java
##
@@ -200,21 +200,28 @@ public Object requestToServer(HostAndPort addr, Object
request, int timeout,
out.flush();
if (replyExpected) {
-DataInputStream in = new DataInputStream(sock.getInputStream());
-if (debugVersionMessage != null && logger.isDebugEnabled()) {
- logger.debug(debugVersionMessage);
-}
-in = new VersionedDataInputStream(in, serverVersion);
+DataInputStream in = null;
try {
Review comment:
Good catch, thanks.
##
File path:
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/DeployCommand.java
##
@@ -101,26 +101,36 @@ public ResultModel deploy(
for (DistributedMember member : targetMembers) {
List remoteStreams = new ArrayList<>();
List jarNames = new ArrayList<>();
- for (String jarFullPath : jarFullPaths) {
-remoteStreams
-.add(exporter.export(new SimpleRemoteInputStream(new
FileInputStream(jarFullPath;
-jarNames.add(FilenameUtils.getName(jarFullPath));
- }
-
- // this deploys the jars to all the matching servers
- ResultCollector resultCollector =
- executeFunction(this.deployFunction, new Object[] {jarNames,
remoteStreams}, member);
-
- @SuppressWarnings("unchecked")
- final List> resultCollectorResult =
- (List>) resultCollector.getResult();
- results.add(resultCollectorResult.get(0));
+ try {
+for (String jarFullPath : jarFullPaths) {
+ FileInputStream fileInputStream = null;
+ try {
+fileInputStream = new FileInputStream(jarFullPath);
+remoteStreams.add(exporter.export(new
SimpleRemoteInputStream(fileInputStream)));
+jarNames.add(FilenameUtils.getName(jarFullPath));
+ } catch (Exception ex) {
+if (fileInputStream != null) {
+ fileInputStream.close();
Review comment:
Fixed
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Code improvement refactoring
>
>
> Key: GEODE-7864
> URL: https://issues.apache.org/jira/browse/GEODE-7864
> Project: Geode
> Issue Type: Improvement
>Reporter: Nabarun Nag
>Priority: Major
> Labels: pull-request-available
> Time Spent: 13h 10m
> Remaining Estimate: 0h
>
> This is a placeholder ticket.
> * this is used to do refactoring.
> * this ticket number is used to number the commit message.
> * this ticket will never be closed.
> * it will be used to mark improvements like correcting spelling mistakes,
> efficient java code, etc.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8157) Write "drop proxy test" for C# (clicache)
[ https://issues.apache.org/jira/browse/GEODE-8157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214098#comment-17214098 ] ASF GitHub Bot commented on GEODE-8157: --- moleske commented on a change in pull request #674: URL: https://github.com/apache/geode-native/pull/674#discussion_r504859727 ## File path: clicache/acceptance-test/SNITests.cs ## @@ -90,7 +91,18 @@ private int ParseProxyPort(string proxyString) return Int32.Parse(portNumberString); } -[Fact] + + //private Task PutAsync(IRegion region) Review comment: Alas, poor commented code! I knew it, @mmartell : a line of async puts, of most excellent fancy: it hath borne me on its back a thousand times; and now, how abhorred in my imagination it is! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Write "drop proxy test" for C# (clicache) > - > > Key: GEODE-8157 > URL: https://issues.apache.org/jira/browse/GEODE-8157 > Project: Geode > Issue Type: New Feature > Components: native client >Reporter: Blake Bender >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7864) Code improvement refactoring
[ https://issues.apache.org/jira/browse/GEODE-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214104#comment-17214104 ] ASF GitHub Bot commented on GEODE-7864: --- lgtm-com[bot] commented on pull request #5582: URL: https://github.com/apache/geode/pull/5582#issuecomment-708559861 This pull request **fixes 108 alerts** when merging 5e5e94d439930cfb44929228206e76f89d083d36 into b16709437c8b2f85bfad53a713fde1b9ae1f3903 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-409cec7c9d3b5a147d807c89271ed5acb35390b7) **fixed alerts:** * 68 for Potential input resource leak * 40 for Potential output resource leak This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Code improvement refactoring > > > Key: GEODE-7864 > URL: https://issues.apache.org/jira/browse/GEODE-7864 > Project: Geode > Issue Type: Improvement >Reporter: Nabarun Nag >Priority: Major > Labels: pull-request-available > Time Spent: 13h 10m > Remaining Estimate: 0h > > This is a placeholder ticket. > * this is used to do refactoring. > * this ticket number is used to number the commit message. > * this ticket will never be closed. > * it will be used to mark improvements like correcting spelling mistakes, > efficient java code, etc. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-8608) StateFlush could hang when the target member is shutdown
Xiaojian Zhou created GEODE-8608: Summary: StateFlush could hang when the target member is shutdown Key: GEODE-8608 URL: https://issues.apache.org/jira/browse/GEODE-8608 Project: Geode Issue Type: Bug Components: membership Reporter: Xiaojian Zhou This was introduced by GEODE-8385. When the StateFlushReplyProcessor is wait for a reply of the target member, if that member shuts down, the StateFlushReplyProcessor could wait forever for that member to reply even though the member no longer in the view. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8608) StateFlush could hang when the target member is shutdown
[ https://issues.apache.org/jira/browse/GEODE-8608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214112#comment-17214112 ] ASF subversion and git services commented on GEODE-8608: Commit 3be1dd6bbc6ce92ce63b7d615eb7c61d6cc46f82 in geode's branch refs/heads/feature/GEODE-8608 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=3be1dd6 ] GEODE-8608: StateFlush could hang when the target member is shutdown Co-authored-by: Darrel Schneider Co-authored-by: Anil Co-authored-by: Bill Burcham > StateFlush could hang when the target member is shutdown > > > Key: GEODE-8608 > URL: https://issues.apache.org/jira/browse/GEODE-8608 > Project: Geode > Issue Type: Bug > Components: membership >Reporter: Xiaojian Zhou >Priority: Major > Labels: pull-request-available > > This was introduced by GEODE-8385. > When the StateFlushReplyProcessor is wait for a reply of the target member, > if that member shuts down, the StateFlushReplyProcessor could wait forever > for that member to reply even though the member no longer in the view. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8608) StateFlush could hang when the target member is shutdown
[ https://issues.apache.org/jira/browse/GEODE-8608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-8608: -- Labels: pull-request-available (was: ) > StateFlush could hang when the target member is shutdown > > > Key: GEODE-8608 > URL: https://issues.apache.org/jira/browse/GEODE-8608 > Project: Geode > Issue Type: Bug > Components: membership >Reporter: Xiaojian Zhou >Priority: Major > Labels: pull-request-available > > This was introduced by GEODE-8385. > When the StateFlushReplyProcessor is wait for a reply of the target member, > if that member shuts down, the StateFlushReplyProcessor could wait forever > for that member to reply even though the member no longer in the view. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8608) StateFlush could hang when the target member is shutdown
[ https://issues.apache.org/jira/browse/GEODE-8608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214111#comment-17214111 ] ASF GitHub Bot commented on GEODE-8608: --- gesterzhou opened a new pull request #5624: URL: https://github.com/apache/geode/pull/5624 Co-authored-by: Darrel Schneider Co-authored-by: Anil Co-authored-by: Bill Burcham Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, check Concourse for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > StateFlush could hang when the target member is shutdown > > > Key: GEODE-8608 > URL: https://issues.apache.org/jira/browse/GEODE-8608 > Project: Geode > Issue Type: Bug > Components: membership >Reporter: Xiaojian Zhou >Priority: Major > > This was introduced by GEODE-8385. > When the StateFlushReplyProcessor is wait for a reply of the target member, > if that member shuts down, the StateFlushReplyProcessor could wait forever > for that member to reply even though the member no longer in the view. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-8609) Create a dunit suspect file per VM
Jens Deppe created GEODE-8609:
-
Summary: Create a dunit suspect file per VM
Key: GEODE-8609
URL: https://issues.apache.org/jira/browse/GEODE-8609
Project: Geode
Issue Type: Test
Reporter: Jens Deppe
In some situations, especially when restarting Dunit VMs, it appears that the
suspect log file can be corrupted since suspect processing reports errors such
as:
{noformat}
org.apache.geode.redis.internal.executor.CrashAndNoRepeatDUnitTest >
classMethod FAILED
java.lang.AssertionError: Suspicious strings were written to the log during
this run.
Fix the strings or use IgnoredException.addIgnoredException to ignore.
---
Found suspect string in log4j at line 19594
/home/geode/.gradle/caches/modules-2/files-2.1/antlr/antlr/2.7.7/83cd2cd674a21[warn
2020/10/11 15:23:24.988 GMT tid=105] Execution of
Redis command APPEND append-key-1 -append-key-1-17484- failed:
org.apache.geode.cache.execute.FunctionException:
org.apache.geode.cache.execute.FunctionInvocationTargetException:
memberDeparted event for < 172.17.0.20(server-3:2004):41003 > crashed,
true{noformat}
Where the suspected string is corrupted.
The proposed fix will create a new dunit_suspect log for each VM. The logs will
now be named {{dunit_suspect-vm.log}}. The {{locator}} vm and the test
runner vm will have logs named {{dunit_suspect-locator.log}} and
{{dunit_suspect-local.log}} respectively.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (GEODE-8609) Create a dunit suspect file per VM
[
https://issues.apache.org/jira/browse/GEODE-8609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Deppe reassigned GEODE-8609:
-
Assignee: Jens Deppe
> Create a dunit suspect file per VM
> --
>
> Key: GEODE-8609
> URL: https://issues.apache.org/jira/browse/GEODE-8609
> Project: Geode
> Issue Type: Test
>Reporter: Jens Deppe
>Assignee: Jens Deppe
>Priority: Major
>
> In some situations, especially when restarting Dunit VMs, it appears that the
> suspect log file can be corrupted since suspect processing reports errors
> such as:
> {noformat}
> org.apache.geode.redis.internal.executor.CrashAndNoRepeatDUnitTest >
> classMethod FAILED
> java.lang.AssertionError: Suspicious strings were written to the log
> during this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in log4j at line 19594
> /home/geode/.gradle/caches/modules-2/files-2.1/antlr/antlr/2.7.7/83cd2cd674a21[warn
> 2020/10/11 15:23:24.988 GMT tid=105] Execution
> of Redis command APPEND append-key-1 -append-key-1-17484- failed:
> org.apache.geode.cache.execute.FunctionException:
> org.apache.geode.cache.execute.FunctionInvocationTargetException:
> memberDeparted event for < 172.17.0.20(server-3:2004):41003 > crashed,
> true{noformat}
> Where the suspected string is corrupted.
> The proposed fix will create a new dunit_suspect log for each VM. The logs
> will now be named {{dunit_suspect-vm.log}}. The {{locator}} vm and the
> test runner vm will have logs named {{dunit_suspect-locator.log}} and
> {{dunit_suspect-local.log}} respectively.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (GEODE-8609) Create a dunit suspect file per VM
[
https://issues.apache.org/jira/browse/GEODE-8609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Deppe updated GEODE-8609:
--
Component/s: tests
> Create a dunit suspect file per VM
> --
>
> Key: GEODE-8609
> URL: https://issues.apache.org/jira/browse/GEODE-8609
> Project: Geode
> Issue Type: Test
> Components: tests
>Reporter: Jens Deppe
>Assignee: Jens Deppe
>Priority: Major
>
> In some situations, especially when restarting Dunit VMs, it appears that the
> suspect log file can be corrupted since suspect processing reports errors
> such as:
> {noformat}
> org.apache.geode.redis.internal.executor.CrashAndNoRepeatDUnitTest >
> classMethod FAILED
> java.lang.AssertionError: Suspicious strings were written to the log
> during this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in log4j at line 19594
> /home/geode/.gradle/caches/modules-2/files-2.1/antlr/antlr/2.7.7/83cd2cd674a21[warn
> 2020/10/11 15:23:24.988 GMT tid=105] Execution
> of Redis command APPEND append-key-1 -append-key-1-17484- failed:
> org.apache.geode.cache.execute.FunctionException:
> org.apache.geode.cache.execute.FunctionInvocationTargetException:
> memberDeparted event for < 172.17.0.20(server-3:2004):41003 > crashed,
> true{noformat}
> Where the suspected string is corrupted.
> The proposed fix will create a new dunit_suspect log for each VM. The logs
> will now be named {{dunit_suspect-vm.log}}. The {{locator}} vm and the
> test runner vm will have logs named {{dunit_suspect-locator.log}} and
> {{dunit_suspect-local.log}} respectively.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (GEODE-8609) Create a dunit suspect file per VM
[
https://issues.apache.org/jira/browse/GEODE-8609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated GEODE-8609:
--
Labels: pull-request-available (was: )
> Create a dunit suspect file per VM
> --
>
> Key: GEODE-8609
> URL: https://issues.apache.org/jira/browse/GEODE-8609
> Project: Geode
> Issue Type: Test
> Components: tests
>Reporter: Jens Deppe
>Assignee: Jens Deppe
>Priority: Major
> Labels: pull-request-available
>
> In some situations, especially when restarting Dunit VMs, it appears that the
> suspect log file can be corrupted since suspect processing reports errors
> such as:
> {noformat}
> org.apache.geode.redis.internal.executor.CrashAndNoRepeatDUnitTest >
> classMethod FAILED
> java.lang.AssertionError: Suspicious strings were written to the log
> during this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in log4j at line 19594
> /home/geode/.gradle/caches/modules-2/files-2.1/antlr/antlr/2.7.7/83cd2cd674a21[warn
> 2020/10/11 15:23:24.988 GMT tid=105] Execution
> of Redis command APPEND append-key-1 -append-key-1-17484- failed:
> org.apache.geode.cache.execute.FunctionException:
> org.apache.geode.cache.execute.FunctionInvocationTargetException:
> memberDeparted event for < 172.17.0.20(server-3:2004):41003 > crashed,
> true{noformat}
> Where the suspected string is corrupted.
> The proposed fix will create a new dunit_suspect log for each VM. The logs
> will now be named {{dunit_suspect-vm.log}}. The {{locator}} vm and the
> test runner vm will have logs named {{dunit_suspect-locator.log}} and
> {{dunit_suspect-local.log}} respectively.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8609) Create a dunit suspect file per VM
[
https://issues.apache.org/jira/browse/GEODE-8609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214129#comment-17214129
]
ASF GitHub Bot commented on GEODE-8609:
---
jdeppe-pivotal opened a new pull request #5625:
URL: https://github.com/apache/geode/pull/5625
- Create a new `dunit_suspect` log for each VM. The logs will now
be named `dunit_suspect-vm.log`. The locator VM and the test
runner VM will have logs named `dunit_suspect-locator.log` and
`dunit_suspect-local.log` respectively.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to d...@geode.apache.org.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Create a dunit suspect file per VM
> --
>
> Key: GEODE-8609
> URL: https://issues.apache.org/jira/browse/GEODE-8609
> Project: Geode
> Issue Type: Test
> Components: tests
>Reporter: Jens Deppe
>Assignee: Jens Deppe
>Priority: Major
>
> In some situations, especially when restarting Dunit VMs, it appears that the
> suspect log file can be corrupted since suspect processing reports errors
> such as:
> {noformat}
> org.apache.geode.redis.internal.executor.CrashAndNoRepeatDUnitTest >
> classMethod FAILED
> java.lang.AssertionError: Suspicious strings were written to the log
> during this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in log4j at line 19594
> /home/geode/.gradle/caches/modules-2/files-2.1/antlr/antlr/2.7.7/83cd2cd674a21[warn
> 2020/10/11 15:23:24.988 GMT tid=105] Execution
> of Redis command APPEND append-key-1 -append-key-1-17484- failed:
> org.apache.geode.cache.execute.FunctionException:
> org.apache.geode.cache.execute.FunctionInvocationTargetException:
> memberDeparted event for < 172.17.0.20(server-3:2004):41003 > crashed,
> true{noformat}
> Where the suspected string is corrupted.
> The proposed fix will create a new dunit_suspect log for each VM. The logs
> will now be named {{dunit_suspect-vm.log}}. The {{locator}} vm and the
> test runner vm will have logs named {{dunit_suspect-locator.log}} and
> {{dunit_suspect-local.log}} respectively.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class
[ https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214132#comment-17214132 ] ASF subversion and git services commented on GEODE-8173: Commit 65a90168defa3e11352cc8143c621bafc3f31296 in geode's branch refs/heads/feature/GEODE-7665 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=65a9016 ] GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208) * GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. Co-authored-by: anilkumar gingade > Add test coverage for PartitionedRegionClear class > -- > > Key: GEODE-8173 > URL: https://issues.apache.org/jira/browse/GEODE-8173 > Project: Geode > Issue Type: Bug > Components: regions >Reporter: Anilkumar Gingade >Priority: Major > Labels: GeodeOperationAPI > Fix For: 1.14.0 > > > Add test coverage for PartitionedRegionClear class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear
[ https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214134#comment-17214134 ] ASF subversion and git services commented on GEODE-8334: Commit 5948b185a9f73ad8e12f01d449e2f1ec4d07bc62 in geode's branch refs/heads/feature/GEODE-7665 from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=5948b18 ] GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock (#5365) Co-authored-by: Xiaojian Zhou Co-authored-by: Anil Gingade > Primary and secondary bucket data mismatch with concurrent putAll/removeAll > and PR.clear > - > > Key: GEODE-8334 > URL: https://issues.apache.org/jira/browse/GEODE-8334 > Project: Geode > Issue Type: Sub-task > Components: regions >Affects Versions: 1.14.0 >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeOperationAPI > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8361) Incorrect Bucket Count Warning Message Shown
[
https://issues.apache.org/jira/browse/GEODE-8361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214135#comment-17214135
]
ASF subversion and git services commented on GEODE-8361:
Commit 26396332807e56fa7d4d45992967bf73ebc0bb7c in geode's branch
refs/heads/feature/GEODE-7665 from Donal Evans
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=2639633 ]
GEODE-8361: Use Set instead of List to track cleared buckets (#5379)
- Refactor PartitionRegionClear to use Set instead of List
- Some other changes to remove warnings/alerts from PartitionedRegionClear and
PartitionedRegionClearMessage
Authored-by: Donal Evans
> Incorrect Bucket Count Warning Message Shown
>
>
> Key: GEODE-8361
> URL: https://issues.apache.org/jira/browse/GEODE-8361
> Project: Geode
> Issue Type: Sub-task
> Components: logging
>Reporter: Juan Ramos
>Assignee: Donal Evans
>Priority: Trivial
> Labels: pull-request-available
> Fix For: 1.14.0
>
>
> While analysing some failures related to GEODE-7670, I've noticed that
> sometimes we report an incorrect bucket count within the warning message
> logged when the clear didn't complete successfully that could confuse our
> users.
> For this test the partition region always has 13 buckets so, as I user, I
> would never expect to see a bucket count higher than 13 in my logs (no matter
> how many redundant copies I have).
> ---
> Below are some examples:
> {noformat}
> [vm1] [warn 2020/07/15 11:56:17.739 GMT Connection(5)-172.17.0.5> tid=0x5f] Unable to clear all the buckets from
> the partitioned region PartitionedRegion, either data (buckets) moved or
> member departed. expected to clear number of buckets: 13 actual cleared: 26
> [vm1] [warn 2020/07/15 11:57:48.403 GMT Connection(6)-172.17.0.9> tid=0x10f] Unable to clear all the buckets from
> the partitioned region PartitionedRegion, either data (buckets) moved or
> member departed. expected to clear number of buckets: 13 actual cleared: 14
> [vm0] [warn 2020/07/15 12:07:36.227 GMT Connection(32)-172.17.0.25> tid=0x1fe] Unable to clear all the buckets
> from the partitioned region PartitionedRegion, either data (buckets) moved or
> member departed. expected to clear number of buckets: 13 actual cleared: 19
> [vm0] [warn 2020/07/15 12:08:56.277 GMT Connection(37)-172.17.0.24> tid=0x2a2] Unable to clear all the buckets
> from the partitioned region PartitionedRegion, either data (buckets) moved or
> member departed. expected to clear number of buckets: 13 actual cleared: 16
> {noformat}
> The full set of artefacts and results:
> {noformat}
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> http://files.apachegeode-ci.info/builds/apache-develop-pr/geode-pr-4848/test-results/repeatTest/1594816968/
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> Test report artifacts from this job are available at:
> http://files.apachegeode-ci.info/builds/apache-develop-pr/geode-pr-4848/test-artifacts/1594816968/stressnewtestfiles-geode-pr-4848.tgz
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class
[ https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214133#comment-17214133 ] ASF subversion and git services commented on GEODE-8173: Commit 65a90168defa3e11352cc8143c621bafc3f31296 in geode's branch refs/heads/feature/GEODE-7665 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=65a9016 ] GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208) * GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. Co-authored-by: anilkumar gingade > Add test coverage for PartitionedRegionClear class > -- > > Key: GEODE-8173 > URL: https://issues.apache.org/jira/browse/GEODE-8173 > Project: Geode > Issue Type: Bug > Components: regions >Reporter: Anilkumar Gingade >Priority: Major > Labels: GeodeOperationAPI > Fix For: 1.14.0 > > > Add test coverage for PartitionedRegionClear class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7670) Partitioned Region clear operations can occur during concurrent data operations
[ https://issues.apache.org/jira/browse/GEODE-7670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214136#comment-17214136 ] ASF subversion and git services commented on GEODE-7670: Commit 7d6c0504077a03d9411396ac8736cf7b962b0575 in geode's branch refs/heads/feature/GEODE-7665 from Juan José Ramos [ https://gitbox.apache.org/repos/asf?p=geode.git;h=7d6c050 ] GEODE-7670: PR Clear with Concurrent Ops DUnitTests (#4848) Added distributed tests to verify that the clear operation on Partitioned Regions works as expected when there are other concurrent operations happening on the cache (put, putAll, get, remove, removeAll, members added and members removed). > Partitioned Region clear operations can occur during concurrent data > operations > --- > > Key: GEODE-7670 > URL: https://issues.apache.org/jira/browse/GEODE-7670 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Juan Ramos >Priority: Major > Labels: GeodeCommons, pull-request-available > Time Spent: 5.5h > Remaining Estimate: 0h > > Clear operations are successful when concurrent read/write operations occur. > Ensure there are test coverage for this use case and modify the code needed > to enable this. > Acceptance : > * Passing DUnit tests where clear operations are successful on partitioned > region with > * concurrent puts (writes) and clear op > * concurrent gets (reads) and clear op > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7846) Clear in Partitioned Region should have its own stats
[ https://issues.apache.org/jira/browse/GEODE-7846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214138#comment-17214138 ] ASF subversion and git services commented on GEODE-7846: Commit 91b19ccbc345d49483151e889b6e354634e187a7 in geode's branch refs/heads/feature/GEODE-7665 from BenjaminPerryRoss [ https://gitbox.apache.org/repos/asf?p=geode.git;h=91b19cc ] GEODE-7846: Adding Stats for Partitioned Region Clear (#5391) Added stats to CachePerfStats for PR Clear - Changed clears to 'regionClears' and 'bucketClears' to differentiate between the number of times the region was cleared and the number of times a bucket was cleared in a PartitionedRegion - Added Local and Total duration stats to record how long clear has been running for a specific region, as well as how long it was spent clearing any specific member > Clear in Partitioned Region should have its own stats > - > > Key: GEODE-7846 > URL: https://issues.apache.org/jira/browse/GEODE-7846 > Project: Geode > Issue Type: Improvement > Components: core >Reporter: Xiaojian Zhou >Assignee: Benjamin P Ross >Priority: Major > Labels: GeodeCommons, GeodeOperationAPI, pull-request-available > > Clear operation in PR should have its own stats: > 1) clear operation executed. > 2) clear operation failed > 3) clear messages sends to buckets -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7672) Partitioned Region clear will successfully update the OQL indexes
[ https://issues.apache.org/jira/browse/GEODE-7672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214139#comment-17214139 ] ASF subversion and git services commented on GEODE-7672: Commit 4bf638afb85840636f9fc35107afbed8122ce6b8 in geode's branch refs/heads/feature/GEODE-7665 from Jinmei Liao [ https://gitbox.apache.org/repos/asf?p=geode.git;h=4bf638a ] GEODE-7672: add dunit test to verify OQL index after PR clear. (#5436) * require rvv lock when create index > Partitioned Region clear will successfully update the OQL indexes > - > > Key: GEODE-7672 > URL: https://issues.apache.org/jira/browse/GEODE-7672 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Jianxia Chen >Priority: Major > Labels: GeodeCommons, pull-request-available > > Clear operations are successfully updates the OQL indexes > > Acceptance : > * Passing Dunit tests where OQL queries using indexes return correct results > after the region is cleared > * clear operation and index updates are successful when clear operation is > executed when the puts are occurring which are trying to update the OQL index. > * Unit tests to ensure that index sizes are zero after the region is cleaned > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > > analyze if these tests are needed for offheap? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7845) Rollingupgrade should not conflict with the new ClearPRMessage
[ https://issues.apache.org/jira/browse/GEODE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214140#comment-17214140 ] ASF subversion and git services commented on GEODE-7845: Commit 68d7c308d9ae070351a0e3045b04bcaf9636537d in geode's branch refs/heads/feature/GEODE-7665 from mhansonp [ https://gitbox.apache.org/repos/asf?p=geode.git;h=68d7c30 ] GEODE-7845 blocking PR region clear if one or more server versions are too old (#5577) - if a server is running an old version when a PR clear is invoked by the client, the client will receive a ServerOperationException with a cause of ServerVersionMismatchException. > Rollingupgrade should not conflict with the new ClearPRMessage > --- > > Key: GEODE-7845 > URL: https://issues.apache.org/jira/browse/GEODE-7845 > Project: Geode > Issue Type: Improvement > Components: core >Reporter: Xiaojian Zhou >Assignee: Mark Hanson >Priority: Major > Labels: GeodeCommons, pull-request-available > > PartitionedRegion clear introduced a new ClearPRMessage. In case of doing > rolling upgrade, the user called PR.clear. The new ClearPRMessage should not > fail. It should not be sent to the old members. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7680) Partitioned region clear operations must be successful while interacting with rebalance
[ https://issues.apache.org/jira/browse/GEODE-7680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214137#comment-17214137 ] ASF subversion and git services commented on GEODE-7680: Commit 02336cdcd9cfb734c7f3abff97a65f51bec0e727 in geode's branch refs/heads/feature/GEODE-7665 from Donal Evans [ https://gitbox.apache.org/repos/asf?p=geode.git;h=02336cd ] GEODE-7680: PR.clear must be successful when interacting with rebalance (#5095) - Added DUnit tests to confirm that clear does not interfere with rebalance or vice versa - Test when member departs during clear/rebalance - Test when member joins during clear/rebalance - Fixed typo in PartitionedRegionClearWithExpirationDUnitTest - Fixed typo in PartitionedRegion - Call assignBucketsToPartitions() on leader colocated region during clear instead of target region Authored-by: Donal Evans > Partitioned region clear operations must be successful while interacting with > rebalance > > > Key: GEODE-7680 > URL: https://issues.apache.org/jira/browse/GEODE-7680 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Donal Evans >Priority: Major > Labels: GeodeCommons, caching-applications, > pull-request-available > Fix For: 1.14.0 > > > Clear operations are successful and while rebalance operations are ongoing. > Acceptance : > * DUnit tests validating the above behavior. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7845) Rollingupgrade should not conflict with the new ClearPRMessage
[ https://issues.apache.org/jira/browse/GEODE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214141#comment-17214141 ] ASF subversion and git services commented on GEODE-7845: Commit 30a699df1d5084de06e9a29a00bf89095f1de53b in geode's branch refs/heads/feature/GEODE-7665 from mhansonp [ https://gitbox.apache.org/repos/asf?p=geode.git;h=30a699d ] GEODE-7845: Adding a cleaner simpler test. (#5622) - Changed the test for ServerVersionMismatchException to be more readable. > Rollingupgrade should not conflict with the new ClearPRMessage > --- > > Key: GEODE-7845 > URL: https://issues.apache.org/jira/browse/GEODE-7845 > Project: Geode > Issue Type: Improvement > Components: core >Reporter: Xiaojian Zhou >Assignee: Mark Hanson >Priority: Major > Labels: GeodeCommons, pull-request-available > > PartitionedRegion clear introduced a new ClearPRMessage. In case of doing > rolling upgrade, the user called PR.clear. The new ClearPRMessage should not > fail. It should not be sent to the old members. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class
[ https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214144#comment-17214144 ] ASF subversion and git services commented on GEODE-8173: Commit 65a90168defa3e11352cc8143c621bafc3f31296 in geode's branch refs/heads/feature/GEODE-7665 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=65a9016 ] GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208) * GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. Co-authored-by: anilkumar gingade > Add test coverage for PartitionedRegionClear class > -- > > Key: GEODE-8173 > URL: https://issues.apache.org/jira/browse/GEODE-8173 > Project: Geode > Issue Type: Bug > Components: regions >Reporter: Anilkumar Gingade >Priority: Major > Labels: GeodeOperationAPI > Fix For: 1.14.0 > > > Add test coverage for PartitionedRegionClear class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7845) Rollingupgrade should not conflict with the new ClearPRMessage
[ https://issues.apache.org/jira/browse/GEODE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214152#comment-17214152 ] ASF subversion and git services commented on GEODE-7845: Commit 30a699df1d5084de06e9a29a00bf89095f1de53b in geode's branch refs/heads/feature/GEODE-7665 from mhansonp [ https://gitbox.apache.org/repos/asf?p=geode.git;h=30a699d ] GEODE-7845: Adding a cleaner simpler test. (#5622) - Changed the test for ServerVersionMismatchException to be more readable. > Rollingupgrade should not conflict with the new ClearPRMessage > --- > > Key: GEODE-7845 > URL: https://issues.apache.org/jira/browse/GEODE-7845 > Project: Geode > Issue Type: Improvement > Components: core >Reporter: Xiaojian Zhou >Assignee: Mark Hanson >Priority: Major > Labels: GeodeCommons, pull-request-available > > PartitionedRegion clear introduced a new ClearPRMessage. In case of doing > rolling upgrade, the user called PR.clear. The new ClearPRMessage should not > fail. It should not be sent to the old members. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7680) Partitioned region clear operations must be successful while interacting with rebalance
[ https://issues.apache.org/jira/browse/GEODE-7680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214148#comment-17214148 ] ASF subversion and git services commented on GEODE-7680: Commit 02336cdcd9cfb734c7f3abff97a65f51bec0e727 in geode's branch refs/heads/feature/GEODE-7665 from Donal Evans [ https://gitbox.apache.org/repos/asf?p=geode.git;h=02336cd ] GEODE-7680: PR.clear must be successful when interacting with rebalance (#5095) - Added DUnit tests to confirm that clear does not interfere with rebalance or vice versa - Test when member departs during clear/rebalance - Test when member joins during clear/rebalance - Fixed typo in PartitionedRegionClearWithExpirationDUnitTest - Fixed typo in PartitionedRegion - Call assignBucketsToPartitions() on leader colocated region during clear instead of target region Authored-by: Donal Evans > Partitioned region clear operations must be successful while interacting with > rebalance > > > Key: GEODE-7680 > URL: https://issues.apache.org/jira/browse/GEODE-7680 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Donal Evans >Priority: Major > Labels: GeodeCommons, caching-applications, > pull-request-available > Fix For: 1.14.0 > > > Clear operations are successful and while rebalance operations are ongoing. > Acceptance : > * DUnit tests validating the above behavior. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8361) Incorrect Bucket Count Warning Message Shown
[
https://issues.apache.org/jira/browse/GEODE-8361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214146#comment-17214146
]
ASF subversion and git services commented on GEODE-8361:
Commit 26396332807e56fa7d4d45992967bf73ebc0bb7c in geode's branch
refs/heads/feature/GEODE-7665 from Donal Evans
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=2639633 ]
GEODE-8361: Use Set instead of List to track cleared buckets (#5379)
- Refactor PartitionRegionClear to use Set instead of List
- Some other changes to remove warnings/alerts from PartitionedRegionClear and
PartitionedRegionClearMessage
Authored-by: Donal Evans
> Incorrect Bucket Count Warning Message Shown
>
>
> Key: GEODE-8361
> URL: https://issues.apache.org/jira/browse/GEODE-8361
> Project: Geode
> Issue Type: Sub-task
> Components: logging
>Reporter: Juan Ramos
>Assignee: Donal Evans
>Priority: Trivial
> Labels: pull-request-available
> Fix For: 1.14.0
>
>
> While analysing some failures related to GEODE-7670, I've noticed that
> sometimes we report an incorrect bucket count within the warning message
> logged when the clear didn't complete successfully that could confuse our
> users.
> For this test the partition region always has 13 buckets so, as I user, I
> would never expect to see a bucket count higher than 13 in my logs (no matter
> how many redundant copies I have).
> ---
> Below are some examples:
> {noformat}
> [vm1] [warn 2020/07/15 11:56:17.739 GMT Connection(5)-172.17.0.5> tid=0x5f] Unable to clear all the buckets from
> the partitioned region PartitionedRegion, either data (buckets) moved or
> member departed. expected to clear number of buckets: 13 actual cleared: 26
> [vm1] [warn 2020/07/15 11:57:48.403 GMT Connection(6)-172.17.0.9> tid=0x10f] Unable to clear all the buckets from
> the partitioned region PartitionedRegion, either data (buckets) moved or
> member departed. expected to clear number of buckets: 13 actual cleared: 14
> [vm0] [warn 2020/07/15 12:07:36.227 GMT Connection(32)-172.17.0.25> tid=0x1fe] Unable to clear all the buckets
> from the partitioned region PartitionedRegion, either data (buckets) moved or
> member departed. expected to clear number of buckets: 13 actual cleared: 19
> [vm0] [warn 2020/07/15 12:08:56.277 GMT Connection(37)-172.17.0.24> tid=0x2a2] Unable to clear all the buckets
> from the partitioned region PartitionedRegion, either data (buckets) moved or
> member departed. expected to clear number of buckets: 13 actual cleared: 16
> {noformat}
> The full set of artefacts and results:
> {noformat}
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> http://files.apachegeode-ci.info/builds/apache-develop-pr/geode-pr-4848/test-results/repeatTest/1594816968/
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> Test report artifacts from this job are available at:
> http://files.apachegeode-ci.info/builds/apache-develop-pr/geode-pr-4848/test-artifacts/1594816968/stressnewtestfiles-geode-pr-4848.tgz
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-7845) Rollingupgrade should not conflict with the new ClearPRMessage
[ https://issues.apache.org/jira/browse/GEODE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214151#comment-17214151 ] ASF subversion and git services commented on GEODE-7845: Commit 68d7c308d9ae070351a0e3045b04bcaf9636537d in geode's branch refs/heads/feature/GEODE-7665 from mhansonp [ https://gitbox.apache.org/repos/asf?p=geode.git;h=68d7c30 ] GEODE-7845 blocking PR region clear if one or more server versions are too old (#5577) - if a server is running an old version when a PR clear is invoked by the client, the client will receive a ServerOperationException with a cause of ServerVersionMismatchException. > Rollingupgrade should not conflict with the new ClearPRMessage > --- > > Key: GEODE-7845 > URL: https://issues.apache.org/jira/browse/GEODE-7845 > Project: Geode > Issue Type: Improvement > Components: core >Reporter: Xiaojian Zhou >Assignee: Mark Hanson >Priority: Major > Labels: GeodeCommons, pull-request-available > > PartitionedRegion clear introduced a new ClearPRMessage. In case of doing > rolling upgrade, the user called PR.clear. The new ClearPRMessage should not > fail. It should not be sent to the old members. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class
[ https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214143#comment-17214143 ] ASF subversion and git services commented on GEODE-8173: Commit 65a90168defa3e11352cc8143c621bafc3f31296 in geode's branch refs/heads/feature/GEODE-7665 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=65a9016 ] GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208) * GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. Co-authored-by: anilkumar gingade > Add test coverage for PartitionedRegionClear class > -- > > Key: GEODE-8173 > URL: https://issues.apache.org/jira/browse/GEODE-8173 > Project: Geode > Issue Type: Bug > Components: regions >Reporter: Anilkumar Gingade >Priority: Major > Labels: GeodeOperationAPI > Fix For: 1.14.0 > > > Add test coverage for PartitionedRegionClear class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear
[ https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214145#comment-17214145 ] ASF subversion and git services commented on GEODE-8334: Commit 5948b185a9f73ad8e12f01d449e2f1ec4d07bc62 in geode's branch refs/heads/feature/GEODE-7665 from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=5948b18 ] GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock (#5365) Co-authored-by: Xiaojian Zhou Co-authored-by: Anil Gingade > Primary and secondary bucket data mismatch with concurrent putAll/removeAll > and PR.clear > - > > Key: GEODE-8334 > URL: https://issues.apache.org/jira/browse/GEODE-8334 > Project: Geode > Issue Type: Sub-task > Components: regions >Affects Versions: 1.14.0 >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeOperationAPI > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7846) Clear in Partitioned Region should have its own stats
[ https://issues.apache.org/jira/browse/GEODE-7846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214149#comment-17214149 ] ASF subversion and git services commented on GEODE-7846: Commit 91b19ccbc345d49483151e889b6e354634e187a7 in geode's branch refs/heads/feature/GEODE-7665 from BenjaminPerryRoss [ https://gitbox.apache.org/repos/asf?p=geode.git;h=91b19cc ] GEODE-7846: Adding Stats for Partitioned Region Clear (#5391) Added stats to CachePerfStats for PR Clear - Changed clears to 'regionClears' and 'bucketClears' to differentiate between the number of times the region was cleared and the number of times a bucket was cleared in a PartitionedRegion - Added Local and Total duration stats to record how long clear has been running for a specific region, as well as how long it was spent clearing any specific member > Clear in Partitioned Region should have its own stats > - > > Key: GEODE-7846 > URL: https://issues.apache.org/jira/browse/GEODE-7846 > Project: Geode > Issue Type: Improvement > Components: core >Reporter: Xiaojian Zhou >Assignee: Benjamin P Ross >Priority: Major > Labels: GeodeCommons, GeodeOperationAPI, pull-request-available > > Clear operation in PR should have its own stats: > 1) clear operation executed. > 2) clear operation failed > 3) clear messages sends to buckets -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7672) Partitioned Region clear will successfully update the OQL indexes
[ https://issues.apache.org/jira/browse/GEODE-7672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214150#comment-17214150 ] ASF subversion and git services commented on GEODE-7672: Commit 4bf638afb85840636f9fc35107afbed8122ce6b8 in geode's branch refs/heads/feature/GEODE-7665 from Jinmei Liao [ https://gitbox.apache.org/repos/asf?p=geode.git;h=4bf638a ] GEODE-7672: add dunit test to verify OQL index after PR clear. (#5436) * require rvv lock when create index > Partitioned Region clear will successfully update the OQL indexes > - > > Key: GEODE-7672 > URL: https://issues.apache.org/jira/browse/GEODE-7672 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Jianxia Chen >Priority: Major > Labels: GeodeCommons, pull-request-available > > Clear operations are successfully updates the OQL indexes > > Acceptance : > * Passing Dunit tests where OQL queries using indexes return correct results > after the region is cleared > * clear operation and index updates are successful when clear operation is > executed when the puts are occurring which are trying to update the OQL index. > * Unit tests to ensure that index sizes are zero after the region is cleaned > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > > analyze if these tests are needed for offheap? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7670) Partitioned Region clear operations can occur during concurrent data operations
[ https://issues.apache.org/jira/browse/GEODE-7670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214147#comment-17214147 ] ASF subversion and git services commented on GEODE-7670: Commit 7d6c0504077a03d9411396ac8736cf7b962b0575 in geode's branch refs/heads/feature/GEODE-7665 from Juan José Ramos [ https://gitbox.apache.org/repos/asf?p=geode.git;h=7d6c050 ] GEODE-7670: PR Clear with Concurrent Ops DUnitTests (#4848) Added distributed tests to verify that the clear operation on Partitioned Regions works as expected when there are other concurrent operations happening on the cache (put, putAll, get, remove, removeAll, members added and members removed). > Partitioned Region clear operations can occur during concurrent data > operations > --- > > Key: GEODE-7670 > URL: https://issues.apache.org/jira/browse/GEODE-7670 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Juan Ramos >Priority: Major > Labels: GeodeCommons, pull-request-available > Time Spent: 5.5h > Remaining Estimate: 0h > > Clear operations are successful when concurrent read/write operations occur. > Ensure there are test coverage for this use case and modify the code needed > to enable this. > Acceptance : > * Passing DUnit tests where clear operations are successful on partitioned > region with > * concurrent puts (writes) and clear op > * concurrent gets (reads) and clear op > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8361) Incorrect Bucket Count Warning Message Shown
[
https://issues.apache.org/jira/browse/GEODE-8361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214156#comment-17214156
]
ASF subversion and git services commented on GEODE-8361:
Commit 26396332807e56fa7d4d45992967bf73ebc0bb7c in geode's branch
refs/heads/feature/GEODE-7665 from Donal Evans
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=2639633 ]
GEODE-8361: Use Set instead of List to track cleared buckets (#5379)
- Refactor PartitionRegionClear to use Set instead of List
- Some other changes to remove warnings/alerts from PartitionedRegionClear and
PartitionedRegionClearMessage
Authored-by: Donal Evans
> Incorrect Bucket Count Warning Message Shown
>
>
> Key: GEODE-8361
> URL: https://issues.apache.org/jira/browse/GEODE-8361
> Project: Geode
> Issue Type: Sub-task
> Components: logging
>Reporter: Juan Ramos
>Assignee: Donal Evans
>Priority: Trivial
> Labels: pull-request-available
> Fix For: 1.14.0
>
>
> While analysing some failures related to GEODE-7670, I've noticed that
> sometimes we report an incorrect bucket count within the warning message
> logged when the clear didn't complete successfully that could confuse our
> users.
> For this test the partition region always has 13 buckets so, as I user, I
> would never expect to see a bucket count higher than 13 in my logs (no matter
> how many redundant copies I have).
> ---
> Below are some examples:
> {noformat}
> [vm1] [warn 2020/07/15 11:56:17.739 GMT Connection(5)-172.17.0.5> tid=0x5f] Unable to clear all the buckets from
> the partitioned region PartitionedRegion, either data (buckets) moved or
> member departed. expected to clear number of buckets: 13 actual cleared: 26
> [vm1] [warn 2020/07/15 11:57:48.403 GMT Connection(6)-172.17.0.9> tid=0x10f] Unable to clear all the buckets from
> the partitioned region PartitionedRegion, either data (buckets) moved or
> member departed. expected to clear number of buckets: 13 actual cleared: 14
> [vm0] [warn 2020/07/15 12:07:36.227 GMT Connection(32)-172.17.0.25> tid=0x1fe] Unable to clear all the buckets
> from the partitioned region PartitionedRegion, either data (buckets) moved or
> member departed. expected to clear number of buckets: 13 actual cleared: 19
> [vm0] [warn 2020/07/15 12:08:56.277 GMT Connection(37)-172.17.0.24> tid=0x2a2] Unable to clear all the buckets
> from the partitioned region PartitionedRegion, either data (buckets) moved or
> member departed. expected to clear number of buckets: 13 actual cleared: 16
> {noformat}
> The full set of artefacts and results:
> {noformat}
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> http://files.apachegeode-ci.info/builds/apache-develop-pr/geode-pr-4848/test-results/repeatTest/1594816968/
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> Test report artifacts from this job are available at:
> http://files.apachegeode-ci.info/builds/apache-develop-pr/geode-pr-4848/test-artifacts/1594816968/stressnewtestfiles-geode-pr-4848.tgz
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-7845) Rollingupgrade should not conflict with the new ClearPRMessage
[ https://issues.apache.org/jira/browse/GEODE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214162#comment-17214162 ] ASF subversion and git services commented on GEODE-7845: Commit 30a699df1d5084de06e9a29a00bf89095f1de53b in geode's branch refs/heads/feature/GEODE-7665 from mhansonp [ https://gitbox.apache.org/repos/asf?p=geode.git;h=30a699d ] GEODE-7845: Adding a cleaner simpler test. (#5622) - Changed the test for ServerVersionMismatchException to be more readable. > Rollingupgrade should not conflict with the new ClearPRMessage > --- > > Key: GEODE-7845 > URL: https://issues.apache.org/jira/browse/GEODE-7845 > Project: Geode > Issue Type: Improvement > Components: core >Reporter: Xiaojian Zhou >Assignee: Mark Hanson >Priority: Major > Labels: GeodeCommons, pull-request-available > > PartitionedRegion clear introduced a new ClearPRMessage. In case of doing > rolling upgrade, the user called PR.clear. The new ClearPRMessage should not > fail. It should not be sent to the old members. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7680) Partitioned region clear operations must be successful while interacting with rebalance
[ https://issues.apache.org/jira/browse/GEODE-7680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214158#comment-17214158 ] ASF subversion and git services commented on GEODE-7680: Commit 02336cdcd9cfb734c7f3abff97a65f51bec0e727 in geode's branch refs/heads/feature/GEODE-7665 from Donal Evans [ https://gitbox.apache.org/repos/asf?p=geode.git;h=02336cd ] GEODE-7680: PR.clear must be successful when interacting with rebalance (#5095) - Added DUnit tests to confirm that clear does not interfere with rebalance or vice versa - Test when member departs during clear/rebalance - Test when member joins during clear/rebalance - Fixed typo in PartitionedRegionClearWithExpirationDUnitTest - Fixed typo in PartitionedRegion - Call assignBucketsToPartitions() on leader colocated region during clear instead of target region Authored-by: Donal Evans > Partitioned region clear operations must be successful while interacting with > rebalance > > > Key: GEODE-7680 > URL: https://issues.apache.org/jira/browse/GEODE-7680 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Donal Evans >Priority: Major > Labels: GeodeCommons, caching-applications, > pull-request-available > Fix For: 1.14.0 > > > Clear operations are successful and while rebalance operations are ongoing. > Acceptance : > * DUnit tests validating the above behavior. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7845) Rollingupgrade should not conflict with the new ClearPRMessage
[ https://issues.apache.org/jira/browse/GEODE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214161#comment-17214161 ] ASF subversion and git services commented on GEODE-7845: Commit 68d7c308d9ae070351a0e3045b04bcaf9636537d in geode's branch refs/heads/feature/GEODE-7665 from mhansonp [ https://gitbox.apache.org/repos/asf?p=geode.git;h=68d7c30 ] GEODE-7845 blocking PR region clear if one or more server versions are too old (#5577) - if a server is running an old version when a PR clear is invoked by the client, the client will receive a ServerOperationException with a cause of ServerVersionMismatchException. > Rollingupgrade should not conflict with the new ClearPRMessage > --- > > Key: GEODE-7845 > URL: https://issues.apache.org/jira/browse/GEODE-7845 > Project: Geode > Issue Type: Improvement > Components: core >Reporter: Xiaojian Zhou >Assignee: Mark Hanson >Priority: Major > Labels: GeodeCommons, pull-request-available > > PartitionedRegion clear introduced a new ClearPRMessage. In case of doing > rolling upgrade, the user called PR.clear. The new ClearPRMessage should not > fail. It should not be sent to the old members. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class
[ https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214153#comment-17214153 ] ASF subversion and git services commented on GEODE-8173: Commit 65a90168defa3e11352cc8143c621bafc3f31296 in geode's branch refs/heads/feature/GEODE-7665 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=65a9016 ] GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208) * GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. Co-authored-by: anilkumar gingade > Add test coverage for PartitionedRegionClear class > -- > > Key: GEODE-8173 > URL: https://issues.apache.org/jira/browse/GEODE-8173 > Project: Geode > Issue Type: Bug > Components: regions >Reporter: Anilkumar Gingade >Priority: Major > Labels: GeodeOperationAPI > Fix For: 1.14.0 > > > Add test coverage for PartitionedRegionClear class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class
[ https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214154#comment-17214154 ] ASF subversion and git services commented on GEODE-8173: Commit 65a90168defa3e11352cc8143c621bafc3f31296 in geode's branch refs/heads/feature/GEODE-7665 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=65a9016 ] GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208) * GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. Co-authored-by: anilkumar gingade > Add test coverage for PartitionedRegionClear class > -- > > Key: GEODE-8173 > URL: https://issues.apache.org/jira/browse/GEODE-8173 > Project: Geode > Issue Type: Bug > Components: regions >Reporter: Anilkumar Gingade >Priority: Major > Labels: GeodeOperationAPI > Fix For: 1.14.0 > > > Add test coverage for PartitionedRegionClear class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7670) Partitioned Region clear operations can occur during concurrent data operations
[ https://issues.apache.org/jira/browse/GEODE-7670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214157#comment-17214157 ] ASF subversion and git services commented on GEODE-7670: Commit 7d6c0504077a03d9411396ac8736cf7b962b0575 in geode's branch refs/heads/feature/GEODE-7665 from Juan José Ramos [ https://gitbox.apache.org/repos/asf?p=geode.git;h=7d6c050 ] GEODE-7670: PR Clear with Concurrent Ops DUnitTests (#4848) Added distributed tests to verify that the clear operation on Partitioned Regions works as expected when there are other concurrent operations happening on the cache (put, putAll, get, remove, removeAll, members added and members removed). > Partitioned Region clear operations can occur during concurrent data > operations > --- > > Key: GEODE-7670 > URL: https://issues.apache.org/jira/browse/GEODE-7670 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Juan Ramos >Priority: Major > Labels: GeodeCommons, pull-request-available > Time Spent: 5.5h > Remaining Estimate: 0h > > Clear operations are successful when concurrent read/write operations occur. > Ensure there are test coverage for this use case and modify the code needed > to enable this. > Acceptance : > * Passing DUnit tests where clear operations are successful on partitioned > region with > * concurrent puts (writes) and clear op > * concurrent gets (reads) and clear op > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7846) Clear in Partitioned Region should have its own stats
[ https://issues.apache.org/jira/browse/GEODE-7846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214159#comment-17214159 ] ASF subversion and git services commented on GEODE-7846: Commit 91b19ccbc345d49483151e889b6e354634e187a7 in geode's branch refs/heads/feature/GEODE-7665 from BenjaminPerryRoss [ https://gitbox.apache.org/repos/asf?p=geode.git;h=91b19cc ] GEODE-7846: Adding Stats for Partitioned Region Clear (#5391) Added stats to CachePerfStats for PR Clear - Changed clears to 'regionClears' and 'bucketClears' to differentiate between the number of times the region was cleared and the number of times a bucket was cleared in a PartitionedRegion - Added Local and Total duration stats to record how long clear has been running for a specific region, as well as how long it was spent clearing any specific member > Clear in Partitioned Region should have its own stats > - > > Key: GEODE-7846 > URL: https://issues.apache.org/jira/browse/GEODE-7846 > Project: Geode > Issue Type: Improvement > Components: core >Reporter: Xiaojian Zhou >Assignee: Benjamin P Ross >Priority: Major > Labels: GeodeCommons, GeodeOperationAPI, pull-request-available > > Clear operation in PR should have its own stats: > 1) clear operation executed. > 2) clear operation failed > 3) clear messages sends to buckets -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear
[ https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214155#comment-17214155 ] ASF subversion and git services commented on GEODE-8334: Commit 5948b185a9f73ad8e12f01d449e2f1ec4d07bc62 in geode's branch refs/heads/feature/GEODE-7665 from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=5948b18 ] GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock (#5365) Co-authored-by: Xiaojian Zhou Co-authored-by: Anil Gingade > Primary and secondary bucket data mismatch with concurrent putAll/removeAll > and PR.clear > - > > Key: GEODE-8334 > URL: https://issues.apache.org/jira/browse/GEODE-8334 > Project: Geode > Issue Type: Sub-task > Components: regions >Affects Versions: 1.14.0 >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeOperationAPI > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7672) Partitioned Region clear will successfully update the OQL indexes
[ https://issues.apache.org/jira/browse/GEODE-7672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214160#comment-17214160 ] ASF subversion and git services commented on GEODE-7672: Commit 4bf638afb85840636f9fc35107afbed8122ce6b8 in geode's branch refs/heads/feature/GEODE-7665 from Jinmei Liao [ https://gitbox.apache.org/repos/asf?p=geode.git;h=4bf638a ] GEODE-7672: add dunit test to verify OQL index after PR clear. (#5436) * require rvv lock when create index > Partitioned Region clear will successfully update the OQL indexes > - > > Key: GEODE-7672 > URL: https://issues.apache.org/jira/browse/GEODE-7672 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Jianxia Chen >Priority: Major > Labels: GeodeCommons, pull-request-available > > Clear operations are successfully updates the OQL indexes > > Acceptance : > * Passing Dunit tests where OQL queries using indexes return correct results > after the region is cleared > * clear operation and index updates are successful when clear operation is > executed when the puts are occurring which are trying to update the OQL index. > * Unit tests to ensure that index sizes are zero after the region is cleaned > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > > analyze if these tests are needed for offheap? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear
[ https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214166#comment-17214166 ] ASF subversion and git services commented on GEODE-8334: Commit 5948b185a9f73ad8e12f01d449e2f1ec4d07bc62 in geode's branch refs/heads/feature/GEODE-7665 from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=5948b18 ] GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock (#5365) Co-authored-by: Xiaojian Zhou Co-authored-by: Anil Gingade > Primary and secondary bucket data mismatch with concurrent putAll/removeAll > and PR.clear > - > > Key: GEODE-8334 > URL: https://issues.apache.org/jira/browse/GEODE-8334 > Project: Geode > Issue Type: Sub-task > Components: regions >Affects Versions: 1.14.0 >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeOperationAPI > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7670) Partitioned Region clear operations can occur during concurrent data operations
[ https://issues.apache.org/jira/browse/GEODE-7670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214169#comment-17214169 ] ASF subversion and git services commented on GEODE-7670: Commit 7d6c0504077a03d9411396ac8736cf7b962b0575 in geode's branch refs/heads/feature/GEODE-7665 from Juan José Ramos [ https://gitbox.apache.org/repos/asf?p=geode.git;h=7d6c050 ] GEODE-7670: PR Clear with Concurrent Ops DUnitTests (#4848) Added distributed tests to verify that the clear operation on Partitioned Regions works as expected when there are other concurrent operations happening on the cache (put, putAll, get, remove, removeAll, members added and members removed). > Partitioned Region clear operations can occur during concurrent data > operations > --- > > Key: GEODE-7670 > URL: https://issues.apache.org/jira/browse/GEODE-7670 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Juan Ramos >Priority: Major > Labels: GeodeCommons, pull-request-available > Time Spent: 5.5h > Remaining Estimate: 0h > > Clear operations are successful when concurrent read/write operations occur. > Ensure there are test coverage for this use case and modify the code needed > to enable this. > Acceptance : > * Passing DUnit tests where clear operations are successful on partitioned > region with > * concurrent puts (writes) and clear op > * concurrent gets (reads) and clear op > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-7845) Rollingupgrade should not conflict with the new ClearPRMessage
[ https://issues.apache.org/jira/browse/GEODE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Hanson resolved GEODE-7845. Fix Version/s: 1.14.0 Resolution: Fixed Added new feature to ensure that unsupported versions were not prompted to do a partition region clear. > Rollingupgrade should not conflict with the new ClearPRMessage > --- > > Key: GEODE-7845 > URL: https://issues.apache.org/jira/browse/GEODE-7845 > Project: Geode > Issue Type: Improvement > Components: core >Reporter: Xiaojian Zhou >Assignee: Mark Hanson >Priority: Major > Labels: GeodeCommons, pull-request-available > Fix For: 1.14.0 > > > PartitionedRegion clear introduced a new ClearPRMessage. In case of doing > rolling upgrade, the user called PR.clear. The new ClearPRMessage should not > fail. It should not be sent to the old members. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8361) Incorrect Bucket Count Warning Message Shown
[
https://issues.apache.org/jira/browse/GEODE-8361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214168#comment-17214168
]
ASF subversion and git services commented on GEODE-8361:
Commit 26396332807e56fa7d4d45992967bf73ebc0bb7c in geode's branch
refs/heads/feature/GEODE-7665 from Donal Evans
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=2639633 ]
GEODE-8361: Use Set instead of List to track cleared buckets (#5379)
- Refactor PartitionRegionClear to use Set instead of List
- Some other changes to remove warnings/alerts from PartitionedRegionClear and
PartitionedRegionClearMessage
Authored-by: Donal Evans
> Incorrect Bucket Count Warning Message Shown
>
>
> Key: GEODE-8361
> URL: https://issues.apache.org/jira/browse/GEODE-8361
> Project: Geode
> Issue Type: Sub-task
> Components: logging
>Reporter: Juan Ramos
>Assignee: Donal Evans
>Priority: Trivial
> Labels: pull-request-available
> Fix For: 1.14.0
>
>
> While analysing some failures related to GEODE-7670, I've noticed that
> sometimes we report an incorrect bucket count within the warning message
> logged when the clear didn't complete successfully that could confuse our
> users.
> For this test the partition region always has 13 buckets so, as I user, I
> would never expect to see a bucket count higher than 13 in my logs (no matter
> how many redundant copies I have).
> ---
> Below are some examples:
> {noformat}
> [vm1] [warn 2020/07/15 11:56:17.739 GMT Connection(5)-172.17.0.5> tid=0x5f] Unable to clear all the buckets from
> the partitioned region PartitionedRegion, either data (buckets) moved or
> member departed. expected to clear number of buckets: 13 actual cleared: 26
> [vm1] [warn 2020/07/15 11:57:48.403 GMT Connection(6)-172.17.0.9> tid=0x10f] Unable to clear all the buckets from
> the partitioned region PartitionedRegion, either data (buckets) moved or
> member departed. expected to clear number of buckets: 13 actual cleared: 14
> [vm0] [warn 2020/07/15 12:07:36.227 GMT Connection(32)-172.17.0.25> tid=0x1fe] Unable to clear all the buckets
> from the partitioned region PartitionedRegion, either data (buckets) moved or
> member departed. expected to clear number of buckets: 13 actual cleared: 19
> [vm0] [warn 2020/07/15 12:08:56.277 GMT Connection(37)-172.17.0.24> tid=0x2a2] Unable to clear all the buckets
> from the partitioned region PartitionedRegion, either data (buckets) moved or
> member departed. expected to clear number of buckets: 13 actual cleared: 16
> {noformat}
> The full set of artefacts and results:
> {noformat}
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> http://files.apachegeode-ci.info/builds/apache-develop-pr/geode-pr-4848/test-results/repeatTest/1594816968/
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> Test report artifacts from this job are available at:
> http://files.apachegeode-ci.info/builds/apache-develop-pr/geode-pr-4848/test-artifacts/1594816968/stressnewtestfiles-geode-pr-4848.tgz
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-7680) Partitioned region clear operations must be successful while interacting with rebalance
[ https://issues.apache.org/jira/browse/GEODE-7680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214170#comment-17214170 ] ASF subversion and git services commented on GEODE-7680: Commit 02336cdcd9cfb734c7f3abff97a65f51bec0e727 in geode's branch refs/heads/feature/GEODE-7665 from Donal Evans [ https://gitbox.apache.org/repos/asf?p=geode.git;h=02336cd ] GEODE-7680: PR.clear must be successful when interacting with rebalance (#5095) - Added DUnit tests to confirm that clear does not interfere with rebalance or vice versa - Test when member departs during clear/rebalance - Test when member joins during clear/rebalance - Fixed typo in PartitionedRegionClearWithExpirationDUnitTest - Fixed typo in PartitionedRegion - Call assignBucketsToPartitions() on leader colocated region during clear instead of target region Authored-by: Donal Evans > Partitioned region clear operations must be successful while interacting with > rebalance > > > Key: GEODE-7680 > URL: https://issues.apache.org/jira/browse/GEODE-7680 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Donal Evans >Priority: Major > Labels: GeodeCommons, caching-applications, > pull-request-available > Fix For: 1.14.0 > > > Clear operations are successful and while rebalance operations are ongoing. > Acceptance : > * DUnit tests validating the above behavior. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class
[ https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214164#comment-17214164 ] ASF subversion and git services commented on GEODE-8173: Commit 65a90168defa3e11352cc8143c621bafc3f31296 in geode's branch refs/heads/feature/GEODE-7665 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=65a9016 ] GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208) * GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. Co-authored-by: anilkumar gingade > Add test coverage for PartitionedRegionClear class > -- > > Key: GEODE-8173 > URL: https://issues.apache.org/jira/browse/GEODE-8173 > Project: Geode > Issue Type: Bug > Components: regions >Reporter: Anilkumar Gingade >Priority: Major > Labels: GeodeOperationAPI > Fix For: 1.14.0 > > > Add test coverage for PartitionedRegionClear class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class
[ https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214165#comment-17214165 ] ASF subversion and git services commented on GEODE-8173: Commit 65a90168defa3e11352cc8143c621bafc3f31296 in geode's branch refs/heads/feature/GEODE-7665 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=65a9016 ] GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208) * GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. Co-authored-by: anilkumar gingade > Add test coverage for PartitionedRegionClear class > -- > > Key: GEODE-8173 > URL: https://issues.apache.org/jira/browse/GEODE-8173 > Project: Geode > Issue Type: Bug > Components: regions >Reporter: Anilkumar Gingade >Priority: Major > Labels: GeodeOperationAPI > Fix For: 1.14.0 > > > Add test coverage for PartitionedRegionClear class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7672) Partitioned Region clear will successfully update the OQL indexes
[ https://issues.apache.org/jira/browse/GEODE-7672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214172#comment-17214172 ] ASF subversion and git services commented on GEODE-7672: Commit 4bf638afb85840636f9fc35107afbed8122ce6b8 in geode's branch refs/heads/feature/GEODE-7665 from Jinmei Liao [ https://gitbox.apache.org/repos/asf?p=geode.git;h=4bf638a ] GEODE-7672: add dunit test to verify OQL index after PR clear. (#5436) * require rvv lock when create index > Partitioned Region clear will successfully update the OQL indexes > - > > Key: GEODE-7672 > URL: https://issues.apache.org/jira/browse/GEODE-7672 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Jianxia Chen >Priority: Major > Labels: GeodeCommons, pull-request-available > > Clear operations are successfully updates the OQL indexes > > Acceptance : > * Passing Dunit tests where OQL queries using indexes return correct results > after the region is cleared > * clear operation and index updates are successful when clear operation is > executed when the puts are occurring which are trying to update the OQL index. > * Unit tests to ensure that index sizes are zero after the region is cleaned > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > > analyze if these tests are needed for offheap? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7845) Rollingupgrade should not conflict with the new ClearPRMessage
[ https://issues.apache.org/jira/browse/GEODE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214173#comment-17214173 ] ASF subversion and git services commented on GEODE-7845: Commit 68d7c308d9ae070351a0e3045b04bcaf9636537d in geode's branch refs/heads/feature/GEODE-7665 from mhansonp [ https://gitbox.apache.org/repos/asf?p=geode.git;h=68d7c30 ] GEODE-7845 blocking PR region clear if one or more server versions are too old (#5577) - if a server is running an old version when a PR clear is invoked by the client, the client will receive a ServerOperationException with a cause of ServerVersionMismatchException. > Rollingupgrade should not conflict with the new ClearPRMessage > --- > > Key: GEODE-7845 > URL: https://issues.apache.org/jira/browse/GEODE-7845 > Project: Geode > Issue Type: Improvement > Components: core >Reporter: Xiaojian Zhou >Assignee: Mark Hanson >Priority: Major > Labels: GeodeCommons, pull-request-available > Fix For: 1.14.0 > > > PartitionedRegion clear introduced a new ClearPRMessage. In case of doing > rolling upgrade, the user called PR.clear. The new ClearPRMessage should not > fail. It should not be sent to the old members. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7845) Rollingupgrade should not conflict with the new ClearPRMessage
[ https://issues.apache.org/jira/browse/GEODE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214174#comment-17214174 ] ASF subversion and git services commented on GEODE-7845: Commit 30a699df1d5084de06e9a29a00bf89095f1de53b in geode's branch refs/heads/feature/GEODE-7665 from mhansonp [ https://gitbox.apache.org/repos/asf?p=geode.git;h=30a699d ] GEODE-7845: Adding a cleaner simpler test. (#5622) - Changed the test for ServerVersionMismatchException to be more readable. > Rollingupgrade should not conflict with the new ClearPRMessage > --- > > Key: GEODE-7845 > URL: https://issues.apache.org/jira/browse/GEODE-7845 > Project: Geode > Issue Type: Improvement > Components: core >Reporter: Xiaojian Zhou >Assignee: Mark Hanson >Priority: Major > Labels: GeodeCommons, pull-request-available > Fix For: 1.14.0 > > > PartitionedRegion clear introduced a new ClearPRMessage. In case of doing > rolling upgrade, the user called PR.clear. The new ClearPRMessage should not > fail. It should not be sent to the old members. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7846) Clear in Partitioned Region should have its own stats
[ https://issues.apache.org/jira/browse/GEODE-7846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214171#comment-17214171 ] ASF subversion and git services commented on GEODE-7846: Commit 91b19ccbc345d49483151e889b6e354634e187a7 in geode's branch refs/heads/feature/GEODE-7665 from BenjaminPerryRoss [ https://gitbox.apache.org/repos/asf?p=geode.git;h=91b19cc ] GEODE-7846: Adding Stats for Partitioned Region Clear (#5391) Added stats to CachePerfStats for PR Clear - Changed clears to 'regionClears' and 'bucketClears' to differentiate between the number of times the region was cleared and the number of times a bucket was cleared in a PartitionedRegion - Added Local and Total duration stats to record how long clear has been running for a specific region, as well as how long it was spent clearing any specific member > Clear in Partitioned Region should have its own stats > - > > Key: GEODE-7846 > URL: https://issues.apache.org/jira/browse/GEODE-7846 > Project: Geode > Issue Type: Improvement > Components: core >Reporter: Xiaojian Zhou >Assignee: Benjamin P Ross >Priority: Major > Labels: GeodeCommons, GeodeOperationAPI, pull-request-available > > Clear operation in PR should have its own stats: > 1) clear operation executed. > 2) clear operation failed > 3) clear messages sends to buckets -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7845) Rollingupgrade should not conflict with the new ClearPRMessage
[ https://issues.apache.org/jira/browse/GEODE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214184#comment-17214184 ] ASF subversion and git services commented on GEODE-7845: Commit 68d7c308d9ae070351a0e3045b04bcaf9636537d in geode's branch refs/heads/feature/GEODE-7665 from mhansonp [ https://gitbox.apache.org/repos/asf?p=geode.git;h=68d7c30 ] GEODE-7845 blocking PR region clear if one or more server versions are too old (#5577) - if a server is running an old version when a PR clear is invoked by the client, the client will receive a ServerOperationException with a cause of ServerVersionMismatchException. > Rollingupgrade should not conflict with the new ClearPRMessage > --- > > Key: GEODE-7845 > URL: https://issues.apache.org/jira/browse/GEODE-7845 > Project: Geode > Issue Type: Improvement > Components: core >Reporter: Xiaojian Zhou >Assignee: Mark Hanson >Priority: Major > Labels: GeodeCommons, pull-request-available > Fix For: 1.14.0 > > > PartitionedRegion clear introduced a new ClearPRMessage. In case of doing > rolling upgrade, the user called PR.clear. The new ClearPRMessage should not > fail. It should not be sent to the old members. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7845) Rollingupgrade should not conflict with the new ClearPRMessage
[ https://issues.apache.org/jira/browse/GEODE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214185#comment-17214185 ] ASF subversion and git services commented on GEODE-7845: Commit 30a699df1d5084de06e9a29a00bf89095f1de53b in geode's branch refs/heads/feature/GEODE-7665 from mhansonp [ https://gitbox.apache.org/repos/asf?p=geode.git;h=30a699d ] GEODE-7845: Adding a cleaner simpler test. (#5622) - Changed the test for ServerVersionMismatchException to be more readable. > Rollingupgrade should not conflict with the new ClearPRMessage > --- > > Key: GEODE-7845 > URL: https://issues.apache.org/jira/browse/GEODE-7845 > Project: Geode > Issue Type: Improvement > Components: core >Reporter: Xiaojian Zhou >Assignee: Mark Hanson >Priority: Major > Labels: GeodeCommons, pull-request-available > Fix For: 1.14.0 > > > PartitionedRegion clear introduced a new ClearPRMessage. In case of doing > rolling upgrade, the user called PR.clear. The new ClearPRMessage should not > fail. It should not be sent to the old members. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7670) Partitioned Region clear operations can occur during concurrent data operations
[ https://issues.apache.org/jira/browse/GEODE-7670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214179#comment-17214179 ] ASF subversion and git services commented on GEODE-7670: Commit 7d6c0504077a03d9411396ac8736cf7b962b0575 in geode's branch refs/heads/feature/GEODE-7665 from Juan José Ramos [ https://gitbox.apache.org/repos/asf?p=geode.git;h=7d6c050 ] GEODE-7670: PR Clear with Concurrent Ops DUnitTests (#4848) Added distributed tests to verify that the clear operation on Partitioned Regions works as expected when there are other concurrent operations happening on the cache (put, putAll, get, remove, removeAll, members added and members removed). > Partitioned Region clear operations can occur during concurrent data > operations > --- > > Key: GEODE-7670 > URL: https://issues.apache.org/jira/browse/GEODE-7670 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Juan Ramos >Priority: Major > Labels: GeodeCommons, pull-request-available > Time Spent: 5.5h > Remaining Estimate: 0h > > Clear operations are successful when concurrent read/write operations occur. > Ensure there are test coverage for this use case and modify the code needed > to enable this. > Acceptance : > * Passing DUnit tests where clear operations are successful on partitioned > region with > * concurrent puts (writes) and clear op > * concurrent gets (reads) and clear op > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear
[ https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214177#comment-17214177 ] ASF subversion and git services commented on GEODE-8334: Commit 5948b185a9f73ad8e12f01d449e2f1ec4d07bc62 in geode's branch refs/heads/feature/GEODE-7665 from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=5948b18 ] GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock (#5365) Co-authored-by: Xiaojian Zhou Co-authored-by: Anil Gingade > Primary and secondary bucket data mismatch with concurrent putAll/removeAll > and PR.clear > - > > Key: GEODE-8334 > URL: https://issues.apache.org/jira/browse/GEODE-8334 > Project: Geode > Issue Type: Sub-task > Components: regions >Affects Versions: 1.14.0 >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeOperationAPI > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7680) Partitioned region clear operations must be successful while interacting with rebalance
[ https://issues.apache.org/jira/browse/GEODE-7680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214180#comment-17214180 ] ASF subversion and git services commented on GEODE-7680: Commit 02336cdcd9cfb734c7f3abff97a65f51bec0e727 in geode's branch refs/heads/feature/GEODE-7665 from Donal Evans [ https://gitbox.apache.org/repos/asf?p=geode.git;h=02336cd ] GEODE-7680: PR.clear must be successful when interacting with rebalance (#5095) - Added DUnit tests to confirm that clear does not interfere with rebalance or vice versa - Test when member departs during clear/rebalance - Test when member joins during clear/rebalance - Fixed typo in PartitionedRegionClearWithExpirationDUnitTest - Fixed typo in PartitionedRegion - Call assignBucketsToPartitions() on leader colocated region during clear instead of target region Authored-by: Donal Evans > Partitioned region clear operations must be successful while interacting with > rebalance > > > Key: GEODE-7680 > URL: https://issues.apache.org/jira/browse/GEODE-7680 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Donal Evans >Priority: Major > Labels: GeodeCommons, caching-applications, > pull-request-available > Fix For: 1.14.0 > > > Clear operations are successful and while rebalance operations are ongoing. > Acceptance : > * DUnit tests validating the above behavior. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8361) Incorrect Bucket Count Warning Message Shown
[
https://issues.apache.org/jira/browse/GEODE-8361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214178#comment-17214178
]
ASF subversion and git services commented on GEODE-8361:
Commit 26396332807e56fa7d4d45992967bf73ebc0bb7c in geode's branch
refs/heads/feature/GEODE-7665 from Donal Evans
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=2639633 ]
GEODE-8361: Use Set instead of List to track cleared buckets (#5379)
- Refactor PartitionRegionClear to use Set instead of List
- Some other changes to remove warnings/alerts from PartitionedRegionClear and
PartitionedRegionClearMessage
Authored-by: Donal Evans
> Incorrect Bucket Count Warning Message Shown
>
>
> Key: GEODE-8361
> URL: https://issues.apache.org/jira/browse/GEODE-8361
> Project: Geode
> Issue Type: Sub-task
> Components: logging
>Reporter: Juan Ramos
>Assignee: Donal Evans
>Priority: Trivial
> Labels: pull-request-available
> Fix For: 1.14.0
>
>
> While analysing some failures related to GEODE-7670, I've noticed that
> sometimes we report an incorrect bucket count within the warning message
> logged when the clear didn't complete successfully that could confuse our
> users.
> For this test the partition region always has 13 buckets so, as I user, I
> would never expect to see a bucket count higher than 13 in my logs (no matter
> how many redundant copies I have).
> ---
> Below are some examples:
> {noformat}
> [vm1] [warn 2020/07/15 11:56:17.739 GMT Connection(5)-172.17.0.5> tid=0x5f] Unable to clear all the buckets from
> the partitioned region PartitionedRegion, either data (buckets) moved or
> member departed. expected to clear number of buckets: 13 actual cleared: 26
> [vm1] [warn 2020/07/15 11:57:48.403 GMT Connection(6)-172.17.0.9> tid=0x10f] Unable to clear all the buckets from
> the partitioned region PartitionedRegion, either data (buckets) moved or
> member departed. expected to clear number of buckets: 13 actual cleared: 14
> [vm0] [warn 2020/07/15 12:07:36.227 GMT Connection(32)-172.17.0.25> tid=0x1fe] Unable to clear all the buckets
> from the partitioned region PartitionedRegion, either data (buckets) moved or
> member departed. expected to clear number of buckets: 13 actual cleared: 19
> [vm0] [warn 2020/07/15 12:08:56.277 GMT Connection(37)-172.17.0.24> tid=0x2a2] Unable to clear all the buckets
> from the partitioned region PartitionedRegion, either data (buckets) moved or
> member departed. expected to clear number of buckets: 13 actual cleared: 16
> {noformat}
> The full set of artefacts and results:
> {noformat}
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> http://files.apachegeode-ci.info/builds/apache-develop-pr/geode-pr-4848/test-results/repeatTest/1594816968/
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> Test report artifacts from this job are available at:
> http://files.apachegeode-ci.info/builds/apache-develop-pr/geode-pr-4848/test-artifacts/1594816968/stressnewtestfiles-geode-pr-4848.tgz
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class
[ https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214176#comment-17214176 ] ASF subversion and git services commented on GEODE-8173: Commit 65a90168defa3e11352cc8143c621bafc3f31296 in geode's branch refs/heads/feature/GEODE-7665 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=65a9016 ] GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208) * GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. Co-authored-by: anilkumar gingade > Add test coverage for PartitionedRegionClear class > -- > > Key: GEODE-8173 > URL: https://issues.apache.org/jira/browse/GEODE-8173 > Project: Geode > Issue Type: Bug > Components: regions >Reporter: Anilkumar Gingade >Priority: Major > Labels: GeodeOperationAPI > Fix For: 1.14.0 > > > Add test coverage for PartitionedRegionClear class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class
[ https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214175#comment-17214175 ] ASF subversion and git services commented on GEODE-8173: Commit 65a90168defa3e11352cc8143c621bafc3f31296 in geode's branch refs/heads/feature/GEODE-7665 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=65a9016 ] GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208) * GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. Co-authored-by: anilkumar gingade > Add test coverage for PartitionedRegionClear class > -- > > Key: GEODE-8173 > URL: https://issues.apache.org/jira/browse/GEODE-8173 > Project: Geode > Issue Type: Bug > Components: regions >Reporter: Anilkumar Gingade >Priority: Major > Labels: GeodeOperationAPI > Fix For: 1.14.0 > > > Add test coverage for PartitionedRegionClear class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7672) Partitioned Region clear will successfully update the OQL indexes
[ https://issues.apache.org/jira/browse/GEODE-7672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214183#comment-17214183 ] ASF subversion and git services commented on GEODE-7672: Commit 4bf638afb85840636f9fc35107afbed8122ce6b8 in geode's branch refs/heads/feature/GEODE-7665 from Jinmei Liao [ https://gitbox.apache.org/repos/asf?p=geode.git;h=4bf638a ] GEODE-7672: add dunit test to verify OQL index after PR clear. (#5436) * require rvv lock when create index > Partitioned Region clear will successfully update the OQL indexes > - > > Key: GEODE-7672 > URL: https://issues.apache.org/jira/browse/GEODE-7672 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Jianxia Chen >Priority: Major > Labels: GeodeCommons, pull-request-available > > Clear operations are successfully updates the OQL indexes > > Acceptance : > * Passing Dunit tests where OQL queries using indexes return correct results > after the region is cleared > * clear operation and index updates are successful when clear operation is > executed when the puts are occurring which are trying to update the OQL index. > * Unit tests to ensure that index sizes are zero after the region is cleaned > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > > analyze if these tests are needed for offheap? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7846) Clear in Partitioned Region should have its own stats
[ https://issues.apache.org/jira/browse/GEODE-7846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214181#comment-17214181 ] ASF subversion and git services commented on GEODE-7846: Commit 91b19ccbc345d49483151e889b6e354634e187a7 in geode's branch refs/heads/feature/GEODE-7665 from BenjaminPerryRoss [ https://gitbox.apache.org/repos/asf?p=geode.git;h=91b19cc ] GEODE-7846: Adding Stats for Partitioned Region Clear (#5391) Added stats to CachePerfStats for PR Clear - Changed clears to 'regionClears' and 'bucketClears' to differentiate between the number of times the region was cleared and the number of times a bucket was cleared in a PartitionedRegion - Added Local and Total duration stats to record how long clear has been running for a specific region, as well as how long it was spent clearing any specific member > Clear in Partitioned Region should have its own stats > - > > Key: GEODE-7846 > URL: https://issues.apache.org/jira/browse/GEODE-7846 > Project: Geode > Issue Type: Improvement > Components: core >Reporter: Xiaojian Zhou >Assignee: Benjamin P Ross >Priority: Major > Labels: GeodeCommons, GeodeOperationAPI, pull-request-available > > Clear operation in PR should have its own stats: > 1) clear operation executed. > 2) clear operation failed > 3) clear messages sends to buckets -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8547) Command "show missing-disk-stores" not working, when all servers are down
[ https://issues.apache.org/jira/browse/GEODE-8547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214198#comment-17214198 ] ASF GitHub Bot commented on GEODE-8547: --- mivanac commented on pull request #5567: URL: https://github.com/apache/geode/pull/5567#issuecomment-708593672 @kirklund is added test OK with you. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Command "show missing-disk-stores" not working, when all servers are down > - > > Key: GEODE-8547 > URL: https://issues.apache.org/jira/browse/GEODE-8547 > Project: Geode > Issue Type: Bug > Components: gfsh >Reporter: Mario Ivanac >Assignee: Mario Ivanac >Priority: Major > Labels: pull-request-available > > If cluster with 2 locators and 2 servers was ungracefully shutdown it can > happen that locators that are able to start up are not having most recent > data to bring up Cluster Configuration Service. > If we excute command "show missing-disk-stores" it will not work, since all > servers are down, > so we are stuck in this situation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8606) Rename DistributedCloseableReference as DistributedReference
[ https://issues.apache.org/jira/browse/GEODE-8606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-8606: -- Labels: pull-request-available (was: ) > Rename DistributedCloseableReference as DistributedReference > > > Key: GEODE-8606 > URL: https://issues.apache.org/jira/browse/GEODE-8606 > Project: Geode > Issue Type: Wish > Components: tests >Reporter: Kirk Lund >Assignee: Kirk Lund >Priority: Major > Labels: pull-request-available > > Rename DistributedCloseableReference as DistributedReference. > Simple change that improves readability issues that I noticed while writing a > blog article. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8606) Rename DistributedCloseableReference as DistributedReference
[ https://issues.apache.org/jira/browse/GEODE-8606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214227#comment-17214227 ] ASF GitHub Bot commented on GEODE-8606: --- kirklund opened a new pull request #5626: URL: https://github.com/apache/geode/pull/5626 This prevents line-wrapping in tests using DistributedReference improving readability. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Rename DistributedCloseableReference as DistributedReference > > > Key: GEODE-8606 > URL: https://issues.apache.org/jira/browse/GEODE-8606 > Project: Geode > Issue Type: Wish > Components: tests >Reporter: Kirk Lund >Assignee: Kirk Lund >Priority: Major > > Rename DistributedCloseableReference as DistributedReference. > Simple change that improves readability issues that I noticed while writing a > blog article. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8585) Redis SCAN, HSCAN, and SSCAN do not detect illegal parameters
[ https://issues.apache.org/jira/browse/GEODE-8585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214230#comment-17214230 ] ASF GitHub Bot commented on GEODE-8585: --- sabbey37 opened a new pull request #5627: URL: https://github.com/apache/geode/pull/5627 Add integration tests and functionality to match native Redis. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Redis SCAN, HSCAN, and SSCAN do not detect illegal parameters > - > > Key: GEODE-8585 > URL: https://issues.apache.org/jira/browse/GEODE-8585 > Project: Geode > Issue Type: Bug > Components: redis >Reporter: Sarah Abbey >Assignee: Sarah Abbey >Priority: Minor > > The parameter parsing for SCAN will not detect some illegal parameters. We > found that if we left off the MATCH keyword it just ignored the match string > we gave it. Native redis throws a syntax error. We also saw that COUNT could > follow MATCH but MATCH could not follow COUNT. I think it also allows COUNT > to be specified twice. HSCAN and SSCAN probably have similar issues. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8585) Redis SCAN, HSCAN, and SSCAN do not detect illegal parameters
[ https://issues.apache.org/jira/browse/GEODE-8585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-8585: -- Labels: pull-request-available (was: ) > Redis SCAN, HSCAN, and SSCAN do not detect illegal parameters > - > > Key: GEODE-8585 > URL: https://issues.apache.org/jira/browse/GEODE-8585 > Project: Geode > Issue Type: Bug > Components: redis >Reporter: Sarah Abbey >Assignee: Sarah Abbey >Priority: Minor > Labels: pull-request-available > > The parameter parsing for SCAN will not detect some illegal parameters. We > found that if we left off the MATCH keyword it just ignored the match string > we gave it. Native redis throws a syntax error. We also saw that COUNT could > follow MATCH but MATCH could not follow COUNT. I think it also allows COUNT > to be specified twice. HSCAN and SSCAN probably have similar issues. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-8610) Add parameter checking to unsupported Redis commands
Sarah Abbey created GEODE-8610: -- Summary: Add parameter checking to unsupported Redis commands Key: GEODE-8610 URL: https://issues.apache.org/jira/browse/GEODE-8610 Project: Geode Issue Type: Bug Components: redis Reporter: Sarah Abbey Create tests/add parameter check -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8610) Add parameter checking to unsupported Redis commands
[ https://issues.apache.org/jira/browse/GEODE-8610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarah Abbey updated GEODE-8610: --- Issue Type: Improvement (was: Bug) > Add parameter checking to unsupported Redis commands > > > Key: GEODE-8610 > URL: https://issues.apache.org/jira/browse/GEODE-8610 > Project: Geode > Issue Type: Improvement > Components: redis >Reporter: Sarah Abbey >Priority: Major > > Create tests/add parameter check -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (GEODE-8610) Add parameter checking to unsupported Redis commands
[ https://issues.apache.org/jira/browse/GEODE-8610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarah Abbey reassigned GEODE-8610: -- Assignee: Sarah Abbey > Add parameter checking to unsupported Redis commands > > > Key: GEODE-8610 > URL: https://issues.apache.org/jira/browse/GEODE-8610 > Project: Geode > Issue Type: Improvement > Components: redis >Reporter: Sarah Abbey >Assignee: Sarah Abbey >Priority: Minor > > Create tests/add parameter check -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8610) Add parameter checking to unsupported Redis commands
[ https://issues.apache.org/jira/browse/GEODE-8610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarah Abbey updated GEODE-8610: --- Priority: Minor (was: Major) > Add parameter checking to unsupported Redis commands > > > Key: GEODE-8610 > URL: https://issues.apache.org/jira/browse/GEODE-8610 > Project: Geode > Issue Type: Improvement > Components: redis >Reporter: Sarah Abbey >Priority: Minor > > Create tests/add parameter check -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8607) Add new API for getting oldest tombstone age.
[
https://issues.apache.org/jira/browse/GEODE-8607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214239#comment-17214239
]
ASF GitHub Bot commented on GEODE-8607:
---
agingade commented on a change in pull request #5623:
URL: https://github.com/apache/geode/pull/5623#discussion_r504938535
##
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/TombstoneService.java
##
@@ -450,6 +450,11 @@ boolean testHook_forceExpiredTombstoneGC(int count, long
timeout, TimeUnit unit)
@Override
protected void beforeSleepChecks() {}
+
+@Override
+public long getOldestTombstoneTimeDelta() {
+ return tombstones.peek().getVersionTimeStamp() -
cacheTime.cacheTimeMillis();
Review comment:
The peek could return null...
Will it be a good enough to return version timestamp instead of delta...The
caller can calculate delta with different time mechanism (using cacheTime or
currentTime).
Also, will it be helpful if the tombstone.toString() info is returned...It
has all the information associated with tombstone.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add new API for getting oldest tombstone age.
> -
>
> Key: GEODE-8607
> URL: https://issues.apache.org/jira/browse/GEODE-8607
> Project: Geode
> Issue Type: Bug
> Components: core
>Reporter: Mark Hanson
>Priority: Major
> Labels: pull-request-available
>
> It would be handy in diagnosing certain issues.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (GEODE-8611) KeyManagerFactory instantiated using the wrong algorithm source.
Jacob Barrett created GEODE-8611:
Summary: KeyManagerFactory instantiated using the wrong algorithm
source.
Key: GEODE-8611
URL: https://issues.apache.org/jira/browse/GEODE-8611
Project: Geode
Issue Type: Bug
Reporter: Jacob Barrett
The JSSE {{KeyManagerFactory}} is instantiated using the default algorithm for
the {{TrustManagerFactory}}. While most like they will both use the same
algorithm if it was necessary to have them be different we could not. Setting
the {{ssl.TrustManagerFactory.algorithm}} system property would affect both
manger factories and {{ssl.KeyManagerFactory.algorithm}} would have no affect.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (GEODE-8608) StateFlush could hang when the target member is shutdown
[ https://issues.apache.org/jira/browse/GEODE-8608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anilkumar Gingade reassigned GEODE-8608: Assignee: Xiaojian Zhou > StateFlush could hang when the target member is shutdown > > > Key: GEODE-8608 > URL: https://issues.apache.org/jira/browse/GEODE-8608 > Project: Geode > Issue Type: Bug > Components: membership >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Labels: pull-request-available > > This was introduced by GEODE-8385. > When the StateFlushReplyProcessor is wait for a reply of the target member, > if that member shuts down, the StateFlushReplyProcessor could wait forever > for that member to reply even though the member no longer in the view. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8611) KeyManagerFactory instantiated using the wrong algorithm source.
[
https://issues.apache.org/jira/browse/GEODE-8611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacob Barrett updated GEODE-8611:
-
Affects Version/s: 1.13.0
> KeyManagerFactory instantiated using the wrong algorithm source.
>
>
> Key: GEODE-8611
> URL: https://issues.apache.org/jira/browse/GEODE-8611
> Project: Geode
> Issue Type: Bug
>Affects Versions: 1.13.0
>Reporter: Jacob Barrett
>Priority: Major
>
> The JSSE {{KeyManagerFactory}} is instantiated using the default algorithm
> for the {{TrustManagerFactory}}. While most like they will both use the same
> algorithm if it was necessary to have them be different we could not. Setting
> the {{ssl.TrustManagerFactory.algorithm}} system property would affect both
> manger factories and {{ssl.KeyManagerFactory.algorithm}} would have no affect.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (GEODE-8608) StateFlush could hang when the target member is shutdown
[ https://issues.apache.org/jira/browse/GEODE-8608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anilkumar Gingade updated GEODE-8608: - Affects Version/s: 1.14.0 1.12.0 1.13.0 > StateFlush could hang when the target member is shutdown > > > Key: GEODE-8608 > URL: https://issues.apache.org/jira/browse/GEODE-8608 > Project: Geode > Issue Type: Bug > Components: membership >Affects Versions: 1.12.0, 1.13.0, 1.14.0 >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Labels: pull-request-available > > This was introduced by GEODE-8385. > When the StateFlushReplyProcessor is wait for a reply of the target member, > if that member shuts down, the StateFlushReplyProcessor could wait forever > for that member to reply even though the member no longer in the view. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8611) KeyManagerFactory instantiated using the wrong algorithm source.
[
https://issues.apache.org/jira/browse/GEODE-8611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacob Barrett updated GEODE-8611:
-
Affects Version/s: 1.14.0
> KeyManagerFactory instantiated using the wrong algorithm source.
>
>
> Key: GEODE-8611
> URL: https://issues.apache.org/jira/browse/GEODE-8611
> Project: Geode
> Issue Type: Bug
>Affects Versions: 1.13.0, 1.14.0
>Reporter: Jacob Barrett
>Priority: Major
>
> The JSSE {{KeyManagerFactory}} is instantiated using the default algorithm
> for the {{TrustManagerFactory}}. While most like they will both use the same
> algorithm if it was necessary to have them be different we could not. Setting
> the {{ssl.TrustManagerFactory.algorithm}} system property would affect both
> manger factories and {{ssl.KeyManagerFactory.algorithm}} would have no affect.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (GEODE-8608) StateFlush could hang when the target member is shutdown
[ https://issues.apache.org/jira/browse/GEODE-8608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anilkumar Gingade updated GEODE-8608: - Component/s: regions > StateFlush could hang when the target member is shutdown > > > Key: GEODE-8608 > URL: https://issues.apache.org/jira/browse/GEODE-8608 > Project: Geode > Issue Type: Bug > Components: membership, regions >Affects Versions: 1.12.0, 1.13.0, 1.14.0 >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Labels: pull-request-available > > This was introduced by GEODE-8385. > When the StateFlushReplyProcessor is wait for a reply of the target member, > if that member shuts down, the StateFlushReplyProcessor could wait forever > for that member to reply even though the member no longer in the view. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (GEODE-8612) Remove unused Redis constants
[ https://issues.apache.org/jira/browse/GEODE-8612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarah Abbey reassigned GEODE-8612: -- Assignee: Sarah Abbey > Remove unused Redis constants > - > > Key: GEODE-8612 > URL: https://issues.apache.org/jira/browse/GEODE-8612 > Project: Geode > Issue Type: Improvement > Components: redis >Reporter: Sarah Abbey >Assignee: Sarah Abbey >Priority: Trivial > > Remove constants we no longer use in `RedisConstants` -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-8612) Remove unused Redis constants
Sarah Abbey created GEODE-8612: -- Summary: Remove unused Redis constants Key: GEODE-8612 URL: https://issues.apache.org/jira/browse/GEODE-8612 Project: Geode Issue Type: Improvement Components: redis Reporter: Sarah Abbey Remove constants we no longer use in `RedisConstants` -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8612) Remove unused Redis constants
[ https://issues.apache.org/jira/browse/GEODE-8612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarah Abbey updated GEODE-8612: --- Priority: Trivial (was: Major) > Remove unused Redis constants > - > > Key: GEODE-8612 > URL: https://issues.apache.org/jira/browse/GEODE-8612 > Project: Geode > Issue Type: Improvement > Components: redis >Reporter: Sarah Abbey >Priority: Trivial > > Remove constants we no longer use in `RedisConstants` -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8612) Remove unused Redis constants
[ https://issues.apache.org/jira/browse/GEODE-8612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-8612: -- Labels: pull-request-available (was: ) > Remove unused Redis constants > - > > Key: GEODE-8612 > URL: https://issues.apache.org/jira/browse/GEODE-8612 > Project: Geode > Issue Type: Improvement > Components: redis >Reporter: Sarah Abbey >Assignee: Sarah Abbey >Priority: Trivial > Labels: pull-request-available > > Remove constants we no longer use in `RedisConstants` -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8612) Remove unused Redis constants
[ https://issues.apache.org/jira/browse/GEODE-8612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214267#comment-17214267 ] ASF GitHub Bot commented on GEODE-8612: --- sabbey37 opened a new pull request #5628: URL: https://github.com/apache/geode/pull/5628 Remove constants we no longer use in `RedisConstants` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove unused Redis constants > - > > Key: GEODE-8612 > URL: https://issues.apache.org/jira/browse/GEODE-8612 > Project: Geode > Issue Type: Improvement > Components: redis >Reporter: Sarah Abbey >Assignee: Sarah Abbey >Priority: Trivial > > Remove constants we no longer use in `RedisConstants` -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8607) Add new API for getting oldest tombstone age.
[
https://issues.apache.org/jira/browse/GEODE-8607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214277#comment-17214277
]
ASF GitHub Bot commented on GEODE-8607:
---
mhansonp commented on a change in pull request #5623:
URL: https://github.com/apache/geode/pull/5623#discussion_r504969566
##
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/TombstoneService.java
##
@@ -450,6 +450,11 @@ boolean testHook_forceExpiredTombstoneGC(int count, long
timeout, TimeUnit unit)
@Override
protected void beforeSleepChecks() {}
+
+@Override
+public long getOldestTombstoneTimeDelta() {
+ return tombstones.peek().getVersionTimeStamp() -
cacheTime.cacheTimeMillis();
Review comment:
I figured that it was one extra step that will always be done, but I
will change it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add new API for getting oldest tombstone age.
> -
>
> Key: GEODE-8607
> URL: https://issues.apache.org/jira/browse/GEODE-8607
> Project: Geode
> Issue Type: Bug
> Components: core
>Reporter: Mark Hanson
>Priority: Major
> Labels: pull-request-available
>
> It would be handy in diagnosing certain issues.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (GEODE-8593) Update native client examples to use Builder pattern
[
https://issues.apache.org/jira/browse/GEODE-8593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated GEODE-8593:
--
Labels: pull-request-available (was: )
> Update native client examples to use Builder pattern
>
>
> Key: GEODE-8593
> URL: https://issues.apache.org/jira/browse/GEODE-8593
> Project: Geode
> Issue Type: Improvement
> Components: docs, native client
>Affects Versions: 1.13.0
>Reporter: Dave Barnes
>Priority: Major
> Labels: pull-request-available
>
> For both C++ and .NET examples, the section of code that creates the
> connection pool should be improved to better illustrate the Builder pattern.
> For example, in the C++ examples, current code is:
> ```
> auto cacheFactory = CacheFactory();
> cacheFactory.set("log-level", "none");
> auto cache = cacheFactory.create();
> auto poolFactory = cache.getPoolManager().createFactory();
>
> poolFactory.addLocator("localhost", 10334);
> auto pool = poolFactory.create("pool");
> ```
> The improved version would be:
> ```
> auto cache = CacheFactory()
>.set("log-level", "debug")
>.set("ssl-enabled", "true")
>.set("ssl-truststore", clientTruststore.string())
>.create();
> cache.getPoolManager()
> .createFactory()
> .addLocator("localhost", 10334)
> .create("pool");
> ```
> Similarly for .NET examples.
> These doc snippets also appear in the user guides, so they'll need updating
> in the docs, as well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8593) Update native client examples to use Builder pattern
[
https://issues.apache.org/jira/browse/GEODE-8593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214282#comment-17214282
]
ASF GitHub Bot commented on GEODE-8593:
---
davebarnes97 opened a new pull request #675:
URL: https://github.com/apache/geode-native/pull/675
Modified examples and the docs that refer to them to show pool creation
using the builder pattern.
Reduced the Using Connection Pools section by about half to its
Configuration-related material (removed load-balancing).
Improved format of the example README files.
Built and ran all examples under MacOS (did not test under Windows).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update native client examples to use Builder pattern
>
>
> Key: GEODE-8593
> URL: https://issues.apache.org/jira/browse/GEODE-8593
> Project: Geode
> Issue Type: Improvement
> Components: docs, native client
>Affects Versions: 1.13.0
>Reporter: Dave Barnes
>Priority: Major
>
> For both C++ and .NET examples, the section of code that creates the
> connection pool should be improved to better illustrate the Builder pattern.
> For example, in the C++ examples, current code is:
> ```
> auto cacheFactory = CacheFactory();
> cacheFactory.set("log-level", "none");
> auto cache = cacheFactory.create();
> auto poolFactory = cache.getPoolManager().createFactory();
>
> poolFactory.addLocator("localhost", 10334);
> auto pool = poolFactory.create("pool");
> ```
> The improved version would be:
> ```
> auto cache = CacheFactory()
>.set("log-level", "debug")
>.set("ssl-enabled", "true")
>.set("ssl-truststore", clientTruststore.string())
>.create();
> cache.getPoolManager()
> .createFactory()
> .addLocator("localhost", 10334)
> .create("pool");
> ```
> Similarly for .NET examples.
> These doc snippets also appear in the user guides, so they'll need updating
> in the docs, as well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8606) Rename DistributedCloseableReference as DistributedReference
[ https://issues.apache.org/jira/browse/GEODE-8606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214289#comment-17214289 ] ASF GitHub Bot commented on GEODE-8606: --- kirklund merged pull request #5626: URL: https://github.com/apache/geode/pull/5626 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Rename DistributedCloseableReference as DistributedReference > > > Key: GEODE-8606 > URL: https://issues.apache.org/jira/browse/GEODE-8606 > Project: Geode > Issue Type: Wish > Components: tests >Reporter: Kirk Lund >Assignee: Kirk Lund >Priority: Major > Labels: pull-request-available > > Rename DistributedCloseableReference as DistributedReference. > Simple change that improves readability issues that I noticed while writing a > blog article. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8606) Rename DistributedCloseableReference as DistributedReference
[ https://issues.apache.org/jira/browse/GEODE-8606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214291#comment-17214291 ] ASF subversion and git services commented on GEODE-8606: Commit 200124078aab5056908670f34d696497ddad49c0 in geode's branch refs/heads/develop from Kirk Lund [ https://gitbox.apache.org/repos/asf?p=geode.git;h=2001240 ] GEODE-8606: Rename DistributedReference (#5626) This prevents line-wrapping in tests using DistributedReference improving readability. > Rename DistributedCloseableReference as DistributedReference > > > Key: GEODE-8606 > URL: https://issues.apache.org/jira/browse/GEODE-8606 > Project: Geode > Issue Type: Wish > Components: tests >Reporter: Kirk Lund >Assignee: Kirk Lund >Priority: Major > Labels: pull-request-available > > Rename DistributedCloseableReference as DistributedReference. > Simple change that improves readability issues that I noticed while writing a > blog article. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8608) StateFlush could hang when the target member is shutdown
[ https://issues.apache.org/jira/browse/GEODE-8608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214293#comment-17214293 ] ASF subversion and git services commented on GEODE-8608: Commit 4d5ed9ddb25a39677f4077c8f2acd964d8480986 in geode's branch refs/heads/develop from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=4d5ed9d ] GEODE-8608: StateFlush could hang when the target member is shutdown (#5624) Co-authored-by: Darrel Schneider Co-authored-by: Anil Co-authored-by: Bill Burcham > StateFlush could hang when the target member is shutdown > > > Key: GEODE-8608 > URL: https://issues.apache.org/jira/browse/GEODE-8608 > Project: Geode > Issue Type: Bug > Components: membership, regions >Affects Versions: 1.12.0, 1.13.0, 1.14.0 >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Labels: pull-request-available > > This was introduced by GEODE-8385. > When the StateFlushReplyProcessor is wait for a reply of the target member, > if that member shuts down, the StateFlushReplyProcessor could wait forever > for that member to reply even though the member no longer in the view. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8608) StateFlush could hang when the target member is shutdown
[ https://issues.apache.org/jira/browse/GEODE-8608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214292#comment-17214292 ] ASF GitHub Bot commented on GEODE-8608: --- gesterzhou merged pull request #5624: URL: https://github.com/apache/geode/pull/5624 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > StateFlush could hang when the target member is shutdown > > > Key: GEODE-8608 > URL: https://issues.apache.org/jira/browse/GEODE-8608 > Project: Geode > Issue Type: Bug > Components: membership, regions >Affects Versions: 1.12.0, 1.13.0, 1.14.0 >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Labels: pull-request-available > > This was introduced by GEODE-8385. > When the StateFlushReplyProcessor is wait for a reply of the target member, > if that member shuts down, the StateFlushReplyProcessor could wait forever > for that member to reply even though the member no longer in the view. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8609) Create a dunit suspect file per VM
[
https://issues.apache.org/jira/browse/GEODE-8609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214301#comment-17214301
]
ASF GitHub Bot commented on GEODE-8609:
---
demery-pivotal commented on a change in pull request #5625:
URL: https://github.com/apache/geode/pull/5625#discussion_r505009141
##
File path:
geode-dunit/src/main/java/org/apache/geode/test/dunit/internal/DUnitLauncher.java
##
@@ -343,59 +339,120 @@ public static void init(MasterRemote master) {
System.setProperty(LAUNCHED_PROPERTY, "true");
}
+ private static List getDunitSuspectFiles() {
+File[] suspectFiles = getDunitSuspectsDir()
+.listFiles((dir, name) -> name.startsWith(SUSPECT_FILENAME_PREFIX));
+
+return Arrays.asList(suspectFiles);
+ }
+
+ private static File getDunitSuspectsDir() {
+return Paths.get(getWorkspaceDir()).toFile();
+ }
+
+ private static void deleteDunitSuspectFiles() {
+getDunitSuspectFiles().forEach(File::delete);
+ }
+
+ private static File createDunitSuspectFile(int vmId, String workingDir) {
+String suffix;
+
+switch (vmId) {
+ case -2:
+suffix = "locator";
+break;
+ case -1:
+suffix = "local";
+break;
+ default:
+suffix = "vm" + vmId;
+}
+
+File dunitSuspect = new File(getDunitSuspectsDir(),
+String.format("%s-%s.log", SUSPECT_FILENAME_PREFIX, suffix));
+dunitSuspect.deleteOnExit();
+
+return dunitSuspect;
+ }
+
+ private static String getWorkspaceDir() {
+String workspaceDir =
System.getProperty(DUnitLauncher.WORKSPACE_DIR_PARAM);
+workspaceDir = workspaceDir == null ? new File(".").getAbsolutePath() :
workspaceDir;
+
+return workspaceDir;
+ }
+
public static void closeAndCheckForSuspects() {
-if (isLaunched()) {
- final List expectedStrings = ExpectedStrings.create("dunit");
- final LogConsumer logConsumer = new LogConsumer(true, expectedStrings,
"log4j", 5);
+if (!isLaunched()) {
+ return;
+}
- final StringBuilder suspectStringBuilder = new StringBuilder();
+List suspectFiles = getDunitSuspectFiles();
- BufferedReader buffReader = null;
- FileChannel fileChannel = null;
- try {
-fileChannel = new FileOutputStream(DUNIT_SUSPECT_FILE,
true).getChannel();
-buffReader = new BufferedReader(new FileReader(DUNIT_SUSPECT_FILE));
- } catch (FileNotFoundException e) {
-System.err.println("Could not find the suspect string output file: " +
e);
-return;
- }
+if (suspectFiles.isEmpty()) {
+ throw new IllegalStateException("No dunit suspect log files found in '"
+ + getDunitSuspectsDir().getAbsolutePath()
+ + "' - perhaps a rule that is cleaning up before suspect processing
has already run.");
+}
+
+for (File suspect : suspectFiles) {
+ checkSuspectFile(suspect);
+}
+ }
+
+ public static void checkSuspectFile(File suspectFile) {
+final List expectedStrings = ExpectedStrings.create("dunit");
+final LogConsumer logConsumer = new LogConsumer(true, expectedStrings,
+suspectFile.getName(), 5);
+
+final StringBuilder suspectStringBuilder = new StringBuilder();
+
+BufferedReader buffReader;
+FileChannel fileChannel;
+try {
+ fileChannel = new FileOutputStream(suspectFile, true).getChannel();
+ buffReader = new BufferedReader(new FileReader(suspectFile));
+} catch (FileNotFoundException e) {
+ System.err.println("Could not find the suspect string output file: " +
e);
+ return;
+}
+
+try {
+ String line;
try {
-String line;
-try {
- while ((line = buffReader.readLine()) != null) {
-final StringBuilder builder = logConsumer.consume(line);
-if (builder != null) {
- suspectStringBuilder.append(builder);
-}
+while ((line = buffReader.readLine()) != null) {
+ final StringBuilder builder = logConsumer.consume(line);
+ if (builder != null) {
+suspectStringBuilder.append(builder);
}
-} catch (IOException e) {
- System.err.println("Could not read the suspect string output file: "
+ e);
}
+ } catch (IOException e) {
+System.err.println("Could not read the suspect string output file: " +
e);
+ }
-try {
- fileChannel.truncate(0);
-} catch (IOException e) {
- System.err.println("Could not truncate the suspect string output
file: " + e);
-}
+ try {
+fileChannel.truncate(0);
+ } catch (IOException e) {
+System.err.println("Could not truncate the suspect string output file:
" + e);
+ }
- } finally {
-try {
- buffReader.close();
- fileChannel.close();
-} catch (IOException e) {
- System
[jira] [Commented] (GEODE-8608) StateFlush could hang when the target member is shutdown
[ https://issues.apache.org/jira/browse/GEODE-8608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214305#comment-17214305 ] ASF subversion and git services commented on GEODE-8608: Commit 21d77a84452f23ef3f2b6c5e4fe7e67f337c3820 in geode's branch refs/heads/support/1.12 from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=21d77a8 ] GEODE-8608: StateFlush could hang when the target member is shutdown (#5624) Co-authored-by: Darrel Schneider Co-authored-by: Anil Co-authored-by: Bill Burcham (cherry picked from commit 4d5ed9ddb25a39677f4077c8f2acd964d8480986) > StateFlush could hang when the target member is shutdown > > > Key: GEODE-8608 > URL: https://issues.apache.org/jira/browse/GEODE-8608 > Project: Geode > Issue Type: Bug > Components: membership, regions >Affects Versions: 1.12.0, 1.13.0, 1.14.0 >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Labels: pull-request-available > > This was introduced by GEODE-8385. > When the StateFlushReplyProcessor is wait for a reply of the target member, > if that member shuts down, the StateFlushReplyProcessor could wait forever > for that member to reply even though the member no longer in the view. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8608) StateFlush could hang when the target member is shutdown
[ https://issues.apache.org/jira/browse/GEODE-8608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214309#comment-17214309 ] ASF subversion and git services commented on GEODE-8608: Commit b6ae64f949d0056487d7d96e0f50a21f3441fa43 in geode's branch refs/heads/support/1.13 from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=b6ae64f ] GEODE-8608: StateFlush could hang when the target member is shutdown (#5624) Co-authored-by: Darrel Schneider Co-authored-by: Anil Co-authored-by: Bill Burcham (cherry picked from commit 4d5ed9ddb25a39677f4077c8f2acd964d8480986) > StateFlush could hang when the target member is shutdown > > > Key: GEODE-8608 > URL: https://issues.apache.org/jira/browse/GEODE-8608 > Project: Geode > Issue Type: Bug > Components: membership, regions >Affects Versions: 1.12.0, 1.13.0, 1.14.0 >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Labels: pull-request-available > > This was introduced by GEODE-8385. > When the StateFlushReplyProcessor is wait for a reply of the target member, > if that member shuts down, the StateFlushReplyProcessor could wait forever > for that member to reply even though the member no longer in the view. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-8608) StateFlush could hang when the target member is shutdown
[ https://issues.apache.org/jira/browse/GEODE-8608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaojian Zhou resolved GEODE-8608. -- Fix Version/s: 1.13.1 1.14.0 1.12.1 Resolution: Fixed > StateFlush could hang when the target member is shutdown > > > Key: GEODE-8608 > URL: https://issues.apache.org/jira/browse/GEODE-8608 > Project: Geode > Issue Type: Bug > Components: membership, regions >Affects Versions: 1.12.0, 1.13.0, 1.14.0 >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Labels: pull-request-available > Fix For: 1.12.1, 1.14.0, 1.13.1 > > > This was introduced by GEODE-8385. > When the StateFlushReplyProcessor is wait for a reply of the target member, > if that member shuts down, the StateFlushReplyProcessor could wait forever > for that member to reply even though the member no longer in the view. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8293) activeCQCount has negative value
[
https://issues.apache.org/jira/browse/GEODE-8293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214310#comment-17214310
]
ASF GitHub Bot commented on GEODE-8293:
---
karensmolermiller commented on a change in pull request #5620:
URL: https://github.com/apache/geode/pull/5620#discussion_r505024176
##
File path: geode-docs/reference/statistics_list.html.md.erb
##
@@ -553,7 +553,12 @@ These statistics are in a client and they describe one of
the client’s connect
## Continuous Querying (CqQueryStats)
-These statistics are for continuous querying information. The statistics are:
+These statistics are for continuous querying information.
+
+**Note:**
+The subscription redundancy changes CQS_ACTIVE, CQS_STOPPED and CQS_CLOSED
count on partitioned region
Review comment:
May we discuss what is intended in this Note? I don't understand it, so
I'd like to help revise the wording?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> activeCQCount has negative value
>
>
> Key: GEODE-8293
> URL: https://issues.apache.org/jira/browse/GEODE-8293
> Project: Geode
> Issue Type: Bug
> Components: statistics
>Reporter: Mario Kevo
>Assignee: Mario Kevo
>Priority: Major
> Labels: pull-request-available
>
> In case you have more than one server in the system and you close CQ there
> will be negative value of active cqs.
> The problem is when you started more than one server and execute cq on it. In
> that case we got incCqsActive on one server, but when it is closed we have
> decCqsActive on both servers.
> {code:java}
> gfsh>show metrics --categories=query
> Cluster-wide MetricsCategory | Metric | Value
> | | -
> query| activeCQCount| 1
> | queryRequestRate | 0.0
> {code}
> After cq is closed or stopped:
> {code:java}
> gfsh>show metrics --categories=query
> Cluster-wide Metrics
> Category | Metric | Value
> | | -
> query| activeCQCount| -1
> | queryRequestRate | 0.0
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
