[
https://issues.apache.org/jira/browse/GEODE-8609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214129#comment-17214129
]
ASF GitHub Bot commented on GEODE-8609:
---------------------------------------
jdeppe-pivotal opened a new pull request #5625:
URL: https://github.com/apache/geode/pull/5625
- Create a new `dunit_suspect` log for each VM. The logs will now
be named `dunit_suspect-vm<VMID>.log`. The locator VM and the test
runner VM will have logs named `dunit_suspect-locator.log` and
`dunit_suspect-local.log` respectively.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to d...@geode.apache.org.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Create a dunit suspect file per VM
> ----------------------------------
>
> Key: GEODE-8609
> URL: https://issues.apache.org/jira/browse/GEODE-8609
> Project: Geode
> Issue Type: Test
> Components: tests
> Reporter: Jens Deppe
> Assignee: Jens Deppe
> Priority: Major
>
> In some situations, especially when restarting Dunit VMs, it appears that the
> suspect log file can be corrupted since suspect processing reports errors
> such as:
> {noformat}
> org.apache.geode.redis.internal.executor.CrashAndNoRepeatDUnitTest >
> classMethod FAILED
> java.lang.AssertionError: Suspicious strings were written to the log
> during this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> -----------------------------------------------------------------------
> Found suspect string in log4j at line 19594
> /home/geode/.gradle/caches/modules-2/files-2.1/antlr/antlr/2.7.7/83cd2cd674a21[warn
> 2020/10/11 15:23:24.988 GMT <GeodeRedisServer-Command-2> tid=105] Execution
> of Redis command APPEND append-key-1 -append-key-1-17484- failed:
> org.apache.geode.cache.execute.FunctionException:
> org.apache.geode.cache.execute.FunctionInvocationTargetException:
> memberDeparted event for < 172.17.0.20(server-3:2004)<v15>:41003 > crashed,
> true{noformat}
> Where the suspected string is corrupted.
> The proposed fix will create a new dunit_suspect log for each VM. The logs
> will now be named {{dunit_suspect-vm<VMID>.log}}. The {{locator}} vm and the
> test runner vm will have logs named {{dunit_suspect-locator.log}} and
> {{dunit_suspect-local.log}} respectively.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
