[
https://issues.apache.org/jira/browse/GEODE-8607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214239#comment-17214239
]
ASF GitHub Bot commented on GEODE-8607:
---------------------------------------
agingade commented on a change in pull request #5623:
URL: https://github.com/apache/geode/pull/5623#discussion_r504938535
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/TombstoneService.java
##########
@@ -450,6 +450,11 @@ boolean testHook_forceExpiredTombstoneGC(int count, long
timeout, TimeUnit unit)
@Override
protected void beforeSleepChecks() {}
+
+ @Override
+ public long getOldestTombstoneTimeDelta() {
+ return tombstones.peek().getVersionTimeStamp() -
cacheTime.cacheTimeMillis();
Review comment:
The peek could return null...
Will it be a good enough to return version timestamp instead of delta...The
caller can calculate delta with different time mechanism (using cacheTime or
currentTime).
Also, will it be helpful if the tombstone.toString() info is returned...It
has all the information associated with tombstone.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add new API for getting oldest tombstone age.
> ---------------------------------------------
>
> Key: GEODE-8607
> URL: https://issues.apache.org/jira/browse/GEODE-8607
> Project: Geode
> Issue Type: Bug
> Components: core
> Reporter: Mark Hanson
> Priority: Major
> Labels: pull-request-available
>
> It would be handy in diagnosing certain issues.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
