[Bug rust/111899] [14 regression] GCC fails to bootstrap with 'rust-tree.cc:131:10: error: ‘NON_DEPENDENT_EXPR’ was not declared in this scope'

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111899

Andrew Pinski  changed:

   What|Removed |Added

   Keywords||build

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug rust/111899] [14 regression] GCC fails to bootstrap with 'rust-tree.cc:131:10: error: ‘NON_DEPENDENT_EXPR’ was not declared in this scope'

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111899

Andrew Pinski  changed:

   What|Removed |Added

   Target Milestone|--- |14.0

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug rust/111899] [14 regression] GCC fails to bootstrap with 'rust-tree.cc:131:10: error: ‘NON_DEPENDENT_EXPR’ was not declared in this scope'

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111899

--- Comment #2 from Andrew Pinski  ---
I noticed it via the build bot:
https://gcc.gnu.org/pipermail/gcc-testresults/2023-October/798851.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug rust/113056] [14 regression] Build failure in libgrust

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113056

--- Comment #3 from Andrew Pinski  ---
Well this is not right:
/var/tmp/portage/sys-devel/gcc-14.0.0_pre20231217/work/build/32/./gcc/xgcc: not

32 should not be there ...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug rust/113056] [14 regression] Build failure in libgrust

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113056

--- Comment #4 from Andrew Pinski  ---
Looks like multilib support in libgrust is just broken. I suspect it would be
worse on other targets where there are many more multilibs.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug rust/113056] [14 regression] Build failure in libgrust

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113056

Andrew Pinski  changed:

   What|Removed |Added

   Keywords||build

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug rust/113056] [14 regression] Build failure in libgrust

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113056

--- Comment #6 from Andrew Pinski  ---
I just did:
```
mkdir objdir
cd objdir
../configure --enable-languages=rust
make -j24
```

And it work ...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug rust/113056] [14 regression] Build failure in libgrust

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113056

Andrew Pinski  changed:

   What|Removed |Added

 Ever confirmed|0   |1
   Last reconfirmed||2023-12-18
 Status|UNCONFIRMED |WAITING

--- Comment #7 from Andrew Pinski  ---
Wait are you building in the src directory?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug rust/113056] [14 regression] Build failure in libgrust

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113056

--- Comment #9 from Andrew Pinski  ---
I am testing out using an absolute path for configure right now. Seeing if that
changes things ...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug rust/113461] [14 Regression] rust-proc-macro.cc:174:15: error: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'long long unsigned int' [-Werror=format=]

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113461

Andrew Pinski  changed:

   What|Removed |Added

   Target Milestone|--- |14.0
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
   Last reconfirmed||2024-01-18
   Keywords||build

--- Comment #1 from Andrew Pinski  ---
Confirmed, this was also reported on IRC.
I think there will be a patch pushed in the next day or so too to fix this.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug rust/113461] [14 Regression] rust-proc-macro.cc:174:15: error: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'long long unsigned int' [-Werror=format=]

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113461

--- Comment #4 from Andrew Pinski  ---
Try after r14-8211-g2341df1cb9b3681bfefe29207887b2b3dc271a95 which was just
committed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug rust/113553] rust fails to build on sparc64-linux-gnu

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113553

--- Comment #2 from Andrew Pinski  ---
Which glibc are you using?

See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82346 and maybe
https://sourceware.org/bugzilla/show_bug.cgi?id=22146

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug rust/113553] rust fails to build on sparc64-linux-gnu

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113553

--- Comment #6 from Andrew Pinski  ---
(In reply to John Paul Adrian Glaubitz from comment #5)
> (In reply to Rainer Orth from comment #1)
> > The build works for me just fine on sparc-sun-solaris2.11.
> > 
> > I've also fired one off on sparc64-unknown-linux-gnu which worked just as
> > well.
> > It was a rough ride, however, with the build aborting with
> > 
> > xgcc: fatal error: cannot execute
> > '/var/gcc/regression/master/6.4.0-gcc-gas-gld/build/./gcc/cc1plus':
> > posix_spawn: Bad address
> > 
> > several times.  When I ran make under strace -f, however, the build worked
> > just
> > fine.  Quite ugly, actually.
> 
> It seems that this can be avoided by building with one job, i.e. with "make
> -j1".
> 
> Some playing around showed that this fixes the problem for me:
> 
> diff --git a/libiberty/pex-unix.c b/libiberty/pex-unix.c
> index af98062a94c..a1d35820181 100644
> --- a/libiberty/pex-unix.c
> +++ b/libiberty/pex-unix.c
> @@ -574,8 +574,8 @@ pex_unix_exec_child (struct pex_obj *obj
> ATTRIBUTE_UNUSED,
>  {
>int ret;
>pid_t pid = -1;
> -  posix_spawnattr_t attr;
> -  posix_spawn_file_actions_t actions;
> +  static posix_spawnattr_t attr;
> +  static posix_spawn_file_actions_t actions;
>int attr_initialized = 0, actions_initialized = 0;
>  
>*err = 0;

Let me look that seems like an unitialized variable. If it is obvious one, I
will apply a patch.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug rust/113553] rust fails to build on sparc64-linux-gnu

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113553

Andrew Pinski  changed:

   What|Removed |Added

   See Also||https://sourceware.org/bugz
   ||illa/show_bug.cgi?id=31068

--- Comment #9 from Andrew Pinski  ---
(In reply to Andrew Pinski from comment #6)
> > Some playing around showed that this fixes the problem for me:
> > 
> > diff --git a/libiberty/pex-unix.c b/libiberty/pex-unix.c
> > index af98062a94c..a1d35820181 100644
> > --- a/libiberty/pex-unix.c
> > +++ b/libiberty/pex-unix.c
> > @@ -574,8 +574,8 @@ pex_unix_exec_child (struct pex_obj *obj
> > ATTRIBUTE_UNUSED,
> >  {
> >int ret;
> >pid_t pid = -1;
> > -  posix_spawnattr_t attr;
> > -  posix_spawn_file_actions_t actions;
> > +  static posix_spawnattr_t attr;
> > +  static posix_spawn_file_actions_t actions;
> >int attr_initialized = 0, actions_initialized = 0;
> >  
> >*err = 0;
> 
> Let me look that seems like an unitialized variable. If it is obvious one, I
> will apply a patch.

So I looked into pex-unix.c and the code does the right thing:
  ret = posix_spawnattr_init (&attr);
...
  ret = posix_spawn_file_actions_init (&actions);


And looking into glibc we have just basically:
  memset (attr, '\0', sizeof (*attr)); //__posix_spawnattr_init 
  memset (file_actions, '\0', sizeof (*file_actions)); //
__posix_spawn_file_actions_init

And that code has not changed in glibc for years (over 10) either.
So maybe memset is not working correctly. 

oh look at this a memset issue on sparc glibc:
https://sourceware.org/bugzilla/show_bug.cgi?id=31068 .

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug rust/113553] rust fails to build on sparc64-linux-gnu

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113553

--- Comment #11 from Andrew Pinski  ---
(In reply to John Paul Adrian Glaubitz from comment #10)
> (In reply to Andrew Pinski from comment #9)
> > oh look at this a memset issue on sparc glibc:
> > https://sourceware.org/bugzilla/show_bug.cgi?id=31068 .
> 
> Hmm, but this would be sparc32. Are you sure that this applies here?

Hmm, that is true. Still that does seem like memset is not working correctly.
Someone will need to debug memset because this code looks correct otherwise.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug rust/113553] rust fails to build on sparc64-linux-gnu

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113553

--- Comment #13 from Andrew Pinski  ---
(In reply to Bruno Haible from comment #12)
> For reference: The Gnulib unit tests for posix_spawn* pass on
> sparc-linux-gnu (both in 32-bit mode and in 64-bit mode).

But the issue sounds very intermittent which makes it sound like memset might
not always work. Even if the GNUlib unit test works, it might be different
alignment of the variables on the stack or something like that is causing the
failures there ...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug rust/114629] rust-ast-resolve-expr contains bloated code for funny_error

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114629

Andrew Pinski  changed:

   What|Removed |Added

 Ever confirmed|0   |1
   Last reconfirmed||2024-04-07
 Status|UNCONFIRMED |NEW
   Keywords||diagnostic

--- Comment #1 from Andrew Pinski  ---
Confirmed.

  else if (funny_error)
{
  /* This was a "break rust" or "break gcc", and the identifier failed to
 resolve.  Emit a funny ICE.  We set the finalizer to our custom one,
 and use the lower-level emit_diagnostic () instead of the more common
 internal_error_no_backtrace () in order to pass our locus.  */
  diagnostic_finalizer (global_dc) = funny_ice_finalizer;
  emit_diagnostic (DK_ICE_NOBT, expr.get_locus (), -1,
   "are you trying to break %s? how dare you?",
   expr.as_string ().c_str ());

This is not even that funny.
I suggest to remove the idea of funny_error really.
  if (ident == "rust" || ident == "gcc")
funny_error = true;

...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug rust/114629] rust-ast-resolve-expr contains bloated code for funny_error

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114629

--- Comment #5 from Andrew Pinski  ---
(In reply to Pierre-Emmanuel Patry from comment #2)
> I can see the problem with the message, but I don't think we can remove the
> behavior as we have to match rustc's behavior. The compiler has to ICE when
> meeting this identifier. I suggest changing the message to rustc's one "It
> looks like you're trying to break rust; would you like some ICE?" and
> removing the "gcc" identifier check.

Really this sounds like a bad idea to copy 100% of what rustc does. Instead we
should follow the rust language specification (hopefully that actually exists).

While you are at it, it would be useful to add a link to the rust langauge
specification (like there is for almost all other languages [I see objective-C
is not listed]) to https://gcc.gnu.org/readings.html .

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug rust/114629] rust-ast-resolve-expr contains bloated code for funny_error

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114629

--- Comment #6 from Andrew Pinski  ---
(In reply to Andrew Pinski from comment #5)
> While you are at it, it would be useful to add a link to the rust langauge
> specification (like there is for almost all other languages [I see
> objective-C is not listed]) to https://gcc.gnu.org/readings.html .

Also it would be useful to update https://gcc.gnu.org/frontends.html too.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug bootstrap/115453] [15 regression] Noise from new dlopen, pthread configure checks since r15-1177-g75299e4fe50aa8

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115453

--- Comment #10 from Andrew Pinski  ---
(In reply to Arthur Cohen from comment #9)
> Ah, sorry Andrew, I thought the component was referring to the origin of the
> issue. Just wanted to be able to find it in the list of Rust-related issues.
> Sorry!

One way to do this is to use `personal tags` though they only show up for your
account and not another account. This might be one of the few cases where rust
related issues are not in the rust components.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug bootstrap/115453] [15 regression] Noise from new dlopen, pthread configure checks since r15-1177-g75299e4fe50aa8

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115453

Andrew Pinski  changed:

   What|Removed |Added

   Keywords||build
  Component|rust|bootstrap

--- Comment #8 from Andrew Pinski  ---
Toplevel makefile is consider bootstrap component rather than rust ...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug rust/116561] [15 regression] gcc/testsuite/rust/execute/torture/iter1.rs:350:5: internal compiler error: 'verify_gimple' failed since r15-3328-g673a448aa24efedd5ac140ebf7bfe652d7a6a846

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116561

Andrew Pinski  changed:

   What|Removed |Added

   See Also||https://gcc.gnu.org/bugzill
   ||a/show_bug.cgi?id=117065

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug rust/116561] [15 regression] gcc/testsuite/rust/execute/torture/iter1.rs:350:5: internal compiler error: 'verify_gimple' failed since r15-3328-g673a448aa24efedd5ac140ebf7bfe652d7a6a846

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116561

--- Comment #3 from Andrew Pinski  ---
Note I think there is still a rust front-end issue. Because if error_mark_node
is making a difference that should not happen since error_mark_node should not
happen as a type unless there is an error and there was no error.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug rust/116561] [15 regression] gcc/testsuite/rust/execute/torture/iter1.rs:350:5: internal compiler error: 'verify_gimple' failed since r15-3328-g673a448aa24efedd5ac140ebf7bfe652d7a6a846

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116561

Andrew Pinski  changed:

   What|Removed |Added

   Target Milestone|--- |15.0

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug rust/117869] New: rust fails to build for me

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=117869

Bug ID: 117869
   Summary: rust fails to build for me
   Product: gcc
   Version: 15.0
Status: UNCONFIRMED
  Keywords: build, documentation
  Severity: normal
  Priority: P3
 Component: rust
  Assignee: unassigned at gcc dot gnu.org
  Reporter: pinskia at gcc dot gnu.org
CC: dkm at gcc dot gnu.org, gcc-rust at gcc dot gnu.org,
pierre-emmanuel.patry at embecosm dot com
  Target Milestone: ---

I did a `yum install cargo` and right now rust is failing for me to build:
```
make[4]: Entering directory
'/bajas/pinskia/src/upstream-gcc-isel/gcc/objdir/libgrust/libformat_parser'
cargo \
  --config
/home/apinski/src/upstream-gcc-isel/gcc/libgrust/libformat_parser/.cargo/config
\
  build \
--offline \
--target-dir . \
--manifest-path
/home/apinski/src/upstream-gcc-isel/gcc/libgrust/libformat_parser/Cargo.toml \
# FIXME: Not always '--release', right?
warning:
/home/apinski/src/upstream-gcc-isel/gcc/libgrust/libformat_parser/Cargo.toml:
`crate_type` is deprecated in favor of `crate-type` and will not work in the
2024 edition
(in the `libformat_parser` library target)
   Compiling libc v0.2.152
   Compiling unicode-xid v0.2.4
error: the `-Z unstable-options` flag must also be passed to enable the flag
`check-cfg`
error: the `-Z unstable-options` flag must also be passed to enable the flag
`check-cfg`


error: could not compile `unicode-xid` (lib)
warning: build failed, waiting for other jobs to finish...
error: could not compile `libc` (build script)
make[4]: *** [Makefile:431: debug/liblibformat_parser.a] Error 101
make[4]: Leaving directory
'/bajas/pinskia/src/upstream-gcc-isel/gcc/objdir/libgrust/libformat_parser'
make[3]: *** [Makefile:422: all-recursive] Error 1
make[3]: Leaving directory
'/bajas/pinskia/src/upstream-gcc-isel/gcc/objdir/libgrust'
make[2]: *** [Makefile:17763: all-stage1-libgrust] Error 2
make[2]: Leaving directory '/bajas/pinskia/src/upstream-gcc-isel/gcc/objdir'
make[1]: *** [Makefile:32497: stage1-bubble] Error 2
make[1]: Leaving directory '/bajas/pinskia/src/upstream-gcc-isel/gcc/objdir'
make: *** [Makefile:1104: all] Error 2

```

Note the version of cargo is required is not documented at all on
https://gcc.gnu.org/install/prerequisites.html . I had assumed centos stream 9
would have a decent version but maybe it does not.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug rust/119333] [15 regression] Rust bootstrap fails with cargo trying to download polonius crates

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=119333

Andrew Pinski  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #6 from Andrew Pinski  ---
Confirmed fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug rust/116561] [15 regression] gcc/testsuite/rust/execute/torture/iter1.rs:350:5: internal compiler error: 'verify_gimple' failed since r15-3328-g673a448aa24efedd5ac140ebf7bfe652d7a6a846

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116561

Andrew Pinski  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #4 from Andrew Pinski  ---
(In reply to Sam James from comment #2)
> (In reply to Thomas Schwinge from comment #1)
> > This appears to be due to recent commit
> > r15-3328-g673a448aa24efedd5ac140ebf7bfe652d7a6a846 "Optimize initialization
> > of small padded objects".
> > 
> > Given this commit doesn't appear to be causing any other issues, chances are
> > that the Rust front end is doing "something funny"?
> 
> It seems to have started passing yesterday or so, probably after
> r15-5772-gf93059c82e61d6.

I reverted that patch and tried again. looks like the front-end is fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug rust/119353] [15 regression] Rust fails to build (build failure: error[E0554]: `#![feature]` may not be used on the stable release channel)

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=119353

Andrew Pinski  changed:

   What|Removed |Added

   Last reconfirmed||2025-03-18
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW
   Severity|normal  |blocker

--- Comment #4 from Andrew Pinski  ---
Even CentOS 9 has something slightly older:
[apinski@xeond2 gcc]$ rustc --version
rustc 1.82.0 (f6e511eec 2024-10-15) (Red Hat 1.82.0-1.el9)

ubuntu 2204 has either 1.27.1 or 1.75.0 which the earliest LTS supported
ubuntu.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug rust/119341] New: statement_list in rust-gcc.cc can use range for

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=119341

Bug ID: 119341
   Summary: statement_list in rust-gcc.cc can use range for
   Product: gcc
   Version: 15.0
Status: UNCONFIRMED
  Keywords: internal-improvement
  Severity: normal
  Priority: P3
 Component: rust
  Assignee: pinskia at gcc dot gnu.org
  Reporter: pinskia at gcc dot gnu.org
CC: dkm at gcc dot gnu.org, gcc-rust at gcc dot gnu.org,
pierre-emmanuel.patry at embecosm dot com
  Target Milestone: ---

Right now statement_list does:
```
  for (std::vector::const_iterator p = statements.begin ();
   p != statements.end (); ++p)
{
  tree t = (*p);

```

But this can be rewritten as:
```
  for (tree t : statements)
```


I am writing up this bug report to remind me to write a patch for this after
finishing up using error_operand_p more inside the rust fe.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug rust/119341] statement_list in rust-gcc.cc can use range for

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=119341

Andrew Pinski  changed:

   What|Removed |Added

URL||https://gcc.gnu.org/piperma
   ||il/gcc-patches/2025-March/6
   ||78070.html
   Keywords||patch

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug rust/119363] [15 Regression] gccrs fails to build, error[E0554]: `#![feature]` may not be used on the stable release channel

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=119363

Andrew Pinski  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Andrew Pinski  ---
Dup.

*** This bug has been marked as a duplicate of bug 119353 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug rust/119342] block in rust-gcc.cc could use some comments

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=119342

Andrew Pinski  changed:

   What|Removed |Added

 Ever confirmed|0   |1
   Last reconfirmed||2025-03-17
 Status|UNCONFIRMED |ASSIGNED

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug rust/119353] [15 regression] Rust fails to build (build failure: error[E0554]: `#![feature]` may not be used on the stable release channel)

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=119353

Andrew Pinski  changed:

   What|Removed |Added

 CC||doko at gcc dot gnu.org

--- Comment #6 from Andrew Pinski  ---
*** Bug 119363 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug rust/119342] block in rust-gcc.cc could use some comments

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=119342

Andrew Pinski  changed:

   What|Removed |Added

URL||https://gcc.gnu.org/piperma
   ||il/gcc-patches/2025-March/6
   ||78069.html
   Keywords||patch

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug rust/119641] New: narrowing Warning during bootstrap in Rust::BIR::PlaceDB::lookup_or_add_variable

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=119641

Bug ID: 119641
   Summary: narrowing Warning during bootstrap in
Rust::BIR::PlaceDB::lookup_or_add_variable
   Product: gcc
   Version: 15.0
Status: UNCONFIRMED
  Severity: normal
  Priority: P3
 Component: rust
  Assignee: unassigned at gcc dot gnu.org
  Reporter: pinskia at gcc dot gnu.org
CC: dkm at gcc dot gnu.org, gcc-rust at gcc dot gnu.org,
pierre-emmanuel.patry at embecosm dot com
  Target Milestone: ---

```
/home/apinski/src/upstream-gcc-match/gcc/gcc/rust/checks/errors/borrowck/rust-bir-place.h:
In member function ‘Rust::BIR::PlaceId
Rust::BIR::PlaceDB::lookup_or_add_variable(Rust::NodeId,
Rust::TyTy::BaseType*)’:
/home/apinski/src/upstream-gcc-match/gcc/gcc/rust/checks/errors/borrowck/rust-bir-place.h:422:28:
warning: narrowing conversion of
‘(((Rust::BIR::PlaceDB*)this)->Rust::BIR::PlaceDB::places.Rust::BIR::IndexVec::size() - 1)’ from ‘size_t’ {aka ‘long unsigned int’} to
‘uint32_t’ {aka ‘unsigned int’} [-Wnarrowing]
  422 | return {places.size () - 1};
  | ~~~^~~
```

It would be useful to get this fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug rust/119508] Hundreds of rust tests XPASS

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=119508

--- Comment #2 from Andrew Pinski  ---
(In reply to Pierre-Emmanuel Patry from comment #1)
> There is something funny happening here because canonical_paths1.rs should
> not pass, nr2 tests are a list of test with an additional flag. We're using
> it to reduce the gap between both name resolution.
> 
> Does XPASSEs happen solely on Solaris or does it also happen on x86_64 ?

I see them also even on x86_64-linux-gnu.
Basically there is an ICE which is not reported and then the XPASS is due to
the diagnostic showing up.

crab1: internal compiler error: in visit, at
rust/resolve/rust-late-name-resolver-2.0.cc:342
0x2acc11f internal_error(char const*, ...)
   
/home/apinski/src/upstream-gcc-match/gcc/gcc/diagnostic-global-context.cc:517
0xb55de1 fancy_abort(char const*, int, char const*)
/home/apinski/src/upstream-gcc-match/gcc/gcc/diagnostic.cc:1749
0x92df13 Rust::Resolver2_0::Late::visit(Rust::AST::TypePath&)
   
/home/apinski/src/upstream-gcc-match/gcc/gcc/rust/resolve/rust-late-name-resolver-2.0.cc:342
0xc648de void
Rust::AST::DefaultASTVisitor::visit(Rust::AST::Type&)
   
/home/apinski/src/upstream-gcc-match/gcc/gcc/rust/ast/rust-ast-visitor.h:402
0xc648de Rust::AST::DefaultASTVisitor::visit(Rust::AST::InherentImpl&)
   
/home/apinski/src/upstream-gcc-match/gcc/gcc/rust/ast/rust-ast-visitor.cc:1018
0xe10cf3 std::function::operator()() const
   
/home/apinski/src/upstream-gcc-match/gcc/objdir/prev-x86_64-pc-linux-gnu/libstdc++-v3/include/bits/std_function.h:593
0xe10cf3
Rust::Resolver2_0::NameResolutionContext::scoped(Rust::Resolver2_0::Rib::Kind,
unsigned int, std::function, tl::optional)
   
/home/apinski/src/upstream-gcc-match/gcc/gcc/rust/resolve/rust-name-resolution-context.cc:122
0xe13c6f Rust::Resolver2_0::DefaultResolver::visit(Rust::AST::InherentImpl&)
   
/home/apinski/src/upstream-gcc-match/gcc/gcc/rust/resolve/rust-default-resolver.cc:77
0xc6399f void
Rust::AST::DefaultASTVisitor::visit(std::unique_ptr >&)
   
/home/apinski/src/upstream-gcc-match/gcc/gcc/rust/ast/rust-ast-visitor.h:406
0xc6399f Rust::AST::DefaultASTVisitor::visit(Rust::AST::Module&)
   
/home/apinski/src/upstream-gcc-match/gcc/gcc/rust/ast/rust-ast-visitor.cc:785
0xe10cf3 std::function::operator()() const
   
/home/apinski/src/upstream-gcc-match/gcc/objdir/prev-x86_64-pc-linux-gnu/libstdc++-v3/include/bits/std_function.h:593
0xe10cf3
Rust::Resolver2_0::NameResolutionContext::scoped(Rust::Resolver2_0::Rib::Kind,
unsigned int, std::function, tl::optional)
   
/home/apinski/src/upstream-gcc-match/gcc/gcc/rust/resolve/rust-name-resolution-context.cc:122
0xe14093 Rust::Resolver2_0::DefaultResolver::visit(Rust::AST::Module&)
   
/home/apinski/src/upstream-gcc-match/gcc/gcc/rust/resolve/rust-default-resolver.cc:43
0xe2e9df Rust::Resolver2_0::Late::go(Rust::AST::Crate&)
   
/home/apinski/src/upstream-gcc-match/gcc/gcc/rust/resolve/rust-late-name-resolver-2.0.cc:118
0xc925fd Rust::Session::compile_crate(char const*)
   
/home/apinski/src/upstream-gcc-match/gcc/gcc/rust/rust-session-manager.cc:648
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See  for instructions.
compiler exited with status 1

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug rust/119342] New: block in rust-gcc.cc could use some comments

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=119342

Bug ID: 119342
   Summary: block in rust-gcc.cc could use some comments
   Product: gcc
   Version: 15.0
Status: UNCONFIRMED
  Keywords: internal-improvement
  Severity: normal
  Priority: P3
 Component: rust
  Assignee: pinskia at gcc dot gnu.org
  Reporter: pinskia at gcc dot gnu.org
CC: dkm at gcc dot gnu.org, gcc-rust at gcc dot gnu.org,
pierre-emmanuel.patry at embecosm dot com
  Target Milestone: ---

block will chain together the decls that are part of the scope so they are part
of the new BLOCK:
```
  tree *pp = &BLOCK_VARS (block_tree);
  for (std::vector::const_iterator pv = vars.begin ();
   pv != vars.end (); ++pv)
{
  *pp = (*pv)->get_decl ();
  if (!error_operand_p (*pp))
pp = &DECL_CHAIN (*pp);
}
```

But unless you understand how BLOCKs work in the first place, it is not obvious
what this is doing.

A comment should be added like:
// Chain together the variables from the scope so they are part of the new
block

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug rust/119341] statement_list in rust-gcc.cc can use range for

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=119341

Andrew Pinski  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |ASSIGNED
   Last reconfirmed||2025-03-17

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug rust/119341] statement_list in rust-gcc.cc can use range for

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=119341

--- Comment #1 from Andrew Pinski  ---
a few others:
block_add_statements 
block
function_set_parameters

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug rust/119341] statement_list in rust-gcc.cc can use range for

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=119341

--- Comment #2 from Andrew Pinski  ---
function_type_variadic

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug rust/119341] statement_list in rust-gcc.cc can use range for

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=119341

--- Comment #3 from Andrew Pinski  ---
function_ptr_type uses it already for an example.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug rust/119508] Hundreds of rust tests XPASS

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=119508

--- Comment #4 from Andrew Pinski  ---
I wonder if it is showing up due to running the testsuite with -jN

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug rust/117869] rust fails to build with cargo command error

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=117869

Andrew Pinski  changed:

   What|Removed |Added

   Target Milestone|--- |15.0
 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED

--- Comment #4 from Andrew Pinski  ---
https://gcc.gnu.org/pipermail/gcc-cvs/2025-April/421309.html

Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug rust/119341] statement_list in rust-gcc.cc can use range for

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=119341

Andrew Pinski  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED
   Target Milestone|--- |15.0

--- Comment #5 from Andrew Pinski  ---
Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug rust/117869] rust fails to build with cargo command error

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=117869

--- Comment #5 from Andrew Pinski  ---
And I can confirm I can build rust now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug rust/119342] block in rust-gcc.cc could use some comments

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=119342

Andrew Pinski  changed:

   What|Removed |Added

   Target Milestone|--- |15.0
 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from Andrew Pinski  ---
Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug rust/108087] -Wodr warnings in rust/rust-lang.cc (lang_type)

[pinskia at gcc dot gnu.org via Gcc-rust]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108087

Andrew Pinski  changed:

   What|Removed |Added

   Keywords||build

--- Comment #2 from Andrew Pinski  ---
This does look like a real issue in the rust front-end.
lang_type is defined differently in those two files.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-- 
Gcc-rust mailing list
Gcc-rust@gcc.gnu.org
https://gcc.gnu.org/mailman/listinfo/gcc-rust

[Bug middle-end/108102] rust bootstrap comparison failure on s390x-linux-gnu

[pinskia at gcc dot gnu.org via Gcc-rust]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108102

Andrew Pinski  changed:

   What|Removed |Added

   Keywords||build
  Component|rust|middle-end

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-- 
Gcc-rust mailing list
Gcc-rust@gcc.gnu.org
https://gcc.gnu.org/mailman/listinfo/gcc-rust

[Bug middle-end/108102] rust bootstrap comparison failure on s390x-linux-gnu

[pinskia at gcc dot gnu.org via Gcc-rust]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108102

Andrew Pinski  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|WAITING |UNCONFIRMED

--- Comment #3 from Andrew Pinski  ---
Moved to middle-end since the code that is causing issues is c++ code.

Can you attach the preprocessed source? I wonder if this is a -g0 vs -g issue
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-- 
Gcc-rust mailing list
Gcc-rust@gcc.gnu.org
https://gcc.gnu.org/mailman/listinfo/gcc-rust

[Bug middle-end/108102] rust bootstrap comparison failure on s390x-linux-gnu

[pinskia at gcc dot gnu.org via Gcc-rust]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108102

--- Comment #5 from Andrew Pinski  ---
(In reply to Stefan Schulze Frielinghaus from comment #4) 
> and the current working directory was most likely /devel/gcc/build/gcc.
> Creating a symlink from $build/stage1-gcc to $build/prev-gcc and then
> running the command from above doesn't do the trick. There is probably an
> easier way which I miss. Any hints?

See stage2-start/stage3-start I think.

See
https://gcc.gnu.org/onlinedocs/gccint/Makefile.html#Makefile

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-- 
Gcc-rust mailing list
Gcc-rust@gcc.gnu.org
https://gcc.gnu.org/mailman/listinfo/gcc-rust