[Bug rust/119342] New: block in rust-gcc.cc could use some comments

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=119342

            Bug ID: 119342
           Summary: block in rust-gcc.cc could use some comments
           Product: gcc
           Version: 15.0
            Status: UNCONFIRMED
          Keywords: internal-improvement
          Severity: normal
          Priority: P3
         Component: rust
          Assignee: pinskia at gcc dot gnu.org
          Reporter: pinskia at gcc dot gnu.org
                CC: dkm at gcc dot gnu.org, gcc-rust at gcc dot gnu.org,
                    pierre-emmanuel.patry at embecosm dot com
  Target Milestone: ---

block will chain together the decls that are part of the scope so they are part
of the new BLOCK:
```
  tree *pp = &BLOCK_VARS (block_tree);
  for (std::vector<Bvariable *>::const_iterator pv = vars.begin ();
       pv != vars.end (); ++pv)
    {
      *pp = (*pv)->get_decl ();
      if (!error_operand_p (*pp))
        pp = &DECL_CHAIN (*pp);
    }
```

But unless you understand how BLOCKs work in the first place, it is not obvious
what this is doing.

A comment should be added like:
// Chain together the variables from the scope so they are part of the new
block

-- 
You are receiving this mail because:
You are on the CC list for the bug.