[Bug 61086] Some clients hang when HTTP responses give status 205 Reset Content
https://bz.apache.org/bugzilla/show_bug.cgi?id=61086
Alexandr Saperov changed:
What|Removed |Added
Status|RESOLVED|REOPENED
Resolution|FIXED |---
--- Comment #3 from Alexandr Saperov ---
Still reproducable on 8.5.16-19.
org.apache.coyote.http11.Http11Processor
...
1129 entityBody = false;
1130 contentDelimitation = true;
1131 if (statusCode == 205) {
1132// RFC 7231 requires the server to explicitly signal an empty
1133// response in this case
1134response.setContentLength(0);
1135 }
...
1166 if (!entityBody) {
1167response.setContentLength(-1);
1168 }
Explicitly setting contentLength(0) in 1134 overrides by 1167, so response
doesn't contain Content-Length header.
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1803030 - in /tomcat/trunk: java/org/apache/catalina/core/ApplicationPushBuilder.java test/org/apache/catalina/core/TestApplicationPushBuilder.java webapps/docs/changelog.xml
Author: markt
Date: Wed Jul 26 09:36:29 2017
New Revision: 1803030
URL: http://svn.apache.org/viewvc?rev=1803030&view=rev
Log:
Correct a bug in the PushBuilder implementation that meant push URLs containing
%nn sequences were not correctly decoded. Identified by FindBugs.
Modified:
tomcat/trunk/java/org/apache/catalina/core/ApplicationPushBuilder.java
tomcat/trunk/test/org/apache/catalina/core/TestApplicationPushBuilder.java
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/java/org/apache/catalina/core/ApplicationPushBuilder.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/ApplicationPushBuilder.java?rev=1803030&r1=1803029&r2=1803030&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/ApplicationPushBuilder.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/core/ApplicationPushBuilder.java Wed
Jul 26 09:36:29 2017
@@ -382,7 +382,7 @@ public class ApplicationPushBuilder impl
StringBuilder result = new StringBuilder(input.length());
while (start != -1) {
-// Found the start of a %nn sequence. Copy everything form the last
+// Found the start of a %nn sequence. Copy everything from the last
// end to this start to the output.
result.append(input.substring(end, start));
// Advance the end 3 characters: %nn
@@ -403,7 +403,7 @@ public class ApplicationPushBuilder impl
private static String decodePercentSequence(String sequence, Charset
charset) {
byte[] bytes = new byte[sequence.length()/3];
for (int i = 0; i < bytes.length; i += 3) {
-bytes[i] = (byte) (HexUtils.getDec(sequence.charAt(1 + 3 * i)) <<
4 +
+bytes[i] = (byte) ((HexUtils.getDec(sequence.charAt(1 + 3 * i)) <<
4) +
HexUtils.getDec(sequence.charAt(2 + 3 * i)));
}
Modified:
tomcat/trunk/test/org/apache/catalina/core/TestApplicationPushBuilder.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/core/TestApplicationPushBuilder.java?rev=1803030&r1=1803029&r2=1803030&view=diff
==
--- tomcat/trunk/test/org/apache/catalina/core/TestApplicationPushBuilder.java
(original)
+++ tomcat/trunk/test/org/apache/catalina/core/TestApplicationPushBuilder.java
Wed Jul 26 09:36:29 2017
@@ -49,6 +49,21 @@ public class TestApplicationPushBuilder
doTest("foo%20", StandardCharsets.UTF_8, "foo ");
}
+@Test
+public void test06() {
+doTest("%21foo", StandardCharsets.UTF_8, "!foo");
+}
+
+@Test
+public void test07() {
+doTest("fo%21o", StandardCharsets.UTF_8, "fo!o");
+}
+
+@Test
+public void test08() {
+doTest("foo%21", StandardCharsets.UTF_8, "foo!");
+}
+
private void doTest(String input, Charset charset, String expected) {
String result = ApplicationPushBuilder.decode(input, charset);
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1803030&r1=1803029&r2=1803030&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Wed Jul 26 09:36:29 2017
@@ -45,6 +45,13 @@
issues do not "pop up" wrt. others).
-->
+
+
+ Correct a bug in the PushBuilder implementation that
+ meant push URLs containing %nn sequences were not correctly
+ decoded. Identified by FindBugs. (markt)
+
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1803031 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/core/ApplicationPushBuilder.java test/org/apache/catalina/core/TestApplicationPushBuilder.java webapps/docs/changelog.xml
Author: markt Date: Wed Jul 26 09:41:05 2017 New Revision: 1803031 URL: http://svn.apache.org/viewvc?rev=1803031&view=rev Log: Correct a bug in the PushBuilder implementation that meant push URLs containing %nn sequences were not correctly decoded. Identified by FindBugs. Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/catalina/core/ApplicationPushBuilder.java tomcat/tc8.5.x/trunk/test/org/apache/catalina/core/TestApplicationPushBuilder.java tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml Propchange: tomcat/tc8.5.x/trunk/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Wed Jul 26 09:41:05 2017 @@ -1 +1 @@ -/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501 ,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745535,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747404,1747506,1747 536,1747924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1756289,1756408-1 756410,1756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762051-1762053,1762123,176216 8,1762172,1762182,1762201-1762202,1762204,1762208,1762288,1762296,1762324,1762348,1762353,1762362,1762374,1762492,1762503,1762505,1762541,1762608,1762710,1762753,1762766,1762769,1762944,1762947,1762953,1763167,1763179,1763232,1763259,1763271-1763
[Bug 61086] Some clients hang when HTTP responses give status 205 Reset Content
https://bz.apache.org/bugzilla/show_bug.cgi?id=61086 Alexandr Saperov changed: What|Removed |Added CC||mt...@yandex.ru --- Comment #4 from Alexandr Saperov --- Created attachment 35175 --> https://bz.apache.org/bugzilla/attachment.cgi?id=35175&action=edit Patch 0-length content for 205 status -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 61086] Some clients hang when HTTP responses give status 205 Reset Content
https://bz.apache.org/bugzilla/show_bug.cgi?id=61086 --- Comment #5 from Violeta Georgieva --- Hi, (In reply to Alexandr Saperov from comment #4) > Created attachment 35175 [details] > Patch 0-length content for 205 status Would you mind to add a test case also? Thanks, Violeta -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 61345] New: Allow system property value replacement from the digester property source
https://bz.apache.org/bugzilla/show_bug.cgi?id=61345 Bug ID: 61345 Summary: Allow system property value replacement from the digester property source Product: Tomcat 9 Version: unspecified Hardware: PC OS: Linux Status: NEW Severity: normal Priority: P2 Component: Util Assignee: dev@tomcat.apache.org Reporter: r...@apache.org Target Milestone: - Created attachment 35178 --> https://bz.apache.org/bugzilla/attachment.cgi?id=35178&action=edit Listener for system property replacement Add a server listener that can be used to do system property replacement from the property source configured in the digester. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.19
Hi, 2017-07-25 2:22 GMT+03:00 Mark Thomas : > > The proposed Apache Tomcat 8.5.19 release is now available for voting. > > The major changes compared to the 8.5.16 release are: > > - Enable TLS connectors to use Java key stores that contain multiple > keys where each key has a separate password. Based on a patch by Frank > Taffelt. > > - Make asynchronous error handling more robust. In particular ensure > that onError() is called for any registered AsyncListeners after an > I/O error on a non-container thread. > > - Sync SSL session access for the APR connector to prevent errors when > accessing the session. > > > Along with lots of other bug fixes and improvements. > > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.19/ > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1146/ > The svn tag is: > http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_19/ > > The proposed 8.5.19 release is: > [ ] Broken - do not release > [X] Stable - go ahead and release as 8.5.19 +1 My tests passed Regards, Violeta > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org >
[Bug 61086] Some clients hang when HTTP responses give status 205 Reset Content
https://bz.apache.org/bugzilla/show_bug.cgi?id=61086 --- Comment #6 from Alexandr Saperov --- Created attachment 35179 --> https://bz.apache.org/bugzilla/attachment.cgi?id=35179&action=edit standalone application with embedded tomcat Building standalone application with embedded tomcat: mvn clean package running application: java -jar target/tomcat-61086-1.0-SNAPSHOT.jar Making request with curl: curl -v "localhost:8080/" curl hangs for 1 minute (default timeout) -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1803038 - in /tomcat/trunk: java/org/apache/tomcat/util/digester/Digester.java java/org/apache/tomcat/util/digester/LocalStrings.properties webapps/docs/changelog.xml webapps/docs/config/
Author: remm
Date: Wed Jul 26 12:15:45 2017
New Revision: 1803038
URL: http://svn.apache.org/viewvc?rev=1803038&view=rev
Log:
61345: Add a server listener that can be used to do system property replacement
from the property source configured in the digester.
Modified:
tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java
tomcat/trunk/java/org/apache/tomcat/util/digester/LocalStrings.properties
tomcat/trunk/webapps/docs/changelog.xml
tomcat/trunk/webapps/docs/config/systemprops.xml
Modified: tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java?rev=1803038&r1=1803037&r2=1803038&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java Wed Jul 26
12:15:45 2017
@@ -29,12 +29,17 @@ import java.util.EmptyStackException;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
+import java.util.Properties;
import java.util.PropertyPermission;
+import java.util.Set;
import javax.xml.parsers.ParserConfigurationException;
import javax.xml.parsers.SAXParser;
import javax.xml.parsers.SAXParserFactory;
+import org.apache.catalina.Lifecycle;
+import org.apache.catalina.LifecycleEvent;
+import org.apache.catalina.LifecycleListener;
import org.apache.juli.logging.Log;
import org.apache.juli.logging.LogFactory;
import org.apache.tomcat.util.ExceptionUtils;
@@ -307,6 +312,35 @@ public class Digester extends DefaultHan
}
}
+
+public static class SystemPropertyReplacementListener
+implements LifecycleListener {
+protected Log log = LogFactory.getLog(Digester.class);
+protected StringManager sm = StringManager.getManager(Digester.class);
+@Override
+public void lifecycleEvent(LifecycleEvent event) {
+if (propertySource != null &&
Lifecycle.BEFORE_INIT_EVENT.equals(event.getType())) {
+IntrospectionUtils.PropertySource[] propertySources =
+new IntrospectionUtils.PropertySource[] {
propertySource };
+Properties properties = System.getProperties();
+Set names = properties.stringPropertyNames();
+for (String name : names) {
+String value = System.getProperty(name);
+if (value != null) {
+try {
+String newValue =
IntrospectionUtils.replaceProperties(value, null, propertySources);
+if (value != newValue) {
+System.setProperty(name, newValue);
+}
+} catch (Exception e) {
+
log.warn(sm.getString("digester.failedToUpdateSystemProperty", name, value), e);
+}
+}
+}
+}
+}
+}
+
// - Properties
Modified:
tomcat/trunk/java/org/apache/tomcat/util/digester/LocalStrings.properties
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/digester/LocalStrings.properties?rev=1803038&r1=1803037&r2=1803038&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/digester/LocalStrings.properties
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/digester/LocalStrings.properties
Wed Jul 26 12:15:45 2017
@@ -15,3 +15,4 @@
disgester.encodingInvalid=The encoding [{0}] is not recognised by the JRE and
will be ignored
digester.failedToUpdateAttributes=Attribute [{0}] failed to update and remains
[{1}]
+digester.failedToUpdateSystemProperty=System property [{0}] failed to update
and remains [{1}]
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1803038&r1=1803037&r2=1803038&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Wed Jul 26 12:15:45 2017
@@ -52,6 +52,15 @@
decoded. Identified by FindBugs. (markt)
+
+
+
+61345: Add a server listener that can be used to do system
+ property replacement from the property source configured in the
+ digester. (remm)
+
+
+
Modified: tomcat/trunk/webapps/docs/config/systemprops.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/systemprops.xml?rev=1803038&r1=1803037&r2=1803038&view=diff
==
--- tomcat/trunk/webapps/docs/config/systemprops.xml (ori
svn commit: r1803039 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/digester/Digester.java java/org/apache/tomcat/util/digester/LocalStrings.properties webapps/docs/changelog.xml webapps/d
Author: remm Date: Wed Jul 26 12:29:01 2017 New Revision: 1803039 URL: http://svn.apache.org/viewvc?rev=1803039&view=rev Log: 61345: Add a server listener that can be used to do system property replacement from the property source configured in the digester. Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/digester/Digester.java tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/digester/LocalStrings.properties tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml tomcat/tc8.5.x/trunk/webapps/docs/config/systemprops.xml Propchange: tomcat/tc8.5.x/trunk/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Wed Jul 26 12:29:01 2017 @@ -1 +1 @@ -/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501 ,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745535,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747404,1747506,1747 536,1747924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1756289,1756408-1 756410,1756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762051-1762053,1762123,176216 8,1762172,1762182,1762201-1762202,1762204,1762208,1762288,1762296,1762324,1762348,1762353,1762362,1762374,1762492,1762503,1762505,1762541,1762608,1762710,1762753,1762766,1762769,1762944,1762947,1762953,176316
[Bug 61345] Allow system property value replacement from the digester property source
https://bz.apache.org/bugzilla/show_bug.cgi?id=61345 Remy Maucherat changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from Remy Maucherat --- I have added this minor feature to 9M26 and 8.5.20, and I don't plan to backport it further unless there's demand for it. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 57645] getContext("/") returns null
https://bz.apache.org/bugzilla/show_bug.cgi?id=57645 Paul Taylor changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #6 from Paul Taylor --- It looks like this bug was re-introduced on the Tomcat 7 branch in 7.0.61 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1803038 - in /tomcat/trunk: java/org/apache/tomcat/util/digester/Digester.java java/org/apache/tomcat/util/digester/LocalStrings.properties webapps/docs/changelog.xml webapps/docs/con
1. This does not belong to Coyote (as you wrote in changelog.xml).
2. Lack of documentation.
Listeners are documented in config/listeners.xml. E.g.:
http://tomcat.us.apache.org/tomcat-8.5-doc/config/listeners.html
3. It does not use all property sources used by Digester. (It uses
Digester.propertySource, not Digester.source).
Generally, this means that it does not perform substitutions of
${system properties} (handled by Digester$SystemPropertySource), but
only of those handled by custom property source.
Generally, substitution of system properties is a wanted feature, but
there are some properties that do not need such replacement, e.g.
"common.loader" property.
4. If this feature is configured as a , it means that it
will be performed only on Tomcat startup, but not on shutdown (where
only the root element of server.xml is parsed).
Based on #3, #4 I thought tha
5. Update
2017-07-26 15:15 GMT+03:00 :
> Author: remm
> Date: Wed Jul 26 12:15:45 2017
> New Revision: 1803038
>
> URL: http://svn.apache.org/viewvc?rev=1803038&view=rev
> Log:
> 61345: Add a server listener that can be used to do system property
> replacement from the property source configured in the digester.
>
> Modified:
> tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java
> tomcat/trunk/java/org/apache/tomcat/util/digester/LocalStrings.properties
> tomcat/trunk/webapps/docs/changelog.xml
> tomcat/trunk/webapps/docs/config/systemprops.xml
>
> Modified: tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java
> URL:
> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java?rev=1803038&r1=1803037&r2=1803038&view=diff
> ==
> --- tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java (original)
> +++ tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java Wed Jul
> 26 12:15:45 2017
> @@ -29,12 +29,17 @@ import java.util.EmptyStackException;
> import java.util.HashMap;
> import java.util.List;
> import java.util.Map;
> +import java.util.Properties;
> import java.util.PropertyPermission;
> +import java.util.Set;
>
> import javax.xml.parsers.ParserConfigurationException;
> import javax.xml.parsers.SAXParser;
> import javax.xml.parsers.SAXParserFactory;
>
> +import org.apache.catalina.Lifecycle;
> +import org.apache.catalina.LifecycleEvent;
> +import org.apache.catalina.LifecycleListener;
> import org.apache.juli.logging.Log;
> import org.apache.juli.logging.LogFactory;
> import org.apache.tomcat.util.ExceptionUtils;
> @@ -307,6 +312,35 @@ public class Digester extends DefaultHan
> }
> }
>
> +
> +public static class SystemPropertyReplacementListener
> +implements LifecycleListener {
> +protected Log log = LogFactory.getLog(Digester.class);
> +protected StringManager sm =
> StringManager.getManager(Digester.class);
> +@Override
> +public void lifecycleEvent(LifecycleEvent event) {
> +if (propertySource != null &&
> Lifecycle.BEFORE_INIT_EVENT.equals(event.getType())) {
> +IntrospectionUtils.PropertySource[] propertySources =
> +new IntrospectionUtils.PropertySource[] {
> propertySource };
> +Properties properties = System.getProperties();
> +Set names = properties.stringPropertyNames();
> +for (String name : names) {
> +String value = System.getProperty(name);
> +if (value != null) {
> +try {
> +String newValue =
> IntrospectionUtils.replaceProperties(value, null, propertySources);
> +if (value != newValue) {
> +System.setProperty(name, newValue);
> +}
> +} catch (Exception e) {
> +
> log.warn(sm.getString("digester.failedToUpdateSystemProperty", name, value),
> e);
> +}
> +}
> +}
> +}
> +}
> +}
> +
>
> // -
> Properties
>
>
> Modified:
> tomcat/trunk/java/org/apache/tomcat/util/digester/LocalStrings.properties
> URL:
> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/digester/LocalStrings.properties?rev=1803038&r1=1803037&r2=1803038&view=diff
> ==
> --- tomcat/trunk/java/org/apache/tomcat/util/digester/LocalStrings.properties
> (original)
> +++ tomcat/trunk/java/org/apache/tomcat/util/digester/LocalStrings.properties
> Wed Jul 26 12:15:45 2017
> @@ -15,3 +15,4 @@
>
> disgester.encodingInvalid=The encoding [{0}] is not recognised by the JRE
> and will be ignored
> digester.failedToUpdateAttributes=Attribute [{0}] failed
Re: svn commit: r1803038 - in /tomcat/trunk: java/org/apache/tomcat/util/digester/Digester.java java/org/apache/tomcat/util/digester/LocalStrings.properties webapps/docs/changelog.xml webapps/docs/con
(Updated. Occasionally sent too early.)
2017-07-26 16:14 GMT+03:00 Konstantin Kolinko :
> 1. This does not belong to Coyote (as you wrote in changelog.xml).
I see why it belongs to Digester: it uses Digester.propertySource.
In changelog this is "Other" section.
> 2. Lack of documentation.
> Listeners are documented in config/listeners.xml. E.g.:
>
> http://tomcat.us.apache.org/tomcat-8.5-doc/config/listeners.html
>
> 3. It does not use all property sources used by Digester. (It uses
> Digester.propertySource, not Digester.source).
>
> Generally, this means that it does not perform substitutions of
> ${system properties} (handled by Digester$SystemPropertySource), but
> only of those handled by custom property source.
>
> Generally, substitution of system properties is a wanted feature, but
> there are some properties that do not need such replacement, e.g.
> "common.loader" property.
>
> 4. If this feature is configured as a , it means that it
> will be performed only on Tomcat startup, but not on shutdown (where
> only the root element of server.xml is parsed).
Based on #3, #4 I thought that such feature (replacement of system
properties) could be configurable in catalina.properties, with
configuration of what properties are not subject for replacement.
Best regards,
Konstantin Kolinko
> 2017-07-26 15:15 GMT+03:00 :
>> Author: remm
>> Date: Wed Jul 26 12:15:45 2017
>> New Revision: 1803038
>>
>> URL: http://svn.apache.org/viewvc?rev=1803038&view=rev
>> Log:
>> 61345: Add a server listener that can be used to do system property
>> replacement from the property source configured in the digester.
>>
>> Modified:
>> tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java
>> tomcat/trunk/java/org/apache/tomcat/util/digester/LocalStrings.properties
>> tomcat/trunk/webapps/docs/changelog.xml
>> tomcat/trunk/webapps/docs/config/systemprops.xml
>>
>> Modified: tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java
>> URL:
>> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java?rev=1803038&r1=1803037&r2=1803038&view=diff
>> ==
>> --- tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java
>> (original)
>> +++ tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java Wed Jul
>> 26 12:15:45 2017
>> @@ -29,12 +29,17 @@ import java.util.EmptyStackException;
>> import java.util.HashMap;
>> import java.util.List;
>> import java.util.Map;
>> +import java.util.Properties;
>> import java.util.PropertyPermission;
>> +import java.util.Set;
>>
>> import javax.xml.parsers.ParserConfigurationException;
>> import javax.xml.parsers.SAXParser;
>> import javax.xml.parsers.SAXParserFactory;
>>
>> +import org.apache.catalina.Lifecycle;
>> +import org.apache.catalina.LifecycleEvent;
>> +import org.apache.catalina.LifecycleListener;
>> import org.apache.juli.logging.Log;
>> import org.apache.juli.logging.LogFactory;
>> import org.apache.tomcat.util.ExceptionUtils;
>> @@ -307,6 +312,35 @@ public class Digester extends DefaultHan
>> }
>> }
>>
>> +
>> +public static class SystemPropertyReplacementListener
>> +implements LifecycleListener {
>> +protected Log log = LogFactory.getLog(Digester.class);
>> +protected StringManager sm =
>> StringManager.getManager(Digester.class);
>> +@Override
>> +public void lifecycleEvent(LifecycleEvent event) {
>> +if (propertySource != null &&
>> Lifecycle.BEFORE_INIT_EVENT.equals(event.getType())) {
>> +IntrospectionUtils.PropertySource[] propertySources =
>> +new IntrospectionUtils.PropertySource[] {
>> propertySource };
>> +Properties properties = System.getProperties();
>> +Set names = properties.stringPropertyNames();
>> +for (String name : names) {
>> +String value = System.getProperty(name);
>> +if (value != null) {
>> +try {
>> +String newValue =
>> IntrospectionUtils.replaceProperties(value, null, propertySources);
>> +if (value != newValue) {
>> +System.setProperty(name, newValue);
>> +}
>> +} catch (Exception e) {
>> +
>> log.warn(sm.getString("digester.failedToUpdateSystemProperty", name, value),
>> e);
>> +}
>> +}
>> +}
>> +}
>> +}
>> +}
>> +
>>
>> // -
>> Properties
>>
>>
>> Modified:
>> tomcat/trunk/java/org/apache/tomcat/util/digester/LocalStrings.properties
>> URL:
>> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/digester/LocalStrings.properties?
Re: svn commit: r1803038 - in /tomcat/trunk: java/org/apache/tomcat/util/digester/Digester.java java/org/apache/tomcat/util/digester/LocalStrings.properties webapps/docs/changelog.xml webapps/docs/con
On Wed, Jul 26, 2017 at 3:21 PM, Konstantin Kolinko
wrote:
> (Updated. Occasionally sent too early.)
>
> 2017-07-26 16:14 GMT+03:00 Konstantin Kolinko :
> > 1. This does not belong to Coyote (as you wrote in changelog.xml).
>
> I see why it belongs to Digester: it uses Digester.propertySource.
>
> In changelog this is "Other" section.
>
> > 2. Lack of documentation.
> > Listeners are documented in config/listeners.xml. E.g.:
> >
> > http://tomcat.us.apache.org/tomcat-8.5-doc/config/listeners.html
> >
> > 3. It does not use all property sources used by Digester. (It uses
> > Digester.propertySource, not Digester.source).
> >
> > Generally, this means that it does not perform substitutions of
> > ${system properties} (handled by Digester$SystemPropertySource), but
> > only of those handled by custom property source.
> >
> > Generally, substitution of system properties is a wanted feature, but
> > there are some properties that do not need such replacement, e.g.
> > "common.loader" property.
> >
> > 4. If this feature is configured as a , it means that it
> > will be performed only on Tomcat startup, but not on shutdown (where
> > only the root element of server.xml is parsed).
>
> Based on #3, #4 I thought that such feature (replacement of system
> properties) could be configurable in catalina.properties, with
> configuration of what properties are not subject for replacement.
>
The purpose is to use the property source configured and only that one. The
(weird) source field from digester only used to add a system property
replacer, which I feared would be bad here (so it won't property replace
"common.loader" or anything internal unless the property source configured
has it).
It is documented with the property source since this is where it belongs as
far as I am concerned. I added the listener this way to the Digester class
to not allow wider access to the property source (which is a location where
obsfucated values may be accessible). We use the property source for
integration with this: https://github.com/picketbox/tomcat-vault
I'm not convinced this is a very useful feature, but hey, it doesn't hurt
too much that way ...
Rémy
>
> Best regards,
> Konstantin Kolinko
>
> > 2017-07-26 15:15 GMT+03:00 :
> >> Author: remm
> >> Date: Wed Jul 26 12:15:45 2017
> >> New Revision: 1803038
> >>
> >> URL: http://svn.apache.org/viewvc?rev=1803038&view=rev
> >> Log:
> >> 61345: Add a server listener that can be used to do system property
> replacement from the property source configured in the digester.
> >>
> >> Modified:
> >> tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java
> >> tomcat/trunk/java/org/apache/tomcat/util/digester/
> LocalStrings.properties
> >> tomcat/trunk/webapps/docs/changelog.xml
> >> tomcat/trunk/webapps/docs/config/systemprops.xml
> >>
> >> Modified: tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.
> java
> >> URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/
> tomcat/util/digester/Digester.java?rev=1803038&r1=1803037&
> r2=1803038&view=diff
> >>
> ==
> >> --- tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java
> (original)
> >> +++ tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java
> Wed Jul 26 12:15:45 2017
> >> @@ -29,12 +29,17 @@ import java.util.EmptyStackException;
> >> import java.util.HashMap;
> >> import java.util.List;
> >> import java.util.Map;
> >> +import java.util.Properties;
> >> import java.util.PropertyPermission;
> >> +import java.util.Set;
> >>
> >> import javax.xml.parsers.ParserConfigurationException;
> >> import javax.xml.parsers.SAXParser;
> >> import javax.xml.parsers.SAXParserFactory;
> >>
> >> +import org.apache.catalina.Lifecycle;
> >> +import org.apache.catalina.LifecycleEvent;
> >> +import org.apache.catalina.LifecycleListener;
> >> import org.apache.juli.logging.Log;
> >> import org.apache.juli.logging.LogFactory;
> >> import org.apache.tomcat.util.ExceptionUtils;
> >> @@ -307,6 +312,35 @@ public class Digester extends DefaultHan
> >> }
> >> }
> >>
> >> +
> >> +public static class SystemPropertyReplacementListener
> >> +implements LifecycleListener {
> >> +protected Log log = LogFactory.getLog(Digester.class);
> >> +protected StringManager sm = StringManager.getManager(
> Digester.class);
> >> +@Override
> >> +public void lifecycleEvent(LifecycleEvent event) {
> >> +if (propertySource != null &&
> >> Lifecycle.BEFORE_INIT_EVENT.equals(event.getType()))
> {
> >> +IntrospectionUtils.PropertySource[] propertySources =
> >> +new IntrospectionUtils.PropertySource[] {
> propertySource };
> >> +Properties properties = System.getProperties();
> >> +Set names = properties.stringPropertyNames();
> >> +for (String name : names) {
> >> +
[Bug 57645] getContext("/") returns null
https://bz.apache.org/bugzilla/show_bug.cgi?id=57645 Konstantin Kolinko changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED --- Comment #7 from Konstantin Kolinko --- (In reply to Paul Taylor from comment #6) Quick test: It does work in 7.0.78. Note that the ServletContext.getContext() method is disabled by default for security reasons. It must be explicitly enabled by setting crossContext="true" in Context configuration of the calling web application. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 57645] getContext("/") returns null
https://bz.apache.org/bugzilla/show_bug.cgi?id=57645
--- Comment #8 from Konstantin Kolinko ---
Created attachment 35180
--> https://bz.apache.org/bugzilla/attachment.cgi?id=35180&action=edit
test.war
Sample web application that demonstrates that the feature is working
successfully.
Steps:
1. Deploy it as webapps/test.war
2. Start Tomcat
3. Access http://localhost:8080/test/
It prints:
getContext("/"): org.apache.catalina.core.ApplicationContextFacade@16b6c55
Tested with 7.0.78.
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 61347] New: Maven Java 8 Web Project does deploys in Apache Tomcat.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61347 Bug ID: 61347 Summary: Maven Java 8 Web Project does deploys in Apache Tomcat. Product: Tomcat 8 Version: 8.5.16 Hardware: PC Status: NEW Severity: blocker Priority: P2 Component: Examples Assignee: dev@tomcat.apache.org Reporter: bkna...@gmail.com Target Milestone: Created attachment 35181 --> https://bz.apache.org/bugzilla/attachment.cgi?id=35181&action=edit Reference Project to reproduce reported error. Hi Team, I created a java web maven project in JDK 1.8. It’s get successfully compiled in eclipse and but when I deployed this project in Apache tomcat then it's showing me an error at the time of deployment. In attached reference project you can find a Java class with name TradeServiceImpl and this class exposed as a rest web service. In this class I used Java 1.8 new feathers like for each loop. Line no 42. error: java.lang.ArrayIndexOutOfBoundsException: 2560 at org.objectweb.asm.ClassReader.accept(Unknown Source) at org.objectweb.asm.ClassReader.accept(Unknown Source) at com.sun.jersey.spi.scanning.AnnotationScannerListener.onProcess(AnnotationScannerListener.java:133) at com.sun.jersey.core.spi.scanning.uri.FileSchemeScanner$1.f(FileSchemeScanner.java:86) at com.sun.jersey.core.util.Closing.f(Closing.java:71) at com.sun.jersey.core.spi.scanning.uri.FileSchemeScanner.scanDirectory(FileSchemeScanner.java:83) at com.sun.jersey.core.spi.scanning.uri.FileSchemeScanner.scan(FileSchemeScanner.java:71) at com.sun.jersey.core.spi.scanning.PackageNamesScanner.scan(PackageNamesScanner.java:223) My finding: When I comment the line number 42 and use old style of looping statement in class TradeServiceImpl, then it's get deployed successfully in Apache tomcat. At initial level I thing it may be jar versions issue but if this is jar version issue then why Instant, Duration classes (Introduced in Java 1.8) is executing. Please check POM.XML For reference, I attached sample project in this ticket. Please find it. Dependency Requirements JDK Version: 1.8 MAVEN: 3.5.0 Apache-Tomcat: 8.5.16 Eclipse: Eclipse Oxygen Rest Client: Postman Steps to reproduce this error 1) Unzip attached file. 2) Import this maven project in eclipse and resolve the dependency. 3) Then run this project. 4) Configure this project with Apache, you can attach Apache in eclipse. 5) Run this project in eclipse. Request Type: POST Request URL: http://localhost:8080/RestWebProject/service/tradeService/service -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 61347] Maven Java 8 Web Project does deploys in Apache Tomcat.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61347 Arun Unniyal changed: What|Removed |Added OS||All -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 61347] Maven Java 8 Web Project does deploys in Apache Tomcat.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61347 mgrigorov changed: What|Removed |Added Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from mgrigorov --- There is no problem in Tomcat. The problem is in your libraries - Jersey and/or ASM. Please use the users@ mailing list for questions. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1803055 - in /tomcat/trunk/java/org/apache: catalina/core/ catalina/startup/ coyote/http2/ tomcat/util/descriptor/web/ tomcat/websocket/
Author: remm
Date: Wed Jul 26 14:37:20 2017
New Revision: 1803055
URL: http://svn.apache.org/viewvc?rev=1803055&view=rev
Log:
Fix bit sign checks warnings, no functional change.
Modified:
tomcat/trunk/java/org/apache/catalina/core/ApplicationFilterFactory.java
tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java
tomcat/trunk/java/org/apache/coyote/http2/ByteUtil.java
tomcat/trunk/java/org/apache/coyote/http2/Flags.java
tomcat/trunk/java/org/apache/tomcat/util/descriptor/web/FilterMap.java
tomcat/trunk/java/org/apache/tomcat/websocket/PerMessageDeflate.java
tomcat/trunk/java/org/apache/tomcat/websocket/Util.java
tomcat/trunk/java/org/apache/tomcat/websocket/WsFrameBase.java
Modified:
tomcat/trunk/java/org/apache/catalina/core/ApplicationFilterFactory.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/ApplicationFilterFactory.java?rev=1803055&r1=1803054&r2=1803055&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/ApplicationFilterFactory.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/core/ApplicationFilterFactory.java
Wed Jul 26 14:37:20 2017
@@ -260,27 +260,27 @@ public final class ApplicationFilterFact
private static boolean matchDispatcher(FilterMap filterMap, DispatcherType
type) {
switch (type) {
case FORWARD :
-if ((filterMap.getDispatcherMapping() & FilterMap.FORWARD) >
0) {
-return true;
+if ((filterMap.getDispatcherMapping() & FilterMap.FORWARD) !=
0) {
+return true;
}
break;
case INCLUDE :
-if ((filterMap.getDispatcherMapping() & FilterMap.INCLUDE) >
0) {
+if ((filterMap.getDispatcherMapping() & FilterMap.INCLUDE) !=
0) {
return true;
}
break;
case REQUEST :
-if ((filterMap.getDispatcherMapping() & FilterMap.REQUEST) >
0) {
+if ((filterMap.getDispatcherMapping() & FilterMap.REQUEST) !=
0) {
return true;
}
break;
case ERROR :
-if ((filterMap.getDispatcherMapping() & FilterMap.ERROR) > 0) {
+if ((filterMap.getDispatcherMapping() & FilterMap.ERROR) != 0)
{
return true;
}
break;
case ASYNC :
-if ((filterMap.getDispatcherMapping() & FilterMap.ASYNC) > 0) {
+if ((filterMap.getDispatcherMapping() & FilterMap.ASYNC) != 0)
{
return true;
}
break;
Modified: tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java?rev=1803055&r1=1803054&r2=1803055&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java (original)
+++ tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java Wed Jul 26
14:37:20 2017
@@ -2130,7 +2130,7 @@ public class ContextConfig implements Li
}
if ((javaClass.getAccessFlags() &
-org.apache.tomcat.util.bcel.Const.ACC_ANNOTATION) > 0) {
+org.apache.tomcat.util.bcel.Const.ACC_ANNOTATION) != 0) {
// Skip annotations.
return;
}
Modified: tomcat/trunk/java/org/apache/coyote/http2/ByteUtil.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http2/ByteUtil.java?rev=1803055&r1=1803054&r2=1803055&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http2/ByteUtil.java (original)
+++ tomcat/trunk/java/org/apache/coyote/http2/ByteUtil.java Wed Jul 26 14:37:20
2017
@@ -27,7 +27,7 @@ class ByteUtil {
static boolean isBit7Set(byte input) {
-return (input & 0x80) > 0;
+return (input & 0x80) != 0;
}
Modified: tomcat/trunk/java/org/apache/coyote/http2/Flags.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http2/Flags.java?rev=1803055&r1=1803054&r2=1803055&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http2/Flags.java (original)
+++ tomcat/trunk/java/org/apache/coyote/http2/Flags.java Wed Jul 26 14:37:20
2017
@@ -24,26 +24,26 @@ class Flags {
static boolean isEndOfStream(int flags) {
-return (flags & 0x01) > 0;
+return (flags & 0x01) != 0;
}
static boolean isAck(int flags) {
-return (flags & 0x01) > 0;
+return (flags & 0x01) != 0;
}
static boolean isEndOfHeaders(int flags) {
-retu
svn commit: r1803056 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/core/ java/org/apache/catalina/startup/ java/org/apache/coyote/http2/ java/org/apache/tomcat/util/descriptor/web/ java/org/
Author: remm Date: Wed Jul 26 14:38:54 2017 New Revision: 1803056 URL: http://svn.apache.org/viewvc?rev=1803056&view=rev Log: Fix bit sign checks warnings, no functional change Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/catalina/core/ApplicationFilterFactory.java tomcat/tc8.5.x/trunk/java/org/apache/catalina/startup/ContextConfig.java tomcat/tc8.5.x/trunk/java/org/apache/coyote/http2/ByteUtil.java tomcat/tc8.5.x/trunk/java/org/apache/coyote/http2/Flags.java tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/descriptor/web/FilterMap.java tomcat/tc8.5.x/trunk/java/org/apache/tomcat/websocket/PerMessageDeflate.java tomcat/tc8.5.x/trunk/java/org/apache/tomcat/websocket/Util.java tomcat/tc8.5.x/trunk/java/org/apache/tomcat/websocket/WsFrameBase.java Propchange: tomcat/tc8.5.x/trunk/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Wed Jul 26 14:38:54 2017 @@ -1 +1 @@ -/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501 ,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745535,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747404,1747506,1747 536,1747924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1756289,1756408-1 756410,1756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761
Re: svn commit: r1803055 - in /tomcat/trunk/java/org/apache: catalina/core/ catalina/startup/ coyote/http2/ tomcat/util/descriptor/web/ tomcat/websocket/
On Wed, Jul 26, 2017 at 4:37 PM, wrote: > Author: remm > Date: Wed Jul 26 14:37:20 2017 > New Revision: 1803055 > > URL: http://svn.apache.org/viewvc?rev=1803055&view=rev > Log: > Fix bit sign checks warnings, no functional change. > > To which branches should non functional cleanups like this be backported now ? 8.5: yes 8.0: no because of planned EOL ? 7.0: yes ? 6.0: no Rémy
Re: [VOTE] Release Apache Tomcat 8.5.18
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, I'm repeating all tests for the 8.5.19 release, so I'll see if I can get it to fail again. Thanks, - -chris On 7/20/17 3:56 PM, Mark Thomas wrote: > On 20/07/17 19:09, Christopher Schultz wrote: >> Mark, >> >> On 7/18/17 9:58 AM, Mark Thomas wrote: >>> The proposed Apache Tomcat 8.5.18 release is now available for >>> voting. > > > >>> The proposed 8.5.18 release is: [ ] Broken - do not release >>> [?] Stable - go ahead and release as 8.5.18 >> >> Works fine for me in a development environment. *There was a unit >> test failure I've never seen before.* Someone who knows more >> about this particular test might want to weigh-in on whether or >> not this is a problem. >> >> Details below. > > > >> For TestVirtualContext (which only failed for NIO2, oddly), here >> are the errors: >> >> 20-Jul-2017 12:10:16.422 SEVERE >> [http-nio2-127.0.0.1-auto-2-exec-2] >> org.apache.catalina.core.StandardHostValve.invoke Exception >> Processing null java.lang.NullPointerException at >> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperV alv >> >> e.java:236) > > OK. That is in the exception handling. That is odd to start with > since we don't expect this test to enter that code. As to what > might be triggering the NPE, it could be any of: - container - > container.getLogger() - wrapper - context > > None of which should ever be null at that point. > > > >> 20-Jul-2017 12:10:16.427 SEVERE >> [http-nio2-127.0.0.1-auto-2-exec-2] >> org.apache.coyote.http11.Http11Processor.service Error processing >> reques t java.lang.NullPointerException at >> org.apache.catalina.connector.Request.notifyAttributeAssigned(Request .ja >> >> va:1555) > > That suggests context is null. > > > >> 20-Jul-2017 12:10:16.440 SEVERE >> [http-nio2-127.0.0.1-auto-2-exec-2] >> org.apache.coyote.http11.Http11Processor.endRequest Error >> finishing response java.lang.NullPointerException at >> org.apache.coyote.http11.Http11OutputBuffer.commit(Http11OutputBuffer .ja >> >> va:368) > > That suggests socketWrapper is null. > > > >> ... and then finally: Testcase: testVirtualClassLoader took >> 14.813 sec Caused an ERROR Read timed out >> java.net.SocketTimeoutException: Read timed out at >> java.net.SocketInputStream.socketRead0(Native Method) > > Hmm. The test should complete in a couple of seconds. > > > >> org.apache.catalina.loader.TestVirtualContext.testVirtualClassLoader( Tes >> >> tVirtualContext.java:105) > > and finally that is the first request made to Tomcat as part of > this test. > > I'm guessing that this failure is not repeatable.. > > Given everything is on localhost, a network glitch seems unlikely. > Some sort of threading / timing issue seems more likely. > > If it isn't repeatable, I'm not sure there is a lot we can do > about this. It suggests that there might be an issue somewhere - > maybe in the start-up code - but it could equally be an issue with > the test code. > > I'd be tempted to note this but carry on with the release unless it > is repeatable. > > Mark > > - > > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > -BEGIN PGP SIGNATURE- Comment: GPGTools - http://gpgtools.org Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBCAAGBQJZeMZwAAoJEBzwKT+lPKRYmIIP/18XTeTMJrbsoB8n7IikIcKH hM3AkU4LyI53d+G8swfDPDZ1FTvf4uG6L85Hxm80KdsLFwlV/AXkAa8WNLQ7SwVZ vXA8VVJfyy8ChgjTQiZ19h9LUtAuqMiQtbJ04WdHyTGF4AA+oL1NS0pQ5U3QHFi8 xeHjSK+4ab4ZazdroIJWvo2xDq9d59ckxqE5kwYUUN7ws6YKtkGiLD5nS+LIYp21 O2RvTbN5gAJjkgX7c4kRC9aL11PDCOnd7KcEkSwWyPaGwMaArPPql0eslKGBPNeF sVSugNJAgwR8bbQ4wJAFFYexHdHUxpSxSJU1Gy4YdeA0HJFZ0BOOnBGkHXOWeugY Y3Es2vN1GZcLlWQtaodnxaHMmk80eCpg1XGsK0X4ClhWzA7bY4k1vu+E54QFfyiN pm1ibViBFFmLHTYHn1iMohJ+UcNgpdHXMiIgrg8yx8lDrsORRYP9mThKMHbJ/rdr xa86GoTO3EDPwvTj34m1KUrPQoTWFvbr/6Ih9QvMvZ/WS3oZt6Tw4IBCbk1kDKUh tp2mCNeMAW9TKvRo+OvwtX3xF3LZ0O7pAU7UbcI6eTn5EOnXxvWZD7FpwD0GUux2 dT1Yqa+19lHUSHM2hNnDGyKJqeKDzhN0XT05zuMdSPas5Y50UJi88f+zDnq/3Rc9 cfZGmU+9LgohEV7Y0UKf =+Rnw -END PGP SIGNATURE- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1803055 - in /tomcat/trunk/java/org/apache: catalina/core/ catalina/startup/ coyote/http2/ tomcat/util/descriptor/web/ tomcat/websocket/
On 26/07/2017 15:42, Rémy Maucherat wrote: > On Wed, Jul 26, 2017 at 4:37 PM, wrote: > >> Author: remm >> Date: Wed Jul 26 14:37:20 2017 >> New Revision: 1803055 >> >> URL: http://svn.apache.org/viewvc?rev=1803055&view=rev >> Log: >> Fix bit sign checks warnings, no functional change. >> >> To which branches should non functional cleanups like this be backported > now ? I'd say assess each one on its merits and back-port it as far as you think makes sense. If another committer wants to back-port it further that would be fine too. My personal view (and what I think I'd do by default) is: > 8.5: yes +1 > 8.0: no because of planned EOL ? Probably not. But if there is a possibility of a bug I probably would. > 7.0: yes ? Probably, unless the back-port was complex and the issue cosmetic. > 6.0: no +1 Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 9.0.0.M25
On 25/07/2017 00:19, Mark Thomas wrote: > The proposed 9.0.0.M25 release is: > [ ] Broken - do not release > [X] Alpha - go ahead and release as 9.0.0.M25 All unit tests passed with NIO, NIO2 and APR/native (1.2.12) on Linux Windows and macOS. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.19
On 25/07/2017 00:22, Mark Thomas wrote: > The proposed Apache Tomcat 8.5.19 release is now available for voting. > > The major changes compared to the 8.5.16 release are: > > - Enable TLS connectors to use Java key stores that contain multiple > keys where each key has a separate password. Based on a patch by Frank > Taffelt. > > - Make asynchronous error handling more robust. In particular ensure > that onError() is called for any registered AsyncListeners after an > I/O error on a non-container thread. > > - Sync SSL session access for the APR connector to prevent errors when > accessing the session. > > > Along with lots of other bug fixes and improvements. > > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.19/ > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1146/ > The svn tag is: > http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_19/ > > The proposed 8.5.19 release is: > [ ] Broken - do not release > [X] Stable - go ahead and release as 8.5.19 All unit tests passed with NIO, NIO2 and APR/native (1.2.12) on Linux Windows and macOS. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GUMP@vmgump-vm3]: Project tomcat-trunk-validate (in module tomcat-trunk) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-validate has an issue affecting its community integration. This issue affects 1 projects. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-trunk-validate : Tomcat 9.x, a web server implementing the Java Servlet 4.0, ... Full details are available at: http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-validate/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on checkstyle exists, no need to add for property checkstyle.jar. -INFO- Failed with reason build failed The following work was performed: http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-validate/gump_work/build_tomcat-trunk_tomcat-trunk-validate.html Work Name: build_tomcat-trunk_tomcat-trunk-validate (Type: Build) Work ended in a state of : Failed Elapsed: 32 secs Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Dbase.path=/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs -Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/checkstyle-8.2-SNAPSHOT.jar -Dexecute.validate=true validate [Working Directory: /srv/gump/public/workspace/tomcat-trunk] CLASSPATH: /usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-8.2-SNAPSHOT.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-20170726.jar:/srv/gump/packages/commons-collections3/commons-collections-3.2.1.jar:/srv/gump/public/workspace/commons-cli/target/commons-cli-1.5-SNAPSHOT.jar:/srv/gump/public/workspace/commons-lang-trunk/target/commons-lang3-3.7-SNAPSHOT.jar:/srv/g ump/public/workspace/apache-commons/logging/target/commons-logging-20170726.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-20170726.jar:/srv/gump/public/workspace/google-guava/guava/target/guava-23.0-SNAPSHOT.jar - Buildfile: /srv/gump/public/workspace/tomcat-trunk/build.xml build-prepare: [delete] Deleting directory /srv/gump/public/workspace/tomcat-trunk/output/build/temp [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/build/temp compile-prepare: download-validate: testexist: [echo] Testing for /srv/gump/public/workspace/checkstyle/target/checkstyle-8.2-SNAPSHOT.jar setproxy: downloadfile: validate: [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/res/checkstyle [checkstyle] Running Checkstyle 8.2-SNAPSHOT on 3152 files [checkstyle] Running Checkstyle 8.2-SNAPSHOT on 245 files [checkstyle] Running Checkstyle 8.2-SNAPSHOT on 1351 files [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-trunk/java/org/apache/tomcat/util/digester/Digester.java:40:1: Disallowed import - org.apache.catalina.Lifecycle. [ImportControl] [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-trunk/java/org/apache/tomcat/util/digester/Digester.java:41:1: Disallowed import - org.apache.catalina.LifecycleEvent. [ImportControl] [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-trunk/java/org/apache/tomcat/util/digester/Digester.java:42:1: Disallowed import - org.apache.catalina.LifecycleListener. [ImportControl] BUILD FAILED /srv/gump/public/workspace/tomcat-trunk/build.xml:592: Got 3 errors and 0 warnings. Total time: 31 seconds - To subscribe to this information via syndicated feeds: - RSS: http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-validate/rss.xml - Atom: http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-validate/atom.xml == Gump Tracking Only === Produced by Apache Gump(TM) version 2.3. Gump Run 20170726180006, vmgump-vm3.apache.org:vmgump:20170726180006 Gump E-mail Identifier (unique within run) #1. -- Apache Gump http://gump.apache.org/ [Instance: vmgump-vm3] - To unsubscribe,
Re: [VOTE] Release Apache Tomcat 8.5.19
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 7/24/17 7:22 PM, Mark Thomas wrote: > The proposed Apache Tomcat 8.5.19 release is now available for > voting. > > The major changes compared to the 8.5.16 release are: > > - Enable TLS connectors to use Java key stores that contain > multiple keys where each key has a separate password. Based on a > patch by Frank Taffelt. > > - Make asynchronous error handling more robust. In particular > ensure that onError() is called for any registered AsyncListeners > after an I/O error on a non-container thread. > > - Sync SSL session access for the APR connector to prevent errors > when accessing the session. > > > Along with lots of other bug fixes and improvements. > > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.19/ The > Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-114 6/ > > The svn tag is: > http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_19/ > > The proposed 8.5.19 release is: [ ] Broken - do not release [X] > Stable - go ahead and release as 8.5.19 All seems well in a test application in a development environment. No unexpected unit test failures. - -chris Details: * Environment * Java (build): java version "1.8.0_101" Java(TM) SE Runtime Environment (build 1.8.0_101-b13) Java HotSpot(TM) 64-Bit Server VM (build 25.101-b13, mixed mode) * Java (test): java version "1.8.0_101" Java(TM) SE Runtime Environment (build 1.8.0_101-b13) Java HotSpot(TM) 64-Bit Server VM (build 25.101-b13, mixed mode) * OS: Linux 2.6.32-312-ec2 x86_64 * cc: cc (Debian 4.7.2-5) 4.7.2 * make: GNU Make 3.81 * OpenSSL: 1.0.2k * APR: 1.4.6 * * Valid MD5 signature for apache-tomcat-8.5.19.zip * Valid GPG signature for apache-tomcat-8.5.19.zip * Valid MD5 signature for apache-tomcat-8.5.19.tar.gz * Valid GPG signature for apache-tomcat-8.5.19.tar.gz * Valid MD5 signature for apache-tomcat-8.5.19.exe * Valid GPG signature for apache-tomcat-8.5.19.exe * Valid MD5 signature for apache-tomcat-8.5.19-src.zip * Valid GPG signature for apache-tomcat-8.5.19-src.zip * Valid MD5 signature for apache-tomcat-8.5.19-src.tar.gz * Valid GPG signature for apache-tomcat-8.5.19-src.tar.gz * * Binary Zip and tarball: Same * Source Zip and tarball: Same * * Building dependencies returned: 0 * tcnative builds cleanly * Tomcat builds cleanly * Junit Tests: FAILED * * Tests that failed: * org.apache.catalina.session.TestStandardSessionIntegration.APR.txt * org.apache.catalina.session.TestStandardSessionIntegration.NIO.txt * org.apache.catalina.session.TestStandardSessionIntegration.NIO2.txt * org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.APR.txt * org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.NIO.txt * org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.NIO2.tx t * org.apache.catalina.tribes.group.TestGroupChannelSenderConnections.APR.t xt * org.apache.catalina.tribes.group.TestGroupChannelSenderConnections.NIO.t xt * org.apache.catalina.tribes.group.TestGroupChannelSenderConnections.NIO2. txt * org.apache.catalina.tribes.group.TestGroupChannelStartStop.APR.txt * org.apache.catalina.tribes.group.TestGroupChannelStartStop.NIO.txt * org.apache.catalina.tribes.group.TestGroupChannelStartStop.NIO2.txt * org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator .APR.txt * org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator .NIO.txt * org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator .NIO2.txt * org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.APR.t xt * org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.NIO.t xt * org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.NIO2. txt * org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.APR .txt * org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.NIO .txt * org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.NIO 2.txt * org.apache.tomcat.util.net.openssl.ciphers.TestCipher.APR.txt * org.apache.tomcat.util.net.openssl.ciphers.TestCipher.NIO.txt * org.apache.tomcat.util.net.openssl.ciphers.TestCipher.NIO2.txt * org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfiguratio nParser.APR.txt * org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfiguratio nParser.NIO.txt * org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfiguratio nParser.NIO2.txt -BEGIN PGP SIGNATURE- Comment: GPGTools - http://gpgtools.org Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBCAAGBQJZePQXAAoJEBzwKT+lPKRYl+AP/2/xBkq4fg/HKndAd3LswdSo nxiwc8nnV5zgxmK+2He8r9QkoNXs9NIGifX8Qp9NCw1d0goI51Jhj0RxrGDtupvY S3ZmceyI2HwEnvVnE9XHI/51AGjUC8GeSLb+5sh9L5ouO9L1o74h2fkHtjK4yTHf NV5KGw6PDlbabHkx3lZmDerf6hUJmMnTlNnT7JDonnxp9VT7J/Kos3KFfn7hL/MS ctMkWIcWK2HTsevmYdbhgPsbFgRsLuUVLmDtxwWgyBuJV
Re: [VOTE] [OT] Release Apache Tomcat 8.5.19
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 7/26/17 2:34 PM, Mark Thomas wrote: > On 25/07/2017 00:22, Mark Thomas wrote: >> The proposed Apache Tomcat 8.5.19 release is now available for >> voting. >> >> The major changes compared to the 8.5.16 release are: >> >> - Enable TLS connectors to use Java key stores that contain >> multiple keys where each key has a separate password. Based on a >> patch by Frank Taffelt. >> >> - Make asynchronous error handling more robust. In particular >> ensure that onError() is called for any registered AsyncListeners >> after an I/O error on a non-container thread. >> >> - Sync SSL session access for the APR connector to prevent errors >> when accessing the session. >> >> >> Along with lots of other bug fixes and improvements. >> >> >> It can be obtained from: >> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.19/ >> The Maven staging repo is: >> https://repository.apache.org/content/repositories/orgapachetomcat-11 46/ >> >> The svn tag is: >> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_19/ >> >> >> The proposed 8.5.19 release is: >> [ ] Broken - do not release [X] Stable - go ahead and release as >> 8.5.19 > > All unit tests passed with NIO, NIO2 and APR/native (1.2.12) on > Linux Windows and macOS. I've noticed that there are some tests which have no bearing on the type of connector, yet are run for each type of connector. For example (from my test report): * org.apache.tomcat.util.net.openssl.ciphers.TestCipher.APR.txt * org.apache.tomcat.util.net.openssl.ciphers.TestCipher.NIO.txt * org.apache.tomcat.util.net.openssl.ciphers.TestCipher.NIO2.txt * org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfiguratio nParser.APR.txt * org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfiguratio nParser.NIO.txt * org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfiguratio nParser.NIO2.txt Would it be worth it to annotate some of these tests as being "not connector-specific" and then running them only a single time? Depending upon the number of them, it could significantly reduce the time it takes to run all of the unit tests. - -chris -BEGIN PGP SIGNATURE- Comment: GPGTools - http://gpgtools.org Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBCAAGBQJZePSPAAoJEBzwKT+lPKRYPhUP/1/yrSuqpbqf5vjyVLfPICnl eV+Ir0i0z8lT5tij2mGb8MQOJPAPR4bfVoGx0NggIpb1qOIaoVr/H3oRzWKHlYl0 9cJrZCLzB2sKlkQI+D8JWfhgn5X/r4B+URRz9q/sCCrOErvQIAWdAHeNGCzKs/zv x6pZguvwZSjCCycguWMtj72pHCNh5vDVGNx9oIsa19JmwEeieTOuk14yeNiN4oEC krQnI4TCCXeJbbJKGYLfs2lJ88cX5Pm+99066DscfXE/jWXg4rKq7saXyohaa0iu xFwnMA0+rLSxcfmqTs71eVcYE01orNOsUP4irTU9jGSs2PmaZ7Hc664LQhYhNx6q SG6duoPwkDkgUfPhoZ7SznwCcop0AC6NpVEZ7JqVioLKm2D01g5Euc6kacTIBS5K BC5cGTHQr5YjH+gCMouF28QYTyQYDJHeWoBkcoTPdBbupkg7VSL3WA2cL833Vn2G Mfp49mu9haPGc0GsOrDsZH0ccezNobI+gJX3pajMILbK47lQIKRcctrFDA17h/IJ dlq6XTPx+N6/xpMPjyk20spMy8AH9Hk9EgWoBBd2s9wX8AKFdNbrjOlVwZhQy6mK /c/KX2JHhiK4Eddj+Jmq3lOJDJawA4ts/Wlps0OXIk7QPe8+qaWP3yO2bv8G3g4i CHVrPbPw6uvh0Z6p27WD =rvpD -END PGP SIGNATURE- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Tomcat release testing script
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, I've been using a script to test Tomcat releases for a while, and I thought I'd make it available to anyone who wants to give it a try. It's a bash script and has only been tested on Linux. It's got some quirks, but most people ought to be able to make it work. Here's an example for testing Tomcat 8.5.19: $ nohup bin/test-tomcat-release.sh > tomcat-8.5.19.log ^ [Wait a long time] $ grep '^\*' tomcat-8.5.19.log This will give you a summary of everything that happened during the build and test process. If you want to run it for Tomcat 8.5.18, you have to change the environment variable TOMCAT_VERSION from 8.5.19 to 8.5.18. I'm sure I'll be changing it so that you can specify that from the command-line or environment so you don't have to modify the script in order to test a different release. You can find the script on GitHub: https://github.com/ChristopherSchultz/apache-tomcat-stuff Pull requests welcome, but only small ones for now. So, if you've got a Linux environment and want to test a release, grab my script and see what happens. Once most Linux environments are working, I'd be happy to make it work on other UNIX-like environments as well. - -chris -BEGIN PGP SIGNATURE- Comment: GPGTools - http://gpgtools.org Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBCAAGBQJZePeVAAoJEBzwKT+lPKRY4uIP/igBIAY7FKV2ebcAS/uKgUFn 71tC9tVlNtpa5YjIS5TNMHtVa8LuqXfEZt+R77tdw9pjpEZKwcew9S0Gbt1LItkW oJCBMMHOH2uG/jzSCsfsY3CKELszTIGWqcX2SkQO9MNtPRcXssLgaNfrDKDANQj2 DA1pM/bBKzy1JhDgTwONNsuyPHBp0kvJAk/OoIX+eYJp+XGrHHL6pm3J24X3oZvm VWmxoghwMJDJvmBm+RxI82EmeQ7HST9OKJiVK9CtGeaI8YDBdFYkLntDQ29rJtsL L7LjBil7gPSO/wzTH8fFscaQ/LNdB7ov0aIftigDgroEdJHljTpPn9/oE+VA27K/ nTtUr0os5zJkbudLxftBgsNWgzPoHxN3JcxZqkUzQsNd8wbA/GcFXRZC0PWqfugv FqYtqpLxlc3P81LuNmebwA4PR2LJyStLHMiM5gYB4vSqmh/dCK+OjDaAtOb7Tj2s LMtqLNqz10RoHxYi13Nun6wAo7EOeBWDQhX81EqVRMHdocgISX0SDSLnfHAAcnYQ sF8PWgVHHsQh2m17j1zF+AX8EDYwXXaXZUTmlFJ9SL8e9oWomauJZL9/YhYStcbO 0wLtBoXdedVjrSSbWauBQX+cdvZUnUe9q53ZmM7vtAWaSMZnAuK6v4cDaqI4RDkZ dp1c3kXmp2qLY+OPiNfr =jHqo -END PGP SIGNATURE- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] [OT] Release Apache Tomcat 8.5.19
On Wed, Jul 26, 2017 at 3:59 PM, Christopher Schultz wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Mark, > > On 7/26/17 2:34 PM, Mark Thomas wrote: >> On 25/07/2017 00:22, Mark Thomas wrote: >>> The proposed Apache Tomcat 8.5.19 release is now available for >>> voting. >>> >>> The major changes compared to the 8.5.16 release are: >>> >>> - Enable TLS connectors to use Java key stores that contain >>> multiple keys where each key has a separate password. Based on a >>> patch by Frank Taffelt. >>> >>> - Make asynchronous error handling more robust. In particular >>> ensure that onError() is called for any registered AsyncListeners >>> after an I/O error on a non-container thread. >>> >>> - Sync SSL session access for the APR connector to prevent errors >>> when accessing the session. >>> >>> >>> Along with lots of other bug fixes and improvements. >>> >>> >>> It can be obtained from: >>> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.19/ >>> The Maven staging repo is: >>> https://repository.apache.org/content/repositories/orgapachetomcat-11 > 46/ >>> >>> > The svn tag is: >>> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_19/ >>> >>> >>> > The proposed 8.5.19 release is: >>> [ ] Broken - do not release [X] Stable - go ahead and release as >>> 8.5.19 >> >> All unit tests passed with NIO, NIO2 and APR/native (1.2.12) on >> Linux Windows and macOS. > > I've noticed that there are some tests which have no bearing on the > type of connector, yet are run for each type of connector. For example > (from my test report): > > * org.apache.tomcat.util.net.openssl.ciphers.TestCipher.APR.txt > * org.apache.tomcat.util.net.openssl.ciphers.TestCipher.NIO.txt > * org.apache.tomcat.util.net.openssl.ciphers.TestCipher.NIO2.txt > * > org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfiguratio > nParser.APR.txt > * > org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfiguratio > nParser.NIO.txt > * > org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfiguratio > nParser.NIO2.txt > > Would it be worth it to annotate some of these tests as being "not > connector-specific" and then running them only a single time? > Depending upon the number of them, it could significantly reduce the > time it takes to run all of the unit tests. +1. Any place we can speed up the test execution is good with me. > - -chris > -BEGIN PGP SIGNATURE- > Comment: GPGTools - http://gpgtools.org > Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ > > iQIcBAEBCAAGBQJZePSPAAoJEBzwKT+lPKRYPhUP/1/yrSuqpbqf5vjyVLfPICnl > eV+Ir0i0z8lT5tij2mGb8MQOJPAPR4bfVoGx0NggIpb1qOIaoVr/H3oRzWKHlYl0 > 9cJrZCLzB2sKlkQI+D8JWfhgn5X/r4B+URRz9q/sCCrOErvQIAWdAHeNGCzKs/zv > x6pZguvwZSjCCycguWMtj72pHCNh5vDVGNx9oIsa19JmwEeieTOuk14yeNiN4oEC > krQnI4TCCXeJbbJKGYLfs2lJ88cX5Pm+99066DscfXE/jWXg4rKq7saXyohaa0iu > xFwnMA0+rLSxcfmqTs71eVcYE01orNOsUP4irTU9jGSs2PmaZ7Hc664LQhYhNx6q > SG6duoPwkDkgUfPhoZ7SznwCcop0AC6NpVEZ7JqVioLKm2D01g5Euc6kacTIBS5K > BC5cGTHQr5YjH+gCMouF28QYTyQYDJHeWoBkcoTPdBbupkg7VSL3WA2cL833Vn2G > Mfp49mu9haPGc0GsOrDsZH0ccezNobI+gJX3pajMILbK47lQIKRcctrFDA17h/IJ > dlq6XTPx+N6/xpMPjyk20spMy8AH9Hk9EgWoBBd2s9wX8AKFdNbrjOlVwZhQy6mK > /c/KX2JHhiK4Eddj+Jmq3lOJDJawA4ts/Wlps0OXIk7QPe8+qaWP3yO2bv8G3g4i > CHVrPbPw6uvh0Z6p27WD > =rvpD > -END PGP SIGNATURE- > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.19
On Mon, Jul 24, 2017 at 7:22 PM, Mark Thomas wrote: > The proposed Apache Tomcat 8.5.19 release is now available for voting. > > The major changes compared to the 8.5.16 release are: > > - Enable TLS connectors to use Java key stores that contain multiple > keys where each key has a separate password. Based on a patch by Frank > Taffelt. > > - Make asynchronous error handling more robust. In particular ensure > that onError() is called for any registered AsyncListeners after an > I/O error on a non-container thread. > > - Sync SSL session access for the APR connector to prevent errors when > accessing the session. > > > Along with lots of other bug fixes and improvements. > > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.19/ > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1146/ > The svn tag is: > http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_19/ > > The proposed 8.5.19 release is: > [ ] Broken - do not release > [x] Stable - go ahead and release as 8.5.19 +1, looks OK to me. > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GUMP@vmgump-vm3]: Project tomcat-trunk-validate (in module tomcat-trunk) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-validate has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 2 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-trunk-validate : Tomcat 9.x, a web server implementing the Java Servlet 4.0, ... Full details are available at: http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-validate/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on checkstyle exists, no need to add for property checkstyle.jar. -INFO- Failed with reason build failed The following work was performed: http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-validate/gump_work/build_tomcat-trunk_tomcat-trunk-validate.html Work Name: build_tomcat-trunk_tomcat-trunk-validate (Type: Build) Work ended in a state of : Failed Elapsed: 37 secs Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Dbase.path=/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs -Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/checkstyle-8.2-SNAPSHOT.jar -Dexecute.validate=true validate [Working Directory: /srv/gump/public/workspace/tomcat-trunk] CLASSPATH: /usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-8.2-SNAPSHOT.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-20170727.jar:/srv/gump/packages/commons-collections3/commons-collections-3.2.1.jar:/srv/gump/public/workspace/commons-cli/target/commons-cli-1.5-SNAPSHOT.jar:/srv/gump/public/workspace/commons-lang-trunk/target/commons-lang3-3.7-SNAPSHOT.jar:/srv/g ump/public/workspace/apache-commons/logging/target/commons-logging-20170727.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-20170727.jar:/srv/gump/public/workspace/google-guava/guava/target/guava-23.0-SNAPSHOT.jar - Buildfile: /srv/gump/public/workspace/tomcat-trunk/build.xml build-prepare: [delete] Deleting directory /srv/gump/public/workspace/tomcat-trunk/output/build/temp [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/build/temp compile-prepare: download-validate: testexist: [echo] Testing for /srv/gump/public/workspace/checkstyle/target/checkstyle-8.2-SNAPSHOT.jar setproxy: downloadfile: validate: [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/res/checkstyle [checkstyle] Running Checkstyle 8.2-SNAPSHOT on 3152 files [checkstyle] Running Checkstyle 8.2-SNAPSHOT on 245 files [checkstyle] Running Checkstyle 8.2-SNAPSHOT on 1351 files [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-trunk/java/org/apache/tomcat/util/digester/Digester.java:40:1: Disallowed import - org.apache.catalina.Lifecycle. [ImportControl] [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-trunk/java/org/apache/tomcat/util/digester/Digester.java:41:1: Disallowed import - org.apache.catalina.LifecycleEvent. [ImportControl] [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-trunk/java/org/apache/tomcat/util/digester/Digester.java:42:1: Disallowed import - org.apache.catalina.LifecycleListener. [ImportControl] BUILD FAILED /srv/gump/public/workspace/tomcat-trunk/build.xml:592: Got 3 errors and 0 warnings. Total time: 37 seconds - To subscribe to this information via syndicated feeds: - RSS: http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-validate/rss.xml - Atom: http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-validate/atom.xml == Gump Tracking Only === Produced by Apache Gump(TM) version 2.3. Gump Run 2017072708, vmgump-vm3.apache.org:vmgump:2017072708 Gump E-mail Identifier (unique within run) #4. -- Apache Gump http://gump.apache.org/ [Instance: vmgump-vm3] - T
Re: [GUMP@vmgump-vm3]: Project tomcat-trunk-validate (in module tomcat-trunk) failed
On Thu, Jul 27, 2017 at 3:41 AM, Bill Barker wrote: > validate: > [mkdir] Created dir: /srv/gump/public/workspace/ > tomcat-trunk/output/res/checkstyle > [checkstyle] Running Checkstyle 8.2-SNAPSHOT on 3152 files > [checkstyle] Running Checkstyle 8.2-SNAPSHOT on 245 files > [checkstyle] Running Checkstyle 8.2-SNAPSHOT on 1351 files > [checkstyle] [ERROR] /srv/gump/public/workspace/ > tomcat-trunk/java/org/apache/tomcat/util/digester/Digester.java:40:1: > Disallowed import - org.apache.catalina.Lifecycle. [ImportControl] > [checkstyle] [ERROR] /srv/gump/public/workspace/ > tomcat-trunk/java/org/apache/tomcat/util/digester/Digester.java:41:1: > Disallowed import - org.apache.catalina.LifecycleEvent. [ImportControl] > [checkstyle] [ERROR] /srv/gump/public/workspace/ > tomcat-trunk/java/org/apache/tomcat/util/digester/Digester.java:42:1: > Disallowed import - org.apache.catalina.LifecycleListener. [ImportControl] > > Unfortunately my change creates a circular dependency. I don't really see a good way to do it without this, so I guess the best way is to revert. Rémy
