-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Mark,
On 7/26/17 2:34 PM, Mark Thomas wrote: > On 25/07/2017 00:22, Mark Thomas wrote: >> The proposed Apache Tomcat 8.5.19 release is now available for >> voting. >> >> The major changes compared to the 8.5.16 release are: >> >> - Enable TLS connectors to use Java key stores that contain >> multiple keys where each key has a separate password. Based on a >> patch by Frank Taffelt. >> >> - Make asynchronous error handling more robust. In particular >> ensure that onError() is called for any registered AsyncListeners >> after an I/O error on a non-container thread. >> >> - Sync SSL session access for the APR connector to prevent errors >> when accessing the session. >> >> >> Along with lots of other bug fixes and improvements. >> >> >> It can be obtained from: >> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.19/ >> The Maven staging repo is: >> https://repository.apache.org/content/repositories/orgapachetomcat-11 46/ >> >> The svn tag is: >> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_19/ >> >> >> The proposed 8.5.19 release is: >> [ ] Broken - do not release [X] Stable - go ahead and release as >> 8.5.19 > > All unit tests passed with NIO, NIO2 and APR/native (1.2.12) on > Linux Windows and macOS. I've noticed that there are some tests which have no bearing on the type of connector, yet are run for each type of connector. For example (from my test report): * org.apache.tomcat.util.net.openssl.ciphers.TestCipher.APR.txt * org.apache.tomcat.util.net.openssl.ciphers.TestCipher.NIO.txt * org.apache.tomcat.util.net.openssl.ciphers.TestCipher.NIO2.txt * org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfiguratio nParser.APR.txt * org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfiguratio nParser.NIO.txt * org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfiguratio nParser.NIO2.txt Would it be worth it to annotate some of these tests as being "not connector-specific" and then running them only a single time? Depending upon the number of them, it could significantly reduce the time it takes to run all of the unit tests. - -chris -----BEGIN PGP SIGNATURE----- Comment: GPGTools - http://gpgtools.org Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBCAAGBQJZePSPAAoJEBzwKT+lPKRYPhUP/1/yrSuqpbqf5vjyVLfPICnl eV+Ir0i0z8lT5tij2mGb8MQOJPAPR4bfVoGx0NggIpb1qOIaoVr/H3oRzWKHlYl0 9cJrZCLzB2sKlkQI+D8JWfhgn5X/r4B+URRz9q/sCCrOErvQIAWdAHeNGCzKs/zv x6pZguvwZSjCCycguWMtj72pHCNh5vDVGNx9oIsa19JmwEeieTOuk14yeNiN4oEC krQnI4TCCXeJbbJKGYLfs2lJ88cX5Pm+99066DscfXE/jWXg4rKq7saXyohaa0iu xFwnMA0+rLSxcfmqTs71eVcYE01orNOsUP4irTU9jGSs2PmaZ7Hc664LQhYhNx6q SG6duoPwkDkgUfPhoZ7SznwCcop0AC6NpVEZ7JqVioLKm2D01g5Euc6kacTIBS5K BC5cGTHQr5YjH+gCMouF28QYTyQYDJHeWoBkcoTPdBbupkg7VSL3WA2cL833Vn2G Mfp49mu9haPGc0GsOrDsZH0ccezNobI+gJX3pajMILbK47lQIKRcctrFDA17h/IJ dlq6XTPx+N6/xpMPjyk20spMy8AH9Hk9EgWoBBd2s9wX8AKFdNbrjOlVwZhQy6mK /c/KX2JHhiK4Eddj+Jmq3lOJDJawA4ts/Wlps0OXIk7QPe8+qaWP3yO2bv8G3g4i CHVrPbPw6uvh0Z6p27WD =rvpD -----END PGP SIGNATURE----- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
