date:20130424

[Bug 54036] currentThreadsBusy issue in centos 6

2013-04-24 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=54036

--- Comment #13 from Brandon Chong  ---
Hi, Francesco?
I have a similar problem as you reported above. I'm using CentOS 6.3 And Tomcat
6.0.35. If you figured out this problem already, could you let me know how to?
If you give me some advise I'll be very pleased!!! Please feel free to email me
at 'lovew...@naver.com'. Thank you in advance. :)

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 54882] New: HttpServletRequest.getRequestURI() returns also fragment

2013-04-24 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=54882

Bug ID: 54882
   Summary: HttpServletRequest.getRequestURI() returns also
fragment
   Product: Tomcat 7
   Version: 7.0.29
  Hardware: PC
Status: NEW
  Severity: normal
  Priority: P2
 Component: Servlet & JSP API
  Assignee: dev@tomcat.apache.org
  Reporter: adrian.rakov...@gratex.com
Classification: Unclassified

According to the Servlet specification and also documentation, this method
should return the part of this request's URL from the protocol name up to the
query string.

But if the URL is e.g. "http://localhost/test.html#fragment";, the returned
string contains also fragment "test.html#fragment", which is wrong, because
fragment is after the query (which is now empty).

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 54882] HttpServletRequest.getRequestURI() returns also fragment

2013-04-24 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=54882

Mark Thomas  changed:

   What|Removed |Added

 OS||All

--- Comment #1 from Mark Thomas  ---
User agents should not be sending URLs that include fragments. Any fragment
should be removed by the user agent prior to making the request and processed
solely on the client side.

Which user agent(s) is(are) sending fragments to the server?

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 54882] HttpServletRequest.getRequestURI() returns also fragment

2013-04-24 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=54882

--- Comment #2 from Adrian  ---
XmlHttpRequest made from IE (8/9/10) will send also fragment. It is definitely
bug of IE, but anyway, I think that getRequestURI should strip it as well.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 54882] HttpServletRequest.getRequestURI() returns also fragment

2013-04-24 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=54882

--- Comment #3 from Mark Thomas  ---
Generally, Tomcat doesn't provide work-arounds for bugs in third-party software
components unless all of the following conditions have been met:
a) The issue affects a large proportion of the Tomcat user base
b) The issue has a significant negative impact on users of affected
applications
c) An application level work-around is not viable
d) The issue has been reported to the vendor of the third-party software
e) The vendor of the third-party software has indicated that a fix will not be
available for an extended period of time (many months)

In this case my current view of the above is:
a) Not demonstrated. Tomcat hasn't handled fragments for as long as I can
remember. The only reference I can find in the archives was a query on the
users list as to why the server wasn't seeing the fragment.
b) Not demonstrated.
c) A Filter could fix this.
d) Not demonstrated.
e) Not demonstrated.

There have been cases where we have provided a work-around but they are few and
far between. At the moment this bug is heading towards being closed as INVALID
or maybe WONTFIX.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1471371 - in /tomcat/trunk: java/org/apache/catalina/core/AsyncContextImpl.java test/org/apache/catalina/core/TestAsyncContextImpl.java

2013-04-24 Thread markt

Author: markt
Date: Wed Apr 24 11:27:11 2013
New Revision: 1471371

URL: http://svn.apache.org/r1471371
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54178
Protect against AsyncListeners that throw RuntimeExceptions (they should 
normally only throw IOExceptions).
Includes a test case.

Modified:
tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java
tomcat/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java

Modified: tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java?rev=1471371&r1=1471370&r2=1471371&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java (original)
+++ tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java Wed Apr 24 
11:27:11 2013
@@ -116,9 +116,10 @@ public class AsyncContextImpl implements
 for (AsyncListenerWrapper listener : listenersCopy) {
 try {
 listener.fireOnComplete(event);
-} catch (IOException ioe) {
+} catch (Throwable t) {
+ExceptionUtils.handleThrowable(t);
 log.warn("onComplete() failed for listener of type [" +
-listener.getClass().getName() + "]", ioe);
+listener.getClass().getName() + "]", t);
 }
 }
 } finally {
@@ -202,9 +203,10 @@ public class AsyncContextImpl implements
 for (AsyncListenerWrapper listener : listenersCopy) {
 try {
 listener.fireOnTimeout(event);
-} catch (IOException ioe) {
+} catch (Throwable t) {
+ExceptionUtils.handleThrowable(t);
 log.warn("onTimeout() failed for listener of type [" +
-listener.getClass().getName() + "]", ioe);
+listener.getClass().getName() + "]", t);
 }
 }
 request.getCoyoteRequest().action(
@@ -381,9 +383,10 @@ public class AsyncContextImpl implements
 for (AsyncListenerWrapper listener : listenersCopy) {
 try {
 listener.fireOnStartAsync(event);
-} catch (IOException ioe) {
+} catch (Throwable t) {
+ExceptionUtils.handleThrowable(t);
 log.warn("onStartAsync() failed for listener of type [" +
-listener.getClass().getName() + "]", ioe);
+listener.getClass().getName() + "]", t);
 }
 }
 listeners.clear();
@@ -445,9 +448,10 @@ public class AsyncContextImpl implements
 for (AsyncListenerWrapper listener : listenersCopy) {
 try {
 listener.fireOnError(errorEvent);
-} catch (IOException ioe) {
+} catch (Throwable t2) {
+ExceptionUtils.handleThrowable(t);
 log.warn("onError() failed for listener of type [" +
-listener.getClass().getName() + "]", ioe);
+listener.getClass().getName() + "]", t2);
 }
 }
 }

Modified: tomcat/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java?rev=1471371&r1=1471370&r2=1471371&view=diff
==
--- tomcat/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java 
(original)
+++ tomcat/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java Wed 
Apr 24 11:27:11 2013
@@ -1188,7 +1188,7 @@ public class TestAsyncContextImpl extend
 
 private static final long serialVersionUID = 1L;
 
-private int status = 200;
+private int status;
 
 public AsyncStatusServlet(int status) {
 this.status = status;
@@ -1628,4 +1628,108 @@ public class TestAsyncContextImpl extend
 }
 }
 }
+
+@Test
+public void testBug54178() throws Exception {
+// Setup Tomcat instance
+Tomcat tomcat = getTomcatInstance();
+
+// Must have a real docBase - just use temp
+File docBase = new File(System.getProperty("java.io.tmpdir"));
+
+Context ctx = tomcat.addContext("", docBase.getAbsolutePath());
+
+Bug54178ServletA bug54178ServletA = new Bug54178ServletA();
+Wrapper wrapper =
+Tomcat.addServlet(ctx, "bug54178ServletA", bug54178ServletA);
+wrapper.setAsyncSupported(true);
+ctx.addServletMapping("/bug54178ServletA", "bug54178ServletA");
+
+Bug54178ServletB bug54178ServletB = new Bug5417

svn commit: r1471372 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/AsyncContextImpl.java test/org/apache/catalina/core/TestAsyncContextImpl.java webapps/docs/changelog.xml

2013-04-24 Thread markt

Author: markt
Date: Wed Apr 24 11:43:30 2013
New Revision: 1471372

URL: http://svn.apache.org/r1471372
Log:
Protect against AsyncListeners that throw RuntimeExceptions (they should 
normally only throw IOExceptions).
Includes a test case.

Modified:
tomcat/tc7.0.x/trunk/   (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/AsyncContextImpl.java
tomcat/tc7.0.x/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc7.0.x/trunk/
--
  Merged /tomcat/trunk:r1471371

Modified: 
tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/AsyncContextImpl.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/AsyncContextImpl.java?rev=1471372&r1=1471371&r2=1471372&view=diff
==
--- tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/AsyncContextImpl.java 
(original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/AsyncContextImpl.java 
Wed Apr 24 11:43:30 2013
@@ -117,9 +117,10 @@ public class AsyncContextImpl implements
 for (AsyncListenerWrapper listener : listenersCopy) {
 try {
 listener.fireOnComplete(event);
-} catch (IOException ioe) {
+} catch (Throwable t) {
+ExceptionUtils.handleThrowable(t);
 log.warn("onComplete() failed for listener of type [" +
-listener.getClass().getName() + "]", ioe);
+listener.getClass().getName() + "]", t);
 }
 }
 } finally {
@@ -148,9 +149,10 @@ public class AsyncContextImpl implements
 for (AsyncListenerWrapper listener : listenersCopy) {
 try {
 listener.fireOnTimeout(event);
-} catch (IOException ioe) {
+} catch (Throwable t) {
+ExceptionUtils.handleThrowable(t);
 log.warn("onTimeout() failed for listener of type [" +
-listener.getClass().getName() + "]", ioe);
+listener.getClass().getName() + "]", t);
 }
 }
 request.getCoyoteRequest().action(
@@ -328,9 +330,10 @@ public class AsyncContextImpl implements
 for (AsyncListenerWrapper listener : listenersCopy) {
 try {
 listener.fireOnStartAsync(event);
-} catch (IOException ioe) {
+} catch (Throwable t) {
+ExceptionUtils.handleThrowable(t);
 log.warn("onStartAsync() failed for listener of type [" +
-listener.getClass().getName() + "]", ioe);
+listener.getClass().getName() + "]", t);
 }
 }
 listeners.clear();
@@ -393,9 +396,10 @@ public class AsyncContextImpl implements
 for (AsyncListenerWrapper listener : listenersCopy) {
 try {
 listener.fireOnError(errorEvent);
-} catch (IOException ioe) {
+} catch (Throwable t2) {
+ExceptionUtils.handleThrowable(t);
 log.warn("onError() failed for listener of type [" +
-listener.getClass().getName() + "]", ioe);
+listener.getClass().getName() + "]", t2);
 }
 }
 }

Modified: 
tomcat/tc7.0.x/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java?rev=1471372&r1=1471371&r2=1471372&view=diff
==
--- 
tomcat/tc7.0.x/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java 
(original)
+++ 
tomcat/tc7.0.x/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java 
Wed Apr 24 11:43:30 2013
@@ -1189,7 +1189,7 @@ public class TestAsyncContextImpl extend
 
 private static final long serialVersionUID = 1L;
 
-private int status = 200;
+private int status;
 
 public AsyncStatusServlet(int status) {
 this.status = status;
@@ -1629,4 +1629,108 @@ public class TestAsyncContextImpl extend
 }
 }
 }
+
+@Test
+public void testBug54178() throws Exception {
+// Setup Tomcat instance
+Tomcat tomcat = getTomcatInstance();
+
+// Must have a real docBase - just use temp
+File docBase = new File(System.getProperty("java.io.tmpdir"));
+
+Context ctx = tomcat.addContext("", docBase.getAbsolutePath());
+
+Bug54178ServletA bug54178ServletA = new Bug54178ServletA();
+

[Bug 54178] runtime exception in onComplete of AsyncListener, will make org.apache.catalina.connector.Request not recycled (orginally reported MESSAGE POST to tomcat, but it called doGet)

2013-04-24 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=54178

Mark Thomas  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

--- Comment #13 from Mark Thomas  ---
(In reply to comment #10)
> hi Sir, it is reproducible now. after I debug with tomcat source code and my
> application. first, I will give my analysis; second I will give the opinion
> that it is a bug, hope I am right; third my question;

Thanks for the additional work to get to the bottom of this.

> first: analysis

The analysis skips over a few stages but is correct. A RuntimeException in a
AsyncListener leads to the problems observed because the Request object is not
recycled.

> second: reason;

Applications should not be throwing RuntimeExceptions in an AsyncListener but
equally it makes sense for Tomcat to protect against that happening in case
they do.

> third:
>  I want to know why AsyncContextImpl.fireOnComplete catches only IOException
> instead of Throwable; then maybe the above is fixed;

Only IOException were caught as they were the only ones that should have been
thrown. I agree the fix is to catch Throwable (well almost - there are some
Throwables that should never be caught but Tomcat has utility code to handle
that).

The fix has been applied to trunk and 7.0.x and will be included in 7.0.40
onwards.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

buildbot failure in ASF Buildbot on tomcat-7-trunk

2013-04-24 Thread buildbot

The Buildbot has detected a new failure on builder tomcat-7-trunk while 
building ASF Buildbot.
Full details are available at:
 http://ci.apache.org/builders/tomcat-7-trunk/builds/1180

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: bb-vm_ubuntu

Build Reason: scheduler
Build Source Stamp: [branch tomcat/tc7.0.x/trunk] 1471372
Blamelist: markt

BUILD FAILED: failed compile_1

sincerely,
 -The Buildbot

Re: [VOTE] Tighten up wiki security to reduce spam

2013-04-24 Thread Konstantin Kolinko

2013/4/19 Mark Thomas :
> Given the recent increase in Wiki Spam (it has increased generally
> across the ASF as well) I think it is time to apply the changes
> described in [1].
>
> On the plus side, it should eliminate spam.
>
> On the down side, legitimate users that want to make changes need to ask
> for access first.
>
> (...)
>
> Infra requires that the community agree to these changes before infra
> will apply them - hence this vote.
>
> Should the changes described in [1] be applied to the Tomcat wiki?
> [x] +1 Make it so
> [ ]  0 No opinion
> [ ] -1 I object to this proposed change because...
>
>
> [1]
> http://wiki.apache.org/general/OurWikiFarm#per_wiki_access_control_-_tighten_your_wiki_just_a_little.2C_benefit_just_a_lot
>

I am regretting it, but let's go on with this change.

> I have said it before but I think it is worth repeating. Adding entries
> to LocalBadContent and deleting the spam is ineffective. The spam has
> already entered our mail archive at that point and has been mirrored
> around the world which is exactly what the spammers want.

a) If it were the only concern, an alternative could be to direct
change notifications to some other mailing list. In a similar way like
documentation comments are not sent to the mailing list.

b) There are not so many barriers that stop one from abusing a mailing
list directly, with the same result. Fixing the wiki software (e.g. to
validate e-mail addresses of new accounts or to improve its spam
filters) is beyond our scope.

c) Generally knowing more about contributors should be good. Let's go
with the change.

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

WebAppClassLoader#addrepository and #addURL

2013-04-24 Thread Romain Manni-Bucau

Hi guys,

looked quickly tomcat-8 and seems the addrepository method is no more here
and addURL method is not respected (parent class)

1. is it intended?

i didnt find VirtualWebappClassloader too. This feature seems often used
and extended and this last part sounds for me like an issue when people
will migrate to t8 (from t7)

2. is it an "in progress" area or is it a known issue?

*Romain Manni-Bucau*
*Twitter: @rmannibucau *
*Blog: **http://rmannibucau.wordpress.com/*
*LinkedIn: **http://fr.linkedin.com/in/rmannibucau*
*Github: https://github.com/rmannibucau*

Re: WebAppClassLoader#addrepository and #addURL

2013-04-24 Thread Mark Thomas


On 24/04/2013 16:47, Romain Manni-Bucau wrote:

Hi guys,

looked quickly tomcat-8 and seems the addrepository method is no more here
and addURL method is not respected (parent class)

1. is it intended?


Yes.


i didnt find VirtualWebappClassloader too. This feature seems often used
and extended and this last part sounds for me like an issue when people
will migrate to t8 (from t7)

2. is it an "in progress" area


No.


or is it a known issue?


It is a non-issue.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 54888] New: TagPlugin "ForEach" doesn't support CSV items

2013-04-24 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=54888

Bug ID: 54888
   Summary: TagPlugin "ForEach" doesn't support CSV items
   Product: Tomcat 7
   Version: trunk
  Hardware: PC
OS: All
Status: NEW
  Severity: normal
  Priority: P2
 Component: Jasper
  Assignee: dev@tomcat.apache.org
  Reporter: xs...@ebay.com
Classification: Unclassified

Created attachment 30225
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=30225&action=edit
Patch for "ForEach"

In JSTL, "forEach" supports items with String value.
The string can be a CSV format. For example,



However, it doesn't support in tagPlugin "ForEach".

Provided a patch for this issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: WebAppClassLoader#addrepository and #addURL

2013-04-24 Thread Romain Manni-Bucau

how libs/extension (like tomee) should extend it? forking?

*Romain Manni-Bucau*
*Twitter: @rmannibucau *
*Blog: **http://rmannibucau.wordpress.com/*
*LinkedIn: **http://fr.linkedin.com/in/rmannibucau*
*Github: https://github.com/rmannibucau*



2013/4/24 Mark Thomas 

> On 24/04/2013 16:47, Romain Manni-Bucau wrote:
>
>> Hi guys,
>>
>> looked quickly tomcat-8 and seems the addrepository method is no more here
>> and addURL method is not respected (parent class)
>>
>> 1. is it intended?
>>
>
> Yes.
>
>
>  i didnt find VirtualWebappClassloader too. This feature seems often used
>> and extended and this last part sounds for me like an issue when people
>> will migrate to t8 (from t7)
>>
>> 2. is it an "in progress" area
>>
>
> No.
>
>
>  or is it a known issue?
>>
>
> It is a non-issue.
>
> Mark
>
>
> --**--**-
> To unsubscribe, e-mail: 
> dev-unsubscribe@tomcat.apache.**org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: WebAppClassLoader#addrepository and #addURL

2013-04-24 Thread Mark Thomas


On 24/04/2013 17:51, Romain Manni-Bucau wrote:

how libs/extension (like tomee) should extend it?


Use the replacement feature.


forking?


That should not be necessary.

Mark



*Romain Manni-Bucau*
*Twitter: @rmannibucau *
*Blog: **http://rmannibucau.wordpress.com/*
*LinkedIn: **http://fr.linkedin.com/in/rmannibucau*
*Github: https://github.com/rmannibucau*



2013/4/24 Mark Thomas 


On 24/04/2013 16:47, Romain Manni-Bucau wrote:


Hi guys,

looked quickly tomcat-8 and seems the addrepository method is no more here
and addURL method is not respected (parent class)

1. is it intended?



Yes.


  i didnt find VirtualWebappClassloader too. This feature seems often used

and extended and this last part sounds for me like an issue when people
will migrate to t8 (from t7)

2. is it an "in progress" area



No.


  or is it a known issue?




It is a non-issue.

Mark


--**--**-
To unsubscribe, e-mail: 
dev-unsubscribe@tomcat.apache.**org
For additional commands, e-mail: dev-h...@tomcat.apache.org







-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: WebAppClassLoader#addrepository and #addURL

2013-04-24 Thread Konstantin Kolinko

2013/4/24 Mark Thomas :
> On 24/04/2013 17:51, Romain Manni-Bucau wrote:
>>
>> how libs/extension (like tomee) should extend it?
>
>
> Use the replacement feature.
>

resources

In nightly Tomcat 8 docs those are described here:
http://ci.apache.org/projects/tomcat/tomcat8/docs/config/resources.html


> (...)

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1471614 - in /tomcat/tc7.0.x/trunk: java/org/apache/coyote/http11/upgrade/LocalStrings.properties java/org/apache/coyote/http11/upgrade/UpgradeAprProcessor.java webapps/docs/changelog.xml

2013-04-24 Thread markt

Author: markt
Date: Wed Apr 24 19:52:25 2013
New Revision: 1471614

URL: http://svn.apache.org/r1471614
Log: (empty)

Modified:

tomcat/tc7.0.x/trunk/java/org/apache/coyote/http11/upgrade/LocalStrings.properties

tomcat/tc7.0.x/trunk/java/org/apache/coyote/http11/upgrade/UpgradeAprProcessor.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Modified: 
tomcat/tc7.0.x/trunk/java/org/apache/coyote/http11/upgrade/LocalStrings.properties
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/coyote/http11/upgrade/LocalStrings.properties?rev=1471614&r1=1471613&r2=1471614&view=diff
==
--- 
tomcat/tc7.0.x/trunk/java/org/apache/coyote/http11/upgrade/LocalStrings.properties
 (original)
+++ 
tomcat/tc7.0.x/trunk/java/org/apache/coyote/http11/upgrade/LocalStrings.properties
 Wed Apr 24 19:52:25 2013
@@ -13,7 +13,8 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-apr.error=Unexpected error [{0}] reading data from the APR/native socket.
+apr.read.error=Error [{0}] reading data from the APR/native socket.
+apr.write.error=Error [{0}] writing data to the APR/native socket.
 
 nio.eof.error=Unexpected EOF read on the socket
 

Modified: 
tomcat/tc7.0.x/trunk/java/org/apache/coyote/http11/upgrade/UpgradeAprProcessor.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/coyote/http11/upgrade/UpgradeAprProcessor.java?rev=1471614&r1=1471613&r2=1471614&view=diff
==
--- 
tomcat/tc7.0.x/trunk/java/org/apache/coyote/http11/upgrade/UpgradeAprProcessor.java
 (original)
+++ 
tomcat/tc7.0.x/trunk/java/org/apache/coyote/http11/upgrade/UpgradeAprProcessor.java
 Wed Apr 24 19:52:25 2013
@@ -49,13 +49,21 @@ public class UpgradeAprProcessor extends
 
 @Override
 public void write(int b) throws IOException {
-Socket.send(socket, new byte[] {(byte) b}, 0, 1);
+int result = Socket.send(socket, new byte[] {(byte) b}, 0, 1);
+if (result != 1) {
+throw new IOException(sm.getString("apr.write.error",
+Integer.valueOf(-result)));
+}
 }
 
 
 @Override
 public void write(byte[]b, int off, int len) throws IOException {
-Socket.send(socket, b, off, len);
+int result = Socket.send(socket, b, off, len);
+if (result != len) {
+throw new IOException(sm.getString("apr.write.error",
+Integer.valueOf(-result)));
+}
 }
 
 
@@ -87,7 +95,7 @@ public class UpgradeAprProcessor extends
 } else if (-result == Status.EAGAIN) {
 return 0;
 } else {
-throw new IOException(sm.getString("apr.error",
+throw new IOException(sm.getString("apr.read.error",
 Integer.valueOf(-result)));
 }
 } finally {

Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1471614&r1=1471613&r2=1471614&view=diff
==
--- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Wed Apr 24 19:52:25 2013
@@ -74,6 +74,15 @@
   
 
   
+  
+
+  
+Ensure write errors when using HTTP Upgrade with the APR/native
+connector result in IOExceptions rather than errors being
+silently swallowed. (markt)
+  
+
+  
   
 
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1471619 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/websocket/StreamInbound.java java/org/apache/catalina/websocket/WsOutbound.java webapps/docs/changelog.xml

2013-04-24 Thread markt

Author: markt
Date: Wed Apr 24 19:55:57 2013
New Revision: 1471619

URL: http://svn.apache.org/r1471619
Log:
Outbound errors need to trigger an onClose event on the inbound side

Modified:
tomcat/tc7.0.x/trunk/java/org/apache/catalina/websocket/StreamInbound.java
tomcat/tc7.0.x/trunk/java/org/apache/catalina/websocket/WsOutbound.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Modified: 
tomcat/tc7.0.x/trunk/java/org/apache/catalina/websocket/StreamInbound.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/websocket/StreamInbound.java?rev=1471619&r1=1471618&r2=1471619&view=diff
==
--- tomcat/tc7.0.x/trunk/java/org/apache/catalina/websocket/StreamInbound.java 
(original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/catalina/websocket/StreamInbound.java 
Wed Apr 24 19:55:57 2013
@@ -88,7 +88,7 @@ public abstract class StreamInbound impl
 
 @Override
 public final void setUpgradeOutbound(UpgradeOutbound upgradeOutbound) {
-outbound = new WsOutbound(upgradeOutbound, outboundByteBufferSize,
+outbound = new WsOutbound(upgradeOutbound, this, 
outboundByteBufferSize,
 outboundCharBufferSize);
 }
 
@@ -207,7 +207,13 @@ public abstract class StreamInbound impl
 }
 }
 
-private void doOnClose(int status) {
+/**
+ * Package private so the outbound connection can signal that the 
connection
+ * has been closed - usually due to an error.
+ *  
+ * @param statusThe WebSocket status code to report to the application
+ */
+void doOnClose(int status) {
 // Need to call onClose using the web application's class loader
 Thread t = Thread.currentThread();
 ClassLoader cl = t.getContextClassLoader();

Modified: 
tomcat/tc7.0.x/trunk/java/org/apache/catalina/websocket/WsOutbound.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/websocket/WsOutbound.java?rev=1471619&r1=1471618&r2=1471619&view=diff
==
--- tomcat/tc7.0.x/trunk/java/org/apache/catalina/websocket/WsOutbound.java 
(original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/catalina/websocket/WsOutbound.java Wed 
Apr 24 19:55:57 2013
@@ -39,6 +39,7 @@ public class WsOutbound {
 public static final int DEFAULT_BUFFER_SIZE = 8192;
 
 private UpgradeOutbound upgradeOutbound;
+private StreamInbound streamInbound;
 private ByteBuffer bb;
 private CharBuffer cb;
 private boolean closed = false;
@@ -46,14 +47,17 @@ public class WsOutbound {
 private boolean firstFrame = true;
 
 
-public WsOutbound(UpgradeOutbound upgradeOutbound) {
-this(upgradeOutbound, DEFAULT_BUFFER_SIZE, DEFAULT_BUFFER_SIZE);
+public WsOutbound(UpgradeOutbound upgradeOutbound,
+StreamInbound streamInbound) {
+this(upgradeOutbound, streamInbound, DEFAULT_BUFFER_SIZE,
+DEFAULT_BUFFER_SIZE);
 }
 
 
-public WsOutbound(UpgradeOutbound upgradeOutbound, int byteBufferSize,
-int charBufferSize) {
+public WsOutbound(UpgradeOutbound upgradeOutbound, StreamInbound 
streamInbound,
+int byteBufferSize, int charBufferSize) {
 this.upgradeOutbound = upgradeOutbound;
+this.streamInbound = streamInbound;
 this.bb = ByteBuffer.allocate(byteBufferSize);
 this.cb = CharBuffer.allocate(charBufferSize);
 }
@@ -365,54 +369,60 @@ public class WsOutbound {
 throw new IOException(sm.getString("outbound.closed"));
 }
 
-// Work out the first byte
-int first = 0x00;
-if (finalFragment) {
-first = first + 0x80;
-}
-if (firstFrame) {
-if (text.booleanValue()) {
-first = first + 0x1;
+try {
+// Work out the first byte
+int first = 0x00;
+if (finalFragment) {
+first = first + 0x80;
+}
+if (firstFrame) {
+if (text.booleanValue()) {
+first = first + 0x1;
+} else {
+first = first + 0x2;
+}
+}
+// Continuation frame is OpCode 0
+upgradeOutbound.write(first);
+
+if (buffer.limit() < 126) {
+upgradeOutbound.write(buffer.limit());
+} else if (buffer.limit() < 65536) {
+upgradeOutbound.write(126);
+upgradeOutbound.write(buffer.limit() >>> 8);
+upgradeOutbound.write(buffer.limit() & 0xFF);
 } else {
-first = first + 0x2;
+// Will never be more than 2^31-1
+upgradeOutbound.write(127);
+upgradeOutbound.write(0);
+upgradeOutbound.write(0);
+upgradeOutbound.write(

[Bug 54756] EXCEPTION_ACCESS_VIOLATION with APR crashing Tomcat

2013-04-24 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=54756

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #7 from Mark Thomas  ---
I've taken a look at this and have found an issue in that errors on the
outbound side were silently swallowed when APR/native was being used. I suspect
the crash observed here is the result of continuing using a socket that has
already closed due to an error.

I have fixed this particular issue and the fix will be in 7.0.40 onwards.
Please test once 7.0.40 is released and let us know if the issue is resolved.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1471614 - in /tomcat/tc7.0.x/trunk: java/org/apache/coyote/http11/upgrade/LocalStrings.properties java/org/apache/coyote/http11/upgrade/UpgradeAprProcessor.java webapps/docs/changelog

2013-04-24 Thread Konstantin Kolinko

2013/4/24  :
> Author: markt
> Date: Wed Apr 24 19:52:25 2013
> New Revision: 1471614
>
> URL: http://svn.apache.org/r1471614
> Log: (empty)
>

Log message 

> Modified:
> 
> tomcat/tc7.0.x/trunk/java/org/apache/coyote/http11/upgrade/LocalStrings.properties
> 
> tomcat/tc7.0.x/trunk/java/org/apache/coyote/http11/upgrade/UpgradeAprProcessor.java
> tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
>
> (...)
> +  
> +
> +  
> +Ensure write errors when using HTTP Upgrade with the APR/native
> +connector result in IOExceptions rather than errors 
> being
> +silently swallowed. (markt)
> +  
> +
> +  

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 54791] No TLD files were found in tools.jar when tools.jar is explicitly added to $CLASSPATH

2013-04-24 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=54791

--- Comment #2 from Mark Thomas  ---
I'm very tempted to say that if Eclipse wants to add tools.jar to the classpath
then Eclipse should be adding tools.jar to jarsToSkip as well and resolve this
as INVALID.

That said, Eclipse is widely enough used that adding tools.jar back to the
default jarsToSkip is probably the better option.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1471632 - /tomcat/trunk/conf/catalina.properties

2013-04-24 Thread markt

Author: markt
Date: Wed Apr 24 20:14:20 2013
New Revision: 1471632

URL: http://svn.apache.org/r1471632
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54791
Restore tools.jar entry in jarsToSkip

Modified:
tomcat/trunk/conf/catalina.properties

Modified: tomcat/trunk/conf/catalina.properties
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/conf/catalina.properties?rev=1471632&r1=1471631&r2=1471632&view=diff
==
--- tomcat/trunk/conf/catalina.properties (original)
+++ tomcat/trunk/conf/catalina.properties Wed Apr 24 20:14:20 2013
@@ -97,6 +97,7 @@ tomcat-jni.jar,tomcat-spdy.jar,\
 tomcat-i18n-en.jar,tomcat-i18n-es.jar,tomcat-i18n-fr.jar,tomcat-i18n-ja.jar,\
 tomcat-juli-adapters.jar,catalina-jmx-remote.jar,catalina-ws.jar,\
 tomcat-jdbc.jar,websocket-api.jar,\
+tools.jar,\
 commons-beanutils*.jar,commons-codec*.jar,commons-collections*.jar,\
 commons-dbcp*.jar,commons-digester*.jar,commons-fileupload*.jar,\
 
commons-httpclient*.jar,commons-io*.jar,commons-lang*.jar,commons-logging*.jar,\



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1471633 - in /tomcat/tc7.0.x/trunk: ./ conf/catalina.properties webapps/docs/changelog.xml

2013-04-24 Thread markt

Author: markt
Date: Wed Apr 24 20:16:38 2013
New Revision: 1471633

URL: http://svn.apache.org/r1471633
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54791
Restore tools.jar entry in jarsToSkip

Modified:
tomcat/tc7.0.x/trunk/   (props changed)
tomcat/tc7.0.x/trunk/conf/catalina.properties
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc7.0.x/trunk/
--
  Merged /tomcat/trunk:r1471632

Modified: tomcat/tc7.0.x/trunk/conf/catalina.properties
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/conf/catalina.properties?rev=1471633&r1=1471632&r2=1471633&view=diff
==
--- tomcat/tc7.0.x/trunk/conf/catalina.properties (original)
+++ tomcat/tc7.0.x/trunk/conf/catalina.properties Wed Apr 24 20:16:38 2013
@@ -97,6 +97,7 @@ tomcat-jni.jar,tomcat-spdy.jar,\
 tomcat-i18n-en.jar,tomcat-i18n-es.jar,tomcat-i18n-fr.jar,tomcat-i18n-ja.jar,\
 tomcat-juli-adapters.jar,catalina-jmx-remote.jar,catalina-ws.jar,\
 tomcat-jdbc.jar,\
+tools.jar,\
 commons-beanutils*.jar,commons-codec*.jar,commons-collections*.jar,\
 commons-dbcp*.jar,commons-digester*.jar,commons-fileupload*.jar,\
 
commons-httpclient*.jar,commons-io*.jar,commons-lang*.jar,commons-logging*.jar,\

Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1471633&r1=1471632&r2=1471633&view=diff
==
--- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Wed Apr 24 20:16:38 2013
@@ -68,6 +68,11 @@
 an event. (markt) 
   
   
+54791: Restore tools.jar entry in
+jarsToSkip property to prevent warnings when running 
Tomcat
+from Eclipse. (markt)
+  
+  
 54851: When scanning for web fragments, directories without
 any web-fragment.xml should not impact the status of distributable
 element. Patch provided by Trask Stalnaker. (violetagg)



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 54791] No TLD files were found in tools.jar when tools.jar is explicitly added to $CLASSPATH

2013-04-24 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=54791

--- Comment #3 from Konstantin Kolinko  ---
(In reply to comment #1)
> Why is tools.jar on the classpath in the first place?

I guess they are following some old docs.
(Or is there anyone who actually uses JDK compiler with Jasper?)

In our Tomcat 8 documentation "tools.jar" is mentioned on two pages, 
jasper-howto.html
windows-service-howto.html

(The later one should probably be corrected).

> That said, Eclipse is widely enough used that adding tools.jar back to the
> default jarsToSkip is probably the better option.

Agreed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 54791] No TLD files were found in tools.jar when tools.jar is explicitly added to $CLASSPATH

2013-04-24 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=54791

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #4 from Mark Thomas  ---
Fixed in trunk and 7.0.x and will be included in 7.0.40 onwards.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn propchange: r1471614 - svn:log

2013-04-24 Thread markt

Author: markt
Revision: 1471614
Modified property: svn:log

Modified: svn:log at Wed Apr 24 20:19:51 2013
--
--- svn:log (original)
+++ svn:log Wed Apr 24 20:19:51 2013
@@ -0,0 +1 @@
+Ensure write errors when using HTTP Upgrade with the APR/native connector 
result in IOExceptions rather than errors being silently swallowed.


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1471614 - in /tomcat/tc7.0.x/trunk: java/org/apache/coyote/http11/upgrade/LocalStrings.properties java/org/apache/coyote/http11/upgrade/UpgradeAprProcessor.java webapps/docs/changelog

2013-04-24 Thread Mark Thomas

On 24/04/2013 21:00, Konstantin Kolinko wrote:
> 2013/4/24  :
>> Author: markt
>> Date: Wed Apr 24 19:52:25 2013
>> New Revision: 1471614
>>
>> URL: http://svn.apache.org/r1471614
>> Log: (empty)
>>
> 
> Log message 

Whoops. Finger trouble in the IDE. Fixed. Thanks.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[RESULT][VOTE] Tighten up wiki security to reduce spam

2013-04-24 Thread Mark Thomas

+1 (binding): markt, funkman, rjung, olamy, kkolinko (with regret)
+1:   Ognjen Blagojevic, violetagg, Chuck

I'll ask infra to make the necessary changes.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [RESULT][VOTE] Tighten up wiki security to reduce spam

2013-04-24 Thread Mark Thomas

On 24/04/2013 21:23, Mark Thomas wrote:
> +1 (binding): markt, funkman, rjung, olamy, kkolinko (with regret)
> +1:   Ognjen Blagojevic, violetagg, Chuck
> 
> I'll ask infra to make the necessary changes.

Done:

https://issues.apache.org/jira/browse/INFRA-6196

Based on the most recent anti-spam efforts I requested the Konstantin,
Chuck and I be added to the admin group. We can add other community
members on request (same for contributors). The first task will be to
add the current committers and any other regular contributors to the
contributors group.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [RESULT][VOTE] Tighten up wiki security to reduce spam

2013-04-24 Thread Konstantin Kolinko

2013/4/25 Mark Thomas :
> On 24/04/2013 21:23, Mark Thomas wrote:
>> +1 (binding): markt, funkman, rjung, olamy, kkolinko (with regret)
>> +1:   Ognjen Blagojevic, violetagg, Chuck
>>
>> I'll ask infra to make the necessary changes.
>
> Done:
>
> https://issues.apache.org/jira/browse/INFRA-6196
>
> Based on the most recent anti-spam efforts I requested the Konstantin,
> Chuck and I be added to the admin group. We can add other community
> members on request (same for contributors). The first task will be to
> add the current committers and any other regular contributors to the
> contributors group.
>


The file is already there,
https://wiki.apache.org/tomcat/AdminGroup

The list includes Chris, Chuck, Ian, Mark, Sebb and me.

I made the file is not readable for general public (per some
recommendation elsewhere) but changes to it are sent to the mailing
list.

ContributorsGroup has not been created yet.

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 54756] EXCEPTION_ACCESS_VIOLATION with APR crashing Tomcat

2013-04-24 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=54756

--- Comment #8 from Michael  ---
Thanks Mark, will do.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Tomcat Wiki] Trivial Update of "DwainFne" by DwainFne

2013-04-24 Thread Apache Wiki

Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change 
notification.

The "DwainFne" page has been changed by DwainFne:
http://wiki.apache.org/tomcat/DwainFne

New page:
Name: Dwain Christenson<>
My age: 34<>
Country: Netherlands<>
City: Delft <>
ZIP: 2613 GD<>
Address: Paxlaan 142<>
<>
[[http://www.naturtheke.eu/|potenzmittel für die frau]]

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Tomcat Wiki] Update of "LocalBadContent" by ChuckCaldarale

2013-04-24 Thread Apache Wiki

Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change 
notification.

The "LocalBadContent" page has been changed by ChuckCaldarale:
http://wiki.apache.org/tomcat/LocalBadContent?action=diff&rev1=146&rev2=147

  mystreyguy
  myteethadvisor\.com
  najem-avtodoma\.info
+ naturtheke\.eu
  nekoo\.cn
  newmichaelkorsclubs\.com
  nihonlinks\.com

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Tomcat Wiki] Update of "ContributorsGroup" by SebastianBazley

2013-04-24 Thread Apache Wiki

Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change 
notification.

The "ContributorsGroup" page has been changed by SebastianBazley:
http://wiki.apache.org/tomcat/ContributorsGroup

New page:
#acl AdminGroup:read,write,admin,revert,delete All:read
'''Contributors''' with permission to edit the Commons wiki – read, write, 
delete and revert pages or individual changes. 
To be added to this group, please send a brief request to the 
[[http://commons.apache.org/mail-lists.html| Commons dev@ list]] including your 
Wiki username.

*AdminGroup

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Tomcat Wiki] Update of "ContributorsGroup" by SebastianBazley

2013-04-24 Thread Apache Wiki

Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change 
notification.

The "ContributorsGroup" page has been changed by SebastianBazley:
http://wiki.apache.org/tomcat/ContributorsGroup?action=diff&rev1=1&rev2=2

  '''Contributors''' with permission to edit the Commons wiki – read, write, 
delete and revert pages or individual changes. 
  To be added to this group, please send a brief request to the 
[[http://commons.apache.org/mail-lists.html| Commons dev@ list]] including your 
Wiki username.
  
- *AdminGroup
+  * AdminGroup
+  * Krzysztof Gil
+  * NevenCvetkovic
+  * AndreaBrugiolo
+  * ShawnYu
+  * GlenIhrig
  

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Tomcat Wiki] Update of "ContributorsGroup" by SebastianBazley

2013-04-24 Thread Apache Wiki

Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change 
notification.

The "ContributorsGroup" page has been changed by SebastianBazley:
http://wiki.apache.org/tomcat/ContributorsGroup?action=diff&rev1=2&rev2=3

  To be added to this group, please send a brief request to the 
[[http://commons.apache.org/mail-lists.html| Commons dev@ list]] including your 
Wiki username.
  
   * AdminGroup
-  * Krzysztof Gil
+  * [Krzysztof Gil]
   * NevenCvetkovic
   * AndreaBrugiolo
   * ShawnYu

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Tomcat Wiki] Update of "AdminGroup" by SebastianBazley

2013-04-24 Thread Apache Wiki

Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change 
notification.

The "AdminGroup" page has been changed by SebastianBazley:
http://wiki.apache.org/tomcat/AdminGroup?action=diff&rev1=5&rev2=6

  #acl AdminGroup:read,write,admin,revert,delete -All:read
  
- This is a list of people who can do editing of the LocalBadContent page:
+ This is a list of people who can do editing of the LocalBadContent and 
ContributorsGroup pages:
   * ChristopherSchultz
   * ChuckCaldarale
   * IanDarwin

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 54756] EXCEPTION_ACCESS_VIOLATION with APR crashing Tomcat

2013-04-24 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=54756

--- Comment #9 from Sebb  ---
(In reply to comment #7)
> I've taken a look at this and have found an issue in that errors on the
> outbound side were silently swallowed when APR/native was being used. I
> suspect the crash observed here is the result of continuing using a socket
> that has already closed due to an error.
> 
> I have fixed this particular issue and the fix will be in 7.0.40 onwards.

What if the user code ignores the new error?
Is it still possible for user code to continue using the socket?

I had a look at the patch but it only seemed to report the error, but maybe I'm
missing something and it's not possible to get at the closed socket using Java
code external to Tomcat.

It's good to report the error, but I would have thought the safest option would
be to fix APR/native so it cannot be crashed externally - whether from Tomcat
code or application code.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Tomcat Wiki] Trivial Update of "CarlaMene" by CarlaMene

2013-04-24 Thread Apache Wiki

Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change 
notification.

The "CarlaMene" page has been changed by CarlaMene:
http://wiki.apache.org/tomcat/CarlaMene

New page:
Elektryka całkiem [[http://skrzynki.citymag.pl|maty grzewcze]] zdominowała 
dzisiejszy Błękitna planeta a codzienne istnienie każdego spośród nas.<>
Bardzo cyklicznie słyszy się powiedzenie, iż dzień dzisiejszy aktualnie komplet 
jest na prąd. I z trudem temu przeczyć, elektryka króluje ponieważ w coraz to 
większej liczbie dziedzin tudzież gałęzi współczesności. Przykładów jest 
dozwolone iżby rozsiewać stosownie bez końca, należałoby lecz wtrącić o w 
wyższym stopniu nowoczesnym i aktualnym, natomiast to jest o elektrycznym 
ogrzewaniu.<>
Jak się bo okazuje, nagrzewanie elektryczne jest rozwiązaniem stosowanym dziś 
raz za razem częściej zaś owo nie wręcz przeciwnie w nowym budownictwie. 
Oczywiście elektryczne ogrzewanie prawdopodobnie pochwalać etap rozmaitych 
form, jeżeli w ogóle ceni się choć elektryczne nagrzewanie podłogowe, które 
wypada aż do form najbardziej luksusowych tudzież nowoczesnych, w sferze 
współczesnych metod grzewczych.<>
Oczywiście elektryczne nagrzewanie podłogowe jest względnie skomplikowane w 
swoim montażu, należy wykorzystać choćby specjalne maty grzewcze. Również a 
przewod grzejny musi byś przyporządkowany aż do konkretnego przypadku. 
Elektryka jest obecna w tak wielu dziedzinach współczesnego życia.<>
Amatorzy nierzadko wykorzystują elektrykę dla dekorowania swoich domów tudzież 
otoczenia, podświetlając schody, skrzynki na listy, chodniki, baseny jednakowoż 
wykorzystując przewody oświetleniowe a elektryczne aż do tworzenia 
skomplikowanych wzorów.<>
<>
Elektryka, gdy wprost widać, nabrała we współczesnym świecie szczególnego 
znaczenia. Bo prócz swoich podstawowych funkcji częstokroć wykorzystywana jest 
po prostu jako rodzaj dodatkowego urozmaicenia zaś dekoracji.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Tomcat Wiki] Update of "LocalBadContent" by ChuckCaldarale

2013-04-24 Thread Apache Wiki

Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change 
notification.

The "LocalBadContent" page has been changed by ChuckCaldarale:
http://wiki.apache.org/tomcat/LocalBadContent?action=diff&rev1=147&rev2=148

  signalsforex
  siliconebody\.com
  skincare
+ skrzynki\.citymag\.pl
  slowmotionpotion\.com
  smbay\.cn
  smokedating\.com

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: WebAppClassLoader#addrepository and #addURL

2013-04-24 Thread Romain Manni-Bucau

Thanks, playing with org.apache.catalina.WebResourceRoot can work.

That said not respecting addURL maybe means you should override it to throw
an UnsupportedOperataion no? + the comment
of org.apache.catalina.loader.WebappClassLoader#getURLs is weird since it
references addURL


*Romain Manni-Bucau*
*Twitter: @rmannibucau *
*Blog: **http://rmannibucau.wordpress.com/*
*LinkedIn: **http://fr.linkedin.com/in/rmannibucau*
*Github: https://github.com/rmannibucau*



2013/4/24 Konstantin Kolinko 

> 2013/4/24 Mark Thomas :
> > On 24/04/2013 17:51, Romain Manni-Bucau wrote:
> >>
> >> how libs/extension (like tomee) should extend it?
> >
> >
> > Use the replacement feature.
> >
>
> resources
>
> In nightly Tomcat 8 docs those are described here:
> http://ci.apache.org/projects/tomcat/tomcat8/docs/config/resources.html
>
>
> > (...)
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

41 matches

Mail list logo