Re: svn commit: r1446712 - /tomcat/native/branches/1.1.x/xdocs/news/2013.xml
On 16.02.2013 07:28, Mladen Turk wrote: > On 02/15/2013 07:07 PM, rj...@apache.org wrote: >> Author: rjung >> >> >> Apache >> Tomcat Native Project >> -2012 News and Status >> +2013 News and Status >> >> > > Thanks :) > > BTW, like said on BZ issue, you can just publish that page since its > a trivial change and its on our web site so does not fall strictly into > release tasks. It was modified after the release so that dates are correct > anyhow. No need to wait for next release. I think Konstantin just did it in r1446770. Regards, Rainer - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1446901 - /tomcat/trunk/webapps/docs/changelog.xml
Author: markt Date: Sat Feb 16 14:56:51 2013 New Revision: 1446901 URL: http://svn.apache.org/r1446901 Log: Whitespace police Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1446901&r1=1446900&r2=1446901&view=diff == --- tomcat/trunk/webapps/docs/changelog.xml (original) +++ tomcat/trunk/webapps/docs/changelog.xml Sat Feb 16 14:56:51 2013 @@ -115,7 +115,7 @@ 54552: Servlet 3.1. Implement HttpSessionIdListener and HttpServletRequest#changeSessionId(). Patch provided by -Nick Williams. (markt) +Nick Williams. (markt) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1446909 - /tomcat/trunk/java/org/apache/catalina/valves/rewrite/RewriteCond.java
Author: markt
Date: Sat Feb 16 16:09:39 2013
New Revision: 1446909
URL: http://svn.apache.org/r1446909
Log:
Fix Findbugs warnings
Modified:
tomcat/trunk/java/org/apache/catalina/valves/rewrite/RewriteCond.java
Modified: tomcat/trunk/java/org/apache/catalina/valves/rewrite/RewriteCond.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/rewrite/RewriteCond.java?rev=1446909&r1=1446908&r2=1446909&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/valves/rewrite/RewriteCond.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/valves/rewrite/RewriteCond.java Sat
Feb 16 16:09:39 2013
@@ -23,11 +23,11 @@ import java.util.regex.Pattern;
public class RewriteCond {
-public abstract class Condition {
+public static abstract class Condition {
public abstract boolean evaluate(String value, Resolver resolver);
}
-public class PatternCondition extends Condition {
+public static class PatternCondition extends Condition {
public Pattern pattern;
public Matcher matcher = null;
@@ -43,7 +43,7 @@ public class RewriteCond {
}
}
-public class LexicalCondition extends Condition {
+public static class LexicalCondition extends Condition {
/**
* -1: <
* 0: =
@@ -69,7 +69,7 @@ public class RewriteCond {
}
}
-public class ResourceCondition extends Condition {
+public static class ResourceCondition extends Condition {
/**
* 0: -d (is directory ?)
* 1: -f (is regular file ?)
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1446910 - /tomcat/trunk/java/org/apache/tomcat/websocket/WsRemoteEndpointBase.java
Author: markt
Date: Sat Feb 16 16:13:24 2013
New Revision: 1446910
URL: http://svn.apache.org/r1446910
Log:
Fix Findbugs warning
Modified:
tomcat/trunk/java/org/apache/tomcat/websocket/WsRemoteEndpointBase.java
Modified:
tomcat/trunk/java/org/apache/tomcat/websocket/WsRemoteEndpointBase.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/websocket/WsRemoteEndpointBase.java?rev=1446910&r1=1446909&r2=1446910&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/websocket/WsRemoteEndpointBase.java
(original)
+++ tomcat/trunk/java/org/apache/tomcat/websocket/WsRemoteEndpointBase.java Sat
Feb 16 16:13:24 2013
@@ -667,7 +667,7 @@ public abstract class WsRemoteEndpointBa
@Override
public SendResult get() throws InterruptedException,
-ExecutionException {
+ ExecutionException {
latch.await();
return result;
}
@@ -676,7 +676,10 @@ public abstract class WsRemoteEndpointBa
public SendResult get(long timeout, TimeUnit unit)
throws InterruptedException, ExecutionException,
TimeoutException {
-latch.await(timeout, unit);
+boolean retval = latch.await(timeout, unit);
+if (retval == false) {
+ throw new TimeoutException();
+}
return result;
}
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1446912 - /tomcat/trunk/res/findbugs/filter-false-positives.xml
Author: markt Date: Sat Feb 16 16:29:46 2013 New Revision: 1446912 URL: http://svn.apache.org/r1446912 Log: Suppress false positive Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/res/findbugs/filter-false-positives.xml?rev=1446912&r1=1446911&r2=1446912&view=diff == --- tomcat/trunk/res/findbugs/filter-false-positives.xml (original) +++ tomcat/trunk/res/findbugs/filter-false-positives.xml Sat Feb 16 16:29:46 2013 @@ -431,6 +431,12 @@ + + + + + + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Jasper: "use of final," "reduce visibility"
Mark, I've noticed in the past few days you've committed several change sets with comments like "use of final" and "reduce visibility" (mostly the latter). I'm trying to understand the Tomcat source code better so that I can potentially contribute more in the future, and I'm wondering what the motivation is behind reducing visibility of Jasper components. I've always viewed reducing visibility as a hindrance to extension (which, of course, is sometimes desired), so I'm curious why the sudden attempt to do this to Jasper? (Is it as simple as just cleaning things up before beginning the JSP 2.3/EL 3.0 implementation?) Specifically, sometime last year I mentioned on the list perhaps contributing an improved Ant task for JSP compilation (bugs 53011, 53012, and 53492, dev list topic "Improving Ant Task for JSP Compilation" from March 31, 2012). After successfully contributing my first bit of new code to trunk, I'm thinking about finally getting around to doing this. Are any of the changes you are making going to hinder my ability to do this? (I gave it a cursory glance in version control and didn't see anything that stood out, but I may be missing something). Thanks, Nick smime.p7s Description: S/MIME cryptographic signature
Re: Jasper: "use of final," "reduce visibility"
On 16/02/2013 16:42, Nick Williams wrote: Mark, I've noticed in the past few days you've committed several change sets with comments like "use of final" and "reduce visibility" (mostly the latter). I'm trying to understand the Tomcat source code better so that I can potentially contribute more in the future, and I'm wondering what the motivation is behind reducing visibility of Jasper components. I've always viewed reducing visibility as a hindrance to extension (which, of course, is sometimes desired), so I'm curious why the sudden attempt to do this to Jasper? (Is it as simple as just cleaning things up before beginning the JSP 2.3/EL 3.0 implementation?) http://svn.apache.org/repos/asf/tomcat/trunk/TOMCAT-NEXT.txt Item 5. Making fields private should never be an issue as accessors should be used. Reducing visibiity encourages good design. Visibility can always be increased if required. Specifically, sometime last year I mentioned on the list perhaps contributing an improved Ant task for JSP compilation (bugs 53011, 53012, and 53492, dev list topic "Improving Ant Task for JSP Compilation" from March 31, 2012). After successfully contributing my first bit of new code to trunk, I'm thinking about finally getting around to doing this. Are any of the changes you are making going to hinder my ability to do this? (I gave it a cursory glance in version control and didn't see anything that stood out, but I may be missing something). No. Visibility can be increased, accessors can be added as necessary. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Jasper: "use of final," "reduce visibility"
On Feb 16, 2013, at 10:51 AM, Mark Thomas wrote: > On 16/02/2013 16:42, Nick Williams wrote: >> Mark, >> >> I've noticed in the past few days you've committed several change >> sets with comments like "use of final" and "reduce visibility" >> (mostly the latter). I'm trying to understand the Tomcat source code >> better so that I can potentially contribute more in the future, and >> I'm wondering what the motivation is behind reducing visibility of >> Jasper components. I've always viewed reducing visibility as a >> hindrance to extension (which, of course, is sometimes desired), so >> I'm curious why the sudden attempt to do this to Jasper? (Is it as >> simple as just cleaning things up before beginning the JSP 2.3/EL 3.0 >> implementation?) > > http://svn.apache.org/repos/asf/tomcat/trunk/TOMCAT-NEXT.txt > Item 5. AH! Haha. I didn't even see that. I will enjoy looking over this list. Thanks. > > Making fields private should never be an issue as accessors should be used. True. I just didn't know if you were also reducing the visibility of classes or methods. > > Reducing visibiity encourages good design. Agreed. Reducing the visibility of fields and using encapsulation are good design approaches. However, sometimes reducing the visibility of methods can be troublesome, depending on the situation. > > Visibility can always be increased if required. > >> Specifically, sometime last year I mentioned on the list perhaps >> contributing an improved Ant task for JSP compilation (bugs 53011, >> 53012, and 53492, dev list topic "Improving Ant Task for JSP >> Compilation" from March 31, 2012). After successfully contributing my >> first bit of new code to trunk, I'm thinking about finally getting >> around to doing this. Are any of the changes you are making going to >> hinder my ability to do this? (I gave it a cursory glance in version >> control and didn't see anything that stood out, but I may be missing >> something). > > No. Visibility can be increased, accessors can be added as necessary. Understood. Thanks! Nick smime.p7s Description: S/MIME cryptographic signature
svn commit: r1446917 - in /tomcat/trunk/java/org/apache/tomcat/websocket: LocalStrings.properties WsSession.java
Author: markt
Date: Sat Feb 16 17:36:48 2013
New Revision: 1446917
URL: http://svn.apache.org/r1446917
Log:
Fix a couple of logging TODOs
Modified:
tomcat/trunk/java/org/apache/tomcat/websocket/LocalStrings.properties
tomcat/trunk/java/org/apache/tomcat/websocket/WsSession.java
Modified: tomcat/trunk/java/org/apache/tomcat/websocket/LocalStrings.properties
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/websocket/LocalStrings.properties?rev=1446917&r1=1446916&r2=1446917&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/websocket/LocalStrings.properties
(original)
+++ tomcat/trunk/java/org/apache/tomcat/websocket/LocalStrings.properties Sat
Feb 16 17:36:48 2013
@@ -42,9 +42,11 @@ wsRemoteEndpoint.inProgress=Message will
# Messages are encoded using UTF-8 where a single character may be encoded in
# as many as 4 bytes.
wsSession.timeout=The WebSocket session timeout expired
+
wsSession.duplicateHandlerBinary=A binary message handler has already been
configured
wsSession.duplicateHandlerPong=A pong message handler has already been
configured
wsSession.duplicateHandlerText=A text message handler has already been
configured
+wsSession.expireFailed=Unable to close expired session cleanly
wsSession.invalidHandlerTypePong=A pong message handler must implement
MessageHandler.Basic
wsSession.removeHandlerFailed=Unable to remove the handler [{0}] as it was not
registered with this session
wsSession.unknownHandler=Unable to add the message handler [{0}] as it was for
the unrecognised type [{1}]
Modified: tomcat/trunk/java/org/apache/tomcat/websocket/WsSession.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/websocket/WsSession.java?rev=1446917&r1=1446916&r2=1446917&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/websocket/WsSession.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/websocket/WsSession.java Sat Feb 16
17:36:48 2013
@@ -41,6 +41,8 @@ import javax.websocket.RemoteEndpoint;
import javax.websocket.Session;
import javax.websocket.WebSocketContainer;
+import org.apache.juli.logging.Log;
+import org.apache.juli.logging.LogFactory;
import org.apache.tomcat.util.res.StringManager;
public class WsSession implements Session {
@@ -49,6 +51,8 @@ public class WsSession implements Sessio
private static final StringManager sm =
StringManager.getManager(Constants.PACKAGE_NAME);
+private final Log log = LogFactory.getLog(WsSession.class);
+
private final Endpoint localEndpoint;
private final WsRemoteEndpointBase wsRemoteEndpoint;
private final ClassLoader applicationClassLoader;
@@ -394,7 +398,7 @@ public class WsSession implements Sessio
close(new CloseReason(CloseCodes.GOING_AWAY,
sm.getString("wsSession.timeout")));
} catch (IOException e) {
-// TODO Log this?
+ log.warn(sm.getString("wsSession.expireFailed"), e);
}
}
}
@@ -446,7 +450,7 @@ public class WsSession implements Sessio
superClassType.getActualTypeArguments()[
((Integer) result).intValue()]);
} else {
-// TODO: Something went wrong. Log an error.
+ // Error will be logged further up the call stack
return null;
}
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1446947 - /tomcat/trunk/java/org/apache/juli/logging/DirectJDKLog.java
Author: markt
Date: Sat Feb 16 20:53:28 2013
New Revision: 1446947
URL: http://svn.apache.org/r1446947
Log:
Remove incomplete comment
Modified:
tomcat/trunk/java/org/apache/juli/logging/DirectJDKLog.java
Modified: tomcat/trunk/java/org/apache/juli/logging/DirectJDKLog.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/juli/logging/DirectJDKLog.java?rev=1446947&r1=1446946&r2=1446947&view=diff
==
--- tomcat/trunk/java/org/apache/juli/logging/DirectJDKLog.java (original)
+++ tomcat/trunk/java/org/apache/juli/logging/DirectJDKLog.java Sat Feb 16
20:53:28 2013
@@ -25,9 +25,6 @@ import java.util.logging.Logger;
/**
* Hardcoded java.util.logging commons-logging implementation.
- *
- * In addition, it curr
- *
*/
class DirectJDKLog implements Log {
// no reason to hide this - but good reasons to not hide
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1446948 - /tomcat/trunk/TOMCAT-NEXT.txt
Author: markt Date: Sat Feb 16 20:55:55 2013 New Revision: 1446948 URL: http://svn.apache.org/r1446948 Log: juli was reviewed with UCDetector in r1225467 Modified: tomcat/trunk/TOMCAT-NEXT.txt Modified: tomcat/trunk/TOMCAT-NEXT.txt URL: http://svn.apache.org/viewvc/tomcat/trunk/TOMCAT-NEXT.txt?rev=1446948&r1=1446947&r2=1446948&view=diff == --- tomcat/trunk/TOMCAT-NEXT.txt (original) +++ tomcat/trunk/TOMCAT-NEXT.txt Sat Feb 16 20:55:55 2013 @@ -35,7 +35,7 @@ but possibly 7.1.x). 5. Run the unused code detector and remove everything that isn't currently used. Add deprecation markers for the removed code to Tomcat 7.0.x - Complete for javax.* -- Complete for o.a.[catalina|coyote|el].* +- Complete for o.a.[catalina|coyote|el|juli].* - Remaining code in progress 6. Change the default URIEncoding on the connector to UTF-8. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1446949 - /tomcat/trunk/TOMCAT-NEXT.txt
Author: markt Date: Sat Feb 16 20:57:04 2013 New Revision: 1446949 URL: http://svn.apache.org/r1446949 Log: naming was reviewed with UCDetector in r1225625 Modified: tomcat/trunk/TOMCAT-NEXT.txt Modified: tomcat/trunk/TOMCAT-NEXT.txt URL: http://svn.apache.org/viewvc/tomcat/trunk/TOMCAT-NEXT.txt?rev=1446949&r1=1446948&r2=1446949&view=diff == --- tomcat/trunk/TOMCAT-NEXT.txt (original) +++ tomcat/trunk/TOMCAT-NEXT.txt Sat Feb 16 20:57:04 2013 @@ -35,7 +35,7 @@ but possibly 7.1.x). 5. Run the unused code detector and remove everything that isn't currently used. Add deprecation markers for the removed code to Tomcat 7.0.x - Complete for javax.* -- Complete for o.a.[catalina|coyote|el|juli].* +- Complete for o.a.[catalina|coyote|el|juli|naming].* - Remaining code in progress 6. Change the default URIEncoding on the connector to UTF-8. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1446952 - in /tomcat/trunk/java/org/apache/jasper/runtime: JspContextWrapper.java JspFactoryImpl.java JspRuntimeLibrary.java JspWriterImpl.java PageContextImpl.java
Author: markt
Date: Sat Feb 16 21:31:51 2013
New Revision: 1446952
URL: http://svn.apache.org/r1446952
Log:
UCDetector
- use final
- reduce visibility
- remove unused code
Modified:
tomcat/trunk/java/org/apache/jasper/runtime/JspContextWrapper.java
tomcat/trunk/java/org/apache/jasper/runtime/JspFactoryImpl.java
tomcat/trunk/java/org/apache/jasper/runtime/JspRuntimeLibrary.java
tomcat/trunk/java/org/apache/jasper/runtime/JspWriterImpl.java
tomcat/trunk/java/org/apache/jasper/runtime/PageContextImpl.java
Modified: tomcat/trunk/java/org/apache/jasper/runtime/JspContextWrapper.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/runtime/JspContextWrapper.java?rev=1446952&r1=1446951&r2=1446952&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/runtime/JspContextWrapper.java
(original)
+++ tomcat/trunk/java/org/apache/jasper/runtime/JspContextWrapper.java Sat Feb
16 21:31:51 2013
@@ -81,7 +81,7 @@ public class JspContextWrapper extends P
private ELContext elContext = null;
-private PageContext rootJspCtxt;
+private final PageContext rootJspCtxt;
public JspContextWrapper(JspContext jspContext,
ArrayList nestedVars, ArrayList atBeginVars,
Modified: tomcat/trunk/java/org/apache/jasper/runtime/JspFactoryImpl.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/runtime/JspFactoryImpl.java?rev=1446952&r1=1446951&r2=1446952&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/runtime/JspFactoryImpl.java (original)
+++ tomcat/trunk/java/org/apache/jasper/runtime/JspFactoryImpl.java Sat Feb 16
21:31:51 2013
@@ -174,7 +174,7 @@ public class JspFactoryImpl extends JspF
}
}
-protected static final class PageContextPool {
+private static final class PageContextPool {
private final PageContext[] pool;
Modified: tomcat/trunk/java/org/apache/jasper/runtime/JspRuntimeLibrary.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/runtime/JspRuntimeLibrary.java?rev=1446952&r1=1446951&r2=1446952&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/runtime/JspRuntimeLibrary.java
(original)
+++ tomcat/trunk/java/org/apache/jasper/runtime/JspRuntimeLibrary.java Sat Feb
16 21:31:51 2013
@@ -59,12 +59,12 @@ public class JspRuntimeLibrary {
protected static class PrivilegedIntrospectHelper
implements PrivilegedExceptionAction {
-private Object bean;
-private String prop;
-private String value;
-private ServletRequest request;
-private String param;
-private boolean ignoreMethodNF;
+private final Object bean;
+private final String prop;
+private final String value;
+private final ServletRequest request;
+private final String param;
+private final boolean ignoreMethodNF;
PrivilegedIntrospectHelper(Object bean, String prop,
String value, ServletRequest request,
Modified: tomcat/trunk/java/org/apache/jasper/runtime/JspWriterImpl.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/runtime/JspWriterImpl.java?rev=1446952&r1=1446951&r2=1446952&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/runtime/JspWriterImpl.java (original)
+++ tomcat/trunk/java/org/apache/jasper/runtime/JspWriterImpl.java Sat Feb 16
21:31:51 2013
@@ -56,16 +56,6 @@ public class JspWriterImpl extends JspWr
}
/**
- * Create a buffered character-output stream that uses a default-sized
- * output buffer.
- *
- * @param response A Servlet Response
- */
-public JspWriterImpl(ServletResponse response) {
-this(response, Constants.DEFAULT_BUFFER_SIZE, true);
-}
-
-/**
* Create a new buffered character-output stream that uses an output
* buffer of the given size.
*
@@ -340,7 +330,8 @@ public class JspWriterImpl extends JspWr
}
-static final String lineSeparator = System.getProperty("line.separator");
+private static final String lineSeparator =
+ System.getProperty("line.separator");
/**
* Write a line separator. The line separator string is defined by the
Modified: tomcat/trunk/java/org/apache/jasper/runtime/PageContextImpl.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/runtime/PageContextImpl.java?rev=1446952&r1=1446951&r2=1446952&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/runtime/PageContextImpl.java (original)
+++ tomcat/trunk/java/org/apache/jasper/runtime/PageContextImpl.java Sat Feb 16
21
svn commit: r1446954 - /tomcat/trunk/java/org/apache/jasper/util/FastRemovalDequeue.java
Author: markt
Date: Sat Feb 16 21:47:52 2013
New Revision: 1446954
URL: http://svn.apache.org/r1446954
Log:
Typo
Modified:
tomcat/trunk/java/org/apache/jasper/util/FastRemovalDequeue.java
Modified: tomcat/trunk/java/org/apache/jasper/util/FastRemovalDequeue.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/util/FastRemovalDequeue.java?rev=1446954&r1=1446953&r2=1446954&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/util/FastRemovalDequeue.java (original)
+++ tomcat/trunk/java/org/apache/jasper/util/FastRemovalDequeue.java Sat Feb 16
21:47:52 2013
@@ -223,7 +223,7 @@ public class FastRemovalDequeue {
* Moves the element to the back.
*
* Could also be implemented as remove() and
- * unpop(), but explicitely coding might be a bit faster.
+ * unpop(), but explicitly coding might be a bit faster.
*
* @param element the entry to move to the back.
* */
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1446955 - in /tomcat/trunk/java/org/apache/jasper: servlet/JspCServletContext.java tagplugins/jstl/Util.java
Author: markt
Date: Sat Feb 16 21:48:59 2013
New Revision: 1446955
URL: http://svn.apache.org/r1446955
Log:
UCDetector
- use final
- reduce visibility
Modified:
tomcat/trunk/java/org/apache/jasper/servlet/JspCServletContext.java
tomcat/trunk/java/org/apache/jasper/tagplugins/jstl/Util.java
Modified: tomcat/trunk/java/org/apache/jasper/servlet/JspCServletContext.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/servlet/JspCServletContext.java?rev=1446955&r1=1446954&r2=1446955&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/servlet/JspCServletContext.java
(original)
+++ tomcat/trunk/java/org/apache/jasper/servlet/JspCServletContext.java Sat Feb
16 21:48:59 2013
@@ -63,19 +63,19 @@ public class JspCServletContext implemen
/**
* Servlet context attributes.
*/
-protected final Hashtable myAttributes;
+private final Hashtable myAttributes;
/**
* The log writer we will write log messages to.
*/
-protected final PrintWriter myLogWriter;
+private final PrintWriter myLogWriter;
/**
* The base URL (document root) for this context.
*/
-protected final URL myResourceBaseURL;
+private final URL myResourceBaseURL;
/**
Modified: tomcat/trunk/java/org/apache/jasper/tagplugins/jstl/Util.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/tagplugins/jstl/Util.java?rev=1446955&r1=1446954&r2=1446955&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/tagplugins/jstl/Util.java (original)
+++ tomcat/trunk/java/org/apache/jasper/tagplugins/jstl/Util.java Sat Feb 16
21:48:59 2013
@@ -43,15 +43,16 @@ import org.apache.jasper.Constants;
public class Util {
-public static final String VALID_SCHEME_CHAR =
+private static final String VALID_SCHEME_CHAR =
"abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789+.-";
public static final String DEFAULT_ENCODING =
"ISO-8859-1";
-public static final int HIGHEST_SPECIAL = '>';
+private static final int HIGHEST_SPECIAL = '>';
-private static char[][] specialCharactersRepresentation = new
char[HIGHEST_SPECIAL + 1][];
+private static final char[][] specialCharactersRepresentation =
+ new char[HIGHEST_SPECIAL + 1][];
static {
specialCharactersRepresentation['&'] = "&".toCharArray();
@@ -262,9 +263,9 @@ public class Util {
*/
public static class ImportResponseWrapper extends
HttpServletResponseWrapper{
-private StringWriter sw = new StringWriter();
-private ByteArrayOutputStream bos = new ByteArrayOutputStream();
-private ServletOutputStream sos = new ServletOutputStream() {
+private final StringWriter sw = new StringWriter();
+private final ByteArrayOutputStream bos = new ByteArrayOutputStream();
+private final ServletOutputStream sos = new ServletOutputStream() {
@Override
public void write(int b) throws IOException {
bos.write(b);
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1446956 - /tomcat/trunk/java/org/apache/jasper/tagplugins/jstl/Util.java
Author: markt
Date: Sat Feb 16 21:50:33 2013
New Revision: 1446956
URL: http://svn.apache.org/r1446956
Log:
Fix a couple of TODOs
Modified:
tomcat/trunk/java/org/apache/jasper/tagplugins/jstl/Util.java
Modified: tomcat/trunk/java/org/apache/jasper/tagplugins/jstl/Util.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/tagplugins/jstl/Util.java?rev=1446956&r1=1446955&r2=1446956&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/tagplugins/jstl/Util.java (original)
+++ tomcat/trunk/java/org/apache/jasper/tagplugins/jstl/Util.java Sat Feb 16
21:50:33 2013
@@ -271,22 +271,16 @@ public class Util {
bos.write(b);
}
-/**
- * TODO SERVLET 3.1
- */
@Override
public boolean isReady() {
-// TODO Auto-generated method stub
+ // Non-blocking IO not supported
return false;
}
-/**
- * TODO SERVLET 3.1
- */
@Override
public void setWriteListener(WriteListener listener) {
-// TODO Auto-generated method stub
-
+ // Non-blocking IO not supported
+ throw new UnsupportedOperationException();
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1446959 - /tomcat/trunk/java/org/apache/jasper/xmlparser/EncodingMap.java
Author: markt
Date: Sat Feb 16 21:58:21 2013
New Revision: 1446959
URL: http://svn.apache.org/r1446959
Log:
UCDetector
- reduce visibility
- remove unused code
Modified:
tomcat/trunk/java/org/apache/jasper/xmlparser/EncodingMap.java
Modified: tomcat/trunk/java/org/apache/jasper/xmlparser/EncodingMap.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/xmlparser/EncodingMap.java?rev=1446959&r1=1446958&r2=1446959&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/xmlparser/EncodingMap.java (original)
+++ tomcat/trunk/java/org/apache/jasper/xmlparser/EncodingMap.java Sat Feb 16
21:58:21 2013
@@ -483,11 +483,7 @@ public class EncodingMap {
//
/** fIANA2JavaMap */
-protected static final Hashtable fIANA2JavaMap =
-new Hashtable<>();
-
-/** fJava2IANAMap */
-protected static final Hashtable fJava2IANAMap =
+private static final Hashtable fIANA2JavaMap =
new Hashtable<>();
//
@@ -866,88 +862,6 @@ public class EncodingMap {
// REVISIT:
// j:CNS11643 -> EUC-TW?
// ISO-2022-CN? ISO-2022-CN-EXT?
-
-// add Java to IANA encoding mappings
-//fJava2IANAMap.put("8859_1","US-ASCII"); // ?
-fJava2IANAMap.put("ISO8859_1","ISO-8859-1");
-fJava2IANAMap.put("ISO8859_2","ISO-8859-2");
-fJava2IANAMap.put("ISO8859_3","ISO-8859-3");
-fJava2IANAMap.put("ISO8859_4","ISO-8859-4");
-fJava2IANAMap.put("ISO8859_5","ISO-8859-5");
-fJava2IANAMap.put("ISO8859_6","ISO-8859-6");
-fJava2IANAMap.put("ISO8859_7","ISO-8859-7");
-fJava2IANAMap.put("ISO8859_8","ISO-8859-8");
-fJava2IANAMap.put("ISO8859_9","ISO-8859-9");
-fJava2IANAMap.put("ISO8859_13","ISO-8859-13");
-fJava2IANAMap.put("ISO8859_15","ISO-8859-15");
-fJava2IANAMap.put("ISO8859_15_FDIS","ISO-8859-15");
-fJava2IANAMap.put("Big5", "BIG5");
-fJava2IANAMap.put("CP037", "EBCDIC-CP-US");
-fJava2IANAMap.put("CP273", "IBM273");
-fJava2IANAMap.put("CP277", "EBCDIC-CP-DK");
-fJava2IANAMap.put("CP278", "EBCDIC-CP-FI");
-fJava2IANAMap.put("CP280", "EBCDIC-CP-IT");
-fJava2IANAMap.put("CP284", "EBCDIC-CP-ES");
-fJava2IANAMap.put("CP285", "EBCDIC-CP-GB");
-fJava2IANAMap.put("CP290", "EBCDIC-JP-KANA");
-fJava2IANAMap.put("CP297", "EBCDIC-CP-FR");
-fJava2IANAMap.put("CP420", "EBCDIC-CP-AR1");
-fJava2IANAMap.put("CP424", "EBCDIC-CP-HE");
-fJava2IANAMap.put("CP437", "IBM437");
-fJava2IANAMap.put("CP500", "EBCDIC-CP-CH");
-fJava2IANAMap.put("CP775", "IBM775");
-fJava2IANAMap.put("CP850", "IBM850");
-fJava2IANAMap.put("CP852", "IBM852");
-fJava2IANAMap.put("CP855", "IBM855");
-fJava2IANAMap.put("CP857", "IBM857");
-fJava2IANAMap.put("CP858", "IBM00858");
-fJava2IANAMap.put("CP860", "IBM860");
-fJava2IANAMap.put("CP861", "IBM861");
-fJava2IANAMap.put("CP862", "IBM862");
-fJava2IANAMap.put("CP863", "IBM863");
-fJava2IANAMap.put("CP864", "IBM864");
-fJava2IANAMap.put("CP865", "IBM865");
-fJava2IANAMap.put("CP866", "IBM866");
-fJava2IANAMap.put("CP868", "IBM868");
-fJava2IANAMap.put("CP869", "IBM869");
-fJava2IANAMap.put("CP870", "EBCDIC-CP-ROECE");
-fJava2IANAMap.put("CP871", "EBCDIC-CP-IS");
-fJava2IANAMap.put("CP918", "EBCDIC-CP-AR2");
-fJava2IANAMap.put("CP924", "IBM00924");
-fJava2IANAMap.put("CP1026", "IBM1026");
-fJava2IANAMap.put("Cp01140", "IBM01140");
-fJava2IANAMap.put("Cp01141", "IBM01141");
-fJava2IANAMap.put("Cp01142", "IBM01142");
-fJava2IANAMap.put("Cp01143", "IBM01143");
-fJava2IANAMap.put("Cp01144", "IBM01144");
-fJava2IANAMap.put("Cp01145", "IBM01145");
-fJava2IANAMap.put("Cp01146", "IBM01146");
-fJava2IANAMap.put("Cp01147", "IBM01147");
-fJava2IANAMap.put("Cp01148", "IBM01148");
-fJava2IANAMap.put("Cp01149", "IBM01149");
-fJava2IANAMap.put("EUCJIS","EUC-JP");
-fJava2IANAMap.put("KS_C_5601-1987", "KS_C_5601-1987");
-fJava2IANAMap.put("GB2312","GB2312");
-fJava2IANAMap.put("ISO2022KR", "ISO-2022-KR");
-fJava2IANAMap.put("ISO2022CN", "ISO-2022-CN");
-fJava2IANAMap.put("JIS", "ISO-2022-JP");
-fJava2IANAMap.put("KOI8_R","KOI8-R");
-fJava2IANAMap.put("KSC5601", "EUC-KR");
-fJava2IANAMap.put("GB18030", "GB18030");
-fJava2IANAMap.put("GBK", "GBK");
-fJava2IANAMap.put("SJIS", "SHIFT_JIS");
svn commit: r1446963 - /tomcat/trunk/java/org/apache/jasper/xmlparser/XMLEncodingDetector.java
Author: markt
Date: Sat Feb 16 22:20:04 2013
New Revision: 1446963
URL: http://svn.apache.org/r1446963
Log:
fAllowJavaEncodings is never set so is always false
Modified:
tomcat/trunk/java/org/apache/jasper/xmlparser/XMLEncodingDetector.java
Modified: tomcat/trunk/java/org/apache/jasper/xmlparser/XMLEncodingDetector.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/xmlparser/XMLEncodingDetector.java?rev=1446963&r1=1446962&r2=1446963&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/xmlparser/XMLEncodingDetector.java
(original)
+++ tomcat/trunk/java/org/apache/jasper/xmlparser/XMLEncodingDetector.java Sat
Feb 16 22:20:04 2013
@@ -52,7 +52,6 @@ public class XMLEncodingDetector {
// org.apache.xerces.impl.XMLEntityManager fields
public static final int DEFAULT_BUFFER_SIZE = 2048;
public static final int DEFAULT_XMLDECL_BUFFER_SIZE = 64;
-private boolean fAllowJavaEncodings;
private SymbolTable fSymbolTable;
private XMLEncodingDetector fCurrentEntity;
private int fBufferSize = DEFAULT_BUFFER_SIZE;
@@ -245,8 +244,7 @@ public class XMLEncodingDetector {
// check for valid name
boolean validIANA = XMLChar.isValidIANAEncoding(encoding);
-boolean validJava = XMLChar.isValidJavaEncoding(encoding);
-if (!validIANA || (fAllowJavaEncodings && !validJava)) {
+if (!validIANA) {
err.jspError("jsp.error.xml.encodingDeclInvalid", encoding);
// NOTE: AndyH suggested that, on failure, we use ISO Latin 1
// because every byte is a valid ISO Latin 1 character.
@@ -262,13 +260,9 @@ public class XMLEncodingDetector {
// try to use a Java reader
String javaEncoding = EncodingMap.getIANA2JavaMapping(ENCODING);
if (javaEncoding == null) {
-if (fAllowJavaEncodings) {
-javaEncoding = encoding;
-} else {
-err.jspError("jsp.error.xml.encodingDeclInvalid", encoding);
-// see comment above.
-javaEncoding = "ISO8859_1";
-}
+err.jspError("jsp.error.xml.encodingDeclInvalid", encoding);
+// see comment above.
+javaEncoding = "ISO8859_1";
}
return new InputStreamReader(inputStream, javaEncoding);
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1446964 - /tomcat/trunk/java/org/apache/jasper/xmlparser/XMLEncodingDetector.java
Author: markt
Date: Sat Feb 16 22:23:05 2013
New Revision: 1446964
URL: http://svn.apache.org/r1446964
Log:
mayReadChunks is always false
Modified:
tomcat/trunk/java/org/apache/jasper/xmlparser/XMLEncodingDetector.java
Modified: tomcat/trunk/java/org/apache/jasper/xmlparser/XMLEncodingDetector.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/xmlparser/XMLEncodingDetector.java?rev=1446964&r1=1446963&r2=1446964&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/xmlparser/XMLEncodingDetector.java
(original)
+++ tomcat/trunk/java/org/apache/jasper/xmlparser/XMLEncodingDetector.java Sat
Feb 16 22:23:05 2013
@@ -61,7 +61,6 @@ public class XMLEncodingDetector {
private char[] ch = new char[DEFAULT_BUFFER_SIZE];
private int position;
private int count;
-private boolean mayReadChunks = false;
// org.apache.xerces.impl.XMLScanner fields
private XMLString fString = new XMLString();
@@ -969,11 +968,8 @@ public class XMLEncodingDetector {
throws IOException {
// read characters
-int length = fCurrentEntity.mayReadChunks?
-(fCurrentEntity.ch.length - offset):
-(DEFAULT_XMLDECL_BUFFER_SIZE);
int count = fCurrentEntity.reader.read(fCurrentEntity.ch, offset,
- length);
+ DEFAULT_XMLDECL_BUFFER_SIZE);
// reset count and position
boolean entityChanged = false;
@@ -1077,9 +1073,6 @@ public class XMLEncodingDetector {
return -1;
}
// better get some more for the voracious reader...
-if (fCurrentEntity.mayReadChunks) {
-return fInputStream.read(b, off, len);
-}
int returnedVal = read();
if (returnedVal == -1) {
fEndOffset = fOffset;
@@ -1145,8 +1138,7 @@ public class XMLEncodingDetector {
if (fOffset == fEndOffset) {
return -1;
}
-return fCurrentEntity.mayReadChunks ? fInputStream.available()
-: 0;
+return 0;
}
return bytesLeft;
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1446965 - /tomcat/trunk/java/org/apache/jasper/xmlparser/XMLEncodingDetector.java
Author: markt
Date: Sat Feb 16 22:25:59 2013
New Revision: 1446965
URL: http://svn.apache.org/r1446965
Log:
literal is never set so is always false
Modified:
tomcat/trunk/java/org/apache/jasper/xmlparser/XMLEncodingDetector.java
Modified: tomcat/trunk/java/org/apache/jasper/xmlparser/XMLEncodingDetector.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/xmlparser/XMLEncodingDetector.java?rev=1446965&r1=1446964&r2=1446965&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/xmlparser/XMLEncodingDetector.java
(original)
+++ tomcat/trunk/java/org/apache/jasper/xmlparser/XMLEncodingDetector.java Sat
Feb 16 22:25:59 2013
@@ -57,7 +57,6 @@ public class XMLEncodingDetector {
private int fBufferSize = DEFAULT_BUFFER_SIZE;
// org.apache.xerces.impl.XMLEntityManager.ScannedEntity fields
-private boolean literal;
private char[] ch = new char[DEFAULT_BUFFER_SIZE];
private int position;
private int count;
@@ -608,9 +607,7 @@ public class XMLEncodingDetector {
// scan literal value
while (fCurrentEntity.position < fCurrentEntity.count) {
c = fCurrentEntity.ch[fCurrentEntity.position++];
-if ((c == quote &&
- (!fCurrentEntity.literal || external))
-|| c == '%' || !XMLChar.isContent(c)) {
+if (c == quote || c == '%' || !XMLChar.isContent(c)) {
fCurrentEntity.position--;
break;
}
@@ -621,12 +618,6 @@ public class XMLEncodingDetector {
// return next character
if (fCurrentEntity.position != fCurrentEntity.count) {
c = fCurrentEntity.ch[fCurrentEntity.position];
-// NOTE: We don't want to accidentally signal the
-// end of the literal if we're expanding an
-// entity appearing in the literal. -Ac
-if (c == quote && fCurrentEntity.literal) {
-c = -1;
-}
}
else {
c = -1;
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1446966 - in /tomcat/trunk/java/org/apache/jasper/xmlparser: ASCIIReader.java ParserUtils.java SymbolTable.java TreeNode.java UCSReader.java UTF8Reader.java XMLChar.java
Author: markt
Date: Sat Feb 16 22:26:32 2013
New Revision: 1446966
URL: http://svn.apache.org/r1446966
Log:
UCDetector
- use final
- reduce visibility
- remove unused code
Modified:
tomcat/trunk/java/org/apache/jasper/xmlparser/ASCIIReader.java
tomcat/trunk/java/org/apache/jasper/xmlparser/ParserUtils.java
tomcat/trunk/java/org/apache/jasper/xmlparser/SymbolTable.java
tomcat/trunk/java/org/apache/jasper/xmlparser/TreeNode.java
tomcat/trunk/java/org/apache/jasper/xmlparser/UCSReader.java
tomcat/trunk/java/org/apache/jasper/xmlparser/UTF8Reader.java
tomcat/trunk/java/org/apache/jasper/xmlparser/XMLChar.java
Modified: tomcat/trunk/java/org/apache/jasper/xmlparser/ASCIIReader.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/xmlparser/ASCIIReader.java?rev=1446966&r1=1446965&r2=1446966&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/xmlparser/ASCIIReader.java (original)
+++ tomcat/trunk/java/org/apache/jasper/xmlparser/ASCIIReader.java Sat Feb 16
22:26:32 2013
@@ -38,10 +38,10 @@ public class ASCIIReader extends Reader
//
/** Input stream. */
-protected InputStream fInputStream;
+private final InputStream fInputStream;
/** Byte buffer. */
-protected byte[] fBuffer;
+private final byte[] fBuffer;
//
// Constructors
Modified: tomcat/trunk/java/org/apache/jasper/xmlparser/ParserUtils.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/xmlparser/ParserUtils.java?rev=1446966&r1=1446965&r2=1446966&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/xmlparser/ParserUtils.java (original)
+++ tomcat/trunk/java/org/apache/jasper/xmlparser/ParserUtils.java Sat Feb 16
22:26:32 2013
@@ -56,12 +56,12 @@ public class ParserUtils {
/**
* An error handler for use when parsing XML documents.
*/
-static ErrorHandler errorHandler = new MyErrorHandler();
+private static final ErrorHandler errorHandler = new MyErrorHandler();
/**
* An entity resolver for use when parsing XML documents.
*/
-static EntityResolver entityResolver = new MyEntityResolver();
+private static EntityResolver entityResolver = new MyEntityResolver();
// Turn off for JSP 2.0 until switch over to using xschema.
public static boolean validating = false;
Modified: tomcat/trunk/java/org/apache/jasper/xmlparser/SymbolTable.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/xmlparser/SymbolTable.java?rev=1446966&r1=1446965&r2=1446966&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/xmlparser/SymbolTable.java (original)
+++ tomcat/trunk/java/org/apache/jasper/xmlparser/SymbolTable.java Sat Feb 16
22:26:32 2013
@@ -58,17 +58,17 @@ public class SymbolTable {
//
/** Default table size. */
-protected static final int TABLE_SIZE = 101;
+private static final int TABLE_SIZE = 101;
//
// Data
//
/** Buckets. */
-protected Entry[] fBuckets = null;
+private final Entry[] fBuckets;
// actual table size
-protected int fTableSize;
+private final int fTableSize;
//
// Constructors
@@ -95,37 +95,6 @@ public class SymbolTable {
* the previous symbol reference is returned instead, in order
* guarantee that symbol references remain unique.
*
- * @param symbol The new symbol.
- */
-public String addSymbol(String symbol) {
-
-// search for identical symbol
-int bucket = hash(symbol) % fTableSize;
-int length = symbol.length();
-OUTER: for (Entry entry = fBuckets[bucket]; entry != null; entry =
entry.next) {
-if (length == entry.characters.length) {
-for (int i = 0; i < length; i++) {
-if (symbol.charAt(i) != entry.characters[i]) {
-continue OUTER;
-}
-}
-return entry.symbol;
-}
-}
-
-// create new entry
-Entry entry = new Entry(symbol, fBuckets[bucket]);
-fBuckets[bucket] = entry;
-return entry.symbol;
-
-} // addSymbol(String):String
-
-/**
- * Adds the specified symbol to the symbol table and returns a
- * reference to the unique symbol. If the symbol already exists,
- * the previous symbol reference is returned instead, in order
- * guarantee that symbol references remain unique.
- *
* @param buffer The buffer containing the new symbol.
* @param offset The offset into the buffer of the new symbol.
* @param length The length of the new symbol in the buffer.
@@ -153,25 +122,6 @@ public class SymbolTable {
} // addSymbol(char[],int,int):String
/**
- * Returns a
svn commit: r1446968 - in /tomcat/trunk/java/org/apache/jasper/xmlparser: XMLChar.java XMLEncodingDetector.java XMLStringBuffer.java
Author: markt
Date: Sat Feb 16 22:33:26 2013
New Revision: 1446968
URL: http://svn.apache.org/r1446968
Log:
UCDetector
- use final
- reduce visibility
- remove unused code
Modified:
tomcat/trunk/java/org/apache/jasper/xmlparser/XMLChar.java
tomcat/trunk/java/org/apache/jasper/xmlparser/XMLEncodingDetector.java
tomcat/trunk/java/org/apache/jasper/xmlparser/XMLStringBuffer.java
Modified: tomcat/trunk/java/org/apache/jasper/xmlparser/XMLChar.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/xmlparser/XMLChar.java?rev=1446968&r1=1446967&r2=1446968&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/xmlparser/XMLChar.java (original)
+++ tomcat/trunk/java/org/apache/jasper/xmlparser/XMLChar.java Sat Feb 16
22:33:26 2013
@@ -843,32 +843,4 @@ public class XMLChar {
}
return false;
} // isValidIANAEncoding(String):boolean
-
-/**
- * Returns true if the encoding name is a valid Java encoding.
- * This method does not verify that there is a decoder available
- * for this encoding, only that the characters are valid for an
- * Java encoding name.
- *
- * @param javaEncoding The Java encoding name.
- */
-public static boolean isValidJavaEncoding(String javaEncoding) {
-if (javaEncoding != null) {
-int length = javaEncoding.length();
-if (length > 0) {
-for (int i = 1; i < length; i++) {
-char c = javaEncoding.charAt(i);
-if ((c < 'A' || c > 'Z') && (c < 'a' || c > 'z') &&
-(c < '0' || c > '9') && c != '.' && c != '_' &&
-c != '-') {
-return false;
-}
-}
-return true;
-}
-}
-return false;
-} // isValidIANAEncoding(String):boolean
-
-
} // class XMLChar
Modified: tomcat/trunk/java/org/apache/jasper/xmlparser/XMLEncodingDetector.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/xmlparser/XMLEncodingDetector.java?rev=1446968&r1=1446967&r2=1446968&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/xmlparser/XMLEncodingDetector.java
(original)
+++ tomcat/trunk/java/org/apache/jasper/xmlparser/XMLEncodingDetector.java Sat
Feb 16 22:33:26 2013
@@ -50,10 +50,10 @@ public class XMLEncodingDetector {
private Reader reader;
// org.apache.xerces.impl.XMLEntityManager fields
-public static final int DEFAULT_BUFFER_SIZE = 2048;
-public static final int DEFAULT_XMLDECL_BUFFER_SIZE = 64;
-private SymbolTable fSymbolTable;
-private XMLEncodingDetector fCurrentEntity;
+private static final int DEFAULT_BUFFER_SIZE = 2048;
+private static final int DEFAULT_XMLDECL_BUFFER_SIZE = 64;
+private final SymbolTable fSymbolTable;
+private final XMLEncodingDetector fCurrentEntity;
private int fBufferSize = DEFAULT_BUFFER_SIZE;
// org.apache.xerces.impl.XMLEntityManager.ScannedEntity fields
@@ -62,15 +62,15 @@ public class XMLEncodingDetector {
private int count;
// org.apache.xerces.impl.XMLScanner fields
-private XMLString fString = new XMLString();
-private XMLStringBuffer fStringBuffer = new XMLStringBuffer();
-private XMLStringBuffer fStringBuffer2 = new XMLStringBuffer();
+private final XMLString fString = new XMLString();
+private final XMLStringBuffer fStringBuffer = new XMLStringBuffer();
+private final XMLStringBuffer fStringBuffer2 = new XMLStringBuffer();
private static final String fVersionSymbol = "version";
private static final String fEncodingSymbol = "encoding";
private static final String fStandaloneSymbol = "standalone";
// org.apache.xerces.impl.XMLDocumentFragmentScannerImpl fields
-private String[] fStrings = new String[3];
+private final String[] fStrings = new String[3];
private ErrorDispatcher err;
Modified: tomcat/trunk/java/org/apache/jasper/xmlparser/XMLStringBuffer.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/xmlparser/XMLStringBuffer.java?rev=1446968&r1=1446967&r2=1446968&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/xmlparser/XMLStringBuffer.java
(original)
+++ tomcat/trunk/java/org/apache/jasper/xmlparser/XMLStringBuffer.java Sat Feb
16 22:33:26 2013
@@ -54,7 +54,7 @@ public class XMLStringBuffer
//
/** Default buffer size (32). */
-public static final int DEFAULT_SIZE = 32;
+private static final int DEFAULT_SIZE = 32;
//
// Constructors
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache
svn commit: r1446969 - /tomcat/trunk/java/org/apache/jasper/Constants.java
Author: markt
Date: Sat Feb 16 22:33:56 2013
New Revision: 1446969
URL: http://svn.apache.org/r1446969
Log:
Remove unused constants
Modified:
tomcat/trunk/java/org/apache/jasper/Constants.java
Modified: tomcat/trunk/java/org/apache/jasper/Constants.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/Constants.java?rev=1446969&r1=1446968&r2=1446969&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/Constants.java (original)
+++ tomcat/trunk/java/org/apache/jasper/Constants.java Sat Feb 16 22:33:56 2013
@@ -48,11 +48,6 @@ public class Constants {
System.getProperty("org.apache.jasper.Constants.SERVICE_METHOD_NAME",
"_jspService");
/**
- * Default servlet content type.
- */
-public static final String SERVLET_CONTENT_TYPE = "text/html";
-
-/**
* These classes/packages are automatically imported by the
* generated code.
*/
@@ -216,12 +211,6 @@ public class Constants {
public static final String CATALINA_HOME_PROP = "catalina.home";
/**
- * Name of the system property containing
- * the tomcat instance installation path
- */
-public static final String CATALINA_BASE_PROP = "catalina.base";
-
-/**
* Name of system property containing default list of JARs to skip when
* scanning JARs for configuration elements such as TLDs.
*/
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1446970 - /tomcat/trunk/java/org/apache/jasper/Constants.java
Author: markt
Date: Sat Feb 16 22:35:00 2013
New Revision: 1446970
URL: http://svn.apache.org/r1446970
Log:
UCDetector
- reduce visibility
Modified:
tomcat/trunk/java/org/apache/jasper/Constants.java
Modified: tomcat/trunk/java/org/apache/jasper/Constants.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/Constants.java?rev=1446970&r1=1446969&r2=1446970&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/Constants.java (original)
+++ tomcat/trunk/java/org/apache/jasper/Constants.java Sat Feb 16 22:35:00 2013
@@ -124,26 +124,26 @@ public class Constants {
* Public Id and the Resource path (of the cached copy)
* of the DTDs for tag library descriptors.
*/
-public static final String TAGLIB_DTD_PUBLIC_ID_11 =
+private static final String TAGLIB_DTD_PUBLIC_ID_11 =
"-//Sun Microsystems, Inc.//DTD JSP Tag Library 1.1//EN";
-public static final String TAGLIB_DTD_RESOURCE_PATH_11 =
+private static final String TAGLIB_DTD_RESOURCE_PATH_11 =
"/javax/servlet/jsp/resources/web-jsptaglibrary_1_1.dtd";
-public static final String TAGLIB_DTD_PUBLIC_ID_12 =
+private static final String TAGLIB_DTD_PUBLIC_ID_12 =
"-//Sun Microsystems, Inc.//DTD JSP Tag Library 1.2//EN";
-public static final String TAGLIB_DTD_RESOURCE_PATH_12 =
+private static final String TAGLIB_DTD_RESOURCE_PATH_12 =
"/javax/servlet/jsp/resources/web-jsptaglibrary_1_2.dtd";
/**
* Public Id and the Resource path (of the cached copy)
* of the DTDs for web application deployment descriptors
*/
-public static final String WEBAPP_DTD_PUBLIC_ID_22 =
+private static final String WEBAPP_DTD_PUBLIC_ID_22 =
"-//Sun Microsystems, Inc.//DTD Web Application 2.2//EN";
-public static final String WEBAPP_DTD_RESOURCE_PATH_22 =
+private static final String WEBAPP_DTD_RESOURCE_PATH_22 =
"/javax/servlet/resources/web-app_2_2.dtd";
-public static final String WEBAPP_DTD_PUBLIC_ID_23 =
+private static final String WEBAPP_DTD_PUBLIC_ID_23 =
"-//Sun Microsystems, Inc.//DTD Web Application 2.3//EN";
-public static final String WEBAPP_DTD_RESOURCE_PATH_23 =
+private static final String WEBAPP_DTD_RESOURCE_PATH_23 =
"/javax/servlet/resources/web-app_2_3.dtd";
/**
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 54571] New: Race condition when handling comet event in thread other than the serving servlet
https://issues.apache.org/bugzilla/show_bug.cgi?id=54571
Bug ID: 54571
Summary: Race condition when handling comet event in thread
other than the serving servlet
Product: Tomcat 6
Version: 6.0.36
Hardware: PC
OS: Linux
Status: NEW
Severity: normal
Priority: P2
Component: Catalina
Assignee: dev@tomcat.apache.org
Reporter: david.f.w...@alcatel-lucent.com
Classification: Unclassified
Created attachment 29958
--> https://issues.apache.org/bugzilla/attachment.cgi?id=29958&action=edit
A werid http stream which has no http header in response
OS: Linux hostname 2.6.32-279.11.1.el6.x86_64 #1 SMP Sat Sep 22 07:10:26 EDT
2012 x86_64 x86_64 x86_64 GNU/Linux
I have a servlet which post the comet event to other thread for further
handling, there is no synchronize mechanism between this handling thread the
servlet.
And I have a simple python script as a client for testing, it act as a client:
1. make a connection to the servlet
2. send http request and check the response
3. close the connection
After some long sequence of test above, I got a bizarre response with header
Transfer-Encoding: chunked.
The demo code is as following
[code][filename]TestServlet.java[/filename]
import javax.servlet.ServletException;
import java.io.PrintWriter;
import javax.servlet.http.HttpServlet;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import java.io.IOException;
import org.apache.catalina.CometEvent;
import org.apache.catalina.CometEvent.EventSubType;
import org.apache.catalina.CometProcessor;
import java.util.concurrent.LinkedBlockingQueue;
public class TestServlet extends HttpServlet implements CometProcessor {
static String
response1="";
static String
response2="bbb";
protected ThreadModule fRunner=null;
public void init() throws ServletException {
fRunner=new ThreadModule();
Thread runningThread=new Thread(fRunner,"test");
runningThread.setDaemon(true);
runningThread.start();
}
public void event(CometEvent event) throws IOException, ServletException
{
HttpServletRequest request = event.getHttpServletRequest();
HttpServletResponse response = event.getHttpServletResponse();
if (event.getEventType() == CometEvent.EventType.BEGIN) {
//log("Begin for session: " + request.getSession(true).getId());
if (request.getContentLength() <= 0){
String uri = request.getRequestURI();
if (uri.contains("HELLO")) {
fRunner.PostMessage(new ThreadMessage(1,response));
}
else if (uri.contains("WORLD")){
fRunner.PostMessage(new ThreadMessage(2,response));
}
else if (uri.contains("SAD")){
fRunner.PostMessage(new ThreadMessage(3,response));
}
else{
fRunner.PostMessage(new ThreadMessage(4,response));
}
}
} else if (event.getEventType() == CometEvent.EventType.ERROR) {
//log("Error for session: " + request.getSession(true).getId());
event.close();
} else if (event.getEventType() == CometEvent.EventType.END) {
//log("End for session: " + request.getSession(true).getId());
event.close();
} else if (event.getEventType() == CometEvent.EventType.READ) {
}
}
public class ThreadMessage {
public int resType;
public HttpServletResponse response;
public ThreadMessage(int inresType, HttpServletResponse inresponse){
this.resType=inresType;
this.response=inresponse;
}
}
public class ThreadModule implements Runnable {
protected LinkedBlockingQueue queue = new
LinkedBlockingQueue();
protected Object waitObject = new Object();
public ThreadModule(){
}
public void PostMessage(ThreadMessage inMessage){
queue.offer(inMessage);
synchronized (waitObject) {
waitObject.notify();
}
}
public void HandleMessage(ThreadMessage inMessage){
try{
if (inMessage.resType == 1){
inMessage.response.setStatus(200);
PrintWriter writer = inMessage.response.getWriter();
writer.write(response1);
writer.close();
}
else if (inMessage.resType == 2){
inMessage.response.setStatus(404);
PrintWriter writer = inMessage.response.getWriter();
writer.write("");
writer.close();
}
else if (inMessage.resType == 3){
inMessage.response.setStatus(307);
PrintWriter writer = inMessage.response.getWriter();
[Bug 54571] Race condition when handling comet event in thread other than the serving servlet
https://issues.apache.org/bugzilla/show_bug.cgi?id=54571 --- Comment #1 from David Wang --- After some long sequence of test above, I got a bizarre response with header Transfer-Encoding: chunked. === Sometimes the response has header, but the chunked body has size 0 indicating the end of the response And others times I got the weird response without any header as I atached -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Taglibs [2013/02/17]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |38193|Ass|Enh|2006-01-09|[RDC] BuiltIn Grammar support for Field | |38600|Ass|Enh|2006-02-10|[RDC] Enable RDCs to be used in X+V markup (X+RDC)| |42413|New|Enh|2007-05-14|[PATCH] Log Taglib enhancements | |46052|New|Nor|2008-10-21|SetLocaleSupport is slow to initialize when many l| |48333|New|Enh|2009-12-02|TLD generator | +-+---+---+--+--+ | Total5 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Tomcat 8 [2013/02/17]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |51497|New|Enh|2011-07-11|Use canonical IPv6 text representation in logs| |53737|Opn|Enh|2012-08-18|Use ServletContext.getJspConfigDescriptor() in Jas| |53930|New|Enh|2012-09-24|allow capture of catalina stdout/stderr to a comma| |53987|New|Enh|2012-10-09|Log uncovered HTTP methods in combined security co| |54095|New|Enh|2012-11-03|[patch] support gzipped versions of static resourc| |54475|New|Maj|2013-01-23|SMAP broken in Java 8 for JSP compile | |54503|New|Enh|2013-01-29|SAML2 based single sign on| |54522|New|Nor|2013-02-04|Add patch binary as prerequisite in BUILDING.txt | +-+---+---+--+--+ | Total8 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Tomcat Connectors [2013/02/17]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |34526|Opn|Nor|2005-04-19|Truncated content in decompressed requests from mo| |35959|Opn|Enh|2005-08-01|mod_jk not independant of UseCanonicalName| |43303|New|Enh|2007-09-04|Versioning under Windows not reported by many conn| |43968|Inf|Enh|2007-11-26|[patch] support ipv6 with mod_jk | |44290|Inf|Nor|2008-01-24|mod_jk/1.2.26: retry is not useful for an importan| |44349|Inf|Maj|2008-02-04|mod_jk/1.2.26 module does not read worker.status.s| |44379|New|Enh|2008-02-07|convert the output of strftime into UTF-8 | |44454|New|Nor|2008-02-19|busy count reported in mod_jk inflated, causes inc| |44571|New|Enh|2008-03-10|Limits busy per worker to a threshold | |45063|New|Nor|2008-05-22|JK-1.2.26 IIS ISAPI filter issue when running diff| |45313|New|Nor|2008-06-30|mod_jk 1.2.26 & apache 2.2.9 static compiled on so| |46337|New|Nor|2008-12-04|real worker name is wrong | |46676|New|Enh|2009-02-09|Configurable test request for Watchdog thread | |46767|New|Enh|2009-02-25|mod_jk to send DECLINED in case no fail-over tomca| |47327|New|Enh|2009-06-07|remote_user not logged in apache logfile | |47617|Inf|Enh|2009-07-31|include time spent doing ajp_get_endpoint() in err| |47678|New|Cri|2009-08-11|Unable to allocate shared memory when using isapi_| |47714|New|Cri|2009-08-20|Reponse mixed between users | |47750|New|Maj|2009-08-27|Loss of worker settings when changing via jkstatus| |47795|New|Maj|2009-09-07|service sticky_session not being set correctly wit| |47840|Inf|Min|2009-09-14|A broken worker name is written in the log file. | |48191|New|Maj|2009-11-13|Problem with mod_jk 1.2.28 - Can not render up the| |48460|New|Nor|2009-12-30|mod_proxy_ajp document has three misleading portio| |48490|New|Nor|2010-01-05|Changing a node to stopped in uriworkermap.propert| |48513|New|Enh|2010-01-09|IIS Quick setup instructions | |48564|New|Nor|2010-01-18|Unable to turn off retries for LB worker | |48830|New|Nor|2010-03-01|IIS shutdown blocked in endpoint service when serv| |48891|Opn|Enh|2010-03-11|Missing EOL-style settings in tomcat/jk/trunk | |49035|New|Maj|2010-04-01|data lost when post a multipart/form-data form| |49063|New|Enh|2010-04-07|Please add JkStripSession status in jk-status work| |49135|New|Enh|2010-04-16|SPDY Connector for The Tomcat | |49469|New|Enh|2010-06-19|Workers status page has negative number of connect| |49732|Opn|Nor|2010-08-10|reply_timeout can't wait forever. | |49822|New|Enh|2010-08-25|Add hash lb worker method | |49903|New|Enh|2010-09-09|Make workers file reloadable | |50186|New|Nor|2010-10-31|Wrong documentation of connection_pool_timeout / c| |52334|New|Maj|2011-12-14|recover_time is not properly used | |52483|New|Enh|2012-01-18|Print JkOptions's options in log file and jkstatus| |52651|New|Nor|2012-02-13|JKSHMFile size limitation | |53324|Opn|Nor|2012-05-30|Starting with mod_jk 1.2.35 I cannot modify worker| |53542|New|Min|2012-07-13|Spelling mistake on 503 service unavailable page | |53762|New|Nor|2012-08-22|JK status manager: mass nodes handling doesn't wor| |53883|New|Maj|2012-09-17|isapi_redirect v 1.2.37 crashes w3wp.exe on the p| |53977|New|Maj|2012-10-07|32bits isapi connector cannot work in wow64 mode | |54027|New|Cri|2012-10-18|isapi send request to outside address instead of i| |54112|Opn|Blk|2012-11-07|ISAPI redirector not working when IIS recycles| |54117|New|Maj|2012-11-08|access violation exception in isapi_redirect.dll | |54177|New|Nor|2012-11-20|jkmanager generates non-well-formed XML for certai| +-+---+---+--+--+ | Total 48 bugs | +---+ --
Bug report for Tomcat 6 [2013/02/17]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |41679|New|Enh|2007-02-22|SemaphoreValve should be able to filter on url pat| |41883|Ass|Enh|2007-03-18|use abstract wrapper instead of plain X509Certific| |43001|New|Enh|2007-07-30|JspC lacks setMappedFile and setDie for use in Ant| |43400|New|Enh|2007-09-14|enum support for tag libs | |43548|Opn|Enh|2007-10-04|xml schema for tomcat-users.xml | |43682|New|Enh|2007-10-23|JULI: web-inf/classes/logging.properties to suppor| |43742|New|Enh|2007-10-30|.tag compiles performed one at a time -- extremel| |43979|New|Enh|2007-11-27|Add abstraction for Java and Classfile output | |44199|New|Enh|2008-01-10|expose current backlog queue size | |44225|New|Enh|2008-01-14|SSL connector tries to load the private keystore f| |44294|New|Enh|2008-01-25|Support for EL functions with varargs | |44645|New|Enh|2008-03-20|[Patch] JNDIRealm - Doesn't support JNDI "java.nam| |44787|New|Enh|2008-04-09|provide more error context on "java.lang.IllegalSt| |44818|New|Enh|2008-04-13|tomcat hangs with GET when content-length is defin| |45014|New|Enh|2008-05-15|Request and Response classes should have wrappers | |45282|New|Enh|2008-06-25|NioReceiver doesn't close cleanly, leaving sockets| |45428|New|Enh|2008-07-18|warn if the tomcat stop doesn't complete | |45832|New|Enh|2008-09-18|add DIGEST authentication support to Ant tasks| |45878|New|Enh|2008-09-24|Generated jars do not contain proper manifests or | |45879|Opn|Enh|2008-09-24|Windows installer fails to install NOTICE and RELE| |45931|Opn|Enh|2008-10-01|trimSpaces incorrectly modifies output| |46173|New|Enh|2008-11-09|Small patch for manager app: Setting an optional c| |46263|New|Enh|2008-11-21|Tomcat reloading of context.xml does not update do| |46284|New|Enh|2008-11-24|Add flag to DeltaManager that blocks processing cl| |46350|New|Enh|2008-12-05|Maven repository should contain source bundles| |46727|New|Enh|2009-02-17|DefaultServlet - serving multiple encodings | |46902|New|Enh|2009-03-24|LoginValve to bypass restrictions of j_security_ch| |47214|New|Enh|2009-05-17|Inner classes that are explicitly referenced - sho| |47242|New|Enh|2009-05-22|request for AJP command line client | |47281|New|Enh|2009-05-28|Efficiency of the JDBCStore | |47407|New|Enh|2009-06-23|HttpSessionListener doesn't operate in the session| |47467|New|Enh|2009-07-02|Deployment of the war file by URL when contextpath| |47834|New|Enh|2009-09-14|TldConfig throws Exception when exploring unpacked| |47919|New|Enh|2009-09-30|Log Tomcat & Java environment variables in additio| |48358|Opn|Enh|2009-12-09|JSP-unloading reloaded| |48543|New|Enh|2010-01-14|[Patch] More flexibility in specifying -Dcatalina.| |48672|New|Enh|2010-02-03|Tomcat Virtual Host Manager (/host-manager) have b| |48674|New|Enh|2010-02-03|Tomcat Virtual Host Manager application doesn't pe| |48743|New|Enh|2010-02-15|Make the SLEEP variable in catalina.sh settable fr| |48899|New|Enh|2010-03-12|Guess URI charset should solve lot of problems| |48922|New|Enh|2010-03-16|org.apache.catalina.connector.Request clone static| |48928|New|Enh|2010-03-17|An alternative solution to preloading classes when| |49161|New|Enh|2010-04-21|Unknown Publisher when installing tomcat 6.0.26 | |49176|Opn|Enh|2010-04-23|Jasper in Dev Mode Is Memory Inefficient | |49464|New|Enh|2010-06-18|DefaultServlet and CharacterEncoding | |49531|New|Enh|2010-06-30|singlesignon failover not working on DeltaManager/| |49804|New|Enh|2010-08-23|Allow Embedded.redirectStreams value to be configu| |49939|New|Enh|2010-09-16|Expose a method via JMX which empties the webapp f| |49943|New|Enh|2010-09-16|Logging (via juli) does not reread configuration c| |50285|New|Enh|2010-11-17|Standard HTTP and AJP connectors silently ignore a| |50288|New|Enh|2010-11-17|Uploading a war file that already exists should au| |50692|
Bug report for Tomcat 7 [2013/02/17]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |16579|New|Enh|2003-01-30|documentation page layout/style breaks wrapping to| |18500|New|Enh|2003-03-30|Host aliases to match by regular expression | |28039|Opn|Enh|2004-03-30|Cluster Support for SingleSignOn | |40728|Inf|Enh|2006-10-11|Catalina MBeans use non-serializable classes | |40881|Opn|Enh|2006-11-02|Unable to receive message through TCP channel -> | |41007|Opn|Enh|2006-11-20|Can't define customized 503 error page| |43866|New|Enh|2007-11-14|add support for session attribute propagation with| |43925|Opn|Enh|2007-11-21|org.apache.jasper.runtime.BodyContentImpl causing | |44216|New|Enh|2008-01-11|Don't reuse session ID even if emptySessionPath=tr| |48550|Inf|Enh|2010-01-14|Update examples and default server.xml to use UTF-| |49395|New|Enh|2010-06-06|manager.findLeaks : display the date when the leak| |49589|New|Enh|2010-07-12|Tag handlers with constant attribute values are al| |49785|New|Enh|2010-08-19|Enabling TLS for JNDIRealm| |49821|New|Enh|2010-08-25|Tomcat CLI| |50019|New|Enh|2010-09-28|Adding JNDI "lookup-name" support In XML and Resou| |50175|New|Enh|2010-10-28|Enhance memory leak detection by selectively apply| |50234|New|Enh|2010-11-08|JspC use servlet 3.0 features | |50504|New|Enh|2010-12-21|Allow setting query string character set trough re| |50670|New|Enh|2011-01-27|Tribes | RpcChannel | Add option to specify extern| |51195|New|Enh|2011-05-13|"Find leaks" reports a false positive memory/class| |51294|Opn|Enh|2011-05-30|Since 7.0.12 do not work option unpackWARs=true fo| |51423|Inf|Enh|2011-06-23|[Patch] to add a path and a version parameters to | |51463|New|Enh|2011-07-01|Tomcat.setBaseDir (package org.apache.catalina.st| |51496|New|Enh|2011-07-11|NSIS - Warn that duplicate service name will resul| |51526|New|Enh|2011-07-18|Process web application context config with embedd| |51587|New|Enh|2011-07-29|Implement status and uptime commands | |51953|New|Enh|2011-10-04|Proposal: netmask filtering valve and filter | |52092|New|Enh|2011-10-26|Please make AsyncFileHandler and OneLineFormatter | |52235|New|Enh|2011-11-23|Please do a bit of SEO tuning for the web site| |52323|New|Enh|2011-12-13|Cobertura test code coverage support for build.xml| |52381|New|Enh|2011-12-22|Please add OSGi metadata | |52448|New|Enh|2012-01-11|Cache jar indexes in WebappClassLoader to speed up| |52489|New|Enh|2012-01-19|Enhancement request for code signing of war files | |52558|New|Enh|2012-01-30|CometConnectionManagerValve is adding non-serializ| |52688|New|Enh|2012-02-16|Add ability to remove old access log files| |52751|Opn|Enh|2012-02-23|Optimized configuration of the system info display| |52952|New|Enh|2012-03-20|Improve ExtensionValidator handling for embedded s| |53085|New|Enh|2012-04-16|[perf] [concurrency] DefaultInstanceManager.annota| |53387|New|Enh|2012-06-08|SSI: Allow to use $1 to get result of regular expr| |53411|Opn|Enh|2012-06-13|NullPointerException in org.apache.tomcat.util.buf| |53492|New|Enh|2012-07-01|Make JspC shell multithreaded | |53553|New|Enh|2012-07-16|[PATCH] Deploy uploaded WAR with context.xml from | |53602|New|Enh|2012-07-25|Support for HTTP status code 451 | |53620|New|Enh|2012-07-30|[juli] delay opening a file until something gets l| |53665|New|Enh|2012-08-06|Minor JNDI Howto document enhancement concerning m| |53776|New|Enh|2012-08-24|Multitenancy support for JDBCRealm| |53777|New|Enh|2012-08-24|Ability to bundle JAAS Configuration in Webappp | |53871|Opn|Enh|2012-09-14|java.lang.StackOverflowError on deploying a web ap| |54013|New|Enh|2012-10-16|Catalina.sh force kill to wait till process exits | |54083|New|Enh|2012-10-31|Provide jarsToSkip on a per-webapp basis | |54330|New|Enh|2012-12-19|Patch with some refactoring of Member.java| |54499|
Bug report for Tomcat Modules [2013/02/17]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |48240|New|Nor|2009-11-19|Tomcat-Lite missing @Override markers | |48268|New|Nor|2009-11-23|Patch to fix generics in tomcat-lite | |48861|New|Nor|2010-03-04|Files without AL headers | |49685|New|Nor|2010-08-02|Unsafe synchronization in class ManagedBean | |49686|New|Nor|2010-08-02|Using an instance lock to protect static shared da| |50571|Inf|Nor|2011-01-11|Tomcat 7 JDBC connection pool exception enhancemen| |51595|Inf|Nor|2011-08-01|org.apache.tomcat.jdbc.pool.jmx.ConnectionPool sho| |51879|Inf|Enh|2011-09-22|Improve access to Native Connection Methods | |52024|Inf|Enh|2011-10-13|Custom interceptor to support automatic failover o| |52318|Opn|Cri|2011-12-11|Version in tomcat-jdbc POM is conflicted with Vers| |53088|Opn|Min|2012-04-17|Give PoolCleaner TimerTask a better name | |53198|New|Cri|2012-05-07|'driverClassName' Data Source Property Being Manda| |53199|Inf|Enh|2012-05-07|Refactor ConnectionPool to use ScheduledExecutorSe| |53200|New|Enh|2012-05-07|Be able to use SlowQueryReport without reporting f| |53770|New|Enh|2012-08-23|tomcat-pool: always log validation query syntax er| |53853|New|Nor|2012-09-11|Can tomcat-jdbc consider Thread#getContextClassLoa| |53905|New|Nor|2012-09-19|Connection pool not reusing connections. | |53968|New|Nor|2012-10-04|Database password is exposed via JMX in getDbPrope| |54225|New|Nor|2012-11-30|if initSQL property is set to an empty string a Nu| |54227|New|Nor|2012-11-30|maxAge should be checked on borrow| |54235|New|Nor|2012-12-03|tomcat jdbc pool stackoverflow error used with spr| |54337|New|Nor|2012-12-21|StatementCache leaks statements/cursors | |54395|New|Nor|2013-01-09|JdbcInterceptor config parameter parsing errors | |54437|New|Enh|2013-01-16|Update PoolProperties javadoc for ConnectState int| |54537|New|Cri|2013-02-07|StatementFinalizer closeInvoked is too slow for la| +-+---+---+--+--+ | Total 25 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Tomcat Native [2013/02/17]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |46179|Opn|Maj|2008-11-10|apr ssl client authentication | |48655|Inf|Nor|2010-02-02|Active multipart downloads prevent tomcat shutdown| |49038|Inf|Nor|2010-04-02|Crash in tcnative | |51655|New|Nor|2011-08-12|Index page does not say what native does | |51813|New|Cri|2011-09-14|Tomcat randomly crashes with [libtcnative-1.so.1+0| |52153|New|Maj|2011-11-08|periodic JVM crash (access violation) on buffer fl| |52231|New|Nor|2011-11-23|Ant Tasks need to reflect changes in manager comma| |52319|New|Maj|2011-12-12|Tomcat 6 crashes with [libapr-1.so.0+0x196da] sig| |52627|New|Min|2012-02-08|Segmentation fault in org.apache.tomcat.jni.File.i| |53110|New|Cri|2012-04-20|Access Violation Error while creating SHM | |53605|New|Nor|2012-07-26|use tcnative-1.1.24 Tomcat shutdown still crash | |53847|Inf|Nor|2012-09-10|High CPU usage in tomcat native 1.22+ | |53937|New|Reg|2012-09-26|Double call to apr_pool_destroy() if OCSP checking| |53940|New|Enh|2012-09-27|Added support for new CRL loading after expiration| |53952|New|Nor|2012-10-02|Add support for TLS 1.1 and 1.2 | |54085|New|Nor|2012-11-01|ssl_socket_recv sometimes loops infinitely with no| +-+---+---+--+--+ | Total 16 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
