svn commit: r1446955 - in /tomcat/trunk/java/org/apache/jasper: servlet/JspCServletContext.java tagplugins/jstl/Util.java

[markt]

Author: markt
Date: Sat Feb 16 21:48:59 2013
New Revision: 1446955

URL: http://svn.apache.org/r1446955
Log:
UCDetector
 - use final
 - reduce visibility

Modified:
    tomcat/trunk/java/org/apache/jasper/servlet/JspCServletContext.java
    tomcat/trunk/java/org/apache/jasper/tagplugins/jstl/Util.java

Modified: tomcat/trunk/java/org/apache/jasper/servlet/JspCServletContext.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/servlet/JspCServletContext.java?rev=1446955&r1=1446954&r2=1446955&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/jasper/servlet/JspCServletContext.java 
(original)
+++ tomcat/trunk/java/org/apache/jasper/servlet/JspCServletContext.java Sat Feb 
16 21:48:59 2013
@@ -63,19 +63,19 @@ public class JspCServletContext implemen
     /**
      * Servlet context attributes.
      */
-    protected final Hashtable<String,Object> myAttributes;
+    private final Hashtable<String,Object> myAttributes;
 
 
     /**
      * The log writer we will write log messages to.
      */
-    protected final PrintWriter myLogWriter;
+    private final PrintWriter myLogWriter;
 
 
     /**
      * The base URL (document root) for this context.
      */
-    protected final URL myResourceBaseURL;
+    private final URL myResourceBaseURL;
 
 
     /**

Modified: tomcat/trunk/java/org/apache/jasper/tagplugins/jstl/Util.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/tagplugins/jstl/Util.java?rev=1446955&r1=1446954&r2=1446955&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/jasper/tagplugins/jstl/Util.java (original)
+++ tomcat/trunk/java/org/apache/jasper/tagplugins/jstl/Util.java Sat Feb 16 
21:48:59 2013
@@ -43,15 +43,16 @@ import org.apache.jasper.Constants;
 
 public class Util {
 
-    public static final String VALID_SCHEME_CHAR =
+    private static final String VALID_SCHEME_CHAR =
         "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789+.-";
 
     public static final String DEFAULT_ENCODING =
         "ISO-8859-1";
 
-    public static final int HIGHEST_SPECIAL = '>';
+    private static final int HIGHEST_SPECIAL = '>';
 
-    private static char[][] specialCharactersRepresentation = new 
char[HIGHEST_SPECIAL + 1][];
+    private static final char[][] specialCharactersRepresentation =
+               new char[HIGHEST_SPECIAL + 1][];
 
     static {
         specialCharactersRepresentation['&'] = "&amp;".toCharArray();
@@ -262,9 +263,9 @@ public class Util {
      */
     public static class ImportResponseWrapper extends 
HttpServletResponseWrapper{
 
-        private StringWriter sw = new StringWriter();
-        private ByteArrayOutputStream bos = new ByteArrayOutputStream();
-        private ServletOutputStream sos = new ServletOutputStream() {
+        private final StringWriter sw = new StringWriter();
+        private final ByteArrayOutputStream bos = new ByteArrayOutputStream();
+        private final ServletOutputStream sos = new ServletOutputStream() {
             @Override
             public void write(int b) throws IOException {
                 bos.write(b);



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org