DO NOT REPLY [Bug 48501] New: Log rotation for ISAPI Redirector
https://issues.apache.org/bugzilla/show_bug.cgi?id=48501 Summary: Log rotation for ISAPI Redirector Product: Tomcat Connectors Version: unspecified Platform: PC OS/Version: Mac OS X 10.4 Status: NEW Severity: enhancement Priority: P2 Component: isapi AssignedTo: dev@tomcat.apache.org ReportedBy: tim.whitting...@orionhealth.com Created an attachment (id=24810) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24810) PATCH - ISAPI Redirector with rotatelogs functionality Apache supports log rotation through piped logging to the rotatelogs program. Attached are patches to provide equivalent functionality in the IIS ISAPI Redirector. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48501] Log rotation for ISAPI Redirector
https://issues.apache.org/bugzilla/show_bug.cgi?id=48501 --- Comment #1 from Tim Whittington 2010-01-07 00:49:51 UTC --- Created an attachment (id=24811) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24811) PATCH - ISAPI Redirector doc updates -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [PROPOSAL] Log rotation in Tomcat Connector
Sounds interesting - I'd probably go with a similar approach if it was just me.
For our user base, IIS tends to equate to unsophisticated smaller IT shops, so
I'm aiming at a solution with as little moving parts as possible.
cheers
tim
- Original Message -
From: "Mladen Turk"
To: "Tomcat Developers List"
Sent: Thursday, 7 January, 2010 12:53:06 AM GMT +12:00 New Zealand
Subject: Re: [PROPOSAL] Log rotation in Tomcat Connector
On 01/06/2010 03:28 AM, Tim Whittington wrote:
>
> The downside of the rotatelogs approach is that it's not easy to do log
> pruning (since the filenames are based on the time the log rotates, rather
> than some kind of backup suffix scheme), so I may do nothing about that for
> now - the best I could do is keep a list in memory and prune, which is
> sub-optimal.
>
I have a modified Apache's logrotate that runs as a service
and listens on a pipe. Opening log files is then
fopen("PIPE\\.\\isapi_redirect_log")
The drawback is that additional service has to be installed
but it eliminates all the problems with process redirection
especially with multiple worker processes.
Also there is no need to change any of the current logging code
inside isapi_redirect.
Regards
--
^TM
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [PROPOSAL] Log rotation in Tomcat Connector
I've attached the initial implementation, along with a docs patch, to an issue
in Bugzilla.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48501
I managed to track down the crashing - I was referencing a jk_file_logger_t
that got deallocated when the log rotated, which IIS didn't like at all.
cheers
tim
- Original Message -
From: "Tim Whittington"
To: "Tomcat Developers List"
Sent: Wednesday, 6 January, 2010 3:28:47 PM GMT +12:00 New Zealand
Subject: Re: [PROPOSAL] Log rotation in Tomcat Connector
For consistency (with Apache at least) I've gone down the road of mirroring the
functionality of rotatelogs, which was fairly easy.
I'm doing some long running tests (I'm seeing some weird DLL unloading/crashing
behaviour in IIS 5.1 that I want to replicate and account for), but if that
works out I'll port the changes to trunk (I'm developing on JK_1_2_28 at the
moment for some reason) and submit a patch.
The downside of the rotatelogs approach is that it's not easy to do log pruning
(since the filenames are based on the time the log rotates, rather than some
kind of backup suffix scheme), so I may do nothing about that for now - the
best I could do is keep a list in memory and prune, which is sub-optimal.
cheers
tim
- Original Message -
From: "Rainer Jung"
To: "Tomcat Developers List"
Sent: Saturday, 19 December, 2009 1:01:53 AM GMT +12:00 New Zealand
Subject: Re: [PROPOSAL] Log rotation in Tomcat Connector
Hi Tim,
On 18.12.2009 03:26, Tim Whittington wrote:
> Hi all
>
> We're experiencing issues with the Tomcat Connector log in some IIS
> production sites where the log file grows to a very large size (8GB on one
> site).
> This is almost entirely due to connection errors between the front end and
> back end produced when the back-end Tomcat is restarted after crashes or for
> maintenance.
> (we have some very high request volume sites - some with hundreds of
> concurrent requests -, so you can get thousands of these errors on each
> restart).
>
> I'm thinking about implementing log file rotation in the IIS connector as a
> solution to this, and wanted to canvas opinions on alternatives and
> implementation first.
Good thing, that was open for a long time for the isapi redirector.
> What I intend implementing is:
> * Daily log file rolling (not configurable) as a clone of the log_to_file
> function (check rotation, close and reopen log file, continue)
> * Very simple configuration for a daily rolling file appender - basically
> 'on/off' and 'number of days to keep', possibly a single rotateable=bool/int
> parameter.
> * The log file name suffix will be appended/inserted to the name of the file
> specified in the connector config with a static pattern e.g. _MM_dd
> * The log method(s) will be guarded with a mutex to protect the rollover
> operation
> * I'll only be doing this for the ISAPI redirector at present (so won't need
> to refactor jk_mt.h to make the locking primitives available on prefork
> builds)
> * On rollover, the file will be closed and a new one opened. Older files will
> be pruned.
> * Rollover checking can be a simple mod operation on the timestamp (since I'm
> not intending to handle log formats)
>
> Questions I have:
> * Short of silencing the logging, is there an alternative to rolling the
> file? (perhaps rolling up of repeated connection errors?)
> * Are there any performance concerns about using a mutex on each log? (log4c
> uses this approach, so I presume it's not prohibitive)
> * Does anyone have any other input into config/behaviour?
Mutex
=
- log rotation for mod_jk with Apache is done using an external process
and logging through a pipe. The external process often used with Apache
is rotatelogs, that comes with apache and thus is also available under
ASL 2.0
- log path for Apache should not change seriously, e.g. no additional
mutex when running mod_jk inside Apache.
- for the redirector I'd say adding a mutex is OK, if it is acquired
after the log line has been formatted and immediately before the line
gets written to the file. So you'll only lock the access to the file.
In apache-2.0/mod_jk.c you will find for example jk_log_to_file(), which
does
rv = apr_global_mutex_lock(jk_log_lock);
if (rv != APR_SUCCESS) {
... log error via Apache ...
}
rv = apr_file_write(p->jklogfp, what, &wrote);
if (rv != APR_SUCCESS) {
... log error via Apache ...
}
rv = apr_global_mutex_unlock(jk_log_lock);
if (rv != APR_SUCCESS) {
... log error via Apache ...
}
Rolling
===
You could also think about doing the rolling externally like we do with
Apache and pipes in case the user configured a pipe as the log file. I'm
not sure about ISAPI and the IIS process management, whether this is
feasable, e.g. all IIS processes sharing the file descriptor to the pipe
etc.
Apart from that I think having a simple daily solution, which can be
activated or deact
DO NOT REPLY [Bug 48501] Log rotation for ISAPI Redirector
https://issues.apache.org/bugzilla/show_bug.cgi?id=48501 --- Comment #2 from Mladen Turk 2010-01-07 01:09:27 UTC --- _ftell_nlock does not exist with older MSVC versions. It was introduced with Visual Studio 2005 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48501] Log rotation for ISAPI Redirector
https://issues.apache.org/bugzilla/show_bug.cgi?id=48501 Tim Whittington changed: What|Removed |Added Attachment #24810|0 |1 is obsolete|| --- Comment #3 from Tim Whittington 2010-01-07 01:24:41 UTC --- Created an attachment (id=24812) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24812) PATCH - ISAPI Redirector with rotatelogs functionality Updated the patch to only use _ftell_nolock when available. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [PROPOSAL] Log rotation in Tomcat Connector
On 01/07/2010 09:56 AM, Tim Whittington wrote: I've attached the initial implementation, along with a docs patch, to an issue in Bugzilla. https://issues.apache.org/bugzilla/show_bug.cgi?id=48501 I managed to track down the crashing - I was referencing a jk_file_logger_t that got deallocated when the log rotated, which IIS didn't like at all. If you fix the MSVCRT80 dependency I have no problem with the patch. However the configuration should be as close to the Httpd's logrotate as possible. For _ftell_nolock I'd use LARGE_INTEGER li; HANDLE h = (HANDLE)_get_osfhandle(fileno(logfile)) GetFilesizeEx(h, &li) if (li.QuadPart ... ) _ftell_nolock has two drawbacks 1. Does not exist in MSVCRT.dll 2. It works for < 2GB files Regards -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r893452 - /tomcat/jk/trunk/native/common/jk_connect.c
This appears to have broken my build on Windows (VC 2005).
SHUT_RD is SD_RECEIVE on Windows?
cheers
tim
- Original Message -
From: mt...@apache.org
To: dev@tomcat.apache.org
Sent: Wednesday, 23 December, 2009 11:01:47 PM GMT +12:00 New Zealand
Subject: svn commit: r893452 - /tomcat/jk/trunk/native/common/jk_connect.c
Author: mturk
Date: Wed Dec 23 10:01:47 2009
New Revision: 893452
URL: http://svn.apache.org/viewvc?rev=893452&view=rev
Log:
Use smarter shutdown. In case we don't receive the full buffer break from loop.
This shoud lower down the shutdown to 2 sec max
Modified:
tomcat/jk/trunk/native/common/jk_connect.c
Modified: tomcat/jk/trunk/native/common/jk_connect.c
URL:
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/common/jk_connect.c?rev=893452&r1=893451&r2=893452&view=diff
==
--- tomcat/jk/trunk/native/common/jk_connect.c (original)
+++ tomcat/jk/trunk/native/common/jk_connect.c Wed Dec 23 10:01:47 2009
@@ -694,8 +694,8 @@
char dummy[512];
int rc = 0;
int rd = 0;
+ int rp = 0;
int save_errno;
- fd_set rs;
struct timeval tv;
time_t start = time(NULL);
@@ -722,10 +722,16 @@
return rc;
}
- /* Set up to wait for readable data on socket... */
- FD_ZERO(&rs);
-
do {
+#ifdef HAVE_POLL
+ struct pollfd fds;
+
+ fds.fd = sd;
+ fds.events = POLLIN;
+#else
+ fd_set rs;
+
+ FD_ZERO(&rs);
/* Read all data from the peer until we reach "end-of-file"
* (FIN from peer) or we've exceeded our overall timeout. If the
* backend does not send us bytes within 2 seconds
@@ -735,8 +741,14 @@
FD_SET(sd, &rs);
tv.tv_sec = SECONDS_TO_LINGER;
tv.tv_usec = 0;
-
- if (select((int)sd + 1, &rs, NULL, NULL, &tv) > 0) {
+#endif
+ rp = 0;
+#ifdef HAVE_POLL
+ if (poll(&fds, 1, SECONDS_TO_LINGER * 1000) > 0)
+#else
+ if (select((int)sd + 1, &rs, NULL, NULL, &tv) > 0)
+#endif
+ {
do {
#if defined(WIN32) || (defined(NETWARE) && defined(__NOVELL_LIBC__))
rc = recv(sd, &dummy[0], sizeof(dummy), 0);
@@ -746,7 +758,7 @@
rc = read(sd, &dummy[0], sizeof(dummy));
#endif
if (rc > 0)
- rd += rc;
+ rp += rc;
} while (JK_IS_SOCKET_ERROR(rc) && (errno == EINTR || errno == EAGAIN));
if (rc <= 0)
@@ -754,7 +766,27 @@
}
else
break;
-
+ rd += rp;
+ if (rp < sizeof(dummy)) {
+ /* We have readed less then size of buffer
+ * It's a good chance there will be no more data
+ * to read.
+ */
+ if ((rc = sononblock(sd))) {
+ rc = jk_close_socket(sd, l);
+ if (JK_IS_DEBUG_LEVEL(l))
+ jk_log(l, JK_LOG_DEBUG,
+ "error setting socket %d to nonblocking", sd);
+ errno = save_errno;
+ JK_TRACE_EXIT(l);
+ return rc;
+ }
+ if (JK_IS_DEBUG_LEVEL(l))
+ jk_log(l, JK_LOG_DEBUG,
+ "shutting down the read side of socket %d", sd);
+ shutdown(sd, SHUT_RD);
+ break;
+ }
} while (difftime(time(NULL), start) < MAX_SECS_TO_LINGER);
rc = jk_close_socket(sd, l);
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [PROPOSAL] Log rotation in Tomcat Connector
That looks better - will incorporate that. On the configuration I went for two properties with the same names as the Httpd rotatelogs params. The rotationtime option is identical in interpretation, and the filesize option doesn't have a trailing M as for rotatelogs (no need in our context, although we could handle it). cheers tim - Original Message - From: "Mladen Turk" To: "Tomcat Developers List" Sent: Thursday, 7 January, 2010 10:26:13 PM GMT +12:00 New Zealand Subject: Re: [PROPOSAL] Log rotation in Tomcat Connector On 01/07/2010 09:56 AM, Tim Whittington wrote: > I've attached the initial implementation, along with a docs patch, to an > issue in Bugzilla. > https://issues.apache.org/bugzilla/show_bug.cgi?id=48501 > > I managed to track down the crashing - I was referencing a jk_file_logger_t > that got deallocated when the log rotated, which IIS didn't like at all. > If you fix the MSVCRT80 dependency I have no problem with the patch. However the configuration should be as close to the Httpd's logrotate as possible. For _ftell_nolock I'd use LARGE_INTEGER li; HANDLE h = (HANDLE)_get_osfhandle(fileno(logfile)) GetFilesizeEx(h, &li) if (li.QuadPart ... ) _ftell_nolock has two drawbacks 1. Does not exist in MSVCRT.dll 2. It works for < 2GB files Regards -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r893452 - /tomcat/jk/trunk/native/common/jk_connect.c
This should fix it
Index: jk_connect.c
===
--- jk_connect.c (revision 896809)
+++ jk_connect.c (working copy)
@@ -678,6 +678,13 @@
#define SHUT_WR 0x01
#endif
#endif
+#ifndef SHUT_RD
+#ifdef SD_RECEIVE
+#define SHUT_RD SD_RECEIVE
+#else
+#define SHUT_RD 0x00
+#endif
+#endif
/** Drain and close the socket
* @param sd socket to close
- Original Message -
From: "Tim Whittington"
To: "Tomcat Developers List"
Sent: Thursday, 7 January, 2010 10:41:02 PM GMT +12:00 New Zealand
Subject: Re: svn commit: r893452 - /tomcat/jk/trunk/native/common/jk_connect.c
This appears to have broken my build on Windows (VC 2005).
SHUT_RD is SD_RECEIVE on Windows?
cheers
tim
- Original Message -
From: mt...@apache.org
To: dev@tomcat.apache.org
Sent: Wednesday, 23 December, 2009 11:01:47 PM GMT +12:00 New Zealand
Subject: svn commit: r893452 - /tomcat/jk/trunk/native/common/jk_connect.c
Author: mturk
Date: Wed Dec 23 10:01:47 2009
New Revision: 893452
URL: http://svn.apache.org/viewvc?rev=893452&view=rev
Log:
Use smarter shutdown. In case we don't receive the full buffer break from loop.
This shoud lower down the shutdown to 2 sec max
Modified:
tomcat/jk/trunk/native/common/jk_connect.c
Modified: tomcat/jk/trunk/native/common/jk_connect.c
URL:
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/common/jk_connect.c?rev=893452&r1=893451&r2=893452&view=diff
==
--- tomcat/jk/trunk/native/common/jk_connect.c (original)
+++ tomcat/jk/trunk/native/common/jk_connect.c Wed Dec 23 10:01:47 2009
@@ -694,8 +694,8 @@
char dummy[512];
int rc = 0;
int rd = 0;
+ int rp = 0;
int save_errno;
- fd_set rs;
struct timeval tv;
time_t start = time(NULL);
@@ -722,10 +722,16 @@
return rc;
}
- /* Set up to wait for readable data on socket... */
- FD_ZERO(&rs);
-
do {
+#ifdef HAVE_POLL
+ struct pollfd fds;
+
+ fds.fd = sd;
+ fds.events = POLLIN;
+#else
+ fd_set rs;
+
+ FD_ZERO(&rs);
/* Read all data from the peer until we reach "end-of-file"
* (FIN from peer) or we've exceeded our overall timeout. If the
* backend does not send us bytes within 2 seconds
@@ -735,8 +741,14 @@
FD_SET(sd, &rs);
tv.tv_sec = SECONDS_TO_LINGER;
tv.tv_usec = 0;
-
- if (select((int)sd + 1, &rs, NULL, NULL, &tv) > 0) {
+#endif
+ rp = 0;
+#ifdef HAVE_POLL
+ if (poll(&fds, 1, SECONDS_TO_LINGER * 1000) > 0)
+#else
+ if (select((int)sd + 1, &rs, NULL, NULL, &tv) > 0)
+#endif
+ {
do {
#if defined(WIN32) || (defined(NETWARE) && defined(__NOVELL_LIBC__))
rc = recv(sd, &dummy[0], sizeof(dummy), 0);
@@ -746,7 +758,7 @@
rc = read(sd, &dummy[0], sizeof(dummy));
#endif
if (rc > 0)
- rd += rc;
+ rp += rc;
} while (JK_IS_SOCKET_ERROR(rc) && (errno == EINTR || errno == EAGAIN));
if (rc <= 0)
@@ -754,7 +766,27 @@
}
else
break;
-
+ rd += rp;
+ if (rp < sizeof(dummy)) {
+ /* We have readed less then size of buffer
+ * It's a good chance there will be no more data
+ * to read.
+ */
+ if ((rc = sononblock(sd))) {
+ rc = jk_close_socket(sd, l);
+ if (JK_IS_DEBUG_LEVEL(l))
+ jk_log(l, JK_LOG_DEBUG,
+ "error setting socket %d to nonblocking", sd);
+ errno = save_errno;
+ JK_TRACE_EXIT(l);
+ return rc;
+ }
+ if (JK_IS_DEBUG_LEVEL(l))
+ jk_log(l, JK_LOG_DEBUG,
+ "shutting down the read side of socket %d", sd);
+ shutdown(sd, SHUT_RD);
+ break;
+ }
} while (difftime(time(NULL), start) < MAX_SECS_TO_LINGER);
rc = jk_close_socket(sd, l);
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48503] New: org.apache.tomcat.dbcp.dbcp.SQLNestedException: Cannot load JDBC driver class 'com.mysql.jdbc.Driver'
https://issues.apache.org/bugzilla/show_bug.cgi?id=48503 Summary: org.apache.tomcat.dbcp.dbcp.SQLNestedException: Cannot load JDBC driver class 'com.mysql.jdbc.Driver' Product: Tomcat 5 Version: 5.5.20 Platform: PC OS/Version: Windows Server 2003 Status: NEW Severity: critical Priority: P2 Component: Unknown AssignedTo: dev@tomcat.apache.org ReportedBy: rameshraod@gmail.com Created an attachment (id=24813) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24813) My Server log file getting these kind of errors HI, When i start my server manually thru "tomcat5" tool. It is giving some other error like: "Cannot rename original file to 'path:\\tomcat-users.xml.old'. I am unable to resolve this problem since one week. I too searched in different forums. But no use. Kindly help regarding this. My Environment variable settings are: CLASS_PATH: C:\Program Files\Java\jre6\lib\rt.jar;C:\Program Files\Apache Software Foundation\Tomcat 5.5\common\lib\servlet-api.jar;C:\Program Files\Apache Software Foundation\Tomcat 5.5\common\lib\jsp-api.jar;\C:\Program Files\Apache Software Foundation\Tomcat 5.5\common\lib\rti.jar;C:\Program Files\Apache Software Foundation\Tomcat 5.5\common\lib\mysql-connector-java-3.0.11-stable-bin.jar; Versions of Java and Tomcat are: Java: C:\Program Files\Java\jdk1.6.0_16; Tomcat: C:\Program Files\Apache Software Foundation\Tomcat 5.5; -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48503] org.apache.tomcat.dbcp.dbcp.SQLNestedException: Cannot load JDBC driver class 'com.mysql.jdbc.Driver'
https://issues.apache.org/bugzilla/show_bug.cgi?id=48503 Ramesh Rao changed: What|Removed |Added Attachment #24813|My Server log file getting |org.apache.tomcat.dbcp.dbcp description|these kind of errors|.SQLNestedException: Cannot ||load JDBC driver class ||'com.mysql.jdbc.Driver' -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48504] New: Disabling redirecting System.out and System.err
https://issues.apache.org/bugzilla/show_bug.cgi?id=48504 Summary: Disabling redirecting System.out and System.err Product: Tomcat 6 Version: 6.0.20 Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Priority: P2 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: michal.pad...@gmail.com I am unable to set redirectStreams to false. I need to write in my webapps log4j to stderr but when starting Catalina, stderr is redirected to stdout (Catalina.initStreams()). I am not running Tomcat as embedded. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48503] org.apache.tomcat.dbcp.dbcp.SQLNestedException: Cannot load JDBC driver class 'com.mysql.jdbc.Driver'
https://issues.apache.org/bugzilla/show_bug.cgi?id=48503 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Comment #1 from Mark Thomas 2010-01-07 03:33:19 GMT --- Bugzilla is not a support forum. Please use the Tomcat users mailing list. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48504] Disabling redirecting System.out and System.err
https://issues.apache.org/bugzilla/show_bug.cgi?id=48504 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Comment #1 from Mark Thomas 2010-01-07 03:34:24 GMT --- Bugzilla is not a support forum. Please direct your question to the Tomcat users mailing list. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [PROPOSAL] Log rotation in Tomcat Connector
On 01/07/2010 10:49 AM, Tim Whittington wrote: That looks better - will incorporate that. Not sure why are you using ftell_nolock We already have a problem with ISS logging because multiple processes (IIS 6+) can write to a single log file. On the configuration I went for two properties with the same names as the Httpd rotatelogs params. The rotationtime option is identical in interpretation, and the filesize option doesn't have a trailing M as for rotatelogs (no need in our context, although we could handle it). Also use 64 bit versions of _ftelli64 and unsigned int64 instead long for log_file_size E.g. If the config for log_file size is 3000 then you will have 2^31 - (3000 * 1000 * 1000) -1 == -852516352 for log file size. Regards -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[REMIND] Re: [VOTE] Release Apache Tomcat Native 1.1.19
Apache Tomcat Native 1.1.19 is: I know it's a pickle season, and you guys are all busy digesting Christmas and New Year eve's meals, but can I have some votes here :) The difference between released 1.1.18 is trivial, like explained in the proposal, so you'll be voting on package rather then functionality. Cheers -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [REMIND] Re: [VOTE] Release Apache Tomcat Native 1.1.19
On 01/07/2010 01:01 PM, Mladen Turk wrote: >> >> Apache Tomcat Native 1.1.19 is: >> > > I know it's a pickle season, and you guys > are all busy digesting Christmas and New Year eve's > meals, but can I have some votes here :) Yep, I am still wasted (my stomach at least). +1 I had some problems to get my remote macosx box to run but it is ok on all the platforms I am able to test. Cheers Jean-Frederic - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Tomcat-Lite update
2010/1/6 Mark Thomas : > On 06/01/2010 00:27, Costin Manolache wrote: >> Also, I would like to know if other comitters are OK with (temporarily - >> i.e. until the 7.0 release vote) including lite in the tomcat7 builds, >> so people can try it out. > > How about adding it to the extras build? It could be included in the > release then as well. > > Mark > +1 for extras Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r896892 - in /tomcat/trunk/java/org/apache/jasper: compiler/Validator.java resources/LocalStrings.properties resources/LocalStrings_es.properties
Author: markt
Date: Thu Jan 7 14:20:30 2010
New Revision: 896892
URL: http://svn.apache.org/viewvc?rev=896892&view=rev
Log:
Update for JSP 2.2
Modified:
tomcat/trunk/java/org/apache/jasper/compiler/Validator.java
tomcat/trunk/java/org/apache/jasper/resources/LocalStrings.properties
tomcat/trunk/java/org/apache/jasper/resources/LocalStrings_es.properties
Modified: tomcat/trunk/java/org/apache/jasper/compiler/Validator.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/compiler/Validator.java?rev=896892&r1=896891&r2=896892&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/compiler/Validator.java (original)
+++ tomcat/trunk/java/org/apache/jasper/compiler/Validator.java Thu Jan 7
14:20:30 2010
@@ -518,7 +518,8 @@
public void visit(Node.JspRoot n) throws JasperException {
JspUtil.checkAttributes("Jsp:root", n, jspRootAttrs, err);
String version = n.getTextAttribute("version");
-if (!version.equals("1.2") && !version.equals("2.0") &&
!version.equals("2.1")) {
+if (!version.equals("1.2") && !version.equals("2.0") &&
+!version.equals("2.1") && !version.equals("2.2")) {
err.jspError(n, "jsp.error.jsproot.version.invalid", version);
}
visitBody(n);
Modified: tomcat/trunk/java/org/apache/jasper/resources/LocalStrings.properties
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/resources/LocalStrings.properties?rev=896892&r1=896891&r2=896892&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/resources/LocalStrings.properties
(original)
+++ tomcat/trunk/java/org/apache/jasper/resources/LocalStrings.properties Thu
Jan 7 14:20:30 2010
@@ -427,7 +427,7 @@
jsp.error.variable.alias=Both or none of the name-from-attribute and alias
attributes must be specified in a variable directive
jsp.error.attribute.null_name=Null attribute name
jsp.error.jsptext.badcontent=\'<\', when appears in the body of
, must be encapsulated within a CDATA
-jsp.error.jsproot.version.invalid=Invalid version number: \"{0}\", must be
\"1.2\", \"2.0\", or \"2.1\"
+jsp.error.jsproot.version.invalid=Invalid version number: \"{0}\", must be
\"1.2\", \"2.0\", \"2.1\" or \"2.2\"
jsp.error.noFunctionPrefix=The function {0} must be used with a prefix when a
default namespace is not specified
jsp.error.noFunction=The function {0} cannot be located with the specified
prefix
jsp.error.noFunctionMethod=Method \"{0}\" for function \"{1}\" not found in
class \"{2}\"
Modified:
tomcat/trunk/java/org/apache/jasper/resources/LocalStrings_es.properties
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/resources/LocalStrings_es.properties?rev=896892&r1=896891&r2=896892&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/resources/LocalStrings_es.properties
(original)
+++ tomcat/trunk/java/org/apache/jasper/resources/LocalStrings_es.properties
Thu Jan 7 14:20:30 2010
@@ -430,7 +430,7 @@
jsp.error.variable.alias = Ambos atributos o ninguno de name-from-attribute y
alias pueden ser especificados en una directiva variable
jsp.error.attribute.null_name = Nombre de atributo nulo
jsp.error.jsptext.badcontent = '<', cuando aparece en el cuerpo de
, debe de estar encapsulado dentro de un CDATA
-jsp.error.jsproot.version.invalid = N\u00FAmero incorrecto de versi\u00F3n\:
"{0}", debe de ser "1.2" o "2.0" o "2.1"
+jsp.error.jsproot.version.invalid = N\u00FAmero incorrecto de versi\u00F3n\:
"{0}", debe de ser "1.2" o "2.0" o "2.1" o "2.2"
jsp.error.noFunctionPrefix = La funci\u00F3n {0} debe de usarse con un prefijo
cuando no se especifica un espacio de nombres por defecto
jsp.error.noFunction = La funci\u00F3n {0} no puede ser localizada mediante el
prefijo especificado
jsp.error.noFunctionMethod = El m\u00E9todo "{0}" para la funci\u00F3n "{1}"
no se pudo hallar en la clase "{2}"
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r896899 - in /tomcat/tc6.0.x/trunk: ./ RUNNING.txt
Author: kkolinko Date: Thu Jan 7 15:05:58 2010 New Revision: 896899 URL: http://svn.apache.org/viewvc?rev=896899&view=rev Log: Add missing svn:keywords Modified: tomcat/tc6.0.x/trunk/ (props changed) tomcat/tc6.0.x/trunk/RUNNING.txt (contents, props changed) Propchange: tomcat/tc6.0.x/trunk/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Thu Jan 7 15:05:58 2010 @@ -1,2 +1,2 @@ /tomcat:883362 -/tomcat/trunk:601180,606992,612607,630314,640888,652744,653247,666232,673796,673820,677910,683969,683982,684001,684081,684234,684269-684270,685177,687503,687645,689402,690781,691392,691805,692748,693378,694992,695053,695311,696780,696782,698012,698227,698236,698613,699427,699634,701355,709294,709811,709816,710063,710066,710125,710205,711126,711600,712461,712467,713953,714002,718360,719119,719124,719602,719626,719628,720046,720069,721040,721286,721708,721886,723404,723738,726052,727303,728032,728768,728947,729057,729567,729569,729571,729681,729809,729815,729934,730250,730590,731651,732859,732863,734734,740675,740684,742677,742697,742714,744160,744238,746321,746384,746425,747834,747863,748344,750258,750291,750921,751286-751287,751289,751295,753039,757335,757774,758249,758365,758596,758616,758664,759074,761601,762868,762929,762936-762937,763166,763183,763193,763228,763262,763298,763302,763325,763599,763611,763654,763681,763706,764985,764997,765662,768335,769979,770716,770809,77 0876,772872,776921,776924,776935,776945,777464,777466,777576,777625,778379,778523-778524,781528,781779,782145,782791,783316,783696,783724,783756,783762,783766,783863,783934,784453,784602,784614,785381,785688,785768,785859,786468,786487,786490,786496,786667,787627,787770,787985,789389,790405,791041,791184,791194,791224,791243,791326,791328,791789,792740,793372,793757,793882,793981,794082,794673,794822,795043,795152,795210,795457,795466,797168,797425,797596,797607,802727,802940,804462,804544,804734,805153,809131,809603,810916,810977,812125,812137,812432,813001,813013,813866,814180,814708,814876,815972,816252,817442,817822,819339,819361,820110,820132,820874,820954,821397,828196,828201,828210,828225,828759,830378-830379,830999,831106,831774,831785,831828,831850,831860,832214,832218,833121,833545,834047,835036,835336,836405,881396,881412,883130,883134,883146,883165,883177,883362,883565,884341,885038,885231,885241,885260,885901,885991,886019,888072,889363,889606,889716,890139,8902 65,890349-890350,890417,891185-891187,891583,892198,892341,892415,892464,892555,892812,892814,892817,892843,892887,893321,893493,894580,894586,894805,894831,895013,895045,895057,896370,896384 +/tomcat/trunk:601180,606992,612607,630314,640888,652744,653247,666232,673796,673820,677910,683969,683982,684001,684081,684234,684269-684270,685177,687503,687645,689402,690781,691392,691805,692748,693378,694992,695053,695311,696780,696782,698012,698227,698236,698613,699427,699634,701355,709294,709811,709816,710063,710066,710125,710205,711126,711600,712461,712467,713953,714002,718360,719119,719124,719602,719626,719628,720046,720069,721040,721286,721708,721886,723404,723738,726052,727303,728032,728768,728947,729057,729567,729569,729571,729681,729809,729815,729934,730250,730590,731651,732859,732863,734734,740675,740684,742677,742697,742714,744160,744238,746321,746384,746425,747834,747863,748344,750258,750291,750921,751286-751287,751289,751295,753039,757335,757774,758249,758365,758596,758616,758664,759074,761601,762868,762929,762936-762937,763166,763183,763193,763228,763262,763298,763302,763325,763599,763611,763654,763681,763706,764985,764997,765662,768335,769979,770716,770809,77 0876,772872,776921,776924,776935,776945,777464,777466,777576,777625,778379,778523-778524,781528,781779,782145,782791,783316,783696,783724,783756,783762,783766,783863,783934,784453,784602,784614,785381,785688,785768,785859,786468,786487,786490,786496,786667,787627,787770,787985,789389,790405,791041,791184,791194,791224,791243,791326,791328,791789,792740,793372,793757,793882,793981,794082,794673,794822,795043,795152,795210,795457,795466,797168,797425,797596,797607,802727,802940,804462,804544,804734,805153,809131,809603,810916,810977,812125,812137,812432,813001,813013,813866,814180,814708,814876,815972,816252,817442,817822,819339,819361,820110,820132,820874,820954,821397,828196,828201,828210,828225,828759,830378-830379,830999,831106,831774,831785,831828,831850,831860,832214,832218,833121,833545,834047,835036,835336,836405,881396,881412,883130,883134,883146,883165,883177,883362,883565,884341,885038,885231,885241,885260,885901,885991,886019,888072,889363,889606,889716,890139,8902 65,890349-890350,890417,891185-891187,891583,892198,892341,892415,892464,892555,892812,892814,892817,892843,892887,893321,893493,894580,894586,894805,894831,895013,895045,895057,895191,895392,896370,896384 Modified: tomcat/tc6.0.x/trunk/RUNNING.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/RUNNING.txt?rev=896899&r1=896898&r2=896
svn commit: r896902 - /tomcat/tc6.0.x/trunk/
Author: kkolinko Date: Thu Jan 7 15:25:35 2010 New Revision: 896902 URL: http://svn.apache.org/viewvc?rev=896902&view=rev Log: mergeinfo change in r896899 was not intentional, undoing it. (removing ",895191,895392" that were added) Modified: tomcat/tc6.0.x/trunk/ (props changed) Propchange: tomcat/tc6.0.x/trunk/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Thu Jan 7 15:25:35 2010 @@ -1,2 +1,2 @@ /tomcat:883362 -/tomcat/trunk:601180,606992,612607,630314,640888,652744,653247,666232,673796,673820,677910,683969,683982,684001,684081,684234,684269-684270,685177,687503,687645,689402,690781,691392,691805,692748,693378,694992,695053,695311,696780,696782,698012,698227,698236,698613,699427,699634,701355,709294,709811,709816,710063,710066,710125,710205,711126,711600,712461,712467,713953,714002,718360,719119,719124,719602,719626,719628,720046,720069,721040,721286,721708,721886,723404,723738,726052,727303,728032,728768,728947,729057,729567,729569,729571,729681,729809,729815,729934,730250,730590,731651,732859,732863,734734,740675,740684,742677,742697,742714,744160,744238,746321,746384,746425,747834,747863,748344,750258,750291,750921,751286-751287,751289,751295,753039,757335,757774,758249,758365,758596,758616,758664,759074,761601,762868,762929,762936-762937,763166,763183,763193,763228,763262,763298,763302,763325,763599,763611,763654,763681,763706,764985,764997,765662,768335,769979,770716,770809,77 0876,772872,776921,776924,776935,776945,777464,777466,777576,777625,778379,778523-778524,781528,781779,782145,782791,783316,783696,783724,783756,783762,783766,783863,783934,784453,784602,784614,785381,785688,785768,785859,786468,786487,786490,786496,786667,787627,787770,787985,789389,790405,791041,791184,791194,791224,791243,791326,791328,791789,792740,793372,793757,793882,793981,794082,794673,794822,795043,795152,795210,795457,795466,797168,797425,797596,797607,802727,802940,804462,804544,804734,805153,809131,809603,810916,810977,812125,812137,812432,813001,813013,813866,814180,814708,814876,815972,816252,817442,817822,819339,819361,820110,820132,820874,820954,821397,828196,828201,828210,828225,828759,830378-830379,830999,831106,831774,831785,831828,831850,831860,832214,832218,833121,833545,834047,835036,835336,836405,881396,881412,883130,883134,883146,883165,883177,883362,883565,884341,885038,885231,885241,885260,885901,885991,886019,888072,889363,889606,889716,890139,8902 65,890349-890350,890417,891185-891187,891583,892198,892341,892415,892464,892555,892812,892814,892817,892843,892887,893321,893493,894580,894586,894805,894831,895013,895045,895057,895191,895392,896370,896384 +/tomcat/trunk:601180,606992,612607,630314,640888,652744,653247,666232,673796,673820,677910,683969,683982,684001,684081,684234,684269-684270,685177,687503,687645,689402,690781,691392,691805,692748,693378,694992,695053,695311,696780,696782,698012,698227,698236,698613,699427,699634,701355,709294,709811,709816,710063,710066,710125,710205,711126,711600,712461,712467,713953,714002,718360,719119,719124,719602,719626,719628,720046,720069,721040,721286,721708,721886,723404,723738,726052,727303,728032,728768,728947,729057,729567,729569,729571,729681,729809,729815,729934,730250,730590,731651,732859,732863,734734,740675,740684,742677,742697,742714,744160,744238,746321,746384,746425,747834,747863,748344,750258,750291,750921,751286-751287,751289,751295,753039,757335,757774,758249,758365,758596,758616,758664,759074,761601,762868,762929,762936-762937,763166,763183,763193,763228,763262,763298,763302,763325,763599,763611,763654,763681,763706,764985,764997,765662,768335,769979,770716,770809,77 0876,772872,776921,776924,776935,776945,777464,777466,777576,777625,778379,778523-778524,781528,781779,782145,782791,783316,783696,783724,783756,783762,783766,783863,783934,784453,784602,784614,785381,785688,785768,785859,786468,786487,786490,786496,786667,787627,787770,787985,789389,790405,791041,791184,791194,791224,791243,791326,791328,791789,792740,793372,793757,793882,793981,794082,794673,794822,795043,795152,795210,795457,795466,797168,797425,797596,797607,802727,802940,804462,804544,804734,805153,809131,809603,810916,810977,812125,812137,812432,813001,813013,813866,814180,814708,814876,815972,816252,817442,817822,819339,819361,820110,820132,820874,820954,821397,828196,828201,828210,828225,828759,830378-830379,830999,831106,831774,831785,831828,831850,831860,832214,832218,833121,833545,834047,835036,835336,836405,881396,881412,883130,883134,883146,883165,883177,883362,883565,884341,885038,885231,885241,885260,885901,885991,886019,888072,889363,889606,889716,890139,8902 65,890349-890350,890417,891185-891187,891583,892198,892341,892415,892464,892555,892812,892814,892817,892843,892887,893321,893493,894580,894586,894805,894831,895013,895045,895057,896370,896384 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apac
svn commit: r896913 - in /tomcat/trunk/test: org/apache/el/ org/apache/jasper/ org/apache/jasper/compiler/ webapp/ webapp/WEB-INF/ webapp/WEB-INF/tags/
Author: markt
Date: Thu Jan 7 16:06:45 2010
New Revision: 896913
URL: http://svn.apache.org/viewvc?rev=896913&view=rev
Log:
Add various EL test cases, mostly extracted from local test JSPs I have used
for individual issues.
Thanks to kkolinko and the numerous bug reporters that provided the basis for
many of these.
At present, although this is Tomcat 7, the tests only cover JSP 2.1
functionality.
Added:
tomcat/trunk/test/org/apache/el/TestELInJsp.java (with props)
tomcat/trunk/test/org/apache/el/TesterFunctions.java (with props)
tomcat/trunk/test/org/apache/jasper/
tomcat/trunk/test/org/apache/jasper/compiler/
tomcat/trunk/test/org/apache/jasper/compiler/TestGenerator.java (with
props)
tomcat/trunk/test/org/apache/jasper/compiler/TestValidator.java (with
props)
tomcat/trunk/test/webapp/
tomcat/trunk/test/webapp/WEB-INF/
tomcat/trunk/test/webapp/WEB-INF/tags/
tomcat/trunk/test/webapp/WEB-INF/tags/echo-double.tag (with props)
tomcat/trunk/test/webapp/WEB-INF/tags/echo-long.tag (with props)
tomcat/trunk/test/webapp/WEB-INF/tags/echo.tag (with props)
tomcat/trunk/test/webapp/WEB-INF/test.tld (with props)
tomcat/trunk/test/webapp/WEB-INF/web.xml (with props)
tomcat/trunk/test/webapp/bug42565.jsp (with props)
tomcat/trunk/test/webapp/bug44994.jsp (with props)
tomcat/trunk/test/webapp/bug45015a.jsp (with props)
tomcat/trunk/test/webapp/bug45015b.jsp (with props)
tomcat/trunk/test/webapp/bug45427.jsp (with props)
tomcat/trunk/test/webapp/bug45451.jspf (with props)
tomcat/trunk/test/webapp/bug45451a.jsp (with props)
tomcat/trunk/test/webapp/bug45451b.jsp (with props)
tomcat/trunk/test/webapp/bug45451c.jsp (with props)
tomcat/trunk/test/webapp/bug45451d.jspx (with props)
tomcat/trunk/test/webapp/bug45511.jsp (with props)
tomcat/trunk/test/webapp/bug46381.jsp (with props)
tomcat/trunk/test/webapp/bug46596.jsp (with props)
tomcat/trunk/test/webapp/bug47331.jsp (with props)
tomcat/trunk/test/webapp/bug47413.jsp (with props)
tomcat/trunk/test/webapp/bug48112.jsp (with props)
tomcat/trunk/test/webapp/el-misc.jsp (with props)
Modified:
tomcat/trunk/test/org/apache/el/TestELEvaluation.java
Modified: tomcat/trunk/test/org/apache/el/TestELEvaluation.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/el/TestELEvaluation.java?rev=896913&r1=896912&r2=896913&view=diff
==
--- tomcat/trunk/test/org/apache/el/TestELEvaluation.java (original)
+++ tomcat/trunk/test/org/apache/el/TestELEvaluation.java Thu Jan 7 16:06:45
2010
@@ -137,7 +137,7 @@
if ("trim".equals(localName)) {
Method m;
try {
-m = this.getClass().getMethod("trim", String.class);
+m = TesterFunctions.class.getMethod("trim", String.class);
return m;
} catch (SecurityException e) {
// Ignore
@@ -147,9 +147,5 @@
}
return null;
}
-
-public static String trim(String input) {
-return input.trim();
-}
}
}
Added: tomcat/trunk/test/org/apache/el/TestELInJsp.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/el/TestELInJsp.java?rev=896913&view=auto
==
--- tomcat/trunk/test/org/apache/el/TestELInJsp.java (added)
+++ tomcat/trunk/test/org/apache/el/TestELInJsp.java Thu Jan 7 16:06:45 2010
@@ -0,0 +1,276 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.el;
+
+import java.io.File;
+
+import org.apache.catalina.startup.Tomcat;
+import org.apache.catalina.startup.TomcatBaseTest;
+import org.apache.tomcat.util.buf.ByteChunk;
+
+public class TestELInJsp extends TomcatBaseTest {
+
+public void testBug42565() throws Exception {
+Tomcat tomcat = getTomcatInstance();
+
+File appDir =
+new File("test/webapp");
+// app dir is relative to server home
+tomcat.addWebapp(nu
Re: svn commit: r896913 - in /tomcat/trunk/test: org/apache/el/ org/apache/jasper/ org/apache/jasper/compiler/ webapp/ webapp/WEB-INF/ webapp/WEB-INF/tags/
On 07/01/2010 16:08, ma...@apache.org wrote: > Author: markt > Date: Thu Jan 7 16:06:45 2010 > New Revision: 896913 > > URL: http://svn.apache.org/viewvc?rev=896913&view=rev > Log: > Add various EL test cases, mostly extracted from local test JSPs I have used > for individual issues. > Thanks to kkolinko and the numerous bug reporters that provided the basis for > many of these. > At present, although this is Tomcat 7, the tests only cover JSP 2.1 > functionality. Note some of these tests currently fail. I am working on fixing the tests, Jasper or the EL as appropriate. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r896916 - in /tomcat/trunk/test: org/apache/jasper/compiler/ webapp/ webapp/WEB-INF/tags/
Author: markt
Date: Thu Jan 7 16:22:24 2010
New Revision: 896916
URL: http://svn.apache.org/viewvc?rev=896916&view=rev
Log:
Add missing license headers
Modified:
tomcat/trunk/test/org/apache/jasper/compiler/TestGenerator.java
tomcat/trunk/test/org/apache/jasper/compiler/TestValidator.java
tomcat/trunk/test/webapp/WEB-INF/tags/echo-double.tag
tomcat/trunk/test/webapp/WEB-INF/tags/echo-long.tag
tomcat/trunk/test/webapp/WEB-INF/tags/echo.tag
tomcat/trunk/test/webapp/bug45451.jspf
tomcat/trunk/test/webapp/bug45451b.jsp
tomcat/trunk/test/webapp/bug45451c.jsp
tomcat/trunk/test/webapp/bug45451d.jspx
Modified: tomcat/trunk/test/org/apache/jasper/compiler/TestGenerator.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/jasper/compiler/TestGenerator.java?rev=896916&r1=896915&r2=896916&view=diff
==
--- tomcat/trunk/test/org/apache/jasper/compiler/TestGenerator.java (original)
+++ tomcat/trunk/test/org/apache/jasper/compiler/TestGenerator.java Thu Jan 7
16:22:24 2010
@@ -1,3 +1,20 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
package org.apache.jasper.compiler;
import java.io.File;
Modified: tomcat/trunk/test/org/apache/jasper/compiler/TestValidator.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/jasper/compiler/TestValidator.java?rev=896916&r1=896915&r2=896916&view=diff
==
--- tomcat/trunk/test/org/apache/jasper/compiler/TestValidator.java (original)
+++ tomcat/trunk/test/org/apache/jasper/compiler/TestValidator.java Thu Jan 7
16:22:24 2010
@@ -1,3 +1,20 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
package org.apache.jasper.compiler;
import java.io.File;
Modified: tomcat/trunk/test/webapp/WEB-INF/tags/echo-double.tag
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/webapp/WEB-INF/tags/echo-double.tag?rev=896916&r1=896915&r2=896916&view=diff
==
--- tomcat/trunk/test/webapp/WEB-INF/tags/echo-double.tag (original)
+++ tomcat/trunk/test/webapp/WEB-INF/tags/echo-double.tag Thu Jan 7 16:22:24
2010
@@ -1,3 +1,19 @@
+<%--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+--%>
<%@ tag %><%@
attribute name="echo" type="java.lang.Double"%><%@
attribute name="index" type="java.lang.String" %>${index}-${echo}
\ No newline at end of file
Modified: tomcat/trunk/test/webapp/WEB-INF/tags/echo-long.tag
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/webapp/WEB-INF/tags/echo-long.tag?rev=896916&r1=896915&r2=896916&view=diff
===
svn commit: r896920 - /tomcat/trunk/test/org/apache/el/TestELInJsp.java
Author: markt
Date: Thu Jan 7 16:35:49 2010
New Revision: 896920
URL: http://svn.apache.org/viewvc?rev=896920&view=rev
Log:
Remove comments
Modified:
tomcat/trunk/test/org/apache/el/TestELInJsp.java
Modified: tomcat/trunk/test/org/apache/el/TestELInJsp.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/el/TestELInJsp.java?rev=896920&r1=896919&r2=896920&view=diff
==
--- tomcat/trunk/test/org/apache/el/TestELInJsp.java (original)
+++ tomcat/trunk/test/org/apache/el/TestELInJsp.java Thu Jan 7 16:35:49 2010
@@ -121,7 +121,7 @@
tomcat.start();
-ByteChunk res = /* getUrl("http://localhost:"; + getPort() +
+ByteChunk res = getUrl("http://localhost:"; + getPort() +
"/test/bug45451a.jsp");
String result = res.toString();
@@ -131,8 +131,8 @@
assertTrue(result.indexOf("02-\\'hello world\\'") > 0);
assertTrue(result.indexOf("03-\\'hello world\\'") > 0);
-res = */ getUrl("http://localhost:"; + getPort() +
"/test/bug45451b.jsp");
-String result = res.toString();
+res = getUrl("http://localhost:"; + getPort() + "/test/bug45451b.jsp");
+result = res.toString();
// Warning: JSP attribute escaping != Java String escaping
assertTrue(result.indexOf("00-2") > 0);
assertTrue(result.indexOf("01-${1+1}") > 0);
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Tomcat-Lite update
On Wed, Jan 6, 2010 at 12:13 AM, Mark Thomas wrote: > On 06/01/2010 00:27, Costin Manolache wrote: > > Also, I would like to know if other comitters are OK with (temporarily - > > i.e. until the 7.0 release vote) including lite in the tomcat7 builds, > > so people can try it out. > > How about adding it to the extras build? It could be included in the > release then as well. > > Sounds good, thanks for the suggestions. On the building part - tomcat-lite supports both maven and ant, and the ant build is using ivy to download the deps - I will keep it this way instead of using the tomcat's download tasks, seems easier. So I will just call lite's build.xml from tomcat extras. Downloading ivy and ivy downloading deps is automated. Any comments on including the experimental SPDY support ( http://www.chromium.org/spdy/spdy-protocol ) ? I know we had countless debates on JK2 and http proxies, but some extra code to try out doesn't hurt :-) Costin
svn commit: r896937 - in /tomcat/trunk/test/webapp: bug45451b.jsp bug45451c.jsp
Author: markt Date: Thu Jan 7 17:36:27 2010 New Revision: 896937 URL: http://svn.apache.org/viewvc?rev=896937&view=rev Log: Add the tag library definition so the tests actually do what they are supposed to. Modified: tomcat/trunk/test/webapp/bug45451b.jsp tomcat/trunk/test/webapp/bug45451c.jsp Modified: tomcat/trunk/test/webapp/bug45451b.jsp URL: http://svn.apache.org/viewvc/tomcat/trunk/test/webapp/bug45451b.jsp?rev=896937&r1=896936&r2=896937&view=diff == --- tomcat/trunk/test/webapp/bug45451b.jsp (original) +++ tomcat/trunk/test/webapp/bug45451b.jsp Thu Jan 7 17:36:27 2010 @@ -15,4 +15,5 @@ limitations under the License. --%> <%...@page isELIgnored="false" %> +<%@ taglib prefix="tags" tagdir="/WEB-INF/tags" %> <%@ include file="bug45451.jspf" %> Modified: tomcat/trunk/test/webapp/bug45451c.jsp URL: http://svn.apache.org/viewvc/tomcat/trunk/test/webapp/bug45451c.jsp?rev=896937&r1=896936&r2=896937&view=diff == --- tomcat/trunk/test/webapp/bug45451c.jsp (original) +++ tomcat/trunk/test/webapp/bug45451c.jsp Thu Jan 7 17:36:27 2010 @@ -15,4 +15,5 @@ limitations under the License. --%> <%...@page isELIgnored="true" %> +<%@ taglib prefix="tags" tagdir="/WEB-INF/tags" %> <%@ include file="bug45451.jspf" %> - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r896949 - /tomcat/trunk/test/org/apache/el/TestELInJsp.java
Author: markt
Date: Thu Jan 7 18:09:33 2010
New Revision: 896949
URL: http://svn.apache.org/viewvc?rev=896949&view=rev
Log:
Correct tests. Remaining failures shoudl now be Jasper/EL bugs
Modified:
tomcat/trunk/test/org/apache/el/TestELInJsp.java
Modified: tomcat/trunk/test/org/apache/el/TestELInJsp.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/el/TestELInJsp.java?rev=896949&r1=896948&r2=896949&view=diff
==
--- tomcat/trunk/test/org/apache/el/TestELInJsp.java (original)
+++ tomcat/trunk/test/org/apache/el/TestELInJsp.java Thu Jan 7 18:09:33 2010
@@ -133,42 +133,48 @@
res = getUrl("http://localhost:"; + getPort() + "/test/bug45451b.jsp");
result = res.toString();
+System.out.println(result);
// Warning: JSP attribute escaping != Java String escaping
+// Warning: Attributes are always unescaped before passing to the EL
+// processor
assertTrue(result.indexOf("00-2") > 0);
assertTrue(result.indexOf("01-${1+1}") > 0);
assertTrue(result.indexOf("02-\\${1+1}") > 0);
assertTrue(result.indexOf("03-${1+1}") > 0);
assertTrue(result.indexOf("04-2") > 0);
assertTrue(result.indexOf("05-${1+1}") > 0);
-assertTrue(result.indexOf("06-\\2") > 0);
+assertTrue(result.indexOf("06-\\2") > 0); // TODO Fails (bug)
assertTrue(result.indexOf("07-\\${1+1}") > 0);
-assertTrue(result.indexOf("08-2") > 0);
+assertTrue(result.indexOf("08-2") > 0);// TODO Fails (bug)
res = getUrl("http://localhost:"; + getPort() + "/test/bug45451c.jsp");
result = res.toString();
// Warning: JSP attribute escaping != Java String escaping
+// TODO - Currently we allow a single unescaped \ in attribute values
+//Review if this should cause a warning/error
assertTrue(result.indexOf("00-${1+1}") > 0);
assertTrue(result.indexOf("01-\\${1+1}") > 0);
assertTrue(result.indexOf("02-${1+1}") > 0);
assertTrue(result.indexOf("03-\\${1+1}") > 0);
assertTrue(result.indexOf("04-${1+1}") > 0);
assertTrue(result.indexOf("05-\\${1+1}") > 0);
-assertTrue(result.indexOf("06-${1+1}") > 0);
-assertTrue(result.indexOf("07-\\${1+1}") > 0);
-assertTrue(result.indexOf("08-${1+1}") > 0);
+assertTrue(result.indexOf("06-\\${1+1}") > 0);
+assertTrue(result.indexOf("07-${1+1}") > 0);
+assertTrue(result.indexOf("08-${1+1}") > 0);
res = getUrl("http://localhost:"; + getPort() + "/test/bug45451d.jspx");
result = res.toString();
// Warning: JSP attribute escaping != Java String escaping
+// \\ Is *not* an escape sequence in XML attributes
assertTrue(result.indexOf("00-2") > 0);
assertTrue(result.indexOf("01-${1+1}") > 0);
assertTrue(result.indexOf("02-\\${1+1}") > 0);
assertTrue(result.indexOf("03-${1+1}") > 0);
assertTrue(result.indexOf("04-2") > 0);
assertTrue(result.indexOf("05-${1+1}") > 0);
-assertTrue(result.indexOf("06-\\2") > 0);
-assertTrue(result.indexOf("07-\\${1+1}") > 0);
-assertTrue(result.indexOf("08-2") > 0);
+assertTrue(result.indexOf("06-\\${1+1}") > 0);
+assertTrue(result.indexOf("07-${1+1}") > 0);
+assertTrue(result.indexOf("08-\\${1+1}") > 0);
}
public void testBug45511() throws Exception {
@@ -262,8 +268,8 @@
String result = res.toString();
assertTrue(result.indexOf("00-\\\"${'hello world'}") > 0);
assertTrue(result.indexOf("01-\\\"\\${'hello world'}") > 0);
-assertTrue(result.indexOf("02-\\\"\\${'hello world'}") > 0);
-assertTrue(result.indexOf("03-\\\"\\${'hello world'}") > 0);
+assertTrue(result.indexOf("02-\\\"\\${'hello world'}") > 0); // TODO -
bug
+assertTrue(result.indexOf("03-\\\"\\hello world") > 0); // TODO -
bug
assertTrue(result.indexOf("2az-04") > 0);
assertTrue(result.indexOf("05-a2z") > 0);
assertTrue(result.indexOf("06-az2") > 0);
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r896953 - in /tomcat/trunk/test: org/apache/el/TestELInJsp.java webapp/el-misc.jsp
Author: markt
Date: Thu Jan 7 18:23:14 2010
New Revision: 896953
URL: http://svn.apache.org/viewvc?rev=896953&view=rev
Log:
Add another test case. This one passes at the moment but would fail with some
of the ideas I have had to fix the tests that currently fail.
Modified:
tomcat/trunk/test/org/apache/el/TestELInJsp.java
tomcat/trunk/test/webapp/el-misc.jsp
Modified: tomcat/trunk/test/org/apache/el/TestELInJsp.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/el/TestELInJsp.java?rev=896953&r1=896952&r2=896953&view=diff
==
--- tomcat/trunk/test/org/apache/el/TestELInJsp.java (original)
+++ tomcat/trunk/test/org/apache/el/TestELInJsp.java Thu Jan 7 18:23:14 2010
@@ -276,6 +276,7 @@
assertTrue(result.indexOf("2az-07") > 0);
assertTrue(result.indexOf("08-a2z") > 0);
assertTrue(result.indexOf("09-az2") > 0);
+assertTrue(result.indexOf("10-${'foo'}bar") > 0);
}
Modified: tomcat/trunk/test/webapp/el-misc.jsp
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/webapp/el-misc.jsp?rev=896953&r1=896952&r2=896953&view=diff
==
--- tomcat/trunk/test/webapp/el-misc.jsp (original)
+++ tomcat/trunk/test/webapp/el-misc.jsp Thu Jan 7 18:23:14 2010
@@ -28,5 +28,6 @@
+
\ No newline at end of file
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r897005 - in /tomcat/trunk/test: org/apache/el/TestELInJsp.java webapp/el-misc.jsp
Author: markt
Date: Thu Jan 7 20:24:57 2010
New Revision: 897005
URL: http://svn.apache.org/viewvc?rev=897005&view=rev
Log:
Add another edge case
Modified:
tomcat/trunk/test/org/apache/el/TestELInJsp.java
tomcat/trunk/test/webapp/el-misc.jsp
Modified: tomcat/trunk/test/org/apache/el/TestELInJsp.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/el/TestELInJsp.java?rev=897005&r1=897004&r2=897005&view=diff
==
--- tomcat/trunk/test/org/apache/el/TestELInJsp.java (original)
+++ tomcat/trunk/test/org/apache/el/TestELInJsp.java Thu Jan 7 20:24:57 2010
@@ -277,6 +277,7 @@
assertTrue(result.indexOf("08-a2z") > 0);
assertTrue(result.indexOf("09-az2") > 0);
assertTrue(result.indexOf("10-${'foo'}bar") > 0);
+assertTrue(result.indexOf("11-\"}") > 0);
}
Modified: tomcat/trunk/test/webapp/el-misc.jsp
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/webapp/el-misc.jsp?rev=897005&r1=897004&r2=897005&view=diff
==
--- tomcat/trunk/test/webapp/el-misc.jsp (original)
+++ tomcat/trunk/test/webapp/el-misc.jsp Thu Jan 7 20:24:57 2010
@@ -29,5 +29,6 @@
+
\ No newline at end of file
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48501] Log rotation for ISAPI Redirector
https://issues.apache.org/bugzilla/show_bug.cgi?id=48501 Tim Whittington changed: What|Removed |Added Attachment #24811|0 |1 is obsolete|| Attachment #24812|0 |1 is obsolete|| --- Comment #4 from Tim Whittington 2010-01-07 12:40:08 UTC --- Created an attachment (id=24815) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24815) PATCH - ISAPI Redirector with rotatelogs functionality Attached updated patch with a couple of changes: * Using GetFileSizeEx on suggestion from Mladen (fixes log size determination with multiple IIS processes and adds 64bit file size support) * Added support for optional use of an M suffix on log_filesize setting, as used in rotatelogs (Combined doc updates into this patch as well) -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [PROPOSAL] Log rotation in Tomcat Connector
> Not sure why are you using ftell_nolock > We already have a problem with ISS logging because > multiple processes (IIS 6+) can write to a single log file. Yeah, my bad. Was hoping it would be cheaper than a file size check, but not thinking about multi-process IIS. > > > On the configuration I went for two properties with the same names as the > > Httpd rotatelogs params. > > The rotationtime option is identical in interpretation, and the filesize > > option doesn't have a trailing M as for rotatelogs (no need in our context, > > although we could handle it). > > > > Also use 64 bit versions of _ftelli64 and unsigned int64 instead long > for log_file_size > > E.g. > If the config for log_file size is 3000 > then you will have 2^31 - (3000 * 1000 * 1000) -1 == -852516352 > for log file size. Yeah, already made that change. Went for GetFileSizeEx and ULONGLONG . Updated patch is on the ticket. > Regards > -- > ^TM > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
DO NOT REPLY [Bug 48069] Log Files not getting updated while using isapi_redirect.properties
https://issues.apache.org/bugzilla/show_bug.cgi?id=48069 Tim Whittington changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Comment #7 from Tim Whittington 2010-01-07 12:55:45 UTC --- If that is the properties file you're using, then the problem is probably that it's a UTF-16 encoded text file, which the redirector cannot load. Try saving it as an ASCII text file, and it should work - if you need any more help, ask on the Tomcat Users list. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48069] Log Files not getting updated while using isapi_redirect.properties
https://issues.apache.org/bugzilla/show_bug.cgi?id=48069 --- Comment #8 from David Esposito 2010-01-07 13:11:56 UTC --- Ugh ... I was using Notepad, the most intolerant editor out there, and it obviously obscured that detail .. I downloaded a sample isapi_redirect from somewhere and modified it to suit my needs so the file encoding never even entered my mind .. Is there some way that isapi_redirect could return a more helpful error message if the issue was that the properties file was unparseable? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 38895] Http headers with an underscore "_" change into hypen "-"
https://issues.apache.org/bugzilla/show_bug.cgi?id=38895 Tim Whittington changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #3 from Tim Whittington 2010-01-07 13:31:47 UTC --- This is an explicit behaviour in the ISAPI Redirector controlled by a compile time directive (USE_RAW_HEADERS) that exists in all versions of the redirector. The redirector can be built in two ways: 1) By default, the headers are queries from IIS using the ALL_HTTP server variable. This results in all the headers being upper cased, the names being prepended with HTTP_ and (undocumented it seems) all dashes being converted to underscores. There is code in the redirector to adjust for all this, but unfortunately it means that the case of header names is lost, and all underscores are converted to dashes. 2) With USE_RAW_HEADERS defined, headers are retrieved in their raw state using the ALL_RAW server variable. I've confirmed that a build with USE_RAW_HEADERS defined fixes your problem, but I'm not sure why the option is there in the first place (and why the default is to not do this) - perhaps someone with a longer memory can comment. This issue should probably be resolved as by design, but I'd like to see if there's a good reason to not have USE_RAW_HEADERS as the default. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Use of raw HTTP headers by default in ISAPI Redirector
There's a long standing issue in the ISAPI redirector, that by default the HTTP headers are obtained using the CGI style ALL_HTTP variable. The net result of this is that the case of headers is lost, and all underscores in the original header names are converted to dashes. There's code in the redirector to handle parsing the raw HTTP headers from the ALL_RAW variable, which is enabled by defining USE_RAW_HEADERS and appears to work fine. This code appears to have been there since the beginning of (Tomcat) time - does anyone know of a good reason why USE_RAW_HEADERS should not be the default (and indeed why there should even be an option)? https://issues.apache.org/bugzilla/show_bug.cgi?id=38895 is the issue (from 2006!) cheers tim
DO NOT REPLY [Bug 48083] IIS7 with Tomcat-Connector
https://issues.apache.org/bugzilla/show_bug.cgi?id=48083 Tim Whittington changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Comment #3 from Tim Whittington 2010-01-07 13:59:28 UTC --- Please use the Tomcat Users list if you need help configuring IIS7. The IIS HOWTO is a bit out of date, so if you still need help I can supply instructions (and possibly fix the docs). -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 44571] Limits busy per worker to a threshold
https://issues.apache.org/bugzilla/show_bug.cgi?id=44571 --- Comment #2 from Tim Whittington 2010-01-07 14:25:45 UTC --- I don't think this approach is the best way anymore. You can use connection_pool_size to limit the business of any given worker, and (since 1.2.27) connection_acquire_timeout to specify a timeout for threads to obtain a connection when the pool is full. The only thing that might be worth changing is the response code when an endpoint cannot be obtained for a mapped worker - Currently this produces a 500, whereas a HTTP_STATUS_SERVICE_UNAVAIL (503) would be more appropriate. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Tomcat-Lite update
Le 7 janv. 2010 à 17:50, Costin Manolache a écrit : On Wed, Jan 6, 2010 at 12:13 AM, Mark Thomas wrote: On 06/01/2010 00:27, Costin Manolache wrote: Also, I would like to know if other comitters are OK with (temporarily - i.e. until the 7.0 release vote) including lite in the tomcat7 builds, so people can try it out. How about adding it to the extras build? It could be included in the release then as well. Sounds good, thanks for the suggestions. On the building part - tomcat-lite supports both maven and ant, Maven support ? Yes and the ant build is using ivy to download the deps - I will keep it this way instead of using the tomcat's download tasks, seems easier. So I will just call lite's build.xml from tomcat extras. Downloading ivy and ivy downloading deps is automated. Any comments on including the experimental SPDY support ( http://www.chromium.org/spdy/spdy-protocol ) ? I know we had countless debates on JK2 and http proxies, but some extra code to try out doesn't hurt :-) Good idea, tclite could/should be an incubator area +1 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
A bug in tomcat6? MapperListener.registerHost, StandardServer.findService
Hi, everyone,
I am using tomcat6.0.20 and run it in Embedded mode and met a problem.
I wrote a class to create Embedded service with below code:
final Embedded tomcatService = new Embedded();
tomcatService.setCatalinaHome( catalinaHome );
tomcatService.setName( "Embed Catalina" );
final Engine engine = tomcatService.createEngine();
engine.setName( "Embed Catalina" );
final Host host = tomcatService.createHost( "localhost", "webapps" );
It's working pretty well when using tomcat 5.5.23. Bug when I upgrade
to 6.0.20, and ran it in debug mode, when it went into
MapperListener.registerHost, line 332
Host host = (Host) ServerFactory.getServer().findService(
domain).getContainer().findChild(name);
Now I have:
this.domain = "Embed Catalina"
this.name = "localhost"
name = "localhost"
And when I debug into StandardServer.findService(String name), now I have stack:
name = "Embed Catalina" (which was passed by the value of
MapperListener.domain)
this.services[0].domain = "Embed Catalina"
this.services[0].name = null
So in this method:
synchronized (services) {
for (int i = 0; i < services.length; i++) {
if (name.equals(services[i].getName())) {
return (services[i]);
}
}
}
can't find corresponding service and it will return null, which cause
NullPointerException and whole app will be exit.
Is there anyone know this? Is it a bug or I missed something? Is there
any workaround?
Thanks a lot.
Tang Jianyu
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: A bug in tomcat6? MapperListener.registerHost, StandardServer.findService
2010/1/8 Tang Jianyu : > (...) > > can't find corresponding service and it will return null, which cause > NullPointerException and whole app will be exit. > > Is there anyone know this? Is it a bug or I missed something? Is there > any workaround? > > Thanks a lot. > > Tang Jianyu > It might be related to https://issues.apache.org/bugzilla/show_bug.cgi?id=47316 Can you try a 6.0.22 release candidate, to eliminate the issues that were already fixed? See http://markmail.org/thread/df55xredhflfqnnn Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r897093 - in /tomcat/trunk/java/org/apache/jasper/resources: LocalStrings.properties LocalStrings_es.properties LocalStrings_fr.properties LocalStrings_ja.properties
Author: kkolinko
Date: Fri Jan 8 04:37:23 2010
New Revision: 897093
URL: http://svn.apache.org/viewvc?rev=897093&view=rev
Log:
followup to r896892
Additional message updates for JSP 2.2
Commented-out the untranslated strings in the French file, so that the English
ones could be used
Modified:
tomcat/trunk/java/org/apache/jasper/resources/LocalStrings.properties
tomcat/trunk/java/org/apache/jasper/resources/LocalStrings_es.properties
tomcat/trunk/java/org/apache/jasper/resources/LocalStrings_fr.properties
tomcat/trunk/java/org/apache/jasper/resources/LocalStrings_ja.properties
Modified: tomcat/trunk/java/org/apache/jasper/resources/LocalStrings.properties
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/resources/LocalStrings.properties?rev=897093&r1=897092&r2=897093&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/resources/LocalStrings.properties
(original)
+++ tomcat/trunk/java/org/apache/jasper/resources/LocalStrings.properties Fri
Jan 8 04:37:23 2010
@@ -109,7 +109,7 @@
jsp.error.unable.rename=Unable to rename class file {0} to {1}
jsp.error.mandatory.attribute={0}: Mandatory attribute {1} missing
jsp.error.flush=Exception occurred when flushing data
-jsp.engine.info=Jasper JSP 2.1 Engine
+jsp.engine.info=Jasper JSP 2.2 Engine
jsp.error.invalid.expression="{0}" contains invalid expression(s): {1}
jsp.error.invalid.attribute={0} has invalid attribute: {1}
jsp.error.usebean.class.notfound=Class: {0} not found
@@ -427,7 +427,7 @@
jsp.error.variable.alias=Both or none of the name-from-attribute and alias
attributes must be specified in a variable directive
jsp.error.attribute.null_name=Null attribute name
jsp.error.jsptext.badcontent=\'<\', when appears in the body of
, must be encapsulated within a CDATA
-jsp.error.jsproot.version.invalid=Invalid version number: \"{0}\", must be
\"1.2\", \"2.0\", \"2.1\" or \"2.2\"
+jsp.error.jsproot.version.invalid=Invalid version number: \"{0}\", must be
\"1.2\", \"2.0\", \"2.1\" or \"2.2\"
jsp.error.noFunctionPrefix=The function {0} must be used with a prefix when a
default namespace is not specified
jsp.error.noFunction=The function {0} cannot be located with the specified
prefix
jsp.error.noFunctionMethod=Method \"{0}\" for function \"{1}\" not found in
class \"{2}\"
Modified:
tomcat/trunk/java/org/apache/jasper/resources/LocalStrings_es.properties
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/resources/LocalStrings_es.properties?rev=897093&r1=897092&r2=897093&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/resources/LocalStrings_es.properties
(original)
+++ tomcat/trunk/java/org/apache/jasper/resources/LocalStrings_es.properties
Fri Jan 8 04:37:23 2010
@@ -103,7 +103,7 @@
jsp.error.unable.rename = No se puede renombrar el archivo de clase {0} a {1}
jsp.error.mandatory.attribute = {0}\: Falta atributo obligatorio {1}
jsp.error.flush = Excepci\u00F3n sucedida al vaciar los datos
-jsp.engine.info = Motor Jasper JSP 2.1
+jsp.engine.info = Motor Jasper JSP 2.2
jsp.error.invalid.expression = "{0}" contiene expresiones incorrectas\: {1}
jsp.error.invalid.attribute = {0}\: Atributo incorrecto, {1}
jsp.error.usebean.class.notfound = Clase\: {0} no hallada
Modified:
tomcat/trunk/java/org/apache/jasper/resources/LocalStrings_fr.properties
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/resources/LocalStrings_fr.properties?rev=897093&r1=897092&r2=897093&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/resources/LocalStrings_fr.properties
(original)
+++ tomcat/trunk/java/org/apache/jasper/resources/LocalStrings_fr.properties
Fri Jan 8 04:37:23 2010
@@ -81,7 +81,7 @@
jsp.error.unable.load=Impossible de charger la classe pour la JSP
jsp.error.unable.rename=Impossible de renommer le fichier classe de {0} vers
{1}
jsp.error.mandatory.attribute={0}: L''attribut obligatoire {1} est manquant
-jsp.engine.info=Moteur Jasper JSP 2.0
+jsp.engine.info=Moteur Jasper JSP 2.2
jsp.error.invalid.expression="{0}" contient d''incorrecte(s) expression(s): {1}
jsp.error.invalid.attribute={0}: Attribut incorrect: {1}
jsp.error.usebean.class.notfound=Classe: {0} non trouv\u00e9e
@@ -126,7 +126,6 @@
jsp.warning.checkInterval=Attention: Valeur incorrecte pour le initParam
checkInterval. Utilisation de la valeur par d\u00e9faut \"300\" secondes
jsp.warning.development=Attention: Valeur incorrecte pour le initParam
development. Utilisation de la valeur par d\u00e9faut \"true\"
jsp.warning.reloading=Attention: Valeur incorrecte pour le initParam
reloading. Utilisation de la valeur par d\u00e9faut \"true\"
-jsp.warning.reloading=
jsp.error.badtaglib=Impossible d''ouvrir le taglibrary {0} : {1}
jsp.error.badGetReader=Im
Re: A bug in tomcat6? MapperListener.registerHost, StandardServer.findService
Thank you! I tried 6.0.22, it's running well. On Fri, Jan 8, 2010 at 11:26 AM, Konstantin Kolinko wrote: > 2010/1/8 Tang Jianyu : >> (...) >> >> can't find corresponding service and it will return null, which cause >> NullPointerException and whole app will be exit. >> >> Is there anyone know this? Is it a bug or I missed something? Is there >> any workaround? >> >> Thanks a lot. >> >> Tang Jianyu >> > > It might be related to > https://issues.apache.org/bugzilla/show_bug.cgi?id=47316 > > Can you try a 6.0.22 release candidate, > to eliminate the issues that were already fixed? > > See > http://markmail.org/thread/df55xredhflfqnnn > > Best regards, > Konstantin Kolinko > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48391] Logfile goes missing when running on IIS6 in application pool (not in IIS5 isolation mode)
https://issues.apache.org/bugzilla/show_bug.cgi?id=48391 Tim Whittington changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WORKSFORME --- Comment #1 from Tim Whittington 2010-01-07 23:51:56 UTC --- I haven't had any issues running the ISAPI Redirector on Windows 2003 Server in IIS 5 isolation mode or without (on many test and production servers). There is a known problem with the ISAPI redirector not flushing the log file to disk that could account for the missing log file (this should be in the upcoming 1.2.29 release), otherwise it will be something like a missing/invalid log_file config option or a permissions problem in the directory specified. If you need any more support getting the redirector working in IIS 6, please use the Tomcat Users list. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Tomcat-Lite update
On 01/07/2010 05:50 PM, Costin Manolache wrote: > On Wed, Jan 6, 2010 at 12:13 AM, Mark Thomas wrote: > >> On 06/01/2010 00:27, Costin Manolache wrote: >>> Also, I would like to know if other comitters are OK with (temporarily - >>> i.e. until the 7.0 release vote) including lite in the tomcat7 builds, >>> so people can try it out. >> >> How about adding it to the extras build? It could be included in the >> release then as well. >> >> > Sounds good, thanks for the suggestions. On the building part - tomcat-lite > supports both > maven and ant, and the ant build is using ivy to download the deps - I will > keep it > this way instead of using the tomcat's download tasks, seems easier. So I > will just call > lite's build.xml from tomcat extras. Downloading ivy and ivy downloading > deps is automated. > > Any comments on including the experimental SPDY support ( > http://www.chromium.org/spdy/spdy-protocol ) ? > I know we had countless debates on JK2 and http proxies, but some extra code > to try out doesn't hurt :-) We need a httpd module (like mod_proxy_ajp) for that :-) Cheers Jean-Frederic > > Costin > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
