> Not sure why are you using ftell_nolock > We already have a problem with ISS logging because > multiple processes (IIS 6+) can write to a single log file.
Yeah, my bad. Was hoping it would be cheaper than a file size check, but not thinking about multi-process IIS. > > > On the configuration I went for two properties with the same names as the > > Httpd rotatelogs params. > > The rotationtime option is identical in interpretation, and the filesize > > option doesn't have a trailing M as for rotatelogs (no need in our context, > > although we could handle it). > > > > Also use 64 bit versions of _ftelli64 and unsigned int64 instead long > for log_file_size > > E.g. > If the config for log_file size is 3000 > then you will have 2^31 - (3000 * 1000 * 1000) -1 == -852516352 > for log file size. Yeah, already made that change. Went for GetFileSizeEx and ULONGLONG . Updated patch is on the ticket. > Regards > -- > ^TM > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >