On 01/07/2010 09:56 AM, Tim Whittington wrote:
I've attached the initial implementation, along with a docs patch, to an issue 
in Bugzilla.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48501

I managed to track down the crashing - I was referencing a jk_file_logger_t 
that got deallocated when the log rotated, which IIS didn't like at all.


If you fix the MSVCRT80 dependency I have no problem with the patch.
However the configuration should be as close to the Httpd's logrotate
as possible.

For _ftell_nolock I'd use

LARGE_INTEGER li;
HANDLE h = (HANDLE)_get_osfhandle(fileno(logfile))
GetFilesizeEx(h, &li)

if (li.QuadPart ... )

_ftell_nolock has two drawbacks
1. Does not exist in MSVCRT.dll
2. It works for < 2GB files



Regards
--
^TM

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to