RE: Query for JMX "Async Event Queue properties"

[Dinesh Akhand]

Hi Barry,



Looks like things are already implemented in geode:



Class : GemFireCacheImpl



if (!rgn.isInternalRegion() || 
rgn.getFullPath().contains("GATEWAY_SENDER_QUEUE")) {

  system.handleResourceEvent(ResourceEvent.REGION_CREATE, rgn);

}



Above code solved my problem .  Async Queue Partition region visible in JMX.



But above code looks like hack in existing code.  Is this fix can we take and 
go ahead because in our requirement we need to show all internal partition 
region.



Or can we define some property in .properties files to enable stats in jmx for 
internal region?.



Thanks,

Dinesh Akhand





-Original Message-
From: Barry Oglesby [mailto:bogle...@pivotal.io]
Sent: Saturday, June 17, 2017 2:14 AM
To: dev@geode.apache.org
Subject: Re: Query for JMX "Async Event Queue properties"



The AsynceEventQueueMBean is monitoring the AsyncEventQueueStats not the 
PartitionedRegionStats. And, actually, the only stat being monitored by that 
MBean is the eventQueueSize stat. The parallel AsyncEventQueue creates a 
colocated PartitionedRegion under the covers, and the stats for that PR are the 
PartitionedRegionStats you referenced. There isn't currently any JMX support 
for those PartitionedRegionStats.



Are you looking to add support for those PartitionedRegionStats to the 
AsynceEventQueueMBean? If so, I guess there are a few ways to do. The first 
would be to find the underlying PartitionedRegion for the parallel 
AsyncEventQueue, add its PartitionedRegionStats to the 
AsyncEventQueueMBeanBridge's monitor and reference the appropriate one(s) (in 
your case dataStoreBytesInUse). Another would be to actually create an MBean 
for that internal PartitionedRegion.



Both of these would only be applicable for a parallel AsyncEventQueue.

Serial AsyncEventQueues don't create a PartitionedRegion.





Thanks,

Barry Oglesby





On Fri, Jun 16, 2017 at 5:38 AM, Dinesh Akhand 
mailto:dines...@amdocs.com>> wrote:



> Hi Team

>

> Regarding the following metrics:

>

> /AsyncEventQueue_XYZ_PARALLEL_GATEWAY_SENDER_QUEUE:PartitionedRegionStats.

> dataStoreEntryCount

> /AsyncEventQueue_XYZ_PARALLEL_GATEWAY_SENDER_QUEUE:PartitionedRegionStats.

> dataStoreBytesInUse

>

>

> I found only count for async queue in JMX , it called here

> EventQueueSize = PartitionedRegionStats.dataStoreEntryCount

>

> /** AsyncEventQueue Stats **/

>   public static final String ASYNCEVENTQUEUE_EVENTS_QUEUE_SIZE =

> "eventQueueSize"

>

> we having Missing  PartitionedRegionStats.dataStoreBytesInUse in JMX

> for Async Qeueue.

>

> Can you help me , which property I need to map for it.

>

> Thanks,

> Dinesh Akhand

>

>

> This message and the information contained herein is proprietary and

> confidential and subject to the Amdocs policy statement,

>

> you may review at https://www.amdocs.com/about/email-disclaimer <

> https://www.amdocs.com/about/email-disclaimer>

>
This message and the information contained herein is proprietary and 
confidential and subject to the Amdocs policy statement,

you may review at https://www.amdocs.com/about/email-disclaimer 

[GitHub] geode pull request #594: GEODE-2861: Remove dead code

[nreich]

GitHub user nreich opened a pull request:

https://github.com/apache/geode/pull/594

GEODE-2861: Remove dead code

  * code removed related to shutting down DiskStoreTaskPool

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [x] Is your initial contribution a single, squashed commit?

- [x] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nreich/geode feature/GEODE-2861

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/594.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #594


commit dfcc01b1e13379e03bb65562319d596570293055
Author: Nick Reich 
Date:   2017-06-16T22:52:00Z

GEODE-2861: Remove dead code

  * code removed related to shutting down DiskStoreTaskPool




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 60157: GEODE-3075: initial work for feature flag and creation of a new subclass of `ServerConnection`.

[Alexander Murmann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60157/#review178387
---




geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
Line 252 (original), 280 (patched)


Why are these all multiline comments now despite being only one line? Does 
the style guide demand this?



geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/GenericProtocolServerConnection.java
Lines 34 (patched)


Would it be better to track TODOs in Jira where we will for sure look at it 
and can prioritize it?



geode-core/src/main/java/org/apache/geode/internal/security/CustomSecurityService.java
Lines 117 (patched)


I am suprised this is log level debug and not info. Security events to me 
are alway something I want to have on record. You really need them when you 
didn't expect you'd need them because it's time to find out how your system was 
compromised. Hackers rarely change the debug level to make that easier for me. 
;)



geode-core/src/main/java/org/apache/geode/internal/security/CustomSecurityService.java
Lines 307 (patched)


This section does something distinct enough that we are giving it a 
comment. Would this be worthwhile extracting it? It also seems to act on a 
slightly different abstraction level than other things in this method 
(excluding that string manipulation higher up).



geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactoryTest.java
Lines 58 (patched)


We never test that any of the other values we pass in get set.


- Alexander Murmann


On June 20, 2017, 12:53 a.m., Galen O'Sullivan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60157/
> ---
> 
> (Updated June 20, 2017, 12:53 a.m.)
> 
> 
> Review request for geode, Alexander Murmann, Bruce Schuchardt, Hitesh 
> Khamesra, Udo Kohlmeyer, and Brian Rowe.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Create `ServerConnectionFactory`, which creates either instances of 
> `LegacyServerConnection` (identical in functionality to the old 
> `ServerConnection`) or `NewProtocolServerConnection` (which is currently 
> basically a stub, but will never get called unless a feature flag is set).
> 
> This is the initial work for GEODE-3074, and will allow us to continue to 
> work on further tasks for that project.
> 
> An explicit goal with this PR is to not disturb any existing functionality. 
> Unless a feature flag is set and a connection with a certain magic byte is 
> received, server connections will work as before. If you see something that 
> you think may break, please let me know.
> 
> Have a nice day!
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
>  85f914637 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
>  5eaa5a4bd 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/Acceptor.java 
> 9a3241b05 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
>  2a8818cef 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientHealthMonitor.java
>  e0b5ab8b6 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientProtocolMessageHandler.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/GenericProtocolServerConnection.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/LegacyServerConnection.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java
>  947b83652 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactory.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/CallbackInstantiator.java
>  2cb8d0817 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/CustomSecurityService.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/DisabledSecurityService.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/IntegratedSecurityService.java
>  171cfb71a 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/LegacySecurityService.java
>  c594bf932 
>   
> geode-core/src/main/java/org/apache/geode/internal/securi

Re: Review Request 60157: GEODE-3075: initial work for feature flag and creation of a new subclass of `ServerConnection`.

[Alexander Murmann]

> On June 20, 2017, 3:54 p.m., Alexander Murmann wrote:
> >

All my issues are minor. Overall this looks good to me. Maybe we can consider 
some of my comments in future refactors. The biggest issue I see is the 
security logging.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60157/#review178387
---


On June 20, 2017, 12:53 a.m., Galen O'Sullivan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60157/
> ---
> 
> (Updated June 20, 2017, 12:53 a.m.)
> 
> 
> Review request for geode, Alexander Murmann, Bruce Schuchardt, Hitesh 
> Khamesra, Udo Kohlmeyer, and Brian Rowe.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Create `ServerConnectionFactory`, which creates either instances of 
> `LegacyServerConnection` (identical in functionality to the old 
> `ServerConnection`) or `NewProtocolServerConnection` (which is currently 
> basically a stub, but will never get called unless a feature flag is set).
> 
> This is the initial work for GEODE-3074, and will allow us to continue to 
> work on further tasks for that project.
> 
> An explicit goal with this PR is to not disturb any existing functionality. 
> Unless a feature flag is set and a connection with a certain magic byte is 
> received, server connections will work as before. If you see something that 
> you think may break, please let me know.
> 
> Have a nice day!
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
>  85f914637 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
>  5eaa5a4bd 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/Acceptor.java 
> 9a3241b05 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
>  2a8818cef 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientHealthMonitor.java
>  e0b5ab8b6 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientProtocolMessageHandler.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/GenericProtocolServerConnection.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/LegacyServerConnection.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java
>  947b83652 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactory.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/CallbackInstantiator.java
>  2cb8d0817 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/CustomSecurityService.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/DisabledSecurityService.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/IntegratedSecurityService.java
>  171cfb71a 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/LegacySecurityService.java
>  c594bf932 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/SecurityService.java
>  feea8995d 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/SecurityServiceFactory.java
>  2e0ad956c 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/SecurityServiceType.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/shiro/ConfigInitializer.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/shiro/CustomAuthRealm.java
>  0e5029bd0 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/shiro/SecurityManagerProvider.java
>  ad8e66e0c 
>   
> geode-core/src/test/java/org/apache/geode/distributed/internal/membership/MembershipJUnitTest.java
>  b0e20d9b3 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactoryIntegrationTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactoryTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionTest.java
>  794c61097 
>   
> geode-core/src/test/java/org/apache/geode/internal/security/DisabledSecurityServiceTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/internal/security/FakePostProcessor.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/internal/security/FakeSecurityManager.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/internal/security/IntegratedSec

Re: Review Request 60157: GEODE-3075: initial work for feature flag and creation of a new subclass of `ServerConnection`.

[Alexander Murmann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60157/#review178396
---


Ship it!




Ship It!

- Alexander Murmann


On June 20, 2017, 12:53 a.m., Galen O'Sullivan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60157/
> ---
> 
> (Updated June 20, 2017, 12:53 a.m.)
> 
> 
> Review request for geode, Alexander Murmann, Bruce Schuchardt, Hitesh 
> Khamesra, Udo Kohlmeyer, and Brian Rowe.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Create `ServerConnectionFactory`, which creates either instances of 
> `LegacyServerConnection` (identical in functionality to the old 
> `ServerConnection`) or `NewProtocolServerConnection` (which is currently 
> basically a stub, but will never get called unless a feature flag is set).
> 
> This is the initial work for GEODE-3074, and will allow us to continue to 
> work on further tasks for that project.
> 
> An explicit goal with this PR is to not disturb any existing functionality. 
> Unless a feature flag is set and a connection with a certain magic byte is 
> received, server connections will work as before. If you see something that 
> you think may break, please let me know.
> 
> Have a nice day!
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
>  85f914637 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
>  5eaa5a4bd 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/Acceptor.java 
> 9a3241b05 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
>  2a8818cef 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientHealthMonitor.java
>  e0b5ab8b6 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientProtocolMessageHandler.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/GenericProtocolServerConnection.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/LegacyServerConnection.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java
>  947b83652 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactory.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/CallbackInstantiator.java
>  2cb8d0817 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/CustomSecurityService.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/DisabledSecurityService.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/IntegratedSecurityService.java
>  171cfb71a 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/LegacySecurityService.java
>  c594bf932 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/SecurityService.java
>  feea8995d 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/SecurityServiceFactory.java
>  2e0ad956c 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/SecurityServiceType.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/shiro/ConfigInitializer.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/shiro/CustomAuthRealm.java
>  0e5029bd0 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/shiro/SecurityManagerProvider.java
>  ad8e66e0c 
>   
> geode-core/src/test/java/org/apache/geode/distributed/internal/membership/MembershipJUnitTest.java
>  b0e20d9b3 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactoryIntegrationTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactoryTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionTest.java
>  794c61097 
>   
> geode-core/src/test/java/org/apache/geode/internal/security/DisabledSecurityServiceTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/internal/security/FakePostProcessor.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/internal/security/FakeSecurityManager.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/internal/security/IntegratedSecurityServiceConstructorTest.java
>  afa007f31 
>   
> geode-core/src/test/java/org/apache/geode/internal/security/IntegratedSecurityServiceTest.java
>  daaf18d3f 
>   
> geode-core/src/test/java/org/apac

[CANCEL][VOTE] Apache Geode release - v1.2.0 RC1

[Anthony Baker]

This vote is cancelled due to GEODE-3095, GEODE-3092.

Anthony

> On Jun 17, 2017, at 2:57 PM, Anthony Baker  wrote:
> 
> Thanks Mike!  Here’s the corrected text:
> 
> This is the first release candidate for Apache Geode, version
> 1.2.0.  Thanks to all the community members for their
> contributions to this release!
> 
> *** Please download, test and vote by Wednesday, June 19, 1700 hrs US
> Pacific. ***
> 
> It fixes the following issues:
>   https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12318420&version=12339257
> 
> Note that we are voting upon the source tags:  rel/v1.2.0.RC1
>   https://git-wip-us.apache.org/repos/asf?p=geode.git;a=commit;h=
> b6598890d41dc607ca4897ead04a75dd77f3e852
>   https://git-wip-us.apache.org/repos/asf?p=geode-examples.
> git;a=commit;h=7f93d95ad06a6f2afee54312585f48435fff11e8
> 
> Commit ID:
>   b6598890d41dc607ca4897ead04a75dd77f3e852 (geode)
>   7f93d95ad06a6f2afee54312585f48435fff11e8 (geode-examples)
> 
> Source and binary files:
> https://dist.apache.org/repos/dist/dev/geode/1.2.0.RC1
> 
> Maven staging repo:
>   https://repository.apache.org/content/repositories/orgapachegeode-1019
> 
> Geode's KEYS file containing PGP keys we use to sign the release:
>   https://git-wip-us.apache.org/repos/asf?p=geode.git;a=blob_
> plain;f=KEYS;hb=HEAD
> 
> pub  4096R/C72CFB64 2015-10-01
>   Fingerprint=948E 8234 14BE 693A 7F74  ABBE 19DB CAEE C72C FB64
> 
> Anthony
> 
> 
> 
>> On Jun 17, 2017, at 2:35 PM, Michael Stolz  wrote:
>> 
>> That shouldn't say incubating should  it?
>> 
>> --
>> Mike Stolz
>> Principal Engineer - Gemfire Product Manager
>> Mobile: 631-835-4771
>> 
>> On Jun 17, 2017 12:01 PM, "Anthony Baker"  wrote:
>> 
> 

Re: release 1.2

[Dave Barnes]

I have staged a v1.2 doc update for the Apache Geode website, using RC 1
versions of the User Guide and the Javadocs.
Later release candidates are unlikely to require doc changes, other than
the Wiki-based relnotes, so I'm nearly certain this will be the final
version.
When we merge or rename this branch to 'asf-site', Apache will publish it.
Because I may be on vacation when the release goes live, I checked it into
the geode-site repo as a feature branch, feature/Geode-1.2-webpages.
-Dave
 PS: Apologies for the awkward name, but I don't know exactly which words
trigger Apache's deus-ex-machina, so thought I'd avoid "asf" and "site".

On Sat, Jun 17, 2017 at 11:43 AM, Anthony Baker  wrote:

>
> > On Jun 14, 2017, at 4:59 PM, Anthony Baker  wrote:
> >
> > Agreed.  Please merge to release/1.2.0 when ready.
> >
> > Anthony
> >
>
> Hi everyone,
>
> Please contribute to the ‘crowd-sourced’ releases notes at:
> https://cwiki.apache.org/confluence/display/GEODE/Release+Notes <
> https://cwiki.apache.org/confluence/display/GEODE/Release+Notes>
>
> If you have contributed something you want to be called out, please add a
> note.
>
> Thanks,
> Anthony
>
>
>

Re: Review Request 60157: GEODE-3075: initial work for feature flag and creation of a new subclass of `ServerConnection`.

[Galen O'Sullivan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60157/
---

(Updated June 20, 2017, 5:21 p.m.)


Review request for geode, Alexander Murmann, Bruce Schuchardt, Hitesh Khamesra, 
Udo Kohlmeyer, and Brian Rowe.


Changes
---

Version 3 was broken and had changes from files that changed on develop in 
between me starting the branch and now.


Repository: geode


Description
---

Create `ServerConnectionFactory`, which creates either instances of 
`LegacyServerConnection` (identical in functionality to the old 
`ServerConnection`) or `NewProtocolServerConnection` (which is currently 
basically a stub, but will never get called unless a feature flag is set).

This is the initial work for GEODE-3074, and will allow us to continue to work 
on further tasks for that project.

An explicit goal with this PR is to not disturb any existing functionality. 
Unless a feature flag is set and a connection with a certain magic byte is 
received, server connections will work as before. If you see something that you 
think may break, please let me know.

Have a nice day!


Diffs (updated)
-

  geode-core/src/main/java/org/apache/geode/internal/cache/tier/Acceptor.java 
9a3241b05 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
 2a8818cef 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientHealthMonitor.java
 e0b5ab8b6 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientProtocolMessageHandler.java
 PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/GenericProtocolServerConnection.java
 PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/LegacyServerConnection.java
 PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java
 947b83652 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactory.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactoryIntegrationTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactoryTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionTest.java
 794c61097 


Diff: https://reviews.apache.org/r/60157/diff/4/

Changes: https://reviews.apache.org/r/60157/diff/3-4/


Testing
---

precheckin passed (on a version without the integration test, but I'd consider 
it pretty much equivalent. If you want me to run again, I will.)


Thanks,

Galen O'Sullivan

Re: Review Request 60217: GEODE-2995: adding in protocol handler for protobuf messages

[Galen O'Sullivan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60217/#review178404
---



Good work!

I would love to see more doc comments in general. It can be hard to figure out 
the meaning of a class just from looking at the code.

I've gotten as far as the first test; I will look at the rest later.


geode-protobuf/src/main/java/org/apache/geode/protocol/OpsProcessor.java
Lines 45 (patched)


We'll throw a NPE if the exception is thrown anyways, would it make more 
sense to rethrow here?



geode-protobuf/src/main/java/org/apache/geode/protocol/handler/ProtobufStreamProcessor.java
Lines 35 (patched)


Is this thread-safe? I'd like to have one copy on the server side and call 
processOneMessage from any thread. In theory the message processors and such 
shouldn't store any state. Do you agree? Do you think it's safe to share one 
`ProtobufStreamProcessor` between threads and sockets?



geode-protobuf/src/main/java/org/apache/geode/protocol/handler/ProtobufStreamProcessor.java
Lines 49 (patched)


Should this maybe use the `org.apache.geode.protocol.protobuf.handler` or 
similar namespace? It looks protobuf-specific.



geode-protobuf/src/main/java/org/apache/geode/protocol/handler/ProtocolHandler.java
Lines 23 (patched)


Would `ProtocolSerializer` or similar be a clearer name for this? Handle 
kind of sounds like it does message processing beyond serialization.



geode-protobuf/src/main/java/org/apache/geode/protocol/operations/OperationHandler.java
Lines 26 (patched)


What does this function do? It could use a doc comment.
The interface could use a doc comment as well.



geode-protobuf/src/main/java/org/apache/geode/protocol/operations/ProtobufRequestOperationParser.java
Lines 29 (patched)


Should it be a `RuntimeException` for us to get a malformed request? I 
would have thought of this as being more like an `IOException` or an 
`InvalidProtocolMessageException`.



geode-protobuf/src/main/java/org/apache/geode/protocol/operations/registry/OperationsHandlerRegistry.java
Lines 24 (patched)


This looks like it's specific to protobuf, so I would like to see it in a 
protobuf package.

Because it's specific to protobuf, I don't think it makes that much sense 
to be a global using a `ServiceLoader`.



geode-protobuf/src/test/java/org/apache/geode/client/protocol/IntegrationTest.java
Lines 66 (patched)


can we call this `testGetRequestProcessor()`?



geode-protobuf/src/test/java/org/apache/geode/client/protocol/IntegrationTest.java
Lines 67 (patched)


Especially since this is a test, I think it's clearer to write `throws 
Exception` here.



geode-protobuf/src/test/java/org/apache/geode/client/protocol/IntegrationTest.java
Lines 82 (patched)


We could assert here that we've gotten the region exactly once and/or we've 
only gotten the one key. It's not a lot of benefit, though.



settings.gradle
Line 39 (original), 39 (patched)


`geode-protobuf` will also need to be added to `geode-assembly` before this 
is functional, but we can do that in the work that combines this with the 
`ServerConnection` work.


- Galen O'Sullivan


On June 20, 2017, 12:17 a.m., Brian Rowe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60217/
> ---
> 
> (Updated June 20, 2017, 12:17 a.m.)
> 
> 
> Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen 
> O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> This change adds a new module for handling client stresms encoded using the 
> new ProtoBuf protocol.  At the top level this can be integrated by passing in 
> the input/output streams and cache reference to the ProtobufStreamProcessor.  
> This will decode the message and ultimately dispatch it to an operation 
> specific handler which will call back into the passed cache object.  Note 
> that this not currently hooked up to geode at all, GEODE-3075 is tracking the 
> work needed to hook this up at that level.
> 
> This change mainly contains the plumbing and encoding/decoding logic, but 
> also contain the Get operation handler a

[GitHub] geode pull request #588: GEODE-2820: Added awaitlity clause to wait for the ...

[jhuynh1]

Github user jhuynh1 commented on a diff in the pull request:

https://github.com/apache/geode/pull/588#discussion_r123060011
  
--- Diff: 
geode-core/src/test/java/org/apache/geode/cache/query/dunit/QueryIndexUsingXMLDUnitTest.java
 ---
@@ -510,6 +512,16 @@ public void 
testCreateAsyncIndexWhileDoingGIIAndCompareQueryResults() throws Exc
 vm1.invoke(prIndexCreationCheck(PERSISTENT_REG_NAME, "secIndex", 50));
 vm1.invoke(indexCreationCheck(REP_REG_NAME, "secIndex"));
 
+vm1.invoke(() -> Awaitility.await().atMost(60, 
TimeUnit.SECONDS).until(() -> {
+  boolean regionSizeCheck = getCache().getRegion(NAME).size() == 500
+  && getCache().getRegion(REP_REG_NAME).size() == 500
--- End diff --

Shouldn't this clause check the index size and not the region size?  I 
would think the timing issue was because the indexes were async.  Because of 
the async, the indexes may not have processes all of the updates prior to 
validating the contents of the index...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [VOTE] Using Pull Requests over Review Board

[Ernest Burghardt]

+1 for PRs in Github - one place, simple

On Wed, Jun 14, 2017 at 9:17 AM, Kenneth Howe  wrote:

> -1 per my comments on the [DISCUSS] thread
>
> > On Jun 11, 2017, at 9:51 AM, Jacob Barrett  wrote:
> >
> > After a few days of discussion [1] this thread has quieted down so I
> would
> > like to take it to a vote. The proposal is to modify the workflow of
> > committers to match that of non-committers such that committers shall:
> >
> > * Perform all work in progress on branches in their personal forks on
> > GitHub rather than directly on the ASF Geode repositories.
> >
> > * Submit GitHub pull requests, following all current rules for pull
> > requests, for changes that would require peer review before committing to
> > the production branches.
> >
> > * Register their GitHub accounts with the ASF so that committers can be
> > identified in the GitHub mirror repositories.
> >
> >
> > Please cast your vote.
> >
> > [   ] +1  Approve
> > [   ] +0  No opinion
> > [   ] -1  Disapprove (and reason why)
> >
> >
> > [1] [DISCUSS] Using Pull Requests over Review Board
> >  list:org%2Eapache%2Egeode%2Edev+discuss+pull>
> >
> > -Jake
>
>

Re: Review Request 60217: GEODE-2995: adding in protocol handler for protobuf messages

[Galen O'Sullivan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60217/#review178419
---




geode-protobuf/src/test/java/org/apache/geode/protocol/handler/ProtobufProtocolHandlerJUnitTest.java
Lines 62 (patched)


It's a small thing, but you can write `@Test(expected = 
InvalidProtocolMessageException.class)` and save yourself the try/catch/assert 
code.



geode-protobuf/src/test/java/org/apache/geode/serialization/ProtobufSerializationServiceImplTest.java
Lines 54 (patched)


typo: decdoed



geode-protobuf/src/test/java/org/apache/geode/serialization/registry/CodecRegistryJUnitTest.java
Lines 35 (patched)


Do you know what this ignore does?



geode-protobuf/src/test/java/org/apache/geode/serialization/registry/CodecRegistryJUnitTest.java
Lines 58 (patched)


This test can have an expected exception


- Galen O'Sullivan


On June 20, 2017, 12:17 a.m., Brian Rowe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60217/
> ---
> 
> (Updated June 20, 2017, 12:17 a.m.)
> 
> 
> Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen 
> O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> This change adds a new module for handling client stresms encoded using the 
> new ProtoBuf protocol.  At the top level this can be integrated by passing in 
> the input/output streams and cache reference to the ProtobufStreamProcessor.  
> This will decode the message and ultimately dispatch it to an operation 
> specific handler which will call back into the passed cache object.  Note 
> that this not currently hooked up to geode at all, GEODE-3075 is tracking the 
> work needed to hook this up at that level.
> 
> This change mainly contains the plumbing and encoding/decoding logic, but 
> also contain the Get operation handler as a proof of concept.  Future work 
> will be needed to handle other types of operations.
> 
> 
> Diffs
> -
> 
>   geode-protobuf/build.gradle PRE-CREATION 
>   geode-protobuf/src/main/java/org/apache/geode/ProtobufUtilities.java 
> PRE-CREATION 
>   geode-protobuf/src/main/java/org/apache/geode/protocol/OpsProcessor.java 
> PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/exception/InvalidProtocolMessageException.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/handler/ProtobufStreamProcessor.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/handler/ProtocolHandler.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/handler/protobuf/ProtobufProtocolHandler.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/operations/OperationHandler.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/operations/ProtobufRequestOperationParser.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/operations/protobuf/GetRequestOperationHandler.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/operations/registry/OperationsHandlerRegistry.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/operations/registry/exception/OperationHandlerAlreadyRegisteredException.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/operations/registry/exception/OperationHandlerNotRegisteredException.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/serialization/ProtobufSerializationService.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/serialization/SerializationService.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/serialization/SerializationType.java
>  PRE-CREATION 
>   geode-protobuf/src/main/java/org/apache/geode/serialization/TypeCodec.java 
> PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/serialization/codec/BinaryCodec.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/serialization/codec/BooleanCodec.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/serialization/codec/ByteCodec.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/serialization/codec/DoubleCodec.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/serialization/codec/FloatCodec.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/serializa

Individual Column update using function

[vigneshwaran02]

I am struggling to update individual column using function. Can anyone share
code snippet to handle at function side to update.

Region - Partition

Client code - 

  Map val = new HashMap();
val.put("lastName", "G");
Set setFilter = new HashSet();
setFilter.add("1");
Execution execution =
FunctionService.onRegion(individual).withFilter(setFilter).withArgs(val);
ResultCollector rc =
execution.execute("com.xxx.logic.IndividualUpdateFunction");




--
View this message in context: 
http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/Individual-Column-update-using-function-tp23672.html
Sent from the Apache Geode (Incubating) Developers Forum mailing list archive 
at Nabble.com.

[GitHub] geode issue #586: GEODE-3075: initial flow adding the new client protocol to...

[bschuchardt]

Github user bschuchardt commented on the issue:

https://github.com/apache/geode/pull/586
  
I'm running precheckin on this PR & will merge it to develop when finished


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 60217: GEODE-2995: adding in protocol handler for protobuf messages

[Bruce Schuchardt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60217/#review178410
---




geode-protobuf/src/main/java/org/apache/geode/ProtobufUtilities.java
Lines 22 (patched)


The new classes are all missing javadocs



geode-protobuf/src/main/java/org/apache/geode/protocol/OpsProcessor.java
Lines 45 (patched)


Create a Logger and use it to log a stack trace with information about the 
context of the exception.

private static final Logger logger = LogService.getLogger();



geode-protobuf/src/main/java/org/apache/geode/protocol/operations/OperationHandler.java
Lines 26 (patched)


I think all interface methods should have javadocs



geode-protobuf/src/main/java/org/apache/geode/protocol/operations/ProtobufRequestOperationParser.java
Lines 29 (patched)


Maybe InternalGemFireException would be better than RuntimeException here.



geode-protobuf/src/main/java/org/apache/geode/serialization/SerializationService.java
Lines 22 (patched)


method javadocs please



geode-protobuf/src/main/java/org/apache/geode/serialization/registry/SerializationCodecRegistry.java
Lines 29 (patched)


Since the collection of codecs is fixed by the enumeration why are you 
using a ServiceLoader to scan the classpath for annotated codecs?  That seems 
inefficient.  I think this should be removed until such time as the set of 
codecs is actually extensible.  It will be a lot faster to just have a table of 
the supported codec classes and iterate over it.


- Bruce Schuchardt


On June 20, 2017, 12:17 a.m., Brian Rowe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60217/
> ---
> 
> (Updated June 20, 2017, 12:17 a.m.)
> 
> 
> Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen 
> O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> This change adds a new module for handling client stresms encoded using the 
> new ProtoBuf protocol.  At the top level this can be integrated by passing in 
> the input/output streams and cache reference to the ProtobufStreamProcessor.  
> This will decode the message and ultimately dispatch it to an operation 
> specific handler which will call back into the passed cache object.  Note 
> that this not currently hooked up to geode at all, GEODE-3075 is tracking the 
> work needed to hook this up at that level.
> 
> This change mainly contains the plumbing and encoding/decoding logic, but 
> also contain the Get operation handler as a proof of concept.  Future work 
> will be needed to handle other types of operations.
> 
> 
> Diffs
> -
> 
>   geode-protobuf/build.gradle PRE-CREATION 
>   geode-protobuf/src/main/java/org/apache/geode/ProtobufUtilities.java 
> PRE-CREATION 
>   geode-protobuf/src/main/java/org/apache/geode/protocol/OpsProcessor.java 
> PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/exception/InvalidProtocolMessageException.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/handler/ProtobufStreamProcessor.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/handler/ProtocolHandler.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/handler/protobuf/ProtobufProtocolHandler.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/operations/OperationHandler.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/operations/ProtobufRequestOperationParser.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/operations/protobuf/GetRequestOperationHandler.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/operations/registry/OperationsHandlerRegistry.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/operations/registry/exception/OperationHandlerAlreadyRegisteredException.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/operations/registry/exception/OperationHandlerNotRegisteredException.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/serialization/ProtobufSerializationService.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/serialization/SerializationService.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/j

Build failed in Jenkins: Geode-nightly #872

[Apache Jenkins Server]

See 


Changes:

[jdeppe] GEODE-3071: Provide capability to parallelize distributedTests

[jdeppe] Remove debug println

[jdeppe] GEODE_3071: Add Apache license header

[jdeppe] GEODE-3071: Pull config of docker volumes into top level script so that

[khowe] GEODE-2601: Fixing banner being logged twice during locator startup (now

[khowe] GEODE-2601: Fixing banner being logged twice during locator startup.

[khowe] GEODE-2601: Updated based on feedback

[jiliao] GEODE-3092: fix specifiedDefaultValue for cacheLoader and cacheWriter

[dbarnes] Update geode-book/README.md

[Anil] GEODE-3091: remove empty method

[jiliao] GEODE-3056: fix the message for invalid partition-resolver

--
[...truncated 970.05 KB...]
at 
org.apache.geode.distributed.internal.DistributionManager.create(DistributionManager.java:573)
at 
org.apache.geode.distributed.internal.InternalDistributedSystem.initialize(InternalDistributedSystem.java:736)
at 
org.apache.geode.distributed.internal.InternalDistributedSystem.newInstance(InternalDistributedSystem.java:350)
at 
org.apache.geode.distributed.internal.InternalDistributedSystem.newInstance(InternalDistributedSystem.java:336)
at 
org.apache.geode.distributed.internal.InternalDistributedSystem.newInstance(InternalDistributedSystem.java:330)
at 
org.apache.geode.distributed.DistributedSystem.connect(DistributedSystem.java:205)
at 
org.apache.geode.distributed.internal.InternalLocator.startDistributedSystem(InternalLocator.java:695)
at 
org.apache.geode.distributed.internal.InternalLocator.startLocator(InternalLocator.java:325)
at org.apache.geode.distributed.Locator.startLocator(Locator.java:253)
at 
org.apache.geode.distributed.Locator.startLocatorAndDS(Locator.java:202)
at 
org.apache.geode.cache.client.internal.LocatorTestBase.startLocator(LocatorTestBase.java:131)
at 
org.apache.geode.cache.client.internal.LocatorTestBase$2.run(LocatorTestBase.java:142)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at hydra.MethExecutor.executeObject(MethExecutor.java:245)
at 
org.apache.geode.test.dunit.standalone.RemoteDUnitVM.executeMethodOnObject(RemoteDUnitVM.java:70)
at sun.reflect.GeneratedMethodAccessor2.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:346)
at sun.rmi.transport.Transport$1.run(Transport.java:200)
at sun.rmi.transport.Transport$1.run(Transport.java:197)
at java.security.AccessController.doPrivileged(Native Method)
at sun.rmi.transport.Transport.serviceCall(Transport.java:196)
at 
sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:568)
at 
sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:826)
at 
sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.lambda$run$0(TCPTransport.java:683)
at java.security.AccessController.doPrivileged(Native Method)
at 
sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:682)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:748)

org.apache.geode.cache.wan.GatewayReceiverAutoConnectionSourceDUnitTest > 
testBridgeServerAndGatewayReceiverClientAndServerWithGroup FAILED
java.lang.AssertionError: Suspicious strings were written to the log during 
this run.
Fix the strings or use IgnoredException.addIgnoredException to ignore.
---
Found suspect string in log4j at line 359

[error 2017/06/20 19:06:27.924 UTC  
tid=0x13] failed setting interface to /127.0.1.1: java.net.SocketException: bad 
argument for IP_MULTICAST_IF: address not bound to any interface
java.net.SocketException: bad argument for IP_MULTICAST_IF: address not 
bound to any interface
at java.net.PlainDatagramSocketImpl.socketSetOption0(Native Method)
at 
java.net.PlainDatagramSocketImpl.socketSetOption(PlainDatagramSocketImpl.java:74)
at 
java.net.AbstractPlainDatagramSocketImpl.setOption(AbstractPlainDatagramSocketImpl.java:309)
at java.net.MulticastSocket.setInterface(MulticastSocket.java:471)
at org.jgroups.protocols.UDP.setInterface(UDP.java:4

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #591 was SUCCESSFUL (with 1868 tests)

[Spring CI]

---
Spring Data GemFire > Nightly-ApacheGeode > #591 was successful.
---
Scheduled
1870 tests in total.

https://build.spring.io/browse/SGF-NAG-591/





--
This message is automatically generated by Atlassian Bamboo

Build failed in Jenkins: Geode-release #69

[Apache Jenkins Server]

See 


Changes:

[jiliao] GEODE-3092: fix specifiedDefaultValue for cacheLoader and cacheWriter

[jiliao] GEODE-3095: fix parameter type mismatch between the diskstore command

[jiliao] GEODE-3092: fix specifiedDefaultValue for cacheLoader and cacheWriter -

--
[...truncated 92.23 KB...]
:extensions/geode-modules-session-internal:sourcesJar
:extensions/geode-modules-session-internal:signArchives SKIPPED
:extensions/geode-modules-session-internal:assemble
:extensions/geode-modules-session-internal:compileTestJava UP-TO-DATE
:extensions/geode-modules-session-internal:processTestResources UP-TO-DATE
:extensions/geode-modules-session-internal:testClasses UP-TO-DATE
:extensions/geode-modules-session-internal:checkMissedTests UP-TO-DATE
:extensions/geode-modules-session-internal:spotlessJavaCheck
:extensions/geode-modules-session-internal:spotlessCheck
:extensions/geode-modules-session-internal:test UP-TO-DATE
:extensions/geode-modules-session-internal:check
:extensions/geode-modules-session-internal:build
:extensions/geode-modules-session-internal:distributedTest UP-TO-DATE
:extensions/geode-modules-session-internal:integrationTest UP-TO-DATE
:extensions/geode-modules-tomcat7:compileTestJava
:extensions/geode-modules-tomcat7:processTestResources
:extensions/geode-modules-tomcat7:testClasses
:extensions/geode-modules-tomcat7:checkMissedTests
:extensions/geode-modules-tomcat7:spotlessJavaCheck
:extensions/geode-modules-tomcat7:spotlessCheck
:extensions/geode-modules-tomcat7:test
:extensions/geode-modules-tomcat7:check
:extensions/geode-modules-tomcat7:build
:extensions/geode-modules-tomcat7:distributedTest
:extensions/geode-modules-tomcat7:integrationTest
:extensions/geode-modules-tomcat8:compileTestJava
Download 
https://repo1.maven.org/maven2/javax/security/auth/message/javax.security.auth.message-api/1.1/javax.security.auth.message-api-1.1.pom
Download 
https://repo1.maven.org/maven2/javax/security/auth/message/javax.security.auth.message-api/1.1/javax.security.auth.message-api-1.1.jar
Note: 

 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
:extensions/geode-modules-tomcat8:processTestResources
:extensions/geode-modules-tomcat8:testClasses
:extensions/geode-modules-tomcat8:checkMissedTests
:extensions/geode-modules-tomcat8:spotlessJavaCheck
:extensions/geode-modules-tomcat8:spotlessCheck
:extensions/geode-modules-tomcat8:test
:extensions/geode-modules-tomcat8:check
:extensions/geode-modules-tomcat8:build
:extensions/geode-modules-tomcat8:distributedTest
:extensions/geode-modules-tomcat8:integrationTest
:geode-assembly:compileJava UP-TO-DATE
:geode-assembly:processResources UP-TO-DATE
:geode-assembly:classes UP-TO-DATE
:geode-assembly:defaultCacheConfig
:geode-assembly:defaultDistributionConfig
:geode-assembly:depsJar
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-analyzers-common/6.4.1/lucene-analyzers-common-6.4.1.pom
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-parent/6.4.1/lucene-parent-6.4.1.pom
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-solr-grandparent/6.4.1/lucene-solr-grandparent-6.4.1.pom
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-core/6.4.1/lucene-core-6.4.1.pom
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-queries/6.4.1/lucene-queries-6.4.1.pom
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-queryparser/6.4.1/lucene-queryparser-6.4.1.pom
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-analyzers-common/6.4.1/lucene-analyzers-common-6.4.1.jar
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-core/6.4.1/lucene-core-6.4.1.jar
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-queries/6.4.1/lucene-queries-6.4.1.jar
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-queryparser/6.4.1/lucene-queryparser-6.4.1.jar
Download 
https://repo1.maven.org/maven2/org/springframework/spring-aspects/4.3.6.RELEASE/spring-aspects-4.3.6.RELEASE.pom
Download 
https://repo1.maven.org/maven2/org/springframework/spring-oxm/4.3.6.RELEASE/spring-oxm-4.3.6.RELEASE.pom
Download 
https://repo1.maven.org/maven2/org/springframework/spring-aop/4.3.6.RELEASE/spring-aop-4.3.6.RELEASE.pom
Download 
https://repo1.maven.org/maven2/org/springframework/spring-aspects/4.3.6.RELEASE/spring-aspects-4.3.6.RELEASE.jar
Download 
https://repo1.maven.org/maven2/org/springframework/spring-oxm/4.3.6.RELEASE/spring-oxm-4.3.6.RELEASE.jar
Download 
https://repo1.maven.org/maven2/org/springframework/spring-aop/4.3.6.RELEASE/spring-aop-4.3.6.RELEASE.jar
:geode-benchmarks:compileJava UP-TO-DATE
:geode-benchmarks:processResources UP-TO-DATE
:geode-benchmarks:classes UP

Re: Review Request 60157: GEODE-3075: initial work for feature flag and creation of a new subclass of `ServerConnection`.

[Udo Kohlmeyer]

> On June 19, 2017, 4:24 p.m., Udo Kohlmeyer wrote:
> > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/NewProtocolServerConnection.java
> > Lines 54 (patched)
> > 
> >
> > could we rename this to clientProtocolHandler or 
> > clientProtocolMessageHandler instead of newClientProtocol
> 
> Galen O'Sullivan wrote:
> That name doesn't give the user any information.. I like 
> `protobufProtocolHandler` better.

given that it is a "generic" ClientProtocolMessageHandler, maybe we stick with 
**messageHandler**. Bothing makes it protobuf specific, other than our current 
implementation


- Udo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60157/#review178152
---


On June 20, 2017, 5:21 p.m., Galen O'Sullivan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60157/
> ---
> 
> (Updated June 20, 2017, 5:21 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Bruce Schuchardt, Hitesh 
> Khamesra, Udo Kohlmeyer, and Brian Rowe.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Create `ServerConnectionFactory`, which creates either instances of 
> `LegacyServerConnection` (identical in functionality to the old 
> `ServerConnection`) or `NewProtocolServerConnection` (which is currently 
> basically a stub, but will never get called unless a feature flag is set).
> 
> This is the initial work for GEODE-3074, and will allow us to continue to 
> work on further tasks for that project.
> 
> An explicit goal with this PR is to not disturb any existing functionality. 
> Unless a feature flag is set and a connection with a certain magic byte is 
> received, server connections will work as before. If you see something that 
> you think may break, please let me know.
> 
> Have a nice day!
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/Acceptor.java 
> 9a3241b05 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
>  2a8818cef 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientHealthMonitor.java
>  e0b5ab8b6 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientProtocolMessageHandler.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/GenericProtocolServerConnection.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/LegacyServerConnection.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java
>  947b83652 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactory.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactoryIntegrationTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactoryTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionTest.java
>  794c61097 
> 
> 
> Diff: https://reviews.apache.org/r/60157/diff/4/
> 
> 
> Testing
> ---
> 
> precheckin passed (on a version without the integration test, but I'd 
> consider it pretty much equivalent. If you want me to run again, I will.)
> 
> 
> Thanks,
> 
> Galen O'Sullivan
> 
>

Re: Review Request 60217: GEODE-2995: adding in protocol handler for protobuf messages

[Brian Rowe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60217/#review178412
---




geode-protobuf/src/main/java/org/apache/geode/protocol/OpsProcessor.java
Lines 45 (patched)


Good catch, we shouldn't be catching anything here.



geode-protobuf/src/main/java/org/apache/geode/protocol/handler/ProtobufStreamProcessor.java
Lines 35 (patched)


It looks like the only state being maintained in here is the mapping of op 
code to op handler and for serialization type to codec, both of which are set 
up at construction time.  There shouldn't be any problem calling into this from 
multiple threads.



geode-protobuf/src/main/java/org/apache/geode/protocol/handler/ProtobufStreamProcessor.java
Lines 49 (patched)


Moved this to ...protocol.protobuf.  Within that package I created 
protobuf.handler and protobuf.operations and moved in the protobuf classes from 
org.apache.geode.protocol.{handler,operations}.protobuf to keep all the 
protobuf code in one area.



geode-protobuf/src/main/java/org/apache/geode/protocol/handler/ProtocolHandler.java
Lines 23 (patched)


Good call, ProtocolSerializer is much more descriptive.  Changed.



geode-protobuf/src/main/java/org/apache/geode/protocol/operations/OperationHandler.java
Lines 26 (patched)


This is only used during the constructor of the OperationHandlerRegistry so 
that it can register itself.  We'll probably remove the service loading code in 
the registry construction, which will lead to the removal of this as well.



geode-protobuf/src/main/java/org/apache/geode/protocol/operations/ProtobufRequestOperationParser.java
Lines 29 (patched)


Good call, changed this to InvalidProtocolMessageException.



geode-protobuf/src/main/java/org/apache/geode/protocol/operations/registry/OperationsHandlerRegistry.java
Lines 24 (patched)


It's actually only specific to the protobuf because the service loader will 
automatically register all of the protobuf operation handlers.  

Let's remove service loading here and just create a protobuf specific 
instance in the ProtobufStreamProcessor which will individually register the 
protobuf specific handlers.  Given that this is somewhat broader scope than the 
rest of the review changes, I'm going to leave this for a follow up push after 
the merge.



geode-protobuf/src/test/java/org/apache/geode/client/protocol/IntegrationTest.java
Lines 66 (patched)


How about testGetRequestProcessed?



geode-protobuf/src/test/java/org/apache/geode/client/protocol/IntegrationTest.java
Lines 67 (patched)


That's a lot simpler, thanks!



geode-protobuf/src/test/java/org/apache/geode/client/protocol/IntegrationTest.java
Lines 82 (patched)


Turn out this is pretty easy to check through Mockito, added.



geode-protobuf/src/test/java/org/apache/geode/protocol/handler/ProtobufProtocolHandlerJUnitTest.java
Lines 62 (patched)


Nice, this really cleans up the test a lot



geode-protobuf/src/test/java/org/apache/geode/serialization/ProtobufSerializationServiceImplTest.java
Lines 54 (patched)


Fixed



geode-protobuf/src/test/java/org/apache/geode/serialization/registry/CodecRegistryJUnitTest.java
Lines 35 (patched)


Without this, JUnit can't determine the category of this test - 
http://static.javadoc.io/org.powermock/powermock-core/1.6.5/org/powermock/core/classloader/annotations/PowerMockIgnore.html



geode-protobuf/src/test/java/org/apache/geode/serialization/registry/CodecRegistryJUnitTest.java
Lines 58 (patched)


fixed



settings.gradle
Line 39 (original), 39 (patched)


Alright, I'll leave that for that batch of work then


- Brian Rowe


On June 20, 2017, 12:17 a.m., Brian Rowe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60217/
> ---
> 
> (Updated June 20, 2017, 12:17 a.m.)
> 
> 
> Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen 
> O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.

Re: Review Request 60217: GEODE-2995: adding in protocol handler for protobuf messages

[Brian Rowe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60217/
---

(Updated June 21, 2017, 12:02 a.m.)


Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen 
O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.


Changes
---

I've added a bunch of javadocs and moved several classes to a new 
...protocol.protobuf package.


Repository: geode


Description
---

This change adds a new module for handling client stresms encoded using the new 
ProtoBuf protocol.  At the top level this can be integrated by passing in the 
input/output streams and cache reference to the ProtobufStreamProcessor.  This 
will decode the message and ultimately dispatch it to an operation specific 
handler which will call back into the passed cache object.  Note that this not 
currently hooked up to geode at all, GEODE-3075 is tracking the work needed to 
hook this up at that level.

This change mainly contains the plumbing and encoding/decoding logic, but also 
contain the Get operation handler as a proof of concept.  Future work will be 
needed to handle other types of operations.


Diffs (updated)
-

  geode-protobuf/build.gradle PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/exception/InvalidProtocolMessageException.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/operations/OperationHandler.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/operations/registry/OperationsHandlerRegistry.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/operations/registry/exception/OperationHandlerAlreadyRegisteredException.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/operations/registry/exception/OperationHandlerNotRegisteredException.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/EncodingTypeTranslator.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufOpsProcessor.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufSerializationService.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufStreamProcessor.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufUtilities.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandler.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/serializer/ProtobufProtocolSerializer.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/serializer/ProtocolSerializer.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/SerializationService.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/SerializationType.java
 PRE-CREATION 
  geode-protobuf/src/main/java/org/apache/geode/serialization/TypeCodec.java 
PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/codec/BinaryCodec.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/codec/BooleanCodec.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/codec/ByteCodec.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/codec/DoubleCodec.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/codec/FloatCodec.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/codec/IntCodec.java 
PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/codec/JSONCodec.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/codec/LongCodec.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/codec/ShortCodec.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/codec/StringCodec.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/exception/TypeEncodingException.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/exception/UnsupportedEncodingTypeException.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/registry/SerializationCodecRegistry.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/registry/exception/CodecAlreadyRegisteredForTypeException.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/registry/exception/CodecNotRegisteredForTypeException.java
 PRE-CREATION 
  geode-protobuf/src/main/proto/basicTypes.proto PRE-CREATION 
  geode-protobuf/src/main/proto/clientProtocol.proto PRE-CREATION 
  geode-protobuf/src/main/proto/region_API.proto PRE-CREATION 
  ge

Jenkins build is back to normal : Geode-nightly-flaky #41

[Apache Jenkins Server]

See 

Re: Review Request 60217: GEODE-2995: adding in protocol handler for protobuf messages

[Udo Kohlmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60217/#review178441
---




geode-protobuf/build.gradle
Lines 26 (patched)


we might want to add the different versions to the 
gradle/dependency-versions.properties file.


- Udo Kohlmeyer


On June 21, 2017, 12:02 a.m., Brian Rowe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60217/
> ---
> 
> (Updated June 21, 2017, 12:02 a.m.)
> 
> 
> Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen 
> O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> This change adds a new module for handling client stresms encoded using the 
> new ProtoBuf protocol.  At the top level this can be integrated by passing in 
> the input/output streams and cache reference to the ProtobufStreamProcessor.  
> This will decode the message and ultimately dispatch it to an operation 
> specific handler which will call back into the passed cache object.  Note 
> that this not currently hooked up to geode at all, GEODE-3075 is tracking the 
> work needed to hook this up at that level.
> 
> This change mainly contains the plumbing and encoding/decoding logic, but 
> also contain the Get operation handler as a proof of concept.  Future work 
> will be needed to handle other types of operations.
> 
> 
> Diffs
> -
> 
>   geode-protobuf/build.gradle PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/exception/InvalidProtocolMessageException.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/operations/OperationHandler.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/operations/registry/OperationsHandlerRegistry.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/operations/registry/exception/OperationHandlerAlreadyRegisteredException.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/operations/registry/exception/OperationHandlerNotRegisteredException.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/EncodingTypeTranslator.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufOpsProcessor.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufSerializationService.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufStreamProcessor.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufUtilities.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandler.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/serializer/ProtobufProtocolSerializer.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/serializer/ProtocolSerializer.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/serialization/SerializationService.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/serialization/SerializationType.java
>  PRE-CREATION 
>   geode-protobuf/src/main/java/org/apache/geode/serialization/TypeCodec.java 
> PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/serialization/codec/BinaryCodec.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/serialization/codec/BooleanCodec.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/serialization/codec/ByteCodec.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/serialization/codec/DoubleCodec.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/serialization/codec/FloatCodec.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/serialization/codec/IntCodec.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/serialization/codec/JSONCodec.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/serialization/codec/LongCodec.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/serialization/codec/ShortCodec.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/serialization/codec/StringCodec.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/serialization/exception/TypeEncodingException.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/serialization/exception/UnsupportedEncodingTypeException.ja

[GitHub] geode issue #588: GEODE-2820: Added awaitlity clause to wait for the region ...

[nabarunnag]

Github user nabarunnag commented on the issue:

https://github.com/apache/geode/pull/588
  
@jhuynh1 Changed the validation  checks to verify that the size of the 
indexes are correct.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Review Request 60257: GEODE-3100/GEM-1256: move authorize* call to external SecurityService and have it available in Cache

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60257/
---

Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
Patrick Rhomberg.


Repository: geode


Description
---

* move the authorize* call to external SecurityService
* Add getSecurityService() that returns the external SecuritySerfice in Cache
* Add a getCache method in FunctionContext
* Add a test to demonstrate the locking in GetRegionFunction and fix it.


Diffs
-

  geode-core/src/main/java/org/apache/geode/cache/Cache.java 
66a3cd8097f8b526d0bd69f3afbd2dc55fa1ac3e 
  geode-core/src/main/java/org/apache/geode/cache/execute/FunctionContext.java 
74f05c557d3cd7bc05e0389419ef84e17d797bf4 
  
geode-core/src/main/java/org/apache/geode/internal/cache/execute/FunctionContextImpl.java
 39190f3c9d6ff2403542b729ee8d9c254bf6898f 
  
geode-core/src/main/java/org/apache/geode/internal/security/SecurityService.java
 feea8995de1ae3ba24d84b4046063ab79e21ec47 
  geode-core/src/main/java/org/apache/geode/security/SecurityService.java 
PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/internal/cache/execute/FunctionExecutionTest.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/60257/diff/1/


Testing
---


Thanks,

Jinmei Liao

Re: Review Request 60257: GEODE-3100/GEM-1256: move authorize* call to external SecurityService and have it available in Cache

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60257/
---

(Updated June 21, 2017, 12:45 a.m.)


Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
Patrick Rhomberg.


Repository: geode


Description (updated)
---

* move the authorize* call to external SecurityService
* Add getSecurityService() that returns the external SecuritySerfice in Cache
* Add a getCache method in FunctionContext
* Add a test to demonstrate the locking in GetRegionFunction and fix it.

a later revision will rename the SecurityService in the internal package to 
InternalSecurityService so that it won't clutter up this changeset.


Diffs (updated)
-

  geode-core/src/main/java/org/apache/geode/cache/Cache.java 
66a3cd8097f8b526d0bd69f3afbd2dc55fa1ac3e 
  geode-core/src/main/java/org/apache/geode/cache/CacheFactory.java 
9b23f6c1a8ed3449d8a49029d6364f1e989e367c 
  geode-core/src/main/java/org/apache/geode/cache/execute/FunctionContext.java 
74f05c557d3cd7bc05e0389419ef84e17d797bf4 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
 15723557915e2b810270ba58a2195dda8c68 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberFactory.java
 b682d93fd5c4b5340e2c30be72c5572e031e26ed 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberServices.java
 c52ccbc1cc5a293d70b177e38f03dc17c7db 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSMemberFactory.java
 01d99951bc70547fb311f2edbfec8dde1be799f7 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/Services.java
 2d6af1a22644d427ec2d17863cef27a8d8961491 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticator.java
 f895b964794f99127f1f0c9564f3f85213e0af22 
  geode-core/src/main/java/org/apache/geode/internal/cache/CacheServerImpl.java 
7d4b6d4988a836854bc2a54a40c761152a635b14 
  
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 
5eaa5a4bd237d9d8954ce69323912a6be5139fd0 
  geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java 
4c229db09f59deb8d36cc56a532ea0c7d3202977 
  
geode-core/src/main/java/org/apache/geode/internal/cache/execute/FunctionContextImpl.java
 39190f3c9d6ff2403542b729ee8d9c254bf6898f 
  geode-core/src/main/java/org/apache/geode/internal/cache/tier/Command.java 
110d6ef2a59c652cbdc860aad745d123e3b344e5 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
 2a8818cefedc8bce415b97b18a32ba083ea2f257 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommand.java
 cc78cca048c0215c2086fab80e7834419bdf65a6 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommandQuery.java
 184aa36fc5509285001155e20d846cc717544d2f 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheClientProxy.java
 d7e354887b000aad402627acd3b9340d8101e4f8 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/HandShake.java
 32735b9ab17fe9467cea46096bd177902145e4bd 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java
 947b83652803d7b6af9e6157ba84ba842c5da58e 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerHandShakeProcessor.java
 8b896945a8f136b3081df6efec51edec304f3086 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/AddPdxEnum.java
 5a4a07b81b18d33e465bd3aa46ad4232b976b608 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/AddPdxType.java
 cb4b261586a3536cfd5609e627a37cbca7ecf81f 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ClearRegion.java
 610af436cd96b0663d69915d8a1b37549e4f7bc2 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ClientReady.java
 ae95caec718141e6567cc57cf1c24193210132fc 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/CloseConnection.java
 ed050bda24bf6896a0494309edbf90e12e759d24 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/CommitCommand.java
 c9987db636d8ff2b01beba1d958d308fdd8430f8 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ContainsKey.java
 d7a1b2b0183405142d524c1d91433eb01ac3e9f6 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ContainsKey66.java
 03e798c579e6c26e3aa7cb9a522f8af514f60ce3 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/CreateRegion.java
 2be4724bc2b2b6d472558cdecddba982da032a08 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Default.java
 5bf9d07760b42c562eabf4d979e6e

Re: Review Request 60257: GEODE-3100/GEM-1256: move authorize* call to external SecurityService and have it available in Cache

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60257/
---

(Updated June 21, 2017, 12:47 a.m.)


Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
Patrick Rhomberg.


Repository: geode


Description (updated)
---

* move the authorize* call to external SecurityService
* Add getSecurityService() that returns the external SecuritySerfice in Cache
* Add a getCache method in FunctionContext
* Add a test to demonstrate the locking in GetRegionFunction and fix it.

revision 1 is a small changeset that shows all the above. 
revision 2 is a simple rename of the internal SecurityService to 
InternalSecurityService. It touches a lot of files, but the changes are pretty 
autonomous.


Diffs
-

  geode-core/src/main/java/org/apache/geode/cache/Cache.java 
66a3cd8097f8b526d0bd69f3afbd2dc55fa1ac3e 
  geode-core/src/main/java/org/apache/geode/cache/CacheFactory.java 
9b23f6c1a8ed3449d8a49029d6364f1e989e367c 
  geode-core/src/main/java/org/apache/geode/cache/execute/FunctionContext.java 
74f05c557d3cd7bc05e0389419ef84e17d797bf4 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
 15723557915e2b810270ba58a2195dda8c68 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberFactory.java
 b682d93fd5c4b5340e2c30be72c5572e031e26ed 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberServices.java
 c52ccbc1cc5a293d70b177e38f03dc17c7db 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSMemberFactory.java
 01d99951bc70547fb311f2edbfec8dde1be799f7 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/Services.java
 2d6af1a22644d427ec2d17863cef27a8d8961491 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticator.java
 f895b964794f99127f1f0c9564f3f85213e0af22 
  geode-core/src/main/java/org/apache/geode/internal/cache/CacheServerImpl.java 
7d4b6d4988a836854bc2a54a40c761152a635b14 
  
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 
5eaa5a4bd237d9d8954ce69323912a6be5139fd0 
  geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java 
4c229db09f59deb8d36cc56a532ea0c7d3202977 
  
geode-core/src/main/java/org/apache/geode/internal/cache/execute/FunctionContextImpl.java
 39190f3c9d6ff2403542b729ee8d9c254bf6898f 
  geode-core/src/main/java/org/apache/geode/internal/cache/tier/Command.java 
110d6ef2a59c652cbdc860aad745d123e3b344e5 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
 2a8818cefedc8bce415b97b18a32ba083ea2f257 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommand.java
 cc78cca048c0215c2086fab80e7834419bdf65a6 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommandQuery.java
 184aa36fc5509285001155e20d846cc717544d2f 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheClientProxy.java
 d7e354887b000aad402627acd3b9340d8101e4f8 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/HandShake.java
 32735b9ab17fe9467cea46096bd177902145e4bd 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java
 947b83652803d7b6af9e6157ba84ba842c5da58e 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerHandShakeProcessor.java
 8b896945a8f136b3081df6efec51edec304f3086 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/AddPdxEnum.java
 5a4a07b81b18d33e465bd3aa46ad4232b976b608 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/AddPdxType.java
 cb4b261586a3536cfd5609e627a37cbca7ecf81f 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ClearRegion.java
 610af436cd96b0663d69915d8a1b37549e4f7bc2 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ClientReady.java
 ae95caec718141e6567cc57cf1c24193210132fc 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/CloseConnection.java
 ed050bda24bf6896a0494309edbf90e12e759d24 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/CommitCommand.java
 c9987db636d8ff2b01beba1d958d308fdd8430f8 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ContainsKey.java
 d7a1b2b0183405142d524c1d91433eb01ac3e9f6 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ContainsKey66.java
 03e798c579e6c26e3aa7cb9a522f8af514f60ce3 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/CreateRegion.java
 2be4724bc2b2b6d472558cdecddba982da032a08 
  
geode-core/src/main/java/org/apache/geode/internal/cache/ti

Re: Review Request 60217: GEODE-2995: adding in protocol handler for protobuf messages

[Udo Kohlmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60217/#review178442
---




geode-protobuf/src/main/java/org/apache/geode/ProtobufUtilities.java
Lines 22 (patched)


I think this should really be the start of a proper ProtobufMessageUtil 
class that will help with the building of Protobuf messages. This should 
hopefully hide the "horrible" builder pattern that would otherwise litter the 
code.



geode-protobuf/src/main/java/org/apache/geode/ProtobufUtilities.java
Lines 29 (patched)


Not sure why we have this (or ever had this). This is not functionality 
that we should have ever... What does it mean to have a default header? Each 
header should have meaning. I hope



geode-protobuf/src/main/java/org/apache/geode/protocol/operations/registry/OperationsHandlerRegistry.java
Lines 24 (patched)


It is hard to say if it is specific to protobuf. It is the mapping of an 
operation in the IDL to the corresponding handler.

Would be interesting to see if we can find a simple way to maintain the 
mapping of IDL operation IDs and their OperationHandlers.



geode-protobuf/src/test/java/org/apache/geode/client/protocol/MessageUtil.java
Lines 20 (patched)


This utility is need not only in the tests but also when building a message 
to send back. We would not want to have the same boilerplate code in every 
message



geode-protobuf/src/test/java/org/apache/geode/serialization/ProtobufSerializationServiceImplTest.java
Lines 27 (patched)


I think the convention is *JUnitTest or *DUnitTest. We might have to go 
through all Test classes and amend accordingly.



geode-protobuf/src/test/java/org/apache/geode/serialization/ProtobufSerializationServiceImplTest.java
Lines 32 (patched)


I don't like these kinds of tests where we bulk test many different things. 
imo, I'd opt to have multiple tests for each type. At least I can see if 
different scenarios have been broken, by running the test once, rather than 
iteratively.



geode-protobuf/src/test/java/org/apache/geode/serialization/codec/StringCodecJUnitTest.java
Lines 29 (patched)


Given now have SerializationServiceImplTest, does this still make sense?


- Udo Kohlmeyer


On June 21, 2017, 12:02 a.m., Brian Rowe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60217/
> ---
> 
> (Updated June 21, 2017, 12:02 a.m.)
> 
> 
> Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen 
> O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> This change adds a new module for handling client stresms encoded using the 
> new ProtoBuf protocol.  At the top level this can be integrated by passing in 
> the input/output streams and cache reference to the ProtobufStreamProcessor.  
> This will decode the message and ultimately dispatch it to an operation 
> specific handler which will call back into the passed cache object.  Note 
> that this not currently hooked up to geode at all, GEODE-3075 is tracking the 
> work needed to hook this up at that level.
> 
> This change mainly contains the plumbing and encoding/decoding logic, but 
> also contain the Get operation handler as a proof of concept.  Future work 
> will be needed to handle other types of operations.
> 
> 
> Diffs
> -
> 
>   geode-protobuf/build.gradle PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/exception/InvalidProtocolMessageException.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/operations/OperationHandler.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/operations/registry/OperationsHandlerRegistry.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/operations/registry/exception/OperationHandlerAlreadyRegisteredException.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/operations/registry/exception/OperationHandlerNotRegisteredException.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/EncodingTypeTranslator.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufOpsProcessor.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufS

Re: Individual Column update using function

[Akihiro Kitada]

Hello Vigneshwaran,

>I am struggling to update individual column using function.

In this context, does "individual column" mean the specific field variable
of the domain object stored in the target region, below?

-
public class EmployeeData {
private static final long serialVersionUID = 1L;

private String id = "";
private String lastName = "";
private String familyName = "";

public MyData() {
}

public MyData(String id, String lastName, String familyName) {
this.id = id;
this.lastName = lastName;
this.familyName = familyName;
}
  :
public String getLastName() {
return lastName;
}
  :
-

Thanks.



-- 
Akihiro Kitada  |  Staff Customer Engineer |  +81 80 3716 3736
Support.Pivotal.io   |  Mon-Fri  9:00am to
5:30pm JST  |  1-877-477-2269
[image: support]  [image: twitter]
 [image: linkedin]
 [image: facebook]
 [image: google plus]
 [image: youtube]



2017-06-21 5:17 GMT+09:00 vigneshwaran02 :

> I am struggling to update individual column using function. Can anyone
> share
> code snippet to handle at function side to update.
>
> Region - Partition
>
> Client code -
>
>   Map val = new HashMap();
> val.put("lastName", "G");
> Set setFilter = new HashSet();
> setFilter.add("1");
> Execution execution =
> FunctionService.onRegion(individual).withFilter(setFilter).withArgs(val);
> ResultCollector rc =
> execution.execute("com.xxx.logic.IndividualUpdateFunction");
>
>
>
>
> --
> View this message in context: http://apache-geode-
> incubating-developers-forum.70738.x6.nabble.com/Individual-Column-update-
> using-function-tp23672.html
> Sent from the Apache Geode (Incubating) Developers Forum mailing list
> archive at Nabble.com.
>