----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60257/ -----------------------------------------------------------
Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg. Repository: geode Description ------- * move the authorize* call to external SecurityService * Add getSecurityService() that returns the external SecuritySerfice in Cache * Add a getCache method in FunctionContext * Add a test to demonstrate the locking in GetRegionFunction and fix it. Diffs ----- geode-core/src/main/java/org/apache/geode/cache/Cache.java 66a3cd8097f8b526d0bd69f3afbd2dc55fa1ac3e geode-core/src/main/java/org/apache/geode/cache/execute/FunctionContext.java 74f05c557d3cd7bc05e0389419ef84e17d797bf4 geode-core/src/main/java/org/apache/geode/internal/cache/execute/FunctionContextImpl.java 39190f3c9d6ff2403542b729ee8d9c254bf6898f geode-core/src/main/java/org/apache/geode/internal/security/SecurityService.java feea8995de1ae3ba24d84b4046063ab79e21ec47 geode-core/src/main/java/org/apache/geode/security/SecurityService.java PRE-CREATION geode-core/src/test/java/org/apache/geode/internal/cache/execute/FunctionExecutionTest.java PRE-CREATION Diff: https://reviews.apache.org/r/60257/diff/1/ Testing ------- Thanks, Jinmei Liao
