Re: JetBrains ReSharper License

[Ernest Burghardt]

+1 go for it Jake

On Thu, May 11, 2017 at 12:26 PM, Jacob Barrett  wrote:

> Has anyone on the project already applied to JetBrains for a Open Source
> license for ReSharper of the Geode Project?
>
> JetBrains offers complimentary licenses to Apache projects for use by their
> contributors.
> https://www.jetbrains.com/buy/opensource/?product=resharper
>
> If nobody has applied I will make the application.
>
> -Jake
>

[GitHub] geode pull request #502: GEODE-2900: push shadow key to the front of eventSe...

[jhuynh1]

Github user jhuynh1 closed the pull request at:

https://github.com/apache/geode/pull/502


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2900) BucketRegionQueue transitions from primary/secondary/primary can lead to events lingering in queue

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014346#comment-16014346
 ] 

ASF GitHub Bot commented on GEODE-2900:
---

Github user jhuynh1 closed the pull request at:

https://github.com/apache/geode/pull/502


> BucketRegionQueue transitions from primary/secondary/primary can lead to 
> events lingering in queue
> --
>
> Key: GEODE-2900
> URL: https://issues.apache.org/jira/browse/GEODE-2900
> Project: Geode
>  Issue Type: Bug
>  Components: lucene, wan
>Reporter: Jason Huynh
>Assignee: Jason Huynh
> Fix For: 1.2.0
>
>
> In this scenario when peek() is called from BucketRegionQueue, a side effect 
> is that the key is removed from the eventSeqNumQueue and an event is placed 
> into the peekedEvents list.
> If there is failure dispatching the event, we add the peekedEvents list to a 
> new peekedEvents list.  Before doing so, we remove any events that we are not 
> primary for.  Now the event is not in the eventSeqNumQueue or the 
> peekedEvents list
> If we now become primary (before the other node could dispatch this event), 
> and because we do not have that event in the eventSeqNumQueue or the 
> peekedEvents, it gets "stuck."
> This also affects the Lucene implementation.  An stuck event can mean 
> incorrectly indexed data or data inconsistencies



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 59316: GEODE-2927: fix pulse logging and useLocator, SSL flags

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59316/
---

(Updated May 17, 2017, 4:39 p.m.)


Review request for geode, Jared Stewart, Ken Howe, Kirk Lund, and Patrick 
Rhomberg.


Repository: geode


Description
---

* using local mbs server connection will bypass all the mbean security checks
* do not update the mbean attribute since pulse user has no cluster:write 
privilege at all
* Created EmbeddedPulseRule for tests
* simplify PulseAppListener
* use log4j2 logging configurations


Diffs (updated)
-

  
geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/EmbeddedPulseRule.java
 0ed5403d662eda1de4009d445a072ca50e4e0836 


Diff: https://reviews.apache.org/r/59316/diff/3/

Changes: https://reviews.apache.org/r/59316/diff/2-3/


Testing
---


Thanks,

Jinmei Liao

Re: Review Request 59316: GEODE-2927: fix pulse logging and useLocator, SSL flags

[Jinmei Liao]

> On May 16, 2017, 11:07 p.m., Jared Stewart wrote:
> > geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/EmbeddedPulseRule.java
> > Lines 38 (patched)
> > 
> >
> > I was a bit surprised that these `set` methods need to be called after 
> > `before`.  Perhaps this would be more clear if `getRepository()` was 
> > replaced with a method like  
> > ```
> > public Cluster connect() { 
> > return repository.getCluster();
> > }
> > ``` 
> > that indicates the point where the `set` methods must be called before.

this is all due to the evil of Repository.get() will return a singleton. 
PulseVerificationTest needs to test using either jmx port or locator port, 
hence the need for these methods. I reworked the rule a bit to cleanup the 
state.


> On May 16, 2017, 11:07 p.m., Jared Stewart wrote:
> > geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/IClusterUpdater.java
> > Lines 36 (patched)
> > 
> >
> > What is the benefit of a default implementation that returns null?

there are bunch of MockClusterUpdator used in the old tests. I added this 
interface and provide a null implementation to avoid updating those mocks.


- Jinmei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59316/#review175171
---


On May 16, 2017, 10:48 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59316/
> ---
> 
> (Updated May 16, 2017, 10:48 p.m.)
> 
> 
> Review request for geode, Jared Stewart, Ken Howe, Kirk Lund, and Patrick 
> Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> * using local mbs server connection will bypass all the mbean security checks
> * do not update the mbean attribute since pulse user has no cluster:write 
> privilege at all
> * Created EmbeddedPulseRule for tests
> * simplify PulseAppListener
> * use log4j2 logging configurations
> 
> 
> Diffs
> -
> 
>   geode-pulse/src/main/resources/log4j2.properties PRE-CREATION 
>   geode-pulse/src/main/resources/log4j2.xml PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59316/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

Re: Review Request 59324: GEODE-1279: rename Bug51193DUnitTest to ClientFunctionTimeoutRegressionTest

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59324/#review175268
---


Ship it!




Ship It!

- Jinmei Liao


On May 16, 2017, 11:46 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59324/
> ---
> 
> (Updated May 16, 2017, 11:46 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, and Patrick 
> Rhomberg.
> 
> 
> Bugs: GEODE-1279
> https://issues.apache.org/jira/browse/GEODE-1279
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-1279: rename Bug51193DUnitTest to ClientFunctionTimeoutRegressionTest
> 
> * renamed test class and cleaned up test code
> 
> Bug51193DUnitTest failed once in a recent precheckin of mine. I think this 
> test might be flaky but I haven't seen it fail again yet. I decided to lookup 
> TRAC #51193 and change the name to something meaningful. I also added a Rule 
> and changed the test to use JUnit Params.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/execute/Bug51193DUnitTest.java
>  0dfbe6cc1580d890104d907e8d9efb388b892c24 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/execute/ClientFunctionTimeoutRegressionTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59324/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin in progress
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

Re: Review Request 59324: GEODE-1279: rename Bug51193DUnitTest to ClientFunctionTimeoutRegressionTest

[Patrick Rhomberg]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59324/#review175269
---


Ship it!




Ship It!

- Patrick Rhomberg


On May 16, 2017, 11:46 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59324/
> ---
> 
> (Updated May 16, 2017, 11:46 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, and Patrick 
> Rhomberg.
> 
> 
> Bugs: GEODE-1279
> https://issues.apache.org/jira/browse/GEODE-1279
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-1279: rename Bug51193DUnitTest to ClientFunctionTimeoutRegressionTest
> 
> * renamed test class and cleaned up test code
> 
> Bug51193DUnitTest failed once in a recent precheckin of mine. I think this 
> test might be flaky but I haven't seen it fail again yet. I decided to lookup 
> TRAC #51193 and change the name to something meaningful. I also added a Rule 
> and changed the test to use JUnit Params.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/execute/Bug51193DUnitTest.java
>  0dfbe6cc1580d890104d907e8d9efb388b892c24 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/execute/ClientFunctionTimeoutRegressionTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59324/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin in progress
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

Re: Review Request 59324: GEODE-1279: rename Bug51193DUnitTest to ClientFunctionTimeoutRegressionTest

[Jared Stewart]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59324/#review175270
---


Ship it!




Ship It!

- Jared Stewart


On May 16, 2017, 11:46 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59324/
> ---
> 
> (Updated May 16, 2017, 11:46 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, and Patrick 
> Rhomberg.
> 
> 
> Bugs: GEODE-1279
> https://issues.apache.org/jira/browse/GEODE-1279
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-1279: rename Bug51193DUnitTest to ClientFunctionTimeoutRegressionTest
> 
> * renamed test class and cleaned up test code
> 
> Bug51193DUnitTest failed once in a recent precheckin of mine. I think this 
> test might be flaky but I haven't seen it fail again yet. I decided to lookup 
> TRAC #51193 and change the name to something meaningful. I also added a Rule 
> and changed the test to use JUnit Params.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/execute/Bug51193DUnitTest.java
>  0dfbe6cc1580d890104d907e8d9efb388b892c24 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/execute/ClientFunctionTimeoutRegressionTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59324/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin in progress
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

Re: Review Request 59316: GEODE-2927: fix pulse logging and useLocator, SSL flags

[Jared Stewart]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59316/#review175271
---


Ship it!




Ship It!

- Jared Stewart


On May 17, 2017, 4:39 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59316/
> ---
> 
> (Updated May 17, 2017, 4:39 p.m.)
> 
> 
> Review request for geode, Jared Stewart, Ken Howe, Kirk Lund, and Patrick 
> Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> * using local mbs server connection will bypass all the mbean security checks
> * do not update the mbean attribute since pulse user has no cluster:write 
> privilege at all
> * Created EmbeddedPulseRule for tests
> * simplify PulseAppListener
> * use log4j2 logging configurations
> 
> 
> Diffs
> -
> 
>   
> geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/EmbeddedPulseRule.java
>  0ed5403d662eda1de4009d445a072ca50e4e0836 
> 
> 
> Diff: https://reviews.apache.org/r/59316/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

Re: Review Request 59326: GEODE-2934: refactor AnalyzeSerializablesJUnitTest and subclasses

[Jared Stewart]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59326/#review175274
---




geode-core/src/test/java/org/apache/geode/internal/lang/SystemUtilsJUnitTest.java
Lines 19 (patched)


You can remove this import


- Jared Stewart


On May 17, 2017, 1:10 a.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59326/
> ---
> 
> (Updated May 17, 2017, 1:10 a.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, and Patrick 
> Rhomberg.
> 
> 
> Bugs: GEODE-2934
> https://issues.apache.org/jira/browse/GEODE-2934
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2934: refactor AnalyzeSerializablesJUnitTest and subclasses
> 
> Subclasses now only need to override the method "String getModuleName()" and 
> return "geode-xxx" where "xxx" is the name of the geode module.
> 
> Eliminate lots of duplicated code, use SystemUtils for Java version check. 
> Convert statics to member variables. Move setup code from tests to the 
> @Before method. Use static imports to reduce line lengths. Generally make it 
> easier to read and debug (this test gave me some issues during recent 
> refactoring).
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/internal/lang/SystemUtils.java 
> 3485ede59 
>   
> geode-core/src/test/java/org/apache/geode/codeAnalysis/AnalyzeSerializablesJUnitTest.java
>  5b78f065f 
>   
> geode-core/src/test/java/org/apache/geode/internal/lang/SystemUtilsJUnitTest.java
>  8a83dc082 
>   
> geode-cq/src/test/java/org/apache/geode/codeAnalysis/AnalyzeCQSerializablesJUnitTest.java
>  747dd8b4e 
>   
> geode-wan/src/test/java/org/apache/geode/codeAnalysis/AnalyzeWANSerializablesJUnitTest.java
>  77c541cbd 
> 
> 
> Diff: https://reviews.apache.org/r/59326/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin in progress
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

Re: Review Request 59326: GEODE-2934: refactor AnalyzeSerializablesJUnitTest and subclasses

[Jared Stewart]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59326/#review175275
---


Ship it!




Ship It!

- Jared Stewart


On May 17, 2017, 1:10 a.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59326/
> ---
> 
> (Updated May 17, 2017, 1:10 a.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, and Patrick 
> Rhomberg.
> 
> 
> Bugs: GEODE-2934
> https://issues.apache.org/jira/browse/GEODE-2934
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2934: refactor AnalyzeSerializablesJUnitTest and subclasses
> 
> Subclasses now only need to override the method "String getModuleName()" and 
> return "geode-xxx" where "xxx" is the name of the geode module.
> 
> Eliminate lots of duplicated code, use SystemUtils for Java version check. 
> Convert statics to member variables. Move setup code from tests to the 
> @Before method. Use static imports to reduce line lengths. Generally make it 
> easier to read and debug (this test gave me some issues during recent 
> refactoring).
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/internal/lang/SystemUtils.java 
> 3485ede59 
>   
> geode-core/src/test/java/org/apache/geode/codeAnalysis/AnalyzeSerializablesJUnitTest.java
>  5b78f065f 
>   
> geode-core/src/test/java/org/apache/geode/internal/lang/SystemUtilsJUnitTest.java
>  8a83dc082 
>   
> geode-cq/src/test/java/org/apache/geode/codeAnalysis/AnalyzeCQSerializablesJUnitTest.java
>  747dd8b4e 
>   
> geode-wan/src/test/java/org/apache/geode/codeAnalysis/AnalyzeWANSerializablesJUnitTest.java
>  77c541cbd 
> 
> 
> Diff: https://reviews.apache.org/r/59326/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin in progress
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

Re: Review Request 59326: GEODE-2934: refactor AnalyzeSerializablesJUnitTest and subclasses

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59326/#review175276
---


Ship it!




Ship It!

- Jinmei Liao


On May 17, 2017, 1:10 a.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59326/
> ---
> 
> (Updated May 17, 2017, 1:10 a.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, and Patrick 
> Rhomberg.
> 
> 
> Bugs: GEODE-2934
> https://issues.apache.org/jira/browse/GEODE-2934
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2934: refactor AnalyzeSerializablesJUnitTest and subclasses
> 
> Subclasses now only need to override the method "String getModuleName()" and 
> return "geode-xxx" where "xxx" is the name of the geode module.
> 
> Eliminate lots of duplicated code, use SystemUtils for Java version check. 
> Convert statics to member variables. Move setup code from tests to the 
> @Before method. Use static imports to reduce line lengths. Generally make it 
> easier to read and debug (this test gave me some issues during recent 
> refactoring).
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/internal/lang/SystemUtils.java 
> 3485ede59 
>   
> geode-core/src/test/java/org/apache/geode/codeAnalysis/AnalyzeSerializablesJUnitTest.java
>  5b78f065f 
>   
> geode-core/src/test/java/org/apache/geode/internal/lang/SystemUtilsJUnitTest.java
>  8a83dc082 
>   
> geode-cq/src/test/java/org/apache/geode/codeAnalysis/AnalyzeCQSerializablesJUnitTest.java
>  747dd8b4e 
>   
> geode-wan/src/test/java/org/apache/geode/codeAnalysis/AnalyzeWANSerializablesJUnitTest.java
>  77c541cbd 
> 
> 
> Diff: https://reviews.apache.org/r/59326/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin in progress
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

[GitHub] geode-native pull request #99: GEODE-2741: Remove custom shared painter and ...

[pivotal-jbarrett]

GitHub user pivotal-jbarrett opened a pull request:

https://github.com/apache/geode-native/pull/99

GEODE-2741: Remove custom shared painter and replace with std::shared_ptr.

Tests pass on Linux, Windows, Solaris and Mac.

Please review.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pivotal-jbarrett/geode-native wip/shared_ptr

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/99.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #99


commit c0098121eb9b8ee7d537ac0d0bb767ebb6d46927
Author: Jacob Barrett 
Date:   2017-03-29T00:34:29Z

GEODE-2741: Remove custom shared pointer from cppcache

commit 6027574a2078b35fadcef450020af775415f1c36
Author: Jacob Barrett 
Date:   2017-04-21T22:59:27Z

GEODE-2741: Remove custom shared pointer from clicache

commit 9a06e1681438c01e3f721f4a3f7b7576bedefd2a
Author: Jacob Barrett 
Date:   2017-05-16T13:24:16Z

GEODE-2741: Backs out workaround for .NET Environment.Exit issues.

commit c6fdafe5793afd057e95b5fbb3d07b88665d1043
Author: Jacob Barrett 
Date:   2017-05-16T20:29:56Z

GEODE-2741: Fix casting issues between generics.

commit 3cb20df08f6b5d624b75609e54354a077b5fcc03
Author: Jacob Barrett 
Date:   2017-05-16T22:29:14Z

GEODE-2741: Fixes potential memory leak on exception.

commit d58a5e30d42ae38fd9a439fe875bb9096cdde386
Author: Jacob Barrett 
Date:   2017-05-17T03:26:35Z

GEODE-2741: Fixes inclusion of unmanaged headers.

commit 767033e5cfd70b3ad41cac67d63db464b3697a85
Author: Jacob Barrett 
Date:   2017-05-17T04:09:22Z

GEODE-2741: Workaround for static de-init issues with CLR.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2741) Use C++11 shared pointer over custom shared pointer

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014431#comment-16014431
 ] 

ASF GitHub Bot commented on GEODE-2741:
---

GitHub user pivotal-jbarrett opened a pull request:

https://github.com/apache/geode-native/pull/99

GEODE-2741: Remove custom shared painter and replace with std::shared_ptr.

Tests pass on Linux, Windows, Solaris and Mac.

Please review.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pivotal-jbarrett/geode-native wip/shared_ptr

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/99.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #99


commit c0098121eb9b8ee7d537ac0d0bb767ebb6d46927
Author: Jacob Barrett 
Date:   2017-03-29T00:34:29Z

GEODE-2741: Remove custom shared pointer from cppcache

commit 6027574a2078b35fadcef450020af775415f1c36
Author: Jacob Barrett 
Date:   2017-04-21T22:59:27Z

GEODE-2741: Remove custom shared pointer from clicache

commit 9a06e1681438c01e3f721f4a3f7b7576bedefd2a
Author: Jacob Barrett 
Date:   2017-05-16T13:24:16Z

GEODE-2741: Backs out workaround for .NET Environment.Exit issues.

commit c6fdafe5793afd057e95b5fbb3d07b88665d1043
Author: Jacob Barrett 
Date:   2017-05-16T20:29:56Z

GEODE-2741: Fix casting issues between generics.

commit 3cb20df08f6b5d624b75609e54354a077b5fcc03
Author: Jacob Barrett 
Date:   2017-05-16T22:29:14Z

GEODE-2741: Fixes potential memory leak on exception.

commit d58a5e30d42ae38fd9a439fe875bb9096cdde386
Author: Jacob Barrett 
Date:   2017-05-17T03:26:35Z

GEODE-2741: Fixes inclusion of unmanaged headers.

commit 767033e5cfd70b3ad41cac67d63db464b3697a85
Author: Jacob Barrett 
Date:   2017-05-17T04:09:22Z

GEODE-2741: Workaround for static de-init issues with CLR.




> Use C++11 shared pointer over custom shared pointer
> ---
>
> Key: GEODE-2741
> URL: https://issues.apache.org/jira/browse/GEODE-2741
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Addison
>Assignee: Jacob S. Barrett
>
> *Context*
> Now that the Native Client is compatible with C++11, we can use its shared 
> pointer over the custom shared pointer we use today.
> *Definition of Done*
> The custom shared pointer is nowhere to be found in the codebase



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 59326: GEODE-2934: refactor AnalyzeSerializablesJUnitTest and subclasses

[Patrick Rhomberg]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59326/#review175277
---




geode-core/src/test/java/org/apache/geode/codeAnalysis/AnalyzeSerializablesJUnitTest.java
Lines 117 (patched)


discrepencies -> discrepancies



geode-core/src/test/java/org/apache/geode/codeAnalysis/AnalyzeSerializablesJUnitTest.java
Lines 137 (patched)


discrepencies -> discrepancies



geode-core/src/test/java/org/apache/geode/internal/lang/SystemUtilsJUnitTest.java
Lines 17-18 (original), 17-18 (patched)


Are star-imports as frowned upon in Java as they are in Python?  IntelliJ 
suggests optimal imports as...

```
import static 
org.apache.geode.internal.lang.SystemUtils.APPLE_JVM_VENDOR_NAME;
import static org.apache.geode.internal.lang.SystemUtils.IBM_J9_JVM_NAME;
import static 
org.apache.geode.internal.lang.SystemUtils.JAVA_HOTSPOT_JVM_NAME;
import static org.apache.geode.internal.lang.SystemUtils.LINUX_OS_NAME;
import static org.apache.geode.internal.lang.SystemUtils.MAC_OSX_NAME;
import static 
org.apache.geode.internal.lang.SystemUtils.ORACLE_JROCKIT_JVM_NAME;
import static 
org.apache.geode.internal.lang.SystemUtils.ORACLE_JVM_VENDOR_NAME;
import static org.apache.geode.internal.lang.SystemUtils.WINDOWS_OS_NAME;
import static org.apache.geode.internal.lang.SystemUtils.getBootClassPath;
import static org.apache.geode.internal.lang.SystemUtils.getClassPath;
import static org.apache.geode.internal.lang.SystemUtils.getJavaVersion;
import static org.apache.geode.internal.lang.SystemUtils.getOsArchitecture;
import static org.apache.geode.internal.lang.SystemUtils.getOsName;
import static org.apache.geode.internal.lang.SystemUtils.getOsVersion;
import static org.apache.geode.internal.lang.SystemUtils.isAppleJVM;
import static org.apache.geode.internal.lang.SystemUtils.isHotSpotVM;
import static org.apache.geode.internal.lang.SystemUtils.isJ9VM;
import static org.apache.geode.internal.lang.SystemUtils.isJRockitVM;
import static 
org.apache.geode.internal.lang.SystemUtils.isJavaVersionAtLeast;
import static org.apache.geode.internal.lang.SystemUtils.isLinux;
import static org.apache.geode.internal.lang.SystemUtils.isMacOSX;
import static org.apache.geode.internal.lang.SystemUtils.isOracleJVM;
import static org.apache.geode.internal.lang.SystemUtils.isWindows;
import static org.assertj.core.api.Assertions.assertThat;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;
import static org.junit.Assume.assumeNotNull;

import org.apache.geode.test.junit.categories.UnitTest;
import org.junit.Test;
import org.junit.experimental.categories.Category;

import java.lang.management.ManagementFactory;
```


- Patrick Rhomberg


On May 17, 2017, 1:10 a.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59326/
> ---
> 
> (Updated May 17, 2017, 1:10 a.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, and Patrick 
> Rhomberg.
> 
> 
> Bugs: GEODE-2934
> https://issues.apache.org/jira/browse/GEODE-2934
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2934: refactor AnalyzeSerializablesJUnitTest and subclasses
> 
> Subclasses now only need to override the method "String getModuleName()" and 
> return "geode-xxx" where "xxx" is the name of the geode module.
> 
> Eliminate lots of duplicated code, use SystemUtils for Java version check. 
> Convert statics to member variables. Move setup code from tests to the 
> @Before method. Use static imports to reduce line lengths. Generally make it 
> easier to read and debug (this test gave me some issues during recent 
> refactoring).
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/internal/lang/SystemUtils.java 
> 3485ede59 
>   
> geode-core/src/test/java/org/apache/geode/codeAnalysis/AnalyzeSerializablesJUnitTest.java
>  5b78f065f 
>   
> geode-core/src/test/java/org/apache/geode/internal/lang/SystemUtilsJUnitTest.java
>  8a83dc082 
>   
> geode-cq/src/test/java/org/apache/geode/codeAnalysis/AnalyzeCQSerializablesJUnitTest.java
>  747dd8b4e 
>   
> geode-wan/src/test/java/org/apache/geode/codeAnalysis/AnalyzeWANSerializablesJUnitTest.java
>  77c541cbd 
> 
> 
> Diff: https://reviews.apache.org/r/59326/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin in progress
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

Re: Review Request 59323: GEODE-1994: Overhaul of internal.lang.StringUtils to extend and heavily use commons.lang.StringUtils.

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59323/#review175278
---




geode-core/src/main/java/org/apache/geode/internal/lang/StringUtils.java
Line 29 (original), 29 (patched)


I would not make this class extends apache common's StringUtils. We should 
always encourage devleopers to use the apache's String utils, and only for very 
specific cases, we would want to use our own.


- Jinmei Liao


On May 16, 2017, 11:25 p.m., Patrick Rhomberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59323/
> ---
> 
> (Updated May 16, 2017, 11:25 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, Kirk Lund, 
> and Swapnil Bawaskar.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> *   Renamed:
> *   --  EMPTY_STRING -> EMPTY (inherited)
> *   --  toUpperCase  -> upperCase (inherited)
> *   --  toLowerCase  -> lowerCase (inherited)
> *   --  padEnding-> rightPad (inherited)
> *
> *   Removed:
> *   --  EMPTY_STRING_ARRAY; usage replaced with 
> commons.lang.ArrayUtils.EMPTY_STRING_ARRAY
> *   --  SPACES
> *   --  UTF_8; rare usage replaced with raw string
> *   --  concat; usage replaced with commons.lang.join, refactoring as 
> necessary.
> *   --  getLettersOnly
> *   --  getSpaces
> *   --  truncate
> *   --  valueOf; usage refactored to use defaultString
> *
> *   Refactored
> *   --  defaultIfBlank: previously relied on varargs and could return null.  
> Usage refactored to allow inheritance from commons.
> *   --  defaultString(s, EMPTY) refactored to use standard signature 
> defaultString(s) for consistency throughout codebase.
> *   --  isBlank: usage refactored to resolve discrepancies with 
> commons.lang.isBlank, which is now inherited.
> *   --  isEmpty: usage refactored to resolve discrepancies with 
> commons.lang.isEmpty, which is now inherited.
> *
> *   Code Cleanup:
> *   --  Many uses of !isBlank -> isNotBlank
> *   --  Changes suggested by Inspections on most touched files.
> *   -- Explicit  -> <> when type is inferable
> *   -- while loops operating on iterators converted to for each loops
> *   -- for loops operating on array indices converted to for each loops
> *   --  Various string typos corrected.
> *   --  isEmpty(s.trim()) -> isBlank(s)
> *   --  s.trim().isEmpty() -> isEmpty(s)
> *   --  Removed some instances of 'dead' code
> *
> *   Qualitative Changes:
> *   --  The following functions now throw an error when called with a null 
> string input:
> *   --  *  LocatorLauncher.Builder.setMemberName
> *   --  *  ServerLauncher.Builder.setMemberName
> *   --  *  ServerLauncher.Builder.setHostnameForClients
> *
> *   Notes:
> *   --  StringUtils.wraps may be inherited from Apache Commons when the 
> dependency is updated.
> *   --  AbstractLauncher.getMember has the documented behavior of returning 
> null when both MemberName and ID are blank.  Is this the best behavior for 
> this method?
> 
> ==
> 
> I'm going through the diff myself now and noticing a lot of refactorings that 
> happen in dead code.  I'm going back to cull the dead code entirely, but 
> wanted to go ahead and get this diff posted.
> 
> 
> Diffs
> -
> 
>   
> geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsDUnitTest.java
>  5277e57 
>   
> geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsTest.java
>  0554f69 
>   
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RestAPITestBase.java
>  f2e90a4 
>   
> geode-core/src/main/java/org/apache/geode/cache/client/internal/locator/LocatorStatusResponse.java
>  d531cc1 
>   
> geode-core/src/main/java/org/apache/geode/cache/query/internal/AttributeDescriptor.java
>  f40ab3e 
>   
> geode-core/src/main/java/org/apache/geode/cache/query/internal/NWayMergeResults.java
>  4e52a67 
>   geode-core/src/main/java/org/apache/geode/distributed/AbstractLauncher.java 
> feba893 
>   geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java 
> 641e009 
>   geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java 
> b2d0151 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/InternalLocator.java
>  ad5e04d 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java
>  4bf010b 
>   
> geode-core/src/main/java/org/apache/geode/internal/InternalDataSerializer.java
>  78b2944 
>   
> geode-core/src/main/java/org/apache/geode/internal/admin/remote/RemoteTransportConfig.java
>  af3cb5d 
>   
> geode-core/src/main/

Re: Review Request 59323: GEODE-1994: Overhaul of internal.lang.StringUtils to extend and heavily use commons.lang.StringUtils.

[Jinmei Liao]

> On May 17, 2017, 5:32 p.m., Jinmei Liao wrote:
> > geode-core/src/main/java/org/apache/geode/internal/lang/StringUtils.java
> > Line 29 (original), 29 (patched)
> > 
> >
> > I would not make this class extends apache common's StringUtils. We 
> > should always encourage devleopers to use the apache's String utils, and 
> > only for very specific cases, we would want to use our own.

You can make this change after you commited this. I would imagine this would 
touch more files.


- Jinmei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59323/#review175278
---


On May 16, 2017, 11:25 p.m., Patrick Rhomberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59323/
> ---
> 
> (Updated May 16, 2017, 11:25 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, Kirk Lund, 
> and Swapnil Bawaskar.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> *   Renamed:
> *   --  EMPTY_STRING -> EMPTY (inherited)
> *   --  toUpperCase  -> upperCase (inherited)
> *   --  toLowerCase  -> lowerCase (inherited)
> *   --  padEnding-> rightPad (inherited)
> *
> *   Removed:
> *   --  EMPTY_STRING_ARRAY; usage replaced with 
> commons.lang.ArrayUtils.EMPTY_STRING_ARRAY
> *   --  SPACES
> *   --  UTF_8; rare usage replaced with raw string
> *   --  concat; usage replaced with commons.lang.join, refactoring as 
> necessary.
> *   --  getLettersOnly
> *   --  getSpaces
> *   --  truncate
> *   --  valueOf; usage refactored to use defaultString
> *
> *   Refactored
> *   --  defaultIfBlank: previously relied on varargs and could return null.  
> Usage refactored to allow inheritance from commons.
> *   --  defaultString(s, EMPTY) refactored to use standard signature 
> defaultString(s) for consistency throughout codebase.
> *   --  isBlank: usage refactored to resolve discrepancies with 
> commons.lang.isBlank, which is now inherited.
> *   --  isEmpty: usage refactored to resolve discrepancies with 
> commons.lang.isEmpty, which is now inherited.
> *
> *   Code Cleanup:
> *   --  Many uses of !isBlank -> isNotBlank
> *   --  Changes suggested by Inspections on most touched files.
> *   -- Explicit  -> <> when type is inferable
> *   -- while loops operating on iterators converted to for each loops
> *   -- for loops operating on array indices converted to for each loops
> *   --  Various string typos corrected.
> *   --  isEmpty(s.trim()) -> isBlank(s)
> *   --  s.trim().isEmpty() -> isEmpty(s)
> *   --  Removed some instances of 'dead' code
> *
> *   Qualitative Changes:
> *   --  The following functions now throw an error when called with a null 
> string input:
> *   --  *  LocatorLauncher.Builder.setMemberName
> *   --  *  ServerLauncher.Builder.setMemberName
> *   --  *  ServerLauncher.Builder.setHostnameForClients
> *
> *   Notes:
> *   --  StringUtils.wraps may be inherited from Apache Commons when the 
> dependency is updated.
> *   --  AbstractLauncher.getMember has the documented behavior of returning 
> null when both MemberName and ID are blank.  Is this the best behavior for 
> this method?
> 
> ==
> 
> I'm going through the diff myself now and noticing a lot of refactorings that 
> happen in dead code.  I'm going back to cull the dead code entirely, but 
> wanted to go ahead and get this diff posted.
> 
> 
> Diffs
> -
> 
>   
> geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsDUnitTest.java
>  5277e57 
>   
> geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsTest.java
>  0554f69 
>   
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RestAPITestBase.java
>  f2e90a4 
>   
> geode-core/src/main/java/org/apache/geode/cache/client/internal/locator/LocatorStatusResponse.java
>  d531cc1 
>   
> geode-core/src/main/java/org/apache/geode/cache/query/internal/AttributeDescriptor.java
>  f40ab3e 
>   
> geode-core/src/main/java/org/apache/geode/cache/query/internal/NWayMergeResults.java
>  4e52a67 
>   geode-core/src/main/java/org/apache/geode/distributed/AbstractLauncher.java 
> feba893 
>   geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java 
> 641e009 
>   geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java 
> b2d0151 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/InternalLocator.java
>  ad5e04d 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java
>  4bf010b 
>   
> geode-core/src/main/java/org/apache/g

Re: Review Request 59287: GEODE-2420: Enable export logs size estimation and user warning

[Patrick Rhomberg]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59287/#review175282
---



On a Mac, Alt-Shift-I does all the inspections for the current file.  It's how 
I find all the typos that bother me so.


geode-core/src/main/java/org/apache/geode/distributed/internal/membership/InternalDistributedMember.java
Line 28 (original), 28 (patched)


Are star-imports frowned upon?  IntelliJ optimizes imports to...

```
import org.apache.geode.DataSerializer;
import org.apache.geode.GemFireConfigException;
import org.apache.geode.InternalGemFireError;
import org.apache.geode.cache.UnsupportedVersionException;
import org.apache.geode.distributed.DistributedMember;
import org.apache.geode.distributed.DurableClientAttributes;
import org.apache.geode.distributed.Role;
import org.apache.geode.distributed.internal.DistributionAdvisor.ProfileId;
import org.apache.geode.distributed.internal.DistributionConfig;
import org.apache.geode.distributed.internal.DistributionManager;
import org.apache.geode.distributed.internal.ServerLocation;
import org.apache.geode.internal.Assert;
import org.apache.geode.internal.DataSerializableFixedID;
import org.apache.geode.internal.InternalDataSerializer;
import org.apache.geode.internal.OSProcess;
import org.apache.geode.internal.Version;
import org.apache.geode.internal.cache.versions.VersionSource;
import org.apache.geode.internal.i18n.LocalizedStrings;
import org.apache.geode.internal.net.SocketCreator;

import java.io.DataInput;
import java.io.DataOutput;
import java.io.EOFException;
import java.io.Externalizable;
import java.io.IOException;
import java.io.ObjectInput;
import java.io.ObjectOutput;
import java.net.InetAddress;
import java.net.UnknownHostException;
import java.util.Arrays;
import java.util.Collections;
import java.util.HashSet;
import java.util.List;
import java.util.Set;
```



geode-core/src/main/java/org/apache/geode/distributed/internal/membership/InternalDistributedMember.java
Line 34 (original), 34 (patched)


This import can be removed.



geode-core/src/main/java/org/apache/geode/distributed/internal/membership/InternalDistributedMember.java
Line 1208 (original), 1208 (patched)


InternalDistrubtedMemberWrapper -> InternalDistributedMemberWrapper



geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogsCommand.java
Lines 158 (patched)


availble -> available



geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsCommandTest.java
Line 107 (original), 128 (patched)


mockFuntionExecutor -> mockFunctionExecutor



geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsCommandTest.java
Lines 139 (patched)


mockFuntionExecutor -> mockFunctionExecutor



geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsCommandTest.java
Lines 150 (patched)


mockFuntionExecutor -> mockFunctionExecutor



geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsDUnitTest.java
Line 41 (original), 42 (patched)


This import can be removed.



geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/SizeExportLogsFunctionCacheTest.java
Lines 92-95 (original), 90-93 (patched)


initalFileSizes -> initialFileSizes


- Patrick Rhomberg


On May 15, 2017, 10:09 p.m., Ken Howe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59287/
> ---
> 
> (Updated May 15, 2017, 10:09 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Kirk Lund, and Patrick 
> Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Adds 'export logs' option, --file-limit-size, to allow user to set
> maximun size of the epxorted logs zip file.
> 
> When size checking is enabled (file-limit-size > 0) then the check
> will also prevent filling up the disk on each member while consolidating
> and filtering the logs.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/InternalDistributedMember.java
>  41c85d6421c8283163b70f2a

[jira] [Commented] (GEODE-1279) Tests for old TRAC bugs should be renamed to useful names

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014482#comment-16014482
 ] 

ASF subversion and git services commented on GEODE-1279:


Commit a54797278b056dc97076b7412289f9868a7c3028 in geode's branch 
refs/heads/develop from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=a547972 ]

GEODE-1279: rename Bug51193DUnitTest to ClientFunctionTimeoutRegressionTest

* renamed test class and cleaned up test code


> Tests for old TRAC bugs should be renamed to useful names
> -
>
> Key: GEODE-1279
> URL: https://issues.apache.org/jira/browse/GEODE-1279
> Project: Geode
>  Issue Type: Improvement
>  Components: tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> Examples:
> * Bug52289JUnitTest -> FinalStaticArrayShouldNotCauseSegFaultTest
> * Bug36619JUnitTest -> MembershipAttributesAreSerializableTest



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2934) Refactor AnalyzeSerializablesJUnitTest and subclasses

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014483#comment-16014483
 ] 

ASF subversion and git services commented on GEODE-2934:


Commit 9e5c75c156a5a24fc7512ddaec3877218af1e466 in geode's branch 
refs/heads/develop from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=9e5c75c ]

GEODE-2934: refactor AnalyzeSerializablesJUnitTest and subclasses


> Refactor AnalyzeSerializablesJUnitTest and subclasses
> -
>
> Key: GEODE-2934
> URL: https://issues.apache.org/jira/browse/GEODE-2934
> Project: Geode
>  Issue Type: Wish
>  Components: tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> There is quite a lot of redundant code in AnalyzeSerializablesJUnitTest, 
> AnalyzeCQSerializablesJUnitTest and AnalyzeWANSerializablesJUnitTest.
> The subclasses should be able to specify a simple geode-module module name 
> and keep all of the other code in AnalyzeSerializablesJUnitTest.
> I'd also like to move most of the setup to the Before method and make the 
> actual tests smaller and easier to debug.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 59326: GEODE-2934: refactor AnalyzeSerializablesJUnitTest and subclasses

[Kirk Lund]

> On May 17, 2017, 5:20 p.m., Patrick Rhomberg wrote:
> > geode-core/src/test/java/org/apache/geode/internal/lang/SystemUtilsJUnitTest.java
> > Lines 17-18 (original), 17-18 (patched)
> > 
> >
> > Are star-imports as frowned upon in Java as they are in Python?  
> > IntelliJ suggests optimal imports as...
> > 
> > ```
> > import static 
> > org.apache.geode.internal.lang.SystemUtils.APPLE_JVM_VENDOR_NAME;
> > import static 
> > org.apache.geode.internal.lang.SystemUtils.IBM_J9_JVM_NAME;
> > import static 
> > org.apache.geode.internal.lang.SystemUtils.JAVA_HOTSPOT_JVM_NAME;
> > import static org.apache.geode.internal.lang.SystemUtils.LINUX_OS_NAME;
> > import static org.apache.geode.internal.lang.SystemUtils.MAC_OSX_NAME;
> > import static 
> > org.apache.geode.internal.lang.SystemUtils.ORACLE_JROCKIT_JVM_NAME;
> > import static 
> > org.apache.geode.internal.lang.SystemUtils.ORACLE_JVM_VENDOR_NAME;
> > import static 
> > org.apache.geode.internal.lang.SystemUtils.WINDOWS_OS_NAME;
> > import static 
> > org.apache.geode.internal.lang.SystemUtils.getBootClassPath;
> > import static org.apache.geode.internal.lang.SystemUtils.getClassPath;
> > import static org.apache.geode.internal.lang.SystemUtils.getJavaVersion;
> > import static 
> > org.apache.geode.internal.lang.SystemUtils.getOsArchitecture;
> > import static org.apache.geode.internal.lang.SystemUtils.getOsName;
> > import static org.apache.geode.internal.lang.SystemUtils.getOsVersion;
> > import static org.apache.geode.internal.lang.SystemUtils.isAppleJVM;
> > import static org.apache.geode.internal.lang.SystemUtils.isHotSpotVM;
> > import static org.apache.geode.internal.lang.SystemUtils.isJ9VM;
> > import static org.apache.geode.internal.lang.SystemUtils.isJRockitVM;
> > import static 
> > org.apache.geode.internal.lang.SystemUtils.isJavaVersionAtLeast;
> > import static org.apache.geode.internal.lang.SystemUtils.isLinux;
> > import static org.apache.geode.internal.lang.SystemUtils.isMacOSX;
> > import static org.apache.geode.internal.lang.SystemUtils.isOracleJVM;
> > import static org.apache.geode.internal.lang.SystemUtils.isWindows;
> > import static org.assertj.core.api.Assertions.assertThat;
> > import static org.junit.Assert.assertEquals;
> > import static org.junit.Assert.assertFalse;
> > import static org.junit.Assert.assertTrue;
> > import static org.junit.Assume.assumeNotNull;
> > 
> > import org.apache.geode.test.junit.categories.UnitTest;
> > import org.junit.Test;
> > import org.junit.experimental.categories.Category;
> > 
> > import java.lang.management.ManagementFactory;
> > ```

"import package.*" is frowned on, but "import static package.Class.*" generally 
is not because it's the "import static" equivalent of "import package.Class" -- 
spotless doesn't seem to care either way


- Kirk


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59326/#review175277
---


On May 17, 2017, 1:10 a.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59326/
> ---
> 
> (Updated May 17, 2017, 1:10 a.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, and Patrick 
> Rhomberg.
> 
> 
> Bugs: GEODE-2934
> https://issues.apache.org/jira/browse/GEODE-2934
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2934: refactor AnalyzeSerializablesJUnitTest and subclasses
> 
> Subclasses now only need to override the method "String getModuleName()" and 
> return "geode-xxx" where "xxx" is the name of the geode module.
> 
> Eliminate lots of duplicated code, use SystemUtils for Java version check. 
> Convert statics to member variables. Move setup code from tests to the 
> @Before method. Use static imports to reduce line lengths. Generally make it 
> easier to read and debug (this test gave me some issues during recent 
> refactoring).
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/internal/lang/SystemUtils.java 
> 3485ede59 
>   
> geode-core/src/test/java/org/apache/geode/codeAnalysis/AnalyzeSerializablesJUnitTest.java
>  5b78f065f 
>   
> geode-core/src/test/java/org/apache/geode/internal/lang/SystemUtilsJUnitTest.java
>  8a83dc082 
>   
> geode-cq/src/test/java/org/apache/geode/codeAnalysis/AnalyzeCQSerializablesJUnitTest.java
>  747dd8b4e 
>   
> geode-wan/src/test/java/org/apache/geode/codeAnalysis/AnalyzeWANSerializablesJUnitTest.java
>  77c541cbd 
> 
> 
> Diff: https://reviews.apache.org/r/59326/diff/1/
> 
> 
> Testing
> ---
> 

[GitHub] geode pull request #516: GEODE-2587: Refactored the OrderByComparator's comp...

[nabarunnag]

GitHub user nabarunnag opened a pull request:

https://github.com/apache/geode/pull/516

GEODE-2587: Refactored the OrderByComparator's compare method

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-2587

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/516.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #516


commit edf70471a8efc963d3086e663918a67b039b2efd
Author: nabarunnag 
Date:   2017-05-15T05:19:26Z

GEODE-2587: Refactored the OrderByComparator's compare method




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2934) Refactor AnalyzeSerializablesJUnitTest and subclasses

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014487#comment-16014487
 ] 

ASF subversion and git services commented on GEODE-2934:


Commit 52dadee32075e66cfc54de15611d3c0e3a816891 in geode's branch 
refs/heads/develop from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=52dadee ]

GEODE-2934: fix typos


> Refactor AnalyzeSerializablesJUnitTest and subclasses
> -
>
> Key: GEODE-2934
> URL: https://issues.apache.org/jira/browse/GEODE-2934
> Project: Geode
>  Issue Type: Wish
>  Components: tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> There is quite a lot of redundant code in AnalyzeSerializablesJUnitTest, 
> AnalyzeCQSerializablesJUnitTest and AnalyzeWANSerializablesJUnitTest.
> The subclasses should be able to specify a simple geode-module module name 
> and keep all of the other code in AnalyzeSerializablesJUnitTest.
> I'd also like to move most of the setup to the Before method and make the 
> actual tests smaller and easier to debug.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2587) Refactor OrderByComparator's compare method

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014488#comment-16014488
 ] 

ASF GitHub Bot commented on GEODE-2587:
---

GitHub user nabarunnag opened a pull request:

https://github.com/apache/geode/pull/516

GEODE-2587: Refactored the OrderByComparator's compare method

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-2587

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/516.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #516


commit edf70471a8efc963d3086e663918a67b039b2efd
Author: nabarunnag 
Date:   2017-05-15T05:19:26Z

GEODE-2587: Refactored the OrderByComparator's compare method




> Refactor OrderByComparator's compare method
> ---
>
> Key: GEODE-2587
> URL: https://issues.apache.org/jira/browse/GEODE-2587
> Project: Geode
>  Issue Type: Bug
>  Components: querying
>Reporter: nabarun
>
> OrderByComparator's compare method creates a lot of objects / arrays with the 
> intention of comparing two objects.
> But allocation of memory for these objects results in GC to kick in.
> The additional time consumed in GC results in increased execution time for 
> queries with ORDER BY clause.
> This method must be refactored to require less memory allocations in order to 
> compare and thus speed up ORDER BY clause.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #516: GEODE-2587: Refactored the OrderByComparator's comp...

[nabarunnag]

Github user nabarunnag closed the pull request at:

https://github.com/apache/geode/pull/516


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2741) Use C++11 shared pointer over custom shared pointer

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014499#comment-16014499
 ] 

ASF subversion and git services commented on GEODE-2741:


Commit 6027574a2078b35fadcef450020af775415f1c36 in geode-native's branch 
refs/heads/develop from Jacob Barrett
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=6027574 ]

GEODE-2741: Remove custom shared pointer from clicache


> Use C++11 shared pointer over custom shared pointer
> ---
>
> Key: GEODE-2741
> URL: https://issues.apache.org/jira/browse/GEODE-2741
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Addison
>Assignee: Jacob S. Barrett
>
> *Context*
> Now that the Native Client is compatible with C++11, we can use its shared 
> pointer over the custom shared pointer we use today.
> *Definition of Done*
> The custom shared pointer is nowhere to be found in the codebase



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2587) Refactor OrderByComparator's compare method

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014494#comment-16014494
 ] 

ASF GitHub Bot commented on GEODE-2587:
---

Github user nabarunnag closed the pull request at:

https://github.com/apache/geode/pull/516


> Refactor OrderByComparator's compare method
> ---
>
> Key: GEODE-2587
> URL: https://issues.apache.org/jira/browse/GEODE-2587
> Project: Geode
>  Issue Type: Bug
>  Components: querying
>Reporter: nabarun
>
> OrderByComparator's compare method creates a lot of objects / arrays with the 
> intention of comparing two objects.
> But allocation of memory for these objects results in GC to kick in.
> The additional time consumed in GC results in increased execution time for 
> queries with ORDER BY clause.
> This method must be refactored to require less memory allocations in order to 
> compare and thus speed up ORDER BY clause.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #99: GEODE-2741: Remove custom shared painter and ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/99


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2741) Use C++11 shared pointer over custom shared pointer

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014505#comment-16014505
 ] 

ASF subversion and git services commented on GEODE-2741:


Commit d58a5e30d42ae38fd9a439fe875bb9096cdde386 in geode-native's branch 
refs/heads/develop from Jacob Barrett
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=d58a5e3 ]

GEODE-2741: Fixes inclusion of unmanaged headers.


> Use C++11 shared pointer over custom shared pointer
> ---
>
> Key: GEODE-2741
> URL: https://issues.apache.org/jira/browse/GEODE-2741
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Addison
>Assignee: Jacob S. Barrett
>
> *Context*
> Now that the Native Client is compatible with C++11, we can use its shared 
> pointer over the custom shared pointer we use today.
> *Definition of Done*
> The custom shared pointer is nowhere to be found in the codebase



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2741) Use C++11 shared pointer over custom shared pointer

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014507#comment-16014507
 ] 

ASF subversion and git services commented on GEODE-2741:


Commit 767033e5cfd70b3ad41cac67d63db464b3697a85 in geode-native's branch 
refs/heads/develop from Jacob Barrett
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=767033e ]

GEODE-2741: Workaround for static de-init issues with CLR.


> Use C++11 shared pointer over custom shared pointer
> ---
>
> Key: GEODE-2741
> URL: https://issues.apache.org/jira/browse/GEODE-2741
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Addison
>Assignee: Jacob S. Barrett
>
> *Context*
> Now that the Native Client is compatible with C++11, we can use its shared 
> pointer over the custom shared pointer we use today.
> *Definition of Done*
> The custom shared pointer is nowhere to be found in the codebase



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2741) Use C++11 shared pointer over custom shared pointer

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014504#comment-16014504
 ] 

ASF GitHub Bot commented on GEODE-2741:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/99


> Use C++11 shared pointer over custom shared pointer
> ---
>
> Key: GEODE-2741
> URL: https://issues.apache.org/jira/browse/GEODE-2741
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Addison
>Assignee: Jacob S. Barrett
>
> *Context*
> Now that the Native Client is compatible with C++11, we can use its shared 
> pointer over the custom shared pointer we use today.
> *Definition of Done*
> The custom shared pointer is nowhere to be found in the codebase



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2741) Use C++11 shared pointer over custom shared pointer

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014503#comment-16014503
 ] 

ASF subversion and git services commented on GEODE-2741:


Commit 3cb20df08f6b5d624b75609e54354a077b5fcc03 in geode-native's branch 
refs/heads/develop from Jacob Barrett
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=3cb20df ]

GEODE-2741: Fixes potential memory leak on exception.


> Use C++11 shared pointer over custom shared pointer
> ---
>
> Key: GEODE-2741
> URL: https://issues.apache.org/jira/browse/GEODE-2741
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Addison
>Assignee: Jacob S. Barrett
>
> *Context*
> Now that the Native Client is compatible with C++11, we can use its shared 
> pointer over the custom shared pointer we use today.
> *Definition of Done*
> The custom shared pointer is nowhere to be found in the codebase



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2741) Use C++11 shared pointer over custom shared pointer

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014502#comment-16014502
 ] 

ASF subversion and git services commented on GEODE-2741:


Commit c6fdafe5793afd057e95b5fbb3d07b88665d1043 in geode-native's branch 
refs/heads/develop from Jacob Barrett
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=c6fdafe ]

GEODE-2741: Fix casting issues between generics.


> Use C++11 shared pointer over custom shared pointer
> ---
>
> Key: GEODE-2741
> URL: https://issues.apache.org/jira/browse/GEODE-2741
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Addison
>Assignee: Jacob S. Barrett
>
> *Context*
> Now that the Native Client is compatible with C++11, we can use its shared 
> pointer over the custom shared pointer we use today.
> *Definition of Done*
> The custom shared pointer is nowhere to be found in the codebase



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2741) Use C++11 shared pointer over custom shared pointer

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014500#comment-16014500
 ] 

ASF subversion and git services commented on GEODE-2741:


Commit 9a06e1681438c01e3f721f4a3f7b7576bedefd2a in geode-native's branch 
refs/heads/develop from Jacob Barrett
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=9a06e16 ]

GEODE-2741: Backs out workaround for .NET Environment.Exit issues.


> Use C++11 shared pointer over custom shared pointer
> ---
>
> Key: GEODE-2741
> URL: https://issues.apache.org/jira/browse/GEODE-2741
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Addison
>Assignee: Jacob S. Barrett
>
> *Context*
> Now that the Native Client is compatible with C++11, we can use its shared 
> pointer over the custom shared pointer we use today.
> *Definition of Done*
> The custom shared pointer is nowhere to be found in the codebase



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 59246: GEODE-2876: reset isGfshVM flag to false when tearing down tests using CliCommandTestBase.

[Patrick Rhomberg]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59246/#review175290
---


Ship it!




Ship It!

- Patrick Rhomberg


On May 12, 2017, 10:12 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59246/
> ---
> 
> (Updated May 12, 2017, 10:12 p.m.)
> 
> 
> Review request for geode, Jared Stewart, Ken Howe, Kirk Lund, and Patrick 
> Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> * tests using CliCommandTestBase will set this flag to true which messes up 
> following test vms.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/GfshParser.java
>  bc4db1660054ba837a4907d1173a254931fef230 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/CliCommandTestBase.java
>  afdb706c285578f63fdaf459ac4ae59d83ab27e3 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/MemberCommandsDUnitTest.java
>  e41164495e2330ffdbf70bd52dc91bc0ae333830 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ShowDeadlockDUnitTest.java
>  a5293eb0fa0a2599b837abc76903704a45428111 
> 
> 
> Diff: https://reviews.apache.org/r/59246/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin running
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

[GitHub] geode pull request #517: GEODE-2587: Refactored the OrderByComparator's comp...

[nabarunnag]

GitHub user nabarunnag opened a pull request:

https://github.com/apache/geode/pull/517

GEODE-2587: Refactored the OrderByComparator's compare method

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-2587

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/517.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #517


commit 5a2a36e05cb0dbf88a527091797da256780a1cc4
Author: nabarunnag 
Date:   2017-05-15T05:19:26Z

GEODE-2587: Refactored the OrderByComparator's compare method




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2587) Refactor OrderByComparator's compare method

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014514#comment-16014514
 ] 

ASF GitHub Bot commented on GEODE-2587:
---

GitHub user nabarunnag opened a pull request:

https://github.com/apache/geode/pull/517

GEODE-2587: Refactored the OrderByComparator's compare method

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-2587

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/517.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #517


commit 5a2a36e05cb0dbf88a527091797da256780a1cc4
Author: nabarunnag 
Date:   2017-05-15T05:19:26Z

GEODE-2587: Refactored the OrderByComparator's compare method




> Refactor OrderByComparator's compare method
> ---
>
> Key: GEODE-2587
> URL: https://issues.apache.org/jira/browse/GEODE-2587
> Project: Geode
>  Issue Type: Bug
>  Components: querying
>Reporter: nabarun
>
> OrderByComparator's compare method creates a lot of objects / arrays with the 
> intention of comparing two objects.
> But allocation of memory for these objects results in GC to kick in.
> The additional time consumed in GC results in increased execution time for 
> queries with ORDER BY clause.
> This method must be refactored to require less memory allocations in order to 
> compare and thus speed up ORDER BY clause.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode issue #517: GEODE-2587: Refactored the OrderByComparator's compare met...

[nabarunnag]

Github user nabarunnag commented on the issue:

https://github.com/apache/geode/pull/517
  
Potential Reviewers
@ladyVader @jhuynh1 @boglesby @upthewaterspout @gesterzhou  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2587) Refactor OrderByComparator's compare method

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014520#comment-16014520
 ] 

ASF GitHub Bot commented on GEODE-2587:
---

Github user nabarunnag commented on the issue:

https://github.com/apache/geode/pull/517
  
Potential Reviewers
@ladyVader @jhuynh1 @boglesby @upthewaterspout @gesterzhou  


> Refactor OrderByComparator's compare method
> ---
>
> Key: GEODE-2587
> URL: https://issues.apache.org/jira/browse/GEODE-2587
> Project: Geode
>  Issue Type: Bug
>  Components: querying
>Reporter: nabarun
>
> OrderByComparator's compare method creates a lot of objects / arrays with the 
> intention of comparing two objects.
> But allocation of memory for these objects results in GC to kick in.
> The additional time consumed in GC results in increased execution time for 
> queries with ORDER BY clause.
> This method must be refactored to require less memory allocations in order to 
> compare and thus speed up ORDER BY clause.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 59323: GEODE-1994: Overhaul of internal.lang.StringUtils to extend and heavily use commons.lang.StringUtils.

[Jared Stewart]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59323/#review175280
---




geode-core/src/main/java/org/apache/geode/cache/query/internal/AttributeDescriptor.java
Line 224 (original), 224 (patched)


Looks like this comment may have been changed accidentally. Actually, since 
we're already looking around in this class, I think all of these "Not yet used" 
method comments should be deleted.



geode-core/src/main/java/org/apache/geode/cache/query/internal/NWayMergeResults.java
Line 214 (original), 214 (patched)


Delete this comment



geode-core/src/main/java/org/apache/geode/distributed/AbstractLauncher.java
Line 504 (original), 507 (patched)


There is no need to pass the empty string into this constructor, `new 
StringBuilder();` will suffice.



geode-core/src/test/java/org/apache/geode/distributed/LocatorLauncherTest.java
Line 157 (original)


Did you intended to remove these assertions?



geode-core/src/test/java/org/apache/geode/distributed/LocatorLauncherTest.java
Line 194 (original)


Did you intended to remove these assertions?



geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherTest.java
Line 165 (original)


Did you intended to remove these assertions?



geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherTest.java
Line 280 (original)


Did you intended to remove these assertions?


- Jared Stewart


On May 16, 2017, 11:25 p.m., Patrick Rhomberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59323/
> ---
> 
> (Updated May 16, 2017, 11:25 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, Kirk Lund, 
> and Swapnil Bawaskar.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> *   Renamed:
> *   --  EMPTY_STRING -> EMPTY (inherited)
> *   --  toUpperCase  -> upperCase (inherited)
> *   --  toLowerCase  -> lowerCase (inherited)
> *   --  padEnding-> rightPad (inherited)
> *
> *   Removed:
> *   --  EMPTY_STRING_ARRAY; usage replaced with 
> commons.lang.ArrayUtils.EMPTY_STRING_ARRAY
> *   --  SPACES
> *   --  UTF_8; rare usage replaced with raw string
> *   --  concat; usage replaced with commons.lang.join, refactoring as 
> necessary.
> *   --  getLettersOnly
> *   --  getSpaces
> *   --  truncate
> *   --  valueOf; usage refactored to use defaultString
> *
> *   Refactored
> *   --  defaultIfBlank: previously relied on varargs and could return null.  
> Usage refactored to allow inheritance from commons.
> *   --  defaultString(s, EMPTY) refactored to use standard signature 
> defaultString(s) for consistency throughout codebase.
> *   --  isBlank: usage refactored to resolve discrepancies with 
> commons.lang.isBlank, which is now inherited.
> *   --  isEmpty: usage refactored to resolve discrepancies with 
> commons.lang.isEmpty, which is now inherited.
> *
> *   Code Cleanup:
> *   --  Many uses of !isBlank -> isNotBlank
> *   --  Changes suggested by Inspections on most touched files.
> *   -- Explicit  -> <> when type is inferable
> *   -- while loops operating on iterators converted to for each loops
> *   -- for loops operating on array indices converted to for each loops
> *   --  Various string typos corrected.
> *   --  isEmpty(s.trim()) -> isBlank(s)
> *   --  s.trim().isEmpty() -> isEmpty(s)
> *   --  Removed some instances of 'dead' code
> *
> *   Qualitative Changes:
> *   --  The following functions now throw an error when called with a null 
> string input:
> *   --  *  LocatorLauncher.Builder.setMemberName
> *   --  *  ServerLauncher.Builder.setMemberName
> *   --  *  ServerLauncher.Builder.setHostnameForClients
> *
> *   Notes:
> *   --  StringUtils.wraps may be inherited from Apache Commons when the 
> dependency is updated.
> *   --  AbstractLauncher.getMember has the documented behavior of returning 
> null when both MemberName and ID are blank.  Is this the best behavior for 
> this method?
> 
> ==
> 
> I'm going through the diff myself now and noticing a lot of refactorings that 
> happen in dead code.  I'm going back to cull the dead code entirely, but 
> wanted to go ahead and get this diff posted.
> 
> 
> Diffs
> -
> 
>   
> geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsDUnitTest.java
>  5277e57 
>   
> geode-assem

[jira] [Commented] (GEODE-2905) CI failure: org.apache.geode.cache.lucene.internal.cli.LuceneIndexCommandsDUnitTest > searchWithoutIndexShouldReturnError

[Diane Hardman (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014545#comment-16014545
 ] 

Diane Hardman commented on GEODE-2905:
--

Adding comment Naba made in Tracker story:
Made changes to change the assertTrue to assertEquals so that the result string 
is printed out and we have more information on the failure, if it fails again 
the next.
Currently we have very less information on what caused the test to fail and 
also we are unable to reproduce the failure.

> CI failure: 
> org.apache.geode.cache.lucene.internal.cli.LuceneIndexCommandsDUnitTest > 
> searchWithoutIndexShouldReturnError 
> --
>
> Key: GEODE-2905
> URL: https://issues.apache.org/jira/browse/GEODE-2905
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Shelley Lynn Hughes-Godfrey
>Assignee: nabarun
>
> This test failed in Apache Jenkins build #830.
> {noformat}
> org.apache.geode.cache.lucene.internal.cli.LuceneIndexCommandsDUnitTest > 
> searchWithoutIndexShouldReturnError FAILED
> java.lang.AssertionError
> at org.junit.Assert.fail(Assert.java:86)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertTrue(Assert.java:52)
> at 
> org.apache.geode.cache.lucene.internal.cli.LuceneIndexCommandsDUnitTest.searchWithoutIndexShouldReturnError(LuceneIndexCommandsDUnitTest.java:462)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (GEODE-2774) CI failure: LuceneIndexDestroyDUnitTest.verifyDestroyAllIndexesWhileDoingPuts

[Diane Hardman (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Diane Hardman reassigned GEODE-2774:


Assignee: Diane Hardman

> CI failure: LuceneIndexDestroyDUnitTest.verifyDestroyAllIndexesWhileDoingPuts
> -
>
> Key: GEODE-2774
> URL: https://issues.apache.org/jira/browse/GEODE-2774
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Affects Versions: 1.2.0
>Reporter: Shelley Lynn Hughes-Godfrey
>Assignee: Diane Hardman
>  Labels: CI
>
> {noformat}
> :geode-lucene:testClassesat 
> org.apache.geode.internal.Assert.fail(Assert.java:68)
> at 
> org.apache.geode.cache.lucene.LuceneIndexDestroyDUnitTest.verifyDestroyAllIndexesWhileDoingPuts(LuceneIndexDestroyDUnitTest.java:215)
> org.apache.geode.cache.RegionDestroyedException: Partitioned Region 
> @1a3e3379 [path='/region'; dataPolicy=PERSISTENT_PARTITION; prId=76; 
> isDestroyed=false; isClosed=false; retryTimeout=360; serialNumber=1315; 
> partition 
> attributes=PartitionAttributes@1060958737[redundantCopies=0;localMaxMemory=100;totalMaxMemory=2147483647;totalNumBuckets=10;partitionResolver=null;colocatedWith=null;recoveryDelay=-1;startupRecoveryDelay=0;FixedPartitionAttributes=null;partitionListeners=null];
>  on VM 172.17.0.5(154):32770], caused by 
> org.apache.geode.cache.RegionDestroyedException: 
> 172.17.0.5(154):32770@org.apache.geode.internal.cache.PartitionedRegionDataStore@983990329
>  name: /AsyncEventQueue_index1#_region_PARALLEL_GATEWAY_SENDER_QUEUE bucket 
> count: 2, caused by org.apache.geode.cache.RegionDestroyedException: 
> Partitioned Region @32c5de26 
> [path='/AsyncEventQueue_index1#_region_PARALLEL_GATEWAY_SENDER_QUEUE'; 
> dataPolicy=PERSISTENT_PARTITION; prId=78; isDestroyed=true; isClosed=false; 
> retryTimeout=360; serialNumber=1340; partition 
> attributes=PartitionAttributes@2128111693[redundantCopies=0;localMaxMemory=1000;totalMaxMemory=2147483647;totalNumBuckets=10;partitionResolver=null;colocatedWith=/region;recoveryDelay=-1;startupRecoveryDelay=0;FixedPartitionAttributes=null;partitionListeners=null];
>  on VM 172.17.0.5(154):32770]
> at 
> org.apache.geode.internal.cache.PartitionedRegion.virtualPut(PartitionedRegion.java:1954)
> at 
> org.apache.geode.internal.cache.LocalRegionDataView.putEntry(LocalRegionDataView.java:151)
> at 
> org.apache.geode.internal.cache.LocalRegion.basicPut(LocalRegion.java:5194)
> at 
> org.apache.geode.internal.cache.LocalRegion.validatedPut(LocalRegion.java:1605)
> at 
> org.apache.geode.internal.cache.LocalRegion.put(LocalRegion.java:1592)
> at 
> org.apache.geode.internal.cache.AbstractRegion.put(AbstractRegion.java:279)
> at 
> org.apache.geode.cache.lucene.LuceneIndexDestroyDUnitTest.doPutsUntilStopped(LuceneIndexDestroyDUnitTest.java:523)
> at 
> org.apache.geode.cache.lucene.LuceneIndexDestroyDUnitTest.lambda$verifyDestroyAllIndexesWhileDoingPuts$b814fe7d$1(LuceneIndexDestroyDUnitTest.java:197)
> org.apache.geode.cache.RegionDestroyedException: 
> 172.17.0.5(154):32770@org.apache.geode.internal.cache.PartitionedRegionDataStore@983990329
>  name: /AsyncEventQueue_index1#_region_PARALLEL_GATEWAY_SENDER_QUEUE bucket 
> count: 2, caused by org.apache.geode.cache.RegionDestroyedException: 
> Partitioned Region @32c5de26 
> [path='/AsyncEventQueue_index1#_region_PARALLEL_GATEWAY_SENDER_QUEUE'; 
> dataPolicy=PERSISTENT_PARTITION; prId=78; isDestroyed=true; isClosed=false; 
> retryTimeout=360; serialNumber=1340; partition 
> attributes=PartitionAttributes@2128111693[redundantCopies=0;localMaxMemory=1000;totalMaxMemory=2147483647;totalNumBuckets=10;partitionResolver=null;colocatedWith=/region;recoveryDelay=-1;startupRecoveryDelay=0;FixedPartitionAttributes=null;partitionListeners=null];
>  on VM 172.17.0.5(154):32770]
> at 
> org.apache.geode.internal.cache.PartitionedRegionDataStore.grabFreeBucket(PartitionedRegionDataStore.java:482)
> at 
> org.apache.geode.internal.cache.PartitionedRegionDataStore.grabFreeBucketRecursively(PartitionedRegionDataStore.java:282)
> at 
> org.apache.geode.internal.cache.PartitionedRegion.virtualPut(PartitionedRegion.java:1916)
> ... 7 more
> Caused by:
> org.apache.geode.cache.RegionDestroyedException: Partitioned 
> Region @32c5de26 
> [path='/AsyncEventQueue_index1#_region_PARALLEL_GATEWAY_SENDER_QUEUE'; 
> dataPolicy=PERSISTENT_PARTITION; prId=78; isDestroyed=true; isClosed=false; 
> retryTimeout=360; serialNumber=1340; partition 
> attributes=PartitionAttributes@2128111693[redundantCopies=0;localMaxMemory=1000;totalMaxMemory=214748364

[jira] [Commented] (GEODE-2774) CI failure: LuceneIndexDestroyDUnitTest.verifyDestroyAllIndexesWhileDoingPuts

[Diane Hardman (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014548#comment-16014548
 ] 

Diane Hardman commented on GEODE-2774:
--

Latest comment from Nabarun in Tracker story:
Unable to reproduce.

> CI failure: LuceneIndexDestroyDUnitTest.verifyDestroyAllIndexesWhileDoingPuts
> -
>
> Key: GEODE-2774
> URL: https://issues.apache.org/jira/browse/GEODE-2774
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Affects Versions: 1.2.0
>Reporter: Shelley Lynn Hughes-Godfrey
>Assignee: Diane Hardman
>  Labels: CI
>
> {noformat}
> :geode-lucene:testClassesat 
> org.apache.geode.internal.Assert.fail(Assert.java:68)
> at 
> org.apache.geode.cache.lucene.LuceneIndexDestroyDUnitTest.verifyDestroyAllIndexesWhileDoingPuts(LuceneIndexDestroyDUnitTest.java:215)
> org.apache.geode.cache.RegionDestroyedException: Partitioned Region 
> @1a3e3379 [path='/region'; dataPolicy=PERSISTENT_PARTITION; prId=76; 
> isDestroyed=false; isClosed=false; retryTimeout=360; serialNumber=1315; 
> partition 
> attributes=PartitionAttributes@1060958737[redundantCopies=0;localMaxMemory=100;totalMaxMemory=2147483647;totalNumBuckets=10;partitionResolver=null;colocatedWith=null;recoveryDelay=-1;startupRecoveryDelay=0;FixedPartitionAttributes=null;partitionListeners=null];
>  on VM 172.17.0.5(154):32770], caused by 
> org.apache.geode.cache.RegionDestroyedException: 
> 172.17.0.5(154):32770@org.apache.geode.internal.cache.PartitionedRegionDataStore@983990329
>  name: /AsyncEventQueue_index1#_region_PARALLEL_GATEWAY_SENDER_QUEUE bucket 
> count: 2, caused by org.apache.geode.cache.RegionDestroyedException: 
> Partitioned Region @32c5de26 
> [path='/AsyncEventQueue_index1#_region_PARALLEL_GATEWAY_SENDER_QUEUE'; 
> dataPolicy=PERSISTENT_PARTITION; prId=78; isDestroyed=true; isClosed=false; 
> retryTimeout=360; serialNumber=1340; partition 
> attributes=PartitionAttributes@2128111693[redundantCopies=0;localMaxMemory=1000;totalMaxMemory=2147483647;totalNumBuckets=10;partitionResolver=null;colocatedWith=/region;recoveryDelay=-1;startupRecoveryDelay=0;FixedPartitionAttributes=null;partitionListeners=null];
>  on VM 172.17.0.5(154):32770]
> at 
> org.apache.geode.internal.cache.PartitionedRegion.virtualPut(PartitionedRegion.java:1954)
> at 
> org.apache.geode.internal.cache.LocalRegionDataView.putEntry(LocalRegionDataView.java:151)
> at 
> org.apache.geode.internal.cache.LocalRegion.basicPut(LocalRegion.java:5194)
> at 
> org.apache.geode.internal.cache.LocalRegion.validatedPut(LocalRegion.java:1605)
> at 
> org.apache.geode.internal.cache.LocalRegion.put(LocalRegion.java:1592)
> at 
> org.apache.geode.internal.cache.AbstractRegion.put(AbstractRegion.java:279)
> at 
> org.apache.geode.cache.lucene.LuceneIndexDestroyDUnitTest.doPutsUntilStopped(LuceneIndexDestroyDUnitTest.java:523)
> at 
> org.apache.geode.cache.lucene.LuceneIndexDestroyDUnitTest.lambda$verifyDestroyAllIndexesWhileDoingPuts$b814fe7d$1(LuceneIndexDestroyDUnitTest.java:197)
> org.apache.geode.cache.RegionDestroyedException: 
> 172.17.0.5(154):32770@org.apache.geode.internal.cache.PartitionedRegionDataStore@983990329
>  name: /AsyncEventQueue_index1#_region_PARALLEL_GATEWAY_SENDER_QUEUE bucket 
> count: 2, caused by org.apache.geode.cache.RegionDestroyedException: 
> Partitioned Region @32c5de26 
> [path='/AsyncEventQueue_index1#_region_PARALLEL_GATEWAY_SENDER_QUEUE'; 
> dataPolicy=PERSISTENT_PARTITION; prId=78; isDestroyed=true; isClosed=false; 
> retryTimeout=360; serialNumber=1340; partition 
> attributes=PartitionAttributes@2128111693[redundantCopies=0;localMaxMemory=1000;totalMaxMemory=2147483647;totalNumBuckets=10;partitionResolver=null;colocatedWith=/region;recoveryDelay=-1;startupRecoveryDelay=0;FixedPartitionAttributes=null;partitionListeners=null];
>  on VM 172.17.0.5(154):32770]
> at 
> org.apache.geode.internal.cache.PartitionedRegionDataStore.grabFreeBucket(PartitionedRegionDataStore.java:482)
> at 
> org.apache.geode.internal.cache.PartitionedRegionDataStore.grabFreeBucketRecursively(PartitionedRegionDataStore.java:282)
> at 
> org.apache.geode.internal.cache.PartitionedRegion.virtualPut(PartitionedRegion.java:1916)
> ... 7 more
> Caused by:
> org.apache.geode.cache.RegionDestroyedException: Partitioned 
> Region @32c5de26 
> [path='/AsyncEventQueue_index1#_region_PARALLEL_GATEWAY_SENDER_QUEUE'; 
> dataPolicy=PERSISTENT_PARTITION; prId=78; isDestroyed=true; isClosed=false; 
> retryTimeout=360; serialNumber=1340; partition 
> attributes=Par

[GitHub] geode pull request #500: GEODE-2662: Gfsh displays field value on wrong line...

[jinmeiliao]

Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/geode/pull/500#discussion_r117080378
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/domain/DataCommandResult.java
 ---
@@ -406,124 +400,140 @@ public Result toCommandResult() {
   section.addData("Message", errorString);
   section.addData(RESULT_FLAG, operationCompletedSuccessfully);
   return ResultBuilder.buildResult(data);
+}
+
+CompositeResultData data = ResultBuilder.createCompositeResultData();
+SectionResultData section = data.addSection();
+TabularResultData table = section.addTable();
+
+section.addData(RESULT_FLAG, operationCompletedSuccessfully);
+if (infoString != null) {
+  section.addData("Message", infoString);
+}
+
+if (isGet()) {
+  toCommandResult_isGet(section, table);
+} else if (isLocateEntry()) {
+  toCommandResult_isLocate(section, table);
+} else if (isPut()) {
+  toCommandResult_isPut(section, table);
+} else if (isRemove()) {
+  toCommandResult_isRemove(section, table);
+} else if (isSelect()) {
+  // its moved to its separate method
--- End diff --

so, for isSelect() we don't do anything? looks like isSelect() is only used 
here, probably we can remove this function? looks like there is a lot of unused 
functions in this class as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #500: GEODE-2662: Gfsh displays field value on wrong line...

[jinmeiliao]

Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/geode/pull/500#discussion_r117081706
  
--- Diff: 
geode-core/src/test/java/org/apache/geode/test/dunit/rules/ServerStarterRule.java
 ---
@@ -145,6 +153,7 @@ public void startServer(boolean pdxPersistent) {
 CacheFactory cf = new CacheFactory(this.properties);
 cf.setPdxReadSerialized(pdxPersistent);
 cf.setPdxPersistent(pdxPersistent);
+this.pdxPersistent = pdxPersistent;
--- End diff --

I don't think we should add this line here. 

we can get rid of this "public void startServer(boolean pdxPersistent)"  
method now since we have withPdxPersistant added. the flag should solely be 
determined by the value of the member variable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Passed: apache/geode-native#305 (pre-modernization - e2630b1)

[Travis CI]

Build Update for apache/geode-native
-

Build: #305
Status: Passed

Duration: 26 minutes and 49 seconds
Commit: e2630b1 (pre-modernization)
Author: masaki.yamakawa
Message: GEDOE-2832: Fixing the link of README.md

Fixed an error in Markdown link notation of README.md.
Delete the space between the display name and the destination URL.
Delete the statements about JCE.

This closes #95

View the changeset: 
https://github.com/apache/geode-native/compare/pre-modernization

View the full build log and details: 
https://travis-ci.org/apache/geode-native/builds/21039?utm_source=email&utm_medium=notification

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

[jira] [Commented] (GEODE-2662) Gfsh displays field value on wrong line!

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014615#comment-16014615
 ] 

ASF GitHub Bot commented on GEODE-2662:
---

Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/geode/pull/500#discussion_r117080378
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/domain/DataCommandResult.java
 ---
@@ -406,124 +400,140 @@ public Result toCommandResult() {
   section.addData("Message", errorString);
   section.addData(RESULT_FLAG, operationCompletedSuccessfully);
   return ResultBuilder.buildResult(data);
+}
+
+CompositeResultData data = ResultBuilder.createCompositeResultData();
+SectionResultData section = data.addSection();
+TabularResultData table = section.addTable();
+
+section.addData(RESULT_FLAG, operationCompletedSuccessfully);
+if (infoString != null) {
+  section.addData("Message", infoString);
+}
+
+if (isGet()) {
+  toCommandResult_isGet(section, table);
+} else if (isLocateEntry()) {
+  toCommandResult_isLocate(section, table);
+} else if (isPut()) {
+  toCommandResult_isPut(section, table);
+} else if (isRemove()) {
+  toCommandResult_isRemove(section, table);
+} else if (isSelect()) {
+  // its moved to its separate method
--- End diff --

so, for isSelect() we don't do anything? looks like isSelect() is only used 
here, probably we can remove this function? looks like there is a lot of unused 
functions in this class as well.


> Gfsh displays field value on wrong line!
> 
>
> Key: GEODE-2662
> URL: https://issues.apache.org/jira/browse/GEODE-2662
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Reporter: Eitan Suez
>Assignee: Patrick Rhomberg
>
> scenario:
> start a locator, a server
> write a client that stores several records of a given type, using pdx 
> serialization
> modify the type in question by adding a field
> write one more record to gemfire, populating all fields, including the new 
> field
> invoke a gfsh query command "select * from /"
> the new field value will display always on the first line of the result set, 
> not on the line associated with the object it actually belongs to.
> example:
> Customer
>  firstName, lastName
> write a customer object:
>  John Doe
> now modify Customer, add telephoneNumber
>  write another customer object:
> Sam Smith, 512.333.
> now run:
> query --query="select c from /Customer c"
> will print:
> firstName | lastName | telephoneNumber
> - |  | ---
> John  | Doe  | 512.333.
> Sam   | Smith| null
> even though the query "select c from /Customer c where c.firstName = 'Sam'" 
> clearly shows the phone number is associated with sam.
> this bug has existed in gemfire at least since v8 and verified to still exist 
> in latest version 9.0.1



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2662) Gfsh displays field value on wrong line!

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014614#comment-16014614
 ] 

ASF GitHub Bot commented on GEODE-2662:
---

Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/geode/pull/500#discussion_r117081706
  
--- Diff: 
geode-core/src/test/java/org/apache/geode/test/dunit/rules/ServerStarterRule.java
 ---
@@ -145,6 +153,7 @@ public void startServer(boolean pdxPersistent) {
 CacheFactory cf = new CacheFactory(this.properties);
 cf.setPdxReadSerialized(pdxPersistent);
 cf.setPdxPersistent(pdxPersistent);
+this.pdxPersistent = pdxPersistent;
--- End diff --

I don't think we should add this line here. 

we can get rid of this "public void startServer(boolean pdxPersistent)"  
method now since we have withPdxPersistant added. the flag should solely be 
determined by the value of the member variable.


> Gfsh displays field value on wrong line!
> 
>
> Key: GEODE-2662
> URL: https://issues.apache.org/jira/browse/GEODE-2662
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Reporter: Eitan Suez
>Assignee: Patrick Rhomberg
>
> scenario:
> start a locator, a server
> write a client that stores several records of a given type, using pdx 
> serialization
> modify the type in question by adding a field
> write one more record to gemfire, populating all fields, including the new 
> field
> invoke a gfsh query command "select * from /"
> the new field value will display always on the first line of the result set, 
> not on the line associated with the object it actually belongs to.
> example:
> Customer
>  firstName, lastName
> write a customer object:
>  John Doe
> now modify Customer, add telephoneNumber
>  write another customer object:
> Sam Smith, 512.333.
> now run:
> query --query="select c from /Customer c"
> will print:
> firstName | lastName | telephoneNumber
> - |  | ---
> John  | Doe  | 512.333.
> Sam   | Smith| null
> even though the query "select c from /Customer c where c.firstName = 'Sam'" 
> clearly shows the phone number is associated with sam.
> this bug has existed in gemfire at least since v8 and verified to still exist 
> in latest version 9.0.1



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2935) Add Events link to Geode site footer

[Joey McAllister (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joey McAllister updated GEODE-2935:
---
Priority: Minor  (was: Major)

> Add Events link to Geode site footer
> 
>
> Key: GEODE-2935
> URL: https://issues.apache.org/jira/browse/GEODE-2935
> Project: Geode
>  Issue Type: Task
>  Components: web-content
>Reporter: Joey McAllister
>Assignee: Joey McAllister
>Priority: Minor
>  Labels: website
>
> From [~mbretl]:
> {quote}
> ASF has created a new tool for scanning TLP sites for compliance and other
> requests. The new tool is located at https://whimsy.apache.org/site, with our 
> own Geode report at https://whimsy.apache.org/site/project/geode. The report 
> looks good, with only one missing requirement of an Events page.
> When I searched for 'event' on the [source of the 
> tool|https://gitbox.apache.org/repos/asf?p=whimsy.git;a=blob_plain;f=tools/site-scan.rb;hb=HEAD],
>  I found http://www.apache.org/events/README.txt, with more event information.
> However, looking at the code, it is searching for: 'apache.org/events/'. So
> we can either create the link as text or use the image as a link.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode issue #517: GEODE-2587: Refactored the OrderByComparator's compare met...

[nabarunnag]

Github user nabarunnag commented on the issue:

https://github.com/apache/geode/pull/517
  
@ladyVader I am assuming that there should be tests already present testing 
the functional aspect. One of the tests did fail and caught an issue in my fix.
@jhuynh1 what do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2587) Refactor OrderByComparator's compare method

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014670#comment-16014670
 ] 

ASF GitHub Bot commented on GEODE-2587:
---

Github user nabarunnag commented on the issue:

https://github.com/apache/geode/pull/517
  
@ladyVader I am assuming that there should be tests already present testing 
the functional aspect. One of the tests did fail and caught an issue in my fix.
@jhuynh1 what do you think?


> Refactor OrderByComparator's compare method
> ---
>
> Key: GEODE-2587
> URL: https://issues.apache.org/jira/browse/GEODE-2587
> Project: Geode
>  Issue Type: Bug
>  Components: querying
>Reporter: nabarun
>
> OrderByComparator's compare method creates a lot of objects / arrays with the 
> intention of comparing two objects.
> But allocation of memory for these objects results in GC to kick in.
> The additional time consumed in GC results in increased execution time for 
> queries with ORDER BY clause.
> This method must be refactored to require less memory allocations in order to 
> compare and thus speed up ORDER BY clause.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2913) Update Lucene documentation

[Karen Smoler Miller (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014738#comment-16014738
 ] 

Karen Smoler Miller commented on GEODE-2913:


The {{destroy lucene index}} gfsh command reference page needs to be corrected. 
 It shows the {{--region}} specification as optional.  It is required.

> Update Lucene documentation
> ---
>
> Key: GEODE-2913
> URL: https://issues.apache.org/jira/browse/GEODE-2913
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>
> Improvements to the code base that need to be reflected in the docs:
> * Change LuceneService.createIndex to use a factory pattern
> {code:java}
> luceneService.createIndex(region, index, ...)
> {code}
> changes to
> {code:java}
> luceneService.createIndexFactory()
> .addField("field1name")
> .addField("field2name")
> .create()
> {code}
> *  Lucene indexes will *NOT* be stored in off-heap memory.
> * Document how to configure an index on accessors - you still need to create 
> the Lucene index before creating the region, even though this member does not 
> hold any region data.
> If the index is not defined on the accessor, an exception like this will be 
> thrown while attempting to create the region:
> {quote}
> [error 2017/05/02 15:19:26.018 PDT  tid=0x1] 
> java.lang.IllegalStateException: Must create Lucene index full_index on 
> region /data because it is defined in another member.
> Exception in thread "main" java.lang.IllegalStateException: Must create 
> Lucene index full_index on region /data because it is defined in another 
> member.
> at 
> org.apache.geode.internal.cache.CreateRegionProcessor$CreateRegionMessage.handleCacheDistributionAdvisee(CreateRegionProcessor.java:478)
> at 
> org.apache.geode.internal.cache.CreateRegionProcessor$CreateRegionMessage.process(CreateRegionProcessor.java:379)
> {quote}
> * Do not need to create a Lucene index on a client with a Proxy cache. The 
> Lucene search will always be done on the server.  Besides, _you can't create 
> an index on a client._
> * If you configure Invalidates for region entries (alone or as part of 
> expiration), these will *NOT* invalidate the Lucene indexes.
> The problem with this is the index contains the keys, but the region doesn't, 
> so the query produces results that don't exist.
> In this test, the first time the query is run, it produces N valid results. 
> The second time it is run it produces N empty results:
> ** load entries
> ** run query
> ** invalidate entries
> ** run query again
> *  Destroying a region will *NOT* automatically destroy any Lucene index 
> associated with that region. Instead, attempting to destroy a region with a 
> Lucene index will throw a colocated region exception. 
> An IllegalStateException is thrown:
> {quote}
> java.lang.IllegalStateException: The parent region [/data] in colocation 
> chain cannot be destroyed, unless all its children 
> [[/cusip_index#_data.files]] are destroyed
> at 
> org.apache.geode.internal.cache.PartitionedRegion.checkForColocatedChildren(PartitionedRegion.java:7231)
> at 
> org.apache.geode.internal.cache.PartitionedRegion.destroyRegion(PartitionedRegion.java:7243)
> at 
> org.apache.geode.internal.cache.AbstractRegion.destroyRegion(AbstractRegion.java:308)
> at 
> DestroyLuceneIndexesAndRegionFunction.destroyRegion(DestroyLuceneIndexesAndRegionFunction.java:46)
> {quote}
> * The process to change a Lucene index using gfsh: 
>   1. export region data
>   2. destroy Lucene index, destroy region 
>   3. create new index, create new region without user-defined business 
> logic callbacks
>   4. import data with option to turn on callbacks (to invoke Lucene Async 
> Event Listener to index the data)
>   5. alter region to add user-defined business logic callbacks
> * Make sure there are no references to replicated regions as they are not 
> supported.
> * Document security implementation and defaults.  If a user has security 
> configured for their cluster, creating a Lucene index requires DATA:MANAGE 
> privilege (similar to OQL), but doing Lucene queries requires DATA:WRITE 
> privilege because a function is called (different from OQL which requires 
> only DATA:READ privilege). Here are all the required privileges for the gfsh 
> commands:
> ** create index requires DATA:MANAGE:region
> ** describe index requires CLUSTER:READ
> ** list indexes requires CLUSTER:READ
> ** search index requires DATA:WRITE
> ** destroy index requires DATA:MANAGE:region
> * A user cannot create a Lucene index on a region that has eviction 
> configured with local destroy. If using Lucene indexing, eviction can only be 
> configured with overflow to disk. In this case, only the region data is 
> overflowed to disk, *NOT* th

[GitHub] geode issue #517: GEODE-2587: Refactored the OrderByComparator's compare met...

[jhuynh1]

Github user jhuynh1 commented on the issue:

https://github.com/apache/geode/pull/517
  
We definitely have order by in the tests, whether or not they are adequate 
I am not sure.  doing a find on "order by" will show a log of queries in the 
tests...
The changes look good to me, if in the future we could collapse common code 
or extract some into smaller methods that would be great.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2587) Refactor OrderByComparator's compare method

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014782#comment-16014782
 ] 

ASF GitHub Bot commented on GEODE-2587:
---

Github user jhuynh1 commented on the issue:

https://github.com/apache/geode/pull/517
  
We definitely have order by in the tests, whether or not they are adequate 
I am not sure.  doing a find on "order by" will show a log of queries in the 
tests...
The changes look good to me, if in the future we could collapse common code 
or extract some into smaller methods that would be great.


> Refactor OrderByComparator's compare method
> ---
>
> Key: GEODE-2587
> URL: https://issues.apache.org/jira/browse/GEODE-2587
> Project: Geode
>  Issue Type: Bug
>  Components: querying
>Reporter: nabarun
>
> OrderByComparator's compare method creates a lot of objects / arrays with the 
> intention of comparing two objects.
> But allocation of memory for these objects results in GC to kick in.
> The additional time consumed in GC results in increased execution time for 
> queries with ORDER BY clause.
> This method must be refactored to require less memory allocations in order to 
> compare and thus speed up ORDER BY clause.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode issue #517: GEODE-2587: Refactored the OrderByComparator's compare met...

[nabarunnag]

Github user nabarunnag commented on the issue:

https://github.com/apache/geode/pull/517
  
Yes, we are opening a new ticket for eliminating the repeated code.
Analyzing the testcode for ORDER BY queries.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2587) Refactor OrderByComparator's compare method

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014797#comment-16014797
 ] 

ASF GitHub Bot commented on GEODE-2587:
---

Github user nabarunnag commented on the issue:

https://github.com/apache/geode/pull/517
  
Yes, we are opening a new ticket for eliminating the repeated code.
Analyzing the testcode for ORDER BY queries.


> Refactor OrderByComparator's compare method
> ---
>
> Key: GEODE-2587
> URL: https://issues.apache.org/jira/browse/GEODE-2587
> Project: Geode
>  Issue Type: Bug
>  Components: querying
>Reporter: nabarun
>
> OrderByComparator's compare method creates a lot of objects / arrays with the 
> intention of comparing two objects.
> But allocation of memory for these objects results in GC to kick in.
> The additional time consumed in GC results in increased execution time for 
> queries with ORDER BY clause.
> This method must be refactored to require less memory allocations in order to 
> compare and thus speed up ORDER BY clause.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #518: GEODE-2913 Update Lucene index documentation

[karensmolermiller]

GitHub user karensmolermiller opened a pull request:

https://github.com/apache/geode/pull/518

GEODE-2913 Update Lucene index documentation

This update needs detailed reviews.  Is the information now correct?  And, 
is there any missing documentation for Lucene indexes?
@joeymcallister @davebarnes97 @upthewaterspout @jhuynh1 @nabarunnag 
@boglesby @dihardman  The more the merrier.  Please review. . .

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karensmolermiller/geode feature/GEODE-2913

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/518.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #518


commit 065b2ccbec3853bcd072240b72ff4e5b9e4fc881
Author: Karen Miller 
Date:   2017-05-17T21:10:42Z

GEODE-2913 Update Lucene index documentation




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2913) Update Lucene documentation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014801#comment-16014801
 ] 

ASF GitHub Bot commented on GEODE-2913:
---

GitHub user karensmolermiller opened a pull request:

https://github.com/apache/geode/pull/518

GEODE-2913 Update Lucene index documentation

This update needs detailed reviews.  Is the information now correct?  And, 
is there any missing documentation for Lucene indexes?
@joeymcallister @davebarnes97 @upthewaterspout @jhuynh1 @nabarunnag 
@boglesby @dihardman  The more the merrier.  Please review. . .

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karensmolermiller/geode feature/GEODE-2913

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/518.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #518


commit 065b2ccbec3853bcd072240b72ff4e5b9e4fc881
Author: Karen Miller 
Date:   2017-05-17T21:10:42Z

GEODE-2913 Update Lucene index documentation




> Update Lucene documentation
> ---
>
> Key: GEODE-2913
> URL: https://issues.apache.org/jira/browse/GEODE-2913
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>
> Improvements to the code base that need to be reflected in the docs:
> * Change LuceneService.createIndex to use a factory pattern
> {code:java}
> luceneService.createIndex(region, index, ...)
> {code}
> changes to
> {code:java}
> luceneService.createIndexFactory()
> .addField("field1name")
> .addField("field2name")
> .create()
> {code}
> *  Lucene indexes will *NOT* be stored in off-heap memory.
> * Document how to configure an index on accessors - you still need to create 
> the Lucene index before creating the region, even though this member does not 
> hold any region data.
> If the index is not defined on the accessor, an exception like this will be 
> thrown while attempting to create the region:
> {quote}
> [error 2017/05/02 15:19:26.018 PDT  tid=0x1] 
> java.lang.IllegalStateException: Must create Lucene index full_index on 
> region /data because it is defined in another member.
> Exception in thread "main" java.lang.IllegalStateException: Must create 
> Lucene index full_index on region /data because it is defined in another 
> member.
> at 
> org.apache.geode.internal.cache.CreateRegionProcessor$CreateRegionMessage.handleCacheDistributionAdvisee(CreateRegionProcessor.java:478)
> at 
> org.apache.geode.internal.cache.CreateRegionProcessor$CreateRegionMessage.process(CreateRegionProcessor.java:379)
> {quote}
> * Do not need to create a Lucene index on a client with a Proxy cache. The 
> Lucene search will always be done on the server.  Besides, _you can't create 
> an index on a client._
> * If you configure Invalidates for region entries (alone or as part of 
> expiration), these will *NOT* invalidate the Lucene indexes.
> The problem with this is the index contains the keys, but the region doesn't, 
> so the query produces results that don't exist.
> In this test, the first time the query is run, it produces N valid results. 
> The second time it is run it produces N empty results:
> ** load entries
> ** run query
> ** invalidate entries
> ** run query again
> *  Destroying a region will *NOT* automatically destroy any Lucene index 
> associated with that region. Instead, attempting to destroy a region with a 
> Lucene index will throw a colocated region exception. 
> An IllegalStateException is thrown:
> {quote}
> java.lang.IllegalStateException: The parent region [/data] in colocation 
> chain cannot be destroyed, unless all its children 
> [[/cusip_index#_data.files]] are destroyed
> at 
> org.apache.geode.internal.cache.PartitionedRegion.checkForColocatedChildren(PartitionedRegion.java:7231)
> at 
> org.apache.geode.internal.cache.PartitionedRegion.destroyRegion(PartitionedRegion.java:7243)
> at 
> org.apache.geode.internal.cache.AbstractRegion.destroyRegion(AbstractRegion.java:308)
> at 
> DestroyLuceneIndexesAndRegionFunction.destroyRegion(DestroyLuceneIndexesAndRegionFunction.java:46)
> {quote}
> * The process to change a Lucene index using gfsh: 
>   1. export region data
>   2. destroy Lucene index, destroy region 
>   3. create new index, create new region without user-defined business 
> logic callbacks
>   4. import data with option to turn on callbacks (to invoke Lucene Async 
> Event Listener to index the data)
>   5. alter region to add user-defined business logic callbacks
> * Make sure there are no references to replicated regions as they are not 
> supported.
> * Document security impleme

[jira] [Commented] (GEODE-2929) Remove superfluous uses of final from classes and methods

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014802#comment-16014802
 ] 

ASF subversion and git services commented on GEODE-2929:


Commit f28c415c84f36c5bad8e3d43b95644eff680b159 in geode's branch 
refs/heads/feature/GEODE-2929-1 from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=f28c415 ]

GEODE-2929: remove superfluous final from methods


> Remove superfluous uses of final from classes and methods
> -
>
> Key: GEODE-2929
> URL: https://issues.apache.org/jira/browse/GEODE-2929
> Project: Geode
>  Issue Type: Wish
>  Components: core
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> Use of final keyword on classes and methods should be reserved for unique 
> situations in the User API where we really need final to prevent a User from 
> overriding something in the API.
> Superfluous usage of final on classes and methods hinders good unit testing 
> by preventing mocking of those classes and methods.
> Any unnecessary usage of final should be removed to facilitate mocking.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2913) Update Lucene documentation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014830#comment-16014830
 ] 

ASF GitHub Bot commented on GEODE-2913:
---

Github user joeymcallister commented on a diff in the pull request:

https://github.com/apache/geode/pull/518#discussion_r117119685
  
--- Diff: geode-docs/tools_modules/lucene_integration.html.md.erb ---
@@ -35,85 +35,67 @@ The Apache Lucene integration:
 For more details, see Javadocs for the classes and interfaces that 
implement Apache Lucene indexes and searches, including
 `LuceneService`, `LuceneQueryFactory`, `LuceneQuery`, and 
`LuceneResultStruct`.
 
-## Using the Apache Lucene Integration
+# Using the Apache Lucene Integration
 
-You can create Apache Lucene indexes through a Java API, through the 
`gfsh` command-line utility, or by means of
-the `cache.xml` configuration file.
+You can interact with Apache Lucene indexes through a Java API,
+through the `gfsh` command-line utility,
+or by means of the `cache.xml` configuration file.
 
-To use Apache Lucene Integration, you will need two pieces of information:
+To use Apache Lucene to create and uses indexes,
+you will need two pieces of information:
 
 1.  The name of the region to be indexed or searched
 2.  The names of the fields you wish to index
 
+## Key Points ###
 
-### Key Points ###
-
+- Apache Lucene indexes are supported only on partitioned regions.
+Replicated region types are *not* supported.
+- Lucene indexes reside on servers.
+There is no way to create a Lucene index on a client.
 - Only top level fields of objects stored in the region can be indexed.
-- Apache Lucene indexes are supported only on Partitioned regions.
 - A single index supports a single region. Indexes do not support multiple 
regions.
 - Heterogeneous objects in single region are supported.
--- End diff --

in "a" single region?


> Update Lucene documentation
> ---
>
> Key: GEODE-2913
> URL: https://issues.apache.org/jira/browse/GEODE-2913
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>
> Improvements to the code base that need to be reflected in the docs:
> * Change LuceneService.createIndex to use a factory pattern
> {code:java}
> luceneService.createIndex(region, index, ...)
> {code}
> changes to
> {code:java}
> luceneService.createIndexFactory()
> .addField("field1name")
> .addField("field2name")
> .create()
> {code}
> *  Lucene indexes will *NOT* be stored in off-heap memory.
> * Document how to configure an index on accessors - you still need to create 
> the Lucene index before creating the region, even though this member does not 
> hold any region data.
> If the index is not defined on the accessor, an exception like this will be 
> thrown while attempting to create the region:
> {quote}
> [error 2017/05/02 15:19:26.018 PDT  tid=0x1] 
> java.lang.IllegalStateException: Must create Lucene index full_index on 
> region /data because it is defined in another member.
> Exception in thread "main" java.lang.IllegalStateException: Must create 
> Lucene index full_index on region /data because it is defined in another 
> member.
> at 
> org.apache.geode.internal.cache.CreateRegionProcessor$CreateRegionMessage.handleCacheDistributionAdvisee(CreateRegionProcessor.java:478)
> at 
> org.apache.geode.internal.cache.CreateRegionProcessor$CreateRegionMessage.process(CreateRegionProcessor.java:379)
> {quote}
> * Do not need to create a Lucene index on a client with a Proxy cache. The 
> Lucene search will always be done on the server.  Besides, _you can't create 
> an index on a client._
> * If you configure Invalidates for region entries (alone or as part of 
> expiration), these will *NOT* invalidate the Lucene indexes.
> The problem with this is the index contains the keys, but the region doesn't, 
> so the query produces results that don't exist.
> In this test, the first time the query is run, it produces N valid results. 
> The second time it is run it produces N empty results:
> ** load entries
> ** run query
> ** invalidate entries
> ** run query again
> *  Destroying a region will *NOT* automatically destroy any Lucene index 
> associated with that region. Instead, attempting to destroy a region with a 
> Lucene index will throw a colocated region exception. 
> An IllegalStateException is thrown:
> {quote}
> java.lang.IllegalStateException: The parent region [/data] in colocation 
> chain cannot be destroyed, unless all its children 
> [[/cusip_index#_data.files]] are destroyed
> at 
> org.apache.geode.internal.cache.PartitionedRegion.checkForColocatedChildren(PartitionedRegion.java:7

[GitHub] geode pull request #518: GEODE-2913 Update Lucene index documentation

[joeymcallister]

Github user joeymcallister commented on a diff in the pull request:

https://github.com/apache/geode/pull/518#discussion_r117119685
  
--- Diff: geode-docs/tools_modules/lucene_integration.html.md.erb ---
@@ -35,85 +35,67 @@ The Apache Lucene integration:
 For more details, see Javadocs for the classes and interfaces that 
implement Apache Lucene indexes and searches, including
 `LuceneService`, `LuceneQueryFactory`, `LuceneQuery`, and 
`LuceneResultStruct`.
 
-## Using the Apache Lucene Integration
+# Using the Apache Lucene Integration
 
-You can create Apache Lucene indexes through a Java API, through the 
`gfsh` command-line utility, or by means of
-the `cache.xml` configuration file.
+You can interact with Apache Lucene indexes through a Java API,
+through the `gfsh` command-line utility,
+or by means of the `cache.xml` configuration file.
 
-To use Apache Lucene Integration, you will need two pieces of information:
+To use Apache Lucene to create and uses indexes,
+you will need two pieces of information:
 
 1.  The name of the region to be indexed or searched
 2.  The names of the fields you wish to index
 
+## Key Points ###
 
-### Key Points ###
-
+- Apache Lucene indexes are supported only on partitioned regions.
+Replicated region types are *not* supported.
+- Lucene indexes reside on servers.
+There is no way to create a Lucene index on a client.
 - Only top level fields of objects stored in the region can be indexed.
-- Apache Lucene indexes are supported only on Partitioned regions.
 - A single index supports a single region. Indexes do not support multiple 
regions.
 - Heterogeneous objects in single region are supported.
--- End diff --

in "a" single region?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #518: GEODE-2913 Update Lucene index documentation

[joeymcallister]

Github user joeymcallister commented on a diff in the pull request:

https://github.com/apache/geode/pull/518#discussion_r117121920
  
--- Diff: geode-docs/tools_modules/lucene_integration.html.md.erb ---
@@ -135,4 +117,164 @@ gfsh> lucene search --regionName=/orders 
-queryStrings="John*" --defaultField=fi
 
 
 ```
+## Queries
 
+### Gfsh Example to 
Query using a Lucene Index
+
+For details, see the [gfsh search 
lucene](gfsh/command-pages/search.html#search_lucene") command reference page.
+
+``` pre
+gfsh> lucene search --regionName=/orders -queryStrings="John*" 
--defaultField=field1 --limit=100
+```
+
+### Java API Example 
to Query using a Lucene Index
+
+``` pre
+LuceneQuery query = 
luceneService.createLuceneQueryFactory()
+  .setResultLimit(10)
+  .create(indexName, regionName, "name:John AND zipcode:97006", 
defaultField);
+
+Collection results = query.findValues();
+```
+
+## Destroying an 
Index
+
+Since a region destroy operation does not cause the destruction
+of any Lucene indexes,
+destroy any Lucene indexes prior to destroying the associated region.
+
+### Java API Example 
to Destroy a Lucene Index
+
+``` pre
+luceneService.destroyIndex(indexName, regionName);
+```
+An attempt to destroy a region with a Lucene index will result in
+an `IllegalStateException`,
+issuing an error message similar to:
+
+``` pre
+java.lang.IllegalStateException: The parent region [/orders] in colocation 
chain cannot be destroyed,
+ unless all its children [[/indexName#_orders.files]] are destroyed
+at 
org.apache.geode.internal.cache.PartitionedRegion.checkForColocatedChildren(PartitionedRegion.java:7231)
+at 
org.apache.geode.internal.cache.PartitionedRegion.destroyRegion(PartitionedRegion.java:7243)
+at 
org.apache.geode.internal.cache.AbstractRegion.destroyRegion(AbstractRegion.java:308)
+at 
DestroyLuceneIndexesAndRegionFunction.destroyRegion(DestroyLuceneIndexesAndRegionFunction.java:46)
+```
+### Gfsh Example to 
Destroy a Lucene Index
+
+For details, see the [gfsh destroy lucene 
index](gfsh/command-pages/destroy.html#destroy_lucene_index") command reference 
page.
+
+The error message that results from an attempt to destroy a region
+prior to destroying its associated Lucene index
+issues an error message similar to:
+
+``` pre
+Error occurred while destroying region "orders".
+ Reason: The parent region [/orders] in colocation chain cannot be 
destroyed,
+ unless all its children [[/indexName#_orders.files]] are destroyed
+```
+
+## Changing an Index
+
+Changing an index requires rebuilding it.
+Implement these steps in `gfsh` to change an index.
--- End diff --

Change period to colon after "index."


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2913) Update Lucene documentation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014843#comment-16014843
 ] 

ASF GitHub Bot commented on GEODE-2913:
---

Github user joeymcallister commented on a diff in the pull request:

https://github.com/apache/geode/pull/518#discussion_r117121920
  
--- Diff: geode-docs/tools_modules/lucene_integration.html.md.erb ---
@@ -135,4 +117,164 @@ gfsh> lucene search --regionName=/orders 
-queryStrings="John*" --defaultField=fi
 
 
 ```
+## Queries
 
+### Gfsh Example to 
Query using a Lucene Index
+
+For details, see the [gfsh search 
lucene](gfsh/command-pages/search.html#search_lucene") command reference page.
+
+``` pre
+gfsh> lucene search --regionName=/orders -queryStrings="John*" 
--defaultField=field1 --limit=100
+```
+
+### Java API Example 
to Query using a Lucene Index
+
+``` pre
+LuceneQuery query = 
luceneService.createLuceneQueryFactory()
+  .setResultLimit(10)
+  .create(indexName, regionName, "name:John AND zipcode:97006", 
defaultField);
+
+Collection results = query.findValues();
+```
+
+## Destroying an 
Index
+
+Since a region destroy operation does not cause the destruction
+of any Lucene indexes,
+destroy any Lucene indexes prior to destroying the associated region.
+
+### Java API Example 
to Destroy a Lucene Index
+
+``` pre
+luceneService.destroyIndex(indexName, regionName);
+```
+An attempt to destroy a region with a Lucene index will result in
+an `IllegalStateException`,
+issuing an error message similar to:
+
+``` pre
+java.lang.IllegalStateException: The parent region [/orders] in colocation 
chain cannot be destroyed,
+ unless all its children [[/indexName#_orders.files]] are destroyed
+at 
org.apache.geode.internal.cache.PartitionedRegion.checkForColocatedChildren(PartitionedRegion.java:7231)
+at 
org.apache.geode.internal.cache.PartitionedRegion.destroyRegion(PartitionedRegion.java:7243)
+at 
org.apache.geode.internal.cache.AbstractRegion.destroyRegion(AbstractRegion.java:308)
+at 
DestroyLuceneIndexesAndRegionFunction.destroyRegion(DestroyLuceneIndexesAndRegionFunction.java:46)
+```
+### Gfsh Example to 
Destroy a Lucene Index
+
+For details, see the [gfsh destroy lucene 
index](gfsh/command-pages/destroy.html#destroy_lucene_index") command reference 
page.
+
+The error message that results from an attempt to destroy a region
+prior to destroying its associated Lucene index
+issues an error message similar to:
+
+``` pre
+Error occurred while destroying region "orders".
+ Reason: The parent region [/orders] in colocation chain cannot be 
destroyed,
+ unless all its children [[/indexName#_orders.files]] are destroyed
+```
+
+## Changing an Index
+
+Changing an index requires rebuilding it.
+Implement these steps in `gfsh` to change an index.
--- End diff --

Change period to colon after "index."


> Update Lucene documentation
> ---
>
> Key: GEODE-2913
> URL: https://issues.apache.org/jira/browse/GEODE-2913
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>
> Improvements to the code base that need to be reflected in the docs:
> * Change LuceneService.createIndex to use a factory pattern
> {code:java}
> luceneService.createIndex(region, index, ...)
> {code}
> changes to
> {code:java}
> luceneService.createIndexFactory()
> .addField("field1name")
> .addField("field2name")
> .create()
> {code}
> *  Lucene indexes will *NOT* be stored in off-heap memory.
> * Document how to configure an index on accessors - you still need to create 
> the Lucene index before creating the region, even though this member does not 
> hold any region data.
> If the index is not defined on the accessor, an exception like this will be 
> thrown while attempting to create the region:
> {quote}
> [error 2017/05/02 15:19:26.018 PDT  tid=0x1] 
> java.lang.IllegalStateException: Must create Lucene index full_index on 
> region /data because it is defined in another member.
> Exception in thread "main" java.lang.IllegalStateException: Must create 
> Lucene index full_index on region /data because it is defined in another 
> member.
> at 
> org.apache.geode.internal.cache.CreateRegionProcessor$CreateRegionMessage.handleCacheDistributionAdvisee(CreateRegionProcessor.java:478)
> at 
> org.apache.geode.internal.cache.CreateRegionProcessor$CreateRegionMessage.process(CreateRegionProcessor.java:379)
> {quote}
> * Do not need to create a Lucene index on a client with a Proxy cache. The 
> Lucene search will always be done on the 

[GitHub] geode pull request #518: GEODE-2913 Update Lucene index documentation

[joeymcallister]

Github user joeymcallister commented on a diff in the pull request:

https://github.com/apache/geode/pull/518#discussion_r117122461
  
--- Diff: geode-docs/tools_modules/lucene_integration.html.md.erb ---
@@ -135,4 +117,164 @@ gfsh> lucene search --regionName=/orders 
-queryStrings="John*" --defaultField=fi
 
 
 ```
+## Queries
 
+### Gfsh Example to 
Query using a Lucene Index
+
+For details, see the [gfsh search 
lucene](gfsh/command-pages/search.html#search_lucene") command reference page.
+
+``` pre
+gfsh> lucene search --regionName=/orders -queryStrings="John*" 
--defaultField=field1 --limit=100
+```
+
+### Java API Example 
to Query using a Lucene Index
+
+``` pre
+LuceneQuery query = 
luceneService.createLuceneQueryFactory()
+  .setResultLimit(10)
+  .create(indexName, regionName, "name:John AND zipcode:97006", 
defaultField);
+
+Collection results = query.findValues();
+```
+
+## Destroying an 
Index
+
+Since a region destroy operation does not cause the destruction
+of any Lucene indexes,
+destroy any Lucene indexes prior to destroying the associated region.
+
+### Java API Example 
to Destroy a Lucene Index
+
+``` pre
+luceneService.destroyIndex(indexName, regionName);
+```
+An attempt to destroy a region with a Lucene index will result in
+an `IllegalStateException`,
+issuing an error message similar to:
+
+``` pre
+java.lang.IllegalStateException: The parent region [/orders] in colocation 
chain cannot be destroyed,
+ unless all its children [[/indexName#_orders.files]] are destroyed
+at 
org.apache.geode.internal.cache.PartitionedRegion.checkForColocatedChildren(PartitionedRegion.java:7231)
+at 
org.apache.geode.internal.cache.PartitionedRegion.destroyRegion(PartitionedRegion.java:7243)
+at 
org.apache.geode.internal.cache.AbstractRegion.destroyRegion(AbstractRegion.java:308)
+at 
DestroyLuceneIndexesAndRegionFunction.destroyRegion(DestroyLuceneIndexesAndRegionFunction.java:46)
+```
+### Gfsh Example to 
Destroy a Lucene Index
+
+For details, see the [gfsh destroy lucene 
index](gfsh/command-pages/destroy.html#destroy_lucene_index") command reference 
page.
+
+The error message that results from an attempt to destroy a region
+prior to destroying its associated Lucene index
+issues an error message similar to:
+
+``` pre
+Error occurred while destroying region "orders".
+ Reason: The parent region [/orders] in colocation chain cannot be 
destroyed,
+ unless all its children [[/indexName#_orders.files]] are destroyed
+```
+
+## Changing an Index
+
+Changing an index requires rebuilding it.
+Implement these steps in `gfsh` to change an index.
+
+1. Export all region data
+2. Destroy the Lucene index
+3. Destroy the region
+4. Create a new index
+5. Create a new region without the user-defined business logic callbacks
+6. Import the region data with the option to turn on callbacks. 
+The callbacks will be to invoke a Lucene async event listener to index
+the data.
+7. Alter the region to add the user-defined business logic callbacks
+
+## Additional Gfsh Commands
+
+See the [gfsh describe lucene 
index](gfsh/command-pages/describe.html#describe_lucene_index") command 
reference page for the command that prints details about
+a specific index.
+
+See the [gfsh list lucene 
index](gfsh/command-pages/list.html#list_lucene_index") command reference page
+for the command that prints details about the 
+Lucene indexes created for all members.
+
+# Requirements and Caveats
+
+- Join queries between regions are not supported.
+- Nested objects are not supported.
+- Lucene indexes will not be stored within off-heap memory.
+- Lucene queries from within transactions are not supported.
+On an attempt to query from within a transaction,
+a `LuceneQueryException` is thrown, issuing an error message
+on the client (accessor) similar to:
+
+``` pre
+Exception in thread "main" 
org.apache.geode.cache.lucene.LuceneQueryException:
+ Lucene Query cannot be executed within a transaction
+at 
org.apache.geode.cache.lucene.internal.LuceneQueryImpl.findTopEntries(LuceneQueryImpl.java:124)
+at 
org.apache.geode.cache.lucene.internal.LuceneQueryImpl.findPages(LuceneQueryImpl.java:98)
+at 
org.apache.geode.cache.lucene.internal.LuceneQueryImpl.findPages(LuceneQueryImpl.java:94)
+at TestClient.executeQuerySingleMethod(TestClient.java:196)
+at TestClient.main(TestClient.java:59)
+```
+- If the Lucene index is not created prior to creating the region,
+an exception will be thrown while attempting to create the region,
+issuing an error message simlar to:
+
+``` pre
+[error 2017/05/

[jira] [Commented] (GEODE-2913) Update Lucene documentation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014848#comment-16014848
 ] 

ASF GitHub Bot commented on GEODE-2913:
---

Github user joeymcallister commented on a diff in the pull request:

https://github.com/apache/geode/pull/518#discussion_r117122461
  
--- Diff: geode-docs/tools_modules/lucene_integration.html.md.erb ---
@@ -135,4 +117,164 @@ gfsh> lucene search --regionName=/orders 
-queryStrings="John*" --defaultField=fi
 
 
 ```
+## Queries
 
+### Gfsh Example to 
Query using a Lucene Index
+
+For details, see the [gfsh search 
lucene](gfsh/command-pages/search.html#search_lucene") command reference page.
+
+``` pre
+gfsh> lucene search --regionName=/orders -queryStrings="John*" 
--defaultField=field1 --limit=100
+```
+
+### Java API Example 
to Query using a Lucene Index
+
+``` pre
+LuceneQuery query = 
luceneService.createLuceneQueryFactory()
+  .setResultLimit(10)
+  .create(indexName, regionName, "name:John AND zipcode:97006", 
defaultField);
+
+Collection results = query.findValues();
+```
+
+## Destroying an 
Index
+
+Since a region destroy operation does not cause the destruction
+of any Lucene indexes,
+destroy any Lucene indexes prior to destroying the associated region.
+
+### Java API Example 
to Destroy a Lucene Index
+
+``` pre
+luceneService.destroyIndex(indexName, regionName);
+```
+An attempt to destroy a region with a Lucene index will result in
+an `IllegalStateException`,
+issuing an error message similar to:
+
+``` pre
+java.lang.IllegalStateException: The parent region [/orders] in colocation 
chain cannot be destroyed,
+ unless all its children [[/indexName#_orders.files]] are destroyed
+at 
org.apache.geode.internal.cache.PartitionedRegion.checkForColocatedChildren(PartitionedRegion.java:7231)
+at 
org.apache.geode.internal.cache.PartitionedRegion.destroyRegion(PartitionedRegion.java:7243)
+at 
org.apache.geode.internal.cache.AbstractRegion.destroyRegion(AbstractRegion.java:308)
+at 
DestroyLuceneIndexesAndRegionFunction.destroyRegion(DestroyLuceneIndexesAndRegionFunction.java:46)
+```
+### Gfsh Example to 
Destroy a Lucene Index
+
+For details, see the [gfsh destroy lucene 
index](gfsh/command-pages/destroy.html#destroy_lucene_index") command reference 
page.
+
+The error message that results from an attempt to destroy a region
+prior to destroying its associated Lucene index
+issues an error message similar to:
+
+``` pre
+Error occurred while destroying region "orders".
+ Reason: The parent region [/orders] in colocation chain cannot be 
destroyed,
+ unless all its children [[/indexName#_orders.files]] are destroyed
+```
+
+## Changing an Index
+
+Changing an index requires rebuilding it.
+Implement these steps in `gfsh` to change an index.
+
+1. Export all region data
+2. Destroy the Lucene index
+3. Destroy the region
+4. Create a new index
+5. Create a new region without the user-defined business logic callbacks
+6. Import the region data with the option to turn on callbacks. 
+The callbacks will be to invoke a Lucene async event listener to index
+the data.
+7. Alter the region to add the user-defined business logic callbacks
+
+## Additional Gfsh Commands
+
+See the [gfsh describe lucene 
index](gfsh/command-pages/describe.html#describe_lucene_index") command 
reference page for the command that prints details about
+a specific index.
+
+See the [gfsh list lucene 
index](gfsh/command-pages/list.html#list_lucene_index") command reference page
+for the command that prints details about the 
+Lucene indexes created for all members.
+
+# Requirements and Caveats
+
+- Join queries between regions are not supported.
+- Nested objects are not supported.
+- Lucene indexes will not be stored within off-heap memory.
+- Lucene queries from within transactions are not supported.
+On an attempt to query from within a transaction,
+a `LuceneQueryException` is thrown, issuing an error message
+on the client (accessor) similar to:
+
+``` pre
+Exception in thread "main" 
org.apache.geode.cache.lucene.LuceneQueryException:
+ Lucene Query cannot be executed within a transaction
+at 
org.apache.geode.cache.lucene.internal.LuceneQueryImpl.findTopEntries(LuceneQueryImpl.java:124)
+at 
org.apache.geode.cache.lucene.internal.LuceneQueryImpl.findPages(LuceneQueryImpl.java:98)
+at 
org.apache.geode.cache.lucene.internal.LuceneQueryImpl.findPages(LuceneQueryImpl.java:94)
+at TestClient.executeQuerySingleMethod(TestClient.java:196)
+at TestClient.ma

[GitHub] geode pull request #518: GEODE-2913 Update Lucene index documentation

[joeymcallister]

Github user joeymcallister commented on a diff in the pull request:

https://github.com/apache/geode/pull/518#discussion_r117122540
  
--- Diff: geode-docs/tools_modules/lucene_integration.html.md.erb ---
@@ -135,4 +117,164 @@ gfsh> lucene search --regionName=/orders 
-queryStrings="John*" --defaultField=fi
 
 
 ```
+## Queries
 
+### Gfsh Example to 
Query using a Lucene Index
+
+For details, see the [gfsh search 
lucene](gfsh/command-pages/search.html#search_lucene") command reference page.
+
+``` pre
+gfsh> lucene search --regionName=/orders -queryStrings="John*" 
--defaultField=field1 --limit=100
+```
+
+### Java API Example 
to Query using a Lucene Index
+
+``` pre
+LuceneQuery query = 
luceneService.createLuceneQueryFactory()
+  .setResultLimit(10)
+  .create(indexName, regionName, "name:John AND zipcode:97006", 
defaultField);
+
+Collection results = query.findValues();
+```
+
+## Destroying an 
Index
+
+Since a region destroy operation does not cause the destruction
+of any Lucene indexes,
+destroy any Lucene indexes prior to destroying the associated region.
+
+### Java API Example 
to Destroy a Lucene Index
+
+``` pre
+luceneService.destroyIndex(indexName, regionName);
+```
+An attempt to destroy a region with a Lucene index will result in
+an `IllegalStateException`,
+issuing an error message similar to:
+
+``` pre
+java.lang.IllegalStateException: The parent region [/orders] in colocation 
chain cannot be destroyed,
+ unless all its children [[/indexName#_orders.files]] are destroyed
+at 
org.apache.geode.internal.cache.PartitionedRegion.checkForColocatedChildren(PartitionedRegion.java:7231)
+at 
org.apache.geode.internal.cache.PartitionedRegion.destroyRegion(PartitionedRegion.java:7243)
+at 
org.apache.geode.internal.cache.AbstractRegion.destroyRegion(AbstractRegion.java:308)
+at 
DestroyLuceneIndexesAndRegionFunction.destroyRegion(DestroyLuceneIndexesAndRegionFunction.java:46)
+```
+### Gfsh Example to 
Destroy a Lucene Index
+
+For details, see the [gfsh destroy lucene 
index](gfsh/command-pages/destroy.html#destroy_lucene_index") command reference 
page.
+
+The error message that results from an attempt to destroy a region
+prior to destroying its associated Lucene index
+issues an error message similar to:
+
+``` pre
+Error occurred while destroying region "orders".
+ Reason: The parent region [/orders] in colocation chain cannot be 
destroyed,
+ unless all its children [[/indexName#_orders.files]] are destroyed
+```
+
+## Changing an Index
+
+Changing an index requires rebuilding it.
+Implement these steps in `gfsh` to change an index.
+
+1. Export all region data
+2. Destroy the Lucene index
+3. Destroy the region
+4. Create a new index
+5. Create a new region without the user-defined business logic callbacks
+6. Import the region data with the option to turn on callbacks. 
+The callbacks will be to invoke a Lucene async event listener to index
+the data.
+7. Alter the region to add the user-defined business logic callbacks
+
+## Additional Gfsh Commands
+
+See the [gfsh describe lucene 
index](gfsh/command-pages/describe.html#describe_lucene_index") command 
reference page for the command that prints details about
+a specific index.
+
+See the [gfsh list lucene 
index](gfsh/command-pages/list.html#list_lucene_index") command reference page
+for the command that prints details about the 
+Lucene indexes created for all members.
+
+# Requirements and Caveats
+
+- Join queries between regions are not supported.
+- Nested objects are not supported.
+- Lucene indexes will not be stored within off-heap memory.
+- Lucene queries from within transactions are not supported.
+On an attempt to query from within a transaction,
+a `LuceneQueryException` is thrown, issuing an error message
+on the client (accessor) similar to:
+
+``` pre
+Exception in thread "main" 
org.apache.geode.cache.lucene.LuceneQueryException:
+ Lucene Query cannot be executed within a transaction
+at 
org.apache.geode.cache.lucene.internal.LuceneQueryImpl.findTopEntries(LuceneQueryImpl.java:124)
+at 
org.apache.geode.cache.lucene.internal.LuceneQueryImpl.findPages(LuceneQueryImpl.java:98)
+at 
org.apache.geode.cache.lucene.internal.LuceneQueryImpl.findPages(LuceneQueryImpl.java:94)
+at TestClient.executeQuerySingleMethod(TestClient.java:196)
+at TestClient.main(TestClient.java:59)
+```
+- If the Lucene index is not created prior to creating the region,
+an exception will be thrown while attempting to create the region,
+issuing an error message simlar to:
+
+``` pre
+[error 2017/05/

[jira] [Commented] (GEODE-2913) Update Lucene documentation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014849#comment-16014849
 ] 

ASF GitHub Bot commented on GEODE-2913:
---

Github user joeymcallister commented on a diff in the pull request:

https://github.com/apache/geode/pull/518#discussion_r117122540
  
--- Diff: geode-docs/tools_modules/lucene_integration.html.md.erb ---
@@ -135,4 +117,164 @@ gfsh> lucene search --regionName=/orders 
-queryStrings="John*" --defaultField=fi
 
 
 ```
+## Queries
 
+### Gfsh Example to 
Query using a Lucene Index
+
+For details, see the [gfsh search 
lucene](gfsh/command-pages/search.html#search_lucene") command reference page.
+
+``` pre
+gfsh> lucene search --regionName=/orders -queryStrings="John*" 
--defaultField=field1 --limit=100
+```
+
+### Java API Example 
to Query using a Lucene Index
+
+``` pre
+LuceneQuery query = 
luceneService.createLuceneQueryFactory()
+  .setResultLimit(10)
+  .create(indexName, regionName, "name:John AND zipcode:97006", 
defaultField);
+
+Collection results = query.findValues();
+```
+
+## Destroying an 
Index
+
+Since a region destroy operation does not cause the destruction
+of any Lucene indexes,
+destroy any Lucene indexes prior to destroying the associated region.
+
+### Java API Example 
to Destroy a Lucene Index
+
+``` pre
+luceneService.destroyIndex(indexName, regionName);
+```
+An attempt to destroy a region with a Lucene index will result in
+an `IllegalStateException`,
+issuing an error message similar to:
+
+``` pre
+java.lang.IllegalStateException: The parent region [/orders] in colocation 
chain cannot be destroyed,
+ unless all its children [[/indexName#_orders.files]] are destroyed
+at 
org.apache.geode.internal.cache.PartitionedRegion.checkForColocatedChildren(PartitionedRegion.java:7231)
+at 
org.apache.geode.internal.cache.PartitionedRegion.destroyRegion(PartitionedRegion.java:7243)
+at 
org.apache.geode.internal.cache.AbstractRegion.destroyRegion(AbstractRegion.java:308)
+at 
DestroyLuceneIndexesAndRegionFunction.destroyRegion(DestroyLuceneIndexesAndRegionFunction.java:46)
+```
+### Gfsh Example to 
Destroy a Lucene Index
+
+For details, see the [gfsh destroy lucene 
index](gfsh/command-pages/destroy.html#destroy_lucene_index") command reference 
page.
+
+The error message that results from an attempt to destroy a region
+prior to destroying its associated Lucene index
+issues an error message similar to:
+
+``` pre
+Error occurred while destroying region "orders".
+ Reason: The parent region [/orders] in colocation chain cannot be 
destroyed,
+ unless all its children [[/indexName#_orders.files]] are destroyed
+```
+
+## Changing an Index
+
+Changing an index requires rebuilding it.
+Implement these steps in `gfsh` to change an index.
+
+1. Export all region data
+2. Destroy the Lucene index
+3. Destroy the region
+4. Create a new index
+5. Create a new region without the user-defined business logic callbacks
+6. Import the region data with the option to turn on callbacks. 
+The callbacks will be to invoke a Lucene async event listener to index
+the data.
+7. Alter the region to add the user-defined business logic callbacks
+
+## Additional Gfsh Commands
+
+See the [gfsh describe lucene 
index](gfsh/command-pages/describe.html#describe_lucene_index") command 
reference page for the command that prints details about
+a specific index.
+
+See the [gfsh list lucene 
index](gfsh/command-pages/list.html#list_lucene_index") command reference page
+for the command that prints details about the 
+Lucene indexes created for all members.
+
+# Requirements and Caveats
+
+- Join queries between regions are not supported.
+- Nested objects are not supported.
+- Lucene indexes will not be stored within off-heap memory.
+- Lucene queries from within transactions are not supported.
+On an attempt to query from within a transaction,
+a `LuceneQueryException` is thrown, issuing an error message
+on the client (accessor) similar to:
+
+``` pre
+Exception in thread "main" 
org.apache.geode.cache.lucene.LuceneQueryException:
+ Lucene Query cannot be executed within a transaction
+at 
org.apache.geode.cache.lucene.internal.LuceneQueryImpl.findTopEntries(LuceneQueryImpl.java:124)
+at 
org.apache.geode.cache.lucene.internal.LuceneQueryImpl.findPages(LuceneQueryImpl.java:98)
+at 
org.apache.geode.cache.lucene.internal.LuceneQueryImpl.findPages(LuceneQueryImpl.java:94)
+at TestClient.executeQuerySingleMethod(TestClient.java:196)
+at TestClient.ma

[GitHub] geode pull request #518: GEODE-2913 Update Lucene index documentation

[joeymcallister]

Github user joeymcallister commented on a diff in the pull request:

https://github.com/apache/geode/pull/518#discussion_r117122734
  
--- Diff: geode-docs/tools_modules/lucene_integration.html.md.erb ---
@@ -135,4 +117,164 @@ gfsh> lucene search --regionName=/orders 
-queryStrings="John*" --defaultField=fi
 
 
 ```
+## Queries
 
+### Gfsh Example to 
Query using a Lucene Index
+
+For details, see the [gfsh search 
lucene](gfsh/command-pages/search.html#search_lucene") command reference page.
+
+``` pre
+gfsh> lucene search --regionName=/orders -queryStrings="John*" 
--defaultField=field1 --limit=100
+```
+
+### Java API Example 
to Query using a Lucene Index
+
+``` pre
+LuceneQuery query = 
luceneService.createLuceneQueryFactory()
+  .setResultLimit(10)
+  .create(indexName, regionName, "name:John AND zipcode:97006", 
defaultField);
+
+Collection results = query.findValues();
+```
+
+## Destroying an 
Index
+
+Since a region destroy operation does not cause the destruction
+of any Lucene indexes,
+destroy any Lucene indexes prior to destroying the associated region.
+
+### Java API Example 
to Destroy a Lucene Index
+
+``` pre
+luceneService.destroyIndex(indexName, regionName);
+```
+An attempt to destroy a region with a Lucene index will result in
+an `IllegalStateException`,
+issuing an error message similar to:
+
+``` pre
+java.lang.IllegalStateException: The parent region [/orders] in colocation 
chain cannot be destroyed,
+ unless all its children [[/indexName#_orders.files]] are destroyed
+at 
org.apache.geode.internal.cache.PartitionedRegion.checkForColocatedChildren(PartitionedRegion.java:7231)
+at 
org.apache.geode.internal.cache.PartitionedRegion.destroyRegion(PartitionedRegion.java:7243)
+at 
org.apache.geode.internal.cache.AbstractRegion.destroyRegion(AbstractRegion.java:308)
+at 
DestroyLuceneIndexesAndRegionFunction.destroyRegion(DestroyLuceneIndexesAndRegionFunction.java:46)
+```
+### Gfsh Example to 
Destroy a Lucene Index
+
+For details, see the [gfsh destroy lucene 
index](gfsh/command-pages/destroy.html#destroy_lucene_index") command reference 
page.
+
+The error message that results from an attempt to destroy a region
+prior to destroying its associated Lucene index
+issues an error message similar to:
+
+``` pre
+Error occurred while destroying region "orders".
+ Reason: The parent region [/orders] in colocation chain cannot be 
destroyed,
+ unless all its children [[/indexName#_orders.files]] are destroyed
+```
+
+## Changing an Index
+
+Changing an index requires rebuilding it.
+Implement these steps in `gfsh` to change an index.
+
+1. Export all region data
+2. Destroy the Lucene index
+3. Destroy the region
+4. Create a new index
+5. Create a new region without the user-defined business logic callbacks
+6. Import the region data with the option to turn on callbacks. 
+The callbacks will be to invoke a Lucene async event listener to index
+the data.
+7. Alter the region to add the user-defined business logic callbacks
+
+## Additional Gfsh Commands
+
+See the [gfsh describe lucene 
index](gfsh/command-pages/describe.html#describe_lucene_index") command 
reference page for the command that prints details about
+a specific index.
+
+See the [gfsh list lucene 
index](gfsh/command-pages/list.html#list_lucene_index") command reference page
+for the command that prints details about the 
+Lucene indexes created for all members.
+
+# Requirements and Caveats
+
+- Join queries between regions are not supported.
+- Nested objects are not supported.
+- Lucene indexes will not be stored within off-heap memory.
+- Lucene queries from within transactions are not supported.
+On an attempt to query from within a transaction,
+a `LuceneQueryException` is thrown, issuing an error message
+on the client (accessor) similar to:
+
+``` pre
+Exception in thread "main" 
org.apache.geode.cache.lucene.LuceneQueryException:
+ Lucene Query cannot be executed within a transaction
+at 
org.apache.geode.cache.lucene.internal.LuceneQueryImpl.findTopEntries(LuceneQueryImpl.java:124)
+at 
org.apache.geode.cache.lucene.internal.LuceneQueryImpl.findPages(LuceneQueryImpl.java:98)
+at 
org.apache.geode.cache.lucene.internal.LuceneQueryImpl.findPages(LuceneQueryImpl.java:94)
+at TestClient.executeQuerySingleMethod(TestClient.java:196)
+at TestClient.main(TestClient.java:59)
+```
+- If the Lucene index is not created prior to creating the region,
+an exception will be thrown while attempting to create the region,
+issuing an error message simlar to:
+
+``` pre
+[error 2017/05/

[jira] [Commented] (GEODE-2913) Update Lucene documentation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014851#comment-16014851
 ] 

ASF GitHub Bot commented on GEODE-2913:
---

Github user joeymcallister commented on a diff in the pull request:

https://github.com/apache/geode/pull/518#discussion_r117122734
  
--- Diff: geode-docs/tools_modules/lucene_integration.html.md.erb ---
@@ -135,4 +117,164 @@ gfsh> lucene search --regionName=/orders 
-queryStrings="John*" --defaultField=fi
 
 
 ```
+## Queries
 
+### Gfsh Example to 
Query using a Lucene Index
+
+For details, see the [gfsh search 
lucene](gfsh/command-pages/search.html#search_lucene") command reference page.
+
+``` pre
+gfsh> lucene search --regionName=/orders -queryStrings="John*" 
--defaultField=field1 --limit=100
+```
+
+### Java API Example 
to Query using a Lucene Index
+
+``` pre
+LuceneQuery query = 
luceneService.createLuceneQueryFactory()
+  .setResultLimit(10)
+  .create(indexName, regionName, "name:John AND zipcode:97006", 
defaultField);
+
+Collection results = query.findValues();
+```
+
+## Destroying an 
Index
+
+Since a region destroy operation does not cause the destruction
+of any Lucene indexes,
+destroy any Lucene indexes prior to destroying the associated region.
+
+### Java API Example 
to Destroy a Lucene Index
+
+``` pre
+luceneService.destroyIndex(indexName, regionName);
+```
+An attempt to destroy a region with a Lucene index will result in
+an `IllegalStateException`,
+issuing an error message similar to:
+
+``` pre
+java.lang.IllegalStateException: The parent region [/orders] in colocation 
chain cannot be destroyed,
+ unless all its children [[/indexName#_orders.files]] are destroyed
+at 
org.apache.geode.internal.cache.PartitionedRegion.checkForColocatedChildren(PartitionedRegion.java:7231)
+at 
org.apache.geode.internal.cache.PartitionedRegion.destroyRegion(PartitionedRegion.java:7243)
+at 
org.apache.geode.internal.cache.AbstractRegion.destroyRegion(AbstractRegion.java:308)
+at 
DestroyLuceneIndexesAndRegionFunction.destroyRegion(DestroyLuceneIndexesAndRegionFunction.java:46)
+```
+### Gfsh Example to 
Destroy a Lucene Index
+
+For details, see the [gfsh destroy lucene 
index](gfsh/command-pages/destroy.html#destroy_lucene_index") command reference 
page.
+
+The error message that results from an attempt to destroy a region
+prior to destroying its associated Lucene index
+issues an error message similar to:
+
+``` pre
+Error occurred while destroying region "orders".
+ Reason: The parent region [/orders] in colocation chain cannot be 
destroyed,
+ unless all its children [[/indexName#_orders.files]] are destroyed
+```
+
+## Changing an Index
+
+Changing an index requires rebuilding it.
+Implement these steps in `gfsh` to change an index.
+
+1. Export all region data
+2. Destroy the Lucene index
+3. Destroy the region
+4. Create a new index
+5. Create a new region without the user-defined business logic callbacks
+6. Import the region data with the option to turn on callbacks. 
+The callbacks will be to invoke a Lucene async event listener to index
+the data.
+7. Alter the region to add the user-defined business logic callbacks
+
+## Additional Gfsh Commands
+
+See the [gfsh describe lucene 
index](gfsh/command-pages/describe.html#describe_lucene_index") command 
reference page for the command that prints details about
+a specific index.
+
+See the [gfsh list lucene 
index](gfsh/command-pages/list.html#list_lucene_index") command reference page
+for the command that prints details about the 
+Lucene indexes created for all members.
+
+# Requirements and Caveats
+
+- Join queries between regions are not supported.
+- Nested objects are not supported.
+- Lucene indexes will not be stored within off-heap memory.
+- Lucene queries from within transactions are not supported.
+On an attempt to query from within a transaction,
+a `LuceneQueryException` is thrown, issuing an error message
+on the client (accessor) similar to:
+
+``` pre
+Exception in thread "main" 
org.apache.geode.cache.lucene.LuceneQueryException:
+ Lucene Query cannot be executed within a transaction
+at 
org.apache.geode.cache.lucene.internal.LuceneQueryImpl.findTopEntries(LuceneQueryImpl.java:124)
+at 
org.apache.geode.cache.lucene.internal.LuceneQueryImpl.findPages(LuceneQueryImpl.java:98)
+at 
org.apache.geode.cache.lucene.internal.LuceneQueryImpl.findPages(LuceneQueryImpl.java:94)
+at TestClient.executeQuerySingleMethod(TestClient.java:196)
+at TestClient.ma

[GitHub] geode pull request #518: GEODE-2913 Update Lucene index documentation

[joeymcallister]

Github user joeymcallister commented on a diff in the pull request:

https://github.com/apache/geode/pull/518#discussion_r117122942
  
--- Diff: geode-docs/tools_modules/lucene_integration.html.md.erb ---
@@ -135,4 +117,164 @@ gfsh> lucene search --regionName=/orders 
-queryStrings="John*" --defaultField=fi
 
 
 ```
+## Queries
 
+### Gfsh Example to 
Query using a Lucene Index
+
+For details, see the [gfsh search 
lucene](gfsh/command-pages/search.html#search_lucene") command reference page.
+
+``` pre
+gfsh> lucene search --regionName=/orders -queryStrings="John*" 
--defaultField=field1 --limit=100
+```
+
+### Java API Example 
to Query using a Lucene Index
+
+``` pre
+LuceneQuery query = 
luceneService.createLuceneQueryFactory()
+  .setResultLimit(10)
+  .create(indexName, regionName, "name:John AND zipcode:97006", 
defaultField);
+
+Collection results = query.findValues();
+```
+
+## Destroying an 
Index
+
+Since a region destroy operation does not cause the destruction
+of any Lucene indexes,
+destroy any Lucene indexes prior to destroying the associated region.
+
+### Java API Example 
to Destroy a Lucene Index
+
+``` pre
+luceneService.destroyIndex(indexName, regionName);
+```
+An attempt to destroy a region with a Lucene index will result in
+an `IllegalStateException`,
+issuing an error message similar to:
+
+``` pre
+java.lang.IllegalStateException: The parent region [/orders] in colocation 
chain cannot be destroyed,
+ unless all its children [[/indexName#_orders.files]] are destroyed
+at 
org.apache.geode.internal.cache.PartitionedRegion.checkForColocatedChildren(PartitionedRegion.java:7231)
+at 
org.apache.geode.internal.cache.PartitionedRegion.destroyRegion(PartitionedRegion.java:7243)
+at 
org.apache.geode.internal.cache.AbstractRegion.destroyRegion(AbstractRegion.java:308)
+at 
DestroyLuceneIndexesAndRegionFunction.destroyRegion(DestroyLuceneIndexesAndRegionFunction.java:46)
+```
+### Gfsh Example to 
Destroy a Lucene Index
+
+For details, see the [gfsh destroy lucene 
index](gfsh/command-pages/destroy.html#destroy_lucene_index") command reference 
page.
+
+The error message that results from an attempt to destroy a region
+prior to destroying its associated Lucene index
+issues an error message similar to:
+
+``` pre
+Error occurred while destroying region "orders".
+ Reason: The parent region [/orders] in colocation chain cannot be 
destroyed,
+ unless all its children [[/indexName#_orders.files]] are destroyed
+```
+
+## Changing an Index
+
+Changing an index requires rebuilding it.
+Implement these steps in `gfsh` to change an index.
+
+1. Export all region data
+2. Destroy the Lucene index
+3. Destroy the region
+4. Create a new index
+5. Create a new region without the user-defined business logic callbacks
+6. Import the region data with the option to turn on callbacks. 
+The callbacks will be to invoke a Lucene async event listener to index
+the data.
+7. Alter the region to add the user-defined business logic callbacks
+
+## Additional Gfsh Commands
+
+See the [gfsh describe lucene 
index](gfsh/command-pages/describe.html#describe_lucene_index") command 
reference page for the command that prints details about
+a specific index.
+
+See the [gfsh list lucene 
index](gfsh/command-pages/list.html#list_lucene_index") command reference page
+for the command that prints details about the 
+Lucene indexes created for all members.
+
+# Requirements and Caveats
+
+- Join queries between regions are not supported.
+- Nested objects are not supported.
+- Lucene indexes will not be stored within off-heap memory.
+- Lucene queries from within transactions are not supported.
+On an attempt to query from within a transaction,
+a `LuceneQueryException` is thrown, issuing an error message
+on the client (accessor) similar to:
+
+``` pre
+Exception in thread "main" 
org.apache.geode.cache.lucene.LuceneQueryException:
+ Lucene Query cannot be executed within a transaction
+at 
org.apache.geode.cache.lucene.internal.LuceneQueryImpl.findTopEntries(LuceneQueryImpl.java:124)
+at 
org.apache.geode.cache.lucene.internal.LuceneQueryImpl.findPages(LuceneQueryImpl.java:98)
+at 
org.apache.geode.cache.lucene.internal.LuceneQueryImpl.findPages(LuceneQueryImpl.java:94)
+at TestClient.executeQuerySingleMethod(TestClient.java:196)
+at TestClient.main(TestClient.java:59)
+```
+- If the Lucene index is not created prior to creating the region,
+an exception will be thrown while attempting to create the region,
+issuing an error message simlar to:
--- End diff --

"similar"

[jira] [Commented] (GEODE-2913) Update Lucene documentation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014852#comment-16014852
 ] 

ASF GitHub Bot commented on GEODE-2913:
---

Github user joeymcallister commented on a diff in the pull request:

https://github.com/apache/geode/pull/518#discussion_r117122942
  
--- Diff: geode-docs/tools_modules/lucene_integration.html.md.erb ---
@@ -135,4 +117,164 @@ gfsh> lucene search --regionName=/orders 
-queryStrings="John*" --defaultField=fi
 
 
 ```
+## Queries
 
+### Gfsh Example to 
Query using a Lucene Index
+
+For details, see the [gfsh search 
lucene](gfsh/command-pages/search.html#search_lucene") command reference page.
+
+``` pre
+gfsh> lucene search --regionName=/orders -queryStrings="John*" 
--defaultField=field1 --limit=100
+```
+
+### Java API Example 
to Query using a Lucene Index
+
+``` pre
+LuceneQuery query = 
luceneService.createLuceneQueryFactory()
+  .setResultLimit(10)
+  .create(indexName, regionName, "name:John AND zipcode:97006", 
defaultField);
+
+Collection results = query.findValues();
+```
+
+## Destroying an 
Index
+
+Since a region destroy operation does not cause the destruction
+of any Lucene indexes,
+destroy any Lucene indexes prior to destroying the associated region.
+
+### Java API Example 
to Destroy a Lucene Index
+
+``` pre
+luceneService.destroyIndex(indexName, regionName);
+```
+An attempt to destroy a region with a Lucene index will result in
+an `IllegalStateException`,
+issuing an error message similar to:
+
+``` pre
+java.lang.IllegalStateException: The parent region [/orders] in colocation 
chain cannot be destroyed,
+ unless all its children [[/indexName#_orders.files]] are destroyed
+at 
org.apache.geode.internal.cache.PartitionedRegion.checkForColocatedChildren(PartitionedRegion.java:7231)
+at 
org.apache.geode.internal.cache.PartitionedRegion.destroyRegion(PartitionedRegion.java:7243)
+at 
org.apache.geode.internal.cache.AbstractRegion.destroyRegion(AbstractRegion.java:308)
+at 
DestroyLuceneIndexesAndRegionFunction.destroyRegion(DestroyLuceneIndexesAndRegionFunction.java:46)
+```
+### Gfsh Example to 
Destroy a Lucene Index
+
+For details, see the [gfsh destroy lucene 
index](gfsh/command-pages/destroy.html#destroy_lucene_index") command reference 
page.
+
+The error message that results from an attempt to destroy a region
+prior to destroying its associated Lucene index
+issues an error message similar to:
+
+``` pre
+Error occurred while destroying region "orders".
+ Reason: The parent region [/orders] in colocation chain cannot be 
destroyed,
+ unless all its children [[/indexName#_orders.files]] are destroyed
+```
+
+## Changing an Index
+
+Changing an index requires rebuilding it.
+Implement these steps in `gfsh` to change an index.
+
+1. Export all region data
+2. Destroy the Lucene index
+3. Destroy the region
+4. Create a new index
+5. Create a new region without the user-defined business logic callbacks
+6. Import the region data with the option to turn on callbacks. 
+The callbacks will be to invoke a Lucene async event listener to index
+the data.
+7. Alter the region to add the user-defined business logic callbacks
+
+## Additional Gfsh Commands
+
+See the [gfsh describe lucene 
index](gfsh/command-pages/describe.html#describe_lucene_index") command 
reference page for the command that prints details about
+a specific index.
+
+See the [gfsh list lucene 
index](gfsh/command-pages/list.html#list_lucene_index") command reference page
+for the command that prints details about the 
+Lucene indexes created for all members.
+
+# Requirements and Caveats
+
+- Join queries between regions are not supported.
+- Nested objects are not supported.
+- Lucene indexes will not be stored within off-heap memory.
+- Lucene queries from within transactions are not supported.
+On an attempt to query from within a transaction,
+a `LuceneQueryException` is thrown, issuing an error message
+on the client (accessor) similar to:
+
+``` pre
+Exception in thread "main" 
org.apache.geode.cache.lucene.LuceneQueryException:
+ Lucene Query cannot be executed within a transaction
+at 
org.apache.geode.cache.lucene.internal.LuceneQueryImpl.findTopEntries(LuceneQueryImpl.java:124)
+at 
org.apache.geode.cache.lucene.internal.LuceneQueryImpl.findPages(LuceneQueryImpl.java:98)
+at 
org.apache.geode.cache.lucene.internal.LuceneQueryImpl.findPages(LuceneQueryImpl.java:94)
+at TestClient.executeQuerySingleMethod(TestClient.java:196)
+at TestClient.ma

[GitHub] geode pull request #518: GEODE-2913 Update Lucene index documentation

[joeymcallister]

Github user joeymcallister commented on a diff in the pull request:

https://github.com/apache/geode/pull/518#discussion_r117123228
  
--- Diff: geode-docs/tools_modules/lucene_integration.html.md.erb ---
@@ -135,4 +117,164 @@ gfsh> lucene search --regionName=/orders 
-queryStrings="John*" --defaultField=fi
 
 
 ```
+## Queries
 
+### Gfsh Example to 
Query using a Lucene Index
+
+For details, see the [gfsh search 
lucene](gfsh/command-pages/search.html#search_lucene") command reference page.
+
+``` pre
+gfsh> lucene search --regionName=/orders -queryStrings="John*" 
--defaultField=field1 --limit=100
+```
+
+### Java API Example 
to Query using a Lucene Index
+
+``` pre
+LuceneQuery query = 
luceneService.createLuceneQueryFactory()
+  .setResultLimit(10)
+  .create(indexName, regionName, "name:John AND zipcode:97006", 
defaultField);
+
+Collection results = query.findValues();
+```
+
+## Destroying an 
Index
+
+Since a region destroy operation does not cause the destruction
+of any Lucene indexes,
+destroy any Lucene indexes prior to destroying the associated region.
+
+### Java API Example 
to Destroy a Lucene Index
+
+``` pre
+luceneService.destroyIndex(indexName, regionName);
+```
+An attempt to destroy a region with a Lucene index will result in
+an `IllegalStateException`,
+issuing an error message similar to:
+
+``` pre
+java.lang.IllegalStateException: The parent region [/orders] in colocation 
chain cannot be destroyed,
+ unless all its children [[/indexName#_orders.files]] are destroyed
+at 
org.apache.geode.internal.cache.PartitionedRegion.checkForColocatedChildren(PartitionedRegion.java:7231)
+at 
org.apache.geode.internal.cache.PartitionedRegion.destroyRegion(PartitionedRegion.java:7243)
+at 
org.apache.geode.internal.cache.AbstractRegion.destroyRegion(AbstractRegion.java:308)
+at 
DestroyLuceneIndexesAndRegionFunction.destroyRegion(DestroyLuceneIndexesAndRegionFunction.java:46)
+```
+### Gfsh Example to 
Destroy a Lucene Index
+
+For details, see the [gfsh destroy lucene 
index](gfsh/command-pages/destroy.html#destroy_lucene_index") command reference 
page.
+
+The error message that results from an attempt to destroy a region
+prior to destroying its associated Lucene index
+issues an error message similar to:
+
+``` pre
+Error occurred while destroying region "orders".
+ Reason: The parent region [/orders] in colocation chain cannot be 
destroyed,
+ unless all its children [[/indexName#_orders.files]] are destroyed
+```
+
+## Changing an Index
+
+Changing an index requires rebuilding it.
+Implement these steps in `gfsh` to change an index.
+
+1. Export all region data
+2. Destroy the Lucene index
+3. Destroy the region
+4. Create a new index
+5. Create a new region without the user-defined business logic callbacks
+6. Import the region data with the option to turn on callbacks. 
+The callbacks will be to invoke a Lucene async event listener to index
+the data.
+7. Alter the region to add the user-defined business logic callbacks
+
+## Additional Gfsh Commands
+
+See the [gfsh describe lucene 
index](gfsh/command-pages/describe.html#describe_lucene_index") command 
reference page for the command that prints details about
+a specific index.
+
+See the [gfsh list lucene 
index](gfsh/command-pages/list.html#list_lucene_index") command reference page
+for the command that prints details about the 
+Lucene indexes created for all members.
+
+# Requirements and Caveats
+
+- Join queries between regions are not supported.
+- Nested objects are not supported.
+- Lucene indexes will not be stored within off-heap memory.
+- Lucene queries from within transactions are not supported.
+On an attempt to query from within a transaction,
+a `LuceneQueryException` is thrown, issuing an error message
+on the client (accessor) similar to:
+
+``` pre
+Exception in thread "main" 
org.apache.geode.cache.lucene.LuceneQueryException:
+ Lucene Query cannot be executed within a transaction
+at 
org.apache.geode.cache.lucene.internal.LuceneQueryImpl.findTopEntries(LuceneQueryImpl.java:124)
+at 
org.apache.geode.cache.lucene.internal.LuceneQueryImpl.findPages(LuceneQueryImpl.java:98)
+at 
org.apache.geode.cache.lucene.internal.LuceneQueryImpl.findPages(LuceneQueryImpl.java:94)
+at TestClient.executeQuerySingleMethod(TestClient.java:196)
+at TestClient.main(TestClient.java:59)
+```
+- If the Lucene index is not created prior to creating the region,
+an exception will be thrown while attempting to create the region,
+issuing an error message simlar to:
+
+``` pre
+[error 2017/05/

[jira] [Commented] (GEODE-2913) Update Lucene documentation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014853#comment-16014853
 ] 

ASF GitHub Bot commented on GEODE-2913:
---

Github user joeymcallister commented on a diff in the pull request:

https://github.com/apache/geode/pull/518#discussion_r117123228
  
--- Diff: geode-docs/tools_modules/lucene_integration.html.md.erb ---
@@ -135,4 +117,164 @@ gfsh> lucene search --regionName=/orders 
-queryStrings="John*" --defaultField=fi
 
 
 ```
+## Queries
 
+### Gfsh Example to 
Query using a Lucene Index
+
+For details, see the [gfsh search 
lucene](gfsh/command-pages/search.html#search_lucene") command reference page.
+
+``` pre
+gfsh> lucene search --regionName=/orders -queryStrings="John*" 
--defaultField=field1 --limit=100
+```
+
+### Java API Example 
to Query using a Lucene Index
+
+``` pre
+LuceneQuery query = 
luceneService.createLuceneQueryFactory()
+  .setResultLimit(10)
+  .create(indexName, regionName, "name:John AND zipcode:97006", 
defaultField);
+
+Collection results = query.findValues();
+```
+
+## Destroying an 
Index
+
+Since a region destroy operation does not cause the destruction
+of any Lucene indexes,
+destroy any Lucene indexes prior to destroying the associated region.
+
+### Java API Example 
to Destroy a Lucene Index
+
+``` pre
+luceneService.destroyIndex(indexName, regionName);
+```
+An attempt to destroy a region with a Lucene index will result in
+an `IllegalStateException`,
+issuing an error message similar to:
+
+``` pre
+java.lang.IllegalStateException: The parent region [/orders] in colocation 
chain cannot be destroyed,
+ unless all its children [[/indexName#_orders.files]] are destroyed
+at 
org.apache.geode.internal.cache.PartitionedRegion.checkForColocatedChildren(PartitionedRegion.java:7231)
+at 
org.apache.geode.internal.cache.PartitionedRegion.destroyRegion(PartitionedRegion.java:7243)
+at 
org.apache.geode.internal.cache.AbstractRegion.destroyRegion(AbstractRegion.java:308)
+at 
DestroyLuceneIndexesAndRegionFunction.destroyRegion(DestroyLuceneIndexesAndRegionFunction.java:46)
+```
+### Gfsh Example to 
Destroy a Lucene Index
+
+For details, see the [gfsh destroy lucene 
index](gfsh/command-pages/destroy.html#destroy_lucene_index") command reference 
page.
+
+The error message that results from an attempt to destroy a region
+prior to destroying its associated Lucene index
+issues an error message similar to:
+
+``` pre
+Error occurred while destroying region "orders".
+ Reason: The parent region [/orders] in colocation chain cannot be 
destroyed,
+ unless all its children [[/indexName#_orders.files]] are destroyed
+```
+
+## Changing an Index
+
+Changing an index requires rebuilding it.
+Implement these steps in `gfsh` to change an index.
+
+1. Export all region data
+2. Destroy the Lucene index
+3. Destroy the region
+4. Create a new index
+5. Create a new region without the user-defined business logic callbacks
+6. Import the region data with the option to turn on callbacks. 
+The callbacks will be to invoke a Lucene async event listener to index
+the data.
+7. Alter the region to add the user-defined business logic callbacks
+
+## Additional Gfsh Commands
+
+See the [gfsh describe lucene 
index](gfsh/command-pages/describe.html#describe_lucene_index") command 
reference page for the command that prints details about
+a specific index.
+
+See the [gfsh list lucene 
index](gfsh/command-pages/list.html#list_lucene_index") command reference page
+for the command that prints details about the 
+Lucene indexes created for all members.
+
+# Requirements and Caveats
+
+- Join queries between regions are not supported.
+- Nested objects are not supported.
+- Lucene indexes will not be stored within off-heap memory.
+- Lucene queries from within transactions are not supported.
+On an attempt to query from within a transaction,
+a `LuceneQueryException` is thrown, issuing an error message
+on the client (accessor) similar to:
+
+``` pre
+Exception in thread "main" 
org.apache.geode.cache.lucene.LuceneQueryException:
+ Lucene Query cannot be executed within a transaction
+at 
org.apache.geode.cache.lucene.internal.LuceneQueryImpl.findTopEntries(LuceneQueryImpl.java:124)
+at 
org.apache.geode.cache.lucene.internal.LuceneQueryImpl.findPages(LuceneQueryImpl.java:98)
+at 
org.apache.geode.cache.lucene.internal.LuceneQueryImpl.findPages(LuceneQueryImpl.java:94)
+at TestClient.executeQuerySingleMethod(TestClient.java:196)
+at TestClient.ma

[GitHub] geode pull request #518: GEODE-2913 Update Lucene index documentation

[joeymcallister]

Github user joeymcallister commented on a diff in the pull request:

https://github.com/apache/geode/pull/518#discussion_r117123398
  
--- Diff: geode-docs/tools_modules/lucene_integration.html.md.erb ---
@@ -135,4 +117,164 @@ gfsh> lucene search --regionName=/orders 
-queryStrings="John*" --defaultField=fi
 
 
 ```
+## Queries
 
+### Gfsh Example to 
Query using a Lucene Index
+
+For details, see the [gfsh search 
lucene](gfsh/command-pages/search.html#search_lucene") command reference page.
+
+``` pre
+gfsh> lucene search --regionName=/orders -queryStrings="John*" 
--defaultField=field1 --limit=100
+```
+
+### Java API Example 
to Query using a Lucene Index
+
+``` pre
+LuceneQuery query = 
luceneService.createLuceneQueryFactory()
+  .setResultLimit(10)
+  .create(indexName, regionName, "name:John AND zipcode:97006", 
defaultField);
+
+Collection results = query.findValues();
+```
+
+## Destroying an 
Index
+
+Since a region destroy operation does not cause the destruction
+of any Lucene indexes,
+destroy any Lucene indexes prior to destroying the associated region.
+
+### Java API Example 
to Destroy a Lucene Index
+
+``` pre
+luceneService.destroyIndex(indexName, regionName);
+```
+An attempt to destroy a region with a Lucene index will result in
+an `IllegalStateException`,
+issuing an error message similar to:
+
+``` pre
+java.lang.IllegalStateException: The parent region [/orders] in colocation 
chain cannot be destroyed,
+ unless all its children [[/indexName#_orders.files]] are destroyed
+at 
org.apache.geode.internal.cache.PartitionedRegion.checkForColocatedChildren(PartitionedRegion.java:7231)
+at 
org.apache.geode.internal.cache.PartitionedRegion.destroyRegion(PartitionedRegion.java:7243)
+at 
org.apache.geode.internal.cache.AbstractRegion.destroyRegion(AbstractRegion.java:308)
+at 
DestroyLuceneIndexesAndRegionFunction.destroyRegion(DestroyLuceneIndexesAndRegionFunction.java:46)
+```
+### Gfsh Example to 
Destroy a Lucene Index
+
+For details, see the [gfsh destroy lucene 
index](gfsh/command-pages/destroy.html#destroy_lucene_index") command reference 
page.
+
+The error message that results from an attempt to destroy a region
+prior to destroying its associated Lucene index
+issues an error message similar to:
+
+``` pre
+Error occurred while destroying region "orders".
+ Reason: The parent region [/orders] in colocation chain cannot be 
destroyed,
+ unless all its children [[/indexName#_orders.files]] are destroyed
+```
+
+## Changing an Index
+
+Changing an index requires rebuilding it.
+Implement these steps in `gfsh` to change an index.
+
+1. Export all region data
+2. Destroy the Lucene index
+3. Destroy the region
+4. Create a new index
+5. Create a new region without the user-defined business logic callbacks
+6. Import the region data with the option to turn on callbacks. 
+The callbacks will be to invoke a Lucene async event listener to index
+the data.
+7. Alter the region to add the user-defined business logic callbacks
+
+## Additional Gfsh Commands
+
+See the [gfsh describe lucene 
index](gfsh/command-pages/describe.html#describe_lucene_index") command 
reference page for the command that prints details about
+a specific index.
+
+See the [gfsh list lucene 
index](gfsh/command-pages/list.html#list_lucene_index") command reference page
+for the command that prints details about the 
+Lucene indexes created for all members.
+
+# Requirements and Caveats
+
+- Join queries between regions are not supported.
+- Nested objects are not supported.
+- Lucene indexes will not be stored within off-heap memory.
+- Lucene queries from within transactions are not supported.
+On an attempt to query from within a transaction,
+a `LuceneQueryException` is thrown, issuing an error message
+on the client (accessor) similar to:
+
+``` pre
+Exception in thread "main" 
org.apache.geode.cache.lucene.LuceneQueryException:
+ Lucene Query cannot be executed within a transaction
+at 
org.apache.geode.cache.lucene.internal.LuceneQueryImpl.findTopEntries(LuceneQueryImpl.java:124)
+at 
org.apache.geode.cache.lucene.internal.LuceneQueryImpl.findPages(LuceneQueryImpl.java:98)
+at 
org.apache.geode.cache.lucene.internal.LuceneQueryImpl.findPages(LuceneQueryImpl.java:94)
+at TestClient.executeQuerySingleMethod(TestClient.java:196)
+at TestClient.main(TestClient.java:59)
+```
+- If the Lucene index is not created prior to creating the region,
+an exception will be thrown while attempting to create the region,
+issuing an error message simlar to:
+
+``` pre
+[error 2017/05/

[jira] [Commented] (GEODE-2913) Update Lucene documentation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014856#comment-16014856
 ] 

ASF GitHub Bot commented on GEODE-2913:
---

Github user joeymcallister commented on a diff in the pull request:

https://github.com/apache/geode/pull/518#discussion_r117123398
  
--- Diff: geode-docs/tools_modules/lucene_integration.html.md.erb ---
@@ -135,4 +117,164 @@ gfsh> lucene search --regionName=/orders 
-queryStrings="John*" --defaultField=fi
 
 
 ```
+## Queries
 
+### Gfsh Example to 
Query using a Lucene Index
+
+For details, see the [gfsh search 
lucene](gfsh/command-pages/search.html#search_lucene") command reference page.
+
+``` pre
+gfsh> lucene search --regionName=/orders -queryStrings="John*" 
--defaultField=field1 --limit=100
+```
+
+### Java API Example 
to Query using a Lucene Index
+
+``` pre
+LuceneQuery query = 
luceneService.createLuceneQueryFactory()
+  .setResultLimit(10)
+  .create(indexName, regionName, "name:John AND zipcode:97006", 
defaultField);
+
+Collection results = query.findValues();
+```
+
+## Destroying an 
Index
+
+Since a region destroy operation does not cause the destruction
+of any Lucene indexes,
+destroy any Lucene indexes prior to destroying the associated region.
+
+### Java API Example 
to Destroy a Lucene Index
+
+``` pre
+luceneService.destroyIndex(indexName, regionName);
+```
+An attempt to destroy a region with a Lucene index will result in
+an `IllegalStateException`,
+issuing an error message similar to:
+
+``` pre
+java.lang.IllegalStateException: The parent region [/orders] in colocation 
chain cannot be destroyed,
+ unless all its children [[/indexName#_orders.files]] are destroyed
+at 
org.apache.geode.internal.cache.PartitionedRegion.checkForColocatedChildren(PartitionedRegion.java:7231)
+at 
org.apache.geode.internal.cache.PartitionedRegion.destroyRegion(PartitionedRegion.java:7243)
+at 
org.apache.geode.internal.cache.AbstractRegion.destroyRegion(AbstractRegion.java:308)
+at 
DestroyLuceneIndexesAndRegionFunction.destroyRegion(DestroyLuceneIndexesAndRegionFunction.java:46)
+```
+### Gfsh Example to 
Destroy a Lucene Index
+
+For details, see the [gfsh destroy lucene 
index](gfsh/command-pages/destroy.html#destroy_lucene_index") command reference 
page.
+
+The error message that results from an attempt to destroy a region
+prior to destroying its associated Lucene index
+issues an error message similar to:
+
+``` pre
+Error occurred while destroying region "orders".
+ Reason: The parent region [/orders] in colocation chain cannot be 
destroyed,
+ unless all its children [[/indexName#_orders.files]] are destroyed
+```
+
+## Changing an Index
+
+Changing an index requires rebuilding it.
+Implement these steps in `gfsh` to change an index.
+
+1. Export all region data
+2. Destroy the Lucene index
+3. Destroy the region
+4. Create a new index
+5. Create a new region without the user-defined business logic callbacks
+6. Import the region data with the option to turn on callbacks. 
+The callbacks will be to invoke a Lucene async event listener to index
+the data.
+7. Alter the region to add the user-defined business logic callbacks
+
+## Additional Gfsh Commands
+
+See the [gfsh describe lucene 
index](gfsh/command-pages/describe.html#describe_lucene_index") command 
reference page for the command that prints details about
+a specific index.
+
+See the [gfsh list lucene 
index](gfsh/command-pages/list.html#list_lucene_index") command reference page
+for the command that prints details about the 
+Lucene indexes created for all members.
+
+# Requirements and Caveats
+
+- Join queries between regions are not supported.
+- Nested objects are not supported.
+- Lucene indexes will not be stored within off-heap memory.
+- Lucene queries from within transactions are not supported.
+On an attempt to query from within a transaction,
+a `LuceneQueryException` is thrown, issuing an error message
+on the client (accessor) similar to:
+
+``` pre
+Exception in thread "main" 
org.apache.geode.cache.lucene.LuceneQueryException:
+ Lucene Query cannot be executed within a transaction
+at 
org.apache.geode.cache.lucene.internal.LuceneQueryImpl.findTopEntries(LuceneQueryImpl.java:124)
+at 
org.apache.geode.cache.lucene.internal.LuceneQueryImpl.findPages(LuceneQueryImpl.java:98)
+at 
org.apache.geode.cache.lucene.internal.LuceneQueryImpl.findPages(LuceneQueryImpl.java:94)
+at TestClient.executeQuerySingleMethod(TestClient.java:196)
+at TestClient.ma

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #557 has FAILED (2 tests failed). Change made by John Blum.

[Spring CI]

---
Spring Data GemFire > Nightly-ApacheGeode > #557 failed.
---
Scheduled with changes by John Blum.
2/1850 tests failed.

https://build.spring.io/browse/SGF-NAG-557/

-
Currently Responsible
-

No one is responsible for fixing this build.



--
Failing Jobs
--
  - Default Job (Default Stage): 2 of 1850 tests failed.



--
Code Changes
--
John Blum (2a021f79b42acfad163cd2f35579d140ed5457b6):

>DATAGEODE-11 - Adapt to API changes in the 
>org.apache.geode.internal.InternalDataSerializer class.



--
Tests
--
New Test Failures (2)
   - LuceneOperationsIntegrationTests: Finds master does as type user 
successfully
   - LuceneOperationsIntegrationTests: Finds doctor does as type person 
successfully

--
This message is automatically generated by Atlassian Bamboo

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #557 was SUCCESSFUL (with 1848 tests). Change made by John Blum.

[Spring CI]

---
Spring Data GemFire > Nightly-ApacheGeode > #557 was successful (rerun once).
---
This build was rerun by John Blum.
1850 tests in total.

https://build.spring.io/browse/SGF-NAG-557/




--
Code Changes
--
John Blum (2a021f79b42acfad163cd2f35579d140ed5457b6):

>DATAGEODE-11 - Adapt to API changes in the 
>org.apache.geode.internal.InternalDataSerializer class.



--
This message is automatically generated by Atlassian Bamboo

org.apache.geode.internal.InternalDataSerializer API Changes...

[John Blum]

Geode devs-

I am not sure how decisions are made when changing Geode's API, but I would
caution that more care should be taken when doing so, regardless of whether
the APIs are public or not, but especially when they are public.

Unfortunately, in this particular case, the API in question is deemed
"internal", which I know, are subject to change.  However, the problem with
this is, the public API is insufficient in some cases, particularly for
"frameworks" (e.g. SDG) and "tooling" building on Geode and attempting to
uphold Geode's functional/behavioral contract.

By way of example, a recent *Spring Data Geode* build broke
 [1] because, the
org.apache.geode.internal.InternalDataSerializer class was recently
changed. The scope of getSerializer(:Class):DataSerializer was changed
from *public
*
[2]
to *private
*
[3]
in a seemingly unrelated commit.

There is a class

[4]
in SDG that extends DataSerializer

[5]
(in Geode's public API) but must use the InternalDataSerializer (internal
Geode API) when changes (e.g. "supported classes") to the SDG serializer
need to be "distributed" across the cluster.  SDG"s serializer use to call
this getSerializer(:Class):DataSerializer method.  However, in this case, I
fixed the problem by not calling this "overloaded" method as it was not
strictly necessary.

While I am trying to avoid the use of "internal" Geode classes and APIs in
SDG in general, as I mention above, this is not always possible.  For
instance, there are a few API blunders such as the ability to register

[6]
a DataSerializer class but not "unregister" it; that is in

[7]
InternalDataSerializer.  The other bad API practices on this class (i.e.
(Internal)DataSerializer) alone.

Framework and tool developers must occasionally rely on "internal" APIs
(especially when the public API is insufficient) to order to achieve a
similar experience to Geode alone; something to keep in mind as Geode's
ecosystem grows.

Finally, I'll also add that, I do need to know anytime the public API
changes as well.  Recently the getOnlineLocators() method

[8]
was added to org.apache.geode.cache.client.Pool, which caused another SDG
build  [9] to fail.

Special thank you to *Nabarun* and *Diane* for the recent heads about the
LuceneQueryFactory method name change... from setResultLimit(:int) to
setLimit(:int).

Regards,

-- 
-John


[1] https://build.spring.io/browse/SGF-NAG-556/log
[2]
https://github.com/apache/geode/blob/rel/v1.1.1/geode-core/src/main/java/org/apache/geode/internal/InternalDataSerializer.java#L1113
[3]
https://github.com/apache/geode/blob/a44585316a8d7eed35917c1dfd829315b34ce316/geode-core/src/main/java/org/apache/geode/internal/InternalDataSerializer.java#L1090
[4]
https://github.com/spring-projects/spring-data-geode/blob/master/src/main/java/org/springframework/data/gemfire/serialization/EnumSerializer.java#L39
[5]
http://gemfire-90-javadocs.docs.pivotal.io/org/apache/geode/DataSerializer.html
[6]
http://gemfire-90-javadocs.docs.pivotal.io/org/apache/geode/DataSerializer.html#register-java.lang.Class-
[7]
https://github.com/apache/geode/blob/rel/v1.1.1/geode-core/src/main/java/org/apache/geode/internal/InternalDataSerializer.java#L1077
[8]
https://github.com/apache/geode/blob/61f676b0187e8918ca62f4a2ec9b6bd3baa942d3/geode-core/src/main/java/org/apache/geode/cache/client/Pool.java#L210
[9] https://build.spring.io/browse/SGF-NAG-552

[jira] [Commented] (GEODE-2587) Refactor OrderByComparator's compare method

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014951#comment-16014951
 ] 

ASF subversion and git services commented on GEODE-2587:


Commit b3fc0c814948cdfeb3181fcb57d07886aba8691e in geode's branch 
refs/heads/develop from nabarunnag
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=b3fc0c8 ]

GEODE-2587: Refactored the OrderByComparator's compare method

* This prevents creation of extra data structures like arrays of arrays
* Hence let number of GC, faster execution of queries with ORDER BY

This closes #517


> Refactor OrderByComparator's compare method
> ---
>
> Key: GEODE-2587
> URL: https://issues.apache.org/jira/browse/GEODE-2587
> Project: Geode
>  Issue Type: Bug
>  Components: querying
>Reporter: nabarun
>
> OrderByComparator's compare method creates a lot of objects / arrays with the 
> intention of comparing two objects.
> But allocation of memory for these objects results in GC to kick in.
> The additional time consumed in GC results in increased execution time for 
> queries with ORDER BY clause.
> This method must be refactored to require less memory allocations in order to 
> compare and thus speed up ORDER BY clause.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #517: GEODE-2587: Refactored the OrderByComparator's comp...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/517


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2587) Refactor OrderByComparator's compare method

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014952#comment-16014952
 ] 

ASF GitHub Bot commented on GEODE-2587:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/517


> Refactor OrderByComparator's compare method
> ---
>
> Key: GEODE-2587
> URL: https://issues.apache.org/jira/browse/GEODE-2587
> Project: Geode
>  Issue Type: Bug
>  Components: querying
>Reporter: nabarun
>
> OrderByComparator's compare method creates a lot of objects / arrays with the 
> intention of comparing two objects.
> But allocation of memory for these objects results in GC to kick in.
> The additional time consumed in GC results in increased execution time for 
> queries with ORDER BY clause.
> This method must be refactored to require less memory allocations in order to 
> compare and thus speed up ORDER BY clause.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2587) Refactor OrderByComparator's compare method

[nabarun (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

nabarun resolved GEODE-2587.

   Resolution: Fixed
Fix Version/s: 1.2.0

> Refactor OrderByComparator's compare method
> ---
>
> Key: GEODE-2587
> URL: https://issues.apache.org/jira/browse/GEODE-2587
> Project: Geode
>  Issue Type: Bug
>  Components: querying
>Reporter: nabarun
> Fix For: 1.2.0
>
>
> OrderByComparator's compare method creates a lot of objects / arrays with the 
> intention of comparing two objects.
> But allocation of memory for these objects results in GC to kick in.
> The additional time consumed in GC results in increased execution time for 
> queries with ORDER BY clause.
> This method must be refactored to require less memory allocations in order to 
> compare and thus speed up ORDER BY clause.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2936) Refactor OrderByComparator's compare method to reduce redundant code

[nabarun (JIRA)]

nabarun created GEODE-2936:
--

 Summary: Refactor OrderByComparator's compare method to reduce 
redundant code
 Key: GEODE-2936
 URL: https://issues.apache.org/jira/browse/GEODE-2936
 Project: Geode
  Issue Type: Bug
  Components: querying
Reporter: nabarun


Issue:
OrderByComparator's compare method has a lot of redundant code.

Solution:
These code sections can be modified to have one method call





--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 59323: GEODE-1994: Overhaul of internal.lang.StringUtils to extend and heavily use commons.lang.StringUtils.

[Patrick Rhomberg]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59323/
---

(Updated May 18, 2017, midnight)


Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, Kirk Lund, and 
Swapnil Bawaskar.


Changes
---

Updated w.r.t. requested changes.  Optimized imports in all touched files.


Repository: geode


Description
---

*   geode.internal.lang.StringUtils has been deprecated.  In the interim, it 
has been heavily refactored and extends commons.lang.StringUtils.
*
*   Renamed:
*   --  EMPTY_STRING -> EMPTY (inherited)
*   --  toUpperCase  -> upperCase (inherited)
*   --  toLowerCase  -> lowerCase (inherited)
*   --  padEnding-> rightPad (inherited)
*
*   Removed:
*   --  EMPTY_STRING_ARRAY; usage replaced with 
commons.lang.ArrayUtils.EMPTY_STRING_ARRAY
*   --  SPACES
*   --  UTF_8; rare usage replaced with raw string
*   --  concat; usage replaced with commons.lang.join, refactoring as necessary.
*   --  getLettersOnly
*   --  getSpaces
*   --  truncate
*   --  valueOf; usage refactored to use defaultString
*
*   Refactored
*   --  defaultIfBlank: previously relied on varargs and could return null.  
Usage refactored to allow inheritance from commons.
*   --  defaultString(s, EMPTY) refactored to use standard signature 
defaultString(s) for consistency throughout codebase.
*   --  isBlank: usage refactored to resolve discrepancies with 
commons.lang.isBlank, which is now inherited.
*   --  isEmpty: usage refactored to resolve discrepancies with 
commons.lang.isEmpty, which is now inherited.
*
*   Code Cleanup:
*   --  Many uses of !isBlank -> isNotBlank
*   --  Changes suggested by Inspections on most touched files.
*   -- Explicit  -> <> when type is inferable
*   -- while loops operating on iterators converted to for each loops
*   -- for loops operating on array indices converted to for each loops
*   --  Various string typos corrected.
*   --  isEmpty(s.trim()) -> isBlank(s)
*   --  s.trim().isEmpty() -> isEmpty(s)
*   --  Removed some instances of 'dead' code
*
*   Qualitative Changes:
*   --  The following functions now throw an error when called with a null 
string input:
*   --  *  LocatorLauncher.Builder.setMemberName
*   --  *  ServerLauncher.Builder.setMemberName
*   --  *  ServerLauncher.Builder.setHostnameForClients
*   --  (Unit tests added to capture these changes)
*
*   Notes:
*   --  StringUtils.wraps may be inherited from Apache Commons when the 
dependency is updated.
*   --  AbstractLauncher.getMember has the documented behavior of returning 
null when both MemberName and ID are blank.  Is this the best behavior for this 
method?

==

I'm going through the diff myself now and noticing a lot of refactorings that 
happen in dead code.  I'm going back to cull the dead code entirely, but wanted 
to go ahead and get this diff posted.


Diffs (updated)
-

  
geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsDUnitTest.java
 5277e57 
  
geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsTest.java
 0554f69 
  
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RestAPITestBase.java
 f2e90a4 
  
geode-core/src/main/java/org/apache/geode/cache/client/internal/locator/LocatorStatusResponse.java
 d531cc1 
  
geode-core/src/main/java/org/apache/geode/cache/query/internal/AttributeDescriptor.java
 f40ab3e 
  
geode-core/src/main/java/org/apache/geode/cache/query/internal/NWayMergeResults.java
 4e52a67 
  geode-core/src/main/java/org/apache/geode/distributed/AbstractLauncher.java 
feba893 
  geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java 
641e009 
  geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java 
b2d0151 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/ClusterConfigurationService.java
 10623b4 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/InternalLocator.java
 ad5e04d 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java
 4bf010b 
  
geode-core/src/main/java/org/apache/geode/internal/InternalDataSerializer.java 
78b2944 
  
geode-core/src/main/java/org/apache/geode/internal/admin/remote/RemoteTransportConfig.java
 af3cb5d 
  
geode-core/src/main/java/org/apache/geode/internal/cache/ClusterConfigurationLoader.java
 55e3542 
  geode-core/src/main/java/org/apache/geode/internal/cache/EntryEventImpl.java 
185fde7 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/HandShake.java
 0b11bf1 
  geode-core/src/main/java/org/apache/geode/internal/lang/StringUtils.java 
499d546 
  geode-core/src/main/java/org/apache/geode/internal/lang/SystemUtils.java 
2e47556 
  
geode-core/src/main/java/org/apache/geode/internal/process/FileP

[jira] [Commented] (GEODE-2913) Update Lucene documentation

[Karen Smoler Miller (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014981#comment-16014981
 ] 

Karen Smoler Miller commented on GEODE-2913:


LuceneIndexStats need to be added to the docs.  Here's a list of stats:

- queryExecutions - Number of lucene queries executed on this member
- queryExecutionTime - Amount of time spent executing lucene queries
- queryExecutionsInProgress, Number of query executions currently in progress
- queryExecutionTotalHits - Total number of documents returned by query 
executions
- repositoryQueryExecutions - Number of lucene repository queries executed on 
this member
- repositoryQueryExecutionTime - Amount of time spent executing lucene 
repository queries
- repositoryQueryExecutionsInProgress - Number of repository query executions 
currently in progress
- repositoryQueryExecutionTotalHits - Total number of documents returned by 
repository query executions
- updates - Number of lucene index documents added/removed on this member
- updateTime - Amount of time spent adding or removing documents from the index
- updatesInProgress - Number of index updates in progress
- commits - Number of lucene index commits on this member
- commitTime - Amount of time spent in lucene index commits
- commitsInProgress - Number of lucene index commits in progress
- documents - Number of documents in the index

> Update Lucene documentation
> ---
>
> Key: GEODE-2913
> URL: https://issues.apache.org/jira/browse/GEODE-2913
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>
> Improvements to the code base that need to be reflected in the docs:
> * Change LuceneService.createIndex to use a factory pattern
> {code:java}
> luceneService.createIndex(region, index, ...)
> {code}
> changes to
> {code:java}
> luceneService.createIndexFactory()
> .addField("field1name")
> .addField("field2name")
> .create()
> {code}
> *  Lucene indexes will *NOT* be stored in off-heap memory.
> * Document how to configure an index on accessors - you still need to create 
> the Lucene index before creating the region, even though this member does not 
> hold any region data.
> If the index is not defined on the accessor, an exception like this will be 
> thrown while attempting to create the region:
> {quote}
> [error 2017/05/02 15:19:26.018 PDT  tid=0x1] 
> java.lang.IllegalStateException: Must create Lucene index full_index on 
> region /data because it is defined in another member.
> Exception in thread "main" java.lang.IllegalStateException: Must create 
> Lucene index full_index on region /data because it is defined in another 
> member.
> at 
> org.apache.geode.internal.cache.CreateRegionProcessor$CreateRegionMessage.handleCacheDistributionAdvisee(CreateRegionProcessor.java:478)
> at 
> org.apache.geode.internal.cache.CreateRegionProcessor$CreateRegionMessage.process(CreateRegionProcessor.java:379)
> {quote}
> * Do not need to create a Lucene index on a client with a Proxy cache. The 
> Lucene search will always be done on the server.  Besides, _you can't create 
> an index on a client._
> * If you configure Invalidates for region entries (alone or as part of 
> expiration), these will *NOT* invalidate the Lucene indexes.
> The problem with this is the index contains the keys, but the region doesn't, 
> so the query produces results that don't exist.
> In this test, the first time the query is run, it produces N valid results. 
> The second time it is run it produces N empty results:
> ** load entries
> ** run query
> ** invalidate entries
> ** run query again
> *  Destroying a region will *NOT* automatically destroy any Lucene index 
> associated with that region. Instead, attempting to destroy a region with a 
> Lucene index will throw a colocated region exception. 
> An IllegalStateException is thrown:
> {quote}
> java.lang.IllegalStateException: The parent region [/data] in colocation 
> chain cannot be destroyed, unless all its children 
> [[/cusip_index#_data.files]] are destroyed
> at 
> org.apache.geode.internal.cache.PartitionedRegion.checkForColocatedChildren(PartitionedRegion.java:7231)
> at 
> org.apache.geode.internal.cache.PartitionedRegion.destroyRegion(PartitionedRegion.java:7243)
> at 
> org.apache.geode.internal.cache.AbstractRegion.destroyRegion(AbstractRegion.java:308)
> at 
> DestroyLuceneIndexesAndRegionFunction.destroyRegion(DestroyLuceneIndexesAndRegionFunction.java:46)
> {quote}
> * The process to change a Lucene index using gfsh: 
>   1. export region data
>   2. destroy Lucene index, destroy region 
>   3. create new index, create new region without user-defined business 
> logic callbacks
>   4. import data with option to turn on callbacks (to invoke Lucene Async 
> Event Liste

Build failed in Jenkins: Geode-nightly #838

[Apache Jenkins Server]

See 


Changes:

[klund] GEODE-2929: remove superfluous uses of final from internal classes

[bschuchardt] GEODE-2915 Messages rejected due to unknown "vmkind"

[upthewaterspout] LuceneClientSecurityDUnitTest was not testing anything

[jstewart] GEODE-2836: CacheCallback now extends Declarable

[jstewart] GEODE-2836: Fix compilation error introduced by rebase

[nnag] GEODE-2914: Fixed few javadoc formatting issues.

--
[...truncated 355.46 KB...]
at 
sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:568)
at 
sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:826)
at 
sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.lambda$run$0(TCPTransport.java:683)
at java.security.AccessController.doPrivileged(Native Method)
at 
sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:682)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)

org.apache.geode.rest.internal.web.controllers.RestAPIsWithSSLDUnitTest > 
testSSLWithTLSv12ProtocolLegacy[1] FAILED
java.lang.AssertionError: Suspicious strings were written to the log during 
this run.
Fix the strings or use IgnoredException.addIgnoredException to ignore.
---
Found suspect string in log4j at line 379

[error 2017/05/17 06:43:34.408 UTC  
tid=3528] failed setting interface to /127.0.1.1: java.net.SocketException: bad 
argument for IP_MULTICAST_IF: address not bound to any interface
java.net.SocketException: bad argument for IP_MULTICAST_IF: address not 
bound to any interface
at java.net.PlainDatagramSocketImpl.socketSetOption0(Native Method)
at 
java.net.PlainDatagramSocketImpl.socketSetOption(PlainDatagramSocketImpl.java:74)
at 
java.net.AbstractPlainDatagramSocketImpl.setOption(AbstractPlainDatagramSocketImpl.java:309)
at java.net.MulticastSocket.setInterface(MulticastSocket.java:471)
at org.jgroups.protocols.UDP.setInterface(UDP.java:443)
at org.jgroups.protocols.UDP.createMulticastSocket(UDP.java:511)
at 
org.jgroups.protocols.UDP.createMulticastSocketWithBindPort(UDP.java:494)
at org.jgroups.protocols.UDP.createSockets(UDP.java:348)
at org.jgroups.protocols.UDP.start(UDP.java:266)
at org.jgroups.stack.ProtocolStack.startStack(ProtocolStack.java:966)
at org.jgroups.JChannel.startStack(JChannel.java:889)
at org.jgroups.JChannel._preConnect(JChannel.java:553)
at org.jgroups.JChannel.connect(JChannel.java:288)
at org.jgroups.JChannel.connect(JChannel.java:279)
at 
org.apache.geode.distributed.internal.membership.gms.messenger.JGroupsMessenger.start(JGroupsMessenger.java:342)
at 
org.apache.geode.distributed.internal.membership.gms.Services.start(Services.java:147)
at 
org.apache.geode.distributed.internal.membership.gms.GMSMemberFactory.newMembershipManager(GMSMemberFactory.java:102)
at 
org.apache.geode.distributed.internal.membership.MemberFactory.newMembershipManager(MemberFactory.java:89)
at 
org.apache.geode.distributed.internal.DistributionManager.(DistributionManager.java:1116)
at 
org.apache.geode.distributed.internal.DistributionManager.(DistributionManager.java:1164)
at 
org.apache.geode.distributed.internal.DistributionManager.create(DistributionManager.java:535)
at 
org.apache.geode.distributed.internal.InternalDistributedSystem.initialize(InternalDistributedSystem.java:693)
at 
org.apache.geode.distributed.internal.InternalDistributedSystem.newInstance(InternalDistributedSystem.java:305)
at 
org.apache.geode.distributed.DistributedSystem.connect(DistributedSystem.java:206)
at 
org.apache.geode.distributed.internal.InternalLocator.startDistributedSystem(InternalLocator.java:714)
at 
org.apache.geode.distributed.internal.InternalLocator.startLocator(InternalLocator.java:342)
at 
org.apache.geode.distributed.internal.InternalLocator.startLocator(InternalLocator.java:302)
at org.apache.geode.distributed.Locator.startLocator(Locator.java:253)
at 
org.apache.geode.distributed.Locator.startLocatorAndDS(Locator.java:202)
at 
org.apache.geode.cache.client.internal.LocatorTestBase.startLocator(LocatorTestBase.java:111)
at 
org.apache.geode.rest.internal.web.controllers.RestAPIsWithSSLDUnitTest.lambda$startInfraWithSSL$447082cb$1(RestAPIsWithSSLDUnitTest.java:225)
at org.apache.geode.test.dunit.NamedRunnable.run(NamedRunnable.java:31)
at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
at 
sun.re