Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/500#discussion_r117080378
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/domain/DataCommandResult.java
---
@@ -406,124 +400,140 @@ public Result toCommandResult() {
section.addData("Message", errorString);
section.addData(RESULT_FLAG, operationCompletedSuccessfully);
return ResultBuilder.buildResult(data);
+ }
+
+ CompositeResultData data = ResultBuilder.createCompositeResultData();
+ SectionResultData section = data.addSection();
+ TabularResultData table = section.addTable();
+
+ section.addData(RESULT_FLAG, operationCompletedSuccessfully);
+ if (infoString != null) {
+ section.addData("Message", infoString);
+ }
+
+ if (isGet()) {
+ toCommandResult_isGet(section, table);
+ } else if (isLocateEntry()) {
+ toCommandResult_isLocate(section, table);
+ } else if (isPut()) {
+ toCommandResult_isPut(section, table);
+ } else if (isRemove()) {
+ toCommandResult_isRemove(section, table);
+ } else if (isSelect()) {
+ // its moved to its separate method
--- End diff --
so, for isSelect() we don't do anything? looks like isSelect() is only used
here, probably we can remove this function? looks like there is a lot of unused
functions in this class as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
