[
https://issues.apache.org/jira/browse/GEODE-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014782#comment-16014782
]
ASF GitHub Bot commented on GEODE-2587:
---------------------------------------
Github user jhuynh1 commented on the issue:
https://github.com/apache/geode/pull/517
We definitely have order by in the tests, whether or not they are adequate
I am not sure. doing a find on "order by" will show a log of queries in the
tests...
The changes look good to me, if in the future we could collapse common code
or extract some into smaller methods that would be great.
> Refactor OrderByComparator's compare method
> -------------------------------------------
>
> Key: GEODE-2587
> URL: https://issues.apache.org/jira/browse/GEODE-2587
> Project: Geode
> Issue Type: Bug
> Components: querying
> Reporter: nabarun
>
> OrderByComparator's compare method creates a lot of objects / arrays with the
> intention of comparing two objects.
> But allocation of memory for these objects results in GC to kick in.
> The additional time consumed in GC results in increased execution time for
> queries with ORDER BY clause.
> This method must be refactored to require less memory allocations in order to
> compare and thus speed up ORDER BY clause.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
