[jira] [Created] (GEODE-2559) Split geode-core to client and server packages

[Vadim Lotarev (JIRA)]

Vadim Lotarev created GEODE-2559:


 Summary: Split geode-core to client and server packages
 Key: GEODE-2559
 URL: https://issues.apache.org/jira/browse/GEODE-2559
 Project: Geode
  Issue Type: Improvement
  Components: build, general
Reporter: Vadim Lotarev


I would propose to consider possibility to split monolithic geode-core to 
geode-server and geode-client  jars. Clients do not need any server specific 
functionality as well as management features, etc. I would like to have as 
lightweight geode-client.jar as possible.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 57175: GEODE-4160: upgrade mortbay-jetty-servlet-api dependency

[Anthony Baker]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57175/#review167276
---


Ship it!




Ship It!

- Anthony Baker


On March 1, 2017, 1:39 a.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57175/
> ---
> 
> (Updated March 1, 2017, 1:39 a.m.)
> 
> 
> Review request for geode, Anthony Baker, Jinmei Liao, Jared Stewart, Kevin 
> Duling, Ken Howe, and Mark Bretl.
> 
> 
> Bugs: GEODE-4160
> https://issues.apache.org/jira/browse/GEODE-4160
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Upgrade mortbay-jetty-servlet-api dependency
> 
> This is the last upgrade on GEODE-4160 ticket.
> 
> 
> Diffs
> -
> 
>   gradle/dependency-versions.properties aca65fa 
> 
> 
> Diff: https://reviews.apache.org/r/57175/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin in progress
> uiTest passes
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

Re: Review Request 57175: GEODE-4160: upgrade mortbay-jetty-servlet-api dependency

[Jared Stewart]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57175/#review167278
---


Ship it!




Ship It!

- Jared Stewart


On March 1, 2017, 1:39 a.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57175/
> ---
> 
> (Updated March 1, 2017, 1:39 a.m.)
> 
> 
> Review request for geode, Anthony Baker, Jinmei Liao, Jared Stewart, Kevin 
> Duling, Ken Howe, and Mark Bretl.
> 
> 
> Bugs: GEODE-4160
> https://issues.apache.org/jira/browse/GEODE-4160
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Upgrade mortbay-jetty-servlet-api dependency
> 
> This is the last upgrade on GEODE-4160 ticket.
> 
> 
> Diffs
> -
> 
>   gradle/dependency-versions.properties aca65fa 
> 
> 
> Diff: https://reviews.apache.org/r/57175/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin in progress
> uiTest passes
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

[jira] [Commented] (GEODE-2441) Remove PDXAutoSerializer

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15890406#comment-15890406
 ] 

ASF GitHub Bot commented on GEODE-2441:
---

Github user echobravopapa commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/42#discussion_r103713640
  
--- Diff: src/quickstart/cpp/CMakeLists.txt ---
@@ -26,16 +26,6 @@ elseif(UNIX)
 set(DYNAMIC_LIBRARY_PATH LD_LIBRARY_PATH=${NATIVECLIENT_DIR}/lib)
 endif()
 
--- End diff --

-verbose flag LTGM, I had made the same changes locally


> Remove PDXAutoSerializer 
> -
>
> Key: GEODE-2441
> URL: https://issues.apache.org/jira/browse/GEODE-2441
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Ernest Burghardt
>
> Remove PDXAutoSerializer utility that generates PDX serialization C++ source 
> that you can include in your project to (de)serialize your C++ classes.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #42: GEODE-2441: Remove leftover pdx auto serializ...

[echobravopapa]

Github user echobravopapa commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/42#discussion_r103713640
  
--- Diff: src/quickstart/cpp/CMakeLists.txt ---
@@ -26,16 +26,6 @@ elseif(UNIX)
 set(DYNAMIC_LIBRARY_PATH LD_LIBRARY_PATH=${NATIVECLIENT_DIR}/lib)
 endif()
 
--- End diff --

-verbose flag LTGM, I had made the same changes locally


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: Geode-nightly #763

[Apache Jenkins Server]

See 


Changes:

[abaker] GEODE-2550 Improve README and BUILDING

[adongre] GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQueueFactory,

[klund] GEODE-2460: update dependency versions

[klund] GEODE-880 Remove unused classes

[klund] GEODE-2526: Enhance log statement to include ResourceTypeName

[boglesby] GEODE-2547: Interest registration no longer causes a CacheLoader to 
be

[klund] GEODE-2461: remove json4s-ast_2.10 as explicit dependency

[upthewaterspout] GEODE-2538: Don't deserialize values on the server when 
getting results

[klund] Revert "GEODE-1887: Now Size api goes through ServerProxy when cache is

--
[...truncated 110.96 KB...]
at 
org.apache.geode.internal.cache.MemberFunctionStreamingMessage.process(MemberFunctionStreamingMessage.java:191)
at 
org.apache.geode.distributed.internal.DistributionMessage.scheduleAction(DistributionMessage.java:376)
at 
org.apache.geode.distributed.internal.DistributionMessage$1.run(DistributionMessage.java:442)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at 
org.apache.geode.distributed.internal.DistributionManager.runUntilShutdown(DistributionManager.java:621)
at 
org.apache.geode.distributed.internal.DistributionManager$9$1.run(DistributionManager.java:1067)
at java.lang.Thread.run(Thread.java:745)

310 tests completed, 4 failed, 8 skipped
:geode-core:flakyTest FAILED
:geode-core:integrationTest
:geode-cq:assemble
:geode-cq:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-cq:processTestResources
:geode-cq:testClasses
:geode-cq:checkMissedTests
:geode-cq:spotlessJavaCheck
:geode-cq:spotlessCheck
:geode-cq:test
:geode-cq:check
:geode-cq:build
:geode-cq:distributedTest
:geode-cq:flakyTest
:geode-cq:integrationTest
:geode-json:assemble
:geode-json:compileTestJava UP-TO-DATE
:geode-json:processTestResources
:geode-json:testClasses
:geode-json:checkMissedTests UP-TO-DATE
:geode-json:spotlessJavaCheck
:geode-json:spotlessCheck
:geode-json:test UP-TO-DATE
:geode-json:check
:geode-json:build
:geode-json:distributedTest UP-TO-DATE
:geode-json:flakyTest UP-TO-DATE
:geode-json:integrationTest UP-TO-DATE
:geode-junit:javadoc
:geode-junit:javadocJar
:geode-junit:sourcesJar
:geode-junit:signArchives SKIPPED
:geode-junit:assemble
:geode-junit:compileTestJava
:geode-junit:processTestResources UP-TO-DATE
:geode-junit:testClasses
:geode-junit:checkMissedTests
:geode-junit:spotlessJavaCheck
:geode-junit:spotlessCheck
:geode-junit:test
:geode-junit:check
:geode-junit:build
:geode-junit:distributedTest
:geode-junit:flakyTest
:geode-junit:integrationTest
:geode-lucene:assemble
:geode-lucene:compileTestJavaNote: Some input files use or override a 
deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-lucene:processTestResources
:geode-lucene:testClasses
:geode-lucene:checkMissedTests
:geode-lucene:spotlessJavaCheck
:geode-lucene:spotlessCheck
:geode-lucene:test
:geode-lucene:check
:geode-lucene:build
:geode-lucene:distributedTest
:geode-lucene:flakyTest
:geode-lucene:integrationTest
:geode-old-client-support:assemble
:geode-old-client-support:compileTestJava
:geode-old-client-support:processTestResources UP-TO-DATE
:geode-old-client-support:testClasses
:geode-old-client-support:checkMissedTests
:geode-old-client-support:spotlessJavaCheck
:geode-old-client-support:spotlessCheck
:geode-old-client-support:test
:geode-old-client-support:check
:geode-old-client-support:build
:geode-old-client-support:distributedTest
:geode-old-client-support:flakyTest
:geode-old-client-support:integrationTest
:geode-old-versions:javadoc UP-TO-DATE
:geode-old-versions:javadocJar
:geode-old-versions:sourcesJar
:geode-old-versions:signArchives SKIPPED
:geode-old-versions:assemble
:geode-old-versions:compileTestJava UP-TO-DATE
:geode-old-versions:processTestResources UP-TO-DATE
:geode-old-versions:testClasses UP-TO-DATE
:geode-old-versions:checkMissedTests UP-TO-DATE
:geode-old-versions:spotlessJavaCheck
:geode-old-versions:spotlessCheck
:geode-old-versions:test UP-TO-DATE
:geode-old-versions:check
:geode-old-versions:build
:geode-old-versions:distributedTest UP-TO-DATE
:geode-old-versions:flakyTest UP-TO-DATE
:geode-old-versions:integrationTest UP-TO-DATE
:geode-pulse:assemble
:geode-pulse:compileTestJavaNote: 

 uses or overrides a deprecated API

[jira] [Commented] (GEODE-2517) Data transfer of size > 2GB from server to client results in a hang and eventual timeout exception

[Bruce Schuchardt (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15890538#comment-15890538
 ] 

Bruce Schuchardt commented on GEODE-2517:
-

[~nnag] can you suggest a way to make #4, forcing a chunk to be large, happen?

> Data transfer of size > 2GB from server to client results in a hang and 
> eventual timeout exception
> --
>
> Key: GEODE-2517
> URL: https://issues.apache.org/jira/browse/GEODE-2517
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Affects Versions: 1.1.0
>Reporter: nabarun
>
> *Situation*:
> 1. Create a server and client.
> 2. Fill the server with a large amount of data. 
> 3. Create a query that will result in over 600,000 entries as result.
> 4. Chunk the result set in such a way that one chunk will result in a size 
> greater than 2GB
> 5. Execute the query from the client.
> *Expected*:
> Message too large exception.
> *Cause / Fix for the issue*:
> If the number of parts to be transmitted is one then in sendBytes()
> {code:title=Message.java}
> for (int i = 0; i < this.numberOfParts; i++) {
>   Part part = this.partsList[i];
>   headerLen += PART_HEADER_SIZE;
>   totalPartLen += part.getLength();
> }
> {code}
> * Here the part.getLength() is an int, so if the size is greater than 2GB we 
> have already overflowed the int barrier and we are putting a negative value 
> in totalPartLen
> so when we do the below check :
> {code:title=Message.java}
> if ((headerLen + totalPartLen) > Integer.MAX_VALUE) {
>   throw new MessageTooLargeException(
>   "Message size (" + (headerLen + totalPartLen) + ") exceeds 
> maximum integer value");
> }
> {code}
> The comparison is between a negative number and positive number 
> [Integer.MAX_VALUE] hence it will always skip this loop.
> and ultimately result in this exception.
> {noformat}
> java.io.IOException: Part length ( -508,098,123 ) and number of parts ( 1 ) 
> inconsistent
>   at 
> com.gemstone.gemfire.internal.cache.tier.sockets.Message.readPayloadFields(Message.java:836)
>   at 
> com.gemstone.gemfire.internal.cache.tier.sockets.ChunkedMessage.readChunk(ChunkedMessage.java:276)
>   at 
> com.gemstone.gemfire.internal.cache.tier.sockets.ChunkedMessage.receiveChunk(ChunkedMessage.java:220)
>   at 
> com.gemstone.gemfire.cache.client.internal.ExecuteRegionFunctionOp$ExecuteRegionFunctionOpImpl.processResponse(ExecuteRegionFunctionOp.java:482)
>   at 
> com.gemstone.gemfire.cache.client.internal.AbstractOp.processResponse(AbstractOp.java:215)
>   at 
> com.gemstone.gemfire.cache.client.internal.AbstractOp.attemptReadResponse(AbstractOp.java:153)
>   at 
> com.gemstone.gemfire.cache.client.internal.AbstractOp.attempt(AbstractOp.java:369)
>   at 
> com.gemstone.gemfire.cache.client.internal.ConnectionImpl.execute(ConnectionImpl.java:252)
>   at 
> com.gemstone.gemfire.cache.client.internal.pooling.PooledConnection.execute(PooledConnection.java:319)
>   at 
> com.gemstone.gemfire.cache.client.internal.OpExecutorImpl.executeWithPossibleReAuthentication(OpExecutorImpl.java:933)
>   at 
> com.gemstone.gemfire.cache.client.internal.OpExecutorImpl.execute(OpExecutorImpl.java:158)
>   at 
> com.gemstone.gemfire.cache.client.internal.PoolImpl.execute(PoolImpl.java:716)
>   at 
> com.gemstone.gemfire.cache.client.internal.ExecuteRegionFunctionOp.execute(ExecuteRegionFunctionOp.java:159)
>   at 
> com.gemstone.gemfire.cache.client.internal.ServerRegionProxy.executeFunction(ServerRegionProxy.java:801)
>   at 
> com.gemstone.gemfire.internal.cache.execute.ServerRegionFunctionExecutor.executeOnServer(ServerRegionFunctionExecutor.java:212)
>   at 
> com.gemstone.gemfire.internal.cache.execute.ServerRegionFunctionExecutor.executeFunction(ServerRegionFunctionExecutor.java:165)
>   at 
> com.gemstone.gemfire.internal.cache.execute.ServerRegionFunctionExecutor.execute(ServerRegionFunctionExecutor.java:363)
>   at com.bookshop.buslogic.TestClient.run(TestClient.java:40)
>   at com.bookshop.buslogic.TestClient.main(TestClient.java:21)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Review Request 57206: let LuceneResultStruct to be Serializable, then customer does not have to defined their Serializable class to hold result

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57206/
---

Review request for geode, Barry Oglesby and Dan Smith.


Bugs: GEODE-11
https://issues.apache.org/jira/browse/GEODE-11


Repository: geode


Description
---

If customer call a lucene query in a function, they need to define their own 
Serializable class to collect results. This has been complained by field 
engineer. 

It will not hurt to let LuceneResultStruct to extend Serializable


Diffs
-

  
geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneResultStruct.java
 b922185 


Diff: https://reviews.apache.org/r/57206/diff/1/


Testing
---


Thanks,

xiaojian zhou

[jira] [Commented] (GEODE-2517) Data transfer of size > 2GB from server to client results in a hang and eventual timeout exception

[Hitesh Khamesra (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15890612#comment-15890612
 ] 

Hitesh Khamesra commented on GEODE-2517:


[~nnag] good point about comparison; Have you change some system property to 
see this?

==
if ((headerLen + totalPartLen) > Integer.MAX_VALUE) {


> Data transfer of size > 2GB from server to client results in a hang and 
> eventual timeout exception
> --
>
> Key: GEODE-2517
> URL: https://issues.apache.org/jira/browse/GEODE-2517
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Affects Versions: 1.1.0
>Reporter: nabarun
>
> *Situation*:
> 1. Create a server and client.
> 2. Fill the server with a large amount of data. 
> 3. Create a query that will result in over 600,000 entries as result.
> 4. Chunk the result set in such a way that one chunk will result in a size 
> greater than 2GB
> 5. Execute the query from the client.
> *Expected*:
> Message too large exception.
> *Cause / Fix for the issue*:
> If the number of parts to be transmitted is one then in sendBytes()
> {code:title=Message.java}
> for (int i = 0; i < this.numberOfParts; i++) {
>   Part part = this.partsList[i];
>   headerLen += PART_HEADER_SIZE;
>   totalPartLen += part.getLength();
> }
> {code}
> * Here the part.getLength() is an int, so if the size is greater than 2GB we 
> have already overflowed the int barrier and we are putting a negative value 
> in totalPartLen
> so when we do the below check :
> {code:title=Message.java}
> if ((headerLen + totalPartLen) > Integer.MAX_VALUE) {
>   throw new MessageTooLargeException(
>   "Message size (" + (headerLen + totalPartLen) + ") exceeds 
> maximum integer value");
> }
> {code}
> The comparison is between a negative number and positive number 
> [Integer.MAX_VALUE] hence it will always skip this loop.
> and ultimately result in this exception.
> {noformat}
> java.io.IOException: Part length ( -508,098,123 ) and number of parts ( 1 ) 
> inconsistent
>   at 
> com.gemstone.gemfire.internal.cache.tier.sockets.Message.readPayloadFields(Message.java:836)
>   at 
> com.gemstone.gemfire.internal.cache.tier.sockets.ChunkedMessage.readChunk(ChunkedMessage.java:276)
>   at 
> com.gemstone.gemfire.internal.cache.tier.sockets.ChunkedMessage.receiveChunk(ChunkedMessage.java:220)
>   at 
> com.gemstone.gemfire.cache.client.internal.ExecuteRegionFunctionOp$ExecuteRegionFunctionOpImpl.processResponse(ExecuteRegionFunctionOp.java:482)
>   at 
> com.gemstone.gemfire.cache.client.internal.AbstractOp.processResponse(AbstractOp.java:215)
>   at 
> com.gemstone.gemfire.cache.client.internal.AbstractOp.attemptReadResponse(AbstractOp.java:153)
>   at 
> com.gemstone.gemfire.cache.client.internal.AbstractOp.attempt(AbstractOp.java:369)
>   at 
> com.gemstone.gemfire.cache.client.internal.ConnectionImpl.execute(ConnectionImpl.java:252)
>   at 
> com.gemstone.gemfire.cache.client.internal.pooling.PooledConnection.execute(PooledConnection.java:319)
>   at 
> com.gemstone.gemfire.cache.client.internal.OpExecutorImpl.executeWithPossibleReAuthentication(OpExecutorImpl.java:933)
>   at 
> com.gemstone.gemfire.cache.client.internal.OpExecutorImpl.execute(OpExecutorImpl.java:158)
>   at 
> com.gemstone.gemfire.cache.client.internal.PoolImpl.execute(PoolImpl.java:716)
>   at 
> com.gemstone.gemfire.cache.client.internal.ExecuteRegionFunctionOp.execute(ExecuteRegionFunctionOp.java:159)
>   at 
> com.gemstone.gemfire.cache.client.internal.ServerRegionProxy.executeFunction(ServerRegionProxy.java:801)
>   at 
> com.gemstone.gemfire.internal.cache.execute.ServerRegionFunctionExecutor.executeOnServer(ServerRegionFunctionExecutor.java:212)
>   at 
> com.gemstone.gemfire.internal.cache.execute.ServerRegionFunctionExecutor.executeFunction(ServerRegionFunctionExecutor.java:165)
>   at 
> com.gemstone.gemfire.internal.cache.execute.ServerRegionFunctionExecutor.execute(ServerRegionFunctionExecutor.java:363)
>   at com.bookshop.buslogic.TestClient.run(TestClient.java:40)
>   at com.bookshop.buslogic.TestClient.main(TestClient.java:21)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Comment Edited] (GEODE-2517) Data transfer of size > 2GB from server to client results in a hang and eventual timeout exception

[Hitesh Khamesra (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15890612#comment-15890612
 ] 

Hitesh Khamesra edited comment on GEODE-2517 at 3/1/17 5:23 PM:


[~nnag] good point about comparison; Have you changed any system property to 
see this failure?

==
if ((headerLen + totalPartLen) > Integer.MAX_VALUE) {



was (Author: hitesh.khamesra):
[~nnag] good point about comparison; Have you change some system property to 
see this?

==
if ((headerLen + totalPartLen) > Integer.MAX_VALUE) {


> Data transfer of size > 2GB from server to client results in a hang and 
> eventual timeout exception
> --
>
> Key: GEODE-2517
> URL: https://issues.apache.org/jira/browse/GEODE-2517
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Affects Versions: 1.1.0
>Reporter: nabarun
>
> *Situation*:
> 1. Create a server and client.
> 2. Fill the server with a large amount of data. 
> 3. Create a query that will result in over 600,000 entries as result.
> 4. Chunk the result set in such a way that one chunk will result in a size 
> greater than 2GB
> 5. Execute the query from the client.
> *Expected*:
> Message too large exception.
> *Cause / Fix for the issue*:
> If the number of parts to be transmitted is one then in sendBytes()
> {code:title=Message.java}
> for (int i = 0; i < this.numberOfParts; i++) {
>   Part part = this.partsList[i];
>   headerLen += PART_HEADER_SIZE;
>   totalPartLen += part.getLength();
> }
> {code}
> * Here the part.getLength() is an int, so if the size is greater than 2GB we 
> have already overflowed the int barrier and we are putting a negative value 
> in totalPartLen
> so when we do the below check :
> {code:title=Message.java}
> if ((headerLen + totalPartLen) > Integer.MAX_VALUE) {
>   throw new MessageTooLargeException(
>   "Message size (" + (headerLen + totalPartLen) + ") exceeds 
> maximum integer value");
> }
> {code}
> The comparison is between a negative number and positive number 
> [Integer.MAX_VALUE] hence it will always skip this loop.
> and ultimately result in this exception.
> {noformat}
> java.io.IOException: Part length ( -508,098,123 ) and number of parts ( 1 ) 
> inconsistent
>   at 
> com.gemstone.gemfire.internal.cache.tier.sockets.Message.readPayloadFields(Message.java:836)
>   at 
> com.gemstone.gemfire.internal.cache.tier.sockets.ChunkedMessage.readChunk(ChunkedMessage.java:276)
>   at 
> com.gemstone.gemfire.internal.cache.tier.sockets.ChunkedMessage.receiveChunk(ChunkedMessage.java:220)
>   at 
> com.gemstone.gemfire.cache.client.internal.ExecuteRegionFunctionOp$ExecuteRegionFunctionOpImpl.processResponse(ExecuteRegionFunctionOp.java:482)
>   at 
> com.gemstone.gemfire.cache.client.internal.AbstractOp.processResponse(AbstractOp.java:215)
>   at 
> com.gemstone.gemfire.cache.client.internal.AbstractOp.attemptReadResponse(AbstractOp.java:153)
>   at 
> com.gemstone.gemfire.cache.client.internal.AbstractOp.attempt(AbstractOp.java:369)
>   at 
> com.gemstone.gemfire.cache.client.internal.ConnectionImpl.execute(ConnectionImpl.java:252)
>   at 
> com.gemstone.gemfire.cache.client.internal.pooling.PooledConnection.execute(PooledConnection.java:319)
>   at 
> com.gemstone.gemfire.cache.client.internal.OpExecutorImpl.executeWithPossibleReAuthentication(OpExecutorImpl.java:933)
>   at 
> com.gemstone.gemfire.cache.client.internal.OpExecutorImpl.execute(OpExecutorImpl.java:158)
>   at 
> com.gemstone.gemfire.cache.client.internal.PoolImpl.execute(PoolImpl.java:716)
>   at 
> com.gemstone.gemfire.cache.client.internal.ExecuteRegionFunctionOp.execute(ExecuteRegionFunctionOp.java:159)
>   at 
> com.gemstone.gemfire.cache.client.internal.ServerRegionProxy.executeFunction(ServerRegionProxy.java:801)
>   at 
> com.gemstone.gemfire.internal.cache.execute.ServerRegionFunctionExecutor.executeOnServer(ServerRegionFunctionExecutor.java:212)
>   at 
> com.gemstone.gemfire.internal.cache.execute.ServerRegionFunctionExecutor.executeFunction(ServerRegionFunctionExecutor.java:165)
>   at 
> com.gemstone.gemfire.internal.cache.execute.ServerRegionFunctionExecutor.execute(ServerRegionFunctionExecutor.java:363)
>   at com.bookshop.buslogic.TestClient.run(TestClient.java:40)
>   at com.bookshop.buslogic.TestClient.main(TestClient.java:21)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 57175: GEODE-4160: upgrade mortbay-jetty-servlet-api dependency

[Kevin Duling]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57175/#review167291
---


Ship it!




Ship It!

- Kevin Duling


On Feb. 28, 2017, 5:39 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57175/
> ---
> 
> (Updated Feb. 28, 2017, 5:39 p.m.)
> 
> 
> Review request for geode, Anthony Baker, Jinmei Liao, Jared Stewart, Kevin 
> Duling, Ken Howe, and Mark Bretl.
> 
> 
> Bugs: GEODE-4160
> https://issues.apache.org/jira/browse/GEODE-4160
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Upgrade mortbay-jetty-servlet-api dependency
> 
> This is the last upgrade on GEODE-4160 ticket.
> 
> 
> Diffs
> -
> 
>   gradle/dependency-versions.properties aca65fa 
> 
> 
> Diff: https://reviews.apache.org/r/57175/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin in progress
> uiTest passes
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

Re: [jira] [Commented] (GEODE-2441) Remove PDXAutoSerializer

[Michael Stolz]

We should make sure to find a new home for the PDXAutoSerializer, not just
remove it.
It is an important part of the product.
Without it, PDX can't claim C++ compatibility.
I assume a separate Jira has bin opened for that work?


--
Mike Stolz
Principal Engineer, GemFire Product Manager
Mobile: +1-631-835-4771

On Wed, Mar 1, 2017 at 10:41 AM, ASF GitHub Bot (JIRA) 
wrote:

>
> [ https://issues.apache.org/jira/browse/GEODE-2441?page=
> com.atlassian.jira.plugin.system.issuetabpanels:comment-
> tabpanel&focusedCommentId=15890406#comment-15890406 ]
>
> ASF GitHub Bot commented on GEODE-2441:
> ---
>
> Github user echobravopapa commented on a diff in the pull request:
>
> https://github.com/apache/geode-native/pull/42#discussion_r103713640
>
> --- Diff: src/quickstart/cpp/CMakeLists.txt ---
> @@ -26,16 +26,6 @@ elseif(UNIX)
>  set(DYNAMIC_LIBRARY_PATH LD_LIBRARY_PATH=${NATIVECLIENT_DIR}/lib)
>  endif()
>
> --- End diff --
>
> -verbose flag LTGM, I had made the same changes locally
>
>
> > Remove PDXAutoSerializer
> > -
> >
> > Key: GEODE-2441
> > URL: https://issues.apache.org/jira/browse/GEODE-2441
> > Project: Geode
> >  Issue Type: Bug
> >  Components: native client
> >Reporter: Ernest Burghardt
> >
> > Remove PDXAutoSerializer utility that generates PDX serialization C++
> source that you can include in your project to (de)serialize your C++
> classes.
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.15#6346)
>

Re: Review Request 57171: GEODE-2461: remove json4s-ast_2.10 as explicit dependency

[Jared Stewart]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57171/#review167295
---


Ship it!




Ship It!

- Jared Stewart


On Feb. 28, 2017, 10:17 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57171/
> ---
> 
> (Updated Feb. 28, 2017, 10:17 p.m.)
> 
> 
> Review request for geode, Anthony Baker, Jinmei Liao, Jared Stewart, Mark 
> Bretl, Udo Kohlmeyer, and Dan Smith.
> 
> 
> Bugs: GEODE-2461
> https://issues.apache.org/jira/browse/GEODE-2461
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Remove explicit dependency on json4s-ast_2.10.
> 
> I couldn't find anything that actually uses json4s-ast_2.10, directly or 
> transitively, so I've removed it completely.
> 
> 
> Diffs
> -
> 
>   geode-assembly/src/test/resources/expected_jars.txt 
> a9a5a792a4e4aafb9b191cd3bf89d54fe559bc75 
>   geode-web-api/build.gradle 8b22bd8de174ddad47f4acbd0da75614a060da99 
>   gradle/dependency-versions.properties 
> be828af14826ff63adee18717de063d87e2f1c6c 
> 
> 
> Diff: https://reviews.apache.org/r/57171/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin passed
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

[jira] [Created] (GEODE-2560) Missing disk files (.crf) during backup/restore throws exception

[Kevin Duling (JIRA)]

Kevin Duling created GEODE-2560:
---

 Summary: Missing disk files (.crf) during backup/restore throws 
exception
 Key: GEODE-2560
 URL: https://issues.apache.org/jira/browse/GEODE-2560
 Project: Geode
  Issue Type: Bug
  Components: persistence
Reporter: Kevin Duling
 Fix For: 1.2.0


The old FileUtil.copy was a noop if the src file did not exist.
The new FileUtils.copyFile throws a FileNotFoundException if the src file does 
not exist.

Protect against missing file.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (GEODE-2560) Missing disk files (.crf) during backup/restore throws exception

[Kevin Duling (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kevin Duling reassigned GEODE-2560:
---

Assignee: Kevin Duling

> Missing disk files (.crf) during backup/restore throws exception
> 
>
> Key: GEODE-2560
> URL: https://issues.apache.org/jira/browse/GEODE-2560
> Project: Geode
>  Issue Type: Bug
>  Components: persistence
>Reporter: Kevin Duling
>Assignee: Kevin Duling
> Fix For: 1.2.0
>
>
> The old FileUtil.copy was a noop if the src file did not exist.
> The new FileUtils.copyFile throws a FileNotFoundException if the src file 
> does not exist.
> Protect against missing file.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #41: GEODE-2513 Rebrand Setting System Properties ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/41


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2513) Geode Native docs: rebrand to match open-source software

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15890672#comment-15890672
 ] 

ASF subversion and git services commented on GEODE-2513:


Commit 798e85a5babbba092eaf3ea841424b4e021011bf in geode-native's branch 
refs/heads/develop from [~karensmolermiller]
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=798e85a ]

Merge branch 'feature/GEODE-2513-2' into develop


> Geode Native docs: rebrand to match open-source software
> 
>
> Key: GEODE-2513
> URL: https://issues.apache.org/jira/browse/GEODE-2513
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Dave Barnes
>
> The newly-contributed Geode Native doc sources contain some GemFire artifacts 
> that have been purged from the open-source code. Docs should be updated to 
> match. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2513) Geode Native docs: rebrand to match open-source software

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15890671#comment-15890671
 ] 

ASF subversion and git services commented on GEODE-2513:


Commit a73abd4c4f2c663b7c6d9e7282c429bec093481b in geode-native's branch 
refs/heads/develop from [~karensmolermiller]
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=a73abd4 ]

GEODE-2513 Rebrand Setting System Properties section
of Geode Native documentation


> Geode Native docs: rebrand to match open-source software
> 
>
> Key: GEODE-2513
> URL: https://issues.apache.org/jira/browse/GEODE-2513
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Dave Barnes
>
> The newly-contributed Geode Native doc sources contain some GemFire artifacts 
> that have been purged from the open-source code. Docs should be updated to 
> match. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2513) Geode Native docs: rebrand to match open-source software

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15890673#comment-15890673
 ] 

ASF GitHub Bot commented on GEODE-2513:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/41


> Geode Native docs: rebrand to match open-source software
> 
>
> Key: GEODE-2513
> URL: https://issues.apache.org/jira/browse/GEODE-2513
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Dave Barnes
>
> The newly-contributed Geode Native doc sources contain some GemFire artifacts 
> that have been purged from the open-source code. Docs should be updated to 
> match. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Review Request 57208: GEODE-2560: Missing disk files (.crf) during backup/restore throws exception

[Kevin Duling]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57208/
---

Review request for geode, Darrel Schneider, Jared Stewart, Kirk Lund, and Dan 
Smith.


Repository: geode


Description
---

GEODE-2560: Missing disk files (.crf) during backup/restore throws exception


Diffs
-

  geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java 
f5aec51a09e671bc7d4ca33d4de8f0f683ef4d73 


Diff: https://reviews.apache.org/r/57208/diff/1/


Testing
---

precheckin running


Thanks,

Kevin Duling

[jira] [Resolved] (GEODE-2560) Missing disk files (.crf) during backup/restore throws exception

[Kevin Duling (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kevin Duling resolved GEODE-2560.
-
Resolution: Fixed

Added a test to ensure the file exists prior to executing the copy.

> Missing disk files (.crf) during backup/restore throws exception
> 
>
> Key: GEODE-2560
> URL: https://issues.apache.org/jira/browse/GEODE-2560
> Project: Geode
>  Issue Type: Bug
>  Components: persistence
>Reporter: Kevin Duling
>Assignee: Kevin Duling
> Fix For: 1.2.0
>
>
> The old FileUtil.copy was a noop if the src file did not exist.
> The new FileUtils.copyFile throws a FileNotFoundException if the src file 
> does not exist.
> Protect against missing file.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: [jira] [Commented] (GEODE-2441) Remove PDXAutoSerializer

[David Kimura]

It has been moved into a contrib directory outside the core sources where
other standalone tools can live too.

https://github.com/apache/geode-native/tree/develop/contrib/pdxautoserializer

Thanks,
David

On Wed, Mar 1, 2017 at 9:28 AM, Michael Stolz  wrote:

> We should make sure to find a new home for the PDXAutoSerializer, not just
> remove it.
> It is an important part of the product.
> Without it, PDX can't claim C++ compatibility.
> I assume a separate Jira has bin opened for that work?
>
>
> --
> Mike Stolz
> Principal Engineer, GemFire Product Manager
> Mobile: +1-631-835-4771
>
> On Wed, Mar 1, 2017 at 10:41 AM, ASF GitHub Bot (JIRA) 
> wrote:
>
> >
> > [ https://issues.apache.org/jira/browse/GEODE-2441?page=
> > com.atlassian.jira.plugin.system.issuetabpanels:comment-
> > tabpanel&focusedCommentId=15890406#comment-15890406 ]
> >
> > ASF GitHub Bot commented on GEODE-2441:
> > ---
> >
> > Github user echobravopapa commented on a diff in the pull request:
> >
> > https://github.com/apache/geode-native/pull/42#discussion_r103713640
> >
> > --- Diff: src/quickstart/cpp/CMakeLists.txt ---
> > @@ -26,16 +26,6 @@ elseif(UNIX)
> >  set(DYNAMIC_LIBRARY_PATH LD_LIBRARY_PATH=${
> NATIVECLIENT_DIR}/lib)
> >  endif()
> >
> > --- End diff --
> >
> > -verbose flag LTGM, I had made the same changes locally
> >
> >
> > > Remove PDXAutoSerializer
> > > -
> > >
> > > Key: GEODE-2441
> > > URL: https://issues.apache.org/jira/browse/GEODE-2441
> > > Project: Geode
> > >  Issue Type: Bug
> > >  Components: native client
> > >Reporter: Ernest Burghardt
> > >
> > > Remove PDXAutoSerializer utility that generates PDX serialization C++
> > source that you can include in your project to (de)serialize your C++
> > classes.
> >
> >
> >
> > --
> > This message was sent by Atlassian JIRA
> > (v6.3.15#6346)
> >
>

[jira] [Created] (GEODE-2561) Native client docs: error in gfsecurity.properties example

[Dave Barnes (JIRA)]

Dave Barnes created GEODE-2561:
--

 Summary: Native client docs: error in gfsecurity.properties example
 Key: GEODE-2561
 URL: https://issues.apache.org/jira/browse/GEODE-2561
 Project: Geode
  Issue Type: Bug
  Components: docs
Reporter: Dave Barnes


Reported by Mike Martell:
Looks like an error on this SSL Sample Impl page: 
.../managing/security/ssl_example.html

Seems like they're using a path for a password:
ssl-truststore-password=/path/to/trusted.truststore

[db note] 
Check entire page to make sure properties shown are consistent with the current 
implementation, as security properties (in particular) were recently revised.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Passed: apache/geode#2123 (develop - 4fbc641)

[Travis CI]

Build Update for apache/geode
-

Build: #2123
Status: Passed

Duration: 9 minutes and 14 seconds
Commit: 4fbc641 (develop)
Author: Anthony Baker
Message: GEODE-880 Remove unused classes

This closes #409

View the changeset: 
https://github.com/apache/geode/compare/bc32a76c223d...4fbc6412f7da

View the full build log and details: 
https://travis-ci.org/apache/geode/builds/206393664

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

Re: Review Request 57175: GEODE-4160: upgrade mortbay-jetty-servlet-api dependency

[Mark Bretl]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57175/#review167371
---


Ship it!




Ship It!

- Mark Bretl


On Feb. 28, 2017, 5:39 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57175/
> ---
> 
> (Updated Feb. 28, 2017, 5:39 p.m.)
> 
> 
> Review request for geode, Anthony Baker, Jinmei Liao, Jared Stewart, Kevin 
> Duling, Ken Howe, and Mark Bretl.
> 
> 
> Bugs: GEODE-4160
> https://issues.apache.org/jira/browse/GEODE-4160
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Upgrade mortbay-jetty-servlet-api dependency
> 
> This is the last upgrade on GEODE-4160 ticket.
> 
> 
> Diffs
> -
> 
>   gradle/dependency-versions.properties aca65fa 
> 
> 
> Diff: https://reviews.apache.org/r/57175/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin in progress
> uiTest passes
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

[jira] [Updated] (GEODE-2561) Docs: error in gfsecurity.properties example (Geode User Guide)

[Dave Barnes (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Barnes updated GEODE-2561:
---
Summary: Docs: error in gfsecurity.properties example (Geode User Guide)  
(was: Native client docs: error in gfsecurity.properties example)

> Docs: error in gfsecurity.properties example (Geode User Guide)
> ---
>
> Key: GEODE-2561
> URL: https://issues.apache.org/jira/browse/GEODE-2561
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Dave Barnes
>
> Reported by Mike Martell:
> Looks like an error on this SSL Sample Impl page: 
> .../managing/security/ssl_example.html
> Seems like they're using a path for a password:
> ssl-truststore-password=/path/to/trusted.truststore
> [db note] 
> Check entire page to make sure properties shown are consistent with the 
> current implementation, as security properties (in particular) were recently 
> revised.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 57171: GEODE-2461: remove json4s-ast_2.10 as explicit dependency

[Mark Bretl]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57171/#review167372
---


Ship it!




Ship It!

- Mark Bretl


On Feb. 28, 2017, 2:17 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57171/
> ---
> 
> (Updated Feb. 28, 2017, 2:17 p.m.)
> 
> 
> Review request for geode, Anthony Baker, Jinmei Liao, Jared Stewart, Mark 
> Bretl, Udo Kohlmeyer, and Dan Smith.
> 
> 
> Bugs: GEODE-2461
> https://issues.apache.org/jira/browse/GEODE-2461
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Remove explicit dependency on json4s-ast_2.10.
> 
> I couldn't find anything that actually uses json4s-ast_2.10, directly or 
> transitively, so I've removed it completely.
> 
> 
> Diffs
> -
> 
>   geode-assembly/src/test/resources/expected_jars.txt 
> a9a5a792a4e4aafb9b191cd3bf89d54fe559bc75 
>   geode-web-api/build.gradle 8b22bd8de174ddad47f4acbd0da75614a060da99 
>   gradle/dependency-versions.properties 
> be828af14826ff63adee18717de063d87e2f1c6c 
> 
> 
> Diff: https://reviews.apache.org/r/57171/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin passed
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

Re: Review Request 57208: GEODE-2560: Missing disk files (.crf) during backup/restore throws exception

[anilkumar gingade]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57208/#review167411
---




geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java
Line 5810 (original), 5810 (patched)


Do we need the same check for drf file?


- anilkumar gingade


On March 1, 2017, 5:56 p.m., Kevin Duling wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57208/
> ---
> 
> (Updated March 1, 2017, 5:56 p.m.)
> 
> 
> Review request for geode, Darrel Schneider, Jared Stewart, Kirk Lund, and Dan 
> Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2560: Missing disk files (.crf) during backup/restore throws exception
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java 
> f5aec51a09e671bc7d4ca33d4de8f0f683ef4d73 
> 
> 
> Diff: https://reviews.apache.org/r/57208/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin running
> 
> 
> Thanks,
> 
> Kevin Duling
> 
>

Re: Review Request 57208: GEODE-2560: Missing disk files (.crf) during backup/restore throws exception

[Darrel Schneider]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57208/#review167414
---


Ship it!




Ship It!

- Darrel Schneider


On March 1, 2017, 9:56 a.m., Kevin Duling wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57208/
> ---
> 
> (Updated March 1, 2017, 9:56 a.m.)
> 
> 
> Review request for geode, Darrel Schneider, Jared Stewart, Kirk Lund, and Dan 
> Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2560: Missing disk files (.crf) during backup/restore throws exception
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java 
> f5aec51a09e671bc7d4ca33d4de8f0f683ef4d73 
> 
> 
> Diff: https://reviews.apache.org/r/57208/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin running
> 
> 
> Thanks,
> 
> Kevin Duling
> 
>

[GitHub] geode issue #410: Overhauling the javadocs for the LuceneService

[upthewaterspout]

Github user upthewaterspout commented on the issue:

https://github.com/apache/geode/pull/410
  
@jhuynh1 @karensmolermiller @gesterzhou 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 57175: GEODE-4160: upgrade mortbay-jetty-servlet-api dependency

[Ken Howe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57175/#review167511
---


Ship it!




Ship It!

- Ken Howe


On March 1, 2017, 1:39 a.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57175/
> ---
> 
> (Updated March 1, 2017, 1:39 a.m.)
> 
> 
> Review request for geode, Anthony Baker, Jinmei Liao, Jared Stewart, Kevin 
> Duling, Ken Howe, and Mark Bretl.
> 
> 
> Bugs: GEODE-4160
> https://issues.apache.org/jira/browse/GEODE-4160
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Upgrade mortbay-jetty-servlet-api dependency
> 
> This is the last upgrade on GEODE-4160 ticket.
> 
> 
> Diffs
> -
> 
>   gradle/dependency-versions.properties aca65fa 
> 
> 
> Diff: https://reviews.apache.org/r/57175/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin in progress
> uiTest passes
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

[jira] [Created] (GEODE-2562) Docs: simplify language in Main Features section

[Karen Smoler Miller (JIRA)]

Karen Smoler Miller created GEODE-2562:
--

 Summary: Docs: simplify language in Main Features section
 Key: GEODE-2562
 URL: https://issues.apache.org/jira/browse/GEODE-2562
 Project: Geode
  Issue Type: Bug
  Components: docs
Reporter: Karen Smoler Miller


Simplify some language within the page that describes main features of Geode.

Will do this task as commit-then-review.  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2562) Docs: simplify language in Main Features section

[Karen Smoler Miller (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15890790#comment-15890790
 ] 

Karen Smoler Miller commented on GEODE-2562:


Adding a paragraph about Geode Native and the clients that can be written.

> Docs: simplify language in Main Features section
> 
>
> Key: GEODE-2562
> URL: https://issues.apache.org/jira/browse/GEODE-2562
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Karen Smoler Miller
>
> Simplify some language within the page that describes main features of Geode.
> Will do this task as commit-then-review.  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 57175: GEODE-4160: upgrade mortbay-jetty-servlet-api dependency

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57175/#review167544
---


Ship it!




Ship It!

- Jinmei Liao


On March 1, 2017, 1:39 a.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57175/
> ---
> 
> (Updated March 1, 2017, 1:39 a.m.)
> 
> 
> Review request for geode, Anthony Baker, Jinmei Liao, Jared Stewart, Kevin 
> Duling, Ken Howe, and Mark Bretl.
> 
> 
> Bugs: GEODE-4160
> https://issues.apache.org/jira/browse/GEODE-4160
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Upgrade mortbay-jetty-servlet-api dependency
> 
> This is the last upgrade on GEODE-4160 ticket.
> 
> 
> Diffs
> -
> 
>   gradle/dependency-versions.properties aca65fa 
> 
> 
> Diff: https://reviews.apache.org/r/57175/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin in progress
> uiTest passes
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

[GitHub] geode pull request #410: Overhauling the javadocs for the LuceneService

[jhuynh1]

Github user jhuynh1 commented on a diff in the pull request:

https://github.com/apache/geode/pull/410#discussion_r103763944
  
--- Diff: 
geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneService.java ---
@@ -18,53 +18,77 @@
 import java.util.Map;
 import java.util.concurrent.TimeUnit;
 
+import org.apache.geode.cache.DataPolicy;
 import org.apache.lucene.analysis.Analyzer;
 
 import org.apache.geode.annotations.Experimental;
 import org.apache.geode.cache.GemFireCache;
 import org.apache.geode.cache.lucene.internal.LuceneIndexCreationProfile;
 
 /**
- * LuceneService instance is a singleton for each cache.
- * 
- * It provides handle for managing the {@link LuceneIndex} and create the 
{@link LuceneQuery} via
- * {@link LuceneQueryFactory}
- * 
+ *
+ * The LuceneService provides the capability to create lucene indexes and 
execute lucene
+ * queries on data stored in geode regions. The lucene indexes are 
automatically maintained
+ * by geode whenever entries are updated in the associated regions.
+ *
+ * 
+ * To obtain an instance of LuceneService, use {@link 
LuceneServiceProvider#get(GemFireCache)}.
+ * 
+ * 
+ * Lucene indexes can be created using gfsh, xml, or the java API. Below 
is an example of
+ * creating a lucene index with the java API. The lucene index created on 
each member that
+ * will host data for the region.
  * 
- * Example: 
- * 
  * 
- * At client and server JVM, initializing cache will create the 
LuceneServiceImpl object, 
- * which is a singleton at each JVM. 
- * 
- * At each server JVM, for data region to create index, create the index 
on fields with default analyzer:
- * LuceneIndex index = luceneService.createIndex(indexName, regionName, 
"field1", "field2", "field3"); 
- * or create index on fields with specified analyzer:
+ * {@code
+ * LuceneIndex index = luceneService.createIndex(indexName, regionName, 
"field1", "field2", "field3");
+ * }
+ * 
+ * 
+ * You can also specify what {@link Analyzer} to use for each field.
+ * 
+ * 
+ * {@code
  * LuceneIndex index = luceneService.createIndex(indexName, regionName, 
analyzerPerField);
- * 
- * We can also create index via cache.xml or gfsh.
- * 
- * At client side, create query and run the search:
- * 
- * LuceneQuery query = 
luceneService.createLuceneQueryFactory().setLimit(200).setPageSize(20)
- * .setResultTypes(SCORE, VALUE, KEY).setFieldProjection("field1", 
"field2")
- * .create(indexName, regionName, querystring, analyzer);
- * 
- * The querystring is using lucene's queryparser syntax, such as 
"field1:zhou* AND field2:gz...@pivotal.io"
- *  
- * PageableLuceneQueryResults results = query.search();
- * 
- * If pagination is not specified:
- * List list = results.getNextPage(); // return all results in one 
getNextPage() call
- * or if paging is specified:
- * if (results.hasNextPage()) {
- *   List page = results.nextPage(); // return resules page by page
  * }
- * 
- * The item of the list is either the domain object or instance of {@link 
LuceneResultStruct}
  * 
- * 
  *
+ * Indexes should be created on all peers that host the region being 
indexed. Clients do not need
+ * to define the index, they can directly execute queries using this 
service.
+ *
+ * 
+ * Queries on this service can return either the region keys, values, or 
both that match
+ * a lucene query expression. To execute a query, start with the {@link 
#createLuceneQueryFactory()} method.
+ * 
+ *
+ * 
+ * {@code
+ * LuceneQuery query = luceneService.createLuceneQueryFactory()
+ *.setLimit(200)
+ *.create(indexName, regionName, "name:John AND zipcode:97006", 
defaultField);
+ * Collection results = query.findValues();
+ * }
+ * 
+ *
+ * 
+ * The lucene index data is colocated with the region that is indexed. 
This means
+ * that the index data will partitioned, copied, or persisted using the 
same configuration
--- End diff --

will *be partitioned


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #410: Overhauling the javadocs for the LuceneService

[jhuynh1]

Github user jhuynh1 commented on a diff in the pull request:

https://github.com/apache/geode/pull/410#discussion_r103763560
  
--- Diff: 
geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneResultStruct.java
 ---
@@ -17,34 +17,29 @@
 import org.apache.geode.annotations.Experimental;
 
 /**
- * 
- * Abstract data structure for one item in query result.
+ * A single result of a lucene query.
  * 
  */
 @Experimental
 public interface LuceneResultStruct {
 
   /**
-   * Return key of the entry
+   * @return The region key of the entry matching the query
*
-   * @return key
-   * @throws IllegalArgumentException If this struct does not contain key
*/
   public K getKey();
 
   /**
-   * Return value of the entry
+   * @return the region value of the entry matching the query.
*
-   * @return value the whole domain object
-   * @throws IllegalArgumentException If this struct does not contain value
*/
   public V getValue();
 
   /**
-   * Return score of the query
+   * Return score of the score of the entry matching the query. Scores
--- End diff --

I think you meant "Return score of the entry..."?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #410: Overhauling the javadocs for the LuceneService

[jhuynh1]

Github user jhuynh1 commented on a diff in the pull request:

https://github.com/apache/geode/pull/410#discussion_r103764691
  
--- Diff: 
geode-lucene/src/main/java/org/apache/geode/cache/lucene/PageableLuceneQueryResults.java
 ---
@@ -15,30 +15,34 @@
 
 package org.apache.geode.cache.lucene;
 
+import org.apache.geode.annotations.Experimental;
+
 import java.util.Iterator;
 import java.util.List;
 
-import org.apache.geode.annotations.Experimental;
-
 /**
  * 
- * Defines the interface for a container of lucene query result collected 
from function
- * execution.
- * 
- * 
+ * This interface allows you to retrieve a page of query results at time, 
using the {@link #hasNext()}
--- End diff --

at *a time


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-examples pull request #3: GEODE-2231 A partitioned region example

[upthewaterspout]

Github user upthewaterspout commented on a diff in the pull request:

https://github.com/apache/geode-examples/pull/3#discussion_r103763778
  
--- Diff: 
partitioned/src/main/java/org/apache/geode/examples/partitioned/Consumer.java 
---
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.examples.partitioned;
+
+import java.util.*;
+import org.apache.geode.cache.client.ClientCache;
+import org.apache.geode.cache.Region;
+
+public class Consumer extends BaseClient {
+
+  public static void main(String[] args) {
+Consumer c = new Consumer();
+c.checkAndPrint(args);
+  }
+
+  public void checkAndPrint(String[] args) {
+if (0 == args.length) {
+  throw new RuntimeException("Expected argument specifying region 
name.");
+} else {
--- End diff --

Nitpick - no need for an else. If (0 == args.length), your method was over 
when it threw an exception. This could help from having a bunch of nested 
levels of if/else here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-examples pull request #3: GEODE-2231 A partitioned region example

[upthewaterspout]

Github user upthewaterspout commented on a diff in the pull request:

https://github.com/apache/geode-examples/pull/3#discussion_r103763868
  
--- Diff: 
partitioned/src/main/java/org/apache/geode/examples/partitioned/Consumer.java 
---
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.examples.partitioned;
+
+import java.util.*;
+import org.apache.geode.cache.client.ClientCache;
+import org.apache.geode.cache.Region;
+
+public class Consumer extends BaseClient {
+
+  public static void main(String[] args) {
+Consumer c = new Consumer();
+c.checkAndPrint(args);
+  }
+
+  public void checkAndPrint(String[] args) {
+if (0 == args.length) {
+  throw new RuntimeException("Expected argument specifying region 
name.");
+} else {
+  if (args.length > 1) {
+throw new RuntimeException("Expected only 1 argument, and received 
more than 1.");
+  } else {
+if (args[0].equals("EmployeeRegion")) {
+  this.printRegionContents();
+} else {
+  if (args[0].equals("BadEmployeeRegion")) {
+this.printBadRegionContents();
+  } else {
+throw new RuntimeException("Unrecognized region name in 
argument specification.");
+  }
+}
+  }
+}
+  }
+
+  public Consumer() {}
+
+  public Consumer(ClientCache clientCache) {
+this.clientCache = clientCache;
+  }
+
+
+  public void printRegionContents() {
+/* Print EmployeeRegion size and contents */
+Region r1 = this.getRegion1();
+Set setOfKeys1 = r1.keySetOnServer();
+logger.info(setOfKeys1.size() + " entries in EmployeeRegion on the 
server(s).");
+if (setOfKeys1.size() > 0) {
--- End diff --

Nitpick - no need for this if check I think.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-examples pull request #3: GEODE-2231 A partitioned region example

[upthewaterspout]

Github user upthewaterspout commented on a diff in the pull request:

https://github.com/apache/geode-examples/pull/3#discussion_r103761595
  
--- Diff: partitioned/README.md ---
@@ -0,0 +1,276 @@
+
+
+# Geode partitioned region example
+
+This example demonstrates the basic property of partitioning, as well
--- End diff --

It might be good to reflow the text here, if someone is looking at it with 
a regular text editor it looks a little choppy.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2231) Create new partitioning example

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15890841#comment-15890841
 ] 

ASF GitHub Bot commented on GEODE-2231:
---

Github user upthewaterspout commented on a diff in the pull request:

https://github.com/apache/geode-examples/pull/3#discussion_r103761595
  
--- Diff: partitioned/README.md ---
@@ -0,0 +1,276 @@
+
+
+# Geode partitioned region example
+
+This example demonstrates the basic property of partitioning, as well
--- End diff --

It might be good to reflow the text here, if someone is looking at it with 
a regular text editor it looks a little choppy.


> Create new partitioning example
> ---
>
> Key: GEODE-2231
> URL: https://issues.apache.org/jira/browse/GEODE-2231
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>Priority: Minor
>
> Add a new example to the geode-examples that demonstrates partitioning.
> The example will use the same structure as the replicated example, starting 2 
> servers that host a partitioned region (with no redundant copies).  Run the 
> producer to populate the region.  Run the consumer to see the contents of the 
> region. Then, stop one of the servers and run the consumer again to notice 
> that only roughly half (with 2 servers and hopefully a reasonable hash) of 
> the entries are present.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-examples pull request #3: GEODE-2231 A partitioned region example

[upthewaterspout]

Github user upthewaterspout commented on a diff in the pull request:

https://github.com/apache/geode-examples/pull/3#discussion_r103763443
  
--- Diff: 
partitioned/src/main/java/org/apache/geode/examples/partitioned/BaseClient.java 
---
@@ -0,0 +1,79 @@
+/*
--- End diff --

Nitpick - I feel like this BaseClient actually makes the code less 
readable. It might be better to just create the caches and regions inline in 
the producer and consumer, and just have a static class that has the common 
properties.

Also, getRegion1 and getRegion2 aren't very descriptive method names.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2231) Create new partitioning example

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15890843#comment-15890843
 ] 

ASF GitHub Bot commented on GEODE-2231:
---

Github user upthewaterspout commented on a diff in the pull request:

https://github.com/apache/geode-examples/pull/3#discussion_r103763868
  
--- Diff: 
partitioned/src/main/java/org/apache/geode/examples/partitioned/Consumer.java 
---
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.examples.partitioned;
+
+import java.util.*;
+import org.apache.geode.cache.client.ClientCache;
+import org.apache.geode.cache.Region;
+
+public class Consumer extends BaseClient {
+
+  public static void main(String[] args) {
+Consumer c = new Consumer();
+c.checkAndPrint(args);
+  }
+
+  public void checkAndPrint(String[] args) {
+if (0 == args.length) {
+  throw new RuntimeException("Expected argument specifying region 
name.");
+} else {
+  if (args.length > 1) {
+throw new RuntimeException("Expected only 1 argument, and received 
more than 1.");
+  } else {
+if (args[0].equals("EmployeeRegion")) {
+  this.printRegionContents();
+} else {
+  if (args[0].equals("BadEmployeeRegion")) {
+this.printBadRegionContents();
+  } else {
+throw new RuntimeException("Unrecognized region name in 
argument specification.");
+  }
+}
+  }
+}
+  }
+
+  public Consumer() {}
+
+  public Consumer(ClientCache clientCache) {
+this.clientCache = clientCache;
+  }
+
+
+  public void printRegionContents() {
+/* Print EmployeeRegion size and contents */
+Region r1 = this.getRegion1();
+Set setOfKeys1 = r1.keySetOnServer();
+logger.info(setOfKeys1.size() + " entries in EmployeeRegion on the 
server(s).");
+if (setOfKeys1.size() > 0) {
--- End diff --

Nitpick - no need for this if check I think.


> Create new partitioning example
> ---
>
> Key: GEODE-2231
> URL: https://issues.apache.org/jira/browse/GEODE-2231
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>Priority: Minor
>
> Add a new example to the geode-examples that demonstrates partitioning.
> The example will use the same structure as the replicated example, starting 2 
> servers that host a partitioned region (with no redundant copies).  Run the 
> producer to populate the region.  Run the consumer to see the contents of the 
> region. Then, stop one of the servers and run the consumer again to notice 
> that only roughly half (with 2 servers and hopefully a reasonable hash) of 
> the entries are present.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2231) Create new partitioning example

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15890842#comment-15890842
 ] 

ASF GitHub Bot commented on GEODE-2231:
---

Github user upthewaterspout commented on a diff in the pull request:

https://github.com/apache/geode-examples/pull/3#discussion_r103763778
  
--- Diff: 
partitioned/src/main/java/org/apache/geode/examples/partitioned/Consumer.java 
---
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.examples.partitioned;
+
+import java.util.*;
+import org.apache.geode.cache.client.ClientCache;
+import org.apache.geode.cache.Region;
+
+public class Consumer extends BaseClient {
+
+  public static void main(String[] args) {
+Consumer c = new Consumer();
+c.checkAndPrint(args);
+  }
+
+  public void checkAndPrint(String[] args) {
+if (0 == args.length) {
+  throw new RuntimeException("Expected argument specifying region 
name.");
+} else {
--- End diff --

Nitpick - no need for an else. If (0 == args.length), your method was over 
when it threw an exception. This could help from having a bunch of nested 
levels of if/else here.


> Create new partitioning example
> ---
>
> Key: GEODE-2231
> URL: https://issues.apache.org/jira/browse/GEODE-2231
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>Priority: Minor
>
> Add a new example to the geode-examples that demonstrates partitioning.
> The example will use the same structure as the replicated example, starting 2 
> servers that host a partitioned region (with no redundant copies).  Run the 
> producer to populate the region.  Run the consumer to see the contents of the 
> region. Then, stop one of the servers and run the consumer again to notice 
> that only roughly half (with 2 servers and hopefully a reasonable hash) of 
> the entries are present.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2231) Create new partitioning example

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15890840#comment-15890840
 ] 

ASF GitHub Bot commented on GEODE-2231:
---

Github user upthewaterspout commented on a diff in the pull request:

https://github.com/apache/geode-examples/pull/3#discussion_r103763443
  
--- Diff: 
partitioned/src/main/java/org/apache/geode/examples/partitioned/BaseClient.java 
---
@@ -0,0 +1,79 @@
+/*
--- End diff --

Nitpick - I feel like this BaseClient actually makes the code less 
readable. It might be better to just create the caches and regions inline in 
the producer and consumer, and just have a static class that has the common 
properties.

Also, getRegion1 and getRegion2 aren't very descriptive method names.


> Create new partitioning example
> ---
>
> Key: GEODE-2231
> URL: https://issues.apache.org/jira/browse/GEODE-2231
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>Priority: Minor
>
> Add a new example to the geode-examples that demonstrates partitioning.
> The example will use the same structure as the replicated example, starting 2 
> servers that host a partitioned region (with no redundant copies).  Run the 
> producer to populate the region.  Run the consumer to see the contents of the 
> region. Then, stop one of the servers and run the consumer again to notice 
> that only roughly half (with 2 servers and hopefully a reasonable hash) of 
> the entries are present.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 57208: GEODE-2560: Missing disk files (.crf) during backup/restore throws exception

[Kevin Duling]

> On March 1, 2017, 10:25 a.m., anilkumar gingade wrote:
> > geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java
> > Line 5810 (original), 5810 (patched)
> > 
> >
> > Do we need the same check for drf file?

I think it needs to be understood why the crf was missing in the first place 
when the crf file variable is not null.  Was it an oversight or expected 
behavior to have the old FileUtil fail silently when the source file does not 
exist?  This change will fix a failing test, but it may be revealing a deeper 
issue that was masked by the silent fail.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57208/#review167411
---


On March 1, 2017, 9:56 a.m., Kevin Duling wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57208/
> ---
> 
> (Updated March 1, 2017, 9:56 a.m.)
> 
> 
> Review request for geode, Darrel Schneider, Jared Stewart, Kirk Lund, and Dan 
> Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2560: Missing disk files (.crf) during backup/restore throws exception
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java 
> f5aec51a09e671bc7d4ca33d4de8f0f683ef4d73 
> 
> 
> Diff: https://reviews.apache.org/r/57208/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin running
> 
> 
> Thanks,
> 
> Kevin Duling
> 
>

Failed: apache/geode#2126 (GEODE-2290 - 02fac31)

[Travis CI]

Build Update for apache/geode
-

Build: #2126
Status: Failed

Duration: 7 minutes and 12 seconds
Commit: 02fac31 (GEODE-2290)
Author: Jared Stewart
Message: DeployJarTestSuite is failing

View the changeset: 
https://github.com/apache/geode/compare/228bf4ff7ff4^...02fac310052f

View the full build log and details: 
https://travis-ci.org/apache/geode/builds/206426402

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

[GitHub] geode-native pull request #43: adding waypoints javascript for subnav

[dyozie]

GitHub user dyozie opened a pull request:

https://github.com/apache/geode-native/pull/43

adding waypoints javascript for subnav

@davebarnes97  This adds the javascript necessary for expanding/collapsing 
subnavs

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dyozie/geode-native javascript-fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/43.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #43


commit 934e1b230b88e4dafb3477e97c22d8a17e85acf2
Author: dyozie 
Date:   2017-03-01T19:58:39Z

adding waypoints javascript for subnav




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 57208: GEODE-2560: Missing disk files (.crf) during backup/restore throws exception

[Darrel Schneider]

> On March 1, 2017, 10:25 a.m., anilkumar gingade wrote:
> > geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java
> > Line 5810 (original), 5810 (patched)
> > 
> >
> > Do we need the same check for drf file?
> 
> Kevin Duling wrote:
> I think it needs to be understood why the crf was missing in the first 
> place when the crf file variable is not null.  Was it an oversight or 
> expected behavior to have the old FileUtil fail silently when the source file 
> does not exist?  This change will fix a failing test, but it may be revealing 
> a deeper issue that was masked by the silent fail.

Whatever is causing the crf to exist will probably also cause the drf to not 
exist. So odds are that with your fix these tests will now get to the next line 
and throw on exception on the drf not existing. It can also happen on the next 
line that copies the krf.


- Darrel


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57208/#review167411
---


On March 1, 2017, 9:56 a.m., Kevin Duling wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57208/
> ---
> 
> (Updated March 1, 2017, 9:56 a.m.)
> 
> 
> Review request for geode, Darrel Schneider, Jared Stewart, Kirk Lund, and Dan 
> Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2560: Missing disk files (.crf) during backup/restore throws exception
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java 
> f5aec51a09e671bc7d4ca33d4de8f0f683ef4d73 
> 
> 
> Diff: https://reviews.apache.org/r/57208/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin running
> 
> 
> Thanks,
> 
> Kevin Duling
> 
>

[GitHub] geode-native pull request #43: adding waypoints javascript for subnav

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/43


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (GEODE-2563) gfsh destroy region should be idempotent

[Swapnil Bawaskar (JIRA)]

Swapnil Bawaskar created GEODE-2563:
---

 Summary: gfsh destroy region should be idempotent
 Key: GEODE-2563
 URL: https://issues.apache.org/jira/browse/GEODE-2563
 Project: Geode
  Issue Type: Improvement
  Components: gfsh
Reporter: Swapnil Bawaskar


If a developer is using gfsh script to define the geode cluster, we should 
support the ability to run the gfsh script multiple times. 
Currently, {{destroy region}} gfsh command throws an error if the region does 
not exist. We should an option {{--if-exists}} to the {{destroy region}} 
command so that it can be scripted.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2563) All destroy commands in gfsh should be idempotent

[Swapnil Bawaskar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Swapnil Bawaskar updated GEODE-2563:

Summary: All destroy commands in gfsh should be idempotent  (was: gfsh 
destroy region should be idempotent)

> All destroy commands in gfsh should be idempotent
> -
>
> Key: GEODE-2563
> URL: https://issues.apache.org/jira/browse/GEODE-2563
> Project: Geode
>  Issue Type: Improvement
>  Components: gfsh
>Reporter: Swapnil Bawaskar
>
> If a developer is using gfsh script to define the geode cluster, we should 
> support the ability to run the gfsh script multiple times. 
> Currently, {{destroy region}} gfsh command throws an error if the region does 
> not exist. We should an option {{--if-exists}} to the {{destroy region}} 
> command so that it can be scripted.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2563) All destroy commands in gfsh should be idempotent

[Swapnil Bawaskar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Swapnil Bawaskar updated GEODE-2563:

Description: If a developer is using gfsh script to define the geode 
cluster, we should support the ability to run the gfsh script multiple times.  
(was: If a developer is using gfsh script to define the geode cluster, we 
should support the ability to run the gfsh script multiple times. 
Currently, {{destroy region}} gfsh command throws an error if the region does 
not exist. We should an option {{--if-exists}} to the {{destroy region}} 
command so that it can be scripted.)

> All destroy commands in gfsh should be idempotent
> -
>
> Key: GEODE-2563
> URL: https://issues.apache.org/jira/browse/GEODE-2563
> Project: Geode
>  Issue Type: Improvement
>  Components: gfsh
>Reporter: Swapnil Bawaskar
>
> If a developer is using gfsh script to define the geode cluster, we should 
> support the ability to run the gfsh script multiple times.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2564) gfsh destroy region should be idempotent

[Swapnil Bawaskar (JIRA)]

Swapnil Bawaskar created GEODE-2564:
---

 Summary: gfsh destroy region should be idempotent
 Key: GEODE-2564
 URL: https://issues.apache.org/jira/browse/GEODE-2564
 Project: Geode
  Issue Type: Sub-task
  Components: gfsh
Reporter: Swapnil Bawaskar


Currently, destroy region gfsh command throws an error if the region does not 
exist. We should an option {{--if-exists}} to the destroy region command so 
that it can be scripted.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (GEODE-2561) Docs: error in gfsecurity.properties example (Geode User Guide)

[Dave Barnes (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Barnes reassigned GEODE-2561:
--

Assignee: Dave Barnes

> Docs: error in gfsecurity.properties example (Geode User Guide)
> ---
>
> Key: GEODE-2561
> URL: https://issues.apache.org/jira/browse/GEODE-2561
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Dave Barnes
>Assignee: Dave Barnes
>
> Reported by Mike Martell:
> Looks like an error on this SSL Sample Impl page: 
> .../managing/security/ssl_example.html
> Seems like they're using a path for a password:
> ssl-truststore-password=/path/to/trusted.truststore
> [db note] 
> Check entire page to make sure properties shown are consistent with the 
> current implementation, as security properties (in particular) were recently 
> revised.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #408: GEODE-2551 Fix code issues found by AppChecker

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/408


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2551) Possible bugs in the source code

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891012#comment-15891012
 ] 

ASF GitHub Bot commented on GEODE-2551:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/408


> Possible bugs in the source code
> 
>
> Key: GEODE-2551
> URL: https://issues.apache.org/jira/browse/GEODE-2551
> Project: Geode
>  Issue Type: Bug
>Reporter: AppChecker
>
> Hello!
> We've checked your project with [static code analyzer 
> AppChecker|https://cnpo.ru/en/solutions/appchecker.php]
> It found several possible defects in the source code:
> 1) 
> https://github.com/apache/geode/blob/8bf39571471642beaaa36c9626a61a90bd3803c2/geode-core/src/main/java/org/apache/geode/management/internal/cli/parser/ParserUtils.java#L96
> {code:java}
> if ((split[i].endsWith("\"") && split[i].endsWith("\""))
> || (split[i].startsWith("\'") && split[i].endsWith("\'"))) {
> {code}
> {noformat}split[i].endsWith("\"") {noformat} is checked twice.
> Probably it should be:
> {code:java}
> if ((split[i].startsWith("\"") && split[i].endsWith("\""))
> || (split[i].startsWith("\'") && split[i].endsWith("\'"))) {
> {code}
> 2) 
> https://github.com/apache/geode/blob/6e5013102927099a725282b6bad5d64a79152fab/geode-core/src/test/java/org/apache/geode/cache/query/dunit/SelectStarQueryDUnitTest.java#L1384
> https://github.com/apache/geode/blob/6e5013102927099a725282b6bad5d64a79152fab/geode-core/src/test/java/org/apache/geode/cache/query/dunit/SelectStarQueryDUnitTest.java#L1444
> {code:java}
> else if (rs instanceof PortfolioPdx || rs instanceof PortfolioPdx) {
> {code}
> rs is checked twice
> 3) 
> https://github.com/apache/geode/blob/8bf39571471642beaaa36c9626a61a90bd3803c2/geode-core/src/main/java/org/apache/geode/management/internal/cli/util/JsonUtil.java#L388
> {code:java}
> } else if (klass.isAssignableFrom(Float.class) || 
> klass.isAssignableFrom(Float.class)) {
> {code}
> klass.isAssignableFrom(Float.class)  is checked twcie



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2551) Possible bugs in the source code

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891011#comment-15891011
 ] 

ASF subversion and git services commented on GEODE-2551:


Commit 8b94e2ec2dc1192e96fc822b4b3a49561a76b2dc in geode's branch 
refs/heads/develop from [~amb]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=8b94e2e ]

GEODE-2551 Fix code issues found by AppChecker

This closes #408


> Possible bugs in the source code
> 
>
> Key: GEODE-2551
> URL: https://issues.apache.org/jira/browse/GEODE-2551
> Project: Geode
>  Issue Type: Bug
>Reporter: AppChecker
>
> Hello!
> We've checked your project with [static code analyzer 
> AppChecker|https://cnpo.ru/en/solutions/appchecker.php]
> It found several possible defects in the source code:
> 1) 
> https://github.com/apache/geode/blob/8bf39571471642beaaa36c9626a61a90bd3803c2/geode-core/src/main/java/org/apache/geode/management/internal/cli/parser/ParserUtils.java#L96
> {code:java}
> if ((split[i].endsWith("\"") && split[i].endsWith("\""))
> || (split[i].startsWith("\'") && split[i].endsWith("\'"))) {
> {code}
> {noformat}split[i].endsWith("\"") {noformat} is checked twice.
> Probably it should be:
> {code:java}
> if ((split[i].startsWith("\"") && split[i].endsWith("\""))
> || (split[i].startsWith("\'") && split[i].endsWith("\'"))) {
> {code}
> 2) 
> https://github.com/apache/geode/blob/6e5013102927099a725282b6bad5d64a79152fab/geode-core/src/test/java/org/apache/geode/cache/query/dunit/SelectStarQueryDUnitTest.java#L1384
> https://github.com/apache/geode/blob/6e5013102927099a725282b6bad5d64a79152fab/geode-core/src/test/java/org/apache/geode/cache/query/dunit/SelectStarQueryDUnitTest.java#L1444
> {code:java}
> else if (rs instanceof PortfolioPdx || rs instanceof PortfolioPdx) {
> {code}
> rs is checked twice
> 3) 
> https://github.com/apache/geode/blob/8bf39571471642beaaa36c9626a61a90bd3803c2/geode-core/src/main/java/org/apache/geode/management/internal/cli/util/JsonUtil.java#L388
> {code:java}
> } else if (klass.isAssignableFrom(Float.class) || 
> klass.isAssignableFrom(Float.class)) {
> {code}
> klass.isAssignableFrom(Float.class)  is checked twcie



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2551) Possible bugs in the source code

[Anthony Baker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anthony Baker resolved GEODE-2551.
--
   Resolution: Fixed
Fix Version/s: 1.2.0

> Possible bugs in the source code
> 
>
> Key: GEODE-2551
> URL: https://issues.apache.org/jira/browse/GEODE-2551
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, serialization
>Reporter: AppChecker
>Assignee: Anthony Baker
> Fix For: 1.2.0
>
>
> Hello!
> We've checked your project with [static code analyzer 
> AppChecker|https://cnpo.ru/en/solutions/appchecker.php]
> It found several possible defects in the source code:
> 1) 
> https://github.com/apache/geode/blob/8bf39571471642beaaa36c9626a61a90bd3803c2/geode-core/src/main/java/org/apache/geode/management/internal/cli/parser/ParserUtils.java#L96
> {code:java}
> if ((split[i].endsWith("\"") && split[i].endsWith("\""))
> || (split[i].startsWith("\'") && split[i].endsWith("\'"))) {
> {code}
> {noformat}split[i].endsWith("\"") {noformat} is checked twice.
> Probably it should be:
> {code:java}
> if ((split[i].startsWith("\"") && split[i].endsWith("\""))
> || (split[i].startsWith("\'") && split[i].endsWith("\'"))) {
> {code}
> 2) 
> https://github.com/apache/geode/blob/6e5013102927099a725282b6bad5d64a79152fab/geode-core/src/test/java/org/apache/geode/cache/query/dunit/SelectStarQueryDUnitTest.java#L1384
> https://github.com/apache/geode/blob/6e5013102927099a725282b6bad5d64a79152fab/geode-core/src/test/java/org/apache/geode/cache/query/dunit/SelectStarQueryDUnitTest.java#L1444
> {code:java}
> else if (rs instanceof PortfolioPdx || rs instanceof PortfolioPdx) {
> {code}
> rs is checked twice
> 3) 
> https://github.com/apache/geode/blob/8bf39571471642beaaa36c9626a61a90bd3803c2/geode-core/src/main/java/org/apache/geode/management/internal/cli/util/JsonUtil.java#L388
> {code:java}
> } else if (klass.isAssignableFrom(Float.class) || 
> klass.isAssignableFrom(Float.class)) {
> {code}
> klass.isAssignableFrom(Float.class)  is checked twcie



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2551) Possible bugs in the source code

[Anthony Baker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anthony Baker updated GEODE-2551:
-
Component/s: serialization
 gfsh

> Possible bugs in the source code
> 
>
> Key: GEODE-2551
> URL: https://issues.apache.org/jira/browse/GEODE-2551
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, serialization
>Reporter: AppChecker
> Fix For: 1.2.0
>
>
> Hello!
> We've checked your project with [static code analyzer 
> AppChecker|https://cnpo.ru/en/solutions/appchecker.php]
> It found several possible defects in the source code:
> 1) 
> https://github.com/apache/geode/blob/8bf39571471642beaaa36c9626a61a90bd3803c2/geode-core/src/main/java/org/apache/geode/management/internal/cli/parser/ParserUtils.java#L96
> {code:java}
> if ((split[i].endsWith("\"") && split[i].endsWith("\""))
> || (split[i].startsWith("\'") && split[i].endsWith("\'"))) {
> {code}
> {noformat}split[i].endsWith("\"") {noformat} is checked twice.
> Probably it should be:
> {code:java}
> if ((split[i].startsWith("\"") && split[i].endsWith("\""))
> || (split[i].startsWith("\'") && split[i].endsWith("\'"))) {
> {code}
> 2) 
> https://github.com/apache/geode/blob/6e5013102927099a725282b6bad5d64a79152fab/geode-core/src/test/java/org/apache/geode/cache/query/dunit/SelectStarQueryDUnitTest.java#L1384
> https://github.com/apache/geode/blob/6e5013102927099a725282b6bad5d64a79152fab/geode-core/src/test/java/org/apache/geode/cache/query/dunit/SelectStarQueryDUnitTest.java#L1444
> {code:java}
> else if (rs instanceof PortfolioPdx || rs instanceof PortfolioPdx) {
> {code}
> rs is checked twice
> 3) 
> https://github.com/apache/geode/blob/8bf39571471642beaaa36c9626a61a90bd3803c2/geode-core/src/main/java/org/apache/geode/management/internal/cli/util/JsonUtil.java#L388
> {code:java}
> } else if (klass.isAssignableFrom(Float.class) || 
> klass.isAssignableFrom(Float.class)) {
> {code}
> klass.isAssignableFrom(Float.class)  is checked twcie



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (GEODE-2551) Possible bugs in the source code

[Anthony Baker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anthony Baker reassigned GEODE-2551:


Assignee: Anthony Baker

> Possible bugs in the source code
> 
>
> Key: GEODE-2551
> URL: https://issues.apache.org/jira/browse/GEODE-2551
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, serialization
>Reporter: AppChecker
>Assignee: Anthony Baker
> Fix For: 1.2.0
>
>
> Hello!
> We've checked your project with [static code analyzer 
> AppChecker|https://cnpo.ru/en/solutions/appchecker.php]
> It found several possible defects in the source code:
> 1) 
> https://github.com/apache/geode/blob/8bf39571471642beaaa36c9626a61a90bd3803c2/geode-core/src/main/java/org/apache/geode/management/internal/cli/parser/ParserUtils.java#L96
> {code:java}
> if ((split[i].endsWith("\"") && split[i].endsWith("\""))
> || (split[i].startsWith("\'") && split[i].endsWith("\'"))) {
> {code}
> {noformat}split[i].endsWith("\"") {noformat} is checked twice.
> Probably it should be:
> {code:java}
> if ((split[i].startsWith("\"") && split[i].endsWith("\""))
> || (split[i].startsWith("\'") && split[i].endsWith("\'"))) {
> {code}
> 2) 
> https://github.com/apache/geode/blob/6e5013102927099a725282b6bad5d64a79152fab/geode-core/src/test/java/org/apache/geode/cache/query/dunit/SelectStarQueryDUnitTest.java#L1384
> https://github.com/apache/geode/blob/6e5013102927099a725282b6bad5d64a79152fab/geode-core/src/test/java/org/apache/geode/cache/query/dunit/SelectStarQueryDUnitTest.java#L1444
> {code:java}
> else if (rs instanceof PortfolioPdx || rs instanceof PortfolioPdx) {
> {code}
> rs is checked twice
> 3) 
> https://github.com/apache/geode/blob/8bf39571471642beaaa36c9626a61a90bd3803c2/geode-core/src/main/java/org/apache/geode/management/internal/cli/util/JsonUtil.java#L388
> {code:java}
> } else if (klass.isAssignableFrom(Float.class) || 
> klass.isAssignableFrom(Float.class)) {
> {code}
> klass.isAssignableFrom(Float.class)  is checked twcie



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 57208: GEODE-2560: Missing disk files (.crf) during backup/restore throws exception

[Kevin Duling]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57208/
---

(Updated March 1, 2017, 12:56 p.m.)


Review request for geode, Darrel Schneider, Jared Stewart, Kirk Lund, and Dan 
Smith.


Repository: geode


Description
---

GEODE-2560: Missing disk files (.crf) during backup/restore throws exception


Diffs (updated)
-

  geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java 
f5aec51a09e671bc7d4ca33d4de8f0f683ef4d73 


Diff: https://reviews.apache.org/r/57208/diff/2/

Changes: https://reviews.apache.org/r/57208/diff/1-2/


Testing
---

precheckin running


Thanks,

Kevin Duling

[jira] [Created] (GEODE-2565) gfsh destroy gateway-sender should be idempotent

[Swapnil Bawaskar (JIRA)]

Swapnil Bawaskar created GEODE-2565:
---

 Summary: gfsh destroy gateway-sender should be idempotent
 Key: GEODE-2565
 URL: https://issues.apache.org/jira/browse/GEODE-2565
 Project: Geode
  Issue Type: Sub-task
  Components: gfsh
Reporter: Swapnil Bawaskar


Currently, running destroy gateway-sender multiple times return the following 
error:
{{{
destroy gateway-sender --id=1

Member | Status
-- | -
serv2  | ERROR: GateWaySender with Id  1 not found
serv1  | ERROR: GateWaySender with Id  1 not found
}}}
We should add a {{--if-exists}} option to destroy gateway-sender command.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2566) gfsh destroy index should be idempotent

[Swapnil Bawaskar (JIRA)]

Swapnil Bawaskar created GEODE-2566:
---

 Summary: gfsh destroy index should be idempotent
 Key: GEODE-2566
 URL: https://issues.apache.org/jira/browse/GEODE-2566
 Project: Geode
  Issue Type: Sub-task
  Components: gfsh
Reporter: Swapnil Bawaskar


Currently, running destroy index multiple times return the following error:
{{{
gfsh>destroy index --name=i1
Index "i1" could not be destroyed for following reasons
Index named "i1" not found.
Occurred on following members
1. 192.168.1.181(serv1:17230):1025
2. 192.168.1.181(serv2:17842):1026
}}}
We should add a {{--if-exists}} option to destroy index command.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2567) gfsh destroy disk-store should be idempotent

[Swapnil Bawaskar (JIRA)]

Swapnil Bawaskar created GEODE-2567:
---

 Summary: gfsh destroy disk-store should be idempotent
 Key: GEODE-2567
 URL: https://issues.apache.org/jira/browse/GEODE-2567
 Project: Geode
  Issue Type: Sub-task
  Components: gfsh
Reporter: Swapnil Bawaskar


Currently, gfsh {{destroy disk-store}} does *not* throw an error when run 
multiple times:
{{{
gfsh>destroy disk-store --name=foo
Member | Result
-- | ---
serv1  | Disk store not found on this member
serv2  | Disk store not found on this member

}}}
However, for a uniform user experience, it should. We should then add a 
{{--if-exists}} option to the command to make it idempotent.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (GEODE-2541) NetstatDUnitTest fails with ClassCastException

[Kenneth Howe (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kenneth Howe reassigned GEODE-2541:
---

Assignee: Kenneth Howe

> NetstatDUnitTest fails with ClassCastException
> --
>
> Key: GEODE-2541
> URL: https://issues.apache.org/jira/browse/GEODE-2541
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, tests
>Reporter: Kirk Lund
>Assignee: Kenneth Howe
>  Labels: MiscellaneousCommands, NetstatCommand, gfsh, netstat
>
> This might be a bug in the error handling code for gfsh or the functions used 
> by MiscellaneousCommands.
> {noformat}
> org.apache.geode.management.internal.cli.NetstatDUnitTest > 
> testConnectToJmxManagerOne FAILED
> org.junit.ComparisonFailure: [{"errorCode":505,"message":["Could not 
> process command due to GemFire error. Error occurred while executing netstat 
> on [server-1]"]}] expected:<[OK]> but was:<[ERROR]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native 
> Method)
> at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at 
> org.apache.geode.test.dunit.rules.GfshShellConnectionRule.executeAndVerifyCommand(GfshShellConnectionRule.java:168)
> at 
> org.apache.geode.management.internal.cli.NetstatDUnitTest.testConnectToJmxManagerOne(NetstatDUnitTest.java:82)
> org.apache.geode.management.internal.cli.NetstatDUnitTest > 
> testConnectToJmxManagerTwo FAILED
> java.lang.ClassCastException: java.lang.String cannot be cast to 
> org.apache.geode.management.internal.cli.result.CommandResult
> at 
> org.apache.geode.test.dunit.rules.GfshShellConnectionRule.executeCommand(GfshShellConnectionRule.java:159)
> at 
> org.apache.geode.test.dunit.rules.GfshShellConnectionRule.executeAndVerifyCommand(GfshShellConnectionRule.java:166)
> at 
> org.apache.geode.management.internal.cli.NetstatDUnitTest.testConnectToJmxManagerTwo(NetstatDUnitTest.java:88)
> org.apache.geode.management.internal.cli.NetstatDUnitTest > 
> testConnectToLocator FAILED
> org.junit.ComparisonFailure: [{"errorCode":520,"message":["Could not find 
> member(s) with Id(s) or name(s): server-1."]}] expected:<[OK]> but 
> was:<[ERROR]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native 
> Method)
> at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at 
> org.apache.geode.test.dunit.rules.GfshShellConnectionRule.executeAndVerifyCommand(GfshShellConnectionRule.java:168)
> at 
> org.apache.geode.management.internal.cli.NetstatDUnitTest.testConnectToLocator(NetstatDUnitTest.java:76)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2568) When its AsyncEventQueue is destroyed, its JMX MBean is not removed

[Barry Oglesby (JIRA)]

Barry Oglesby created GEODE-2568:


 Summary: When its AsyncEventQueue is destroyed, its JMX MBean is 
not removed
 Key: GEODE-2568
 URL: https://issues.apache.org/jira/browse/GEODE-2568
 Project: Geode
  Issue Type: Bug
  Components: wan
Reporter: Barry Oglesby


This results in the exception below if the AsyncEventQueue is re-added:
{noformat}
[warning 2017/03/01 10:53:33.500 PST   
tid=0x3f] javax.management.InstanceAlreadyExistsException: 
GemFire:service=AsyncEventQueue,queue=cusip_index#_data,type=Member,member=192.168.2.9(74354)-1026
org.apache.geode.management.ManagementException: 
javax.management.InstanceAlreadyExistsException: 
GemFire:service=AsyncEventQueue,queue=cusip_index#_data,type=Member,member=192.168.2.9(74354)-1026
at 
org.apache.geode.management.internal.MBeanJMXAdapter.registerMBean(MBeanJMXAdapter.java:114)
at 
org.apache.geode.management.internal.SystemManagementService.registerInternalMBean(SystemManagementService.java:407)
at 
org.apache.geode.management.internal.beans.ManagementAdapter.handleAsyncEventQueueCreation(ManagementAdapter.java:584)
at 
org.apache.geode.management.internal.beans.ManagementListener.handleEvent(ManagementListener.java:186)
at 
org.apache.geode.distributed.internal.InternalDistributedSystem.notifyResourceEventListeners(InternalDistributedSystem.java:2146)
at 
org.apache.geode.distributed.internal.InternalDistributedSystem.handleResourceEvent(InternalDistributedSystem.java:536)
at 
org.apache.geode.internal.cache.GemFireCacheImpl.addAsyncEventQueue(GemFireCacheImpl.java:4068)
at 
org.apache.geode.cache.asyncqueue.internal.AsyncEventQueueFactoryImpl.create(AsyncEventQueueFactoryImpl.java:197)
at 
org.apache.geode.cache.lucene.internal.LuceneIndexImpl.createAEQ(LuceneIndexImpl.java:184)
at 
org.apache.geode.cache.lucene.internal.LuceneIndexImpl.createAEQ(LuceneIndexImpl.java:150)
at 
org.apache.geode.cache.lucene.internal.LuceneIndexImpl.initialize(LuceneIndexImpl.java:140)
at 
org.apache.geode.cache.lucene.internal.LuceneServiceImpl.afterDataRegionCreated(LuceneServiceImpl.java:227)
at 
org.apache.geode.cache.lucene.internal.LuceneServiceImpl$1.afterCreate(LuceneServiceImpl.java:207)
at 
org.apache.geode.internal.cache.GemFireCacheImpl.invokeRegionAfter(GemFireCacheImpl.java:3370)
at 
org.apache.geode.internal.cache.GemFireCacheImpl.createVMRegion(GemFireCacheImpl.java:3349)
at 
org.apache.geode.internal.cache.GemFireCacheImpl.basicCreateRegion(GemFireCacheImpl.java:3190)
at 
org.apache.geode.internal.cache.GemFireCacheImpl.createRegion(GemFireCacheImpl.java:3178)
at org.apache.geode.cache.RegionFactory.create(RegionFactory.java:762)
at CreateRegionFunction.createRegion(CreateRegionFunction.java:27)
at CreateRegionFunction.execute(CreateRegionFunction.java:22)
at 
org.apache.geode.internal.cache.tier.sockets.command.ExecuteFunction66.executeFunctionaLocally(ExecuteFunction66.java:324)
at 
org.apache.geode.internal.cache.tier.sockets.command.ExecuteFunction66.cmdExecute(ExecuteFunction66.java:249)
at 
org.apache.geode.internal.cache.tier.sockets.command.ExecuteFunction70.cmdExecute(ExecuteFunction70.java:55)
at 
org.apache.geode.internal.cache.tier.sockets.BaseCommand.execute(BaseCommand.java:141)
at 
org.apache.geode.internal.cache.tier.sockets.ServerConnection.doNormalMsg(ServerConnection.java:783)
at 
org.apache.geode.internal.cache.tier.sockets.ServerConnection.doOneMessage(ServerConnection.java:914)
at 
org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1171)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at 
org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:519)
at java.lang.Thread.run(Thread.java:745)
Caused by: javax.management.InstanceAlreadyExistsException: 
GemFire:service=AsyncEventQueue,queue=cusip_index#_data,type=Member,member=192.168.2.9(74354)-1026
at com.sun.jmx.mbeanserver.Repository.addMBean(Repository.java:437)
at 
com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerWithRepository(DefaultMBeanServerInterceptor.java:1898)
at 
com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerDynamicMBean(DefaultMBeanServerInterceptor.java:966)
at 
com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerObject(DefaultMBeanServerInterceptor.java:900)
at 
com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerMBean(DefaultMBeanServerInterceptor.java:324)
at 
com.sun.jmx.mbeanserver.JmxMBeanServer.registerMBean(JmxMBeanServer.ja

[jira] [Assigned] (GEODE-2568) When its AsyncEventQueue is destroyed, its JMX MBean is not removed

[Barry Oglesby (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Barry Oglesby reassigned GEODE-2568:


Assignee: Barry Oglesby

> When its AsyncEventQueue is destroyed, its JMX MBean is not removed
> ---
>
> Key: GEODE-2568
> URL: https://issues.apache.org/jira/browse/GEODE-2568
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Reporter: Barry Oglesby
>Assignee: Barry Oglesby
>
> This results in the exception below if the AsyncEventQueue is re-added:
> {noformat}
> [warning 2017/03/01 10:53:33.500 PST   0> tid=0x3f] javax.management.InstanceAlreadyExistsException: 
> GemFire:service=AsyncEventQueue,queue=cusip_index#_data,type=Member,member=192.168.2.9(74354)-1026
> org.apache.geode.management.ManagementException: 
> javax.management.InstanceAlreadyExistsException: 
> GemFire:service=AsyncEventQueue,queue=cusip_index#_data,type=Member,member=192.168.2.9(74354)-1026
>   at 
> org.apache.geode.management.internal.MBeanJMXAdapter.registerMBean(MBeanJMXAdapter.java:114)
>   at 
> org.apache.geode.management.internal.SystemManagementService.registerInternalMBean(SystemManagementService.java:407)
>   at 
> org.apache.geode.management.internal.beans.ManagementAdapter.handleAsyncEventQueueCreation(ManagementAdapter.java:584)
>   at 
> org.apache.geode.management.internal.beans.ManagementListener.handleEvent(ManagementListener.java:186)
>   at 
> org.apache.geode.distributed.internal.InternalDistributedSystem.notifyResourceEventListeners(InternalDistributedSystem.java:2146)
>   at 
> org.apache.geode.distributed.internal.InternalDistributedSystem.handleResourceEvent(InternalDistributedSystem.java:536)
>   at 
> org.apache.geode.internal.cache.GemFireCacheImpl.addAsyncEventQueue(GemFireCacheImpl.java:4068)
>   at 
> org.apache.geode.cache.asyncqueue.internal.AsyncEventQueueFactoryImpl.create(AsyncEventQueueFactoryImpl.java:197)
>   at 
> org.apache.geode.cache.lucene.internal.LuceneIndexImpl.createAEQ(LuceneIndexImpl.java:184)
>   at 
> org.apache.geode.cache.lucene.internal.LuceneIndexImpl.createAEQ(LuceneIndexImpl.java:150)
>   at 
> org.apache.geode.cache.lucene.internal.LuceneIndexImpl.initialize(LuceneIndexImpl.java:140)
>   at 
> org.apache.geode.cache.lucene.internal.LuceneServiceImpl.afterDataRegionCreated(LuceneServiceImpl.java:227)
>   at 
> org.apache.geode.cache.lucene.internal.LuceneServiceImpl$1.afterCreate(LuceneServiceImpl.java:207)
>   at 
> org.apache.geode.internal.cache.GemFireCacheImpl.invokeRegionAfter(GemFireCacheImpl.java:3370)
>   at 
> org.apache.geode.internal.cache.GemFireCacheImpl.createVMRegion(GemFireCacheImpl.java:3349)
>   at 
> org.apache.geode.internal.cache.GemFireCacheImpl.basicCreateRegion(GemFireCacheImpl.java:3190)
>   at 
> org.apache.geode.internal.cache.GemFireCacheImpl.createRegion(GemFireCacheImpl.java:3178)
>   at org.apache.geode.cache.RegionFactory.create(RegionFactory.java:762)
>   at CreateRegionFunction.createRegion(CreateRegionFunction.java:27)
>   at CreateRegionFunction.execute(CreateRegionFunction.java:22)
>   at 
> org.apache.geode.internal.cache.tier.sockets.command.ExecuteFunction66.executeFunctionaLocally(ExecuteFunction66.java:324)
>   at 
> org.apache.geode.internal.cache.tier.sockets.command.ExecuteFunction66.cmdExecute(ExecuteFunction66.java:249)
>   at 
> org.apache.geode.internal.cache.tier.sockets.command.ExecuteFunction70.cmdExecute(ExecuteFunction70.java:55)
>   at 
> org.apache.geode.internal.cache.tier.sockets.BaseCommand.execute(BaseCommand.java:141)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.doNormalMsg(ServerConnection.java:783)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.doOneMessage(ServerConnection.java:914)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1171)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:519)
>   at java.lang.Thread.run(Thread.java:745)
> Caused by: javax.management.InstanceAlreadyExistsException: 
> GemFire:service=AsyncEventQueue,queue=cusip_index#_data,type=Member,member=192.168.2.9(74354)-1026
>   at com.sun.jmx.mbeanserver.Repository.addMBean(Repository.java:437)
>   at 
> com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerWithRepository(DefaultMBeanServerInterceptor.java:1898)
>   at 
> com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerDynamicMBean(DefaultMBeanServerInterceptor.j

Re: 1.1.0 is done so let's start work on 1.2.0

[Anthony Baker]

bump

The json.org removal is complete.  Any thoughts on additional scope / timing / 
release manager?

Anthony

> On Feb 16, 2017, at 8:20 AM, Anthony Baker  wrote:
> 
> Great job everyone on releasing 1.1.0!  Let’s get organized for the next 
> release :-)
> 
> Scope:
>   We definitely need to focus on eliminating JSON.org prior to 4/31.  See 
> GEODE-629, GEODE-2142, GEODE-2331, GEODE-2380.
>   Anything else?
> 
> Timing:
>   I suggest shooting for a release candidate around mid-March if possible 
> (release often!)
> 
> Release Manager:
>   Any volunteers?
> 
> Note:  as a process reminder please don’t set Fix Version in JIRA unless you 
> fix a bug that has been merged to develop or the issue has been prioritized 
> by the community for inclusion in a release.
> 
> Thanks,
> Anthony
> 

[jira] [Resolved] (GEODE-2561) Docs: error in gfsecurity.properties example (Geode User Guide)

[Dave Barnes (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Barnes resolved GEODE-2561.

   Resolution: Fixed
Fix Version/s: 1.2.0

Example corrected. Properties check out with current list.

> Docs: error in gfsecurity.properties example (Geode User Guide)
> ---
>
> Key: GEODE-2561
> URL: https://issues.apache.org/jira/browse/GEODE-2561
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Dave Barnes
>Assignee: Dave Barnes
> Fix For: 1.2.0
>
>
> Reported by Mike Martell:
> Looks like an error on this SSL Sample Impl page: 
> .../managing/security/ssl_example.html
> Seems like they're using a path for a password:
> ssl-truststore-password=/path/to/trusted.truststore
> [db note] 
> Check entire page to make sure properties shown are consistent with the 
> current implementation, as security properties (in particular) were recently 
> revised.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2541) NetstatDUnitTest fails with ClassCastException

[Kenneth Howe (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891065#comment-15891065
 ] 

Kenneth Howe commented on GEODE-2541:
-

The failure from ClassCastException results from 
org.apache.geode.management.internal.cli.HeadlessGfsh not handling a command 
results that's not a Result object as expected by the test rule.

The underlying cause of the test failure was a remote VM ran out of heap 
memory. The netstat command that gfsh was executing returned an error string 
instead of a CommandResult object, so the explicit cast in 
GfshShellConnectionRule threw the exception.

> NetstatDUnitTest fails with ClassCastException
> --
>
> Key: GEODE-2541
> URL: https://issues.apache.org/jira/browse/GEODE-2541
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, tests
>Reporter: Kirk Lund
>Assignee: Kenneth Howe
>  Labels: MiscellaneousCommands, NetstatCommand, gfsh, netstat
>
> This might be a bug in the error handling code for gfsh or the functions used 
> by MiscellaneousCommands.
> {noformat}
> org.apache.geode.management.internal.cli.NetstatDUnitTest > 
> testConnectToJmxManagerOne FAILED
> org.junit.ComparisonFailure: [{"errorCode":505,"message":["Could not 
> process command due to GemFire error. Error occurred while executing netstat 
> on [server-1]"]}] expected:<[OK]> but was:<[ERROR]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native 
> Method)
> at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at 
> org.apache.geode.test.dunit.rules.GfshShellConnectionRule.executeAndVerifyCommand(GfshShellConnectionRule.java:168)
> at 
> org.apache.geode.management.internal.cli.NetstatDUnitTest.testConnectToJmxManagerOne(NetstatDUnitTest.java:82)
> org.apache.geode.management.internal.cli.NetstatDUnitTest > 
> testConnectToJmxManagerTwo FAILED
> java.lang.ClassCastException: java.lang.String cannot be cast to 
> org.apache.geode.management.internal.cli.result.CommandResult
> at 
> org.apache.geode.test.dunit.rules.GfshShellConnectionRule.executeCommand(GfshShellConnectionRule.java:159)
> at 
> org.apache.geode.test.dunit.rules.GfshShellConnectionRule.executeAndVerifyCommand(GfshShellConnectionRule.java:166)
> at 
> org.apache.geode.management.internal.cli.NetstatDUnitTest.testConnectToJmxManagerTwo(NetstatDUnitTest.java:88)
> org.apache.geode.management.internal.cli.NetstatDUnitTest > 
> testConnectToLocator FAILED
> org.junit.ComparisonFailure: [{"errorCode":520,"message":["Could not find 
> member(s) with Id(s) or name(s): server-1."]}] expected:<[OK]> but 
> was:<[ERROR]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native 
> Method)
> at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at 
> org.apache.geode.test.dunit.rules.GfshShellConnectionRule.executeAndVerifyCommand(GfshShellConnectionRule.java:168)
> at 
> org.apache.geode.management.internal.cli.NetstatDUnitTest.testConnectToLocator(NetstatDUnitTest.java:76)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2551) Possible bugs in the source code

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891072#comment-15891072
 ] 

ASF subversion and git services commented on GEODE-2551:


Commit 635d3118177f6cae6b0497097e64bdb7a9aee800 in geode's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=635d311 ]

Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/geode into 
develop

* 'develop' of https://git-wip-us.apache.org/repos/asf/geode: (57 commits)
  GEODE-2551 Fix code issues found by AppChecker
  Revert "GEODE-1887: Now Size api goes through ServerProxy when cache is of 
type client and DataPolicy is Empty."
  GEODE-2538: Don't deserialize values on the server when getting results
  GEODE-2461: remove json4s-ast_2.10 as explicit dependency
  GEODE-2547: Interest registration no longer causes a CacheLoader to be invoked
  GEODE-2526: Enhance log statement to include ResourceTypeName
  GEODE-880 Remove unused classes
  GEODE-2460: update dependency versions
  GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQueueFactory, 
ReliableMessageQueueFactoryImpl and it's usage in the code from 
GemfireCacheImpl and DistributedRegion.
  GEODE-2550 Improve README and BUILDING
  GEODE-2538: Don't invoke a cache loader when fetching values for a lucene 
query
  GEODE-2404: Added support for destroying lucene indexes
  GEODE-2545: NPE during lucene query execution when cache is closing or region 
is destroyed
  GEODE-2515: Disabling BaseLineAndCompareQueryPerfJUnitTest
  GEODE-2142: Removing JSON licence stuff from NOTICE files
  GEODE-2142: removing tests so run precheckin
  GEODE-2142: final compiling build
  GEODE-2142: cyclical dependency in gradle build
  GEODE-2142: spotless
  GEODE-2142: Refactoring of tests to work with new JSONObject class. Changing 
file export to use Base64 encoding.
  ...


> Possible bugs in the source code
> 
>
> Key: GEODE-2551
> URL: https://issues.apache.org/jira/browse/GEODE-2551
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, serialization
>Reporter: AppChecker
>Assignee: Anthony Baker
> Fix For: 1.2.0
>
>
> Hello!
> We've checked your project with [static code analyzer 
> AppChecker|https://cnpo.ru/en/solutions/appchecker.php]
> It found several possible defects in the source code:
> 1) 
> https://github.com/apache/geode/blob/8bf39571471642beaaa36c9626a61a90bd3803c2/geode-core/src/main/java/org/apache/geode/management/internal/cli/parser/ParserUtils.java#L96
> {code:java}
> if ((split[i].endsWith("\"") && split[i].endsWith("\""))
> || (split[i].startsWith("\'") && split[i].endsWith("\'"))) {
> {code}
> {noformat}split[i].endsWith("\"") {noformat} is checked twice.
> Probably it should be:
> {code:java}
> if ((split[i].startsWith("\"") && split[i].endsWith("\""))
> || (split[i].startsWith("\'") && split[i].endsWith("\'"))) {
> {code}
> 2) 
> https://github.com/apache/geode/blob/6e5013102927099a725282b6bad5d64a79152fab/geode-core/src/test/java/org/apache/geode/cache/query/dunit/SelectStarQueryDUnitTest.java#L1384
> https://github.com/apache/geode/blob/6e5013102927099a725282b6bad5d64a79152fab/geode-core/src/test/java/org/apache/geode/cache/query/dunit/SelectStarQueryDUnitTest.java#L1444
> {code:java}
> else if (rs instanceof PortfolioPdx || rs instanceof PortfolioPdx) {
> {code}
> rs is checked twice
> 3) 
> https://github.com/apache/geode/blob/8bf39571471642beaaa36c9626a61a90bd3803c2/geode-core/src/main/java/org/apache/geode/management/internal/cli/util/JsonUtil.java#L388
> {code:java}
> } else if (klass.isAssignableFrom(Float.class) || 
> klass.isAssignableFrom(Float.class)) {
> {code}
> klass.isAssignableFrom(Float.class)  is checked twcie



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2547) Interest registration can cause a CacheLoader to be invoked

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891076#comment-15891076
 ] 

ASF subversion and git services commented on GEODE-2547:


Commit 635d3118177f6cae6b0497097e64bdb7a9aee800 in geode's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=635d311 ]

Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/geode into 
develop

* 'develop' of https://git-wip-us.apache.org/repos/asf/geode: (57 commits)
  GEODE-2551 Fix code issues found by AppChecker
  Revert "GEODE-1887: Now Size api goes through ServerProxy when cache is of 
type client and DataPolicy is Empty."
  GEODE-2538: Don't deserialize values on the server when getting results
  GEODE-2461: remove json4s-ast_2.10 as explicit dependency
  GEODE-2547: Interest registration no longer causes a CacheLoader to be invoked
  GEODE-2526: Enhance log statement to include ResourceTypeName
  GEODE-880 Remove unused classes
  GEODE-2460: update dependency versions
  GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQueueFactory, 
ReliableMessageQueueFactoryImpl and it's usage in the code from 
GemfireCacheImpl and DistributedRegion.
  GEODE-2550 Improve README and BUILDING
  GEODE-2538: Don't invoke a cache loader when fetching values for a lucene 
query
  GEODE-2404: Added support for destroying lucene indexes
  GEODE-2545: NPE during lucene query execution when cache is closing or region 
is destroyed
  GEODE-2515: Disabling BaseLineAndCompareQueryPerfJUnitTest
  GEODE-2142: Removing JSON licence stuff from NOTICE files
  GEODE-2142: removing tests so run precheckin
  GEODE-2142: final compiling build
  GEODE-2142: cyclical dependency in gradle build
  GEODE-2142: spotless
  GEODE-2142: Refactoring of tests to work with new JSONObject class. Changing 
file export to use Base64 encoding.
  ...


> Interest registration can cause a CacheLoader to be invoked
> ---
>
> Key: GEODE-2547
> URL: https://issues.apache.org/jira/browse/GEODE-2547
> Project: Geode
>  Issue Type: Bug
>  Components: client queues
>Reporter: Barry Oglesby
>Assignee: Barry Oglesby
> Fix For: 1.2.0
>
>
> A simple scenario to reproduce this issue is:
> - configure a Region with a CacheLoader
> - destroy a key (it doesn't matter if the entry exists)
> - register interest in that key
> The CacheLoader will be invoked



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-1887) Client PROXY region should delegate all operations to server

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891073#comment-15891073
 ] 

ASF subversion and git services commented on GEODE-1887:


Commit 635d3118177f6cae6b0497097e64bdb7a9aee800 in geode's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=635d311 ]

Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/geode into 
develop

* 'develop' of https://git-wip-us.apache.org/repos/asf/geode: (57 commits)
  GEODE-2551 Fix code issues found by AppChecker
  Revert "GEODE-1887: Now Size api goes through ServerProxy when cache is of 
type client and DataPolicy is Empty."
  GEODE-2538: Don't deserialize values on the server when getting results
  GEODE-2461: remove json4s-ast_2.10 as explicit dependency
  GEODE-2547: Interest registration no longer causes a CacheLoader to be invoked
  GEODE-2526: Enhance log statement to include ResourceTypeName
  GEODE-880 Remove unused classes
  GEODE-2460: update dependency versions
  GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQueueFactory, 
ReliableMessageQueueFactoryImpl and it's usage in the code from 
GemfireCacheImpl and DistributedRegion.
  GEODE-2550 Improve README and BUILDING
  GEODE-2538: Don't invoke a cache loader when fetching values for a lucene 
query
  GEODE-2404: Added support for destroying lucene indexes
  GEODE-2545: NPE during lucene query execution when cache is closing or region 
is destroyed
  GEODE-2515: Disabling BaseLineAndCompareQueryPerfJUnitTest
  GEODE-2142: Removing JSON licence stuff from NOTICE files
  GEODE-2142: removing tests so run precheckin
  GEODE-2142: final compiling build
  GEODE-2142: cyclical dependency in gradle build
  GEODE-2142: spotless
  GEODE-2142: Refactoring of tests to work with new JSONObject class. Changing 
file export to use Base64 encoding.
  ...


> Client PROXY region should delegate all operations to server
> 
>
> Key: GEODE-1887
> URL: https://issues.apache.org/jira/browse/GEODE-1887
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Swapnil Bawaskar
>Assignee: Avinash Dongre
>
> Currently a ClientRegionShortcut.PROXY region sends operations like put() and 
> get() over to the server, but for operations like size() and isEmpty() it 
> just consults the local state on the client  and returns 0 and true 
> respectively, even though there may be data in the servers for that region.
> A PROXY region should not attempt to consult its local state for any 
> operation. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2561) Docs: error in gfsecurity.properties example (Geode User Guide)

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891071#comment-15891071
 ] 

ASF subversion and git services commented on GEODE-2561:


Commit c3dbd742cde95a2aa9266990d6c42f4ce359cea2 in geode's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=c3dbd74 ]

GEODE-2561 Docs: error in gfsecurity.properties example (Geode User Guide)


> Docs: error in gfsecurity.properties example (Geode User Guide)
> ---
>
> Key: GEODE-2561
> URL: https://issues.apache.org/jira/browse/GEODE-2561
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Dave Barnes
>Assignee: Dave Barnes
> Fix For: 1.2.0
>
>
> Reported by Mike Martell:
> Looks like an error on this SSL Sample Impl page: 
> .../managing/security/ssl_example.html
> Seems like they're using a path for a password:
> ssl-truststore-password=/path/to/trusted.truststore
> [db note] 
> Check entire page to make sure properties shown are consistent with the 
> current implementation, as security properties (in particular) were recently 
> revised.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2461) Remove unnecessary explicit dependencies

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891075#comment-15891075
 ] 

ASF subversion and git services commented on GEODE-2461:


Commit 635d3118177f6cae6b0497097e64bdb7a9aee800 in geode's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=635d311 ]

Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/geode into 
develop

* 'develop' of https://git-wip-us.apache.org/repos/asf/geode: (57 commits)
  GEODE-2551 Fix code issues found by AppChecker
  Revert "GEODE-1887: Now Size api goes through ServerProxy when cache is of 
type client and DataPolicy is Empty."
  GEODE-2538: Don't deserialize values on the server when getting results
  GEODE-2461: remove json4s-ast_2.10 as explicit dependency
  GEODE-2547: Interest registration no longer causes a CacheLoader to be invoked
  GEODE-2526: Enhance log statement to include ResourceTypeName
  GEODE-880 Remove unused classes
  GEODE-2460: update dependency versions
  GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQueueFactory, 
ReliableMessageQueueFactoryImpl and it's usage in the code from 
GemfireCacheImpl and DistributedRegion.
  GEODE-2550 Improve README and BUILDING
  GEODE-2538: Don't invoke a cache loader when fetching values for a lucene 
query
  GEODE-2404: Added support for destroying lucene indexes
  GEODE-2545: NPE during lucene query execution when cache is closing or region 
is destroyed
  GEODE-2515: Disabling BaseLineAndCompareQueryPerfJUnitTest
  GEODE-2142: Removing JSON licence stuff from NOTICE files
  GEODE-2142: removing tests so run precheckin
  GEODE-2142: final compiling build
  GEODE-2142: cyclical dependency in gradle build
  GEODE-2142: spotless
  GEODE-2142: Refactoring of tests to work with new JSONObject class. Changing 
file export to use Base64 encoding.
  ...


> Remove unnecessary explicit dependencies
> 
>
> Key: GEODE-2461
> URL: https://issues.apache.org/jira/browse/GEODE-2461
> Project: Geode
>  Issue Type: Wish
>  Components: build
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> These unused entries are potential candidates for removal from 
> gradle/dependency-versions.properties:
> * cdi-api.version
> * hadoop.version*
> * hbase.version (remove contains check from geode-assembly)
> * hibernate.version
> * hibernate-commons-annotations.version
> * hsqldb.version
> * jline.version
> * jsr305.version
> * paranamer.version
> * quartz.version
> * spymemcached.version? (remove testCompile from geode-core)
> These entries are actually for transitive dependencies and should have the 
> explicit dependency removed:
> * activation.version
> * asm.version (done)
> * cglib.version (remove testRuntime from test.gradle)
> * classmate (remove compile from geode-web-api)
> * mortbay-jetty-servlet-api.version? (remove provided from geode-pulse)
> * scala.version (remove compile from geode-web-api)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2538) Lucene query with values should not invoke cache loader

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891074#comment-15891074
 ] 

ASF subversion and git services commented on GEODE-2538:


Commit 635d3118177f6cae6b0497097e64bdb7a9aee800 in geode's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=635d311 ]

Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/geode into 
develop

* 'develop' of https://git-wip-us.apache.org/repos/asf/geode: (57 commits)
  GEODE-2551 Fix code issues found by AppChecker
  Revert "GEODE-1887: Now Size api goes through ServerProxy when cache is of 
type client and DataPolicy is Empty."
  GEODE-2538: Don't deserialize values on the server when getting results
  GEODE-2461: remove json4s-ast_2.10 as explicit dependency
  GEODE-2547: Interest registration no longer causes a CacheLoader to be invoked
  GEODE-2526: Enhance log statement to include ResourceTypeName
  GEODE-880 Remove unused classes
  GEODE-2460: update dependency versions
  GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQueueFactory, 
ReliableMessageQueueFactoryImpl and it's usage in the code from 
GemfireCacheImpl and DistributedRegion.
  GEODE-2550 Improve README and BUILDING
  GEODE-2538: Don't invoke a cache loader when fetching values for a lucene 
query
  GEODE-2404: Added support for destroying lucene indexes
  GEODE-2545: NPE during lucene query execution when cache is closing or region 
is destroyed
  GEODE-2515: Disabling BaseLineAndCompareQueryPerfJUnitTest
  GEODE-2142: Removing JSON licence stuff from NOTICE files
  GEODE-2142: removing tests so run precheckin
  GEODE-2142: final compiling build
  GEODE-2142: cyclical dependency in gradle build
  GEODE-2142: spotless
  GEODE-2142: Refactoring of tests to work with new JSONObject class. Changing 
file export to use Base64 encoding.
  ...


> Lucene query with values should not invoke cache loader
> ---
>
> Key: GEODE-2538
> URL: https://issues.apache.org/jira/browse/GEODE-2538
> Project: Geode
>  Issue Type: Improvement
>  Components: lucene
>Reporter: Dan Smith
>Assignee: Dan Smith
> Fix For: 1.2.0
>
>
> Lucene queries use getAll to fetch pages when returning values.
> If an entry is destroyed after the query has found the list of keys, but 
> before the query finds the values, the getAll with trigger a cache loader and 
> reload the value. This may be unexpected behavior.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: 1.1.0 is done so let's start work on 1.2.0

[Hitesh Khamesra]

I would prefer to consider GEODE-2413 as well.
-Hitesh
  From: Anthony Baker 
 To: dev@geode.apache.org 
 Sent: Wednesday, March 1, 2017 1:21 PM
 Subject: Re: 1.1.0 is done so let's start work on 1.2.0
   
bump

The json.org removal is complete.  Any thoughts on additional scope / timing / 
release manager?

Anthony

> On Feb 16, 2017, at 8:20 AM, Anthony Baker  wrote:
> 
> Great job everyone on releasing 1.1.0!  Let’s get organized for the next 
> release :-)
> 
> Scope:
>     We definitely need to focus on eliminating JSON.org prior to 4/31.  See 
> GEODE-629, GEODE-2142, GEODE-2331, GEODE-2380.
>     Anything else?
> 
> Timing:
>     I suggest shooting for a release candidate around mid-March if possible 
> (release often!)
> 
> Release Manager:
>     Any volunteers?
> 
> Note:  as a process reminder please don’t set Fix Version in JIRA unless you 
> fix a bug that has been merged to develop or the issue has been prioritized 
> by the community for inclusion in a release.
> 
> Thanks,
> Anthony
> 


   

[jira] [Commented] (GEODE-2142) Remove JSON.org dependency

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891090#comment-15891090
 ] 

ASF subversion and git services commented on GEODE-2142:


Commit 635d3118177f6cae6b0497097e64bdb7a9aee800 in geode's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=635d311 ]

Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/geode into 
develop

* 'develop' of https://git-wip-us.apache.org/repos/asf/geode: (57 commits)
  GEODE-2551 Fix code issues found by AppChecker
  Revert "GEODE-1887: Now Size api goes through ServerProxy when cache is of 
type client and DataPolicy is Empty."
  GEODE-2538: Don't deserialize values on the server when getting results
  GEODE-2461: remove json4s-ast_2.10 as explicit dependency
  GEODE-2547: Interest registration no longer causes a CacheLoader to be invoked
  GEODE-2526: Enhance log statement to include ResourceTypeName
  GEODE-880 Remove unused classes
  GEODE-2460: update dependency versions
  GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQueueFactory, 
ReliableMessageQueueFactoryImpl and it's usage in the code from 
GemfireCacheImpl and DistributedRegion.
  GEODE-2550 Improve README and BUILDING
  GEODE-2538: Don't invoke a cache loader when fetching values for a lucene 
query
  GEODE-2404: Added support for destroying lucene indexes
  GEODE-2545: NPE during lucene query execution when cache is closing or region 
is destroyed
  GEODE-2515: Disabling BaseLineAndCompareQueryPerfJUnitTest
  GEODE-2142: Removing JSON licence stuff from NOTICE files
  GEODE-2142: removing tests so run precheckin
  GEODE-2142: final compiling build
  GEODE-2142: cyclical dependency in gradle build
  GEODE-2142: spotless
  GEODE-2142: Refactoring of tests to work with new JSONObject class. Changing 
file export to use Base64 encoding.
  ...


> Remove JSON.org dependency
> --
>
> Key: GEODE-2142
> URL: https://issues.apache.org/jira/browse/GEODE-2142
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Anthony Baker
>Assignee: Udo Kohlmeyer
>Priority: Blocker
>  Labels: json
> Fix For: 1.2.0
>
>
> ASF has determined that the JSON library should be treated as Category X and 
> is incompatible with ASLv2.
> We have until Apr-30, 2017 to remove this dependency.  Any release we ship 
> prior to that time must state this usage via NOTICE.
> http://mail-archives.apache.org/mod_mbox/incubator-general/201611.mbox/%3ccajwfca2ox62mugp+-+-v6ktbkhhgkixucjcr9syes-azfp+...@mail.gmail.com%3e
> There are related reasons for removing the JSON library anyway, but this bug 
> captures the legal reasons.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2142) Remove JSON.org dependency

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891091#comment-15891091
 ] 

ASF subversion and git services commented on GEODE-2142:


Commit 635d3118177f6cae6b0497097e64bdb7a9aee800 in geode's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=635d311 ]

Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/geode into 
develop

* 'develop' of https://git-wip-us.apache.org/repos/asf/geode: (57 commits)
  GEODE-2551 Fix code issues found by AppChecker
  Revert "GEODE-1887: Now Size api goes through ServerProxy when cache is of 
type client and DataPolicy is Empty."
  GEODE-2538: Don't deserialize values on the server when getting results
  GEODE-2461: remove json4s-ast_2.10 as explicit dependency
  GEODE-2547: Interest registration no longer causes a CacheLoader to be invoked
  GEODE-2526: Enhance log statement to include ResourceTypeName
  GEODE-880 Remove unused classes
  GEODE-2460: update dependency versions
  GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQueueFactory, 
ReliableMessageQueueFactoryImpl and it's usage in the code from 
GemfireCacheImpl and DistributedRegion.
  GEODE-2550 Improve README and BUILDING
  GEODE-2538: Don't invoke a cache loader when fetching values for a lucene 
query
  GEODE-2404: Added support for destroying lucene indexes
  GEODE-2545: NPE during lucene query execution when cache is closing or region 
is destroyed
  GEODE-2515: Disabling BaseLineAndCompareQueryPerfJUnitTest
  GEODE-2142: Removing JSON licence stuff from NOTICE files
  GEODE-2142: removing tests so run precheckin
  GEODE-2142: final compiling build
  GEODE-2142: cyclical dependency in gradle build
  GEODE-2142: spotless
  GEODE-2142: Refactoring of tests to work with new JSONObject class. Changing 
file export to use Base64 encoding.
  ...


> Remove JSON.org dependency
> --
>
> Key: GEODE-2142
> URL: https://issues.apache.org/jira/browse/GEODE-2142
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Anthony Baker
>Assignee: Udo Kohlmeyer
>Priority: Blocker
>  Labels: json
> Fix For: 1.2.0
>
>
> ASF has determined that the JSON library should be treated as Category X and 
> is incompatible with ASLv2.
> We have until Apr-30, 2017 to remove this dependency.  Any release we ship 
> prior to that time must state this usage via NOTICE.
> http://mail-archives.apache.org/mod_mbox/incubator-general/201611.mbox/%3ccajwfca2ox62mugp+-+-v6ktbkhhgkixucjcr9syes-azfp+...@mail.gmail.com%3e
> There are related reasons for removing the JSON library anyway, but this bug 
> captures the legal reasons.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2142) Remove JSON.org dependency

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891089#comment-15891089
 ] 

ASF subversion and git services commented on GEODE-2142:


Commit 635d3118177f6cae6b0497097e64bdb7a9aee800 in geode's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=635d311 ]

Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/geode into 
develop

* 'develop' of https://git-wip-us.apache.org/repos/asf/geode: (57 commits)
  GEODE-2551 Fix code issues found by AppChecker
  Revert "GEODE-1887: Now Size api goes through ServerProxy when cache is of 
type client and DataPolicy is Empty."
  GEODE-2538: Don't deserialize values on the server when getting results
  GEODE-2461: remove json4s-ast_2.10 as explicit dependency
  GEODE-2547: Interest registration no longer causes a CacheLoader to be invoked
  GEODE-2526: Enhance log statement to include ResourceTypeName
  GEODE-880 Remove unused classes
  GEODE-2460: update dependency versions
  GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQueueFactory, 
ReliableMessageQueueFactoryImpl and it's usage in the code from 
GemfireCacheImpl and DistributedRegion.
  GEODE-2550 Improve README and BUILDING
  GEODE-2538: Don't invoke a cache loader when fetching values for a lucene 
query
  GEODE-2404: Added support for destroying lucene indexes
  GEODE-2545: NPE during lucene query execution when cache is closing or region 
is destroyed
  GEODE-2515: Disabling BaseLineAndCompareQueryPerfJUnitTest
  GEODE-2142: Removing JSON licence stuff from NOTICE files
  GEODE-2142: removing tests so run precheckin
  GEODE-2142: final compiling build
  GEODE-2142: cyclical dependency in gradle build
  GEODE-2142: spotless
  GEODE-2142: Refactoring of tests to work with new JSONObject class. Changing 
file export to use Base64 encoding.
  ...


> Remove JSON.org dependency
> --
>
> Key: GEODE-2142
> URL: https://issues.apache.org/jira/browse/GEODE-2142
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Anthony Baker
>Assignee: Udo Kohlmeyer
>Priority: Blocker
>  Labels: json
> Fix For: 1.2.0
>
>
> ASF has determined that the JSON library should be treated as Category X and 
> is incompatible with ASLv2.
> We have until Apr-30, 2017 to remove this dependency.  Any release we ship 
> prior to that time must state this usage via NOTICE.
> http://mail-archives.apache.org/mod_mbox/incubator-general/201611.mbox/%3ccajwfca2ox62mugp+-+-v6ktbkhhgkixucjcr9syes-azfp+...@mail.gmail.com%3e
> There are related reasons for removing the JSON library anyway, but this bug 
> captures the legal reasons.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2526) Enhance log statement in StatsArchiveReader

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891077#comment-15891077
 ] 

ASF subversion and git services commented on GEODE-2526:


Commit 635d3118177f6cae6b0497097e64bdb7a9aee800 in geode's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=635d311 ]

Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/geode into 
develop

* 'develop' of https://git-wip-us.apache.org/repos/asf/geode: (57 commits)
  GEODE-2551 Fix code issues found by AppChecker
  Revert "GEODE-1887: Now Size api goes through ServerProxy when cache is of 
type client and DataPolicy is Empty."
  GEODE-2538: Don't deserialize values on the server when getting results
  GEODE-2461: remove json4s-ast_2.10 as explicit dependency
  GEODE-2547: Interest registration no longer causes a CacheLoader to be invoked
  GEODE-2526: Enhance log statement to include ResourceTypeName
  GEODE-880 Remove unused classes
  GEODE-2460: update dependency versions
  GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQueueFactory, 
ReliableMessageQueueFactoryImpl and it's usage in the code from 
GemfireCacheImpl and DistributedRegion.
  GEODE-2550 Improve README and BUILDING
  GEODE-2538: Don't invoke a cache loader when fetching values for a lucene 
query
  GEODE-2404: Added support for destroying lucene indexes
  GEODE-2545: NPE during lucene query execution when cache is closing or region 
is destroyed
  GEODE-2515: Disabling BaseLineAndCompareQueryPerfJUnitTest
  GEODE-2142: Removing JSON licence stuff from NOTICE files
  GEODE-2142: removing tests so run precheckin
  GEODE-2142: final compiling build
  GEODE-2142: cyclical dependency in gradle build
  GEODE-2142: spotless
  GEODE-2142: Refactoring of tests to work with new JSONObject class. Changing 
file export to use Base64 encoding.
  ...


> Enhance log statement in StatsArchiveReader
> ---
>
> Key: GEODE-2526
> URL: https://issues.apache.org/jira/browse/GEODE-2526
> Project: Geode
>  Issue Type: New Feature
>  Components: statistics
>Reporter: Srikanth Manvi
>Assignee: Srikanth Manvi
>Priority: Trivial
> Fix For: 1.2.0
>
>
> Rarely stats files are corrupted due to missing ResourceType info in the gfs 
> file. In those cases the gfs files cannot be opened in VSD tool as the tool 
> throws an error while loading.
> The log statement in the method 
> StatsArchiveReader.java(readResourceInstanceCreateToken())  prints out only 
> the missing ResourceTypeId which appears to be dynamically created. 
> If the log message can be enhanced to include the resourceName as well, it 
> will be valuable to know the name of ResourceType that is actually missing in 
> the stats file. 
> There is a [stats-cleaner | https://github.com/smanvi-pivotal/stats-cleaner] 
> utility which takes in a corrupted stats files, name and id of the missing 
> ResourceType in the corrupted file and outputs a new .gfs file by filling in 
> the missing resource info. The new file can then be loaded and analyzed in 
> VSD.
>  
> For the [stats-cleaner | https://github.com/smanvi-pivotal/stats-cleaner] 
> utility to be usable one needs to know the actual name of missing 
> resourceType, hence this New feature request.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2142) Remove JSON.org dependency

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891087#comment-15891087
 ] 

ASF subversion and git services commented on GEODE-2142:


Commit 635d3118177f6cae6b0497097e64bdb7a9aee800 in geode's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=635d311 ]

Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/geode into 
develop

* 'develop' of https://git-wip-us.apache.org/repos/asf/geode: (57 commits)
  GEODE-2551 Fix code issues found by AppChecker
  Revert "GEODE-1887: Now Size api goes through ServerProxy when cache is of 
type client and DataPolicy is Empty."
  GEODE-2538: Don't deserialize values on the server when getting results
  GEODE-2461: remove json4s-ast_2.10 as explicit dependency
  GEODE-2547: Interest registration no longer causes a CacheLoader to be invoked
  GEODE-2526: Enhance log statement to include ResourceTypeName
  GEODE-880 Remove unused classes
  GEODE-2460: update dependency versions
  GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQueueFactory, 
ReliableMessageQueueFactoryImpl and it's usage in the code from 
GemfireCacheImpl and DistributedRegion.
  GEODE-2550 Improve README and BUILDING
  GEODE-2538: Don't invoke a cache loader when fetching values for a lucene 
query
  GEODE-2404: Added support for destroying lucene indexes
  GEODE-2545: NPE during lucene query execution when cache is closing or region 
is destroyed
  GEODE-2515: Disabling BaseLineAndCompareQueryPerfJUnitTest
  GEODE-2142: Removing JSON licence stuff from NOTICE files
  GEODE-2142: removing tests so run precheckin
  GEODE-2142: final compiling build
  GEODE-2142: cyclical dependency in gradle build
  GEODE-2142: spotless
  GEODE-2142: Refactoring of tests to work with new JSONObject class. Changing 
file export to use Base64 encoding.
  ...


> Remove JSON.org dependency
> --
>
> Key: GEODE-2142
> URL: https://issues.apache.org/jira/browse/GEODE-2142
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Anthony Baker
>Assignee: Udo Kohlmeyer
>Priority: Blocker
>  Labels: json
> Fix For: 1.2.0
>
>
> ASF has determined that the JSON library should be treated as Category X and 
> is incompatible with ASLv2.
> We have until Apr-30, 2017 to remove this dependency.  Any release we ship 
> prior to that time must state this usage via NOTICE.
> http://mail-archives.apache.org/mod_mbox/incubator-general/201611.mbox/%3ccajwfca2ox62mugp+-+-v6ktbkhhgkixucjcr9syes-azfp+...@mail.gmail.com%3e
> There are related reasons for removing the JSON library anyway, but this bug 
> captures the legal reasons.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2142) Remove JSON.org dependency

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891086#comment-15891086
 ] 

ASF subversion and git services commented on GEODE-2142:


Commit 635d3118177f6cae6b0497097e64bdb7a9aee800 in geode's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=635d311 ]

Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/geode into 
develop

* 'develop' of https://git-wip-us.apache.org/repos/asf/geode: (57 commits)
  GEODE-2551 Fix code issues found by AppChecker
  Revert "GEODE-1887: Now Size api goes through ServerProxy when cache is of 
type client and DataPolicy is Empty."
  GEODE-2538: Don't deserialize values on the server when getting results
  GEODE-2461: remove json4s-ast_2.10 as explicit dependency
  GEODE-2547: Interest registration no longer causes a CacheLoader to be invoked
  GEODE-2526: Enhance log statement to include ResourceTypeName
  GEODE-880 Remove unused classes
  GEODE-2460: update dependency versions
  GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQueueFactory, 
ReliableMessageQueueFactoryImpl and it's usage in the code from 
GemfireCacheImpl and DistributedRegion.
  GEODE-2550 Improve README and BUILDING
  GEODE-2538: Don't invoke a cache loader when fetching values for a lucene 
query
  GEODE-2404: Added support for destroying lucene indexes
  GEODE-2545: NPE during lucene query execution when cache is closing or region 
is destroyed
  GEODE-2515: Disabling BaseLineAndCompareQueryPerfJUnitTest
  GEODE-2142: Removing JSON licence stuff from NOTICE files
  GEODE-2142: removing tests so run precheckin
  GEODE-2142: final compiling build
  GEODE-2142: cyclical dependency in gradle build
  GEODE-2142: spotless
  GEODE-2142: Refactoring of tests to work with new JSONObject class. Changing 
file export to use Base64 encoding.
  ...


> Remove JSON.org dependency
> --
>
> Key: GEODE-2142
> URL: https://issues.apache.org/jira/browse/GEODE-2142
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Anthony Baker
>Assignee: Udo Kohlmeyer
>Priority: Blocker
>  Labels: json
> Fix For: 1.2.0
>
>
> ASF has determined that the JSON library should be treated as Category X and 
> is incompatible with ASLv2.
> We have until Apr-30, 2017 to remove this dependency.  Any release we ship 
> prior to that time must state this usage via NOTICE.
> http://mail-archives.apache.org/mod_mbox/incubator-general/201611.mbox/%3ccajwfca2ox62mugp+-+-v6ktbkhhgkixucjcr9syes-azfp+...@mail.gmail.com%3e
> There are related reasons for removing the JSON library anyway, but this bug 
> captures the legal reasons.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2550) Improve README

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891081#comment-15891081
 ] 

ASF subversion and git services commented on GEODE-2550:


Commit 635d3118177f6cae6b0497097e64bdb7a9aee800 in geode's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=635d311 ]

Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/geode into 
develop

* 'develop' of https://git-wip-us.apache.org/repos/asf/geode: (57 commits)
  GEODE-2551 Fix code issues found by AppChecker
  Revert "GEODE-1887: Now Size api goes through ServerProxy when cache is of 
type client and DataPolicy is Empty."
  GEODE-2538: Don't deserialize values on the server when getting results
  GEODE-2461: remove json4s-ast_2.10 as explicit dependency
  GEODE-2547: Interest registration no longer causes a CacheLoader to be invoked
  GEODE-2526: Enhance log statement to include ResourceTypeName
  GEODE-880 Remove unused classes
  GEODE-2460: update dependency versions
  GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQueueFactory, 
ReliableMessageQueueFactoryImpl and it's usage in the code from 
GemfireCacheImpl and DistributedRegion.
  GEODE-2550 Improve README and BUILDING
  GEODE-2538: Don't invoke a cache loader when fetching values for a lucene 
query
  GEODE-2404: Added support for destroying lucene indexes
  GEODE-2545: NPE during lucene query execution when cache is closing or region 
is destroyed
  GEODE-2515: Disabling BaseLineAndCompareQueryPerfJUnitTest
  GEODE-2142: Removing JSON licence stuff from NOTICE files
  GEODE-2142: removing tests so run precheckin
  GEODE-2142: final compiling build
  GEODE-2142: cyclical dependency in gradle build
  GEODE-2142: spotless
  GEODE-2142: Refactoring of tests to work with new JSONObject class. Changing 
file export to use Base64 encoding.
  ...


> Improve README
> --
>
> Key: GEODE-2550
> URL: https://issues.apache.org/jira/browse/GEODE-2550
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Anthony Baker
>Assignee: Anthony Baker
> Fix For: 1.2.0
>
>
> The project README and BUILDING could use some updates, particularly the 
> 'Geode in 5 minutes' example.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2404) Add API to destroy a region containing lucene indexes

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891083#comment-15891083
 ] 

ASF subversion and git services commented on GEODE-2404:


Commit 635d3118177f6cae6b0497097e64bdb7a9aee800 in geode's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=635d311 ]

Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/geode into 
develop

* 'develop' of https://git-wip-us.apache.org/repos/asf/geode: (57 commits)
  GEODE-2551 Fix code issues found by AppChecker
  Revert "GEODE-1887: Now Size api goes through ServerProxy when cache is of 
type client and DataPolicy is Empty."
  GEODE-2538: Don't deserialize values on the server when getting results
  GEODE-2461: remove json4s-ast_2.10 as explicit dependency
  GEODE-2547: Interest registration no longer causes a CacheLoader to be invoked
  GEODE-2526: Enhance log statement to include ResourceTypeName
  GEODE-880 Remove unused classes
  GEODE-2460: update dependency versions
  GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQueueFactory, 
ReliableMessageQueueFactoryImpl and it's usage in the code from 
GemfireCacheImpl and DistributedRegion.
  GEODE-2550 Improve README and BUILDING
  GEODE-2538: Don't invoke a cache loader when fetching values for a lucene 
query
  GEODE-2404: Added support for destroying lucene indexes
  GEODE-2545: NPE during lucene query execution when cache is closing or region 
is destroyed
  GEODE-2515: Disabling BaseLineAndCompareQueryPerfJUnitTest
  GEODE-2142: Removing JSON licence stuff from NOTICE files
  GEODE-2142: removing tests so run precheckin
  GEODE-2142: final compiling build
  GEODE-2142: cyclical dependency in gradle build
  GEODE-2142: spotless
  GEODE-2142: Refactoring of tests to work with new JSONObject class. Changing 
file export to use Base64 encoding.
  ...


> Add API to destroy a region containing lucene indexes
> -
>
> Key: GEODE-2404
> URL: https://issues.apache.org/jira/browse/GEODE-2404
> Project: Geode
>  Issue Type: New Feature
>  Components: docs, lucene
>Reporter: Barry Oglesby
> Fix For: 1.2.0
>
> Attachments: DestroyRegionMultipleMembersFunction.java
>
>
> h2. Description
> An application {{Region}} containing {{LuceneIndexes}} should be able to be 
> destroyed.
> There are several options, including:
> - Invoke one API to destroy both the application {{Region}} and its 
> {{LuceneIndexes}}
> - Invoke two API:
> ## destroy the {{LuceneIndexes}}
> ## destroy application {{Region}} as it is done currently
> h3. One API
> In this case, we would need a callback on {{LuceneService}} to destroy the 
> {{LuceneIndexes}} before destroying the application {{Region}} like:
> {noformat}
> public void beforeDestroyRegion(Region region);
> {noformat}
> This API would get all the {{LuceneIndexes}} for the application {{Region}}, 
> then destroy each one. See the *Two API* section below for details on 
> destroying a {{LuceneIndex}}.
> Without changes to the way {{PartitionedRegions}} are destroyed, this causes 
> an issue though.
> The current behavior of {{PartitionedRegion destroyRegion}} is to first check 
> for colocated children. If there are any, the call fails.
> There are two options for adding the call to destroy the {{LuceneIndexes}}:
> # check for colocated children
> # invoke {{LuceneService beforeDestroyRegion}} to remove the {{LuceneIndexes}}
> # do the rest of the destroy
> 
> # invoke {{LuceneService beforeDestroyRegion}} to remove the {{LuceneIndexes}}
> # check for colocated children
> # do the rest of the destroy
> Both of these options are problematic in different ways.
> In the case of a {{PartitionedRegion}} with {{LuceneIndexes}}, there are 
> colocated children, so the first option would cause the {{destroyRegion}} 
> call to fail; the second option would succeed. I don't think the first option 
> should fail since the colocated children are internal {{Regions}} that the 
> application knows nothing about.
> In the case of a {{PartitionedRegion}} defining {{LuceneIndexes}} and having 
> an {{AsyncEventQueue}}, there are colocated children, so the first option 
> would cause the {{destroyRegion}} call to fail. This is ok since one of the 
> children is an application-known {{AsyncEventQueue}}. The second option would 
> fail in a bad way. It would first remove the {{LuceneIndexes}}, then fail the 
> colocated children check, so the {{destroyRegion}} call would fail. In this 
> case, the application {{Region}} doesn't get destroyed but its 
> {{LuceneIndexes}} do. This would be bad.
> One option would be to look into changing the check for colocated children to 
> check for application-defined (or not hidden) colocated children. Then the 
> 

[jira] [Commented] (GEODE-880) Remove unused classes

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891078#comment-15891078
 ] 

ASF subversion and git services commented on GEODE-880:
---

Commit 635d3118177f6cae6b0497097e64bdb7a9aee800 in geode's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=635d311 ]

Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/geode into 
develop

* 'develop' of https://git-wip-us.apache.org/repos/asf/geode: (57 commits)
  GEODE-2551 Fix code issues found by AppChecker
  Revert "GEODE-1887: Now Size api goes through ServerProxy when cache is of 
type client and DataPolicy is Empty."
  GEODE-2538: Don't deserialize values on the server when getting results
  GEODE-2461: remove json4s-ast_2.10 as explicit dependency
  GEODE-2547: Interest registration no longer causes a CacheLoader to be invoked
  GEODE-2526: Enhance log statement to include ResourceTypeName
  GEODE-880 Remove unused classes
  GEODE-2460: update dependency versions
  GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQueueFactory, 
ReliableMessageQueueFactoryImpl and it's usage in the code from 
GemfireCacheImpl and DistributedRegion.
  GEODE-2550 Improve README and BUILDING
  GEODE-2538: Don't invoke a cache loader when fetching values for a lucene 
query
  GEODE-2404: Added support for destroying lucene indexes
  GEODE-2545: NPE during lucene query execution when cache is closing or region 
is destroyed
  GEODE-2515: Disabling BaseLineAndCompareQueryPerfJUnitTest
  GEODE-2142: Removing JSON licence stuff from NOTICE files
  GEODE-2142: removing tests so run precheckin
  GEODE-2142: final compiling build
  GEODE-2142: cyclical dependency in gradle build
  GEODE-2142: spotless
  GEODE-2142: Refactoring of tests to work with new JSONObject class. Changing 
file export to use Base64 encoding.
  ...


> Remove unused classes
> -
>
> Key: GEODE-880
> URL: https://issues.apache.org/jira/browse/GEODE-880
> Project: Geode
>  Issue Type: Wish
>  Components: general
>Reporter: Kirk Lund
> Fix For: 1.2.0
>
>
> We would typically only keep unused classes if they were part of the user API 
> in a previous release.
> If an unused class is not required for backwards compatibility then it should 
> be deleted. This jira ticket lists unused classes that should be removed. If 
> you delete any of these classes, please add an appropriate comment and then 
> remove the class name from the ticket description.
> * geode-core/src/test/java/com/gemstone/gemfire/internal/JavaExec.java
> * geode-core/src/test/java/com/gemstone/gemfire/internal/LongBuffer.java



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2545) NPE during lucene query execution when cache is closing or region is destroyed

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891084#comment-15891084
 ] 

ASF subversion and git services commented on GEODE-2545:


Commit 635d3118177f6cae6b0497097e64bdb7a9aee800 in geode's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=635d311 ]

Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/geode into 
develop

* 'develop' of https://git-wip-us.apache.org/repos/asf/geode: (57 commits)
  GEODE-2551 Fix code issues found by AppChecker
  Revert "GEODE-1887: Now Size api goes through ServerProxy when cache is of 
type client and DataPolicy is Empty."
  GEODE-2538: Don't deserialize values on the server when getting results
  GEODE-2461: remove json4s-ast_2.10 as explicit dependency
  GEODE-2547: Interest registration no longer causes a CacheLoader to be invoked
  GEODE-2526: Enhance log statement to include ResourceTypeName
  GEODE-880 Remove unused classes
  GEODE-2460: update dependency versions
  GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQueueFactory, 
ReliableMessageQueueFactoryImpl and it's usage in the code from 
GemfireCacheImpl and DistributedRegion.
  GEODE-2550 Improve README and BUILDING
  GEODE-2538: Don't invoke a cache loader when fetching values for a lucene 
query
  GEODE-2404: Added support for destroying lucene indexes
  GEODE-2545: NPE during lucene query execution when cache is closing or region 
is destroyed
  GEODE-2515: Disabling BaseLineAndCompareQueryPerfJUnitTest
  GEODE-2142: Removing JSON licence stuff from NOTICE files
  GEODE-2142: removing tests so run precheckin
  GEODE-2142: final compiling build
  GEODE-2142: cyclical dependency in gradle build
  GEODE-2142: spotless
  GEODE-2142: Refactoring of tests to work with new JSONObject class. Changing 
file export to use Base64 encoding.
  ...


> NPE during lucene query execution when cache is closing or region is destroyed
> --
>
> Key: GEODE-2545
> URL: https://issues.apache.org/jira/browse/GEODE-2545
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Affects Versions: 1.0.0-incubating
>Reporter: Jason Huynh
>Assignee: Jason Huynh
> Fix For: 1.2.0
>
>
> If the LuceneQueryFunction executes while a cache is closing, it is possible 
> that the function receives a null region/index.  In this case the NPE is 
> thrown.  Instead we should detect this and fail the function.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2538) Lucene query with values should not invoke cache loader

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891082#comment-15891082
 ] 

ASF subversion and git services commented on GEODE-2538:


Commit 635d3118177f6cae6b0497097e64bdb7a9aee800 in geode's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=635d311 ]

Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/geode into 
develop

* 'develop' of https://git-wip-us.apache.org/repos/asf/geode: (57 commits)
  GEODE-2551 Fix code issues found by AppChecker
  Revert "GEODE-1887: Now Size api goes through ServerProxy when cache is of 
type client and DataPolicy is Empty."
  GEODE-2538: Don't deserialize values on the server when getting results
  GEODE-2461: remove json4s-ast_2.10 as explicit dependency
  GEODE-2547: Interest registration no longer causes a CacheLoader to be invoked
  GEODE-2526: Enhance log statement to include ResourceTypeName
  GEODE-880 Remove unused classes
  GEODE-2460: update dependency versions
  GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQueueFactory, 
ReliableMessageQueueFactoryImpl and it's usage in the code from 
GemfireCacheImpl and DistributedRegion.
  GEODE-2550 Improve README and BUILDING
  GEODE-2538: Don't invoke a cache loader when fetching values for a lucene 
query
  GEODE-2404: Added support for destroying lucene indexes
  GEODE-2545: NPE during lucene query execution when cache is closing or region 
is destroyed
  GEODE-2515: Disabling BaseLineAndCompareQueryPerfJUnitTest
  GEODE-2142: Removing JSON licence stuff from NOTICE files
  GEODE-2142: removing tests so run precheckin
  GEODE-2142: final compiling build
  GEODE-2142: cyclical dependency in gradle build
  GEODE-2142: spotless
  GEODE-2142: Refactoring of tests to work with new JSONObject class. Changing 
file export to use Base64 encoding.
  ...


> Lucene query with values should not invoke cache loader
> ---
>
> Key: GEODE-2538
> URL: https://issues.apache.org/jira/browse/GEODE-2538
> Project: Geode
>  Issue Type: Improvement
>  Components: lucene
>Reporter: Dan Smith
>Assignee: Dan Smith
> Fix For: 1.2.0
>
>
> Lucene queries use getAll to fetch pages when returning values.
> If an entry is destroyed after the query has found the list of keys, but 
> before the query finds the values, the getAll with trigger a cache loader and 
> reload the value. This may be unexpected behavior.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-1995) remove ReliableMessageQueueFactory, ReliableMessageQueue, and getReliableMessageQueueFactory

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891080#comment-15891080
 ] 

ASF subversion and git services commented on GEODE-1995:


Commit 635d3118177f6cae6b0497097e64bdb7a9aee800 in geode's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=635d311 ]

Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/geode into 
develop

* 'develop' of https://git-wip-us.apache.org/repos/asf/geode: (57 commits)
  GEODE-2551 Fix code issues found by AppChecker
  Revert "GEODE-1887: Now Size api goes through ServerProxy when cache is of 
type client and DataPolicy is Empty."
  GEODE-2538: Don't deserialize values on the server when getting results
  GEODE-2461: remove json4s-ast_2.10 as explicit dependency
  GEODE-2547: Interest registration no longer causes a CacheLoader to be invoked
  GEODE-2526: Enhance log statement to include ResourceTypeName
  GEODE-880 Remove unused classes
  GEODE-2460: update dependency versions
  GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQueueFactory, 
ReliableMessageQueueFactoryImpl and it's usage in the code from 
GemfireCacheImpl and DistributedRegion.
  GEODE-2550 Improve README and BUILDING
  GEODE-2538: Don't invoke a cache loader when fetching values for a lucene 
query
  GEODE-2404: Added support for destroying lucene indexes
  GEODE-2545: NPE during lucene query execution when cache is closing or region 
is destroyed
  GEODE-2515: Disabling BaseLineAndCompareQueryPerfJUnitTest
  GEODE-2142: Removing JSON licence stuff from NOTICE files
  GEODE-2142: removing tests so run precheckin
  GEODE-2142: final compiling build
  GEODE-2142: cyclical dependency in gradle build
  GEODE-2142: spotless
  GEODE-2142: Refactoring of tests to work with new JSONObject class. Changing 
file export to use Base64 encoding.
  ...


> remove ReliableMessageQueueFactory, ReliableMessageQueue, and 
> getReliableMessageQueueFactory
> 
>
> Key: GEODE-1995
> URL: https://issues.apache.org/jira/browse/GEODE-1995
> Project: Geode
>  Issue Type: Improvement
>  Components: regions
>Reporter: Darrel Schneider
>Assignee: Avinash Dongre
> Fix For: 1.2.0
>
>
> ReliableMessageQueueFactory, ReliableMessageQueue, and 
> GemFireCacheImpl.getReliableMessageQueueFactory should all be removed. They 
> are internal and were never used. No tests exist for them.
> They are part of required Roles which is a deprecated feature.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2142) Remove JSON.org dependency

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891088#comment-15891088
 ] 

ASF subversion and git services commented on GEODE-2142:


Commit 635d3118177f6cae6b0497097e64bdb7a9aee800 in geode's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=635d311 ]

Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/geode into 
develop

* 'develop' of https://git-wip-us.apache.org/repos/asf/geode: (57 commits)
  GEODE-2551 Fix code issues found by AppChecker
  Revert "GEODE-1887: Now Size api goes through ServerProxy when cache is of 
type client and DataPolicy is Empty."
  GEODE-2538: Don't deserialize values on the server when getting results
  GEODE-2461: remove json4s-ast_2.10 as explicit dependency
  GEODE-2547: Interest registration no longer causes a CacheLoader to be invoked
  GEODE-2526: Enhance log statement to include ResourceTypeName
  GEODE-880 Remove unused classes
  GEODE-2460: update dependency versions
  GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQueueFactory, 
ReliableMessageQueueFactoryImpl and it's usage in the code from 
GemfireCacheImpl and DistributedRegion.
  GEODE-2550 Improve README and BUILDING
  GEODE-2538: Don't invoke a cache loader when fetching values for a lucene 
query
  GEODE-2404: Added support for destroying lucene indexes
  GEODE-2545: NPE during lucene query execution when cache is closing or region 
is destroyed
  GEODE-2515: Disabling BaseLineAndCompareQueryPerfJUnitTest
  GEODE-2142: Removing JSON licence stuff from NOTICE files
  GEODE-2142: removing tests so run precheckin
  GEODE-2142: final compiling build
  GEODE-2142: cyclical dependency in gradle build
  GEODE-2142: spotless
  GEODE-2142: Refactoring of tests to work with new JSONObject class. Changing 
file export to use Base64 encoding.
  ...


> Remove JSON.org dependency
> --
>
> Key: GEODE-2142
> URL: https://issues.apache.org/jira/browse/GEODE-2142
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Anthony Baker
>Assignee: Udo Kohlmeyer
>Priority: Blocker
>  Labels: json
> Fix For: 1.2.0
>
>
> ASF has determined that the JSON library should be treated as Category X and 
> is incompatible with ASLv2.
> We have until Apr-30, 2017 to remove this dependency.  Any release we ship 
> prior to that time must state this usage via NOTICE.
> http://mail-archives.apache.org/mod_mbox/incubator-general/201611.mbox/%3ccajwfca2ox62mugp+-+-v6ktbkhhgkixucjcr9syes-azfp+...@mail.gmail.com%3e
> There are related reasons for removing the JSON library anyway, but this bug 
> captures the legal reasons.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2460) Update dependency versions

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891079#comment-15891079
 ] 

ASF subversion and git services commented on GEODE-2460:


Commit 635d3118177f6cae6b0497097e64bdb7a9aee800 in geode's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=635d311 ]

Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/geode into 
develop

* 'develop' of https://git-wip-us.apache.org/repos/asf/geode: (57 commits)
  GEODE-2551 Fix code issues found by AppChecker
  Revert "GEODE-1887: Now Size api goes through ServerProxy when cache is of 
type client and DataPolicy is Empty."
  GEODE-2538: Don't deserialize values on the server when getting results
  GEODE-2461: remove json4s-ast_2.10 as explicit dependency
  GEODE-2547: Interest registration no longer causes a CacheLoader to be invoked
  GEODE-2526: Enhance log statement to include ResourceTypeName
  GEODE-880 Remove unused classes
  GEODE-2460: update dependency versions
  GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQueueFactory, 
ReliableMessageQueueFactoryImpl and it's usage in the code from 
GemfireCacheImpl and DistributedRegion.
  GEODE-2550 Improve README and BUILDING
  GEODE-2538: Don't invoke a cache loader when fetching values for a lucene 
query
  GEODE-2404: Added support for destroying lucene indexes
  GEODE-2545: NPE during lucene query execution when cache is closing or region 
is destroyed
  GEODE-2515: Disabling BaseLineAndCompareQueryPerfJUnitTest
  GEODE-2142: Removing JSON licence stuff from NOTICE files
  GEODE-2142: removing tests so run precheckin
  GEODE-2142: final compiling build
  GEODE-2142: cyclical dependency in gradle build
  GEODE-2142: spotless
  GEODE-2142: Refactoring of tests to work with new JSONObject class. Changing 
file export to use Base64 encoding.
  ...


> Update dependency versions
> --
>
> Key: GEODE-2460
> URL: https://issues.apache.org/jira/browse/GEODE-2460
> Project: Geode
>  Issue Type: Wish
>  Components: build, docs
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> Here's the first bunch of dependency version updates that passes precheckin 
> without modifying source code:
> Update the following dependency versions defined in
> gradle/dependency-versions.properties.
> Update major versions (test-only):
> * org.apache.bcel:bcel:6.0
> Update minor versions (test and main):
> * commons-beanutils:1.9.3 
> * commons-fileupload:1.3.2 
> * commons-io:2.5 
> * commons-lang:2.6
> * commons-logging:1.2
> * commons-modeler:2.0.1
> * fastutil:7.0.13
> * guava:21.0
> * jansi:1.14
> * javax.mail-api:1.4.7
> * jline:2.14.3
> * jopt-simple:5.0.3
> * log4j-api:2.7
> * log4j-core:2.7
> * log4j-jcl:2.7
> * log4j-jul:2.7
> * log4j-slf4j-impl:2.7
> * netty-all:4.1.7.Final
> * shiro-core:1.3.2
> * slf4j-api:1.7.22
> Update minor versions (test-only):
> * assertj-core:3.6.2
> * cglib:cglib:3.2.4
> * commons-configuration:1.10
> * derby:10.13.1.1
> * google-gson:2.8.0
> * httpclient:4.5.2
> * httpcore:4.4.6
> * hsqldb:2.3.4
> * javassist:3.21.0-GA
> * jedis:2.9.0
> * JUnitParams:1.0.6
> * mockrunner:1.1.2
> * mortbay-jetty-servlet-api:2.5.20110712
> * phantomjsdriver:1.3.0
> * powermock-core:1.6.6
> * powermock-module-junit4:1.6.6
> * powermock-api-mockito:1.6.6
> * selenium-api:3.0.1
> * selenium-remote-driver:3.0.1
> * selenium-support:3.0.1
> * spymemcached:2.12.2
> * system-rules:1.16.1
> * tomcat-catalina:7.0.73 (tomcat7)
> * tomcat-coyote:7.0.73 (tomcat7)
> * tomcat-juli:7.0.73 (tomcat7)
> * tomcat-catalina:8.5.9 (tomcat8)
> * tomcat-coyote:8.5.9 (tomcat8)
> * tomcat-juli:8.5.9 (tomcat8)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2515) CI Failure: BaseLineAndCompareQueryPerfJUnitTest.testPerformanceForRangeQueries FAILED failed with AssertionFailedError

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891085#comment-15891085
 ] 

ASF subversion and git services commented on GEODE-2515:


Commit 635d3118177f6cae6b0497097e64bdb7a9aee800 in geode's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=635d311 ]

Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/geode into 
develop

* 'develop' of https://git-wip-us.apache.org/repos/asf/geode: (57 commits)
  GEODE-2551 Fix code issues found by AppChecker
  Revert "GEODE-1887: Now Size api goes through ServerProxy when cache is of 
type client and DataPolicy is Empty."
  GEODE-2538: Don't deserialize values on the server when getting results
  GEODE-2461: remove json4s-ast_2.10 as explicit dependency
  GEODE-2547: Interest registration no longer causes a CacheLoader to be invoked
  GEODE-2526: Enhance log statement to include ResourceTypeName
  GEODE-880 Remove unused classes
  GEODE-2460: update dependency versions
  GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQueueFactory, 
ReliableMessageQueueFactoryImpl and it's usage in the code from 
GemfireCacheImpl and DistributedRegion.
  GEODE-2550 Improve README and BUILDING
  GEODE-2538: Don't invoke a cache loader when fetching values for a lucene 
query
  GEODE-2404: Added support for destroying lucene indexes
  GEODE-2545: NPE during lucene query execution when cache is closing or region 
is destroyed
  GEODE-2515: Disabling BaseLineAndCompareQueryPerfJUnitTest
  GEODE-2142: Removing JSON licence stuff from NOTICE files
  GEODE-2142: removing tests so run precheckin
  GEODE-2142: final compiling build
  GEODE-2142: cyclical dependency in gradle build
  GEODE-2142: spotless
  GEODE-2142: Refactoring of tests to work with new JSONObject class. Changing 
file export to use Base64 encoding.
  ...


> CI Failure: 
> BaseLineAndCompareQueryPerfJUnitTest.testPerformanceForRangeQueries FAILED 
> failed with AssertionFailedError
> ---
>
> Key: GEODE-2515
> URL: https://issues.apache.org/jira/browse/GEODE-2515
> Project: Geode
>  Issue Type: Bug
>  Components: querying
>Affects Versions: 1.0.0-incubating
>Reporter: Jason Huynh
>Assignee: Dan Smith
> Fix For: 1.2.0
>
>
>   java.lang.AssertionError: Avg. Time taken to query with index should be 
> less than time taken without index
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at 
> org.apache.geode.cache.query.BaseLineAndCompareQueryPerfJUnitTest.testPerformanceForRangeQueries(BaseLineAndCompareQueryPerfJUnitTest.java:299)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (GEODE-2488) Netstat command fails with OutOfMemoryError

[Kenneth Howe (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kenneth Howe reassigned GEODE-2488:
---

Assignee: Kenneth Howe

> Netstat command fails with OutOfMemoryError
> ---
>
> Key: GEODE-2488
> URL: https://issues.apache.org/jira/browse/GEODE-2488
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, management
>Reporter: Kirk Lund
>Assignee: Kenneth Howe
>  Labels: MiscellaneousCommands, NetstatCommand, netstat
>
> Note: this can occur outside of dunit tests as well. Just using the gfsh 
> netstat command on locator or server with too little heap space will hit 
> this. See the 1st comment about not streaming the netstat output -- the 
> entire output is held in memory in a string and two byte arrays before 
> sending the result back from NetstatFunction.
> The JUnit controller JVM for NetstatDUnitTest fails with something like the 
> follow stack. The cause appears to be one of the DUnit VMs running out of 
> memory (see the OOME stack down further in this description.
> {noformat}
> org.junit.ComparisonFailure: [{"errorCode":505,"message":["Could not process 
> command due to GemFire error. Error occurred while executing netstat on 
> [server-1]"]}] expected:<[OK]> but was:<[ERROR]>
>   at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
>   at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
>   at 
> org.apache.geode.test.dunit.rules.GfshShellConnectionRule.executeAndVerifyCommand(GfshShellConnectionRule.java:163)
>   at 
> org.apache.geode.management.internal.cli.NetstatDUnitTest.testConnectToJmxManagerOne(NetstatDUnitTest.java:81)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.apache.geode.test.junit.rules.DescribedExternalResource$1.evaluate(DescribedExternalResource.java:37)
>   at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
>   at sun.reflect.GeneratedMethodAccessor3.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> org.gradle.internal.dispatch.ProxyDispatchAdapter$Dispatc

[jira] [Commented] (GEODE-2541) NetstatDUnitTest fails with ClassCastException

[Kenneth Howe (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891093#comment-15891093
 ] 

Kenneth Howe commented on GEODE-2541:
-

The issue with gfsh netstat command causing a Java heap OutOfMemoryError has 
been reported as GEODE-2488.


> NetstatDUnitTest fails with ClassCastException
> --
>
> Key: GEODE-2541
> URL: https://issues.apache.org/jira/browse/GEODE-2541
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, tests
>Reporter: Kirk Lund
>Assignee: Kenneth Howe
>  Labels: MiscellaneousCommands, NetstatCommand, gfsh, netstat
>
> This might be a bug in the error handling code for gfsh or the functions used 
> by MiscellaneousCommands.
> {noformat}
> org.apache.geode.management.internal.cli.NetstatDUnitTest > 
> testConnectToJmxManagerOne FAILED
> org.junit.ComparisonFailure: [{"errorCode":505,"message":["Could not 
> process command due to GemFire error. Error occurred while executing netstat 
> on [server-1]"]}] expected:<[OK]> but was:<[ERROR]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native 
> Method)
> at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at 
> org.apache.geode.test.dunit.rules.GfshShellConnectionRule.executeAndVerifyCommand(GfshShellConnectionRule.java:168)
> at 
> org.apache.geode.management.internal.cli.NetstatDUnitTest.testConnectToJmxManagerOne(NetstatDUnitTest.java:82)
> org.apache.geode.management.internal.cli.NetstatDUnitTest > 
> testConnectToJmxManagerTwo FAILED
> java.lang.ClassCastException: java.lang.String cannot be cast to 
> org.apache.geode.management.internal.cli.result.CommandResult
> at 
> org.apache.geode.test.dunit.rules.GfshShellConnectionRule.executeCommand(GfshShellConnectionRule.java:159)
> at 
> org.apache.geode.test.dunit.rules.GfshShellConnectionRule.executeAndVerifyCommand(GfshShellConnectionRule.java:166)
> at 
> org.apache.geode.management.internal.cli.NetstatDUnitTest.testConnectToJmxManagerTwo(NetstatDUnitTest.java:88)
> org.apache.geode.management.internal.cli.NetstatDUnitTest > 
> testConnectToLocator FAILED
> org.junit.ComparisonFailure: [{"errorCode":520,"message":["Could not find 
> member(s) with Id(s) or name(s): server-1."]}] expected:<[OK]> but 
> was:<[ERROR]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native 
> Method)
> at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at 
> org.apache.geode.test.dunit.rules.GfshShellConnectionRule.executeAndVerifyCommand(GfshShellConnectionRule.java:168)
> at 
> org.apache.geode.management.internal.cli.NetstatDUnitTest.testConnectToLocator(NetstatDUnitTest.java:76)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2569) Unhelpful log message

[Bruce Schuchardt (JIRA)]

Bruce Schuchardt created GEODE-2569:
---

 Summary: Unhelpful log message
 Key: GEODE-2569
 URL: https://issues.apache.org/jira/browse/GEODE-2569
 Project: Geode
  Issue Type: Bug
  Components: membership, messaging
Reporter: Bruce Schuchardt


I found this in a log file:

Unable to form a TCP/IP connection to null in over 31 seconds

Just prior to this the same thread logged this:

Unable to form a TCP/IP connection to 10.32.109.100(15954):48987 in over 31 
seconds

The member mentioned was being removed from the membership view in another 
thread during this time and nothing malfunctioned, but it isn't useful to print 
the message with "null" in it.  We should supress that message.




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2569) Unhelpful log message

[Bruce Schuchardt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bruce Schuchardt updated GEODE-2569:

Priority: Trivial  (was: Major)

> Unhelpful log message
> -
>
> Key: GEODE-2569
> URL: https://issues.apache.org/jira/browse/GEODE-2569
> Project: Geode
>  Issue Type: Bug
>  Components: membership, messaging
>Reporter: Bruce Schuchardt
>Priority: Trivial
>
> I found this in a log file:
> Unable to form a TCP/IP connection to null in over 31 seconds
> Just prior to this the same thread logged this:
> Unable to form a TCP/IP connection to 10.32.109.100(15954):48987 in over 
> 31 seconds
> The member mentioned was being removed from the membership view in another 
> thread during this time and nothing malfunctioned, but it isn't useful to 
> print the message with "null" in it.  We should supress that message.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2570) Export cluster-configuration returns "GemFire error" message

[Wes Williams (JIRA)]

Wes Williams created GEODE-2570:
---

 Summary: Export cluster-configuration returns "GemFire error" 
message
 Key: GEODE-2570
 URL: https://issues.apache.org/jira/browse/GEODE-2570
 Project: Geode
  Issue Type: Bug
  Components: configuration, gfsh
Reporter: Wes Williams
 Fix For: 1.2.0, 1.1.0


gfsh>version
1.1.0

gfsh>start locator --name=locator1 --port=10334 
--properties-file=config/locator.properties 
--load-cluster-configuration-from-dir=true --initial-heap=256m --max-heap=256m

gfsh>start server --name=server1 --server-port=0 
--properties-file=config/gemfire.properties --initial-heap=1g --max-heap=1g

gfsh>list regions
No Regions Found

gfsh>list members
  Name   | Id
 | 
locator1 | 192.168.0.5(locator1:43398:locator):1024
server1  | 192.168.0.5(server1:43404):1025

gfsh>create region --name=Test --type=PARTITION
Member  | Status
--- | ---
server1 | Region "/Test" created on "server1"

gfsh>export cluster-configuration --zip-file-name=test.zip
Could not process command due to GemFire error. Error while processing command 
 Reason : null

[info 2017/03/01 16:27:55.414 EST locator1  
tid=0x6c] (tid=108 msgId=72) Could not execute "export cluster-configuration 
--zip-file-name=test.zip".
java.lang.NullPointerException
at 
org.apache.geode.management.internal.cli.commands.ExportImportClusterConfigurationCommands.exportSharedConfig(ExportImportClusterConfigurationCommands.java:85)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at 
org.springframework.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:216)
at 
org.apache.geode.management.internal.cli.remote.RemoteExecutionStrategy.execute(RemoteExecutionStrategy.java:91)
at 
org.apache.geode.management.internal.cli.remote.CommandProcessor.executeCommand(CommandProcessor.java:117)
at 
org.apache.geode.management.internal.cli.remote.CommandStatementImpl.process(CommandStatementImpl.java:71)
at 
org.apache.geode.management.internal.cli.remote.MemberCommandService.processCommand(MemberCommandService.java:52)
at 
org.apache.geode.management.internal.beans.MemberMBeanBridge.processCommand(MemberMBeanBridge.java:1639)
at 
org.apache.geode.management.internal.beans.MemberMBean.processCommand(MemberMBean.java:404)
at 
org.apache.geode.management.internal.beans.MemberMBean.processCommand(MemberMBean.java:397)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at sun.reflect.misc.Trampoline.invoke(MethodUtil.java:71)
at sun.reflect.GeneratedMethodAccessor2.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at sun.reflect.misc.MethodUtil.invoke(MethodUtil.java:275)
at 
com.sun.jmx.mbeanserver.ConvertingMethod.invokeWithOpenReturn(ConvertingMethod.java:193)
at 
com.sun.jmx.mbeanserver.ConvertingMethod.invokeWithOpenReturn(ConvertingMethod.java:175)
at 
com.sun.jmx.mbeanserver.MXBeanIntrospector.invokeM2(MXBeanIntrospector.java:117)
at 
com.sun.jmx.mbeanserver.MXBeanIntrospector.invokeM2(MXBeanIntrospector.java:54)
at 
com.sun.jmx.mbeanserver.MBeanIntrospector.invokeM(MBeanIntrospector.java:237)
at com.sun.jmx.mbeanserver.PerInterface.invoke(PerInterface.java:138)
at com.sun.jmx.mbeanserver.MBeanSupport.invoke(MBeanSupport.java:252)
at 
com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.invoke(DefaultMBeanServerInterceptor.java:819)
at 
com.sun.jmx.mbeanserver.JmxMBeanServer.invoke(JmxMBeanServer.java:801)
at 
javax.management.remote.rmi.RMIConnectionImpl.doOperation(RMIConnectionImpl.java:1466)
at 
javax.management.remote.rmi.RMIConnectionImpl.access$300(RMIConnectionImpl.java:76)
at 
javax.management.remote.rmi.RMIConnectionImpl$PrivilegedOperation.run(RMIConnectionImpl.java:1307)
at 
javax.management.remote.rmi.RMIConnectionImpl.doPrivilegedOperation(RMIConnectionImpl.java:1399)
at 
javax.management.remote.rmi.RMIConnectionImpl.invoke(RMIConnectionImpl.java:828)
at sun.reflect.GeneratedMethodAccessor197.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccess

[jira] [Commented] (GEODE-2541) NetstatDUnitTest fails with ClassCastException

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891118#comment-15891118
 ] 

ASF subversion and git services commented on GEODE-2541:


Commit b8953046cb0b32155ff8bce09890161a77bea473 in geode's branch 
refs/heads/feature/GEODE-2541 from [~khowe]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=b895304 ]

GEODE-2541: Fixed ClassCastException failure

Fixed in HeadlessGfsh, and added new test for handling a command response
that's not a CommandResult object


> NetstatDUnitTest fails with ClassCastException
> --
>
> Key: GEODE-2541
> URL: https://issues.apache.org/jira/browse/GEODE-2541
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, tests
>Reporter: Kirk Lund
>Assignee: Kenneth Howe
>  Labels: MiscellaneousCommands, NetstatCommand, gfsh, netstat
>
> This might be a bug in the error handling code for gfsh or the functions used 
> by MiscellaneousCommands.
> {noformat}
> org.apache.geode.management.internal.cli.NetstatDUnitTest > 
> testConnectToJmxManagerOne FAILED
> org.junit.ComparisonFailure: [{"errorCode":505,"message":["Could not 
> process command due to GemFire error. Error occurred while executing netstat 
> on [server-1]"]}] expected:<[OK]> but was:<[ERROR]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native 
> Method)
> at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at 
> org.apache.geode.test.dunit.rules.GfshShellConnectionRule.executeAndVerifyCommand(GfshShellConnectionRule.java:168)
> at 
> org.apache.geode.management.internal.cli.NetstatDUnitTest.testConnectToJmxManagerOne(NetstatDUnitTest.java:82)
> org.apache.geode.management.internal.cli.NetstatDUnitTest > 
> testConnectToJmxManagerTwo FAILED
> java.lang.ClassCastException: java.lang.String cannot be cast to 
> org.apache.geode.management.internal.cli.result.CommandResult
> at 
> org.apache.geode.test.dunit.rules.GfshShellConnectionRule.executeCommand(GfshShellConnectionRule.java:159)
> at 
> org.apache.geode.test.dunit.rules.GfshShellConnectionRule.executeAndVerifyCommand(GfshShellConnectionRule.java:166)
> at 
> org.apache.geode.management.internal.cli.NetstatDUnitTest.testConnectToJmxManagerTwo(NetstatDUnitTest.java:88)
> org.apache.geode.management.internal.cli.NetstatDUnitTest > 
> testConnectToLocator FAILED
> org.junit.ComparisonFailure: [{"errorCode":520,"message":["Could not find 
> member(s) with Id(s) or name(s): server-1."]}] expected:<[OK]> but 
> was:<[ERROR]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native 
> Method)
> at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at 
> org.apache.geode.test.dunit.rules.GfshShellConnectionRule.executeAndVerifyCommand(GfshShellConnectionRule.java:168)
> at 
> org.apache.geode.management.internal.cli.NetstatDUnitTest.testConnectToLocator(NetstatDUnitTest.java:76)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2541) NetstatDUnitTest fails with ClassCastException

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891119#comment-15891119
 ] 

ASF subversion and git services commented on GEODE-2541:


Commit 8e30938aae3d1d60735c24ea16459b555addebdb in geode's branch 
refs/heads/feature/GEODE-2541 from [~khowe]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=8e30938 ]

Merge remote-tracking branch 'origin/develop' into feature/GEODE-2541


> NetstatDUnitTest fails with ClassCastException
> --
>
> Key: GEODE-2541
> URL: https://issues.apache.org/jira/browse/GEODE-2541
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, tests
>Reporter: Kirk Lund
>Assignee: Kenneth Howe
>  Labels: MiscellaneousCommands, NetstatCommand, gfsh, netstat
>
> This might be a bug in the error handling code for gfsh or the functions used 
> by MiscellaneousCommands.
> {noformat}
> org.apache.geode.management.internal.cli.NetstatDUnitTest > 
> testConnectToJmxManagerOne FAILED
> org.junit.ComparisonFailure: [{"errorCode":505,"message":["Could not 
> process command due to GemFire error. Error occurred while executing netstat 
> on [server-1]"]}] expected:<[OK]> but was:<[ERROR]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native 
> Method)
> at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at 
> org.apache.geode.test.dunit.rules.GfshShellConnectionRule.executeAndVerifyCommand(GfshShellConnectionRule.java:168)
> at 
> org.apache.geode.management.internal.cli.NetstatDUnitTest.testConnectToJmxManagerOne(NetstatDUnitTest.java:82)
> org.apache.geode.management.internal.cli.NetstatDUnitTest > 
> testConnectToJmxManagerTwo FAILED
> java.lang.ClassCastException: java.lang.String cannot be cast to 
> org.apache.geode.management.internal.cli.result.CommandResult
> at 
> org.apache.geode.test.dunit.rules.GfshShellConnectionRule.executeCommand(GfshShellConnectionRule.java:159)
> at 
> org.apache.geode.test.dunit.rules.GfshShellConnectionRule.executeAndVerifyCommand(GfshShellConnectionRule.java:166)
> at 
> org.apache.geode.management.internal.cli.NetstatDUnitTest.testConnectToJmxManagerTwo(NetstatDUnitTest.java:88)
> org.apache.geode.management.internal.cli.NetstatDUnitTest > 
> testConnectToLocator FAILED
> org.junit.ComparisonFailure: [{"errorCode":520,"message":["Could not find 
> member(s) with Id(s) or name(s): server-1."]}] expected:<[OK]> but 
> was:<[ERROR]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native 
> Method)
> at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at 
> org.apache.geode.test.dunit.rules.GfshShellConnectionRule.executeAndVerifyCommand(GfshShellConnectionRule.java:168)
> at 
> org.apache.geode.management.internal.cli.NetstatDUnitTest.testConnectToLocator(NetstatDUnitTest.java:76)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)