> On March 1, 2017, 10:25 a.m., anilkumar gingade wrote: > > geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java > > Line 5810 (original), 5810 (patched) > > <https://reviews.apache.org/r/57208/diff/1/?file=1652784#file1652784line5810> > > > > Do we need the same check for drf file? > > Kevin Duling wrote: > I think it needs to be understood why the crf was missing in the first > place when the crf file variable is not null. Was it an oversight or > expected behavior to have the old FileUtil fail silently when the source file > does not exist? This change will fix a failing test, but it may be revealing > a deeper issue that was masked by the silent fail.
Whatever is causing the crf to exist will probably also cause the drf to not exist. So odds are that with your fix these tests will now get to the next line and throw on exception on the drf not existing. It can also happen on the next line that copies the krf. - Darrel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57208/#review167411 ----------------------------------------------------------- On March 1, 2017, 9:56 a.m., Kevin Duling wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57208/ > ----------------------------------------------------------- > > (Updated March 1, 2017, 9:56 a.m.) > > > Review request for geode, Darrel Schneider, Jared Stewart, Kirk Lund, and Dan > Smith. > > > Repository: geode > > > Description > ------- > > GEODE-2560: Missing disk files (.crf) during backup/restore throws exception > > > Diffs > ----- > > geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java > f5aec51a09e671bc7d4ca33d4de8f0f683ef4d73 > > > Diff: https://reviews.apache.org/r/57208/diff/1/ > > > Testing > ------- > > precheckin running > > > Thanks, > > Kevin Duling > >
