Re: [PR] [minor](fix) Fix incorrect fmt arguments (#38840) [doris]
doris-robot commented on PR #38861: URL: https://github.com/apache/doris/pull/38861#issuecomment-2268325203 TeamCity be ut coverage result: Function Coverage: 36.42% (9267/25446) Line Coverage: 27.94% (75799/271258) Region Coverage: 26.79% (38986/145530) Branch Coverage: 23.51% (19789/84170) Coverage Report: http://coverage.selectdb-in.cc/coverage/7ca8880c44a2ec826ca124fd36eeaafad1363589_7ca8880c44a2ec826ca124fd36eeaafad1363589/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](clone) fix stale tablet report miss the new cloning replica #38695 [doris]
yujun777 commented on PR #38839: URL: https://github.com/apache/doris/pull/38839#issuecomment-2268328919 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](minor) Delete unused code [doris]
doris-robot commented on PR #38848: URL: https://github.com/apache/doris/pull/38848#issuecomment-2268337323 TPC-H: Total hot run time: 41590 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 54c5df151b2bd656663f186b4f6efe93587c9a3a, data reload: false -- Round 1 -- q1 17618 416141134113 q2 2028199 199 199 q3 10529 137713861377 q4 10160 789 940 789 q5 7656298929592959 q6 227 138 137 137 q7 1061622 625 622 q8 9447189719571897 q9 8457656665836566 q10 8776386538493849 q11 429 245 249 245 q12 417 226 220 220 q13 17774 294729512947 q14 268 247 252 247 q15 523 487 486 486 q16 522 400 385 385 q17 977 884 878 878 q18 7924727771617161 q19 1388121912101210 q20 550 328 325 325 q21 5422470147104701 q22 353 277 283 277 Total cold run time: 112506 ms Total hot run time: 41590 ms - Round 2, with runtime_filter_mode=off - q1 4059407440694069 q2 331 227 224 224 q3 2980303031583030 q4 2015202419681968 q5 5574550854975497 q6 220 130 128 128 q7 2147177918201779 q8 3325335533943355 q9 8632865187538651 q10 3968400239613961 q11 557 476 476 476 q12 764 603 600 600 q13 16012 311731303117 q14 295 280 269 269 q15 528 479 503 479 q16 457 425 414 414 q17 1778174217421742 q18 8192767577367675 q19 1709172517591725 q20 2048183218351832 q21 5681547252435243 q22 547 481 465 465 Total cold run time: 71819 ms Total hot run time: 56699 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [pick](nestedtype)support nested type with agg replace_if_not_null [doris]
amorynan commented on PR #38716: URL: https://github.com/apache/doris/pull/38716#issuecomment-2268339076 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](clone) fix stale tablet report miss the new cloning replica #38695 [doris]
github-actions[bot] commented on PR #38839: URL: https://github.com/apache/doris/pull/38839#issuecomment-2268339134 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [fix](tools) tpcds-tools: report benchmark result before cleanup [doris]
englefly opened a new pull request, #38864: URL: https://github.com/apache/doris/pull/38864 ## Proposed changes cleanup may failed, and blocks printing hot/cold run summary Issue Number: close #xxx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](tools) tpcds-tools: report benchmark result before cleanup [doris]
doris-robot commented on PR #38864: URL: https://github.com/apache/doris/pull/38864#issuecomment-2268341863 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](tools) tpcds-tools: report benchmark result before cleanup [doris]
englefly commented on PR #38864: URL: https://github.com/apache/doris/pull/38864#issuecomment-2268341963 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Improvement](runtime-filter) adjust always true judge rule of runtime filter apply [doris]
HappenLee commented on code in PR #38300:
URL: https://github.com/apache/doris/pull/38300#discussion_r1703646508
##
be/src/vec/exprs/vruntimefilter_wrapper.h:
##
@@ -39,12 +39,25 @@ class VExprContext;
} // namespace vectorized
} // namespace doris
+inline double get_in_list_ignore_thredhold(size_t list_size) {
Review Comment:
better eazy to cal and understand
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](tools) tpcds-tools: report benchmark result before cleanup [doris]
github-actions[bot] commented on PR #38864:
URL: https://github.com/apache/doris/pull/38864#issuecomment-2268343124
`sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/10244334095";) output.
shellcheck errors
```
'shellcheck ' returned error 1 finding the following syntactical issues:
--
In tools/tpcds-tools/bin/run-tpcds-queries.sh line 144:
cat ${backup_session_variables_file}
^-- SC2086 (info): Double quote to prevent globbing and word
splitting.
Did you mean:
cat "${backup_session_variables_file}"
For more information:
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing
...
--
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=
above the line that contains the issue, where is the error code;
3. Add '-e ' to the SHELLCHECK_OPTS setting in your .yml action file.
```
shfmt errors
```
'shfmt ' returned error 1 finding the following formatting issues:
--
--- tools/tpcds-tools/bin/run-tpcds-queries.sh.orig
+++ tools/tpcds-tools/bin/run-tpcds-queries.sh
--
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhencement] support HTTPS in fragment manager URL construction [doris]
github-actions[bot] commented on PR #33872: URL: https://github.com/apache/doris/pull/33872#issuecomment-2268346581 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [pick](nestedtype)support nested type with agg replace_if_not_null [doris]
github-actions[bot] commented on PR #38716: URL: https://github.com/apache/doris/pull/38716#issuecomment-2268351213 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](parquet) disable parquet page index by default [doris]
doris-robot commented on PR #38691: URL: https://github.com/apache/doris/pull/38691#issuecomment-2268352407 TPC-H: Total hot run time: 41506 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 74dc076f4a42ef5de4fdea0661d418b9e8c88381, data reload: false -- Round 1 -- q1 17606 417640684068 q2 2029201 211 201 q3 10463 124913171249 q4 10163 871 905 871 q5 7659299429792979 q6 217 137 135 135 q7 1061612 628 612 q8 9454186219491862 q9 8592659465656565 q10 8763385038233823 q11 436 245 247 245 q12 432 225 231 225 q13 17769 290829442908 q14 273 248 248 248 q15 522 491 496 491 q16 537 396 378 378 q17 967 931 929 929 q18 7983727671647164 q19 1447122412201220 q20 562 317 335 317 q21 5322478747364736 q22 351 288 280 280 Total cold run time: 112608 ms Total hot run time: 41506 ms - Round 2, with runtime_filter_mode=off - q1 4089404340034003 q2 326 230 229 229 q3 3019298231632982 q4 1997202819601960 q5 5644545254445444 q6 217 129 130 129 q7 2126183718351835 q8 3287333433543334 q9 8664866687368666 q10 4012395639733956 q11 555 472 463 463 q12 792 608 633 608 q13 14511 310131053101 q14 315 278 263 263 q15 525 487 497 487 q16 454 431 419 419 q17 1803174917421742 q18 8325776176587658 q19 1766173617501736 q20 2064183518341834 q21 5740534853685348 q22 511 463 462 462 Total cold run time: 70742 ms Total hot run time: 56659 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Improvement](runtime-filter) adjust always true judge rule of runtime filter apply [doris]
HappenLee commented on code in PR #38300:
URL: https://github.com/apache/doris/pull/38300#discussion_r1703653947
##
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##
@@ -2176,11 +2176,17 @@ uint16_t
SegmentIterator::_evaluate_vectorization_predicate(uint16_t* sel_rowid_
SCOPED_RAW_TIMER(&_opts.stats->vec_cond_ns);
bool all_pred_always_true = true;
for (const auto& pred : _pre_eval_block_predicate) {
-if (!pred->always_true()) {
+if (!pred->always_true(false)) {
all_pred_always_true = false;
break;
}
}
+if (all_pred_always_true) {
+for (const auto& pred : _pre_eval_block_predicate) {
Review Comment:
why here need set always true ？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix] (scan) push down expr in agg and mor [doris]
doris-robot commented on PR #38379: URL: https://github.com/apache/doris/pull/38379#issuecomment-2268352722 TPC-H: Total hot run time: 41771 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 4ba7414b4796a30c92c2c3eadaa475ec744006bd, data reload: false -- Round 1 -- q1 17619 408540804080 q2 2028199 204 199 q3 10455 128813381288 q4 10178 787 895 787 q5 7674296029802960 q6 224 136 134 134 q7 1054608 604 604 q8 9439192219611922 q9 8577661866226618 q10 8741384838333833 q11 428 243 245 243 q12 446 228 221 221 q13 17776 294229592942 q14 271 247 245 245 q15 522 485 507 485 q16 521 387 393 387 q17 972 942 928 928 q18 8070737873477347 q19 1568122912221222 q20 554 338 345 338 q21 5316473947094709 q22 345 279 293 279 Total cold run time: 112778 ms Total hot run time: 41771 ms - Round 2, with runtime_filter_mode=off - q1 4081401840204018 q2 334 222 225 222 q3 3003303031743030 q4 1988201819601960 q5 5589548154925481 q6 219 128 138 128 q7 2137172017991720 q8 3309337333443344 q9 8657864087988640 q10 3960408939773977 q11 545 455 448 448 q12 772 622 569 569 q13 13248 315931103110 q14 290 280 277 277 q15 534 484 490 484 q16 482 413 408 408 q17 1821173817331733 q18 8196784376777677 q19 1803171917251719 q20 2077184818671848 q21 5841543752525252 q22 517 460 459 459 Total cold run time: 69403 ms Total hot run time: 56504 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](nereids) adjust broadcast/shuffle join [doris]
doris-robot commented on PR #37823: URL: https://github.com/apache/doris/pull/37823#issuecomment-2268352800 TPC-H: Total hot run time: 40583 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 39fa580006cf0a20989774829f0f3efd5627c3ce, data reload: false -- Round 1 -- q1 17628 417941114111 q2 2018173 182 173 q3 10511 123113501231 q4 10174 811 927 811 q5 7556280628562806 q6 227 140 136 136 q7 1052602 592 592 q8 9431180719431807 q9 8501657065566556 q10 7047247624782476 q11 434 249 250 249 q12 404 223 226 223 q13 17763 293929522939 q14 280 241 244 241 q15 534 481 495 481 q16 533 381 384 381 q17 975 921 940 921 q18 8006725673067256 q19 1633122112351221 q20 565 326 330 326 q21 5289471047854710 q22 994 936 961 936 Total cold run time: 111555 ms Total hot run time: 40583 ms - Round 2, with runtime_filter_mode=off - q1 4134404640574046 q2 321 228 219 219 q3 2813280728282807 q4 1900200219861986 q5 5458559154155415 q6 226 131 131 131 q7 2091167716891677 q8 3323341033773377 q9 8646860487148604 q10 3438346034753460 q11 566 455 463 455 q12 833 620 560 560 q13 16280 305831203058 q14 303 275 273 273 q15 533 485 475 475 q16 459 419 414 414 q17 1749190717771777 q18 8126769575207520 q19 1812171017381710 q20 2054184718741847 q21 5786550954305430 q22 1079967 958 958 Total cold run time: 71930 ms Total hot run time: 56199 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](optimizer) Remove unused code [doris]
liutang123 commented on PR #38862: URL: https://github.com/apache/doris/pull/38862#issuecomment-2268353961 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](minor) Delete unused code [doris]
doris-robot commented on PR #38848: URL: https://github.com/apache/doris/pull/38848#issuecomment-2268355004 TPC-DS: Total hot run time: 169352 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 54c5df151b2bd656663f186b4f6efe93587c9a3a, data reload: false query1 912 375 369 369 query2 6459165016591650 query3 6657217 219 217 query4 19950 17432 17067 17067 query5 3639511 507 507 query6 257 163 168 163 query7 4593296 301 296 query8 237 197 189 189 query9 8504236023472347 query10 440 285 273 273 query11 10546 10066 98979897 query12 120 99 89 89 query13 1633380 374 374 query14 9865697076046970 query15 202 161 165 161 query16 6947448 434 434 query17 937 567 562 562 query18 1906276 271 271 query19 192 143 144 143 query20 98 84 84 84 query21 206 98 96 96 query22 4357405040854050 query23 33932 33738 33513 33513 query24 9452316930453045 query25 665 397 408 397 query26 1331159 152 152 query27 3018291 287 287 query28 7455205820062006 query29 1097436 442 436 query30 238 159 155 155 query31 945 772 799 772 query32 98 57 57 57 query33 680 322 336 322 query34 922 483 506 483 query35 853 789 757 757 query36 1029917 885 885 query37 165 82 87 82 query38 3036279827872787 query39 879 829 830 829 query40 252 116 114 114 query41 48 47 46 46 query42 116 102 114 102 query43 468 428 419 419 query44 1173730 764 730 query45 212 182 180 180 query46 1082817 809 809 query47 1811171317371713 query48 365 302 300 300 query49 862 439 443 439 query50 900 441 444 441 query51 6724670466716671 query52 105 100 92 92 query53 264 181 182 181 query54 637 469 480 469 query55 76 76 81 76 query56 285 278 271 271 query57 1148103710271027 query58 294 285 273 273 query59 2515234922892289 query60 300 283 294 283 query61 121 119 115 115 query62 900 660 662 660 query63 211 184 184 184 query64 5886197819861978 query65 3158312430933093 query66 1322347 349 347 query67 15337 14723 14903 14723 query68 4437581 567 567 query69 558 342 310 310 query70 1126108110401040 query71 425 288 292 288 query72 7881284326942694 query73 761 324 327 324 query74 6007568056435643 query75 3441275327262726 query76 2379117412791174 query77 619 313 318 313 query78 9656889588278827 query79 4397533 531 531 query80 1886508 498 498 query81 562 225 232 225 query82 1131133 135 133 query83 323 174 175 174 query84 273 82 80 80 query85 2044308 324 308 query86 446 289 281 281 query87 3251305731193057 query88 3930236523842365 query89 463 287 291 287 query90 1912191 186 186 query91 124 101 100 100 query92 64 48 51 48 query93 5357614 615 614 query94 963 290 280 280 query95 380 269 259 259 query96 630 281 283 281 query97 3248305430803054 query98 223 196 192 192 query99 1624129413131294 Total cold run time: 271545 ms Total hot run time: 169352 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th
Re: [PR] [refactor](minor) Delete unused code [doris]
doris-robot commented on PR #38848: URL: https://github.com/apache/doris/pull/38848#issuecomment-2268364610 ClickBench: Total hot run time: 29.88 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 54c5df151b2bd656663f186b4f6efe93587c9a3a, data reload: false query1 0.040.040.04 query2 0.070.040.04 query3 0.220.050.04 query4 1.690.070.07 query5 0.480.490.48 query6 1.170.720.72 query7 0.020.010.01 query8 0.060.050.04 query9 0.570.510.54 query10 0.570.550.56 query11 0.150.110.11 query12 0.160.120.12 query13 0.620.620.61 query14 0.780.800.80 query15 0.890.870.86 query16 0.360.350.37 query17 0.981.010.98 query18 0.210.210.22 query19 1.821.761.71 query20 0.010.000.01 query21 15.42 0.770.65 query22 4.138.251.31 query23 17.86 1.381.26 query24 2.250.220.22 query25 0.180.080.08 query26 0.320.220.22 query27 0.460.230.23 query28 13.19 0.990.96 query29 12.52 3.283.27 query30 0.270.060.05 query31 2.880.400.40 query32 3.230.500.48 query33 2.962.932.92 query34 15.45 4.274.24 query35 4.284.254.31 query36 0.680.470.47 query37 0.200.170.17 query38 0.170.150.16 query39 0.040.030.04 query40 0.160.140.13 query41 0.100.050.05 query42 0.050.050.05 query43 0.040.040.04 Total cold run time: 107.71 s Total hot run time: 29.88 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Improvement](runtime-filter) adjust always true judge rule of runtime filter apply [doris]
HappenLee commented on code in PR #38300:
URL: https://github.com/apache/doris/pull/38300#discussion_r1703624983
##
be/src/vec/exprs/vruntimefilter_wrapper.cpp:
##
@@ -81,26 +76,16 @@ void VRuntimeFilterWrapper::close(VExprContext* context,
Status VRuntimeFilterWrapper::execute(VExprContext* context, Block* block,
int* result_column_id) {
DCHECK(_open_finished || _getting_const_col);
+_judge_counter--;
if (_always_true) {
block->insert({create_always_true_column(block->rows(),
_data_type->is_nullable()),
Review Comment:
add TODO，should be return const column？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement](audit log) Set print audit log sesssion variable default value to false [doris]
Yukang-Lian commented on PR #38865: URL: https://github.com/apache/doris/pull/38865#issuecomment-2268366326 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](Nereids) refactor logical join constructor to withXXX [doris]
doris-robot commented on PR #37543: URL: https://github.com/apache/doris/pull/37543#issuecomment-2268367458 TPC-H: Total hot run time: 42570 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 4663ecc58dedac7f9787135296724dc06f130651, data reload: false -- Round 1 -- q1 17640 419340084008 q2 2011201 195 195 q3 10473 130513181305 q4 10165 825 904 825 q5 7592300129492949 q6 217 141 140 140 q7 1065628 607 607 q8 9431183419331834 q9 8493656766106567 q10 8725381238433812 q11 428 246 252 246 q12 412 231 224 224 q13 17769 290429462904 q14 274 246 247 246 q15 522 486 492 486 q16 547 408 425 408 q17 964 930 929 929 q18 7976722472147214 q19 1423121012011201 q20 595 353 384 353 q21 5537518851775177 q22 985 940 944 940 Total cold run time: 113244 ms Total hot run time: 42570 ms - Round 2, with runtime_filter_mode=off - q1 4071402940124012 q2 331 221 221 221 q3 2991310931743109 q4 2025195219931952 q5 5564546153565356 q6 256 128 129 128 q7 2155183018041804 q8 3253332733003300 q9 8687870386168616 q10 4010390039933900 q11 547 455 465 455 q12 765 604 602 602 q13 15476 310730923092 q14 305 259 282 259 q15 520 476 494 476 q16 573 545 533 533 q17 1757172917351729 q18 8269763476007600 q19 1734170817131708 q20 2069185618551855 q21 9911959794709470 q22 10431004982 982 Total cold run time: 76312 ms Total hot run time: 61159 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [Enhancement](audit log) Set print audit log sesssion variable default value to false [doris]
Yukang-Lian opened a new pull request, #38865: URL: https://github.com/apache/doris/pull/38865 ## Proposed changes In #38419, we introduced a new variable `enable_prepared_stmt_audit_log` to make group commit faster. Here we set this session variable default value to false. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement](audit log) Set print audit log sesssion variable default value to false [doris]
doris-robot commented on PR #38865: URL: https://github.com/apache/doris/pull/38865#issuecomment-2268366101 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](parquet) disable parquet page index by default [doris]
doris-robot commented on PR #38691: URL: https://github.com/apache/doris/pull/38691#issuecomment-2268370834 TPC-DS: Total hot run time: 167939 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 74dc076f4a42ef5de4fdea0661d418b9e8c88381, data reload: false query1 903 379 372 372 query2 6475163316421633 query3 6662217 231 217 query4 19898 17276 17411 17276 query5 3610502 522 502 query6 275 167 161 161 query7 4587293 297 293 query8 262 216 203 203 query9 8510239023752375 query10 423 273 267 267 query11 10565 997499059905 query12 120 91 86 86 query13 1653372 379 372 query14 9620609970166099 query15 220 167 166 166 query16 6979486 473 473 query17 947 567 593 567 query18 1909277 275 275 query19 203 144 141 141 query20 88 87 82 82 query21 209 97 98 97 query22 4274415139483948 query23 33650 33859 33411 33411 query24 9531302530983025 query25 640 401 423 401 query26 1198161 151 151 query27 2390279 284 279 query28 7248201020052005 query29 965 431 423 423 query30 240 155 152 152 query31 954 785 763 763 query32 103 54 59 54 query33 678 326 320 320 query34 933 500 496 496 query35 855 760 752 752 query36 1067919 887 887 query37 171 85 86 85 query38 2956283928282828 query39 861 823 800 800 query40 201 114 115 114 query41 49 44 44 44 query42 129 99 101 99 query43 484 430 405 405 query44 1202749 749 749 query45 206 178 174 174 query46 1101835 774 774 query47 1796172916771677 query48 368 285 291 285 query49 833 435 427 427 query50 905 436 440 436 query51 6710669166966691 query52 112 89 99 89 query53 250 191 186 186 query54 637 454 453 453 query55 76 81 76 76 query56 268 250 253 250 query57 1161101410591014 query58 262 271 275 271 query59 2544232222642264 query60 296 268 274 268 query61 100 92 100 92 query62 898 643 649 643 query63 210 214 184 184 query64 4472189818821882 query65 3143308631013086 query66 860 325 323 323 query67 15149 14729 14587 14587 query68 4380577 596 577 query69 675 404 336 336 query70 1072103710381037 query71 411 321 280 280 query72 7583264725342534 query73 780 326 328 326 query74 6047556356755563 query75 3372271327302713 query76 2705120012781200 query77 550 314 307 307 query78 9429898589288928 query79 2207540 541 540 query80 889 511 502 502 query81 556 227 227 227 query82 1356135 132 132 query83 198 172 167 167 query84 269 79 79 79 query85 1423317 305 305 query86 477 272 285 272 query87 3323307731603077 query88 3768238424312384 query89 384 295 290 290 query90 1784194 195 194 query91 124 99 104 99 query92 62 49 50 49 query93 2153619 614 614 query94 755 292 293 292 query95 386 270 268 268 query96 608 285 280 280 query97 3262303131073031 query98 223 201 195 195 query99 1632125612741256 Total cold run time: 260097 ms Total hot run time: 167939 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s
Re: [PR] [fix] (scan) push down expr in agg and mor [doris]
doris-robot commented on PR #38379: URL: https://github.com/apache/doris/pull/38379#issuecomment-2268371144 TPC-DS: Total hot run time: 168927 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 4ba7414b4796a30c92c2c3eadaa475ec744006bd, data reload: false query1 908 377 371 371 query2 6482161516521615 query3 6644234 222 222 query4 20092 17600 17097 17097 query5 3702519 533 519 query6 284 181 187 181 query7 4598302 288 288 query8 285 194 200 194 query9 8514238523672367 query10 443 273 266 266 query11 10621 992210076 9922 query12 124 89 86 86 query13 1621374 369 369 query14 9839690072826900 query15 201 164 159 159 query16 6796461 451 451 query17 936 572 537 537 query18 1819293 294 293 query19 201 148 147 147 query20 96 94 87 87 query21 242 98 96 96 query22 4122413338253825 query23 33619 33747 7 7 query24 9467314131043104 query25 647 405 412 405 query26 1411162 157 157 query27 2893279 281 279 query28 7443205420212021 query29 1006431 430 430 query30 238 155 158 155 query31 947 764 764 764 query32 98 57 60 57 query33 680 338 334 334 query34 937 513 533 513 query35 886 793 769 769 query36 1074894 893 893 query37 162 83 87 83 query38 2887277927662766 query39 869 834 814 814 query40 255 110 113 110 query41 49 43 43 43 query42 117 102 105 102 query43 461 406 415 406 query44 1192735 727 727 query45 205 175 181 175 query46 1078793 782 782 query47 1785171417471714 query48 366 289 285 285 query49 853 415 426 415 query50 898 433 432 432 query51 6783677167596759 query52 99 95 94 94 query53 256 182 183 182 query54 651 469 447 447 query55 76 74 74 74 query56 267 267 266 266 query57 1137104510661045 query58 284 273 313 273 query59 2700262123032303 query60 304 258 267 258 query61 99 95 91 91 query62 902 661 665 661 query63 211 182 179 179 query64 4797190519051905 query65 3158308730873087 query66 972 328 380 328 query67 15222 14760 14677 14677 query68 4309565 572 565 query69 442 296 305 296 query70 1115103310571033 query71 369 284 283 283 query72 7353269425182518 query73 765 328 322 322 query74 6005563056295629 query75 3332274727302730 query76 2108124212861242 query77 434 309 304 304 query78 9431892789028902 query79 1759531 540 531 query80 1158507 505 505 query81 554 231 226 226 query82 1029136 130 130 query83 242 171 169 169 query84 271 77 81 77 query85 1142319 298 298 query86 398 296 283 283 query87 3235315231523152 query88 2905240224332402 query89 397 308 290 290 query90 1669197 194 194 query91 125 100 99 99 query92 58 51 49 49 query93 1449633 621 621 query94 757 311 302 302 query95 376 266 269 266 query96 601 293 284 284 query97 3204304330863043 query98 225 205 201 201 query99 1598128812951288 Total cold run time: 257826 ms Total hot run time: 168927 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
Re: [PR] [fix](fs) Use full path as file cache key [doris]
gavinchou commented on code in PR #38808: URL: https://github.com/apache/doris/pull/38808#discussion_r1703666746 ## be/src/io/cache/block_file_cache.cpp: ## Review Comment: Add UT to cover all newly added branches, make sure nothing is missed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](nereids) Support eliminate outer join by match expression [doris]
924060929 commented on PR #38537: URL: https://github.com/apache/doris/pull/38537#issuecomment-2268372091 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](parquet) disable parquet page index by default [doris]
doris-robot commented on PR #38691: URL: https://github.com/apache/doris/pull/38691#issuecomment-2268380368 ClickBench: Total hot run time: 30.08 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 74dc076f4a42ef5de4fdea0661d418b9e8c88381, data reload: false query1 0.040.040.04 query2 0.070.040.03 query3 0.230.050.05 query4 1.690.070.07 query5 0.480.480.48 query6 1.140.720.71 query7 0.010.010.01 query8 0.040.040.04 query9 0.560.500.51 query10 0.560.550.58 query11 0.150.120.11 query12 0.140.120.13 query13 0.630.600.61 query14 0.780.790.81 query15 0.900.870.86 query16 0.350.350.36 query17 0.991.001.01 query18 0.250.240.21 query19 1.831.721.77 query20 0.010.010.01 query21 15.39 0.770.66 query22 3.688.051.36 query23 17.96 1.291.33 query24 2.260.220.22 query25 0.180.080.08 query26 0.320.220.22 query27 0.460.230.23 query28 13.19 0.980.95 query29 12.55 3.273.24 query30 0.250.060.06 query31 2.870.400.41 query32 3.250.500.49 query33 2.922.992.98 query34 15.44 4.284.27 query35 4.304.314.32 query36 0.680.470.48 query37 0.180.160.16 query38 0.160.160.15 query39 0.040.040.03 query40 0.150.140.13 query41 0.100.050.04 query42 0.060.050.05 query43 0.060.040.04 Total cold run time: 107.3 s Total hot run time: 30.08 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix] (scan) push down expr in agg and mor [doris]
doris-robot commented on PR #38379: URL: https://github.com/apache/doris/pull/38379#issuecomment-2268380642 ClickBench: Total hot run time: 31.02 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 4ba7414b4796a30c92c2c3eadaa475ec744006bd, data reload: false query1 0.050.040.04 query2 0.070.040.04 query3 0.220.050.05 query4 1.670.060.06 query5 0.480.490.48 query6 1.140.720.72 query7 0.020.020.01 query8 0.050.030.04 query9 0.570.500.50 query10 0.560.580.56 query11 0.160.110.12 query12 0.150.120.12 query13 0.610.600.59 query14 0.770.800.80 query15 0.900.860.89 query16 0.350.370.35 query17 0.990.980.99 query18 0.250.220.21 query19 1.861.721.74 query20 0.010.020.01 query21 15.39 0.740.65 query22 3.806.882.30 query23 18.07 1.431.43 query24 2.260.220.22 query25 0.180.080.08 query26 0.320.220.21 query27 0.460.240.23 query28 13.16 1.000.98 query29 12.59 3.273.30 query30 0.260.060.06 query31 2.860.400.41 query32 3.240.480.48 query33 2.932.932.98 query34 15.44 4.264.21 query35 4.294.274.26 query36 0.680.490.48 query37 0.200.160.17 query38 0.170.150.15 query39 0.040.040.03 query40 0.180.130.13 query41 0.100.040.04 query42 0.050.050.04 query43 0.040.050.04 Total cold run time: 107.59 s Total hot run time: 31.02 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](sql) Forbid show hidden columns and create table with hidden column [doris]
924060929 commented on PR #38796: URL: https://github.com/apache/doris/pull/38796#issuecomment-2268383680 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix] (regression test) Fix unstable regression test [doris]
csun5285 commented on PR #36563: URL: https://github.com/apache/doris/pull/36563#issuecomment-2268384277 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](Nereids) refactor logical join constructor to withXXX [doris]
doris-robot commented on PR #37543: URL: https://github.com/apache/doris/pull/37543#issuecomment-2268386121 TPC-DS: Total hot run time: 169775 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 4663ecc58dedac7f9787135296724dc06f130651, data reload: false query1 932 372 358 358 query2 6277164716651647 query3 6655215 225 215 query4 18837 17553 17527 17527 query5 3383510 511 510 query6 271 178 177 177 query7 4604295 295 295 query8 256 217 205 205 query9 8525239523632363 query10 450 299 296 296 query11 10504 10081 10063 10063 query12 131 92 86 86 query13 1636404 375 375 query14 11354 736786117367 query15 217 169 169 169 query16 6630424 419 419 query17 944 558 576 558 query18 1898278 279 278 query19 186 141 147 141 query20 94 87 90 87 query21 205 99 96 96 query22 4142423940524052 query23 34129 33511 33168 33168 query24 10180 306531063065 query25 697 402 436 402 query26 1725152 152 152 query27 2901283 283 283 query28 7254202719841984 query29 1285445 424 424 query30 245 156 153 153 query31 932 777 754 754 query32 104 54 56 54 query33 695 314 330 314 query34 896 482 491 482 query35 860 789 757 757 query36 1017885 880 880 query37 287 86 83 83 query38 3045287428472847 query39 887 845 878 845 query40 258 112 111 111 query41 47 45 44 44 query42 127 99 96 96 query43 460 416 413 413 query44 1175729 746 729 query45 203 178 177 177 query46 1077822 794 794 query47 1835173617241724 query48 355 294 285 285 query49 937 425 416 416 query50 892 426 422 422 query51 6762670366646664 query52 100 97 91 91 query53 262 186 180 180 query54 627 455 441 441 query55 76 77 80 77 query56 266 267 270 267 query57 1172106610381038 query58 268 264 292 264 query59 2370233324342333 query60 310 269 274 269 query61 96 94 93 93 query62 882 654 654 654 query63 210 174 186 174 query64 5597189319101893 query65 3171309331103093 query66 1320334 333 333 query67 15171 14811 14791 14791 query68 4245574 580 574 query69 442 303 313 303 query70 1114106610661066 query71 412 286 332 286 query72 7001267024562456 query73 767 323 324 323 query74 6030558257115582 query75 3334271327142713 query76 2292119912701199 query77 432 303 298 298 query78 9419896088788878 query79 1099541 533 533 query80 911 525 492 492 query81 569 226 229 226 query82 451 132 132 132 query83 260 167 166 166 query84 272 78 77 77 query85 1228329 306 306 query86 438 316 303 303 query87 3289314730833083 query88 2869240323902390 query89 388 297 285 285 query90 1708188 186 186 query91 124 98 99 98 query92 64 49 49 49 query93 1756619 615 615 query94 777 278 300 278 query95 406 302 303 302 query96 603 279 278 278 query97 3261304530303030 query98 218 200 198 198 query99 1576129112731273 Total cold run time: 259051 ms Total hot run time: 169775 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
Re: [PR] [Improvement](runtime-filter) adjust always true judge rule of runtime filter apply [doris]
HappenLee commented on code in PR #38300:
URL: https://github.com/apache/doris/pull/38300#discussion_r1703675662
##
be/src/vec/exprs/vruntimefilter_wrapper.cpp:
##
@@ -81,26 +76,16 @@ void VRuntimeFilterWrapper::close(VExprContext* context,
Status VRuntimeFilterWrapper::execute(VExprContext* context, Block* block,
int* result_column_id) {
DCHECK(_open_finished || _getting_const_col);
+_judge_counter--;
Review Comment:
the operation of `judge_counter` is error, must do change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](clone) fix stale tablet report miss the new cloning replica #38695 [doris]
doris-robot commented on PR #38839: URL: https://github.com/apache/doris/pull/38839#issuecomment-2268389574 TeamCity be ut coverage result: Function Coverage: 36.40% (9264/25448) Line Coverage: 27.93% (75764/271268) Region Coverage: 26.78% (38974/145534) Branch Coverage: 23.49% (19774/84172) Coverage Report: http://coverage.selectdb-in.cc/coverage/668646a445308019d11f2002abd2b7102bedf65e_668646a445308019d11f2002abd2b7102bedf65e/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](function) support group concat with distinct and order by [doris]
BiteThet merged PR #38851: URL: https://github.com/apache/doris/pull/38851 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch branch-2.1 updated: [Feature](function) support group concat with distinct and order by (#38851)
This is an automated email from the ASF dual-hosted git repository.
panxiaolei pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-2.1 by this push:
new 86ef0069ea8 [Feature](function) support group concat with distinct and
order by (#38851)
86ef0069ea8 is described below
commit 86ef0069ea85ee32f5d73317f86ce76f33974b11
Author: Pxl
AuthorDate: Mon Aug 5 15:44:51 2024 +0800
[Feature](function) support group concat with distinct and order by (#38851)
pick from #38744 and #38776
---
.../vec/aggregate_functions/aggregate_function.h | 11 +-
.../aggregate_function_distinct.cpp| 25 +--
.../aggregate_function_distinct.h | 206 +++--
.../aggregate_function_foreach.h | 2 -
.../aggregate_functions/aggregate_function_null.h | 2 -
.../aggregate_function_simple_factory.cpp | 1 -
.../aggregate_functions/aggregate_function_sort.h | 13 +-
7 files changed, 173 insertions(+), 87 deletions(-)
diff --git a/be/src/vec/aggregate_functions/aggregate_function.h
b/be/src/vec/aggregate_functions/aggregate_function.h
index c74e22bdbcd..74700dff17f 100644
--- a/be/src/vec/aggregate_functions/aggregate_function.h
+++ b/be/src/vec/aggregate_functions/aggregate_function.h
@@ -43,6 +43,8 @@ class AggregateFunctionBitmapCount;
template
class AggregateFunctionBitmapOp;
struct AggregateFunctionBitmapUnionOp;
+class IAggregateFunction;
+using AggregateFunctionPtr = std::shared_ptr;
using DataTypePtr = std::shared_ptr;
using DataTypes = std::vector;
@@ -178,11 +180,6 @@ public:
const size_t offset, IColumn& to,
const size_t num_rows) const = 0;
-/** Returns true for aggregate functions of type -State.
- * They are executed as other aggregate functions, but not finalized
(return an aggregation state that can be combined with another).
- */
-virtual bool is_state() const { return false; }
-
/** Contains a loop with calls to "add" function. You can collect
arguments into array "places"
* and do a single call to "add_batch" for devirtualization and inlining.
*/
@@ -223,6 +220,8 @@ public:
virtual void set_version(const int version_) { version = version_; }
+virtual AggregateFunctionPtr transmit_to_stable() { return nullptr; }
+
protected:
DataTypes argument_types;
int version {};
@@ -519,8 +518,6 @@ public:
}
};
-using AggregateFunctionPtr = std::shared_ptr;
-
class AggregateFunctionGuard {
public:
using AggregateData = std::remove_pointer_t;
diff --git a/be/src/vec/aggregate_functions/aggregate_function_distinct.cpp
b/be/src/vec/aggregate_functions/aggregate_function_distinct.cpp
index 5b2269a27d9..4773a620e0a 100644
--- a/be/src/vec/aggregate_functions/aggregate_function_distinct.cpp
+++ b/be/src/vec/aggregate_functions/aggregate_function_distinct.cpp
@@ -29,6 +29,16 @@
namespace doris::vectorized {
+template
+struct Reducer {
+template
+using Output = AggregateFunctionDistinctSingleNumericData;
+using AggregateFunctionDistinctNormal = AggregateFunctionDistinct;
+};
+
+template
+using AggregateFunctionDistinctNumeric =
Reducer::AggregateFunctionDistinctNormal;
+
class AggregateFunctionCombinatorDistinct final : public
IAggregateFunctionCombinator {
public:
String get_name() const override { return "Distinct"; }
@@ -51,22 +61,15 @@ public:
if (arguments.size() == 1) {
AggregateFunctionPtr res(
-
creator_with_numeric_type::create(
+
creator_with_numeric_type::create(
arguments, result_is_nullable, nested_function));
if (res) {
return res;
}
-if
(arguments[0]->is_value_unambiguously_represented_in_contiguous_memory_region())
{
-res = creator_without_type::create>>(
-arguments, result_is_nullable, nested_function);
-} else {
-res = creator_without_type::create>>(
-arguments, result_is_nullable, nested_function);
-}
+res = creator_without_type::create<
+
AggregateFunctionDistinct>(
+arguments, result_is_nullable, nested_function);
return res;
}
return creator_without_type::create<
diff --git a/be/src/vec/aggregate_functions/aggregate_function_distinct.h
b/be/src/vec/aggregate_functions/aggregate_function_distinct.h
index c0c7a5b66dd..4f42e8509f2 100644
--- a/be/src/vec/aggregate_functions/aggregate_function_distinct.h
+++ b/be/src/vec/aggregate_functions/aggregate_function_distinct.h
@@ -28,6 +28,8 @@
#include
#include
#include
+#include
+#include
#include
#include "vec/aggregate_function
Re: [PR] [refactor](Nereids) refactor logical join constructor to withXXX [doris]
doris-robot commented on PR #37543: URL: https://github.com/apache/doris/pull/37543#issuecomment-2268395758 ClickBench: Total hot run time: 29.7 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 4663ecc58dedac7f9787135296724dc06f130651, data reload: false query1 0.050.040.04 query2 0.080.040.04 query3 0.230.050.04 query4 1.680.060.06 query5 0.480.500.49 query6 1.140.720.71 query7 0.020.020.01 query8 0.050.050.04 query9 0.570.500.51 query10 0.560.570.58 query11 0.160.120.12 query12 0.150.120.13 query13 0.630.610.59 query14 0.780.800.79 query15 0.910.880.86 query16 0.360.360.35 query17 0.970.971.01 query18 0.220.230.22 query19 1.801.721.72 query20 0.010.010.01 query21 15.40 0.760.65 query22 4.168.071.06 query23 18.08 1.351.34 query24 2.260.220.21 query25 0.180.080.08 query26 0.320.210.21 query27 0.460.220.22 query28 13.16 0.990.98 query29 12.65 3.293.24 query30 0.270.060.06 query31 2.860.400.41 query32 3.250.470.48 query33 2.972.972.93 query34 15.43 4.264.24 query35 4.294.304.28 query36 0.670.490.48 query37 0.190.160.16 query38 0.150.140.15 query39 0.040.040.04 query40 0.170.130.13 query41 0.090.050.05 query42 0.060.040.05 query43 0.040.040.04 Total cold run time: 108 s Total hot run time: 29.7 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](Cloud) Support session variable disable_file_cache and enable_segment_cache in query [doris]
doris-robot commented on PR #37141: URL: https://github.com/apache/doris/pull/37141#issuecomment-2268395868 TPC-H: Total hot run time: 41931 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 2a115b417d19ed33bc472b581160c9476bd9137d, data reload: false -- Round 1 -- q1 18278 423941694169 q2 2437207 206 206 q3 11296 143313611361 q4 10788 854 1027854 q5 8233309530513051 q6 232 144 145 144 q7 1061612 612 612 q8 9459179219621792 q9 8609661866016601 q10 8746383438403834 q11 428 252 250 250 q12 412 229 221 221 q13 17753 296729322932 q14 275 245 245 245 q15 523 484 496 484 q16 508 402 389 389 q17 983 903 934 903 q18 8037730872977297 q19 1506122512141214 q20 574 321 339 321 q21 5312476647984766 q22 357 289 285 285 Total cold run time: 115807 ms Total hot run time: 41931 ms - Round 2, with runtime_filter_mode=off - q1 4080403940094009 q2 333 223 217 217 q3 3004300129852985 q4 1908189018831883 q5 5302523552425235 q6 215 130 132 130 q7 2101170917361709 q8 3198329432323232 q9 8332832883308328 q10 3762385738363836 q11 551 444 446 444 q12 725 573 540 540 q13 12143 294629602946 q14 289 257 254 254 q15 522 476 470 470 q16 452 404 400 400 q17 1730171217061706 q18 7790744872367236 q19 1674166316861663 q20 1988177517581758 q21 5388541652155215 q22 513 454 446 446 Total cold run time: 66000 ms Total hot run time: 54642 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement](audit log) Set print audit log sesssion variable default value to false [doris]
doris-robot commented on PR #38865: URL: https://github.com/apache/doris/pull/38865#issuecomment-2268399941 TPC-H: Total hot run time: 41653 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit b8a6a5aa9f36bde1b05a749db39d8dfb3537efc3, data reload: false -- Round 1 -- q1 18265 414741624147 q2 2464210 203 203 q3 11374 130813431308 q4 10947 817 936 817 q5 7911303729992999 q6 226 145 145 145 q7 1090641 622 622 q8 9439191319271913 q9 8425656765266526 q10 8688381638283816 q11 417 258 259 258 q12 413 236 230 230 q13 17758 294829692948 q14 270 243 241 241 q15 522 485 499 485 q16 486 400 387 387 q17 961 905 889 889 q18 7870729471717171 q19 1424122112131213 q20 575 330 346 330 q21 5304472648204726 q22 345 284 279 279 Total cold run time: 115174 ms Total hot run time: 41653 ms - Round 2, with runtime_filter_mode=off - q1 4260404239903990 q2 326 220 218 218 q3 2986298729792979 q4 1872186018501850 q5 5247524851995199 q6 216 130 130 130 q7 2063171016901690 q8 3160323531973197 q9 8302827082758270 q10 3751385338323832 q11 547 454 455 454 q12 741 609 558 558 q13 13465 299329552955 q14 295 259 256 256 q15 525 469 479 469 q16 434 401 397 397 q17 1713169816891689 q18 7747724571287128 q19 1670168216811681 q20 1975175917591759 q21 5416517651965176 q22 500 450 454 450 Total cold run time: 67211 ms Total hot run time: 54327 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](nereids) Support eliminate outer join by match expression [doris]
doris-robot commented on PR #38537: URL: https://github.com/apache/doris/pull/38537#issuecomment-2268403860 TPC-H: Total hot run time: 41721 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 8fff252ec2f42293b26c67adfabdc1a575b8313d, data reload: false -- Round 1 -- q1 17622 410641304106 q2 2024203 220 203 q3 10461 122812911228 q4 10163 803 946 803 q5 7652302529882988 q6 224 138 143 138 q7 1073631 613 613 q8 9451184719751847 q9 9310665466046604 q10 8850384438833844 q11 426 254 256 254 q12 439 234 227 227 q13 17768 293629392936 q14 268 240 251 240 q15 524 474 500 474 q16 529 396 384 384 q17 965 937 936 936 q18 8019734273087308 q19 1378123612361236 q20 572 330 334 330 q21 5354474748084747 q22 351 275 286 275 Total cold run time: 113423 ms Total hot run time: 41721 ms - Round 2, with runtime_filter_mode=off - q1 4058402740514027 q2 323 217 219 217 q3 3017301729972997 q4 1880189118791879 q5 5263523052515230 q6 220 131 131 131 q7 2039171317031703 q8 3187328032493249 q9 8289824582908245 q10 3752384938363836 q11 561 452 457 452 q12 736 552 562 552 q13 14510 295429432943 q14 292 253 263 253 q15 517 484 478 478 q16 440 402 383 383 q17 1713170917121709 q18 7715726871877187 q19 1662169716651665 q20 1972176617411741 q21 5395527552215221 q22 512 466 452 452 Total cold run time: 68053 ms Total hot run time: 54550 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Improvement](runtime-filter) adjust always true judge rule of runtime filter apply [doris]
BiteThet commented on code in PR #38300:
URL: https://github.com/apache/doris/pull/38300#discussion_r1703687732
##
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##
@@ -2176,11 +2176,17 @@ uint16_t
SegmentIterator::_evaluate_vectorization_predicate(uint16_t* sel_rowid_
SCOPED_RAW_TIMER(&_opts.stats->vec_cond_ns);
bool all_pred_always_true = true;
for (const auto& pred : _pre_eval_block_predicate) {
-if (!pred->always_true()) {
+if (!pred->always_true(false)) {
all_pred_always_true = false;
break;
}
}
+if (all_pred_always_true) {
+for (const auto& pred : _pre_eval_block_predicate) {
Review Comment:
Whenever we process a block of data, we should change the judge counter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](optimizer) Remove unused code [doris]
doris-robot commented on PR #38862: URL: https://github.com/apache/doris/pull/38862#issuecomment-2268405141 TPC-H: Total hot run time: 49733 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 61abb2cd1fe80d05c8b772873459d673fc0065ec, data reload: false -- Round 1 -- q1 17641 439043354335 q2 2071153 142 142 q3 10298 192519211921 q4 10338 128913141289 q5 8654386438893864 q6 244 123 151 123 q7 2071160715711571 q8 9310273426972697 q9 10619 10117 10151 10117 q10 8601349834713471 q11 412 244 251 244 q12 477 304 309 304 q13 18381 396840343968 q14 345 321 322 321 q15 510 449 458 449 q16 687 582 586 582 q17 1129957 978 957 q18 7362698870736988 q19 1795163415871587 q20 526 308 301 301 q21 4438417840544054 q22 540 455 448 448 Total cold run time: 116449 ms Total hot run time: 49733 ms - Round 2, with runtime_filter_mode=off - q1 4334439343554355 q2 323 224 222 222 q3 4204413741334133 q4 2741274227332733 q5 7008712170407040 q6 238 118 121 118 q7 3250282828402828 q8 4381448844634463 q9 16933 16807 16807 16807 q10 4208431442554255 q11 771 683 682 682 q12 1019852 841 841 q13 6976378137203720 q14 473 424 419 419 q15 504 454 456 454 q16 761 678 682 678 q17 3864386038503850 q18 8878878587958785 q19 1747172516741674 q20 2355216521662165 q21 8560854184258425 q22 1080998 1046998 Total cold run time: 84608 ms Total hot run time: 79645 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](tools) tpcds-tools: report benchmark result before cleanup [doris]
doris-robot commented on PR #38864: URL: https://github.com/apache/doris/pull/38864#issuecomment-2268406421 TPC-H: Total hot run time: 41512 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 618d4aadcf3757cc414065332d916ffc9587ceec, data reload: false -- Round 1 -- q1 17784 412740534053 q2 2019201 199 199 q3 10466 133613851336 q4 10162 831 881 831 q5 7651294029492940 q6 224 136 134 134 q7 1044610 611 610 q8 9431190419291904 q9 8428657265746572 q10 8729382438133813 q11 439 250 243 243 q12 439 228 221 221 q13 17757 292329192919 q14 274 240 246 240 q15 529 488 490 488 q16 527 402 385 385 q17 953 920 900 900 q18 7992745272057205 q19 1693122312081208 q20 565 324 353 324 q21 5186472447084708 q22 343 283 279 279 Total cold run time: 112635 ms Total hot run time: 41512 ms - Round 2, with runtime_filter_mode=off - q1 4089401640704016 q2 321 226 232 226 q3 2995297631312976 q4 1951202719771977 q5 5563547053705370 q6 214 130 128 128 q7 2121180917901790 q8 330533193319 q9 8616861487498614 q10 3906404639163916 q11 546 448 466 448 q12 765 600 599 599 q13 14889 310130903090 q14 318 271 275 271 q15 524 478 490 478 q16 462 398 417 398 q17 1743175617141714 q18 8123772477547724 q19 1710173017331730 q20 2057183418271827 q21 5635546352415241 q22 537 488 452 452 Total cold run time: 70390 ms Total hot run time: 56304 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[I] 空间地理数据如何存储 [doris]
jnfJNF opened a new issue, #38867: URL: https://github.com/apache/doris/issues/38867 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Description 我希望将空间地理数据存储到doris里面，并且能进行空间计算，请问如何存储计算POINT ### Use case _No response_ ### Related issues _No response_ ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](function) Results for stddev with nan and inf are unstable. [doris]
Mryange commented on PR #38866: URL: https://github.com/apache/doris/pull/38866#issuecomment-2268409489 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](function) Results for stddev with nan and inf are unstable. [doris]
doris-robot commented on PR #38866: URL: https://github.com/apache/doris/pull/38866#issuecomment-2268409403 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [I] [Bug] transport: Error while dialing: dial tcp 0.0.0.0:9090 [doris]
chengxin1374 commented on issue #36340: URL: https://github.com/apache/doris/issues/36340#issuecomment-2268412111 > 2.1.4-rc03 i also use doris-version:2.1.4-rc03. Have you solved the problem? I have the same problem as you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] add information_schema.table_properties #38745 [doris]
Vallishp commented on PR #38746: URL: https://github.com/apache/doris/pull/38746#issuecomment-2268414821 > please add auth check: 1 create user without any tables's priv, then it can see no table. 2 grant select priv to this user, then it can see the table's prop. 3 revoke select priv to this user, then it can see no table. I have updated regression test case for this case and result matching expectation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](Cloud) Support session variable disable_file_cache and enable_segment_cache in query [doris]
doris-robot commented on PR #37141: URL: https://github.com/apache/doris/pull/37141#issuecomment-2268414814 TPC-DS: Total hot run time: 168324 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 2a115b417d19ed33bc472b581160c9476bd9137d, data reload: false query1 909 384 368 368 query2 6486169116961691 query3 6672208 222 208 query4 20264 17395 17126 17126 query5 4314512 514 512 query6 279 171 181 171 query7 4605306 285 285 query8 251 198 196 196 query9 8526236923742369 query10 431 275 269 269 query11 10491 10030 10047 10030 query12 144 88 89 88 query13 1638375 373 373 query14 9198768368526852 query15 226 165 163 163 query16 7111457 448 448 query17 955 582 565 565 query18 1831291 281 281 query19 201 148 146 146 query20 98 89 91 89 query21 205 108 107 107 query22 4138414440574057 query23 33831 32973 32832 32832 query24 10548 308830773077 query25 692 377 370 370 query26 1755147 148 147 query27 2964271 281 271 query28 6922199119871987 query29 1317410 410 410 query30 285 147 148 147 query31 941 747 745 745 query32 99 55 56 55 query33 708 300 312 300 query34 905 491 487 487 query35 831 722 718 718 query36 996 870 861 861 query37 303 79 79 79 query38 2858279027762776 query39 874 792 804 792 query40 288 113 108 108 query41 44 43 43 43 query42 117 101 96 96 query43 493 420 419 419 query44 1193726 725 725 query45 203 175 175 175 query46 1074828 795 795 query47 1800172317191719 query48 367 293 287 287 query49 1188420 420 420 query50 913 437 435 435 query51 6856663566196619 query52 105 93 91 91 query53 257 178 175 175 query54 651 451 453 451 query55 79 74 98 74 query56 283 261 259 259 query57 1119104210441042 query58 283 271 259 259 query59 2600230625422306 query60 314 274 295 274 query61 94 107 94 94 query62 919 661 676 661 query63 224 181 175 175 query64 5852195718681868 query65 3165309330793079 query66 1418336 344 336 query67 15314 14842 14754 14754 query68 4365569 577 569 query69 451 292 297 292 query70 1078108510811081 query71 418 279 269 269 query72 7105266024672467 query73 815 336 335 335 query74 6068564756955647 query75 3386274127032703 query76 2516123812651238 query77 440 305 320 305 query78 9419902388768876 query79 1528533 542 533 query80 1287509 498 498 query81 586 228 224 224 query82 1007132 133 132 query83 265 170 172 170 query84 277 79 85 79 query85 1262322 298 298 query86 381 304 300 300 query87 3353308831063088 query88 2961241724322417 query89 393 291 284 284 query90 1805198 198 198 query91 124 99 100 99 query92 61 50 49 49 query93 1429628 625 625 query94 893 306 290 290 query95 379 270 267 267 query96 616 283 282 282 query97 3250304030583040 query98 230 199 202 199 query99 1613128312961283 Total cold run time: 262776 ms Total hot run time: 168324 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
Re: [PR] [chore](sql) Forbid show hidden columns and create table with hidden column [doris]
doris-robot commented on PR #38796: URL: https://github.com/apache/doris/pull/38796#issuecomment-2268415547 TPC-H: Total hot run time: 41843 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 097f5fcc32f079272adb80e034b5d419fc517301, data reload: false -- Round 1 -- q1 18160 415242814152 q2 2543208 212 208 q3 11108 128914121289 q4 11166 807 919 807 q5 7888298130152981 q6 228 139 142 139 q7 1049602 620 602 q8 9439191419331914 q9 8391659866166598 q10 8689383138433831 q11 425 252 265 252 q12 404 237 236 236 q13 17756 291929292919 q14 273 240 245 240 q15 520 477 483 477 q16 496 383 385 383 q17 956 914 900 900 q18 8034734574767345 q19 1386120612121206 q20 569 322 350 322 q21 5438477947614761 q22 349 281 292 281 Total cold run time: 115267 ms Total hot run time: 41843 ms - Round 2, with runtime_filter_mode=off - q1 4066400639973997 q2 326 221 226 221 q3 2974301129722972 q4 1895183718571837 q5 5251522552065206 q6 215 130 130 130 q7 2059169417051694 q8 3173324432443244 q9 8276823182678231 q10 3738385738313831 q11 549 473 448 448 q12 725 570 552 552 q13 14231 296529322932 q14 288 259 254 254 q15 524 482 481 481 q16 449 400 403 400 q17 1744168816831683 q18 7687732672267226 q19 1657167316581658 q20 1968176117511751 q21 5375511552065115 q22 527 463 445 445 Total cold run time: 67697 ms Total hot run time: 54308 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [test](mtmv)Add the cases of upgrade and downgrade of mtmv [doris]
doris-robot commented on PR #38868: URL: https://github.com/apache/doris/pull/38868#issuecomment-2268417861 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [test](mtmv)Add the cases of upgrade and downgrade of mtmv [doris]
zfr9527 opened a new pull request, #38868: URL: https://github.com/apache/doris/pull/38868 ## Proposed changes [test](mtmv)Add the cases of upgrade and downgrade of mtmv -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [test](mtmv)Add the cases of upgrade and downgrade of mtmv [doris]
zfr9527 commented on PR #38868: URL: https://github.com/apache/doris/pull/38868#issuecomment-2268418217 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [cdc] fix enable-delete option not work [doris-flink-connector]
vinlee19 opened a new pull request, #455: URL: https://github.com/apache/doris-flink-connector/pull/455 # Proposed changes Issue Number: close #xxx ## Problem Summary: In the previous version, when we set `enable-delete=false`, the flink-connector-doris would also synchronize this deleted data to Doris. Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behavior: (Yes/No/I Don't know) 2. Has unit tests been added: (Yes/No/No Need) 3. Has document been added or modified: (Yes/No/No Need) 4. Does it need to update dependencies: (Yes/No) 5. Are there any changes that cannot be rolled back: (Yes/No) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement](audit log) Set print audit log sesssion variable default value to false [doris]
doris-robot commented on PR #38865: URL: https://github.com/apache/doris/pull/38865#issuecomment-2268418812 TPC-DS: Total hot run time: 167790 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit b8a6a5aa9f36bde1b05a749db39d8dfb3537efc3, data reload: false query1 918 376 368 368 query2 6481168716431643 query3 6665209 224 209 query4 19421 17355 17190 17190 query5 4312509 517 509 query6 287 174 167 167 query7 4619294 300 294 query8 253 210 204 204 query9 8508237023742370 query10 437 282 258 258 query11 10579 10043 10073 10043 query12 138 88 89 88 query13 1667377 363 363 query14 9208671264656465 query15 206 158 162 158 query16 7111420 451 420 query17 925 577 530 530 query18 1920277 275 275 query19 193 143 141 141 query20 87 85 83 83 query21 202 101 97 97 query22 4153392440973924 query23 33580 33084 32999 32999 query24 10318 311730673067 query25 663 378 392 378 query26 1802145 148 145 query27 3028270 281 270 query28 7054197219591959 query29 1333408 406 406 query30 282 149 150 149 query31 917 745 763 745 query32 104 55 53 53 query33 702 318 312 312 query34 904 468 483 468 query35 811 712 750 712 query36 996 861 843 843 query37 287 76 79 76 query38 2869277627632763 query39 858 800 793 793 query40 281 112 112 112 query41 50 45 43 43 query42 121 100 101 100 query43 465 399 420 399 query44 1188737 727 727 query45 205 183 178 178 query46 1081793 785 785 query47 1824171517301715 query48 361 282 287 282 query49 1190418 407 407 query50 902 435 422 422 query51 6837669966646664 query52 98 90 92 90 query53 252 176 182 176 query54 619 445 458 445 query55 81 75 77 75 query56 272 242 249 242 query57 1156106710061006 query58 322 263 282 263 query59 2600254222572257 query60 290 272 286 272 query61 94 95 92 92 query62 912 670 693 670 query63 213 181 182 181 query64 5877189619151896 query65 3191307130783071 query66 1428332 333 332 query67 15384 14889 14819 14819 query68 4374568 593 568 query69 448 301 294 294 query70 1109102810661028 query71 413 277 271 271 query72 7064272124672467 query73 759 327 331 327 query74 6028574956865686 query75 3392273127302730 query76 2443120912821209 query77 425 318 325 318 query78 9362902989188918 query79 1133532 534 532 query80 1035586 493 493 query81 567 222 223 222 query82 1346130 129 129 query83 240 174 170 170 query84 262 84 80 80 query85 1135327 296 296 query86 342 312 295 295 query87 3303309131323091 query88 2912240824492408 query89 392 291 282 282 query90 1990193 195 193 query91 137 101 102 101 query92 65 49 54 49 query93 1246622 617 617 query94 877 293 292 292 query95 378 271 315 271 query96 592 277 281 277 query97 3189303930453039 query98 209 198 203 198 query99 1658128712811281 Total cold run time: 260917 ms Total hot run time: 167790 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th
(doris) branch branch-3.0 updated: [improve](columns)replace logFatal with exception and del some useless code in columns #38035 (#38863)
This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch branch-3.0
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-3.0 by this push:
new 1a6a3c09a86 [improve](columns)replace logFatal with exception and del
some useless code in columns #38035 (#38863)
1a6a3c09a86 is described below
commit 1a6a3c09a86c62e513f3ff60810f0ea1d6c312bf
Author: amory
AuthorDate: Mon Aug 5 15:59:48 2024 +0800
[improve](columns)replace logFatal with exception and del some useless code
in columns #38035 (#38863)
## Proposed changes
backport: https://github.com/apache/doris/pull/38035
Issue Number: close #xxx
---
be/src/common/exception.h | 23 +
be/src/olap/compaction.cpp | 27 ++
be/src/olap/schema_change.h| 4 +-
be/src/vec/columns/column.cpp | 25 -
be/src/vec/columns/column.h| 102 -
be/src/vec/columns/column_array.cpp| 36 +---
be/src/vec/columns/column_array.h | 3 +-
be/src/vec/columns/column_complex.h| 16 ++--
be/src/vec/columns/column_const.cpp| 8 +-
be/src/vec/columns/column_decimal.cpp | 4 +-
be/src/vec/columns/column_dictionary.h | 62 +
be/src/vec/columns/column_dummy.h | 23 +++--
be/src/vec/columns/column_impl.h | 5 +-
be/src/vec/columns/column_map.cpp | 29 +++---
be/src/vec/columns/column_map.h| 3 +-
be/src/vec/columns/column_nullable.cpp | 10 +-
be/src/vec/columns/column_object.cpp | 92 +++
be/src/vec/columns/column_object.h | 17
be/src/vec/columns/column_string.cpp | 3 +-
be/src/vec/columns/column_string.h | 20 +---
be/src/vec/columns/column_struct.cpp | 18 ++--
be/src/vec/columns/column_struct.h | 9 +-
be/src/vec/columns/column_vector.cpp | 4 +-
be/src/vec/columns/column_vector.h | 3 +-
be/src/vec/columns/predicate_column.h | 72 ++-
.../vec/functions/array/function_arrays_overlap.h | 1 +
.../data/nereids_p0/join/test_join_on.out | 5 +
.../suites/nereids_p0/join/test_join_on.groovy | 53 +++
28 files changed, 391 insertions(+), 286 deletions(-)
diff --git a/be/src/common/exception.h b/be/src/common/exception.h
index ce44e658749..e8b6d3567a7 100644
--- a/be/src/common/exception.h
+++ b/be/src/common/exception.h
@@ -139,3 +139,26 @@ inline const std::string& Exception::to_string() const {
}
\
}
\
} while (0);
+
+#define HANDLE_EXCEPTION_IF_CATCH_EXCEPTION(stmt, exception_handler)
\
+do {
\
+try {
\
+doris::enable_thread_catch_bad_alloc++;
\
+Defer defer {[&]() { doris::enable_thread_catch_bad_alloc--; }};
\
+{
\
+Status _status_ = (stmt);
\
+if (UNLIKELY(!_status_.ok())) {
\
+exception_handler(doris::Exception());
\
+return _status_;
\
+}
\
+}
\
+} catch (const doris::Exception& e) {
\
+exception_handler(e);
\
+if (e.code() == doris::ErrorCode::MEM_ALLOC_FAILED) {
\
+return Status::MemoryLimitExceeded(fmt::format(
\
+"PreCatch error code:{}, {}, __FILE__:{}, __LINE__:{},
__FUNCTION__:{}", \
+e.code(), e.to_string(), __FILE__, __LINE__,
__PRETTY_FUNCTION__)); \
+}
Re: [PR] [enhancement](nereids) Support eliminate outer join by match expression [doris]
doris-robot commented on PR #38537: URL: https://github.com/apache/doris/pull/38537#issuecomment-2268423073 TPC-DS: Total hot run time: 168803 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 8fff252ec2f42293b26c67adfabdc1a575b8313d, data reload: false query1 916 397 378 378 query2 6306167616411641 query3 5961231 226 226 query4 19936 17717 17505 17505 query5 4206507 512 507 query6 274 177 198 177 query7 4288296 300 296 query8 261 211 198 198 query9 8133237423772374 query10 438 270 256 256 query11 10632 999610047 9996 query12 147 90 88 88 query13 1555379 383 379 query14 9724682868046804 query15 212 168 164 164 query16 7073445 482 445 query17 964 552 545 545 query18 1910284 275 275 query19 199 144 139 139 query20 90 87 84 84 query21 216 98 103 98 query22 4234407640534053 query23 33724 32906 33065 32906 query24 9963305330853053 query25 648 382 404 382 query26 1729148 147 147 query27 2748272 275 272 query28 6495196519711965 query29 1186442 414 414 query30 283 150 152 150 query31 936 753 761 753 query32 96 53 59 53 query33 679 309 318 309 query34 887 464 484 464 query35 845 739 731 731 query36 996 883 871 871 query37 278 79 78 78 query38 2871279527432743 query39 857 792 811 792 query40 267 115 113 113 query41 46 44 45 44 query42 124 101 108 101 query43 467 408 413 408 query44 1178735 726 726 query45 206 177 176 176 query46 1085817 782 782 query47 1788170517291705 query48 361 299 290 290 query49 1144422 429 422 query50 925 433 442 433 query51 6721677766526652 query52 102 91 86 86 query53 257 183 182 182 query54 628 453 446 446 query55 78 76 77 76 query56 267 262 248 248 query57 1158104410521044 query58 307 271 280 271 query59 2577240323942394 query60 293 273 275 273 query61 97 94 96 94 query62 910 656 675 656 query63 215 181 181 181 query64 5622189619041896 query65 3189311030963096 query66 1377342 330 330 query67 15377 14741 14885 14741 query68 4199571 580 571 query69 448 297 298 297 query70 1119105410391039 query71 404 291 279 279 query72 7154270225202520 query73 782 333 324 324 query74 6067564356315631 query75 3425273527312731 query76 2404124312911243 query77 442 311 321 311 query78 9477894189068906 query79 1428541 527 527 query80 973 505 506 505 query81 578 227 227 227 query82 962 131 131 131 query83 245 180 173 173 query84 277 76 80 76 query85 1618325 302 302 query86 406 295 306 295 query87 3331309430993094 query88 2938240224212402 query89 384 288 288 288 query90 1819196 188 188 query91 126 110 114 110 query92 61 53 53 53 query93 1315628 620 620 query94 876 299 301 299 query95 391 283 277 277 query96 601 289 291 289 query97 3263301530633015 query98 229 209 205 205 query99 1677129813111298 Total cold run time: 259081 ms Total hot run time: 168803 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
Re: [PR] [function](cast)Make string casting to integers more like MySQL's behavior [doris]
doris-robot commented on PR #38847: URL: https://github.com/apache/doris/pull/38847#issuecomment-2268421135 TPC-H: Total hot run time: 41877 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 40b3054f420129832004a714247e2b3c86f697e2, data reload: false -- Round 1 -- q1 17656 419540934093 q2 2020203 200 200 q3 10452 129313801293 q4 10184 813 996 813 q5 7670299030042990 q6 221 140 142 140 q7 1071615 609 609 q8 9446196919581958 q9 8561665166386638 q10 8778390438623862 q11 435 250 259 250 q12 412 236 238 236 q13 17759 294029552940 q14 268 243 243 243 q15 523 493 493 493 q16 528 389 404 389 q17 983 949 915 915 q18 8066732471947194 q19 1913122812241224 q20 583 337 342 337 q21 5340477748064777 q22 357 283 286 283 Total cold run time: 113226 ms Total hot run time: 41877 ms - Round 2, with runtime_filter_mode=off - q1 4153405240864052 q2 335 224 216 216 q3 3010302931783029 q4 2027203519951995 q5 5591549754585458 q6 219 129 131 129 q7 2119172318551723 q8 3320339533323332 q9 8765868788378687 q10 3982409139823982 q11 558 450 448 448 q12 748 608 591 591 q13 16505 314430923092 q14 304 285 288 285 q15 542 484 492 484 q16 464 415 412 412 q17 1782174017431740 q18 8095768476867684 q19 1753172517181718 q20 2069188818781878 q21 5838555254515451 q22 526 475 472 472 Total cold run time: 72705 ms Total hot run time: 56858 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improve](columns)replace logFatal with exception and del some useless code in columns #38035 [doris]
dataroaring merged PR #38863: URL: https://github.com/apache/doris/pull/38863 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](function) Results for stddev with nan and inf are unstable. [doris]
github-actions[bot] commented on PR #38866: URL: https://github.com/apache/doris/pull/38866#issuecomment-2268421827 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](tools) tpcds-tools: report benchmark result before cleanup [doris]
doris-robot commented on PR #38864: URL: https://github.com/apache/doris/pull/38864#issuecomment-2268426011 TPC-DS: Total hot run time: 169265 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 618d4aadcf3757cc414065332d916ffc9587ceec, data reload: false query1 906 369 378 369 query2 6461163016091609 query3 6643219 237 219 query4 20328 17417 17404 17404 query5 3637509 512 509 query6 292 176 174 174 query7 4602293 295 293 query8 252 205 195 195 query9 8523236223702362 query10 467 286 262 262 query11 10567 10062 98359835 query12 122 89 89 89 query13 1622385 380 380 query14 8410688074456880 query15 225 164 161 161 query16 6968433 441 433 query17 929 571 535 535 query18 1878278 279 278 query19 187 146 142 142 query20 91 86 96 86 query21 201 100 99 99 query22 4533438841024102 query23 33869 33479 33463 33463 query24 9394313330583058 query25 675 397 384 384 query26 1305154 149 149 query27 3052275 282 275 query28 7495202019981998 query29 1020427 432 427 query30 242 147 154 147 query31 924 757 785 757 query32 107 55 59 55 query33 686 313 313 313 query34 937 491 488 488 query35 835 763 761 761 query36 1096908 890 890 query37 174 85 81 81 query38 2990288328932883 query39 879 805 814 805 query40 267 116 117 116 query41 48 46 46 46 query42 120 104 102 102 query43 483 414 416 414 query44 1169738 740 738 query45 208 186 184 184 query46 1093798 797 797 query47 1841175617611756 query48 358 328 285 285 query49 852 422 433 422 query50 889 441 428 428 query51 6804668966756675 query52 102 97 95 95 query53 265 187 178 178 query54 589 439 447 439 query55 75 72 73 72 query56 273 262 249 249 query57 1170104310511043 query58 262 268 267 267 query59 2540232723112311 query60 285 261 281 261 query61 95 95 92 92 query62 871 652 661 652 query63 209 182 184 182 query64 4832190718741874 query65 3153306930603060 query66 968 327 341 327 query67 15197 14920 14915 14915 query68 4534573 585 573 query69 594 410 313 313 query70 1077103410551034 query71 382 289 285 285 query72 7156271724742474 query73 775 325 326 325 query74 6019565556975655 query75 3320272926792679 query76 2166124412731244 query77 567 324 305 305 query78 9476896387688768 query79 1882536 534 534 query80 1275513 511 511 query81 555 228 223 223 query82 1027131 127 127 query83 251 174 166 166 query84 256 76 77 76 query85 1138311 296 296 query86 458 320 301 301 query87 3289309030843084 query88 2889236924162369 query89 380 291 294 291 query90 1655188 189 188 query91 128 100 102 100 query92 58 53 50 50 query93 1674624 624 624 query94 797 299 282 282 query95 376 259 262 259 query96 617 276 274 274 query97 3259304730973047 query98 220 198 192 192 query99 1622128612931286 Total cold run time: 258414 ms Total hot run time: 169265 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
Re: [PR] [Feature](Cloud) Support session variable disable_file_cache and enable_segment_cache in query [doris]
doris-robot commented on PR #37141: URL: https://github.com/apache/doris/pull/37141#issuecomment-2268425037 ClickBench: Total hot run time: 30.89 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 2a115b417d19ed33bc472b581160c9476bd9137d, data reload: false query1 0.040.040.04 query2 0.080.040.04 query3 0.230.050.04 query4 1.690.060.07 query5 0.490.470.49 query6 1.150.720.71 query7 0.020.010.01 query8 0.060.040.04 query9 0.560.500.51 query10 0.540.570.55 query11 0.160.120.12 query12 0.150.120.12 query13 0.620.610.59 query14 0.780.820.78 query15 0.910.870.86 query16 0.360.360.35 query17 1.001.011.01 query18 0.230.220.21 query19 1.841.721.70 query20 0.020.010.01 query21 15.42 0.760.67 query22 3.916.572.28 query23 18.11 1.291.28 query24 2.310.230.22 query25 0.180.080.08 query26 0.320.210.22 query27 0.460.230.22 query28 13.18 1.000.97 query29 12.55 3.313.30 query30 0.260.060.05 query31 2.870.400.40 query32 3.240.490.48 query33 2.942.933.02 query34 15.67 4.274.23 query35 4.294.294.31 query36 0.680.480.48 query37 0.190.170.16 query38 0.160.150.15 query39 0.040.040.03 query40 0.170.140.13 query41 0.090.040.05 query42 0.050.040.05 query43 0.050.040.04 Total cold run time: 108.07 s Total hot run time: 30.89 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [branch-2.1] (doris-future) Support auto partition name function [doris]
yiguolei merged PR #38853: URL: https://github.com/apache/doris/pull/38853 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](optimizer) Remove unused code [doris]
doris-robot commented on PR #38862: URL: https://github.com/apache/doris/pull/38862#issuecomment-2268428829 TPC-DS: Total hot run time: 204118 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 61abb2cd1fe80d05c8b772873459d673fc0065ec, data reload: false query1 996 385 403 385 query2 6524280726472647 query3 6926208 206 206 query4 19959 18100 18206 18100 query5 19743 653065746530 query6 291 221 230 221 query7 4155308 305 305 query8 451 400 417 400 query9 3098264325622562 query10 436 302 299 299 query11 11323 10679 10780 10679 query12 124 78 76 76 query13 5599708 692 692 query14 17743 13150 13624 13150 query15 369 247 247 247 query16 6446282 268 268 query17 17091457881 881 query18 2301425 413 413 query19 205 146 148 146 query20 79 83 80 80 query21 185 100 92 92 query22 5316516850085008 query23 32742 31796 31859 31796 query24 6908657464786478 query25 527 434 427 427 query26 526 168 160 160 query27 1860294 289 289 query28 6107235323292329 query29 2896277628602776 query30 244 167 167 167 query31 938 746 743 743 query32 69 65 63 63 query33 409 265 269 265 query34 857 479 477 477 query35 1113921 937 921 query36 1346109011021090 query37 101 59 64 59 query38 3067292829672928 query39 1383132713451327 query40 212 95 94 94 query41 46 45 44 44 query42 82 81 90 81 query43 697 718 604 604 query44 1135722 724 722 query45 249 234 237 234 query46 1229980 973 973 query47 1797171417741714 query48 1025732 714 714 query49 626 376 375 375 query50 876 628 577 577 query51 4707465546214621 query52 99 83 82 82 query53 451 323 318 318 query54 2675247024592459 query55 95 77 91 77 query56 241 217 206 206 query57 1218106310441044 query58 221 198 198 198 query59 4051391238723872 query60 214 227 197 197 query61 102 96 98 96 query62 821 504 495 495 query63 496 344 342 342 query64 2409155615111511 query65 3623360035753575 query66 836 383 396 383 query67 15628 16035 16521 16035 query68 9614705 690 690 query69 572 358 352 352 query70 1708140215321402 query71 416 314 318 314 query72 6558350035043500 query73 745 315 313 313 query74 6336584958515849 query75 5464369036923690 query76 6219116311901163 query77 1029246 259 246 query78 12487 11940 11613 11613 query79 9517639 644 639 query80 1300396 405 396 query81 487 232 232 232 query82 1437101 101 101 query83 168 132 135 132 query84 264 71 72 71 query85 881 333 346 333 query86 328 293 291 291 query87 3275300330143003 query88 4761229222852285 query89 464 304 275 275 query90 2002199 209 199 query91 191 141 153 141 query92 57 53 57 53 query93 6655579 605 579 query94 684 208 203 203 query95 1096104210431042 query96 646 323 313 313 query97 6449639663376337 query98 184 173 168 168 query99 3061915 868 868 Total cold run time: 315987 ms Total hot run time: 204118 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go
Re: [PR] [fix](clone) fix stale tablet report miss the new cloning replica #38695 [doris]
yujun777 commented on PR #38839: URL: https://github.com/apache/doris/pull/38839#issuecomment-2268429470 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch branch-2.1 updated: [branch-2.1] (doris-future) Support auto partition name function (#38853)
This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-2.1 by this push:
new 65154f8abee [branch-2.1] (doris-future) Support auto partition name
function (#38853)
65154f8abee is described below
commit 65154f8abeeb3ba99e3ae2dfe20aefa0efe2175c
Author: Uniqueyou <134280716+wyxxx...@users.noreply.github.com>
AuthorDate: Mon Aug 5 16:04:24 2024 +0800
[branch-2.1] (doris-future) Support auto partition name function (#38853)
cherry-pick https://github.com/apache/doris/pull/34258 to branch-2.1
---
be/src/vec/functions/function_string.cpp | 1 +
be/src/vec/functions/function_string.h | 215 +
.../doris/catalog/BuiltinScalarFunctions.java | 2 +
.../functions/scalar/AutoPartitionName.java| 105 ++
.../expressions/visitor/ScalarFunctionVisitor.java | 5 +
gensrc/script/doris_builtins_functions.py | 2 +
.../data/nereids_function_p0/scalar_function/A.out | 129 +
.../nereids_function_p0/scalar_function/A.groovy | 72 +++
8 files changed, 531 insertions(+)
diff --git a/be/src/vec/functions/function_string.cpp
b/be/src/vec/functions/function_string.cpp
index cf82970185e..673889a33e5 100644
--- a/be/src/vec/functions/function_string.cpp
+++ b/be/src/vec/functions/function_string.cpp
@@ -1120,6 +1120,7 @@ void register_function_string(SimpleFunctionFactory&
factory) {
factory.register_function();
factory.register_function();
factory.register_function();
+factory.register_function();
factory.register_function();
factory.register_function();
factory.register_function();
diff --git a/be/src/vec/functions/function_string.h
b/be/src/vec/functions/function_string.h
index df15bc600ec..9fc8e8702d7 100644
--- a/be/src/vec/functions/function_string.h
+++ b/be/src/vec/functions/function_string.h
@@ -26,6 +26,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -33,6 +34,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -68,6 +70,7 @@
#include "vec/core/field.h"
#include "vec/core/types.h"
#include "vec/data_types/data_type.h"
+#include "vec/functions/function_binary_arithmetic.h"
#include "vec/functions/round.h"
#include "vec/io/io_helper.h"
@@ -527,6 +530,218 @@ private:
}
};
+class FunctionAutoPartitionName : public IFunction {
+public:
+static constexpr auto name = "auto_partition_name";
+static FunctionPtr create() { return
std::make_shared(); }
+String get_name() const override { return name; }
+size_t get_number_of_arguments() const override { return 0; }
+bool is_variadic() const override { return true; }
+
+DataTypePtr get_return_type_impl(const DataTypes& arguments) const
override {
+return std::make_shared();
+}
+
+Status execute_impl(FunctionContext* context, Block& block, const
ColumnNumbers& arguments,
+size_t result, size_t input_rows_count) const override
{
+size_t argument_size = arguments.size();
+if (argument_size < 2) {
+return Status::InvalidArgument(
+"auto_partition_name must contains at least two
arguments");
+}
+std::vector chars_list(argument_size);
+std::vector offsets_list(argument_size);
+std::vector is_const_args(argument_size);
+
+for (int i = 0; i < argument_size; ++i) {
+const auto& [col, is_const] =
+
unpack_if_const(block.get_by_position(arguments[i]).column);
+
+const auto* col_str = assert_cast(col.get());
+chars_list[i] = &col_str->get_chars();
+offsets_list[i] = &col_str->get_offsets();
+is_const_args[i] = is_const;
+}
+auto res = ColumnString::create();
+auto& res_data = res->get_chars();
+auto& res_offset = res->get_offsets();
+res_offset.resize(input_rows_count);
+
+const char* partition_type = chars_list[0]->raw_data();
+// partition type is list|range
+if (std::strncmp(partition_type, "list", 4) == 0) {
+return _auto_partition_type_of_list(chars_list, offsets_list,
is_const_args, res_data,
+res_offset, input_rows_count,
argument_size, block,
+result, res);
+} else {
+return _auto_partition_type_of_range(chars_list, offsets_list,
is_const_args, res_data,
+ res_offset, input_rows_count,
argument_size, block,
+ result, res);
+}
+return Status::OK();
+}
+
+private:
+std::u16string _string_to_u16string(const std::string& str) const {
+
Re: [PR] [Enhancement](audit log) Set print audit log sesssion variable default value to false [doris]
doris-robot commented on PR #38865: URL: https://github.com/apache/doris/pull/38865#issuecomment-2268429414 ClickBench: Total hot run time: 30.07 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit b8a6a5aa9f36bde1b05a749db39d8dfb3537efc3, data reload: false query1 0.050.040.04 query2 0.070.040.04 query3 0.230.040.05 query4 1.680.060.06 query5 0.480.470.48 query6 1.150.710.72 query7 0.020.010.01 query8 0.050.050.04 query9 0.560.510.52 query10 0.570.570.58 query11 0.160.110.11 query12 0.150.130.12 query13 0.610.610.60 query14 0.760.780.79 query15 0.910.870.88 query16 0.350.370.36 query17 1.051.021.02 query18 0.230.230.22 query19 1.871.721.76 query20 0.010.010.01 query21 15.40 0.750.66 query22 4.167.311.36 query23 17.92 1.421.36 query24 2.290.220.22 query25 0.190.080.07 query26 0.330.220.22 query27 0.460.240.22 query28 13.16 0.990.97 query29 12.52 3.283.26 query30 0.260.060.06 query31 2.860.410.40 query32 3.250.500.49 query33 2.912.972.89 query34 15.44 4.274.24 query35 4.294.294.30 query36 0.690.470.48 query37 0.190.170.16 query38 0.170.150.15 query39 0.040.040.03 query40 0.160.120.14 query41 0.090.050.04 query42 0.060.050.05 query43 0.050.040.04 Total cold run time: 107.85 s Total hot run time: 30.07 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [enhancement]use awaitility.await() in schema testcases #37817 [doris]
Vallishp opened a new pull request, #38869: URL: https://github.com/apache/doris/pull/38869 ## Proposed changes Issue Number: close #xxx use awaitility.await() in schema testcases(part2) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [pick](nestedtype)support nested type with agg replace_if_not_null [doris]
doris-robot commented on PR #38716: URL: https://github.com/apache/doris/pull/38716#issuecomment-2268431074 TPC-H: Total hot run time: 50042 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit a1aed4f988fe29887fc21424e07c8e0b843bccd0, data reload: false -- Round 1 -- q1 17663 446843854385 q2 2089162 146 146 q3 10458 194019751940 q4 10232 125113141251 q5 8604385039643850 q6 234 124 146 124 q7 2065160416121604 q8 9299274727282728 q9 10780 10464 10239 10239 q10 8656352035193519 q11 418 254 246 246 q12 472 298 299 298 q13 18380 397240443972 q14 355 340 338 338 q15 523 451 459 451 q16 682 580 580 580 q17 1134935 965 935 q18 7289688870426888 q19 1784168316731673 q20 574 312 310 310 q21 4491415941294129 q22 532 436 445 436 Total cold run time: 116714 ms Total hot run time: 50042 ms - Round 2, with runtime_filter_mode=off - q1 4326431043824310 q2 328 226 224 224 q3 4202412841484128 q4 2759276127912761 q5 7235714671657146 q6 241 120 123 120 q7 3242287329002873 q8 4365445545194455 q9 16880 16793 16764 16764 q10 4243425243114252 q11 760 683 678 678 q12 1057857 838 838 q13 6935373039303730 q14 453 432 422 422 q15 501 471 455 455 q16 747 689 694 689 q17 3815380438533804 q18 8769881387838783 q19 1733172916731673 q20 2363216221632162 q21 8506848085468480 q22 1074961 966 961 Total cold run time: 84534 ms Total hot run time: 79708 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement]use awaitility.await() in schema testcases #37817 [doris]
doris-robot commented on PR #38869: URL: https://github.com/apache/doris/pull/38869#issuecomment-226843 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] add information_schema.table_properties #38745 [doris]
wangbo commented on code in PR #38746:
URL: https://github.com/apache/doris/pull/38746#discussion_r1703706188
##
regression-test/suites/query_p0/system/test_table_options.groovy:
##
@@ -185,5 +178,32 @@ suite("test_table_options") {
"""
qt_select """select * from information_schema.table_options where
table_schema=\"${dbName}\" order by TABLE_NAME; """
-sql "drop database if exists ${dbName}"
+sql """
+drop table test_row_column_page_size2;
+"""
+qt_select """select * from information_schema.table_options where
table_schema=\"${dbName}\" order by TABLE_NAME; """
+
+def user = "table_options_user"
+sql "DROP USER IF EXISTS ${user}"
+sql "CREATE USER ${user} IDENTIFIED BY '123abc!@#'"
+sql "GRANT SELECT_PRIV ON information_schema.table_properties TO ${user}"
+
+def tokens = context.config.jdbcUrl.split('/')
+def url=tokens[0] + "//" + tokens[2] + "/" + "information_schema" + "?"
+
+connect(user=user, password='123abc!@#', url=url) {
+ qt_select """select * from information_schema.table_options ORDER BY
TABLE_NAME ASC; """
Review Comment:
For easy for reviwer to check every qt's output, better to change as follow:
1 rename ```qt_select``` to ```qt_select_check_1```,```qt_select_check_2```
and ```qt_select_check_3``` .
2 gant one table's priv intead of DB priv, so the output is less and can be
reviewed manually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](nereids) Support eliminate outer join by match expression [doris]
doris-robot commented on PR #38537: URL: https://github.com/apache/doris/pull/38537#issuecomment-2268433654 ClickBench: Total hot run time: 29.88 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 8fff252ec2f42293b26c67adfabdc1a575b8313d, data reload: false query1 0.050.040.04 query2 0.070.030.04 query3 0.220.050.05 query4 1.680.070.07 query5 0.480.480.50 query6 1.150.730.71 query7 0.020.020.01 query8 0.060.040.05 query9 0.570.510.52 query10 0.560.560.56 query11 0.160.110.12 query12 0.150.130.13 query13 0.630.630.61 query14 0.770.800.79 query15 0.900.870.86 query16 0.360.360.35 query17 1.001.001.00 query18 0.210.210.22 query19 1.871.791.74 query20 0.010.010.00 query21 15.40 0.760.66 query22 4.038.091.15 query23 17.84 1.331.37 query24 2.240.220.21 query25 0.190.070.07 query26 0.320.220.21 query27 0.460.230.23 query28 13.18 1.010.98 query29 12.59 3.313.26 query30 0.250.060.06 query31 2.870.420.41 query32 3.250.490.48 query33 2.913.002.95 query34 15.43 4.244.22 query35 4.284.294.30 query36 0.680.480.49 query37 0.190.160.16 query38 0.160.150.14 query39 0.040.030.04 query40 0.160.130.14 query41 0.090.050.05 query42 0.070.040.04 query43 0.040.040.04 Total cold run time: 107.59 s Total hot run time: 29.88 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [opt](inverted index) Optimization of the initialization process in topn [doris]
zzzxl1993 opened a new pull request, #38870: URL: https://github.com/apache/doris/pull/38870 1. reduce the performance cost of initialization pick https://github.com/apache/doris/pull/37722 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] add information_schema.table_properties #38745 [doris]
wangbo commented on code in PR #38746:
URL: https://github.com/apache/doris/pull/38746#discussion_r1703707073
##
regression-test/suites/query_p0/system/test_table_options.groovy:
##
@@ -185,5 +178,32 @@ suite("test_table_options") {
"""
qt_select """select * from information_schema.table_options where
table_schema=\"${dbName}\" order by TABLE_NAME; """
-sql "drop database if exists ${dbName}"
+sql """
+drop table test_row_column_page_size2;
+"""
+qt_select """select * from information_schema.table_options where
table_schema=\"${dbName}\" order by TABLE_NAME; """
+
+def user = "table_options_user"
+sql "DROP USER IF EXISTS ${user}"
+sql "CREATE USER ${user} IDENTIFIED BY '123abc!@#'"
+sql "GRANT SELECT_PRIV ON information_schema.table_properties TO ${user}"
+
+def tokens = context.config.jdbcUrl.split('/')
+def url=tokens[0] + "//" + tokens[2] + "/" + "information_schema" + "?"
Review Comment:
connect(user = 'test_wg_priv_user2', password = '', url =
context.config.jdbcUrl) {
qt_select "xxx"
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](inverted index) Optimization of the initialization process in topn [doris]
doris-robot commented on PR #38870: URL: https://github.com/apache/doris/pull/38870#issuecomment-2268433976 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](inverted index) Optimization of the initialization process in topn [doris]
zzzxl1993 commented on PR #38870: URL: https://github.com/apache/doris/pull/38870#issuecomment-2268434307 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch branch-2.1 updated (65154f8abee -> bb962a82915)
This is an automated email from the ASF dual-hosted git repository. gabriellee pushed a change to branch branch-2.1 in repository https://gitbox.apache.org/repos/asf/doris.git from 65154f8abee [branch-2.1] (doris-future) Support auto partition name function (#38853) add bb962a82915 [minor](fix) Fix incorrect fmt arguments (#38840) (#38861) No new revisions were added by this update. Summary of changes: be/src/pipeline/pipeline_x/local_exchange/local_exchanger.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [minor](fix) Fix incorrect fmt arguments (#38840) [doris]
Gabriel39 merged PR #38861: URL: https://github.com/apache/doris/pull/38861 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](sql) Forbid show hidden columns and create table with hidden column [doris]
doris-robot commented on PR #38796: URL: https://github.com/apache/doris/pull/38796#issuecomment-2268435872 TPC-DS: Total hot run time: 167550 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 097f5fcc32f079272adb80e034b5d419fc517301, data reload: false query1 897 381 367 367 query2 6463166916721669 query3 6659213 227 213 query4 19367 17337 17097 17097 query5 4305516 517 516 query6 277 181 173 173 query7 4604297 289 289 query8 254 217 200 200 query9 8533239023932390 query10 428 286 270 270 query11 10418 10070 10048 10048 query12 142 90 86 86 query13 1639377 377 377 query14 612767186127 query15 201 171 167 167 query16 7242449 466 449 query17 987 568 557 557 query18 1909293 286 286 query19 199 149 154 149 query20 93 93 87 87 query21 202 99 99 99 query22 4357409540924092 query23 33776 33187 32926 32926 query24 10434 311330463046 query25 709 396 403 396 query26 1788156 153 153 query27 2984282 286 282 query28 6946199419661966 query29 1294425 431 425 query30 287 151 157 151 query31 966 748 759 748 query32 109 60 57 57 query33 783 311 315 311 query34 959 481 481 481 query35 878 752 723 723 query36 1002870 877 870 query37 287 82 80 80 query38 2861277127722771 query39 880 797 816 797 query40 286 122 110 110 query41 46 46 44 44 query42 131 99 104 99 query43 486 409 438 409 query44 1201744 726 726 query45 210 182 177 177 query46 1147836 794 794 query47 1799168216971682 query48 360 291 294 291 query49 1192443 427 427 query50 985 444 445 444 query51 6883664467316644 query52 109 92 92 92 query53 267 190 183 183 query54 638 450 453 450 query55 77 79 78 78 query56 302 260 264 260 query57 1150102910441029 query58 292 289 270 270 query59 2558241422242224 query60 310 271 278 271 query61 122 91 94 91 query62 926 655 684 655 query63 220 195 193 193 query64 5839191518801880 query65 3218311130933093 query66 1454335 348 335 query67 15219 14912 14685 14685 query68 4436571 610 571 query69 458 303 296 296 query70 1118102011541020 query71 405 283 291 283 query72 7137272124752475 query73 817 332 327 327 query74 5970561956165616 query75 3454273727302730 query76 2531130414111304 query77 463 335 320 320 query78 9494891588058805 query79 2282537 527 527 query80 1011535 505 505 query81 566 230 233 230 query82 801 130 133 130 query83 259 178 165 165 query84 276 82 77 77 query85 1706308 291 291 query86 496 313 311 311 query87 3269309630553055 query88 3886241324092409 query89 392 294 281 281 query90 1891193 200 193 query91 126 101 103 101 query92 62 54 54 54 query93 2277623 624 623 query94 917 324 295 295 query95 377 258 264 258 query96 659 283 276 276 query97 3219307430283028 query98 217 199 195 195 query99 1733127213021272 Total cold run time: 266250 ms Total hot run time: 167550 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
Re: [PR] [fix](tools) tpcds-tools: report benchmark result before cleanup [doris]
doris-robot commented on PR #38864: URL: https://github.com/apache/doris/pull/38864#issuecomment-2268436517 ClickBench: Total hot run time: 29.96 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 618d4aadcf3757cc414065332d916ffc9587ceec, data reload: false query1 0.050.050.04 query2 0.070.040.04 query3 0.220.040.04 query4 1.680.060.06 query5 0.480.490.49 query6 1.130.710.72 query7 0.020.010.02 query8 0.050.040.04 query9 0.580.520.52 query10 0.560.560.55 query11 0.160.120.12 query12 0.150.130.13 query13 0.600.600.59 query14 0.770.790.79 query15 0.930.880.85 query16 0.350.370.36 query17 0.970.991.03 query18 0.220.220.21 query19 1.791.721.76 query20 0.020.010.01 query21 15.41 0.760.66 query22 4.057.361.38 query23 18.16 1.381.34 query24 2.280.220.21 query25 0.180.070.08 query26 0.320.210.21 query27 0.460.230.22 query28 13.22 1.000.97 query29 12.51 3.303.23 query30 0.260.060.05 query31 2.850.400.39 query32 3.270.490.47 query33 2.922.923.00 query34 15.43 4.244.25 query35 4.274.294.27 query36 0.680.480.49 query37 0.200.160.16 query38 0.160.140.15 query39 0.030.030.04 query40 0.170.150.13 query41 0.100.040.04 query42 0.050.050.05 query43 0.050.050.03 Total cold run time: 107.83 s Total hot run time: 29.96 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](optimizer) Remove unused code [doris]
doris-robot commented on PR #38862: URL: https://github.com/apache/doris/pull/38862#issuecomment-2268439188 ClickBench: Total hot run time: 30.66 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 61abb2cd1fe80d05c8b772873459d673fc0065ec, data reload: false query1 0.020.030.02 query2 0.080.020.02 query3 0.250.050.05 query4 1.790.070.06 query5 0.530.530.52 query6 1.230.610.62 query7 0.020.010.00 query8 0.040.030.02 query9 0.510.480.48 query10 0.540.540.54 query11 0.120.090.09 query12 0.120.090.10 query13 0.620.610.61 query14 0.780.810.78 query15 0.770.760.77 query16 0.370.370.36 query17 1.010.991.04 query18 0.250.240.24 query19 1.941.881.80 query20 0.020.010.01 query21 15.49 0.540.54 query22 1.911.901.32 query23 16.74 0.931.06 query24 4.261.251.36 query25 0.410.070.04 query26 0.530.150.17 query27 0.050.040.04 query28 8.240.710.72 query29 12.64 2.322.36 query30 0.610.540.53 query31 2.800.390.39 query32 3.360.490.49 query33 3.103.073.06 query34 15.29 4.764.78 query35 4.864.864.83 query36 1.081.011.02 query37 0.060.040.05 query38 0.040.020.02 query39 0.020.020.01 query40 0.160.140.14 query41 0.070.020.01 query42 0.020.020.01 query43 0.030.010.01 Total cold run time: 102.78 s Total hot run time: 30.66 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [fix](nereids)support group_concat with distinct and order by [doris]
starocean999 opened a new pull request, #38871: URL: https://github.com/apache/doris/pull/38871 ## Proposed changes pick from master https://github.com/apache/doris/pull/38080 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](nereids)support group_concat with distinct and order by [doris]
doris-robot commented on PR #38871: URL: https://github.com/apache/doris/pull/38871#issuecomment-2268440859 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](nereids)support group_concat with distinct and order by [doris]
starocean999 commented on PR #38871: URL: https://github.com/apache/doris/pull/38871#issuecomment-2268440994 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [function](cast)Make string casting to integers more like MySQL's behavior [doris]
doris-robot commented on PR #38847: URL: https://github.com/apache/doris/pull/38847#issuecomment-2268441657 TPC-DS: Total hot run time: 169226 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 40b3054f420129832004a714247e2b3c86f697e2, data reload: false query1 918 371 374 371 query2 6456175416981698 query3 6653221 234 221 query4 20193 17408 17375 17375 query5 3667503 538 503 query6 297 178 169 169 query7 4591300 302 300 query8 261 203 227 203 query9 8503238923702370 query10 436 280 263 263 query11 10567 10092 10092 10092 query12 124 90 95 90 query13 1628385 388 385 query14 9360630962566256 query15 196 166 171 166 query16 6980437 467 437 query17 941 554 541 541 query18 1918278 289 278 query19 186 147 162 147 query20 98 84 84 84 query21 204 102 98 98 query22 4196403341294033 query23 33725 33561 33589 33561 query24 10035 309230913091 query25 682 407 438 407 query26 1720157 149 149 query27 2954284 276 276 query28 7407204120492041 query29 1321452 449 449 query30 246 152 152 152 query31 960 768 754 754 query32 107 56 56 56 query33 671 312 317 312 query34 934 502 502 502 query35 871 797 747 747 query36 1050935 922 922 query37 208 78 81 78 query38 3043287728672867 query39 919 865 854 854 query40 255 116 109 109 query41 47 45 42 42 query42 112 106 98 98 query43 470 435 419 419 query44 1193742 735 735 query45 212 174 175 174 query46 1090798 811 798 query47 1799173117111711 query48 360 295 288 288 query49 957 418 418 418 query50 896 434 444 434 query51 6813661466986614 query52 108 87 88 87 query53 252 183 183 183 query54 634 451 447 447 query55 80 77 78 77 query56 278 252 256 252 query57 1120104210601042 query58 271 264 293 264 query59 2689248624612461 query60 295 270 277 270 query61 95 93 96 93 query62 898 675 665 665 query63 221 183 178 178 query64 5591193618841884 query65 3138309831083098 query66 1314327 337 327 query67 15263 14924 14793 14793 query68 4299581 584 581 query69 431 300 309 300 query70 1101105311031053 query71 411 288 272 272 query72 7023272524992499 query73 768 324 337 324 query74 6019567455895589 query75 3371269727152697 query76 2301120712971207 query77 423 302 305 302 query78 9381896988468846 query79 1326541 538 538 query80 961 563 498 498 query81 553 229 237 229 query82 1062131 130 130 query83 240 177 170 170 query84 270 82 77 77 query85 1196311 291 291 query86 398 289 302 289 query87 3302308031223080 query88 2922240023872387 query89 392 284 301 284 query90 1720191 192 191 query91 122 106 104 104 query92 59 49 52 49 query93 1416629 627 627 query94 783 302 315 302 query95 384 268 276 268 query96 601 284 288 284 query97 3298302730893027 query98 210 207 195 195 query99 1626130712771277 Total cold run time: 260046 ms Total hot run time: 169226 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
Re: [PR] [feature](inverted index) String type inverted index match function c… [doris]
zzzxl1993 commented on PR #38872: URL: https://github.com/apache/doris/pull/38872#issuecomment-2268445011 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [cdc] fix enable-delete option not work [doris-flink-connector]
DongLiang-0 commented on code in PR #455:
URL:
https://github.com/apache/doris-flink-connector/pull/455#discussion_r1703713675
##
flink-doris-connector/src/main/java/org/apache/doris/flink/sink/writer/serializer/jsondebezium/JsonDebeziumChangeContext.java:
##
@@ -116,6 +119,10 @@ public String getTargetTableSuffix() {
return targetTableSuffix;
}
+public boolean isEnableDelete() {
Review Comment:
```suggestion
public boolean enableDelete() {
```
##
flink-doris-connector/src/main/java/org/apache/doris/flink/sink/writer/serializer/JsonDebeziumSchemaSerializer.java:
##
@@ -111,6 +112,7 @@ public JsonDebeziumSchemaSerializer(
.getStreamLoadProp()
.getProperty(LINE_DELIMITER_KEY,
LINE_DELIMITER_DEFAULT);
this.ignoreUpdateBefore = executionOptions.getIgnoreUpdateBefore();
+this.enableDelete = executionOptions.getDeletable();
Review Comment:
When this parameter is not set, the default is false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [feature](inverted index) String type inverted index match function c… [doris]
zzzxl1993 opened a new pull request, #38872: URL: https://github.com/apache/doris/pull/38872 https://github.com/apache/doris/pull/38170 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](inverted index) String type inverted index match function c… [doris]
doris-robot commented on PR #38872: URL: https://github.com/apache/doris/pull/38872#issuecomment-2268444909 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](optimizer) Remove unused code [doris]
doris-robot commented on PR #38862: URL: https://github.com/apache/doris/pull/38862#issuecomment-2268445462 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit 61abb2cd1fe80d05c8b772873459d673fc0065ec with default session variables Stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s Stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s Insert into select: 21.2 seconds inserted 1000 Rows, about 471K ops/s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](sql) Forbid show hidden columns and create table with hidden column [doris]
doris-robot commented on PR #38796: URL: https://github.com/apache/doris/pull/38796#issuecomment-2268446598 ClickBench: Total hot run time: 30.16 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 097f5fcc32f079272adb80e034b5d419fc517301, data reload: false query1 0.050.040.04 query2 0.080.050.04 query3 0.220.040.05 query4 1.680.090.07 query5 0.490.480.48 query6 1.130.710.71 query7 0.020.010.02 query8 0.050.040.04 query9 0.590.520.52 query10 0.560.560.57 query11 0.150.110.11 query12 0.150.120.13 query13 0.620.600.60 query14 0.760.830.79 query15 0.890.860.87 query16 0.340.340.37 query17 1.000.991.00 query18 0.220.220.22 query19 1.841.751.70 query20 0.010.010.01 query21 15.40 0.760.66 query22 3.898.601.50 query23 18.08 1.331.31 query24 2.260.220.22 query25 0.190.090.08 query26 0.310.220.22 query27 0.450.240.22 query28 13.16 1.000.97 query29 12.63 3.313.27 query30 0.260.060.05 query31 2.880.410.40 query32 3.240.500.48 query33 2.892.992.97 query34 15.45 4.244.24 query35 4.304.274.30 query36 0.670.490.47 query37 0.180.160.15 query38 0.160.160.14 query39 0.040.030.04 query40 0.150.130.13 query41 0.100.050.05 query42 0.060.040.04 query43 0.040.040.04 Total cold run time: 107.64 s Total hot run time: 30.16 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](function) Results for stddev with nan and inf are unstable. [doris]
doris-robot commented on PR #38866: URL: https://github.com/apache/doris/pull/38866#issuecomment-2268448432 TPC-H: Total hot run time: 41631 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 192a5baab99ef2fc98a11f57ef60ef39b9cb1fa7, data reload: false -- Round 1 -- q1 18393 428941594159 q2 2526209 217 209 q3 12399 131813271318 q4 11139 885 989 885 q5 7980289929462899 q6 221 140 144 140 q7 1031620 621 620 q8 9448175519461755 q9 8428652965906529 q10 8717380637963796 q11 426 265 263 263 q12 430 239 234 234 q13 17759 295629522952 q14 273 243 249 243 q15 533 489 493 489 q16 496 412 396 396 q17 951 938 905 905 q18 7965727672627262 q19 1445121212111211 q20 559 318 321 318 q21 5400476147844761 q22 352 287 290 287 Total cold run time: 116871 ms Total hot run time: 41631 ms - Round 2, with runtime_filter_mode=off - q1 4129400940374009 q2 326 224 229 224 q3 2979302029722972 q4 1882189318561856 q5 5235520752155207 q6 215 131 140 131 q7 2040171216921692 q8 3174325632523252 q9 8273822482088208 q10 3719383238183818 q11 559 457 468 457 q12 726 549 546 546 q13 9398297429672967 q14 287 256 251 251 q15 517 477 471 471 q16 466 398 397 397 q17 1711167016831670 q18 7688742271607160 q19 1653167016621662 q20 1968174417611744 q21 5411518051375137 q22 521 480 469 469 Total cold run time: 62877 ms Total hot run time: 54300 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [cdc] fix enable-delete option not work [doris-flink-connector]
DongLiang-0 commented on code in PR #455: URL: https://github.com/apache/doris-flink-connector/pull/455#discussion_r1703713712 ## flink-doris-connector/src/main/java/org/apache/doris/flink/sink/writer/serializer/JsonDebeziumSchemaSerializer.java: ## @@ -111,6 +112,7 @@ public JsonDebeziumSchemaSerializer( .getStreamLoadProp() .getProperty(LINE_DELIMITER_KEY, LINE_DELIMITER_DEFAULT); this.ignoreUpdateBefore = executionOptions.getIgnoreUpdateBefore(); +this.enableDelete = executionOptions.getDeletable(); Review Comment: When this parameter is not set, the default is false. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](inverted index) Optimization of the initialization process in topn [doris]
github-actions[bot] commented on PR #38870: URL: https://github.com/apache/doris/pull/38870#issuecomment-2268449217 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [function](cast)Make string casting to integers more like MySQL's behavior [doris]
doris-robot commented on PR #38847: URL: https://github.com/apache/doris/pull/38847#issuecomment-2268452019 ClickBench: Total hot run time: 30.48 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 40b3054f420129832004a714247e2b3c86f697e2, data reload: false query1 0.050.050.04 query2 0.070.040.04 query3 0.220.040.05 query4 1.670.070.08 query5 0.490.490.48 query6 1.140.720.72 query7 0.020.010.02 query8 0.050.040.04 query9 0.560.500.52 query10 0.580.560.58 query11 0.160.120.11 query12 0.140.120.13 query13 0.630.610.60 query14 0.780.800.79 query15 0.900.870.88 query16 0.350.350.36 query17 0.981.021.02 query18 0.220.200.21 query19 1.821.761.72 query20 0.010.010.02 query21 15.40 0.760.66 query22 3.996.751.65 query23 18.20 1.371.40 query24 2.270.230.21 query25 0.190.080.08 query26 0.310.210.21 query27 0.460.230.23 query28 13.17 1.000.97 query29 12.56 3.303.30 query30 0.260.060.05 query31 2.860.410.42 query32 3.220.480.48 query33 2.992.922.92 query34 15.46 4.274.25 query35 4.284.334.32 query36 0.680.480.49 query37 0.190.160.16 query38 0.160.160.14 query39 0.040.040.04 query40 0.160.130.14 query41 0.100.040.04 query42 0.060.050.05 query43 0.040.040.04 Total cold run time: 107.89 s Total hot run time: 30.48 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] add information_schema.table_properties #38745 [doris]
Vallishp commented on code in PR #38746:
URL: https://github.com/apache/doris/pull/38746#discussion_r1703719129
##
regression-test/suites/query_p0/system/test_table_options.groovy:
##
@@ -185,5 +178,32 @@ suite("test_table_options") {
"""
qt_select """select * from information_schema.table_options where
table_schema=\"${dbName}\" order by TABLE_NAME; """
-sql "drop database if exists ${dbName}"
+sql """
+drop table test_row_column_page_size2;
+"""
+qt_select """select * from information_schema.table_options where
table_schema=\"${dbName}\" order by TABLE_NAME; """
+
+def user = "table_options_user"
+sql "DROP USER IF EXISTS ${user}"
+sql "CREATE USER ${user} IDENTIFIED BY '123abc!@#'"
+sql "GRANT SELECT_PRIV ON information_schema.table_properties TO ${user}"
+
+def tokens = context.config.jdbcUrl.split('/')
+def url=tokens[0] + "//" + tokens[2] + "/" + "information_schema" + "?"
Review Comment:
This I tried first use jdbcUrl of test case , since user dont have any
privileges, it failed to connect to the database of test case.
so I gave a minimal permission for information_schema, used it to connect .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [pick](nestedtype)support nested type with agg replace_if_not_null [doris]
doris-robot commented on PR #38716: URL: https://github.com/apache/doris/pull/38716#issuecomment-2268455308 TPC-DS: Total hot run time: 204779 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit a1aed4f988fe29887fc21424e07c8e0b843bccd0, data reload: false query1 917 387 430 387 query2 6545305227142714 query3 6925214 200 200 query4 20354 17925 18170 17925 query5 19728 649766096497 query6 289 221 236 221 query7 4154307 312 307 query8 465 424 442 424 query9 3112268225812581 query10 426 312 305 305 query11 11466 10721 10717 10717 query12 126 87 77 77 query13 5601719 719 719 query14 18090 13765 13908 13765 query15 369 240 262 240 query16 6491290 268 268 query17 16871475872 872 query18 2297422 407 407 query19 211 151 149 149 query20 80 80 79 79 query21 189 98 95 95 query22 5203510450015001 query23 32443 32152 31974 31974 query24 6909653664636463 query25 527 421 442 421 query26 525 164 159 159 query27 1895292 296 292 query28 6165233723152315 query29 2914287227562756 query30 240 170 166 166 query31 935 757 742 742 query32 68 65 61 61 query33 409 240 246 240 query34 851 480 473 473 query35 1154899 875 875 query36 1326129511291129 query37 91 62 56 56 query38 3074293629482936 query39 1366133513171317 query40 214 95 87 87 query41 48 43 46 43 query42 80 85 82 82 query43 652 667 743 667 query44 1138721 725 721 query45 250 233 237 233 query46 1243986 967 967 query47 1955162019251620 query48 1033719 736 719 query49 619 388 380 380 query50 865 599 590 590 query51 4798465947044659 query52 103 80 87 80 query53 443 324 320 320 query54 2658244624972446 query55 85 80 80 80 query56 228 206 208 206 query57 1189113811581138 query58 214 205 191 191 query59 4250449940174017 query60 217 212 196 196 query61 98 95 94 94 query62 682 464 459 459 query63 495 338 347 338 query64 2573155014481448 query65 3627360135693569 query66 771 375 378 375 query67 15769 15886 16508 15886 query68 10328 648 664 648 query69 599 357 354 354 query70 1936128614671286 query71 426 325 312 312 query72 6534350834913491 query73 741 347 325 325 query74 6371594358955895 query75 5452368737443687 query76 6584119112131191 query77 1123267 267 267 query78 12779 11608 11520 11520 query79 8434666 629 629 query80 1328414 416 414 query81 492 242 233 233 query82 159699 102 99 query83 169 136 137 136 query84 264 73 72 72 query85 889 345 329 329 query86 340 301 291 291 query87 3258304730593047 query88 4678229522992295 query89 481 309 320 309 query90 1944216 216 216 query91 190 139 141 139 query92 57 54 54 54 query93 6416566 570 566 query94 685 216 216 216 query95 1143107110641064 query96 645 337 320 320 query97 6425641364226413 query98 185 187 187 187 query99 3042859 838 838 Total cold run time: 317448 ms Total hot run time: 204779 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
[PR] [fix](inverted index) fix match_phrase_edge query result error [doris]
zzzxl1993 opened a new pull request, #38873: URL: https://github.com/apache/doris/pull/38873 https://github.com/apache/doris/pull/38327 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](inverted index) fix match_phrase_edge query result error [doris]
doris-robot commented on PR #38873: URL: https://github.com/apache/doris/pull/38873#issuecomment-2268459354 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
