DongLiang-0 commented on code in PR #455:
URL: 
https://github.com/apache/doris-flink-connector/pull/455#discussion_r1703713675


##########
flink-doris-connector/src/main/java/org/apache/doris/flink/sink/writer/serializer/jsondebezium/JsonDebeziumChangeContext.java:
##########
@@ -116,6 +119,10 @@ public String getTargetTableSuffix() {
         return targetTableSuffix;
     }
 
+    public boolean isEnableDelete() {

Review Comment:
   ```suggestion
       public boolean enableDelete() {
   ```



##########
flink-doris-connector/src/main/java/org/apache/doris/flink/sink/writer/serializer/JsonDebeziumSchemaSerializer.java:
##########
@@ -111,6 +112,7 @@ public JsonDebeziumSchemaSerializer(
                             .getStreamLoadProp()
                             .getProperty(LINE_DELIMITER_KEY, 
LINE_DELIMITER_DEFAULT);
             this.ignoreUpdateBefore = executionOptions.getIgnoreUpdateBefore();
+            this.enableDelete = executionOptions.getDeletable();

Review Comment:
   When this parameter is not set, the default is false.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to