HappenLee commented on code in PR #38300:
URL: https://github.com/apache/doris/pull/38300#discussion_r1703653947
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -2176,11 +2176,17 @@ uint16_t
SegmentIterator::_evaluate_vectorization_predicate(uint16_t* sel_rowid_
SCOPED_RAW_TIMER(&_opts.stats->vec_cond_ns);
bool all_pred_always_true = true;
for (const auto& pred : _pre_eval_block_predicate) {
- if (!pred->always_true()) {
+ if (!pred->always_true(false)) {
all_pred_always_true = false;
break;
}
}
+ if (all_pred_always_true) {
+ for (const auto& pred : _pre_eval_block_predicate) {
Review Comment:
why here need set always true ？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
