Re: [PR] [Refact](inverted index) comment out block_column_predicate for inverted index and refact some code [doris]

[via GitHub]

github-actions[bot] commented on code in PR #28281:
URL: https://github.com/apache/doris/pull/28281#discussion_r1423582235


##
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##
@@ -1100,6 +1100,36 @@ bool SegmentIterator::_need_read_data(ColumnId cid) {
 return true;
 }
 
+bool SegmentIterator::_is_target_expr_match_predicate(const 
vectorized::VExprSPtr& expr,

Review Comment:
   warning: method '_is_target_expr_match_predicate' can be made static 
[readability-convert-member-functions-to-static]
   
   be/src/olap/rowset/segment_v2/segment_iterator.h:377:
   ```diff
   - bool _is_target_expr_match_predicate(const vectorized::VExprSPtr& expr,
   + static bool _is_target_expr_match_predicate(const 
vectorized::VExprSPtr& expr,
   ```
   



##
be/src/olap/rowset/segment_v2/segment_iterator.h:
##
@@ -361,6 +362,22 @@ class SegmentIterator : public RowwiseIterator {
 return 0;
 }
 
+bool _is_match_predicate_and_not_remaining(

Review Comment:
   warning: method '_is_match_predicate_and_not_remaining' can be made static 
[readability-convert-member-functions-to-static]
   
   ```suggestion
   static bool _is_match_predicate_and_not_remaining(
   ```
   



##
be/src/olap/rowset/segment_v2/segment_iterator.h:
##
@@ -361,6 +362,22 @@
 return 0;
 }
 
+bool _is_match_predicate_and_not_remaining(
+ColumnPredicate* pred, const std::vector& 
remaining_predicates) {
+return pred->type() == PredicateType::MATCH &&
+   std::find(remaining_predicates.begin(), 
remaining_predicates.end(), pred) ==
+   remaining_predicates.end();
+}
+
+void _delete_expr_from_conjunct_roots(const vectorized::VExprSPtr& expr,

Review Comment:
   warning: method '_delete_expr_from_conjunct_roots' can be made static 
[readability-convert-member-functions-to-static]
   
   ```suggestion
   static void _delete_expr_from_conjunct_roots(const 
vectorized::VExprSPtr& expr,
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [improvement](transaction) reduce publish txn fail log [doris]

[via GitHub]

doris-robot commented on PR #28277:
URL: https://github.com/apache/doris/pull/28277#issuecomment-1851476552

   
   
   TPC-H test result on machine: 
'aliyun_ecs.c7a.8xlarge_32C64G'
   
   ```
   Tpch sf100 test result on commit 12033c72dc87b0ed300fcda3040965a585a6619c, 
data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1   4631443244314431
   q2   359 156 159 156
   q3   1478123812171217
   q4   1107964 880 880
   q5   3139313431253125
   q6   248 129 129 129
   q7   976 485 471 471
   q8   21792179
   q9   6640668166806680
   q10  3222325832553255
   q11  325 207 204 204
   q12  347 209 203 203
   q13  4607379438433794
   q14  244 207 212 207
   q15  559 523 525 523
   q16  450 388 392 388
   q17  996 593 547 547
   q18  7542757170437043
   q19  1515127915141279
   q20  1170285 306 285
   q21  3065260926942609
   q22  352 283 289 283
   Total cold run time: 45194 ms
   Total hot run time: 39888 ms
   
   run tpch-sf100 query with default conf and set session variable 
runtime_filter_mode=off
   q1   4438437143874371
   q2   266 161 175 161
   q3   3558353835363536
   q4   2393237423682368
   q5   5766574057695740
   q6   243 122 123 122
   q7   2400191818491849
   q8   3513353635233523
   q9   9109901390589013
   q10  3906398739733973
   q11  518 378 387 378
   q12  777 601 606 601
   q13  4277356235423542
   q14  282 259 261 259
   q15  570 513 515 513
   q16  502 460 477 460
   q17  1904187818531853
   q18  8756822986808229
   q19  1778174917761749
   q20  2246194419341934
   q21  6536637161646164
   q22  498 448 426 426
   Total cold run time: 64236 ms
   Total hot run time: 60764 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [test](regression) add flink sync db case [doris]

[via GitHub]

JNSimba commented on PR #19328:
URL: https://github.com/apache/doris/pull/19328#issuecomment-1851480462

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [opt](vfilescanner) interrupt running parquet/orc readers when scannode is finished [doris]

[via GitHub]

doris-robot commented on PR #28223:
URL: https://github.com/apache/doris/pull/28223#issuecomment-1851481372

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.63 seconds
stream load tsv:  578 seconds loaded 74807831229 Bytes, about 123 
MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc:  66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet:  32 seconds loaded 861443392 Bytes, about 25 
MB/s
insert into select:  29.0 seconds inserted 1000 Rows, about 
344K ops/s
storage size: 17219733880 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [improvement](transaction) reduce publish txn fail log [doris]

[via GitHub]

doris-robot commented on PR #28277:
URL: https://github.com/apache/doris/pull/28277#issuecomment-1851482773

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.81 seconds
stream load tsv:  577 seconds loaded 74807831229 Bytes, about 123 
MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc:  66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet:  32 seconds loaded 861443392 Bytes, about 25 
MB/s
insert into select:  28.3 seconds inserted 1000 Rows, about 
353K ops/s
storage size: 17219635444 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [regression-test](group commit) enable wait_internal_group_commit_finish [doris]

[via GitHub]

doris-robot commented on PR #26856:
URL: https://github.com/apache/doris/pull/26856#issuecomment-1851482776

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.03 seconds
stream load tsv:  576 seconds loaded 74807831229 Bytes, about 123 
MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc:  66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet:  32 seconds loaded 861443392 Bytes, about 25 
MB/s
insert into select:  28.8 seconds inserted 1000 Rows, about 
347K ops/s
storage size: 17224391195 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

[PR] [only test](pipelineX) add local_shuffle in nested loop join [doris]

[via GitHub]

Mryange opened a new pull request, #28282:
URL: https://github.com/apache/doris/pull/28282

   ## Proposed changes
   
   Issue Number: close #xxx
   
   
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [fix](Nereids): remove duplicated dependency [doris]

[via GitHub]

doris-robot commented on PR #28279:
URL: https://github.com/apache/doris/pull/28279#issuecomment-1851485446

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.38 seconds
stream load tsv:  578 seconds loaded 74807831229 Bytes, about 123 
MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc:  66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet:  33 seconds loaded 861443392 Bytes, about 24 
MB/s
insert into select:  29.0 seconds inserted 1000 Rows, about 
344K ops/s
storage size: 17226491033 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [regression-test](group commit) enable wait_internal_group_commit_finish [doris]

[via GitHub]

doris-robot commented on PR #26856:
URL: https://github.com/apache/doris/pull/26856#issuecomment-1851486132

   
   
   TPC-H test result on machine: 
'aliyun_ecs.c7a.8xlarge_32C64G'
   
   ```
   Tpch sf100 test result on commit 920f490190741c7640c1b5b63d83f9f92f0261cb, 
data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1   4660445344734453
   q2   360 162 160 160
   q3   1444125612111211
   q4   1126945 882 882
   q5   3141313931413139
   q6   253 127 127 127
   q7   1005498 481 481
   q8   2211219921652165
   q9   6653666866206620
   q10  3203324832753248
   q11  331 207 208 207
   q12  352 204 205 204
   q13  4983382341023823
   q14  247 210 213 210
   q15  563 526 518 518
   q16  440 393 387 387
   q17  995 562 551 551
   q18  7676728975947289
   q19  1533129814291298
   q20  654 309 314 309
   q21  3083264926972649
   q22  343 274 279 274
   Total cold run time: 45256 ms
   Total hot run time: 40205 ms
   
   run tpch-sf100 query with default conf and set session variable 
runtime_filter_mode=off
   q1   4364439143724372
   q2   266 168 173 168
   q3   3551354135373537
   q4   2403239423672367
   q5   5731572557515725
   q6   239 120 123 120
   q7   2386185118761851
   q8   3516351135103510
   q9   9079900890029002
   q10  3894398739673967
   q11  500 388 377 377
   q12  765 599 579 579
   q13  4288361135463546
   q14  282 254 254 254
   q15  566 530 521 521
   q16  494 437 512 437
   q17  1853186518351835
   q18  8803820383728203
   q19  1733176117541754
   q20  2247194319451943
   q21  6540617361516151
   q22  499 409 421 409
   Total cold run time: 63999 ms
   Total hot run time: 60628 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [pipelineX](rf) merge local rf to support multi-instances [doris]

[via GitHub]

github-actions[bot] commented on PR #28266:
URL: https://github.com/apache/doris/pull/28266#issuecomment-1851487092

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [refactor](Nereids): avoid ConnectContext.get() to improve proformance [doris]

[via GitHub]

jackwener commented on PR #28278:
URL: https://github.com/apache/doris/pull/28278#issuecomment-1851487334

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [only test](pipelineX) add local_shuffle in nested loop join [doris]

[via GitHub]

Mryange commented on PR #28282:
URL: https://github.com/apache/doris/pull/28282#issuecomment-1851492725

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [only test](pipelineX) add local_shuffle in nested loop join [doris]

[via GitHub]

github-actions[bot] commented on code in PR #28282:
URL: https://github.com/apache/doris/pull/28282#discussion_r1423603315


##
be/src/pipeline/exec/nested_loop_join_build_operator.h:
##
@@ -102,6 +102,8 @@ class NestedLoopJoinBuildSinkOperatorX final
 Status sink(RuntimeState* state, vectorized::Block* in_block,
 SourceState source_state) override;
 
+ExchangeType get_local_exchange_type() const override { return 
ExchangeType::PASSTHROUGH; }

Review Comment:
   warning: method 'get_local_exchange_type' can be made static 
[readability-convert-member-functions-to-static]
   
   ```suggestion
   static ExchangeType get_local_exchange_type() override { return 
ExchangeType::PASSTHROUGH; }
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [fix](Nereids): remove duplicated dependency [doris]

[via GitHub]

doris-robot commented on PR #28279:
URL: https://github.com/apache/doris/pull/28279#issuecomment-1851495531

   
   
   TPC-H test result on machine: 
'aliyun_ecs.c7a.8xlarge_32C64G'
   
   ```
   Tpch sf100 test result on commit 8210db26378de40f775046a9efafe06f79743879, 
data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1   4733445644794456
   q2   357 167 160 160
   q3   1456128712491249
   q4   1117954 969 954
   q5   3145312231333122
   q6   258 130 132 130
   q7   993 490 473 473
   q8   2241224422122212
   q9   6699670566416641
   q10  3220326232663262
   q11  323 213 198 198
   q12  347 217 214 214
   q13  4542381037603760
   q14  243 218 206 206
   q15  568 521 525 521
   q16  439 389 389 389
   q17  1010540 526 526
   q18  7476701170137011
   q19  1517127814621278
   q20  516 314 327 314
   q21  3142268227192682
   q22  351 283 285 283
   Total cold run time: 44693 ms
   Total hot run time: 40041 ms
   
   run tpch-sf100 query with default conf and set session variable 
runtime_filter_mode=off
   q1   4438439344114393
   q2   268 166 172 166
   q3   3551366435483548
   q4   2399238523802380
   q5   5769573657935736
   q6   242 124 126 124
   q7   2395187518711871
   q8   3528353635333533
   q9   9082906790059005
   q10  3903399539893989
   q11  497 379 387 379
   q12  775 599 600 599
   q13  4303356635533553
   q14  278 239 254 239
   q15  567 516 512 512
   q16  518 482 474 474
   q17  1896187918621862
   q18  8865931283968396
   q19  1731177017281728
   q20  2261195519261926
   q21  6594623062006200
   q22  507 424 414 414
   Total cold run time: 64367 ms
   Total hot run time: 61027 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

[PR] [fix](group commit) Fix insert_group_commit_into_unique_sync_mode [doris]

[via GitHub]

mymeiyi opened a new pull request, #28283:
URL: https://github.com/apache/doris/pull/28283

   ## Proposed changes
   
   The `insert_group_commit_into_unique_sync_mode` is failed sometimes because 
of `PUBLISH_TIMEOUT`
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [fix](group commit) Fix insert_group_commit_into_unique_sync_mode [doris]

[via GitHub]

mymeiyi commented on PR #28283:
URL: https://github.com/apache/doris/pull/28283#issuecomment-1851500055

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [only test](pipelineX) add local_shuffle in set [doris]

[via GitHub]

doris-robot commented on PR #28275:
URL: https://github.com/apache/doris/pull/28275#issuecomment-1851506773

   
   
   TPC-H test result on machine: 
'aliyun_ecs.c7a.8xlarge_32C64G'
   
   ```
   Tpch sf100 test result on commit 13f4f8e7e03ed42a9cf57283c1e5a830ab79e65e, 
data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1   4655446444404440
   q2   360 175 158 158
   q3   1461126612241224
   q4   1106921 911 911
   q5   3077316831183118
   q6   253 125 128 125
   q7   998 487 472 472
   q8   2178219721662166
   q9   6652666866656665
   q10  3223323832783238
   q11  319 195 208 195
   q12  351 208 205 205
   q13  4548378837973788
   q14  245 214 211 211
   q15  562 533 517 517
   q16  449 383 390 383
   q17  1000563 556 556
   q18  7585745570707070
   q19  1509130514781305
   q20  2851315 290 290
   q21  3118265626782656
   q22  356 273 287 273
   Total cold run time: 46856 ms
   Total hot run time: 39966 ms
   
   run tpch-sf100 query with default conf and set session variable 
runtime_filter_mode=off
   q1   4426440944134409
   q2   267 165 175 165
   q3   3561353635323532
   q4   2396238723832383
   q5   5742573857785738
   q6   240 121 122 121
   q7   2388187118671867
   q8   3505351135193511
   q9   9116903590529035
   q10  3875397540013975
   q11  494 390 391 390
   q12  771 596 599 596
   q13  4293354135633541
   q14  284 254 248 248
   q15  565 529 518 518
   q16  512 457 475 457
   q17  1883187618321832
   q18  8754876882538253
   q19  1721171817431718
   q20  2253195819941958
   q21  6553626661776177
   q22  514 424 411 411
   Total cold run time: 64113 ms
   Total hot run time: 60835 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [community](collaborator) add new collaborator KassieZ as a doc contributor [doris]

[via GitHub]

jackwener commented on PR #27708:
URL: https://github.com/apache/doris/pull/27708#issuecomment-1851508585

   There are currently more than 10 collaborators, so we need to remove one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [fix](group commit) Fix insert_group_commit_into_unique_sync_mode [doris]

[via GitHub]

mymeiyi commented on PR #28283:
URL: https://github.com/apache/doris/pull/28283#issuecomment-1851512437

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [pipelineX](rf) merge local rf to support multi-instances [doris]

[via GitHub]

github-actions[bot] commented on PR #28266:
URL: https://github.com/apache/doris/pull/28266#issuecomment-1851516654

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [Fix](be log)Support BE log 'sys_log_level' modify to take effect dynamically #26060 [doris]

[via GitHub]

LuGuangming closed pull request #26061: [Fix](be log)Support BE log 
'sys_log_level' modify to take effect dynamically #26060
URL: https://github.com/apache/doris/pull/26061


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [case](regression) Test duplicated load id [doris]

[via GitHub]

doris-robot commented on PR #28251:
URL: https://github.com/apache/doris/pull/28251#issuecomment-1851516763

   
   
   TPC-H test result on machine: 
'aliyun_ecs.c7a.8xlarge_32C64G'
   
   ```
   Tpch sf100 test result on commit 02e6fa3110980b56a99706cb868a97daff455b54, 
data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1   4706441944684419
   q2   370 145 158 145
   q3   1454119312131193
   q4   1100895 881 881
   q5   3120313331103110
   q6   252 129 128 128
   q7   994 479 471 471
   q8   2186222421682168
   q9   6649667166336633
   q10  3195324632703246
   q11  320 211 209 209
   q12  347 208 213 208
   q13  4534379737733773
   q14  241 218 211 211
   q15  551 520 533 520
   q16  445 385 393 385
   q17  1002582 534 534
   q18  7674705879887058
   q19  1527130714931307
   q20  1717409 325 325
   q21  3037267526812675
   q22  365 279 297 279
   Total cold run time: 45786 ms
   Total hot run time: 39878 ms
   
   run tpch-sf100 query with default conf and set session variable 
runtime_filter_mode=off
   q1   4417437543844375
   q2   270 165 175 165
   q3   3575355135453545
   q4   2408243723892389
   q5   5729576357405740
   q6   238 119 120 119
   q7   2397185918951859
   q8   3507351435103510
   q9   9076903390119011
   q10  3898398939873987
   q11  505 395 396 395
   q12  773 581 614 581
   q13  4304358335393539
   q14  283 244 247 244
   q15  576 524 521 521
   q16  499 472 475 472
   q17  1872186718521852
   q18  8689860183638363
   q19  1733175517341734
   q20  2289196019391939
   q21  6576622161766176
   q22  513 426 425 425
   Total cold run time: 64127 ms
   Total hot run time: 60941 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [feature](Nereids): return edges that can be pulled up [doris]

[via GitHub]

XieJiann commented on PR #28280:
URL: https://github.com/apache/doris/pull/28280#issuecomment-1851524259

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [only test](pipelineX) add local_shuffle in set [doris]

[via GitHub]

doris-robot commented on PR #28275:
URL: https://github.com/apache/doris/pull/28275#issuecomment-1851527108

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.36 seconds
stream load tsv:  574 seconds loaded 74807831229 Bytes, about 124 
MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc:  66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet:  33 seconds loaded 861443392 Bytes, about 24 
MB/s
insert into select:  29.1 seconds inserted 1000 Rows, about 
343K ops/s
storage size: 17216743381 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Error while running github feature from .asf.yaml in doris!

[Apache Infrastructure]

An error occurred while running github feature in .asf.yaml!:
You can only have a maximum of 10 external triage collaborators, please contact 
vp-in...@apache.org to request an exception.


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [improve](group commit) Group commit support max filter ratio when rows is less than value in config [doris]

[via GitHub]

dataroaring merged PR #28139:
URL: https://github.com/apache/doris/pull/28139


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

(doris) branch master updated: [improve](group commit) Group commit support max filter ratio when rows is less than value in config (#28139)

[dataroaring]

This is an automated email from the ASF dual-hosted git repository.

dataroaring pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/master by this push:
 new 45b2dbab6af [improve](group commit) Group commit support max filter 
ratio when rows is less than value in config (#28139)
45b2dbab6af is described below

commit 45b2dbab6afa093f3402ac919929f97ff28f5c9a
Author: meiyi 
AuthorDate: Tue Dec 12 16:33:36 2023 +0800

[improve](group commit) Group commit support max filter ratio when rows is 
less than value in config (#28139)
---
 be/src/common/config.cpp   |   3 +-
 be/src/common/config.h |   3 +-
 be/src/runtime/group_commit_mgr.cpp|   6 +-
 be/src/runtime/group_commit_mgr.h  |   2 -
 .../runtime/stream_load/stream_load_executor.cpp   |   9 +
 be/src/vec/sink/group_commit_block_sink.cpp|  61 +++-
 be/src/vec/sink/group_commit_block_sink.h  |   5 +
 .../apache/doris/analysis/NativeInsertStmt.java|   2 +-
 .../apache/doris/planner/GroupCommitBlockSink.java |   5 +-
 .../apache/doris/planner/GroupCommitPlanner.java   |   5 +-
 .../apache/doris/planner/StreamLoadPlanner.java|   6 +-
 .../java/org/apache/doris/qe/StmtExecutor.java |   5 +-
 gensrc/thrift/DataSinks.thrift |   1 +
 .../insert_group_commit_into_max_filter_ratio.out  |  34 +++
 .../data/insert_p0/test_group_commit_10.csv|   4 +
 .../data/insert_p0/test_group_commit_11.csv.gz | Bin 0 -> 35223 bytes
 .../http_stream/test_group_commit_http_stream.out  |   3 -
 ...nsert_group_commit_into_max_filter_ratio.groovy | 339 +
 .../insert_group_commit_with_prepare_stmt.groovy   |   2 +
 .../test_group_commit_http_stream.groovy   |  14 +-
 .../test_group_commit_stream_load.groovy   |   2 +-
 21 files changed, 475 insertions(+), 36 deletions(-)

diff --git a/be/src/common/config.cpp b/be/src/common/config.cpp
index 549f6a0db0d..c97959f2e4a 100644
--- a/be/src/common/config.cpp
+++ b/be/src/common/config.cpp
@@ -1100,10 +1100,11 @@ DEFINE_Int16(bitmap_serialize_version, "1");
 DEFINE_String(group_commit_replay_wal_dir, "./wal");
 DEFINE_Int32(group_commit_replay_wal_retry_num, "10");
 DEFINE_Int32(group_commit_replay_wal_retry_interval_seconds, "5");
-DEFINE_Bool(wait_internal_group_commit_finish, "false");
 
 // the count of thread to group commit insert
 DEFINE_Int32(group_commit_insert_threads, "10");
+DEFINE_Int32(group_commit_memory_rows_for_max_filter_ratio, "1");
+DEFINE_Bool(wait_internal_group_commit_finish, "false");
 
 DEFINE_mInt32(scan_thread_nice_value, "0");
 DEFINE_mInt32(tablet_schema_cache_recycle_interval, "86400");
diff --git a/be/src/common/config.h b/be/src/common/config.h
index bad4724ac91..e3dbe3234c4 100644
--- a/be/src/common/config.h
+++ b/be/src/common/config.h
@@ -1173,10 +1173,11 @@ DECLARE_Int16(bitmap_serialize_version);
 DECLARE_String(group_commit_replay_wal_dir);
 DECLARE_Int32(group_commit_replay_wal_retry_num);
 DECLARE_Int32(group_commit_replay_wal_retry_interval_seconds);
-DECLARE_Bool(wait_internal_group_commit_finish);
 
 // This config can be set to limit thread number in group commit insert thread 
pool.
 DECLARE_mInt32(group_commit_insert_threads);
+DECLARE_mInt32(group_commit_memory_rows_for_max_filter_ratio);
+DECLARE_Bool(wait_internal_group_commit_finish);
 
 // The configuration item is used to lower the priority of the scanner thread,
 // typically employed to ensure CPU scheduling for write operations.
diff --git a/be/src/runtime/group_commit_mgr.cpp 
b/be/src/runtime/group_commit_mgr.cpp
index 224d446b661..b97d5de8a54 100644
--- a/be/src/runtime/group_commit_mgr.cpp
+++ b/be/src/runtime/group_commit_mgr.cpp
@@ -133,8 +133,7 @@ void LoadBlockQueue::cancel(const Status& st) {
 
 Status GroupCommitTable::get_first_block_load_queue(
 int64_t table_id, int64_t base_schema_version, const UniqueId& load_id,
-std::shared_ptr block, 
std::shared_ptr& load_block_queue,
-int be_exe_version) {
+std::shared_ptr& load_block_queue, int be_exe_version) 
{
 DCHECK(table_id == _table_id);
 {
 std::unique_lock l(_lock);
@@ -425,7 +424,6 @@ void GroupCommitMgr::stop() {
 Status GroupCommitMgr::get_first_block_load_queue(int64_t db_id, int64_t 
table_id,
   int64_t base_schema_version,
   const UniqueId& load_id,
-  
std::shared_ptr block,
   
std::shared_ptr& load_block_queue,
   int be_exe_version) {
 std::shared_ptr group_commit_table;
@@ -439,7 +437,7 @@ Status GroupCommitMgr::get_first_block_load_queue(int64_t 
db_id, int64_t table_i
 group_commit_table

Re: [PR] [feature](Load)(step2)support nereids load job schedule [doris]

[via GitHub]

wsjz commented on PR #26356:
URL: https://github.com/apache/doris/pull/26356#issuecomment-1851530308

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [case](regression) Test duplicated load id [doris]

[via GitHub]

doris-robot commented on PR #28251:
URL: https://github.com/apache/doris/pull/28251#issuecomment-1851534229

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.68 seconds
stream load tsv:  589 seconds loaded 74807831229 Bytes, about 121 
MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc:  66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet:  33 seconds loaded 861443392 Bytes, about 24 
MB/s
insert into select:  28.5 seconds inserted 1000 Rows, about 
350K ops/s
storage size: 17223905365 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [Refact](inverted index) comment out block_column_predicate for inverted index and refact some code [doris]

[via GitHub]

doris-robot commented on PR #28281:
URL: https://github.com/apache/doris/pull/28281#issuecomment-1851539976

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.84 seconds
stream load tsv:  577 seconds loaded 74807831229 Bytes, about 123 
MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc:  66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet:  34 seconds loaded 861443392 Bytes, about 24 
MB/s
insert into select:  29.4 seconds inserted 1000 Rows, about 
340K ops/s
storage size: 17219951959 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [refactor](Nereids): avoid ConnectContext.get() to improve proformance [doris]

[via GitHub]

doris-robot commented on PR #28278:
URL: https://github.com/apache/doris/pull/28278#issuecomment-1851539420

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.52 seconds
stream load tsv:  576 seconds loaded 74807831229 Bytes, about 123 
MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc:  66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet:  32 seconds loaded 861443392 Bytes, about 25 
MB/s
insert into select:  28.8 seconds inserted 1000 Rows, about 
347K ops/s
storage size: 17219748921 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [only test](pipelineX) add local_shuffle in nested loop join [doris]

[via GitHub]

doris-robot commented on PR #28282:
URL: https://github.com/apache/doris/pull/28282#issuecomment-1851545760

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.32 seconds
stream load tsv:  576 seconds loaded 74807831229 Bytes, about 123 
MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc:  66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet:  32 seconds loaded 861443392 Bytes, about 25 
MB/s
insert into select:  28.6 seconds inserted 1000 Rows, about 
349K ops/s
storage size: 17219715300 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [fix](Nereids): remove duplicated dependency [doris]

[via GitHub]

github-actions[bot] commented on PR #28279:
URL: https://github.com/apache/doris/pull/28279#issuecomment-1851560208

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [fix](Nereids) pull up cte anchor should also pull up cte in apply [doris]

[via GitHub]

morrySnow merged PR #28214:
URL: https://github.com/apache/doris/pull/28214


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

(doris) branch master updated: [fix](Nereids) pull up cte anchor should also pull up cte in apply (#28214)

[morrysnow]

This is an automated email from the ASF dual-hosted git repository.

morrysnow pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/master by this push:
 new 4e50b2791ac [fix](Nereids) pull up cte anchor should also pull up cte 
in apply (#28214)
4e50b2791ac is described below

commit 4e50b2791ac349c4572a9ee9d0b7cd76503444de
Author: morrySnow <101034200+morrys...@users.noreply.github.com>
AuthorDate: Tue Dec 12 16:56:04 2023 +0800

[fix](Nereids) pull up cte anchor should also pull up cte in apply (#28214)
---
 .../nereids/rules/rewrite/PullUpCteAnchor.java | 32 +-
 .../nereids/stats/ColumnStatsAdjustVisitor.java|  2 +-
 .../doris/nereids/trees/expressions/Exists.java|  5 
 .../nereids/trees/expressions/InSubquery.java  |  6 
 .../doris/nereids/trees/expressions/ListQuery.java |  5 
 .../nereids/trees/expressions/ScalarSubquery.java  |  5 
 .../nereids/trees/expressions/SubqueryExpr.java|  2 ++
 .../nereids/trees/plans/logical/LogicalApply.java  |  7 -
 8 files changed, 61 insertions(+), 3 deletions(-)

diff --git 
a/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PullUpCteAnchor.java
 
b/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PullUpCteAnchor.java
index c6461be2718..4bfb36db813 100644
--- 
a/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PullUpCteAnchor.java
+++ 
b/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PullUpCteAnchor.java
@@ -18,12 +18,16 @@
 package org.apache.doris.nereids.rules.rewrite;
 
 import org.apache.doris.nereids.jobs.JobContext;
+import org.apache.doris.nereids.trees.expressions.SubqueryExpr;
 import org.apache.doris.nereids.trees.plans.Plan;
+import org.apache.doris.nereids.trees.plans.logical.LogicalApply;
 import org.apache.doris.nereids.trees.plans.logical.LogicalCTEAnchor;
 import org.apache.doris.nereids.trees.plans.logical.LogicalCTEProducer;
+import org.apache.doris.nereids.trees.plans.logical.LogicalPlan;
 import org.apache.doris.nereids.trees.plans.visitor.CustomRewriter;
 import org.apache.doris.nereids.trees.plans.visitor.DefaultPlanRewriter;
 
+import com.google.common.collect.ImmutableList;
 import com.google.common.collect.Lists;
 
 import java.util.List;
@@ -42,7 +46,7 @@ public class PullUpCteAnchor extends 
DefaultPlanRewriter> 
producers) {
+public Plan rewriteRoot(Plan plan, List> 
producers) {
 Plan root = plan.accept(this, producers);
 for (LogicalCTEProducer producer : producers) {
 root = new LogicalCTEAnchor<>(producer.getCteId(), producer, root);
@@ -71,4 +75,30 @@ public class PullUpCteAnchor extends 
DefaultPlanRewriter 
apply,
+List> producers) {
+SubqueryExpr subqueryExpr = apply.getSubqueryExpr();
+PullUpCteAnchor pullSubqueryExpr = new PullUpCteAnchor();
+List> subqueryExprProducers = 
Lists.newArrayList();
+Plan newPlanInExpr = 
pullSubqueryExpr.rewriteRoot(subqueryExpr.getQueryPlan(), 
subqueryExprProducers);
+while (newPlanInExpr instanceof LogicalCTEAnchor) {
+newPlanInExpr = ((LogicalCTEAnchor) newPlanInExpr).right();
+}
+SubqueryExpr newSubqueryExpr = subqueryExpr.withSubquery((LogicalPlan) 
newPlanInExpr);
+
+Plan newApplyLeft = apply.left().accept(this, producers);
+
+Plan applyRight = apply.right();
+PullUpCteAnchor pullApplyRight = new PullUpCteAnchor();
+List> childProducers = Lists.newArrayList();
+Plan newApplyRight = pullApplyRight.rewriteRoot(applyRight, 
childProducers);
+while (newApplyRight instanceof LogicalCTEAnchor) {
+newApplyRight = ((LogicalCTEAnchor) newApplyRight).right();
+}
+producers.addAll(childProducers);
+return apply.withSubqueryExprAndChildren(newSubqueryExpr,
+ImmutableList.of(newApplyLeft, newApplyRight));
+}
 }
diff --git 
a/fe/fe-core/src/main/java/org/apache/doris/nereids/stats/ColumnStatsAdjustVisitor.java
 
b/fe/fe-core/src/main/java/org/apache/doris/nereids/stats/ColumnStatsAdjustVisitor.java
index ff4290557d1..eaf2ce37344 100644
--- 
a/fe/fe-core/src/main/java/org/apache/doris/nereids/stats/ColumnStatsAdjustVisitor.java
+++ 
b/fe/fe-core/src/main/java/org/apache/doris/nereids/stats/ColumnStatsAdjustVisitor.java
@@ -71,7 +71,7 @@ public class ColumnStatsAdjustVisitor extends 
ExpressionVisitor withSubqueryExprAndChildren(SubqueryExpr 
subqueryExpr, List children) {
+return new LogicalApply<>(correlationSlot, subqueryExpr, 
correlationFilter,
+markJoinSlotReference, needAddSubOutputToProjects, inProject, 
children.get(0), children.get(1));
+}
+
 @Override
-public LogicalBinary withChildren(List children) {
+public LogicalApply withChildren(List children) {
 Preconditions.checkArgument(children.size() == 2);
 return n

Error while running github feature from .asf.yaml in doris!

[Apache Infrastructure]

An error occurred while running github feature in .asf.yaml!:
You can only have a maximum of 10 external triage collaborators, please contact 
vp-in...@apache.org to request an exception.


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [test](regression) add flink sync db case [doris]

[via GitHub]

JNSimba commented on PR #19328:
URL: https://github.com/apache/doris/pull/19328#issuecomment-1851573100

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [feature](Nereids): return edges that can be pulled up [doris]

[via GitHub]

doris-robot commented on PR #28280:
URL: https://github.com/apache/doris/pull/28280#issuecomment-1851573933

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.33 seconds
stream load tsv:  576 seconds loaded 74807831229 Bytes, about 123 
MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc:  66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet:  32 seconds loaded 861443392 Bytes, about 25 
MB/s
insert into select:  28.9 seconds inserted 1000 Rows, about 
346K ops/s
storage size: 17224215396 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [opt](session var) throw exception when setting query time out to zero [doris]

[via GitHub]

github-actions[bot] commented on PR #28247:
URL: https://github.com/apache/doris/pull/28247#issuecomment-1851574046

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [fix](group commit) Fix insert_group_commit_into_unique_sync_mode [doris]

[via GitHub]

mymeiyi commented on PR #28283:
URL: https://github.com/apache/doris/pull/28283#issuecomment-1851583562

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [I] [Bug] 聚合模型BITMAP类型聚合结果不正确 [doris]

[via GitHub]

LemonLiTree commented on issue #28118:
URL: https://github.com/apache/doris/issues/28118#issuecomment-1851585248

   等在2.0.3 发布后 你升级看看吧


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

[I] [Bug] show create table result doesn't match ddl when use three single-quota (''') [doris]

[via GitHub]

alanredsheep opened a new issue, #28284:
URL: https://github.com/apache/doris/issues/28284

   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no 
similar issues.
   
   
   ### Version
   
   doris-1.2.6
   selectdb(with doris-core-2.0.2)
   
   
   ### What's Wrong?
   
   Notice that the show create table result has a **syntax error** in the 
comment of column `name`. 
   
   https://github.com/apache/doris/assets/35416678/5962c11a-843f-4b07-922f-d969ed251081";>
   
   When use three double-quota, the behavior is different.
   
   https://github.com/apache/doris/assets/35416678/c337127b-add5-4e76-868f-b34400c6477c";>
   
   
   ### What You Expected?
   
   We know that mysql can use two single-quota or two double-quota to escape.
   So in show create table result, this escape quota should add a slash(/) just 
like the behavior of three double-quota.
   
   'default:''' should become 'default:\'' just like "default:""" -> 
"default:\"",
   but no 'default:'' which would lead to a syntax error.
   
   Or doris can just throw an error when users use three single-quota(''').
   
   
   
   
   ### How to Reproduce?
   
   Create table with ddl below:
   ```sql
   CREATE TABLE tmp.test (
 `id` int NOT NULL COMMENT 'id',
 `name` varchar(256) NOT NULL COMMENT 'name, default:'''
   ) 
   UNIQUE KEY(`id`)
   DISTRIBUTED BY HASH(`id`) BUCKETS 1
   PROPERTIES (
 "replication_allocation" = "tag.location.default: 3"
   );
   ```
   Then show create table shows result below:
   ```sql
   CREATE TABLE `test` (
 `id` int(11) NOT NULL COMMENT 'id',
 `name` varchar(256) NOT NULL COMMENT 'name, default:''
   ) ENGINE=OLAP
   UNIQUE KEY(`id`)
   COMMENT 'OLAP'
   DISTRIBUTED BY HASH(`id`) BUCKETS 1
   PROPERTIES (
   "replication_allocation" = "tag.location.default: 3",
   "in_memory" = "false",
   "storage_format" = "V2",
   "disable_auto_compaction" = "false"
   );
   ```
   
   
   ### Anything Else?
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [doc]Update the Doris park connector version description to 1.3.0 [doris]

[via GitHub]

JNSimba commented on code in PR #27996:
URL: https://github.com/apache/doris/pull/27996#discussion_r1423694741


##
docs/zh-CN/docs/ecosystem/spark-doris-connector.md:
##
@@ -79,8 +80,8 @@ 
spark.yarn.jars=hdfs:///spark-jars/spark-doris-connector-3.2_2.12-1.2.0-SNAPSHOT
 ```
 
 org.apache.doris
-spark-doris-connector-3.2_2.12
-1.2.0
+spark-doris-connector-3.4_2.12
+1.3.0-SNAPSHOT

Review Comment:
   1.3.0



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [Refact](inverted index) comment out block_column_predicate for inverted index and refact some code [doris]

[via GitHub]

github-actions[bot] commented on PR #28281:
URL: https://github.com/apache/doris/pull/28281#issuecomment-1851605411

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [Refact](inverted index) comment out block_column_predicate for inverted index and refact some code [doris]

[via GitHub]

doris-robot commented on PR #28281:
URL: https://github.com/apache/doris/pull/28281#issuecomment-1851615391

   
   
   TPC-H test result on machine: 
'aliyun_ecs.c7a.8xlarge_32C64G'
   
   ```
   Tpch sf100 test result on commit cf1a166f3268bb1b1dab3e43c1c1bb94e43661f7, 
data reload: true
   
   run tpch-sf100 query with default conf and session variables
   q1   4899444743754375
   q2   376 117 121 117
   q3   1525123412441234
   q4   3416853 883 853
   q5   3381318431983184
   q6   236 122 125 122
   q7   998 473 477 473
   q8   3851213821932138
   q9   6805665767076657
   q10  3236326932913269
   q11  329 187 204 187
   q12  363 207 206 206
   q13  4565381638333816
   q14  240 206 213 206
   q15  561 520 523 520
   q16  437 378 381 378
   q17  1001622 561 561
   q18  7239717469766976
   q19  1585145714581457
   q20  584 318 300 300
   q21  3072268926622662
   q22  339 281 276 276
   Total cold run time: 49038 ms
   Total hot run time: 39967 ms
   
   run tpch-sf100 query with default conf and set session variable 
runtime_filter_mode=off
   q1   4406442643924392
   q2   265 160 170 160
   q3   3496349834863486
   q4   2385236723892367
   q5   5729573057285728
   q6   232 122 119 119
   q7   2393183918611839
   q8   3526351835393518
   q9   8995897390018973
   q10  3943401240554012
   q11  495 394 375 375
   q12  766 605 588 588
   q13  4300359835433543
   q14  292 258 246 246
   q15  574 531 516 516
   q16  496 448 425 425
   q17  1875186718401840
   q18  8670819181998191
   q19  1723175217481748
   q20  2251194119231923
   q21  6498614861556148
   q22  503 407 421 407
   Total cold run time: 63813 ms
   Total hot run time: 60544 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [I] [Bug]https://repo1.maven.org/maven2/org/apache/doris/spark-doris-connector-3.2_2.12/1.3.0/spark-doris-connector-3.2_2.12-1.3.0.pom: expected='1.3.0 found='1.3.0-SNAPSHOT' [doris-spark-connecto

[via GitHub]

gnehil commented on issue #170:
URL: 
https://github.com/apache/doris-spark-connector/issues/170#issuecomment-1851618054

   Is there any impact on usage?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

[PR] [regression](memtable) add case for memtable flush error status handle [doris]

[via GitHub]

Ma1oneZhang opened a new pull request, #28285:
URL: https://github.com/apache/doris/pull/28285

   1. Enable debug points
   2. Trigger the debug points and change the _flush_status varible
   3. Catch the execption
   4. Disable all debug points


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [regression](memtable) add case for memtable flush error status handle [doris]

[via GitHub]

Ma1oneZhang commented on PR #28285:
URL: https://github.com/apache/doris/pull/28285#issuecomment-1851619029

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [feture](Nereids) support delete from without using [doris]

[via GitHub]

morrySnow commented on PR #28083:
URL: https://github.com/apache/doris/pull/28083#issuecomment-1851618824

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [fix](pipelineX) fix use-after-free in filter timer queue [doris]

[via GitHub]

Gabriel39 merged PR #28236:
URL: https://github.com/apache/doris/pull/28236


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

(doris) branch master updated (4e50b2791ac -> f401a9c7ec3)

[gabriellee]

This is an automated email from the ASF dual-hosted git repository.

gabriellee pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


from 4e50b2791ac [fix](Nereids) pull up cte anchor should also pull up cte 
in apply (#28214)
 add f401a9c7ec3 [fix](pipelineX) fix use-after-free in filter timer queue 
(#28236)

No new revisions were added by this update.

Summary of changes:
 be/src/pipeline/pipeline_x/dependency.cpp | 5 +++--
 be/src/pipeline/pipeline_x/dependency.h   | 8 +++-
 2 files changed, 6 insertions(+), 7 deletions(-)


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Error while running github feature from .asf.yaml in doris!

[Apache Infrastructure]

An error occurred while running github feature in .asf.yaml!:
You can only have a maximum of 10 external triage collaborators, please contact 
vp-in...@apache.org to request an exception.


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [I] [Bug] spark-doris-connector 1.3.0 : Unrecognized Doris type JSON [doris-spark-connector]

[via GitHub]

gnehil commented on issue #167:
URL: 
https://github.com/apache/doris-spark-connector/issues/167#issuecomment-1851623286

   Is there any more detailed information? Or you can add me on WeChat to see 
this issue. My WeChat ID is gnehil489.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [feature](pipelineX) add local_shuffle in sort partition sort analytic node [doris]

[via GitHub]

github-actions[bot] commented on PR #28265:
URL: https://github.com/apache/doris/pull/28265#issuecomment-1851623641

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [feature](pipelineX) add local_shuffle in sort partition sort analytic node [doris]

[via GitHub]

github-actions[bot] commented on PR #28265:
URL: https://github.com/apache/doris/pull/28265#issuecomment-1851623751

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [feature](Nereids): one side eager aggregation [doris]

[via GitHub]

wuyanxing commented on PR #28143:
URL: https://github.com/apache/doris/pull/28143#issuecomment-1851627231

   why a rbo not a cbo path? @jackwener 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [only test](pipelineX) add local_shuffle in nested loop join [doris]

[via GitHub]

doris-robot commented on PR #28282:
URL: https://github.com/apache/doris/pull/28282#issuecomment-1851632191

   
   
   TPC-H test result on machine: 
'aliyun_ecs.c7a.8xlarge_32C64G'
   
   ```
   Tpch sf100 test result on commit b5f1a902a123440a56b1d56570854e7f60e15097, 
data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1   4735448144344434
   q2   365 142 158 142
   q3   1474127112001200
   q4   1099914 879 879
   q5   3187317231483148
   q6   248 130 127 127
   q7   985 479 477 477
   q8   2140226921892189
   q9   6667666866626662
   q10  3215327232833272
   q11  325 209 195 195
   q12  351 206 208 206
   q13  4622381238533812
   q14  250 208 210 208
   q15  568 515 514 514
   q16  456 381 386 381
   q17  990 606 533 533
   q18  7864683268666832
   q19  1509142913691369
   q20  536 299 299 299
   q21  3054266126342634
   q22  353 276 290 276
   Total cold run time: 44993 ms
   Total hot run time: 39789 ms
   
   run tpch-sf100 query with default conf and set session variable 
runtime_filter_mode=off
   q1   4431441343834383
   q2   264 163 173 163
   q3   3514350134933493
   q4   2387237523702370
   q5   5723574657505746
   q6   236 121 124 121
   q7   2358185218621852
   q8   3515351635263516
   q9   9056898090258980
   q10  3927401740124012
   q11  508 391 384 384
   q12  760 588 612 588
   q13  4288353335483533
   q14  284 256 259 256
   q15  579 531 521 521
   q16  495 449 467 449
   q17  1883184418361836
   q18  8439809381478093
   q19  1720179517461746
   q20  2260197419421942
   q21  6474609061336090
   q22  491 427 439 427
   Total cold run time: 63592 ms
   Total hot run time: 60501 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [test](regression) add flink sync db case [doris]

[via GitHub]

JNSimba commented on PR #19328:
URL: https://github.com/apache/doris/pull/19328#issuecomment-1851631364

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [fix](memory) `TabletSchema` and `Schema` no longer track memory, only track columns count. [doris]

[via GitHub]

xinyiZzz commented on code in PR #28149:
URL: https://github.com/apache/doris/pull/28149#discussion_r1423714318


##
be/src/olap/tablet_meta.cpp:
##
@@ -679,7 +679,7 @@ void TabletMeta::to_meta_pb(TabletMetaPB* tablet_meta_pb) {
 time_series_compaction_time_threshold_seconds());
 }
 
-uint32_t TabletMeta::mem_size() const {
+int64_t TabletMeta::mem_size() const {

Review Comment:
   先记着TODO留着吧，假以时日，还是要把元数据内存统计准的



##
be/src/olap/tablet_meta.cpp:
##
@@ -679,7 +679,7 @@ void TabletMeta::to_meta_pb(TabletMetaPB* tablet_meta_pb) {
 time_series_compaction_time_threshold_seconds());
 }
 
-uint32_t TabletMeta::mem_size() const {
+int64_t TabletMeta::mem_size() const {

Review Comment:
   先记着TODO留着吧，假以时日，还是要把元数据内存统计准的



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [feature](Nereids): return edges that can be pulled up [doris]

[via GitHub]

github-actions[bot] commented on PR #28280:
URL: https://github.com/apache/doris/pull/28280#issuecomment-1851635404

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [only test](pipelineX) add local_shuffle in nested loop join [doris]

[via GitHub]

Mryange commented on PR #28282:
URL: https://github.com/apache/doris/pull/28282#issuecomment-1851635876

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [feature](HiveCatalog) Support for getting hive meta data from relational databases under HMS [doris]

[via GitHub]

BePPPower commented on PR #28188:
URL: https://github.com/apache/doris/pull/28188#issuecomment-1851637154

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [regression](memtable) add case for memtable flush error status handle [doris]

[via GitHub]

github-actions[bot] commented on PR #28285:
URL: https://github.com/apache/doris/pull/28285#issuecomment-1851637857

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [feture](Nereids) support delete from without using [doris]

[via GitHub]

github-actions[bot] commented on PR #28083:
URL: https://github.com/apache/doris/pull/28083#issuecomment-1851638608

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [fix](statistics)Escape load stats sql. [doris]

[via GitHub]

doris-robot commented on PR #28231:
URL: https://github.com/apache/doris/pull/28231#issuecomment-1851642578

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 51.19 seconds
stream load tsv:  586 seconds loaded 74807831229 Bytes, about 121 
MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc:  66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet:  31 seconds loaded 861443392 Bytes, about 26 
MB/s
insert into select:  29.4 seconds inserted 1000 Rows, about 
340K ops/s
storage size: 17162215811 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [case](regression) Test enable pipeline load [doris]

[via GitHub]

github-actions[bot] commented on PR #28172:
URL: https://github.com/apache/doris/pull/28172#issuecomment-1851642547

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [regression-test](group commit) enable wait_internal_group_commit_finish [doris]

[via GitHub]

mymeiyi commented on PR #26856:
URL: https://github.com/apache/doris/pull/26856#issuecomment-1851648861

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [feature](Nereids): return edges that can be pulled up [doris]

[via GitHub]

doris-robot commented on PR #28280:
URL: https://github.com/apache/doris/pull/28280#issuecomment-1851649311

   
   
   TPC-H test result on machine: 
'aliyun_ecs.c7a.8xlarge_32C64G'
   
   ```
   Tpch sf100 test result on commit 7366369039a5c0e51f6f71897bd3695a55162133, 
data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1   4736446744674467
   q2   372 146 160 146
   q3   1459122412221222
   q4   1106932 893 893
   q5   3175317432043174
   q6   246 130 128 128
   q7   989 476 482 476
   q8   2209223521812181
   q9   6723810067016701
   q10  3234329032853285
   q11  335 206 193 193
   q12  363 208 203 203
   q13  4574377737953777
   q14  241 210 216 210
   q15  574 530 529 529
   q16  438 400 378 378
   q17  1023605 540 540
   q18  8545818071517151
   q19  1540152313721372
   q20  544 321 304 304
   q21  3084259626932596
   q22  350 286 284 284
   Total cold run time: 45860 ms
   Total hot run time: 40210 ms
   
   run tpch-sf100 query with default conf and set session variable 
runtime_filter_mode=off
   q1   4399441543854385
   q2   267 167 169 167
   q3   3508349234943492
   q4   2384236923672367
   q5   5744573257325732
   q6   235 122 122 122
   q7   2359186218681862
   q8   3517355535323532
   q9   9066905690169016
   q10  3924402640054005
   q11  502 386 390 386
   q12  772 598 603 598
   q13  4293355335623553
   q14  284 261 254 254
   q15  579 530 527 527
   q16  498 451 463 451
   q17  1887186818631863
   q18  8679806183668061
   q19  1715176517511751
   q20  2273204519291929
   q21  6521616861556155
   q22  491 433 435 433
   Total cold run time: 63897 ms
   Total hot run time: 60641 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [only test](pipelineX) add local_shuffle in nested loop join [doris]

[via GitHub]

github-actions[bot] commented on PR #28282:
URL: https://github.com/apache/doris/pull/28282#issuecomment-1851654467

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [chore](show partitions) show partitions print commit version [doris]

[via GitHub]

yujun777 commented on PR #28274:
URL: https://github.com/apache/doris/pull/28274#issuecomment-1851657088

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [fix](decimal) fix decimal overflow caused by null value [doris]

[via GitHub]

doris-robot commented on PR #28260:
URL: https://github.com/apache/doris/pull/28260#issuecomment-1851665648

   
   
   TPC-H test result on machine: 
'aliyun_ecs.c7a.8xlarge_32C64G'
   
   ```
   Tpch sf100 test result on commit d9fb9e79d51e0832a492eb4d1bc9945aa73348ff, 
data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1   4706445744674457
   q2   357 158 159 158
   q3   1473125912371237
   q4   1107882 871 871
   q5   3188321331903190
   q6   247 128 128 128
   q7   1030489 481 481
   q8   2208226922132213
   q9   6715675766626662
   q10  3281326132763261
   q11  331 194 205 194
   q12  354 203 208 203
   q13  6790378637923786
   q14  249 213 214 213
   q15  580 527 527 527
   q16  447 395 396 395
   q17  1011606 528 528
   q18  7492714468396839
   q19  1539153313291329
   q20  533 331 289 289
   q21  3101263826512638
   q22  352 274 283 274
   Total cold run time: 47091 ms
   Total hot run time: 39873 ms
   
   run tpch-sf100 query with default conf and set session variable 
runtime_filter_mode=off
   q1   4421438643824382
   q2   268 164 171 164
   q3   3512348634913486
   q4   2403239023902390
   q5   5727572957385729
   q6   235 122 121 121
   q7   2358187018851870
   q8   3526351935253519
   q9   9068904289798979
   q10  3933399340023993
   q11  509 376 390 376
   q12  762 617 618 617
   q13  4325355235303530
   q14  285 251 249 249
   q15  566 535 515 515
   q16  493 465 489 465
   q17  1879186718681867
   q18  8498816780688068
   q19  1722177317741773
   q20  2265195419291929
   q21  6529615261256125
   q22  493 418 413 413
   Total cold run time: 63777 ms
   Total hot run time: 60560 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [pipelineX](rf) merge local rf to support multi-instances [doris]

[via GitHub]

github-actions[bot] commented on PR #28266:
URL: https://github.com/apache/doris/pull/28266#issuecomment-1851665721

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [regression-test](group commit) enable wait_internal_group_commit_finish [doris]

[via GitHub]

github-actions[bot] commented on PR #26856:
URL: https://github.com/apache/doris/pull/26856#issuecomment-1851666194

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [nereids] found rows support fe side [doris]

[via GitHub]

github-actions[bot] commented on PR #28272:
URL: https://github.com/apache/doris/pull/28272#issuecomment-1851666846

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [fix](decimal) fix decimal overflow caused by null value [doris]

[via GitHub]

doris-robot commented on PR #28260:
URL: https://github.com/apache/doris/pull/28260#issuecomment-1851669351

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.73 seconds
stream load tsv:  586 seconds loaded 74807831229 Bytes, about 121 
MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc:  66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet:  33 seconds loaded 861443392 Bytes, about 24 
MB/s
insert into select:  28.9 seconds inserted 1000 Rows, about 
346K ops/s
storage size: 17217033626 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

[PR] [improvement](fe) Add reason log when `Env` is not ready [doris]

[via GitHub]

SWJTU-ZhangLei opened a new pull request, #28286:
URL: https://github.com/apache/doris/pull/28286

   ## Proposed changes
   
   Issue Number: close #xxx
   
   
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [improvement](fe) Add reason log when `Env` is not ready [doris]

[via GitHub]

SWJTU-ZhangLei commented on PR #28286:
URL: https://github.com/apache/doris/pull/28286#issuecomment-1851672116

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [opt](session var) throw exception when setting query time out to zero [doris]

[via GitHub]

github-actions[bot] commented on PR #28247:
URL: https://github.com/apache/doris/pull/28247#issuecomment-1851685985

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [feature](Nereids): return edges that can be pulled up [doris]

[via GitHub]

github-actions[bot] commented on PR #28280:
URL: https://github.com/apache/doris/pull/28280#issuecomment-1851687417

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [feature](nereids) Support basic aggregate rewrite and function rollup using materialized view [doris]

[via GitHub]

seawinde commented on PR #28269:
URL: https://github.com/apache/doris/pull/28269#issuecomment-1851689685

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] add push down filter through logical generate [doris]

[via GitHub]

xiaokang commented on PR #28212:
URL: https://github.com/apache/doris/pull/28212#issuecomment-1851691722

   run buildall 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

(doris) branch master updated: [feature](Nereids): return edges that can be pulled up (#28280)

[jakevin]

This is an automated email from the ASF dual-hosted git repository.

jakevin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/master by this push:
 new 7ac12ac7d72 [feature](Nereids): return edges that can be pulled up 
(#28280)
7ac12ac7d72 is described below

commit 7ac12ac7d7260f2cbb05093cc55a99914c1f8c43
Author: 谢健 
AuthorDate: Tue Dec 12 17:55:59 2023 +0800

[feature](Nereids): return edges that can be pulled up (#28280)
---
 .../jobs/joinorder/hypergraph/HyperGraph.java  |  39 +--
 .../jobs/joinorder/hypergraph/edge/FilterEdge.java |   4 +
 .../joinorder/hypergraph/CompareOuterJoinTest.java | 117 -
 3 files changed, 152 insertions(+), 8 deletions(-)

diff --git 
a/fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/joinorder/hypergraph/HyperGraph.java
 
b/fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/joinorder/hypergraph/HyperGraph.java
index 9f04ae38cbe..7b721a40993 100644
--- 
a/fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/joinorder/hypergraph/HyperGraph.java
+++ 
b/fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/joinorder/hypergraph/HyperGraph.java
@@ -580,6 +580,10 @@ public class HyperGraph {
 LongBitmap.getIterator(addedNodes).forEach(index -> 
nodes.get(index).attachEdge(edge));
 }
 
+public int edgeSize() {
+return joinEdges.size() + filterEdges.size();
+}
+
 /**
  * compare hypergraph
  *
@@ -588,20 +592,37 @@ public class HyperGraph {
  *  be pull up from this hyper graph
  */
 public @Nullable List isLogicCompatible(HyperGraph viewHG, 
LogicalCompatibilityContext ctx) {
-if (viewHG.filterEdges.size() != filterEdges.size() && 
viewHG.joinEdges.size() != joinEdges.size()) {
-return null;
-}
 Map queryToView = constructEdgeMap(viewHG, 
ctx.getQueryToViewEdgeExpressionMapping());
-if (queryToView.size() != filterEdges.size() + joinEdges.size()) {
+
+// All edge in view must have a mapped edge in query
+if (queryToView.size() != viewHG.edgeSize()) {
 return null;
 }
+
 boolean allMatch = queryToView.entrySet().stream()
 .allMatch(entry ->
 compareEdgeWithNode(entry.getKey(), entry.getValue(), 
ctx.getQueryToViewNodeIDMapping()));
 if (!allMatch) {
 return null;
 }
-return ImmutableList.of();
+
+// join edges must be identical
+boolean isJoinIdentical = joinEdges.stream()
+.allMatch(queryToView::containsKey);
+if (!isJoinIdentical) {
+return null;
+}
+
+// extract all top filters
+List residualFilterEdges = filterEdges.stream()
+.filter(e -> !queryToView.containsKey(e))
+.collect(ImmutableList.toImmutableList());
+if (residualFilterEdges.stream().anyMatch(e -> !e.isTopFilter())) {
+return null;
+}
+return residualFilterEdges.stream()
+.flatMap(e -> e.getExpressions().stream())
+.collect(ImmutableList.toImmutableList());
 }
 
 private Map constructEdgeMap(HyperGraph viewHG, 
Map exprMap) {
@@ -622,13 +643,19 @@ public class HyperGraph {
 
 private boolean compareEdgeWithNode(Edge t, Edge o, Map 
nodeMap) {
 if (t instanceof FilterEdge && o instanceof FilterEdge) {
-return false;
+return compareEdgeWithFilter((FilterEdge) t, (FilterEdge) o, 
nodeMap);
 } else if (t instanceof JoinEdge && o instanceof JoinEdge) {
 return compareJoinEdge((JoinEdge) t, (JoinEdge) o, nodeMap);
 }
 return false;
 }
 
+private boolean compareEdgeWithFilter(FilterEdge t, FilterEdge o, 
Map nodeMap) {
+long tChild = t.getReferenceNodes();
+long oChild = o.getReferenceNodes();
+return compareNodeMap(tChild, oChild, nodeMap);
+}
+
 private boolean compareJoinEdge(JoinEdge t, JoinEdge o, Map nodeMap) {
 long tLeft = t.getLeftExtendedNodes();
 long tRight = t.getRightExtendedNodes();
diff --git 
a/fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/joinorder/hypergraph/edge/FilterEdge.java
 
b/fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/joinorder/hypergraph/edge/FilterEdge.java
index d04031067d8..ec037871025 100644
--- 
a/fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/joinorder/hypergraph/edge/FilterEdge.java
+++ 
b/fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/joinorder/hypergraph/edge/FilterEdge.java
@@ -49,6 +49,10 @@ public class FilterEdge extends Edge {
 return rejectEdges;
 }
 
+public boolean isTopFilter() {
+return rejectEdges.isEmpty();
+}
+
 @Override
 public Set getInputSlots() {
 return filter.getInputSlots();
diff --git 
a/fe/fe-core/src/test/java/org/apach

Re: [PR] [feature](Nereids): return edges that can be pulled up [doris]

[via GitHub]

jackwener merged PR #28280:
URL: https://github.com/apache/doris/pull/28280


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Error while running github feature from .asf.yaml in doris!

[Apache Infrastructure]

An error occurred while running github feature in .asf.yaml!:
You can only have a maximum of 10 external triage collaborators, please contact 
vp-in...@apache.org to request an exception.


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [fix](Nereids): remove duplicated dependency [doris]

[via GitHub]

jackwener merged PR #28279:
URL: https://github.com/apache/doris/pull/28279


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

(doris) branch master updated (7ac12ac7d72 -> 6e5f84635bc)

[jakevin]

This is an automated email from the ASF dual-hosted git repository.

jakevin pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


from 7ac12ac7d72 [feature](Nereids): return edges that can be pulled up 
(#28280)
 add 6e5f84635bc [fix](Nereids): remove duplicated dependency (#28279)

No new revisions were added by this update.

Summary of changes:
 fe/pom.xml | 5 -
 1 file changed, 5 deletions(-)


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [refactor](Nereids): avoid ConnectContext.get() to improve proformance [doris]

[via GitHub]

jackwener commented on PR #28278:
URL: https://github.com/apache/doris/pull/28278#issuecomment-1851708417

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Error while running github feature from .asf.yaml in doris!

[Apache Infrastructure]

An error occurred while running github feature in .asf.yaml!:
You can only have a maximum of 10 external triage collaborators, please contact 
vp-in...@apache.org to request an exception.


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [pipelineX](rf) merge local rf to support multi-instances [doris]

[via GitHub]

github-actions[bot] commented on PR #28266:
URL: https://github.com/apache/doris/pull/28266#issuecomment-1851722435

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

[PR] [enhancement](err-msg) expose real error msg for invalid delete conf [doris]

[via GitHub]

TangSiyang2001 opened a new pull request, #28287:
URL: https://github.com/apache/doris/pull/28287

   ## Proposed changes
   
   As title.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [enhancement](err-msg) expose real error msg for invalid delete conf [doris]

[via GitHub]

TangSiyang2001 commented on PR #28287:
URL: https://github.com/apache/doris/pull/28287#issuecomment-1851724622

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

(doris) branch master updated (6e5f84635bc -> b821c377b63)

[jianliangqi]

This is an automated email from the ASF dual-hosted git repository.

jianliangqi pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


from 6e5f84635bc [fix](Nereids): remove duplicated dependency (#28279)
 add b821c377b63 [Refact](inverted index) comment out 
block_column_predicate for inverted index and refact some code (#28281)

No new revisions were added by this update.

Summary of changes:
 be/src/olap/rowset/segment_v2/segment_iterator.cpp | 103 ++---
 be/src/olap/rowset/segment_v2/segment_iterator.h   |  17 
 2 files changed, 66 insertions(+), 54 deletions(-)


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

[PR] [improvement](doris compose) list command show all cluster and master fe endpoint [doris]

[via GitHub]

yujun777 opened a new pull request, #28288:
URL: https://github.com/apache/doris/pull/28288

   ## Proposed changes
   
   Issue Number: close #xxx
   
   
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [Refact](inverted index) comment out block_column_predicate for inverted index and refact some code [doris]

[via GitHub]

qidaye merged PR #28281:
URL: https://github.com/apache/doris/pull/28281


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [Refact](inverted index) comment out block_column_predicate for inverted index and refact some code [doris]

[via GitHub]

github-actions[bot] commented on PR #28281:
URL: https://github.com/apache/doris/pull/28281#issuecomment-1851733043

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Error while running github feature from .asf.yaml in doris!

[Apache Infrastructure]

An error occurred while running github feature in .asf.yaml!:
You can only have a maximum of 10 external triage collaborators, please contact 
vp-in...@apache.org to request an exception.


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [improvement](doris compose) list command show all cluster and master fe endpoint [doris]

[via GitHub]

yujun777 commented on PR #28288:
URL: https://github.com/apache/doris/pull/28288#issuecomment-1851734424

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [regression-test](group commit) enable wait_internal_group_commit_finish [doris]

[via GitHub]

doris-robot commented on PR #26856:
URL: https://github.com/apache/doris/pull/26856#issuecomment-1851734863

   
   
   TPC-H test result on machine: 
'aliyun_ecs.c7a.8xlarge_32C64G'
   
   ```
   Tpch sf100 test result on commit 48edc6368141adb2de027d61a9dca0a660d5aad8, 
data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1   4702445945004459
   q2   367 147 138 138
   q3   1468124412401240
   q4   1121908 914 908
   q5   3192317431673167
   q6   251 127 130 127
   q7   1015482 480 480
   q8   2219220621822182
   q9   6681664266436642
   q10  10056   328332583258
   q11  329 205 210 205
   q12  349 203 201 201
   q13  4551379738103797
   q14  243 212 219 212
   q15  577 529 520 520
   q16  436 385 391 385
   q17  1007639 555 555
   q18  7183689969046899
   q19  1510146212961296
   q20  559 343 300 300
   q21  3067261726632617
   q22  351 283 285 283
   Total cold run time: 51234 ms
   Total hot run time: 39871 ms
   
   run tpch-sf100 query with default conf and set session variable 
runtime_filter_mode=off
   q1   4425442043914391
   q2   277 165 168 165
   q3   3513351635123512
   q4   2406239123822382
   q5   5743573457185718
   q6   236 122 122 122
   q7   2388186518461846
   q8   3508353235293529
   q9   9039904290409040
   q10  3924398839893988
   q11  504 382 375 375
   q12  774 599 596 596
   q13  4303354335673543
   q14  290 249 269 249
   q15  575 529 525 525
   q16  514 460 470 460
   q17  1896182018291820
   q18  8552818682828186
   q19  1704174417531744
   q20  2249196919191919
   q21  6481615961506150
   q22  502 454 414 414
   Total cold run time: 63803 ms
   Total hot run time: 60674 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [enhancement](err-msg) expose real error msg for invalid delete conf [doris]

[via GitHub]

github-actions[bot] commented on PR #28287:
URL: https://github.com/apache/doris/pull/28287#issuecomment-1851737681

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

[PR] [fix](decimal) fix decimal overflow caused by null value (#28260) [doris]

[via GitHub]

jacktengg opened a new pull request, #28289:
URL: https://github.com/apache/doris/pull/28289

   ## Proposed changes
   
   Pick from #28260
   
   
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org