github-actions[bot] commented on code in PR #28282:
URL: https://github.com/apache/doris/pull/28282#discussion_r1423603315


##########
be/src/pipeline/exec/nested_loop_join_build_operator.h:
##########
@@ -102,6 +102,8 @@ class NestedLoopJoinBuildSinkOperatorX final
     Status sink(RuntimeState* state, vectorized::Block* in_block,
                 SourceState source_state) override;
 
+    ExchangeType get_local_exchange_type() const override { return 
ExchangeType::PASSTHROUGH; }

Review Comment:
   warning: method 'get_local_exchange_type' can be made static 
[readability-convert-member-functions-to-static]
   
   ```suggestion
       static ExchangeType get_local_exchange_type() override { return 
ExchangeType::PASSTHROUGH; }
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to