github-actions[bot] commented on code in PR #28281:
URL: https://github.com/apache/doris/pull/28281#discussion_r1423582235
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -1100,6 +1100,36 @@ bool SegmentIterator::_need_read_data(ColumnId cid) {
return true;
}
+bool SegmentIterator::_is_target_expr_match_predicate(const
vectorized::VExprSPtr& expr,
Review Comment:
warning: method '_is_target_expr_match_predicate' can be made static
[readability-convert-member-functions-to-static]
be/src/olap/rowset/segment_v2/segment_iterator.h:377:
```diff
- bool _is_target_expr_match_predicate(const vectorized::VExprSPtr& expr,
+ static bool _is_target_expr_match_predicate(const
vectorized::VExprSPtr& expr,
```
##########
be/src/olap/rowset/segment_v2/segment_iterator.h:
##########
@@ -361,6 +362,22 @@ class SegmentIterator : public RowwiseIterator {
return 0;
}
+ bool _is_match_predicate_and_not_remaining(
Review Comment:
warning: method '_is_match_predicate_and_not_remaining' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static bool _is_match_predicate_and_not_remaining(
```
##########
be/src/olap/rowset/segment_v2/segment_iterator.h:
##########
@@ -361,6 +362,22 @@
return 0;
}
+ bool _is_match_predicate_and_not_remaining(
+ ColumnPredicate* pred, const std::vector<ColumnPredicate*>&
remaining_predicates) {
+ return pred->type() == PredicateType::MATCH &&
+ std::find(remaining_predicates.begin(),
remaining_predicates.end(), pred) ==
+ remaining_predicates.end();
+ }
+
+ void _delete_expr_from_conjunct_roots(const vectorized::VExprSPtr& expr,
Review Comment:
warning: method '_delete_expr_from_conjunct_roots' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void _delete_expr_from_conjunct_roots(const
vectorized::VExprSPtr& expr,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
