[GitHub] [doris] doris-robot commented on pull request #24943: [fix](Nereids): tolerate DateLike overflow in SQL CAST/CONVERT
doris-robot commented on PR #24943: URL: https://github.com/apache/doris/pull/24943#issuecomment-1736816076 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.22 seconds stream load tsv: 562 seconds loaded 74807831229 Bytes, about 126 MB/s stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s insert into select: 29.0 seconds inserted 1000 Rows, about 344K ops/s storage size: 17162233157 Bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] doris-robot commented on pull request #24914: [bug](profile) query profile api of fe cann't get result if non-root user query on the other fe
doris-robot commented on PR #24914: URL: https://github.com/apache/doris/pull/24914#issuecomment-1736816015 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.68 seconds stream load tsv: 557 seconds loaded 74807831229 Bytes, about 128 MB/s stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s insert into select: 28.8 seconds inserted 1000 Rows, about 347K ops/s storage size: 17162258122 Bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] xiaolin84250 closed pull request #24368: [Fix](k8s install docs) append the bugs encountered during k8s installation and give answers.
xiaolin84250 closed pull request #24368: [Fix](k8s install docs) append the bugs encountered during k8s installation and give answers. URL: https://github.com/apache/doris/pull/24368 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #24952: [improvement](compaction) output tablet_id when be core dumped.
github-actions[bot] commented on PR #24952: URL: https://github.com/apache/doris/pull/24952#issuecomment-1736818399 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] murong00 opened a new issue, #24957: [Bug] The option '-n' does not work when starting a xlus
murong00 opened a new issue, #24957: URL: https://github.com/apache/doris/issues/24957 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Version master ### What's Wrong? When using the below script to start a cluster: ``` $ kubectl -n test create -f doris_follower.yml ``` it is failed to get the statefulset in specified namespace `test`: ``` 2023-09-26 08:32:59,540 WARN (main|1) [K8sDeployManager.getGroupHostInfosByStatefulSet():177] get null statefulSet in namespace default, statefulSetName: doris-follower-cluster1 2023-09-26 08:33:04,551 WARN (main|1) [K8sDeployManager.getGroupHostInfosByStatefulSet():177] get null statefulSet in namespace default, statefulSetName: doris-follower-cluster1 ``` ### What You Expected? We can get the k8s resources in the specified namespace when using option `-n`. ### How to Reproduce? _No response_ ### Anything Else? Although we can specify the variable `APP_NAMESPACE` in the yaml as a workaround, it is preferred to use the downward API to cover this. ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] doris-robot commented on pull request #24898: [bug](json)Fix some problems of json function on Nereids
doris-robot commented on PR #24898: URL: https://github.com/apache/doris/pull/24898#issuecomment-1736825705 TeamCity be ut coverage result: Function Coverage: 36.33% (8142/22413) Line Coverage: 28.44% (65157/229110) Region Coverage: 27.40% (33790/123300) Branch Coverage: 24.07% (17251/71670) Coverage Report: http://coverage.selectdb-in.cc/coverage/de3d27abdcae3dec5c7ffb7dbf493b2ceead2dfd_de3d27abdcae3dec5c7ffb7dbf493b2ceead2dfd/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] doris-robot commented on pull request #24952: [improvement](compaction) output tablet_id when be core dumped.
doris-robot commented on PR #24952: URL: https://github.com/apache/doris/pull/24952#issuecomment-1736826062 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.14 seconds stream load tsv: 573 seconds loaded 74807831229 Bytes, about 124 MB/s stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s insert into select: 29.0 seconds inserted 1000 Rows, about 344K ops/s storage size: 17162058599 Bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #24945: [enhancement](Nereids) remove stats derivation in CostAndEnforce job
github-actions[bot] commented on PR #24945: URL: https://github.com/apache/doris/pull/24945#issuecomment-1736829280 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #24945: [enhancement](Nereids) remove stats derivation in CostAndEnforce job
github-actions[bot] commented on PR #24945: URL: https://github.com/apache/doris/pull/24945#issuecomment-1736829333 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morrySnow opened a new pull request, #24959: [fix](Nereids) could not prune datev1 partition column
morrySnow opened a new pull request, #24959: URL: https://github.com/apache/doris/pull/24959 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #24947: [pipelineX](bug) Fix dead lock in exchange sink operator
github-actions[bot] commented on PR #24947: URL: https://github.com/apache/doris/pull/24947#issuecomment-1736830083 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morrySnow commented on pull request #24959: [fix](Nereids) could not prune datev1 partition column
morrySnow commented on PR #24959: URL: https://github.com/apache/doris/pull/24959#issuecomment-1736830117 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #24947: [pipelineX](bug) Fix dead lock in exchange sink operator
github-actions[bot] commented on PR #24947: URL: https://github.com/apache/doris/pull/24947#issuecomment-1736830157 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] bobhan1 commented on pull request #23395: [Fix](Status) Make `Status` `[[nodiscard]]` and handle returned `Status` correctly
bobhan1 commented on PR #23395: URL: https://github.com/apache/doris/pull/23395#issuecomment-1736830368 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] doris-robot commented on pull request #24636: [fix](compile) failed on arm platform, with clang compiler and pch on, close #24633
doris-robot commented on PR #24636: URL: https://github.com/apache/doris/pull/24636#issuecomment-1736831426 TeamCity be ut coverage result: Function Coverage: 36.32% (8140/22413) Line Coverage: 28.43% (65139/229104) Region Coverage: 27.39% (33777/123299) Branch Coverage: 24.05% (17237/71670) Coverage Report: http://coverage.selectdb-in.cc/coverage/a50d520dd321362ba465aa8208e4669c9a613961_a50d520dd321362ba465aa8208e4669c9a613961/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zhangstar333 opened a new pull request, #24960: [bug](partition_sort)partition sort need sort all data in two phase global
zhangstar333 opened a new pull request, #24960: URL: https://github.com/apache/doris/pull/24960 https://github.com/apache/doris/pull/24886 this PR have mark phase in FE, now add those change in BE. ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris-flink-connector] codeAntg commented on a diff in pull request #200: [fix] If there are single quotes in ddl statements, table creation fails
codeAntg commented on code in PR #200:
URL:
https://github.com/apache/doris-flink-connector/pull/200#discussion_r1338149232
##
flink-doris-connector/src/main/java/org/apache/doris/flink/catalog/doris/DorisSystem.java:
##
@@ -180,7 +180,7 @@ public String buildCreateTableDDL(TableSchema schema) {
//append table comment
if(!StringUtils.isNullOrWhitespaceOnly(schema.getTableComment())){
sb.append(" COMMENT '")
-.append(schema.getTableComment())
+.append(schema.getTableComment().replace("'",""))
Review Comment:
Thanks,Changed to the quoteComment method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zhangstar333 commented on pull request #24960: [bug](partition_sort)partition sort need sort all data in two phase global
zhangstar333 commented on PR #24960: URL: https://github.com/apache/doris/pull/24960#issuecomment-1736835195 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris-flink-connector] codeAntg commented on a diff in pull request #200: [fix] If there are single quotes in ddl statements, table creation fails
codeAntg commented on code in PR #200:
URL:
https://github.com/apache/doris-flink-connector/pull/200#discussion_r1338151525
##
flink-doris-connector/src/main/java/org/apache/doris/flink/catalog/doris/DorisSystem.java:
##
@@ -180,7 +180,7 @@ public String buildCreateTableDDL(TableSchema schema) {
//append table comment
if(!StringUtils.isNullOrWhitespaceOnly(schema.getTableComment())){
sb.append(" COMMENT '")
-.append(schema.getTableComment())
+.append(schema.getTableComment().replace("'",""))
Review Comment:
And it has been packaged and tested, no problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] doris-robot commented on pull request #24954: [fix](insert) Fix test_group_commit_stream_load and add more regressi…
doris-robot commented on PR #24954: URL: https://github.com/apache/doris/pull/24954#issuecomment-1736844215 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 44.91 seconds stream load tsv: 555 seconds loaded 74807831229 Bytes, about 128 MB/s stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s insert into select: 29.2 seconds inserted 1000 Rows, about 342K ops/s storage size: 17161923728 Bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] DongLiang-0 commented on pull request #24950: [fix](doc) Update doris zh-CN doc hit-the-rollup.md prefix index link address open fail
DongLiang-0 commented on PR #24950: URL: https://github.com/apache/doris/pull/24950#issuecomment-1736844261 Thank you for your contribution. Please add this link to the corresponding English document. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #24960: [bug](partition_sort)partition sort need sort all data in two phase global
github-actions[bot] commented on PR #24960: URL: https://github.com/apache/doris/pull/24960#issuecomment-1736844192 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] doris-robot commented on pull request #24826: [feature](es-catalog) add `include_hidden_index`in order to get the hidden index.
doris-robot commented on PR #24826: URL: https://github.com/apache/doris/pull/24826#issuecomment-1736846652 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.26 seconds stream load tsv: 561 seconds loaded 74807831229 Bytes, about 127 MB/s stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s insert into select: 29.0 seconds inserted 1000 Rows, about 344K ops/s storage size: 17162201706 Bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] doris-robot commented on pull request #24954: [fix](insert) Fix test_group_commit_stream_load and add more regressi…
doris-robot commented on PR #24954: URL: https://github.com/apache/doris/pull/24954#issuecomment-1736847440 TeamCity be ut coverage result: Function Coverage: 36.33% (8142/22413) Line Coverage: 28.44% (65160/229104) Region Coverage: 27.41% (33791/123299) Branch Coverage: 24.07% (17248/71670) Coverage Report: http://coverage.selectdb-in.cc/coverage/95731b096278c94149c3ed6e4559e6f20043eeda_95731b096278c94149c3ed6e4559e6f20043eeda/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] doris-robot commented on pull request #24952: [improvement](compaction) output tablet_id when be core dumped.
doris-robot commented on PR #24952: URL: https://github.com/apache/doris/pull/24952#issuecomment-1736847574 TeamCity be ut coverage result: Function Coverage: 36.33% (8142/22413) Line Coverage: 28.44% (65153/229108) Region Coverage: 27.40% (33779/123299) Branch Coverage: 24.05% (17240/71670) Coverage Report: http://coverage.selectdb-in.cc/coverage/7504b4433085dbff5f79e9e367e45198693b2377_7504b4433085dbff5f79e9e367e45198693b2377/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] doris-robot commented on pull request #24952: [improvement](compaction) output tablet_id when be core dumped.
doris-robot commented on PR #24952: URL: https://github.com/apache/doris/pull/24952#issuecomment-1736848426 TeamCity be ut coverage result: Function Coverage: 36.31% (8140/22417) Line Coverage: 28.42% (65139/229203) Region Coverage: 27.39% (33779/123319) Branch Coverage: 24.05% (17242/71684) Coverage Report: http://coverage.selectdb-in.cc/coverage/be7ead39bc138706c2740a5d06bb3f1dbc0b4979_be7ead39bc138706c2740a5d06bb3f1dbc0b4979/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] doris-robot commented on pull request #24826: [feature](es-catalog) add `include_hidden_index`in order to get the hidden index.
doris-robot commented on PR #24826: URL: https://github.com/apache/doris/pull/24826#issuecomment-1736849642 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.1 seconds stream load tsv: 556 seconds loaded 74807831229 Bytes, about 128 MB/s stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s insert into select: 28.7 seconds inserted 1000 Rows, about 348K ops/s storage size: 17162093784 Bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] doris-robot commented on pull request #24898: [bug](json)Fix some problems of json function on Nereids
doris-robot commented on PR #24898: URL: https://github.com/apache/doris/pull/24898#issuecomment-1736850124 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.74 seconds stream load tsv: 554 seconds loaded 74807831229 Bytes, about 128 MB/s stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s insert into select: 29.0 seconds inserted 1000 Rows, about 344K ops/s storage size: 17162016285 Bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] doris-robot commented on pull request #24952: [improvement](compaction) output tablet_id when be core dumped.
doris-robot commented on PR #24952: URL: https://github.com/apache/doris/pull/24952#issuecomment-1736851151 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.81 seconds stream load tsv: 558 seconds loaded 74807831229 Bytes, about 127 MB/s stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s insert into select: 28.9 seconds inserted 1000 Rows, about 346K ops/s storage size: 17162043123 Bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] murong00 opened a new pull request, #24961: [fix](k8s) specify namespace using downward api
murong00 opened a new pull request, #24961: URL: https://github.com/apache/doris/pull/24961 ## Proposed changes Issue Number: close #24957 We'd better to specify namespace using the downward API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] doris-robot commented on pull request #24956: [fix](planner)the common type of date and decimal should be double
doris-robot commented on PR #24956: URL: https://github.com/apache/doris/pull/24956#issuecomment-1736853237 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.09 seconds stream load tsv: 559 seconds loaded 74807831229 Bytes, about 127 MB/s stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s insert into select: 28.7 seconds inserted 1000 Rows, about 348K ops/s storage size: 17162105579 Bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] liutang123 commented on pull request #23142: [opt](pipeline) Make pipeline fragment context send_report asynchronized
liutang123 commented on PR #23142: URL: https://github.com/apache/doris/pull/23142#issuecomment-1736854065 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] murong00 commented on pull request #24648: [improvement](docker) Refine runtime docker image related files
murong00 commented on PR #24648: URL: https://github.com/apache/doris/pull/24648#issuecomment-1736855563 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] doris-robot commented on pull request #24945: [enhancement](Nereids) remove stats derivation in CostAndEnforce job
doris-robot commented on PR #24945: URL: https://github.com/apache/doris/pull/24945#issuecomment-1736866921 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.86 seconds stream load tsv: 560 seconds loaded 74807831229 Bytes, about 127 MB/s stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s insert into select: 29.2 seconds inserted 1000 Rows, about 342K ops/s storage size: 17162273549 Bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Gabriel39 merged pull request #24947: [pipelineX](bug) Fix dead lock in exchange sink operator
Gabriel39 merged PR #24947: URL: https://github.com/apache/doris/pull/24947 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #24875: [Fix](doc) Fix doris english doc data-model.md table name spell error
github-actions[bot] commented on PR #24875: URL: https://github.com/apache/doris/pull/24875#issuecomment-1736869618 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated (87a30dc41d7 -> aa4dbbedc7f)
This is an automated email from the ASF dual-hosted git repository. gabriellee pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 87a30dc41d7 [feature-wip](arrow-flight)(step3) Support authentication and user session (#24772) add aa4dbbedc7f [pipelineX](bug) Fix dead lock in exchange sink operator (#24947) No new revisions were added by this update. Summary of changes: be/src/pipeline/exec/exchange_sink_operator.cpp | 3 +-- be/src/pipeline/exec/exchange_sink_operator.h | 30 + be/src/vec/runtime/vdata_stream_recvr.cpp | 24 ++-- 3 files changed, 9 insertions(+), 48 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] doris-robot commented on pull request #24959: [fix](Nereids) could not prune datev1 partition column
doris-robot commented on PR #24959: URL: https://github.com/apache/doris/pull/24959#issuecomment-1736870326 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.55 seconds stream load tsv: 560 seconds loaded 74807831229 Bytes, about 127 MB/s stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s insert into select: 28.9 seconds inserted 1000 Rows, about 346K ops/s storage size: 17162026614 Bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] murong00 commented on pull request #24961: [fix](k8s) specify namespace using downward api
murong00 commented on PR #24961: URL: https://github.com/apache/doris/pull/24961#issuecomment-1736871880 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #24935: [remove](function) make execute_impl const and remove running_difference function
Mryange commented on PR #24935: URL: https://github.com/apache/doris/pull/24935#issuecomment-1736871349 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #23395: [Fix](Status) Make `Status` `[[nodiscard]]` and handle returned `Status` correctly
github-actions[bot] commented on PR #23395: URL: https://github.com/apache/doris/pull/23395#issuecomment-1736871421 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] platoneko commented on pull request #24929: [feature](merge-cloud) Abstract BaseTablet for CloudTablet
platoneko commented on PR #24929: URL: https://github.com/apache/doris/pull/24929#issuecomment-1736872101 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zy-kkk commented on pull request #24236: [typo](docs) add 'order by' when use 'limit m,n'
zy-kkk commented on PR #24236: URL: https://github.com/apache/doris/pull/24236#issuecomment-1736875563 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #24236: [typo](docs) add 'order by' when use 'limit m,n'
github-actions[bot] commented on PR #24236: URL: https://github.com/apache/doris/pull/24236#issuecomment-1736876487 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #24236: [typo](docs) add 'order by' when use 'limit m,n'
github-actions[bot] commented on PR #24236: URL: https://github.com/apache/doris/pull/24236#issuecomment-1736876561 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] liugddx commented on pull request #24875: [Fix](doc) Fix doris english doc data-model.md table name spell error
liugddx commented on PR #24875: URL: https://github.com/apache/doris/pull/24875#issuecomment-1736879651 > I have refactor data-model.md ,fix some doc error and fixed some formatting issues #24941 @hf200012 @zy-kkk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #23897: [typo](docs)delete wrong description of from_unixtime
github-actions[bot] commented on PR #23897: URL: https://github.com/apache/doris/pull/23897#issuecomment-1736878328 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #23897: [typo](docs)delete wrong description of from_unixtime
github-actions[bot] commented on PR #23897: URL: https://github.com/apache/doris/pull/23897#issuecomment-1736878263 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #24929: [feature](merge-cloud) Abstract BaseTablet for CloudTablet
github-actions[bot] commented on code in PR #24929:
URL: https://github.com/apache/doris/pull/24929#discussion_r1338187107
##
be/src/olap/rowset/rowset_meta.cpp:
##
@@ -0,0 +1,154 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "olap/rowset/rowset_meta.h"
+
+#include "common/logging.h"
+#include "google/protobuf/util/message_differencer.h"
+#include "io/fs/local_file_system.h"
+#include "json2pb/json_to_pb.h"
+#include "json2pb/pb_to_json.h"
+#include "olap/olap_common.h"
+#include "olap/storage_policy.h"
+#include "olap/tablet_schema.h"
+#include "olap/tablet_schema_cache.h"
+
+namespace doris {
+
+RowsetMeta::~RowsetMeta() = default;
+
+bool RowsetMeta::init(const std::string& pb_rowset_meta) {
+bool ret = _deserialize_from_pb(pb_rowset_meta);
+if (!ret) {
+return false;
+}
+_init();
+return true;
+}
+
+bool RowsetMeta::init_from_pb(const RowsetMetaPB& rowset_meta_pb) {
+if (rowset_meta_pb.has_tablet_schema()) {
+_schema = TabletSchemaCache::instance()->insert(
+rowset_meta_pb.tablet_schema().SerializeAsString());
+}
+// Release ownership of TabletSchemaPB from `rowset_meta_pb` and then set
it back to `rowset_meta_pb`,
+// this won't break const semantics of `rowset_meta_pb`, because
`rowset_meta_pb` is not changed
+// before and after call this method.
+auto& mut_rowset_meta_pb = const_cast(rowset_meta_pb);
+auto schema = mut_rowset_meta_pb.release_tablet_schema();
+_rowset_meta_pb = mut_rowset_meta_pb;
+mut_rowset_meta_pb.set_allocated_tablet_schema(schema);
+_init();
+return true;
+}
+
+bool RowsetMeta::init_from_json(const std::string& json_rowset_meta) {
+bool ret = json2pb::JsonToProtoMessage(json_rowset_meta, &_rowset_meta_pb);
+if (!ret) {
+return false;
+}
+_init();
+return true;
+}
+
+bool RowsetMeta::json_rowset_meta(std::string* json_rowset_meta) {
+json2pb::Pb2JsonOptions json_options;
+json_options.pretty_json = true;
+bool ret = json2pb::ProtoMessageToJson(_rowset_meta_pb, json_rowset_meta,
json_options);
+return ret;
+}
+
+const io::FileSystemSPtr& RowsetMeta::fs() {
Review Comment:
warning: method 'fs' can be made const
[readability-make-member-function-const]
```suggestion
const io::FileSystemSPtr& RowsetMeta::fs() const {
```
be/src/olap/rowset/rowset_meta.h:48:
```diff
- const io::FileSystemSPtr& fs();
+ const io::FileSystemSPtr& fs() const;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] liugddx commented on pull request #24875: [Fix](doc) Fix doris english doc data-model.md table name spell error
liugddx commented on PR #24875: URL: https://github.com/apache/doris/pull/24875#issuecomment-1736878699 I have refactor data-model.md ,fix some doc error and fixed some formatting issues #24941 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #23187: [typo](docs)enable_storage_policy should not configure dynamically
github-actions[bot] commented on PR #23187: URL: https://github.com/apache/doris/pull/23187#issuecomment-1736878944 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] fcb-xiaobo opened a new pull request, #24962: [fix](doc) Update doris en doc hit-the-rollup.md prefix index link address
fcb-xiaobo opened a new pull request, #24962: URL: https://github.com/apache/doris/pull/24962 ## Proposed changes update doris en doc hit-the-rollup.md prefix index link address -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] lsy3993 commented on pull request #24236: [typo](docs) add 'order by' when use 'limit m,n'
lsy3993 commented on PR #24236: URL: https://github.com/apache/doris/pull/24236#issuecomment-1736881580 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #24935: [remove](function) make execute_impl const and remove running_difference function
github-actions[bot] commented on code in PR #24935:
URL: https://github.com/apache/doris/pull/24935#discussion_r1338189288
##
be/src/vec/functions/array/function_array_element.h:
##
@@ -129,7 +129,8 @@ class FunctionArrayElement : public IFunction {
private:
//=== map element===//
-ColumnPtr _get_mapped_idx(const ColumnArray& column, const
ColumnWithTypeAndName& argument) {
+ColumnPtr _get_mapped_idx(const ColumnArray& column,
Review Comment:
warning: function '_get_mapped_idx' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] ColumnPtr _get_mapped_idx(const ColumnArray& column, const
ColumnWithTypeAndName& argument) const {
```
##
be/src/vec/functions/function.h:
##
@@ -430,9 +430,9 @@ class IFunction : public
std::enable_shared_from_this,
bool is_stateful() const override { return false; }
-/// TODO: make const
-Status execute_impl(FunctionContext* context, Block& block, const
ColumnNumbers& arguments,
-size_t result, size_t input_rows_count) override = 0;
+virtual Status execute_impl(FunctionContext* context, Block& block,
Review Comment:
warning: 'virtual' is redundant since the function is already declared
'override' [modernize-use-override]
```suggestion
Status execute_impl(FunctionContext* context, Block& block,
```
##
be/src/vec/functions/array/function_array_distance.h:
##
@@ -170,7 +170,7 @@ class FunctionArrayDistance : public IFunction {
}
private:
-bool _check_input_type(const DataTypePtr& type) {
+bool _check_input_type(const DataTypePtr& type) const {
Review Comment:
warning: function '_check_input_type' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] bool _check_input_type(const DataTypePtr& type) const {
```
##
be/src/vec/functions/array/function_array_sort.h:
##
@@ -80,7 +80,7 @@ class FunctionArraySort : public IFunction {
}
private:
-ColumnPtr _execute(const ColumnArray& src_column_array) {
+ColumnPtr _execute(const ColumnArray& src_column_array) const {
Review Comment:
warning: function '_execute' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] ColumnPtr _execute(const ColumnArray& src_column_array)
const {
```
##
be/src/vec/functions/function_json.cpp:
##
@@ -974,7 +974,8 @@ class FunctionJsonContains : public IFunction {
return true;
}
-bool json_contains_array(const rapidjson::Value& target, const
rapidjson::Value& search_value) {
+bool json_contains_array(const rapidjson::Value& target,
Review Comment:
warning: function 'json_contains_array' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] bool json_contains_array(const rapidjson::Value& target,
const rapidjson::Value& search_value) const {
```
##
be/src/vec/functions/function_string.h:
##
@@ -2665,7 +2666,7 @@ class FunctionReplace : public IFunction {
}
private:
-std::string replace(std::string str, std::string_view old_str,
std::string_view new_str) {
+std::string replace(std::string str, std::string_view old_str,
std::string_view new_str) const {
Review Comment:
warning: function 'replace' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] std::string replace(std::string str, std::string_view
old_str, std::string_view new_str) const {
```
##
be/src/vec/functions/match.h:
##
@@ -66,22 +66,22 @@ class FunctionMatchBase : public IFunction {
}
Status execute_impl(FunctionContext* context, Block& block, const
ColumnNumbers& arguments,
-size_t result, size_t input_rows_count) override;
+size_t result, size_t input_rows_count) const override;
virtual Status execute_match(const std::string& column_name, const
std::string& match_query_str,
size_t input_rows_count, const ColumnString*
string_col,
InvertedIndexCtx* inverted_index_ctx,
const ColumnArray::Offsets64* array_offsets,
- ColumnUInt8::Container& result) = 0;
+ ColumnUInt8::Container& result) const = 0;
-doris::segment_v2::InvertedIndexQueryType get_query_type_from_fn_name();
+doris::segment_v2::InvertedIndexQueryType get_query_type_from_fn_name()
const;
Review Comment:
warning: function 'get_query_type_from_fn_name' should be marked
[[nodiscard]] [modernize-use-nodiscard]
```suggestion
[[nodiscard]] doris::segment_v2::InvertedIndexQueryType
get_query_type_from_fn_name()
[GitHub] [doris] lsy3993 commented on pull request #23897: [typo](docs)delete wrong description of from_unixtime
lsy3993 commented on PR #23897: URL: https://github.com/apache/doris/pull/23897#issuecomment-1736881989 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] lsy3993 commented on pull request #23187: [typo](docs)enable_storage_policy should not configure dynamically
lsy3993 commented on PR #23187: URL: https://github.com/apache/doris/pull/23187#issuecomment-1736882513 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] fcb-xiaobo commented on pull request #24950: [fix](doc) Update doris zh-CN doc hit-the-rollup.md prefix index link address open fail
fcb-xiaobo commented on PR #24950: URL: https://github.com/apache/doris/pull/24950#issuecomment-1736884042 > Thank you for your contribution. Please add this link to the corresponding English document. i hive modified the doris en doc open prefix index link address https://github.com/apache/doris/pull/24962#issue-1914907140,Could you please take a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #23594: [Enhancement](Column) Support int default value to int type column
github-actions[bot] commented on PR #23594: URL: https://github.com/apache/doris/pull/23594#issuecomment-1736884537 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zy-kkk commented on pull request #23594: [Enhancement](Column) Support int default value to int type column
zy-kkk commented on PR #23594: URL: https://github.com/apache/doris/pull/23594#issuecomment-1736884829 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zy-kkk merged pull request #24676: [typo](doc)modify error link description in fe-config-template
zy-kkk merged PR #24676: URL: https://github.com/apache/doris/pull/24676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Gabriel39 opened a new pull request, #24963: [pipelineX](bug) Fix meta scan operator
Gabriel39 opened a new pull request, #24963: URL: https://github.com/apache/doris/pull/24963 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [typo](doc)modify error link description in fe-config-template (#24676)
This is an automated email from the ASF dual-hosted git repository. zykkk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new a6d1da0db90 [typo](doc)modify error link description in fe-config-template (#24676) a6d1da0db90 is described below commit a6d1da0db90db76eaadab1dacaa8df23151cd416 Author: ZhenchaoXu <49646212+i...@users.noreply.github.com> AuthorDate: Wed Sep 27 15:51:47 2023 +0800 [typo](doc)modify error link description in fe-config-template (#24676) --- docs/en/docs/admin-manual/config/fe-config-template.md| 2 +- docs/zh-CN/docs/admin-manual/config/fe-config-template.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/en/docs/admin-manual/config/fe-config-template.md b/docs/en/docs/admin-manual/config/fe-config-template.md index e73cf1ec9f2..2ae517ac243 100644 --- a/docs/en/docs/admin-manual/config/fe-config-template.md +++ b/docs/en/docs/admin-manual/config/fe-config-template.md @@ -52,7 +52,7 @@ There are two ways to view the configuration items of FE: 1. FE web page -Open the FE web page `http://fe_host:fe_http_port/variable` in the browser. You can see the currently effective FE configuration items in `Configure Info`. +Open the FE web page `http://fe_host:fe_http_port/Configure` in the browser. You can see the currently effective FE configuration items in `Configure Info`. 2. View by command diff --git a/docs/zh-CN/docs/admin-manual/config/fe-config-template.md b/docs/zh-CN/docs/admin-manual/config/fe-config-template.md index 08a711aadb0..a0fb6a62778 100644 --- a/docs/zh-CN/docs/admin-manual/config/fe-config-template.md +++ b/docs/zh-CN/docs/admin-manual/config/fe-config-template.md @@ -50,7 +50,7 @@ FE 的配置项有两种方式进行查看： 1. FE 前端页面查看 - 在浏览器中打开 FE 前端页面 `http://fe_host:fe_http_port/variable`。在 `Configure Info` 中可以看到当前生效的 FE 配置项。 + 在浏览器中打开 FE 前端页面 `http://fe_host:fe_http_port/Configure`。在 `Configure Info` 中可以看到当前生效的 FE 配置项。 2. 通过命令查看 - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #24924: [pipelineX](node)support file scan operator
Mryange commented on PR #24924: URL: https://github.com/apache/doris/pull/24924#issuecomment-1736886905 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #24935: [remove](function) make execute_impl const and remove running_difference function
github-actions[bot] commented on code in PR #24935:
URL: https://github.com/apache/doris/pull/24935#discussion_r1338193974
##
be/src/vec/functions/array/function_array_difference.h:
##
@@ -178,7 +179,8 @@ class FunctionArrayDifference : public IFunction {
}
}
-ColumnPtr _execute_non_nullable(const ColumnWithTypeAndName& arg, size_t
input_rows_count) {
+ColumnPtr _execute_non_nullable(const ColumnWithTypeAndName& arg,
Review Comment:
warning: function '_execute_non_nullable' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] ColumnPtr _execute_non_nullable(const
ColumnWithTypeAndName& arg,
```
##
be/src/vec/functions/array/function_array_element.h:
##
@@ -129,7 +129,8 @@ class FunctionArrayElement : public IFunction {
private:
//=== map element===//
-ColumnPtr _get_mapped_idx(const ColumnArray& column, const
ColumnWithTypeAndName& argument) {
+ColumnPtr _get_mapped_idx(const ColumnArray& column,
Review Comment:
warning: function '_get_mapped_idx' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] ColumnPtr _get_mapped_idx(const ColumnArray& column,
```
##
be/src/vec/functions/function_json.cpp:
##
@@ -995,7 +996,7 @@ class FunctionJsonContains : public IFunction {
return true;
}
-bool json_contains(const rapidjson::Value& target, const rapidjson::Value&
search_value) {
+bool json_contains(const rapidjson::Value& target, const rapidjson::Value&
search_value) const {
Review Comment:
warning: function 'json_contains' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] bool json_contains(const rapidjson::Value& target, const
rapidjson::Value& search_value) const {
```
##
be/src/vec/functions/function_json.cpp:
##
@@ -974,7 +974,8 @@ class FunctionJsonContains : public IFunction {
return true;
}
-bool json_contains_array(const rapidjson::Value& target, const
rapidjson::Value& search_value) {
+bool json_contains_array(const rapidjson::Value& target,
Review Comment:
warning: function 'json_contains_array' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] bool json_contains_array(const rapidjson::Value& target,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Gabriel39 commented on pull request #24963: [pipelineX](bug) Fix meta scan operator
Gabriel39 commented on PR #24963: URL: https://github.com/apache/doris/pull/24963#issuecomment-1736890427 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #24963: [pipelineX](bug) Fix meta scan operator
github-actions[bot] commented on PR #24963: URL: https://github.com/apache/doris/pull/24963#issuecomment-1736900241 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] liugddx commented on pull request #24826: [feature](es-catalog) add `include_hidden_index`in order to get the hidden index.
liugddx commented on PR #24826: URL: https://github.com/apache/doris/pull/24826#issuecomment-1736900449 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zy-kkk merged pull request #24619: [typo](doc)modify error description of GROUP_CONCAT fiction.
zy-kkk merged PR #24619: URL: https://github.com/apache/doris/pull/24619 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated (a6d1da0db90 -> 53025ce3fcd)
This is an automated email from the ASF dual-hosted git repository. zykkk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from a6d1da0db90 [typo](doc)modify error link description in fe-config-template (#24676) add 53025ce3fcd [typo](doc)modify error description of GROUP_CONCAT fiction. (#24619) No new revisions were added by this update. Summary of changes: .../docs/sql-manual/sql-functions/aggregate-functions/group-concat.md | 2 +- .../docs/sql-manual/sql-functions/aggregate-functions/group-concat.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zy-kkk merged pull request #24307: [typo](doc)modify the wrong parameter in the example.
zy-kkk merged PR #24307: URL: https://github.com/apache/doris/pull/24307 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [typo](doc)modify the wrong parameter in the example. (#24307)
This is an automated email from the ASF dual-hosted git repository. zykkk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 41dfbdac14f [typo](doc)modify the wrong parameter in the example. (#24307) 41dfbdac14f is described below commit 41dfbdac14f31684bee71fdb571b7e8bedd44e0c Author: ZhenchaoXu <49646212+i...@users.noreply.github.com> AuthorDate: Wed Sep 27 16:04:07 2023 +0800 [typo](doc)modify the wrong parameter in the example. (#24307) --- .../Data-Manipulation-Statements/Load/CREATE-ROUTINE-LOAD.md| 2 +- .../Data-Manipulation-Statements/Load/CREATE-ROUTINE-LOAD.md| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/en/docs/sql-manual/sql-reference/Data-Manipulation-Statements/Load/CREATE-ROUTINE-LOAD.md b/docs/en/docs/sql-manual/sql-reference/Data-Manipulation-Statements/Load/CREATE-ROUTINE-LOAD.md index 12cbbfc62f2..f9484d63c56 100644 --- a/docs/en/docs/sql-manual/sql-reference/Data-Manipulation-Statements/Load/CREATE-ROUTINE-LOAD.md +++ b/docs/en/docs/sql-manual/sql-reference/Data-Manipulation-Statements/Load/CREATE-ROUTINE-LOAD.md @@ -428,7 +428,7 @@ Assuming that we need to import data from Kafka into tables "test1" and "test2" "max_batch_interval" = "20", "max_batch_rows" = "30", "max_batch_size" = "209715200", - "strict_mode" = "false" + "strict_mode" = "true" ) FROM KAFKA ( diff --git a/docs/zh-CN/docs/sql-manual/sql-reference/Data-Manipulation-Statements/Load/CREATE-ROUTINE-LOAD.md b/docs/zh-CN/docs/sql-manual/sql-reference/Data-Manipulation-Statements/Load/CREATE-ROUTINE-LOAD.md index 2f6db96c167..4e9b55d49c6 100644 --- a/docs/zh-CN/docs/sql-manual/sql-reference/Data-Manipulation-Statements/Load/CREATE-ROUTINE-LOAD.md +++ b/docs/zh-CN/docs/sql-manual/sql-reference/Data-Manipulation-Statements/Load/CREATE-ROUTINE-LOAD.md @@ -430,7 +430,7 @@ FROM data_source [data_source_properties] "max_batch_interval" = "20", "max_batch_rows" = "30", "max_batch_size" = "209715200", - "strict_mode" = "false" + "strict_mode" = "true" ) FROM KAFKA ( - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] leo65535 closed pull request #20003: [Fix](k8s) Fix wrong LOG import
leo65535 closed pull request #20003: [Fix](k8s) Fix wrong LOG import URL: https://github.com/apache/doris/pull/20003 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zy-kkk merged pull request #24185: [typo](doc)modify error result of explode_split function.
zy-kkk merged PR #24185: URL: https://github.com/apache/doris/pull/24185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [typo](doc)modify error result of explode_split function. (#24185)
This is an automated email from the ASF dual-hosted git repository. zykkk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 83f5ff7b225 [typo](doc)modify error result of explode_split function. (#24185) 83f5ff7b225 is described below commit 83f5ff7b225d64d1322dd222d42cd7990bbbc0af Author: ZhenchaoXu <49646212+i...@users.noreply.github.com> AuthorDate: Wed Sep 27 16:04:18 2023 +0800 [typo](doc)modify error result of explode_split function. (#24185) --- .../sql-manual/sql-functions/table-functions/explode-split.md| 9 ++--- .../sql-manual/sql-functions/table-functions/explode-split.md| 3 +-- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/docs/en/docs/sql-manual/sql-functions/table-functions/explode-split.md b/docs/en/docs/sql-manual/sql-functions/table-functions/explode-split.md index ae9af43b196..1ccf91c40aa 100644 --- a/docs/en/docs/sql-manual/sql-functions/table-functions/explode-split.md +++ b/docs/en/docs/sql-manual/sql-functions/table-functions/explode-split.md @@ -70,18 +70,13 @@ mysql> select k1, e1 from example1 lateral view explode_split(k2, ',') tmp1 as e +--+--+ mysql> select k1, e1 from example1 lateral view explode_split(k2, ',') tmp1 as e1 where k1 = 2 order by k1, e1; -+--+--+ -| k1 | e1 | -+--+--+ -|2 | NULL | -+--+--+ +Empty set mysql> select k1, e1 from example1 lateral view explode_split(k2, ',') tmp1 as e1 where k1 = 3 order by k1, e1; +--+--+ | k1 | e1 | +--+--+ |3 | | -|3 | | +--+--+ mysql> select k1, e1 from example1 lateral view explode_split(k2, ',') tmp1 as e1 where k1 = 4 order by k1, e1; @@ -95,9 +90,9 @@ mysql> select k1, e1 from example1 lateral view explode_split(k2, ',') tmp1 as e +--+--+ | k1 | e1 | +--+--+ -|5 | 1| |5 | 2| |5 | 3| +|5 | 1| +--+--+ mysql> select k1, e1 from example1 lateral view explode_split(k2, ',') tmp1 as e1 where k1 = 6 order by k1, e1; diff --git a/docs/zh-CN/docs/sql-manual/sql-functions/table-functions/explode-split.md b/docs/zh-CN/docs/sql-manual/sql-functions/table-functions/explode-split.md index faaae733870..64f5b1eee72 100644 --- a/docs/zh-CN/docs/sql-manual/sql-functions/table-functions/explode-split.md +++ b/docs/zh-CN/docs/sql-manual/sql-functions/table-functions/explode-split.md @@ -71,7 +71,6 @@ mysql> select k1, e1 from example1 lateral view explode_split(k2, ',') tmp1 as e | k1 | e1 | +--+--+ |3 | | -|3 | | +--+--+ mysql> select k1, e1 from example1 lateral view explode_split(k2, ',') tmp1 as e1 where k1 = 4 order by k1, e1; @@ -85,9 +84,9 @@ mysql> select k1, e1 from example1 lateral view explode_split(k2, ',') tmp1 as e +--+--+ | k1 | e1 | +--+--+ -|5 | 1| |5 | 2| |5 | 3| +|5 | 1| +--+--+ mysql> select k1, e1 from example1 lateral view explode_split(k2, ',') tmp1 as e1 where k1 = 6 order by k1, e1; - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #24955: [doc](doc)Update doc: delete Z-order
github-actions[bot] commented on PR #24955: URL: https://github.com/apache/doris/pull/24955#issuecomment-1736906751 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #24955: [doc](doc)Update doc: delete Z-order
github-actions[bot] commented on PR #24955: URL: https://github.com/apache/doris/pull/24955#issuecomment-1736906692 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #24461: [Improvement](hash) some refactor of process hash table probe impl
github-actions[bot] commented on PR #24461: URL: https://github.com/apache/doris/pull/24461#issuecomment-1736917096 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #24461: [Improvement](hash) some refactor of process hash table probe impl
github-actions[bot] commented on PR #24461: URL: https://github.com/apache/doris/pull/24461#issuecomment-1736917188 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] BiteTheDDDDt merged pull request #24461: [Improvement](hash) some refactor of process hash table probe impl
BiteThet merged PR #24461: URL: https://github.com/apache/doris/pull/24461 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] doris-robot commented on pull request #24924: [pipelineX](node)support file scan operator
doris-robot commented on PR #24924: URL: https://github.com/apache/doris/pull/24924#issuecomment-1736918958 TeamCity be ut coverage result: Function Coverage: 36.30% (8140/22424) Line Coverage: 28.41% (65133/229256) Region Coverage: 27.38% (33769/123353) Branch Coverage: 24.04% (17236/71696) Coverage Report: http://coverage.selectdb-in.cc/coverage/285c7d7d8da3a9f80f7c865bb8c4928734748e70_285c7d7d8da3a9f80f7c865bb8c4928734748e70/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hust-hhb opened a new pull request, #24964: [fix](compaction) block reader should check column string offset
hust-hhb opened a new pull request, #24964: URL: https://github.com/apache/doris/pull/24964 ## Proposed changes there is some bug like cats will make data wrong, compaction will core when reading wrong data, so need to add a check on column string. Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] doris-robot commented on pull request #24960: [bug](partition_sort)partition sort need sort all data in two phase global
doris-robot commented on PR #24960: URL: https://github.com/apache/doris/pull/24960#issuecomment-1736927258 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.24 seconds stream load tsv: 558 seconds loaded 74807831229 Bytes, about 127 MB/s stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s insert into select: 28.9 seconds inserted 1000 Rows, about 346K ops/s storage size: 17162000759 Bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hust-hhb commented on pull request #24964: [fix](compaction) block reader should check column string offset
hust-hhb commented on PR #24964: URL: https://github.com/apache/doris/pull/24964#issuecomment-1736928450 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] doris-robot commented on pull request #24963: [pipelineX](bug) Fix meta scan operator
doris-robot commented on PR #24963: URL: https://github.com/apache/doris/pull/24963#issuecomment-1736933411 TeamCity be ut coverage result: Function Coverage: 36.31% (8140/22415) Line Coverage: 28.42% (65142/229173) Region Coverage: 27.40% (33782/123306) Branch Coverage: 24.06% (17241/71672) Coverage Report: http://coverage.selectdb-in.cc/coverage/2383ceae7b4cabf920f2f0e12c9d101503749c3b_2383ceae7b4cabf920f2f0e12c9d101503749c3b/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] LemonLiTree commented on pull request #24898: [bug](json)Fix some problems of json function on Nereids
LemonLiTree commented on PR #24898: URL: https://github.com/apache/doris/pull/24898#issuecomment-1736935053 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] sjyango opened a new pull request, #24965: [Feature](datatype) Add IPv4/v6 data type for doris
sjyango opened a new pull request, #24965: URL: https://github.com/apache/doris/pull/24965 ## Proposed changes Issue Number: close #21370 ## Describe your changes Now We do not support IPv4/v6 data type for doris witch is common data type in database So it's the time to support it ! We have some basic funnctions for data type to check the data type is supported completly - [x] support CURD - [x] support StreamLoad - [x] support Serde functions - [x] support (implicit/explicit) cast functions. The following cast functions have been implemented： 1. uint8/int8 -> ipv4 2. uint16/int16 -> ipv4 3. uint32/int32 -> ipv4 4. uint64/int64 -> ipv4 5. string -> ipv4 6. string -> ipv6 - [ ] specific functions for itself data type (u can reference clickhouse or mysql) - [ ] make a Performance Test result with clickhouse or ElasticSearch in load this data type ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] sjyango commented on pull request #24965: [Feature](datatype) Add IPv4/v6 data type for doris
sjyango commented on PR #24965: URL: https://github.com/apache/doris/pull/24965#issuecomment-1736939897 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] DongLiang-0 commented on pull request #24950: [fix](doc) Update doris zh-CN doc hit-the-rollup.md prefix index link address open fail
DongLiang-0 commented on PR #24950: URL: https://github.com/apache/doris/pull/24950#issuecomment-1736940626 > > Thank you for your contribution. Please add this link to the corresponding English document. > > i have modified the doris en doc open prefix index link address,pr address [#24962 (comment)](https://github.com/apache/doris/pull/24962#issue-1914907140) you please take a look This is the same problem. Can it be merged into one PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #24964: [fix](compaction) block reader should check column string offset
github-actions[bot] commented on code in PR #24964:
URL: https://github.com/apache/doris/pull/24964#discussion_r1338246197
##
be/src/vec/common/pod_array.h:
##
@@ -340,6 +340,7 @@ class PODArray : public PODArrayBasec_start; }
Review Comment:
warning: function 'get_begin_ptr' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] void* get_begin_ptr() const { return this->c_start; }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] doris-robot commented on pull request #23594: [Enhancement](Column) Support int default value to int type column
doris-robot commented on PR #23594: URL: https://github.com/apache/doris/pull/23594#issuecomment-1736939511 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.89 seconds stream load tsv: 552 seconds loaded 74807831229 Bytes, about 129 MB/s stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s insert into select: 29.3 seconds inserted 1000 Rows, about 341K ops/s storage size: 17162178431 Bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] doris-robot commented on pull request #24924: [pipelineX](node)support file scan operator
doris-robot commented on PR #24924: URL: https://github.com/apache/doris/pull/24924#issuecomment-1736942630 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 47.11 seconds stream load tsv: 561 seconds loaded 74807831229 Bytes, about 127 MB/s stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s insert into select: 29.1 seconds inserted 1000 Rows, about 343K ops/s storage size: 17161892898 Bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] jackwener merged pull request #24945: [enhancement](Nereids) remove stats derivation in CostAndEnforce job
jackwener merged PR #24945: URL: https://github.com/apache/doris/pull/24945 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [enhancement](Nereids): remove stats derivation in CostAndEnforce job (#24945)
This is an automated email from the ASF dual-hosted git repository.
jakevin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 9562e280af3 [enhancement](Nereids): remove stats derivation in
CostAndEnforce job (#24945)
9562e280af3 is described below
commit 9562e280af3324b11150fb0ae0e46d97d201f9dc
Author: 谢健
AuthorDate: Wed Sep 27 16:31:03 2023 +0800
[enhancement](Nereids): remove stats derivation in CostAndEnforce job
(#24945)
1. remove stats derivation in CostAndEnforce job
2. enforce valid for each stats after estimating
---
.../doris/nereids/jobs/cascades/ApplyRuleJob.java | 4 +-
.../nereids/jobs/cascades/CostAndEnforcerJob.java | 19 +
.../doris/nereids/stats/StatsCalculator.java | 1 +
.../org/apache/doris/statistics/Statistics.java| 20 +
.../doris/nereids/stats/StatsCalculatorTest.java | 4 +-
.../nereids_tpcds_shape_sf100_p0/shape/query61.out | 98 +++---
.../nereids_tpcds_shape_sf100_p0/shape/query71.out | 51 ++-
.../nereids_tpcds_shape_sf100_p0/rf/ds_rf61.groovy | 2 +-
.../nereids_tpcds_shape_sf100_p0/rf/ds_rf71.groovy | 2 +-
9 files changed, 102 insertions(+), 99 deletions(-)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/cascades/ApplyRuleJob.java
b/fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/cascades/ApplyRuleJob.java
index edf8a48afb1..df58b4ed18a 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/cascades/ApplyRuleJob.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/cascades/ApplyRuleJob.java
@@ -88,7 +88,7 @@ public class ApplyRuleJob extends Job {
} else {
// The Join Commute rule preserves the operator's
expression and children,
// thereby not altering the statistics. Hence, there
is no need to derive statistics for it.
-groupExpression.setStatDerived(true);
+newGroupExpression.setStatDerived(true);
}
} else {
pushJob(new CostAndEnforcerJob(newGroupExpression,
context));
@@ -100,7 +100,7 @@ public class ApplyRuleJob extends Job {
// These implementation rules integrate rules for plan
shape transformation.
pushJob(new DeriveStatsJob(newGroupExpression,
context));
} else {
-groupExpression.setStatDerived(true);
+newGroupExpression.setStatDerived(true);
}
}
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/cascades/CostAndEnforcerJob.java
b/fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/cascades/CostAndEnforcerJob.java
index 1c41a48ecd1..dbe45d13bb6 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/cascades/CostAndEnforcerJob.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/cascades/CostAndEnforcerJob.java
@@ -31,7 +31,6 @@ import
org.apache.doris.nereids.properties.ChildrenPropertiesRegulator;
import org.apache.doris.nereids.properties.EnforceMissingPropertiesHelper;
import org.apache.doris.nereids.properties.PhysicalProperties;
import org.apache.doris.nereids.properties.RequestPropertyDeriver;
-import org.apache.doris.nereids.stats.StatsCalculator;
import com.google.common.collect.Lists;
import org.apache.logging.log4j.LogManager;
@@ -236,25 +235,13 @@ public class CostAndEnforcerJob extends Job implements
Cloneable {
PhysicalProperties outputProperty =
childOutputPropertyDeriver.getOutputProperties(groupExpression);
// update current group statistics and re-compute costs.
-if (groupExpression.children().stream().anyMatch(group ->
group.getStatistics() == null)) {
-// TODO: If it's error, add some warning log at least.
+if (groupExpression.children().stream().anyMatch(group ->
group.getStatistics() == null)
+&& groupExpression.getOwnerGroup().getStatistics() == null) {
// if we come here, mean that we have some error in stats
calculator and should fix it.
+LOG.warn("Nereids try to calculate cost without stats for group
expression {}", groupExpression);
return false;
}
-StatsCalculator statsCalculator =
StatsCalculator.estimate(groupExpression,
-
context.getCascadesContext().getConnectContext().getSessionVariable().getForbidUnknownColStats(),
-
context.getCascadesContext().getConnectContext().getTotalColumnStatisticMap(),
-
context.getCascadesContext().getConnectContext().getSessionVariable().isPlayNereidsDump(),
-context.getCascadesContext());
-if
(!context.getCascadesContext().getConnectContext().getSessionVariable(
[GitHub] [doris] BiteTheDDDDt opened a new pull request, #24966: [Improvement](hash) refactor of hash map context
BiteThet opened a new pull request, #24966: URL: https://github.com/apache/doris/pull/24966 ## Proposed changes refactor of hash map context ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on pull request #24966: [Improvement](hash) refactor of hash map context
BiteThet commented on PR #24966: URL: https://github.com/apache/doris/pull/24966#issuecomment-1736949507 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] doris-robot commented on pull request #24963: [pipelineX](bug) Fix meta scan operator
doris-robot commented on PR #24963: URL: https://github.com/apache/doris/pull/24963#issuecomment-1736953008 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.45 seconds stream load tsv: 560 seconds loaded 74807831229 Bytes, about 127 MB/s stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s insert into select: 28.9 seconds inserted 1000 Rows, about 346K ops/s storage size: 17162214455 Bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] doris-robot commented on pull request #24826: [feature](es-catalog) add `include_hidden_index`in order to get the hidden index.
doris-robot commented on PR #24826: URL: https://github.com/apache/doris/pull/24826#issuecomment-1736955136 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.54 seconds stream load tsv: 553 seconds loaded 74807831229 Bytes, about 129 MB/s stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s insert into select: 29.1 seconds inserted 1000 Rows, about 343K ops/s storage size: 17162209730 Bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #24965: [Feature](datatype) Add IPv4/v6 data type for doris
github-actions[bot] commented on code in PR #24965:
URL: https://github.com/apache/doris/pull/24965#discussion_r1338261857
##
be/src/olap/types.h:
##
@@ -957,6 +969,103 @@ struct
FieldTypeTraits
}
};
+template <>
+struct FieldTypeTraits
+: public BaseFieldtypeTraits {
+static Status from_string(void* buf, const std::string& scan_key, const
int precision,
+ const int scale) {
+StringParser::ParseResult result = StringParser::PARSE_SUCCESS;
+uint32_t value =
StringParser::string_to_unsigned_int(scan_key.c_str(),
scan_key.size(), &result);
+
+if (result == StringParser::PARSE_FAILURE) {
+return Status::Error(
+"FieldTypeTraits::from_string meet
PARSE_FAILURE");
+}
+*reinterpret_cast(buf) = value;
+return Status::OK();
+}
+
+static std::string to_string(const void* src) {
+uint32_t value = *reinterpret_cast(src);
+std::stringstream ss;
Review Comment:
warning: variable 'ss' is not initialized [cppcoreguidelines-init-variables]
```suggestion
std::stringstream ss = 0;
```
##
be/src/olap/types.h:
##
@@ -957,6 +969,103 @@ struct
FieldTypeTraits
}
};
+template <>
+struct FieldTypeTraits
+: public BaseFieldtypeTraits {
+static Status from_string(void* buf, const std::string& scan_key, const
int precision,
+ const int scale) {
+StringParser::ParseResult result = StringParser::PARSE_SUCCESS;
+uint32_t value =
StringParser::string_to_unsigned_int(scan_key.c_str(),
scan_key.size(), &result);
+
+if (result == StringParser::PARSE_FAILURE) {
+return Status::Error(
+"FieldTypeTraits::from_string meet
PARSE_FAILURE");
+}
+*reinterpret_cast(buf) = value;
+return Status::OK();
+}
+
+static std::string to_string(const void* src) {
+uint32_t value = *reinterpret_cast(src);
+std::stringstream ss;
+ss << ((value >> 24) & 0xFF) << '.'
+ << ((value >> 16) & 0xFF) << '.'
+ << ((value >> 8) & 0xFF) << '.'
+ << (value & 0xFF);
+return ss.str();
+}
+};
+
+
+template <>
+struct FieldTypeTraits
+: public BaseFieldtypeTraits {
+static Status from_string(void* buf, const std::string& scan_key, const
int precision,
+ const int scale) {
+std::istringstream iss(scan_key);
+std::string token = 0;
Review Comment:
warning: variable 'token' is not initialized
[cppcoreguidelines-init-variables]
```suggestion
std::string token = 0 = 0;
```
##
be/src/vec/data_types/data_type_ipv4.h:
##
@@ -0,0 +1,78 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+
+#include
+#include
+
+#include
+#include
+#include
+
+#include "common/status.h"
+#include "runtime/define_primitive_type.h"
+#include "vec/core/types.h"
+#include "vec/data_types/data_type.h"
+#include "vec/data_types/data_type_number_base.h"
+#include "vec/data_types/serde/data_type_ipv4_serde.h"
+
+namespace doris {
+namespace vectorized {
+class BufferWritable;
+class ReadBuffer;
+class IColumn;
+} // namespace vectorized
+} // namespace doris
+
+namespace doris::vectorized {
+
+class DataTypeIPv4 final : public DataTypeNumberBase {
+public:
+TypeIndex get_type_id() const override { return TypeIndex::IPv4; }
+PrimitiveType get_type_as_primitive_type() const override { return
TYPE_IPV4; }
+TPrimitiveType::type get_type_as_tprimitive_type() const override {
+return TPrimitiveType::IPV4;
+}
+const char* get_family_name() const override { return "IPv4"; }
+std::string do_get_name() const override { return "IPv4"; }
+
+bool can_be_inside_nullable() const override { return true; }
+
+bool equals(const IDataType& rhs) const override;
+std::string to_string(const IColumn& column, size_t row_num) const
override;
+void to_string(const IColumn& column, size_t row_num, BufferWritable&
ostr) const override;
+Status from_string(ReadBuffer& rb, IColumn*
[GitHub] [doris] LiBinfeng-01 opened a new pull request, #24967: [Fix](Nereids) forbid bitmap type in compare scenarios
LiBinfeng-01 opened a new pull request, #24967: URL: https://github.com/apache/doris/pull/24967 Problem: be core because of bitmap calculation. Reason: when be check failed, it would core directly. Example: SELECT id_bitmap FROM test_bitmap WHERE id_bitmap IN (NULL) LIMIT 20; Solved: Forbidden this kind of expression in fe when analyze. And also forbid bitmap type comparing in other unsupported expressions. ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] doris-robot commented on pull request #24935: [remove](function) make execute_impl const and remove running_difference function
doris-robot commented on PR #24935: URL: https://github.com/apache/doris/pull/24935#issuecomment-1736956807 TeamCity be ut coverage result: Function Coverage: 36.31% (8137/22410) Line Coverage: 28.41% (65089/229101) Region Coverage: 27.37% (33730/123241) Branch Coverage: 24.03% (17214/71624) Coverage Report: http://coverage.selectdb-in.cc/coverage/e53c04a4e250364c15f8da55a8a67e25b0c9594e_e53c04a4e250364c15f8da55a8a67e25b0c9594e/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
